kc3-lang/angle

Log

Author Commit Date CI Message
Tim Van Patten 0d175f30 2021-01-20T16:34:40 Tests: Add eFootball PES 2021 trace Test: angle_perftests --gtest_filter=TracePerfTest.Run/*efootball_pes_2021* Bug: angleproject:5564 Bug: angleproject:5517 Change-Id: I9738876b6a6c365984cecce01f2f09e0260b41cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2656989 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill 85efb9d5 2021-01-26T14:39:19 Log dEQP QPA files as test artifacts. This adds artifact output to the test runner. We add a fake test at the start of a test run that owns the artifacts. Bug: angleproject:5236 Change-Id: Ice8001bf1f2aafbd8123fee76e0e7fcc3e5a8a0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2657535 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll e3096d07 2021-02-01T10:01:18 Roll SwiftShader from 5830d745b1b2 to df5dee645ab5 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/5830d745b1b2..df5dee645ab5 2021-01-31 liyl@google.com Allow sampling usage when querying linear image format properties. 2021-01-30 capn@google.com Pool Subzero constant data 2021-01-30 capn@google.com Finalize Reactor Function creation at Routine acquisition 2021-01-29 amaiorano@google.com Fix Reactor memory leaks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:5377 Tbr: jmadill@google.com Change-Id: Ifa400697c8afdc49d133a3bc7d1639355698678c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2662689 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fa41c227 2021-02-01T10:01:41 Roll vulkan-deps from e02583244aad to 38d88d12b2fd (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e02583244aad..38d88d12b2fd 2021-01-29 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 85caecfecec3 to 81dd1f107ba6 (1 revision) 2021-01-29 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 84a41cd4883d to 4741bbaa641d (1 revision) 2021-01-29 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 47940fbfe0ad to 2b9a7b114eaa (1 revision) 2021-01-29 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c327f81e35a4 to 85caecfecec3 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I6d6f9019c39d7f0334734688bf7869533632055c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2662401 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 85a9ec10 2021-02-01T07:01:00 Roll Chromium from 0c6211fe862e to 532fea9e2fd2 (584 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0c6211fe862e..532fea9e2fd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9007e0a586..dce1147a27 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c4fefcb646..0b33acd751 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..91735e2e67 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/2c183c9f93..c876c8f871 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cc8d00af13..df7daef465 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/78b89e3bb2..7c835a619b No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: Id51490606be8b8935c24ab0afb6b0efa5ce8dcd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2662399 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi b15de455 2021-01-27T13:58:42 Remove extension check in validation of ES3.2 entry points Bug: angleproject:3582 Change-Id: I563c6d77b825afd44809db0d08dc4842a5f93b6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653914 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis 0be050a4 2020-09-23T15:12:56 Pass GL_VERSION info through ANGLE's GL_RENDERER string Chrome needs ANGLE to pass through the underlying driver vendor and version, which cannot always be determined by the SystemInfo library. This is done by construction GL_RENDERER in the frontend through combining GL_VENDOR, GL_RENDERER, and GL_VERSION from the backends. Example changes are in the doc: https://docs.google.com/document/d/1p0dvrLlu8NKhO-RCU5gqlQ_LvcQj-ZqhvfwSk1n3Sz8/edit?usp=sharing Bug: chromium:1126526 Bug: chromium:1131248 Bug: chromium:1134669 Bug: chromium:1169861 Change-Id: Ia618ebcd7f3caaeb376b4b6a03446732efdaeecb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2427383 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 62387fc6 2021-01-27T13:58:01 Vulkan: Enable geometry/tessellation deqp KHR 3.2 tests Preliminary triaging is done for the failing tests. Additionally, the tests are only enabled for windows for now, due to failures on the Android and Linux bots, likely due to old drivers. Locally, the failures on Linux match the expectations for windows. Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: I72d998097fad495c21414917ef09e132274f7c8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653913 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 61f60161 2021-01-27T13:57:13 Vulkan: Set missing geometry/tessellation limits Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: Idb8ebc0c3beee8f273d0df3b4e0d84722a8590b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653912 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Peng Huang c6a8bc4a 2021-01-30T14:58:22 Fix a crash in DynamicBuffer::~DynamicBuffer() The crash is because mBufferFreeList is not moved from the rhs value for DynamicBuffer's move constructor. Bug: chromium:1170339 Change-Id: I7d41b775ab56af8fa9412369d5a4008f59da3053 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2661615 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi eae262e7 2021-01-27T13:56:49 Vulkan: Fix image layout barriers for tessellation shaders Also fixes a bug where invalid stages may be specified for example if AllGraphicsReadOnly or DepthStencilReadOnly layouts are used and geometry or tessellation shaders are not supported by the implementation. Bug: angleproject:5557 Change-Id: Ia25a6aec8138c67701c63da65783263d8a7bda27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653911 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 6d86a0fe 2021-01-29T11:08:04 Fix mActiveImageShaderBits not updated in PPO's executable Allows the backend to rely on this bitset always being valid, instead of working around the bug. Bug: angleproject:5587 Change-Id: I25e1304c0e5e34b5fc1677a819315574603ed034 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2658885 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Cody Northrop d5ca645e 2021-01-29T13:29:49 Capture/Replay: Set uniform buffer offset alignment During capture, we need to set a common uniform buffer offset alignment so the trace will be more portable. The offset used by the trace needs to be divisible by the device's actual value for GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT. Empirically I've seen the following values supported by devices: ARM (16), Intel (32), Qualcomm (128), Nvidia (256) Test: Manhattan 3.1 MEC Bug: angleproject:5589 Change-Id: I071b6ae7be4c827eb8df4a8b39db901226d0f00b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2659849 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mohan Maiya 37a0dced 2021-01-28T17:52:05 Vulkan: Disable clip space transform based on EXT_clip_control When depth is set to "ZERO_TO_ONE_EXT" using EXT_clip_control API, don't transform the z position in shader since it now matches Vulkan's depth range. Toggle transformPositionToVulkanClipSpace accordingly. Bug: angleproject:5471 Tests: dEQP-GLES2.functional.clip_control.depth_mode_zero_to_one Change-Id: I7e715cb3c98cecf5aaa5cdc3822a3a83bae9c720 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615864 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b1deba2f 2021-01-28T16:06:51 Vulkan: Don't emit spec const declaration in compute shaders Bug: angleproject:5070 Change-Id: I74becfeac88b4a8ff66dd36670792082d0b941cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2658882 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang a5ab7974 2021-01-28T12:32:10 Turn on vulkan backend for android ndk level < 26 Fixes two issue for build Vulkan backend for android ndk level < 26, * Disable Vulkan validation layers for android ndk level < 26 * Share vulkan memory allocator implementation with chrome to avoid duplicated symbols link errors. * Only run vulkan backend test with Android P or newer Note: This change will break android-binary-size try bot, we need to update expected_static_initializer_count to 4 at [1] while rolling this change into chromium. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/static_initializers.gni;l=19?q=expected_static_initializer_count&ss=chromium%2Fchromium%2Fsrc Bug: chromium:1170339 Change-Id: Idb9238d8f339724c4d8f9ac136305b95ff06fae4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2656980 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Kenneth Russell b4fd4628 2021-01-27T15:56:58 Revise WebGL's shaderSource validation. Per discussion in the WebGL working group, shaderSource no longer generates INVALID_VALUE for sources containing characters outside the ESSL character set. Compilation and/or linking is still specified to fail when illegal constructs are used. With this change, https://github.com/KhronosGroup/WebGL/pull/3206 passes with the passthrough command decoder. Revise WebGL compatibility tests to follow the new rules. Bug: chromium:1171506 Change-Id: Id132e0b64fa94b373f2732acf2a7071f38f0d4ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2654264 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Mohan Maiya 80a4223e 2021-01-28T17:51:31 Vulkan: Handle changes to viewport when clip origin is modified The expected view port is different from current viewport translation when the clip origin is the upper left. So now, it has four different view port translations based on clip origin and y-flip of framebuffer. - add query and state management for EXT_clip_control - add dirty bit for clip control - change viewport, scissor and cull face when clip origin changes Bug: angleproject:5471 Tests: dEQP-GLES2.functional.clip_control.* Change-Id: I78dc752c3287b09f25496034e0d0d2724138010c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615863 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 6cfbe252 2021-01-27T13:42:55 Fix geometry/tessellation checks to account for ES3.2 Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: Iae54940cefb5ba516dc173413b35b646e1968ba6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653906 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Mohan Maiya 74f7be6d 2021-01-28T14:04:47 Vulkan: Rectify typo in EXT_texture_format_sRGB_override The extension string for EXT_texture_format_sRGB_override was missing the "format" substring. Bug: angleproject:4561 Change-Id: I19788191b589b64639b036d2bb54508077fca7e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2658355 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Peng Huang 312ffba8 2021-01-28T20:53:16 Roll third_party/vulkan_memory_allocator/ 065e73907..b1d65a2b3 (2 commits) https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/+log/065e739079d9..b1d65a2b3373 $ git log 065e73907..b1d65a2b3 --date=short --no-merges --format='%ad %ae %s' 2021-01-27 shawn.p.huang Add vma.cpp contains vma's implementation. 2021-01-27 shawn.p.huang Add a new target with the VmaUsage.cpp and VmaUsage.h Created with: roll-dep third_party/vulkan_memory_allocator Bug: chromium:1170339 Change-Id: I4db27eb0674d1da3157a1081aec3b7db6d7433fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2657724 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll a29ef612 2021-01-29T10:01:41 Roll vulkan-deps from 5f7a1ace1a5e to e02583244aad (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5f7a1ace1a5e..e02583244aad 2021-01-29 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from aed40d52837d to 47940fbfe0ad (2 revisions) 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d602a4f75d3c to c327f81e35a4 (2 revisions) 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from e8bd26e1f835 to 297723d75af4 (1 revision) 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from b812fd634ea5 to e8bd26e1f835 (1 revision) 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 36df92e4a0ef to f7c43377f095 (1 revision) 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 31e95c1707c5 to d602a4f75d3c (2 revisions) 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 7c25ce965b92 to a03938051ff6 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I1c193acab56bb55f8f35b1f1afe3592d15637eac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2658883 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0ab4987a 2021-01-29T10:01:18 Roll SwiftShader from 3e9b79ff42de to 5830d745b1b2 (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/3e9b79ff42de..5830d745b1b2 2021-01-29 capn@google.com Enable named mmap usage for CMake builds 2021-01-28 capn@google.com Enable named mmap usage for Chromium 2021-01-28 capn@google.com Only enable naming anonymous mmap on Linux 2021-01-28 sugoi@google.com Add utility function to count input components 2021-01-28 sugoi@google.com Support SampleId and SamplePosition builtins 2021-01-28 sugoi@google.com Store interpolation data in routine 2021-01-28 sugoi@google.com Per sample shading If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I24d107b9cb69e860c55abce571e670b2181adc8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2657929 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 67a84f34 2021-01-29T07:00:38 Roll Chromium from 34154bd58dcb to 0c6211fe862e (430 revisions) https://chromium.googlesource.com/chromium/src.git/+log/34154bd58dcb..0c6211fe862e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/80d8522df9..9007e0a586 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e3db55b463..990491572d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4f733a4525..c4fefcb646 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f43a84ba66..602133a964 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9d5ec46922 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/ec1e3f2e46..84a6931d87 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0d2b89124b..cc8d00af13 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c3a074da20..78b89e3bb2 * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/203790d797..0bdacc0246 * tools/skia_goldctl/linux: opL5N0hiBtWxiOFaEhRqXpJWh70uurNTInvkY8NHr8oC..AyPgwgutb8buiGKwMyMGU2SGR5H8h1Y2XDfiIN2BtzwC * tools/skia_goldctl/mac: pmlVeVFuSc7Re0D7Efu2pAh2Oo5rEAnlg1rFIfp1RncC..tIfvKvCHGv4G8z3DzRxNQ7W7G95EP9N0R1wbJ_ezmwkC * tools/skia_goldctl/win: GRI6-L-7YmnYGw8gs2jXZDqvI5KIFIgsj_GvzZ4krYQC..kET1R1m5NBszkTdWAJUnKHE6R3DkKz59FxiaENTn_QgC No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I045d83ff08e004e18b81cc20fb37f0e4c58ed492 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2658880 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott e419222d 2021-01-28T17:14:02 MSAA PreRot: Make MultisampleTest use rectangular window This will make it easier to fix/prevent bugs with MSAA-swapchain windows, which are not currently pre-rotated properly on Android. Bug: b/175793022 Change-Id: Ia51446db62c8ec94313ae75fd87ad8e9477f76e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2656997 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 2dae09e8 2021-01-27T13:54:25 Fix draw mode validation of PPOs with geometry/tessellation The properties related to geometry and tessellation shaders were not being copied from the Program's exectuble to the Program Pipeline's. Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: Ied6ff82c7e30f24504c9a3f5c008181b179b07ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653909 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi ddba70da 2021-01-27T13:52:12 Fix xfb mode validation with geometry/tessellation In the presence of geometry and/or tessellation shaders, transform feedback mode must match what these shaders produce, instead of what's passed to glDrawArrays. Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: I6a21621e66b31553ed6a3a50c3aebf60e1ac7be5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653908 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi a685db2e 2021-01-26T14:45:58 Update README.md for Fuchsia Bug: angleproject:1944 Change-Id: I823ffba6b67e65dbf4b24e8863a117fcdff76657 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2648638 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org>
Peng Huang 122a1cc5 2021-01-26T20:06:24 Fix several vulkan backend problem on Android. * Load AHardwarebuffer API dynamically, so vulkan backend can be built with old NDK, but can work with newer android releases. * Do not link with libvulkan on android. * Expose EGL_ANDROID_get_native_client_buffer extension with vulkan backend. Bug: chromium:1170339 Change-Id: Idf7f6867a86ae40ba6d57a86e419c610ba404ba8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653506 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Yuly Novikov 4ec7021c 2021-01-27T16:41:45 Report angle_restricted_trace_gold_tests as interrupted on Exception Otherwise step is reported as failed but build as succeeded Bug: chromium:1153299 Change-Id: Id21d7ceafd04553634463be5acb64c070d251abb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653859 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 2baa6288 2021-01-27T13:55:36 Fix validation of glCreateShaderProgramv for geometry/tessellation Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: I581d7485d0e8771f3f23dea4255139d56052bee9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653910 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Peng Huang 53105997 2021-01-28T07:42:15 Initialize some missing vulkan function pointers Those methods are used by VMA. However VMA can get those methods by itself, if null function pointers are provided for creating the VMA. But it will cause problem, when ANGLE & Chromium are sharing one VMA implementation, since the VMA implementation in chromium will be built with VMA_STATIC_VULKAN_FUNCTIONS=0 & VMA_DYNAMIC_VULKAN_FUNCTIONS=0. Bug: chromium:1170339 Change-Id: I5bf435698e4e361bfa7a6afce84390ccc4355b53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2655795 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi a408ce83 2021-01-27T13:48:27 Fix geometry shader draw mode validation The draw mode (as passed to glDrawArrays) was being compared with the transform feedback mode in the presence of geometry shaders, but the two are completely unrelated. Bug: angleproject:5579 Change-Id: I03bff97f79fe8d8a4354a6ea3abfed58c1e600eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653907 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 07f16f00 2021-01-28T10:01:57 Roll vulkan-deps from 01ef7ce6f449 to 5f7a1ace1a5e (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/01ef7ce6f449..5f7a1ace1a5e 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from a4f97da409f2 to b812fd634ea5 (3 revisions) 2021-01-27 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from a61600c7639c to a4f97da409f2 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ie4aad65246d623241089cc3bd42b73ef2d8fa0dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2655326 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b28f1c44 2021-01-28T10:01:24 Roll SwiftShader from aec0826aba0d to 3e9b79ff42de (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/aec0826aba0d..3e9b79ff42de 2021-01-27 capn@google.com Enable named mmap usage on Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Idceb84d5d63afab8efe3ab2f50e46ba4b30ac46a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2655345 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 5e0a8f9b 2021-01-27T13:46:08 Translator: Enable geometry and tessellation in ES3.2 Symbols that these extensions introduced were only accepted if the extension directive was present. This is not necessary for es 320 shaders. This change adds a new tag to builtin variable and function declarations in the translator, namely "essl_extension_becomes_core_in" which makes gen_builtin_symbols.py automatically create two entries for the builtin; one with the specified level and extension, one with the core level and without extension. Entries in builtin_function_declarations.txt can potentially be deduplicated as a follow up to take advantage of this tag, though likely an anologous "glsl_extension_becomes_core_in" needs to be introduced. Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: I84c19f48a3ccc89d82d80a4f35f7833205bbc88f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2649449 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten badcf3bd 2021-01-27T17:14:43 Vulkan: Enable fbo.invalidate.whole.unbind_blit_msaa_[color|stencil] These test failures were fixed with a recent SwS CL: https://swiftshader-review.googlesource.com/c/SwiftShader/+/52088 Bug: angleproject:5044 Test: dEQP-GLES3.functional.fbo.invalidate.whole.unbind_blit_msaa_color Test: dEQP-GLES3.functional.fbo.invalidate.whole.unbind_blit_msaa_stencil Change-Id: I36034c72e28fc07ecff0eaca31745c97f054b77e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2654526 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4ce2e213 2021-01-28T07:00:42 Roll Chromium from 9ac53d238b0c to 34154bd58dcb (208 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9ac53d238b0c..34154bd58dcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/60c7f94b29..80d8522df9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d573d8d1be..4f733a4525 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9d5ec46922 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eb5ab41f38..0d2b89124b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6806d508f7..c3a074da20 * tools/skia_goldctl/linux: 5uRd0nSbglRL_SlkzkofedmMPgK-1F0ICeAPyhneOY4C..opL5N0hiBtWxiOFaEhRqXpJWh70uurNTInvkY8NHr8oC * tools/skia_goldctl/mac: jH1EXicKWfNsK_lsEmfi4_MozROrG68ybn4yGmcDj_oC..pmlVeVFuSc7Re0D7Efu2pAh2Oo5rEAnlg1rFIfp1RncC * tools/skia_goldctl/win: n1MqOqpTysNu10SmTHGk7eHIIUMoy2SErGFxHZBoZNIC..GRI6-L-7YmnYGw8gs2jXZDqvI5KIFIgsj_GvzZ4krYQC No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: Iecafd7f85dd36b0a1c7fe6c67fdd26876af9780b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2654433 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a12edfa5 2021-01-27T21:27:07 Roll Chromium from 4bbaf376844e to 9ac53d238b0c (270 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4bbaf376844e..9ac53d238b0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fcaf1b1b36..60c7f94b29 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/71044dffd0..e3db55b463 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/001e33eea6..d573d8d1be * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f0c0aae6f2..f43a84ba66 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9d5ec46922 No update to Clang. Bug: angleproject:5417 Tbr: jmadill@google.com,ynovikov@google.com Change-Id: I5f4b945ca375385c2974c06f6b727080a731b421 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2654082 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tim Van Patten 5006a573 2021-01-26T17:15:10 Capture/Replay: Capture glUniformBlockBinding() eFootball PES 2021 uses glBindBufferRange(), which requires glUniformBlockBinding() to create the pairing of uniform block indexes to buffer bindings. The uniform buffer indexes that are assigned when each program is linked can differ between drivers, so the glUniformBlockBinding() calls need to be recorded to get the correct index values for the glBindBufferRange() calls. Bug: angleproject:5564 Change-Id: I909e05d5b1cc50e592b887bd130aa80cdb1bb40f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2650993 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 351e6e8c 2021-01-26T17:08:59 Add 'UniformBlockIndex' struct Add the new structure 'UniformBlockIndex'. This is in preparation for capturing glUniformBlockBinding() calls, which requires the (new) corresponding ParamType::TUniformBlockIndex. Bug: angleproject:5564 Change-Id: I88613dd96d058659dd253e8088fab49670c32316 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2651287 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang bc7554f9 2021-01-27T14:41:18 Remove extension files that are not written by ANGLE. We inconsistantly added some extension txt files to our extensions folder that are not maintained but possibly implemented by ANGLE. Some of these extensions trip up Android's automatic license detection. Bug: None Change-Id: I9bde4235c7ad2bf4d9bcf5385f4138296cef2c13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653848 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 8f6c328d 2021-01-27T18:40:56 Roll vulkan-deps from 3849583848aa to 01ef7ce6f449 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/3849583848aa..01ef7ce6f449 2021-01-27 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c47ac8e1cc37 to 31e95c1707c5 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com,syoussefi@google.com Change-Id: I18291ddfe3171db0bbdb7d27d9a2290468d85926 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653847 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang ea0f3496 2021-01-25T12:47:27 GL: Update VertexArrayGL to not store per-context state. Move StateManagerGL and FunctionsGL members out of VertexArrayGL and query them directly from the context in methods. Bug: angleproject:5577, chromium:1167179 Change-Id: I376f3eff15fbd9855c5956737064f56d54acbceb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2647868 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill f6925344 2021-01-25T13:13:33 Trace Tests: Update expectations. Bug: angleproject:5530 Change-Id: I48a6dc5753406e6dd6cd1845f1f28fcbfc485e34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2647871 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 52afb6f1 2021-01-26T22:22:07 Fix angle_unittests build on iOS Link failed because libfeature_support symbols were private Bug: angleproject:5417 Change-Id: I04c4056e1a887a9ad7bde692c7c2780b5d1dd387 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2649122 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Doug Horn e7ca0aa2 2021-01-24T17:46:26 Fix crash in multi-context D3D11 backend. The crash occured due to a lack of marking a context dirty on eglMakeCurrent(), resulting in a situation where a thread B would call eglMakeCurrent() but before issuing additional GL calls, thread A would issue a draw command. Prior to this change, context state would only be marked dirty on gl calls. Test: dEQP-EGL.functional.sharing.gles2.multithread.* dEQP-EGL.functional.multithread.* dEQP-EGL.functional.render.multi_thread.* dEQP-EGL.functional.color_clears.multi_thread.* Bug: b/177602915 Change-Id: I765e0423002a373f94ea459b81b6e6f6942870d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2646609 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Doug Horn <doughorn@google.com>
angle-autoroll fdf441ce 2021-01-27T10:01:27 Roll SwiftShader from ea1f7d10db1f to aec0826aba0d (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ea1f7d10db1f..aec0826aba0d 2021-01-26 amaiorano@google.com VulkanBenchmarks: split out benchmark classes into separate files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Icd0d171ea312f0b2cd3e905b7ba75f8d5fb0e977 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2652288 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 317f4991 2021-01-27T10:01:06 Roll vulkan-deps from 0ba7f6930e7e to 3849583848aa (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0ba7f6930e7e..3849583848aa 2021-01-26 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 79b22370b0b0 to c47ac8e1cc37 (1 revision) 2021-01-26 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 6abdde3ce511 to 36df92e4a0ef (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I8c18aebefb94a7b7290325f6c9c64ce20f41edfa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2652366 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 63b4df59 2021-01-27T07:35:55 Roll Chromium from 70020e670c0f to 4bbaf376844e (453 revisions) https://chromium.googlesource.com/chromium/src.git/+log/70020e670c0f..4bbaf376844e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c4a8df816d..fcaf1b1b36 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/74d2546231..71044dffd0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/13cdc88532..001e33eea6 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/63a2bc635d..f0c0aae6f2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1cd5ea42ac * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/518d81558c..fa0de07678 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/94a96af5d6..eb5ab41f38 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/2b1beb5865..6806d508f7 No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I21aff744f673c74a16fdb90d619fab2ac38271db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2651650 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi de53e308 2021-01-26T12:44:04 Metal: Fix XFB failures on ARM. Metal back-end needs to generate 2 versions of XFB shader: - one version without XFB emulation code for rasterized draw. - one version with XFB emulation code for draws with rasterization disabled. Based on a change by le.hoang.q@gmail.com Bug: chromium:1167763 Change-Id: I2858859e15b18701fadff09092bb08778c4a7e64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2648636 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 4921e457 2021-01-22T22:36:13 Vulkan: Avoid unnecessary pipeline rebinds Bug: angleproject:5528 Change-Id: I5502498fa5d6767f55635fe9fff949d7fd644f4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2645640 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi c38413f8 2021-01-26T15:04:38 Make glmark2 benchmark output parsing more resilient On Linux, the following info messages are being output which are seemingly harmless: INFO: EGL CRITICAL: eglQueryString: display is not initialized. INFO: EGL ERROR: eglGetPlatformDisplayEXT: Bad platform type. These lines are now parsed and forwarded to output. Bug: angleproject:3139 Change-Id: Ia9feb2aef4c1809283588d6e5fc1b6a51ae8812b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2648641 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jonah Ryan-Davis f9afaaee 2021-01-25T13:46:22 GL: Remove in-thread link status check from parallel link path. A call to checkLinkStatus was wrongly placed in the nativeParallelCompile path, which ended up blocking on shader linking, rendering parallel compilation useless. Bug: chromium:1169477 Bug: chromium:1099763 Change-Id: Id2c5fe31e651abac76207c93919fd83d79f30556 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2647987 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 50f7d646 2021-01-26T10:01:06 Roll vulkan-deps from dbc46e43978b to 0ba7f6930e7e (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/dbc46e43978b..0ba7f6930e7e 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 5a01949aa859 to 79b22370b0b0 (2 revisions) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7e0458f5ee73 to 5a01949aa859 (2 revisions) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c55e290fe581 to 7e0458f5ee73 (2 revisions) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f3a9b5b33c61 to c55e290fe581 (2 revisions) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 1186f95a2f7b to f3a9b5b33c61 (1 revision) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 819117cd48e7 to a61600c7639c (1 revision) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 89ad2272baae to 819117cd48e7 (1 revision) 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 968659aee8af to 89ad2272baae (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I4cd05e4b38e5651d33c70d072d9e86d229f1497b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2649670 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 81a751d8 2021-01-26T10:01:27 Roll SwiftShader from 413f7cb17c77 to ea1f7d10db1f (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/413f7cb17c77..ea1f7d10db1f 2021-01-26 sugoi@google.com Handle sampleRateShading parameters 2021-01-26 sugoi@google.com Move required interpolation logic to SpirvShader 2021-01-26 sugoi@google.com Add mode for sample qualifier 2021-01-26 natsu@google.com Update Android.bp for VK_EXT_headless_surface 2021-01-25 amaiorano@google.com VulkanBenchmarks: refactor TriangleBenchmark into a more reusable base class 2021-01-25 amaiorano@google.com VulkanBenchmarks: add solid and interpolated triangles tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ibd406cc362597fb2bd5576c31d0f0c69486b1907 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2649770 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 274dc1bf 2021-01-26T07:01:23 Roll Chromium from 8378a463e1a2 to 70020e670c0f (434 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8378a463e1a2..70020e670c0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/710b42c08b..c4a8df816d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/13547b97da..74d2546231 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b66650c011..13cdc88532 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2b1e9cf86a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/756cf7138c..2b1beb5865 * tools/skia_goldctl/linux: T8wzDdpKse34sb84KYsgP5FcmR1QAnFdrtUSkZOBtvcC..5uRd0nSbglRL_SlkzkofedmMPgK-1F0ICeAPyhneOY4C * tools/skia_goldctl/mac: YkIZZLTolR7P8J70QaLh9tuiSkEDPWV3MCs3BRYhX2YC..jH1EXicKWfNsK_lsEmfi4_MozROrG68ybn4yGmcDj_oC * tools/skia_goldctl/win: bN3GOEHxnirdwM8liN0rP7M9VljsA-PP_h50Tbw1XrQC..n1MqOqpTysNu10SmTHGk7eHIIUMoy2SErGFxHZBoZNIC No update to Clang. Bug: angleproject:5417 Tbr: jmadill@google.com Change-Id: I1aa6dd51eb7ae4132b35a8f365a1d51a2e344447 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2649461 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 9bbcd86a 2021-01-25T10:52:35 Capture/Replay: Fix instanced array client data. Enables a bunch of self-tests. Bug: angleproject:5530 Change-Id: Idd14574ba0f3d44124e153ccb32fec7318baf217 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2647745 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 6689a54d 2021-01-21T00:36:14 Vulkan: autogen for SPIR-V instruction build and parse Handwritten SPIR-V instruction parse and build code is replaced with autogenerated functions based on the SPIR-V grammar. Bug: angleproject:4889 Change-Id: I09d724fd944e79c03fe4eadca3ee3e3ef0b49872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2644721 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Amy Liu cc5083e0 2021-01-15T10:29:36 Compression of the data from vkGetPipelineCacheData. The size of pipelineCacheData sometimes is greater than 64k which cannot be saved because of the Android blob cache limitation (single cache data size should be < 64k). Implement the compression to store more cache data. Bug: angleproject:4722 Change-Id: I435b086d70d0e6378f1141464ae2bafbe076f193 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2631511 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill cfb9c30c 2021-01-25T10:54:09 Capture/Replay: Apply skips correctly on SwS. The skips listed currently were explicitly for ES2_Vulkan instead of applying to both desktop and SwS Vulkan implementations. This CL swaps the expectations to use wildcards so they will work for both. Bug: angleproject:5530 Change-Id: Iae83207411296cb819bb0a25d2247cb4af863adb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2645723 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3623868e 2021-01-22T12:24:50 Trace Tests: Add xvfb command line option. This will enable running the tests on Linux. Bug: angleproject:5530 Change-Id: I7cd2155fac89d395a8bebacb2f1a44be0e7d3739 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2644723 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll d026fd35 2021-01-25T10:01:24 Roll vulkan-deps from a0047c0f6ec8 to dbc46e43978b (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a0047c0f6ec8..dbc46e43978b 2021-01-25 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 684390cedbff to 9166a0677e44 (1 revision) 2021-01-22 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from fd06d42afd9a to 1186f95a2f7b (2 revisions) 2021-01-22 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from ab73ad637606 to fd06d42afd9a (1 revision) 2021-01-22 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 9acb9ec31f5a to 84a41cd4883d (1 revision) 2021-01-22 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f37547c73a98 to 968659aee8af (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I6b69186a6d46beac39d06508fef3fcf70b020fba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2646556 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7ea083c4 2021-01-25T10:01:20 Roll SwiftShader from 9441aea16221 to 413f7cb17c77 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/9441aea16221..413f7cb17c77 2021-01-22 sugoi@google.com Flip samples to their correct position 2021-01-22 capn@google.com Target macOS 10.14 on ARM64 to enable C++17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I3e092e5b22b355942c4dc9f6950b4ee022667a9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2646615 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cd0b933d 2021-01-25T07:02:02 Roll Chromium from 318dff1807ef to 8378a463e1a2 (643 revisions) https://chromium.googlesource.com/chromium/src.git/+log/318dff1807ef..8378a463e1a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/888f037dd4..710b42c08b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/eeb08d20a6..b66650c011 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..957dfeae29 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/786cae1ea0..94a96af5d6 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/07f759b55a..756cf7138c * tools/skia_goldctl/linux: ISnBOFRy8pK6MqHvQt1Dssi358v4KHM5zJuWVrsmL6cC..T8wzDdpKse34sb84KYsgP5FcmR1QAnFdrtUSkZOBtvcC * tools/skia_goldctl/mac: -AmQt0We5dhSelcdGZjJtq6gbhQWATSagCOyH-JL0yIC..YkIZZLTolR7P8J70QaLh9tuiSkEDPWV3MCs3BRYhX2YC * tools/skia_goldctl/win: Dlf6e8GKMBiJAaFXTVte4LowGeiFs79erbrVany5R1gC..bN3GOEHxnirdwM8liN0rP7M9VljsA-PP_h50Tbw1XrQC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I52b1160913d24512b2d5ebcbcb8c3f47b4708d0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2646357 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 3c3b82ab 2021-01-21T20:21:34 Tests: Add Hearthstone trace Test: angle_perftests --gtest_filter="*hearthstone*" Bug: angleproject:5571 Change-Id: Idc6535bbf817cd62d34aa9e684604be068455520 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2644143 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi c51c3548 2021-01-19T14:15:54 Vulkan: Unconditionally expose OES_shader_io_blocks All relevant tests pass, so no longer conditioned to exposeNonConformantExtensionsAndVersions. Bug: angleproject:3580 Change-Id: I9b398bd962831fabf0ec39ad9aad3b200717d087 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636687 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 61bd3440 2021-01-21T16:57:38 Roll Khronos headers. Many of our GLES and EGL headers had old SGI licenses which tripped up Android's license detection. Bug: None Change-Id: Iede9a72b3619fdd77ba21895fc5a76a81f0a5790 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643489 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 3846cff3 2021-01-21T16:37:12 Suppress headers includes privacy checks on iOS shared libraries are hidden inside ios_framework_bundle, so technically we are not allowed to include headers from them. Ignore this check since everything works fine besides "gn gen --check". All ANGLE headers are considered public, so we don't need this check. Bug: angleproject:5417 Change-Id: I6b621132dfe85e0fb1bea4ae2b93097945a8801a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643859 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill e60ce3da 2021-01-21T16:42:17 Capture/Replay: Allow testing with multiple versions. This embeds the context version and device type info into the replay. The self-tests then can create the correct display and context types. This fixes testing against SwiftShader which is necessary for the bots. Bug: angleproject:4759 Change-Id: If9da6bfdc1c2b315ccd7e453872fc84063277054 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643363 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill b745f6df 2021-01-21T14:41:00 Capture/Replay tests: Fixes for goma & depot tools. Adds the depot tools path to be specified via the command line. This will allow the bots to specify working directory locations. Also adds quotes around the goma path in the gn args. Bug: angleproject:5530 Change-Id: I1291a8cdf4e36e55786403b4d9a6ce8565093352 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2642894 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 5c71a4b1 2021-01-22T10:01:20 Roll SwiftShader from 22be66d40712 to 9441aea16221 (10 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/22be66d40712..9441aea16221 2021-01-22 bclayton@google.com Merge changes I6c21b03d,Ic6136d02,I988c0288,I21d11818,I79fa8162, ... 2021-01-21 capn@google.com Implement non-void indirect Reactor Call() support 2021-01-21 amaiorano@google.com Make RoutineT::getEntry() type safe 2021-01-21 swiftshader.regress@gmail.com Regres: Update test lists @ b3e5c440 2021-01-21 capn@google.com Target macOS 10.12 when building LLVM 2021-01-21 capn@google.com Use aligned allocation for classes with aligned members 2021-01-21 nicolascapens@google.com Enable and require C++17 compilation 2021-01-20 srisser@google.com Implement VK_KHR_depth_stencil_resolve 2021-01-20 amaiorano@google.com Move reusable Vulkan code from VulkanBenchmarks to new VulkanWrapper library 2021-01-20 amaiorano@google.com VulkanBenchmarks: factor out code into separate files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: If067e1497564ff72fab0711621d95911f80bd902 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2644698 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3f4e004f 2021-01-22T10:01:24 Roll vulkan-deps from f646afdb8929 to a0047c0f6ec8 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/f646afdb8929..a0047c0f6ec8 2021-01-21 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 9b4e82efb482 to 6abdde3ce511 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iac0fb2ddd8cb81e7cec57df74062e83eca32c172 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643123 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c827ccbb 2021-01-22T07:01:08 Roll Chromium from 67fb6a8435bb to 318dff1807ef (435 revisions) https://chromium.googlesource.com/chromium/src.git/+log/67fb6a8435bb..318dff1807ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2f05905c0d..888f037dd4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0c30db82f7..13547b97da * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cd618b63bb..eeb08d20a6 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/947ea991af..63a2bc635d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..957dfeae29 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3c716375fd..786cae1ea0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7161349d95..07f759b55a No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I6bc26ccad8ffc7a406c03c6726112212a492ed3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643865 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Steven An ff5f715e 2021-01-19T16:46:04 Properly fail upon program binary version mismatch Return angle::Result::Stop instead of Incomplete when Program::deserialize detects version mismatch. This causes the caller, Program::loadBinary, to stop trying to load it. At least with the Vulkan backend, trying to load it results in a crash. Added test case to ProgramBinariesAcrossPlatforms which exhibits the old crash. Bug: angleproject:5567 Change-Id: I2ebb27cee0aa895855504f758992b4dfec3f4aa3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639078 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Steven An <stevenan@google.com>
Tim Van Patten 9ccd3536 2021-01-20T18:19:41 Capture/Replay: Capture all indexed buffer bindings during MEC "eFootball PES 2021" binds uniform buffers via glBindBufferRange() before any frames haves been rendered and then uses those bound buffers for all subsequent frames. A recent fix captured the UBOs that were also bound as GL_UNIFORM_BUFFER, but failed to capture all indexed buffers bound only with glBindBufferRange(). This CL captures all indexed uniform, atomic counter, and shader storage buffers during MEC setup. Bug: angleproject:5564 Change-Id: I0e638ec4407a091f943b9640e8fc6a7c9f4c4e08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2640424 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Cody Northrop 70f493d6 2021-01-20T14:22:14 Tests: Add Subway Surfers trace Note this differs from the previous trace for the app, "subway_surfer_500". The previous trace is no longer compatible with the replay harness and could not be re-recorded due to using Vulkan at the time. Test: angle_perftests --gtest_filter="*subway_surfers*" Bug: angleproject:5569 Change-Id: If941a3f0e88e3e1aee7fb7db736e623f66a65de6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2641098 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tim Van Patten 535d4783 2021-01-20T14:14:02 Vulkan: Flush if sync object is pending during SyncVk::getStatus() When a glGetSynciv() is performed for GL_SYNC_STATUS, we should flush any pending commands if a sync object is pending a flush, since the caller is interested in the status of a fence. This will guarantee that the work is submitted to the hardware and eventually completes. This is accomplished by moving mSyncObjectPendingFlush from ContextVk to ShareGroupVk, so that any sync objects used by any contexts within the share group are submitted to hardware and the required work completes. Bug: angleproject:5306 Bug: angleproject:5425 Test: FenceSyncTest.BasicOperations Change-Id: I2e2681ad01fda429ba37f061c9bac5eb91f800fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2641095 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Tim Van Patten 26e02593 2021-01-15T12:38:46 Capture/Replay: Erase texture from mCachedTextureLevelData When the caller issues a glCompressedTexImage call, we need to delete the cached texture data, since the texture size/data are being respecified and the old data is now stale. This fixes MEC for "Klondike Adventures". Bug: angleproject:5549 Change-Id: Ie788e2bf39f7a29ec6bc55f95d6f570f1d22d659 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633071 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Peng Huang f5d56799 2021-01-20T10:00:54 Do not make context current during context deletion. ANGLE will make a context current during deletion, so ANGLE can release related resources, but for an external context, the API user should make sure the native context is current during deleting the ANGLE external context, so ANGLE doesn't need to make the context current. Bug: angleproject:5509 Change-Id: Ia4cee4e3965e9e9e811e3f989f6f6d72bd940f41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2640593 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 203154b5 2021-01-18T10:43:07 Vulkan: Remove swiftshader workaround for missing gl_Position The following line was added by the translator to work around a swiftshader bug where no gl_PerVertex declaration (and hence no gl_Position) would fail an assertion: gl_Position = gl_Position; The swiftshader bug is fixed, so this line can be removed. Bug: b/176161380 Change-Id: I68a8e0d9cd8b97e9d294a119c2daa4ab64ec863f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633729 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f28a06ba 2021-01-21T10:01:24 Roll vulkan-deps from 3180f85f9bcd to f646afdb8929 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3180f85f9bcd..f646afdb8929 2021-01-20 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 1bd539b9bfc4 to f37547c73a98 (1 revision) 2021-01-20 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 56f8ed48efd5 to 1bd539b9bfc4 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I592dbdeccf1b7aeaa8bc36b0cafaf9363678b19e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2641011 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0e37da9b 2021-01-21T08:14:23 Roll Chromium from 132575638f37 to 67fb6a8435bb (480 revisions) https://chromium.googlesource.com/chromium/src.git/+log/132575638f37..67fb6a8435bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3fd2266640..2f05905c0d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4dfabb3243..cd618b63bb * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..beb8370c49 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2e4e6e975a..3c716375fd No update to Clang. Bug: angleproject:3580 Tbr: cnorthrop@google.com Change-Id: I5aeb58e86be883cbb5e03bbc910981deaede93c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2641008 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 9f4b159b 2021-01-19T12:48:15 Translator: Avoid vector copies with multi-replacement Turns push_backs into emplace_backs and changes the TIntermSequence constructor argument to &&. Bug: angleproject:5535 Change-Id: I640ce879b6ade48a28dea6385ebb7a95cb8304ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636680 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Tim Van Patten bb766000 2021-01-20T16:58:16 Vulkan: Move Flush during SyncHelper::clientWait() earlier The checks and call to contextVk->flushImpl() needs to be moved before the timeout check to ensure that the vkEvent is flushed to HW eventually when the caller is waiting on it, even if they don't specify a timeout. Bug: chromium:1060139 Test: CopyOutputScalingPixelTest.ScaledCopyOfDrawnFrame/48 Change-Id: I725ea492aaf21e291fe3e5b9ae11ea009e59e019 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2640423 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Shahbaz Youssefi f0286e63 2021-01-19T12:38:46 Translator: Stop allocating TIntermSequence The functions that take a TIntermSequence always copy out / Swap the contents away. This change makes all TIntermSequences live on the stack instead of being newed. Bug: angleproject:5535 Change-Id: I942f1c5e57b00199d5308183f71bd9e18b0608bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636679 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sunny Sachanandani 137271ff 2021-01-13T14:34:12 Support specifying array slice for D3D11 texture EGLImage Client can specify array slice for creating the SRV/RTV with EGL_D3D11_TEXTURE_ARRAY_SLICE_ANGLE. Test: D3DTextureTest.TextureArrayImage* Bug: angleproject:5538, chromium:1116101 Change-Id: I81cb2823df2145f1d05ad1526b0e36d6a0724d5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2628609 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Shahbaz Youssefi bb3adfa4 2020-12-01T15:43:13 Rename ShaderVariable::structName to structOrBlockName Bug: angleproject:3580 Change-Id: Ic53a5267972f153dad2e20948e493e9767a45d16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568247 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang df33d561 2021-01-19T11:42:35 EGL: Respect eglMakeCurrent with a null context. Our context virtualization code would try to optimize this case and leave the current context bound when possible. This has the side effect of leaving the current surface bound too, even if it was deleted. During Chrome's window resizing, it deletes the window, calls eglMakeCurrent with null and then recreates the window. This causes an error because the window still exists because it was left current in ANGLE. Bug: chromium:1167718 Change-Id: I857be88be48dfa9c0dd9173f235e155e727e3014 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2637717 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Peng Huang 2ebff7f2 2021-01-20T08:39:40 Support switch surfaces for external context. WebView may change surfaces due to resizing. So we need to support switching surfaces with the external context. Bug: angleproject:5509 Change-Id: Id91eed092a63b3740fd796e0a3cb819ae18baaa9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639077 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Jamie Madill 0ae61c25 2021-01-20T10:40:24 Capture/Replay tests: Use failure exit code. This will allow the test step to fail when run in CI. Bug: angleproject:5530 Change-Id: I7c156438ded82aa7191b8b597a9a52200c0efe57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2638989 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi ea71c6b6 2021-01-12T14:13:35 Vulkan: Emulate R32F images with R32UI GL requires that imageAtomicExchange be supported for r32f formats. However VK_FORMAT_FEATURE_STORAGE_*_ATOMIC_BIT is nearly unsupported everywhere without some Vulkan extension that brings in unnecessary support. This GL feature is emulated by transforming the shader to use r32ui for all images that originally specified r32f. floatToUintBits and uintBitsToFloat is used to maintain correct usage of the image* builtin functions. Bug: angleproject:5535 Change-Id: Ie607089935d3283b3ffa054f4b4385b81fb8f53d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2635453 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill a4d05638 2021-01-18T14:58:22 Capture/Replay: Don't serialize compile resources string. The resources string gets changed dynamically during capture. This breaks the regression tests because they were comparing for identity. Bug: angleproject:5530 Change-Id: I0734f735577a5ff4c9083adb8f25a37aad3c0e37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634830 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Michał Pichliński 80b45c33 2021-01-20T12:20:35 Make metal_shader_cache_file_hooking a data_deps After https://chromium-review.googlesource.com/c/angle/angle/+/2580918 angle_unittests will not run on OSX when it is non component build and metal_shader_cache_file_hooking is a shared library: dyld: Library not loaded: ./libmetal_shader_cache_file_hooking.dylib Bug: angleproject:5565 Change-Id: I1ac43d928cfaff692aa233c2ba3504a73573ee3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2640173 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 2b242f53 2021-01-17T14:24:53 Vulkan: Simplify RewriteCubeMapSamplersAs2DArray This change is mostly done to remove an unnecessary helper in ReplaceVariable.cpp. Tested locally, as the bots all support ES3.1+. There are a few failures, with or without this change. Bug: angleproject:5556 Change-Id: I7bd2d4294c9dc164146d713db6b45cbc73e59c16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633437 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll bd8ca051 2021-01-20T10:01:56 Roll vulkan-deps from dd50a3bce3ca to 3180f85f9bcd (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/dd50a3bce3ca..3180f85f9bcd 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from e25db023c47a to 56f8ed48efd5 (1 revision) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c7ffe6890160 to ab73ad637606 (2 revisions) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from efecc309816c to c7ffe6890160 (2 revisions) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from fb6e414f76dc to efecc309816c (1 revision) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 03e41cc0c2a8 to fb6e414f76dc (2 revisions) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 6886c4b57f10 to 03e41cc0c2a8 (3 revisions) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 10651a9c0bc2 to 6886c4b57f10 (1 revision) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 5b7d68ca6b3f to 9b4e82efb482 (1 revision) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 3de5cfe50ede to 5b7d68ca6b3f (1 revision) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 9efc4a631161 to 684390cedbff (1 revision) 2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 8383bd5d6f26 to e25db023c47a (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ic79a5b12d8132a7f322c507150d3a7aa62ca0d66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639815 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 15a3d28b 2021-01-20T10:01:51 Roll SwiftShader from 8da0f82baf35 to 22be66d40712 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/8da0f82baf35..22be66d40712 2021-01-20 capn@google.com Fix always performing early depth test when requested 2021-01-19 digit@google.com vulkan: Support VK_KHR_external_memory_fd on OS X. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iddb4b62f284463aef7d7cdcc289b711668e0c545 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639923 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2900a0f4 2021-01-20T07:00:58 Roll Chromium from f3626a1bfa8f to 132575638f37 (396 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f3626a1bfa8f..132575638f37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9766d96a51..3fd2266640 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c38b5ab1c6..0c30db82f7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d6e501127c..4dfabb3243 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..05342ef131 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/819010a7e6..2e4e6e975a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/860610b866..7161349d95 * tools/skia_goldctl/linux: fZ-8UCX4nVBdizWPWt4iEXoKw9052O2u8regRqax1zUC..ISnBOFRy8pK6MqHvQt1Dssi358v4KHM5zJuWVrsmL6cC * tools/skia_goldctl/mac: tb5CVkUBpdIU8L9wnnDjjfFYcI6Xbq9-m8iZlEi5G-EC..-AmQt0We5dhSelcdGZjJtq6gbhQWATSagCOyH-JL0yIC * tools/skia_goldctl/win: CY_g7u7URjjZnq4pgCohkA5JcSnWH4YE10bSECPnYewC..Dlf6e8GKMBiJAaFXTVte4LowGeiFs79erbrVany5R1gC No update to Clang. Bug: angleproject:2930,angleproject:3481 Tbr: cnorthrop@google.com Change-Id: If5369b42a9d3c3e994e502dd34b50044388d5e16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639545 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 186fe990 2021-01-15T15:49:30 Vulkan: Redo RewriteAtomicCounters With MonomorphizeUnsupportedFunctionsInVulkanGLSL and RewriteArrayOfArrayOfOpaqueUniforms transformations run, it is no longer possible to encounter array of array of atomic counters, or have any passed to functions. As a result, RewriteAtomicCounters is greatly simplified. Additionally, it is no longer necessary to pass binding/offset information for atomic counters around and they can use constants. This change removes dependency on the shaderStorageBufferArrayDynamicIndexing Vulkan feature. Bug: angleproject:3726 Bug: angleproject:3881 Change-Id: Ia43092a668f60d009eccbbceeed5deaf105a5895 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633687 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 64c89120 2021-01-19T21:51:23 Suppress incomplete texture tests on mac/arm Bug: chromium:1168370 Change-Id: I5f3e1b76b4efd21f3655d6995293ff4bbbebea17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639273 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0