kc3-lang/angle

Log

Author Commit Date CI Message
Alexey Knyazev 147ba459 2024-05-30T00:00:00 Allow polygonMode* commands with active PLS Drive-by: * Test that polygonOffsetClampEXT is allowed when PLS is active. Fixed: angleproject:345253437 Change-Id: I5d9f60b3e70eaf8da19017a8b9d6c2592cb4f4f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5601849 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 3c92002a 2024-06-06T10:01:35 Roll SwiftShader from b8cf5b3d2bce to c344e2837bbe (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/b8cf5b3d2bce..c344e2837bbe 2024-06-06 chrisforbes@google.com Only offer KHR_swapchain_mutable_format on non-android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I7f920b309b0bef8db7ead7ef2087b4f83ac56ea7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5597915 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6fffe695 2024-06-06T07:15:42 Roll Chromium from b1a657048264 to 263a51c32801 (599 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b1a657048264..263a51c32801 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/038161e394..8fede9ade6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/bf0c265e19..2bd8dea61c * buildtools/linux64: git_revision:4fb095d3f70f624c73bfdd156c5179fad535287d..git_revision:b3a0bff47dd81073bfe67a402971bad92e4f2423 * buildtools/mac: git_revision:4fb095d3f70f624c73bfdd156c5179fad535287d..git_revision:b3a0bff47dd81073bfe67a402971bad92e4f2423 * buildtools/reclient: re_client_version:0.146.0.0c7ca4be-gomaip..re_client_version:0.143.0.518e369-gomaip * buildtools/win: git_revision:4fb095d3f70f624c73bfdd156c5179fad535287d..git_revision:b3a0bff47dd81073bfe67a402971bad92e4f2423 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a18d081cd4..ee2736d561 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/30d4d21846..bfe59c2726 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/c55fe19074..ca4cddf94a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/01b3d1cd47..eda440d333 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c069eff3f4..ad3ad021d9 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/ba56d9bb6a..c1d18115ba * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b4ab4fad33..1c5ff31f9f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cececb2a6b..fe9a5bb276 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/13496db704..74137f12c1 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Iba42d18678bb72e9f676eb54b1fcf32460cfd948 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5601083 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao b93af07a 2024-05-31T11:36:32 Reland "Vulkan: Defer texture data flush until data provided for all levels" This is a reland of commit 490c056a88a33870cb4ba2a7906b0a9688d96262 Original change's description: > Vulkan: Defer texture data flush until data provided for all levels > > One of the major overhead with VkEvent is seeing with first frame where > all textures are being specified. The immutable textures, we always > immediately flush out the update as data provided for each level. This > means one VkEvent is created and SetEvent is called per level. This CL > delays the flush until data for all levels are provided, thus there is > only one flush per texture instead of per level. With this CL asphalt_9 > is no longer timeout on bots when VkEvent is enabled. > > There is also another benefit comes with this CL. On all desktop GPUs, > ASTC format texture are falling back to RGBA8. We always stage a clear > for the emulated format. That staged clear are able to be removed if > data is provided later. Because of we flush out staged update when first > level data is provided, all staged clear for the subsequent levels are > also gets flushed out, losing the chance to be removed. This CL will > allow all staged clears being removed. > > Bug: b/343976993 > Bug: b/336844257 > Change-Id: Ica731ea57db771b16966f4da92ccdc551ae93d81 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588816 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: b/343976993 Bug: b/336844257 Change-Id: Ie987582a44e0d73abd38ce8f6813ff8995e907e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5597810 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Cody Northrop b0eff196 2024-06-04T20:03:40 capture_replay_tests: Skip forceRobustResourceInit failures These tests fail when forceRobustResourceInit is enabled, regardless of capture status. They were previously skipped: https://chromium-review.googlesource.com/c/angle/angle/+/3118549 and then were removed (perhaps inadvertently): https://chromium-review.googlesource.com/c/angle/angle/+/3291643 They started failing again after a CL that affects the timing of texture updates (http://crrev/c/5588816), were likely just getting lucky, so lets return them to SKIP. Bug: b/345024038 Bug: angleproject:6314 Change-Id: I370502bf9f293a29f7535b04741e47843bffb937 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5599918 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 6968848e 2024-05-30T00:00:00 Remove PLS checks from GLES 1.x entry points Fixed: angleproject:345125742 Change-Id: If845ddb654221cfb88c3f69bb98e07dbee8b6b39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5598770 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 17cd1f5f 2024-06-05T09:56:14 Roll Chromium from f75226a669d5 to b1a657048264 (679 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f75226a669d5..b1a657048264 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1cb0cd5333..038161e394 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f15f314b78..bf0c265e19 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/aeb067e838..a18d081cd4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d822bffbe0..01b3d1cd47 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2a18f6d324..c069eff3f4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/74672d33b4..b4ab4fad33 * tools/luci-go: git_revision:3c691526411b6ba25a7582ad8aff1f5a8848b7be..git_revision:0e7802b85394ee2b790423aa212a53ffe2b828a8 * tools/luci-go: git_revision:3c691526411b6ba25a7582ad8aff1f5a8848b7be..git_revision:0e7802b85394ee2b790423aa212a53ffe2b828a8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/dbc92d80e7..13496db704 * tools/skia_goldctl/linux: DwebaDF4oPSZMck-atrwghRPzS584hU4SE0VMntP4sEC..oKjaaaIuivr1YVLozgi7-TQ_3L8gqePnlb73gNTqm9sC * tools/skia_goldctl/mac_amd64: K1iF08dyALEazf18lHRmK7k-tvRErDRGAVS3JHxHcbsC..v3bqiNn3bOVnhlAPzxLrUe8TQu3c6g-tn486WqLLDGwC * tools/skia_goldctl/mac_arm64: ms8v9LYso2x5_PGXcrV6Jf6ZW_9JYX0yFyJnqB0VrkMC..D18xFIj1nfH7hzyRPZ-RwRkUi2mkd78IR2vxt2o3yTUC * tools/skia_goldctl/win: -t8nUSs-QQ1RnwaD9oWH-_3W-avC2ugb8y29Og6Sq1YC..eEmE3_xLsZUdGeEycq_UviwCJC4BbKqbiTsNrRALpjwC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I4bef28fb737506e014eefee77c2a1c6374b6adcd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5601069 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll d809b7ab 2024-06-05T10:01:27 Roll SwiftShader from 4bb94d6c235c to b8cf5b3d2bce (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/4bb94d6c235c..b8cf5b3d2bce 2024-06-04 syoussefi@google.com Update Vulkan headers to version 1.3.286 2024-06-04 syoussefi@google.com Update Vulkan headers to version 1.3.281 2024-06-04 vvitczak.dominik@gmail.com Fix issues seen when vkCmdSetViewportWithCountEXT() is used. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8605 Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ie63b64737c1dd3a9c52a983eaeceefde36827050 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5600488 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 60c64db1 2024-06-05T10:01:25 Roll vulkan-deps from 162f2ec871cc to a58be9cfb9b6 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/162f2ec871cc..a58be9cfb9b6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/4a2e0c9b3663d1bacc91821ae5699965bff4e5e9..6a2bdeee75eb35e5349c6993d33c9afe30237d79 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/5b71c4be018cfd7951f3618defeb3c4cbf9603e9..f1bf2fadb0d599c9bd5516aefa9f8a10d7a377cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I280617f35f368747dcb7f6e01738244fab7f2283 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5599926 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 6aad8a89 2024-05-31T14:46:28 Vulkan: Remove combineAllShadersInPipelineLibrary If we have VK_NULL_HANDLE as the descriptor set layout handle for both pre-rasterization and fragment shader subset pipelines we run into VVL - VUID-VkGraphicsPipelineCreateInfo-pLibraries-06681 Need to work around this by having the renderer store a placeholder descriptor set layout handle for an empty DescriptorSetLayoutDesc that can be reused across all contexts Bug: angleproject:8677 Tests: EGLMultiContextTest.NonSharedContextsReuseDescritorSetLayoutHandle* Change-Id: I22e7f39c497d7f668afe7cb26690f6a9de49831b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5587990 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Liza Burakova 657c8c0a 2024-06-04T15:16:20 Add optimization to defer clear calls. This change adds a new SubresourceUpdate struct that will hold either an update for a clear call or a texture upload in an ImageHelper's update queue. It also adds logic to defer clear calls similar to Vulkan's, where clears are deferred if there is not an active render pass. Draw based clears are not yet supported, so the optimization does not handle those yet. Bug: angleproject:8582 Change-Id: I3ee010fa64745871835d53ce0ccb56e3fdd74550 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5554984 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Amirali Abdolrashidi 1ecb9ba3 2024-06-03T18:04:34 Vulkan: Make logging GLES32 ext conditional * Added the following flag: * kEnableLogMissingExtensionsForGLES32 * Only if enabled will LogMissingExtensionsForGLES32() log missing extensions required for GLES 3.2. Bug: b/344455232 Bug: b/336860504 Change-Id: I1b10212b0b67e61a0884b1d8af1bb395e693323c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5595319 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 68a899c2 2024-06-04T12:02:06 Vulkan: Remove shaderProgramOut from initGraphicsShaderPrograms - Remove `shaderProgramOut` from `ProgramExecutableVk` `initGraphicsShaderPrograms()` method, because in all instances argument was `nullptr` (unused). - Update `ProgramInfo::getShaderProgram()` to return reference instead of pointer. This removes confusion, causing unnecessary ASSERTs that checked result for `nullptr`. Note: CL that removed last use of `shaderProgramOut`: https://chromium-review.googlesource.com/c/angle/angle/+/5408796 Bug: angleproject:8297 Change-Id: Idf9fb1c3fd42e90dd385f48a5714ea2751f0c7db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5596549 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov d0280f09 2024-06-03T13:21:06 Cleanup Program Executable post link task wait Frontend changes: - Add `ASSERT` into `ProgramExecutable::waitForPostLinkTasks()` to check that `mPostLinkSubTasks` must be empty after backend wait. - Add `UNIMPLEMENTED` into `ProgramExecutableImpl` `waitForPostLinkTasks()`, because this method is only required if backend fills `postLinkSubTasksOut` in `LinkTask`, and frontend must not call this method if `mPostLinkSubTasks` are empty. Vulkan backend changes: - Add public `ProgramExecutableVk::waitForComputePostLinkTasks()` with ASSERT to only allow usage with Compute executable. This change avoids confusion calling `waitForPostLinkTasksIfNecessary()` with `nullptr` in case of the Compute pipelines, which will always wait. - Rename `waitForPostLinkTasksIfNecessary()` to `waitForGraphicsPostLinkTasks()`, add ASSERT to only allow usage with Graphics executable, and change optional pointer to the `GraphicsPipelineDesc` to the reference. - Add `WaitableEvent::AllReady()` check into `ProgramExecutableVk` `waitForGraphicsPostLinkTasks()` when going to skip waiting, in order to process tasks (by calling wait) when all tasks are ready. Without this change, post link task may never be processed, causing repeated `GraphicsPipelineDesc` comparisons. - Replace `GraphicsPipelineDesc` hash comparison in `waitForGraphicsPostLinkTasks()` with `keyEqual()` call. This method is around 7 times faster, however effect on the overall performance will likely be unmeasurable. Changed for clarity. - Remove unnecessary `mWarmUpGraphicsPipelineDesc` reset from: `ProgramExecutableVk` initializer list (has default constructor), Compute warmup (already clean after constructor), wait post link tasks (not used when no tasks). - Other minor changes. Bug: angleproject:8297 Change-Id: I7d790da6712be013243083e314af75f82e73886d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5592474 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Shahbaz Youssefi 25ebddb2 2024-06-04T09:47:53 Mark recently added test as flaky timeout Bug: angleproject:332383430 Change-Id: I67fd00b2735362a9298152e6d23f903ba76a2ba0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5593280 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll b52390b0 2024-06-04T09:14:24 Roll Chromium from bf81256137c8 to f75226a669d5 (634 revisions) Manual update to flatbuffers/BUILD.gn https://chromium.googlesource.com/chromium/src.git/+log/bf81256137c8..f75226a669d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8b9a3d06ef..1cb0cd5333 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/efa920ce14..f15f314b78 * buildtools/reclient: re_client_version:0.143.0.518e369-gomaip..re_client_version:0.146.0.0c7ca4be-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d228592459..aeb067e838 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7adb32fd7a..d822bffbe0 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/840e538154..2a18f6d324 * third_party/flatbuffers/src: https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/150644d7f4..6ede1ccc9e * third_party/turbine: JA8o86DtHkYnsW4v8F9pdcvi7uqN1WB-L1XFLggZdtAC..elwEJQJc0yejdGqKWdrPxMt4P7dQ-cC4UB0UdGYRllsC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/34192533e1..ba56d9bb6a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/586ee04637..74672d33b4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f10c7204c8..dbc92d80e7 No update to Clang. Bug: angleproject:5038 Change-Id: I394574efd8599a28c842d562eb83b0da4c201c00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594940 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll aa1abba2 2024-06-04T10:01:12 Roll vulkan-deps from 356a05c8a553 to 162f2ec871cc (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/356a05c8a553..162f2ec871cc Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0e311906b92f8cc74eab258260343074b00a9710..4da479aa6afa43e5a2ce4c4148c572a03123faf3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/21effda93a239cc4d726b37738c27fdc3e20ec3e..377016eea5ebd4f6d6689c1e7a7ca2a2207c3fb4 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/6bc92daa125da7aed037b46513845ebc67bc96e6..252879e8958afc0c250ed460dbecf43c206fca04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Idb814bcb8a27b0b471ff0a62e303943488b2c634 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594942 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov c41cbb3d 2024-06-03T18:59:27 Fix binary is not cached after isBinaryReady() is true Backend may wait and clear `mPostLinkSubTasks`. The `isBinaryReady()` will check, that there are no tasks, and will skip the caching. This change renamed `cacheProgramBinaryIfNotAlready()` to more general `cacheProgramBinaryIfNecessary()`, because it skips caching if there are post link tasks. The `cacheProgramBinary()` renamed to `cacheProgramBinaryIfNotAlready()`, to better reflect it's behavior. Call `cacheProgramBinaryIfNotAlready()` from `isBinaryReady()` if there no post link tasks to ensure binary is cached. Removed check for empty `mPostLinkSubTasks` before calling executable's wait, because same check already performed internally. The `waitForPostLinkTasks()` is not on hot path and does not require avoiding no-op method call. Bug: angleproject:8297 Change-Id: I2bd78c15231805cda4b62a9889287d8cf780cd1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5593928 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Takuto Ikuta 8a246e12 2024-06-04T10:11:07 Roll third_party/dawn/ 9a3d29c78..ff26bfbd4 (88 commits; 2 trivial rolls) https://dawn.googlesource.com/dawn.git/+log/9a3d29c786c6..ff26bfbd4920 $ git log 9a3d29c78..ff26bfbd4 --date=short --no-merges --format='%ad %ae %s' 2024-06-04 dawn-autoroll Roll ANGLE from 166858014f8c to d8c7c4be7320 (11 revisions) 2024-06-04 beaufort.francois dawn.node: Replace GPUAdapter requestAdapterInfo() with info 2024-06-03 penghuang d3d11: use D3D11_COPY_DISCARD for uploading content to textures 2024-06-03 jrprice [msl] Emit continuing inside a new block 2024-06-03 jrprice [msl] Move RenameConflicts to core and use it 2024-06-03 dawn-autoroll Roll Depot Tools from 840e538154a9 to 2a18f6d32454 (1 revision) 2024-06-03 cwallez Use windows_with_undefs.h everywhere in Dawn. 2024-06-03 dsinclair Update some OWNERS files. 2024-06-03 bsheedy Suppress CTS codecs failures 2024-06-03 lehoangquyen Dawn/vk: Implement input attachments in BindGroup. 2024-06-03 ynovikov Suppress Pixel 6 Android 14 failures already suppressed on Android T 2024-06-03 dawn-autoroll Roll vulkan-deps from 975bd14542a4 to a27561991332 (1 revision) 2024-06-03 jimblackler Kotlin versions of objects are AutoCloseable and Dawn *Release methods are called on close. 2024-06-03 jimblackler Add initial version of the Kotlin JNI conversion 2024-06-03 dawn-autoroll Roll ANGLE from 42a61f6e70c9 to 166858014f8c (1 revision) 2024-06-03 dsinclair Run the code formatter. 2024-06-02 dawn-autoroll Roll ANGLE from 1fa6c0208216 to 42a61f6e70c9 (1 revision) 2024-06-01 dawn-autoroll Roll Depot Tools from 3963cc6399e4 to 840e538154a9 (1 revision) 2024-06-01 dawn-autoroll Roll ANGLE from e3cba40e9a67 to 1fa6c0208216 (10 revisions) 2024-06-01 lokokung Roll reclient to 0.143.0.518e369 2024-05-31 dawn-autoroll Roll vulkan-deps from 4a0e77c7168d to 975bd14542a4 (2 revisions) 2024-05-31 dawn-autoroll Roll Depot Tools from 6427b94bc227 to 3963cc6399e4 (2 revisions) 2024-05-31 dawn-autoroll Roll ANGLE from 7b2c62128d44 to e3cba40e9a67 (9 revisions) 2024-05-31 lokokung [dawn][mock] Update ObjectBase::GetInstance to use device override. 2024-05-31 dsinclair Convert std::endl to newlines. 2024-05-31 jimblackler Complete the Kotlin bindings for ART Android Apps 2024-05-31 wong.kl.matthew dawn/node: Add documentation for ASan CMake builds. 2024-05-31 bclayton [tint][fuzz] Use renamer transform if running HLSL output through DXC 2024-05-31 jrprice [ir] Fix consecutive calls in dependency scanner 2024-05-31 arthursonzogni Roll partition_alloc and build dependencies. 2024-05-31 ynovikov Suppress Pixel 6 Android 14 failures already suppressed on Android T 2024-05-31 blundell [Tests] Add validation test of Device::GetAHardwareBufferProperties() 2024-05-31 dawn-autoroll Roll DirectX Shader Compiler from 3a78b6784928 to 978d36221dae (1 revision) 2024-05-31 dawn-autoroll Roll vulkan-deps from f666a6e01c85 to 4a0e77c7168d (4 revisions) 2024-05-31 lokokung [wgpu-headers] Introduce 2nd userdata to get compilation info callback. 2024-05-31 sokcevic [DEPS] Rely on buildtools recursedep to fetch clang-format 2024-05-31 dawn-autoroll Roll ANGLE from 9876d2ce1f0f to 7b2c62128d44 (5 revisions) 2024-05-31 bsheedy [tools][cts] Add results test coverage 2024-05-31 lehoangquyen Update DawnLoadResolveTexture's render pass compatibility spec 2024-05-31 dawn-autoroll Roll Depot Tools from da5e2f948a0e to 6427b94bc227 (3 revisions) 2024-05-31 dsinclair Update ir::builder includes. 2024-05-31 dawn-autoroll Roll SwiftShader from ec5dbd2dfb46 to 4bb94d6c235c (1 revision) 2024-05-30 dsinclair Cleanup some includes 2024-05-30 rharrison Add check for option to tint::glsl::writer::ASTFuzzer 2024-05-30 dsinclair Remove unused inferred template default parameter. 2024-05-30 jrprice [spirv] Fix terminator creation in MergeReturn 2024-05-30 jrprice Revert "[tools] Improvements to 'fuzz'" 2024-05-30 chouinard Remove passing matrix mul overflow expectations 2024-05-30 bclayton [tools] Improvements to 'fuzz' 2024-05-30 bclayton [tint][wgsl][fuzz] Add more to dictionary.txt 2024-05-30 kylechar Add trace events for Vulkan recording/submit 2024-05-30 dawn-autoroll Roll DirectX Shader Compiler from 128e6ce2be8f to 3a78b6784928 (1 revision) 2024-05-30 dawn-autoroll Roll vulkan-deps from 8f291de2f5be to f666a6e01c85 (2 revisions) 2024-05-30 ynovikov Suppress DrawIndexedTest.NegativeBaseVertex on ARM GLES 2024-05-30 jrprice [ir] Fix store target validation highlight 2024-05-30 jrprice [ir] Add RemoveTerminatorArgs transform 2024-05-30 dawn-autoroll Roll ANGLE from c82d910db718 to 9876d2ce1f0f (2 revisions) 2024-05-30 jrprice [tintd] Allow all extensions and features 2024-05-30 dawn-autoroll Roll Depot Tools from 84ef52b4df40 to da5e2f948a0e (8 revisions) 2024-05-30 sunnyps d3d: Delete unused ValidateTextureCanBeWrapped code 2024-05-30 bsheedy Add tools/src format check 2024-05-30 bsheedy Exclude Go dependencies from builders 2024-05-30 dawn-autoroll Roll vulkan-deps from 9fbe42f1f959 to 8f291de2f5be (6 revisions) 2024-05-30 kainino Make sure adapter info/properties tests actually test for UAF 2024-05-29 dawn-autoroll Roll ANGLE from 018188c73303 to c82d910db718 (4 revisions) 2024-05-29 bclayton [tint][resolver] Mark all short-circuited RHS expressions as not-evaluated 2024-05-29 dsinclair [glsl] Reorder GLSL transforms. 2024-05-29 hitawala [YCbCr Samplers] Add SampleTypeBit::External 2024-05-29 dneto Add 'fuzzer' option to build Tint fuzzers in CMake builds 2024-05-29 dawn-autoroll Roll Depot Tools from a85dcffff40e to 84ef52b4df40 (4 revisions) 2024-05-29 jrprice [ir] Fix Disassembly::EmitOperandList() with count 2024-05-29 jrprice [ir] Track BreakIf as a loop exit 2024-05-29 jrprice [ir] Validate loop body with params has initializer 2024-05-29 jrprice [spirv] Do not add exit phi for loop initializer 2024-05-29 jrprice [msl] Implement ShaderIO transform 2024-05-29 bclayton [tint][ir][spirv] Deduplicate storage textures with different accesses 2024-05-29 lehoangquyen Tint: Add support for input_attachment_index in inspector. 2024-05-29 cwallez Add wgpu::SurfaceCapabilities::usages 2024-05-29 senorblanco OpenGLES: baseVertex, baseInstance workaround. 2024-05-29 bclayton Revert "Remove stale WebGPU CTS expectations" 2024-05-29 blundell [Android] Add Device::GetAHardwareBufferProperties() 2024-05-29 beaufort.francois Add wgpuAdapterGetInfo 2024-05-29 dawn-autoroll Roll ANGLE from 0c87d0edb767 to 018188c73303 (12 revisions) 2024-05-29 dawn-autoroll Roll vulkan-deps from 9486d04e3ac1 to 9fbe42f1f959 (1 revision) 2024-05-29 rharrison Add missing bits of build support for libprotobuf-mutator 2024-05-29 dawn-autoroll Roll Depot Tools from 97246c4f73e6 to a85dcffff40e (1 revision) Created with: roll-dep third_party/dawn Bug: angleproject:341220050 Change-Id: I38cf4321d69879596bb9405da30c7f8e8f6669b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5595369 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Yuly Novikov 170851ff 2024-06-04T09:01:11 Revert "Vulkan: Defer texture data flush until data provided for all levels" This reverts commit 490c056a88a33870cb4ba2a7906b0a9688d96262. Reason for revert: breaks win-trace https://ci.chromium.org/ui/p/angle/builders/ci/win-trace/6014/overview Original change's description: > Vulkan: Defer texture data flush until data provided for all levels > > One of the major overhead with VkEvent is seeing with first frame where > all textures are being specified. The immutable textures, we always > immediately flush out the update as data provided for each level. This > means one VkEvent is created and SetEvent is called per level. This CL > delays the flush until data for all levels are provided, thus there is > only one flush per texture instead of per level. With this CL asphalt_9 > is no longer timeout on bots when VkEvent is enabled. > > There is also another benefit comes with this CL. On all desktop GPUs, > ASTC format texture are falling back to RGBA8. We always stage a clear > for the emulated format. That staged clear are able to be removed if > data is provided later. Because of we flush out staged update when first > level data is provided, all staged clear for the subsequent levels are > also gets flushed out, losing the chance to be removed. This CL will > allow all staged clears being removed. > > Bug: b/343976993 > Bug: b/336844257 > Change-Id: Ica731ea57db771b16966f4da92ccdc551ae93d81 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588816 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: b/343976993 Bug: b/336844257 Change-Id: I25854b855334c4cac1c2b40467d8e2ecb7661b8f No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5593935 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Matthew Denton af72bf7f 2024-05-24T15:00:44 ESSL -> WGSL: emit basic types This emits dimensionless types (no vectors, matrices, arrays). Function signatures will emit their return type (assuming it is dimensionless). Bug: angleproject:42267100 Change-Id: I0d2479f71408eb20b9c329a99c70a6bf6426a72f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5590384 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll cb118080 2024-06-03T21:50:11 Manual roll vulkan-deps from 6e8f93674ed4 to 356a05c8a553 (1 revision) Manual roll requested by cnorthrop@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/6e8f93674ed4..356a05c8a553 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8623 Tbr: syoussefi@google.com,cnorthrop@google.com Change-Id: Ifda8f2e5b0f45b6d00fdc925f82dcc39b71bd239 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594284 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 490c056a 2024-05-31T11:36:32 Vulkan: Defer texture data flush until data provided for all levels One of the major overhead with VkEvent is seeing with first frame where all textures are being specified. The immutable textures, we always immediately flush out the update as data provided for each level. This means one VkEvent is created and SetEvent is called per level. This CL delays the flush until data for all levels are provided, thus there is only one flush per texture instead of per level. With this CL asphalt_9 is no longer timeout on bots when VkEvent is enabled. There is also another benefit comes with this CL. On all desktop GPUs, ASTC format texture are falling back to RGBA8. We always stage a clear for the emulated format. That staged clear are able to be removed if data is provided later. Because of we flush out staged update when first level data is provided, all staged clear for the subsequent levels are also gets flushed out, losing the chance to be removed. This CL will allow all staged clears being removed. Bug: b/343976993 Bug: b/336844257 Change-Id: Ica731ea57db771b16966f4da92ccdc551ae93d81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588816 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll d8c7c4be 2024-06-03T20:16:36 Manual roll VK-GL-CTS from fd5cc7b1e075 to d2d6aa656073 (30 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fd5cc7b1e075..d2d6aa656073 2024-05-31 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-31 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-31 javed@igalia.com Add coverage for image load/store of depth formats 2024-05-31 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-30 marcin.zajac@mobica.com Video capabilities EXT to KHR 2024-05-30 michal.jakubek@mobica.com Coverage for Ldexp, Frexp and Atan2 with subnormal floats 2024-05-30 spatibandlla@nvidia.com Components: Framework - Add native support for QNX Screen 2024-05-30 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (transform_feedback2_states), PART 7 2024-05-30 kamil.goras@mobica.com Split KHR-GL4x.texture_swizzle.smoke and KHR-GL4x.texture_swizzle.functional test 2024-05-30 kamil.goras@mobica.com Split KHR-GL4x.copy_image.functional test 2024-05-30 piotr.byszewski@mobica.com Add self-dependency to resolve_image tests 2024-05-30 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-29 yuxinhu@google.com Fix missing Android build dependencies 2024-05-29 yuxinhu@google.com Fix a wrong class type in tcuTestLogParserJNI 2024-05-29 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-29 erik.faye-lund@collabora.com Update tests to cover BGRA8 formats 2024-05-24 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-24 boris.zanin@amd.com Additional testing for fp16 immediate/inline arguments 2024-05-24 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-24 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-24 david.heidelberg@collabora.com Correct EGL_EXT_config_select_group extension query 2024-05-24 cturner@igalia.com Check transfer queue image granularity requirements 2024-05-24 c.hambacher@samsung.com Fix bind_buffers_2 tests using out-of-bounds vertices for non-maint5 2024-05-24 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-17 syoussefi@google.com main: Run clang-format + remove de* types If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ib728f0df93a6cc8bf16bba4f24312bed5cc184a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594575 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7113795e 2024-06-03T20:26:15 Manual roll vulkan-deps from d4f7e6e954db to 6e8f93674ed4 (19 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/d4f7e6e954db..6e8f93674ed4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2b19bf7e1bc0b60cf2fe9d33e5ba6b37dfc1cc83..0e311906b92f8cc74eab258260343074b00a9710 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/49a1fceb9b1d087f3c25ad5ec077bb0e46231297..ff2afc3afc48dff4eec2a10f0212402a80708e38 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/77c40bece1b8b441eee432fc9d74efbf985f777f..4a2e0c9b3663d1bacc91821ae5699965bff4e5e9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/5677bafb820e476441e9e1f745371b72133407d3..192d051db3382e213f8bd9d8048fc9eaa78ed6ab https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e15fdd01eff029f2bf15e63970f2a7cebf2999b0..5b71c4be018cfd7951f3618defeb3c4cbf9603e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I403fdea8d5582d7fd5c862a7daab9c5774df0977 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594279 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao f1f277fc 2024-06-03T10:26:30 Test: Fix crash in MultithreadingTestES3.SimultaneousBufferBind The bug here is that thread0 stopped between nextStep(Step::Thread0Ready) and waitForStep(Step::Thread1Ready)), and then the thread 1 could run all the way to finish. Now when thread 0 wake up and resumes again, waitForStep will hit assertion. This CL let thread 1 wait for thread 0 to finish to avoid getting into this situation. Bug: b/344053420 Change-Id: Ib75e6652feff55e7bb561cc284cdcb86a4852881 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5587993 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Solti 62cdd74a 2024-05-29T19:27:02 Prepare deqp_support files for the removal of de* types - The de* types were removed by the change: https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+/1a09796462f70cfe2a6117f9bc6af6e3ef74e6ff - This CL updates ANGLE accordingly. The change is generated by: https://paste.googleplex.com/4847290045169664 - Reference: https://github.com/KhronosGroup/VK-GL-CTS/blob/aefd5c09cacdb5a3320da717af6ec646d96c2379/format_all.sh#L17-L41 Notes: - starting in patchset #10, the CL de-coulples the deqp_support updates from the VK-GL-CTS DEPS advance. Test: presubmit, and the problematic files mentioned in http://b/343202259#comment3 are updated. Bug: b/343202259 Change-Id: Idc374fa0873e9ddaafe4c9f861995952f2f5e7e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5580985 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Solti Ho <solti@google.com>
Solti 9ca4c0df 2024-05-31T23:08:26 Manual roll vulkan-deps from f7e762742da9 to d4f7e6e954db (1 revision) Manual roll requested by solti@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/f7e762742da9..d4f7e6e954db Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ff56cf67d3494eec1243cc4225d1667e9b3f90cd..e15fdd01eff029f2bf15e63970f2a7cebf2999b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Note: - in addition to the DEPS, this CL suppresses the VVL error. Bug: angleproject:344031874 Bug: b/343202259 Change-Id: I145d09821ba1ae4adbefcf151d3a852f00c3f950 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5587991 Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao a87ca02c 2024-05-31T11:18:52 Vulkan: change shouldUpdateBeStaged to shouldUpdateBeFlushed All usage of shouldUpdateBeStaged() is actually a negate if(!shouldUpdateBeStaged(...)) {doFlush();}. This CL changes shouldUpdateBeStaged to shouldUpdateBeFlushed to make it easier to read. The other change is that there is a distinction of a texture update must be flushed and update prefer to be flushed. So shouldUpdateBeStaged() logic has been split into two functions updateMustBeStaged and updateMustBeFlushed. shouldUpdateBeFlushed simply because it is either must be flushed or not mustBeStaged (proactively flush for performance reason). This CL is also a preparation for next CL. No actual behavior change is expected here. Bug: b/343976993 Change-Id: Icd9f57f43b6fb5761e9845cc6f27f9458073f905 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588815 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Yuly Novikov 63ae42fc 2024-06-03T16:15:16 Skip end2end test on Linux Intel Vulkan GLSLTest_ES31.TernaryOnStructsInDifferentBlockStorages new test added in http://crrev.com/c/5570154 fails on Mesa 23.2.1 Bug: angleproject:342316794 Change-Id: I73ab54837643bf4b51c68b747439b85e887c2bc8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5593929 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Roman Lavrov c8db5292 2024-05-31T19:35:32 Remove locks from most glUniform* calls Note: only the Vulkan backend claims to be thread safe. glUniform1i and glUniform1iv are kept locked as they might set samplers, which is more complicated. glUniformBlockBinding is a more complex state change with notifications. Other glUniform functions simply call setUniformImpl() or setUniformMatrixfv() in the vulkan backend, which as https://crrev.com/c/5588853 and https://crrev.com/c/5592968 show only update mDefaultUniformBlocks and mDefaultUniformBlocksDirty. This should be thread-safe as long as the application is not creating race conditions itself such as by changing the same object in parallel. This should yield a significant improvement in the driver_overhead_2 benchmark which is heavy on such calls. Bug: angleproject:8666 Bug: b/335295728 Change-Id: Iad1577b9ab2eb57b6a4599ec6d70fa90eb518e8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588385 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov ce2bc8e8 2024-05-31T17:29:24 Docs: Add a little guide for repro'ing failures on bots Bug: angleproject:344019996 Change-Id: I89168b1ebdd62d2ac5775c300faeda6a8c06a0a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5587906 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Takuto Ikuta 3b29b2cb 2024-06-03T15:35:54 doc: remove references to goma goma is not maintained anymore. Bug: angleproject:341220050 Change-Id: I0e0c9f9066498a65e77d187dfa0c6d9230de773b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588006 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 5e66f6e4 2024-06-03T09:27:44 Vulkan: Make setUniformMatrixfv a free function Same as https://crrev.com/c/5588853 but for matrices const gl::ProgramExecutable and non-const output variables, makes it clear that it only updates: mDefaultUniformBlocks mDefaultUniformBlocksDirty Bug: angleproject:8666 Bug: b/335295728 Change-Id: Ie5a5d527bf314309860fc7ca193c2a32013e7872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5592968 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 16685801 2024-06-03T07:01:02 Roll Chromium from 190dbcca7b39 to bf81256137c8 (690 revisions) https://chromium.googlesource.com/chromium/src.git/+log/190dbcca7b39..bf81256137c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5b8c05aed0..8b9a3d06ef * buildtools/linux64: git_revision:d010969ecc312c4c9512d4b4987b2589087df01a..git_revision:4fb095d3f70f624c73bfdd156c5179fad535287d * buildtools/mac: git_revision:d010969ecc312c4c9512d4b4987b2589087df01a..git_revision:4fb095d3f70f624c73bfdd156c5179fad535287d * buildtools/win: git_revision:d010969ecc312c4c9512d4b4987b2589087df01a..git_revision:4fb095d3f70f624c73bfdd156c5179fad535287d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4b8b9d2f22..d228592459 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4ffc88de80..7adb32fd7a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6427b94bc2..840e538154 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/5f2c9767ce..c5d2b1886c * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/a16d528d25..ab43b1d3c9 * third_party/siso: git_revision:3c4edd7ed1f9902bb0e422b2257a42600edd3ce5..git_revision:14cdeef66cab719c7c63c95894ce443288d020f4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/557b28f80d..586ee04637 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a900142d91..f10c7204c8 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Icc61e1d3b6802782c2254c638e40b2a1f2565daa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5591561 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yiwei Zhang 42a61f6e 2024-06-01T23:25:39 Vulkan: no longer need isVenus condition All things needed by Venus have been upstreamed or gated behind the actual hw driver backend. Bug: None Test: build Change-Id: I5cec111aaeac5cc5cef05e199653489ee6dffc2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5591469 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 1fa6c020 2024-05-28T14:44:09 Vulkan: Add multisample line width query support * As part of GLES 3.2 support, added support to query the following through glGetFloatv(): * GL_MULTISAMPLE_LINE_WIDTH_GRANULARITY * GL_MULTISAMPLE_LINE_WIDTH_RANGE * Added some tests to check the limits of the values above. * Updated comment regarding ES 3.2 spec table number. Bug: angleproject:42266081 Bug: b/336860504 Change-Id: I2c359bbb9003b3e76f342f7419477bdb1caaf88f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5576760 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi d353f2ce 2024-05-31T16:57:41 Vulkan: Check any robustness instead of EXT only * Updated checks for robustnessEXT with robustnessAny(), which also includes robustnessKHR. Bug: angleproject:42262244 Change-Id: Ia79bc7f1a5ead29417eec0a5663b70d79c34ad56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5587992 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi ddd93740 2024-05-16T15:49:47 Vulkan: Extend GLES 3.2 extension requirements * Added CanSupportGLES32() to extend the extension requirements for GLES 3.2. * The following function returns the extension list: * GetRequiredGLES32ExtensionList() * If any required feature is not supported, we must fall back to GLES 3.1 (unless exposeNonConformantExtensionsAndVersions is enabled). * Added LogMissingExtensionsForGLES32() to log any missing extension that is required for GLES 3.2. * (Currently, if xfb extension is not supported and cannot be emulated, we fall back to GLES 2.0.) * (KHR_debug by default is marked as a supported extension in the frontend. Therefore it is not added to the check.) * In generateSupportedExtensions() * CanSupportGPUShader5EXT() is now private to vk_cap_utils.cpp. * Before checking if the max GLES version should be capped, we make sure that the caps are initialized. Bug: angleproject:42263905 Bug: b/336860504 Change-Id: Ib5d85df310c6ec7df6258d3ea430f9c365153fb1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5544455 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 1db5581d 2024-05-21T13:07:44 Implement KHR_robustness * Added implementation for the validation layers for the added functions, and updated some of the existing ones. * The core functions require GLES 3.2. * The KHR functions have been limited to GLES 2.0+. * KHR_robustness requires GLES 2.0 and removes support for GLES 1.1 for logistical reasons. * Some functions require GLES 3.0 with this extension, which become core in GLES 3.2. * glGetnUniformuivKHR() * Enabled robustnessKHR on several platforms. * Added unit tests similar to ContextLostTest.BasicUsage for the new cases. * Added ContextLostTestES32 for the core usage in GLES 3.2. Bug: angleproject:42262244 Change-Id: Id1425c39d9a1a66ae1a90048b673cb1ae391c0ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5555985 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi ce6232fc 2024-05-21T11:15:51 Add KHR_robustness * From the spec, there are some differences between KHR_robustness and EXT_robustness (already in use). In this CL, the following are addressed: * Updating the EXT suffixes * Changing EXT to KHR for GLES * Removing EXT for GL * Adding GLGetnUniformuivKHR (no equivalent in EXT) * Added GL_KHR_robustness to the list of extensions. * The API implementations seem to be already in place. * Validation functions will be updated in a follow-up CL. Bug: angleproject:42262244 Change-Id: Ibbc1bc11ec08ac756f4a03d11f51ba1268d037a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5555984 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 9137d9a9 2024-05-31T12:28:04 Vulkan: Make setUniformImpl a free function const gl::ProgramExecutable and non-const output variables, makes it clear that it only updates: mDefaultUniformBlocks mDefaultUniformBlocksDirty Bug: angleproject:8666 Bug: b/335295728 Change-Id: I8851eb500c3e09e896d02c0f83b700cde2a1bbf1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588853 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Matthew Denton d68395fe 2024-05-24T15:14:46 ESSL->WGSL: Emit basic function signatures ...signatures don't yet include types or parameters. See WGSLOutput_test.cpp for a sample translation. Bug: angleproject:8662 Change-Id: I93273156f72ba193441e737074bd1a8a054f2ea9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5582949 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org>
Matthew Denton e0541f1a 2024-05-29T11:36:56 Add skeleton traverser for outputting WGSL Bug: angleproject:8662 Change-Id: I0d917c65692eb0f137c7e751f65f16312a4625f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5581744 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 0cbc0fe4 2024-05-30T00:00:00 Add IncompatibleTexture end2end tests Bug: angleproject:343922404 Change-Id: Ic96cc1e2493454844ef65ec799e1aba221d9f084 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5589245 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 0508fc9b 2024-04-23T15:32:52 Reland "Cleanup: replace DirtyObjectType check with constexpr generator" Avoid using lambdas with member function pointers which caused issues on MSVC C++17. This is a reland of commit 89caa0e1d99e45f3d6f355f6e14c147f8de3e0e5 Original change's description: > Cleanup: replace DirtyObjectType check with constexpr generator > > Static assert was meant to avoid kDirtyObjectHandlers getting out of > sync, but it doesn't achieve that goal as it's just comparing values > with ints which is confusing. > > Replacing with constexpr generated std::array. C++20 allows to easily > validate that all values are set by _not_ default-initializing > `handlers`. C++17 makes it trickier, addeded static_assert on an > additional static constexpr bool (silly but I can't find a more concise > way) > > Bug: angleproject:8666 > Bug: b/335295728 > Change-Id: Idf9bbd087d09d5ba253a7587ce0503cae3fcf3a7 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5478231 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Roman Lavrov <romanl@google.com> Bug: angleproject:8666 Bug: b/335295728 Change-Id: I62e66b700512e072ef10cc57a17e8837a534c0d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5589285 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Caggiano e3cba40e 2024-04-30T17:47:36 gn: Add install target Define an install_target GN template which installs include directories and a predefined list of libraries to a given prefix. The template is taking advantage of an install_target.py script which generates package config files for every named target. Bug: angleproject:8110 Change-Id: I6deb40fe9c54f11da7caf4fb5df59d3ce522df29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5553797 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Antonio Caggiano <quic_acaggian@quicinc.com>
Geoff Lang 7ce42b42 2024-05-30T16:08:12 Skip Display::prepareForCall calls everywhere except Mac. Display::prepareForCall was added for CGL and EAGL backends which need to know when an EGL call on a new thread is about to happen. Making this virtual call on all EGL calls on all platforms adds overhead which we can avoid so compile out prepareForCall everywhere except Mac. Bug: angleproject:8434 Change-Id: I7b50463ed405a73eb993e18eb4f83434b4a4fd6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5582015 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 0e892a02 2024-05-30T14:07:47 EGL: Move egl surface timing calls into tail calls. eglGetCompositorTimingANDROID and eglGetFrameTimestampsANDROID can both take a lot of driver time to execute proportional to ANGLE's overhead. Bug: angleproject:42266858 Change-Id: I9b991f74a261b45aeb2aaf133fca7d22cabc41f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5580877 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 11c92f77 2024-03-29T16:19:05 Vulkan: Optimize ProgramExecutable::shouldIgnoreUniform() Increases GFX Bench offscreen driver overhead performance on Samsung S24 S921B (locked frequencies) 6201 -> 6327 frames (+2%) Regression commit: Fix off-by-one bounds check on uniform location. fba482b7107ccf3e178f6bf56b6b0285407ace3a Bug: chromium:1504162 Bug: chromium:1484878 Change-Id: I164cbb9feeacd35979cc60aa3489252397a3e2bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5585896 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 5a549dae 2024-05-31T10:01:25 Roll SwiftShader from ec5dbd2dfb46 to 4bb94d6c235c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ec5dbd2dfb46..4bb94d6c235c 2024-05-30 kelsenliu21@gmail.com Fix incorrect macro definition in rc file If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I212d2b0e46fedc5afdeb6189415ab37aaeb374a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5587961 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c61ea2db 2024-05-31T08:16:26 Roll Chromium from 514da917ca32 to 190dbcca7b39 (623 revisions) https://chromium.googlesource.com/chromium/src.git/+log/514da917ca32..190dbcca7b39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/007a74bf79..5b8c05aed0 * buildtools/linux64: git_revision:e11af6727dd38fdd0e8cbbab2e207c369522ac7a..git_revision:d010969ecc312c4c9512d4b4987b2589087df01a * buildtools/mac: git_revision:e11af6727dd38fdd0e8cbbab2e207c369522ac7a..git_revision:d010969ecc312c4c9512d4b4987b2589087df01a * buildtools/win: git_revision:e11af6727dd38fdd0e8cbbab2e207c369522ac7a..git_revision:d010969ecc312c4c9512d4b4987b2589087df01a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/22df32c685..4b8b9d2f22 * third_party/android_build_tools/lint: 802fuDf2tCI5HIcMNx1jWJbsTrLt2DS5z8BuFE_Sx7cC..UTwAxkXgodrL9GZEkxLVNaKg7p14YVDh8SrgP4TnOXcC * third_party/android_build_tools/manifest_merger: EBQZXvDztclHzavY9ulEJA3r4mn0PmbIMeKYKnzhEoEC..NhxjXSeTx7oy0a_3ilG0QjFMO8YItXf67EW20A_stP8C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6ef56f2347..4ffc88de80 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/da5e2f948a..6427b94bc2 * third_party/fuchsia-sdk/sdk: version:20.20240522.3.1..version:20.20240529.4.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7d6eb60255..557b28f80d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/01344b3187..a900142d91 No update to Clang. Bug: angleproject:8434 Tbr: solti@google.com Change-Id: I1f2f777d32ac666a5404e99101d3eb39291a7f50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5587306 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Scott Marcy 4ebb28d7 2024-05-30T11:36:58 Fix stack overflow crash by traversing a too-deep AST This simply moves the check for a too-deep AST before the first attempts to traverse the AST (i.e., `validateAST()`). Bug: angleproject:343505104 Change-Id: Iafb658a30f74a666beab8c69745ca53d17d70dd3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5585186 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Scott M <mscott@apple.com>
Josip Sokcevic f4bacd79 2024-05-31T01:58:50 [DEPS] Rely on buildtools recursedep to fetch clang-format buildtools has first party support to fetch clang-format so no longer needed to use custom hooks. Bug: chromium:336843583 Change-Id: I6464baad7ab7269768c8065b5ce61167cb864b1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5585281 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 67036978 2024-05-30T00:00:00 Update Intel PCI IDs Synced with Mesa headers: * Changed one EHL PCI ID * Changed four ADL PCI IDs * Added six more RPL PCI IDs Fixed: angleproject:343037865 Change-Id: I5218c94265e33bb640e2c3109ce62e93255e8d28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5580878 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7b2c6212 2024-05-30T17:18:52 Manual roll vulkan-deps from 1c35ddaeefd9 to f7e762742da9 (1 revision) Manual roll requested by solti@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/1c35ddaeefd9..f7e762742da9 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3b35db58df3ab871753981b4b5b6a2101716a869..ff56cf67d3494eec1243cc4225d1667e9b3f90cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I8901abbc477fbd0a0ea006c551ab183f02d12312 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5584578 Commit-Queue: Solti Ho <solti@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Le Hoang Quyen 4d4c99b1 2024-05-31T02:07:11 Metal: skip copying via parentTexture on iOS simulator. iOS simulator has bug in [MTLTexture parentRelativeSlice] so don't use it to upload data to the texture. Bug: angleproject:343734719 Change-Id: I78cf0066c1120c04f9b62c30e280ad866c2096d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5584042 Reviewed-by: Kenneth Russell <kbr@chromium.org> Auto-Submit: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Roman Lavrov 818915a9 2024-05-27T10:53:35 PPO: Propagate dirty uniforms via mPPOProgramExecutables This eliminates the need for ProgramUniformUpdated notification Update mDefaultUniformBlocksDirty rather than just add a check to hasDirtyUniforms, as mDefaultUniformBlocksDirty can then be used elsewhere (for example, calcUniformUpdateRequiredSpace) Also adds ProgramExecutable.mIsPPO flag for an easy check for PPO without inspecting mPPOProgramExecutables Bug: angleproject:8666 Bug: b/335295728 Change-Id: I7725d02460104997df5c89a54d0e5ef3c3079946 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5569184 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Erik Staab 22790eaf 2024-05-30T04:26:16 Add gardener_rotations property This is a temporary measure to allow SoM to update their code before we can remove the sheriff_rotations property. Bug: chromium:343503161 Change-Id: I461db50f09e6946ceb6244199208935d38a99598 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5580852 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi c33c6cd3 2024-05-27T00:06:18 Vulkan: Use OpSelect with all types with SPIR-V 1.4 SPIR-V 1.4 relaxes the types that can be used as arguments of OpSelect. Previously, the types were limited to scalars and vectors, but since SPIR-V 1.4, it's unrestricted. Writing tests for this change, another bug was discovered where support for structs and arrays with the ternary operator was disabled due to ESSL 1.0, even though that support is mandatory in ESSL 3.2. Bug: angleproject:342316794 Bug: angleproject:343218491 Bug: angleproject:3830 Change-Id: I6cff2f8178634369f773c4fb16a1ddde96928c8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5570154 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 9876d2ce 2024-05-30T07:00:48 Roll Chromium from 40e780119c08 to 514da917ca32 (624 revisions) https://chromium.googlesource.com/chromium/src.git/+log/40e780119c08..514da917ca32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/32eb067e80..007a74bf79 * buildtools/linux64: git_revision:df98b86690c83b81aedc909ded18857296406159..git_revision:e11af6727dd38fdd0e8cbbab2e207c369522ac7a * buildtools/mac: git_revision:df98b86690c83b81aedc909ded18857296406159..git_revision:e11af6727dd38fdd0e8cbbab2e207c369522ac7a * buildtools/win: git_revision:df98b86690c83b81aedc909ded18857296406159..git_revision:e11af6727dd38fdd0e8cbbab2e207c369522ac7a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/23386c603b..22df32c685 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b027bd3c0b..30d4d21846 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/24a969aef2..6ef56f2347 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/67896a0860..da5e2f948a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3754abfc6f..cececb2a6b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e09506d068..01344b3187 * tools/skia_goldctl/linux: _Ncs9Mfd7zCjjNFYk88XronnAaJuEuYMI1m8uFEgUgUC..DwebaDF4oPSZMck-atrwghRPzS584hU4SE0VMntP4sEC * tools/skia_goldctl/mac_amd64: uhEwv_RChtvOXUbLV4vbOH--bfXc80Wt3oqpvX7l05cC..K1iF08dyALEazf18lHRmK7k-tvRErDRGAVS3JHxHcbsC * tools/skia_goldctl/mac_arm64: l3G1R_7kNvuMM6opTzPqlBgPYf04UfVcQrfHtFfwPfMC..ms8v9LYso2x5_PGXcrV6Jf6ZW_9JYX0yFyJnqB0VrkMC * tools/skia_goldctl/win: 7_CWayNfX49-C69e9--i60DGVTOr01SqQgSsRc4IdZUC..-t8nUSs-QQ1RnwaD9oWH-_3W-avC2ugb8y29Og6Sq1YC No update to Clang. Bug: angleproject:8434 Tbr: solti@google.com Change-Id: I7e58313a7c5328466008fb876f25085b32907d6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5583908 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 34b832a3 2024-05-24T13:38:58 Vulkan: Add RefCountedEvent recycler Previously the recycler was disabled due to race between resetEvent and setEvent. This CL splits mFreeStack into two list: mEventsToReset and mEventsToReuse. Events are first added to mEventsToReset list. Then at OutsideRenderPassCommandBufferHelper::flushToPrimary time, VkCmdResetEvents are added to reset all events in mEventsToReset list, and that reset operation is tracked by mResettingQueue. When reset command is completed, events moved into mEventsToReuse list. Since access to renderer's RefCountedEventRecycler requires lock, RefCountedEventCollector (a queue of events) is passed between ShareGroupVk and renderer's recycler to minimize the locked access. Bug: b/336844257 Change-Id: Iffac095729a81ba65a43df68cc9255d76e4be7c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5576757 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Ho Cheung c82d910d 2024-05-29T09:35:12 Roll third_party/dawn/ d32858a30..9a3d29c78 (252 commits; 2 trivial rolls) https://dawn.googlesource.com/dawn.git/+log/d32858a3045a..9a3d29c786c6 $ git log d32858a30..9a3d29c78 --date=short --no-merges --format='%ad %ae %s' 2024-05-29 bclayton [tint][docs] Begin documentation for the fuzzers 2024-05-29 cwallez Remove unused "shared texture memory vk image descriptor" 2024-05-29 bsheedy [tools][cts] Add GetRawResults test coverage 2024-05-29 jiawei.shao Tint: Add `dual_source_blending` as a valid WGSL extension 2024-05-29 lehoangquyen Tint: Add input attachments support to spirv AST printer. 2024-05-28 lehoangquyen Tint: Add input attachments support to spirv IR printer. 2024-05-28 enga Check that VkInstance is not null after creation 2024-05-28 lehoangquyen Tint: Add inputAttachmentLoad to core.def, wgsl.def, IR 2024-05-28 jrprice [msl] Populate Output::workgroup_allocations 2024-05-28 lehoangquyen WaitAnySystemEvent: retry poll if errno=EAGAIN or EINTR. 2024-05-28 dawn-autoroll Roll ANGLE from a3057eed0f86 to 0c87d0edb767 (3 revisions) 2024-05-28 bclayton [tint][ast][msl] Remove the need for SingleEntryPoint to be run 2024-05-28 dneto Fix misc-include-cleaner warnings from clang-tidy 2024-05-28 bclayton [tint][ir] Validate compute entry point has workgroup_size 2024-05-28 bclayton [tint][ast][msl] Skip the MSL fuzzer if the program has multiple entry points 2024-05-28 dawn-autoroll Roll ANGLE from 1a8546ad512d to a3057eed0f86 (7 revisions) 2024-05-28 jiawei.shao Tint: Check if location is too large in TruncateInterstageVariables 2024-05-28 jrprice [ir] Remove abstract types from disassembler 2024-05-28 dawn-autoroll Roll Depot Tools from 8a11c2d152e9 to 97246c4f73e6 (1 revision) 2024-05-28 rharrison Update top-level OWNERS to reflect team changes 2024-05-27 rharrison [cmake] Add build rules for libprotobuf-mutator 2024-05-27 bclayton [tint][ir] Fix unused variable warnings 2024-05-27 bclayton [DEPS] Add libprotobuf-mutator as a new dependency 2024-05-27 bclayton [tint][proto] Pass correct flags to protoc for imports 2024-05-27 bclayton [tint][ir] Use Operand() instead of indexing operands_ directly 2024-05-27 jrprice [msl] Move printer/*_test.* to writer/ 2024-05-27 jrprice [tint] Do not use AInt for attribute arguments 2024-05-27 jrprice [msl] Support workgroup vars in ModuleScopeVars 2024-05-27 dawn-autoroll Roll vulkan-deps from feb3ce48e509 to 9486d04e3ac1 (9 revisions) 2024-05-27 jrprice Add chouinard@google.com to Tint OWNERS 2024-05-27 dawn-autoroll Manual roll vulkan-deps from 48e47a7bb90c to feb3ce48e509 (32 revisions) 2024-05-27 dawn-autoroll Roll ANGLE from 59adc1910597 to 1a8546ad512d (1 revision) 2024-05-27 beaufort.francois Set surfaceConfiguration alphaMode default value to auto 2024-05-27 dawn-autoroll Roll Depot Tools from 7d95eb2eb054 to 8a11c2d152e9 (2 revisions) 2024-05-27 zhaoming.jiang Tint: consider subgroup_size used in compute stage as uniform 2024-05-26 dawn-autoroll Roll ANGLE from 6cf3c96db2dc to 59adc1910597 (1 revision) 2024-05-25 dawn-autoroll Roll ANGLE from ad46d67dbcd5 to 6cf3c96db2dc (1 revision) 2024-05-25 bclayton [tint] Mark operator bool() as explicit 2024-05-25 dawn-autoroll Roll Depot Tools from 09c232e7c0d5 to 7d95eb2eb054 (1 revision) 2024-05-25 dawn-autoroll Roll DirectX Shader Compiler from cdc56031b562 to 128e6ce2be8f (1 revision) 2024-05-25 chrome-automated-expectation Remove stale WebGPU CTS expectations 2024-05-25 bsheedy Add cmake/msvc exclusion filters 2024-05-25 dawn-autoroll Roll ANGLE from 066cde8b1259 to ad46d67dbcd5 (9 revisions) 2024-05-24 bsheedy Suppress volteer WebGPU CTS failures 2024-05-24 bclayton [tint][ir] Add error handling to the binary decoder 2024-05-24 lehoangquyen Tint: parse @input_attachment_index 2024-05-24 dawn-autoroll Roll SwiftShader from 90519141a709 to ec5dbd2dfb46 (1 revision) 2024-05-24 bsheedy [tools][cts] Switch CTS roller to use BigQuery 2024-05-24 bsheedy Add Linux/Intel experimental expectation 2024-05-24 dawn-autoroll Manual roll vulkan-deps from e25f9bb7a149 to 48e47a7bb90c (10 revisions) (...) 2024-05-15 lokokung [wgpu-headers] Introduce 2nd userdata to popErrorScope callback. 2024-05-15 rharrison Add expectations for failing tests on Dawn -> Chromium rolls 2024-05-15 enga Use the max signaled value of pending fences in BeginAccess 2024-05-14 dawn-autoroll Roll DirectX Shader Compiler from f9389db7c34d to 8fe99be640a1 (5 revisions) 2024-05-14 jrprice [msl] const-qualify many things in printer 2024-05-14 bclayton [tint][ast] Fix DirectVariableAccess with uncalled function ptr params 2024-05-14 chrome-branch-day Activate dawn M126 2024-05-14 dawn-autoroll Roll Depot Tools from c5e2ceabe3f0 to 84798693112c (8 revisions) 2024-05-14 lehoangquyen Add MultisampleStateExpandResolveTextureDawn chained struct. 2024-05-14 dawn-autoroll Roll vulkan-deps from af34cd975650 to e25f9bb7a149 (5 revisions) 2024-05-14 cwallez Remove ASSERT that encoding only produces validation errors 2024-05-14 dawn-autoroll Roll ANGLE from decf0e9d4297 to df2e7bd7c99e (8 revisions) 2024-05-14 dsinclair Fixup doxygen issues 2024-05-14 dawn-autoroll Roll DirectX Shader Compiler from f6d175959760 to f9389db7c34d (1 revision) 2024-05-14 senorblanco OpenGL: fix spurious EGLSync on queue destruction. 2024-05-14 jiawei.shao Revert "Remove mock WGPU[Obj]Release that was deprecated in favor of AddRef" 2024-05-14 bclayton [tint][ast] Fix RemovePhonies transform with short-circuited fn call 2024-05-14 bclayton [tint][ir] Split BreakIf arguments into two lists 2024-05-14 bclayton [tint][resolver] Fix evaluation stage of function calls 2024-05-14 penghuang Revert "Remove deprecated `APIReference()`" 2024-05-14 dawn-autoroll Roll Depot Tools from e1385296c4ab to c5e2ceabe3f0 (1 revision) 2024-05-13 enga Break Instance->Backend->PhysicalDevice->Instance refcycle 2024-05-13 dawn-autoroll Roll vulkan-deps from a06b82c306ee to af34cd975650 (7 revisions) 2024-05-13 hocheung Reland "(3/N) Rename WGPUDeviceLostReason_Undefined to Unknown" 2024-05-13 bclayton [tint][ir] Validate NextIteration instructions 2024-05-13 bclayton [tint][ir] Validate continue statements 2024-05-13 cwallez Remove mock WGPU[Obj]Release that was deprecated in favor of AddRef 2024-05-13 cwallez Move metal::PhysicalDevice to its own file. 2024-05-13 blundell [YCbCr] Add YCbCr info to STMProperties 2024-05-13 bclayton [tools][run-cts] Improve error diagnostics when npx is not found 2024-05-13 dawn-autoroll Roll ANGLE from 4e887491e14a to decf0e9d4297 (1 revision) 2024-05-13 keishi [BRP] Un-rewrite raw_ptr used in MotionMark 2024-05-13 dawn-autoroll Roll DirectX Shader Compiler from 01007bcd7f95 to f6d175959760 (1 revision) 2024-05-13 dawn-autoroll Roll Depot Tools from a9b9284faf89 to e1385296c4ab (1 revision) 2024-05-13 jie.a.chen Remove ExternalImageDXGI 2024-05-13 dawn-autoroll Roll vulkan-deps from 862e523d9e3d to a06b82c306ee (1 revision) 2024-05-13 jiawei.shao Remove deprecated `APIReference()` 2024-05-12 dawn-autoroll Roll ANGLE from d1bb6ed8399d to 4e887491e14a (3 revisions) 2024-05-11 ynovikov Suppress Pixel 6 Android 14 failures already suppressed on Android T 2024-05-11 dawn-autoroll Roll vulkan-deps from 3317f9533df9 to 862e523d9e3d (1 revision) 2024-05-11 dawn-autoroll Roll Depot Tools from a76c50e296ea to a9b9284faf89 (1 revision) 2024-05-11 dawn-autoroll Roll ANGLE from 8d23fa3f92ed to d1bb6ed8399d (1 revision) 2024-05-11 dawn-autoroll Roll DirectX Shader Compiler from 8e9cefa1d507 to 01007bcd7f95 (1 revision) 2024-05-11 chrome-automated-expectation Remove stale WebGPU CTS expectations 2024-05-11 penghuang d3d11: SharedTextureMemoryD3D11Texture2D supports texture array 2024-05-11 dawn-autoroll Roll vulkan-deps from 4a16c5226357 to 3317f9533df9 (4 revisions) 2024-05-11 dawn-autoroll Roll Depot Tools from 6e32e926e9de to a76c50e296ea (3 revisions) 2024-05-10 enga Fix SharedResourceMemory begin/end access without using texture 2024-05-10 jimblackler Reapply "Generator for Kotlin structures." 2024-05-10 dawn-autoroll Roll ANGLE from 4cacc66e70c4 to 8d23fa3f92ed (2 revisions) Created with: roll-dep third_party/dawn Manually roll changes from Dawn to ANGLE. Bug:chromium:42241081 Change-Id: If9aa297a16c36a0a6adcd10a1b586adf36783591 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5579394 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll edae1e7a 2024-05-29T10:01:24 Roll vulkan-deps from 9486d04e3ac1 to 1c35ddaeefd9 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9486d04e3ac1..1c35ddaeefd9 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/d3d530c90dd6549bcfc7cfaedd3ff85fe8ff04a2..21effda93a239cc4d726b37738c27fdc3e20ec3e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/8bc338928b5c92489d953e049018eab2359d437a..6bc92daa125da7aed037b46513845ebc67bc96e6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ee4ac8ea868cf33da30281e25380415c3434523f..3b35db58df3ab871753981b4b5b6a2101716a869 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ib5e9a10ca0eb325a6862de23d8852f88356441b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5578678 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 995a8061 2024-05-29T07:42:55 Roll Chromium from a2a19fca2468 to 40e780119c08 (637 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a2a19fca2468..40e780119c08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/50a1aed2a3..32eb067e80 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/34b12a9839..23386c603b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/97246c4f73..67896a0860 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b663b9c4c5..5f2c9767ce * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/9b894306ec..ccfbe1c82a * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/8c5b971941..a16d528d25 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/4abbe88863..ed9284c473 * tools/luci-go: git_revision:4967d21f2b92546ac3747086cdcbb046b6db52fb..git_revision:3c691526411b6ba25a7582ad8aff1f5a8848b7be * tools/luci-go: git_revision:4967d21f2b92546ac3747086cdcbb046b6db52fb..git_revision:3c691526411b6ba25a7582ad8aff1f5a8848b7be * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/2448d81f97..c5b623b3ba * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7f5fcffb9f..e09506d068 * tools/skia_goldctl/linux: WMIZj5iCtXaIDiOhz7iiswLMOl8EWWP5gfRyHAEZUSAC.._Ncs9Mfd7zCjjNFYk88XronnAaJuEuYMI1m8uFEgUgUC * tools/skia_goldctl/mac_amd64: 88_YxpnUWyvy_qTnp6FH2cvFsJ3eKeNLLph6CbyXHmoC..uhEwv_RChtvOXUbLV4vbOH--bfXc80Wt3oqpvX7l05cC * tools/skia_goldctl/mac_arm64: TtqdFmghiNp8fsnpcuBhyC8e9PjVxKAXDBQhNoTReaUC..l3G1R_7kNvuMM6opTzPqlBgPYf04UfVcQrfHtFfwPfMC * tools/skia_goldctl/win: zHUBIGOiczuqjD1DhUqsPCLIcVp7c-7bnuOzAncAsy0C..7_CWayNfX49-C69e9--i60DGVTOr01SqQgSsRc4IdZUC No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Iebe60548a8fecb0fc2deda32cd35cd4b56103d1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5579889 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi c53b3405 2024-05-25T02:50:27 Vulkan: Use OpCopyLogical with SPIR-V 1.4 When shaders copy structs and arrays, this instruction saves a lot of churn in the SPIR-V. Bug: angleproject:342316794 Bug: angleproject:343218484 Change-Id: I698a8d8ee8c15113e40602a0f4953726bc9a84f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5570152 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 018188c7 2024-05-28T14:44:14 Vulkan: Fix CachedPreferCoherent to actually require cached VK_MEMORY_PROPERTY_HOST_CACHED_BIT should be in requiredBits instead of preferredBits for CachedPreferCoherent buffer. This again caused pixel6 test failures. flush() call is added right after buffer allocation to fix the test failure. This likely is due to the spec says " If a range of non-coherent memory is written by the host and then invalidated without first being flushed, its contents are undefined.". Bug: b/339562049 Change-Id: Ie8529722bd03534598b03983ba447131573b1879 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5578276 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 5137eb99 2024-05-27T01:38:23 Translator: Fix internal inconsistency with output init When creating "zero" nodes, this transformation directly takes the TType's from the variables being initialized. This means that qualifiers such as invariant, as well as any associations with interface blocks are retained in these constructors, which is not valid. This can trip up the SPIR-V generator which does not expect constructors to be qualified as such (i.e. assumes the TypeSpec to be the default). Bug: angleproject:342866364 Bug: angleproject:342866374 Bug: angleproject:343011429 Change-Id: If5c38e18ce977bd0eb1a48e41c59f6199eb7d2e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5570155 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov d1db33b9 2024-05-20T16:49:18 Vulkan: Cleanup EXT_sRGB_write_control support Bug: angleproject:5075 Change-Id: I91f40aaeaf5ff661ee2e227b5b1bb30a5b400e46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5573396 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Shahbaz Youssefi 9620d4d3 2024-05-23T16:12:52 Vulkan: Emit SPIR-V 1.4 where available In preparation for optimizations possible for SPIR-V 1.4. This change makes ANGLE output SPIR-V 1.4 if supported, and SPIR-V 1.3 otherwise. It handles the following differences between the two versions: - OpEntryPoint in SPIR-V 1.4 includes all global variables, as opposed to SPIR-V 1.3 where only the Input and Output variables are listed - Storage buffers use a dedicated storage class in SPIR-V 1.4 Bug: angleproject:342316794 Change-Id: I157ed46449ff2d0f14d284b883b4ddc1b4b46fd1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5565224 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev dd2780ad 2024-05-23T00:00:00 Write point size for SimpleStateChange tests that use points Point rendering without specifying gl_PointSize is undefined. Fixed: angleproject:342671887 Change-Id: I7ad8fd1cfc5c4495647677665e4beb3464d2ce8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5570938 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Solti 6e5eed1c 2024-05-28T20:14:47 Suppress failing newly added deqp test on S22 The cases are failing on S22, per http://b/343202259#comment2 Test: presubmit Bug: b/343202259 Bug: angleproject:341780527 Change-Id: I16fd8db65785c85df671ceddd19e480bd9672e2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5576756 Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Amirali Abdolrashidi 55c8c714 2024-05-23T17:26:24 Vulkan: Enable ABE emulation for Android * Enabled emulating advanced blend equations for all Android devices without VK_EXT_blend_operation_advanced. Bug: b/336860504 Change-Id: I97bf654dc4058b5a92d7de32b1000fb7aff86828 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5567092 Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 3467f0f2 2024-05-20T16:24:53 Vulkan: Cleanup QCOM foveated rendering extensions support Change removed `ContextVK::updateFoveatedRendering()` method because of the following: - Modifying `mGraphicsPipelineDesc` without also updating `mGraphicsPipelineTransition` may case usage of incorrect PSO. - Despite of the above, there is no bug, because the update itself is redundant. In all cases, where `updateFoveatedRendering()` was called, there also will be `onDrawFramebufferRenderPassDescChange()` call, that will call `mGraphicsPipelineDesc->updateRenderPassDesc()`. - The `onDrawFramebufferRenderPassDescChange()` will also call `invalidateCurrentGraphicsPipeline()` therefore, there is no need for this call in the `updateFoveatedRendering()`. - In all cases, the `onRenderPassFinished()` is called before `updateFoveatedRendering()`, therefore, there is no need to set `DIRTY_BIT_RENDER_PASS` bit. - All of the above made `updateFoveatedRendering()` completely redundant (maybe except for the ASSERT). Change also removed `mRenderPassDesc` update from `FramebufferVk::updateFoveationState()`. Note: similar update may be also removed when handling `shouldUpdateSrgbWriteControlMode`. Also fixes possible `mFoveationState` and `mCurrentFramebufferDesc` desynchronization in case if `updateFragmentShadingRateAttachment()` fails. Bug: angleproject:8484 Change-Id: If453bb6691e47aac3c11d0a5a6df696e885b64cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5573395 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Bruno BELANYI be78da6e 2024-05-22T15:33:46 FrameCapture: log end of trace capture This makes it easy to spot when the capture is done through logcat. Bug: angleproject:343190307 Change-Id: Idf174cbf256242e32cda3c781c8b1092123254bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5557966 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Bruno BELANYI <ambroisie@google.com>
Jean-Francois Thibert ceaec322 2024-05-24T11:25:08 Vulkan: use depth stencil bits to check AHB are renderable This resolves an incomplete attachment failure for AHB imported depth buffers. Bug: angleproject:342603523 Change-Id: I16ca0d1bfdab8d542ecf26e5a4e8510171960610 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5570617 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 9b7d8d6a 2024-05-20T20:39:50 Vulkan: Fix AtomicRefCounted threading issue The `AtomicRefCounted::getAndReleaseRef()` is used to decrement the reference counter and to destroy the object if there are no more uses. Decrement operation must use acquire-release memory ordering, in order to guarantee that all accesses from other threads happened before last thread checks that counter is "1" and destroys the object. Added comments to `releaseRef()` and `isReferenced()`, that these methods do not provide any synchronization, and can not be used to achieve same affect as `getAndReleaseRef()`. Relaxed ordering is kept for performance reasons. Bug: angleproject:8601 Change-Id: I8e5654416383e9490c23bc02fda9664216a81076 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5573394 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Bruno BELANYI d3d96a37 2024-05-24T14:43:12 Add 'angle_always_log_info' option This allows outputting `INFO`-level logs and up, without having to trudge through the mountain of output that gets enabled by `angle_enable_trace`. Bug: angleproject:343190307 Change-Id: I88d4f0b48951f1c7cbdda4fce8ce309a25f43e3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5569092 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 0c87d0ed 2024-05-27T14:35:12 Tests: Increase win-intel shards due to --max-processes=1 Currently bottlenecking win-test CI latency Bug: angleproject:7874 Change-Id: I7aceade04175ecc9b89a59363c26060167ed846c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5570283 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll cb6be2f3 2024-05-28T10:01:39 Roll vulkan-deps from ab1d358e50d2 to 9486d04e3ac1 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ab1d358e50d2..9486d04e3ac1 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1cad045cc2bf79c976e1d7001ac71644f6cb29a8..2b19bf7e1bc0b60cf2fe9d33e5ba6b37dfc1cc83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ica31534313f2e387007041eaf44bfbab017d0e14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5573156 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 42f2f350 2024-05-28T07:01:14 Roll Chromium from 4c6db788f16a to a2a19fca2468 (332 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4c6db788f16a..a2a19fca2468 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc0bb16569..50a1aed2a3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f6db8ec73f..34b12a9839 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6753f15395..24a969aef2 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/450c36420d..97246c4f73 * third_party/r8: WOxXvh9fg3-WrIaxJQ5oJmndrrRhljgY6kuKponkL_sC..NCxNylYCpeF52DT5ju1xvvVnuEh3CFBKweSUhjn-IjcC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3d973f22ec..7d6eb60255 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f90bf44416..7f5fcffb9f No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I2558835deb76067490f52a94d7b6675b01efa4ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5573095 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov a3057eed 2024-05-27T14:48:51 Vulkan: DIRTY_BIT_DESCRIPTOR_SETS in handleDirtyUniformsImpl For consistency between graphics and compute handling Bug: angleproject:7103 Change-Id: If6db0739d2f75d9e8e77bf88a05466e56d165a0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5574006 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 71e0038c 2024-05-27T14:50:09 Vulkan: Remove SwiftShader+AsyncCommandQueue tests The AsyncCommandQueue feature is not shipping anywhere, especially not with SwiftShader. Besides, the tests already run Vulkan+AsyncCommandQueue tests. Additionally, SwiftShader still gets exposure to this feature together with the EnableParallelCompileAndLink feature. Bug: angleproject:40644897 Change-Id: I34f0f76ef598f757d3af365777ebb91149b95be3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5574007 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 7c5d2b81 2024-05-21T16:22:53 Vulkan: Add WarmUpTaskCommon::mExecutableVk initialization Change is only for safety, because uninitialized member is not used in the current code. Bug: angleproject:8601 Change-Id: I65fa912119bc9c33a6248c5616388bde4d33b223 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5573393 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Le Hoang Quyen 8db2d61a 2024-05-14T00:39:47 Metal: properly handle base/max level for immutable textures. Previously, we treat every texture the same as a non-immutable texture. Every texture has a native mtl::Texture containing mipmap levels from base GL level to max GL level. And base GL level would be mapped to level 0 of the native texture. However, this is not correct for immutable textures, pbuffer or EGLImage bound textures. Such textures have mipmaps pre-allocated either via glTexStorage calls or externally. Base and max GL levels don't affect their allocated mipmap levels, only limit the levels a shader can sample. For example, a texture has 8 levels allocated via glTexStorage. Its base level is set 1, and max level is set to 2. Shaders will only be able to sample from level 1 to level 2 of this texture. However, it's valid to attach level 0 or level > 2 of this texture to an FBO. This CL addresses this bug by separating internal mtl::Texture into two main objects: - A native storage will contain the actual mipmap levels of the texture. FBO attachment or data uploads can refer to a level in this object. - A view of the native storage from base GL level to max GL level. This view will be used in shader sampling and mipmap generations. Bug: angleproject:6447 Bug: angleproject:8355 Bug: b/42265945 Change-Id: I186b69f02e9e40c75830ffe4b48bd5a3c8d49cf2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5531392 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org> Auto-Submit: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll 81fe86ae 2024-05-27T10:01:20 Roll vulkan-deps from feb3ce48e509 to ab1d358e50d2 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/feb3ce48e509..ab1d358e50d2 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7c3c50ea94354d06dc8c280de8b8a5d5aacbbb19..1cad045cc2bf79c976e1d7001ac71644f6cb29a8 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/f6c54531066c6d28ef403b50ff9cff3ea195d28a..8bc338928b5c92489d953e049018eab2359d437a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b25dea41d4a441268745ed9a83f82757170ec459..ee4ac8ea868cf33da30281e25380415c3434523f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I50779319539216fbbc2ecad28581b6a9bcfbf9a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5572397 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll dc3cb1f5 2024-05-27T10:01:34 Roll SwiftShader from 90519141a709 to ec5dbd2dfb46 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/90519141a709..ec5dbd2dfb46 2024-05-24 swiftshader.regress@gmail.com Regres: Update test lists @ 90519141 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I0e2a9c52bc530269541fd7781b53f9aab95b5e9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5573328 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Scott Marcy b793888a 2024-05-09T11:40:18 Deeply nested switch statements -> ambiguous error Improve the error reported (and potentially avoid a stack overflow crash) when parsing deeply nested `switch` statements. Limits the total number of nested switch and/or iterator statements to `mMaxStatementDepth` (defaults to 256). Bug: angleproject:8645 Change-Id: Iba4795db15c3859d172df8366bc7de3125c2d472 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5527630 Auto-Submit: Scott M <mscott@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll 1a8546ad 2024-05-27T07:01:36 Roll Chromium from 1daa08898eed to 4c6db788f16a (743 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1daa08898eed..4c6db788f16a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/59a9be4050..dc0bb16569 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/940cfd4db1..f6db8ec73f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ec40c25bd8..6753f15395 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/09c232e7c0..450c36420d * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ba37085866..b663b9c4c5 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/e0a4f3561e..8c5b971941 * third_party/r8: 2VsAp2dMXnrxyG6_BD0El4gDAxTXPqrw8xCV0MNmxcUC..WOxXvh9fg3-WrIaxJQ5oJmndrrRhljgY6kuKponkL_sC * third_party/siso: git_revision:df7a992166415f66f6958744f149f724df138879..git_revision:3c4edd7ed1f9902bb0e422b2257a42600edd3ce5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9772a0a349..3d973f22ec * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/973c253520..3754abfc6f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ce2f1c1daa..f90bf44416 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I4b6743de7fe8b36f5ec593598f4bc469aa06deec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5571513 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 59adc191 2024-05-23T00:00:00 Metal: Ensure valid vertex buffer layout stride Metal Validation causes runtime failures if the sum of the vertex buffer binding offset and the related vertex layout stride is greater than the buffer's length. Fixed: angleproject:342350849 Change-Id: I531f092c6130b37cb8b0b89b20804a222160ceb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5565528 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
Alexey Knyazev 6cf3c96d 2024-05-23T00:00:00 Metal: Handle empty vertex buffers Use the current attribute value when the bound array buffer has no data to avoid Metal Validation errors. Drive-by: do not emit empty client data upload commands. Fixed: angleproject:40050025 Change-Id: I813725322c52bc16ca432f617a40fe7cee24dd6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5569091 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Yuxin Hu ad46d67d 2024-05-24T10:19:00 Suppress failing newly added deqp test on S22 Bug: angleproject:341780527 Change-Id: I274493f2b820b9ff007e93cfe41d04af5f3c5e09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5568654 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov f3c52204 2024-05-24T16:46:01 Skip antutu_refinery on Linux Intel and AMD Bug: angleproject:342545097 Change-Id: Id4cec570256dbfa13fc406ef31d4e714950f66d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5570937 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Alexey Knyazev 9742351b 2024-05-23T00:00:00 Move ConversionWithNoVertices to WebGL tests Reliably passing the test requires either extra validation or backend support. Bug: angleproject:342419059 Change-Id: Ifd861f292b5d8f0eb63280a182842343078b7e0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5569094 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi dc470fa1 2024-05-24T12:10:34 HLSL: Initialize uninitialized storage-image-related data Bug: chromium:342464439 Change-Id: I5664177ecd99fbae419bc00a17c0864e43f06776 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5570599 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll a999fd21 2024-05-24T12:30:54 Manual roll vulkan-deps from 48e47a7bb90c to feb3ce48e509 (32 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/48e47a7bb90c..feb3ce48e509 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/af0641aa09f2e63da2423fd652d2cd57497c5b48..7c3c50ea94354d06dc8c280de8b8a5d5aacbbb19 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/ccf3e3c1035189bbb50793d1e249a2c0ba3388a3..77c40bece1b8b441eee432fc9d74efbf985f777f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/1e8781effc88d0cea1a443ea3e0023726fd58eb4..d3d530c90dd6549bcfc7cfaedd3ff85fe8ff04a2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/777358fdad21132866be4a835327fbc28eabc1a4..f6c54531066c6d28ef403b50ff9cff3ea195d28a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/f244736ca190fd50c46507ed50c3615fd7a23189..b25dea41d4a441268745ed9a83f82757170ec459 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com,ynovikov@google.com Change-Id: Ieaef7e23da2aa866f40b65a9ba3c03835e0a378f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5569075 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov f0cdb3af 2024-05-24T15:14:49 Skip StateChangeTestES3.RasterizerDiscard on Win Intel Bug: angleproject:342557702 Change-Id: Ifd79939f53efdc99ed8ec3784c737da87a13e5e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5569093 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Alexey Knyazev 6f82959d 2024-05-23T00:00:00 Move OutOfBoundsByteAttribute to WebGL tests Reliably passing the test requires either extra validation or backend support. Bug: angleproject:342419059 Fixed: angleproject:42265239 Change-Id: I29d3fff67a1d15941f18143d30bcb2c940f4e135 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5569089 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 3090866c 2024-05-24T10:01:02 Roll SwiftShader from bf0c5d6b9d00 to 90519141a709 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/bf0c5d6b9d00..90519141a709 2024-05-23 ynovikov@chromium.org regres: Fix LLVM version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I45db98b226c728ee80c68b5c7be99c174ab1879f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5568743 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5d988854 2024-05-24T07:01:26 Roll Chromium from 1d82a1fadc76 to 1daa08898eed (652 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1d82a1fadc76..1daa08898eed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e3c3f5e5f5..59a9be4050 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/be3b6a0ecc..940cfd4db1 * third_party/android_build_tools/lint: Xnap6swAQawTjX1djXDa7Y6utr3To_5vWeNljRgbTHgC..802fuDf2tCI5HIcMNx1jWJbsTrLt2DS5z8BuFE_Sx7cC * third_party/android_build_tools/manifest_merger: let00MLFVBLhc9quEKtUuTMxC_vL8cvLoxiRSF2M4nkC..EBQZXvDztclHzavY9ulEJA3r4mn0PmbIMeKYKnzhEoEC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1f97358483..ec40c25bd8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4071d0d728..09c232e7c0 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/0906c4a315..e0a4f3561e * third_party/r8: WbqEJ5OsG7ZZ0tJWEj3-SoY215emnCb3V88u0L6O1t4C..2VsAp2dMXnrxyG6_BD0El4gDAxTXPqrw8xCV0MNmxcUC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/839e9816f5..34192533e1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9c88d44665..9772a0a349 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f143139396..973c253520 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/657cc22a92..ce2f1c1daa No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Iea1115564bd15f58a934b19a6ea571d2eb55cc62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5568729 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0