kc3-lang/angle

Log

Author Commit Date CI Message
Corentin Wallez 14ec0d2c 2021-02-15T17:14:08 Suppress a SimpleStateChangeTestES31 on Linux AMD GLES SimpleStateChangeTestES31.DrawThenSampleWithCompute was failing since it was introduced. TBR=syoussefi@chromium.org Bug: angleproject:5649 Change-Id: I46f531724bd4f12c760675de5038f2345eb21aac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2692816 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
angle-autoroll cebe8d3b 2021-02-15T10:01:46 Roll SwiftShader from 673a7fe5c3ff to 539ef8e9426e (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/673a7fe5c3ff..539ef8e9426e 2021-02-12 srisser@google.com Support querying for Vulkan11 properties 2021-02-12 sugoi@google.com Implement GLSLstd450Interpolate* functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ia327c40ccf0c4721b9f2001cdfca846a72b7ecd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2695310 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ef6b31ed 2021-02-15T10:01:12 Roll vulkan-deps from c409714366e9 to 418fd62b5c0f (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c409714366e9..418fd62b5c0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/4afd691772..6ab923c69d * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/cfa1dadb1e..c79edd260c * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/ec2db85225..1d99b835ec * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/01c9ae9b47..c62432713f Bug: None Tbr: syoussefi@google.com Change-Id: I0b9179d9c7031886cb1aeca30573ba27cd396f38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2695289 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 619c8ea2 2021-02-15T07:00:40 Roll Chromium from 59663a6eb4d6 to 17c6b31351cf (178 revisions) https://chromium.googlesource.com/chromium/src.git/+log/59663a6eb4d6..17c6b31351cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3696926416..251bfc5101 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d2a884ad6d..7dee089ce5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..35976bfcac * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fea4246907..dbe0d801bb * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/106e9dfc90..f473fa69fa No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I3f30b42de6724786d7dd669c201807ea17d5f4cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2695140 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 031dd5c5 2021-02-11T14:56:43 Vulkan: Add fast path for pack buffer copies When vkCmdCopyImageToBuffer is possible, it is used to implement glReadPixels with PBO instead of a CPU readback. A few tests are added to verify synchronization between pack/unpack and compute shader writes. Bug: angleproject:5070 Change-Id: Ia5da0feb31348f6b52d164b973ff95e2a0510582 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2691466 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 2b15062b 2021-02-11T12:52:39 Allow more formats as texture attachments in GLES 1 This change allows all formats in the GLES 1.1 spec, table 3.4 to be used as a texture attachment. Also normalize values passed into glColorPointer if the format is of type GL_UNSIGNED_BYTE. These changes are needed for the android app, Kick the Buddy to render correctly. Bug: angleproject:5599 Tests: *DrawTextureTest.ColorArrayDifferentTypes* *FramebufferObjectTest.TextureObjectDifferentFormats* Change-Id: Ie9d27fc24d94106651262cf9b2080dd3f05af1c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690920 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 545d0051 2021-02-11T13:59:08 Add a number of glMemoryBarrier tests Bug: angleproject:5070 Change-Id: I835a4e936cb50d3f4b1187bebbe1d1adc49d0b52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689366 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 19e4cf86 2021-02-09T21:49:42 Capture/Replay: Some fixes for capturing WebGL Bug: angleproject:5635 Change-Id: I756471fbad34660c494fb7f9ba1144accd5c08b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686119 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mohan Maiya 3500b434 2021-02-13T09:14:08 Update assert in BitSetArray::Iterator::prepareCopy Prior to a mutation of the bitset, mCurrentIterator would have been from mParent but post-mutation subsequent iterators are obtained from mParentCopy. Assert that the end() markers for both containers are the same. Bug: angleproject:3877 Change-Id: Ia29abd2acc0014522ef5856a88d8ec227cf9f19d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2693813 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 12990d73 2021-02-11T11:37:03 GetBitSet now uses BitSetArray instead of IterableBitSet Remove the now unused IterableBitSet class. Bug: angleproject:3877 Change-Id: I161e5d062c8183e30a7eb9040f3018116fe6e69e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683494 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya dfd2a881 2021-02-11T11:26:18 Add more functionality to BitSetArray class Add support for more unary and binary operators. In order to support setLaterBit and resetLaterBit in BitSetArray::Iterator there were 2 choices - 1. Make a copy of BitSetArray only if it is a mutating usecase 2. Always perform a copy in the constructor BitSetIteratorPerfTest was run with both patches - 1) Copy only when necessary - RESULT BitSetIteratorPerf.wall_time: run = 116.1067374961 ns 2) Copy always - RESULT BitSetIteratorPerf.wall_time: run = 242.7446459439 ns We settled on the copy only when necessary path. Bug: angleproject:3877 Change-Id: If1d3cc428c68c84857952b46237aa5f206f080cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690912 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Austin Sullivan a2fad5ea 2021-02-11T22:49:33 Mark uninstantiated tests This problem was discovered by attempting to roll googletest past CL 315255779, which causes test binaries to fail when they include test suites / parametrized tests that are not instantiated, and when they include empty test suites. This CL uses the GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST() macro to annotate the suites / tests that are causing test failures. This is necessary to get googletest rolled past CL 315255779. Bug: chromium:1163396 Change-Id: I17c7cae1121079219f632cbbcf8cfc65a27bfdb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2691459 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Brian Salomon e7496f51 2021-01-26T16:13:04 Disable warnings when building in Skia Bug: skia:11223 Change-Id: Ia634bf0bf7a157c759ae192501ff763a1baa8d2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2650986 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 8d993cb7 2021-02-13T02:36:35 Roll Chromium from 764e5b48c0ab to 59663a6eb4d6 (349 revisions) https://chromium.googlesource.com/chromium/src.git/+log/764e5b48c0ab..59663a6eb4d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fd66250b4d..3696926416 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/7e85fef7d9..228b1c1883 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/086ae0a486..d2a884ad6d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e4328db483 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/35e7868383..fea4246907 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/84eb9fba67..106e9dfc90 * tools/skia_goldctl/linux: FnrTtCqUzIkttLMcUafQ-E14XeYY8Yg79UKi-yF4k-gC..IY5qc7Fm3l7ofSvX0tx81d_UYTMJ1cVFlXp3beXxGacC * tools/skia_goldctl/mac: 33D5pMUWm9PcQ9nzgMNc-cv9Y67SNea1XX9S3h0q0zoC..sThAFNVmUGB1KLYyFvxlfBZgrQvQm8C1jpik4b8Eq6QC * tools/skia_goldctl/win: pjN_saVBekGyLe4KBiQ_-ZjYGUfDR6X9O33jfnvsZOwC..AshRD0sQsymS9bHa8cDgrecFq4NCi98zUJ9TNnD054AC No update to Clang. Bug: angleproject:4483 Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: I600b3b598c79f1b023bd31106625b530ff4d3d50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2694097 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten baf64903 2021-02-03T14:02:55 Allow small compressed mip level copies Update ValidateCopyImageSubDataBase() to take into consideration if the entire mip level is being written, even if the size of the mip level is smaller than the compressed block size. This also uncovered a bug in ImageHelper::initializeNonZeroMemory() where the image extents are not at least as large as the compressed format block size: VUID-vkCmdCopyBufferToImage-imageExtent-00207 This CL adds isAllocateNonZeroMemoryEnabled() to allow skipping the test when that feature is enabled while that bug is chased. Bug: angleproject:5592 Bug: angleproject:5634 Bug: angleproject:5643 Test: Texture2DTestES3.CopyCompressedImageMipMaps Change-Id: I0381e0d3490fb148604b61dc3bae8f96ba8b5f8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673069 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten a9de5d99 2021-02-04T20:44:15 Vulkan: setAllDefaultUniformsDirty after createPipelineLayout The default uniform descriptor set is reset while recreating the pipeline layout during handling of immutable samplers and then is never re-allocated and bound before the next draw. The call stack to allocate the program uniforms descriptor set: ProgramExecutableVk::allocUniformAndXfbDescriptorSet ProgramVk::updateUniforms ContextVk::setupDraw ContextVk::drawArrays Context::drawArrays Unfortunately, this occurs before the pipeline layout is reset (and the descriptor sets are reset) due to the presence of an immutable sampler: ProgramExecutableVk::reset <<---- mDescriptorSets.fill(VK_NULL_HANDLE); ProgramExecutableVk::createPipelineLayout ContextVk::updateActiveTextures ContextVk::invalidateCurrentTextures ContextVk::syncState Context::syncDirtyBits Context::prepareForDraw Context::drawArrays This CL calls setAllDefaultUniformsDirty() for the Program/PPO to ensure the default uniforms descriptor sets are re-allocated and re-bound before the next draw command. Bug: b/178424566 Bug: angleproject:5624 Test: CtsCameraTestCases Change-Id: If54a9f2cc09809a5103bc3eac641c77f56362229 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2677385 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Peng Huang 46203e32 2021-02-10T18:41:06 Workaround context lost for Adreno 42x and 3xx Bug: chromium:1171371 Change-Id: I8c2e13f3f35bf1f780526ad1d9d483226ce5ea34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2688901 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 0a99bc39 2021-02-12T14:33:02 Remove dEQP expectations for tests removed from masterpass In https://chromium-review.googlesource.com/c/angle/angle/+/2690142 https://github.com/KhronosGroup/VK-GL-CTS/commit/7630a653d152f5da673e3992c0a1597d605c955f Bug: angleproject:5648 Bug: angleproject:3466, angleproject:3317, angleproject:4235 Change-Id: Ic4ee1d8b69319e839dbed192ce74811d0281b60e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2692513 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Alexey Knyazev 1094d324 2021-02-12T03:14:38 GL: Add allow_etc_formats workaround Enable ETC2/EAC formats on newer Intel GPUs. Bug: angleproject:1552 Change-Id: I240b07d6d81d48e1e03dfcd56aad6fa9f1d7817f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690952 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 5be6ee96 2021-02-12T08:14:18 Roll Chromium from d671c89249af to 764e5b48c0ab (394 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d671c89249af..764e5b48c0ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5088ad39f5..fd66250b4d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c9a2320aee..086ae0a486 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b4dd2a2f6c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f33f4c53ae..35e7868383 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3294cf7fc4..84eb9fba67 * tools/skia_goldctl/win: xC87Xnbi3y7b2aSw2voaEk8MtTPrvU1peyj7NfC6ZtIC..pjN_saVBekGyLe4KBiQ_-ZjYGUfDR6X9O33jfnvsZOwC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I72988210207ef16e3f17fe4c982028fd1dda591c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2691274 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 8b624c6d 2021-02-05T15:33:52 Use constexpr initializer list for bitsets Allows setting/resetting multiple bits to be coalesced into one operation. Bug: angleproject:5528 Change-Id: Ibf2dff8c81441a75c268d95066d23da1b2a3c810 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2678885 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill cf8c71de 2021-02-11T16:32:00 Supress failing capture/replay test. StateChangeTest.DrawAfterFlushWithNoStateChange/* Bug: angleproject:5530 Change-Id: I8e9365219a617b8c6dd6d5c767e40ecde100a76d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689378 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 7309830b 2021-02-11T17:30:28 Roll VK-GL-CTS from fd70e387953e to d8a8a5c337df (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fd70e387953e..d8a8a5c337df 2021-02-05 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2021-02-05 dneto@google.com Update README for GL/glx.h dependency on Linux If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC syoussefi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com,angle-bots+autoroll-info@google.com Change-Id: I55bf4df6b634b3d6e80b196f60b51fc3f249d93c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689309 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 804226df 2021-02-11T14:53:43 Link angle_util statically into angle_system_info_test Otherwise ANativeActivity_onCreate is not found in component build. Bug: angleproject:4483 Change-Id: Ic4a9f66e5b7d150a3740529f866de9995550ea68 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689370 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Austin Sullivan bae53d96 2021-02-10T16:28:14 Only define test suites when TEST_Ps defined The EXTClipCullDistanceForVertexShaderCompileFailureTest and EXTClipCullDistanceForFragmentShaderCompileFailureTest test suites each contain only one test, which is defined iff ANGLE_ENABLE_VULKAN is defined. This results in UNINSTANTIATED_PARAMETERIZED_TEST errors. This problem was discovered by attempting to roll googletest past CL 315255779, which causes test binaries to fail when they include test suites / parametrized tests that are not instantiated, and when they include empty test suites. Bug: chromium:1163396 Change-Id: Ie1837bc2879c14ad9f51a4a757ee1edc7e603c61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686377 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi e281fbb0 2021-02-11T15:37:43 Revert "GL: Cache the results of glGetString" This reverts commit 27906e9c9f8a6767fb8af22d9f80264d8672243a. Reason for revert: Causes failures in mac_optional_gpu_tests_rel Original change's description: > GL: Cache the results of glGetString > > To reduce the amount of queries to the driver, we can cache the > results of glGetString. On Mac, we need to invalidate this cache > on GPU switch. > > Bug: chromium:1173672 > Change-Id: I039172068aec35034a87881a8804f52c080ce4ce > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676882 > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> TBR=geofflang@chromium.org,jonahr@google.com,jmadill@chromium.org Change-Id: I5799c5d287dd01b946446bd66d4c89aef6756d3a Bug: chromium:1173672 Bug: angleproject:5639 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690145 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 62d4b9be 2021-02-11T12:41:11 Capture Tests: Add to CQ when script is changed. This ensures we will force the CQ to verify the trace tests before changes to the capture test script itself, or the test expectations. Bug: angleproject:5530 Change-Id: I7d9d04a14ae0525a6ff59681216abbdb85b72c78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689365 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 537cd0d5 2021-02-11T12:38:10 Capture Tests: Update path to capture/. Bug: angleproject:5530 Change-Id: Ibbabab2bcc03c196c6c51e5bf67d81df8bad4925 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689364 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis 5af5808b 2021-02-10T13:06:36 GL: Do not support ETC1 textures on Desktop GL As pointed out in WebGL issue 3014, ANGLE has been exposing ETC1 texture support on desktop GL when GL_ARB_ES3_compatibility or GL 4.3+ is available. However, it is very likely that none of these platforms actually have hardware support for this format, and are only supporting it for compatiblity with ES3. We shouldn't expose this so that desktop clients can use a better format instead. Bug: chromium:1048244 Change-Id: I53837a05719d0ca3ff390b5b45b61a1f9c72a535 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2687466 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll b6cb6c01 2021-02-11T10:01:12 Roll vulkan-deps from 4dc6ccfad74a to c409714366e9 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4dc6ccfad74a..c409714366e9 2021-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d1bfbcd594d6 to 01c9ae9b47e5 (1 revision) 2021-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from ff6a9e31358a to a66ceba27225 (2 revisions) 2021-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f0c96f40c79d to cfa1dadb1e62 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I312c5f0aca5df7fcaa469b3ea1336b4df946c36a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690016 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll df226276 2021-02-11T08:14:03 Roll Chromium from 95cbe3e024b0 to d671c89249af (511 revisions) https://chromium.googlesource.com/chromium/src.git/+log/95cbe3e024b0..d671c89249af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a8f1167b05..5088ad39f5 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/bd12831a6f..7e85fef7d9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4ff3b79a9a..c9a2320aee * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7ce745057e..b33c25cc0b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b013189435 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8f265d6ddf..f33f4c53ae * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a33116a559..3294cf7fc4 * tools/skia_goldctl/linux: lenVc-lo77pTtOxFWjwWnArJLXKHftA-J-nOq_0W8EMC..FnrTtCqUzIkttLMcUafQ-E14XeYY8Yg79UKi-yF4k-gC * tools/skia_goldctl/mac: n5BYBVoiLzVMumXdheNmsUhTHYTpm2CAcb9W2KcPZA8C..33D5pMUWm9PcQ9nzgMNc-cv9Y67SNea1XX9S3h0q0zoC * tools/skia_goldctl/win: Evb_hYwKX21F3mSBdnoPa1gPiJlejpLrfECXIpdrrqgC..xC87Xnbi3y7b2aSw2voaEk8MtTPrvU1peyj7NfC6ZtIC No update to Clang. Bug: angleproject:5499 Tbr: syoussefi@google.com Change-Id: I15aa82ee87912270d98bc82342f6c94483924ef9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690011 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Le Hoang Quyen 807d1ad7 2021-02-10T23:30:56 Metal: fix incorrect default viewport size with contentsScale>1 The correct metal layer's drawable size should be calculated after mMetalLayer.get().contentsScale is set during initialization to allow initial viewport to be computed properly on front-end side. Bug: angleproject:2634 Change-Id: If278f40c0b6800bbe12fb5ea94986f728381bc00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2687300 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll d0e8c636 2021-02-10T04:08:28 Roll VK-GL-CTS from 28d3d98b040d to fd70e387953e (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/28d3d98b040d..fd70e387953e 2021-02-05 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC syoussefi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Change-Id: I8f160df11b65f88e79010c37aeb7a89aa70b84e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690142 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott cffe90b4 2021-02-09T12:48:13 Vulkan: Update documentation for enabling debug markers After changes to the GN arg "angle_enable_trace" were done, other GN args are now needed. Bug: b/170249632 Change-Id: Ib5e703434cb580aa838ef8632b271f5f20554f42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2684933 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Ian Elliott 7ec4d2d7 2021-02-09T11:48:32 Android: Create a new ANGLE APK package name for AGI Use "org.chromium.angle.agi" for the specially-built ANGLE APK for Android Graphics Inspector (AGI). This will allow AGI to work with a version of ANGLE that is built for it regardless of what other version(s) of ANGLE are or aren't installed on the device. Continue to use "org.chromium.angle" for developer builds. Bug: b/168745566 Change-Id: I4610d3b1eec6b0564d020dca7bd1f9e9d6532a64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2684920 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 45a493ea 2021-02-05T13:48:48 Vulkan: Use a dirty bit to start the render pass Some dirty bits need to run before the render pass starts. An upcoming change for example needs to break the render pass when the program pipeline is changed while transform feedback is active. Another upcoming change may need to do the same based on a preceding glMemoryBarrier. This change adds a new dirty bit to start the render pass after some dirty bits have already been processed. Bug: angleproject:5528 Change-Id: I993c9efefed4c8fee268b218a8dd66a582d4e7cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2678863 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Tim Van Patten dccec125 2021-02-08T16:21:30 Vulkan: Clear mCurrentGraphicsPipeline after createPipelineLayout() Set mCurrentGraphicsPipeline = nullptr when the pipeline layout is recreated if immutable samplers are used to prevent a use-after-free. For a fuller discussion on why this is necessary, see: Vulkan: clear mCurrentGraphicsPipeline during invalidate | https://chromium-review.googlesource.com/c/angle/angle/+/2647746 Bug: b/178424566 Bug: angleproject:5624 Change-Id: I70679bda85cd587dbd8893a4576ee5d33aee2b70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683041 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang 393c44f1 2021-02-01T15:45:24 EGL: Trim requested config parameters to EGL. ANGLE requests a config with several uneccessary parameters. I suspect these parameters are causing issues in the wild where eglChooseConfig fails. Try requesting ES3 then fall back to ES2 configs. Skip config caveats, floating point configs and multisample configs, we provided the default parameters. The resulting config is very similiar to the one Chrome requests in gl_surface_egl.cc Bug: chromium:1173161 Change-Id: Ifa78ff8081e3d86e823036981e1e2b5f8f751fed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2665888 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Peng Huang <penghuang@chromium.org>
Jamie Madill 6bfb64ae 2021-02-10T14:33:03 infra: Add trace tests to CQ conditionally. This will add the trace tests with the "libANGLE/capture/" folder changes. This will prevent slow trace tests from clogging the CQ on unrelated changes, while still providing some regression testing. Bug: angleproject:5530 Change-Id: I76361aaa51c49c84dab8be7d74f4bad0db7d2419 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686438 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Peng Huang 0e8f7727 2021-02-10T15:03:10 Fix crash in gl::Context::unMakeCurrent() gl::Context's ctor may need to create a native EGL context and it can fail. If it fails, the context->mImplementation will be nullptr, and it will cause crash elsewhere. Fix the problem by checking it after create a gl::Context instance. Bug: chromium:1171371 Change-Id: Ic57f088dcbf9716b85fee92bf54d557eb94642d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686439 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Jamie Madill 6fc10389 2021-02-10T11:20:16 Move Frame Capture to capture/ folder. This will make it easier to trigger the trace tests when these files are modified. Bug: angleproject:5530 Change-Id: I5f0c450595b380cd91b20c1477dc1845bee35dd9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686120 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 7dee9639 2021-02-09T23:49:25 infra: Fixes to main.star. - Includes the missing logo - Adds presubmit builder to the try list view - Sorts the ci console view more consistently - Adds ynovikov to OWNERS - Updates documentation Also removes the old handwritten cfg files. Bug: angleproject:5559 Change-Id: I7d0ad4bd4d0afb56e114107b6a14718b384f9b37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686630 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jonah Ryan-Davis 27906e9c 2021-02-04T16:54:56 GL: Cache the results of glGetString To reduce the amount of queries to the driver, we can cache the results of glGetString. On Mac, we need to invalidate this cache on GPU switch. Bug: chromium:1173672 Change-Id: I039172068aec35034a87881a8804f52c080ce4ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676882 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill a8a2a71b 2021-02-01T17:18:18 Vulkan: Support y-flip with no driver support. We can reuse the surface rotation matrix code to do the y-flip. This requires the SPIR-V transformation support. Because not all rotations are encoded into the table we can only support rotation with the driver support for y-flip (currently). Includes some very minimal regression testing. This work is targeted towards supporting vk-portability implementations which are not as up-to-date with Vulkan features. Bug: angleproject:5596 Change-Id: I270fa1efc03267551d28df33ddac9972e1343d60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2665892 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 4e1b46d3 2021-02-10T10:01:07 Roll SwiftShader from 9d35d544ce96 to 673a7fe5c3ff (10 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/9d35d544ce96..673a7fe5c3ff 2021-02-10 capn@google.com Unify load/store operand accessors 2021-02-10 capn@google.com Discern between load and store addresses 2021-02-10 capn@google.com Rename InstIntrinsicCall to InstIntrinsic 2021-02-10 capn@google.com Eliminate the InstIntrinsicCall Target parameter 2021-02-10 capn@google.com Eliminate Subzero profiling support 2021-02-10 capn@google.com Regres: Remove GLES tests from CI test runs 2021-02-09 capn@google.com Benchmark time spent by all threads 2021-02-09 natsu@google.com Ignore two unused variables in llvm 2021-02-09 natsu@google.com Revert "Enable named mmap usage on Android" 2021-02-09 amaiorano@google.com VulkanWrapper: fix loading driver when lib path can be resolved by dlopen If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I867da2c4d62c19ba711b7923fb3d1d2632854a3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2687120 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0f74ae58 2021-02-10T10:01:12 Roll vulkan-deps from f640b7005a0c to 4dc6ccfad74a (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f640b7005a0c..4dc6ccfad74a 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from a03938051ff6 to 6952dfcc1df5 (1 revision) 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7b727b773d50 to d1bfbcd594d6 (1 revision) 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 64ffe55c3bf6 to 7b727b773d50 (2 revisions) 2021-02-09 jmadill@chromium.org Add script for formatting commit messages. 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 6fcd515be5b3 to ff6a9e31358a (1 revision) 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 386b4fcb28e5 to 4afd69177258 (1 revision) 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from b2c81e3615bf to 64ffe55c3bf6 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I4eb306a46fa934c46fa2903c111b97b73306af8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686911 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 313cedff 2021-02-10T07:32:30 Roll Chromium from 02dbd1fa1c75 to 95cbe3e024b0 (423 revisions) https://chromium.googlesource.com/chromium/src.git/+log/02dbd1fa1c75..95cbe3e024b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/44961f39c0..a8f1167b05 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fc5af1ac75..bd12831a6f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dfd112748a..4ff3b79a9a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/73458740c0..7ce745057e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b013189435 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/de0632cfad..a33116a559 * tools/skia_goldctl/linux: RCW4v6H43n2nkU3V54jWsXz5Q1h_OZaV_DcRQNXMV4sC..lenVc-lo77pTtOxFWjwWnArJLXKHftA-J-nOq_0W8EMC * tools/skia_goldctl/mac: hwxykGQN8q1I4nBPA93MSwNqdynaW_gYQ3CJwZJLyngC..n5BYBVoiLzVMumXdheNmsUhTHYTpm2CAcb9W2KcPZA8C * tools/skia_goldctl/win: XMdzQyfm6ZBS1E6dZSblabBo-_I49Cf38UhKjkyukC8C..Evb_hYwKX21F3mSBdnoPa1gPiJlejpLrfECXIpdrrqgC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ifd38d1b95e4f511ac795f946879774aa624dfd03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686684 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 80308e20 2021-02-08T16:16:36 Vulkan: Match min/magFilter to chromaFilter VkSamplerCreateInfo.magFilter and minFilter must match VkSamplerYcbcrConversionCreateInfo.chromaFilter. VkSamplerYcbcrConversionCreateInfo.chromaFilter is currently hard-coded to VK_FILTER_NEAREST in HardwareBufferImageSiblingVkAndroid(), so force magFilter and minFilter to VK_FILTER_NEAREST in SamplerDesc::init() if an externalFormat is being used. Bug: b/178424566 Change-Id: Ia1f7fc21e3faa4e57f837ed3ae70608134150aea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683038 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi bb062070 2021-02-09T15:30:04 Vulkan: Fix updates to element buffer If glBufferSubData results in a new vk::BufferHelper allocation, VertexArrayVk::mCurrentElementArrayBuffer needs to be updated. VertexArrayVk::syncState was working under the assumption that DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA cannot result in a vk::BufferHelper pointer change. This assumption was broken in https://chromium-review.googlesource.com/c/angle/angle/+/2204655. Bug: b/178231226 Change-Id: I969549c5ffec3456bdc08ac3e03a0fa0e7b4593f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2685439 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten c3887991 2021-02-03T13:52:32 Capture/Replay Don't capture invalid commands Special Forces Group 2 issues invalid OpenGL ES commands, which are currently captured by ANGLE's frame capture. These invalid commands generate errors on both ANGLE and the native driver, causing the test to be marked as "failed". This CL updates FrameCapture::captureCall() to not capture invalid commands, which prevents replay errors. However, the other work related to the call is still performed, including: - maybeOverrideEntryPoint() - maybeCapturePreCallUpdates() - maybeCapturePostCallUpdates() This work is necessary, otherwise calls that update necessary members like FrameCapture::mClientArraySizes may be missed, causing leading to compilation failures related to missing symbols. For example, mClientArraySizes is updated via the following call stack: captureClientArraySnapshot() maybeCaptureDrawArraysClientData() maybeCapturePreCallUpdates() It's necessary for mClientArraySizes to contain non-zero values, so that the variable gClientArrays[] is output by WriteCppReplayIndexFiles(). Otherwise a compilation error will occur when it's referenced by a glVertexAttribPointer() call in the capture. Bug: angleproject:5592 Change-Id: I625a074e035eb75267d8384dc61ce6de1717af91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673068 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mohan Maiya f6784006 2021-02-08T16:39:04 Modify data type of ActiveTextureMask and ImageUnitMask ActiveTextureMask and ImageUnitMask need more than 64bits. We can now use the BitSetArray datatype and avoid the perf penalty of using std::bitset Bug: angleproject:3877 Tests: angle_perftests.exe --gtest_filter=TexturesBenchmark* Change-Id: Ic82e09d1aa2c1904d06ad48ba6200f35896665ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2664734 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya f1cbcaba 2021-02-07T13:37:49 Use const reference when possible When retrieving BitSet masks return a const reference of the mask to avoid invoking the copy-constructor. Bug: angleproject:3877 Change-Id: I9f724a4864f3db17aa6f1ab74b81053c65313764 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2681767 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Jamie Madill aca0dc35 2021-02-05T12:18:15 infra: Update to starlark config. Makes a number of small configuration changes. Notable the "try" console view is replaced with a list view. Bug: angleproject:5559 Change-Id: Id3c4cb28fe9d456f8b79ed740f978b72e2ffcdd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2677903 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Stephen White ad60c22d 2021-02-09T13:22:09 Add an option to use "metal" as ANGLE_DEFAULT_PLATFORM. Bug: angleproject:5632 Change-Id: Id470993a01609ace851372b1bbe01fee8cde274b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2684635 Commit-Queue: Stephen White <senorblanco@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 831afbaf 2021-02-09T16:24:20 Don't test 32-bit Android Vk on CQ Keeping only CI testing due to lack of phone capacity. Bug: angleproject:5633 Change-Id: I9b41d86630ce6a6647fb058cd70382f1cb9a938f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686116 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tim Van Patten 60c3f404 2021-02-03T18:12:06 Tests: Add Bus Simulator Indonesia trace Bug: angleproject:5612 Test: angle_perftests --gtest_filter=TracePerfTest.Run/*bus_simulator_indonesia* Change-Id: I067795b237fc32406d63785e347324b423978768 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2674305 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi a7df19c8 2021-02-09T10:37:41 Roll VK-GL-CTS from b29bf0434c16 to 28d3d98b040d (82 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b29bf0434c16..28d3d98b040d 2021-02-05 alexander.galazin@arm.com Remove GLES-only tests from the GL 4.5 package 2021-02-05 alexander.galazin@arm.com Support GL 4.5 in the Separate shader tests 2021-02-04 alanbaker@google.com VK_KHR_zero_initialize_workgroup_memory tests 2021-02-04 alexander.galazin@arm.com Update Vulkan headers 2021-02-03 alexander.galazin@arm.com Update glslang 2021-02-03 ari.suonpaa@siru.fi Change gradient generator for pipeline image tests 2021-02-03 gleese@broadcom.com Add tests for multisample texture size 2021-02-03 piotr.byszewski@mobica.com Fix memory scope in OpControlBarrier tests 2021-02-03 marcin.kantoch@amd.com VK_KHR_fragment_shading_rate pixel consistency 2021-01-29 ruoyu@amd.com Adjust texture data and threshold 2021-01-29 rgarcia@igalia.com Fix validation in mismatched format tests 2021-01-29 venni.ihanakangas@siru.fi Test descriptor set layout binding ordering 2021-01-29 ari.suonpaa@siru.fi Add descriptor update stress test 2021-01-29 antto.makinen@siru.fi Coverage tests for undefined values 2021-01-29 rgarcia@igalia.com Test attributes beyond static vertex stride 2021-01-28 gleese@broadcom.com Check for astc_sliced_3d extension in negative API tests 2021-01-28 rgarcia@igalia.com Disable dithering in nearest edge test cases 2021-01-28 rgarcia@igalia.com Check sparse image format support before creation 2021-01-28 rgarcia@igalia.com Additional conditional rendering tests 2021-01-28 estea@igalia.com Expand tests for image queries of null descriptors 2021-01-22 gleese@broadcom.com Stop dEQP-GL45 tests falling back to ES3.1 2021-01-22 apinheiro@igalia.com Add VariablePointerFeatures requirement for amber test requiring it 2021-01-22 apinheiro@igalia.com Avoid querying YCbCr combined sampler count in RGBA 2021-01-22 rgarcia@igalia.com Check unsupported formats with sparse AMD bias/lod 2021-01-22 mika.vainola@siru.fi Add command line option for filtering by runner 2021-01-22 antto.makinen@siru.fi Fix a Graphicsfuzz coverage test not to depend on an undefined value 2021-01-22 antto.makinen@siru.fi dEQP-VK.graphicsfuzz.cov-tail-duplicator-infinite-loops 2021-01-22 mika.vainola@siru.fi Add FrexpStruct comparison tests 2021-01-22 ari.suonpaa@siru.fi Use target environment for Amber shaders 2021-01-22 alexander.galazin@arm.com Add gitattributes 2021-01-22 piotr.byszewski@mobica.com Test negative depthBiasClamp values 2021-01-21 Kyle.Griffiths@imgtec.com Threshold Consistency for ES2 FBO Tests 2021-01-21 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-01-21 alexander.galazin@arm.com Support GL 4.5 in the GetTexLevelParameter tests 2021-01-21 alexander.galazin@arm.com Support GL 4.5 in the multisample interpolation states tests 2021-01-21 alexander.galazin@arm.com Support GL 4.5 in the Shader state query tests 2021-01-21 alexander.galazin@arm.com Support GL 4.5 in the Stencil texturing tests 2021-01-21 alexander.galazin@arm.com Support GL 4.5 in the Synchronization tests 2021-01-21 alexander.galazin@arm.com Support GL 4.5 in various multisample tests 2021-01-21 cheryl.wei@arm.com Fix ReadPixels format 2021-01-20 alexander.galazin@arm.com Support GL 4.5 in the Texture buffer syncronization tests 2021-01-20 alexander.galazin@arm.com Support GL 4.5 in the Texture Specification Tests 2021-01-20 alexander.galazin@arm.com Support GL 4.5 in the Query vertex attribute binding state tests 2021-01-20 greg@lunarg.com Add minimum nonUniform tests to descriptor indexing texts 2021-01-19 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Texture size tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Shader Image Load & Store Tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the gl_HelperInvocation tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the GL_EXT_shader_framebuffer_fetch tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Common function tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Opaque Type Indexing Tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Internal format queries tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Layout binding tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Integer state query tests 2021-01-19 alexander.galazin@arm.com Suppotr GL 4.5 in the sRGB write control tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Cube map array texture tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the base vertex extension drawing tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the indexed draw buffers tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the default vertex array object test 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Boolean State Query tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the atomic operation with image tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the draw_indirect tests 2021-01-17 alexander.galazin@arm.com Notice of withdrawal of Vulkan CTS 1.2.1.x 2021-01-13 Alexander.Galazin@arm.com Merge "Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master" 2021-01-13 thomas.spurden@broadcom.com Add --force option to fetch_sources.py 2021-01-13 estea@igalia.com Fix checks for conditional rendering support 2021-01-13 slawomir.cygan@intel.com Check for VK_KHR_portability_subset extension before checking it's features 2021-01-13 estea@igalia.com Add striped 3D blitting tests 2021-01-11 estea@igalia.com Add tests for logical operations 2021-01-08 ruoyu@amd.com Disable-SeamlessCubeMap-In-Reference-ES2Context 2021-01-08 gleese@broadcom.com Test invalid Lods in the textureSize tests 2021-01-08 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2021-01-07 rgarcia@igalia.com Fix sync problems in conditional_rendering.draw_clear tests 2021-01-07 cwabbott0@gmail.com Don't access arrays out-of-bounds in robustness2 tests 2021-01-07 anholt@google.com pipeline statistics test: Fix compute shader setup in !GL4.3 case. 2021-01-06 rgarcia@igalia.com Clarify depth/stencil resolve write access sync 2020-12-29 alexander.galazin@arm.com Support GL 4.5 in the texture test utils 2020-12-29 alexander.galazin@arm.com Support GL 4.5 in the blend_equation_advanced tests 2020-12-29 alexander.galazin@arm.com Support GL 4.5 in the 'negative' tests 2020-12-29 alexander.galazin@arm.com Support GL 4.5 in geometry/tesselation shader tests 2020-12-29 alexander.galazin@arm.com Support GL 4.5 context in the precision and draw tests 2020-12-29 alexander.galazin@arm.com First steps towards running ES3.1 functional tests on GL4.5 drivers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:3687 Bug: angleproject:3688 Change-Id: I8de830ec9f56ab6a29218f83caaf96b86ceba648 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679296 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 224e3c14 2021-02-08T13:00:16 Support optimized bitsets that need more than 64bits For usecases that needed more than 64bits we were using std::bitset container. This has slower perf compared to the BitSetT container. Add a new class that can support large bitsets by wrapping an array of BitSet32/BitSet64 objects, depending on CPU bitness, as the container. Bug: angleproject:3877 Tests: angle_unittests.exe --gtest_filter=BitSetArrayTest* angle_white_box_perftests.exe --gtest_filter=BitSetIteratorPerfTest* Change-Id: I3f4a635f9e6974a99db7a4b592ab206aad754760 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2664733 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 54242b8f 2021-02-04T12:20:57 Vulkan: Leverage ExtendedDirtyBitType Expand ExtendedDirtyBitType to include bit for clip distance, mipmap generation hint and shader derivative hint. Handle these dirty bits in ContextVk::syncState Bug: angleproject:5611 Change-Id: If8d1646334e737f81ac72cdddb8fe3ba613b4b94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676173 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 38916bcc 2021-02-09T11:00:30 infra: Upgrade XCode version to "12a7209". This mirrors the version used in Chromium. Bug: angleproject:5559 Change-Id: Ie1702281ce88fef00bf46079ae76477d33207dfd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679298 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 41a1920e 2021-02-08T22:04:10 Tests: Reduce capture_replay_test exception list Remove some tests that no longer fail to compile. Test: capture_replay_tests.py --gtest_filter=*ES2_Vulkan_SwiftShader Bug: angleproject:5630 Change-Id: If04787494e58afad0a98d0ee7f37e00d2e77ec1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683543 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll b7d441e6 2021-02-09T10:01:12 Roll vulkan-deps from d6c9a9f3f705 to f640b7005a0c (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/d6c9a9f3f705..f640b7005a0c 2021-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from db287d4ad474 to b2c81e3615bf (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ifd3d52b5f8828aa3d1f8cf3be6d4aecec0adfb82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683856 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cd5c27d6 2021-02-09T10:01:07 Roll SwiftShader from 266614a36dbd to 9d35d544ce96 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/266614a36dbd..9d35d544ce96 2021-02-08 amaiorano@google.com Make vk-unittests use VulkanWrapper If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I1a87604249b72aab496adfef32e05ef29cd5aba0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683822 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 80335a11 2021-02-09T07:00:22 Roll Chromium from 82fe35376dee to 02dbd1fa1c75 (492 revisions) https://chromium.googlesource.com/chromium/src.git/+log/82fe35376dee..02dbd1fa1c75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a2a134032e..44961f39c0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f86e30675a..dfd112748a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cf4c59a332 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fae3adcf16..8f265d6ddf No update to Clang. Bug: angleproject:5499 Tbr: syoussefi@google.com Change-Id: I8edd0b6d67fd6c01cad722ebc0a719ef44cb3c0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683547 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jonah Ryan-Davis 4968f6f2 2021-02-04T16:40:36 Move getRendererDescription from ContextImpl to DisplayImpl The other backend description strings are in DisplayImpl. This will help with caching the result of glGetString in the GL backend. Also Update the getters to not be const in order to allow caching. Bug: chromium:1173672 Change-Id: I43df35688762b23429f47f169c04482cf4cd089a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676881 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jonah Ryan-Davis e174c358 2021-02-04T15:14:10 GL: Consolidate glGetString calls First step for cacheing the result of glGetString calls is mostly cleanup. Bug: chromium:1173672 Change-Id: I47281a09b9bd5859655d16376977a6eabcfbb3c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676203 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 0ccf1010 2021-02-08T18:13:13 Roll vulkan-deps from 38d88d12b2fd to d6c9a9f3f705 (29 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/38d88d12b2fd..d6c9a9f3f705 2021-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 264cce03f6e4 to db287d4ad474 (2 revisions) 2021-02-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 047a6b59c90b to 264cce03f6e4 (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 6ee1006a4ec9 to 047a6b59c90b (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 773871cc7e99 to 6ee1006a4ec9 (2 revisions) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 3ad7e5fcc0ee to f0c96f40c79d (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 2292623a4339 to 773871cc7e99 (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 4b8c885ffebf to 2292623a4339 (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f11f74348158 to 3ad7e5fcc0ee (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from c91a25af13e1 to f11f74348158 (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d68ee750eb0b to 4b8c885ffebf (1 revision) 2021-02-04 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from e3025c6cdeba to d68ee750eb0b (2 revisions) 2021-02-04 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 1c3d365b1008 to e3025c6cdeba (1 revision) 2021-02-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 5c4f421121c4 to 386b4fcb28e5 (1 revision) 2021-02-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from fd5cc6962213 to 6fcd515be5b3 (1 revision) 2021-02-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 5f585ae240dd to 1c3d365b1008 (1 revision) 2021-02-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 669dfd5ce67f to 5f585ae240dd (1 revision) 2021-02-02 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 6668e1afddc9 to 669dfd5ce67f (7 revisions) 2021-02-02 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from d61a7d110d93 to c91a25af13e1 (1 revision) 2021-02-02 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 2b9a7b114eaa to fd5cc6962213 (1 revision) 2021-02-02 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 9166a0677e44 to ec2db85225ab (1 revision) 2021-02-02 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f074521d88d4 to 6668e1afddc9 (2 revisions) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from aa59169d542d to f074521d88d4 (2 revisions) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d825d6bd2084 to aa59169d542d (1 revision) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7687a48e8da0 to d825d6bd2084 (1 revision) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 480d27774986 to 7687a48e8da0 (1 revision) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 81dd1f107ba6 to 480d27774986 (1 revision) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 6d68720cbb5e to 5c4f421121c4 (1 revision) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f7c43377f095 to 6d68720cbb5e (1 revision) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 297723d75af4 to d61a7d110d93 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: I5d8c5c6da16d84d92e49299fb5f101417c154eef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679047 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 281c6552 2021-02-05T16:55:09 infra: Remove ssd:0 from builderless config. Unsure why we added this requirement in the past. We shouldn't need to explicitly specify a ssd dimension for the bots. Removing to simplify the migration to .star files. Bug: angleproject:5559 Change-Id: I55484dec74e4274013390d378678824a3ed0778a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2678865 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 9d5fd2e4 2021-02-08T10:01:24 Roll SwiftShader from ff010f9f0131 to 266614a36dbd (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/ff010f9f0131..266614a36dbd 2021-02-05 amaiorano@google.com Fix crash during llvm_shutdown due to init order fiasco 2021-02-05 capn@google.com Reactor: fix using -x86-asm-syntax only on x86 compilations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I15489c0713bb9e11ea828715dd663c358e279791 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2682220 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5712107a 2021-02-08T07:01:28 Roll Chromium from 19ae187233a0 to 82fe35376dee (607 revisions) https://chromium.googlesource.com/chromium/src.git/+log/19ae187233a0..82fe35376dee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/57d7d0ceae..a2a134032e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b56fbac691..f86e30675a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ab8a40f411 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f18ba70b3a..fae3adcf16 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5c2436468d..de0632cfad * tools/skia_goldctl/linux: 76SWgiS8ELcHcnzwLeB2gpoF28Vg1-g2TYKAteSZ8tUC..RCW4v6H43n2nkU3V54jWsXz5Q1h_OZaV_DcRQNXMV4sC * tools/skia_goldctl/mac: JlJ5LLfSRnkBI9WIgbkLC1xkaj8vjPP2YrpHHnI1XZcC..hwxykGQN8q1I4nBPA93MSwNqdynaW_gYQ3CJwZJLyngC * tools/skia_goldctl/win: EwtBCz0Ab6XGWqTptLtETY6O4_Q1aq96--G4dMUuup0C..XMdzQyfm6ZBS1E6dZSblabBo-_I49Cf38UhKjkyukC8C No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I8b976d1675dc3ee12744f4a5027852bdaa3b306e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679266 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 6b20e1c8 2021-02-07T14:42:54 Tests: Add Hill Climb Racing trace Test: angle_perftests --gtest_filter="*hill_climb_racing*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5626 Change-Id: I64a52a56569ef1e1a219c5d7e931620dcb438f4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2681837 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 8dae4007 2021-02-07T14:18:22 Tests: Add Worms Zone io trace Test: angle_perftests --gtest_filter="*worms_zone_io*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5625 Change-Id: I38bf148409aec4ae15bdf0759676518f44a98359 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2681835 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Doug Horn 580961fb 2021-02-02T10:27:48 Micro-optimizations for setUniform* This CL improves the setUniform* call for the case where the niform component size is 4. In that case, we can issue a single memcpy. This reduces the average wall time of setUniform4fv in our test app by ~20%. Test: Run the dEQP shader tests. Bug: b/179160884 Change-Id: I9352f6188bc87449719aac522d1a2323adf7fca5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2667592 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Doug Horn <doughorn@google.com>
Jason Macnak d820ec7b 2021-02-05T10:39:25 Use __system_property* to read Android props ... instead of popen to avoid needing shell_exec permission. Bug: b/179041465 Test: roll_aosp.sh && m && launch Cuttlefish w/ SwANGLE Test: aosp/1574848 presubmit Change-Id: Ie64d2730fd2ea00a1b5089459297ef7ffe98bc59 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676271 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Jason Macnak <natsu@google.com>
Cody Northrop 0bb520ad 2021-02-05T11:53:11 Tests: Add Romancing Saga trace Test: angle_perftests --gtest_filter="*romancing_saga*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5622 Change-Id: I9f35fd0e0b9897e77f8d56547c2c134638b8b685 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679323 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Geoff Lang ab1f516d 2021-02-05T21:13:25 Skip happy_color trace on Windows AMD Vulkan Bug: angleproject:5623 Change-Id: I75338183c5c1321efd2516ac3a27a83d47c8d29b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679246 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Ian Elliott ce540d8c 2021-02-01T17:38:10 Create MSAA-swapchain windows' VkImages differently The actual VkImage needs to have rotated extents, but the ImageHelper needs to have non-rotated extents in order for the rest of ANGLE's pre-rotation to work. Bug: b/175793022 Change-Id: I6fa25ab8c636886787ac50b194e566111308f30b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2666514 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Cody Northrop d3c00f95 2021-02-05T11:09:27 Tests: Add Rise of Kingdoms trace Test: angle_perftests --gtest_filter="*rise_of_kingdoms*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5621 Change-Id: I148d7ae0c23e0ce8ecf75d12affb4c8dfdc04e1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679221 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 3bb5f1ff 2021-02-04T22:45:33 Tests: Add Clash Royale trace Test: angle_perftests --gtest_filter="*clash_royale*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5620 Change-Id: I13eb10dc84deffa31f0e7fd1f0382e87bf69e46e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2677621 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll b2de0688 2021-02-05T10:01:18 Roll SwiftShader from 14dcbed947ce to ff010f9f0131 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/14dcbed947ce..ff010f9f0131 2021-02-05 capn@google.com Limit Subzero routine stack size to 512 KiB 2021-02-05 capn@google.com Limit LLVM routine stack size to 512 KiB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I22a9fb120bc9965efe370bca7393469e7734bf90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2678021 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 82df8034 2021-02-05T07:00:48 Roll Chromium from f5e138b74576 to 19ae187233a0 (532 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f5e138b74576..19ae187233a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fc04613723..57d7d0ceae * testing: https://chromium.googlesource.com/chromium/src/testing/+log/967a8819da..b56fbac691 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/602133a964..73458740c0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..138dc4ba2e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4ee065a4cc..f18ba70b3a * tools/skia_goldctl/linux: 6LF5F6aXrWP5GXP59OtHK-18DPO1aPrWT-5XYQEaYBMC..76SWgiS8ELcHcnzwLeB2gpoF28Vg1-g2TYKAteSZ8tUC * tools/skia_goldctl/mac: wKJl4xmBqSYjy0jV-1mXCtsx-D8if80AIBo9uiP-nrEC..JlJ5LLfSRnkBI9WIgbkLC1xkaj8vjPP2YrpHHnI1XZcC * tools/skia_goldctl/win: pUKrWuFOfyPuNAzRy9gRHv-8dvvUOzMEHO9KvF9dRMIC..EwtBCz0Ab6XGWqTptLtETY6O4_Q1aq96--G4dMUuup0C No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I478a9000c2cfe454836021163cbd73f67c4ceb9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2677624 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop cf9ca55f 2021-02-04T21:28:17 Tests: Add Happy Color trace Test: angle_perftests --gtest_filter="*happy_color*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5619 Change-Id: I199c066c18412701b710eab66689107b07ec51f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2677219 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop ac8d7807 2021-02-04T20:24:35 Tests: Add Sniper 3D trace Test: angle_perftest --gtest_filter="*sniper_3d*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5618 Change-Id: Ie190dea3d5f233fb7f7ed2b10aaab939da4b374e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676790 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 95143f11 2021-02-04T19:32:51 Tests: Add Coin Master trace TBR: jmadill@google.com,timvp@google.com Test: angle_perftest --gtest_filter="*coin_master*" Bug: angleproject:5617 Change-Id: Ief6b9cdb4bc3b52f4085ba08dc32e62db1f8db8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676789 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill e5c5efc0 2021-02-05T02:39:55 Revert "Test Runner: Pick single/multi-process mode automatically." This reverts commit 573d7f34a462fa5b2ca767dd84773ae6fa460d8a. Reason for revert: Breaking ANGLE roll. No-try: true Original change's description: > Test Runner: Pick single/multi-process mode automatically. > > This enables multi-process when running with more than one test > config. This saves developers from remembering to add the arg. > It can also simplify our test configurations by allowing us to omit > the default arguments. On Android by default we stay with single > process. It also changes the --bot-mode flag into --single-process > and --multi-process which override the default behaviour. > > Bug: angleproject:5585 > Change-Id: I3dd885a8a8e6604c224693c546ff5d15224e016e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2664246 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=kbr@chromium.org,syoussefi@chromium.org,jonahr@google.com,jmadill@chromium.org,jonahr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:5585 Change-Id: I11ee1034c301aa246c4b03e29ff9b56235a1005c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676247 Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop af70ceac 2021-02-04T15:55:43 Tests: Add Fallout Shelter Online trace The trace includes calls to glDrawElements with zero count, but since that causes erros on QCOM, we have commented them out. To see them, grep for the following: glDrawElements(GL_TRIANGLES, 0, Test: angle_perftests --gtest_filter="*fallout_shelter_online*" Bug: angleproject:5615 Change-Id: I7e6a7d99f614884104df7d87dab082bef6d179e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676208 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Josip Sokcevic 953e001e 2021-02-03T14:37:57 Move metadata in OWNERS files to DIR_METADATA files Bug: chromium:1113033 Change-Id: I62504dff4c421eafe2dd23465a85f73c6b8c5a21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673686 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill df48c027 2021-02-02T13:34:29 Vulkan: Don't request aliased FB attachments. This produces undefined pixel values in GL. We can also return UNSUPPORTED if required and still be conformant. This fixes an assert in the gfx-rs portability implementation. Bug: angleproject:5601 Change-Id: Ifb84ad9b5e2365360a81cddba766b0bea81f2d51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2668311 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexis Hetu 18a5e7a6 2021-02-04T11:19:21 Enable packing extensions for the Vulkan backend The following extensions are ES2 extensions which become core in ES3: - EXT_unpack_subimage - NV_pack_subimage Since the Vulkan backend already fully supports ES3, it should be ok to enable these for ES2 contexts. This fixes all YUV related viz_unittests failures when using SwANGLE with the passthrough command decoder. Bug: chromium:1060139 Change-Id: I24ffd7a58f576799b93fe91e6be4032ca3175eda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676201 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
angle-autoroll 72815904 2021-02-04T07:00:04 Roll Chromium from 6b006f95bb79 to f5e138b74576 (467 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6b006f95bb79..f5e138b74576 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/46a0056a44..fc04613723 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d2dcdd0691..967a8819da * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5c5a2976d5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/455d077360..4ee065a4cc * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7b1875ee59..5c2436468d * tools/skia_goldctl/linux: IVFOp-Te_OC8Hb0U5-sVhId98p1bYPyyIfuRG1_azZEC..6LF5F6aXrWP5GXP59OtHK-18DPO1aPrWT-5XYQEaYBMC * tools/skia_goldctl/mac: A1gA-0qf7jDyzvaC64y1M7gCo29AH4NKhihm_wregxsC..wKJl4xmBqSYjy0jV-1mXCtsx-D8if80AIBo9uiP-nrEC * tools/skia_goldctl/win: blyrcy7Sj3SVM1D1ALLFTRtSxoOKvF0OWnGXubSAbyQC..pUKrWuFOfyPuNAzRy9gRHv-8dvvUOzMEHO9KvF9dRMIC No update to Clang. Bug: angleproject:5236 Tbr: geofflang@google.com Change-Id: I9548e0c201b7befc3aedbfc8124a8b1cd18e3eba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2674782 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 4e8a848d 2021-02-03T14:59:16 Tests: Add Shadow Fight 2 trace TBR: jmadill@google.com,timvp@google.com Test: angle_perftests --gtest_filter="*shadow_fight_2*" Bug: angleproject:5610 Change-Id: I80c6c44e19d77124096ed5970f99fbb6157bf03b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2674482 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop fff0a72e 2021-02-03T14:03:57 Tests: Add Hay Day trace TBR: jmadill@google.com,timvp@google.com Test: angle_perftests --gtest_filters="*hay_day*" Bug: angleproject:5608 Change-Id: Ib0e259f193ed08ac80f1ae7b1a738c62a235d572 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673070 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 63e7ab8d 2021-02-03T13:05:41 Tests: Add One Punch Man trace Full app name is: ONE PUNCH MAN: The Strongest (Authorized) Test: angle_perftests --gtest_filter="*one_punch_man*" Bug: angleproject:5607 Change-Id: Ib887fb06e53238e56ff5b3e2d45e5d37522a87e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673881 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 54367a3e 2021-02-02T19:31:33 Capture/Replay: Support glCopyImageSubData with compressed formats Special Forces Group 2 uses glCopyImageSubData() to copy compressed texture data, which requires special handling for ANGLE's frame capture since compressed texture data can't be read back. To support this, when glCopyImageSubData() is called with textures using compressed formats, a new mCachedTextureLevelData entry will be created for the destination texture which is a copy of the source texture data. Note that this implementation only supports copying the full level data. http://anglebug.com/5604 will track adding support for partial level copies if an app requires that in the future. Bug: angleproject:5592 Bug: angleproject:5604 Change-Id: Ibce13f91f838fd691269c796fbeb5b9c6133c6aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2669955 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Cody Northrop 2dfb3fcd 2021-02-03T10:55:58 Tests: Add 8 Ball Pool trace Test: angle_perftests --gtest_filter="*eight_ball_pool*" Bug: angleproject:5606 Change-Id: Ied7392ecb5148280e1b4cee65c7c63a0baee24fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673064 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2c685a41 2021-02-03T11:20:20 Fix the perf test runner calibration. This path was broken for the white box unit tests. Also adds argparse handling to the runner so we can more flexibly override command line arguments. Previously the broken calibration was causing some of the tests to run only a single test iteration when measuring. This could lead to low quality measurements. Bug: angleproject:5573 Change-Id: Ic1cb2b2553774a361325f290440c40b2ff90db5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2672702 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 89f50584 2021-02-03T08:51:04 Vulkan: Add ExtendedDirtyBitType bitset ExtendedDirtyBitType qualifies DIRTY_BIT_EXTENDED dirtybit. Clip control code path can now set the appropriate ExtendedDirtyBitType when there is a change in state. Also remove the ClipSpaceOrigin member in the Vulkan backend that cached front-end state. Bug: angleproject:5471 Tests: dEQP-GLES2.functional.clip_control.* Change-Id: I8dbb509ef940e7905439d32483fd67a8fc171a6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673062 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Jamie Madill 573d7f34 2021-02-01T10:36:56 Test Runner: Pick single/multi-process mode automatically. This enables multi-process when running with more than one test config. This saves developers from remembering to add the arg. It can also simplify our test configurations by allowing us to omit the default arguments. On Android by default we stay with single process. It also changes the --bot-mode flag into --single-process and --multi-process which override the default behaviour. Bug: angleproject:5585 Change-Id: I3dd885a8a8e6604c224693c546ff5d15224e016e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2664246 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop ffb36559 2021-02-03T10:22:43 Tests: Add Temple Run 2 trace TBR: jmadill@google.com,timvp@google.com Test: angle_perftests --gtest_filter="*temple_run_2*" Bug: angleproject:5605 Change-Id: I4b60b5f258e57dda44df9186c981764d4633a277 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673063 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop ad985fcd 2021-02-02T21:35:04 Tests: Add Minecraft trace Test: angle_perftests --gtest_filter="*minecraft*" Bug: angleproject:5603 Change-Id: I8befbbb49762a14beea1863f4bb76e676cde0d8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2669959 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0