|
1cd52d2c
|
2020-02-18T15:28:29
|
|
docs: Document how to use ANGLE on Android
This CL creates a new page that is dedicated to building and using
ANGLE for Android.
With Android 10 released, now anyone can try out ANGLE as their GLES
driver for debuggable apps. It can also be loaded for any app if the
user has root access.
Also migrated existing Android build instructions with updates from
the team.
Bug: angleproject:4347
Change-Id: Iead6a456780aba033a1227605f197a456ad30eb3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063569
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
f77f10f3
|
2020-03-09T07:01:56
|
|
Roll third_party/spirv-tools/src 66a682b6a8f9..4c027048d88b (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/66a682b6a8f9..4c027048d88b
Created with:
gclient setdep -r third_party/spirv-tools/src@4c027048d88b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I8a6734e9e1cd5f2f531f4bedc1ea7e5401685105
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2094684
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
c535c7d2
|
2020-03-09T07:02:01
|
|
Roll third_party/vulkan-headers/src 9bd3f561bcee..74556a131735 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/9bd3f561bcee..74556a131735
git log 9bd3f561bcee..74556a131735 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 oddhack@sonic.net Update for Vulkan-Docs 1.2.134
Created with:
gclient setdep -r third_party/vulkan-headers/src@74556a131735
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
TBR=ianelliott@google.com
Bug: None
Change-Id: I5ad970eb2807053d6e6eded91cdc4ecf045a750f
Tbr: ianelliott@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2094803
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
0945fd85
|
2020-03-09T07:55:47
|
|
Roll third_party/glslang/src aa95c80e1a89..6861ea4e10a1 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/aa95c80e1a89..6861ea4e10a1
Created with:
gclient setdep -r third_party/glslang/src@6861ea4e10a1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: jmadill@google.com
Change-Id: I9eb2c38a1e62e07425f48201f62f96aefec914d7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2094688
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
717fa7a9
|
2020-03-09T07:01:42
|
|
Roll third_party/SwiftShader 51b2800bb317..b44162fdbb25 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/51b2800bb317..b44162fdbb25
git log 51b2800bb317..b44162fdbb25 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 madesroches@google.com Support for the largePoints feature in Vulkan
2020-03-06 capn@google.com Explicitly compile with warnings-as-errors
Created with:
gclient setdep -r third_party/SwiftShader@b44162fdbb25
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I1642eeaf1cbf2e9e86db0180ae09db1fb58a3081
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2094683
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
0c9b6abd
|
2020-02-06T08:53:16
|
|
Skip invalid end2end test for ES2
Previously, the incomplete framebuffer depth stencil attachment
test would run on ES2 if GL_OES_packed_depth_stencil were present.
This is insufficient since it uses the GL_DEPTH_STENCIL_ATTACHMENT
enum, which is not introduced in any extension prior to ES3. The
test has been disabled on ES2, regardless of extensions.
Bug: angleproject:4454
Test: angle_end2end_tests --gtest_filter=StateChangeTest.FramebufferIncompleteDepthStencilAttachment/*
Change-Id: Ic5a6a521e35b49c5d723b33f588fa608264d6390
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090783
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
03ed5f6c
|
2020-03-06T22:15:42
|
|
Revert "Instantiate rx::DisplayEGL when device type EGL is selected"
This reverts commit 7455b54401dd55833944b5ad857ccd9852ef6a79.
Reason for revert: This appears to break the "Linux FYI Ozone (Intel)" bots on the chromium.gpu.fyi waterfall. Ozone means ChromeOS.
Original change's description:
> Instantiate rx::DisplayEGL when device type EGL is selected
>
> Define EGL_PLATFORM_ANGLE_DEVICE_TYPE_EGL_ANGLE that should be
> used to request a driver egl-backed implementation with ANGLE.
>
> Bug: angleproject:4328
> Change-Id: I6871d3a27e2bfc02af9815dcf86ae1cb6524f0cc
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2030038
> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
TBR=geofflang@chromium.org,syoussefi@chromium.org,jonahr@google.com,julien.isorce@chromium.org
Change-Id: I8aec6c2783b0acb67d3315d351cdc9e526f58d6b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4328
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2091864
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
1a5c7a16
|
2020-02-25T12:02:31
|
|
Reland "Vulkan:Include precision qualifier in GLSL"
Currently still ignoring precision qualifiers for Vulkan shaders by
default, but have added feature "enablePrecisionQualifiers" that can be
enabled in order to include precision qualifiers.
With this initial implementation, it's possible to get precision
qualifier mis-matches in the generated GLSL 4.50. According to the
spec this is allowed. From GLSLangSpec 4.50 section 4.7 "Precision and
Precision Qualifiers":
For the purposes of determining if an output from one shader stage
matches an input of the next stage, the precision qualifier need not
match.
However, when converted to SPIR-V and run through the shader validation
any mismatches will cause shader validation errors. Initially just
ignoring those errors with this commit.
Bug: angleproject:3078
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057749
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
Change-Id: Ieecca604bb2c834c9b1c2bcab85279d1f8755dfa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2086280
|
|
7455b544
|
2020-03-03T00:13:03
|
|
Instantiate rx::DisplayEGL when device type EGL is selected
Define EGL_PLATFORM_ANGLE_DEVICE_TYPE_EGL_ANGLE that should be
used to request a driver egl-backed implementation with ANGLE.
Bug: angleproject:4328
Change-Id: I6871d3a27e2bfc02af9815dcf86ae1cb6524f0cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2030038
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
20c69733
|
2020-03-06T11:02:31
|
|
Fix GN warning about unused variable when angle_enable_commit_id=false
BUG=angleproject:2344
Change-Id: I3a0c8384d280755557fd425e80877addd756a9ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2091625
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
3797fc85
|
2020-03-05T11:44:28
|
|
Generate new compiler errors for array-of-arrays
The GLES GLSL 3.1 spec states that it is an error to use array-of-arrays
in the following cases:
- Vertex shader outputs
- Fragment shader inputs
- Fragment shader outputs
ANGLE currently generates errors in the case of vertex shader inputs.
It needs to add the above cases.
Reproduce by running "angle_deqp_khr_gles31_tests" with:
--gtest_filter=dEQP.KHR_GLES31/core_arrays_of_arrays_InteractionInterfaceArrays2* --use-angle=swiftshader
Bug: angleproject:4148
Change-Id: I1147fc7d4755e5b6c07d2ab5d14566d919dec530
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2087647
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
e8883562
|
2020-03-06T09:32:18
|
|
Add a GN argument to enable/disable commit_id.
Some android builds are done when .git is not present.
BUG=angleproject:2344
Change-Id: Ic5418fb3b8161855e9c62d877eee22dabee846ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090684
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
81cee994
|
2020-03-06T07:19:16
|
|
Roll third_party/glslang/src c6a4c6d3d8b5..aa95c80e1a89 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c6a4c6d3d8b5..aa95c80e1a89
Created with:
gclient setdep -r third_party/glslang/src@aa95c80e1a89
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I4d6b98f7f8ea3104c38857bc3034414f9c310eb1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2091042
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d763f1eb
|
2020-03-06T07:01:40
|
|
Roll third_party/vulkan-tools/src 1af57a3ec414..94ed4c384c34 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1af57a3ec414..94ed4c384c34
git log 1af57a3ec414..94ed4c384c34 --date=short --first-parent --format='%ad %ae %s'
2020-03-05 raul@tambre.ee generate_vulkan_layers_json.py: Fix Python 3 compatibility
Created with:
gclient setdep -r third_party/vulkan-tools/src@94ed4c384c34
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I21b034d0268768f80966037c6cd9abd1033132fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2091040
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d2e50306
|
2020-03-06T07:01:37
|
|
Roll third_party/SwiftShader a095711c5d77..51b2800bb317 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/a095711c5d77..51b2800bb317
git log a095711c5d77..51b2800bb317 --date=short --first-parent --format='%ad %ae %s'
2020-03-05 capn@google.com Support launching PowerVR samples from Visual Studio using SwiftShader
Created with:
gclient setdep -r third_party/SwiftShader@51b2800bb317
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: Ib0e4cd11fb701707932546e10c087a58bfdcab01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2091039
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1a41937a
|
2020-03-06T07:01:42
|
|
Roll third_party/spirv-tools/src 044ecc0b2c65..66a682b6a8f9 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/044ecc0b2c65..66a682b6a8f9
Created with:
gclient setdep -r third_party/spirv-tools/src@66a682b6a8f9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I549f8d82cfdbe52cbc704ce27f4b142b5ae2723f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2091041
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
9acaf662
|
2020-02-28T14:58:17
|
|
Add timer query support to TracePerfTests.
This can allow us to get some profiling measurements on ANGLE vs a
native driver. We correlate host times with GL times using the blocking
timestamp query. We also time RenderPasses/FBO switches using the
trace instrumentation we added in an earlier patch combined with timer
queries.
Not currently instrumented for the current tests. We'll need to re-run
capture to get the callbacks working correctly.
Bug: angleproject:4433
Change-Id: I8f61774a3a090ac9460a378d34715a72954d1331
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080597
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
55228e53
|
2020-03-04T18:25:47
|
|
Add Chrome texture formats test for VulkanExternalImageTest
This make sure the VkFormat/internalformat combinations that Chrome uses
succeed import, which in particular requires the object size to match.
Allowing VK_FORMAT_R8G8B8_UNORM VkFormat for GL_RGB8 will make this test
fail when run on a native vulkan that supports that format.
Bug: chromium:1058521
Change-Id: I91483568ba8552f40314f10215bfea59e5ca2b94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2088652
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
85265395
|
2020-03-05T07:01:36
|
|
Roll third_party/SwiftShader 126720bd2e57..a095711c5d77 (4 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/126720bd2e57..a095711c5d77
git log 126720bd2e57..a095711c5d77 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 amaiorano@google.com Subzero: implement Short4::Short4(RValue<Float4)
2020-03-04 amaiorano@google.com Subzero: don't assert about lack of atomic load/store on x86
2020-03-04 amaiorano@google.com Fix Regres regression post CMake var renaming
2020-03-04 amaiorano@google.com Subzero: fix regression in Optimizer
Created with:
gclient setdep -r third_party/SwiftShader@a095711c5d77
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I9f8e2084134732edfe709ece8882976b5517c70b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2089017
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2894d57e
|
2020-03-05T07:01:42
|
|
Roll third_party/spirv-tools/src a6d3a2dd41d4..044ecc0b2c65 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a6d3a2dd41d4..044ecc0b2c65
Created with:
gclient setdep -r third_party/spirv-tools/src@044ecc0b2c65
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I02a17dc219c3909029768466424bf457d475896b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2089018
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
343ee4e8
|
2020-03-05T07:01:16
|
|
Roll third_party/glslang/src 8985fc91089f..c6a4c6d3d8b5 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8985fc91089f..c6a4c6d3d8b5
Created with:
gclient setdep -r third_party/glslang/src@c6a4c6d3d8b5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: Icd0150b1918bd88b18a18453d49cd64adc02fe2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2089016
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
c55fbc40
|
2020-03-01T16:23:05
|
|
Capture/Replay: Fill out more ES 3.0 state in mid-execution capture
Test: Manhattan mid-execution capture working
Bug: angleproject:3662
Bug: angleproject:4091
Change-Id: Id7f1a3f667229e4d5abedb3ada25d44db250605a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080592
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
ca04de85
|
2020-03-03T09:59:42
|
|
Vulkan: blacklist VK_FORMAT_R8G8B8_UNORM
Chrome makes assumptions that depend on ANGLE implementing 24bit
RGB as 32 RGBX. Since that was the behavior of ANGLE for a while,
remove those formats from the VK format table to force that behavior
again.
Test: Chrome on Fuchsia
Bug: angleproject:4282
Change-Id: I22a3f07b00d7870044ed6b3326dd528721b89af8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2085043
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
|
|
|
e682bc57
|
2020-03-01T16:19:32
|
|
Capture/Replay: Add Sampler Object support to mid-execution capture
Test: Manhattan mid-execution capture working
Bug: angleproject:3662
Bug: angleproject:4091
Change-Id: Iafa528e2a25efe1c49eb49ecc429eac8f25c162c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080591
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
6125419c
|
2020-03-04T10:31:26
|
|
Vulkan: Suppress some flaky tests for Intel Linux driver
Bug: angleproject:4453
Change-Id: I55475f85298a593597daa300effa828a6b0ed342
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2087896
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
9459bae1
|
2020-03-01T16:17:41
|
|
Capture/Replay: Add Vertex Array Object support to mid-execution capture
Test: Manhattan mid-execution capture working
Bug: angleproject:3662
Bug: angleproject:4091
Change-Id: I5d16e8faed759507c85b6358b65750fe5c33ddfe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079190
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
f8ecac29
|
2020-03-01T16:16:18
|
|
Capture/Replay: Add TransformFeedback Object support to mid-execution capture
Test: Manhattan mid-execution capture working
Bug: angleproject:3662
Bug: angleproject:4091
Change-Id: Ibaa708085c5707a4ece637186daeafe6c681068f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2070901
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
605ab763
|
2020-02-24T19:43:32
|
|
D3D11: Implement OES_draw_buffers_indexed
Existing CONSTANT_COLOR/CONSTANT_ALPHA limitation was generalized to independent blend states with draw call invalidation and a new end2end test. dEQP tests that are incompatible with this limitation result in INVALID_OPERATION and are marked as FAIL.
D3D11 renderer always normalizes and deduplicates requested blend states based on their enabled features and bound framebuffer.
Bug: angleproject:4394
Change-Id: I284796e18be71de1b5bfb087d36f6a45be4c3f70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2070575
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
f143ab1f
|
2020-03-03T17:15:38
|
|
Vulkan: Disable forceOldRewriteStructSamplers for SwS-Android
Disable the forceOldRewriteStructSamplers feature for SwiftShader on
Android. Another change fixed the issue that prevented SwiftShader on
Android from supporting sampler arrays as parameters. The Qualcomm
driver still cannot support sampler arrays as parameters, and so it
still needs forceOldRewriteStructSamplers.
Bug: angleproject:4071
Bug: angleproject:2703
Change-Id: I77fbfacdad6cd9cc918c79fa0918f15de0558ce0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2086282
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
e45fe217
|
2020-02-29T23:28:33
|
|
Fix up EGLSurfaceTest.
* removes the SwapInterval test. This test was not really based on
spec language. SwapInterval is highly os-dependent so likely a
robust test would include some OS-specific logic instead of timing.
* give the pbuffer surface non-zero dimensions. this fixes an uncaught
error on Windows and may give better results.
* lifts a couple Android suppression possibly related to the pbuffer
bug. a couple tests still fail.
Bug: angleproject:3123
Bug: angleproject:3162
Change-Id: I68e4e943b94d17777704bbe3b8ae7e646fc9c54d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2082131
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
27a81308
|
2020-02-29T12:53:45
|
|
Vulkan: Re-enable RobustResourceInitTest.Texture test
Commit "Vulkan: Add robust init for NULL texture image." for
angleproject:4255 also fixed angleproject:3416, re-enable the
disabled test in 3416.
Bug: angleproject:3416
Change-Id: I36c09d90eafe9dea0b477c49487284d4a305d992
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2086931
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
3f283eb2
|
2020-03-04T07:01:40
|
|
Roll third_party/vulkan-tools/src a553ed74b7fe..1af57a3ec414 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/a553ed74b7fe..1af57a3ec414
git log a553ed74b7fe..1af57a3ec414 --date=short --first-parent --format='%ad %ae %s'
2020-03-03 charles@lunarg.com vulkaninfo: Refactor error handling
Created with:
gclient setdep -r third_party/vulkan-tools/src@1af57a3ec414
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: Ia770492b1bcc1237088a5e1d24e1f9e263849474
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2086710
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d62881ce
|
2020-03-04T07:01:39
|
|
Roll third_party/vulkan-validation-layers/src f32bf1c930c8..97484d689869 (16 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f32bf1c930c8..97484d689869
git log f32bf1c930c8..97484d689869 --date=short --first-parent --format='%ad %ae %s'
2020-03-03 mark@lunarg.com practices: Call statetracker base for all record funcs
2020-03-03 mark@lunarg.com practices: Remove static extension deprecation info
2020-03-03 mark@lunarg.com practices: Add code-generated checks for deprecated exts
2020-03-03 mark@lunarg.com scripts: Updated bp gen to collect deprecation info
2020-03-03 mark@lunarg.com practices: Hook up code-gen'd VkResult warning checks
2020-03-03 mark@lunarg.com scripts: Add best practices gen'd files to generate_source
2020-03-03 mark@lunarg.com scripts: Add best practices files
2020-03-03 mark@lunarg.com scripts: Update lvl_genvk.py for best practices files
2020-03-03 mark@lunarg.com scripts: Add best practices code generator script
2020-03-03 mark@lunarg.com practices: Change names of non-generated bestpractices files
2020-03-03 mark@lunarg.com logging: Use core object types in place of deprecated ones
2020-03-03 mark@lunarg.com utils: Fix invalid utils create info sType
2020-03-03 mark@lunarg.com tests: Use bespoke enums for error type
2020-03-03 mark@lunarg.com utils: Use local warn/error/info enum defs
2020-03-03 mark@lunarg.com tests: Enable debug utils for test framework
2020-03-03 jasuarez@igalia.com build: Export build commands
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@97484d689869
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: Ia6a912a6640798f5c3675c285c3ec79dd5c97ce1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2086709
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
7a14bf5b
|
2020-03-04T07:03:42
|
|
Roll third_party/spirv-tools/src e1688b60caf7..a6d3a2dd41d4 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e1688b60caf7..a6d3a2dd41d4
Created with:
gclient setdep -r third_party/spirv-tools/src@a6d3a2dd41d4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I00b1e4237a42f03ea300f35d7f4b620398e9857e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2086992
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
ad841521
|
2020-03-04T07:01:37
|
|
Roll third_party/SwiftShader 176f3a3dbbc9..126720bd2e57 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/176f3a3dbbc9..126720bd2e57
git log 176f3a3dbbc9..126720bd2e57 --date=short --first-parent --format='%ad %ae %s'
2020-03-03 jrprice@google.com Use LINK_FLAGS for -BSymbolic in CMake build
2020-03-03 capn@google.com Fix ASTC support for GN build
Created with:
gclient setdep -r third_party/SwiftShader@126720bd2e57
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: Ie161f3f836c27c81d02d7983b7a9e95e51dd5bd4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2086708
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1c233bdd
|
2020-03-04T07:01:17
|
|
Roll third_party/glslang/src 56364b6b6026..8985fc91089f (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/56364b6b6026..8985fc91089f
Created with:
gclient setdep -r third_party/glslang/src@8985fc91089f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I6bc0fe374c073513f4036faff0e8e834ef171c4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2086707
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
028a7a72
|
2020-03-03T18:19:33
|
|
Skip if GL_EXT_texture_compression_dxt1 isn't supported
If GL_EXT_texture_compression_dxt1 is not support, will be failed
at glCompressedTexImage2D in CopyCompressedTextureTest.Immutable
Bug: angleproject:1424
Change-Id: I287c6a40c1c09fa379088e5ad4bec06f0dfc2f59
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2086533
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
9e9493f2
|
2020-03-03T21:03:01
|
|
Skip crashing dEQP-GLES3.functional.samplers.*_tex_3d.* on SwANGLE
Started after
https://chromium-review.googlesource.com/c/angle/angle/+/2076740
Bug: angleproject:3983
Change-Id: I4073baa36aebd4bbd210bb0a0f46959b9ef66450
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2086695
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
54bd0005
|
2020-03-01T16:13:23
|
|
Capture/Replay: Add Query Object support to mid-execution capture
Test: Manhattan mid-execution capture working
Bug: angleproject:3662
Bug: angleproject:4091
Change-Id: I3e0d0fb1692b1fda08fd057d528f70aa5e50ef1c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2070900
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
dfae826d
|
2020-03-01T16:07:49
|
|
Capture/Replay: Update getTexImage for depth/stencil and 3D
3D support based on work from ancheng.qiao@arm.com.
Test: Manhattan mid-execution capture working
Bug: angleproject:4058
Bug: angleproject:4091
Change-Id: I7f8b8542fbc1f3484a2451850db0dc752c0b8906
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2070899
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
90019cea
|
2020-02-26T18:04:25
|
|
Vulkan: Add depth to mipmap generation
In generateMipmaps, remove hard coded depth of 1, shift depth
like every other dimension.
Remove MipmapsForTexture3D test pixel value check, in es spec3.2 8.14.4
"No particular filter algorithm is required, though a box filter is recommended."
It's implementation-dependent. In current angle implementation, will
choose VK_FILTER_LINEAR/VK_FILTER_NEAREST according to vkdeice support.
Bug: angleproject:3983
Test: MipmapTestES3.MipmapsForTexture3D/ES3_Vulkan
Test: dEQP-GLES3.functional.samplers.single_tex_3d.diff_max_lod
Test: dEQP-GLES3.functional.samplers.single_tex_3d.diff_min_lod
Test: dEQP-GLES3.functional.samplers.multi_tex_3d.diff_max_lod
Test: dEQP-GLES3.functional.samplers.multi_tex_3d.diff_min_lod
Change-Id: I5e73f8c743053aeb521b5e0b3e372bbe77e57ad2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076740
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
f8b28678
|
2020-02-26T19:12:39
|
|
Vulkan: Add support for VK_EXT_index_type_uint8
Enable VK_EXT_index_type_uint8 Vulkan extension if supported by
VkDevice.
Bug: angleproject:4405
Change-Id: I84d030497898c5944a36d9a88a31e7377ccd5e9e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2082391
Commit-Queue: Xiaoxuan Liu <xiaoxuan.liu@arm.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
c3655c3a
|
2020-03-03T07:01:36
|
|
Roll third_party/SwiftShader 416d37452275..176f3a3dbbc9 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/416d37452275..176f3a3dbbc9
git log 416d37452275..176f3a3dbbc9 --date=short --first-parent --format='%ad %ae %s'
2020-03-02 swiftshader.regress@gmail.com Regres: Update test lists @ 416d3745
2020-03-02 capn@google.com Enable ASTC on supported builds only
Created with:
gclient setdep -r third_party/SwiftShader@176f3a3dbbc9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I905ac74551a8401d889b93e582499488b133bc0e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2084432
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
c9cf5066
|
2020-03-03T07:01:39
|
|
Roll third_party/vulkan-validation-layers/src cb689b0b1d30..f32bf1c930c8 (8 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/cb689b0b1d30..f32bf1c930c8
git log cb689b0b1d30..f32bf1c930c8 --date=short --first-parent --format='%ad %ae %s'
2020-03-03 s.fricke@samsung.com tests: Add tests for checking sType-unique
2020-03-03 s.fricke@samsung.com layers: Add support for sType-unique and most pNext-pNext
2020-03-02 s.fricke@samsung.com tests: Add tests for 02280 and 02281
2020-03-02 s.fricke@samsung.com layers: Add support for 02280 and 02281
2020-03-02 s.fricke@samsung.com tests: Add test for 01545
2020-03-02 s.fricke@samsung.com layers: Add support for 01545
2020-03-02 s.fricke@samsung.com layers: Rename ValidateComputePipelineShaderState
2020-03-02 s.fricke@samsung.com layers: Label VUID 00337, 00338, 00339
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@f32bf1c930c8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I5330a0a9ac8f2078e31ef5c2ed81642a15939c0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2084433
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
b84969ad
|
2020-02-29T09:14:36
|
|
Vulkan: Use QueryHelper for internal GPU timing.
This cleans up the code. Using QueryHelper means we don't need to
duplicate the timestamp query/result code. It also means we don't need
special allocate/free functions in DynamicQueryPool.
Done while investigating timing GPU events for T-Rex.
Bug: angleproject:4433
Change-Id: I8512a5618e1dd00956942ae2d12d46d8193c4e51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2081379
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
4fb29948
|
2020-02-12T13:48:43
|
|
Split up EGLContextCompatibilityTest.
Instead of attempting to run numConfigs^2 test permutations in a single
test we now split up each config into its own test. Each permutation
also gets a unique name based on the configs it is testing. Because
there were so many tests on some back-ends (e.g. D3D11) this CL adds
a way to hard limit the number of test permutations by discarding
random tests to reach a specified maximum per back-end.
Uses the GoogleTest "RegisterTests" API instead of using the GTEST
macros. See online GTest docs for more info.
This will allow more easily supporting test timeouts when running
batches of tests multi-process.
As a side effect we no longer need to restrict this test to Release
builds or ignore some renderers.
Bug: angleproject:4449
Change-Id: Ia7991e2a3906175413b77a876432061da527d03b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050812
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
a1e5f582
|
2020-02-29T08:01:16
|
|
Vulkan: Clean up QueryHelper uses.
Makes the wrapper classes take boxed query handles. Also cleans up some
repeated code patterns. It also encapsulates the QueryHelper class more
so that the pool indexes and handles are hidden from the user of the
class.
Fixed while working on GPU trace event timing.
Bug: angleproject:4433
Change-Id: Ib6cba9c52ec956ebede9b411b70261ea5b877d7d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2081378
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
80f55e97
|
2020-02-28T15:05:41
|
|
Expose glGetInteger64vEXT.
This entry point is specifically for retrieving very large timestamp
values from EXT_disjoint_time_query. In GLES 2.0 contexts with the
Vulkan back-end we were getting some astronomical values that couldn't
be cast to 32-bit ints.
Also fix missing dependencies in generate_loader.py.
Bug: angleproject:4433
Change-Id: I59146dcc1a163a24ac2d7c37546f4551a7a8890a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080595
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
51a9da21
|
2020-02-28T13:57:25
|
|
Add OES_draw_buffers_indexed autogenerated wrappers and validation redirects.
This extension allows setting independent blend state (and color write mask) for each draw buffer. OES and EXT versions provide exactly the same functionality. It is also included in GLES 3.2 core.
Bug: angleproject:4394
Change-Id: I0c27c419472622e309a038dd1463fa0b3e4ca595
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2078587
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
deb65a6f
|
2020-02-27T15:58:17
|
|
Add scripts for rolling and generating Android.bp for AOSP
BUG=angleproject:2344
Change-Id: I379cc924a6126e22b16e4cb096026d881e06763d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079195
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
ff60abaf
|
2020-02-28T14:06:07
|
|
Vulkan:Disable FramebufferVk cache on Apple
Currently hitting a crash on Apple so disabling FramebufferVk cache.
Bug: angleproject:4442
Change-Id: I3824252210aeeaf9919c8d17730395b394a50862
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080661
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
|
dd19d554
|
2020-03-02T09:41:22
|
|
Change commit_id 'check' back to looking for .git files.
commit_id.py was change to try running 'git status' to confirm that git
was present. This caused it to succeed if there was a git checkout
somewhere above ANGLE if ANGLE's .git didn't exist, incorrectly adding
a non-existant .git/HEAD file to the gn rule's inputs.
Always verify that ANGLE's .git/HEAD is present in commit_id.py.
BUG=angleproject:2344
Change-Id: I7e170f39c8d5cef73086ecf6d68925a1d3512de1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2082993
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
35785308
|
2020-02-24T17:37:55
|
|
Vulkan: reserve extra varyings
when basicGLLineRasterization or supportsTransformFeedbackExtension is enabled.
updated with MaxVaryingWithFeedbackAndGLline
adding test to validate pixel value (disabled for macos)
Bug: angleproject:4273
Change-Id: Ie3d3516fd3806c0d622fb402ba8223d302206f73
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2071237
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
73034dfd
|
2020-03-02T07:01:39
|
|
Roll third_party/vulkan-validation-layers/src 8c312ef4c7a9..cb689b0b1d30 (4 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8c312ef4c7a9..cb689b0b1d30
git log 8c312ef4c7a9..cb689b0b1d30 --date=short --first-parent --format='%ad %ae %s'
2020-02-28 attilio.provenzano@arm.com tests: Add BP tests for images and buffers
2020-02-28 attilio.provenzano@arm.com practices: Add checks for images and buffers
2020-02-28 mark@lunarg.com gpu: Remove unneeded refs to debug report enums
2020-02-28 igor.ostrowski@intel.com layers: Fix layer settings file loading using registry
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@cb689b0b1d30
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Change-Id: I48ffc0a181c5e984a4dfe5a8fefa5593509f795e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2082872
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
85e11542
|
2020-03-02T07:01:37
|
|
Roll third_party/SwiftShader 05f5e0b34ac8..416d37452275 (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/05f5e0b34ac8..416d37452275
git log 05f5e0b34ac8..416d37452275 --date=short --first-parent --format='%ad %ae %s'
2020-02-28 jmadill@chromium.org PipelineCache: Handle nullptr mismatch of specialization info.
2020-02-28 sugoi@google.com Implement ASTC support
2020-02-28 jonahr@google.com Add missing attribute to eglGetConfigAttrib
Created with:
gclient setdep -r third_party/SwiftShader@416d37452275
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: angleproject:4426
Tbr: geofflang@google.com
Change-Id: I6df3cd9ecc97806bafe670bc7a0ce597948e2220
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2082871
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
85e8a452
|
2020-03-02T07:01:42
|
|
Roll third_party/spirv-tools/src 70f888131ede..e1688b60caf7 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/70f888131ede..e1688b60caf7
Created with:
gclient setdep -r third_party/spirv-tools/src@e1688b60caf7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Change-Id: I5c52fb8063236eefaa8d4ff7a06840fab8f34979
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2082873
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
6e1e64d8
|
2020-03-02T07:01:16
|
|
Roll third_party/glslang/src f13d38f3cd3c..56364b6b6026 (5 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f13d38f3cd3c..56364b6b6026
Created with:
gclient setdep -r third_party/glslang/src@56364b6b6026
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Change-Id: I19bf8db8655a2d5a0809134b575d72ac8168f9f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2082490
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
fd75545f
|
2020-03-01T20:59:48
|
|
Test Runner: Add stub register function to GLES 1 CTS.
These tests use the same main function as end2end_tests. Add the
register function stub so the compilation works correctly in standalone
and component builds.
Bug: angleproject:4449
Change-Id: Id240a834ae0e358d0e2520b12842f3f337c0aa31
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2081514
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
da2e65c0
|
2020-03-01T13:01:24
|
|
Test Runner: Add stub register function to white box tests.
These tests use the same main function as end2end_tests. Add the
register function stub so the compilation works correctly in standalone
and component builds.
Bug: angleproject:4449
Change-Id: Ib1558a596b9a558b16a7c5b7bfccc1e495a67e39
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2082135
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
390be9bb
|
2020-03-01T08:47:37
|
|
Test Runner: Use system path for gtest-internal.
This ensures we use the correct internal path in Chromium builds as
well.
Bug: angleproject:3162
Change-Id: I036dcbd8802f67162e5f5eccb6158910f0a5efcc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2082134
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
49a68f18
|
2020-03-01T08:12:53
|
|
Add RegisterContextCompatibilityTests stub.
We'll call this function from the Chromium angle_end2end_tests main.
First this CL needs to roll into Chrome. Then we can make a second CL
in ANGLE to change the way the EGLContextCompatibilityTests are set up.
This is to break up the slow tests into smaller pieces. See the issue
for more details.
Bug: angleproject:4449
Change-Id: Icc10679c61fd2f7a5e396f7a310ffcfd0b45893b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2082133
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
daf6e471
|
2020-02-28T15:12:48
|
|
Upgrade gl2ext.h.
Includes a new entry point needed for disjoint timer queries. This
header is copied exactly from Khronos's official repo. We add one
change so that we can include special ANGLE modifications in
gl2ext_angle.h.
Bug: angleproject:4433
Change-Id: I6c9cbdfa73ca3de052ff49c5ea91eb5e9a9ee699
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080596
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
94d399ca
|
2020-02-28T08:18:37
|
|
Trace/Replay: Add framebuffer change callback.
The perf tests can use this callback to instrument timer queries to
delineate render pass times on the device.
The new call pattern in the replay looks like this:
glBindFramebuffer(GL_FRAMEBUFFER, gFramebufferMap[1]);
OnFramebufferChange(GL_FRAMEBUFFER_OES, gFramebufferMap[1]);
Bug: angleproject:4433
Change-Id: Ice5150741d1d5becb26d60020e8c00e3a2fb6218
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2074337
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
54bc3dab
|
2020-02-27T15:52:04
|
|
Add the ANGLE Android developer options to the ANGLE repository.
The ANGLE repository will house all the scripts needed to build
ANGLE.apk and the developer options are packaged in the APK.
BUG=angleproject:2344
Change-Id: I29090bd91a07546a1d2ccc03a6af19f45ffa3d90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079194
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
b07816d6
|
2020-01-02T15:13:37
|
|
Vulkan: Add robust init for NULL texture image.
In gl::ReadPixels(), ValidateReadPixels() will try to
flush staged updates before readPixels. In the case
where a texture was initialized with null RGBA data,
no Framebuffer dirty bits are set, and thus the staged
clear would never be flushed from the staged updates.
1. Add robust init in TextureVk::initImage to ensure
image is initialized.
Test: ./angle_end2end_tests --gtest_filter=\
RobustResourceInitTest*_Vulkan_AllocateNonZeroMemory
2. Update stageSubresourceRobustClear() to
kEmulatedInitColorValue in the case where robust resource
was initialized without full RGBA format to update
init value of robust resource.
Test: texture-attachment-formats.html in
webgl_conformance_vulkan_passthrough_tests.
3. Revert "Suppress Vulkan RobustResourceInit tests."
Revert commit a8e6a463121b9920564fb6efd7f2c857d7023fe3.
Reason for revert: re-enable related robust tests.
Bug: angleproject:4255
Change-Id: I79f20e0c02c2f1b1cd68ab590f0f765229f9e780
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1985503
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
6c56c579
|
2020-01-21T11:08:36
|
|
Add Android boot animation and rounding error test
This introduces an end2end test that makes the same GLES1
calls as Android's default boot animation. The test uses
images of much smaller sizes, but we do the same thing
with the images as the original code (it uses one image as a
mask and moves the other along behind it).
The original default boot animation code can be found here:
https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/cmds/bootanimation/BootAnimation.cpp#422
This change also implements glTexParameterx since the default boot
animation requires it. This function is part of OES_FIXED_POINT.
This also includes a test to check for int to floating point cast errors
when using GL_TEXTURE_CROP_RECT_OES.
Tests: angle_end2end_tests --gtest_filter=*DefaultBootAnimation*
angle_end2end_tests
--gtest_filter=*TextureParameterTest.IntConversionsAndIntBounds*
Bug: angleproject:3644
Change-Id: Ib7e99c9dc1c001c71543d03ea4dd76082192f6a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053506
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
|
|
|
fb551728
|
2020-02-28T11:10:29
|
|
Suppress SwANGLE dEQP-GLES3.functional.texture.compressed.astc.* failures
Started after SwiftShader enabled ASTC in
https://swiftshader-review.googlesource.com/c/SwiftShader/+/41568
Bug: angleproject:4447
Change-Id: I251ff26d4972f17f1f76f8ad1df57dc9c539782c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2078755
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
1e1d7446
|
2020-02-28T07:33:16
|
|
Roll third_party/glslang/src 07e1a0a67aee..f13d38f3cd3c (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/07e1a0a67aee..f13d38f3cd3c
Created with:
gclient setdep -r third_party/glslang/src@f13d38f3cd3c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Change-Id: I076b53154399d1d6bf03f7c1def768986d7752cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080041
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
936f9069
|
2020-02-28T07:01:39
|
|
Roll third_party/vulkan-validation-layers/src 38f68cce445b..8c312ef4c7a9 (5 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/38f68cce445b..8c312ef4c7a9
git log 38f68cce445b..8c312ef4c7a9 --date=short --first-parent --format='%ad %ae %s'
2020-02-27 mark@lunarg.com threading: Remove use of debug report defs
2020-02-27 attilio.provenzano@arm.com tests: Add BP tests for small allocations
2020-02-27 attilio.provenzano@arm.com practices: Add checks for memory allocations
2020-02-27 attilio.provenzano@arm.com tests: Add BP tests for command buffers
2020-02-27 attilio.provenzano@arm.com practices: Add checks for command buffers
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@8c312ef4c7a9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Change-Id: I95d6318d381accc38b0c6a8743cb7c2e3bb7927e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080039
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
8c6e40d2
|
2020-02-28T07:01:37
|
|
Roll third_party/SwiftShader 4b34ee3de531..05f5e0b34ac8 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/4b34ee3de531..05f5e0b34ac8
git log 4b34ee3de531..05f5e0b34ac8 --date=short --first-parent --format='%ad %ae %s'
2020-02-27 jmadill@chromium.org Add codereview.settings.
2020-02-27 amaiorano@google.com Subzero: add support for variadic calls (System V)
Created with:
gclient setdep -r third_party/SwiftShader@05f5e0b34ac8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Change-Id: I938aa6bcdd73607f4684000806d93befd8ec00d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080038
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
a60e4973
|
2020-02-27T20:11:20
|
|
Revert "Vulkan:Include precision qualifier in GLSL"
This reverts commit 93e72f5f0eb80b89334ea8fe577b32901a00b5fb.
Reason for revert: This is having a negative impact on gfxbench
Manhattan 3.1 tests (20-30%) with only a minor improvement (~4%) in TRex offscreen. Pulling out for now and need to re-evaluate best
solution here.
Original change's description:
> Vulkan:Include precision qualifier in GLSL
>
> With this initial implementation, it's possible to get precision
> qualifier mis-matches in the generated GLSL 4.50. According to the
> spec this is allowed. From GLSLangSpec 4.50 section 4.7 "Precision and
> Precision Qualifiers":
>
> For the purposes of determining if an output from one shader stage
> matches an input of the next stage, the precision qualifier need not
> match.
>
> However, when converted to SPIR-V and run through the shader validation
> any mismatches will cause shader validation errors. Initially just
> ignoring those errors with this commit.
>
> Bug: angleproject:3078
> Change-Id: Ia2b04f90f0a7b6b1302c1b1b3e32bcfd8db9ed49
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057749
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Tobin Ehlis <tobine@google.com>
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Commit-Queue: Tobin Ehlis <tobine@google.com>
TBR=tobine@google.com,timvp@google.com,jmadill@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: angleproject:3078
Change-Id: I84984e2a963bde573f0f1de585001ceb83623c89
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079334
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
78da538a
|
2020-02-26T21:23:16
|
|
Revert "Vulkan: Disable global merge for volk"
This reverts commit bab2b3de2273796ca15edfc46747f3bbab3f27c3.
Reason for revert:
A fixed clang version has been rolled in, so this flag should no longer
be necessary.
Original change's description:
> Vulkan: Disable global merge for volk
>
> This optimization pass breaks the build by exporting volk's internal
> binding symbols from libGLESv2.so. Since the test binary also links
volk,
> this causes a SEGV as the wrong (uninitialized) function pointer is
> called.
>
> This is an LLVM bug and will be fixed upstream:
> https://reviews.llvm.org/D73235
>
> Bug: angleproject:4351
> Change-Id: Iebe0eabd975f8109231df30eef8c9074af8190e9
> Reviewed-on:
https://chromium-review.googlesource.com/c/angle/angle/+/2023910
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Michael Spang <spang@chromium.org>
TBR=spang@chromium.org,syoussefi@chromium.org,jmadill@chromium.org
Bug: angleproject:4351
Change-Id: Ie832d7d42fab7c8360f2d4d548f1708164c60d3f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076138
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
|
|
|
5dde4db5
|
2020-02-27T15:39:30
|
|
Capture/Replay: Capture DrawBuffersEXT.
The extension entry point can forward to the ES 3.0 entry point. Needed
for capturing the mutiple draw buffers sample.
Bug: angleproject:4433
Change-Id: I1081e6a5ad57eca6dc328947bb0f9037d47fe9f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079155
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
da6d12d0
|
2020-02-27T14:20:32
|
|
Fix out-of-bounds read in test.
The test wasn't reserving a large enough buffer when initializing
the vertex data. Fix the test buffer limits.
Bug: angleproject:4430
Change-Id: I4b9a98e1af1cc8088afb871816061d7ee4dd6a2c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079153
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
698ffd02
|
2020-02-27T10:59:13
|
|
eglGetConfigAttrib validation missing extension check
The extension EGL_ANGLE_iosurface_client_buffer adds a new attribute
to the config: EGL_BIND_TO_TEXTURE_TARGET_ANGLE. However, validation
was not checking the extension was present when this attribute was
requested.
Bug: chromium:1015454
Change-Id: I24c6e20f3b602e8a71a46f0f1e99c1472d5bbb1e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2078892
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
4d2040a6
|
2020-02-27T09:59:11
|
|
Make GLSLTest_ES31.MixOfAllResources more lenient.
Lower precision in Vulkan caused off-by-one issues with this test.
BUG=angleproject:4438
Change-Id: I17111a06133ef403be1f0c99321f1dbf8ab6083c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2078791
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
f0d32401
|
2020-02-14T14:50:25
|
|
Vulkan: Optimize element buffer conversion
Uses CPU copy if the buffer is CPU visible. Also add dirty bit check to avoid repeated conversion on clean data
Bug: angleproject:4400
Change-Id: I1f472703ebc4a65ee0de129c27f56b081748f900
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057758
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
|
201bb086
|
2020-02-27T07:01:36
|
|
Roll third_party/SwiftShader da659b374113..4b34ee3de531 (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/da659b374113..4b34ee3de531
git log da659b374113..4b34ee3de531 --date=short --first-parent --format='%ad %ae %s'
2020-02-27 jmadill@chromium.org Fix comparison of specialization constant keys.
2020-02-26 amaiorano@google.com Subzero: add support for large stacks on Windows
2020-02-26 capn@google.com Build with -Bsymbolic to prevent symbol preemption
Created with:
gclient setdep -r third_party/SwiftShader@4b34ee3de531
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: angleproject:4426
Tbr: geofflang@google.com
Change-Id: I11df2c2bb3b1d3f9d2faef9b2e1471f080b7d377
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076807
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
3cef98b7
|
2020-02-27T07:01:39
|
|
Roll third_party/vulkan-validation-layers/src 3f4d08da8897..38f68cce445b (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3f4d08da8897..38f68cce445b
git log 3f4d08da8897..38f68cce445b --date=short --first-parent --format='%ad %ae %s'
2020-02-26 mikes@lunarg.com scripts: Add line diff to generate_source.py
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@38f68cce445b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Change-Id: Ic081ef4abe3e69ef9d4a8724314db2c1a6efc8a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076808
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
cb7f5f4a
|
2020-02-26T16:59:01
|
|
Vulkan: Updated expectations after SwS fixed 4259
Bug: angleproject:4259
Change-Id: I518db27a1fb50d35f2c784f655d3e7ee40f4bdf2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076415
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
8b8dc561
|
2020-02-26T19:09:31
|
|
Fix Android component build.
Shared libraries have .cr.so extension in Android component builds.
Tests were failing to load the ANGLE libraries with just .so extensions.
Bug: angleproject:4396
Change-Id: I88555c830c49136623ea9da9896f86ea6204f3b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076778
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
e488d8b8
|
2020-02-26T16:11:29
|
|
Vulkan: Implement Android pre-rotation
As an Android GLES driver on top of Vulkan, ANGLE must pre-rotate
rendering on behalf of the application. This involves modifying the
vertex shader to multiply gl_Position with a mat2 "rotation matrix".
Not doing so means that SurfaceFlinger (SF) will perform a costly
rotation blit before presenting every image. Setting
WindowSurfaceVk::mPreTransform to mCurrentTransform tells SF to not do
the blit.
When the surface is rotated 90 or 270 degrees, the width and height
must be swapped for:
- The swapchain images, and for any depth, stencil, and/or multisample
attachments used with the swapchain image.
- The viewport, scissor, and render area.
Because the Metal back-end shares the TranslatorVulkan, it will define
the same preRotation (mat2) DriverUniform that is used for Vulkan.
Bug: angleproject:3502
Change-Id: I968dbe8869ba0f50de18dd41f1195e847c06b545
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038272
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
ba8ef68c
|
2020-02-24T14:13:40
|
|
Always use commit_id.py to generate commit.h
commit_id_.py is capable of generating the default commit.h.
This makes it so we always take a single path in gn.
Remove the existing commit.h and generate it into the root
generation folder (not the id subfolder) because Android blueprints
can't handle generating into subfolders that don't exist.
Make the <angle_dir> argument capable of taking a filename or
directory name. This allows us to pass the .git/HEAD file which is
a gn input. Android blueprints require all paths used as input
or output to a script are listed as inputs or outputs in the genrule.
BUG=angleproject:2344
Change-Id: I6600083fc400faf07808316c4a6244d6599df79a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2074924
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
c79b0ea5
|
2020-02-25T08:26:23
|
|
Vulkan: Document command access APIs.
Includes a short description of the ContextVk command APIs.
Also a few small cleanups to other Vulkan back-end documentation.
Bug: angleproject:4029
Change-Id: I3bd04861f27b718e6a94fdae00644c124452bc62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2070597
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
0a450363
|
2020-02-26T15:27:55
|
|
Fix MultipleDrawBuffers sample.
Was attempting to read invalid shader paths.
Noticed when working on trace/replay.
Bug: angleproject:4433
Change-Id: If43c08891b40f210112db8ffb98b8c6f53528496
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076137
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
93e72f5f
|
2020-02-25T12:02:31
|
|
Vulkan:Include precision qualifier in GLSL
With this initial implementation, it's possible to get precision
qualifier mis-matches in the generated GLSL 4.50. According to the
spec this is allowed. From GLSLangSpec 4.50 section 4.7 "Precision and
Precision Qualifiers":
For the purposes of determining if an output from one shader stage
matches an input of the next stage, the precision qualifier need not
match.
However, when converted to SPIR-V and run through the shader validation
any mismatches will cause shader validation errors. Initially just
ignoring those errors with this commit.
Bug: angleproject:3078
Change-Id: Ia2b04f90f0a7b6b1302c1b1b3e32bcfd8db9ed49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057749
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
|
8aea6d5a
|
2020-02-25T11:22:00
|
|
glslang: enforce initialize and release as once per process
Bug: angleproject:4354
Change-Id: Ice0912a90d4e9a4fe3fdaf67d67292afc0eba8a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2073201
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
b9b4569b
|
2020-02-25T15:01:21
|
|
Save binding information when caching shader
Test: KHR-GLES31.core.layout_binding.sampler2D_layout_binding_texture_FragmentShader
Bug: angleproject:4106
Bug: angleproject:3089
Change-Id: Ia92ee172ae574e50bf1759583e46ffb54f348962
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2072871
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
de3b97eb
|
2020-02-26T07:01:42
|
|
Roll third_party/spirv-tools/src 8910ea5f1c7b..70f888131ede (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8910ea5f1c7b..70f888131ede
Created with:
gclient setdep -r third_party/spirv-tools/src@70f888131ede
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Change-Id: I9645668cf93574256604db6f7ef1858a8cea6c11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2073603
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
908dc220
|
2020-02-26T07:01:39
|
|
Roll third_party/vulkan-validation-layers/src a09ab94aa920..3f4d08da8897 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a09ab94aa920..3f4d08da8897
git log a09ab94aa920..3f4d08da8897 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 mark@lunarg.com tests: Use VkDisplayKHR objects in thread safety validation
2020-02-25 mark@lunarg.com threading: Cover createobject calls for display objects
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@3f4d08da8897
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: geofflang@google.com
Change-Id: I731601f1f8190596d8313408052415f14dff42ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2073602
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
4a9ec2ef
|
2020-02-25T16:33:21
|
|
Revert "Always use commit_id.py to generate commit.h"
This reverts commit 4dc19c38c0c5e307350ecd8b9f80d59573161df9.
Causes a git error during 'gn gen':
fatal: this operation must be run in a work tree
BUG=chromium:1055991,angleproject:2344
Change-Id: I74dd36d557dcaf1bd1b13264d806a1c6b09e1a56
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2073200
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
a1ceb87b
|
2020-02-25T11:58:19
|
|
Vulkan:Refactor precision emulation code
GLSL, ESSL, and HLSL translators all had the same code to emulate
precision so migrate that code to base class.
This is a structural change to prepare for honoring precision
qualifiers in the Vulkan translator as well, which is done in a
follow-on commit.
Bug: angleproject:3078
Change-Id: Id85bba83543189e3bbc4002be92b056e63afc8de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2072644
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
27cb806c
|
2020-02-25T12:15:14
|
|
Update DEPS for SPIRV-Tools and SwiftShader
They have to be rolled simultaneously due to a breaking change.
https://swiftshader.googlesource.com/SwiftShader.git/+log/214ec337a0b2..da659b374113
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/79f8caf9154a..8910ea5f1c7b
Bug: angleproject:4425
Change-Id: If9b402295375436fcdb344835b65be7d2b55abc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2071011
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
916d204c
|
2020-02-25T14:18:38
|
|
Vulkan: Use new APIs in BufferHelper::copyFromBuffer.
We shouldn't need to special case the barrier logic in this function
any more. Instead use the 'onBufferRead' and 'onBufferWrite' APIs.
Bug: angleproject:4029
Change-Id: I7f67b67aa312d9ae64172b40d73086b7772d49d2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2071143
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
660c0dd6
|
2020-02-25T13:30:33
|
|
Vulkan: Fix padding out Buffer allocations on AMD.
We would often pad incorrectly given the constraints of the max stride.
We shouldn't really be rounding up the buffer size, but we should
instead be adding the max alignment size to the end of the buffer.
Bug: angleproject:4428
Change-Id: Id2afc572c85985548a18f60b42cdc388d83d5c4c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2071235
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
5b7ce876
|
2020-02-25T09:52:05
|
|
Vulkan: Update buffer accumulation TODO bug IDs.
Bug: angleproject:4029
Bug: angleproject:4429
Change-Id: Ice4ae48a92e376ea916f05d1433a68f3accc09d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2071145
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
b185002d
|
2020-02-21T16:58:39
|
|
Fix the condition of glOrtho{fx} validation
According to the OpenGL ES 1.1 spec, remove the conditions
of glOrtho validation that n and f must be positive.
Bug: angleproject:4281
Change-Id: I644a25408a026ce87211f2203b8e8203eeaf69bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2067002
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
f031f7c8
|
2020-02-19T18:13:32
|
|
Fix a GCC 10 build failure.
Build failed on GCC10 with C++17. An #ifdef was added to support both
C++17 and C++14
Bug: angleproject:4390
Change-Id: I397513a8ebad4a55635ba863c47edc658e405729
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063545
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
46cb0f62
|
2020-02-21T11:38:17
|
|
Vulkan: prevent volk reloading on null instance and devices
Bug: angleproject:4419
Change-Id: I82f9bb157e88754efd074358dccef1bb82cab0f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068902
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
14a2983f
|
2020-02-20T17:14:02
|
|
Trace/Replay: Add uniform locations map.
This portability feature allows a single T-Rex capture done on Vulkan
to work seamlessly on the ANGLE GL back-end and the WGL-loaded NVIDIA
OpenGL driver.
Previously the uniform locations would not be consistent between ANGLE
and a native driver. And incompatiblities would trigger error messages
between ANGLE back-ends.
Will allow us to compare ANGLE performance vs the native driver using a
capture.
Example captured calls:
glLinkProgram(gShaderProgramMap[3]);
UpdateUniformLocation(gShaderProgramMap[3], "s_texture", 0);
Bug: angleproject:4411
Change-Id: I5ddc76d75e15a9291b351e2aab94af4881f6ef47
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068121
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|