kc3-lang/angle

Log

Author Commit Date CI Message
Roman Lavrov 250b2f68 2024-01-12T11:04:48 Add imports for use_resource_processor: true Bug: b/319160342 Change-Id: If3429b2407d78747e6d6d96d11d8b895e962e13d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5192476 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop a06f5f89 2024-01-10T21:50:42 Android: Apply rules to global settings on boot When we receive BOOT_COMPLETE or MY_PACKAGE_REPLACED broadcasts, parse the rules and apply them to global settings. Bug: b/293503000 Test: Manually built and installed on Android Change-Id: If081f707f5acf0f22d10837177823bac59c3d4df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5191963 Reviewed-by: Peiyong Lin <lpy@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 99ca7f24 2024-01-11T20:49:00 Android: Add ANGLE to rules so it is non-empty This allows tests to know when the rules parsing is complete and global settings have been initalized. Bug: b/293503000 Test: Manually built and installed on Android Change-Id: Ifdb7537cf210ff36900c432394b21e183b4dac3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5191962 Reviewed-by: Peiyong Lin <lpy@google.com> Commit-Queue: Peiyong Lin <lpy@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 28290eae 2024-01-11T00:00:00 Metal: Do not try to create buffers exceeding device limits Checked Metal device's maxBufferLength before creating a new buffer. Fixed: angleproject:8326 Change-Id: Ie56db8f951a733b7b6a6a07284b6d912ee59f7ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5190340 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll 126d7b10 2024-01-12T10:01:00 Roll vulkan-deps from 124ff11a5e15 to b8c02f610c1d (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/124ff11a5e15..b8c02f610c1d Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c7affa1707..01ee1bf317 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6f441477e7..0078555268 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I62afb22d7c38fa03c62e3c413bd82f659084009c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5192350 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll eb77635a 2024-01-12T07:01:03 Roll Chromium from acdb36669f64 to 84fab30ecd66 (576 revisions) https://chromium.googlesource.com/chromium/src.git/+log/acdb36669f64..84fab30ecd66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/eba30cc909..48ef4c0c29 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a656fc7fe0..4d143ade13 * buildtools/linux64: git_revision:85944ebc24a90ec1e489e85a46fdc68542c3146f..git_revision:d4be45bb28fbfc16a41a1e02c86137df6815f2dd * buildtools/mac: git_revision:85944ebc24a90ec1e489e85a46fdc68542c3146f..git_revision:d4be45bb28fbfc16a41a1e02c86137df6815f2dd * buildtools/win: git_revision:85944ebc24a90ec1e489e85a46fdc68542c3146f..git_revision:d4be45bb28fbfc16a41a1e02c86137df6815f2dd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3888b83c28..105d4c3f46 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ad697e33c1..39bc04eb9f * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e4aac3ace5..d1f035a3ff * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f80f02a81e..a1171ad549 * third_party/r8: QWZP08h89KyQf8Bmiw74dItBaIvpN4n7QUOIPP1fOJ4C..-33V5QWJXVKP_bE-P5-BqM4rcEmndOTuK1LyWc2l3N4C * third_party/siso: git_revision:d01a25fcf2367e28e0abd1f22f3d67786c9bbf6f..git_revision:d8744c99a9e175e6c4569de0717bd8c53981ce0c * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/40e35a76af..956936c53c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/28c2eefa98..990bc36ac0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b6623f2f01..d67de05ec4 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/216d33bbf9..137d838b1d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8c0c8db480..a1137e89f9 * tools/skia_goldctl/mac_amd64: aczic__c3_V2fDigCiqhiSUpK79EbS7cIzL2JHhsp6wC..lkI4UMXstA7DR9LqFykhbBB0sT-pbajdPVIN8nO1xCwC * tools/skia_goldctl/mac_arm64: WJRRztj2l1AZCPM0pg9f3FpevNt22sN86zaNLStjH8wC..lhItSTy1WLT7ZDUaklin1sNQ2vdQFPwVcEKC5gRty-4C No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ieb2926b3c3011079e9b96ef6ac9a65cab940b63c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5192265 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 073b6510 2024-01-11T07:40:32 Add missing GLES1 glGetBooleanv() enums In OpenGL ES 1, capabilities that can be queried using glIsEnabled() can also be queried using glGetBooleanv(). As such, some valid glGetBooleanv() calls were returning "Invalid pname" error. Added support for the missing enums in glGetBooleanv(). Bug: angleproject:8481 Tests: GLES1 - QueryTest* Change-Id: Ic3a50eda4eae5855cd9491dbf217b5f69c1669b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5188456 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e3708149 2024-01-11T15:23:30 Add a test to ensure multiple eglInitialize calls work Bug: angleproject:8265 Change-Id: I186942a7830a35c563df503aa2b06e407288eef3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5191165 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Vasiliy Telezhnikov 80e4bcd6 2024-01-05T13:58:13 Fix crash in eglQueryDeviceStringEXT for EGL backend Underlying eglQueryDeviceStringEXT can return NULL if there is no DRM node associated with EGL device. https://registry.khronos.org/EGL/extensions/EXT/EGL_EXT_device_drm_render_node.txt Bug: angleproject:7686 Change-Id: Iec6acc43ac8c9d277df064161e718155d5c03c95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5170889 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Shahbaz Youssefi c0dae760 2024-01-10T18:37:03 Wildcards instead of redundant API specification in expectations The expectations already specify the API they relate to. As such, specifying the API tag in the gtest name is redundant. For example, it is preferred to specify: 1234 MAC OPENGL : Foo.Bar/* = SKIP instead of: 1234 MAC OPENGL : Foo.Bar/ES2_OpenGL = SKIP 1234 MAC OPENGL : Foo.Bar/ES3_OpenGL = SKIP This change also adds a presubmit to make sure the latter is not reintroduced. The only possibly legitimate use case for being specific about the test name is if only a variant of the test fails (such as ES3_OpenGL_SomeWorkaround). Note that if the opposite is the case (i.e. ES3_OpenGL fails, but ES3_OpenGL_SomeWorkaround passes), it's an indication that the feature that made the test pass should have been enabled by default. Bug: angleproject:8465 Change-Id: I11476e36c83cbbeb8148b6e934c42ccd9b988de1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5185675 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 2e2d7247 2024-01-11T11:50:44 Roll vulkan-deps from eb5fcf15ff7f to 124ff11a5e15 (21 revisions) Skip VUID-VkImportMemoryWin32HandleInfoKHR-handleType-00658 added in: https://github.com/KhronosGroup/Vulkan-ValidationLayers/commit/939e7c3fcbb75f71f0dfa999064c74f27a014189 https://chromium.googlesource.com/vulkan-deps.git/+log/eb5fcf15ff7f..124ff11a5e15 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/db4d6f85af..1952e63d43 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/cffc08a542..37a58e4c95 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/1bfd27101e..bdd1b2ab1f * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/e2b7bb1207..4c20ea3156 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/02f1cb7d55..6f441477e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8482 Tbr: cnorthrop@google.com Change-Id: Iaa696787ae66ba44db591c18833d2b7261474c08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5185141 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 950d054a 2024-01-11T00:00:00 Metal: Do not defer global const initializers Since MSL supports constant global variables, they should not be included in the DeferGlobalInitializers operation. This reduces temporary register usage and thus makes shaders that use large const arrays more compatible with Apple GPUs. Fixed: angleproject:8479 Change-Id: If1cd17a0a194173e60e6b5152297054fc384c0b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5189165 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll d3f22881 2024-01-11T10:01:47 Roll SwiftShader from 2fa7e9b99ae4 to f4819d2276b7 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/2fa7e9b99ae4..f4819d2276b7 2024-01-10 natsu@google.com Revert "LLVMReactor: Remove CreateFreeze() call" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: If5e37e476e05b0a7987df71692c8deaa50f1a7a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5187153 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 21b1109e 2024-01-11T07:00:53 Roll Chromium from efb407701371 to acdb36669f64 (590 revisions) https://chromium.googlesource.com/chromium/src.git/+log/efb407701371..acdb36669f64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/05ae923a4a..eba30cc909 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/71983d684f..a656fc7fe0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/edac18841f..3888b83c28 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d556a0f934..5fe3232525 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f582f5bb51..73730a049e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/095b349ad3..ad697e33c1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/f18cfa95e1..e4aac3ace5 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/29eb3a55f4..e09e0d462a * third_party/r8: 7ZLGp8JIt4e06kV9hmLku6y5pnjOWTVG8jkjXo-I-REC..QWZP08h89KyQf8Bmiw74dItBaIvpN4n7QUOIPP1fOJ4C * third_party/siso: git_revision:d8744c99a9e175e6c4569de0717bd8c53981ce0c..git_revision:d01a25fcf2367e28e0abd1f22f3d67786c9bbf6f * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/55c9211cbe..771b9c761f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9eb7931923..28c2eefa98 * tools/luci-go: git_revision:d740e2026f68271ad436672df5a4c763d244451d..git_revision:0d11be367258bfe14a13ff1afcf43a0bc6aedb45 * tools/luci-go: git_revision:d740e2026f68271ad436672df5a4c763d244451d..git_revision:0d11be367258bfe14a13ff1afcf43a0bc6aedb45 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8c385fc97c..8c0c8db480 * tools/skia_goldctl/linux: x4RN7JjJs8RMOELL5AyOg-slqXooabsQz4QloMxQOh8C..407H-TbIdlUjRbGWaMLTbSuhauPqvPICdysGuqJvZwUC * tools/skia_goldctl/mac_amd64: HHxYWtQ35VrmgW6tPX3TR-PxmFmK3VTQ7GpD9aCX2IsC..aczic__c3_V2fDigCiqhiSUpK79EbS7cIzL2JHhsp6wC * tools/skia_goldctl/mac_arm64: brZvkrVhGd26_BnF7fagivr7Ai5qgVKpUok9A8u2vw0C..WJRRztj2l1AZCPM0pg9f3FpevNt22sN86zaNLStjH8wC * tools/skia_goldctl/win: WJGWEQTyCb6vzrxUS4mGt7JoflSwFWxJravowUoTMMAC..14DPIsHsHs60_8PzIoLPiLesYnsN_0qV7RUmyNCr3zMC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I124f4ae331bf555bc2be51f2ffc1ee0f4d542e47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5185139 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya f1fee64d 2024-01-10T13:35:53 Bugfix in MultithreadedAHBImport tests Depending on thread scheduling it is possible that thread0 moves beyond Step::Start before thread1 waits for it. This causes a FATAL error with log - FATAL: MultiThreadSteps.h:73 (waitForStep): \ waitForStep requires increasing order. mCurrentStep=1, waitStep=0 Fix this by making thread1 wait on Step::Thread0Created* Bug: b/261552549 Change-Id: I8e7c9ed554285fea5674263c5807db67b908a725 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5186836 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e00995d4 2023-12-21T15:57:39 Vulkan: Invalidate pipeline with FBO draw buffer change Enabling/disabling draw buffers can affect the graphics pipeline without changing the render pass description. In that case, the graphics pipeline was not being invalidated. Bug: angleproject:8463 Change-Id: I6848472dcbb3d3ce4c34d95be28c8ec3fc50dcd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5147847 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com>
Alexey Knyazev 473dd389 2024-01-04T00:00:00 Metal: Fix out/inout parameter aliasing Ensured that MSL-internal structs are included in the parameter aliasing checks. Fixed the following tests: dEQP-GLES2.functional.shaders.function .global_variable_aliasing_fragment .global_variable_aliasing_vertex dEQP-GLES3.functional.shaders.function .global_variable_aliasing_fragment .global_variable_aliasing_vertex Fixed: angleproject:7145 Change-Id: Ia1e40e72a69e2f91b480ef5fbb75ff0f0a1a772a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5176988 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll c815735a 2024-01-10T07:47:44 Roll Chromium from 75a96f770572 to efb407701371 (638 revisions) https://chromium.googlesource.com/chromium/src.git/+log/75a96f770572..efb407701371 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e920e5bbda..05ae923a4a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f5d99b3266..71983d684f * buildtools/reclient: re_client_version:0.125.0.f3883c2-gomaip..re_client_version:0.126.0.4aaef37-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/89bb5ed84f..edac18841f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6953ebe3c1..095b349ad3 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/8c2468e9dd..f18cfa95e1 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/42293b96f8..29eb3a55f4 * third_party/r8: kTbaOlJzi5hYF_n8tweI4zxcmTeJ0wo7ckimuDOpkYwC..7ZLGp8JIt4e06kV9hmLku6y5pnjOWTVG8jkjXo-I-REC * tools/luci-go: git_revision:a7b7f319032d68f1cf0e710e695a84957d3b11dc..git_revision:d740e2026f68271ad436672df5a4c763d244451d * tools/luci-go: git_revision:a7b7f319032d68f1cf0e710e695a84957d3b11dc..git_revision:d740e2026f68271ad436672df5a4c763d244451d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8218408089..b6623f2f01 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bd9d239994..8c385fc97c * tools/skia_goldctl/linux: gF8-tllaG53TS_NMzDyBBEon5i-UMVdhPADIv_39ZpsC..x4RN7JjJs8RMOELL5AyOg-slqXooabsQz4QloMxQOh8C * tools/skia_goldctl/mac_amd64: 5z5sg3DatlGfhGSg6wO3JTMyBofd0Dr9_bCBVDBfuJYC..HHxYWtQ35VrmgW6tPX3TR-PxmFmK3VTQ7GpD9aCX2IsC * tools/skia_goldctl/mac_arm64: tJys4TOPo-asafdTKs677RtNMEWct4WvJ4-SDmdqoYkC..brZvkrVhGd26_BnF7fagivr7Ai5qgVKpUok9A8u2vw0C * tools/skia_goldctl/win: wCfWvHnVA6RiLbvH5NL3Pc51a6uladkFepTSj06s370C..WJGWEQTyCb6vzrxUS4mGt7JoflSwFWxJravowUoTMMAC No update to Clang. Bug: angleproject:6430,angleproject:7079 Tbr: cnorthrop@google.com Change-Id: I21d1874e4540a534a759e27fa7482ef12abfc136 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5183283 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya c2ad86bc 2024-01-09T15:39:26 eglGetError is now a lockless entrypoint eglGetError returns last recorded error in a thread, there is no need to lock the global mutex. Bug: b/318921454 Change-Id: I9e5192becc67dc81b54abfb63d2b32283ebc69d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5181881 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 2937ee27 2024-01-08T20:01:48 Manual roll VK-GL-CTS from c92e4b2608d4 to 75a6a8315e20 (14 revisions) Includes manual ANGLE changes to reference new file names. https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c92e4b2608d4..75a6a8315e20 2024-01-08 lorenzo@khronosgroup.org Update external sources 2024-01-07 rgarcia@igalia.com More VK_EXT_host_image_copy tests with depth/stencil buffers 2024-01-07 rgarcia@igalia.com Additional host image copy tests 2024-01-07 rgarcia@igalia.com Fix identical_memory_layout host image copy tests 2024-01-07 james.fitzpatrick@imgtec.com Check for entry points dependencies and validate all entry points from extensions 2024-01-07 rgarcia@igalia.com Add --quiet option to suppress standard output messages 2024-01-07 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2024-01-05 gleese@broadcom.com Allow VK_KHR_vertex_attribute_divisor 2024-01-05 jbolz@nvidia.com Disable KHR attrib_divisor tests for VulkanSC 2024-01-05 cturner@igalia.com Populate all members of StdVideoDecodeH265PictureInfoFlags 2024-01-05 eilif.swensen@arm.com Add external_format_resolve to no_unknown_extensions 2024-01-05 marcin.hajder@mobica.com TransformFeedback API errors in compatibility profiles 2024-01-05 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-01-02 aitor@lunarg.com Rename files/directories from master to main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8475 Change-Id: Iab2df38c310becb4785828d7129fe10c6d0228fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5177828 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 92bd0099 2024-01-09T07:01:47 Roll Chromium from 91e307af275c to 75a96f770572 (565 revisions) https://chromium.googlesource.com/chromium/src.git/+log/91e307af275c..75a96f770572 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2c36118783..e920e5bbda * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9b82414562..f5d99b3266 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4305f60c44..89bb5ed84f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5c4205e588..f582f5bb51 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/35a5306635..6953ebe3c1 * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/515dd10de9..e2d024354e * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/34685c3c0e..8c2468e9dd * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/1ec08211bd..f80f02a81e * third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/006709ba3e..0bad08bb20 * third_party/r8: asYZzL1fLd9SKLslDmuZtpdu2HHd8W71vCISzp_DbxQC..kTbaOlJzi5hYF_n8tweI4zxcmTeJ0wo7ckimuDOpkYwC * third_party/turbine: M27KV5bN2pvX97rzQXxamxLUFHmKEes8wvZevk8nU2YC..ABguU2WKErRBdXX1LMt0zqZListLS_05X0Rp_V7pwAYC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/cfcf160bc5..55c9211cbe * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bfbe1f7add..bd9d239994 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I511d3df46b268d35163b54a85f4d1919e4655dec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5180109 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 4b356c39 2023-08-17T10:49:19 Vulkan: Drop support for VMA 2.0 Since ANGLE and Chromium were last updated to use VMA 3.0, there have been no breaking issues so far. * ANGLE update: https://crrev.com/c/4777337 * Chromium update: https://crrev.com/c/4911597 Therefore, the support for the old VMA (2.3) can now be removed. * Removed ANGLE_VMA_VERSION from the build files, since they are no longer required. * Removed the VMA-related guards in the code as well. * Removed the flags and thresholds for the buddy algorithm, which were used in VMA 2.3. * Share group buffer pools is no longer a map. Bug: b/303290680 Change-Id: Ic2b29e8f95ca5c941b297b20442c5bad4b8f52e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4791667 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 8fd035f1 2024-01-08T10:01:18 Roll vulkan-deps from dd0c87f2c1d5 to eb5fcf15ff7f (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/dd0c87f2c1d5..eb5fcf15ff7f Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/2aa686f455..e2b7bb1207 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e21dc3deb0..2c0a644db8 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/fce11d52fe..4cfc176e32 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/474888add4..02f1cb7d55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I8d8019bfaa45e9580ae619c0ffa1a33cc8d0822d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5176158 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 54ad4a46 2024-01-08T07:00:33 Roll Chromium from d9d3c9435db8 to 91e307af275c (591 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d9d3c9435db8..91e307af275c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/45d237e54f..2c36118783 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5e016b7d32..9b82414562 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/03f8c9a08d..4305f60c44 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/0efbd21db7..d556a0f934 * third_party/android_build_tools/manifest_merger: WTmajghAylCsg6DjtBSRd1dHKUjkkeex-9ASgLJ0cu8C..00I6IYO5b1mwIYv-jWPmTZvw3paoypOPHYEg9vpqFDUC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/cf6ba2ec4f..4037529999 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/97195eceef..5c4205e588 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/783c919a44..35a5306635 * third_party/fuchsia-sdk/sdk: version:17.20231218.3.1..version:17.20240105.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/15db46be4e..34685c3c0e * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/2602aecdf4..42293b96f8 * third_party/r8: KdsiU0baghnLNppJOps875j4Bejz104odNSi7xx2nz0C..asYZzL1fLd9SKLslDmuZtpdu2HHd8W71vCISzp_DbxQC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/657c88b9c0..9eb7931923 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b8839efae6..8218408089 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/af26c3be10..bfbe1f7add Clang version changed llvmorg-18-init-14420-gea3a3b25:llvmorg-18-init-16072-gc4146121e940 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/657c88b9c012b3f8036f891f2c819626e74f31c9..9eb79319239629c1b23cf7a59e5ebb2bab319a34/scripts/update.py Bug: None Tbr: ynovikov@google.com Change-Id: I0b4deea94003c2e54f1f9c0100c1649ebc7ff927 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5174849 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e6708de2 2024-01-05T17:02:08 Manual roll vulkan-deps from 7f90849f10d0 to dd0c87f2c1d5 (37 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/7f90849f10d0..dd0c87f2c1d5 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/88c5373ee4..db4d6f85af * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/f349c91274..cffc08a542 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/1c6bb27435..1bfd27101e * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f0cc85efdb..c7affa1707 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/80207f9da8..217e93c664 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a3b11f1fcc..2aa686f455 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/524f8910d0..fce11d52fe * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/98dea76972..474888add4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I5f37a6bbaf864d812a2530ee6eb263cdbd053d9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5171149 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f7296e95 2023-12-29T10:01:26 Roll vulkan-deps from 1fd0038f3bbb to 7f90849f10d0 (6 revisions) Skip VUID-VkImportMemoryFdInfoKHR-handleType-00667 added in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/7199/commits/cebf29d9587aad38acf52351d4b6225e7c1d032f https://chromium.googlesource.com/vulkan-deps.git/+log/1fd0038f3bbb..7f90849f10d0 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/89824a83b7..88c5373ee4 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/741a9dfd8f..a3b11f1fcc * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e3d690bb54..98dea76972 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8470 Change-Id: Iba9e9dae398a753fd9675e5b68551abe2dfc0c46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5155494 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Solti Ho <solti@google.com>
angle-autoroll 05516d6a 2024-01-05T10:15:11 Manual roll Chromium from 51f403269037 to d9d3c9435db8 (1511 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/51f403269037..d9d3c9435db8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/758a805edf..45d237e54f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/947ee0610d..03f8c9a08d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b7ad4e9eff..0efbd21db7 * third_party/android_build_tools/lint: lFTxX9qC3bg4t8i5dN6Wqa666iz7rHuVSLkzpUDmdk4C..cBQ1qc7aJ6gwBvrCOJNVq6Mlijj4HlNtTmzJEXpgmBQC * third_party/android_build_tools/manifest_merger: SsLJuePpgSRlofU-tTKtZM6uoAelYZV8509WbBDI-ecC..WTmajghAylCsg6DjtBSRd1dHKUjkkeex-9ASgLJ0cu8C * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/f7abe43b8a..4d99ea187e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6d3a4756c7..97195eceef * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/911ccd864c..783c919a44 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8806fb8bb2..1ec08211bd * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/7fc833e889..f477acb104 * third_party/r8: 7Bh-YvMIvXQguOKifHK0dPByTf-YalKg29UInFS7lLAC..KdsiU0baghnLNppJOps875j4Bejz104odNSi7xx2nz0C * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/9d7648a0c7..cfcf160bc5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2b9d966ec5..657c88b9c0 * tools/luci-go: git_revision:0ffd60c8bd4fa542fb8d7c6a60ead9b96dc4387a..git_revision:a7b7f319032d68f1cf0e710e695a84957d3b11dc * tools/luci-go: git_revision:0ffd60c8bd4fa542fb8d7c6a60ead9b96dc4387a..git_revision:a7b7f319032d68f1cf0e710e695a84957d3b11dc * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e592c0f866..b8839efae6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5ddc22d0e8..af26c3be10 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Id29257700b7f7b1cb6c9953eac6a62c7d1adda03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5171337 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 295eece6 2023-12-26T17:28:04 Vulkan: Add feature to force enable sample usage Add a feature that would force enable the VK_IMAGE_USAGE_SAMPLED_BIT usage flag for an image with external format, irrespective of the requested AHB usage. Bug: b/155487768 Change-Id: Ie46012d6f905317cd42a69768b4d35b44db474c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5153131 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Amirali Abdolrashidi 82c0ba93 2023-12-21T16:18:40 Set dirty bit when GLES1 texture state changes During experiments, it was seen that some devices fail to use the tex coord pointer properly after GL_TEXTURE_2D is re-enabled and there is a draw without updating any additional attribute pointers. * The GLES1 renderer will now also set the dirty bit for the vertex array when GL_TEXTURE_2D state changes. * (via setEnableVertexAttribArray()) * Updated the following test: DrawWithTexCoordPtrThenDisableTexture2DAndDrawAnother * Updated so after GL_TEXTURE_2D is enabled, we draw without updating the vertex pointer to check that simply enabling textures is enough to use the texture data. Bug: b/310688730 Change-Id: I0d93bd6fae3d07ea86cf0e5e094ce7a29f2e5f1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5147197 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Mohan Maiya 343e774a 2023-12-26T16:44:47 Vulkan: Bugfix in usage flags of images with external formats Enable VK_IMAGE_USAGE_SAMPLED_BIT usage flag for an image with external format only if the equivalent AHB usage was requested. Force enabling VK_IMAGE_USAGE_SAMPLED_BIT usage will mask bugs where an app or vendor gralloc module fails to include the AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE or the equivalent gralloc usage flag when creating the AHB Bug: b/155487768 Change-Id: If09cd739a6fdc3ac7905f9d4c1fc9d4098e0cdad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5153125 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Alexey Knyazev a6b9a744 2023-12-21T00:00:00 Metal: Implement vertex attribute aliasing When vertex attribute aliasing is supported, the external vertex input struct is filled post-link to account for potentially aliased attributes. Fixed the following tests: dEQP-GLES2.functional.attribute_location.bind_aliasing .cond_float .cond_vec2 .cond_vec3 .cond_vec4 .cond_mat2 .cond_mat2_offset_1 .cond_mat3 .cond_mat3_offset_1 .cond_mat4 .cond_mat4_offset_1 dEQP-GLES3.functional.attribute_location.bind_aliasing .cond_float .cond_vec2 .cond_vec3 .cond_vec4 .cond_mat2 .cond_mat2_offset_1 .cond_mat3 .cond_mat3_offset_1 .cond_mat4 .cond_mat4_offset_1 .max_cond_float .max_cond_vec2 .max_cond_vec3 .max_cond_vec4 .max_cond_mat2 .max_cond_mat3 .max_cond_mat4 Fixed: angleproject:6297 Change-Id: Ifa6b82e0d7d4e12115ec19e342cfb82ab4389f5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5148210 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 3c8501b3 2023-12-21T00:00:00 Metal: Handle embedded uniform struct arrays Preserve arrayness type information when replacing uniform declarations. Fixed: angleproject:6525 Change-Id: I09ea79ffa5bf74e06503985d4f90ccbe0bf25570 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5150729 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 706b5abe 2023-12-21T00:00:00 Avoid UB in 16-bit IOSurface tests * Removed incorrect R16UI mappings from backends * Fixed the enum used in RenderToR16IOSurface * Added more 16-bit tests Fixed: angleproject:7445 Change-Id: I7d5fb8b6a5fc7a57de8f988fdcc21e66606f875d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5148211 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Mark Lobodzinski d18f22ca 2023-12-14T11:50:19 ANGLE: Update syncval exceptions and add test for syncval errors Trace testing found some new cases where the current sync val error messages needed to be widened to cover more cases. A test was added to reproduce the behavior seen in the Asphalt 9 ANGLE trace. Test: FramebufferTest.InvalidateAttachmentStencilOnly Bug: b/316337308 Change-Id: Icde7ad560e6949712bfd785d9969b9e179d11492 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5124314 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
angle-autoroll 1b3f101c 2024-01-02T07:01:23 Roll Chromium from 785f1c59fc7f to 51f403269037 (105 revisions) https://chromium.googlesource.com/chromium/src.git/+log/785f1c59fc7f..51f403269037 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md No dependencies changed. No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I8a11596e2831fe5e943690d225e80cd3ee0535b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5157968 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4b857381 2024-01-01T07:00:07 Roll Chromium from 9cf4a28c8c16 to 785f1c59fc7f (258 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9cf4a28c8c16..785f1c59fc7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/413b664277..758a805edf * third_party/android_build_tools/manifest_merger: 3rLesGAkawLbiSrx8-sR19ZU_fIHT5djFfmm1U2CRsYC..SsLJuePpgSRlofU-tTKtZM6uoAelYZV8509WbBDI-ecC * third_party/android_sdk/public: Sy00LuyBIUJdRGYKwg0zjWH8eAIUvgnnNiPkI8etaZYC..BRpfUGFd3WoveSGTLVgkQF7ugIVyywGneVICP4c0010C No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I2feda7743b4f3eff2dcc60c1225adb683eba0739 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5156758 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 09c69b5b 2023-12-29T07:01:24 Roll Chromium from 1f725fb9b559 to 9cf4a28c8c16 (152 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1f725fb9b559..9cf4a28c8c16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fd08af42da..413b664277 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ecef358a99..5e016b7d32 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6e1c3ff3ce..947ee0610d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8191486420..911ccd864c * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d0429f0628..15db46be4e No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ifa00d07edea9620767812ac32c68f86f70095f99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5153240 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 48ff6a26 2023-12-28T10:01:49 Roll vulkan-deps from 5eda6f64c68b to 1fd0038f3bbb (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5eda6f64c68b..1fd0038f3bbb Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f914f5e4a5..741a9dfd8f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/62b49b1a2e..e3d690bb54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I79aa852970407d9d502c105583962c8d1f09d803 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5154681 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ad8987c2 2023-12-28T07:47:23 Roll Chromium from 5bb93a4bc2f1 to 1f725fb9b559 (207 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5bb93a4bc2f1..1f725fb9b559 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ffbe9ab8b8..fd08af42da * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d7101be641..6e1c3ff3ce * third_party/android_build_tools/manifest_merger: Wk3Q4wN95_lB58e1sRWAgXljF18hHuJI60JbyPmqXVoC..3rLesGAkawLbiSrx8-sR19ZU_fIHT5djFfmm1U2CRsYC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2e8980b21b..6d3a4756c7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/007dd45a94..8191486420 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/802db79a6a..216d33bbf9 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I7d1aba9b219afddced996e8975cc84fa4c2bdec8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5154680 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0ddebba5 2023-12-27T10:01:49 Roll vulkan-deps from ddef466fc7d4 to 5eda6f64c68b (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ddef466fc7d4..5eda6f64c68b Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/809fd43ed6..89824a83b7 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a323cd0623..62b49b1a2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I6724580d7d793af78702693bb2a486dac5fcc9ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5153624 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e939f9a9 2023-12-27T07:01:24 Roll Chromium from 709f4a531d4b to 5bb93a4bc2f1 (147 revisions) https://chromium.googlesource.com/chromium/src.git/+log/709f4a531d4b..5bb93a4bc2f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/android_build_tools/lint: pvFK7MtH5IsrWhv7D-JOyKc5CPgDCyDAWjN_DbAFjVwC..lFTxX9qC3bg4t8i5dN6Wqa666iz7rHuVSLkzpUDmdk4C * third_party/android_toolchain/ndk: XSjN84pHxBPX13CrUj3fQjEroncvFGGeJY9wDVEDswoC..wpJvg81kuXdMM66r_l9Doa-pLfR6S26Jd1x40LpwWEoC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f2abc0cd0c..2e8980b21b No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I3063a7081558b4414c71627c6bfdf09883cf6872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5152426 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3dfb2158 2023-12-26T10:01:49 Roll vulkan-deps from 75058a70503d to ddef466fc7d4 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/75058a70503d..ddef466fc7d4 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/e997844110..f914f5e4a5 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/163c09e3cb..a323cd0623 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ia4ef00d5d48f2f4cf461e1af78213a57883bffe5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5152550 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ef580810 2023-12-26T07:01:23 Roll Chromium from 6b6f931ed171 to 709f4a531d4b (105 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6b6f931ed171..709f4a531d4b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/85f13aead6..ffbe9ab8b8 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0d01458c01..ecef358a99 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/31b01457fa..d0429f0628 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Id42bb60c96253670a7b31eb8701131af6bdc2a69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5152338 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3f9f34b4 2023-12-25T10:01:49 Roll vulkan-deps from c3b062a5b7ab to 75058a70503d (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c3b062a5b7ab..75058a70503d Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/abb79089a8..809fd43ed6 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/fd2d689c3f..163c09e3cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I817d738ca1b89a5992f4ac0ed7638fa8bb5a89f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5151577 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c8af75dd 2023-12-25T07:00:20 Roll Chromium from d4375501722f to 6b6f931ed171 (384 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d4375501722f..6b6f931ed171 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/71c79f4cb1..85f13aead6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/77e2825246..0d01458c01 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/86dfa79382..d7101be641 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/42d35c7fa9..b7ad4e9eff * third_party/android_toolchain/ndk: NSOM616pOQCfRfDAhC72ltgjyUQp9lAWCMzlmgB18dAC..XSjN84pHxBPX13CrUj3fQjEroncvFGGeJY9wDVEDswoC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/49c8dd3237..f2abc0cd0c * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9b0e39e840..31b01457fa * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/09ec89c115..2b9d966ec5 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ic186e4b7d9d9a91e14d8553a39e5ea1bfd6692cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5151575 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3f5f4aa4 2023-12-22T10:56:18 Roll VK-GL-CTS from fa3dcc95cfc0 to c92e4b2608d4 (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fa3dcc95cfc0..c92e4b2608d4 2023-12-22 rgarcia@igalia.com Test high number of XFB outputs 2023-12-22 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2023-12-21 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2023-12-21 lorenzo@khronosgroup.org Fix running all recipies 2023-12-21 lorenzo@khronosgroup.org Support dependencies with +, for extensions' <require> elements 2023-12-21 pawel.ksiezopolski@mobica.com Perform compute-only tests 2023-12-21 ziga@lunarg.com Add tests using VkImageFormatListCreateInfo 2023-12-21 lorenzo@khronosgroup.org Allow multiple recipies in the arguments of check_build_sanity.py 2023-12-21 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I190b4a870bde678cd2b7217164976403a2ed87cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5146998 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 03b93d4f 2023-12-22T10:01:49 Roll vulkan-deps from 34a8babeb440 to c3b062a5b7ab (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/34a8babeb440..c3b062a5b7ab Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3798f68b73..e997844110 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8095b050f9..fd2d689c3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: If481e2a36c97e55736c6f4ed7693857b602e0d26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5147201 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6f809c7f 2023-12-22T07:30:31 Roll Chromium from 71a57680b06d to d4375501722f (902 revisions) https://chromium.googlesource.com/chromium/src.git/+log/71a57680b06d..d4375501722f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f2f5a10150..71c79f4cb1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e8e9f90e58..77e2825246 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/edab5262fa..86dfa79382 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8c91f1a73b..42d35c7fa9 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/7a76422eef..cf6ba2ec4f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/390005586b..007dd45a94 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/715a7b8509..9b0e39e840 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/3cafb40647..2602aecdf4 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/002f75df25..40e35a76af * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/289bde07a0..09ec89c115 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9f03ce32b7..5ddc22d0e8 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I1d83f546e7f7b9affa97bbf18576db4f0787986a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5147200 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Hailin Zhang 536042b6 2023-12-20T12:26:00 vulkan: fix etc2 srgb8_alpha8 alpha decode issue. for etc2_srgb8_alpha8 format, we should not use signed alpha decoder. Bug: b/314875175 Change-Id: I89f7eaf71e31f279da08c83989f8d692a8ba2c81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5142566 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Hailin Zhang <hailinzhang@google.com>
Shahbaz Youssefi a1143857 2023-12-18T15:24:42 Fix UBO dirty bits vs PPOs This change fixes propagation of UBO dirty bits (such as through glUniformBlockBinding and glBindBufferRange) to program pipeline objects. Since PPOs concatenate the attached programs' UBOs in a list, a map of program UBO indices to PPO UBO indices is introduced to offset these dirty bits appropriately. Additionally, when the program's executable's buffer bindings change (through glUniformBlockBinding), a notification is send to the PPO to update its executable's buffer binding accordingly (which is otherwise only updated during PPO link). Bug: angleproject:8462 Change-Id: I4965ae23e6fc6cac0842e1643755e42e95d3d5cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5131418 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 16bfe951 2023-12-21T10:23:05 Add README.chromium for llvm and clspv Bug: angleproject:8369 Change-Id: I20bbb38b45aace848f8002cb49f206d98c2d7aa1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5145927 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll e15a7de3 2023-12-21T10:01:41 Roll vulkan-deps from 9c3a33aed0ec to 34a8babeb440 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9c3a33aed0ec..34a8babeb440 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/c155f881ee..abb79089a8 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/40633a61aa..3798f68b73 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/b42addf414..e21dc3deb0 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ea496a3de8..8095b050f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8468 Change-Id: Icf23d4056b1f9a6caae2483125841bc6aefe3a8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5144390 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 13685465 2023-12-20T15:39:24 Vulkan: Don't request surface extensions without VK_KHR_surface ... on headless platforms. Bug: angleproject:8467 Change-Id: Id0032ddd9f57540719d90f58b7d99cfb79f91a8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5142626 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi c51259ec 2023-12-14T15:58:56 Vulkan: Ignore tex coord at draw if tex disabled In GLES1, it is possible to disable texture rendering in some cases. It is done using glDisable(GL_TEXTURE_2D). In that case, if TexCoordPointer has been enabled in the client state prior to disabling the texture, its data should no longer be used, especially if the primitive changes to use more vertices. In that case, there is a risk of unauthorized memory access. In this CL, the active vertex attributes are updated accordingly if texture is disabled using the aforementioned API call. * Updated GLES1 renderer to ignore TexCoordPointer if texture has been disabled. * Added GLES1 tests for tex coord pointer, including tests to make sure that tex coord pointer is no longer used if the texture is disabled using glDisable(), and that it is used again when texture is enabled using glEnable(). * To ensure that tex coord pointer is not used, the test draws using enough vertex data that would exceed the texcoord array size, which can trigger segfault if accessed. Bug: b/310688730 Change-Id: I5d259c83a172cc1a11733c0b42c2f9b02c9b2967 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5124259 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 016b1033 2023-12-20T17:46:45 Manual roll vulkan-deps from 06ba2decfb32 to 9c3a33aed0ec (44 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/06ba2decfb32..9c3a33aed0ec Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a7785ea1ff..c155f881ee * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e03c8f5c8e..f0cc85efdb * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/41263fc5aa..80207f9da8 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/979242bdd7..40633a61aa * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8f6c0e51dc..b42addf414 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/b89f4b8415..524f8910d0 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0c6e58c7f0..ea496a3de8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,ynovikov@google.com Change-Id: Ibe87c94ba0e647022b6888fa3bc98bb8e445f1dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5141506 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 0aaa8de9 2023-12-19T23:23:40 Vulkan: Fix memory tracking vs external texture acquire ... with a layout of GL_NONE. Bug: angleproject:8464 Change-Id: I94690c5693c5bcb6d510e4a27097206f0da58a41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5138656 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e9c0241d 2023-12-19T10:23:13 Vulkan: Rely on Vulkan 1.1 entry points in tests Some KHR entry points that were promoted to Vulkan 1.1 no longer seem to be loadable with their KHR symbols. Bug: angleproject:8464 Change-Id: Id5417e5b047e6bd34d144fead518f771c17658e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5135676 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6951508b 2023-12-19T19:30:05 Manual roll vulkan-deps from de368ee1bf18 to 06ba2decfb32 (1 revision) Manual roll requested by ynovikov@google.com Suppress SYNC-HAZARD validation errors in vkQueueSubmit(), enabled by https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/7129 https://chromium.googlesource.com/vulkan-deps.git/+log/de368ee1bf18..06ba2decfb32 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/eebe1dfcef..0c6e58c7f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: b/316013423 Change-Id: Id63a3ddd4615f8a520b68588db4520d30a687598 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5137081 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 82c95b30 2023-12-20T07:01:16 Roll Chromium from 9a3d5ea818e6 to 71a57680b06d (589 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9a3d5ea818e6..71a57680b06d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b3e01488a0..f2f5a10150 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5fe189d3b5..e8e9f90e58 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a478c1743a..edab5262fa * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/23118cc3c3..49c8dd3237 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d855d8bc2e..715a7b8509 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/3bb3983367..3cafb40647 * third_party/r8: FxJgCW2a6MbqM5WkyXAxu91pykj7_QAYNerG9ettPPAC..7Bh-YvMIvXQguOKifHK0dPByTf-YalKg29UInFS7lLAC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dbe34d7b76..289bde07a0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/13930ba900..9f03ce32b7 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I1d3b182b29aee878ef43cf21612bc9de1c0a5ebd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5139198 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 5a062a39 2023-12-14T21:15:59 Do not update the vertex attribute limit on divisor change The effect of the divisor on the vertex attribute limit is accounted for in StateCache::updateVertexElementLimitsImpl since https://chromium-review.googlesource.com/c/angle/angle/+/5101508, and so the vertex attribute's mCachedElementLimit is now independent of the divisor. Bug: angleproject:8448 Change-Id: I3f76986d6b8d3ba6b0ebd955f9a26854ee8c20e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5122996 Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 9f148c41 2023-12-14T00:00:00 Metal: Fix triangle fan indices generation * Ensured that the second index is preserved when skipping leading primitive restart values * Restricted the search loop to the index count * Ensured that draw calls are skipped when the generated index buffer is empty to avoid Metal validation errors, also for line loops Fixed: angleproject:6458 Change-Id: I3194eb9db3e7e225448901edce167a2091563cd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5132092 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
angle-autoroll e3600abb 2023-12-19T15:55:05 Manual roll vulkan-deps from 510bed662233 to de368ee1bf18 (34 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/510bed662233..de368ee1bf18 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/9a35abff55..a7785ea1ff * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6b4f0c9d0b..e03c8f5c8e * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/19a863ccce..41263fc5aa * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0133778cb1..979242bdd7 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1ee9eea9f1..8f6c0e51dc * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/4a89051018..b89f4b8415 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3d6bdd9dc7..eebe1dfcef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,ynovikov@google.com Change-Id: I22cec01f0906202cfb0b3ae9b15f6da6e2bb574f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5132325 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 66da618c 2023-12-19T16:25:35 Skip UniformBufferTest.BufferBlockBindingChange on Mac NVIDIA GL Flaky Bug: angleproject:8465 Change-Id: Ic923a3af4937a346fdba0b80d486a9ed8e46402e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5136275 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 80db7c4b 2023-10-17T10:03:06 Vulkan: Remove fixed VU suppressions Bug: angleproject:5309 Bug: b/175584609 Change-Id: I8f952a1feb235b6bd060b5fe0b89c01fde6f84be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4946592 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 59d0e50b 2023-12-19T07:34:27 Roll Chromium from 511b16a33b04 to 9a3d5ea818e6 (459 revisions) https://chromium.googlesource.com/chromium/src.git/+log/511b16a33b04..9a3d5ea818e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ad3bfe9769..b3e01488a0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a481c9ee1a..5fe189d3b5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8c03186e63..a478c1743a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2298e63899..23118cc3c3 * third_party/fuchsia-sdk/sdk: version:17.20231211.2.1..version:17.20231218.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/28d7125795..d855d8bc2e * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c7c5649e8b..8806fb8bb2 * third_party/r8: w4FEa7Y-q3MIsKwjR0LC_-fPnANe8DlIIAWD_pMF5z0C..FxJgCW2a6MbqM5WkyXAxu91pykj7_QAYNerG9ettPPAC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/562a4372d1..002f75df25 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d888191c19..9d7648a0c7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ebb8297256..13930ba900 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I110ef3adbeec45dc0126a1c7b497de9acc8103bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5133385 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang bd5dce9a 2023-11-21T15:39:04 Metal: Use MTLEvent instead of MTLSharedEvent when possible Refactor mtl::Sync to be abstract and have multiple implementations using either MTLEvent or MTLSharedEvent. Use MTLEvent in all cases except for EGL Syncs when the user sets the sync type to EGL_SYNC_METAL_SHARED_EVENT_ANGLE. Determine completion of the sync object by watching for completion of the command buffer where the event's signaling was enqueued. Avoid any sleep loops by waiting on a condition_variable which is notified when the completed queue serial is updated. Forked from CLs by sky@ and kbr@ Bug: angleproject:8153 Change-Id: I4547444b596366496c811cb9954872b85ab14ad8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5133706 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 4bf40237 2023-12-18T15:24:15 GL: Fix missing glUniformBlockBinding handling When a program is current and this call is made, the program is made dirty so that the GL backend reacts to this call. Prior to https://chromium-review.googlesource.com/c/angle/angle/+/4922969, the program was made dirty when its executable was installed as well (if it had any UBOs dirty), but that change removed it. As a result, if this call was made while the program was _not_ current, the GL backend would miss processing it. This call ensures that the appropriate dirty bit is set when the program is made current again. This revealed a bug in the Vulkan backend where sometimes the executable's dirty bits would not get reset. This was benign but fired an assertion, and is fixed in this CL as well. Bug: chromium:1511506 Change-Id: Iae86ba0aa5b8f9e4f20dd6df6002d37e405280e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5123005 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Yiwei Zhang 1e4c4c76 2023-12-18T19:35:13 Vulkan: avoid disabling explicitlyCastMediumpFloatTo16Bit for venus We disabled it to work around below legacy skia cts: CtsSkQPTestCases org.skia.skqp.SkQPRunner#gles_gradient_many_stops The test no longer exists in newer skia cts. Meanwhile, we have to drop the workaround for other precision issue on Mali-G52. Bug: b/316474995 Test: dEQP-GLES2.functional.shaders.algorithm.rgb_to_hsl_vertex Change-Id: I18394595632d05657e96f8b9c9675b4dd959d92b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5133372 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org>
angle-autoroll d704273d 2023-12-18T10:01:40 Roll SwiftShader from 77be35e337bb to 2fa7e9b99ae4 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/77be35e337bb..2fa7e9b99ae4 2023-12-15 dnfield@google.com Support a static build rule for swiftshader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Id2376205e9c18e69474783b6de2566c12eb8ec9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5129891 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 466e0b5a 2023-12-18T07:47:04 Roll Chromium from bdc028a23412 to 511b16a33b04 (571 revisions) https://chromium.googlesource.com/chromium/src.git/+log/bdc028a23412..511b16a33b04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/caa7a57c21..ad3bfe9769 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9325d4d500..a481c9ee1a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/172dd7d235..8c03186e63 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/99f5e4d09e..28d7125795 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/90769c8b0c..562a4372d1 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/fb38cd74c6..d888191c19 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0da27905d2..e592c0f866 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/465ab5e2d6..ebb8297256 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ia4065386ed24793410f0a185883f76b59fe3280c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5130886 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 40f4de8f 2023-12-15T10:17:32 Vulkan: Ensure we use cached memory for readPixels stagingBuffer Previous CL crrev.com/c/5112759 does not solve the performance issue for ChromeOS. The reason is that on more recent intel GPU, there is no hostVisibleCachedCoherent heap. When we allocate staging buffer, we specify CachedCoherent as the preferredFlags instead of requiredFlags. This means we still end up getting UncachedCoherent since VMA tries to respect coherent bits as first priority. This CL Changes CachedCoherent to CachedPreferCoherent, and made Cached as required bit, thus ensures the memory allocated is cached. Since coherent bit may not be honored, thus we have to call invalidate/flush (which underline implementation will check the bit and early out if no need). Somehow on ARM GPU using cachedNonCoherent staging buffer causing many test failures, even though we do call invalidate() after allocation, and tests pass on all other GPUs. It almost indicates ARM driver have a bug with invalidate() that it is not doing expected. But before I can be sure and fixed, I added feature bit to keep ARM the old behavior, which uses UnCached memory for readPixels which should suffer the performance as well. Bug: b/315836169 Bug: b/310701311 Change-Id: I1eec6105ce74275faa893b0206be8470f0cde72f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5122318 Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Stephen White a950f005 2023-12-06T18:58:35 Move compressed format validation to Vk backend. Add test to call glCompressedTexSubImage3D() from a pixel unpack buffer. This currently fails on OpenGL. Bug: angleproject:8449 Change-Id: I863b602e39a14878af8745ff62b408bdd879bc98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5100348 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Austin Annestrand 80893f26 2023-11-30T16:57:15 OpenCL: Remove unneeded impl getters Some of the OpenCL backend (impl) getters are not needed. These are the size query for image creation, and CL source retrieval for program objects not created from source. Bug: angleproject:8438 Change-Id: I76b39b75f1ae76ec0c3c94d5715632cb9dd4900a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5078243 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 66d29149 2023-10-16T12:43:43 OpenCL: Add scaffolding to renderer/vulkan code Start off ANCLE (OpenCL on ANGLE) with backend scaffolding code with placeholder API error returns until they are later implemented. Bug: angleproject:8377 Change-Id: I223d3482cce097ccb298e121fc03ec416e8958fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4950556 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 18a68f6d 2023-12-07T16:23:10 Fix vertex attribute limit check Bug: angleproject:8448 Change-Id: Ie5d2b71f0be86b31ec74a1d55501b60a25245668 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5101508 Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Austin Annestrand 5e619b21 2023-11-29T14:56:59 OpenCL: DoubleFpConfig query validation fix There is currently a minor bug in the CL validation code that unconditionally validates "cl_khr_fp64" extension string when client queries for fp64 support. This is correct behavior for OpenCL 1.1 and lower. However for OpenCL 1.2 and greater, this became a core query for clGetDeviceInfo via "CL_DEVICE_DOUBLE_FP_CONFIG". Thus, on some 1.2 and greater implementations (ANGLE CL passthrough), this extension string wouldn't be specified since its a core API query in that case - and validation check will incorrectly fail via: ANGLE_VALIDATE_EXTENSION(info.khrFP64) Fix is to conditionally check this for the appropriate CL versions. Bug: angleproject:8436 Change-Id: Id2bb5699fa523061d738af19edb465a78dbd880d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5075775 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 3439e421 2023-12-15T11:37:53 Vulkan: Remove AHB workaround for camera app This is now fixed in camera app main branch. The workaround is removed here. Bug: b/239181279 Change-Id: I782baf7a42a8c9a897f1947d8b2f6feba606ce29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5126931 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand c1aaa313 2023-11-29T18:54:06 OpenCL: Updated autogen script for updated CL error handling Part 3 of Issue 8435: Updated entrypoint autogen script for CL to: - Remove errorCode param for all CL APIs returning CL objects - Init CL error TLS object for all CL APIs prior to calling ANGLE FE Bug: angleproject:8435 Change-Id: I4f1784c0bda393d5f3126f205f17ec24662424ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5075774 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand ed7c31c7 2023-11-29T18:31:43 OpenCL: Replace error-passing APIs to use angle::Result Part 2 of Issue 8435: This part replaces existing error handling for all CL APIs that return CL objects to now use "angle::Result". Bug: angleproject:8435 Change-Id: I75e41c7cbb06220cabec7cc9f9cb5107a3b6bd6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5075773 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Gowtham Tammana cd56b248 2023-12-08T15:36:17 third_party/clspv: Add GN build files The clspv project uses CMake for build. Adding support for GN build in here. The build is currently setup to generate linux/x86 and android/arm64 artifacts for now and relevant gn files are placed in `third_party/clspv` location. Bug: angleproject:8369 Change-Id: Iec7ef1916617a8b8a93324ff7302f89bd571b814 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106594 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll dea00fff 2023-12-15T16:20:42 Roll VK-GL-CTS from ecdec25ff753 to fa3dcc95cfc0 (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ecdec25ff753..fa3dcc95cfc0 2023-12-15 rgarcia@igalia.com Test redundant binds with dynamic and static state 2023-12-15 Tyler.Schneider@amd.com Ray Query stress tests cases: dEQP-VK.ray_query.stress.* 2023-12-15 boris.zanin@amd.com VK_KHR_cooperative_matrix - multicomponent 2023-12-15 rgarcia@igalia.com Test frag shader library with varying sample counts 2023-12-15 rgarcia@igalia.com Remove many ESO and GPL variants without significant coverage loss 2023-12-15 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-12-15 ziga@lunarg.com Fix ds formats in depth_stencil_resolve tests 2023-12-15 gleese@broadcom.com Remove data for tests that don't exist 2023-12-15 cturner@igalia.com Fix missing queue selection logic in several transfer_only tests 2023-12-15 amber@igalia.com Make extra padding draws in the indirect draws tests produce incorrect output. 2023-12-15 lorenzo@khronosgroup.org Add pass/fail results for each session in cts-run-summary.xml 2023-12-15 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2023-12-14 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-12-12 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-12-10 ziga@lunarg.com Update vulkan-docs and merge dev/VK_KHR_vertex_attribute_divisor into main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ic9a182666ef032f41ce4c6e0910fdf692b8a9783 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5126168 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a1789bef 2023-12-15T07:01:42 Roll Chromium from a7af25804d20 to bdc028a23412 (543 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a7af25804d20..bdc028a23412 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/87e1b716a4..caa7a57c21 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6ba5182022..9325d4d500 * buildtools/reclient: re_client_version:0.124.1.13f78cc-gomaip..re_client_version:0.125.0.f3883c2-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/301a3438a2..172dd7d235 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/15a737bc5c..8c91f1a73b * third_party/android_build_tools/manifest_merger: _2qAeWRS5XnDom8pAt4e7GuEof_KB86zQO0Lnr5uQBQC..Wk3Q4wN95_lB58e1sRWAgXljF18hHuJI60JbyPmqXVoC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/396204ce89..2298e63899 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6444de14d1..390005586b * third_party/kotlin_stdlib: QEHg036Jc2HWG4-ao7usl1QUexRidGFFSgqqWUpmK-YC..KIU1zubKhCbwM8mZNhGe3NriMr5QZRo3mHdOu4rAYowC * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/dbea847672..99f5e4d09e * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/6bd25883ff..c7c5649e8b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b66828a72c..fb38cd74c6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3beb3d18f0..465ab5e2d6 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Idc24f32f8d46d3b06247fc52d0c6bdddb9e9a278 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5124330 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand a9512a9f 2023-11-29T14:56:29 OpenCL: Replace error-return APIs to use angle::Result The motivation of converting existing CL APIs using "cl_int errorCode" to now use "angle::Result" is for better interop with internal ANGLE plumbing/abstractions. To facilitate this, we now make use of a TLS errorCode object that we set internally and read from entrypoint/stubs layer so that we can propagate back to user. Bug: angleproject:8435 Change-Id: I7c2a786019c33c56649be4b6e8b61bc318497bb1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5075772 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Peiyong Lin fca3eb6b 2023-12-12T23:00:41 Refactor ANGLE settings UI. This patch refactors the ANGLE settings UI to make sure it aligns better with the settings global variables. This patch: 1) moves all ANGLE rule parsing logic to its own class, the parsing will only parse the rule and store them, it currently does not set the settings global variables; 2) removes the global enablement as it is now an option in Developer options and that one has better guarding condition; 3) refactors the logic to query all packages in the system, instead of constructing them with raw package name, use application name to allow a more user-friendly UI, and also allow to toggle for system applications. 4) adds two new entries to allow building ANGLE apk without any ANGLE libraries; 5) adds a README.md file to document the design. 6) removes unused functions and variables and minor renames. Bug: b/293503000 Test: manual Change-Id: I7287935791c00040b0eacba7dce3e4df5eb4de3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5118135 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Peiyong Lin <lpy@google.com>
Alexey Knyazev 8f966559 2023-12-07T00:00:00 Metal: Fix matrix vertex attributes with mixed sources Updated VertexArrayMtl::setupDraw to support matrix vertex attributes that use current and array values simultaneously. Simplified the helper function. Fixed: angleproject:8456 Change-Id: I09a26a978cda4b9ac3747325ad571d5ad2fff72d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5116500 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll bb51167b 2023-12-14T07:01:51 Roll Chromium from 9197ec952f31 to a7af25804d20 (593 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9197ec952f31..a7af25804d20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3f2733bfc4..87e1b716a4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8d75795be6..6ba5182022 * buildtools/linux64: git_revision:7367b0df0a0aa25440303998d54045bda73935a5..git_revision:85944ebc24a90ec1e489e85a46fdc68542c3146f * buildtools/mac: git_revision:7367b0df0a0aa25440303998d54045bda73935a5..git_revision:85944ebc24a90ec1e489e85a46fdc68542c3146f * buildtools/win: git_revision:7367b0df0a0aa25440303998d54045bda73935a5..git_revision:85944ebc24a90ec1e489e85a46fdc68542c3146f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/23d202a3d2..301a3438a2 * third_party/android_build_tools/lint: HauAZeOm40GKv93v51MaoIilRbuPDo29QhN98r7kQaMC..pvFK7MtH5IsrWhv7D-JOyKc5CPgDCyDAWjN_DbAFjVwC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c2cfac4228..7a76422eef * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bdaddf92ea..396204ce89 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/18bb70aed6..6444de14d1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/1f70899ab6..dbea847672 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d5e7c425e0..6bd25883ff * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/278e5fbafc..3bb3983367 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/41759e11ec..e1ae7a6663 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/69a2e01edd..90769c8b0c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3ccfff74a0..dbe34d7b76 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/884774321e..802db79a6a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2eeaae46cb..3beb3d18f0 Clang version changed llvmorg-18-init-12938-geb1d5065:llvmorg-18-init-14420-gea3a3b25 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/3ccfff74a0d0cda8ddf2612cc09217278fb018bc..dbe34d7b760dc429ddc938fa19b92c2b330a72ec/scripts/update.py Bug: None Tbr: solti@google.com Change-Id: I3a511ea37be475f736fe570730bd14a9e0ad2b09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5121652 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yiwei Zhang 524bcb8e 2023-12-13T20:21:38 Vulkan: avoid forcing preferSubmitAtFBOBoundary with Venus It turns out benefiting Venus atop ARM while hurting in a non-trivial way on old Gen Intel due to execbuf overhead. Bug: b/314847707 Test: 2%+ gain for trex on ANV on CML Change-Id: I61eb18a05e94c97ee6a4d70f98ae30423155e632 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5118128 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Solti c8604e97 2023-12-13T19:48:16 suppress VUID-VkVertexInputBindingDivisorDescriptionKHR-divisor-01870 Unblock the autoroller first Bug: angleproject:8454, b/316176944 Change-Id: I7f692a81e7a8b0189f83ce6f00e0cec6e2d7e2b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5118126 Commit-Queue: Solti Ho <solti@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Solti Ho df4d9667 2023-12-13T18:28:53 Revert "Optimize HandleAllocator for fast ID churning." This reverts commit b25ffe5a9775cc912a304c8552dd9c097a93420a. Reason for revert: b/316162914 Original change's description: > Optimize HandleAllocator for fast ID churning. > > Instead of calculating ranges of IDs and the overhead with updating > them every allocation/release, store a released ID list in a small > FastVector. > > Optimize the allocate path for the "good case" of no reserved IDs so > that it either pops the last released ID or incriments a next value and > returns it. Release has a similar cost of just a push_back when there > are no reserved IDs. > > This adds a small fixed memory cost due to the FastVector and a dynamic > memory cost of mReleasedList having up to N elements where N is the > maxmimum total handles allocated at one time. > > Bug: angleproject:8434 > Change-Id: I7c5aa126b5303c105cd2464d0d0933b922cc2b8f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5101509 > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:8434 Change-Id: Ide43d787b6942cc6b622e3b5d938bfbbbf3b3ebb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5120277 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuly Novikov 1c9ac273 2023-12-13T17:34:19 Remove mentions of "no GTest" dEQP targets in docs. Suites removed in https://chromium-review.googlesource.com/c/angle/angle/+/3173251 Bug: None Change-Id: I59ffc95f3772f8d4ea89133083fe2612b1d5ee39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5117260 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll bdd3a778 2023-12-13T07:00:03 Roll Chromium from fd8978318166 to 9197ec952f31 (617 revisions) https://chromium.googlesource.com/chromium/src.git/+log/fd8978318166..9197ec952f31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2711b553c3..3f2733bfc4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d7e0ec1306..8d75795be6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a5c15ce1b6..23d202a3d2 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c4a82efb2f..c2cfac4228 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d3f7f448d3..bdaddf92ea * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aa65be9856..18bb70aed6 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a88e6d6daa..1f70899ab6 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/dd5fc1316c..69a2e01edd * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d689bae2fa..2eeaae46cb No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I6db743e5a70f394b9c485c7e1bd717f49a3710ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5118122 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gowtham Tammana cdacdf63 2023-12-11T11:18:34 llvm: Move it to third_party/llvm/src Clone the llvm_project into third_party src location to make for README.chromium and related files. Bug: angleproject:8369 Change-Id: I625eefd8fd883a956985d217f33274ebe7fbe7ed Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5111802 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang b25ffe5a 2023-12-07T16:36:29 Optimize HandleAllocator for fast ID churning. Instead of calculating ranges of IDs and the overhead with updating them every allocation/release, store a released ID list in a small FastVector. Optimize the allocate path for the "good case" of no reserved IDs so that it either pops the last released ID or incriments a next value and returns it. Release has a similar cost of just a push_back when there are no reserved IDs. This adds a small fixed memory cost due to the FastVector and a dynamic memory cost of mReleasedList having up to N elements where N is the maxmimum total handles allocated at one time. Bug: angleproject:8434 Change-Id: I7c5aa126b5303c105cd2464d0d0933b922cc2b8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5101509 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev e172c104 2023-12-07T00:00:00 Metal: Fix temporary array initialization Ensure that temporary array declarations have literal initializers to bypass Metal compiler issues. Fixed the following tests on Apple silicon: dEQP-GLES2.functional.shaders.indexing.tmp_array .float_const_write_dynamic_loop_read_fragment .float_const_write_dynamic_loop_read_vertex .float_const_write_dynamic_read_fragment .float_const_write_dynamic_read_vertex Fixed: angleproject:7058 Change-Id: Id4a360b0a5a15da43ce4626c6dfe03556cc9d0f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5115898 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Solti 5e63cee5 2023-12-12T20:59:44 update e2e expectation Bug: b/316013423 Change-Id: I4a70fdc0b38d8e412c0ca1035564aecb1f1dbc32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5118119 Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Solti Ho <solti@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 35e49df7 2023-12-11T21:16:57 FrameCapture: Skip eglQueryContext We don't use the return value of the call, so it can be omitted from the capture. Test: Flip capture Bug: b/308208067 Change-Id: Ib3dfea2b7bd5638092bd691e66c6b9e2b6fabf15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5112776 Reviewed-by: Mike Schuchardt <mikes@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 9b66848f 2023-12-11T20:54:30 FrameCapture: Handle context Reset with no calls The code was assuming that setDefaultResetCalls adds reset calls for an entry point, but it has logic for skipping if the current state is already default. This CL checks to see if we added any calls for the entry point before trying to iterate through them. Test: Flip capture Bug: b/308208067 Change-Id: I8a214b0eb0df068d6b3172c0ca1406f6751f91ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5114271 Reviewed-by: Mike Schuchardt <mikes@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Kieron Josephs 282a5fb4 2023-12-08T15:53:17 Fix out-of-bounds vector index when using SPIR-V precision fixer Accessing mVariableInfoById after id has been replaced by the precision fixer was causing an out-of-bounds access. Running SpirvVaryingPrecisionFixer::modifyEntryPointInterfaceList before SpirvSecondaryOutputTransformer::modifyEntryPointInterfaceList was causing an out-of-bounds access for the same reason. Bug: angleproject:8452 Change-Id: I54f7f105ec2fb5aeb3e4234e8e3e052bcc42977c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5105193 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang f8fae1ff 2023-12-08T13:20:36 Validate Uniform variable limits with each iteration VariablePacker would loop over all variables and sum up the total row counts before validating. Each variable can take hundreds of rows so it is possible to overflow the counters before validating them. Validate the limits with each iteration and early-out when the limits are exceeded. https://bugzilla.mozilla.org/show_bug.cgi?id=1864587 Bug: chromium:1864587 Change-Id: Ic235ada1516a0d5a9948d82b22f6316a037c09ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106408 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 398cfb4b 2023-12-12T08:09:41 Roll Chromium from f9f8b1a54ff6 to fd8978318166 (587 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f9f8b1a54ff6..fd8978318166 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e2ef5faece..2711b553c3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/48eb5d0b33..d7e0ec1306 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8a289204b0..a5c15ce1b6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6edbd6b5ca..d3f7f448d3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1714cc6e5a..aa65be9856 * third_party/fuchsia-sdk/sdk: version:16.20231129.1.1..version:17.20231211.2.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/16665d119a..a88e6d6daa * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/147f175921..b66828a72c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bc59d8d3cf..d689bae2fa No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I73fb0cd578d9f8ff67e30022f63bb7c6e0287776 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5114867 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0