|
263232ef
|
2020-02-23T15:02:16
|
|
Trace/Replay: Pass CallCapture to parameter replay writer.
This will allow more advanced processing when writing the cpp replay
for a specific parmeter. For the uniform locations map it'll allow us
to look up the specified program from the call parameters.
Bug: angleproject:4411
Change-Id: I4e91b3e4c6775c42140d00b2d155344b553a7404
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2067629
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
e3aee0b4
|
2020-02-20T15:19:18
|
|
Remove skip dEQP-GLES31 test now passing on NVIDIA
More precisely, the test is
dEQP-GLES31.functional.vertex_attribute_binding.usage.mixed_usage.mixed_api_change_binding_point
Bug: angleproject:2432
Change-Id: Iafb401380ed00bd823a821d6814be5c22f9667a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065670
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
a889d30f
|
2020-02-04T23:08:55
|
|
Reland "Provide default implementation of rx::DisplayEGL"
This is a reland of 123fd97000bb9fd912159bb9ccc62308b763aead
Original change's description:
> Provide default implementation of rx::DisplayEGL
>
> Will allow to use EGL instead of GLX on X11.
>
> Meant to be used on modern EGL so it requires the extensions
> EGL_KHR_no_config_context and EGL_KHR_surfaceless_context.
> This keeps the default implementation simple (no pBuffer
> fallback)
>
> Also provide simple WorkerContextEGL.
>
> Bug: angleproject:4328
> Change-Id: I92a1ded9e09e65de8bb83710274e0a73ecdff0a4
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061168
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Bug: angleproject:4328
Change-Id: I02046613324e9283ba8f2ed02dd9c7ce703e0fde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063045
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c7f63a01
|
2020-02-23T16:46:41
|
|
Fix debug callback in perf tests.
Was not outputting correctly. Also print more information like the type
and severity of the message. Moves some stringification code out of
RendererGL into common/utilities.
Bug: angleproject:3630
Change-Id: I029e279764fa4ae5cab8d903bd0ef7d376b7b846
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2067630
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
959d077f
|
2020-02-24T07:01:29
|
|
Roll third_party/vulkan-tools/src 16cf5591e399..a553ed74b7fe (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/16cf5591e399..a553ed74b7fe
git log 16cf5591e399..a553ed74b7fe --date=short --first-parent --format='%ad %ae %s'
2020-02-21 charles@lunarg.com vulkaninfo: dynamically load vulkan
2020-02-21 charles@lunarg.com vulkaninfo: Fix uninitialized surface capabilities
2020-02-21 charles@lunarg.com vulkaninfo: Fix uninitialized surface capabilities
Created with:
gclient setdep -r third_party/vulkan-tools/src@a553ed74b7fe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I938f3be97272ce1cc0f3c5d2ecf19b174925b685
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2069909
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
b7840380
|
2020-02-24T07:01:53
|
|
Roll third_party/glslang/src c12493ff69e2..07e1a0a67aee (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c12493ff69e2..07e1a0a67aee
Created with:
gclient setdep -r third_party/glslang/src@07e1a0a67aee
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ib613e2bf160c21f10c5bac3a6a682a2a8125486e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2069910
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
8b73596f
|
2020-02-24T07:01:14
|
|
Roll third_party/SwiftShader f50cc82b3bed..214ec337a0b2 (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f50cc82b3bed..214ec337a0b2
git log f50cc82b3bed..214ec337a0b2 --date=short --first-parent --format='%ad %ae %s'
2020-02-23 thakis@chromium.org Fix Wrange-loop-analysis warnings in swiftshader.
2020-02-21 amaiorano@google.com Replace target_cpu with current_cpu in Build.gn files
2020-02-21 sugoi@google.com Revert "Subzero: add support for large stacks on Windows"
Created with:
gclient setdep -r third_party/SwiftShader@214ec337a0b2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I5445af4e346d8d80d91f299f373e0958a210d6a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2069908
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
b5576b67
|
2020-02-21T20:44:42
|
|
Vulkan: Fix pipeline stage when waiting on a semaphore
Using VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT in pWaitDstStageMask doesn't
create a dependency, since no memory is accessed during that stage.
Switch to VK_PIPELINE_STAGE_ALL_COMMANDS_BIT to synchronize all accesses.
This fixes flickering observed in WebGL on ARM GPUs when composited using
Vulkan in Chromium.
Bug: angleproject:4422
Change-Id: I37da461c03dbf52f8658408b159c2b173cccd0b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068906
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
|
|
|
a741abb9
|
2020-02-21T16:37:37
|
|
Vulkan: Rename CommandGraphResource to Resource.
Also renames the h and cpp files to ResourceVk (to keep distinct from
other resource.h/cpp files) and renames 'onResourceAccess' to 'retain'.
Cleans up a few remaining mentions of the command graph in comments.
Bug: angleproject:4029
Change-Id: Ifc8e880c8cea3fc48a4aec4730191c88aa35a076
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065920
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
468dfed3
|
2020-02-21T12:12:51
|
|
Reformat GN files
Otherwise this blocks the CQ at presubmit.
Bug: angleproject:3492
Change-Id: I3cf77c72daa358f5e1eabecf1dcb8808a1dc9e07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068538
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
eacec98a
|
2020-02-21T17:23:21
|
|
Suppress SwANGLE dEQP GLES3 failure.
Bug: angleproject:4418
Change-Id: Iec75633351add75433eef3044390934149903ba8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068898
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
042fe72c
|
2020-02-21T17:03:11
|
|
Roll chromium_revision a9ad696264..86e00b5dd2 (742676:743688)
Change log: https://chromium.googlesource.com/chromium/src/+log/a9ad696264..86e00b5dd2
Full diff: https://chromium.googlesource.com/chromium/src/+/a9ad696264..86e00b5dd2
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/5499c7c1d6..5d6bdfc4f1
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/afc5b798c7..feb2d0c562
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/177ef69e99..74854b3f7b
* third_party/yasm: https://chromium.googlesource.com/chromium/src/third_party/yasm/+log/0d0134789a..8e4e548d0b
DEPS diff: https://chromium.googlesource.com/chromium/src/+/a9ad696264..86e00b5dd2/DEPS
No update to Clang.
TBR=spang@google.com,
BUG=None
Change-Id: I1aab8058773e5846dc731170737840084363b587
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068897
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
|
|
f3325dd8
|
2020-02-21T10:20:01
|
|
Add uniform location checks for ignored/invalid location
R=geofflang@chromium.org
Bug: chromium:1028418
Change-Id: Iae257fbfa8d58f9a0aa7b876fba416bb060fbe54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068127
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
8df46810
|
2020-02-21T13:32:29
|
|
Suppress SwANGLE dEQP failures
As observed from try runs on SwANGLE waterfall.
Bug: angleproject:4110, angleproject:4371, angleproject:4416
Change-Id: I61cf86c60085a53896b7b66fcbf662ab7abe1c18
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068542
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
39087f4a
|
2020-02-16T11:53:23
|
|
Refactor DrawCallPerf test parameters.
Use the new combiners functions added in an earlier CL. Makes it easy
to maintain bigger lists of test combinations.
Also a few other changes:
- removes some D3D9 perf testing since we don't maintain this config
- removes the "validation only" tests. these were mostly redundant
- makes the tests permutation combinations more consistent
Bug: angleproject:3630
Change-Id: I175d887a01b21123f83f9fa4f64dacaa2644147a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059468
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c4197713
|
2019-06-03T19:23:02
|
|
Implement glImportMemoryZirconHandle & glImportSemaphoreZirconHandle
Implement import of fuchsia external objects passed by zircon handle. This
works exactly the same as with file descriptors.
Bug: angleproject:3492
Change-Id: I4d46917dfc5902f00c94550158a9f8073097f0a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1642334
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
5b78b389
|
2020-02-21T12:03:22
|
|
Add geofflang@google.com to OWNERS.
Rolling ANGLE into AOSP is done with an @google.com account so we need
to have @google.com accounts in the OWNERS file to land rolls.
Will add more @google.com accounts if this is successful.
BUG=angleproject:2344
Change-Id: I0319656a5ee5d3cc6403906ae6756721608c773b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068124
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
a18f4145
|
2020-02-19T22:42:12
|
|
Trace/Replay: Add uniform location type.
This is a large refactor that replaces instances of "GLint location"
for uniform locations with "UniformLocation location". This boxed type
is similar to the ResourceID types that we use to capture resource IDs
more easily. Eventually this will give us a more portable replay.
Bug: angleproject:4411
Change-Id: I848e861c3956d95b6b953f57f8b6a2c4a676766f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066117
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
d3aad0f4
|
2020-02-20T08:59:58
|
|
Vulkan: Remove command graph size overlay widget.
No longer applicable without the command graph.
Bug: angleproject:4029
Change-Id: If75e3aca56eb18567074e14ceb23b3fd7a0afb3d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065919
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
61194f93
|
2020-02-21T07:01:02
|
|
Roll third_party/vulkan-loader/src c357af84c7cb..136207a63495 (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c357af84c7cb..136207a63495
git log c357af84c7cb..136207a63495 --date=short --first-parent --format='%ad %ae %s'
2020-02-20 mark@lunarg.com loader: Remove standard_val refs from LoaderLayerIF doc
2020-02-20 dj2@everburning.com Move BUILD_TESTS option up as well
2020-02-20 dj2@everburning.com Allow Vulkan-Headers to be in externals.
Created with:
gclient setdep -r third_party/vulkan-loader/src@136207a63495
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I99ef890234ddba0dd2ebaa2f85621eec902ba17e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068199
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
91817365
|
2020-02-21T07:01:08
|
|
Roll third_party/SwiftShader 74d3f371f201..f50cc82b3bed (6 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/74d3f371f201..f50cc82b3bed
git log 74d3f371f201..f50cc82b3bed --date=short --first-parent --format='%ad %ae %s'
2020-02-20 amaiorano@google.com Subzero: add support for large stacks on Windows
2020-02-20 sugoi@google.com VK_EXT_shader_stencil_export support
2020-02-20 bclayton@google.com Remove rr::Thread
2020-02-20 capn@google.com Support JIT on a separate thread
2020-02-20 sugoi@google.com Revert "VK_EXT_shader_stencil_export support"
2020-02-20 sugoi@google.com VK_EXT_shader_stencil_export support
Created with:
gclient setdep -r third_party/SwiftShader@f50cc82b3bed
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Iee314936392d69caf6fe77de0cbd9fd64b61aae5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068202
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
5b057604
|
2020-02-21T07:01:05
|
|
Roll third_party/vulkan-validation-layers/src 6112b121e104..a09ab94aa920 (5 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6112b121e104..a09ab94aa920
git log 6112b121e104..a09ab94aa920 --date=short --first-parent --format='%ad %ae %s'
2020-02-20 mark@lunarg.com stateless: Remove redundant API version check
2020-02-20 mark@lunarg.com corechecks: Remove redundant API version checks
2020-02-20 mark@lunarg.com tests: Added BP tests for deprecated extension warnings
2020-02-20 mark@lunarg.com practices: Updated deprecrated extension list
2020-02-20 camden@lunarg.com layers: Add deprecated extension warnings to BP
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@a09ab94aa920
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I291d41cff90476679d7cdf34f403f629bb4e300e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068200
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
c58458e6
|
2020-02-19T14:51:41
|
|
Vulkan: Remove CommandGraph code.
Also updates relevant comments to no longer refer to a graph.
Bug: angleproject:4029
Change-Id: Ic29716e9ae4926870f902947d49d8fee7af98662
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057804
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
519163ee
|
2020-02-15T12:20:17
|
|
Run debug callback in perf render tests.
This can catch unexpected GL errors from ANGLE or the system driver.
Only enable when ASSERTs are enabled to ensure that we get full
performance when profiling.
Helpful to diagnose incorrect perf test rendering. In this case it
helped diagnose that our frame tracing and replay do not correctly
remap uniform locations.
Bug: angleproject:3630
Change-Id: Ifd9f47196381e48f74a810ea0c9f9c0fd7a13a22
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057352
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
|
|
b8c6521a
|
2020-02-14T14:23:08
|
|
Reland "Move sampleAlphaToCoverage out of blendState"
This is a reland of f6e73131c528b1317067624bc71c3ce41a48f9aa
Aligned BlendStateKey fields
Original change's description:
> Move sampleAlphaToCoverage out of blendState
>
> This is the second step towards exposing OES_draw_buffers_indexed (that defines independent blend state for each draw buffer). This flag is global in all graphics APIs, however D3D11 technically puts it in the blend state.
>
> D3D11: BlendStateKey was extended to keep existing D3D11 state caching semantics.
>
> D3D9: a comment was added explaining why this feature was never implemented there.
>
> Bug: angleproject:4394
> Change-Id: Ie6a294eeb6fcf4c868a1f1001c4f7efd61692ccd
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057063
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Bug: angleproject:4394
Change-Id: Ia7aed863f0f9f6066daf1b02ecade3256f494062
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066698
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
94ec1e5f
|
2020-02-19T15:29:54
|
|
Vulkan: Update shader compilation documentation
Bug: angleproject:3394
Change-Id: If8df97644d07f258a8f1ea1bde6b6b3572f6d024
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062745
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e4ba2d87
|
2020-02-20T16:05:02
|
|
Pass ContextVk instead of gl::Context to internal methods
Minor cleanup to change funciton signatures of vulkan specific methods in
MemoryObjectVk & SemaphoreVk.
Bug: angleproject:2475
Change-Id: I230664548004ebc48b559e0f25264ea948ce5a1f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2067500
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
b8ca4309
|
2020-02-20T08:27:33
|
|
CaptureReplay: Emit unused resources
In the final frame of Manhattan, resources are cleaned up,
even if they are non-existent. This is allowed by the GLES
spec. Compilation of the replay would fail, for instance:
error: use of undeclared identifier 'gRenderbufferMap';
did you mean 'gFramebufferMap'?
const GLuint glDeleteRenderbuffers_renderbuffersPacked_0[] =
{ gRenderbufferMap[0] };
^~~~~~~~~~~~~~~~
This is because we are only declaring resources if they are used.
Instead, go ahead and emit the resources, then circle back when
filtering is implemented, allow that to optimize the replay.
Bug: angleproject:4091
Bug: angleproject:4223
Change-Id: Ib48da0d9c3f4f2eca268646e7717a12126b1d85c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066455
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
ce4918f1
|
2020-02-19T09:39:44
|
|
Vulkan: Sanitize Images & Buffers with non-zero values.
Only enabled for specific tests at the moment. This CL allows our tests
to sanitizes memory for the robust resource access extension. It is
quite slow so should not be enabled by default.
Only works for 1 level 2D color textures and buffers. Makes several
flaky robust resource initialization tests consistently fail.
Controlled via an angle::Feature in FeaturesVk.
It works by initializing memory to an abitrary non-zero value:
- if newly allocated memory is mappable, we map it in init and set it
- if a buffer or texture can be a transfer destination, we use a
staging resource
- otherwise we don't attempt to initialize the resource.
Bug: angleproject:4384
Change-Id: I9b4f347bfcddf3096f491ed0243bef86837feaa0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2043271
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
dec00bc8
|
2019-04-03T15:51:28
|
|
Generate entrypoints for Fuchsia external objects extensions
Add GL_ANGLE_memory_object_zircon_handle &
GL_ANGLE_semaphore_zircon_handle extensions to supported extensions list
and re-generate bindings.
Bug: angleproject:2475
Change-Id: I464aa402aaac916c1f459930c771a0813ec63c9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1642333
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
3352d492
|
2020-02-19T17:41:24
|
|
Vulkan: Add command stream diagnostics when graph is disabled.
Very simple diagnostics that prints out the command stream. Since there
is very little deferral right now the graph itself became quite a bit
simpler.
Also fills in some missing values in the switch that prints the command
name string.
Bug: angleproject:4029
Change-Id: Ib64a7fed6f9f56ce406cc7dbc6cc993ed510e2cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065530
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
cf2ec3b1
|
2020-01-31T16:55:50
|
|
Vulkan:Add FramebufferVk cache
This adds a FramebufferVk cache. Cache signature is based on unique Serial
values that are assigned to ImageHelper objects backing all color and DS
rendertargets as well as level/layer values unique to the imageView.
Update the Serials and cache signature at FramebufferVk::syncState() time.
L0 cache is a currently active framebuffer.
L1 cache retrieves previously created framebuffer from new cache.
If neither of those hit, create new FramebufferVk and add to L1.
Bug: angleproject:4322
Change-Id: I3f585271798ddfb9e5f194020adca8cf8a6b19dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033869
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
709f6285
|
2020-02-20T08:56:17
|
|
Vulkan: Enable FenceNV extension without graph.
Bug: angleproject:4029
Change-Id: I6b3f469b692010e373b9c82b689966da98b8a6cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065918
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
0941e653
|
2020-02-19T15:49:23
|
|
Add external object extensions for Fuchsia to GL API
Add extensions layered on top of GL_EXT_memory_object and GL_EXT_semaphore
to support GL & Vulkan interoperation on Fuchsia. They are analagous to
the file descriptor versions, except not quite as opaque.
This is a draft; the underlying vulkan extensions have not been submitted
to Khronos.
Bug: angleproject:3492
Change-Id: Ic4723ded9fff752c4186eaa6a7f07d9ac51a3364
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1642332
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
0aab41b7
|
2020-02-20T08:39:10
|
|
Vulkan: Make mapped memory available with graph disabled.
This copies functionality out of the command graph path. A preemptive
barrier ensures we don't need to issue an availability barrier when we
need to map buffer memory.
Bug: angleproject:4029
Change-Id: I868ce8bdb3c452dccf35cc9e70adf81ad7905c66
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065917
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
166875eb
|
2019-03-27T13:52:04
|
|
Don't clamp in glBlendColor if context supports renderable [half-]float.
Add test for glBlendColor >1.0, skipped on D3D9 since it's unsupportable
there.
Bug: angleproject:3323
Change-Id: I3fcf867dae96bdadf8a0183269d8f27b659d0baf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1541723
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jeff Gilbert <jgilbert@mozilla.com>
|
|
|
a61e273a
|
2020-02-19T14:51:40
|
|
Vulkan: Fix store ops with linear command recording.
DiscardFramebuffer was being ignored in the new linear path. Fix this
by using the correct APIs. Also cleans up some of the access to the
"RenderPassCommandBuffer" struct in ContextVk. Add a new accessor that
returns the RenderPass without a flush that ensures it is only called
when a RenderPass is already started.
Bug: angleproject:4029
Change-Id: Ibd199f3a371c0f91b448a0b34c8752dc8b76c284
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057329
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
b4357d46
|
2020-02-20T08:29:49
|
|
Update expectations after swiftshader fix
Swiftshader fixed issue with shader array length() function.
Bug: angleproject:4098
Change-Id: I129f87a80c4ac254bf1b1112d34fcd2b858eab6a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066454
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
612cf818
|
2020-02-20T07:56:39
|
|
Vulkan: Update ES 3.1 test expections
Breaking up an old test, narrowing the scope.
Bug: angleproject:4312
Bug: angleproject:4413
Bug: angleproject:4414
Change-Id: Ib570450dc42de111baaf72ba0033515e519bab5b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066451
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
bd4e756a
|
2020-02-17T09:49:45
|
|
Const-ify the validation layer.
Enforces that the validation layers should be working pretty much read-
only with the exeption of updating caches. Requires a few tricks:
- updates EP code generation to add 'const' to pointer parameters
- enables a kludge const_cast to enable the robust query extension
- makes some members of Framebuffer mutable to work around syncState
- makes 'is' queries and other methods in Context/State const
Will allow us to more safely expose the no_error extension.
Bug: angleproject:1280
Change-Id: Id9756757854c9e68fc096ecec8d93759fbe6b3a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2060689
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
4864413b
|
2020-02-17T15:34:33
|
|
Vulkan: Implement eglWaitNative function
Implement eglWaitNative API. It will call XSync() on XCB and
do nothing on other systems.
Bug: angleproject:4281
Change-Id: I597b75124a380df519ab10af3cab9b6e26f3194f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059620
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
2527327a
|
2020-02-20T07:01:08
|
|
Roll third_party/glslang/src 113d07a6ebda..c12493ff69e2 (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/113d07a6ebda..c12493ff69e2
Created with:
gclient setdep -r third_party/glslang/src@c12493ff69e2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I3152a0b7a861fa97d13687335fcc273dae06a831
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066053
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
32101999
|
2020-02-19T15:50:29
|
|
Vulkan:Skip appendToStartedRenderPass()
In the case where command graph is disabled, we don't need to call
appendToStartedRenderPass().
Bug: angleproject:4029
Change-Id: I9b9d1ad666a903fcb63ab394944cfe7adb836a08
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065708
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
bb654cf8
|
2020-02-15T23:54:44
|
|
[fuchsia] Migrate to SDK-provided FIDL & package targets.
Bug: chromium:1050703
Change-Id: I7c031f4501b567fde117c30b25f0bc071d4acc44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2058948
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
0a9c0b7b
|
2020-02-19T14:55:04
|
|
Vulkan: Fix image queue changes with graph disabled.
These again weren't being tested on the CQ. Probably necessary for some
image sharing scenarios.
Bug: angleproject:4029
Change-Id: Iccbebf127e2ec6fdb74dd213998674fff77b75b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065529
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
|
|
|
475c527b
|
2020-02-19T22:06:42
|
|
Update status of ANGLE conformance
Bug: angleproject:1944
Change-Id: Ifd26d11fad1395a7cb87bea9dc5385c122fd30d4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066077
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9421a20d
|
2020-02-20T07:01:08
|
|
Roll third_party/SwiftShader 8def9063c4fd..74d3f371f201 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/8def9063c4fd..74d3f371f201
git log 8def9063c4fd..74d3f371f201 --date=short --first-parent --format='%ad %ae %s'
2020-02-20 sugoi@google.com Array length fix
Created with:
gclient setdep -r third_party/SwiftShader@74d3f371f201
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ibc8be2fa16e4ff4efa8eb41e69a8b8f78954b860
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066054
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2156c444
|
2020-02-20T07:01:05
|
|
Roll third_party/vulkan-validation-layers/src f155ccfd202d..6112b121e104 (8 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f155ccfd202d..6112b121e104
git log f155ccfd202d..6112b121e104 --date=short --first-parent --format='%ad %ae %s'
2020-02-19 jeremy@lunarg.com tests: Skip negative test if extension unavailable
2020-02-19 mark@lunarg.com tests: Update threading test to include api name
2020-02-19 mark@lunarg.com threading: Plumb API names throught to error messages
2020-02-19 tony@lunarg.com layers: Fix swapchain CreateInfo flags
2020-02-19 mark@lunarg.com layers: Delete standard_validation.json source file
2020-02-19 mark@lunarg.com tests: Remove layer refs to standard_validation
2020-02-19 mark@lunarg.com BUILD.gn: Remove copying of standard_validation.json file
2020-02-19 mark@lunarg.com cmake: Remove copy of standard_validation.json file
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@6112b121e104
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I64239e4ac00cfc9f84307954d75abc822edc3fe8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066052
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
b0e9cd66
|
2020-02-20T07:01:02
|
|
Roll third_party/vulkan-loader/src 39e685ccd37e..c357af84c7cb (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/39e685ccd37e..c357af84c7cb
git log 39e685ccd37e..c357af84c7cb --date=short --first-parent --format='%ad %ae %s'
2020-02-19 lenny@lunarg.com loader: Remove queue info count check
Created with:
gclient setdep -r third_party/vulkan-loader/src@c357af84c7cb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I6c9c43a48864722c9d1a137eecbac38847c6d6d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066051
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2801bf43
|
2020-02-19T15:39:17
|
|
Add .vscode to .gitignore
Visual Studio Code project file.
Bug: None
Change-Id: I4dddee7c1e14a6bf601bd79ebca0e107829b0d65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062746
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
49010904
|
2020-02-15T12:21:17
|
|
Refactor test parameters to TracePerfTest.
Reduces much of the code duplication by adding some new helper methods.
The helpers allow combining test parameters similarly to how the
GoogleTest Combine() and Values() generators work. They are more
general and work by returning collections of test parameters instead
of combining generator functions.
Also updates the GLMark2 benchmark runner to use the new methods.
Bug: angleproject:3630
Change-Id: Ibc10f9afb401e119d67a7119974a1a8d9b5abb60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057353
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
25097b6c
|
2020-02-19T08:07:23
|
|
Vulkan: Lift failing test suppression.
EGLContextSharingTest.DeleteReaderOfSharedTexture/ES2_Vulkan
Passes with the new command graph linearization.
Bug: angleproject:4130
Change-Id: Ic7233696d2c06303ddf46947610b793a1a9e8a65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063041
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
113d0002
|
2020-02-19T12:09:39
|
|
Roll chromium_revision 8ffb18d0b9..a9ad696264 (736949:742676)
Change log: https://chromium.googlesource.com/chromium/src/+log/8ffb18d0b9..a9ad696264
Full diff: https://chromium.googlesource.com/chromium/src/+/8ffb18d0b9..a9ad696264
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e5293d8fa2..5499c7c1d6
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/cf6ed46cff..177ef69e99
* third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/c83f99e10c..703ca235f0
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/b9b9a5af7c..c2eb8a7f7a
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/953ea7aff8..eeaa53b76f
DEPS diff: https://chromium.googlesource.com/chromium/src/+/8ffb18d0b9..a9ad696264/DEPS
Clang version changed eaabaf7e04fe98990a8177a3e053346395efde1c:c29003813ab9bd6ea7b6de40ea8f1fe21979f13f
Details: https://chromium.googlesource.com/chromium/src/+/8ffb18d0b9..a9ad696264/tools/clang/scripts/update.py
TBR=ynovikov@chromium.org,
Bug: chromium:1050703
Change-Id: Ic3b5104698fe7c1a8d95b22fee164af1b8d3c02c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2064067
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
9a481b6e
|
2020-02-18T19:21:34
|
|
Add missing #include to fix build with GCC 10.
Bug: angleproject:4389
Change-Id: I4a2f04a12a059924871f5d54f137c67670747ebd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063042
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
ee0498b9
|
2020-02-15T09:24:03
|
|
GN: Update trace tests build.
Includes two small fixes:
- add .gitignore for trace tests.
- fix path for restricted traces, should fix bots.
Bug: angleproject:4386
Change-Id: I51c657c4f2e772411e95faa76188d43c8b6981f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057350
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
1f5f7ea3
|
2020-02-14T23:39:11
|
|
Vulkan: Fix SPIR-V transformation name-info association
Prior to this commit, when "OpName %id name" was encountered, the info
corresponding to "name" was immediately associated with %id. This is
not necessarily correct because there could be multiple ids with the
same name. For example a sampler declaration and an unrelated function
argument could have the same name. In this case, the sampler
declaration and function argument name don't even need to be in the same
shader stage.
This change modifies the SPIR-V transformation such that the name-id
mapping is tracked until the OpVariable instruction that actually
declares the variable is visited. The mapping to variable info is only
done if the storage class specified in this instruction corresponds to a
shader interface variable.
Bug: angleproject:3394
Change-Id: I35a1f6f8278e4b1ad81c9955a55e1b72d6f2e4ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057248
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
4b4ea4be
|
2020-02-03T09:48:09
|
|
Remove getIndexRange call from ValidateDrawRangeElementsBaseVertex
This is essentially the same commit as fed0dda, but with the BaseVertex variant.
Bug: angleproject:4373
Change-Id: I2d6fe46a0e8ce5faa8c92d4db6909f8cabd9692f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2032972
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c5b227ba
|
2020-02-19T07:01:02
|
|
Roll third_party/vulkan-loader/src 0bd30e43c007..39e685ccd37e (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0bd30e43c007..39e685ccd37e
git log 0bd30e43c007..39e685ccd37e --date=short --first-parent --format='%ad %ae %s'
2020-02-18 bas@basnieuwenhuizen.nl loader: Deal with failure loading implicit layer libraries.
2020-02-18 georg.m.lehmann@gmail.com loader: correct the name of vkNegotiateLayerInterfaceVersion
Created with:
gclient setdep -r third_party/vulkan-loader/src@39e685ccd37e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I6f92fecb5ea14e14fdabe7e73d7f4327c0dacb25
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2064049
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
9b731d47
|
2020-02-19T07:01:29
|
|
Roll third_party/vulkan-tools/src fb2272297f00..16cf5591e399 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/fb2272297f00..16cf5591e399
git log fb2272297f00..16cf5591e399 --date=short --first-parent --format='%ad %ae %s'
2020-02-18 shannon@lunarg.com build: Update known-good for 1.2.133 header
Created with:
gclient setdep -r third_party/vulkan-tools/src@16cf5591e399
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I92325cf3cf797b12eeafd8c1b52f38dfd6cc1736
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2064052
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
bbd00336
|
2020-02-19T07:01:07
|
|
Roll third_party/spirv-tools/src 77fefe765c06..79f8caf9154a (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/77fefe765c06..79f8caf9154a
Created with:
gclient setdep -r third_party/spirv-tools/src@79f8caf9154a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ia851eb56702cc4c02ccd238ad4c49ad9f31ca91f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063813
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
54d1b383
|
2020-02-19T07:01:08
|
|
Roll third_party/SwiftShader 0bbf7ba9f909..8def9063c4fd (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/0bbf7ba9f909..8def9063c4fd
git log 0bbf7ba9f909..8def9063c4fd --date=short --first-parent --format='%ad %ae %s'
2020-02-18 cwallez@chromium.org Only call updateBorders on ranges that can be cubemaps.
2020-02-18 capn@google.com Fix sRGB conversion precision issues
Created with:
gclient setdep -r third_party/SwiftShader@8def9063c4fd
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ib73fd3373ba4065034921e8bfed97cb4583a5388
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063814
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
0b41c4af
|
2020-02-17T17:28:58
|
|
Reland "Use newer OSX SDK for iOS"
This is a reland of 192da9d76fef6012245473c92b9dfcb607848e6a
Re-land after OS upgrade to 10.15.
Original change's description:
> Use newer OSX SDK for iOS
>
> Based on http://crrev.com/c/2056465
>
> Bug: chromium:1052887
> Change-Id: I2f76067883ff528ca45becd90dd3a6f71a507494
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059669
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Bug: chromium:1052887
Change-Id: If5d5c9e5b2dbb3b56eedfd9060015721817f47cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063040
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
d57bcfdb
|
2020-02-19T07:01:04
|
|
Roll third_party/vulkan-validation-layers/src 873e416c2d07..f155ccfd202d (13 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/873e416c2d07..f155ccfd202d
git log 873e416c2d07..f155ccfd202d --date=short --first-parent --format='%ad %ae %s'
2020-02-19 locke@lunarg.com layers: Clean up
2020-02-19 jzulauf@lunarg.com layers: Refactor global image layout map for perf
2020-02-19 locke@lunarg.com layers: Remove ImageSubresourcePair
2020-02-19 locke@lunarg.com layers: Add initial layout when creating
2020-02-19 locke@lunarg.com layers: New container
2020-02-19 locke@lunarg.com layers: format is not necessary
2020-02-19 locke@lunarg.com layers: Correct data type
2020-02-19 locke@lunarg.com layers: Remove binding.mem
2020-02-19 locke@lunarg.com layers: Remove MEMORY_UNBOUND
2020-02-19 locke@lunarg.com layers: shared_ptr memory
2020-02-18 baldurk@baldurk.org tests: Add positive and negative non-semantic info tests
2020-02-18 baldurk@baldurk.org layers: Validate non-semantic info extension
2020-02-17 shannon@lunarg.com build: Update known-good files for 1.2.133 header
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@f155ccfd202d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: If8d1b808c1e10d8be5161886035b2f063dda4280
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2064050
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
38bb9fdf
|
2020-02-19T13:02:00
|
|
Revert "Move sampleAlphaToCoverage out of blendState"
This reverts commit f6e73131c528b1317067624bc71c3ce41a48f9aa.
Reason for revert: Crashes on Win10 FYI x64 Debug (NVIDIA) and Win7 FYI Debug (AMD) in the webgl CTS
Original change's description:
> Move sampleAlphaToCoverage out of blendState
>
> This is the second step towards exposing OES_draw_buffers_indexed (that defines independent blend state for each draw buffer). This flag is global in all graphics APIs, however D3D11 technically puts it in the blend state.
>
> D3D11: BlendStateKey was extended to keep existing D3D11 state caching semantics.
>
> D3D9: a comment was added explaining why this feature was never implemented there.
>
> Bug: angleproject:4394
> Change-Id: Ie6a294eeb6fcf4c868a1f1001c4f7efd61692ccd
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057063
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
TBR=geofflang@chromium.org,jmadill@chromium.org,lexa.knyazev@gmail.com
Change-Id: I650624b5dfb7f2777c316906b9145a411243f42f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4394
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062605
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
|
|
|
90c9f66c
|
2020-02-19T12:51:01
|
|
Revert "Provide default implementation of rx::DisplayEGL"
This reverts commit 123fd97000bb9fd912159bb9ccc62308b763aead.
Reason for revert: Causes GL creation failure on Linux FYI Ozone (Intel)
Original change's description:
> Provide default implementation of rx::DisplayEGL
>
> Will allow to use EGL instead of GLX on X11.
>
> Meant to be used on modern EGL so it requires the extensions
> EGL_KHR_no_config_context and EGL_KHR_surfaceless_context.
> This keeps the default implementation simple (no pBuffer
> fallback)
>
> Also provide simple WorkerContextEGL.
>
> Bug: angleproject:4328
> Change-Id: I92a1ded9e09e65de8bb83710274e0a73ecdff0a4
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061168
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
TBR=geofflang@chromium.org,jmadill@chromium.org,julien.isorce@chromium.org
Change-Id: Ia55180ed83386fe1a158ccefda6155b33d779e98
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4328
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062604
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
|
|
fa9eff37
|
2020-02-17T23:49:36
|
|
Disable GL_EXT_semaphore_fd for Mesa version < 19.3.5 on AMD GPUs
Bug: chromium:1053516
Change-Id: Idfc271ac70c8ded7d05a258beb4a7578a5a652c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062162
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
123fd970
|
2020-02-04T23:08:55
|
|
Provide default implementation of rx::DisplayEGL
Will allow to use EGL instead of GLX on X11.
Meant to be used on modern EGL so it requires the extensions
EGL_KHR_no_config_context and EGL_KHR_surfaceless_context.
This keeps the default implementation simple (no pBuffer
fallback)
Also provide simple WorkerContextEGL.
Bug: angleproject:4328
Change-Id: I92a1ded9e09e65de8bb83710274e0a73ecdff0a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061168
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
4b7bac78
|
2020-02-15T12:17:12
|
|
Vulkan: Throttle when way ahead of device.
This CL adds a fence wait when we get more than 100 serials behind the
device. This fixes an ASSERT when unit tests or offscreen performance
tests get way ahead of the device.
Bug: angleproject:3630
Bug: angleproject:4281
Change-Id: I90f9af1b2ceb2b1cd9f2f638d6d84caaeeb83bb1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057351
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
efd2a669
|
2020-02-15T08:45:46
|
|
Vulkan: Command graph linearization for SemaphoreVk.
This doesn't seem to be tested in the default CQ configuration.
Bug: angleproject:4029
Change-Id: If0acd5c78602324433b63498e2de8c16881023de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057354
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
f6e73131
|
2020-02-14T14:23:08
|
|
Move sampleAlphaToCoverage out of blendState
This is the second step towards exposing OES_draw_buffers_indexed (that defines independent blend state for each draw buffer). This flag is global in all graphics APIs, however D3D11 technically puts it in the blend state.
D3D11: BlendStateKey was extended to keep existing D3D11 state caching semantics.
D3D9: a comment was added explaining why this feature was never implemented there.
Bug: angleproject:4394
Change-Id: Ie6a294eeb6fcf4c868a1f1001c4f7efd61692ccd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057063
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
f87fac56
|
2020-02-17T09:55:32
|
|
Use non-mutating getQuery in validation.
Previously the validation layer would create the query if not created.
This change should be a no-op that makes the validation layer work in
a more "const-friendly" way.
Bug: angleproject:1280
Change-Id: Ife0c216c8a0dcda2a33d1182821c51e4ed5f67e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2060688
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e96da533
|
2020-02-18T07:01:05
|
|
Roll third_party/vulkan-validation-layers/src 211ee9c4eec1..873e416c2d07 (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/211ee9c4eec1..873e416c2d07
git log 211ee9c4eec1..873e416c2d07 --date=short --first-parent --format='%ad %ae %s'
2020-02-17 mark@lunarg.com tests: Touch up some incorrect errorMonitor calls
2020-02-17 mark@lunarg.com tests: Added tests for CmdBlitImage planar VUIDs
2020-02-17 mark@lunarg.com corechecks: Add CmdBlitImage multiplanar format checks
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@873e416c2d07
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I589193d37add002f04f7426df0308cff0beb74bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061124
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
a33dc9ce
|
2020-02-18T07:01:03
|
|
Roll third_party/vulkan-loader/src c731adec183b..0bd30e43c007 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c731adec183b..0bd30e43c007
git log c731adec183b..0bd30e43c007 --date=short --first-parent --format='%ad %ae %s'
2020-02-17 shannon@lunarg.com build: Update known-good for 1.2.133 header
Created with:
gclient setdep -r third_party/vulkan-loader/src@0bd30e43c007
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I3ba81af4748d41f690b79b229245909e9b13add5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061123
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
7efa03ac
|
2020-02-18T07:01:08
|
|
Roll third_party/SwiftShader 481daed34f15..0bbf7ba9f909 (5 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/481daed34f15..0bbf7ba9f909
git log 481daed34f15..0bbf7ba9f909 --date=short --first-parent --format='%ad %ae %s'
2020-02-17 amaiorano@google.com Cache callstack results to avoid expensive lookup
2020-02-17 amaiorano@google.com Subzero: add REACTOR_EMIT_PRINT_LOCATION support
2020-02-17 bclayton@google.com third_party: Add shell script that updates marl.
2020-02-17 amaiorano@google.com Implement rr::Print support for Subzero
2020-02-17 amaiorano@google.com Subzero: fix another load from constant data
Created with:
gclient setdep -r third_party/SwiftShader@0bbf7ba9f909
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I52277a2305d73e84211ad9b48a12b8275aa221b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061126
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
9fcbd7e3
|
2020-02-18T07:01:08
|
|
Roll third_party/glslang/src ae59435606fc..113d07a6ebda (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ae59435606fc..113d07a6ebda
Created with:
gclient setdep -r third_party/glslang/src@113d07a6ebda
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I62752cf29e88146c2df52f371ba7bb2e109ff235
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061125
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2e0661d7
|
2020-02-17T20:19:13
|
|
Vulkan: Update ES 3.1 test expectations
Split off shader compilation failure to a new bug.
Bug: angleproject:3596
Bug: angleproject:4402
Change-Id: Iac054e469440cfa2b84289e08c5b21e3fbdf5410
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061448
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
c8676d4b
|
2019-11-25T11:38:19
|
|
Unlimit texture size on relatively new linux
If limit texture size to a small number, application may
need to reshape texture, lead to more discontinuous
memory access and performance loss.
Bug: angleproject:4086
Change-Id: I502a90535c2e3d13738e23827f4712a77987585e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934048
Reviewed-by: Xinghua Cao <xinghua.cao@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>
|
|
|
015cb808
|
2020-02-18T00:24:55
|
|
Revert "Use newer OSX SDK for iOS"
This reverts commit 192da9d76fef6012245473c92b9dfcb607848e6a.
Reason for revert: Causing failures on mac builders due to license.
Original change's description:
> Use newer OSX SDK for iOS
>
> Based on http://crrev.com/c/2056465
>
> Bug: chromium:1052887
> Change-Id: I2f76067883ff528ca45becd90dd3a6f71a507494
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059669
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
TBR=thakis@chromium.org,ynovikov@chromium.org,jmadill@chromium.org
Change-Id: I8698ed56fc81a76900da2aaf6cd19d08b57c5525
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1052887
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061228
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
192da9d7
|
2020-02-17T17:28:58
|
|
Use newer OSX SDK for iOS
Based on http://crrev.com/c/2056465
Bug: chromium:1052887
Change-Id: I2f76067883ff528ca45becd90dd3a6f71a507494
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059669
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
ee89849b
|
2020-02-17T22:47:57
|
|
Metal: Fixed memory leak due to the CAMetalLayer still attached to super layer
When destroying SurfaceMtl, the CAMetalLayer should detach from its
super layer, otherwise memory leak could happen.
This memory leak caused the end2end tests to ran out of memory.
Bug: angleproject:2634
Change-Id: I8ea91cccdb42cf0ae8ef807cf01f1e05043dc7c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2060250
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
5f5292c8
|
2020-02-14T13:08:47
|
|
Only enable robust client memory if the context supports validation.
Bug: chromium:1028418
Change-Id: Id47ac64a3d56b58455e1f36d8a17dbdc9db7e509
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2056506
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
|
|
|
59126651
|
2020-02-17T09:52:05
|
|
Revert "Provide default implementation of rx::DisplayEGL"
This reverts commit e82ab75a4ca8f4389a5f23b3a51d9388a92428e2.
Reason for revert: crbug.com/1052772
Original change's description:
> Provide default implementation of rx::DisplayEGL
>
> Will allow to use EGL instead of GLX on X11.
>
> Meant to be used on modern EGL so it requires the extensions
> EGL_KHR_no_config_context and EGL_KHR_surfaceless_context.
> This keeps the default implementation simple (no pBuffer
> fallback)
>
> Also provide simple WorkerContextEGL.
>
> Bug: angleproject:4328
> Change-Id: I825c6998e4a3727a13e533ede3d9fb1820edc804
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2031699
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
TBR=geofflang@chromium.org,syoussefi@chromium.org,jonahr@google.com,jmadill@chromium.org,julien.isorce@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: angleproject:4328
Change-Id: I62436cad1e6aae0c5e072acb1dab0bd10b2cf722
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2058952
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
|
|
|
6b43fba9
|
2020-02-17T07:01:07
|
|
Roll third_party/spirv-tools/src 6c218ec60b5f..77fefe765c06 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6c218ec60b5f..77fefe765c06
Created with:
gclient setdep -r third_party/spirv-tools/src@77fefe765c06
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ibf658094111733ca1a8fa50b865c30d903d51721
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059856
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
18bfdb7f
|
2020-02-17T07:01:05
|
|
Roll third_party/vulkan-validation-layers/src 73d377fae66e..211ee9c4eec1 (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/73d377fae66e..211ee9c4eec1
git log 73d377fae66e..211ee9c4eec1 --date=short --first-parent --format='%ad %ae %s'
2020-02-14 s.fricke@samsung.com tests: Add test for vkCmdCopyImage VUID
2020-02-14 s.fricke@samsung.com layers: Add support for vkCmdCopyImage VUID
2020-02-14 mark@lunarg.com corechecks: Correct conditions for triggering VUID 1564
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@211ee9c4eec1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I730510f9bf8891032075e9ec964d4e04b918e6fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059855
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
674d0ec2
|
2020-02-17T07:01:54
|
|
Roll third_party/vulkan-headers/src 726435870206..9bd3f561bcee (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/726435870206..9bd3f561bcee
git log 726435870206..9bd3f561bcee --date=short --first-parent --format='%ad %ae %s'
2020-02-16 oddhack@sonic.net Update for Vulkan-Docs 1.2.133
Created with:
gclient setdep -r third_party/vulkan-headers/src@9bd3f561bcee
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
TBR=courtneygo@google.com
Bug: None
Change-Id: I7676db5d51844e2633fa3aa6e660444edaca971a
Tbr: courtneygo@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2058775
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
c7df822f
|
2020-02-17T07:01:08
|
|
Roll third_party/SwiftShader f9f999f5a2eb..481daed34f15 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f9f999f5a2eb..481daed34f15
git log f9f999f5a2eb..481daed34f15 --date=short --first-parent --format='%ad %ae %s'
2020-02-15 swiftshader.regress@gmail.com Regres: Update test lists @ 348f07b4
2020-02-14 amaiorano@google.com Fix unit test when ENABLE_RR_EMIT_PRINT_LOCATION is defined
Created with:
gclient setdep -r third_party/SwiftShader@481daed34f15
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I7021723c43885bdfeccb96e63b8ad988a740407b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059857
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2dd40d7f
|
2020-02-15T07:32:26
|
|
Vulkan: Free pool allocation leak with graph disabled.
Our secondary command buffer pools were leaking memory every submit.
This change pops the secondary command buffer pool allocator scope
after commands are flushed during a submit.
Fixes the memory leak observable on any Vulkan application.
Bug: angleproject:4029
Bug: angleproject:4403
Change-Id: I3d0f8d53456336ef0b03c6d37425fb76c88d1551
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057349
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
798a8375
|
2020-02-14T12:48:21
|
|
Vulkan: Add more debug labels handling with graph off.
Bug: angleproject:4029
Change-Id: Ia3c88af5f9fa1a7940d7f809ded599c064126be7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055555
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
12a36dd9
|
2020-02-14T12:48:20
|
|
Vulkan: Add debug utils functions to wrapper.
Also adds a more consistent way of checking if the debug utils
extension is enabled.
Enables adding support for the debug utils markers with the command
graph disabled.
Bug: angleproject:4029
Change-Id: I5f8762921b06f54e400c25764012ab70e10bfb8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055554
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
bb7534ee
|
2020-02-14T16:23:28
|
|
Use ASSERT() instead of assert() when possible.
Since ASSERT() works in Release builds.
Left assert() in a few places where calling a function may not be safe.
Bug: angleproject:4396
Change-Id: Ic75a3d41d846e327097f8c37fe2336dcd3be6cb8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057745
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
9f4ab98d
|
2020-02-13T12:49:05
|
|
Return angle::Result from more label functions.
This is necessary for the new Vulkan implementation.
Bug: angleproject:4029
Change-Id: I07ef54145252ff102c74179361436587bb330fc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055553
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
3a3e7d4d
|
2020-02-14T14:08:07
|
|
Don't skip functional.layout_binding.ubo.vertex_binding_max on NV/D3D11
This test no longer fails with any recent drivers.
Bug: angleproject:4276
Change-Id: I7a20ee66f1da82d0f378848ccc9faa327a4ed63a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057065
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
eaff904e
|
2020-02-14T07:01:05
|
|
Roll third_party/vulkan-tools/src db0a1553991d..fb2272297f00 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/db0a1553991d..fb2272297f00
git log db0a1553991d..fb2272297f00 --date=short --first-parent --format='%ad %ae %s'
2020-02-13 charles@lunarg.com vulkaninfo: support ASTC HDR formats
2020-02-13 charles@lunarg.com vulkaninfo: Update VkFormat ranges
Created with:
gclient setdep -r third_party/vulkan-tools/src@fb2272297f00
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I01999deef8a186abbb83a717364235f766534568
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2056306
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2646163d
|
2020-02-14T07:01:08
|
|
Roll third_party/SwiftShader ac4e1d236088..f9f999f5a2eb (6 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/ac4e1d236088..f9f999f5a2eb
git log ac4e1d236088..f9f999f5a2eb --date=short --first-parent --format='%ad %ae %s'
2020-02-13 jonahr@google.com Implement HostMappedForeignMemory DeviceMemory
2020-02-13 bclayton@google.com Update Marl to a047dd0bb
2020-02-13 bclayton@google.com third_party/marl: Add mips64 support to BUILD.gn
2020-02-13 swiftshader.regress@gmail.com Regres: Update test lists @ ac4e1d23
2020-02-13 amaiorano@google.com Kokoro: build and run rr::Print unit tests
2020-02-13 amaiorano@google.com Fix rr::Print and add unit tests
Created with:
gclient setdep -r third_party/SwiftShader@f9f999f5a2eb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: Id1422ca8e34f6eaf013b47416a35bb7cefd67745
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2056308
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2e9b5376
|
2020-02-14T07:01:05
|
|
Roll third_party/vulkan-validation-layers/src 30794ac2f91b..73d377fae66e (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/30794ac2f91b..73d377fae66e
git log 30794ac2f91b..73d377fae66e --date=short --first-parent --format='%ad %ae %s'
2020-02-13 tony@lunarg.com layers: Fix false errors if query condition is unknown
2020-02-13 mark@lunarg.com layers: Fix string validation returned results
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@73d377fae66e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ic6f674dfe8c209ac38a69d76728741574d53de1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2056307
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d5861a68
|
2020-02-13T15:46:49
|
|
Fix ASAN errors in end2end tests.
2 minor issues of reading from uninitialized memory in tests.
Removes the suppressions from the fixed tests.
Bug: chromium:1029378
Change-Id: I466ce231cfed1ce53a60732706c05b778b096805
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055649
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
4f9608ca
|
2020-02-13T09:26:52
|
|
Vulkan: Update more bug numbers for ES 3.1
This reflects the most recent conformance run on Android with SwiftShader.
Bug: angleproject:4106
Bug: angleproject:4108
Bug: angleproject:4188
Bug: angleproject:4190
Bug: angleproject:4240
Bug: angleproject:4300
Bug: angleproject:4312
Change-Id: I0107262eecc963a8d5343a53806bb0483b5af3be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2054068
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
ef599fb0
|
2020-02-11T18:19:16
|
|
Vulkan: Fold glClear into draw call when command graph is disabled
This sets ContextVk::mRenderPassCommandBuffer properly when glClear get
called so that it wonr end up start anotyer render pass during setupDraw
call.
Bug: angleproject:4395
Change-Id: Id2110719ad4d70b4c410062466d32381fb5e1f88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050966
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
94c19142
|
2020-02-12T19:50:38
|
|
Capture/Replay: Track and restore mapped buffer data
When a buffer is mapped writable by the host, we need to
track its final contents, and then restore them during replay.
This implementation just blindly captures the whole mapped
range if writable, and can be optimized in the future.
This change renders the moving billboards in Manhattan correctly.
Test: First 500 frames of Manhattan and TRex
Bug: angleproject:4091
Change-Id: I5f7775235f569efb264bde679fd3045d7012c622
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053512
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
b79b57e0
|
2020-02-13T17:59:16
|
|
Vulkan: expose ANGLE_compressed_texture_etc
Bug: angleproject:4399
Change-Id: I51cd304c8726c985c5f70b78bd98c8af19d2a80d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053889
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|