kc3-lang/angle

Log

Author Commit Date CI Message
Antonio Caggiano 2a9c4b01 2022-02-10T11:33:32 dEQP: Enable CreateSurfacePlatformEXT tests Add the corresponding capability to NativeWindow and implement getPlatformExtension virtual method to return a native pointer that can be used with eglCreatePlatformWindowSurfaceEXT(). Bug: angleproject:6961 Change-Id: Ieb1a1fd8b3cae4e6f199c269f3922cbd0307aa35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452102 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano b92ebdb7 2022-02-24T12:23:09 EGL: Add code-gen for dmabuf extensions Add code-gen for EGL_EXT_image_dma_buf_import and EGL_EXT_image_dma_buf_import_modifiers. Bug: angleproject:7065 Change-Id: Ib1bd2a881f11e96b1e7e5128975bdba3bdc41e0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495122 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop ef6688c9 2022-03-01T09:21:20 Tests: Add Five Nights at Freddy's trace Test: angle_perftests --gtest_filter="*five_nights_at_freddys*" Bug: angleproject:7066 Change-Id: Iad911da90eea7e798fabeaf697afea29fb53ce93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495880 Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Antonio Caggiano bf619311 2022-03-01T17:23:38 EGL: Implement isX11 for DisplayGLX This fixes CreatePlatformWindowSurfaceEXT for the GL renderer. Bug: angleproject:6961 Change-Id: Iaec90f5fe81ee605f43d62e6e63a3fbedd314cb4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3497684 Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki 309e6dad 2022-02-18T12:31:31 Tests: Add Final Fantasy Brave Exvius trace. Test: angle_perftests --gtest_filter="*final_fantasy_brave_exvius*" Bug: angleproject:7041 Change-Id: I3a30a317b1c10b016652dbdaadcd577bf167c5f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3475352 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 697a942b 2022-03-01T10:01:12 Roll SwiftShader from 949ffcf55151 to 6e9eafd34639 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/949ffcf55151..6e9eafd34639 2022-02-28 capn@google.com Support implicit conversion of Int4 component to Int 2022-02-28 capn@google.com Move Swizzle type definitions into a separate header 2022-02-28 swiftshader.regress@gmail.com Regres: Update test lists @ 949ffcf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ib61b6842f5b4f7b49eb4b176eccff888e3ffd6a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3496981 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 1bfdc981 2022-01-21T14:21:45 TorusBufferStorage: Regenerate buffer storage every second. To test regeneration in FrameCapture, the torus buffer storage example now reinitializes its coherent buffer storage every second. Define attrib pointers every draw. Bug: angleproject:4599 Bug: angleproject:5857 Bug: angleproject:6774 Change-Id: I32984535d9810478b6906217102ac9c3e83464b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406756 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 3e00c7d5 2022-03-01T10:01:56 Roll vulkan-deps from 4d9fe6bf1f0c to 6f0521f42451 (35 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4d9fe6bf1f0c..6f0521f42451 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/d15deba1d8..43d585d863 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/188dc8b13c..d16183d1d2 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/6a55fade62..f75fc98bad * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/b32da5329b..aa18f182eb * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a32af9ca72..a4fb0b36cf * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/5f9e5f14e5..078d44e466 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/efcb50f63a..8726d47ca7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I24401d520b1b61cf0777f08723a48dcd77d1be9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3496645 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 5118002e 2021-11-29T21:01:03 Capture/Replay: test and handle texture gen-on-bind Bug: angleproject:6425 Change-Id: Ieb4c0a7a6ffdbf0690c07c10e001835a0dcbb6e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295620 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny bc20e55b 2021-11-29T21:00:45 Capture/Replay: test and handle renderbuffer gen-on-bind Bug: angleproject:6425 Change-Id: I591bf0fdfe2e7f83d7e02f63c8265234f7b85df6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295618 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny efb951e8 2021-11-29T21:00:02 Capture/Replay: test and handle buffer gen-on-bind Bug: angleproject:6425 Change-Id: If8b573d0d77192befe6db82498158c535bd3b104 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295619 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 5236a767 2022-02-23T12:15:26 Capture/Replay: enable running GLES 3.2 tests with script In addition add annotations for the tests that fail (crash) Bug: angleproject:5366 Change-Id: I92747e70b4c0a494fb7f67ed0c282bd76788f505 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484057 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll 820a47be 2022-03-01T07:00:18 Roll Chromium from 5feb16fcf80f to 4f52dd6c4de1 (446 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5feb16fcf80f..4f52dd6c4de1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3651f40a5d..54a203edb9 * buildtools/linux64: git_revision:0725d7827575b239594fbc8fd5192873a1d62f44..git_revision:e3f114f46537152cfbdb553015518d1db1b812fd * buildtools/mac: git_revision:0725d7827575b239594fbc8fd5192873a1d62f44..git_revision:e3f114f46537152cfbdb553015518d1db1b812fd * buildtools/win: git_revision:0725d7827575b239594fbc8fd5192873a1d62f44..git_revision:e3f114f46537152cfbdb553015518d1db1b812fd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8bf5b5b5e9..f1eeca027d * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/da9e4a3759..d936596e3c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2cfdaa8ce0 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6b28c1ddef..ca9706d139 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/5de432790d..aa5ea608a4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/55aa202015..3a67a5003b * tools/luci-go: git_revision:582e828c5a8aaf5cdd0ad1d5465fb9092b71eab8..git_revision:a1616e207f0d9c24beefe848ee899b7a73efcb70 * tools/luci-go: git_revision:582e828c5a8aaf5cdd0ad1d5465fb9092b71eab8..git_revision:a1616e207f0d9c24beefe848ee899b7a73efcb70 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4b6550b5a7..8faffb3a7d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/19bce3c47a..1f34318e3e No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I8eb5c883dcc67a4e5782e223be30fdc71045bc21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3496680 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 32881018 2022-01-14T16:03:22 Capture/Replay: atomic counter buffer limits are shader specific Therefore, the override must also be applied to the per shader values. Bug: angleproject:6895 Change-Id: Iecd790afaca9358ee767d41b4c806bb8257b5fa6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3386948 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Tim Van Patten 5749ec7d 2022-03-01T02:14:42 Revert "Vulkan: Move mid-RP color clear to loadOp if content undefined" This reverts commit cfe5a1735a934cc83133bb6c69d19aa27278a270. Reason for revert: https://bugs.chromium.org/p/angleproject/issues/detail?id=5048#c7 @timvp That change just caused a regression in my project. I clear the color + depth buffer before drawing, but initially draw only to the depth buffer. It seems that it decided to ignore the color buffer clear as a result of that. Original change's description: > Vulkan: Move mid-RP color clear to loadOp if content undefined > > Instead of using vkCmdClearAttachments, if the color attachment has not > been written to, modify the loadOp of the currently open renderpass to > CLEAR. > > Bug: angleproject:5048 > Test: VulkanPerformanceCounterTest.MidRenderpassClear > Change-Id: Ida47e6ac7d0f29e2c49bdf2e74c1d876a5d7c223 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3381912 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Tim Van Patten <timvp@google.com> Bug: angleproject:5048 Change-Id: Iec5c73632429a80f955f7d659cf670f9cbb6c9b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3496662 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Cody Northrop c80c7ae3 2022-02-24T10:43:15 Capture/Replay: Merge Deletes in Reset Before this CL, when regenning resources, we would iterate through each resource ID and issue a delete followed by a gen. The delete is required to get resources back to their original state, often caused by applications recreating them during the run. This ran into problems when our resource maps had stale data in them, i.e. a texture that had been deleted by the app but remained in our gTextureMap. We could inadvertently delete a resource we had just genned. For example, in ResetReplay(), say we have two textures to delete: // gTextureMap[1] start with 5 const GLuint glDeleteTextures_texturesPacked_1[] = { gTextureMap[1] }; glDeleteTextures(1, glDeleteTextures_texturesPacked_1); // We just deleted texture 5, now create a new one glGenTextures(1, reinterpret_cast<GLuint *>(gReadBuffer)); // The driver returned 15, which was unused at this time UpdateTextureID(1, 0); // gTextureMap[1] now contains 15 ... // gTextureMap[2] happens to start with 15, which was in use in // the trace, but was deleted and is no longer in use. The // deleted value is not cleared from gTextureMap (which is // another possible way to solve this). const GLuint glDeleteTextures_texturesPacked_2[] = { gTextureMap[2] }; glDeleteTextures(1, glDeleteTextures_texturesPacked_2); // Whoops! We just deleted our brand new texture 15, even though // it no longer maps to the original texture. glGenTextures(1, reinterpret_cast<GLuint *>(gReadBuffer)); UpdateTextureID(2, 0); // Now gTextureMap[2] contains whatever came back from the driver ... // The first use of gTextureMap[1] will fail on loop because // texture 15 no longer exists! To avoid this problem we delete all resources up front before genning any new ones. const GLuint deleteTextures[] = {gTextureMap[1], gTextureMap[2]}; glDeleteTextures(2, deleteTextures); // Now we no longer have any deletes in the create sequence glGenTextures(1, reinterpret_cast<GLuint *>(gReadBuffer)); UpdateTextureID(1, 0); glGenTextures(1, reinterpret_cast<GLuint *>(gReadBuffer)); UpdateTextureID(2, 0); This is applied to all the resources we regen right now. This CL: * Merges the deletion of new resources (that didn't exist when the trace starts) with resources that are being regenned. That means there is just one big delete. * Removes Delete from the call sequences we track for each resource since we no longer need to keep them around. * Adds a formatting helper to avoid code duplication. Test: Blade&Soul Revolution MEC (UE4) Bug: angleproject:4599 Bug: angleproject:7053 Change-Id: Ida3b7e1ad5d94c5e9860447d5cf959278f37ad47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3492849 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tim Van Patten cfe5a173 2022-01-11T19:26:42 Vulkan: Move mid-RP color clear to loadOp if content undefined Instead of using vkCmdClearAttachments, if the color attachment has not been written to, modify the loadOp of the currently open renderpass to CLEAR. Bug: angleproject:5048 Test: VulkanPerformanceCounterTest.MidRenderpassClear Change-Id: Ida47e6ac7d0f29e2c49bdf2e74c1d876a5d7c223 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3381912 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Cody Northrop 802e0d4d 2022-02-15T16:40:07 Document perf test metrics Bug: angleproject:1944 Change-Id: I7f0d5c73c943ba28b3e0270e17681d7e69a7ee4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3466757 Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov 977945fa 2022-02-28T15:57:03 Fix self link broken by https://crrev.com/c/3124341 Bug: angleproject:6323 Change-Id: I9408aa3746770e112ed7301689f842598ffeb484 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3495023 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 045e25de 2022-02-28T10:01:11 Roll SwiftShader from f423bda7e8e3 to 949ffcf55151 (9 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f423bda7e8e3..949ffcf55151 2022-02-26 capn@google.com Refactor image offset methods 2022-02-26 swiftshader.regress@gmail.com Regres: Update test lists @ 310874c9 2022-02-25 sugoi@google.com Fix dynamic rendering implicit clears with multiview 2022-02-25 capn@google.com Set the stack limit through a function attribute 2022-02-25 capn@google.com Regres: remove OpenGL ES testlists 2022-02-25 capn@google.com Assert llvm::Expected<> don't contain an error 2022-02-25 sugoi@google.com VK_KHR_maintenance4 support 2022-02-25 sugoi@google.com LocalSizeId for VK_KHR_maintenance4 2022-02-25 martin.troiber@gmail.com Add LLVM-Submodule backend option If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I018a35625bb57bb983aa808dbeaebcc78996af10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3493140 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 56378606 2022-02-28T07:01:38 Roll Chromium from 903941d19666 to 5feb16fcf80f (645 revisions) https://chromium.googlesource.com/chromium/src.git/+log/903941d19666..5feb16fcf80f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9e7c4ed752..3651f40a5d * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/8cd7191937..2ea265b95a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e867c867ab..8bf5b5b5e9 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/6f9d0386be..e6c2b86f92 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0f23dc5218..da9e4a3759 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..666eff907b * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c23f5e8299..5de432790d * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3730026620..55aa202015 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bf2c351791..4b6550b5a7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/18673704e4..19bce3c47a No update to Clang. Bug: angleproject:6430,angleproject:6489 Tbr: abdolrashidi@google.com Change-Id: Ia0d1afd345f94e3a77e743b3117a31e866cd1d10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3494136 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 8390196a 2022-02-26T02:36:22 Revert "Remove ImageViewHelper from ResourceUseList" This reverts commit 126e967de3978f0dc4f6cf0fa3f9749366ea39ba. Reason for revert: Hits an ASSERT about too much garbage being accumulated. anglebug.com/7063 Original change's description: > Remove ImageViewHelper from ResourceUseList > > Instead of keeping a dedicated SharedResourceUse mUse for > ImageViewHelper, let ImageViewHelper take ImageHelper.mUse > for lifetime tracking. ImageViewHelper no longer needs to > add its' own mUse in the ResourceUseList through retain() > calls, and this should cut the ResourceUseList size by > almost half. For instance, in the trace aztec_ruins, > the maximum ResourceUseList size before the change is 3643, > and the maximum ResourceUseList size after the change is 1694. > Since ImageViewHelper no longer needs to keep SharedResourceUse > mUse as a class memberWe can remove the inheritance from > Resource class, and make ImageViewHelper simply a NonCopyable class. > > Bug: angleproject:6717 > Change-Id: I460e83f5f3c1d6ef9722b9f3c9a5ba9552563cb9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3449450 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:6717 Change-Id: Iea3d40458e2cc5be6ab0257ba6df8b82a4eeecda No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3491345 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gregg Tavares c11cef2f 2022-02-16T10:42:41 Add Clearifying comment about Occlusion Query Test Bug: angleproject:6752 Change-Id: I710273c43694b50ab4fb59a840ae15d6cb14391d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469718 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Amirali Abdolrashidi fd44f1a0 2022-02-25T13:34:01 Update API version in VulkanHelper to 1.1 * Updated the API version in VulkanHelper to avoid the validation error regarding UNASSIGNED-API-Version-Violation on Android devices. Bug: angleproject:7062 Change-Id: Iacb12cd5c79ecc803cdb5fe5c8738d1ac352eec0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3491502 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Tim Van Patten 6db60483 2022-02-25T11:13:40 Android: Skip flaky EGL end2end tests Skip flaky EGL end2end tests on Android. Bug: angleproject:7059 Test: EGLSurfaceTest.ResizeWindowWithDraw Test: EGLReadinessCheckTest.IsRunningOnANGLE Test: EGLReadinessCheckTest.GetProcAddressNegativeTest Test: EGLReadinessCheckTest.HasGetPlatformDisplayEXT Test: EGLContextSharingTestNoSyncTextureUploads.NoSync Change-Id: Ib6637625fa3bead4860268fcacd108da2183ce86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3491501 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi ce243358 2022-02-25T14:07:17 Vulkan: Add precision fix to SPIR-V transformation validation The SPIR-V transformation validation ASSERT was done before varying precision fixes were determined. This change reorders the operations such that the ASSERT also includes varying precision fix information. Bug: angleproject:7046 Change-Id: I1685a41cda080ac128025aa84a783984042e7c4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3488559 Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Caggiano f762cb1b 2022-01-05T20:33:06 EGL: CreatePlatformWindowSurfaceEXT Implement CreatePlatformWindowSurfaceEXT just like CreatePlatformWindowSurface in egl_stubs.cpp taking into account that native window for X11 should be Window* instead of Window. Bug: angleproject:6961 Change-Id: Ic129bd3e9dd264fdee12b062b5b422a9a6012dd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3427425 Reviewed-by: Jeff Vigil <jvigilsamsung@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Erik Rose a70d728c 2022-02-25T13:50:54 Correct a typo that was keeping Skia from compiling. For example: https://logs.chromium.org/logs/skia/5948b4721f002c11/+/steps/gn_gen/0/stdout. More specifically: https://logs.chromium.org/logs/skia/5948b4721f002c11/+/steps/gn_gen/0/stdout. Bug crept in on https://chromium-review.googlesource.com/c/angle/angle/+/3487449. Bug: angleproject:7061 Change-Id: I6bae23375505aa714733033f5b84c1b3c8c421f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3488558 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Brandon Schade ded25241 2021-08-11T18:38:15 Vulkan: Clear Recycler's mObjectFreeList on destroy Previously the Recycler class never freed it's mObjectFreeList. Free it on destroy(). Bug: angleproject:6278 Change-Id: I3d207aaf67db92350886528c2fb1ce57c3441136 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3089659 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Kyle Piddington af45d166 2022-02-23T14:05:47 Metal: PVRTC formats fail conformance tests on simulator Remove support for PVRTC in simulator, as conformance tests fail Bug: angleproject:6874 Change-Id: I2c3f9e26523098aaa6a988db5cb3f4bf748a0cdc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3485640 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Ian Elliott 1d137a48 2022-02-25T12:47:53 Add to ANGLE's OWNERS Add Frank and his new team members to OWNERS. Will also add to OWNERS.android so that they can land ANGLE->AOSP autorolls. Bug: b/221459804 Change-Id: I64ee42318fa5631dc3fc40948e3f137fe2b18955 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3488560 Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Yuxin Hu 126e967d 2022-02-09T01:46:25 Remove ImageViewHelper from ResourceUseList Instead of keeping a dedicated SharedResourceUse mUse for ImageViewHelper, let ImageViewHelper take ImageHelper.mUse for lifetime tracking. ImageViewHelper no longer needs to add its' own mUse in the ResourceUseList through retain() calls, and this should cut the ResourceUseList size by almost half. For instance, in the trace aztec_ruins, the maximum ResourceUseList size before the change is 3643, and the maximum ResourceUseList size after the change is 1694. Since ImageViewHelper no longer needs to keep SharedResourceUse mUse as a class memberWe can remove the inheritance from Resource class, and make ImageViewHelper simply a NonCopyable class. Bug: angleproject:6717 Change-Id: I460e83f5f3c1d6ef9722b9f3c9a5ba9552563cb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3449450 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Mohan Maiya 5094968f 2022-02-24T16:28:00 Vulkan: Account for Invariant in transformDecorate When replacing a varying with a temp variable make sure to propagate the Invariant decorator to the replacement variable. Bug: angleproject:7046 Change-Id: I6e1f9ae5a6045ca963738cfdee5788f04ae620e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3489812 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 06fead6d 2022-02-25T16:06:30 Roll VK-GL-CTS from d321c7ec84de to 2328c3fcf88d (4 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/d321c7ec84de..2328c3fcf88d 2022-02-24 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main 2022-02-24 ari.suonpaa@siru.fi Test message passing using permuted indices 2022-02-24 michal.jakubek@mobica.com Reduce and amortize memory allocations in RT utilities 2022-02-21 gleese@broadcom.com Fix arguments for image test reference generation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com,angle-bots+autoroll-info@google.com Change-Id: I1c6fb7b4e7299ad1c5b418be93f0a791c374a2a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3489821 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten e2f8c5c6 2022-02-22T19:15:11 Vulkan: Add ClearBenchmark.Run/vulkan_scissoredClear Add the test ClearBenchmark.Run/vulkan_scissoredClear to benchmark scissored clears with the Vulkan backend. Bug: angleproject:5194 Test: ClearBenchmark.Run/vulkan_scissoredClear Change-Id: I7d6aeb8683b2ac2488e1c961d0cc194e6107b7f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3408457 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll 7f03fb5d 2022-02-25T10:01:11 Roll SwiftShader from cd8e0282137f to f423bda7e8e3 (12 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/cd8e0282137f..f423bda7e8e3 2022-02-25 swiftshader.regress@gmail.com Regres: Update test lists @ 9f170f07 2022-02-25 sugoi@google.com Image memory requirements for VK_KHR_maintenance4 2022-02-25 sugoi@google.com vkGetImageMemoryRequirements2 refactor 2022-02-24 sugoi@google.com Buffer memory requirements for VK_KHR_maintenance4 2022-02-24 sugoi@google.com VK_KHR_zero_initialize_workgroup_memory support 2022-02-24 swiftshader.regress@gmail.com Regres: Update test lists @ cd8e0282 2022-02-24 capn@google.com Implement DAZ/FTZ control for non-Windows x86 2022-02-24 capn@google.com Implement separate DAZ/FTZ control for Windows 2022-02-24 capn@google.com Fix comparing lodOrBias as integer values 2022-02-24 capn@google.com Add utility functions for detecting divergent/uniform values 2022-02-24 syoussefi@google.com Set advancedBlendMaxColorAttachments to max 2022-02-24 sugoi@google.com Remove unicode characters from comments If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:3586 Tbr: abdolrashidi@google.com Change-Id: I7e144b73af798b3e74c77dcaa47f65d7d1ba6b82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3490201 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 240dcdff 2022-02-25T07:01:40 Roll Chromium from effb00c1eb6d to 903941d19666 (506 revisions) https://chromium.googlesource.com/chromium/src.git/+log/effb00c1eb6d..903941d19666 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9a383acb5c..9e7c4ed752 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/82b83d357f..e867c867ab * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/10baf29753..0f23dc5218 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8d2395bd1b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c668c866d..6b28c1ddef * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/27dbe48bd5..c23f5e8299 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0c2c9b023a..bf2c351791 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9d72bfaa27..18673704e4 No update to Clang. Bug: angleproject:6430,angleproject:6489 Tbr: abdolrashidi@google.com Change-Id: Ia5703d94bd15524f9a304de9f44bbc6c9d0156e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3489814 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 1e1505b5 2022-02-24T20:59:57 Upgrade Python scripts from Python2 to Python3 Bug: angleproject:5707 Change-Id: I2c00ef7e7cb529eab2be61378c9a5511a69acd1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3486298 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Antonio Caggiano 613ec1c8 2022-02-15T17:01:01 Vulkan: Duplicate dmabuf FD on import When importing a dmabuf FD, Vulkan takes the ownership and attempts to close on vkFreeMemory. This means we need to duplicate it. Bug: angleproject:7027 Change-Id: Ife3dce30bd0c88c6b6fd622b93a44528b6a9ea68 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3464855 Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill c874943b 2022-02-18T15:29:14 Rename FastUnordered types to FlatUnordered. These names are consistent with the common parlance. Flat indicates the values are packed in memory, while fast indicates that lookup is as fast as possible. Bug: angleproject:6776 Change-Id: I7b56af26d7fdbf5956872be5033c3aa3f6b1b8c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484978 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano e2d5eb72 2022-02-24T10:21:06 Vulkan: Wayland dependency Add wayland as a third-party dependency and add it to the include directories of vulkan-dependent targets. Bug: angleproject:6902 Change-Id: I1c6305ac3e214ecda532988e28acaa6b8e997fd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3487449 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 43273273 2022-02-24T10:01:12 Roll SwiftShader from 7529468c7902 to cd8e0282137f (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/7529468c7902..cd8e0282137f 2022-02-23 sugoi@google.com VK_KHR_shader_non_semantic_info support 2022-02-23 swiftshader.regress@gmail.com Regres: Update test lists @ 7529468c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2ee24d35fd5ce7bde35920f0027a652d322e45c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3486409 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5ceded43 2022-02-24T07:00:09 Roll Chromium from e092c426ee21 to effb00c1eb6d (431 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e092c426ee21..effb00c1eb6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/208912d7cb..9a383acb5c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/93c15529c3..893aa038dd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f6ece9fd76..82b83d357f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/4f4f006a04..a13888fac0 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/fdc771ba71..10baf29753 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..08a8050c47 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/306b03b191..2c668c866d * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4823a8571d..27dbe48bd5 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f932f4f5e7..0c2c9b023a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bf4b3f4070..9d72bfaa27 * tools/skia_goldctl/linux: td7IhN6Q3eTDLXn6p5jlbeSIDYl7rI75dlX0qj8fEEsC..eZ3k373CYgRxlu4JKph6e-_7xkP02swy_jePFFMiyIQC * tools/skia_goldctl/mac_amd64: im5u9GiTMHxNcLH_Nc2X3RqzjfDs2oDmC0VhkLgUCeYC..nHUjLIViYsLxRjv-zDdmzqT8p1R3VoyHq5gdGkKeMYwC * tools/skia_goldctl/mac_arm64: edDMT5wDXf_HjD5qeNPgIEmYXDGUB1BswQ0G84CQBdUC..-mc865SGfJAqreLZM6fkn8tgCJ7u5QLk5zm7r-ZRJ9gC * tools/skia_goldctl/win: 5k9ZnDE42Xoqs07enkcOdWOf9jT-bhW-OXOp2fY-IR4C..iEqqRADI7znrc6pG-MVnc5pBZwD25koILREPC6x2AFAC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I3cfa6349d8f2d19f04adfb169b610d46be5ccffe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3486297 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi d3ded9aa 2022-02-22T23:02:59 Vulkan: Make Overlay init lazy So it's not done when overlay is not in use. Bug: angleproject:7051 Change-Id: Iae2ba20cf8c0825dc5f321e5b31dd278cd892066 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3481310 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 1e773db9 2022-02-22T10:51:15 Vulkan: Shader support for KHR_blend_equation_advanced Translator can accept the layout qualifiers for the advanced blend equation. No emulation code is currently generated, and ANGLE will initially rely on the corresponding Vulkan extension. Based on change by Brandon Schade <b.schade@samsung.com> Bug: angleproject:3586 Test: angle_unittests --gtest_filter=*KHRBlendEquationAdvanced* Change-Id: I3b728c5f144386d7030bbbb301ddb07daa1492b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3481309 Reviewed-by: Brandon Schade <b.schade@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki b69349bc 2022-02-15T14:59:03 Tests: Add Real Racing 3 trace. Add GL_EXT_shader_framebuffer_fetch prerequisite. Test: angle_perftests --gtest_filter="*real_racing3*" Bug: angleproject:7026 Change-Id: Ie76e7ca43bb3a95c343e56d3b830f1f6d6e733c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3475351 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Gert Wollny 19704a89 2022-02-15T13:21:12 Capture/Replay: Capture GetTexLevelParameterfvANGLE params Bug: angleproject:3565 Change-Id: I940154a4e3ace9a3b8683eebdcd7bbb14402a641 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3461564 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll cbc1c9c8 2022-02-23T10:01:11 Roll SwiftShader from b8d7deae87a7 to 7529468c7902 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/b8d7deae87a7..7529468c7902 2022-02-22 capn@google.com Exhaustively test the log2 implementation's conformance 2022-02-22 capn@google.com Assert exp2 is exact at integer values 2022-02-22 capn@google.com Make inc() flush subnormals to zero when DAZ is enabled 2022-02-22 sugoi@google.com Fix dynamic rendering with multiview 2022-02-22 swiftshader.regress@gmail.com Regres: Update test lists @ b8d7deae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I51658eb7ef4b50aff2d9648f19d9e18b52221f35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3484098 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 913d8add 2022-01-25T11:43:40 Capture/Replay: Mark another test as Windows-only crash Bug: angleproject:6631 Change-Id: I30395b2cc9358963d73f0748c179300c5bfbe72b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3413158 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 223a25f0 2022-01-25T11:15:16 Capture/Replay: Allow capturing of multisample texture content It just works. Bug: angleproject:6611 Change-Id: Ia3da2ee0ea3e09889a65910fd101a7daaa99ea56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3413157 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll 0d1f67d1 2022-02-23T08:38:37 Roll Chromium from 76e3790bfd26 to e092c426ee21 (458 revisions) https://chromium.googlesource.com/chromium/src.git/+log/76e3790bfd26..e092c426ee21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/eaff71261c..208912d7cb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d612e87084..f6ece9fd76 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/4c73a7ae74..fdc771ba71 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..58ce6f9e68 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42cf2acbae..306b03b191 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d29d689c1d..71d78db8de * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f8d70d1346..4823a8571d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0a3dc05ff3..f932f4f5e7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/16a46ce6d2..bf4b3f4070 * tools/skia_goldctl/linux: t-kuo00LREzFSvvcKqhCDfF9a3vrU6x8bvpcqoOolxQC..td7IhN6Q3eTDLXn6p5jlbeSIDYl7rI75dlX0qj8fEEsC * tools/skia_goldctl/mac_amd64: q0e0eoFci9WHabP-U6xwl2vazg4Fh0iDyXPwa7GGoQMC..im5u9GiTMHxNcLH_Nc2X3RqzjfDs2oDmC0VhkLgUCeYC * tools/skia_goldctl/mac_arm64: qRTt0rC2ItXtcqu1dxTrhYh8FVz21OFuYU2YzKfboRMC..edDMT5wDXf_HjD5qeNPgIEmYXDGUB1BswQ0G84CQBdUC * tools/skia_goldctl/win: 7MVl6nWD2T_LTrD1aXv5dLQaPIBY04wfSmCsu5NdVdwC..5k9ZnDE42Xoqs07enkcOdWOf9jT-bhW-OXOp2fY-IR4C No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ife71008329e87f07d099f09e7c440f1c6065eaf1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3483975 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi e47a67e4 2022-02-22T11:40:23 Update Python scripts to run with Python 3 * Updated the scripts used in run_code_generation.py so they could be run with Python 3 with no errors. Bug: angleproject:5707 Change-Id: Iad7ff61a34ce53b6d54821cdd53ee846dc4afc3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3482156 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 3154b00b 2022-02-22T16:34:29 Increase end2end timeout and sharding on Pixel 6 Bug: angleproject:7050 Change-Id: I3402a9f930f47a32537afd13674a3d6bc514f606 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3481302 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi b80635ca 2022-02-22T15:50:58 Revert "Vulkan: Suppress VVL message about allocation exceeding heap size" This reverts commit 158d47831e77edf16721f631c1c4b45149182f4d. Reason for revert: No longer necessary anglebug.com/6444#c20 Original change's description: > Vulkan: Suppress VVL message about allocation exceeding heap size > > VMA does not check the result of vkGetBufferMemoryRequirements against > the heap size before attempting to make an allocation, which leads to a > validation error. > > The error is benign for ANGLE as the subsequent Vulkan allocation will > fail, leading to an OOM generated by Vulkan isntead of ANGLE to the same > effect as far as the application is concerned. > > Bug: angleproject:6444 > Change-Id: Ia474629971d6835f727b3fb43313a6003e3c939a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3387088 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Nicolas Capens <nicolascapens@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:6444 Change-Id: I6b153f6002b35c057fed11d287e0c8211f4ada66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3480738 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Antonio Caggiano 2944e265 2022-02-15T16:57:53 Vulkan: Fix dmabuf memory importable check Bug: angleproject:7027 Change-Id: I64522d2629c153b8456c975a06fd4293f89aa19a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3464854 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a8ec86a5 2022-02-22T10:01:11 Roll SwiftShader from d25df2a67cd2 to b8d7deae87a7 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/d25df2a67cd2..b8d7deae87a7 2022-02-21 capn@google.com Eliminate initialization of fragment shader inputs 2022-02-21 capn@google.com Use legacy math precision for the Pipeline source set as well If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I93b2acef9130aeacba167432cb9cc34f468e9046 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3479410 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 937d5a5d 2022-02-22T07:00:37 Roll Chromium from 2b8afbc70460 to 76e3790bfd26 (193 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2b8afbc70460..76e3790bfd26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/82354b2402..eaff71261c * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/7539622043..8cd7191937 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3779e1fb3e..d612e87084 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ad002f6051..4f4f006a04 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b718bf93ff * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0cfa90e203..42cf2acbae * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4aca88e355..f8d70d1346 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9e0a2ac8d2..0a3dc05ff3 * tools/skia_goldctl/linux: njGzzVyYPSA__3tShsGxsvh8k5kJfL9V0wvLthXSUV4C..t-kuo00LREzFSvvcKqhCDfF9a3vrU6x8bvpcqoOolxQC * tools/skia_goldctl/mac_amd64: hO0OT7GrBan0deDL_pb0LFML9ueWrbdDtzCU-awv-8IC..q0e0eoFci9WHabP-U6xwl2vazg4Fh0iDyXPwa7GGoQMC * tools/skia_goldctl/mac_arm64: iG5_8Fr1Z6-7hWUIaiAy_BdqEqZztiO1hsUkG8KD_csC..qRTt0rC2ItXtcqu1dxTrhYh8FVz21OFuYU2YzKfboRMC * tools/skia_goldctl/win: k8tTHDT2HQHQFD7TPjRrdMHGABN8YbxP1GXsJnmS9JIC..7MVl6nWD2T_LTrD1aXv5dLQaPIBY04wfSmCsu5NdVdwC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I885224e7817c7168e8a4e3b50b3d39e74ac68ea0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3478456 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3a4f862f 2022-02-21T10:01:11 Roll SwiftShader from b4a56a893496 to d25df2a67cd2 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/b4a56a893496..d25df2a67cd2 2022-02-18 sugoi@google.com Implement buffer memory requirement for VK_KHR_maintenance4 2022-02-18 sugoi@google.com VK_KHR_dynamic_rendering support 2022-02-18 capn@google.com Use non-conformant transcendentals for Chromium 2022-02-18 sugoi@google.com Merge changes I3c7eb72e,Ib40d778f,I9d83501b,Idbe4c715 2022-02-18 swiftshader.regress@gmail.com Regres: Update test lists @ b4a56a89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I5416d724e7972b75790ae3172eea847259f26a1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3477117 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c4494a52 2022-02-21T07:01:42 Roll Chromium from 6594a8d1e6cf to 2b8afbc70460 (606 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6594a8d1e6cf..2b8afbc70460 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2fb44025ab..82354b2402 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/aa5552f516..3779e1fb3e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b718bf93ff * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/988c0af5be..0cfa90e203 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/31e5ad1c42..4aca88e355 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/69635b2a1b..9e0a2ac8d2 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/4d131c20da..3c34a54fcd No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ife87aa7be674328d530286a04e46a0a2c1c4b112 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3476387 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao de37ad17 2022-02-16T15:30:46 Vulkan: Call releaseStagedUpdates before releaseImage When Texture is destroyed, we call TextureVk::releaseAndDeleteImageAndViews(). Right now it calls releaseImage() first and then calls releaseStagedUpdates(). The correct order should be releaseStagedUpdates() before releaseImages(). Otherwise for EGLImages, releaseImages will set mImage to nullptr which will make releaseStagedUpdates skip and leave the staged updates there which causes problem since context gets destroyed while EGLImage still hold onto staging buffer belongs to this context's shared group. Bug: b/219646764 Change-Id: I04a005b742a0d90b981a2f399a5e03b03e3a0adb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469727 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Jamie Madill 9296f389 2022-02-18T10:45:01 infra: Enable Python 3 for ANGLE recipe. Bug: chromium:1256377 Change-Id: I0c3a71b2a89fc3e271ad8d4f6c9a8cd91b339899 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3472130 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 78c64dd7 2022-02-18T10:01:11 Roll SwiftShader from 13f7365e81be to b4a56a893496 (11 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/13f7365e81be..b4a56a893496 2022-02-17 sergeyu@google.com [Fuchsia] Stop ignoring warnings in llvm-10.0 2022-02-17 capn@google.com Make shader inputs/outputs only statically indexable 2022-02-17 sugoi@google.com VK_EXT_inline_uniform_block implementation 2022-02-17 capn@google.com Fix rr::RoundIntClamped() for architectures other than x86 and ARM 2022-02-16 capn@google.com Fix and improve exp2 accuracy 2022-02-16 capn@google.com Fix handling overflow in Exp2() 2022-02-16 capn@google.com Exhaustively test the exp2 implementation's conformance 2022-02-16 sugoi@google.com Support render area instead of extent in Renderer::draw() 2022-02-16 swiftshader.regress@gmail.com Regres: Update test lists @ 13f7365e 2022-02-16 sugoi@google.com Small resolveDepthStencil refactor 2022-02-16 sugoi@google.com Format fix in VkPromotedExtensions.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ic484c218da2d356fe82b35a0d0df6caac38b8954 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3474334 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 00c4dc93 2022-02-18T09:10:34 Python3: Update generate_test_spec_json.py Bug: angleproject:5707 Change-Id: Ifa84ecfc4f718f2798b232da30613b8af4940a7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3475171 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki d98f4812 2022-02-17T15:22:22 FrameCapture: Capture empty buffer generation. This avoids emitting VertexAttribPointer with non-null offsets when the array buffer is empty and a vertex array is bound in MEC. When no buffer is bound, which was also the case if the buffer was empty, non-null offsets are not allowed in VertexAttribPointer and will result in: "Client data cannot be used with a non-default vertex array object." Add EmptyArrayBuffer test to VertexAttributeTestES3. Test: angle_end2end_tests --gtest_filter="VertexAttributeTestES3.EmptyArrayBuffer/*" Bug: angleproject:7026 Change-Id: I0cb02a5588f5d2bbc85f58b75fd14493b644d52b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3468524 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 7a4fd421 2022-02-18T07:01:09 Roll Chromium from d984ec3b132a to 6594a8d1e6cf (1749 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d984ec3b132a..6594a8d1e6cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/47f630a2c5..2fb44025ab * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/169eef5b95..93c15529c3 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/1e0047c09e..7539622043 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e5e34cbf4b..aa5552f516 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/00852ba1c5..4c73a7ae74 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..91986b1fdb * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d6a3040bfd..988c0af5be * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/901a5d97c2..31e5ad1c42 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0a9dd7740c..3730026620 * tools/luci-go: git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa..git_revision:582e828c5a8aaf5cdd0ad1d5465fb9092b71eab8 * tools/luci-go: git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa..git_revision:582e828c5a8aaf5cdd0ad1d5465fb9092b71eab8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/25c9dfaa86..69635b2a1b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/715f5e95c1..16a46ce6d2 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/0e5920bffa..5045db5098 Clang version changed llvmorg-15-init-1464-gbf7f8d6f:llvmorg-15-init-1995-g5bec1ea7 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/0a9dd7740c61dddd0144cf2a17e06f2cfb3b9265..3730026620f6de2d26c2ad3f35e21e6982101e5d/scripts/update.py Bug: angleproject:6430 Tbr: cnorthrop@google.com Change-Id: I034db73ada1f0e525d49a42aaf9314bf82fe7ec8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3472702 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b1bdce5f 2022-02-17T23:14:29 Roll VK-GL-CTS from 834c2e16ae1c to d321c7ec84de (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/834c2e16ae1c..d321c7ec84de 2022-02-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/github-main into vk-gl-cts/main 2022-02-17 d.evans@samsung.com Fix waived tests being able to crash suite 2022-02-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main 2022-02-17 rgarcia@igalia.com Test more depth/stencil formats in load_store_op_none tests 2022-02-17 rgarcia@igalia.com Check dynamic viewports with depth clip control 2022-02-17 juha.heiskanen@siru.fi Add tests for zero initialize workgroup memory 2022-02-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,cnorthrop@google.com Change-Id: I86e633450bbdf03d81e42385197b30b6a0f27e4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3472692 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao f996d4d8 2022-02-16T09:27:04 Vulkan: Fix DynamicBuffer cache reuse. There is a regression bug that the DynamicBuffer's BufferHelper's size is no longer the size of entire buffer block's size, but the size of suballocation. This caused buffer reuse logic to screw up since it relies on the size to make the decision to keep or free the mFreeBufferList. This CL fixes this bug by using the buffer block's size. This CL also removes DynamicBufferPolicy since it is not used any more since most of DynamicBuffer usages that triggered that DynamicBufferPolicy implementation have been switched to BufferPool. The remaining DynamicBuffer usage is only for attributes and uniforms which are generally small and per context. Bug: angleproject:6980 Change-Id: I9e013cbd67dd74f5e7fc5bb7d9c9696bd1f69965 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469714 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 8dc9e83e 2022-02-16T21:48:53 Translator: Fix RunAtTheEndOfShader w.r.t discard RunAtTheEndOfShader wrapped main() if it ended in discard. However, it didn't account for the fact that the discard instruction could be wrapped in a block. This change makes RunAtTheEndOfShader more conservative w.r.t discard and has it wrap main() on any encounter of discard. The change additionally adds AST validation to ensure transformations don't generate dead code after branches. Test credit to Cody Northrop. Test: GLSLTest_ES3.ConstantConditionGuardingDiscard Test: GLSLTest_ES3.NestedUnconditionalDiscards Bug: angleproject:7033 Change-Id: Ie9d5210a5cfbb13449720a8a3f44666df9443d98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3471014 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki 00169174 2022-02-17T14:11:01 gl.xml: Remove GL_BLEND_EQUATION_EXT from GetPName. When retrieving the GL_BLEND_EQUATION enum using glGet, FrameCapture incorrectly emitted GL_BLEND_EQUATION_EXT, which is not part of core GL4, GLES 2+3. Add BlendEquationGetInteger test to SimpleOperationTest which failed to compile in the capture/replay tests before this change. Bug: angleproject:7026 Test: angle_end2end_tests --gtest_filter="SimpleOperationTest.BlendEquationGetInteger/*" Change-Id: I886e64ca316754f05ada8e45604bd3aef58a5ba5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3468522 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Jamie Madill 8ade4c2f 2022-02-16T13:14:54 Vulkan: Add overlay and stats for descriptor set caches. This adds more overlay widgets for different metrics of descriptor sets, including for uniforms and for all sets. Bug: angleproject:6776 Change-Id: If1a053bd711454227e7ccbdb01202a712a5f9787 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469228 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 671fcf73 2022-02-16T14:22:38 Vulkan: Add a feature to retain SPIR-V debug info Add a feature to retain debug info in SPIR-V blob. It is enabled when validation layers are enabled. Bug: angleproject:5901 Change-Id: Iccdff31ae0f12fc95d59d20e43e94b6f3d1ae00e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850388 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Jamie Madill 1315bc81 2022-02-09T11:25:58 Vulkan: Refactor DynamicBuffer::allocate. Reduces duplicate code by re-using allocateFromCurrentBuffer. Bug: angleproject:6980 Change-Id: I3f1126a53136be8f68a3a79008dd9adae45c86b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3449279 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 8d966f7d 2022-02-08T11:05:09 Vulkan: Simplify SubAllocation data types. We no longer need to bootstrap on the wrapper classes because we use a separate garbage list. This simplifies the code for the allocation tracking considerably. Also we remove a few mutable accessor to fortify our OOP design. (Credit to Jamie since it is splited from his CL) Bug: angleproject:6980 Change-Id: I2025ec4d141531273e824bb586957a38efc30be1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469715 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 57b8b933 2022-02-17T10:01:41 Roll vulkan-deps from 9fb91023eb58 to 4d9fe6bf1f0c (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9fb91023eb58..4d9fe6bf1f0c Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/90d4bd05cd..d15deba1d8 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/131278458e..188dc8b13c * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/edb793cf31..a32af9ca72 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0b8873487d..efcb50f63a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I5e197c9eb4e8258e8e398888eeaf8d89cb316e4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469732 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu ae9c94f1 2022-02-05T01:47:09 Add instructions to build RenderDoc for Android on Windows Add instructions on how to 1. Install Android dependencies on Windows 2. Install build tools on Windows 3. Build errors and resolutions 4. Steps to build and use RenderDoc for Android on Windows Bug: b/210134963 Change-Id: I707ddf68f5f834fcacd106fd0e3041b8757ae05c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3441634 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 38723c28 2022-02-15T16:29:36 Vulkan: Allocate space for default attrib only if it is enabled When context's default attributes is dirty, we allocate space for the default attribute, regardless it is enabled or not. Then we call into VertexArrayVk::updateDefaultAttrib() which only update its state if the attribute is enabled. This causes a use-after-free scenario that if it is disabled, the vertex array may have a pointer to the buffer that is now becomes inflight which may gets deleted when DynamicBuffer code think the size no longer matches etc. Bug: chromium:1296467 Change-Id: Ib9ec8e60ebdb326f9bbfb215b3711c37631fce4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3466776 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Kenneth Russell ad462491 2022-02-16T13:36:21 Refine suppression for GLSLTest.SwizzledChainedAssignIncrement. On NVIDIA, skip only on OpenGL and GLES, not Vulkan. Bug: angleproject:7029 Change-Id: I2ec2732a94d3952a147df8616fd248876f12172c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469723 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 8cb58667 2022-02-16T13:47:22 Vulkan: Add uniform descriptor set caching test. This covers the case where we'd continually miss the cache due to buffer size mismatches. Bug: angleproject:6980 Change-Id: Ia58871f431b6241af52fa0c37ab51952bc1c4f97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469227 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Kyle Piddington bfbe8661 2022-02-15T16:52:07 Fix UpdateChromeANGLE on mac for debug angle Update script to copy libABSL, libC++ and google_zLIB optionally Add in check before removing nonexistant files Tested by running script after building ANGLE Bug: angleproject:1944 Change-Id: I532d055b7fc70f58ebd807e7e203e4fa6a86be0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3466777 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi a0d558f0 2022-02-16T12:23:29 Vulkan: Fix D/S invalidation for MSAA EGL configs Bug: angleproject:7007 Change-Id: I165ce16e8fdd388ae13aa2e3d05901199706ee24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469221 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 3b891062 2022-02-16T11:38:31 Roll Chromium DEPS manually. Includes a fix for the removed Gold service account mixin. Also upgrades roll_chromium_deps to Python 3. Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/021b19e04d..47f630a2c5 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/01efcb5d51..738dc100c6 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/b323ac8f4c..1e0047c09e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2062399745..e5e34cbf4b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/47dfacfcce..ad002f6051 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/86630a4fe3..00852ba1c5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6fbe58035d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f72361d313..d6a3040bfd * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4e87a80d55..901a5d97c2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ad74e59c0f..0a9dd7740c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/aa8103bd9b..25c9dfaa86 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6d4e79909d..715f5e95c1 No update to Clang. Bug: angleproject:5707 Change-Id: I781dc018443fab6bbde1351c6c0ab426338be4d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469215 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill fb6303a1 2022-02-15T10:50:27 Update docs for checkout with 'fetch' tool. Bug: angleproject:7018 Change-Id: I3e7e905ce536353bb07e260302bfba07d4a4a619 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3465504 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll afacf7f9 2022-02-16T10:01:42 Roll vulkan-deps from 956ca5369840 to 9fb91023eb58 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/956ca5369840..9fb91023eb58 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/471428a04f..d18d0d92e5 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5e96fd5450..edb793cf31 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ca162081a7..0b8873487d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I54387fa7687d2a1c421a054c7316c9dda5a08554 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3464511 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 2893effa 2022-02-10T14:28:32 validationESEXT: Implement ValidateGetCompressedTexImageANGLE. Add CompressedTexImageNegativeAPI test. Bug: angleproject:6177 Test: angle_end2end_tests --gtest_filter="GetImageTest.CompressedTexImageNegativeAPI*" Change-Id: Ia7ed503a7a98f10e4b02deb3954f367f842da3fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452112 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Lubosz Sarnecki b1075951 2022-02-09T17:35:56 vk_helpers: Adjust CopyImageToBuffer extent to block size. When using readPixels with compressed formats, the VkBufferImageCopy bufferRowLength and bufferImageHeight need to be a multiple of the block size. This prevents the following Vk validation errors: VUID-vkCmdCopyImageToBuffer-bufferRowLength-00203 VUID-vkCmdCopyImageToBuffer-bufferImageHeight-00204 Add tests with texture sizes that are not multiple of block size. Test: angle_end2end_tests --gtest_filter="GetImageTest.CompressedTexImageNotBlockMultiple*" Test: angle_end2end_tests --gtest_filter="GetImageTest.CompressedTexImageCubeMap*" Test: angle_end2end_tests --gtest_filter="GetImageTestES32.CompressedTexImageCubeMapArray*" Bug: angleproject:6177 Change-Id: I34c788efece285753857500801e88abeaa6a8a78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452111 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll d77f64b3 2022-02-16T10:01:11 Roll SwiftShader from 5f1c00bda1c1 to 13f7365e81be (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/5f1c00bda1c1..13f7365e81be 2022-02-16 capn@google.com Skip testing subnormals when flushed to zero 2022-02-16 capn@google.com Benchmark the effect of flush-to-zero / denormals-are-zero 2022-02-15 capn@google.com Don't treat all warnings as errors in tests and benchmarks 2022-02-15 swiftshader.regress@gmail.com Regres: Update test lists @ 5f1c00bd 2022-02-15 capn@google.com Don't silently ignore unsupported extension structures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I3615b55bb8905f7fdf6407e99b252ef2535c7050 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3467757 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki bdedf146 2022-01-14T13:35:30 TextureVk: Implement getCompressedTexImage. Extend ImageHelper::readPixels to support compressed formats. Implement readPixelsForCompressedGetImage. Add compression tests to GetImageTest. Implement CaptureGetCompressedTexImageANGLE_pixels in capture_gles_ext_params. Test: angle_end2end_tests --gtest_filter="GetImageTest*.CompressedTexImage*" Bug: angleproject:6177 Change-Id: I6e5b6d746b9c6cc9b885fa44f75a985660d8fb58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452110 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Shahbaz Youssefi 5f3f13f6 2022-02-15T13:39:57 Vulkan: Invalidate D/S for multisampled EGL configs too Regardless of whether the EGL config is MSAA, depth/stencil should be invalidated at the end of the last render pass. Originally, optimizeRenderPassForPresent was gated on !MSAA because it was only affecting the layout of the color attachment. Bug: angleproject:7007 Change-Id: I7cd5497a9da6eeb168c3b55b91f2ff6f5674adb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3465498 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kyle Piddington eeddb050 2022-01-27T11:36:10 Metal: Incorrect parenthization for assignment expressions Fix for Webgl tests conformance/ogles/GL/build/build_017_to_024.html Create intermediate values for assign-equals operations, as they cause issues on expansion later. Bug: angleproject:6489 Change-Id: I7fea162bd1f59c7c765868af739d6ddfc1c1747f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3421527 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Gregg Tavares ed39d49a 2022-02-14T11:32:12 Metal: Fix Hang in WebGL CTS Occlusionquery_strict test If a query was just in progress and then we switch contexts a command buffer, which has already been enqueued, is not committed. Later, other command buffers are enqueued and committed and Metal hangs, waiting on the uncommitted but previously enqueued command buffer. The solution was to not enqueue a command buffer early but instead, enqueue just before committing. Bug: angleproject:6752 Change-Id: I62c07ca3d1ed98cc5b27c8c4af405fdedff922b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3461419 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Steven Noonan 760253ce 2022-01-27T07:24:27 Vulkan: replace uniforms FastIntegerMap with FastUnorderedMap This is in preparation for removing FastIntegerSet and FastIntegerMap. Bug: angleproject:6954 Change-Id: Ifa0a5c5ca39c705a9f774558bb6cad72ed8f0bc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3420952 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 93186337 2022-02-14T11:15:04 Vulkan: Check Serial is valid in SyncHelperNativeFence The change 6d94471bc70 incorrectly checked for validity of mUse in the clientWait and getStatus methods. mUse is valid once the constructor is complete, instead check for validity of the serial. Bug: angleproject:2517 Test: EGLSyncTest.AndroidNativeFence_* Change-Id: Id71eddc4ecf27cea487be56cb362afd68db1fd65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3465455 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Cody Northrop 904a4797 2022-02-15T10:58:07 Python3 upgrades Required to run run_code_generation.py on gLinux. Bug: angleproject:5707 Change-Id: Ifb416be6f89eb67faf43e7de66c6f9a92a5eb5e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3465514 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll c590a1aa 2022-02-15T16:58:29 Roll VK-GL-CTS from 2d1377ec02b5 to 834c2e16ae1c (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2d1377ec02b5..834c2e16ae1c 2022-02-15 quic_mnetsch@quicinc.com Merge pull request #305 from akihikodaki/do-not-directly-use-openglcts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,cnorthrop@google.com Change-Id: Ie680635cbff87ab878e804ed8e64d2c435367333 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3464456 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Sean Risser 3adace15 2022-01-10T22:53:19 Don't expose detailed driver version info to webGL WebGL's GL_RENDERER string now only includes basic version information on all backends. This is controlled through a bool passed through getBackendVersionString. Bug: angleproject:6777 Change-Id: Ie4e3d91d22c96f175a8139fac1c66e985ed9e1b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3380263 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Sean Risser <srisser@google.com>
Sergiy Belozorov 255fec89 2022-02-10T17:57:05 Remove reference to policy_testserver.py The file has been removed in https://crrev.com/c/3452227. Bug: chromium:1270314 Change-Id: I8c0a00540cd820f852364ad3f8b17ccdb3711225 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452114 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop e2f8ff32 2022-02-14T15:55:04 Tests: Add State of Survival trace Test: angle_perftests --gtest_filter="*state_of_survival*" Bug: angleproject:7020 Change-Id: I3e09fa1aaffbd647c4e99316f21db984bbebb2f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3462802 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Vadim Shtayura a5badc3e 2022-02-09T11:39:36 [infra] Update active lucicfg experiments. Remove retired noop experiments and add the one needed for the ongoing luci-scheduler.cfg format migration. R: jmadill@chromium.org Bug: chromium:1182002 Change-Id: I759e03f8fd189682c282af0b8a0b108815b46329 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3449242 Auto-Submit: Vadim Shtayura <vadimsh@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya cf4b50c5 2022-02-14T14:12:13 Vulkan: Retain images before changeLayoutAndQueue This change d9882db5f694c1c added retain calls for images in some places. Such retains are needed for textures and renderbuffers as well. Bug: angleproject:4628 Change-Id: I6b08033870f82851cc62a123bfd9c780812f17b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3462801 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 3b8b1f70 2022-02-15T12:59:11 Roll SwiftShader from cbd31d271e4c to 5f1c00bda1c1 (12 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/cbd31d271e4c..5f1c00bda1c1 2022-02-14 natsu@google.com Fix `WARNING: UNSUPPORTED:` warnings for having external format in sampler 2022-02-14 penghuang@chromium.org Win32SurfaceKHR: use StretchDIBits to replace StrectchBlt. 2022-02-11 dvet@google.com Add a SPIR-V profiling and reporting framework. 2022-02-11 capn@google.com Don't build PowerVR samples by default 2022-02-11 swiftshader.regress@gmail.com Regres: Update test lists @ 0863290d 2022-02-10 sugoi@google.com Add partial support of VK_EXT_extended_dynamic_state2 2022-02-10 sugoi@google.com Support VK_EXT_texel_buffer_alignment promoted features 2022-02-10 capn@google.com Fix shuffling of vectors with a different size mask 2022-02-10 sugoi@google.com VK_EXT_extended_dynamic_state support 2022-02-10 capn@google.com Remove unused sin/cos approximations 2022-02-10 capn@google.com Optimize SPIR-V sin and cos operations 2022-02-10 swiftshader.regress@gmail.com Regres: Update test lists @ cbd31d27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I912bcc3f3e36a026785eda03c7c587535d8eab56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3463540 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0