kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi 35fade1e 2025-09-29T11:45:11 Suppress failing tests Bug: angleproject:444980424 Bug: angleproject:40096874 Change-Id: I7f835f40fb685fb7122e921db8e047f3789c37f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6995361 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Shahbaz Youssefi 549e9ee0 2025-09-26T18:15:26 Capture/Replay: Re-enable passing tests: Bug: angleproject:404418769 Change-Id: I4216a6206ec3d96a75ddd5177995ee26d539d73e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6990630 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 62861200 2025-09-29T07:56:45 Roll Chromium from a8396ec39897 to e7f7a832abc7 (869 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a8396ec39897..e7f7a832abc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a53bdd1c49..dd54bc718b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6b7117dcf6..fe8567e143 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1ff7404922..6d914f364e * third_party/android_build_tools/lint/cipd: KO0H7R4ln4nEeG8mUjEPEX03zNJL8KEL9a-Ock9_42UC..2tl7Wkl-h3xQcHYGcsqwSrIQpyLSlBLjBl36vQwV8VgC * third_party/android_build_tools/manifest_merger/cipd: HrhZb4lTNAd5YEE1rNdZELRw7RXp3OZg-neKFvWAdY0C..dOI-ntBgO0MZG3WmKK37I1njjcGALsDJc00mVeoSfVUC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/dc8d94d80c..823c713789 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/73e46667ed..675a3a9ccd * third_party/fuchsia-sdk/sdk: version:29.20250911.3.1..version:29.20250927.0.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/bcc74d7745..4b4a57f5cf * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/0388350fe9..0c61a55402 * third_party/siso/cipd: git_revision:acfc39d4c923834851300e8676daf8fc47e53a2d..git_revision:f7020b54462c37f1b10a16e68563c338c9f14371 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d857988935..b8f81888f2 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I9f89d84945f6c3ecfd1a29ed0c9aef906ffd88e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6993870 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 7a7681cc 2025-09-23T16:36:43 tests: Require GL_EXT_fragment_shading_rate_primitive Shaders can only reference the built-in gl_PrimitiveShadingRateEXT if the extension GL_EXT_fragment_shading_rate_primitive is supported. However, the test ShadingRateEXTTest.FragmentShadingRateBlend uses a shader that references the built-in without checking if it's available first. Skip the test ShadingRateEXTTest.FragmentShadingRateBlend if the extension GL_EXT_fragment_shading_rate_primitive is not available. Bug: b/446958061 Test: angle_end2end_tests --gtest_filter=ShadingRateEXTTest.* Change-Id: I11d7086a30db704c560c7446b4b7d997bb54b578 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6976660 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxin Hu 020c8ea3 2025-09-26T12:35:25 Disable convertLowpAndMediumpFloatUniformsTo16Bits on non-ARM devices It is unknown if other GPUs need this explicitly 32-bit to 16-bit casts, and the performance impact of this feature needs to be verified across different GPUs. Bug: b/405795981 Change-Id: I1b450aea58d6f4a20eddac5c9edceb4ebac4d999 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6990532 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 6218bbd4 2025-09-26T12:20:39 Vulkan: Make min submit command count dynamic * Turned the constant submit count threshold to a variable that can be set for different devices independently. * Added feature flag to enable forcing submission for certain GL commands, such as Clear and Invalidate. * If disabled, it would treat all commands the same and submit at the count threshold without exception. Bug: b/422507974 Change-Id: Ib13d36adfdcf75aa865dafadc279287f4a4bd1c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6990531 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 18f28e59 2025-09-25T13:41:45 Translator: Mark redeclared gl_Position/PointSize as built-in When redeclared according to EXT_separate_shader_objects, these variables were given a UserDefined symbol type. While this doesn't affect SPIR-V (with Vulkan being the only backend that supports EXT_separate_shader_objects), it does affect the rest of the AST, including GLSL generation which would output _ugl_Position if support for the extension is enabled. Bug: angleproject:42265086 Bug: angleproject:349994211 Change-Id: I04d088017dbe6e32bfee675f0124c4cc3ffdefc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6985322 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tingwei Guo 94777428 2025-08-08T10:36:22 Shading rate should be {1,1} when enabled PER_SAMPLE According to spec, if FETCH_PER_SAMPLE_ARM is enabled, the fragment shading rate is set to {1,1}. Bug: angleproject:437957110 Change-Id: I3ea6958f1aaec5f13923f62001906c7c6c71e09e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6839957 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Tingwei Guo <tingwei.guo@arm.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Mark Lobodzinski 1ca9e7fb 2025-09-25T15:23:48 Tests: Add Harry Potter Magic Awakened trace Test: angle_trace_tests --gtest_filter=*harry_potter_magic_awakened Bug: b/441547450 Change-Id: Ie804ef3dc8c6d6d17f041dadab0f4fb58a27d867 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6986843 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 193e9cda 2025-09-25T15:26:39 Revert "Vulkan: Simplify/Fix DmaBufImageSiblingVkLinux import probing" This reverts commit d917f77130e5194e82418f3bdaa2cd5b2af55c03. Reason for revert: Google Meet Regression https://crbug.com/445863166 Original change's description: > Vulkan: Simplify/Fix DmaBufImageSiblingVkLinux import probing > > Remove the multi-format probing logic in DmaBufImageSiblingVkLinux. > Use the renderer’s base VkFormat and a single check with > VkImageFormatListCreateInfo, instead of looping over mVkFormats with > mutable/non-mutable combinations. This cuts down redundant queries > and streamlines initImpl. > > Also, this CL fixes some issues occur when mapping DRM format into > Vulkan backend formats. > - Default to SampleOnly but prefer Renderable if the modifier properties > exposes both sampling and rendering, since usage at import time is > unknown. > - Fix emulated-format handling issue by using getIntendedFormatID() and > getActualImageFormatID() instead of deriving both IDs from VkFormat with > GetFormatIDFromVkFormat() directly. > > Bug: angleproject:442313595 > Bug: angleproject:426475684 > Change-Id: Ia38d8e7901da10948a2c15eb284b055359dd4a2d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6904888 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: mohan maiya <m.maiya@samsung.com> Bug: angleproject:442313595 Bug: angleproject:426475684 Bug: chromium:445863166 Change-Id: I530e9b363a2e25ec2325e3933a409d0aae9940c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6986844 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 5e51d8e7 2025-09-26T09:45:18 Roll Chromium from 9117e948a9f4 to a8396ec39897 (749 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9117e948a9f4..a8396ec39897 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/369e98b82b..a53bdd1c49 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/61ca0b41f8..6b7117dcf6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cc2a2c47e3..1ff7404922 * third_party/android_build_tools/error_prone/cipd: qtE2WAvADZ8xIiG9JKU7PwWTsjruwLj4bwJa6jqxVpIC..qjoXMGvbc36wB6J_7ERVNhYaotHaTDdrny1PpdNJ1qMC * third_party/android_build_tools/lint/cipd: xfIWrh7SdVKSsAkgiBA0rAaoLKgw06TKtT49xbcx_AkC..KO0H7R4ln4nEeG8mUjEPEX03zNJL8KEL9a-Ock9_42UC * third_party/android_build_tools/manifest_merger/cipd: 8pUvvNgkyjHGP9B17Pbp1YwmjP4GKUXWl_qmEmKtYM0C..HrhZb4lTNAd5YEE1rNdZELRw7RXp3OZg-neKFvWAdY0C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ee7730aa27..e2b34e6c5d * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e39a567268..bcc74d7745 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/a1d9ff0845..0388350fe9 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/34ef99baee..667365a2ae * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/9cdaa6f49e..aba324bb72 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cc42de7c58..b1d66053e6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b513495fc1..d857988935 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/6242e1f716..f93e7ca2a6 Clang version changed llvmorg-22-init-6852-g2384a6a2:llvmorg-22-init-8940-g4d4cb757 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/cc42de7c589335b2dd4d9476a930937cfabdf1ae..b1d66053e6460f04dbe81d77cfeaa9a5d50dee3e/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: I21d4b1032c708c5de53e44868351562b2d5ca73b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6988010 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 1f40285c 2025-09-24T11:54:44 Vulkan: Bypass buffer for VA if Bind*Buffers2 Due to added support for BindVertexBuffers2 and BindIndexBuffer2, there would be no need to allocate a buffer for vertex arrays via getBufferForVertexArray() if the related features are supported. It should be possible to directly reference the original buffer and the proper offset instead without errors. * The buffer handles and offsets in VertexArrayVk now get the original buffer handle and offset instead of using getBufferForVertexArray(). * getBufferForVertexArray() will now be used only when the following feature is disabled: * useVertexInputBindingStrideDynamicState * (which is used as condition for vkCmdBindVertexBuffers2()) * Renamed the function for index buffer: getIndexBufferForVertexArray() This will be used when the following feature is disabled: * supportsMaintenance5 * (which is used as condition for vkCmdBindIndexBuffer2())) * Moved the rest of the code in getBufferForVertexArray() to ~Impl(), which is used by both the functions above. * Removed redundant condition from the vertex input binding stride dynamic state feature. Bug: chromium:40059200 Bug: angleproject:394337110 Change-Id: I665611f92058048a9778aa4b823fabfad7c96c84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6980316 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Rachael Newitt 16e937be 2025-09-25T00:37:44 Rename logdog README.chromium to README.md README.chromium is used for tracking third party open source dependencies, and logdog is a Chromium infra project. Renaming the file to ensure that we don't attempt to enforce 3P OSS management on this directory. Bug: chromium:422372900 Change-Id: I1e995cbefdc5f1b603fff6e7a254b8e62d7a0d1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6981100 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 392d4a4d 2025-09-24T15:58:23 Windows: Fix angle_enable_trace build The writeFile helper was modified to take only two parameters. Test: Build on Windows with angle_enable_trace = true Bug: b/436880895 Change-Id: I603cb1e85a7f9c1f0d2d008adf3a6c9351b4252a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6981094 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll f891f3d2 2025-09-25T07:01:35 Roll Chromium from 3dc9d16aefb2 to 9117e948a9f4 (542 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3dc9d16aefb2..9117e948a9f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d0fcc9d937..369e98b82b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6f5246ca99..61ca0b41f8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/da0a671345..cc2a2c47e3 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1785df7779..c3655ab8bb * third_party/android_build_tools/lint/cipd: P8K_TqqlfAsVDdYQsTmShh1m5oAOuFLB2lnrpIXmprAC..xfIWrh7SdVKSsAkgiBA0rAaoLKgw06TKtT49xbcx_AkC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e66626fb9e..dc8d94d80c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1880cf769b..ee7730aa27 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/838e4c6aa7..73e46667ed * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c662aee7f0..e39a567268 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/4a68b52b89..322be580a5 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/9f31af4aa9..a1d9ff0845 * third_party/r8/d8/cipd: gt1-zSjnG7X9doAhlbcWFpH4PbBSW4tfzcbccnWr6cwC..llWUebGsQPrzc7z3fwJF78NcrdGs1wrUhy0Y-0Wrb-4C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/f538b9f508..34ef99baee * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d6b5ee9c03..9cdaa6f49e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5f914d77d8..e7c34dafbf * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e4712e36b0..b513495fc1 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: If656fcc531c78c4530185faf267a36d1e42b46fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6982424 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Liza Burakova 69745720 2025-09-23T11:16:21 [WebGPU] Implement texture copy from cpu reads. This CL implements a slow path to copying from a texture that reads data from the CPU. This path is taken when the src and destination formats differ. Bug: angleproject:438268609 Change-Id: I5a81fbed5bbac68c48537d8c7a2fcc487c31e76e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6847147 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Auto-Submit: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 35b92525 2025-08-13T15:27:32 Remove lock from GenVertexArrays/IsVertexArray VertexArrays are per context anyway and is thread safe, so there is no need for shared lock. This CL moves mVertexArrayMap from Context to PrivateState so that it won't be accessed by other APIs. Bug: b/433331119 Change-Id: I466a79762e887dbec78b796b52028420837cff59 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6977163 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Austin Annestrand ea4dab49 2025-07-08T18:49:19 cl/vk: add missing map routine locks/counts thread-heavy workloads are exposing parent buffer and sub-buffer mapping/map-count logic. using map lock/count to remedy this. Bug: angleproject:376722715 Change-Id: I1e5cba76f388fa62f244a9372238b2526e910b60 Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6973873 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 4eb8604f 2025-09-24T00:13:51 Translator: Use EvqNumSamples for gl_NumSamples This qualifier was seemingly intended for this built-in, but EvqUniform was used for it instead; presumably following gl_DepthRange. Bug: angleproject:349994211 Change-Id: I1ec7f76195d790ac2a53c4f2b0f9a136976480d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6977986 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Sean Callanan cb3b51a6 2025-09-12T20:45:38 Vulkan: Respect externalFormat properties for AHB When the Vulkan driver sets `VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT` in `VkAndroidHardwareBufferFormatPropertiesANDROID::formatFeatures`, ANGLE has the option of using `VK_FORMAT_UNDEFINED` rather than the reported `VkAndroidHardwareBufferFormatPropertiesANDROID::format` if the feature set is what is desired. This patch introduces separate checks of `formatFeatures` and the capabilities of `format`, and modifies the validation and creation of `VKImage`s to specify a format explicitly only when this would be necessary to conform to user intent expressed by the usage of the AHB. Test: atest GpuFormatIdentityTest Bug: b/440416844 Change-Id: I629b556c1d1daffbced0992f421db2bcd95bbada Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6944813 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Charlie Lao 24fdc63a 2025-09-24T11:52:30 Vulkan: Disable recycleVkEvent Until we figure out whats causing VkEvent leak, disable the recycleVkEvent feature for now. Bug: b/440066521 Change-Id: I1b56554e8986b7113b12280d30cce2aae54b9589 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6981088 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Rachael Newitt a59f1e3d 2025-09-23T23:56:39 Update the bug link in the UpdateMechanism for Stackwalker. Bad copypaste from the original bug for this which ommitted the .com value, creating an invalid link. Bug: b/446257992 Change-Id: If50392f9098a4f3c9fcaaf6447b639c738ee9527 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6976600 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Rachael Newitt <renewitt@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Amirali Abdolrashidi 15a0f3d6 2025-09-24T11:37:36 Unskip KHR-GLESEXT fragment shading rate tests * Unskipped the fragment shading rate tests that no longer fail. Bug: b/436389014 Change-Id: Id0ad01cff8aca6227e7b768d5952818079f58257 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6981087 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Tim Van Patten 043b07e7 2025-09-22T11:08:08 tests: Skip LogEnabledFeatures on system EGL Skip the test EGLPrintFeaturesVulkanExtensionsInfoTest.LogEnabledFeatures when testing the system EGL, because not all platforms expose ANGLE-specific extensions. Bug: b/409384875 Test: angle_end2end_tests \ --gtest_filter=EGLPrintFeaturesVulkanExtensionsInfoTest.LogEnabledFeatures* Change-Id: Id1b602b7d177b109da5cfc7c4082ad044c97475e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6973139 Reviewed-by: Solti Ho <solti@google.com> Auto-Submit: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang 3d8f1d82 2025-09-24T09:48:06 Manual roll Roll VK-GL-CTS from 7f30dc62428c to c67cffddd65a (18 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7f30dc62428c..c67cffddd65a 2025-09-19 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.6 into vk-gl-cts/main 2025-09-19 ziga@lunarg.com Add MRTSS tests with AHB 2025-09-19 rgarcia@igalia.com Test DGC IES with null pSetLayoutsInfo 2025-09-19 rgarcia@igalia.com Check timeline semaphore submit info is properly ignored 2025-09-19 marcin.zajac@cognizant.com Fix various validation errors 2025-09-19 ziga@lunarg.com Enable shader objects extension in coop matrix tests if available 2025-09-19 ewerness@nvidia.com Make ray query tests comply with VU 06353 2025-09-19 lionel.g.landwerlin@intel.com Fix mismatching pipeline creation flags in pipeline binary tests 2025-09-19 michal.jakubek@mobica.com Update white list: VUID-vkCmdDispatch-SampledType-04472 2025-09-19 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/vulkan-cts-1.4.4 2025-09-17 lorenzo@khronosgroup.org Allow Vulkan CTS 1.4.4.0 2025-09-12 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.6 into vk-gl-cts/main 2025-09-12 javed@igalia.com Add tests for helper invocation 2025-09-12 mateusz.bahyrycz@cognizant.com Fix validation errors in ray query and ray tracing tests 2025-09-12 marcin.zajac@cognizant.com Fix validation errors in ycbcr tests 2025-09-12 ziga@lunarg.com Test buffer device address with OpAccessChain offset 2025-09-12 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12 into vk-gl-cts/main 2025-09-12 lorenzo@khronosgroup.org Remove \r (CR) characters from generated files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: Ib4d4cd99e034e680f4f77ac5a2b72ceb1fc778b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6979304 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Geoff Lang e3dc97b1 2025-09-22T16:38:28 Metal: fix SDK condition macro for mathMode. It was missing conditions for tvOS and visionOS and the conditions were > instead of >=. Bug: chromium:383994655 Change-Id: I0a565a7028a3fe43b745419d9bac1da0abcc99be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6972592 Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuxiang Qian 7acb00a4 2025-09-15T15:35:51 Add egl config support GL_RGB16F for Linux Headless Add egl config support GL_RGB16F for Linux Headless. If it is renderable, then ANGLE would generate EGL config for this format. Bug: angleproject:446545299 Change-Id: I213fc6856c561890762eb8548a9a22b3e6fb53f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6975604 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 621fe27d 2025-09-24T03:01:26 Roll SwiftShader from 7dd631d218ad to 5f1c459a11bb (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/7dd631d218ad..5f1c459a11bb 2025-09-23 swiftshader.regress@gmail.com Regres: Update test lists @ 7dd631d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I0eefd8480122d8237f2e5afb66492abfdf145749 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6978030 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ae33b59d 2025-09-24T09:06:38 Roll Chromium from 5b7c14199915 to 3dc9d16aefb2 (707 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5b7c14199915..3dc9d16aefb2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cebe2c6d1f..d0fcc9d937 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8252e9fca7..6f5246ca99 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fcda05a3c1..da0a671345 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3b15c11368..1880cf769b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9b361d9c09..838e4c6aa7 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/cc488d26cf..c662aee7f0 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/b84d427516..9f31af4aa9 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/e8bd9fa14f..f538b9f508 * third_party/siso/cipd: git_revision:760362be9f7ce8728e2538cc02a84aa83c6b05e9..git_revision:acfc39d4c923834851300e8676daf8fc47e53a2d * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f8fcf557a1..d6b5ee9c03 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/55dc67af35..cc42de7c58 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3f47dadef7..e4712e36b0 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/75e3637805..6242e1f716 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ifda36f4f5cd68552bc007d410b99f3daa313feac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6978253 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi dd51c3e5 2025-09-16T00:03:20 Vulkan: Expand usage of BindVertexBuffers2 * bindVertexBuffers2() can now be used when vertex input dynamic state is enabled. * Since dynamic vertex input already sets the strides, there is no need to add the strides to bindVertexBuffers2() anymore and passing in nullptr should work. * Added the following token: BindVertexBuffers2NoStride * This is used to avoid the condition check overhead for the draw calls taking this code path. * Removed the condition of vertex input dynamic state from using vertex input binding stride. * The following pipeline flags can now be added to a pipeline object at the same time: * VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE * VK_DYNAMIC_STATE_VERTEX_INPUT_EXT * Changed the condition of positive vertex attribute count to any vertex attributes to add input binding stride flag to the pipeline. Bug: chromium:40059200 Change-Id: Id3be458580da0ca46db554bf292f240dae4d5097 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6944912 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Xin Yuan b4d1333d 2025-07-24T10:28:25 Fix the issues when blitting within same resources Per GLES spec,when the attachments in src and dst framebuffers are identical, angle should generate GL_INVALID_OPERATION. But different mipmap levels of a texture, different layers of a 3D texture or 2D array texture, and different faces of a cube map texture do not constitute identical buffers, these are valid operations. Bug: angleproject:433816259 Change-Id: Ie6d34819dfbc2faa4af22ec370e59c1ed4521bcb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6780168 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Xin Yuan <xin.yuan@arm.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Hoyeon Lim 81d5ad4b 2025-09-23T16:54:46 FrameCapture: Set GL_TEXTURE_CROP_RECT_OES texture parameter Add texture parameter setting for GL_TEXTURE_CROP_RECT_OES in frame capture (GLES1 only) Bug: b/446779901 Change-Id: I174dc351292b3a928f75419590f5eaea37c5f376 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6975608 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Shahbaz Youssefi bfdf223a 2025-09-23T11:42:39 Translator: Don't differentiate static read vs write In the end, the only thing that matters is whether a symbol is statically used, so no need to track whether the static use was in a read or a write context. Bug: angleproject:349994211 Change-Id: I4964fc9f76a5f7798f1b5e42ce2ae997dca78063 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6976297 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu df433920 2025-09-23T11:16:44 Add instructions when apps do not have access to /sdcard Bug: None Change-Id: I41bcf8de82f03e1a4dbeae8cb1aefcfe6fa88474 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6976652 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Rafael Cintron ddc6885d 2025-09-22T17:22:20 Remove SubjectMessage::ContentsChanged handler from gl::Texture Case statement for SubjectMessage::ContentsChanged in gl::Texture::onSubjectStateChange was added during the development of multisampledRenderToTextureEXT on Windows. Since we're removed the partial implementation, we no longer need to handle this condition. Bug:chromium:443111620 Change-Id: I78f83121491c295961386e1e2a4da191c0ce7171 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6975022 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 8c263b84 2025-09-23T08:09:56 Update end2end expectations file A few pipeline cache related tests were removed recently, remove them from the end2end expectations file as well. Bug: angleproject:386749841 Change-Id: I8cb607e84a3463248a666abc8c4523ff782e50ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6976425 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Hoyeon Lim 205a9a22 2025-09-22T14:04:59 FrameCapture: set starting binding GL_ELEMENT_ARRAY_BUFFER set starting binding GL_ELEMENT_ARRAY_BUFFER of vertex array object. Bug: b/446464003 Change-Id: I64f05694f66909fba81dc454df871d4cd49c20bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6968196 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 453c2478 2025-09-23T07:01:23 Roll Chromium from d6b89a2a25f7 to 5b7c14199915 (611 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d6b89a2a25f7..5b7c14199915 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5775f8cf70..cebe2c6d1f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/65bbe96cad..8252e9fca7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/78ffc85e76..fcda05a3c1 * third_party/android_build_tools/manifest_merger/cipd: uKGig6PBT9wSbI5t2hAl8MQ9b8iT5CcnYe1T9tGBVIkC..8pUvvNgkyjHGP9B17Pbp1YwmjP4GKUXWl_qmEmKtYM0C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c9615828ed..3b15c11368 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8ab2a5350f..9b361d9c09 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/ae547b0b2f..cc488d26cf * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/5e9aa30cfe..b84d427516 * third_party/r8/cipd: GdIzaPd-qIK7U0nz0iINlRfmvCQI73zL3OSNmyEXFWEC..llWUebGsQPrzc7z3fwJF78NcrdGs1wrUhy0Y-0Wrb-4C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/ab2a5f0cfd..e8bd9fa14f * third_party/turbine/cipd: 9ZS5YYFBth7RSqNe7VLip-qJhk00WoicV_Qb0byHna8C..LaDt9HreG5-Q6yBbZLf6LJSvLKqNjamn84VJgZHXSTEC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/abd36d9022..f8fcf557a1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6953e505c2..55dc67af35 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1002a71873..3f47dadef7 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I039a8e20b2271d7b703de8c82142f57528bb7202 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6972782 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Matt Stark 3da898aa 2025-09-17T05:15:40 Add missing include for windows Bug: chromium:40263312 Change-Id: I3c4c82c3f6ec1c4b26b6a26b2fe56945be0351aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6957755 Auto-Submit: Matt Stark <msta@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shyam Manohar c41ec91d 2025-07-03T13:34:09 CL/Vulkan: Zero-copy support added for CL Images - Using syncHost now for HostTransferConfigVisitor - Modified the interface of copyImageToFromBuffer Bug: angleproject:444481344 Change-Id: Iad315952720fcb23cbc0e58321594cb4d0db71dd Signed-off-by: Shyam Manohar <s.manohar@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6939059 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Gowtham Tammana bc69e27d 2025-06-19T11:25:35 CL/Vulkan: Add helper routine to calculate VkBufferImageCopy When copying image to buffer and buffer to image, we need to construct VkBufferImageCopy object. Setting up a helper function for command usage. Bug: angleproject:444481344 Change-Id: I4d156454cea6e0de87604aaecde8809f1669de8c Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6939058 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Charlie Lao 91263bbb 2025-09-18T14:55:02 Vulkan:Improve ContextVk::handleDirtyGraphicsDefaultAttribs ContextVk::handleDirtyGraphicsDefaultAttribs() calls updateDefaultAttrib(), which basically does the work ContextVk::onVertexArrayChange() is doing. This CL simplify the code by calling onVertexArrayChange directly from handleDirtyGraphicsDefaultAttribs. onVertexAttributeChange is removed. This also has the advantage that onVertexArrayChange put the for loop inside if check, versus current implementation does all the if check inside the for loop. Bug: b/439073246 Change-Id: Ic7b7f531f2f831d16f34794e23fefc9569a3e142 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6967318 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Mohan Maiya fde13336 2025-09-21T14:38:09 Update documentation for ANGLE_AHB_FORMAT_* Bug: angleproject:386749841 Change-Id: I235ac1abe7c0fc1e18751377e1a3953d81b507f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6970621 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Mohan Maiya a8ed5bd1 2025-09-20T16:38:48 Vulkan: Disable convertLowpAndMediumpFloatUniformsTo16Bits for Samsung Bug: angleproject:405795981 Change-Id: Ib71a5121ab71df57cd30ece8698694f11f91c563 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6970446 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Geoff Lang 0e719508 2025-09-22T11:37:36 Metal: Gate mathMode usage on compile time SDK versions. Integrators of ANGLE who compile with SDK versions lower than macOS 15 would get compile errors by referencing mathMode. Bug: chromium:383994655 Change-Id: I152403977c1233e4049f13f3d99cdd12fdf87073 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6973058 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org>
Mohan Maiya 50927761 2025-09-19T14:45:24 Vulkan: Add externallySynchronizePipelineCacheAccess feature Acquire renderer's pipeline cache mutex IFF externallySynchronizePipelineCacheAccess feature is enabled Bug: angleproject:386749841 Bug: angleproject:445240187 Change-Id: I91804e2713944768a5379adc3113ce7632a17111 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6969910 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Mark Lobodzinski 02b53738 2025-09-08T08:55:23 Trace/Replay: Fix context grouping issues In tracing Harry Potter Magic Awakened, issues related to context grouping were found affecting shader and program state. While these objects are shared among all contexts, their state is not. This led to race conditions in object lifetimes as well as incorrect states for operations dependent on stader/program state. Test: angle_trace_tests --gtest_filter=*harry_potter_magic_awakened Bug: b/445208963 Change-Id: I8dbb22f72c917103f947cd34d088c4db0cd39731 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6950247 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Panfeng Hou 1e1830b7 2025-09-10T15:35:54 Vulkan: Return length=0 if the bufSize of glGetActiveAttrib is 0 Bug: angleproject:444058258 Change-Id: I9d1bd6f85f4340e1d330317923b954e5bfaeb3b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6933702 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Panfeng Hou <panfeng.hou@arm.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 59cba8ca 2025-09-22T07:01:00 Roll Chromium from 129abbaa76d7 to d6b89a2a25f7 (1428 revisions) https://chromium.googlesource.com/chromium/src.git/+log/129abbaa76d7..d6b89a2a25f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e924c0b4e3..5775f8cf70 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f924cff1b2..65bbe96cad * buildtools/linux64: git_revision:5d0a4153b0bcc86c5a23310d5b648a587be3c56d..git_revision:81b24e01531ecf0eff12ec9359a555ec3944ec4e * buildtools/mac: git_revision:5d0a4153b0bcc86c5a23310d5b648a587be3c56d..git_revision:81b24e01531ecf0eff12ec9359a555ec3944ec4e * buildtools/win: git_revision:5d0a4153b0bcc86c5a23310d5b648a587be3c56d..git_revision:81b24e01531ecf0eff12ec9359a555ec3944ec4e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f1faf4cb02..78ffc85e76 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/47b1fee1d4..1785df7779 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/4d7a487088..8f954f456f * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e161b0d383..e66626fb9e * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/e97e62b0b5..e3919359f2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d266e57b80..c9615828ed * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d761e6db8..8ab2a5350f * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7b8dc07adc..ae547b0b2f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/49c8eeff56..5e9aa30cfe * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/2a41c8cc1b..ab2a5f0cfd * third_party/siso/cipd: git_revision:e1e6b655eeb5da6f764ea736e9f5b1dbbd2859d6..git_revision:760362be9f7ce8728e2538cc02a84aa83c6b05e9 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/caf4afa1af..85f05b0835 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/7d15f427b6..abd36d9022 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d5c58bc612..6953e505c2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/28382daab7..5f914d77d8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/91aecc7266..1002a71873 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/75a2b60baf..75e3637805 * tools/skia_goldctl/linux: 0m9SaljOycDrE8fearwZkVxxQQ098EfFXGJeb3EBjQYC..fRuslzP17fJiIrNMmrGUnphvWkc8jcmavhAEtbG5_IgC * tools/skia_goldctl/mac_amd64: AzKEv2HI-8_ky3EVvExnuRplPIq3tixEfrAHZEb_07kC..RIjp_6aODKNgiyQW90GtpE3kM2NGlSW6B33OdAlPwnYC * tools/skia_goldctl/mac_arm64: VrlF0xpgJleUjmPltWxsqf_gls027kAQjJxsrnn-iDkC.._Ufwu0yprCm3Au8mKCt_ahugJqb3ImjdAVQceH7bbFUC * tools/skia_goldctl/win: kJaXlUqja-Q_RLqhVDs9FUO3RhdH6i_xcIAmuGI5Xi4C..7tIc3ckW4E5m2fK83LYxUD2PDwpKEvuZiFUSYUTLY5gC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ibf8220ed7a8ade0e90f6121725332df299c5a71e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6971906 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski c07bed66 2025-09-17T10:36:27 Trace/Replay: Allow for ignored uniform locations If a uniform location is -1 it must be ignored and no changes can be made. Skip default uniform location updates for these locations. Test: Capture GFXBench car chase scene Bug: b/441583445 Change-Id: Ifd476636f241a352ad058890bf945cf337e61f6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6961035 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 369e4e00 2025-09-19T15:34:40 Tests: Add trace batch for 2025-09-19 These traces were contributed by Samsung. Traces in the batch include: - cashman_casino - dc_dark_legion - jackpot_party - lightning_link Test: angle_trace_tests Bug: b/446235047, b/446234214, b/446235287, b/446235073 Bug: b/446064595, b/42264359 Change-Id: I1afd78bcfa9254a90890f9d8630463d93ba3d155 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6969917 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 082882b5 2025-09-19T16:10:41 Fix README.chromium for llvm Add the required Version field. Bug: b/445256169 Change-Id: Ifd9ea36204cc70f7d4e53ca6dcf3e4b494b230cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6969489 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 75f6faf1 2025-09-05T17:01:43 Vulkan: Use size in BindVertexBuffers2 * Added the following attribute array to VertexArrayVk: mCurrentArrayBufferSizes * Updated during syncing/updating the vertex array attributes. * Added the pointer for buffer sizes to the following call: vkCmdBindVertexBuffers2EXT() Bug: chromium:40059200 Change-Id: I754741d12a729d42dab7e0f0b166a174c8d86181 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6917838 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Jeff Vigil 61c452ba 2025-09-03T17:23:37 Vulkan: Disable supportsShaderFramebufferFetch for Samsung Disable framebuffer fetch extensions for Samsung. Bug: angleproject:445083429 Change-Id: I89828b148ea1ac8ad2d59626e15d5f9358fe5b3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6962954 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Gowtham Tammana 3d60009c 2025-02-26T00:09:37 CL/Vulkan: Don't serialize on external CQ events At the moment, the vulkan backend is setup with a single queue for all command buffer recordings. So flushing the external cq's on its dependencies is sufficient enough. Bug: angleproject:446112158 Tests-Passing: ocl_cts.test_events Change-Id: I7310f1b5e24abf7476b7a753a280456050e1afd5 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6939057 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Solti Ho 7db4a404 2025-09-19T18:12:41 Vulkan: Fix UBSan by initializing CopyImageParameters A sporadic UBSan crash was caused by reading 'copyYuvWithoutColorConversion' member from an uninitialized CopyImageParameters struct. Fix this by zero-initializing the 'params' variable at the call site in TextureVk.cpp Bug: b/446185698 Bug: b/445180744 Change-Id: I92db7a735b91df8603698bb2a33d95ec6d7556a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6965689 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Solti Ho <solti@google.com>
Yuly Novikov 722572ab 2025-09-19T13:15:30 Add Pixel 10 experimental builders Not running any tests for now. Bug: chromium:443001330 Change-Id: I0ed9f73f7d72ef22a74a97c88f6b0db1ce4ca5ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6969103 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Rachael Newitt 9fdc7a13 2025-09-19T03:50:13 Adds a freshness exemption for StalkWalker. Bug: chromium:422917292 Change-Id: Ie36fc10ac94b0f5e9c657f649cc96ed26b04de12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6968094 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f507e78c 2025-09-19T03:01:33 Roll SwiftShader from ce5b85176a89 to 7dd631d218ad (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ce5b85176a89..7dd631d218ad 2025-09-18 msta@google.com Fix an ambigious definition error for clang modules on windows. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I3856b567ff21179ece1984e5fcdb13df5d622443 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6968720 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5ea06c0c 2025-09-19T10:01:24 Roll vulkan-deps from 86b0a2e14a4d to 8ff085ff814f (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/86b0a2e14a4d..8ff085ff814f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/100cd65f96d1ffdaac93b560e65eb5e207466b3f..5c69a98762f6d8bc68d4a0042ba4a037d4af0a05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I35a33451e3c0d99b92a57da4ffc6c772b3677183 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6968519 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gowtham Tammana 096924c1 2025-06-13T17:26:20 CL: Consolidate cl::{Offset,Extents} types The following definitions were equivalent, so consolidating their definitions. - cl::MemOffsets ~ cl::Offset - cl::Coordinate ~ cl::Extents Bug: angleproject:444481344 Change-Id: I6c1bd68bc3260b8da0ab4b4796668caf474e56a1 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6939056 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana 04cbd20d 2025-06-16T11:06:44 CL/Vulkan: Fix the rect size calculation Take into consideration on the extraneous region when calculating the size of the enclosing buffer size for buffer rects. Bug: angleproject:444481344 Change-Id: Ifd146035565abf5bea0650ccee375bc2b28a55c1 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6939055 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Charlie Lao b1fc47c7 2025-09-17T18:21:02 Vulkan: add check for vertexAttributeInstanceRateZeroDivisor Allow zero divisor for vertex attributes when mVertexAttributeDivisorFeaturesmVertexAttributeDivisorFeatures.vertexAttributeInstanceRateZeroDivisor is true. Bug: b/439073246 Change-Id: I68705faffcefb38360f6fbcf5d937d1d902180aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6961233 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 17c0d100 2025-09-16T13:59:36 Vulkan: Remove VertexArrayVk::updateActiveAttribInfo This function get called from DIRTY_BIT_VERTEX_ARRAY_BINDING context dirty bit processing. It is doing exact same work as ContextVk::onVertexArrayChange(), which was already been optimized in earlier CL. In this CL VertexArrayVk::updateActiveAttribInfo() is deleted and onVertexArrayChange() is being used, which does minimum things when supportsVertexInputDynamicState is enabled. Bug: b/439073246 Change-Id: I6b388a8f89a63e654d290c6f8d2212052b8c0d1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6945076 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao cba665f3 2025-09-11T17:59:41 Vulkan: Add fast path for supportsVertexInputDynamicState In earlier CLs, we have stored stride/offset/format/divisor in Vulkan structs directly in VertexArray, this CL try to send these structs to vulkan driver directly without making another copy. divisor code has been modified to update inputRate as well as divisor in VertexArrayVk. WHen program and VertexArray's attribute types matches we use VertexArray's mVertexInputBindingDesc and mVertexInputAttribDesc without any data copy. If attribType mismatch then we make a copy and patch up the stride/format. Bug: b/439073246 Change-Id: I905b1e6d0609ffc4eb63b47e11a84f8617e06c29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6898416 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 45521eea 2025-09-17T15:57:04 Fix DrawWithMismatchedComponentCountLocationSpecified test bug The test has a bug that enabling the wrong vertex attribute. Instead of using hard coded attribute index (1), use colorLocation instead. Bug: angleproject:42264298 Bug: b/439073246 Change-Id: I3ae652e0ea6abe0392e6698c01af2f1c255cba26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6962956 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxin Hu f28c8029 2025-09-17T16:02:40 Re-enable the feature that transforms float uniforms to 16 bits Re-enable the feature after suppressing the WebGL conformance tests: https://chromium-review.googlesource.com/c/chromium/src/+/6937051. Temporary disable this feature on PowerVR while the bugs are under investigations. Bug: angleproject:405795981 Bug: angleproject:443302350 Bug: angleproject:443302625 Change-Id: I8263bd6fcf120b7bed8211f0439962be40afd992 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6962958 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Geoff Lang 1b5fc24c 2025-09-17T16:36:33 Metal: Avoid deprecated fastMathEnabled on newer MacOS. Use the mathMode and mathFloatingPointFunctions properties instead. The new enum properties are set to the equivalent bool value from before. Bug: chromium:383994655 Change-Id: Ia28f5b8358fe0721183dd6041432856d25e16475 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6962694 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 1595f3f7 2025-09-18T10:02:13 Roll vulkan-deps from 59d1ef64176c to 86b0a2e14a4d (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/59d1ef64176c..86b0a2e14a4d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/720fe8ab367beb15c4b08064c13cdf96711247f5..d89fe7492d26b3eb12b2f1990cc2ad4bcdd953f1 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/6ce15ebd721a74c7aae1f9c49033635b81224044..d7ac0e0fd062953f946169304456b58e36c32778 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/83cded838a1a6e2dadfda6b114c8e12135194718..95cfb8b1ba7fbcbe1383302ff286808c34e1fb9e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/a0543a68cca0de632c010724fad08fce0bc27679..fa01ab38ca196264fe44fa923feaffc7dcc76d76 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b7cec35a0ca9d1197aeb85a00a5f426249e1e134..100cd65f96d1ffdaac93b560e65eb5e207466b3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ib1eef96912a093b73e35d6685e8230b429e35ac1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6965295 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi a44693f6 2025-09-17T14:50:37 Vulkan: Fix SPIR-V gen for invariant structs Bug: angleproject:349994211 Change-Id: I7db05d9a6232a577a65f7a337cfd1636bce0c53b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6961859 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4f384e51 2025-09-18T07:59:53 Roll Chromium from 8e8081831607 to 129abbaa76d7 (640 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8e8081831607..129abbaa76d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/298617b7f0..e924c0b4e3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/19bc3708ba..f924cff1b2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5f35403daf..f1faf4cb02 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f733f5a3fa..47b1fee1d4 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/399e5f5ba9..4d7a487088 * third_party/android_build_tools/lint/cipd: d6CQ9eCLBIOopQEbwq-Sax2LJTcnhF8kso6FeFopbkgC..P8K_TqqlfAsVDdYQsTmShh1m5oAOuFLB2lnrpIXmprAC * third_party/android_build_tools/nullaway/cipd: Zk_ffB0B6qGrr2ZDKqCxAgnPmo4-5giVRIauRffZaZYC..N8e9CN_YH72RHiFh5wTuXkcMtNbQBBrtot_-HePTmAwC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/cf6beb83fd..e161b0d383 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0a50a85229..d266e57b80 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6da6aecbb4..0d761e6db8 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/f2fc757153..49c8eeff56 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/6a2c6d01f5..7d15f427b6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8e6c4696e2..d5c58bc612 * tools/luci-go: git_revision:49b2e707cefeee85697673b81627b3329debfae4..git_revision:6645da847edf4e1ebcfe8cf4d860ad75e63b20cb * tools/luci-go: git_revision:49b2e707cefeee85697673b81627b3329debfae4..git_revision:6645da847edf4e1ebcfe8cf4d860ad75e63b20cb * tools/luci-go: git_revision:49b2e707cefeee85697673b81627b3329debfae4..git_revision:6645da847edf4e1ebcfe8cf4d860ad75e63b20cb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0b97617ee6..91aecc7266 * tools/skia_goldctl/linux: hV2dfcJ5iud2DblnB27NWew6qYb6HipSH86rBfdGh1EC..0m9SaljOycDrE8fearwZkVxxQQ098EfFXGJeb3EBjQYC * tools/skia_goldctl/mac_amd64: r6FpOxWU9iELjJeuq72JTfmKs93KTxpbkt6RwybYABoC..AzKEv2HI-8_ky3EVvExnuRplPIq3tixEfrAHZEb_07kC * tools/skia_goldctl/mac_arm64: 0DvbA0ox2ZUvnTJFNQMtNGdwzeJbpCaAZQcQYyiFTpMC..VrlF0xpgJleUjmPltWxsqf_gls027kAQjJxsrnn-iDkC * tools/skia_goldctl/win: k1h3MReK-_5P1okvxqyXSeNIJ1EaFV5dfHokEHQUKpcC..kJaXlUqja-Q_RLqhVDs9FUO3RhdH6i_xcIAmuGI5Xi4C No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I6b99e68b2353bce3089b895dc92c386aafba555d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6961465 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 3c588044 2025-09-17T22:44:36 Tests: Add trace batch for 2025-09-17 These traces were contributed by Samsung. Traces in this batch include: - match_factory - paper_io2 Test: angle_trace_tests Bug: b/445816053, b/445816060 Change-Id: Id75e9ca06cd3beafc0794b4c2cf134e22ee5318a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6961131 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Austin Annestrand 7217890d 2025-06-17T11:51:08 CL/VK: Add SerializedExecution feature knob Feature allows for each enqueue-able CL command to submit and wait for fence (debugging aid). Bug: angleproject:444491489 Change-Id: I16b7e74f2a321680a81ab3c8a18dd9534a64ce1a Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6941617 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Andrew Mitchell f5f9c129 2025-09-14T18:24:09 Add reference to ReAuth guide Change-Id: Ifc9128da700cfd0e0a74e6426eefee9f3fb2aaa0 Bug: chromium:415115279 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6947247 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 9e8f3c1f 2025-06-06T15:01:59 CL/VK: Cleanup buffer and image map handling - Create/move memory map routine(s) to CLBufferVK/CLImageVk. - Update image staging buffer routines. - Remove unused CLMemoryVk routines. Bug: angleproject:444481344 Change-Id: Ibd8361ce8eec67a1891effe0fee344ef977d25dd Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6941607 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Brian Sheedy 44db20f2 2025-09-17T15:57:09 Revert "Add a "noncoherent" layout qualifier to PLS" This reverts commit ef9c5ce43110f4f8ba56124bdee927944ce3ddd1. Reason for revert: Causes issues on Apple silicon crbug.com/445727125 Original change's description: > Add a "noncoherent" layout qualifier to PLS > > Raster ordering can be expensive. If an app knows the geometry in a draw > does not overlap, it can mark the PLS planes as noncoherent and opt for > using barriers instead. > > Bug: angleproject:40096838 > Change-Id: I2d686c2e64f51940face186637a9fcadcc251bef > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923300 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Chris Dalton <chris@rive.app> Bug: angleproject:40096838 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ibc24bed27cec406b6e4ffa9aaa8fe3a2110b58ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6962955 Reviewed-by: Kenneth Russell <kbr@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Charlie Lao 7201e17d 2025-09-16T11:04:05 Vulkan: Move divisor>MaxVertexAttribDivisor to VA::syncState Another preparation for use mVertexInputBindingDesc directly. Instead of checking divisor > renderer->getMaxVertexAttribDivisor() in ContextVk code, this CL take care of them in VertexArrayVk::syncState, so that all other code do not need to take care of it. Bug: b/439073246 Change-Id: Id938c168a1490e072e6f4bb08b85b60b55968ddf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6955256 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Austin Annestrand b3e715de 2025-07-15T13:43:31 cl/vk: Fix user-event handling - add missing internal retain for user-event setting - add missing predicate for condition variable wait - fix double-alloc on user-event backend creation - mImpl is created during "initBackend", not ctor Bug: angleproject:444482493 Change-Id: I48fa8bca43a06d5ff8b2bceb884a924840ec5682 Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6941605 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao e542cb6c 2025-09-15T16:35:34 Vulkan: Split handleDirtyGraphicsVertexBuffers into two funcs ContextVk::handleDirtyGraphicsVertexBuffers() has two code paths that are quite different, depends on if supportsVertexInputDynamicState is enabled or not. This CL splits this function into two so that 1) code is much easier to read that what is done in each case and 2) get rid of if check at draw time. Bug: b/439073246 Change-Id: Iaf9f84fb20d82e784f9dfe8ece321cff94b7b58d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6956208 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Charlie Lao <cclao@google.com>
Shahbaz Youssefi f128872e 2025-09-16T23:37:08 Translator: Compare variables by unique id instead of pointer Bug: angleproject:349994211 Change-Id: I32ab2ffe9a04e196330949484e704913d0f4e41d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6955119 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Geoff Lang 0cc9b7be 2025-09-03T11:33:37 Support more YUV formats in CopyTextureCHROMIUM Add support for formats in GL_ANGLE_yuv_internal_format as source textures to glCopyTextureCHROMIUM. These formats are common AHardwareBuffer formats and Chrome uses them as copy texture sources when decoding video. Bug: chromium:405308165 Change-Id: Ic817cce83b676ee9a517bee4fac6ef94a174961f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6908295 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Lokbondo Kung 938c80d5 2025-09-17T11:57:39 Fix missing include for <ratio> used for std::nano. Bug: b/412761856 Change-Id: I7535e7176e4372df6948f903504594e448153d48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6961860 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Loko Kung <lokokung@google.com> Commit-Queue: Loko Kung <lokokung@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 130bdaa9 2025-09-10T12:51:37 Vulkan: Store VkFormat in VkVertexInputBindingDescription2EXT In preparation for next CL that uses VkVertexInputBindingDescription2EXT directly, this CL also stores the VkFormat in VkVertexInputBindingDescription2EXT directly. mDefaultAttribFormatIDs is added to store the angle::FormatID for the default attribute (used when attrib is disabled in VertexArray) Bug: b/439073246 Change-Id: Ia36758b258be23676b9b12c0c7cec7adefe1036a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6935270 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 1252d9aa 2025-05-30T14:16:23 CL: Create frontend event and pass to enqueue APIs Since frontend cl_event object does not depend on enqueue API routines, we can construct it early and then pass to mImpl enqueue API calls (for any backend that needs it). Also update backend routines to init their backend event implementations using frontend event object. Bug: angleproject:444482493 Change-Id: I459dbf34f10cb6b30245479c9966f876d6e905d7 Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6941604 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 5298dccc 2025-09-13T21:04:47 Vulkan: Fix depth/stencil blit src layer The depth/stencil views used in blit viewed the exact layer, so they are always 2D and no layer parameter is needed. Tests upcoming in https://chromium-review.googlesource.com/c/angle/angle/+/6780168 Bug: angleproject:433816259 Change-Id: I7fa105d2734c47c86d4d0e82e8f68dc1a23e4612 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6944631 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Aurora Zhang f8c8264a 2025-09-17T10:01:22 Support RGBX format with GL_RGBA when using glTexSubImage2D Add an additional combination support with GL_RGBA in glTexSubImage2D for RGBX format. Add an end2end test. Bug: angleproject:444335354 Change-Id: I96fc9d3543fc58c9f666bf149f78cf9049758a32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6938945 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Panfeng Hou c8af6941 2025-09-16T14:51:55 Vulkan: Enable FragmentShadingRateEXT CTS fix patch was merged, enable per draw and per primitive VRS. Bug: angleproject:397255625 Change-Id: I681a52d9d28572153ff868cfbfc71657f26e3b21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6953541 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Panfeng Hou <panfeng.hou@arm.com>
Mark Mentovai 2f564f1c 2025-09-16T16:46:36 mac: handle Metal toolchain being unbundled from Xcode 26 The Metal toolchain was formerly part of Xcode, but in Xcode 26, it has been unbundled and is now a separate install. Attempting to use the Metal toolchain without installing it results in a build error, such as: error: error: cannot execute tool 'metal' due to missing Metal Toolchain; use: xcodebuild -downloadComponent MetalToolchain By running the suggested command, the Metal toolchain can be installed, but the existing angle build does not know how to find it correctly. For system Xcode installations, tools from the Metal toolchain (`metal` and `metallib`) can be run via `xcrun`. This construct should work equally well for older Xcode versions, for situations where it’s still in use. For the hermetic toolchain, we’ll continue splicing the Metal toolchain into the location it had previously been avialable (see https://chromium-review.googlesource.com/c/6950738), although this is subject to change in the future. Bug: chromium:423933062, chromium:445400016 Change-Id: I139eca51938f7cecfec9b90fd488947160ef4ec9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6955000 Auto-Submit: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 7b4946b7 2025-09-17T03:01:47 Roll SwiftShader from 3877515497c0 to ce5b85176a89 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/3877515497c0..ce5b85176a89 2025-09-16 swiftshader.regress@gmail.com Regres: Update test lists @ 38775154 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ia39f24a46a40975b73bd1d50a684ae3d2618f5e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6958592 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4c5b7f14 2025-09-17T11:21:44 Roll vulkan-deps from 90665ef518dd to 59d1ef64176c (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/90665ef518dd..59d1ef64176c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/1614abe2a290062df11c142bfc67fccc56692133..720fe8ab367beb15c4b08064c13cdf96711247f5 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/4ff7bc64c6881d8028251323d97a1078ebb60201..50399a2c3011bea1941a977f5b90a241053af4bc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/9819b31bed2a79cb88260d69ede346a92319ac8b..b7cec35a0ca9d1197aeb85a00a5f426249e1e134 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ifc9dfb058d51f5d37d46cf39b84142eb2c4e2f17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6958719 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e24df24e 2025-09-17T07:01:51 Roll Chromium from c960af7f560f to 8e8081831607 (593 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c960af7f560f..8e8081831607 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3afd36a297..298617b7f0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/958004daac..19bc3708ba * buildtools/reclient: re_client_version:0.179.0.28341fc7-gomaip..re_client_version:0.183.0.3b3097cd-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/57fef43213..5f35403daf * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9d692d6692..f733f5a3fa * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/0c9a24dacc..399e5f5ba9 * third_party/android_build_tools/error_prone/cipd: _xvKMGMJix5ysOYKkNTfSBd8CHQlf-DqEmAYYoEP3wgC..qtE2WAvADZ8xIiG9JKU7PwWTsjruwLj4bwJa6jqxVpIC * third_party/android_build_tools/manifest_merger/cipd: -IKgMtIkFMuvZVpfM_1mWxAhbYzplqRHQ1JHqsbZ1RQC..uKGig6PBT9wSbI5t2hAl8MQ9b8iT5CcnYe1T9tGBVIkC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/74d30d13de..cf6beb83fd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/375b4c2e2a..0a50a85229 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/35982166cc..6da6aecbb4 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0257666efc..7b8dc07adc * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/06a10da15f..f2fc757153 * third_party/r8/cipd: mYSxNBcKcdv-HE9jrIzdWaxdKITSSM0lbH_DTAVO4tcC..GdIzaPd-qIK7U0nz0iINlRfmvCQI73zL3OSNmyEXFWEC * third_party/six: https://chromium.googlesource.com/chromium/src/third_party/six/+log/580980eb7d..98dedb5909 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/266f8e4f13..6a2c6d01f5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/700365ffd9..0b97617ee6 No update to Clang. Bug: angleproject:5038 Tbr: solti@google.com Change-Id: I4d49f4627eb677650e01c6aa325223df7e3b0d7e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6956066 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b770a628 2025-09-17T03:09:44 Manual roll VK-GL-CTS from 4dea45108845 to 7f30dc62428c (1 revision) Manual roll requested by solti@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/4dea45108845..7f30dc62428c 2025-09-12 ziga@lunarg.com Test task shader with primitive type payload If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Iec95c20589dcc903f93cc6714cecab0af9e9d063 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6956786 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kenneth Russell baeea13f 2025-09-11T10:51:33 PLS: enforce rules around color attachment 0. Generate INVALID_OPERATION during draw calls if the following two rules are not satisfied: 1. If the fragment shader declares index zero output, then attachment zero must be present, and have a compatible numeric type. 2. If attachment zero is present, it must be enabled. This avoids complex and error-prone workarounds on macOS with AMD GPUs, and enforces the same simple and consistent rules on all platforms. Bug: angleproject:402810076 Change-Id: If029f677ca645060b8e7c2c4040e8a26d2aa2eb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6937659 Reviewed-by: Chris Dalton <chris@rive.app> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 13ab9ed5 2025-09-16T08:08:46 Tests: Fix slotomania trace name Previous name had a typo in it: - slotmania -> slotomania Test: angle_trace_tests --gtest_filter=*slotomania Bug: b/445241470 Change-Id: Ie1c7f99ddf683dce7c93b394d53a4c5b90f57158 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6954868 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
angle-autoroll 4abc99e3 2025-09-16T23:17:21 Manual roll VK-GL-CTS from bf9b8e7f0a4b to 4dea45108845 (3 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/bf9b8e7f0a4b..4dea45108845 2025-09-12 marcin.zajac@cognizant.com QuerySize query check for NULL texel buffers 2025-09-12 marcin.zajac@cognizant.com Fix validation errors in draw tests 2025-09-12 piotr.byszewski@mobica.com Generate mandatory features tests using vulkan_object If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Icbcae354129b4075c7e22f72712fe614c016c6aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6956064 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton ef9c5ce4 2025-09-07T17:50:37 Add a "noncoherent" layout qualifier to PLS Raster ordering can be expensive. If an app knows the geometry in a draw does not overlap, it can mark the PLS planes as noncoherent and opt for using barriers instead. Bug: angleproject:40096838 Change-Id: I2d686c2e64f51940face186637a9fcadcc251bef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923300 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
angle-autoroll 5968f540 2025-09-16T20:21:42 Manual roll VK-GL-CTS from 12633f4f5972 to bf9b8e7f0a4b (4 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/12633f4f5972..bf9b8e7f0a4b 2025-09-12 piotr.byszewski@mobica.com Use vulkan_object.py in gen_framework 2025-09-12 jbolz@nvidia.com Add support for forcing a test group to run in fraction 0. 2025-09-11 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-09-09 lorenzo@khronosgroup.org Add -Winconsistent-missing-override If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I90773ce2123b83d43ee807bea319cb1119d167b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6953470 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roberto Rodriguez 16771259 2025-09-12T11:10:18 Update main() prototype in shader if main() has been replaced. If the main() function definition has been wrapped/replaced in a shader and a main() function prototype is also present, the prototype needs to be replaced. Otherwise it will continue to reference the replaced main() which can cause issues with shader translation steps. Bug: angleproject:444653099 Change-Id: Ie6ce85cac89e026876a1b6e25cd294f1d8a536c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6944807 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Mark Lobodzinski cf04616b 2025-09-11T12:16:54 Trace/Replay: Make SetupReplayContext(main) last in setup The SetupReplayContext function for the main context was always executed first in the main setup replay function -- move it to last to minimize issues where Frame1 is expecting specific shader state from the main context. Test: angle_trace_tests --gtest_filter=*harry_potter_magic_awakened Bug: b/445208963 Change-Id: Ia48760e704465150617ffd33d419195723a51285 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6950246 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 8e7fa804 2025-09-15T14:06:38 Check shaderFloat16 feature support for enabling Float16 in Spirv According to VK_KHR_shader_float16_int8 device extension spec: "It introduces two new optional features shaderFloat16 and shaderInt8 which directly map to the Float16 and the Int8 SPIR-V capabilities." We should check if the shaderFloat16 is supported before we generate SPIRV that declares SPIR-V Capability Float16 Bug: angleproject:405795981 Change-Id: Ied7edfbed81ed5b862907c9bb1e772cb43acdb8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6919673 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Xiang Wang <xwxw@google.com>
kmx.io     mail     discord kmxgit v0.4.0