Log

Author Commit Date CI Message
Shahbaz Youssefi 44722daa 2019-12-06T22:31:08 Vulkan: Enable inactive SSBO with unsized array tests The change introduced in https://chromium-review.googlesource.com/c/angle/angle/+/1951523 removes inactive shader interface declarations. That automatically resolves an issue where glslang wrapper doesn't handle inactive SSBO declarations with unsized arrays, by removing those declarations at translation time altogether. Bug: angleproject:3714 Change-Id: I710d59546d716bfb5bc0112b5152fed20a810a52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954615 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 7e19e25e 2019-12-16T10:59:42 Vulkan: Fix SwiftShader disabled build. Disabling SwiftShader in the GN build led to a compile error when trying to use ANGLE_VK_SWIFTSHADER_ICD_JSON. Bug: angleproject:4223 Change-Id: I076a88e6bc58adf1e34bbb7286b1f46028cd021a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969059 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi d674e1e5 2019-12-12T14:47:24 Vulkan: EXT_gpu_shader5: non-const offset in textureGatherOffset This change includes preparatory work for textureGatherOffsets as well, though that requires special handling which is addressed in a follow-up change. This special handling is due to the fact that this family of functions is the only built-in with an array parameter, and our built-in table generation doesn't handle it correctly. Bug: angleproject:3569 Change-Id: Ic1c8dd03878a184be00f578ab9fc42af8f6e47ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965435 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 634ee434 2019-12-16T11:39:10 Improve presubmit's Bug: tag check Specifying the project name is now mandatory. This helps avoid accidentally referring to chromium bugs by forgetting the project name. At the same time, it ensures the project name is not misspelled. Bug: angleproject:4184 Change-Id: I6bbfe1751e2fd0baf424be38018374cce360df5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969067 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi a5dd3888 2019-12-04T14:31:57 Vulkan: fix handling of inactive atomic counters The translator emulates atomic counters with a storage buffer array during translation to Vulkan GLSL. Glslang wrapper then should assign set/binding to this buffer. However, if the atomic counters are actually unused in the shader, this assignment is never done. This change adds a small tree transformation for Vulkan that removes any uniform or interface block declaration that's not active. In particular, this makes atomic counter emulation a no-op if no atomic counters are used. It also has the benefit of not requiring glslang wrapper to remove such inactive resources. Bug: angleproject:4190 Change-Id: I286c199854ec2379558ad1ec48b4d2c4bf5544d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1951523 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
angle-autoroll 0c14e233 2019-12-17T07:01:41 Roll third_party/spirv-tools/src 96354f5047bf..38d7fbaad0a3 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/96354f5047bf..38d7fbaad0a3 Created with: gclient setdep -r third_party/spirv-tools/src@38d7fbaad0a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I81d302d7aaf865489f50fa722791efdb5fbb6a05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1971254 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 5407aaa0 2019-12-16T15:50:12 Re-land "Add new test runner harness." (#2) Re-land #2 changes: * export labels are fixed for the CFI build * crash test disabled because of flakiness and issues with asan Re-land changes: * Unit test is suppressed in ASAN * --deqp-case is fixed * Debug layer errors should correctly work with failure expectations Original message: The ANGLE test harness is a harness around GoogleTest that provides functionality similar to the Chromium test harness. It supports: * splitting a test set into shards * catching and reporting crashes and timeouts * outputting to the Chromium JSON test results format * multi-process execution Unit tests are added in test_utils_unittest.cpp. Bug: angleproject:3162 Bug: chromium:1030192 Change-Id: I71d66a407ea0e53d73cbe75b5b4bfb9e73791534 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965091 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Brandon Schade 5cfab195 2019-10-28T09:12:53 Vulkan: Add test that logs supported texture formats Add a whitebox test to log all supported GLES formats for the active Vulkan ICD. The test object is dependent on libANGLE's gl_enum_util.* files as we need it to print out human readable values in the PrintAllFormatSupport test. Test: angle_white_box_tests --gtest_filter=*PrintAllSupportedFormats* Bug: angleproject:4093 Change-Id: I99d74935b705b2984f6320ed80a0e977c8fcd4be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1930607 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 9190f49c 2019-12-16T16:03:57 GN: Make new angle_test_utils target. This source set target lets other targets import the test utils without needing to export them. They get built into angle_util. They also get compiled into the various tests and samples. The change also fixes export issues. Moves some of the GN logic into the util/ subfolder. Bug: angleproject:3162 Bug: chromium:1030192 Change-Id: If99d201092ad8541c0de60b3bd893ac9b5875270 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1968259 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Brandon Schade 390c4952 2019-12-10T19:30:15 Adds missing extensions to registry_xml.py Bug: angleproject:4093 Change-Id: I979b54e12c1e897ccfa116f332bf9146dcd00cae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965644 Commit-Queue: Brandon Schade <b.schade@samsung.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Courtney Goeltzenleuchter ce41a43c 2019-12-16T09:49:05 Vulkan: Fix failed assert when unbinding texture We were hitting onImageStateChange with no texture active and hitting the assert in that function for needing a texture. There are times when we call onImageStateChange where there is no texture bound, early exit in those cases. Test: angle_deqp_khr_gles31_tests --user-angle=swiftshader --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_image2D_layout_binding_imageLoad_* also: --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_atomic_uint_layout_binding_atomic_ComputeShader --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_buffer_layout_binding_atomicAdd_ComputeShader --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_block_layout_binding_block_ComputeShader --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_sampler2D_layout_binding_texture_ComputeShader Bug: angleproject:4124 Change-Id: I027cf4ecb6a5d6aea874c306bf3e67b95a75af62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965027 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tobin Ehlis 5fd73782 2019-08-09T11:46:46 Vulkan: Use volk to load vk* func ptrs Thanks to Jamie Madill for some fixes to get all CI test passing w/ volk. This change updates all ANGLE targets that use Vulkan to dyanmically link all of the VK entrypoints using the volk OSS library from https://github.com/zeux/volk. It's only two source files so baking them directly into ANGLE repo. Also it's used in both the tests and libANGLE trees so added to src/common/third_party/volk dir. Updated volk and the renderer to track latest instance and device that were loaded and renderer will refresh vk* function pointers if the current and previous device and/or instance don't match. This prevents errors in the test framework as we transition between backends, especially between VK HW & SwiftShader ICDs. This change rolls the Vulkan Loader forward to use the latest loader version which no longer allows static linking but requires dynamic linking. Bug: angleproject:3740 Bug: angleproject:4092 Bug: angleproject:4162 Bug: angleproject:4210 Bug: angleproject:4225 Change-Id: I8a0b7d24c9545bbfdfaa4b9357a9bfe6793e0140 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965640 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Brandon Schade 2eeb980e 2019-12-10T12:58:13 Added enums to InternalFormat and PixelType groups in gl.xml Bug: angleproject:4093 Change-Id: Ib69f0553f79d0e5dfbcc9165ad71a42be3e6d55d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965643 Commit-Queue: Brandon Schade <b.schade@samsung.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Courtney Goeltzenleuchter 06cbb283 2019-12-11T14:46:59 Validate uniform location size, fix unlink cleanup Also cleanup shader storage blocks. Test: angle_deqp_khr_gles31_tests --use-angle=swiftshader --gtest_filter=dEQP.KHR_GLES31/core_explicit_uniform_location_uniform* Bug: angleproject:4132 Bug: angleproject:4217 Change-Id: Ie0375ab9226f3f49cb0c0d208ac08f99d98dad8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1963139 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
angle-autoroll 8f619682 2019-12-16T07:01:41 Roll third_party/SwiftShader ebb0bec91552..fbbfeb700295 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/ebb0bec91552..fbbfeb700295 git log ebb0bec91552..fbbfeb700295 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 chrisforbes@google.com Add missing source file to android build 2019-12-13 swiftshader.regress@gmail.com Regres: Update test lists @ ebb0bec9 Created with: gclient setdep -r third_party/SwiftShader@fbbfeb700295 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: I93e47bb372477b074173951ded4f0af35269e206 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969219 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d5914d97 2019-12-16T07:01:02 Roll third_party/vulkan-tools/src c1a7421f0f93..0c2618b2c31e (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c1a7421f0f93..0c2618b2c31e git log c1a7421f0f93..0c2618b2c31e --date=short --first-parent --format='%ad %ae %s' 2019-12-13 jeremyk@lunarg.com build: Update glslang version in known_good.json Created with: gclient setdep -r third_party/vulkan-tools/src@0c2618b2c31e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: Iaddfe799d5fb0e3e444eea4cc3cf4a3852be7f1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969218 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 14820b1e 2019-12-16T07:01:58 Roll third_party/vulkan-validation-layers/src d2c3daeb56e9..2b19f3916726 (10 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d2c3daeb56e9..2b19f3916726 git log d2c3daeb56e9..2b19f3916726 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 mark@lunarg.com tests: Add tests for DescTemplates fixes and new VUIDs 2019-12-13 mark@lunarg.com objlifetimes: Fix CreateDescUpdateTemplates object val 2019-12-13 mark@lunarg.com build: Update glslang & VulkanTools known-good IDs 2019-12-13 geecandrey@gmail.com corechecks: Invalid error message in vkCmdPipelineBarrier 2019-12-13 mark@lunarg.com tests: Add positive test for tooling ext query 2019-12-13 mark@lunarg.com chassis: Support tooling queries in khronos layer 2019-12-13 mark@lunarg.com chassis: Add physicaldevice support for tools info API 2019-12-13 mark@lunarg.com stateless: Update for new struct_type_array case 2019-12-13 mark@lunarg.com chassis: Implement GetPhysicalDeviceProcAddr layer func 2019-12-13 jeremyk@lunarg.com layers: Fix issue 1416 Created with: gclient setdep -r third_party/vulkan-validation-layers/src@2b19f3916726 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: Idadb73efcc3bdf73f0dfd41d4f1793eb93e3b0b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969220 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Le Hoang Quyen d1860ea1 2019-11-19T23:04:00 Metal: support OES_depth_texture Also added Depth32 & Depth16 texture data upload tests. Bug: angleproject:2634 Change-Id: I103f1cda1dc915f0dc8b04f7aaa2d8c0f9220cda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919281 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Le Hoang Quyen 75875885 2019-11-20T01:04:00 Metal: Fix glDisable(GL_DEPTH_TEST) didn't disable depth write Per standard glDisable(GL_DEPTH_TEST) will disable depth write also regardless of the value of glDepthMask() Tests done: - dEQP.GLES2/functional_fragment_ops_depth_stencil_stencil_*_no_depth Bug: angleproject:2634 Change-Id: I3b101b8c0b3060f5ddbb18d3f97d7d6889cdec01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966184 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Le Hoang Quyen 5245de82 2019-11-20T01:04:00 Metal: Update spirv-cross from upstream to fix mat2 issues Previously spirv-cross had problems translate mat2 to equivalent Metal type. See the reported issue: https://github.com/KhronosGroup/SPIRV-Cross/issues/1200 It has been fixed on upstream repo. DEQP tests using mat2 should pass now. Bug: angleproject:2634 Change-Id: I68e871965c7004ae34dc0fa92c926905cb0c14cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966183 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Peng Huang 92ba377f 2019-12-10T23:48:35 Vulkan: remove unnecessary transition of external images Since semaphore has been supported, the code for changing external texture layout and queue family is not necessary anymore. So remove them. Bug: angleproject:3289 Change-Id: I5470fa4bf7db7ee4c68f157674cf907a8e455d75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1964655 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org>
Michael Spang 7718c952 2019-12-13T16:39:15 [Fuchsia] Update FIDL library target names in ANGLE The SDK has renamed some targets, so update to the new names. Bug: chromium:1033597 Change-Id: Id346f5fb0094e4b71f8ec3b8c302eaa362529c06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1967958 Commit-Queue: Michael Spang <spang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 8b74bdc2 2019-12-10T23:15:57 Vulkan: Refactor glslang wrapper's varying location assignment Instead of multiple ifs that test for various combination of shader stages and calling AssignVaryingLocations for the appropriate pairs, that function loops over all stages and assigns a location to the varying in any stage it is active. This change will help keep this code simpler with the introduction of tessellation shaders. Bug: angleproject:3571 Change-Id: Iaf3ee67990bd219080314237b314bd2770a43085 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961096 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 19868b7e 2019-12-13T14:29:57 Restructure textureGatherOffset* builtin declarations This is in preparation of textureGatherOffsets support. Bug: angleproject:3569 Change-Id: I4ce5a1e102790181c8f843735961b9c249a69221 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965720 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b8e056dd 2019-12-11T15:02:43 Vulkan: Have the translator output in/out qualifiers Currently, when assigning varying locations, we assign in/out qualifiers based on whether the varying name is present between different shader stages. This is broken for separate shader objects as there is possibly no pair of shaders to be able to tell which is input and which is output (by trying to find the same varying in a stage before or after the shader). Bug: angleproject:3571 Change-Id: Id928a3eaa16e917c81bae0b3414c41842eb2b664 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961993 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi e181f2f7 2019-12-10T22:57:42 Validate that image array indices are constant Also adds compiler tests for dynamic indexing of SSBOs and images. Bug: angleproject:3569 Change-Id: I84b90813840ffad5a9a3cd8e7f12bd637a57b327 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961095 Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Renaud Lepage bf47a17e 2019-12-13T01:40:33 Fix GGP build Bug: angleproject:4221 Change-Id: I625b78795dbc826d176660e47af9b51d3f8d417b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966410 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll e1822727 2019-12-13T07:01:58 Roll third_party/vulkan-validation-layers/src 6a35bc9967d9..d2c3daeb56e9 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6a35bc9967d9..d2c3daeb56e9 git log 6a35bc9967d9..d2c3daeb56e9 --date=short --first-parent --format='%ad %ae %s' 2019-12-12 jzulauf@lunarg.com layers: Improve const shared pointer handling 2019-12-12 mark@lunarg.com corechecks: Correct swapchain validation error text 2019-12-12 tony@lunarg.com gpu: Add validation for VK_KHR_buffer_device_address Created with: gclient setdep -r third_party/vulkan-validation-layers/src@d2c3daeb56e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: Iafb69556fd7a48e7df8e1f08d8f38fd23a659f9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966026 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f139f976 2019-12-13T07:01:41 Roll third_party/SwiftShader 07958d452f93..ebb0bec91552 (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/07958d452f93..ebb0bec91552 git log 07958d452f93..ebb0bec91552 --date=short --first-parent --format='%ad %ae %s' 2019-12-12 sergeyu@chromium.org Use allocateExecutable() in LLVMReactor 2019-12-12 sugoi@google.com Fix BCn related SwANGLE test failure 2019-12-12 capn@google.com Prevent clang-format from splitting shift operator 2019-12-12 sugoi@google.com Support for BC1, BC2, BC3, BC4 and BC5 Created with: gclient setdep -r third_party/SwiftShader@ebb0bec91552 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: If0eb478a35cabd6c09007f70a75dad0757749605 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966024 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 06db147e 2019-12-13T07:01:40 Roll third_party/spirv-tools/src 5c019b5923c1..96354f5047bf (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5c019b5923c1..96354f5047bf Created with: gclient setdep -r third_party/spirv-tools/src@96354f5047bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: Ia02eda3a904131e1efa5f401e6259e09bf9848a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966023 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ef11f849 2019-12-13T07:01:56 Roll third_party/glslang/src 6c479796f6e4..ebf634bcaa3e (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6c479796f6e4..ebf634bcaa3e Created with: gclient setdep -r third_party/glslang/src@ebf634bcaa3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: I5d36e291b54c1d57688e413a9b8e6a794b15277f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966025 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 1d77542f 2019-12-03T15:54:41 Add flag to label captures Add an optional parameter (ANGLE_CAPTURE_LABEL) to ANGLE frame capture that tags files and functions uniquely, allowing multiple frame captures to be replayed by a test harness. Example: ANGLE_CAPTURE_LABEL=foo Results in filenames like this: foo_capture_context1.cpp foo_capture_context1.h foo_capture_context1_files.txt foo_capture_context1_frame000.angledata foo_capture_context1_frame000.cpp foo_capture_context1_frame001.angledata foo_capture_context1_frame001.cpp ... Functions wrapped in namespaces like this: namespace foo { void ReplayContext1Frame0(); void ReplayContext1Frame1(); } For use like this: foo::SetupContext1Replay(); for (...) { foo::ReplayContext1Frame(i); } Bug: angleproject:3630 Change-Id: Ibe27dc4d40a36606ee40678a9e4d43b5a4baf976 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1949603 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 554b453c 2019-12-12T13:09:30 gn: Add 'test_only' label to util targets. Clarifies that angle_util is only used in tests and samples. Bug: angleproject:3162 Change-Id: I9a578cf7a9a09b2c3fd4683155824ed2e72f68cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1964934 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 270e2e88 2019-12-12T13:08:08 util: Always export default visibility. This should fix the CFI build compatibility with class exports. Bug: chromium:1030192 Bug: angleproject:3162 Change-Id: I228d6d387f8b29c0a500038de962f9f216454d7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1964933 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e0f8b5d0 2019-12-12T14:58:12 Roll chromium_revision d209d45ba4..e1633af636 (719599:724302) Change log: https://chromium.googlesource.com/chromium/src/+log/d209d45ba4..e1633af636 Full diff: https://chromium.googlesource.com/chromium/src/+/d209d45ba4..e1633af636 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ebec9c5ad4..dfe5662014 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/72e16daaa5..c1b508625d * third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/60616473f7..f8eeeb06c0 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e77e1c06c8..f262c1b3c4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/05979d8cad..a9190d6699 DEPS diff: https://chromium.googlesource.com/chromium/src/+/d209d45ba4..e1633af636/DEPS Clang version changed e84b7a5fe230e42b8e6fe451369874a773bf1867:c2443155a0fb245c8f17f2c1c72b6ea391e86e81 Details: https://chromium.googlesource.com/chromium/src/+/d209d45ba4..e1633af636/tools/clang/scripts/update.py TBR=jmadill@chromium.org, BUG=None Change-Id: I3e2d6b59263870a6713b8e3d2161c2411b932cf1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965436 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 0bf3c4b5 2019-12-12T07:01:02 Roll third_party/vulkan-tools/src 0dc201a808ec..c1a7421f0f93 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/0dc201a808ec..c1a7421f0f93 git log 0dc201a808ec..c1a7421f0f93 --date=short --first-parent --format='%ad %ae %s' 2019-12-11 charles@lunarg.com build: update vulkaninfo.hpp to fix windows build warnings 2019-12-11 mark@lunarg.com build: Update to verson 1.1.130 of the Vulkan Headers 2019-12-11 charles@lunarg.com vulkaninfo: reduced spurious warnings for msvc Created with: gclient setdep -r third_party/vulkan-tools/src@c1a7421f0f93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: Id6562a8b6967909c70aef10ea8f6c9fead24c0c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1963622 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e2d7cbf6 2019-12-12T07:01:40 Roll third_party/spirv-tools/src 00ca4e5bdfdb..5c019b5923c1 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/00ca4e5bdfdb..5c019b5923c1 Created with: gclient setdep -r third_party/spirv-tools/src@5c019b5923c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: I58aada86788183ec7904ec51e8a68df29c77f2b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1963623 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d5ac2e89 2019-12-12T07:01:58 Roll third_party/vulkan-validation-layers/src da451cc7cd04..6a35bc9967d9 (6 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/da451cc7cd04..6a35bc9967d9 git log da451cc7cd04..6a35bc9967d9 --date=short --first-parent --format='%ad %ae %s' 2019-12-12 jbolz@nvidia.com tests: Add tests for VK_KHR_buffer_device_address 2019-12-12 jbolz@nvidia.com layers: Add VK_KHR_buffer_device_address support 2019-12-11 tobias.hector@amd.com tests: Added tests for new vkAllocateMemory validation 2019-12-11 tobias.hector@amd.com layers: Introduce validation for vkAllocateMemory VUIDs 2019-12-11 jeremy@lunarg.com tests: Test overlapping push constant ranges 2019-12-11 jeremy@lunarg.com corechecks: Fix overlapping push constant ranges Created with: gclient setdep -r third_party/vulkan-validation-layers/src@6a35bc9967d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: Ib8f078d1fb93bee521567b67fa87c6ccc078eaaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1963625 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 62602e94 2019-12-12T07:01:41 Roll third_party/SwiftShader 544ae91ee039..07958d452f93 (10 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/544ae91ee039..07958d452f93 git log 544ae91ee039..07958d452f93 --date=short --first-parent --format='%ad %ae %s' 2019-12-12 bclayton@google.com src/Vulkan/Debug: Add scope for case block 2019-12-11 bclayton@google.com Vulkan/Debug: Add Server 2019-12-11 bclayton@google.com Vulkan/Debug: Add Context 2019-12-11 bclayton@google.com Tweaks to make clang-format produce better code 2019-12-11 amaiorano@google.com Add EmulatedReactor.cpp to Subzero.vcxproj 2019-12-11 bclayton@google.com Regres: Fix debug macro detection 2019-12-11 capn@google.com Do not indent C++ namespace contents 2019-12-11 bclayton@google.com Vulkan: Add description methods to all commands. 2019-12-11 bclayton@google.com .vscode: Add cppdap to includePath 2019-12-11 swiftshader.regress@gmail.com Regres: Update test lists @ 544ae91e Created with: gclient setdep -r third_party/SwiftShader@07958d452f93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: I5576ab6409124dd99dd903c949598797479894cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1963624 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 6381d7f1 2019-12-10T23:19:23 Vulkan: Avoid linear search in shader on varying location assignment Glslang wrapper was trying to identify whether the varying is declared in each of the out/in shaders by looping through the macro symbols that need replacement. This change instead adds stage information to PackedVarying assigned when collecting varyings. Glslang wrapper then simply tests the bitfield for the stages of interest. Bug: angleproject:3571 Change-Id: I29614e3e62d7df88e413c1732ac04e24243f167a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954677 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 3c75d244 2019-12-11T15:52:14 Suppress more dEQP-GLES31.functional.shaders.helper_invocation.* tests Failures discovered when running locally on Pixel 2 with recent OS. Bug: angleproject:4110 Change-Id: I14cde5456a0d7802c60ed3bc771fc371b0834087 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1962541 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
James Darpinian 4dff9956 2019-12-10T17:05:37 Presubmit check forbidding tab characters in source files. WebKit's Subversion repository forbids tab characters in source files. Follow-up to: https://chromium-review.googlesource.com/c/angle/angle/+/1954410 Bug: angleproject:3439 Change-Id: I7ab170cae6985c62ee2f163c15d2746f620fe648 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959750 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi 49135f68 2019-12-10T11:27:09 Vulkan: Fix descriptor pool init in presence of atomic counters The descriptor pool was initialized with the number of atomic counter buffers, but we always use 8 storage buffers for atomic counter buffer emulation regardless of how many atomic counter buffers there. This change fixes the descriptor pool initialization by requesting 8 storage buffer descriptors if there are any atomic counter buffers. Bug: angleproject:4199 Change-Id: Ide58c013cba8ac46228dba795a82304b97ee83ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959489 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi e4eb75da 2019-12-06T11:10:47 Vulkan: EXT_gpu_shader5 support: dynamically uniform indexing Bug: angleproject:3569 Change-Id: I5abb7f2889fa5173457497d4156a3dadbcf77640 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954613 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Ian Elliott fa467885 2019-12-11T06:31:36 Vulkan: Update Linux-specific multisample failures Bug: angleproject:3565 Change-Id: I429268ba679dff924b229d289ced7148c1d86fdb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961594 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Courtney Goeltzenleuchter 4ad8b55e 2019-12-03T10:07:41 Return valid qualifier after error Using EvqLast for the variable causes us to hit an assert in sh::getQualifierString when we try to print a later error message. Just use the appropriate qualifier regardless that it's not valid for a compute shader, we've output the error. Bug: angleproject:4187 Change-Id: If6fa5dea07d7b6e0d3307485f41d59c5ea7f1c4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948525 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 1ed23f2d 2019-12-11T07:01:02 Roll third_party/vulkan-tools/src 5ceb7be9a3bf..0dc201a808ec (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/5ceb7be9a3bf..0dc201a808ec git log 5ceb7be9a3bf..0dc201a808ec --date=short --first-parent --format='%ad %ae %s' 2019-12-10 jeremyk@lunarg.com vulkaninfo: Add VK_EXT_metal_surface info 2019-12-10 jeremyk@lunarg.com windows: Change winrt name 2019-12-10 slawomir.cygan@intel.com vulkaninfo: load user32.dll dynamically Created with: gclient setdep -r third_party/vulkan-tools/src@0dc201a808ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: I6dc514f4bb5718acc6d344870fc936f7c1274a8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961569 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ac107569 2019-12-11T07:01:58 Roll third_party/vulkan-validation-layers/src a749c31b749b..da451cc7cd04 (5 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a749c31b749b..da451cc7cd04 git log a749c31b749b..da451cc7cd04 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 mark@lunarg.com layers: Remove vuid mapping file 2019-12-10 mark@lunarg.com build: Update for 1.1.130 version of Vulkan header 2019-12-10 mark@lunarg.com tests: Fix stray VUID ref in buffer_image_memory_sampler 2019-12-10 mark@lunarg.com tests: Fix stray VUID refs in positivelayertests 2019-12-10 mark@lunarg.com corechecks: Fix incorrect CmdSetViewportWScalingNV names Created with: gclient setdep -r third_party/vulkan-validation-layers/src@da451cc7cd04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: I5e2f985bf0066e5249dfd79c17ba3a5af413fb29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961572 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 11c42996 2019-12-11T07:01:42 Roll third_party/SwiftShader 31916f494c2e..544ae91ee039 (29 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/31916f494c2e..544ae91ee039 git log 31916f494c2e..544ae91ee039 --date=short --first-parent --format='%ad %ae %s' 2019-12-11 capn@google.com Enable vk-unittests with Subzero JIT 2019-12-10 bclayton@google.com Kokoro: Split tests into Debug and RelWithDebInfo 2019-12-10 chrisforbes@google.com Accept ImageCubeArray SPIRV capability 2019-12-10 bclayton@google.com Vulkan/Debug: Add Thread and EventListener 2019-12-10 bclayton@google.com Vulkan/Debug: Add Location 2019-12-10 bclayton@google.com Vulkan/Debug: Add File 2019-12-10 bclayton@google.com Vulkan/Debug: Add WeakMap 2019-12-10 bclayton@google.com Vulkan/Debug: Add Value and Variable 2019-12-10 bclayton@google.com Vulkan/Debug: Add Type 2019-12-10 bclayton@google.com CMakeLists: Fix logic of BUILD_CPPDAP 2019-12-10 swiftshader.regress@gmail.com Regres: Update test lists @ d00dfe49 2019-12-10 chrisforbes@google.com Advertise VK_PRESENT_MODE_MAILBOX_KHR 2019-12-10 bclayton@google.com Regres: Reduce scope of regres CI emails 2019-12-10 amaiorano@google.com Fix REACTOR_DEFAULT_OPT_LEVEL not actually applying 2019-12-10 capn@google.com Remove Visual Studio Vulkan project files 2019-12-10 bclayton@google.com Vulkan/Debug: Add ID 2019-12-09 chrisforbes@google.com Remove Float->UInt conversion workaround 2019-12-09 capn@google.com Add Float to UInt unit test 2019-12-09 amaiorano@google.com Add REACTOR_DEFAULT_OPT_LEVEL macro 2019-12-09 amaiorano@google.com Subzero: fix alloca return address allocation 2019-12-09 amaiorano@google.com Subzero: proper fix for assert(Dest->hasReg()) 2019-12-09 bclayton@google.com CMakeLists: Add CMake rules for Vulkan debugger 2019-12-09 bclayton@google.com Add github.com/google/cppdap as a third_party dependency 2019-12-09 bclayton@google.com Add github.com/nlohmann/json as a third_party dependency 2019-12-09 capn@google.com Enforce int and short to be 32- and 16-bit respectively 2019-12-09 sugoi@google.com Cubemap array support 2019-12-09 amaiorano@google.com Revert "Fix materialization of function arguments" 2019-12-09 bclayton@google.com Kokoro: Add ReactorUnitTests to windows presubmits 2019-12-09 capn@google.com Remove coverage asserts for tested code Created with: gclient setdep -r third_party/SwiftShader@544ae91ee039 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: Icc4faea0596e4e01d0d997a2d2d0a07aa1d993cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961571 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e5c2089f 2019-12-11T07:01:41 Roll third_party/spirv-tools/src 983b5b4fccea..00ca4e5bdfdb (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/983b5b4fccea..00ca4e5bdfdb Created with: gclient setdep -r third_party/spirv-tools/src@00ca4e5bdfdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: If27692a6f0255eecb19794c13d3f4b3e4d6ad6eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961570 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
James Darpinian d6053daa 2019-12-05T17:46:23 Remove tabs from source files. WebKit's Subversion repo refuses to commit source files that contain tabs. Bug: angleproject:3439 Change-Id: I0a804bcfa0375a98e19945e20297c90d31106827 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954410 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Hyunchang Kim caa6eccd 2019-10-27T13:46:56 Vulkan: Implement Transform Feedback support via extension Implemented transform feedback extension path. Where VK_EXT_transform_feedback is supported, extension path will be taken over an emulation path. Extension path has advantages in terms of performance. BUG=angleproject:3206 Test: dEQP-GLES3.functional.transform_feedback.* angle_end2end_tests --gtest_filter=TransformFeedbackTest* Change-Id: Ia07c23afb289d9c67073469a97b714ec96f5265a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1882767 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll ccea6b5b 2019-12-10T08:35:56 Roll third_party/glslang/src d519167d2ecb..6c479796f6e4 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d519167d2ecb..6c479796f6e4 Created with: gclient setdep -r third_party/glslang/src@6c479796f6e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: I0a2e7eff7a803818df5ad331b5ff0fe75eb83588 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959779 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4059f49c 2019-12-10T07:01:58 Roll third_party/vulkan-validation-layers/src f34b9fb086b3..a749c31b749b (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f34b9fb086b3..a749c31b749b git log f34b9fb086b3..a749c31b749b --date=short --first-parent --format='%ad %ae %s' 2019-12-10 tony@lunarg.com tests: Add pos test for GetProcAddr with extensions 2019-12-10 tony@lunarg.com layers: Fix GetProcAddr for promoted extensions 2019-12-09 shannon@lunarg.com build: Update known-good for 1.1.129 Vulkan header Created with: gclient setdep -r third_party/vulkan-validation-layers/src@a749c31b749b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: I34b27bb71b6806f20019976863dd7760c9fed0cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959774 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott 9906bccc 2019-12-10T09:59:17 Vulkan: Update bugs for multisample texture failures After additional debugging, new bugs were filed and bug numbers were updated. Bug: angleproject:3565 Bug: angleproject:4197 Bug: angleproject:4212 Bug: angleproject:4213 Change-Id: I7211df7d19280f2fba482394c23a887e6ea5e002 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959490 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 9af3e137 2019-12-05T15:35:33 Vulkan: EXT_gpu_shader5 support: fma Add the fma() builtin function to ESSL. Bug: angleproject:3569 Change-Id: Ic8419b4c117ecdd8b47aa733bf7aff9ee7579bbf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954484 Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
David Benjamin 351307eb 2019-12-10T10:47:41 Fix potential indexing into an empty vector in ANGLE tests The tests are failing after "Warning: incomplete system info collection" which suggests systemInfo.gpus is empty. Check for that before indexing into the vector; defaulting the active index to zero in https://chromium-review.googlesource.com/c/angle/angle/+/1925031 was not sufficient and the line still needs a bounds check. Bug: chromium:923166, chromium:1032552 Change-Id: Ic9716830403e0dfcfa5d11539537c2a39e0e2386 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959488 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Brandon Schade 3eaf6294 2019-11-25T18:08:18 Vulkan: Add options to select more device types Add support to set a default device type using existing ANGLE_DEFAULT_PLATFORM environment variable. The valid vulkan options are as follows: vulkan - vulkan with device hardware vulkan-null - vulkan with null device (Mock ICD) swiftshader - vulkan with swiftshader Bug: angleproject:3998 Change-Id: I15f00e8024818fbaf674ca6fcdbcdac5a90cace2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1956140 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
David Benjamin f60da874 2019-11-19T18:45:45 Fix out-of-bounds access bug in ANGLE tests When not filled in, as in Android, activeGPUIndex is -1. This is fine for Android because it doesn't use vendorID, but the function computed vendorID unconditionally without checking for -1. Default activeGPUIndex to 0 instead of -1. Note code still needs to check for systemInfo.gpus.empty(). This caused crashes when _LIBCPP_DEBUG=0 was enabled. Bug: chromium:923166 Change-Id: If4d1dff9553a580fd92bc0497fc092789d07ed93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1925031 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jonah Ryan-Davis 6e4004dd 2019-12-06T14:41:17 Add metal display type to angle_deqp_tests Adds --deqp-egl-display-type=angle-metal for running the deqp tests on Mac. Note: does not add any test suppressions for metal. Bug: angleproject:2634 Change-Id: I8f8d3a83cf93a5b930b05af9f0075a9ce435823a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954612 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 01553e0e 2019-12-09T08:25:48 Roll third_party/vulkan-headers/src 2b89fd4e2734..0e57fc1cfa56 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/2b89fd4e2734..0e57fc1cfa56 git log 2b89fd4e2734..0e57fc1cfa56 --date=short --first-parent --format='%ad %ae %s' 2019-12-09 oddhack@sonic.net Update for Vulkan-Docs 1.1.130 Created with: gclient setdep -r third_party/vulkan-headers/src@0e57fc1cfa56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=ianelliot@google.com Bug: None Change-Id: Ie028ebf3b6be0b833e980658b755ef428250614c Tbr: ianelliot@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957400 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5a1add39 2019-12-09T07:02:41 Roll third_party/SwiftShader b9f03f47d5f5..31916f494c2e (7 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/b9f03f47d5f5..31916f494c2e git log b9f03f47d5f5..31916f494c2e --date=short --first-parent --format='%ad %ae %s' 2019-12-07 digit@google.com [Subzero] Remove assert that breaks Shuffle operations. 2019-12-06 bclayton@google.com SpirvShader: Use struct for MemoryVisitor callback. 2019-12-06 bclayton@google.com Regres: Update dEQP to include fence timeout fix. 2019-12-06 bclayton@google.com Vulkan: Tidy VkCommandBuffer.cpp 2019-12-06 bclayton@google.com Reactor: Rename Blend() to Shuffle() 2019-12-06 swiftshader.regress@gmail.com Regres: Update test lists @ b9f03f47 2019-12-06 bclayton@google.com Reactor: Switch swizzles over to 16-bit hex codes Created with: gclient setdep -r third_party/SwiftShader@31916f494c2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Icfd2b4304841ad6d7b419d5c7d5d477faef45505 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957973 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d7967b83 2019-12-09T08:42:57 Roll third_party/glslang/src 0de87ee9a5bf..d519167d2ecb (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0de87ee9a5bf..d519167d2ecb Created with: gclient setdep -r third_party/glslang/src@d519167d2ecb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: I29c4f44ed84166120a14025a16913a64782e4d4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1956491 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d94856d0 2019-12-09T07:01:58 Roll third_party/vulkan-validation-layers/src a3ee4384fb57..f34b9fb086b3 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a3ee4384fb57..f34b9fb086b3 git log a3ee4384fb57..f34b9fb086b3 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 jeremy@lunarg.com Remove default initialized push constant ranges 2019-12-06 mark@lunarg.com tests: Add imageless framebuffer positive test 2019-12-06 mark@lunarg.com statetracker: Avoid bad derefs for imageless framebuffer cases Created with: gclient setdep -r third_party/vulkan-validation-layers/src@f34b9fb086b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ib392ee963d7390a4584d0b0c2f6504cacb5e6d2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957971 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 64860e76 2019-12-09T07:02:40 Roll third_party/spirv-tools/src e82a428605f6..983b5b4fccea (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e82a428605f6..983b5b4fccea Created with: gclient setdep -r third_party/spirv-tools/src@983b5b4fccea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ie7e4e811857bf0d2113ada42b723e46e2e351c3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957972 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a42b6db1 2019-12-09T07:01:02 Roll third_party/vulkan-tools/src 0a0625a3dca6..5ceb7be9a3bf (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/0a0625a3dca6..5ceb7be9a3bf git log 0a0625a3dca6..5ceb7be9a3bf --date=short --first-parent --format='%ad %ae %s' 2019-12-06 tony@lunarg.com Revert "cube: Port Wayland impl from wl-shell to xdg-shell" Created with: gclient setdep -r third_party/vulkan-tools/src@5ceb7be9a3bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I601964651ce3e66680e00c5d1cce20811b8eeb4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957968 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 27c89d2b 2019-11-25T10:22:01 Vulkan: fix BufferVk::map() synchronization 4398b2b6a2ac13034dff249d8c049c4047b5fed2 made finishToSerial() in BufferVk::map() conditional to whether the serial is in use to work around a performance regression. Notes: - Prior to 087f1384f233792921d34c0ca5b5a90fac75b070, finishToSerial already did that, but that check was inadvertently removed. - finishToSerial waits for the smallest serial that's bigger than or equal to the requested serial. - The flush() call in BufferVk::map() was conditional to whether the serial is in use, but it really meant to check whether the buffer has pending commands in the graph. The end result is that there was an unnecessary flush in BufferVk::map() if we had to wait for a previous serial to finish. This change makes the flush conditional to whether the buffer has pending commands in the graph, and the finishToSerial call to whether the serial is not yet finished. Bug: angleproject:3994 Change-Id: Idca436ef2439bcc8c59396a07b2591c1dfadd669 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1932341 Reviewed-by: Brandon Schade <b.schade@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Xinyi He 36ab960e 2019-12-04T14:13:05 Vulkan: Resize the result vector in EGLChooseConfigTest end2end test Resize the defaultConfigs vector to its actual size to avoid using nullptr elements to get attributes. BUG=angleproject:4195 Change-Id: I3cbad9ee8c2c9faeaa30f72a04cf2c071f79db19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1949985 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Ian Elliott 92183a26 2019-12-06T11:27:33 Vulkan: Latest Intel driver fixes 2-sample standard positions Update the expectations file to expect these to pass on all Vulkan drivers now. Bug: angleproject:4198 Change-Id: I38982db1e23706f0063795757dfe1d8c8c45294a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1955697 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Ian Elliott c6458072 2019-12-05T11:45:10 Fix multisample renderbuffer compliance (e.g. 3->4 samples) This change ensures that the following spec language is correctly implemented: the resulting value for RENDERBUFFER_SAMPLES is guaranteed to be greater than or equal to samples and no more than the next larger sample count supported by the implementation. For example, if 2, 4, and 8 samples are supported, and if 5 samples are requested, ANGLE should use 8 samples, and return 8 when GL_RENDERBUFFER_SAMPLES is queried. Note: There is a known problem with NVIDIA OpenGL driver that causes another test to be expected to fail. Bug: angleproject:2222 Bug: angleproject:4196 Change-Id: I28921badf9568427799b0af347198b5df06c2aaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954444 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Jonah Ryan-Davis 63c15519 2019-12-05T12:59:13 Also use GL_RENDERER to determine vendorID ~10% or more Linux users* do not have AMD/ATI in the GL_VENDOR, only in GL_RENDERER. Our heuristics only checked GL_VENDOR, so this CL adds GL_RENDERER to the string being checked to find the vendor ID. (*According to https://feedback.wildfiregames.com/report/opengl/feature/GL_VENDOR) Bug: angleproject:4204 Change-Id: Ie89080b4431fdf02a4ca09709973ea3f271a3e84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953486 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill b92ec244 2019-12-06T15:08:54 Revert "Re-land "Add new test runner harness."" This reverts commit e20560faf1de86c01198143ef7733a12a098a90b. Reason for revert: Now fails on Linux CFI and also is a bit flaky. Original change's description: > Re-land "Add new test runner harness." > > Re-land changes: > > * Unit test is suppressed in ASAN > * --deqp-case is fixed > * Debug layer errors should correctly work with failure expectations > > Original message: > > The ANGLE test harness is a harness around GoogleTest that provides > functionality similar to the Chromium test harness. It supports: > > * splitting a test set into shards > * catching and reporting crashes and timeouts > * outputting to the Chromium JSON test results format > * multi-process execution > > Unit tests are added in test_utils_unittest.cpp. > > Bug: angleproject:3162 > Change-Id: I841f2b5dfe51f7f44dac68324bdf6afd418b8bfb > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948240 > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=ynovikov@chromium.org,ianelliott@google.com,jonahr@google.com,jmadill@chromium.org Change-Id: Ibfd65b8b18ead3a232abb6cb75fd6489b0ff5f38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:3162 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954570 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Josh Matthews 732c9d02 2019-11-29T13:59:03 Add /APPCONTAINER linker flag to shared libraries in UWP builds. Bug: angleproject:4181 Change-Id: I6940d5605e85bcf923b201be0f0f2b1f61c30ed5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1944463 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll eef22131 2019-12-06T07:01:42 Roll third_party/SwiftShader bbd0694f9ab2..b9f03f47d5f5 (18 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/bbd0694f9ab2..b9f03f47d5f5 git log bbd0694f9ab2..b9f03f47d5f5 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 digit@google.com [vulkan] Add VK_SUBGROUP_FEATURE_ARITHMETIC_BIT support 2019-12-05 bclayton@google.com Vulkan: Optimize shaderClipDistance and shaderCullDistance 2019-12-05 bclayton@google.com Vulkan: Implement shaderClipDistance and shaderCullDistance 2019-12-05 paulthomson@google.com Regres: support GCOV_PREFIX for collecting coverage 2019-12-05 chrisforbes@google.com Regres: update testlists for recent deqp roll 2019-12-05 chrisforbes@google.com Regres: Adjust exit code handling 2019-12-05 digit@google.com [vulkan] Clarify configuration macros for external memory and semaphores. 2019-12-05 amaiorano@google.com ReactorUnitTests: add unit tests for intrinsics 2019-12-05 amaiorano@google.com SubzeroReactor: implement most missing intrinsics 2019-12-05 amaiorano@google.com SubzeroReactor: add stubbed coroutine support 2019-12-05 amaiorano@google.com Subzero: fix assert for sqrt of vector float types 2019-12-05 amaiorano@google.com Subzero: hack fix for assert(Dest->hasReg()) 2019-12-05 amaiorano@google.com SubzeroReactor: fix assertion !isVectorType(Ty) 2019-12-05 amaiorano@google.com Subzero: fix assert when dumping unnamed constant 2019-12-05 chrisforbes@google.com Regres: roll deqp forward to current tip of 1.1.6 2019-12-04 sugoi@google.com Enable the fullDrawIndexUint32 feature 2019-12-04 swiftshader.regress@gmail.com Regres: Update test lists @ bbd0694f 2019-12-04 bclayton@google.com VulkanUnitTests: Fix bad comment on assembly. Created with: gclient setdep -r third_party/SwiftShader@b9f03f47d5f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I720c9e121605054c30570ccfe8f83678d4b1262b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1955230 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b2c2d667 2019-12-06T07:01:58 Roll third_party/vulkan-validation-layers/src e72b61c7c20d..a3ee4384fb57 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e72b61c7c20d..a3ee4384fb57 git log e72b61c7c20d..a3ee4384fb57 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 mark@lunarg.com tests: Add tests for CmdFillBuffer offset and size 2019-12-05 mark@lunarg.com corechecks: Add offset/size checks for CmdFillBuffer Created with: gclient setdep -r third_party/vulkan-validation-layers/src@a3ee4384fb57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I175ccbba8eaf3d5c79b397422c7c32d64de8ef3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1955231 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jonah Ryan-Davis 11e6944e 2019-12-05T13:12:10 Linux AMD crash when src blit region outside framebuffer Linux AMD has a crash on an assert in the mesa driver that the source rectangle for blitFramebuffer be inside the framebuffer. Add Linux AMD to the existing workaround for this case. Note: this will duplicate some work on Linux AMD if the blit call is outside the framebuffer and also very large (the adjustSrcDstRegionBlitFramebuffer workaround) Bug: 1014370 Change-Id: I1afd1c92ab07dba6814d6b87ff7c3c19a19bdc0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953487 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Ian Elliott 4576f1d0 2019-12-05T10:10:48 Vulkan: Implement multisample textures This functionality is exercised by running angle_deqp_gles31_tests with the following sets of command arguments: --gtest_filter=dEQP.GLES31/functional_texture_multisample* --use-angle=vulkan --gtest_filter=dEQP.GLES31/functional_state_query_texture_level_texture_2d_multisample* --use-angle=vulkan --gtest_filter=dEQP.GLES31/functional_state_query_texture_texture_2d_multisample_texture_immutable* --use-angle=vulkan The following are some high-level design notes: - Texture::setStorageMultisample() handles converting the "requested number of samples" to the actual number of samples used (e.g. converting 3 to 4), supported by the underlying back-end). The actual number used is stored in gl::TextureState::mImageDescs, for use by other GLES commands. - ANGLE uses the Vulkan standard sample locations/positions. If the underlying Vulkan driver's VkPhysicalDeviceLimits::standardSampleLocations is false, ANGLE limits itself to GLES 2.0 (i.e. before GLES 3.0 which adds multisample renderbuffers). - The Vulkan specification currently doesn't support ANGLE providing support for GLES 1-sample textures, because of the following Vulkan specification statement: - If the image was created with VkImageCreateInfo::samples equal to VK_SAMPLE_COUNT_1_BIT, the instruction must: have MS = 0. - At least one Vulkan driver returns different VkPhysicalDeviceLimits::*SampleCounts for different formats. Because of this, ANGLE does a logical-AND of all values in order to only support the commonly-available numbers of samples. The detailed design document is located at: https://docs.google.com/document/d/1NiM8gAR74iGGXGTE6IP1ChdDUZjhtXRuJdtEp_wGFEM/edit?usp=sharing Bug: angleproject:3565 Bug: angleproject:4103 Bug: angleproject:4104 Bug: angleproject:4196 Bug: angleproject:4197 Bug: angleproject:4198 Change-Id: I28921badf9568427799b0af347198b5df06c2db0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919982 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d68bf3e2 2019-12-04T12:30:56 Fix image/sampler uniform range in presence of atomic counters The change that introduced images to the front-end placed them at the end of the uniforms list, so the loop that was calculating the image range was starting from the end of that list. The change that introduced atomic counters to the front-end placed them at the end of the uniforms list too, but the image range loop was not adjusted to take this fact into account (neither was the sampler range loop for that matter). If a shader used both images and atomic counter buffers, the image range was calculated as empty. Similar issues would arise if the shader used both samplers and atomic counters. A test is added where a shader has a default uniform, a UBO, an SSBO, an image and an atomic counter, to make sure any combination of these resources doesn't result in a bug. Bug: angleproject:4190 Change-Id: I7818ee5258dd964215a18acfd7c3d6515b61c595 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950655 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi 6e532b8c 2019-12-05T11:16:16 Fix compute shared memory size validation When a struct was involved, the required size for each field was added up, but also multiplied by its array size. However, when calculating the field size, the array size was already multipled in. This resulted in the calculated size to be larger than it actually is, resulting in failures in KHR-GLES31.core.compute_shader.shared-max. Bug: angleproject:4173 Change-Id: I900c17fa65decdeb20c3651c3342295fed2f7c61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953483 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 795a3559 2019-12-03T11:31:18 Vulkan: EXT_gpu_shader5 support: precise The precise keyword is used in tessellation shaders but introduced in this extension. EXT_gpu_shader5 introduces a handful of features to shaders. This change only implements the `precise` keyword. Bug: angleproject:3569 Change-Id: I2252b79098eb8ba2d2faa040d7eaed7548b7051e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1939851 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill e20560fa 2019-12-04T13:18:36 Re-land "Add new test runner harness." Re-land changes: * Unit test is suppressed in ASAN * --deqp-case is fixed * Debug layer errors should correctly work with failure expectations Original message: The ANGLE test harness is a harness around GoogleTest that provides functionality similar to the Chromium test harness. It supports: * splitting a test set into shards * catching and reporting crashes and timeouts * outputting to the Chromium JSON test results format * multi-process execution Unit tests are added in test_utils_unittest.cpp. Bug: angleproject:3162 Change-Id: I841f2b5dfe51f7f44dac68324bdf6afd418b8bfb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948240 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi af52f9c6 2019-12-03T14:11:17 Fix tests checking for major version > 3 The tests meant to do getClientMajorVersion() >= 3, but in a few locations accidentally did > 3. Bug: angleproject:3569 Change-Id: Ie69898348982c6aae7dac265a18229c257dbfbda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947458 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 362168eb 2019-12-05T07:01:56 Roll third_party/glslang/src e58c080d4f02..0de87ee9a5bf (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e58c080d4f02..0de87ee9a5bf Created with: gclient setdep -r third_party/glslang/src@0de87ee9a5bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I8ff675710626a7197a71abb386b2b4013f27c30f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1952391 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott 5f857839 2019-12-04T15:30:50 Improve current multisampled renderbuffer/texture support This is split off from a change to implement multisampled textures for the Vulkan back-end, and will come before that change. The changes include: - Make a common utility rx::GetSamplePosition() function. D3D11 and Vulkan use the same standard sample positions/locations for 1, 2, 4, 8, and 16 samples. The D3D11 back-end has a utility function for this, which is being moved to a common location--for use by both the D3D11 and Vulkan back-ends. - Texture::setStorageMultisample() handles converting the "requested number of samples" to the actual number of samples used (e.g. converting 3 to 4), supported by the underlying back-end). The actual number used is stored in gl::TextureState::mImageDescs, for use by other GLES commands. - Change some end2end tests to not make assumptions about the supported number of samples, but to properly query what is supported. Bug: angleproject:3565 Bug: angleproject:4196 Change-Id: I1dc12fedd0f8fb4975f90d87486e443b069b7141 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948535 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 2719fa44 2019-12-04T15:05:57 Remove build_apk_secondary_abi from gn files This flag is always true now and is being removed from GN. Bug: angleproject:4026 Bug: angleproject:2344 Change-Id: I7e90d95a41cd4a9e054e3e102578db3323e999e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1951525 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill e3c25715 2019-12-03T14:08:36 gn: Minor improvements. Renaming "all" targets to reduce duplication. Also add libGLESv1_CM to "angle". And remove "shader_translator" since we already had "angle_shader_translator". An attempt to work around "invalid COFF sections" error that is popping up on the MSVC try bots. Bug: None Change-Id: I105aa5e59f67173643a3a2071b2aff345b5a6135 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947457 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi fab10c23 2019-12-04T11:34:42 Vulkan: Optimize unused uniform cleanup in glslang wrapper Bug: angleproject:3803 Change-Id: Ib260c86c68e5b11deaec8658cd9768af9b44e086 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1949629 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi c3f0352d 2019-12-04T12:13:00 Re-enable atomic counter tests on !windows There is a bug that prevents us from running these tests on the windows bots. This change enables them on other platforms so we don't lose coverage. Bug: angleproject:3738 Change-Id: I9b546c3223499af88b347f8a01be8edb245c19a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950654 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 61c6aecc 2019-11-28T14:30:18 Vulkan: Fold read access into write flags on buffer writes This could lead to a subtle bug: Say we use a buffer as a storage buffer and write to it. We then must issue a memory barrier before using it as a uniform buffer. However we would set the SHADER_READ bit as a read mask on a storage buffer access. This seems like it could lead to a missing barrier. Bug: angleproject:4178 Change-Id: I486002739b7fb000ffacc0a1e996784b7875e7ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943034 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
shrekshao a654d351 2019-12-02T18:12:24 Turn on fboRenderMipmap for D3D11 Bug: 1023747 Change-Id: I8ca320432aad663e2a6d70f494692df518376258 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947710 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com>
Courtney Goeltzenleuchter b40c65ce 2019-12-03T10:12:34 Split out core.compute_shader expectations The failures have been triaged and split into more specific bugs. Bug: angleproject:3601 Change-Id: Icb262a047bba78a11d710e479ad659a9fa1caf1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948524 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Courtney Goeltzenleuchter 33a00efd 2019-11-27T09:21:45 Add Compute Shared Memory Size Validation Add tracking of shared memory declarations in compute shaders. Test:   angle_deqp_gles31_tests --gtest_filter=dEQP.GLES31/functional_debug_negative_coverage_callbacks_compute_exceed_shared_memory_size_limit Bug: 4173 Change-Id: If2a86d467a82f73fa5b2ee0ced752701acfe1872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934653 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tom Anderson 5f3456e3 2019-12-03T14:16:19 Expose GL_ARB_sync for GL BUG=chromium:1028799 R=jonahr CC=vasilyt Change-Id: Id17c4061b206953b1e904bf7938cb371612e33fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948534 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 006a1554 2019-12-04T07:01:58 Roll third_party/vulkan-validation-layers/src 4fde9b750992..e72b61c7c20d (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4fde9b750992..e72b61c7c20d git log 4fde9b750992..e72b61c7c20d --date=short --first-parent --format='%ad %ae %s' 2019-12-03 dadschoorse@gmail.com include cassert in vk_extension_helper.h Created with: gclient setdep -r third_party/vulkan-validation-layers/src@e72b61c7c20d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I647c43e868f17775548545671e283830559b3aba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950027 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 154167f2 2019-12-04T07:01:41 Roll third_party/SwiftShader b64fbfec4dcd..bbd0694f9ab2 (3 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/b64fbfec4dcd..bbd0694f9ab2 git log b64fbfec4dcd..bbd0694f9ab2 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 chrisforbes@google.com Remove Common/Types.hpp include from SpirvShader 2019-12-03 chrisforbes@google.com Regres: Add pending deqp change to fix bad graphicsfuzz tests 2019-12-03 srisser@google.com Make Vk::Stringify return std::string Created with: gclient setdep -r third_party/SwiftShader@bbd0694f9ab2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia5795718520bc2de13a5331fb3471f5d16ba5dbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950025 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 089c4716 2019-12-04T07:01:40 Roll third_party/spirv-tools/src 3ed4586044f2..e82a428605f6 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3ed4586044f2..e82a428605f6 Created with: gclient setdep -r third_party/spirv-tools/src@e82a428605f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I84921c632e3a8f55a5c2e16d03984f5119d7ac15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950024 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b939b4a7 2019-12-04T07:01:56 Roll third_party/glslang/src a4af7676feb0..e58c080d4f02 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a4af7676feb0..e58c080d4f02 Created with: gclient setdep -r third_party/glslang/src@e58c080d4f02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia950c8adef32a30ee53f05e3c9e01d8576f62f8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950026 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 249cb200 2019-12-03T11:10:06 Translator: Rename TIntermInvariantDeclaration to ..GlobalQualifier.. This is to support the upcoming `precise` keyword. Bug: angleproject:3569 Change-Id: Idbcc8fd6f261757dbbf81b381e7a2dae938d8101 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947451 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi a5045ac3 2019-12-03T11:02:17 glslang.l: refactor extension checks Bug: angleproject:3569 Change-Id: I7cbbaa4d1cdd4dd4268f28e06c907958cff9b4e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947450 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 5efb36b9 2019-11-25T16:14:55 Automatically call flex/bison if necessary ANGLE translator's parser code generation is changed to use the binaries of flex/bison stored in the cloud. scripts/run_code_generation.py now automatically runs these files if the input files change. Bug: angleproject:3419 Change-Id: Icce4247f93b27baf8ee12dbb16112fa2cc98c111 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940572 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>