kc3-lang/angle

Log

Author Commit Date CI Message
Roman Lavrov 44a8184b 2024-09-09T10:31:10 Android aosp: refactor roll_aosp.sh, add docs A few minor simplifications and documenting some caveats. Bug: b/279980674 Change-Id: I895721a97f9aa849a2cd6a67fe3a76098c10e9e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5845911 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Liza Burakova ca2e588b 2024-09-12T14:20:33 WebGPU: Add support for depth/stencil clears This CL also adds helper methods to create webgpu depth/stencil attachments for a render pass descriptor, as well as depth/stencil attachment images. Bug: angleproject:42267012 Change-Id: Iebef99ba34db2e50f56449d0737b3dbb03b90f2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5750001 Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Alexey Knyazev b5280aa3 2024-09-12T00:00:00 Add shadow sampler LOD tests for cubemaps Added tests for GLSL 3.00 shadow samplers in fragment shaders with TEXTURE_CUBE_MAP target. Bug: angleproject:365066518 Change-Id: I2b8577310ea5c258d4d13611607f5c4d9be57e04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5865112 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 5e45d53f 2024-09-15T11:12:01 Tests: Add Downwell trace Test: angle_trace_tests --gtest_filter="*downwell*" Bug: b/367019385 Change-Id: Iad12378a0d770e24b5a74db9eee78b0d8cbaa094 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5863490 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuly Novikov 005345d4 2024-09-16T11:02:37 Suppress flaky dEQP GLES2 test dEQP-GLES2.functional.texture.filtering.cube.linear_mipmap_linear_nearest_clamp_etc1 on Linux NVIDIA 535.183.01 driver. Bug: angleproject:362486580 Change-Id: Icdf6add6fe4c1f27c8903df12eb42e8b91bffa57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5865110 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 7d79eb48 2024-09-16T10:01:10 Roll SwiftShader from 3239872f9c5f to 2afc8c97882a (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/3239872f9c5f..2afc8c97882a 2024-09-16 dloehr@google.com Include usage instructions in update-marl.sh If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ia322b09d4d283198a6c960c5996dc656ccbb9282 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5864590 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e5dd355a 2024-09-16T08:01:26 Roll VK-GL-CTS from c3450b232f2c to 1df39e522f4a (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c3450b232f2c..1df39e522f4a 2024-09-12 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.11 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Iafb804e7ef7cca282f327ce4b08902e0f583e96f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5863495 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll aca185ba 2024-09-16T08:07:07 Roll Chromium from 2819a64dc892 to a4e2f421d97f (656 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2819a64dc892..a4e2f421d97f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f383f21cf0..4bd877395d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e4f992c066..a7a84ac61e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fec3e166ce..ceb8beb7d8 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b2fb4604d1..18476ef59e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d43a3eb748..22df6f8e62 * third_party/fuchsia-sdk/sdk: version:24.20240906.3.1..version:24.20240913.4.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/887f732df0..50ab693ecb * third_party/r8/cipd: mqzE1g-dbf23PQ04w-4TpmupGkMOnZljVa993-MkzhIC..7uFd3SlbG6FD-AMxTS6HGHCrIMPFsBHVTcJ-s8jKBz4C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c40256744f..e47c184ec5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/487335b1ca..b9b0be7e92 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ie58398223aab683003fa0aca277a99b053317717 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5863496 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gowtham Tammana 937c5dc8 2024-09-09T12:18:55 Vulkan: Make image{Read,Write} helper interface api agnostic Removing ContextVk dependency on the imageRead/imageWrite helper utility functions. Bug: angleproject:42266971 Change-Id: I493e1fb11e8ae192f766c822cbee278c49c23bfe Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5845197 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f6d9b179 2024-09-13T09:28:48 Roll Chromium from ca9e6516864e to 2819a64dc892 (690 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ca9e6516864e..2819a64dc892 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/547c20b88e..f383f21cf0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/34a8595e75..e4f992c066 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3d3b873e0b..fec3e166ce * third_party/android_build_tools/lint/cipd: 0NjBV6ny4NFaPqwbcGq1QIWTxKd77cPGUBMo_piBTn0C..KAn8XNv30rD_Nmtd1lKJs3RE7IyZrZ5ZIn23eohaG1QC * third_party/android_build_tools/manifest_merger/cipd: sa8Vo-ZxAsdWEoHTyymObnW4P7_yyEc7_fIpOF0A8VYC..JnUHT3SsYpv4WBlOV5VrBkuj2Q9SJ3cXlNHZ-u78L5IC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/585ff6a9bf..b2fb4604d1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c46e0e5bd6..296226a4a0 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/20a0cda9e9..d43a3eb748 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6ae6f38d10..887f732df0 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/11b62edaf2..29b2e9a0f4 * third_party/r8/cipd: SfTjETaHqxbqyJ2oM5I95Iff9NJRgm9LHaDH03COwT0C..mqzE1g-dbf23PQ04w-4TpmupGkMOnZljVa993-MkzhIC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2bcc82bda8..c40256744f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c2a6cf93eb..487335b1ca * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/eb8f9c275d..a7d3d8af53 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I93a1e596bbd1b9962f127c04c7d4709709fc6989 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5860296 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev 9decad75 2024-09-12T00:00:00 Add shadow sampler LOD tests for 2D arrays Added tests for GLSL 3.00 shadow samplers in fragment shaders with TEXTURE_2D_ARRAY target. Bug: angleproject:365066518 Change-Id: Iab68d7de6709e470ae6a4cd7d94682b454ed2880 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5861427 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 0cce8fd3 2024-09-12T00:00:00 Add EXT_texture_shadow_lod stubs Bug: angleproject:365108862 Change-Id: Ib879c2994871a41ad680bfe487593ea8ccbba7cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5860118 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 25c693c9 2024-09-15T00:03:38 Manual roll vulkan-deps from cafccf56bad4 to 85337aef88cb (5 revisions) Manual roll requested by yuxinhu@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/cafccf56bad4..85337aef88cb Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/dc1012140e015d43711514d1294ac6f626890a40..708d560c23d99e028722b7e98710371cca56fe5b https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/7c9210cc1d82e8bf0ca969a88db069c83d838398..4451f6ab13dda98bf255a7cd7b4d120132dc0dfd https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/ea5774a13e3017b6d5d79af6fba9f0d72ca5c61a..eb62fb38a538cde41b1180ec182ba923455a49ee https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/884762aed0beff0f312c900c104d130479758ac9..ff33a4e06ba7b0a7d7253f7b9c4b2dc2a1a53cc0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I23586f232d80f50a713483b5f2222b625ad395e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5863489 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 6ee07959 2024-09-13T17:12:26 Remove the suppressed VVL error https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/8523 is fixed. Remove the VVL error from the suppressed list. Bug: b/365580001 Change-Id: Ib7a3819e740393306995df1eabec14e1b9878d7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5860811 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll d1f23926 2024-09-13T19:08:38 Manual roll vulkan-deps from 5a507062e158 to cafccf56bad4 (4 revisions) Manual roll requested by yuxinhu@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/5a507062e158..cafccf56bad4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/380275eacdb929f5adc6cc145fad5a60ca9a4b42..7c9210cc1d82e8bf0ca969a88db069c83d838398 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ef846ac0883cde5e69ced0e7d7af59fe92f34e25..884762aed0beff0f312c900c104d130479758ac9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ib1166d8b972715d09534f0221f05bebda8528465 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5860804 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kaiyi Li 42c85cc4 2024-09-13T12:52:25 roll_aosp: move the non conformant cflags to a cc_defaults ... so that the downstream can customize it easier. Test: generate the Android.bp and build on aosp/main branch with the cf product Bug: b/366518715 Change-Id: Ie4f028bcfb45b650a98b21b46e645b3aabf63c20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5862029 Auto-Submit: Kaiyi Li <kaiyili@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Kaiyi Li <kaiyili@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Mark Lobodzinski 27738fe4 2024-09-04T19:53:01 Fix retracer script error due to blank argument Traces fail when running the retracer script if the --request-extensions argument is passed with a blank value. Bug: b/42266279 Change-Id: I1e465caaaa7a5f8d8048c09890b5d01eeb2d0df1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5860298 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov c91e2792 2024-09-13T14:22:19 Tests: aosp end2end test lib depends on _ndk_ gtest/gmock This appears to resolve build issues in https://crrev.com/c/5857112 Re-enable end2nd test target in aosp. Bug: b/279980674 Change-Id: Icf8f1cf9868564b70515cb121526a3a1210e8b27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5860262 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Hailin Zhang bf29f7bd 2024-09-13T11:36:23 vulkan: fix eagl compile issue. fix https://chromium-review.googlesource.com/c/angle/angle/+/5858255 build issue for eagl. Bug: b/311022968 Change-Id: Icc6f3276338572f0303e49bede256c1a7239d3ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5862027 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Hailin Zhang <hailinzhang@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Hailin Zhang 8c12874c 2024-09-12T11:26:29 vulkan: add double buffer swapchain for fifo mode. Double buffer swapchain usually drop the performance. But at B* the default fps cap for silver device still at 30fps. This change is for reduce latency. Bug: b/311022968 Change-Id: Ida4044f439bbe3f235d53f5d1d2f945533cbb094 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5858255 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev e90de4b2 2024-09-05T00:00:00 Add shadow sampler LOD tests Added tests for GLSL 3.00 shadow samplers in fragment shaders with TEXTURE_2D target. Bug: angleproject:365066518 Change-Id: I5b93d030cd14a388541acaff9f7a707ad599dba3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5845491 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuxin Hu 96733038 2024-09-12T16:10:53 Add back sdk_version entry to build targets ANGLE in android repo are failing to compile on some lunch targets: e.g. mainline_modules*, with sdk_version entry removed from build targets. For instance, after removing sdk_version for build target libEGL_angle, compilation failed with this error message: ``` error: external/angle/Android.bp:8174:1: dependency "libEGL_angle" of "ANGLE" missing variant: os:android,arch:arm64_armv8-a,sdk:sdk,link:shared available variants: os:android,arch:arm64_armv8-a,link:shared os:android,arch:arm_armv8-a,link:shared ``` Add back sdk_version entry to the build targets. END2END_TEST_TARGET needs to be disabled, because with sdk_version entry added to END2END_TEST_TARGET, the target failed to compile due to its' dependency libgmock is missing the variant: ``` error: external/angle/Android.bp:699:1: dependency "libgmock" of "libangle_end2end_tests__library" missing variant: os:android,arch:arm64_armv8-a,sdk:sdk,link:static ``` Bug: b/279980674 Change-Id: I96ea45b93519b84d72a70559d1ade9076ef9d955 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5857112 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov 7dcfc32b 2024-09-12T16:25:28 Remove renamed VUID VUID-VkVertexInputBindingDivisorDescriptionEXT-divisor-01870 was renamed to VUID-VkVertexInputBindingDivisorDescriptionKHR-divisor-01870 in https://github.com/KhronosGroup/Vulkan-ValidationLayers/commit/6adb436617e6c66fbc8b2a24996659f5c5bbb63f Bug: angleproject:42266877, angleproject:42266639 Change-Id: I382625d33ef6728835d8e9db307d32b7910ac9b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5855187 Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Solti Ho <solti@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 1205d218 2024-09-12T11:46:48 Suppress flaky failures on new Linux Intel and NVIDIA drivers Intel Mesa 23.2.1: Texture2DTest.NegativeAPISubImage/ES2_WebGPU NVIDIA 535.183.01: KHR-GLES32.core.texture_cube_map_array.image_op_compute_sh KHR-GLES31.core.texture_cube_map_array.image_op_fragment_sh Bug: angleproject:362486580, angleproject:360083331 Change-Id: I5038f867ccda43331def4b6ee4253b580a1a6f1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5854328 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 7168e3e6 2024-09-12T10:01:31 Roll vulkan-deps from 49bb428cd451 to 5a507062e158 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/49bb428cd451..5a507062e158 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/12a17b7ce41436427e358608183100b1103274da..dc1012140e015d43711514d1294ac6f626890a40 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/d160e170d74ff45cb2a88dfb365bdfd896016f7c..380275eacdb929f5adc6cc145fad5a60ca9a4b42 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/50910c05fdc909aba59cc71e6320b0c5908912cd..ef846ac0883cde5e69ced0e7d7af59fe92f34e25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I715ac50392cfc8c97dcfe8ff61a92099f58f21e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5856396 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll dce150ce 2024-09-12T07:27:43 Roll Chromium from 9ba8dc9b3945 to ca9e6516864e (599 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9ba8dc9b3945..ca9e6516864e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c08e101374..547c20b88e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/52156e171b..3d3b873e0b * third_party/android_build_tools/error_prone/cipd: iksKTcNa8fCfCXLvYa9Og9yhPWH8iTk7xbESPSw243QC..fNCLAzE8NSvOXTryvUGT3NmX8no8lyRHR1yfY0zbv8YC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/39833eaec8..585ff6a9bf * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61fad561d6..20a0cda9e9 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/4426a8da65..927aabfcd2 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d3aea2341c..fa9f14143c * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/badf79a4b9..6e83c10671 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0a60bc4551..2bcc82bda8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d14dbf1cb1..c2a6cf93eb No update to Clang. Bug: angleproject:6430,angleproject:7425 Tbr: yuxinhu@google.com Change-Id: I3318e64e74e22c7d7bf0ecdb2937a014602765af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5856394 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev f0919be3 2024-09-05T00:00:00 GL: Reset color mask before clearing textures Some OpenGL drivers may apply last used color mask state to ClearTexImage operations. Bug: angleproject:347047859 Change-Id: I0bbf103793857b96e50fae8d6dfafc96b8dfe224 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5854319 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Matthew Denton 1a5fee10 2024-09-11T17:37:54 Fix missing include Bug: angleproject:42267100 Change-Id: Iafa56c8bfcfd898ca58bfe0cc0bb67ca253813e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5854007 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Matthew Denton <mpdenton@chromium.org>
Charlie Lao c9d55051 2024-09-06T10:56:07 Vulkan: Consolidate dirtyRanges before vertex conversion Detect two ranges overlap or are continuous and merge them. This reduces number of dispatch calls as well as avoids redundant conversion. Bug: b/357622380 Change-Id: I06b73a1e9fd573d79af985b247f4d66bf97f756e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5851642 Auto-Submit: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 9f002018 2024-09-11T16:31:50 Suppress flaky test on Linux NVIDIA Vulkan KHR-GLES31.core.draw_buffers_indexed.color_masks Bug: angleproject:365974429 Change-Id: Ib7d1a38aa0d4af999975957791d88b90c770f4a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5854322 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cody Northrop 3c93f29b 2024-09-10T20:27:16 Test: Add Chrono Trigger trace Test: angle_trace_tests --gtest_filter="*chrono_trigger*" Bug: b/365875548 Change-Id: Ifd9f2c09f93716341fb36b79e7c7ae5291fa9ed2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5852912 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
angle-autoroll 11c0a783 2024-09-11T10:01:13 Roll SwiftShader from 8dd40811c571 to 3239872f9c5f (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/8dd40811c571..3239872f9c5f 2024-09-10 swiftshader.regress@gmail.com Regres: Update test lists @ 8dd40811 2024-09-10 dloehr@google.com Update Marl to 690889fbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I324c946140366b0b488b099a3d979dcbbd646890 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5852843 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 60f1309d 2024-09-11T10:01:42 Roll vulkan-deps from 3b92cef97feb to 49bb428cd451 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/3b92cef97feb..49bb428cd451 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/99de3c17fbc2db6b6da0347916c9e01a383c2758..50910c05fdc909aba59cc71e6320b0c5908912cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I6109c6d8433426e31dad08f7268d5d14e4c9eead Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5853413 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 094e9c19 2024-09-11T07:02:33 Roll Chromium from 425b927532ae to 9ba8dc9b3945 (623 revisions) https://chromium.googlesource.com/chromium/src.git/+log/425b927532ae..9ba8dc9b3945 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1c773de893..c08e101374 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6a71c9b405..34a8595e75 * buildtools/reclient: re_client_version:0.159.2.996d35d3-gomaip..re_client_version:0.163.0.d27158ab-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c211d3a605..52156e171b * third_party/android_build_tools/error_prone/cipd: YYa_g0mrETe0GrN2UsP2xRXNjCb1udBz0c7yp0WFiOkC..iksKTcNa8fCfCXLvYa9Og9yhPWH8iTk7xbESPSw243QC * third_party/android_build_tools/lint/cipd: 0j6PgTJxbBi5tTD1TAeLuyhU5iSUjgiXdpEhVCDtxC4C..0NjBV6ny4NFaPqwbcGq1QIWTxKd77cPGUBMo_piBTn0C * third_party/android_build_tools/manifest_merger/cipd: 2bcaX6fJS6WildBm3bMUKnbKuGk-TIiSBKQ9P9Q4O18C..sa8Vo-ZxAsdWEoHTyymObnW4P7_yyEc7_fIpOF0A8VYC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/6bbb636f8a..39833eaec8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/39de890708..c46e0e5bd6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/46f5de67e1..61fad561d6 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9be1056e88..6ae6f38d10 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/25c90d0f70..0a60bc4551 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6417f436c7..3793b7f7b4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c357ec287c..d14dbf1cb1 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/f9f02d66ab..cf58645be8 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: If1a8daaf7d6284b017d68436db53fac5b28068f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5853130 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Dan Glastonbury c335ddfa 2024-07-19T11:48:54 Check only important stencil bits in partialClearNeedsInit When determining if a partial clear is taking place, instead of checking all bits of the stencil masks, only check the lowest bits corresponding to the bit depth of the active drawing stencil attachment. This results in combinations of masks, such as 0xFFFFFFFF and 0x7FFFFFFF as 0xFF and 0xFF, which are equal and not different. Change-Id: Id94082b6f689af92b00fb6d9a6cf65a1e3b4396a Bug: chromium:354025373 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5721289 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 958b657f 2024-09-10T20:34:57 Manual roll vulkan-deps from 725499142cb6 to 3b92cef97feb (32 revisions) Manual roll requested by yuxinhu@google.com Manual roll changes: suppress VUID-vkCmdDrawIndexed-Input-08734 until VVL issue angleproject:365580001 is addressed. https://chromium.googlesource.com/vulkan-deps.git/+log/725499142cb6..3b92cef97feb Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a496a34b439022750d41d2ba04fbbe416ef81c9a..12a17b7ce41436427e358608183100b1103274da https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/efb6b4099ddb8fa60f62956dee592c4b94ec6a49..2a9b6f951c7d6b04b6c21fe1bf3f475b68b84801 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/e1782d6675b88225225e331a6318554d473c54db..d160e170d74ff45cb2a88dfb365bdfd896016f7c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/c758bac8bf1580b5018adafd3a2ec709237b0134..1108bba6c97174d172d45470a7470a3d6a564647 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/fbb4db92c6b2ac09003b2b8e5ceb978f4f2dda71..ea5774a13e3017b6d5d79af6fba9f0d72ca5c61a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/af7b0a35d009b5ad6e0b280a5b81388608ebfe39..99de3c17fbc2db6b6da0347916c9e01a383c2758 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:365580001 Tbr: yuxinhu@google.com Change-Id: Iac9c8b6310d3ebb955dd09fd26b71d373e13b479 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5849280 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 8a8ca298 2024-09-10T14:34:11 Tests: Add Brawlhalla trace Test: angle_trace_tests --gtest_filter="*brawlhalla*" Bug: b/365824633 Change-Id: If3a5213661ffb041903a84a12713e04588b516e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5851640 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Charlie Lao 10d56e63 2024-09-06T10:56:07 Vulkan: use mEntireBufferDirty if range covers entire buffer Detect the dirtyRange covers entire buffer and set mEntireBufferDirty instead of add range into mDirtyRanges. This will get into a much simpler code path that will not have any redundant conversion. This also removes quite big portion of overlapped ranges cases without much of overhead. Bug: b/357622380 Change-Id: Iedaa3662a6fc52257e71d39ab75baddf6ad3e41b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5840476 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Charlie Lao <cclao@google.com>
Matthew Denton c2a9300c 2024-09-10T19:33:33 WGSL: Rewrite input/output variables GLSL builtin variables and in/out variables correspond to WGSL's main function params and return value, so rewrite them accordingly. This is done by generating structs to use as main function params and return values, generating similar global structs, and copying the former into the latter so the rest of the program can just use the variables stored in the global structs. Bug: angleproject:42267100 Change-Id: Ic3e1196f6fb95b963ce03845096a59ea7599d608 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5835347 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Amirali Abdolrashidi 9a2b1f16 2024-09-10T13:06:57 Add .git-blame-ignore-revs Bug: angleproject:365820898 Change-Id: I8bdbb9f1d96bd4bb06943406d45eb4476344773b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5851638 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 61a255cb 2024-09-10T10:56:58 Skip the critical_ops trace on S22 This trace crashes on S22: https://chromium-swarm.appspot.com/task?id=6bf09c55e48e1710. Skip it to keep the bot green and investigate the crash offline. Bug: b/267953710 Change-Id: Id8fc9f4b014ed3d97ca7cce2f56bc49cd9ef380f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5851574 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 6afcbd3e 2024-09-10T10:31:42 Vulkan: Disable dynamic rendering on ARM Due to driver bugs. Bug: b/356051947 Change-Id: Ic345496010b051ad054811a8c34bb3f816bbf258 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5851632 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Rafael Cintron 6655e94f 2024-09-09T15:41:09 Remove Feature Level 9_3, part 2 Remove all of the remaining feature level 9_3 code. Bug: angleproject:355462523 Change-Id: Ifd15d8f5486d3e7f8f2e134f23872abf4a8ea51c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5847452 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Liza Burakova 84492ff3 2024-09-10T13:11:07 Sync vertex attributs in VertexArrayWgpu. This change only sets vertex attributes within VertexArrayWgpu and sets them in the render pipeline description owned by the context. It does not yet set attributes in the output pipeline created in CreatePipeline, as vertex buffers are also not set yet. Bug: angleproject:359823692 Change-Id: I1c3848e15d790026d53d4ab5614b1125f773e06a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5781788 Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Dan Glastonbury d40d1a67 2024-09-05T14:56:46 Metal: Fix OverrideMTLClearColor handling of no texture It's possible for OverrideMTLClearColor to be called with no texture. This can happen with multiple draw buffers where the bound program executable and framebuffer has incompatible component types. When the render pass is prepared by a drawing command, these incompatible attachments are skipped. As demonstated by the new test case, when switching to the framebuffer that has previously been prepared by such a draw, if the state is clean, the render pass attachments are not updated and |texture| is unavailable for use in determining any emulated clear color. Fixed: angleproject:364687937 Change-Id: I1ec9b564dc8cdb5faf7a1ed0f935d38502ca5514 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5836314 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 50188715 2024-09-10T10:01:59 Roll SwiftShader from 5561c71fa64e to 8dd40811c571 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/5561c71fa64e..8dd40811c571 2024-09-09 natsu@google.com Drop checking ContainsSampleQualifier 2024-09-09 natsu@google.com Enable sample rate shader when SampleRateShading cap found 2024-09-09 natsu@google.com Break out long condition into a helper function If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I26a5d004f7214eb658bea190813c1e159e0c79f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5849469 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 20b66890 2024-09-10T07:02:14 Roll Chromium from 55810c9b176d to 425b927532ae (591 revisions) https://chromium.googlesource.com/chromium/src.git/+log/55810c9b176d..425b927532ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/58e988bf3b..1c773de893 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c50379e934..6a71c9b405 * buildtools/linux64: git_revision:f792b9756418af8ab8a91a4c15b582431cb86ff9..git_revision:20806f79c6b4ba295274e3a589d85db41a02fdaa * buildtools/mac: git_revision:f792b9756418af8ab8a91a4c15b582431cb86ff9..git_revision:20806f79c6b4ba295274e3a589d85db41a02fdaa * buildtools/win: git_revision:f792b9756418af8ab8a91a4c15b582431cb86ff9..git_revision:20806f79c6b4ba295274e3a589d85db41a02fdaa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6eab34bb11..c211d3a605 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ea8a06debe..1f7e21e34c * third_party/android_build_tools/lint/cipd: IH7AKIwWSYXSo48ZTygnHFqznygQpejo_a94GUIyqAAC..0j6PgTJxbBi5tTD1TAeLuyhU5iSUjgiXdpEhVCDtxC4C * third_party/android_build_tools/manifest_merger/cipd: BAf3JISR2TbfPyRYeLa62W7tsmuAQ6x7THsx6qvpSb4C..2bcaX6fJS6WildBm3bMUKnbKuGk-TIiSBKQ9P9Q4O18C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/753e45cfb9..39de890708 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ae3745656b..46f5de67e1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7ef1f0a187..9be1056e88 * third_party/r8/cipd: EQKzOXcfxGc6pp0NyDCDBQYJ68PTOs19P4zEraID18kC..SfTjETaHqxbqyJ2oM5I95Iff9NJRgm9LHaDH03COwT0C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/08ebd93ba5..25c90d0f70 * tools/luci-go: git_revision:1d383421736c86faeb7dea6d2039d8ea2ef6d648..git_revision:1aca70b6bf116c1bd8fbf0526c9a89e9be308718 * tools/luci-go: git_revision:1d383421736c86faeb7dea6d2039d8ea2ef6d648..git_revision:1aca70b6bf116c1bd8fbf0526c9a89e9be308718 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/760e21a898..c357ec287c * tools/skia_goldctl/linux: Lha0rEJ7GHU0Fil1gSD6dalZtxzX6uaFjpYvWih41WIC..FqgGUYCOqrRnp8FnQKKpTVCh2qW_G9ACEGWzbAxNqxwC * tools/skia_goldctl/mac_amd64: KcJIi8wfbLT-tqejE6z9o5wPpCrtBjPhdVuNl2_NyqoC..BrQDdXzXeqJHWCYdKNXj2Tq08cgRYE0KLEnVAklyemkC * tools/skia_goldctl/mac_arm64: Gt9vuY-MHU7Sm1HRXh-XGw7kzNXCTwMpt4LhVmc5I58C..bnOHfm8fLa2gZiirRaLqMN1SfJM2_XMMXzCTNDB8nmQC * tools/skia_goldctl/win: 7XZbTrL--iaDvJOdJ21qL6AKnpf2paDm9LmknGHscX8C..QjLZ5qMfQ5_I_sMHQ6cQdaqTUyl3UWFVVZ1o8MONqOgC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I04b44cca2bf73977b933bf9adde8f752b280bb91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5849349 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 941b3df3 2024-08-21T17:23:16 Vulkan: Add new threshold for CPU buffer subdata Currently, with preferCPUForBufferSubData enabled, when the GPU is busy, we use the CPU to copy subdata, which includes duplicating the buffer. If the buffer is large, this can cause performance regression. To avoid this, we should avoid using the CPU in cases that can lead to such regressions. * Enabled preferCPUForBufferSubData for all ARM devices. * This feature is only used in the following cases: * If the buffer is smaller than than 32K; or * If the copy size is greater than 1/8 of the total buffer size. * Significant performance improvement observed in several traces. Bug: b/360118138 Change-Id: Ibc8e3de9b4e081c69457c85facba893283c8fb38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5824347 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 53476d6f 2024-09-04T14:34:11 Vulkan: Do vertex conversion with fine grain dirtyRange Right now when we do vertex conversion with multiple dirty ranges, we are merging dirty ranges into single range and then UtilsVk::convertVertexBuffer() is called for the merged dirty range. If there is big gap between two ranges, the merged range could be very big. This means we end up doing many unnecessary conversion. This CL tracks individual dirty ranges and issues dispatchCompute for each dirty range, thus minimize the unnecessary conversions. On S24, this change further reduces TraceTest.gangstar_vegas frame time from ~6.0ms to ~3.8ms, almost parity to native GLES's ~3.6ms. Bug: b/357622380 Change-Id: Ia103f3963bdb5996ff3f95164c955a3e4f33f311 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5787633 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Jiewei Qian e3e59b24 2024-09-09T14:30:25 ssci: mark StackWalker as "Version: N/A" StackWalker is tracked by revision, marking it as "Version: N/A" per README guideline. Bug: b/365320706 Change-Id: I3e5b8319843682d251b95d61ea26d06a9f117372 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5837376 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Dan Glastonbury a0126d55 2024-09-06T11:58:58 Metal: Clear mRenderPassesSinceFlush to avoid infinite recursion When there is more than kMaxRenderPassesPerCommandBuffer render passes with active occlusion query, it's possible for the Metal backend to end up in infinite recursion of the following call sequence: `ensureCommandBufferReady` -> `flushCommandBufferIfNeeded` -> `flushCommandBuffer` -> `endEncoding` -> `endRenderEncoding` -> `prepareRenderPassVisibilityPoolBuffer` -> `getBlitCommandEncoderWithoutEndingRenderEncoder` -> `ensureCommandBufferReady` This recursion is caused by the checks in flushCommandBufferIfNeeded not being disarmed once the flush has started and is most likely caused by |mRenderPassesSinceFlush| exceeding |kMaxRenderPassesPerCommandBuffer|. This change moves the clearing of |mRenderPassesSinceFlush| to the top of of `flushCommandBuffer`, before any calls to `endEncoding`, breaking the need to call `flushCommandBuffer` via `getBlitCommandEncoderWithoutEndingRenderEncoder`. Additionally, |OcclusionQueryPool::mUsed| is set to false before the results are cleared. This will also break the recursion and is added for the `mCmdBuffer.needsFlushForDrawCallLimits` case in `flushCommandBufferIfNeeded`. Change-Id: Ib54c0a87ae9c5365ae56d487b6bef99b681d9f59 Fixed: chromium:362791944 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5839224 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop bda33598 2024-09-08T16:08:04 Test: Add Critical Ops trace Test: angle_trace_tests --gtest_filter="*critical_ops*" Bug: b/365417418 Bug: b/365524876 Change-Id: I3e6f3278a9c6ea819d61a0136986631b19170018 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5843583 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 22c39d24 2024-09-09T11:14:27 Android aosp: remove sdk_version from most rules (try 2) Missed another line in https://crrev.com/c/5845930 Bug: b/279980674 Change-Id: I357654f39cb2d37f6a9b3016fe31fdb053575e3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5845910 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov bfadbe80 2024-09-09T14:25:26 Revert "Tests: temporarily disable end2end test .so library in AOSP" This reverts commit 2deb9534d550dbacf024ed9250f8bfa95d505a3b. Reason for revert: aosp builds fixed by https://crrev.com/c/5842687 and https://crrev.com/c/5845930 Original change's description: > Tests: temporarily disable end2end test .so library in AOSP > > aosp build failures: https://r.android.com/3258459 > > Bug: b/279980674 > Change-Id: I64cbd4821f542436d15e0d9e32a306bdceeeafa3 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5842021 > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: b/279980674 Change-Id: I296e4a36c259e5d862b7aa45718bec8168b21f0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5845931 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 18aeee88 2024-09-09T10:08:05 Android aosp: remove sdk_version from most rules This doesn't seem necessary and is breaking end2end builds that we're enabling. Note that we already have these in the top-level rules which are not going to be affected by this change: 'sdk_version': 'system_current', 'target_sdk_version': TARGET_SDK_VERSION, 'min_sdk_version': MIN_SDK_VERSION, Bug: b/279980674 Test: aosp presubmit https://r.android.com/3260111 Change-Id: I50b9843ec8bf859717f94681374d4ece1a4505c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5845930 Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 67b3149f 2024-09-09T08:01:06 Roll VK-GL-CTS from 7d2299e67fe7 to c3450b232f2c (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7d2299e67fe7..c3450b232f2c 2024-09-06 gleese@broadcom.com Add a test for modf with whole numbers < 0 2024-09-06 piotr.byszewski@mobica.com Additional VIEW_INDEX_FROM_DEVICE_INDEX_BIT tests 2024-09-05 javed@igalia.com Add coverage for waiting on multiple events 2024-09-05 javed@igalia.com Enable tests for storage texel buffer atomic 2024-09-05 marcin.hajder@mobica.com Fix multiple issues related to KHR-GLES3.api.coverage 2024-09-05 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-09-04 lorenzo@khronosgroup.org Reformat JSON extension files automatically 2024-09-02 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_pipeline_binaries' into main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I691a5406f0040ff441cd9a0b7eee954cd45c985a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5844490 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 681a3cac 2024-09-09T07:00:42 Roll Chromium from 1640f4fb3586 to 55810c9b176d (683 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1640f4fb3586..55810c9b176d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0f665af83d..58e988bf3b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/012c060b76..c50379e934 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ad248e83d0..6eab34bb11 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1b83be0f96..753e45cfb9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/43691064b4..ae3745656b * third_party/fuchsia-sdk/sdk: version:23.20240830.3.1..version:24.20240906.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a4812f9f72..7ef1f0a187 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/da2fe725b8..37bbf271c6 * third_party/siso/cipd: git_revision:578c7a731c5efa9fde8ef210e34e38df0bcf0d34..git_revision:eaee19cf51478b64614e2e8daad77378238a3c6c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5208ebe9c2..08ebd93ba5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9da6470c47..760e21a898 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/24da716443..eb8f9c275d No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I4a31b0b733dba945f4db2e23dbd77eb3968d4251 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5844489 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand fc65058c 2024-05-03T14:47:29 CL/Vulkan: Rework spec constant handling Specialization constants can be combined into a single hash map that's later iterated on when we create the compute pipeline. Bug: angleproject:364396920 Change-Id: I161356808ff0bd6a589f01854264210011bec512 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5834664 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov f063960c 2024-09-06T18:50:05 roll_aosp.sh: keep third_party/jdk/BUILD.gn Re-added BUILD.gn to aosp in https://r.android.com/3257014, need to avoid it getting deleted again by the script. Bug: b/279980674 Change-Id: I3adad6a906385078607498c9e608d92a3430b4fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5842687 Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Cody Northrop e19377af 2024-08-21T14:52:09 Tests: Support multiple users on Android On most Android platforms, the userId is '0' and many of our defaults just work. But on some, the default is non-zero, and that complicates things. To support this, we have to specify which user is correct, which can be determined with: adb shell am get-current-user Update everywhere we were using sdcard directly and use: Before: /sdcard After: /storage/emulated/<userId> Incorporate the userId to find the application's home directory: Before: /data/data/com.android.angle.test After: /data/user/<userId>/com.android.angle.test This CL: - Starts using a user flag in our Android scripts - Updates where tests look for test data and binaries - Updates where scripts use temp and external storage - Updates script to not use sdcard at all when root - Disables run-as when user is not default Bug: b/361388557 Change-Id: I0fb556ecb2d0f6bc6569a858c290b127217d4638 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5825122 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Roman Lavrov 2deb9534 2024-09-06T18:31:35 Tests: temporarily disable end2end test .so library in AOSP aosp build failures: https://r.android.com/3258459 Bug: b/279980674 Change-Id: I64cbd4821f542436d15e0d9e32a306bdceeeafa3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5842021 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mike Schuchardt 45ea2094 2024-09-06T10:36:07 Don't build api_dump for secondary abi on Android 32-bit builds of VK_LAYER_LUNARG_api_dump are extremely slow so skip them when building for arm64. Bug: b/42267058 Change-Id: I8c2d959d86a58537dafa518fb58267b38cda21f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5842279 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Charlie Lao 20511d0b 2024-09-05T17:35:33 Vulkan: Remove unnecessary perfetto trace in BufferVk::mapRange There is not much usefulness to know there is mapRange call. The more meaningful place is where we end up waiting for GPU to finish which we already have the perfetto trace in SharedFence::wait. The exitsing of this trace made a lot of noise in trace since app tends to call this a lot and there are many tiny lines on the trace. Bug: None Change-Id: I83fbbba827361d068b521bdfb2bc187865d11012 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5841067 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov 49a8d05c 2024-09-05T17:41:07 Tests: Add end2end test .so library to AOSP build m[mm] external/angle:libangle_end2end_tests__library produces libangle_end2end_tests__library.so I tested that integration with Chromium wrappers works with some manual patches; no integration is included in this CL. googlest/gtest dependencies replaced with platform libgtest, libgmock TestSuite heavily depends on rapidjson so it is currently excluded, only the standard gtest implementation is included (--gtest_list_tests, --gtest_filter, --gtest_output etc) This also disables support for expectation files as it is piped through TestSuite instance. Bug: b/279980674 Change-Id: I35cb2328d74a3ac778e1d93bb4fe4ac044920b6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5838526 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 887d148a 2024-09-06T07:01:38 Roll Chromium from 93076992192b to 1640f4fb3586 (640 revisions) https://chromium.googlesource.com/chromium/src.git/+log/93076992192b..1640f4fb3586 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/259b72d9ae..0f665af83d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9c4d44a89a..012c060b76 * buildtools/linux64: git_revision:a737c2849f13f47b7808020f1a37c8403da66d92..git_revision:f792b9756418af8ab8a91a4c15b582431cb86ff9 * buildtools/mac: git_revision:a737c2849f13f47b7808020f1a37c8403da66d92..git_revision:f792b9756418af8ab8a91a4c15b582431cb86ff9 * buildtools/win: git_revision:a737c2849f13f47b7808020f1a37c8403da66d92..git_revision:f792b9756418af8ab8a91a4c15b582431cb86ff9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/225240b0c1..ad248e83d0 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/a828b2c3d4..da8bcc9ab0 * third_party/android_build_tools/lint/cipd: vK2EWXYFdvy3H4rz3g07kr9KSM6DEIQCN7ExiDk9YpQC..IH7AKIwWSYXSo48ZTygnHFqznygQpejo_a94GUIyqAAC * third_party/android_build_tools/manifest_merger/cipd: gOOAK8RSQfCcMiPGkXboJjJdBDOlrvDaVON2LFSZNzcC..BAf3JISR2TbfPyRYeLa62W7tsmuAQ6x7THsx6qvpSb4C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8f37f0d031..6bbb636f8a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ee4a947642..1b83be0f96 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/62fc3a1d24..43691064b4 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/b6405588e4..a4812f9f72 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a834cb2539..11b62edaf2 * third_party/r8/cipd: RbwehSZaS0uD2p3t0AZ6kPBoJW-B6F1Xwi0C6QVK8kwC..EQKzOXcfxGc6pp0NyDCDBQYJ68PTOs19P4zEraID18kC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/43facff7a9..badf79a4b9 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dbab69bc91..5208ebe9c2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/260c14af22..9da6470c47 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/d2af8c2608..24da716443 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I3fd37b4ef28657b9294fcc2fa290e5643b914880 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5841189 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 61c26fd6 2024-08-29T10:11:00 Tests: Add Passmark benchmark Unity trace Add trace of the 'OpenGL ES using Unity ' benchmark case of the Passmark performance test suite. Test: angle_trace_tests --gtest_filter=*passmark_unity* Bug: b/362801313 Change-Id: I15a57fefdb4959e60196646aa5053b6fa5960bcb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5825785 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 0a04cb90 2024-09-04T11:30:36 Translator: Limit shader size check to WebGL and Chromium shaders This is because std430 is not taken into account in the check. That can be fixed with https://chromium-review.googlesource.com/c/angle/angle/+/5835580 if ever necessary. Bug: angleproject:361369308 Change-Id: Id5eacc9bab6d959c8f9f8d09ebd87504dcfa25af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5836785 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 34201e0d 2024-09-05T07:00:04 Roll Chromium from e8f446cd167a to 93076992192b (563 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e8f446cd167a..93076992192b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/152af5f11f..259b72d9ae * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c0b937cf55..9c4d44a89a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8efa252b9b..225240b0c1 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/99be9e63c8..ea8a06debe * third_party/android_build_tools/error_prone/cipd: UUmy7T8JpYWyZicO5hv_doYLkvkPncgf8a99fVSIZOsC..YYa_g0mrETe0GrN2UsP2xRXNjCb1udBz0c7yp0WFiOkC * third_party/android_build_tools/lint/cipd: McDb8dEvTYCUAegJWyiNM_wadZHqcKTnf9mRocsu9LcC..vK2EWXYFdvy3H4rz3g07kr9KSM6DEIQCN7ExiDk9YpQC * third_party/android_build_tools/manifest_merger/cipd: rzdFQHQmRPlBZaKYPTWDw5qBToQZ2NXthGS1xXSh190C..gOOAK8RSQfCcMiPGkXboJjJdBDOlrvDaVON2LFSZNzcC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c282fc3e7b..ee4a947642 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b89b440351..62fc3a1d24 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d12ed9caf2..b6405588e4 * third_party/r8/cipd: RromJiK-SGOx_w-xDbiEfPi-uNKIxOaw797xkao2FqwC..RbwehSZaS0uD2p3t0AZ6kPBoJW-B6F1Xwi0C6QVK8kwC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0af6db3961..dbab69bc91 * tools/luci-go: git_revision:5845c6112f584c023a47776b31c3b6f08f562fb8..git_revision:1d383421736c86faeb7dea6d2039d8ea2ef6d648 * tools/luci-go: git_revision:5845c6112f584c023a47776b31c3b6f08f562fb8..git_revision:1d383421736c86faeb7dea6d2039d8ea2ef6d648 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6d4274cb84..6417f436c7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e128247e39..260c14af22 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/24773901fd..d2af8c2608 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Ib6040a9353999eaeb1513a7056092b32e8f4321e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5838499 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand 59eff366 2024-05-03T11:33:25 CL/Vulkan: Enable global offset support There is a "--global-offset" clspv flag that enables OpenCL global offsets. This feature is disabled by default otherwise. Bug: angleproject:364396921 Change-Id: I89179228d2ff9e0b6750d9d0d062261dfaddec6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5834663 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 621bba6c 2024-09-04T09:58:09 Vulkan: Fix device entry points loaded as instance Bug: angleproject:359420106 Change-Id: I970ac7b924013a3c8ea5dd73f90bbe1649969753 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5836783 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll ec8879a2 2024-09-04T09:58:28 Roll Chromium from def24c080915 to e8f446cd167a (673 revisions) Update third_party/turbine/cipd location per https://chromium-review.googlesource.com/c/chromium/src/+/5834369 https://chromium.googlesource.com/chromium/src.git/+log/def24c080915..e8f446cd167a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/469c6d5062..152af5f11f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0811404e1e..c0b937cf55 * buildtools/linux64: git_revision:50ecf4c84d08dad3d16d14590221dd43fe65ea62..git_revision:a737c2849f13f47b7808020f1a37c8403da66d92 * buildtools/mac: git_revision:50ecf4c84d08dad3d16d14590221dd43fe65ea62..git_revision:a737c2849f13f47b7808020f1a37c8403da66d92 * buildtools/reclient: re_client_version:0.158.0.ddc2270e-gomaip..re_client_version:0.159.2.996d35d3-gomaip * buildtools/win: git_revision:50ecf4c84d08dad3d16d14590221dd43fe65ea62..git_revision:a737c2849f13f47b7808020f1a37c8403da66d92 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ed91446a1c..8efa252b9b * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/960226f4dd..8f37f0d031 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/21462dff93..c282fc3e7b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e9dbf36b50..d12ed9caf2 * third_party/r8/cipd: icXdAothi1iSZHTnk5v4Y_5ZHVS4eJTlAImleVCXl64C..RromJiK-SGOx_w-xDbiEfPi-uNKIxOaw797xkao2FqwC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d676a3164c..43facff7a9 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b8d4c963cc..0af6db3961 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3b13e3ac21..e128247e39 No update to Clang. Bug: None Change-Id: I3efdb824b15efc0b33fb528ffd5625cc1fadb248 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5836099 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll f0d0b014 2024-09-04T10:01:06 Roll vulkan-deps from aa237b66d8cc to 725499142cb6 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/aa237b66d8cc..725499142cb6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/b21dda0ee7a3ea4e0192a7b2b09db1df1de9d5e7..e1782d6675b88225225e331a6318554d473c54db https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/d25bd69eb7d386bc584cbca4f0f005c7ee57535f..c758bac8bf1580b5018adafd3a2ec709237b0134 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/f6381d64213a21d351a1cf83034be78e07f76301..af7b0a35d009b5ad6e0b280a5b81388608ebfe39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Icc83debbf45743192c923a25a04bc703bdf2c810 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5836159 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2d9a2bcb 2024-09-04T10:01:04 Roll SwiftShader from 3c4bdf66d81d to 5561c71fa64e (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/3c4bdf66d81d..5561c71fa64e 2024-09-03 swiftshader.regress@gmail.com Regres: Update test lists @ 3c4bdf66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I5610a917f495d5db864d41362715624bf922ed00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5836139 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Rafael Cintron d1a4b0ff 2019-05-04T17:15:42 Remove Feature Level 9_3 code Feature Level 9_3 was originally added for developers creating apps for devices which did not have the DirectX 9 API and are no longer supported. Hence, we can remove the corresponding code in the 11 backend. Bug: angleproject:355462523 Change-Id: I22db15640b435c61db4d82a815edbc65cecc4e12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5824661 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Alexey Knyazev e13cc7df 2024-08-30T00:00:00 Metal: Add shadow sampler overloads for textureProj[Offset] Added compile guards because sample_compare with bias is not defined for older MSL versions. Fixed: angleproject:354101888 Change-Id: I3972fabc9ebe7b7475343438272e57dcfed007f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5828944 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Igor Nazarov 177d15b3 2024-08-23T19:34:34 Vulkan: Simplify WindowSurfaceVk::prepareSwap() method In case of swapchain recreate inside `prepareSwap()`, perform unlocked ANI call as usual. ANI processing will be done late in `swap()` or `getBufferAge()`. This is possible, because surface `getWidth/Height()` is no longer require valid `mColorRenderTarget`. Because of the above, `swapchainRecreatedOut` parameter was removed. Additionally, `getBufferAge()` now uses `doDeferredAcquireNextImageWithUsableSwapchain()` in order to process possible VK_ERROR_OUT_OF_DATE_KHR error and recreate the swapchain, instead of failing. Test: angle_end2end_tests --gtest-filter=EGLSingleBufferTest.AcquireImageFromSwapImpl* Bug: angleproject:6851 Bug: angleproject:8133 Change-Id: Ieb375781da2b1108d0a5e11dbb012885a946688e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5806335 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Kimmo Kinnunen edc6d2fc 2024-09-02T19:02:11 Metal: Fix watchOS supports32BitFloatFiltering use Avoid using supports32BitFloatFiltering on watchOS, turns out it is not available. Bug: angleproject:360147119 Change-Id: I9ac7101b72d05e06807ba2d18e0fabe7579f62a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5830352 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen 8b8b3d4d 2024-09-02T21:04:11 Metal: Flush with NoWait on iOS when hitting renderpass count limits Avoid deviating between iOS and macOS in this regard. The behavior should be the same for the caller as well as the implementation. Bug: chromium:1466696 Bug: angleproject:363984104 Change-Id: I39160bcc0a54ea9c767e1109d80cb4d71ecdf207 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5830799 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen e5532e6c 2024-09-02T20:55:58 Metal: Avoid using Display::prepareForCall The call can be disabled if CGL and EAGL are not in use. Bug: angleproject:363916154 Change-Id: I4aafddec37daae4470316e2ea70a48e4489573b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5830798 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll c997a32b 2024-09-03T10:01:51 Roll vulkan-deps from c9475650ea41 to aa237b66d8cc (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c9475650ea41..aa237b66d8cc Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/12cbda959b6df2af119a76a73ff906c2bed36884..a496a34b439022750d41d2ba04fbbe416ef81c9a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/2761c159b9325baa5980e028ac081963b5d5dd9c..d25bd69eb7d386bc584cbca4f0f005c7ee57535f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/7e82aea5fc1394d417a0df6a5680a4cce5c37286..4c63e845962ff3b197855f3ae4907a47d0863f5a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/7ea05992a52e96426bd4c56ea12d208e0d6c9a5f..fbb4db92c6b2ac09003b2b8e5ceb978f4f2dda71 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/c155770a44493002fefb21b325e3bbe6cbd55e05..f6381d64213a21d351a1cf83034be78e07f76301 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I7c2f99c5ff90a4d5cb271b97719a3a80f4a93450 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5833224 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5108112e 2024-09-03T07:40:50 Roll Chromium from 88be4af3fd72 to def24c080915 (266 revisions) https://chromium.googlesource.com/chromium/src.git/+log/88be4af3fd72..def24c080915 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5ecde98563..469c6d5062 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ce01263a75..0811404e1e * buildtools/linux64: git_revision:225e90c5025bf74f41dbee60d9cde4512c846fe7..git_revision:50ecf4c84d08dad3d16d14590221dd43fe65ea62 * buildtools/mac: git_revision:225e90c5025bf74f41dbee60d9cde4512c846fe7..git_revision:50ecf4c84d08dad3d16d14590221dd43fe65ea62 * buildtools/win: git_revision:225e90c5025bf74f41dbee60d9cde4512c846fe7..git_revision:50ecf4c84d08dad3d16d14590221dd43fe65ea62 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b0be9a1eed..ed91446a1c * third_party/android_build_tools/error_prone/cipd: VPB1LeLcomm-CeDrV1XZWJ9irPR3kH2viZ3IKZjm5EMC..UUmy7T8JpYWyZicO5hv_doYLkvkPncgf8a99fVSIZOsC * third_party/android_build_tools/manifest_merger/cipd: tGJojLQrpNBHFNNbB7g_ZoGcwbt30dvMfwiT8y3V92YC..rzdFQHQmRPlBZaKYPTWDw5qBToQZ2NXthGS1xXSh190C * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/38d6ad0fe6..e9dbf36b50 * third_party/turbine: 0x14qVQmOdhVAM7Sygzzwm0xfTjL7Bl-0I642feaCSkC..aLKJszAm9PXh5T9KNcDH0MQJeEAIpEiFAYVEimlKdDsC * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/bd3ae34fa1..a7bb45e874 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/490234e516..3b13e3ac21 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I6fde69ec6e169025c22c567ba02a1fa50a8a677b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5832053 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cf9e7fa5 2024-09-02T10:01:35 Roll vulkan-deps from 183438492d3f to c9475650ea41 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/183438492d3f..c9475650ea41 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/fbda05468ec5956bc4f163b50c18b8df9312cdee..c6391a7b8cd57e79ce6b6c832c8e3043c4d9967b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/562b182f9c6443020c1d29192e6bc6a57f193e47..c155770a44493002fefb21b325e3bbe6cbd55e05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I2bb777ac4d11d98da18ae731a9a97ce970c4984b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5832122 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 377f7b68 2024-08-30T11:59:41 Vulkan: Remove redundant needs-flush check in glClientWaitSync `SyncHelper::prepareForClientWait` calls `SyncHelper::getStatus`, which already causes pending flushes in the share context to be performed. The second call in `SyncHelper::prepareForClientWait` was redundant and a no-op. Bug: b/362604439 Change-Id: I125e3e5773d29976fe916c3e2f78733f12c72ed0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5823558 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ac82ae70 2024-09-02T08:45:09 Roll VK-GL-CTS from f1cd1d841346 to 7d2299e67fe7 (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/f1cd1d841346..7d2299e67fe7 2024-09-01 javed@igalia.com Add coverage for multiple queue submits 2024-09-01 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-08-30 gleese@broadcom.com Remove isSkippedPixel from derivative tests 2024-08-30 scerveau@igalia.com video: remove obsolete define ES_STATIC_COMPILATION 2024-08-30 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-08-29 lorenzo@khronosgroup.org Update Vulkan spec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I14c959a0342687989c0e5c6ac9a88b244c96feba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5832121 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov 636d838e 2024-08-27T16:30:04 Vulkan: Decouple Window Surface width/height from color RT `mColorRenderTarget` is invalidated in `releaseSwapchainImages()` method, when swapchain is recreated. It remains invalid until ANI result is processed in the `postProcessUnlockedTryAcquire()` method. In case if swapchain recreate and processing of the results are done in different API calls (prepareSwap and swap), other thread way query invalid render target size using `eglQuerySurface()` API. Currently this should not be possible, but may change in the future. Another way to have invalid render target, is if ANI fails after swapchain recreate. To avoid above problems, surface size is cached after swapchain is recreated. Implementation is moved to the `SurfaceVk` base class. The `WindowSurfaceVk::getRotatedWidth/Height()` methods were unused. `mColorRenderTarget` is now only acessed after ANI result is processed. Bug: angleproject:1319 Change-Id: Ibc007f1e8d30b6281be93c4561e05dd2f14f44d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5816834 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Igor Nazarov 74816e9e 2024-08-29T15:58:22 Vulkan: Cleanup RenderTargetVk release/destroy methods Current implementation of `release()` and `destroy()` methods does not actually invalidate state of the object. All they do is manage the Framebuffer cache. The `release()` method renamed to `releaseFramebuffers()` to match its behavior. Added new `releaseImageAndViews()` method that calls `releaseFramebuffers()` and also null the pointers in order to catch invalid usage in ASSSERTs (for example: usage of `SurfaceVk::mColorRenderTarget` after swapchain recreation but before ANI processing). `destroy()` is updated to also call `reset()`. `releaseFramebuffers()` is only used in `TextureVk` class. In case of `releaseImageViews()`, arrays are cleared, so there is no point calling `releaseImageAndViews()`. In case of `refreshImageViews()`, render targets may be reused, since all pointers remain valid. `RenderbufferVk` and `WindowSurfaceVk` are using new `releaseImageAndViews()` and updated `destroy()` methods. Other changes: - Replace clearing of RT arrays in `TextureVk::setImageHelper()` with ASSERTs. - Fix ASSERT in `TextureVk::releaseImageViews()`, but it seems that this code path is impossible. Bug: b/234769934 Change-Id: I431d25b81dd4dd343149c12e680e5c997aa18436 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5822575 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
angle-autoroll 5d306ca4 2024-09-02T07:49:07 Roll Chromium from 32ac9da2c5a2 to 88be4af3fd72 (439 revisions) https://chromium.googlesource.com/chromium/src.git/+log/32ac9da2c5a2..88be4af3fd72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/16184cdb32..5ecde98563 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ce0161ffa0..ce01263a75 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/147155281a..b0be9a1eed * third_party/android_build_tools/manifest_merger/cipd: h5Atz8TKYBaDMfiwvbH5UT3JFoe0Xfe16LXYdqUW8O0C..tGJojLQrpNBHFNNbB7g_ZoGcwbt30dvMfwiT8y3V92YC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d794c84ff3..960226f4dd * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2836a02f55..b89b440351 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e6b5251bf5..38d6ad0fe6 * third_party/r8/cipd: jy1tjy7CukaTPONDmbQkYfPQnLhwqa2Si_JlIIVSHLIC..icXdAothi1iSZHTnk5v4Y_5ZHVS4eJTlAImleVCXl64C * third_party/siso/cipd: git_revision:10bd8dc16d411e512d5a9d0cfe7435a7cee10071..git_revision:578c7a731c5efa9fde8ef210e34e38df0bcf0d34 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/4f3ee3fd09..d676a3164c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/11d66c472e..490234e516 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I21f2f103967535b4d855f4aca87025e10898bddc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5831537 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 8b6b1113 2024-08-30T16:06:17 Vulkan: Fallback to host unCached if no cached memory available Android studio may not have any host cached memory. This CL will make it use unCached memory in this case. User of this memory will still treat it like cached and try to flush/invalidate cache, but these flush/invalidate call will early out, so they should still work. Performance wont be good, but that is the best we can do to make it work instead of crash. Bug: b/363347052 Change-Id: I68ac917585f6f5672a75085c397858bdc28687e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5828132 Reviewed-by: Lars Harrison <slumpwuffle@google.com> Auto-Submit: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 21b286a1 2024-08-28T15:06:10 Trace replay: Call glFinish before screenshots On some platforms we're getting partial or no results in the screenshot, even though it ends up displaying correctly on screen. Adding a glFinish before glReadPixels clears up the issue. Bug: b/42263221 Change-Id: Id5d2384c01fece1f7cd4d79b7cc599d082fb2864 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5824180 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Charlie Lao 20e0b83a 2024-08-30T11:05:09 Vulkan: Expand preferSubmitAtFBOBoundary from ARM to all tiler GPUs On S24, enable preferSubmitAtFBOBoundary flag boost black_clover_m frame time significantly. The app uses occlusion query which was blocking the CPU to encode next frame until one of the previous frame's render pass is completed. Enable preferSubmitAtFBOBoundary makes the render pass being submitted early which reduces the query wait time, which in turn boost GPU utilization and bumps GPU clock. This reduces frame time of black_clover_m from 23.8ms to 6.4ms, even much better than native's 16ms. It could impact power usage as well, a little bit harder to tell without data that it will be better or worse. For now, I am enabling this for all tiler based GPUs and we can re-evaluate if any problems comes up. This would potentially also benefit other desktop GPU as well, but I am not touching these until we have data showing the benefit before enabling it. Bug: b/362555815 Change-Id: Ie7a5231350389c49091bb2771c542b4439c9c227 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5829781 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 56ea2edc 2024-08-30T11:01:48 Traces: Update regex for power rails Bug: b/354006406 Change-Id: If014c49ccdbb6e0a57c0dc88833511049c3578ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5828131 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll a2a9c686 2024-08-30T17:56:20 Manual roll Chromium from b5ec9af34e67 to 32ac9da2c5a2 (781 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/b5ec9af34e67..32ac9da2c5a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2c70f3683e..16184cdb32 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/44c93928ad..ce0161ffa0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2b3a90645e..147155281a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ed92bd5a90..99be9e63c8 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/a7f3606481..a828b2c3d4 * third_party/android_build_tools/error_prone/cipd: rFlGLiGUWHZuXRxyaWP5D1dxSJp79SS06p9S0E2HIXoC..VPB1LeLcomm-CeDrV1XZWJ9irPR3kH2viZ3IKZjm5EMC * third_party/android_build_tools/lint/cipd: knwfPKstRSh1B-e2cENtTrOmhehHsYsYeAC_yzBDDY0C..McDb8dEvTYCUAegJWyiNM_wadZHqcKTnf9mRocsu9LcC * third_party/android_build_tools/manifest_merger/cipd: u_GJEAN3XSfdXjiTZMFk5_bR6Jepu0t3K7BIeesb8uwC..h5Atz8TKYBaDMfiwvbH5UT3JFoe0Xfe16LXYdqUW8O0C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0e9c56bbf4..d794c84ff3 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/783f19f6e1..14ebe73674 * third_party/android_sdk/public: fv6JzkTqfxfIbmsRC8u1b2y0EQO7yQDMDzY3-g0NVu4C..B4p95sDPpm34K8Cf4JcfTM-iYSglWko9qjWgbT9dxWQC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9b4fe2aacd..21462dff93 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/22f6c9d8e9..2836a02f55 * third_party/fuchsia-sdk/sdk: version:23.20240823.0.1..version:23.20240830.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d8d9de41d7..e6b5251bf5 * third_party/r8/cipd: bkA7QgnyJtoxOVZ6JF9qXTD-ddmw5xXBnlamEm6kTBkC..jy1tjy7CukaTPONDmbQkYfPQnLhwqa2Si_JlIIVSHLIC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8ed6a7e581..11d66c472e No update to Clang. Bug: None Tbr: abdolrashidi@google.com,ynovikov@google.com Change-Id: I56cce5734dd833472726f1a5868b66c54e00e43b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5828575 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao e4be31ca 2024-08-29T14:30:11 Test: Add VertexAttribPointer test with different offset The first test draw with VertexAttribPointer with smaller offset and then followed by draw with VertexAttribPointer with larger offset. The second test draw with larger offset and then followed by draw with smaller offset. They will exercise logic in backend that may reuse the conversion buffers (when forced format fallback is used). Bug: b/357622380 Change-Id: If325a0547e5f80305125f448e9f987896f3e35bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5827285 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 4167a9a0 2024-08-29T23:38:05 Don't lock the context mutex if no flush in eglClientWaitSync Bug: b/362604439 Change-Id: Ic514bcb3824514b5fd82ebb14ab97286aeb6557c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5828262 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 4e3b4e0c 2024-08-21T16:56:47 Vulkan: Clear conversion buffer's dirtyRange if bufferData called If BufferData is called, the previous dirtyRange on the conversion buffer is no longer valid (the original data in BufferVk is no longer valid). This CL clears the dirty range in conversion buffers so that they do not gets unnecessarily converted. Bug: b/357622380 Change-Id: Ic97c867a8d2141659a0ffd269049f9d4168a421f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5804531 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 27a0a5ed 2024-08-29T23:23:19 Vulkan: Only access ContextVk in EGLSync if asked to flush Bug: b/362604439 Change-Id: Ifec413628de88e9048e8134c2c5e9497970f358c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5828261 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao e4aab5cc 2024-08-13T14:54:19 Vulkan: Reuse the same conversion buffer by adjusting offset In some usage case where app calls bufferSubData and then calls glVertexAttribPointer to source vertex from different offset, we could still just reuse the existing VertexConversionBuffer instead of create a new one. The benefit with this is that all previous converted data are still valid, thus reduce the overall conversion, and reduce the number of conversion buffers and saves memory. Bug: b/357622380 Change-Id: Ifcf626427e2ed500d6ab617541b78a60839d9acd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5785670 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov 4dfba10a 2024-08-30T15:05:44 Skip passmark_complex on Linux Intel Bug: b/362801312 Change-Id: I743261c7f5086d5aaf98d28c1b32fa494c0fc2e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5822715 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 8d6f6c23 2024-08-29T14:56:31 Vulkan: Unsuppress fixed VVL errors Bug: angleproject:361600662 Change-Id: Ic4585f4b38261f69700a9703bdb10b60e18f638a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5826762 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev d886a0fb 2024-08-29T00:00:00 Metal: Remove unused platform macros ANGLE_APPLE_AVAILABLE_XCI and ANGLE_APPLE_AVAILABLE_XI are no longer used. Bug: angleproject:360147119 Change-Id: I872fbe994a352673a6e9ad6468f0141c3ed98694 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5823423 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
kmx.io     mail     discord kmxgit v0.4.0