kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 5259efe8 2023-12-11T07:48:58 Roll Chromium from 27249fedce4b to f9f8b1a54ff6 (725 revisions) https://chromium.googlesource.com/chromium/src.git/+log/27249fedce4b..f9f8b1a54ff6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6fdac9cc5e..e2ef5faece * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9a7b235810..48eb5d0b33 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1633d23fc7..8a289204b0 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/025aa883df..15a737bc5c * third_party/android_build_tools/manifest_merger: SdNR04V227YL22FMmKoS4AdLYwv6MJe8HBAZKNhXoCsC.._2qAeWRS5XnDom8pAt4e7GuEof_KB86zQO0Lnr5uQBQC * third_party/android_toolchain/ndk: XSjN84pHxBPX13CrUj3fQjEroncvFGGeJY9wDVEDswoC..NSOM616pOQCfRfDAhC72ltgjyUQp9lAWCMzlmgB18dAC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/69bde63990..6edbd6b5ca * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/05a55efaa9..1714cc6e5a * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4ab8957af3..16665d119a * third_party/r8: NyEPLS024hp8BUV5gx7DSIZzgCEWY-tevgRF8F1RWYgC..w4FEa7Y-q3MIsKwjR0LC_-fPnANe8DlIIAWD_pMF5z0C * third_party/siso: git_revision:acf6e472017229d73c507e50c8660c2d3a2021e0..git_revision:d8744c99a9e175e6c4569de0717bd8c53981ce0c * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/143660d186..147f175921 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/28cba3ec32..3ccfff74a0 * tools/luci-go: git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae..git_revision:0ffd60c8bd4fa542fb8d7c6a60ead9b96dc4387a * tools/luci-go: git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae..git_revision:0ffd60c8bd4fa542fb8d7c6a60ead9b96dc4387a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/2206f69ffd..0da27905d2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e582bc0452..bc59d8d3cf * tools/skia_goldctl/linux: Zoe29KUyqS2oKisSjN23NSWAF2ABY3oXtvnMcmNgFf8C..gF8-tllaG53TS_NMzDyBBEon5i-UMVdhPADIv_39ZpsC * tools/skia_goldctl/mac_amd64: JqbiGnBxG8TPvCgKA3OOreiQ59Tn_xZoQOrWCP7rzOUC..5z5sg3DatlGfhGSg6wO3JTMyBofd0Dr9_bCBVDBfuJYC * tools/skia_goldctl/mac_arm64: 6U5_zURvPx2a03ZdJP9q_CPrUrIp3nU7x9u9a7ZWvFsC..tJys4TOPo-asafdTKs677RtNMEWct4WvJ4-SDmdqoYkC * tools/skia_goldctl/win: zEvgRWYnnTxGYfan6MIEqFyxyBfzgryl755RHBP98wYC..wCfWvHnVA6RiLbvH5NL3Pc51a6uladkFepTSj06s370C No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Idb8348aad9d291c7dc77f83be889637083d982e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5108441 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gowtham Tammana c8507249 2023-12-07T13:34:22 clspv: Move it to third_party/clspv/src Clone the clspv into third_party src location to make way for GN build files. Bug: angleproject:8369 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Change-Id: Id27d131ca7d5c0e941d9d770924587cdd3e5d8e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106593 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 7288507c 2023-12-07T00:00:00 Lift SNORM framebuffer completeness suppressions The CTS has been updated to allow GL_EXT_render_snorm exposure on OpenGL ES 3.0 contexts. Bug: angleproject:8048 Change-Id: If00df67dbcb541565ad236983b9d406a9f4444e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106510 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev bc301691 2023-12-07T00:00:00 Run PackUnpackTest on all backends Fixed negative zero serialization for capture/replay. Bug: angleproject:4092 Change-Id: Ic12a556f56e40064da8bf3a8ce7d01af92c7086a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106509 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev ede15b85 2023-12-07T00:00:00 Metal: Run multi draw tests Added ANGLE_INSTANTIATE_TEST_COMBINE_3. Used the new macro for multi draw and BVBI tests. Bug: angleproject:6963 Change-Id: If05800f92f670bf21b7ff889a2fb8bb30f62a488 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106508 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao d0eb968d 2023-12-08T16:11:46 Vulkan: Fix the AHB leak for AHB backed buffer object For client buffer backed OpenGL buffer object, we call InitAndroidExternalMemory which calls AHB acquire. But when buffer object is released/destroyed, we never call ReleaseAndroidExternalMemory, which end up leaking AHB. Bug: b/314791770 Change-Id: I693c74213e73008497a6dfeca93ea62e84c71352 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106599 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Charlie Lao <cclao@google.com>
Alexey Knyazev 0b0b4b22 2023-12-07T00:00:00 Avoid UB in VertexAttributeTestES3.DrawWithUnalignedData The test uses a signed normalized vertex attribute, which requires a floating point vertex input. Bug: angleproject:7001 Fixed: angleproject:7068 Change-Id: I97afc97b03a58130e0d6ee63ec7ee3e44f1e0230 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5105194 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 87eee12f 2023-12-08T22:01:29 Manual roll vulkan-deps from fb2389e52832 to 510bed662233 (8 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/fb2389e52832..510bed662233 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/e6b013a492..f349c91274 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a0308b56d8..0133778cb1 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/2feac58733..4a89051018 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/847a8a1f8a..3d6bdd9dc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2105b0b769863e8e1c57f32ff5f609f9d313bdfc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106850 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f57ab75f 2023-12-08T16:45:00 Roll VK-GL-CTS from af594bc856e5 to ecdec25ff753 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/af594bc856e5..ecdec25ff753 2023-12-08 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2023-12-08 gleese@broadcom.com Remove descriptions from all Vulkan test groups 2023-12-08 rgarcia@igalia.com Switch vertex input binding stride without binding new buffers 2023-12-08 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2023-12-07 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2023-12-07 ziga@lunarg.com Add MSRTSS tests where input attachment is not rendered to 2023-12-07 rgarcia@igalia.com Test null multisample state with alphaToOne disabled 2023-12-07 javed@igalia.com Add test for gl_PointSize clamping on max point size. 2023-12-07 ziga@lunarg.com Add vkMergePipelineCaches tests 2023-12-07 russellc@nvidia.com Add setVisible for VulkanWindowDirectDrm 2023-12-07 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2dc00b81e97ed5d90ebf8d0dae44be571ee2044b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5105590 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang c27a4a1d 2023-11-27T14:44:07 Re-use EGL sync object allocations. Create a pool of EGL sync objects with their implementations that can be re-used. Update all backend implementations to support multiple calls to initialize/destroy. Pool size of 32 chosen through experimentation using Chrome. Bug: angleproject:8430 Change-Id: I86fea41aed35eddccc953efb3802bf5fdb7f3cb2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5063341 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 4732409f 2023-12-08T07:01:01 Roll Chromium from e567f1f8ed1d to 27249fedce4b (492 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e567f1f8ed1d..27249fedce4b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8b5921ef0c..6fdac9cc5e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a19d89f939..9a7b235810 * buildtools/reclient: re_client_version:0.123.1.b4c22d0-gomaip..re_client_version:0.124.1.13f78cc-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/eb3062b377..1633d23fc7 * third_party/android_build_tools/lint: 0myhyR77F6-p8FkluxgAw-t0PcSPOLVMoRUV8zqCBIkC..HauAZeOm40GKv93v51MaoIilRbuPDo29QhN98r7kQaMC * third_party/android_toolchain/ndk: NSOM616pOQCfRfDAhC72ltgjyUQp9lAWCMzlmgB18dAC..XSjN84pHxBPX13CrUj3fQjEroncvFGGeJY9wDVEDswoC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/97b05366a4..69bde63990 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/60f6c8a860..05a55efaa9 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/df5952f59c..4ab8957af3 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e88fcc906f..d5e7c425e0 * third_party/r8: g0IMQK-a9MiyqyQd6f26Ut45q36vivXE9UFtVa8mM38C..NyEPLS024hp8BUV5gx7DSIZzgCEWY-tevgRF8F1RWYgC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/925b4391a1..143660d186 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/85bbbfc395..e582bc0452 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I7f9952ec63d700c10aaa0772c9045054943a1de5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5101972 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi b8ca8de4 2023-12-05T13:36:53 Vulkan: Don't crash when glCopyTexImage2D redefines itself The Vulkan backend marks a level being redefined as such before doing the copy. If a single-level texture was being redefined, it releases it so it can be immediately reallocated. If the source of the copy is the same texture, this causes a crash. This can be properly supported by using a temp image to do the copy, but that is not implemented in this change. Bug: chromium:1501798 Change-Id: I9dde99aa0b88bc7d5f582ff15772f70b36f424e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5089150 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 8dbdd57c 2023-12-07T11:21:13 Roll vulkan-deps from bc34fe665e84 to fb2389e52832 (16 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bc34fe665e84..fb2389e52832 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/0fedf7d95a..9a35abff55 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/7c335edc66..e6b013a492 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/cca08c63ce..1c6bb27435 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b79c10bac1..a0308b56d8 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/67cda9672b..1ee9eea9f1 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8739b87fcf..847a8a1f8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2fa61f5e9913a16afe90428d154fa01767927456 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5099084 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e4f1f1e3 2023-12-07T09:34:24 Roll Chromium from d6f0715fbaaf to e567f1f8ed1d (592 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d6f0715fbaaf..e567f1f8ed1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7d0812ef48..8b5921ef0c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/894e045303..a19d89f939 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dbd7cb3e68..eb3062b377 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/0764ad493e..025aa883df * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/093f85fdf8..97b05366a4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/916dda0a0b..60f6c8a860 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7f2dd14f5d..df5952f59c * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/4cb5c2cefe..e88fcc906f * third_party/r8: ntZT6d-gLBdyTo-D6ie-hZXbQqDe_YNG3RK5ah85jBsC..g0IMQK-a9MiyqyQd6f26Ut45q36vivXE9UFtVa8mM38C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/991b697d2c..28cba3ec32 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3044fe1fd3..85bbbfc395 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ic8e78f63b2f5105b3b48110ce7a5718b5bb4f62b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5098158 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fd957a65 2023-12-07T10:01:49 Roll SwiftShader from 4befa3ada54c to 77be35e337bb (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/4befa3ada54c..77be35e337bb 2023-12-06 syoussefi@google.com Remove VK_GOOGLE_sampler_filtering_precision If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I8d914be718336ec2ca119b1737399d42c0dea5cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5098532 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi dc4b1acd 2023-11-30T15:42:32 Translator: Limit private variable size to 64KB This is indirectly fixing an issue where passing large arrays in SPIR-V such that an internal cast is needed (such as array inside interface block copied to local varaible) causes an overflow of the instruction length limit (in the absence of OpCopyLogical). By limiting the size of private variables to 32KB, this limitation is indirectly enforced. It was observed that all the test shaders added in this CL fail on the Nvidia OpenGL drivers, so such a limit seems to be reasonble. Bug: chromium:1505009 Change-Id: Ia36134b2bf8501a5b875814db3566be28b183e0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077408 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d788c2c0 2023-12-04T22:43:39 Remove team members no longer part of the project Bug: None Change-Id: I66bf34ece50995fdecfab55a2198e9946e9be4cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5087208 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 6d9f0aee 2023-11-30T00:00:00 Metal: Ensure helper invocations when derivatives are used Set sample coverage mask to ensure that fragment shader helper invocations are performed when derivatives are used. Fixed the following tests on Apple silicon: dEQP-GLES2.functional.texture.mipmap .2d.projected.nearest_linear_repeat .2d.projected.linear_linear_repeat .cube.projected.linear_nearest .cube.projected.linear_linear dEQP-GLES3.functional.texture.mipmap .2d.projected.nearest_nearest_mirror .2d.projected.linear_nearest_clamp .2d.projected.linear_nearest_repeat .2d.projected.linear_nearest_mirror .2d.projected.nearest_linear_repeat .2d.projected.linear_linear_clamp .2d.projected.linear_linear_repeat .3d.projected.nearest_nearest_mirror .3d.projected.linear_nearest_clamp .3d.projected.linear_nearest_repeat .3d.projected.nearest_linear_clamp .3d.projected.nearest_linear_mirror .3d.projected.linear_linear_clamp .3d.projected.linear_linear_repeat Fixed: angleproject:8443 Fixed: angleproject:7023 Change-Id: I13fc52532b94de098dcf3e9f5f02d48a6c8913c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5089131 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Gowtham Tammana ac4cb708 2023-12-04T16:04:44 DEPS: Add clspv and llvm deps clspv is a OpenCL C to Vulkan compute shader compiler useful for CL implementation on Vulkan. Add these as third party modules in Angle. Bug: angleproject:8369 Change-Id: If31e755525a8e71d727b528d2f3a7f3c7fdd55d8 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5085667 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Daniel Cheng bc7af34c 2023-12-06T00:15:33 Use googletest flag macros to access googletest flags. The implementation details of flags can change; fixing this proactively makes it easier to roll googletest. Bug: chromium:1409870 Change-Id: I5efa2487d9e38e122ca20f201748faf8e8050347 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5092928 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org>
angle-autoroll df5e37b0 2023-12-06T11:10:51 Roll vulkan-deps from 299bb7684789 to bc34fe665e84 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/299bb7684789..bc34fe665e84 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/72b403ad71..0fedf7d95a * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/63656eb768..8739b87fcf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I769266b783e60bd148c8cd6e69cfbd18dd763080 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5094393 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c31476c1 2023-12-06T07:01:18 Roll Chromium from 624a7aa7a053 to d6f0715fbaaf (606 revisions) https://chromium.googlesource.com/chromium/src.git/+log/624a7aa7a053..d6f0715fbaaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b2f7b93383..7d0812ef48 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0ac67b7cef..894e045303 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4837aac5d8..dbd7cb3e68 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e9e09fc19c..093f85fdf8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/963000950b..916dda0a0b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/caccdb0407..7f2dd14f5d * third_party/r8: RVHUDXQq4bO_rJwe8vsZtb57_mnqCVm0WNcp0H9bLecC..ntZT6d-gLBdyTo-D6ie-hZXbQqDe_YNG3RK5ah85jBsC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/60751d2b6f..925b4391a1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/90bafacea8..991b697d2c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/55f4b3f9c4..2206f69ffd * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/569c4f0b27..3044fe1fd3 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I979f5ee6cc809c135668b96bf0e5075af7cec9d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5092689 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop f58ba088 2023-11-05T16:40:37 Tests: Add Warcraft Rumble trace Test: angle_trace_tests --gtest_filter="*warcraft_rumble*" Bug: b/309345647 Change-Id: I6e78fb0465edcfa97943ff8374c568dcd9b8eba7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5007173 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi e9d5f13e 2023-12-04T22:36:41 Vulkan: More trace points in the readpixels path Occassionally we hit a bad path in this case, this change makes it clearer from the traces which bad path is hit. Bug: b/310701311 Change-Id: Ic674d6396b0e88f1a1db3ded7efe195fb7397135 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5087207 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 9bfe5847 2023-12-05T18:44:02 Manual roll vulkan-deps from 66a2496b8cff to 299bb7684789 (32 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/66a2496b8cff..299bb7684789 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a1138bacff..72b403ad71 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/a3da0e87fa..7c335edc66 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0d87845532..6b4f0c9d0b * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/9d27c893cd..19a863ccce * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f4ae60be27..b79c10bac1 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/98d168c168..67cda9672b * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/1fb77ad1d4..2feac58733 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7add1ebaaf..63656eb768 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I69cacef57e9c73161958177269fa87f7c3bda9a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5090128 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev d7077e9f 2023-12-05T00:00:00 Update macOS end2end expectations Bug: angleproject:2273 Bug: angleproject:2408 Bug: angleproject:3837 Bug: angleproject:5325 Bug: angleproject:5360 Bug: angleproject:5594 Bug: angleproject:6358 Bug: angleproject:6418 Bug: angleproject:6454 Bug: angleproject:6457 Bug: angleproject:6540 Bug: angleproject:6702 Bug: angleproject:6751 Bug: angleproject:7068 Bug: angleproject:7309 Bug: angleproject:7445 Change-Id: I7f4c012ed2de6af83188ed69170b19f8d2bb19de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5087774 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 0ff2c771 2023-12-05T15:17:22 Revert "aosp: remove gclient flag --delete_unversioned_trees" This reverts commit c40f1a04271f5a99fda8b9e48b521493210e13bc. Reason for revert: doesn't help Original change's description: > aosp: remove gclient flag --delete_unversioned_trees > > Suggested by Gerrit folks: b/305091097#comment13 > This flag has been set for a long time, but after migration to > submodules it might be causing trouble. > > Bug: b/305091097 > Change-Id: I9eba5bf4ebe192942ab72b7670628f957b03ecc6 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077411 > Auto-Submit: Roman Lavrov <romanl@google.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bug: b/305091097 Change-Id: I6b954f01cb10e030af72e7965343e4007ba21c35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5087159 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Alexey Knyazev 5d70a41c 2023-11-30T00:00:00 Metal: Use a separate struct for last fragment data Used a separate MSL struct type for reading from framebuffer attachments to not fetch unnecessary draw buffers and to be able to set a sample mask. Removed TranslatorMSL::isSampleMaskAllowed() Ensured that the lastFragmentOut variable is not added when PLS does not use framebuffer fetch. Fixed: angleproject:8442 Change-Id: Ia3320fc6063277479b5aa9b7fea34457465add75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5079450 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 37c86f7c 2023-12-05T07:59:50 Roll Chromium from 192be4e9edea to 624a7aa7a053 (615 revisions) https://chromium.googlesource.com/chromium/src.git/+log/192be4e9edea..624a7aa7a053 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9b8bc79c29..b2f7b93383 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d11c27b4cb..0ac67b7cef * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3fdf1cf406..4837aac5d8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/95eabf6f99..e9e09fc19c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/081bca8cb3..963000950b * third_party/r8: 40RdMjvS_7M6jwmYUMU3GHGAayTXD9X2CoOLHzA5HZwC..RVHUDXQq4bO_rJwe8vsZtb57_mnqCVm0WNcp0H9bLecC * third_party/siso: git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae..git_revision:acf6e472017229d73c507e50c8660c2d3a2021e0 * third_party/turbine: e8ccyNXO5wVjI0vv5W8kfA101BaaLNjNiVH1JddpdWkC..M27KV5bN2pvX97rzQXxamxLUFHmKEes8wvZevk8nU2YC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bb2261c395..569c4f0b27 No update to Clang. Bug: angleproject:6430,angleproject:7079 Tbr: abdolrashidi@google.com Change-Id: I5322da02c506baa3c5b245664624f7f2e7707acc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5085585 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 74f9da02 2023-12-04T19:53:25 Vulkan: Remove spam about depth/stencil feedback loop It triggers a warning even if the application is appropriately using BASE and MAX levels to avoid feedback loop. Bug: b/289436017 Change-Id: Ie7e8281908802e91dfaad1b49dd95197ac6de1a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5086070 Commit-Queue: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Cody Northrop 18d51f01 2023-12-03T18:26:12 Tests: Add Black Clover M trace Test: angle_trace_tests --gtest_filter="*black_clover_m*" Bug: b/314683298 Change-Id: Icee6102aa5161f2054134831e00eb99b8048c448 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5082209 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Chris Forbes a1cd2198 2023-12-04T11:42:13 Fix yuv_2_rgb and rgb_2_yuv GLSL function emulation The color conversions themselves were already correct, but Y was assumed to be full range, and u,v assumed to be centered on zero. This change folds the range expansion and chroma bias into the transforms. In order to accomplish the bias the matrices are extended to be mat4x3, and the provided color value is extended to a vec4 with w=1. Various other methods are possible (and potentially more efficient if the standard is not a constant) but just folding everything into the matrices is the most straightforward. Test: atest CtsNativeHardwareTestCases Bug: b/308437613 Change-Id: I33f797450c9ad9e758100eb8530d86548939f4ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5082558 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4f09451a 2023-12-04T07:00:24 Roll Chromium from f38cb20b11bf to 192be4e9edea (197 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f38cb20b11bf..192be4e9edea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f99b6dbc03..d11c27b4cb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0a6bb23039..3fdf1cf406 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/13c08122f7..caccdb0407 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Ibfdee80141a2d855d26b2478b1ee97799a3e12d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5082697 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi fb6b960c 2023-11-27T14:24:28 Remove GL_CHROMIUM_texture_filtering_hint This was using an unregistered Vulkan extension to set the precision of SwiftShader's internal filtering for the sake of Chrome. That's baked in at build instead. Bug: angleproject:8349 Bug: chromium:726075 Change-Id: I12849d2d29d99626f22a92ee9d74366f78658476 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5063344 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 6d3fc554 2023-12-02T15:01:06 Manual roll Chromium from d0afe9132509 to f38cb20b11bf (472 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/chromium/src.git/+log/d0afe9132509..f38cb20b11bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a443f73cbc..9b8bc79c29 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ba3cb9e951..f99b6dbc03 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0c6d88fd75..0a6bb23039 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/be49b4d066..95eabf6f99 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cccca95d8f..081bca8cb3 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/3467ae2512..13c08122f7 * third_party/r8: A5uzwWQ1XpXtSZMcM7n-u9qcngzVKnyyRVBrJw1STFMC..40RdMjvS_7M6jwmYUMU3GHGAayTXD9X2CoOLHzA5HZwC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/67da756b88..dd5fc1316c * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/3ee0331f3c..60751d2b6f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b084c92e02..55f4b3f9c4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d55cd8bab4..bb2261c395 No update to Clang. Bug: None Tbr: romanl@google.com,syoussefi@google.com Change-Id: I18600aa55d1eb98b9c2a338bd3d67e3e3a39a8d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5081264 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 90767546 2023-12-01T12:27:15 Vulkan: Add test for __samplerExternal2DY2YEXT then swizzle Added a correctness test SourceYUVTextureTargetExternalRGBSampleYUVSampleWithSwizzle for applying swizzle after sampler. Also removed some bug workaround for VVL and drivers since they are fixed now. Bug: b/309480316 Change-Id: If82b2251745a96335b535c67b6e0c0847268b25b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5080497 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 554d761a 2023-12-01T15:14:22 Tests: Add AFK Arena trace Test: angle_trace_tests --gtest_filter="*afk_arena*" Bug: b/314365671 Change-Id: Id0213199b0e75919701be8ec9e216a224a6725d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5078682 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi caa5e4ea 2023-11-30T14:12:42 Translator: Fail compilation if too many struct fields If there are too many struct fields, SPIR-V cannot be produced (as it has a hard limit of 16383 fields). The Nvidia GL driver has also been observed to fail when there are too many fields. Bug: chromium:1505009 Change-Id: If9b01716c1cab35a6e537da64421e29fe0eda91e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5074629 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Mark Lobodzinski 25f448f4 2023-12-01T12:33:27 Tests: Add Walking Dead Survivors trace Test: angle_trace_tests --gtest_filter=TraceTest.walking_dead_survivors Bug: b/314311102 Change-Id: Icf104613b59a8de0f89fc5fa3dd6db4ad9a3dc2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5080498 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 6df603ed 2023-11-30T13:53:00 Translator: Optimize field-name-collision check As each field of the struct was encountered, its name was linearly checked against previously added fields. That's O(n^2). The name collision check is now moved to when the struct is completely defined, and is done with an unordered_map. Bug: chromium:1505009 Change-Id: If28d738254a541450912eba4ed168424dad9d8be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077407 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll 77812001 2023-12-01T15:11:52 Manual roll vulkan-deps from f4204cd3fb57 to 66a2496b8cff (1 revision) Manual roll requested by romanl@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/f4204cd3fb57..66a2496b8cff Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/64fb8917ea..7add1ebaaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I5bf8e2b9960543a316e5f4432cd3b2e9b4297010 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5079284 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Sergey Kataev 75e13e68 2023-11-29T22:19:46 Metal should not inline non-const global initialisers Bug: angleproject:8403 Change-Id: Iaa6126d7043931a16104ea84c5f7e737017dabc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5076256 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Sergey Kataev <sergeyka@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 0f7dedef 2023-12-01T18:08:01 Roll VK-GL-CTS from faf4fbbc8f8e to af594bc856e5 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/faf4fbbc8f8e..af594bc856e5 2023-12-01 sricker@nvidia.com Add additional vksc descriptor pool tests 2023-12-01 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-12-01 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2023-12-01 rgarcia@igalia.com Regenerate mustpass for main 2023-11-30 rgarcia@igalia.com Test Z Export without MS info in frag shader library 2023-11-30 ziga@lunarg.com Enable required features in nested_cmd_buffer tests 2023-11-30 anna.lesniewska@intel.com Use compute queue instead of transfer queue in compute queue support check 2023-11-30 mirela.nicolescu@broadcom.com Descriptor_indexing tests: use nearest filtering 2023-11-30 rgarcia@igalia.com Test many indirect draws and dispatches in sec. cmd. buffers 2023-11-30 rgarcia@igalia.com Add new multi draw tests that do not depend on DrawIndex 2023-11-30 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ic76aca3e99b1671cef6c0bf228a3c659e012f52d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5079058 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9a7e4882 2023-12-01T14:36:53 Manual roll Chromium from 996514892366 to d0afe9132509 (733 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/chromium/src.git/+log/996514892366..d0afe9132509 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bb826aaf00..a443f73cbc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b17c7e870e..ba3cb9e951 * buildtools/reclient: re_client_version:0.121.0.e622934-gomaip..re_client_version:0.123.1.b4c22d0-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9213eae588..0c6d88fd75 * third_party/android_build_tools/lint: hPW0THuEdVxwGMSWqn9CZgyFBNXe9sXc2NJsh1hiliIC..0myhyR77F6-p8FkluxgAw-t0PcSPOLVMoRUV8zqCBIkC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ee967548fe..be49b4d066 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9e5fc28b6b..cccca95d8f * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0ad014cff4..3467ae2512 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/bbe2764382..278e5fbafc * third_party/r8: 1cleC9ETmNTNjX-TQoPj14Siz7FFAy6HR6x5pbSS00oC..A5uzwWQ1XpXtSZMcM7n-u9qcngzVKnyyRVBrJw1STFMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/990e9cdeeb..90bafacea8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5b7313d3e5..b084c92e02 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/913a358a00..d55cd8bab4 Clang version changed llvmorg-18-init-12422-g74cdb8e6:llvmorg-18-init-12938-geb1d5065 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/990e9cdeeb4b639b6468a7f11206d22b6ecc258e..90bafacea8b63686eb658a8249a9f719e0df9981/scripts/update.py Bug: None Tbr: romanl@google.com Change-Id: Ia6437b21f40253effcd0f4857677be0c00c1c620 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5079282 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi ab992c3e 2023-12-01T11:51:13 Clarify which link failed in link program perf test Bug: angleproject:8417 Change-Id: I5445518fdf6dcc2533ea055588221d6e45c45d9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077412 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b46cf698 2023-11-30T11:00:18 Vulkan: Fix Android deadlock with querying buffer age Similar to eglSwapBuffers, eglQuerySurface with EGL_BUFFER_AGE_EXT can cause a call to vkAcquireNextImageKHR. Bug: angleproject:6851 Bug: b/313975825 Change-Id: If3f0521219cab9aba2aeb2b70958bf0f197bc96a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077406 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev edcfab40 2023-11-23T00:00:00 Metal: Implement textureCubeGrad transformation for AGX Wrapped all affected built-in function calls with helpers that transform derivative values. Fixed all *.texturegrad.* dEQP failures on Apple silicon. Fixed: angleproject:7021 Fixed: angleproject:8433 Change-Id: I16b023840ad267ab72d31fde3cb0fa7048e5310c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5071254 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Roman Lavrov eef89870 2023-12-01T09:47:40 Trace tests: skip mini_world on win intel native Flaking Bug: angleproject:8440 Change-Id: Iff415531d4820937ef5e42c8fcba05c305494c38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5078288 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov c40f1a04 2023-12-01T09:17:04 aosp: remove gclient flag --delete_unversioned_trees Suggested by Gerrit folks: b/305091097#comment13 This flag has been set for a long time, but after migration to submodules it might be causing trouble. Bug: b/305091097 Change-Id: I9eba5bf4ebe192942ab72b7670628f957b03ecc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077411 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 7f1d9e05 2023-12-01T10:01:53 Roll vulkan-deps from 9bc701361bf9 to f4204cd3fb57 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9bc701361bf9..f4204cd3fb57 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/3f615ad93e..a1138bacff * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f4a73dd7a0..0d87845532 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ced1ecb526..f4ae60be27 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/923226cb92..64fb8917ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I0a46f4004b5933add9b27c68f6d8b53cd0bce3bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5079271 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 3fe678c9 2023-11-30T12:15:57 Avoid malloc in VertexArrayVk::mergeClientAttribsRange Replace temporary std::vector with angle::FixedVector Bug: b/300968773 Change-Id: I002233afc99c0eb03a5ad11ab7a5bfd85626b3a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5074625 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 3680a5dc 2023-11-17T13:51:07 Vulkan: Let program warmup continue passed link The warmup task does not actually affect the link results, so there is no reason to wait for it when the application queries the link status. This change allows the warm up task to continue in parallel until the program is used at draw time. This allows the warm up to be more efficient when the link itself is not parallelized. For applications that create programs in the middle of every frame, it's still likely best to disable warm up (as the following immediate draw will already effectively do the warm up). Note that currently the warm up code in the Vulkan backend is not completely thread-safe, and so the program still blocks on that task before the first draw can happen (or the program is modified in any way). Bug: angleproject:8417 Change-Id: I0877fef39a0585c3279e32699ce817d4643d7cd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5037538 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yiwei Zhang d842f3db 2023-11-29T06:53:58 Vulkan: add a disableSeparateShaderObjects feature Dota Underlords uses one PPO and keeps swapping the attached program. Though we get cache hit, the hundreds pipeline creation calls still amount to non-trivial CPU overhead via ANGLE. The use of SSO has been disabled by the app in certain cases, and this feature is added to support entirely disabling SSO in ANGLE on all Vulkan backend impls. Bug: b/309028728 Test: Dota Underlords easily hits target FPS on ANV and RADV Change-Id: I54532975237218563b8750f1878a83e386fe776d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5073414 Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 58a32acc 2023-11-30T10:01:00 Roll SwiftShader from 35b1a501141a to 4befa3ada54c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/35b1a501141a..4befa3ada54c 2023-11-29 syoussefi@google.com Remove Jonah from OWNERS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I129612b51ac64aeb03aacf03344f7dcc13983111 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5076105 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c10dea22 2023-11-30T10:01:23 Roll vulkan-deps from c41e80cec06c to 9bc701361bf9 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c41e80cec06c..9bc701361bf9 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/c59b876ca0..3f615ad93e * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/50e90dd74e..a3da0e87fa * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/afaf8fda2a..f4a73dd7a0 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/cf32131e12..ced1ecb526 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b994b0d458..923226cb92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I93a42e4cc56cdab212c3b924f8c7da15da91b3f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5076259 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9a5058be 2023-11-30T07:46:08 Roll Chromium from a2a7acf06e25 to 996514892366 (702 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a2a7acf06e25..996514892366 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f9cc71c99c..bb826aaf00 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c65da25aed..b17c7e870e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/342c05bb4d..9213eae588 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ec903ccd87..0764ad493e * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/3470538450..c4a82efb2f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2823d8f8be..ee967548fe * third_party/fuchsia-sdk/sdk: version:16.20231117.2.1..version:16.20231129.1.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6cd38f6d30..0ad014cff4 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c21fd3819a..4cb5c2cefe * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/85df028e4c..bbe2764382 * third_party/r8: o6MAAUwWCotub-YLAZV6fewtgr4AUJUrZpDwervcrtMC..1cleC9ETmNTNjX-TQoPj14Siz7FFAy6HR6x5pbSS00oC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/7b4829c7a3..67da756b88 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a1a98c84ca..5b7313d3e5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5e2447e2fb..913a358a00 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I5d38de547bb8a49bab8d9c2db3bf469558b68284 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5076359 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 6f4f5e39 2023-11-18T22:15:49 Fix checking result of link sub tasks Bug: angleproject:8297 Change-Id: I143a26be6e7340a4a2d2b917bbe4dd9dd474f7af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5042346 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao b746dc3b 2023-11-29T17:40:53 Vulkan: Fix assertion when texture's min/mag filter disagree Camera CTS test testCameraGpuEncoderPath[1] is hitting assertion due to minFilter is NEAREST but magFilter is LINEAR. This CL use sampler's filter if min/mag agrees. Otherwise it uses default YCbCr chroma filter. The min/mag filter will still apply separately if VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_SEPARATE_RECONSTRUCTION_FILTER_BIT is set. If this bit is not set, we will force all of three filter to be the same anyway. Bug: b/302196568 Bug: b/308208067 Change-Id: I19007a107cfcea0f839cb66c236a70c003c43653 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5074826 Reviewed-by: Chris Forbes <chrisforbes@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Geoff Lang 820e0d7a 2023-11-29T13:39:27 Compute the shader hash without copying objects. The shader hash was calculated by generating a large string and then sha1 hashing the string. sha1 can be generated with a fixed memory cost using the angle::base::SecureHashAlgorithm class. Bug: angleproject:8434 Change-Id: I816e2c3bbc7283cd5424621b4cc8f6dab0407aa4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5073293 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 2a6336ed 2023-11-29T13:35:57 Don't construct a compiler instance on shader cache hits. We can avoid constructing a shader compiler instance and then destroying it when we get shader cache hits. The resources and output type are available from the root gl::Compiler object. Bug: angleproject:8434 Change-Id: I2de43db34dc1b86265aa648b1275e32814487ff4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5073292 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sergey Kataev 058a2fd6 2023-11-28T17:38:28 Clear active queries before Begin Bug: angleproject:8415 Change-Id: I97dfd904d65933a66f25cd168c50fe150ef9c765 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5068525 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Sergey Kataev <sergeyka@chromium.org>
Charlie Lao f7eb7efb 2023-11-28T11:20:57 Vulkan: Fix camera panorama hang When EGL attributes does not speficy color space, right now we pick VK_COLOR_SPACE_SRGB_NONLINEAR_KHR. This overwrites the color space people set via ANativeWindow. This causes camera goes into CSC conversion and errors out and stops media codec pipeline and causes camera to hang. This CL enables mapUnspecifiedColorSpaceToPassThrough feature flag for all platform that supports VK_EXT_swapchain_colorspace so that it will pick VK_COLOR_SPACE_PASS_THROUGH_EXT and vulkan swapchain code will try to keep whatever color space surface already has. The feature flag is still kept here in case there is regression and we need to experiment this feature flag again. We can remove it once everything settles down. This CL also adds updateColorSpace() and getActualFormatID() to de-duplicate the logic of R8G8B8_UNORM overriding and use of VK_COLOR_SPACE_PASS_THROUGH_EXT. Bug: b/309480316 Bug: b/302196568 Change-Id: I0952fe78c2bfd59446391c553745b2b5cb152a9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066801 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Chris Forbes <chrisforbes@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 05e9ec11 2023-11-23T00:00:00 Metal: Saturate floating-point depth textures on upload Metal does not clamp uploaded floating-point depth texture values to the normalized range. Used a compute shader to enforce the expected OpenGL ES semantics. Fixed the following tests on Intel and Apple GPUs: dEQP-GLES3.functional.texture.specification .teximage2d_depth.depth_component32f .teximage2d_depth.depth32f_stencil8 .teximage2d_depth_pbo.depth_component32f .teximage2d_depth_pbo.depth32f_stencil8 .teximage3d_depth.depth_component32f_2d_array .teximage3d_depth.depth32f_stencil8_2d_array .teximage3d_depth_pbo.depth_component32f_2d_array .teximage3d_depth_pbo.depth32f_stencil8_2d_array .texsubimage2d_depth.depth_component32f .texsubimage2d_depth.depth32f_stencil8 .texsubimage3d_depth.depth_component32f_2d_array .texsubimage3d_depth.depth32f_stencil8_2d_array Fixed: angleproject:8422 Fixed: angleproject:8426 Change-Id: I843024f098fef2fbca15e7b6124052681d05b6ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5062710 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev d696b40f 2023-11-23T00:00:00 Metal: Use precise tanh for highp result types When fast math is enabled, default tanh does not pass dEQP precision tests. Explicitly request precise tanh when the result type has high precision. Bug: angleproject:8287 Change-Id: I07c8c2638b5f0a51feacbeadb78382152a95b03c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5057298 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll aaafecee 2023-11-29T10:01:37 Roll vulkan-deps from 47125179fa7d to c41e80cec06c (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/47125179fa7d..c41e80cec06c Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b820431a2c..c59b876ca0 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7d2a618bf9..afaf8fda2a * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b00cb455c4..cf32131e12 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e00625d685..b994b0d458 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ide971370f5b16ca4b6a43ba38ef0637e7b2c5a4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5068529 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 55814099 2023-11-29T07:00:39 Roll Chromium from b8706c636bf7 to a2a7acf06e25 (698 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b8706c636bf7..a2a7acf06e25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4a176626b8..f9cc71c99c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/aa432dc92d..c65da25aed * buildtools/linux64: git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03..git_revision:7367b0df0a0aa25440303998d54045bda73935a5 * buildtools/mac: git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03..git_revision:7367b0df0a0aa25440303998d54045bda73935a5 * buildtools/reclient: re_client_version:0.120.1.f75cfb7-gomaip..re_client_version:0.121.0.e622934-gomaip * buildtools/win: git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03..git_revision:7367b0df0a0aa25440303998d54045bda73935a5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c6b2bfd4cc..342c05bb4d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/334071bcb5..ec903ccd87 * third_party/android_build_tools/lint: A9hM5McVrqwLhfWjg3dptcOFMxIiBJaMsrmG-rb8aW0C..hPW0THuEdVxwGMSWqn9CZgyFBNXe9sXc2NJsh1hiliIC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/702ef3a599..2823d8f8be * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0acc468d8b..9e5fc28b6b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/763198b843..6cd38f6d30 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b90fa05c89..c21fd3819a * third_party/siso: git_revision:d3c91417789c3190676d18dc3cc26dff20819eea..git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e2d55f9bea..3ee0331f3c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/522ab0728a..990e9cdeeb * tools/luci-go: git_revision:bd7ce256f73f85cb75c630b40afa382cdf7fcc51..git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae * tools/luci-go: git_revision:bd7ce256f73f85cb75c630b40afa382cdf7fcc51..git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4874affc0c..a1a98c84ca * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/63050f1b91..5e2447e2fb No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I027e87639df6543348b9908fa1da8aa835d2a851 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5068528 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 989b1143 2023-11-28T14:06:06 Trace perf: logcat output captured line-buffered I've seen warmup detection getting stuck intermittently not seeing the log line despite the line being there. Hopefully this fixes. Bug: b/291604008 Change-Id: I10da772c485f7b1badd34efc00c20fc6d55139cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5067855 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop ee4b7a27 2023-11-03T09:06:50 Add --memory to restricted_trace_perf.py Detailed analysis of our power results showed that even checking memory can impact power. This CL makes memory measurement optional (like power) to enhance power measurements. Test: restricted_trace_perf.py --memory --power Bug: b/292249127 Change-Id: I69b34d378ca923de42af59fc1b532a1d766b4391 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066797 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Mark Lobodzinski 068a0ee8 2023-11-28T08:43:45 Tests: Add Retro Bowl trace Test: angle_trace_tests --gtest_filter=TraceTest.retro_bowl Bug: b/313610392 Change-Id: Iec30c95fd46a75c6995d968dfac5652a89209bc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066795 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 333e3a9c 2023-11-28T12:12:44 Re-add VUID-vkDestroySemaphore-semaphore-01137 temporarily To unbreak ANGLE-> Chromium swangle.. https://crrev.com/c/5066784 Bug: angleproject:7729 Change-Id: Ic7aaa10540cb9c6581872c9709b2d329eae4b8f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5067854 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 233b6675 2023-11-28T12:48:17 Roll vulkan-deps from e892a337898c to 47125179fa7d (24 revisions) VVL renamed VUID-vkDestroySemaphore-semaphore-01137 -> VUID-vkDestroySemaphore-semaphore-05149 https://chromium.googlesource.com/vulkan-deps.git/+log/e892a337898c..47125179fa7d Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/153064f2c7..b820431a2c * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/42299f92ef..50e90dd74e * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2a238ed24d..7d2a618bf9 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/7d92fe7b68..9d27c893cd * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0e7cf57a29..b00cb455c4 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/9ef6c05af3..98d168c168 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/228f7487dd..1fb77ad1d4 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4d7cdcc223..e00625d685 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7729 Tbr: romanl@google.com Change-Id: I8268b3532b78aa4362e632ae68f335b6808966e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066853 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll f2aee23f 2023-11-28T10:01:36 Roll SwiftShader from 50dbfc35468c to 35b1a501141a (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/50dbfc35468c..35b1a501141a 2023-11-27 syoussefi@google.com Make high precision filtering a build flag If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Icf9ff3ae4b7b8668c4e1b3bd37699db6a2ad6646 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066074 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1b8775f9 2023-11-28T07:47:29 Roll Chromium from 3c5e99605653 to b8706c636bf7 (594 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3c5e99605653..b8706c636bf7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cdf0c47b04..4a176626b8 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ed2855f2d6..aa432dc92d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e20739ec64..c6b2bfd4cc * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3747d5b3f1..334071bcb5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f0228fa92b..702ef3a599 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/25b4354fad..0acc468d8b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9e4e987c28..763198b843 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e6a7fd81ed..b90fa05c89 * third_party/r8: YJv5xgb5CjUj1a0k36y8EQ5Fg7faGfQi1bKh8-cAv6QC..o6MAAUwWCotub-YLAZV6fewtgr4AUJUrZpDwervcrtMC * third_party/turbine: rg7X3-H8Yd0enT9HWZY9KwEh1ciZBP0jkla5_rGW2pUC..e8ccyNXO5wVjI0vv5W8kfA101BaaLNjNiVH1JddpdWkC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/22124f50e9..7b4829c7a3 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/521ee9b0a7..e2d55f9bea * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8e1981d442..522ab0728a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a13c719040..4874affc0c * tools/skia_goldctl/linux: X1YWlW-vzJ8VB4_DZDx7vQjrh06xi6o_hnxnoQ9pRJgC..Zoe29KUyqS2oKisSjN23NSWAF2ABY3oXtvnMcmNgFf8C * tools/skia_goldctl/mac_amd64: tfXYA7PdwTB_MKkvGO3x0SiH7mnjOz_Qmaflm4quiVYC..JqbiGnBxG8TPvCgKA3OOreiQ59Tn_xZoQOrWCP7rzOUC * tools/skia_goldctl/mac_arm64: yXR-TKcp4Hk7mBJ1Yzar9h8PTy_CPyw9tGoYKjwooJoC..6U5_zURvPx2a03ZdJP9q_CPrUrIp3nU7x9u9a7ZWvFsC * tools/skia_goldctl/win: BYJuHIvTZ_3r-th5RnKUkcSmHEaKFPYrrkWebSiN4g0C..zEvgRWYnnTxGYfan6MIEqFyxyBfzgryl755RHBP98wYC Clang version changed llvmorg-18-init-11962-g73e96337:llvmorg-18-init-12422-g74cdb8e6 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/8e1981d4424915d69d4774d8f6835799c3c1d6a1..522ab0728a5204e48573ab73f5bd7ae34a7f5ef2/scripts/update.py Bug: None Tbr: romanl@google.com Change-Id: Ic631c3d147c91799b23d6e5149667f5ad928e2b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5065991 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 716c5d00 2023-11-13T10:23:10 Vulkan: Add RGB8-to-RGBA8 ubyte loading function Currently, to update RGB8 on desktop, ANGLE uses memcpy for each pixel, which is suboptimal. This CL adds a loading function to improve the copy time for RGB textures where RGBA is needed on the hardware. * Added a specialization to LoadToNative3To4() for unsigned bytes using 0xFF as the fourth component. * It is optimized for unsigned bytes when converting an RGB format to its corresponding RGBA format, e.g., RGB8 to RGBA8. * It uses uint32_t operations to speed up the process. * Added unit tests for the specialized LoadToNative3To4. * LoadToNative_unittest.cpp * Added perf test for RGB8 image allocation and loading. * RGBImageAllocationBenchmark in RGBImageAllocation.cpp. * RGBImageAllocationBenchmark shows some improvement in cpu_time and wall_time on a Linux and a Windows device. (Results below using aligned source pointer and texture size of 2048): * On Windows: +~85% cpu_time, +~71% wall_time * On Linux: +~26% cpu_time, +~27% wall_time Bug: b/308177124 Change-Id: I421d83f75fdc513b0111dffb0a5d5e74682dd6fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4995489 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Geoff Lang 1ff6a6f2 2023-11-27T13:08:29 Pass the attribute map to egl::Sync::initialize. The attribute map was typically passed to the impl objects in the constructors. Instead, pass it to the initialize function. This removes the need for many member variables in different backends and opens up the future optimization of re-using sync objects by calling initialize on them with new attributes. Bug: angleproject:8430 Change-Id: If69970462cfed39d9a205034adb5ddd937c5ea31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5063335 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Steven Noonan 99b077b7 2023-11-26T08:24:18 Vulkan: fix data clobbering with AllocateNonZeroMemory The offset of the suballocation was not being used when initializing memory, so it was possible to overwrite the start of an existing buffer with garbage. Bug: angleproject:8427 Change-Id: I8205068a173dc4342894c6c49ee5fa9c4a8a255a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5060776 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net>
Alexey Knyazev 3e617615 2023-11-23T00:00:00 Metal: Update depth texture dEQP expectations Bug: angleproject:5243 Bug: angleproject:8425 Bug: angleproject:8426 Change-Id: I62fe901e50cd76b483ba415ad01707129c4ff857 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5054336 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 1db20bf4 2023-11-27T15:33:23 Roll VK-GL-CTS from fdb23dfe8f79 to faf4fbbc8f8e (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fdb23dfe8f79..faf4fbbc8f8e 2023-11-27 rgarcia@igalia.com Remove many EDS stencil test combinations 2023-11-27 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I7df820b32c2f8aef34a76f17c645ab25b155d381 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5062274 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 3de9237e 2023-11-27T08:55:26 Disable recursive global lock with Chromium Bug: chromium:983167 Change-Id: I7eb1c993a2ffa4127ec207f160c12e4c94c6b2e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5061830 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev b7a31b7f 2023-11-27T00:00:00 dEQP: Treat signed integer overflow as two's complement Bug: b/307584642 Fixed: angleproject:8429 Change-Id: Ib3cdd1835d4c669a79a4553b24da676eb41e21b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5062708 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ea823893 2023-11-27T07:00:17 Roll Chromium from 89adc6a8e802 to 3c5e99605653 (503 revisions) https://chromium.googlesource.com/chromium/src.git/+log/89adc6a8e802..3c5e99605653 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8b922e8b99..cdf0c47b04 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/06a9897f24..ed2855f2d6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1ff91ec2c9..e20739ec64 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c03569abfc..9e4e987c28 * third_party/r8: Vjgh6DGZpPhxYqNjulYH9ogpNFhkWn31RDgrWeRQmPcC..YJv5xgb5CjUj1a0k36y8EQ5Fg7faGfQi1bKh8-cAv6QC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9fbc780088..8e1981d442 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/31368237c9..63050f1b91 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I83e87d480cc4ceb8c619aeec1f39431d6ed24277 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5060780 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9a70fc90 2023-11-25T15:53:13 Roll VK-GL-CTS from 005862913ee9 to fdb23dfe8f79 (10 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/005862913ee9..fdb23dfe8f79 2023-11-25 rgarcia@igalia.com Test static stencil write mask zero with discarded fragments 2023-11-25 ziga@lunarg.com Add transform feedback with conditional rendering tests 2023-11-25 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-11-24 gsweet@broadcom.com Add missing pipeline barriers in d/s buffer-to-image copies 2023-11-24 amber@igalia.com Add device lost detection support and a --deqp-terminate-on-device-lost option. 2023-11-24 ziga@lunarg.com Fix usage flags in external memory maintenance5 test 2023-11-24 rgarcia@igalia.com Remove ESO variants of extended dynamic state null pointer tests 2023-11-24 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-11-24 lorenzo@khronosgroup.org Fix for bug introduced in a8b1e1b (verbose option) 2023-11-20 javed@igalia.com Restore test descriptions as comments If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I9ea46e867c8b6747200ff55127576bee5344a1cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5060238 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lu Yahan 1bdb4038 2023-11-23T16:37:37 [riscv] Add riscv support Bug: angleproject:8423 Change-Id: Id1d9b06ff18985cb66a865477c30fdac8791e9de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5057086 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll baf4a9ca 2023-11-24T11:57:08 Roll vulkan-deps from fe7ac4762e47 to e892a337898c (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/fe7ac4762e47..e892a337898c Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/fd403737d2..153064f2c7 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/42aac916ab..42299f92ef * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a4ff6a54e4..0e7cf57a29 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7adefb0aeb..4d7cdcc223 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I1083ac6d49c55d274da32adcbd56620d641bcbc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5057095 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll bb7ac182 2023-11-24T07:42:59 Roll Chromium from d2936bfdb0ac to 89adc6a8e802 (325 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d2936bfdb0ac..89adc6a8e802 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/95d1d44174..8b922e8b99 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2a8d2c5eab..06a9897f24 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b403c6abb2..1ff91ec2c9 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e9f4ddc3e1..3470538450 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b80aa2639f..f0228fa92b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4b348d339b..c03569abfc * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/371593893a..e6a7fd81ed * third_party/r8: vFBpAdZar_sS8W_xKvQThRv5XpFyYZP4bMzjigyTTcwC..Vjgh6DGZpPhxYqNjulYH9ogpNFhkWn31RDgrWeRQmPcC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/5daffc716b..22124f50e9 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d262359249..521ee9b0a7 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ef629b98df..a13c719040 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/fb0d858a62..31368237c9 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Iad99d76360dccc90399acbf34eb5f165483b1fb2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5058171 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi aa3bebf9 2023-11-18T22:15:11 GL: Fix parallel link query of in-progress link Bug: angleproject:8297 Change-Id: Iab2f12467a2c567c945742435939057a40642951 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5042345 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev c8f707f8 2023-11-16T00:00:00 Metal: Simplify MSL sRGB conversions * Used metal::powr instead of metal::pow because the arguments are non-negative. * Reduced nesting. Bug: angleproject:8366 Change-Id: Ibc50880060c12217b4ee8452c662d346a1cb273a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5040993 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll a5e8f86a 2023-11-23T09:58:23 Roll Chromium from 36830a1d917b to d2936bfdb0ac (525 revisions) https://chromium.googlesource.com/chromium/src.git/+log/36830a1d917b..d2936bfdb0ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/968682938b..95d1d44174 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/92b79f4d75..2a8d2c5eab * testing: https://chromium.googlesource.com/chromium/src/testing/+log/60522bfa78..b403c6abb2 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1e8861f03f..3747d5b3f1 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/abf7a60fd7..e9f4ddc3e1 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/38b8de056e..25b4354fad * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4026ecfd49..4b348d339b * third_party/r8: vgwqt33JWwV0OVbbDCoTLt78eMlewV8Ut0CN1HyOdfYC..vFBpAdZar_sS8W_xKvQThRv5XpFyYZP4bMzjigyTTcwC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9db1a23b04..9fbc780088 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f068a70f17..ef629b98df * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6131f2e326..fb0d858a62 Clang version changed llvmorg-18-init-9505-g10664813:llvmorg-18-init-11962-g73e96337 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/9db1a23b048abc77c2649412775752e67e07e8f1..9fbc780088a01c4e5e5551c63f1af2a2ea0e2efc/scripts/update.py Bug: None Tbr: abdolrashidi@google.com Change-Id: If83477e9af19c15f8ce5c15618c06a0da62c4ad1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5054166 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang fba482b7 2023-11-22T12:01:31 Fix off-by-one bounds check on uniform location. Log an error when the user provides an invalid uniform location. Bug: chromium:1504162 Bug: chromium:1484878 Change-Id: Ieb7eb964d508954ac8dfa8e4d9bd941778185223 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5054238 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: James Godfrey-Kittle <jamesgk@google.com>
angle-autoroll 95f842d6 2023-11-22T10:01:17 Roll vulkan-deps from 856d90fb41aa to fe7ac4762e47 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/856d90fb41aa..fe7ac4762e47 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/4efde4c4c1..fd403737d2 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/42ee043c5c..a4ff6a54e4 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/de53ecbb06..7adefb0aeb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Iab25a85a45dc58324911e98846b42f69647f7516 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5051817 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b5e311a9 2023-11-22T07:01:47 Roll Chromium from 27466d6e992e to 36830a1d917b (565 revisions) https://chromium.googlesource.com/chromium/src.git/+log/27466d6e992e..36830a1d917b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/945d770c9a..968682938b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4f46c73c17..92b79f4d75 * buildtools/linux64: git_revision:c7b223bfb225ce87a72a244d016ffdfcf227fa5e..git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03 * buildtools/mac: git_revision:c7b223bfb225ce87a72a244d016ffdfcf227fa5e..git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03 * buildtools/win: git_revision:c7b223bfb225ce87a72a244d016ffdfcf227fa5e..git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/918cef4514..60522bfa78 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5c1525f035..b80aa2639f * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/434a8efe28..4026ecfd49 * third_party/r8: mIydEkNvLtzm1YbYV6Vch1Oj7Hwzdgw-XVLHEKLmjq4C..vgwqt33JWwV0OVbbDCoTLt78eMlewV8Ut0CN1HyOdfYC * third_party/siso: git_revision:2133382e6d258f4fa4de2cfb255d8287efc91039..git_revision:d3c91417789c3190676d18dc3cc26dff20819eea * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/32bdb9407b..6131f2e326 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ie4e2b6628360cef71db29c9c5ac8c41c4b9eade9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5050569 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 20eff9db 2023-11-21T10:01:52 Roll vulkan-deps from 63bb05a5e0ad to 856d90fb41aa (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/63bb05a5e0ad..856d90fb41aa Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/854db99ff1..4efde4c4c1 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/af4fb97d7b..7d92fe7b68 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/19e9e53255..42ee043c5c * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/e4ceafdd06..228f7487dd * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1cbb2c8ffa..de53ecbb06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Iecfd144a4b13a301aca3b10ceeb76b8961841b2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5046148 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c69e4825 2023-11-21T08:11:54 Roll Chromium from 0ddb38eda131 to 27466d6e992e (574 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0ddb38eda131..27466d6e992e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cd2687c456..945d770c9a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2895795509..4f46c73c17 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f6ba9d58d1..918cef4514 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d1c140e8b7..1e8861f03f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bd17576ac2..5c1525f035 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eb48a6ac0f..38b8de056e * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a96e76348a..434a8efe28 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f06a19ed57..9db1a23b04 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/407bbc768d..32bdb9407b No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I2caeffdff234a2cd22cc7f87bba0b7742c802d93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5046146 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 1169f6b4 2023-11-18T21:03:54 Add bad app behavior to parallel link perf test A large majority of apps hinder parallelism by immediately querying the link status after glLinkProgram. The parallel link perf test is now exercising this behavior as well. Additionally, since the Vulkan backend's default is to disable parallel link, the perf test is also enhanced to include this case. A follow up change will improve the performance of both these scenarios with the Vulkan backend. Bug: angleproject:8417 Change-Id: I39b9d5703a17d051d20d35fd4cede2b415e770a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5042344 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll cb28076f 2023-11-20T10:01:48 Roll vulkan-deps from b5f778a99583 to 63bb05a5e0ad (16 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b5f778a99583..63bb05a5e0ad Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/845e5d5a28..854db99ff1 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0df791f97a..2a238ed24d * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/38c5ce8b11..19e9e53255 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ae2a2dc99b..9ef6c05af3 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/177e2312fa..e4ceafdd06 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9534ebe901..1cbb2c8ffa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: If6eed060cb850e03db4d7c045ff934ec688b1e93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5043922 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c8a544dd 2023-11-20T09:49:36 Roll VK-GL-CTS from 55b64f6ad410 to 005862913ee9 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/55b64f6ad410..005862913ee9 2023-11-18 ziga@lunarg.com Remove descriptions from new eds tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I6d0a9f851d0eebe449441c56c304a2e0b6a73730 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5042854 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7c3233d7 2023-11-20T07:01:45 Roll Chromium from db5279ea46cd to 0ddb38eda131 (743 revisions) https://chromium.googlesource.com/chromium/src.git/+log/db5279ea46cd..0ddb38eda131 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/23f94fa6ef..cd2687c456 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/7d02c8ca33..2895795509 * buildtools/linux64: git_revision:bc5744174d9ea1c292f3f08cfb95fa97ea5c595e..git_revision:c7b223bfb225ce87a72a244d016ffdfcf227fa5e * buildtools/mac: git_revision:bc5744174d9ea1c292f3f08cfb95fa97ea5c595e..git_revision:c7b223bfb225ce87a72a244d016ffdfcf227fa5e * buildtools/win: git_revision:bc5744174d9ea1c292f3f08cfb95fa97ea5c595e..git_revision:c7b223bfb225ce87a72a244d016ffdfcf227fa5e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9740b867f3..f6ba9d58d1 * third_party/android_build_tools/manifest_merger: kyXImK5GOP19ROuy-2wf_I_zzcVr2RVsPvB0jhLyrCEC..SdNR04V227YL22FMmKoS4AdLYwv6MJe8HBAZKNhXoCsC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bb1266a081..bd17576ac2 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/06c4261af7..eb48a6ac0f * third_party/fuchsia-sdk/sdk: version:16.20231110.0.1..version:16.20231117.2.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4399383935..a96e76348a * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d529bb588f..371593893a * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/19b1234bfb..85df028e4c * third_party/r8: LSKbogNru-rwoTlrVtJniI4WT8_ZQbcI8QyWQJfwHXoC..mIydEkNvLtzm1YbYV6Vch1Oj7Hwzdgw-XVLHEKLmjq4C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1f8329e28f..f06a19ed57 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0638c560d2..f068a70f17 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cbdb0871cd..407bbc768d No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I3c962e06718cd60ab387c272d4f3126806c29380 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5043628 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Le Hoang Quyen 98d79260 2023-11-09T10:15:11 Metal: use release-consume order for queue's serials. Currently mtl::CommandQueue's mCommittedBufferSerial, mCompletedBufferSerial use relaxed memory order for load & store. They should use consume & release memory order respectively instead. Bug: angleproject:8406 Change-Id: I871259f1a6cca0e63d6c24b7592e7b80fd443dff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5015524 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll 88f7a65d 2023-11-18T10:32:07 Roll VK-GL-CTS from ff0a874a4e15 to 55b64f6ad410 (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ff0a874a4e15..55b64f6ad410 2023-11-18 javed@igalia.com Add tests for unused push constants. 2023-11-18 javed@igalia.com Fix test failures on VK_ERROR_FORMAT_NOT_SUPPORTED cases. 2023-11-18 lorenzo@khronosgroup.org Add verbose option for logging build information 2023-11-18 javed@igalia.com Add coverage for fully dynamic blend state with 0 attachment count. 2023-11-18 rgarcia@igalia.com Test pipeline libraries do not use the creation render pass 2023-11-18 rgarcia@igalia.com Test feedback loop attachment followed by draw with 0 attachments 2023-11-18 rgarcia@igalia.com Test mismatch in pipeline and render info att. count 2023-11-18 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iec7aa2ad19ad41debfa760885c3c0ada6d4b9d2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5039284 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chia-I Wu 170ba8c9 2023-11-16T19:45:35 Vulkan: Workaround depth bias constant factor on RADV Both ANV and RADV need the same workaround. Improve IsRADV to support Venus-over-RADV. Also "git cl format" to make presubmit happy. Bug: b/308835020 Test: dEQP-GLES3.functional.polygon_offset.fixed16_render_with_units Change-Id: Ibbad4d09f12df419e38aff1365d37d55ca326532 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5040097 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Chia-I Wu <olv@google.com>
kmx.io     mail     discord kmxgit v0.4.0