kc3-lang/angle

Log

Author Commit Date CI Message
Roman Lavrov 53e37a3e 2023-09-29T14:15:37 Replace mActiveTextures.fill(nullptr) with memset std::array::fill yields unoptimized, unrolled loop with 8 byte increments. Surprisingly high (>2%) effect on the instructions counter in my tests (first frame of real_racing3 trace) The number of samples hitting this spot in profiling is also signficantly reduced. Impact on power harder to judge due to noise but does seem to be a bit better. Added a FillWithNullptr utility to check that nullptr is 0 and used it in other places where fill(nullptr) was used in ContextVk. It's not used elsewhere in vulkan. Bug: b/302708437 Change-Id: If7fab66d858bc10ca356418d2ab26232bb9a9ce7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4902288 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov a0967770 2023-10-06T18:01:45 Add egl/wrapper headers to deqp opengl sources gn gen --check catches these and "include not allowed" Bug: b/303881910 Change-Id: I26728dc2618436daec232152c56d59a7233ca91e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4916365 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev d1cf2d43 2023-10-05T00:00:00 Cleanup sampler completeness validation * Simplyfied control flow in TextureState::computeSamplerCompleteness * Used special rules for all depth and stencil formats instead of the filter support flag * Fixed DEPTH_STENCIL_TEXTURE_MODE affecting completeness of depth-only textures with REF_TO_TEXTURE compare mode * Skipped mipmap validation for multisample 2D array textures Bug: angleproject:2373 Change-Id: I0f9b6e7401fb85433f2ba4873f271055139bb17e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4922392 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll b4d87668 2023-10-10T10:01:46 Roll vulkan-deps from d3dc8dfdccca to be2755d4d109 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d3dc8dfdccca..be2755d4d109 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/5ff0c048b7..277d09e679 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/6d4f07c995..d728191673 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/730234d8e4..31b95ce237 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/10988f7589..84a7db4f82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I918c643c830931f95bf22c7854fdafeb9e2e15ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4925139 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 04ce14af 2023-10-10T07:00:15 Roll Chromium from b3c67dea8ed9 to 2f77720808c4 (504 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b3c67dea8ed9..2f77720808c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7c58dc7046..5f1ddffe0a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/878f3f1678..657ac241f8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2e28c272ba..910b1725b1 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/bf36a1f158..88f60e4dc3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4d83729ced..30e34f3dc1 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6aed4f5a0c..92d8c4e0cf * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/24bdc4f64c..8fc17971d6 * third_party/siso: git_revision:23257e255f1d58d9f66923a1a40e746ac3a4b9d8..git_revision:c689f99bb4b9908073bd2f3fbd68f289d9e45a75 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/41f294687f..d06f70c93b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/171f64306f..40dc9a464b No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I36c12202445f4716fe71e4c63ed2c6acee3e3785 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4924804 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 99b208c1 2023-10-09T10:01:44 Roll vulkan-deps from f770c9936a5a to d3dc8dfdccca (57 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f770c9936a5a..d3dc8dfdccca Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4fab7435bf..933db564ca * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/6f0d6550e6..bbe0f575eb * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/dedcfae378..6d4f07c995 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e483d0dfc7..730234d8e4 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/2169a0849e..9e088360b5 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8dee683271..10988f7589 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ib2336a9b279eebbabd4c2dcd2d55d3b56604bbf2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4921620 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bc959555 2023-10-09T07:01:03 Roll Chromium from 4622adaa4bf3 to b3c67dea8ed9 (723 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4622adaa4bf3..b3c67dea8ed9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d0b39db71d..7c58dc7046 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d953546f4f..878f3f1678 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1a4c54d785..2e28c272ba * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/60adf7b6d9..6aed4f5a0c * third_party/fuchsia-sdk/sdk: version:15.20230930.1.1..version:15.20231007.2.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/3023d15de4..24bdc4f64c * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b6e1ac1649..db9800c042 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f775f73afa..22e1594188 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e28b774df3..41f294687f Clang version changed llvmorg-18-init-7313-geee1f7ce:llvmorg-18-init-7785-geef35c28 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/f775f73afa543b4b1285aa65ca0cd9c395d07a3e..22e15941889dad6fcffeca7134684b888299ad55/scripts/update.py Bug: None Tbr: romanl@google.com Change-Id: I659460ae086e01d36ac058e4b612a859d602fba3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4921614 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 0afc3ec9 2023-10-05T00:00:00 Metal: Fix robust initialization of PVRTC1 textures Replace Region Validation: rowBytes must be 0 for: * MTLPixelFormatPVRTC_RGB_2BPP * MTLPixelFormatPVRTC_RGB_2BPP_sRGB * MTLPixelFormatPVRTC_RGB_4BPP * MTLPixelFormatPVRTC_RGB_4BPP_sRGB * MTLPixelFormatPVRTC_RGBA_2BPP * MTLPixelFormatPVRTC_RGBA_2BPP_sRGB * MTLPixelFormatPVRTC_RGBA_4BPP * MTLPixelFormatPVRTC_RGBA_4BPP_sRGB Fixed: angleproject:8370 Change-Id: I153bea5bb487f79b0966be0b8670a2ee4e3aeb39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4915704 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Roman Lavrov 7e8907db 2023-10-06T15:41:05 Add egl/wrapper to deqp opengl includes Needed to roll VK-GL-CTS upstream change: https://issuetracker.google.com/303881910 Bug: b/303881910 Change-Id: Idffa299cc6c1d277702167bf50e1d944febb9e7e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4915605 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev 0015d1e2 2023-10-05T00:00:00 Allow ETC1_RGB8 for 2D array textures When GL_EXT_compressed_ETC1_RGB8_sub_texture is enabled, ETC1_RGB8 format must be accepted for 2D array textures. Bug: angleproject:5731 Change-Id: Ic5e647ffd4e7d2a171e25ea8cf3f41514cf37072 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4915918 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 5149d210 2023-10-02T22:27:11 Vulkan: Deduplicate sync's clientWait logic As a side effect, both GL_NV_fence's client wait and external fence client wait is also done in an unlocked tail call. Bug: angleproject:8340 Change-Id: Ia0b882cc67ecf7ac5b2a8f9dc9e721060cca3c9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4908351 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi adb17c80 2023-10-06T10:39:17 Vulkan: Copy 3D<->2DArray images with vkCmdBlitImage anyway Despite the validation error, do the copy with vkCmdBlitImage anyway. Drivers seem to work correctly, and the validation restrictions seem unintentional. Bug: angleproject:7291 Change-Id: Ie7a0ecfe559be44738da3eada281ea97424b38ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4916359 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 65e8ae30 2023-10-06T09:42:45 Vulkan: ANGLE_device_vulkan is incompatible w/ asyncCommandQueue The application may use EGL_ANGLE_device_vulkan to retrieve ANGLE's Vulkan queue for direct usage. There is no mechanism for the application to synchronize with the internal thread that uses the same queue when the asyncCommandQueue feature is enabled. This was causing flakiness where VVL reported this error. This change makes sure an ASSERT catches this incompatible usage. Bug: angleproject:7204 Bug: b/299693666 Change-Id: Idf349f99d80b7bbddeb9a0b2d72e3dd7c707fa5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4915594 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov d6bf8e0d 2023-10-02T18:10:36 Improve capture_replay_tests (win-trace) logging * Get rid of the CRASH expectation as it is always confusing. Replace items in expectations with SKIP_FOR_CAPTURE. This will no longer run the corresponding tests (which was making logs even more confusing) * Use CaptureFailed and ReplayFailed instead of Crashed status (the actual meaning is a non-zero return code from the test harness) * Introduce batch names by indexing them as they are created: batch_000, batch_001, ... This enables easy searching in logs. * When logging a batch (result) include its name and why it is logged * Failed batches are printed with full output instead of "abbreviated" output. One issue with b/303065176 was that an important part of the output (errors) was truncated by this "abbreviation" * Remove "regression log" and "Summary" as these are often just confusing: regression log just duplicates information printed earlier and summary may not be clear w.r.t test expectations. The part that prints what was unexpected is still there. It also now includes batch names so it's much more obvious what comes from where. Example: Unexpected 'CaptureFailed' (8): != Pass: batch_000 FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBellowBaseLevelLOD/ES3_Vulkan_SwiftShader != Pass: batch_000 FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBellowBaseLevelLOD/ES3_Vulkan_SwiftShader_AsyncCommandQueue != Pass: batch_000 FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBellowBaseLevelLOD/ES3_Vulkan_SwiftShader_EnableParallelCompileAndLink != Pass: batch_000 FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithSubImageWithBeyondMaxLevel/ES3_Vulkan_SwiftShader != Pass: batch_000 FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithSubImageWithBeyondMaxLevel/ES3_Vulkan_SwiftShader_AsyncCommandQueue != Pass: batch_000 FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithSubImageWithBeyondMaxLevel/ES3_Vulkan_SwiftShader_EnableParallelCompileAndLink != Pass: batch_000 FramebufferTest_ES3.RenderImmutableTextureWithSubImageWithBeyondMaxLevel/ES3_Vulkan_SwiftShader != Pass: batch_000 FramebufferTest_ES3.RenderImmutableTextureWithSubImageWithBeyondMaxLevel/ES3_Vulkan_SwiftShader_AsyncCommandQueue Unexpected 'FailedToTrace' (1): != Pass: batch_001 FramebufferTest_ES3.RenderSampleDepthTextureWithExcludedLevel/ES3_Vulkan_SwiftShader Bug: angleproject:7519 Bug: b/303065176 Change-Id: Ie0c4734c7c4ac965aa6fd38b0c1783e0b92af7a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4908349 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 3671dbbd 2023-10-06T07:00:10 Roll Chromium from 138350604230 to 4622adaa4bf3 (433 revisions) https://chromium.googlesource.com/chromium/src.git/+log/138350604230..4622adaa4bf3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/76f5031632..d0b39db71d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c3c28168c6..d953546f4f * buildtools/reclient: re_client_version:0.113.0.8b45b89-gomaip..re_client_version:0.116.1.9128bc4-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d7592c0f05..1a4c54d785 * third_party/android_build_tools/aapt2: STY0BXlZxsEhudnlXQFed-B5UpwehcoM0sYqor6qRqsC..y1G4s2RWI63L9ZLgzS3RzFdWdeblpCmYyAUzMphcQawC * third_party/android_build_tools/lint: Ac-fmwsSKvAmbfGL_uV4S6Xfz2jKwcHYelE29TjBPikC..qOmRl_DUi0ABBlqEHTW3kw6DMtplzGdRr7td0USaw0IC * third_party/android_build_tools/manifest_merger: 9gAaukznhLAAtANeZ_AT_9z8xXF5ZUzuc0h0TfMr7IIC..f91o-aOAEitXaUBozBpROZfvZOxQOB9aqPJGduMwoNYC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1a33dd1f59..4d83729ced * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c2e0061723..60adf7b6d9 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e0cb589445..3023d15de4 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/3f0af7f1d5..fef58692c1 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/4540d5f88f..b4f0262c93 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3e68a98ed5..e28b774df3 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I57d4f36e3fe71daf104207ff9e242f9568c4fd46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4918911 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 8c341cfd 2023-10-04T12:49:59 Vulkan: Fix blits involving 3D images The layer vs depth value involved with 3D images when calling vkCmdBlitImage is fixed in this change. However, that brought to light that the combination of VUID-vkCmdBlitImage-srcImage-00240 and VUID-vkCmdBlitImage-dstImage-00252 make it impossible to blit between 3D and 2D array images, which is likely a spec oversight. This change makes 3D<->2DArray blits fall back to draw-based blit. This in turn exposed the fact that 3D images as src were not handled in BlitResolve.frag. A new Blit3DSrc.frag shader is added which shares code with BlitResolve.frag to implement this. This is a separate shader to avoid creating unnecessary and invalid combinations of shaders. VK_EXT_image_2d_view_of_3d could have been used to avoid this new shader, but that is not ubiquitous. Bug: angleproject:7291 Bug: dawn:1962 Change-Id: I6a96162f95829304b4731d43208d9d054f538105 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4911800 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 48474d15 2023-10-05T14:43:52 Manual roll Chromium from 07002c74826e to 138350604230 (1338 revisions) Manually update third_party/flatbuffers following chromium's update: https://crrev.com/c/4910377 alignment_test_generated.h is copy-pasted into angle's repo... and also has to be re-git-cl-format'ted... https://chromium.googlesource.com/chromium/src.git/+log/07002c74826e..138350604230 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e487e6db20..76f5031632 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c8bee3e69d..c3c28168c6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/729cd7fa3b..d7592c0f05 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/0f519c0d9c..bf36a1f158 * third_party/android_build_tools/lint: _HzBkAzPHHstN_PQaEGq4413D2VuwK7rqGfk8qD--SsC..Ac-fmwsSKvAmbfGL_uV4S6Xfz2jKwcHYelE29TjBPikC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/88124d563b..1a33dd1f59 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/422ba5b9a5..c2e0061723 * third_party/flatbuffers/src: https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/0343396e49..bcb9ef1876 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a094e2535c..e0cb589445 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e8e4eb8f1c..b6e1ac1649 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/7608093d21..2ce7927479 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/17e6503b3b..4540d5f88f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/63add4de58..f775f73afa * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bfe350d6ed..3e68a98ed5 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/68be214291..8b06a53701 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/768e830d42..171f64306f Clang version changed llvmorg-18-init-4631-gd50b56d1:llvmorg-18-init-7313-geee1f7ce Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/63add4de58da9da47128fc588c17ac4d5e614c79..f775f73afa543b4b1285aa65ca0cd9c395d07a3e/scripts/update.py Bug: None Tbr: romanl@google.com Change-Id: Iabc1fd4e312b528afdcd228d51f4a561882d3be8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4916750 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 856a6ec0 2023-10-03T17:17:35 Enable rgb-565-no-depth-no-stencil tests on Android Bots Enable gles3 and gles31 rgb-565-no-depth-no-stencil tests on Android Bots. Khronos conformance package ran the gles3 and gles31 tests with rgb-565-no-depth-no-stencil configurations on Android devices: https://github.com/KhronosGroup/VK-GL-CTS/blob/main/external/openglcts/modules/runner/glcAospMustpassEs.hpp#L41 Enable the rgb-565-no-depth-no-stencil configuration tests on Android bots to cover them. Non-Android platforms do not support rgb-565-no-depth-no-stencil configuration. We should not enable it on non-Android platforms. This CL also disables this configuration from building on non-android platforms in src/tests/BUILD.gn. Bug: b/297901032 Change-Id: I23d83213818884ea679dd76bf4b001c3b636dffc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4908171 Reviewed-by: Roman Lavrov <romanl@google.com>
Yiwei Zhang 3d75b794 2023-10-04T11:10:34 Vulkan: enable preferSubmitAtFBOBoundary for Virtio-GPU Venus Now we see perf gain for the concerning title Asphalt 9 with ANGLE-on-Venus even for low end devices. So enable this by default for Venus since it mitigates 3DMark Sling Shot Physics score regression. Bug: b/302230555 Test: top app affected by the feature and 3DMark Change-Id: I2e115e022eb085a3dc693378fe2f0a960890b7d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4911958 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll e109a092 2023-10-04T17:39:50 Manual roll vulkan-deps from 89aea904c65f to f770c9936a5a (61 revisions) Manual roll requested by cnorthrop@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/89aea904c65f..f770c9936a5a Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2bfacdac91..5ff0c048b7 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/6e1fb9b09e..37fee00a71 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/79743b899f..e867c06631 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/48c97c1311..4fab7435bf * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/df60f03168..6f0d6550e6 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f352069ad3..dedcfae378 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/576f3286e1..e483d0dfc7 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/8486ee700e..2169a0849e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1b8b09b3ab..8dee683271 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com,cnorthrop@google.com Change-Id: I0258b66f7c84f1eb39abae5aa5b648665222bfe4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4911956 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Chris Forbes <chrisforbes@google.com>
Roman Lavrov f8f98477 2023-10-04T12:54:06 Suppress VUID-VkRenderPassBeginInfo-renderPass-00904 Getting a lot of these, for example: dEQP-GLES31.functional.blend_equation_advanced.basic.multiply Bug: b/303441816 Change-Id: I78bf5c0e34bb65f349c71f324ea1c71ae8b416e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4911799 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
Roman Lavrov 276e0c78 2023-10-04T12:42:23 Also suppress VUID-VkGraphicsPipelineCreateInfo-pStages-00739 dEQP-GLES31.functional.primitive_bounding_box.points.* are hitting this one Bug: b/303219657 Change-Id: I26ae20ce6feeb84019488689667fa66fb7ca2925 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4911798 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com>
Roman Lavrov 43abae13 2023-10-04T10:49:44 Suppress VUID-VkGraphicsPipelineCreateInfo-pStages-00738 Bug: b/303219657 Change-Id: Ibc23ccc700b15c351b2d7ab644bd8fc28bc07dcf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4911795 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll c17ea301 2023-10-04T10:01:59 Roll SwiftShader from 5b6f768198ce to 400ac3a175a6 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/5b6f768198ce..400ac3a175a6 2023-10-03 cnorthrop@google.com Update Vulkan headers to version 1.3.266 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Iee12272bcc03529bab10c78d71168c3aa2e9896f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4910460 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 777a46bf 2023-09-29T00:00:00 Metal: Fix power function translation GLSL definition of pow(x, y) excludes negative x, so it must be translated to metal::powr, not metal::pow. Fixed: angleproject:8366 Change-Id: Idaa66da73a149119e2a74beddc9a49e187d3e7af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4901995 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi ffb32380 2023-10-02T16:01:37 Vulkan: Fix device creation on multi-queue devices When multiple eligible queue families are exposed by the device, ANGLE defers devices creation until a surface is made current, at which point it selects a queue family that supports presentation to that surface. This path was largely untested and was broken: - Some post-device-creation initialization was not deferred until the device was actually created - Some cap calculation depended on the chosen queue family index - Query of device capabilities was done too late, such that ANGLE could not correctly determine the level of support for ES versions. Bug: angleproject:8300 Change-Id: I2a35396d1fd08ed26d217dff07d10e9a9c1ac55f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4907895 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Roman Lavrov 1eccf863 2023-10-03T16:18:07 Handle non-debuggable com.android.angle.test on device Noticed in capture_tests on CI, and angle_perftests also runs into this. When a non-debuggable test apk is installed on the device the hash check fails as run-as does not work for non-debuggable apps. It's just an optimization to avoid re-installing the apk though, so just warn about the error and re-install the apk. Bug: b/303276423 Change-Id: Iecc68de285454043fc7f090163af373a22e11e41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4910152 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov f29f73d9 2023-10-03T14:31:47 Add missed include <atomic> Following https://crrev.com/c/4886388 Bug: b/302112423 Change-Id: I8d9c1269d5e2470ee9f559eae26eddeb8a956a9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4904696 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 75409184 2023-10-03T18:57:42 Revert "Add VMA version to logcat" This reverts commit 92218933df79a4427b9bd29d0b7af892108e410e. Reason for revert: VMA 3.0 usage is confirmed. Log can be removed. Original change's description: > Add VMA version to logcat > > This is a temporary CL. It will be used to confirm that Android > uses VMA 3.0 with ANGLE as the default driver. > > * Added the VMA version log when the renderer is being initialized. > > Bug: b/295208838 > Change-Id: I054a4e0e080aa5d06533bd7785eea608e14bba39 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4868086 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Charlie Lao <cclao@google.com> Bug: b/295208838 Change-Id: If1b9883c02c78121ff72601b650ac04aef685527 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4909899 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 7f5143c2 2023-10-02T15:38:15 Vulkan: Notify VAO when VBO's mBufferWithUserSize changed. When buffer robust access is enabled, and bufferData is called with different size and we end up reusing the underline storage, we will have to recreate VkBuffer with user's size, and driver is relying on VkBuffer's size to implement robust access. The bug here is that we notify VAO when storage changes. But when storage is reused and we have dedicated VkBufer with user size and that VkBuffer changed, we were not notifying the VAO. This CL adds that notification so that VAO gets notified and dirty bits processed and its cache of VkBuffer gets updated Bug: chromium:1488055 Bug: b/303138134 Change-Id: Ie693c92c2edde9a22a41a25f5bde493397550d95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4906568 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 8b9500ae 2023-09-28T16:15:21 Enable multisample deqp tests on bots Enable gles3 and gles31 deqp multisample tests on bots. Khronos conformance package ran the tests in gles3 and gles31 mustpass list with multisample config rgba8888d24s8ms4: https://github.com/KhronosGroup/VK-GL-CTS/blob/main/external/openglcts/modules/runner/glcAospMustpassEs.hpp#L24 Enable the multisample config tests on bots cover the tests. This CL only enables the multisample tests on Vulkan backends (including swiftshader) on Android, Linux, Windows, as we are prioritizing vulkan backend development. Bug: b/297901032 Change-Id: Iaa830bd466e3564bb1e83c98cc360bd5a85abf86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4903430 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi e9719f5c 2023-10-02T12:15:35 Capture/Replay: Disable VK_EXT_host_image_copy during capture Bug: b/303065176 Change-Id: I87f9dd11cd87115f097bb35d44f024db19274d51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4903077 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d919870f 2023-09-14T16:00:07 Vulkan: Do host image copy without holding the share group lock When an application uploads texture data such as with `glTexSubImage2D`, the share group lock is being hold while the data is being copied. Without VK_EXT_host_image_copy, this is a copy to a staging buffer, which may itself be expensive. With VK_EXT_host_image_copy, the cost of the copy is higher and so the lock would be held for a longer duration. This is particularly harmful to applications that spawn a separate thread for texture uploads (as the main thread is unable to make GL calls). This change moves the actual copy call to the tail of the call after the share group lock has been released. As a result: - The upload thread may be a bit slower, but - The copy does not interfere with the main thread, and - The copy does not interfere with the GPU's rendering work. As a result, games that load content seamlessly during gameplay should experience less stutter during texture uploads. Bug: angleproject:8341 Change-Id: I818c4389d4bf828847578da89414623e4b5e844e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4864290 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 09706e1c 2023-10-03T10:01:18 Roll SwiftShader from 7f4d495c89c2 to 5b6f768198ce (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/7f4d495c89c2..5b6f768198ce 2023-10-02 zequanwu@google.com Add LLVM_LVALUE_FUNCTION to llvm's Optional::map. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I8f05729ccf3363823502ad29db831503ef51e5a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4909161 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 16086afb 2023-10-03T07:02:18 Roll Chromium from 8a3d372ccd3c to 07002c74826e (635 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8a3d372ccd3c..07002c74826e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f360b1ae70..e487e6db20 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/50c348906c..c8bee3e69d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/074ff55a07..729cd7fa3b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7207ed23d5..0f519c0d9c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/506acd31ba..c83050b88e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4f81c1e295..88124d563b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/90a30a5b53..422ba5b9a5 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7cf98622ab..a094e2535c * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/43e5a34c5b..7608093d21 * third_party/turbine: yCsGwOtj8SizFXXeS-xmdIaZ3PuyTsy8IJsp411p_uIC..hgwj3KajqJCdACBdNiRoYQZhZw2NhHu0-pwuAp3S-LcC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f1c868477e..17e6503b3b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dc3593cbb8..63add4de58 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/91d35f630f..bfe350d6ed * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/94bb6e3960..768e830d42 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I30ecdbab1d282630f12adade60a6ec1c946ce917 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4908424 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 4ace4da1 2023-09-28T00:00:00 Metal: Add 2D array and 3D texture type mappings Do not try to copy texture levels with mismatching layer counts to avoid triggering Metal validation. Fixed: angleproject:8364 Change-Id: I4bc72be753a62dd78dc131562c62e14eb540ab2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4901993 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Amirali Abdolrashidi 84c30b76 2022-07-12T20:42:00 Vulkan: Add single-level mutable texture flushing So far, the feature to flush mutable textures after switching to a new texture only applied to textures with at least two mip levels. In that case, the whole mip chain would be allocated for those textures. This change will add single-level texture flushing as well. However, the it should be optimized to prevent allocating the whole mip chain for only one defined level, and reduce memory usage. * Updated the code for previous texture flushing to include one-mip textures as well. * Added the condition that the mutable texture not be bound as an attachment for flushing. * Changed ImageMipLevels::FullMipChain to ::EnabledLevels in order to limit the number of allocated mips. * Removed ::FullMipChain from ImageMipLevels. Bug: b/285613719 Change-Id: Ibc76917345820c5a0991f700e9fb93e4cda6efae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3763841 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 961ed7a2 2023-10-02T15:07:44 RepeatedEglInitAndTerminate: 100 -> 50 repetitions One of the variants ES3_1_Vulkan_SwiftShader_EnableParallelCompileAndLink is taking >60s which seems a bit too much time for this kind of test Bug: b/303089709 Change-Id: I75584bf376cfac8e4ddd61b21ccd75b9ac6d2967 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4908348 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 5ab344be 2023-09-28T17:26:29 Remove old VUIDs after renaming Some of the VUIDs were renamed in a recent VVL roll. The new VUIDs for those that were skipped were also added to the list in a prior fix CL. After the related VVL change and the fix also rolled into Chromium, the old VUIDs can be safely removed from the skip list. * Removed the following VUIDs from the skip list * VUID-VkBufferViewCreateInfo-buffer-00934 * VUID-VkPipelineInputAssemblyStateCreateInfo-topology-00428 Bug: angleproject:8358 Change-Id: I63474cb36408637be8a60def9add1f77c48e9c93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4903984 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov 0769e7ce 2023-10-02T14:27:10 decode() subprocess.check_output output Currently getting this output as a single line: export_targets.py failed: b'Importing graph\n ( ...' Bug: b/303079476 Change-Id: Ia6c13822476744efd4a8a2934eaedb30ec463709 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4908347 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxin Hu 32ef34df 2023-10-02T10:30:48 Remove the dEQP-EGL.functional.color_clears*/render* test suppression The dEQP-EGL.functional.color_clears* and dEQP-EGL.functional.render* test failures on Pixel6 have been fixed in https://gerrit.khronos.org/c/vk-gl-cts/+/12272. Remove the test suppression from the expectation files. Bug: b/295394803 Bug: angleproject:8214 Change-Id: I2d99f9ed282eba43dc9c18e4427f5abd5014224e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4908191 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 3d5308aa 2023-10-02T07:01:20 Roll Chromium from 7d030fb2d0f3 to 8a3d372ccd3c (719 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7d030fb2d0f3..8a3d372ccd3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/23812209f6..f360b1ae70 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ece39eb658..50c348906c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7be94e7b03..074ff55a07 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/7ebbd1ea9b..1fb4dd28f9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a217ecb5ad..4f81c1e295 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c1d6d90bc..90a30a5b53 * third_party/fuchsia-sdk/sdk: version:15.20230920.1.1..version:15.20230930.1.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/8a241ea043..7cf98622ab * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/724cd40fb6..43e5a34c5b * tools/luci-go: git_revision:3e49653ac027a003d9ef6cf89068acbf28f5bd9e..git_revision:589d8654cfa7808816a6ecb4284ed2fd72c2f6d5 * tools/luci-go: git_revision:3e49653ac027a003d9ef6cf89068acbf28f5bd9e..git_revision:589d8654cfa7808816a6ecb4284ed2fd72c2f6d5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/471bcb7483..94bb6e3960 * tools/skia_goldctl/linux: O5Qnoa4MmsF8xWeyb3Q21JeZTv-xshcXDBNTFS0Pbm8C..yRR4wNw_p_PCRQQVZO5Y4UKfDQ0AqBIKbfj97QVbiIcC * tools/skia_goldctl/mac_amd64: N0TF2Fb4AY_HGf_wkMFjMsShJ9KADsZEkZyxbBuGjyoC..1SHcSqKCFlDIwzDTHUyQqql_3FxCOIdJmgUMpdXJHssC * tools/skia_goldctl/mac_arm64: dhhDKAB9aDP4kBCiYZz4-8h4kkvsOmg5s9HqFtLpSqEC..26EXZ4e5kuFt-BT9YOQKl6ZE6fkCcjVqF8sBdp5FWiIC * tools/skia_goldctl/win: OpzSEVB6-LaJ1-yaM5mISiNaWker0hgINXOgwOS0dGUC..wSL6CZdkxlrYe9Uuw6OIWVysK5_6_RYkQmAE83aVbW8C No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I7e940df79d57009c0887115732ccb27301f36f9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4907007 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 34c8778b 2023-09-26T13:45:06 Use atomic counters early in perf warning macros Before this CL, snprintf was called repeatedly to format the warning message which was then discarded after 4 logs. snprintf showed up in profiling at ~2% and this CL appears to yield an ~8% power improvement in one of the traces (egypt_1500). A mutex was previously used to avoid the race condition on the static sRepeatCount variable. This CL avoids the need for that by using static atomics instead. Also updated the Debug macro to use the VK macro vararg approach so that formatting only happens when the message is actually logged. Bug: b/302112423 Change-Id: Ia8a18361cfb5a9f2aa19ff939499754ba861efb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4886388 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 03034715 2023-09-29T15:35:50 Roll VK-GL-CTS from d88f9c5772a8 to a55b0930e9db (10 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/d88f9c5772a8..a55b0930e9db 2023-09-29 rgarcia@igalia.com Fix VulkanSC version check for promoted function pointers 2023-09-29 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-09-28 javed@igalia.com Add TESS/GEOM shaders in combination with the barycentric FS 2023-09-28 ziga@lunarg.com Add texture gather offsets tests using implementation limits 2023-09-28 gleese@broadcom.com Simplify construction of float controls tests 2023-09-28 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2023-09-25 rgarcia@igalia.com Test GPL with XFB 2023-09-22 rgarcia@igalia.com Add more XFB simple test variants using PointSize 2023-09-22 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2023-09-22 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2eeb1e3e724c341cd577421d1b4c3795dd152b44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4904361 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 03eea365 2023-09-25T17:50:51 ANGLE Tracer: Mark FBAttachment texture resources as active If a texture and framebuffer were set up before capture and referenced during a capture, the texture resource would not be set as active and the trace may fail. Test: Capture a Diablo Immortal trace and attempt to replay Bug: b/301999483 Change-Id: I5ea114e65b11479a5cdbf496dc8c5ab4eeadbf55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4893251 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Kenneth Russell d1d639eb 2023-09-28T15:02:14 Don't check out Android dependencies on macOS. Doing so is causing problems for multiple teammates. Fixed: angleproject:8363 Change-Id: I29e8e4e25fae2726b2af61abffb86ab8c2abaa6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4902756 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 16651b65 2023-09-29T08:46:41 Roll Chromium from 1fe2defab2d7 to 7d030fb2d0f3 (752 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1fe2defab2d7..7d030fb2d0f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4cf92feae1..23812209f6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2c6e20e2ff..ece39eb658 * buildtools/reclient: re_client_version:0.114.2.81e819b-gomaip..re_client_version:0.113.0.8b45b89-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/76f3b55855..7be94e7b03 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9f3298993d..7207ed23d5 * third_party/android_build_tools/manifest_merger: EPmMtC5CNXQqxByKOxqF9Vk8LURwarA6qy5siWX1kRoC..9gAaukznhLAAtANeZ_AT_9z8xXF5ZUzuc0h0TfMr7IIC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/328888ea45..a217ecb5ad * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/34e0ecf20e..4c1d6d90bc * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/055d494c5c..8a241ea043 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/49658294d8..724cd40fb6 * third_party/siso: git_revision:7c83de2b4db68a7b96e62a272a3b1eb40681fb81..git_revision:23257e255f1d58d9f66923a1a40e746ac3a4b9d8 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/91a295c72e..3f0af7f1d5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f8b2b1163d..dc3593cbb8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/01291106f9..91d35f630f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8084029261..471bcb7483 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ief8bca49c9d18ea77c95dd6eea382c383bc1d12d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4903435 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 1cab871c 2023-09-27T22:11:25 GL: Fix ScalarizeVecAndMatConstructorArgs vs precision If the constructor being expanded has no precision (such as if it's entirely made up of constants and bools), the workaround didn't produce a precision for the helper function, leading to GLES compilation errors. Bug: chromium:1420130 Bug: angleproject:8361 Change-Id: I0de312dfd1bfbf45317db4fb88d685a843052817 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4898697 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 6717a65b 2023-09-28T00:00:00 Metal: Skip maximum render target size validation for Mac GPUs Only GPUs that do not support Mac families have this limitation. Bug: angleproject:8268 Change-Id: I3f9174dd104c2ba4e9781272fbc7062fe14d78a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4903722 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Kyle Piddington d55893cd 2023-09-27T16:40:58 Issue 1484512: Out of bounds access to Metal uniform blocks Fixed conversion offset for Uniform buffers: Dynamic buffers were being allocated and copied from the 'updateBufferSubData' offset, than from the previously allocated offset. This meant that when creating a new dynamic buffer to hold the metal uniforms, ANGLE didn't re-convert blocks from the initial source offset, nor did we allocate enough space to read those blocks. Important use cases to test include any UBO-heavy sites. Bug: chromium:1484512 Change-Id: Ia9f505e3df871a401d40682d737019bd5d3f443f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4899369 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
angle-autoroll 621bee25 2023-09-27T22:07:24 Manual roll vulkan-deps from b8fa58ef74a9 to 89aea904c65f (61 revisions) Manual roll requested by abdolrashidi@google.com * Updated the skipped VVL messages in accordance with the following vulkan-deps roll: Vulkan-ValidationLayers to 9fe2f727 https://chromium.googlesource.com/vulkan-deps.git/+log/b8fa58ef74a9..89aea904c65f Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/4c57db1595..2bfacdac91 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/5e963d62fa..6e1fb9b09e * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/fc7d246276..79743b899f * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a40483d313..48c97c1311 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/4f51aac14f..df60f03168 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/9dc0e31574..f352069ad3 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1ecbed6db3..576f3286e1 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/6774c9b24b..8486ee700e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c26ff51102..1b8b09b3ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8358 Tbr: abdolrashidi@google.com Change-Id: I7927abe872fbb1d25523b06cc205b13ef2a887f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4898000 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Alexey Knyazev 49c4d87a 2023-08-21T00:00:00 Apply fragment color broadcasting to secondary outputs When GL_EXT_draw_buffers is enabled, gl_FragColor is replaced with gl_FragData. Apply the same transformation to gl_SecondaryFragColorEXT if it is statically used to avoid compiler failures. Bug: angleproject:1085 Change-Id: If154cd20a8e14a92da520847a9c4508971a45fef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4900641 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 25bfe035 2023-09-07T00:00:00 GL: Adjust disableTextureMirrorClampToEdge condition The extension support has been fixed in Mesa 23.1.7. Fixed: angleproject:8319 Change-Id: Ie83dee83773823dad90826267040e40b6f296c53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4901182 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 66d3db3b 2023-09-27T09:15:19 d3d: Shorten warning about complex uniform blocks The warning was excessively large, while ANGLE_PERF_WARNING might use a smaller buffer to format the message. Bug: b/302112423 Change-Id: Ie8c2fe472c90a39f678fa685e852bbd49b5c8442 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4894632 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 80228c64 2023-09-28T07:00:45 Roll Chromium from 90ee8fc080db to 1fe2defab2d7 (444 revisions) https://chromium.googlesource.com/chromium/src.git/+log/90ee8fc080db..1fe2defab2d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0a9aa32bbe..4cf92feae1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/dd597d467e..2c6e20e2ff * testing: https://chromium.googlesource.com/chromium/src/testing/+log/95b1376904..76f3b55855 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4105ea6a42..328888ea45 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8609345923..34e0ecf20e * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/823696f806..055d494c5c * third_party/siso: git_revision:412571deccd76eb54f681963ca14e13c3efc63e1..git_revision:7c83de2b4db68a7b96e62a272a3b1eb40681fb81 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/fc2715028a..91a295c72e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a705c19db3..01291106f9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c9d48cf49a..8084029261 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ifee60b1d83ae0abe48a1694126885158af7542d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4900419 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jeff Vigil 929ace8d 2023-09-22T09:59:43 Vulkan: Get queueFamilyIndex from renderer In WindowSurfaceVkWayland::createSurfaceVk, use context->getRenderer()->getQueueFamilyIndex() to get index Bug: angleproject:8353 Change-Id: Ia209c1c8a16ef12e260b0a9d584b50b1a4c95181 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4885341 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jeff Vigil <j.vigil@samsung.com> Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Hans Wennborg a2a16b45 2023-09-27T16:57:23 Use constexpr if to suppress more aggressive conversion warning The latest version of Clang started warning about the implicit conversion in the 'else' branch even for types where that branch is not taken. Use 'constexpr if' to passify the compiler. Bug: chromium:1487142 Change-Id: I52ae111abaeac46b586bf9f5c150c9a58e419704 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4891702 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Greg Schlomoff d07965b3 2023-09-25T16:54:00 Workaround for the ETC2 transcoding bug on some AMD GPUs. We now perform alpha encoding first, in 8-bit alpha mode. While this should not make any difference from a logic perspective, it does fix a bug on certain AMD GPUs. See b/300672851 for details. Tested on a Radeon RX 560X Series GPU, which current drivers. Bug: b/300672851 Change-Id: I5d2bfbca36a27f064918f19e7330dd7467a320cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4892879 Reviewed-by: Hailin Zhang <hailinzhang@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 3defb2cd 2023-09-26T14:03:47 Remove mention of --use-goma from capture/replay doc Goma is autodetected. --use-goma is not accepted by the script anymore and was removed in: https://chromium-review.googlesource.com/c/angle/angle/+/3149190 Bug: angleproject:6102 Change-Id: I19c32346f86ca608476af2dff40b9d6ea0a3eb44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4894631 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll cc689920 2023-09-27T07:00:44 Roll Chromium from eaf61b9c576c to 90ee8fc080db (1095 revisions) https://chromium.googlesource.com/chromium/src.git/+log/eaf61b9c576c..90ee8fc080db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bf26514b29..0a9aa32bbe * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b1681a8c6c..dd597d467e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/96134a476f..95b1376904 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/c2ac88e292..9f3298993d * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/801bc6657b..290bf47520 * third_party/android_build_tools/lint: l5GhbN0RAcpoaj1qIS43ZX7AYnLxdF-rZJ0ruGu_iWAC.._HzBkAzPHHstN_PQaEGq4413D2VuwK7rqGfk8qD--SsC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/297421bd46..506acd31ba * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3c4b5cf37f..4105ea6a42 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c5505889cf..8609345923 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/645470002f..823696f806 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c28dc42f0d..e8e4eb8f1c * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/1f88fff745..49658294d8 * third_party/r8: w5NK9teKNDuEhU_7rQE8WYwuBzdXA8lVkJwo6VOgWv8C..ZQH8yoO1Ol5rCFRL2hzp4_mcdq23Fk19Z_gVHn5pzk8C * third_party/turbine: NR31kJWll1NZz_scMvMPtPH_P3wOQ5aKBJ-n8XQ7QrYC..yCsGwOtj8SizFXXeS-xmdIaZ3PuyTsy8IJsp411p_uIC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/26ace0aa44..f1c868477e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8709515e87..f8b2b1163d * tools/luci-go: git_revision:8b73cff3b780a7136c4904103f19124d2be3dee1..git_revision:3e49653ac027a003d9ef6cf89068acbf28f5bd9e * tools/luci-go: git_revision:8b73cff3b780a7136c4904103f19124d2be3dee1..git_revision:3e49653ac027a003d9ef6cf89068acbf28f5bd9e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/30749e99ce..a705c19db3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1b7548b361..c9d48cf49a No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: If81ca949e6c3d6a7d7a0a145140cf02e01ed5ed1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4896245 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 2c0f9d20 2023-09-26T11:50:54 Metal: Protect against invalid locations in setUniformImpl Chrome disables validation and a common bug is that the wrong program is used during uniform setting in Skia. Make this bug less catastrophic while the root cause is investigated. Bug: chromium:1484878 Change-Id: I521e99cdf6cebc56775e484fa8d61ad18f506479 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4886384 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 7cacb537 2023-09-26T11:27:49 Limit the uncompressed data size when decompressing blobs. If the data in the blob cache is invalid for any reason, ANGLE will take the last 32 bits of it an interpret it as a size for decompressing the blob. Add some reasonal upper bounds on the decompressed data size so that if the data is invalid it will simply fail decompression instead of allocating giant buffers. Bug: chromium:1485277 Change-Id: Ifb807f5ea836b692f37734b20789f5daefcca5c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4887599 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cody Northrop 7f5b5f74 2023-09-19T07:35:16 Tests: Add Batman: The Telltale Series trace Test: angle_trace_tests --gtest_filter="*batman_telltale*" Bug: b/301024256 Change-Id: Ice5aa3ed093901c04486fca64121592eb8805f93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4883428 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 97a48912 2023-09-26T10:31:58 Turn is-link-thread-safe feature into a positive condition Chrome's --disable-gpu-driver-bug-workarounds currently sets every feature to false, which breaks the GL backend. Bug: angleproject:8297 Change-Id: I284d0699e356d7c1a362eb992cdc0d052f9ea7c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4887598 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 1579eed5 2023-09-25T18:21:39 BufferHelperPointerVector -> BufferHelperQueue (deque) DynamicBuffer.mBufferFreeList is a vector<unique_ptr>. DynamicBuffer::allocate erases an element from the front, which is what deque is exactly good for. Changed other uses too (mBufferFreeList, VertexArrayVk.mCachedStreamIndexBuffers) per Charlie's recommendation. Yields a significant power improvement in words_crush trace. Bug: b/302020992 Change-Id: I1b0242481404b8fc2cfdc27611252308b922f4d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4886367 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov c9955641 2023-09-25T14:31:01 Avoid malloc in angle::Mat4 by using array instead of vector angle::Matrix<float>::inverse() showed up in cpu profile of "minetest" trace at ~10%. It's a gles1 trace. Multiple objects are constructed and require malloc due to the use of std::vector. Called here: https://crsrc.org/c/third_party/angle/src/libANGLE/GLES1Renderer.cpp;drc=eb0d59973d21f845b5785563f5d56b8ebb617478;l=371 This CL decouples Mat4 from angle::Matrix (some of the functionality had to be copied over) to switch from std::vector to std::array. Testing "minetest" on a phone I saw a ~20% cpu power improvement due to this CL. There is an existing unit test coverage: MatrixUtilsTest.Mat4InvTr Moved 4x4 cofactor matrix code to a helper with transposition included Bug: b/301977186 Change-Id: I1e4c2201d19759dd37c0fee44fb44f4d24a58a6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4885501 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Mohan Maiya 6b0ddce0 2023-09-22T13:13:38 Backends need to handle invalid render area during a clear 1. Frontend no longer noops empty scissors during clear 2. FramebufferVk is updated to handle invalid render area by restaging deferred clears in clearImpl(...) if render area is invalid Bug: angleproject:8348 Tests: EGLSurfaceTest*WindowThenScissoredClear* Change-Id: Iec51914a083a59bad7f939798c932dffada56a6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4867641 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Mohan Maiya 826e5f95 2023-09-24T09:48:55 Vulkan: Rename redeferClears as restageDeferredClears This is a simple rename to better reflect implementation and has no functional changes. Bug: angleproject:8348 Change-Id: I53ce42e8bb14687a0dda167b8d79eba1eb357254 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4888691 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao be8739f2 2023-09-22T14:36:45 Vulkan: Fix StatInfo in vk_mem_alloc_wrapper.h to match VMA Right now we are defining our own StatInfo structure in vk_mem_alloc_wrapper.h to avoid inclusion of VMA header directly in other ANGLE code. This caused this struct no longer matches VMA's structure since VMA 3.0 switch. For quick fix, this CL just update StatInfo to match VMA 3.0 define. Bug: b/301653706 Change-Id: Ic510c362f30d9296a13964e6ba9c617e80e49ceb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4888625 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Mohan Maiya 6399f8d3 2023-09-24T05:01:22 Bugfix in HandleAllocator::reset(...) Cache "maximumHandleValue" passed in via constructor and use this value in reset(...) Bug: angleproject:8354 Test: HandleAllocatorTest.ResetAndReallocate Change-Id: I63bb953186a07d32582a0276af3ac8cb26a007a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4888690 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 29d0fe51 2023-09-25T07:03:09 Roll Chromium from 86cb232d2fc2 to eaf61b9c576c (734 revisions) https://chromium.googlesource.com/chromium/src.git/+log/86cb232d2fc2..eaf61b9c576c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3a0a70c754..bf26514b29 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d53d0131e2..b1681a8c6c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f5159f7d11..96134a476f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/99f2d536fb..3c4b5cf37f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af369d8962..c5505889cf * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a75061bc37..645470002f * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/cb9bef1717..c28dc42f0d * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/4027f4521c..1f88fff745 * third_party/r8: qLYuLt4k9raGYbeiaAh3ORseYrHh8pt9WUaeD60Yov4C..w5NK9teKNDuEhU_7rQE8WYwuBzdXA8lVkJwo6VOgWv8C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/b1f4a09d6f..fc2715028a * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f1c4d9a146..26ace0aa44 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ac34945aad..8709515e87 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0ce20e9bb6..30749e99ce * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/332226148d..1b7548b361 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I92e71cf2e4292541413cb14ef59ba7edce77294a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4891377 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 9fc3baf5 2023-07-26T10:29:13 Add the missing GraphicsPipelineDesc legacy dither bit update When the app calls glEnable(GL_DITHER) or glDisable(GL_DITHER), we need to update the legacy dither bit of the renderpass that belongs to ContextVk::mGraphicsPipelineDesc. If not, there is a change that the graphics pipeline will be created with a renderpass that has outdated legacy dither bit. This results the dither being applied to the render results incorrectly: e.g. the app calls glDisable(GL_DITHER), but the render results have dithering applied. Bug: b/286921997 Bug: b/292282210 Bug: b/293349058 Bug: b/284462263 Change-Id: Ie24b95898526c9021be6e3cb7620e4050f9faaaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4722446 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Hailin Zhang 141bada9 2023-09-22T10:25:30 Vulkan: add prefer cached memory type for dynamic buffer usage. Bug: b/288119108 Change-Id: I0fb5d91780e83af06762b9f3e6122313e76624da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4886846 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Hailin Zhang <hailinzhang@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi e1d2e88a 2023-09-20T11:53:15 Check pending garbage after some buffer releases * Embedded BufferHelper::releaseBufferAndDescriptorSetCache() inside a new ContextVk method: releaseBufferAllocation() * After releasing the buffer, there is a check for excess pending garbage. If the tracked pending garbage size is larger than the threshold, the context will be flushed. * Unskipped the test "BufferDataInLoopManyTimes", which was failing on Android devices. Bug: b/280304441 Change-Id: Ib34319f3291dd2200fc1a92e30645f9d1da8e2b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4879086 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Christopher Cameron a1e3abc0 2023-09-22T10:14:43 Add ES2 support for copying GL_SRGB8_ALPHA8 to GL_RGBA8 Bug: angleproject:7907 Change-Id: I02ae9785ea1f942e85983c18155cfd75ec39b5c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4887271 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Le Hoang Quyen 7b1b8a01 2023-09-21T20:15:29 Metal: Allow using GL_RGB with either RGBA/BGRA IOSurface. Previously we only allowed GL_RGB internal format to be used with BGRA IOSurface and GL_RGBX8_ANGLE to be used with RGBA IOSurface respectively. However, there are currently many places in Chrome prefer GL_RGB to be able to be used with both RGBA and BGRA IOSurface. This CL allows such combinations. Instead of deducing angle::FormatID of the IOSurface pbuffer based on the input GL internal format & type, we will take into account the pixel format of the IOSurface as well. For example, when we call eglCreatePbufferFromClientBuffer with GL_RGB internal format attribute: - if IOSurface's pixel format is 'RGBA' -> deduced angle::FormatID is R8G8B8A8_UNORM. - if IOSurface's pixel format is 'BGRA' -> deduced angle::FormatID is B8G8R8A8_UNORM. This CL also removes GL_RGBX8_ANGLE support from Metal backend. Because there are many places in Chrome that use this format enum for both RGBA & BGRA IOSurface when the extension is available. It's redundant to support that since GL_RGB already covers most of the required cases. Bug: angleproject:8350 Change-Id: I5a121a97e031a42d0779721d4348f373dfaee9a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4881742 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
angle-autoroll 63eb70a6 2023-09-22T13:35:51 Roll VK-GL-CTS from 23a6249942af to d88f9c5772a8 (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/23a6249942af..d88f9c5772a8 2023-09-22 ziga@lunarg.com Remove exceptions from vkGetDeviceProcAddr test 2023-09-22 aitor@lunarg.com Add u/int to fp spirv conversion rounding tests 2023-09-22 dneto@google.com Exercise narrowing float conversions with RTE, RTZ 2023-09-22 gleese@broadcom.com Reduce copy-and-paste in localsize tests 2023-09-22 ziga@lunarg.com Fix pNext chain for device create info in api buffer tests 2023-09-22 ewerness@nvidia.com Compare the results of the shader with an epsilon 2023-09-22 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-09-21 lorenzo@khronosgroup.org Merge "Merge dev/VK_EXT_frame_boundary into main" into main 2023-09-15 gleese@broadcom.com Fix misspelling of OID_LENGTH If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ib45b73402c26629a30424603ee9ad03a1ad08ea8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4885336 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4ff5beba 2023-09-22T08:17:00 Roll Chromium from 65385dc9c1b7 to 86cb232d2fc2 (626 revisions) https://chromium.googlesource.com/chromium/src.git/+log/65385dc9c1b7..86cb232d2fc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/480a7a59d8..3a0a70c754 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fb8823aeb4..d53d0131e2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/625ab1c17d..f5159f7d11 * third_party/android_build_tools/manifest_merger: FlwnxEZ1wdjoQfedkF4MiZgo8pD48-_CJNA7RnU6as4C..EPmMtC5CNXQqxByKOxqF9Vk8LURwarA6qy5siWX1kRoC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/43f4530c97..99f2d536fb * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a45d2d4c90..af369d8962 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/316166f499..a75061bc37 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/82c3c02548..cb9bef1717 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/244575ffb6..4027f4521c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cd4546f65b..0ce20e9bb6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/29f2e7dc1c..332226148d No update to Clang. Bug: angleproject:6430,angleproject:8317 Tbr: cnorthrop@google.com Change-Id: I31aa962ae8747977ec2281c40ae3b0110ddb3664 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4886730 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 26148a02 2023-09-21T11:25:16 Vulkan: Minor cleanup of mPrevUploadedMutableTexture When texture is transit from mutable to immutable, we need to remove it from SharedGroupVk::mPrevUploadedMutableTexture if it is pointing to. Right now we did not clear the pointer, but rely on next texImage call to detect that mPrevUploadedMutableTexture is pointing to a immutable texture and then set it to new tetxure. This is a bit confusing since we only add a mutable texture to this mPrevUploadedMutableTexture pointer but at some point it becomes immutable. This CL changes to immediately reset the pointer when texture is respecified from mutable to immutable, and added assertion that mPrevUploadedMutableTexture is mutable. Bug: b/301289624 Change-Id: I97a11616887367cd4c2069419fe17d3dea052b50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4879087 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll 9f94ab7f 2023-09-21T08:48:56 Roll Chromium from 82003a98b373 to 65385dc9c1b7 (649 revisions) https://chromium.googlesource.com/chromium/src.git/+log/82003a98b373..65385dc9c1b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f474ec05a2..480a7a59d8 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/da74596ec9..fb8823aeb4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6b95b20c49..625ab1c17d * third_party/android_toolchain/ndk: vD5FPvy1sIu7nXcWvm7PTF4yfBbjkyJJC-AgjYEdaYQC..NSOM616pOQCfRfDAhC72ltgjyUQp9lAWCMzlmgB18dAC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7eff3d6a1f..43f4530c97 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed9a0819a4..a45d2d4c90 * third_party/fuchsia-sdk/sdk: version:15.20230909.2.1..version:15.20230920.1.1 * third_party/kotlin_stdlib: 7XCiIAlSi36gvPwOn8N4Q1GE9sMLw6V1RljM9151cWIC..as5vlzFVMpLTCQXVJqs-kifMAEQmjK_fImDy09zQB8AC * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/3e8a3b3c5d..316166f499 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f6a17c88dd..82c3c02548 * third_party/r8: f6AwZX-cIa-qdx2fK93cJy9cfTg9ZqO2PkBWDNUMZXQC..qLYuLt4k9raGYbeiaAh3ORseYrHh8pt9WUaeD60Yov4C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/235986452b..b1f4a09d6f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/45952a2a57..cd4546f65b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7d52128ecb..29f2e7dc1c No update to Clang. Bug: angleproject:6430 Tbr: cnorthrop@google.com Change-Id: I2c0c71fe008388338dd400e58ba789131a070442 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4882004 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Igor Nazarov 73252f34 2023-09-20T16:46:47 Fix ASSERT and potential bug with UnlockedTailCall ASSERT happened in the Instagram application. - record REEL using camera; - press "Next" button; - return to the previous screen; - ASSERT happens. Crash details: pid: 31451, tid: 2938, name: mediacompositio >>> com.instagram.android <<< signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr -------- Abort message: 'FATAL: entry_points_egl_autogen.cpp:437 (EGL_GetError): ! Assert failed in EGL_GetError (../../src/libGLESv2/entry_points_egl_autogen.cpp:437): backtrace: ... #07 pc 0000000000627740 /vendor/lib64/egl/libGLESv2_samsung.so (gl::LogMessage::~LogMessage()+140) (BuildId: acced3587e668343) #08 pc 000000000027e79c /vendor/lib64/egl/libGLESv2_samsung.so (EGL_GetError+360) (BuildId: acced3587e668343) #09 pc 000000000007c14c /system/lib64/libEGL.so (android::eglGetErrorImpl()+28) (BuildId: 5b32b014e5c062afdd3d1abd3ba13dd2) #10 pc 0000000000079464 /system/lib64/libEGL.so (eglDestroyImageKHR+20) (BuildId: 5b32b014e5c062afdd3d1abd3ba13dd2) #11 pc 000000000000e540 /system/lib64/libnativedisplay.so (android::EGLConsumer::EglImage::~EglImage()+44) (BuildId: 3b0b03d2c8ab7eb49d16eb7be29eb3fd) #12 pc 000000000000e598 /system/lib64/libnativedisplay.so (android::EGLConsumer::EglImage::~EglImage()+16) (BuildId: 3b0b03d2c8ab7eb49d16eb7be29eb3fd) #13 pc 000000000000e434 /system/lib64/libnativedisplay.so (android::EGLConsumer::onFreeBufferLocked(int)+156) (BuildId: 3b0b03d2c8ab7eb49d16eb7be29eb3fd) #14 pc 000000000000bda0 /system/lib64/libnativedisplay.so (android::SurfaceTexture::freeBufferLocked(int)+48) (BuildId: 3b0b03d2c8ab7eb49d16eb7be29eb3fd) #15 pc 00000000000bc294 /system/lib64/libgui.so (android::ConsumerBase::onBuffersReleased()+172) (BuildId: f219f4196018eeed01e28ec428c73c99) #16 pc 000000000008d9d4 /system/lib64/libgui.so (android::BufferQueue::ProxyConsumerListener::onBuffersReleased()+92) (BuildId: f219f4196018eeed01e28ec428c73c99) #17 pc 0000000000099608 /system/lib64/libgui.so (android::BufferQueueProducer::disconnect(int, android::IGraphicBufferProducer::DisconnectMode)+184) (BuildId: f219f4196018eeed01e28ec428c73c99) #18 pc 00000000000eb3ec /system/lib64/libgui.so (android::Surface::disconnect(int, android::IGraphicBufferProducer::DisconnectMode)+268) (BuildId: f219f4196018eeed01e28ec428c73c99) #19 pc 00000000000eaf04 /system/lib64/libgui.so (android::Surface::hook_perform(ANativeWindow*, int, ...)+264) (BuildId: f219f4196018eeed01e28ec428c73c99) #20 pc 0000000000031214 /system/lib64/libvulkan.so (vulkan::driver::DestroySurfaceKHR(VkInstance_T*, VkSurfaceKHR_T*, VkAllocationCallbacks const*)+56) (BuildId: 44c563855311012ead3ce5e7afdb9792) #21 pc 000000000039bb40 /vendor/lib64/egl/libGLESv2_samsung.so (void std::__Cr::__function::__policy_invoker<void (void*)>::__call_impl<std::__Cr::__function::__default_alloc_func<rx::WindowSurfaceVk::destroy(egl::Display const*)::$_0, void (void*)> >(std::__Cr::__function::__policy_storage const*, void*)+140) (BuildId: acced3587e668343) #22 pc 0000000000522114 /vendor/lib64/egl/libGLESv2_samsung.so (angle::UnlockedTailCall::runImpl(void*)+56) (BuildId: acced3587e668343) #23 pc 000000000027dcec /vendor/lib64/egl/libGLESv2_samsung.so (EGL_DestroySurface+260) (BuildId: acced3587e668343) This CL will fix the ASSERT as well as remove possibility of calling same callback twice. Bug: angleproject:8127 Change-Id: I8e56981d0db2ef5723afedc22d5286421237444b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4874040 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Igor Nazarov 1833a686 2023-09-20T16:21:21 Fix FixedVector bugs and unit tests Problems: - test was not testing assignment operators; - fixed compilation error in r-value assignment operator; - r-value constructor/assignment were not resetting size. Additionally updated FixedVector.Constructors to better test copy and assignment operations. Bug: angleproject:2435 Bug: angleproject:8127 Change-Id: Ic501b8d85af0280801c7abec8fb20a0ddf67580b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4874039 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 8fcd4a50 2023-09-19T14:08:14 Cleanup POD struct usage to make them more consistent In recent months, I have made many CLs to wrap various data structures into a trivially copy-able struct. Some of them uses different terminology. This CL replaces all of these to use a consistent name "pod" in the struct, and "mPod" in a class. This CL also turns ActiveVariable methods into macros to remove the code duplication. This CL also moves ProgramInput/ProgramOutput struct implementations from Program.cpp to ProgramExecutable.cpp Bug: b/275102061 Change-Id: Ia2a4210a9ea633f3d323bebe674ee74f8b90b363 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4877335 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Charlie Lao 9ca025d2 2023-09-18T15:50:48 Flatten BufferVariable/ShaderVariableBuffer/InterfaceBlock struct InterfaceBlock inherits from ShaderVariableBuffer, ShaderVariableBuffer is not a trivially copyable struct, this made InterfaceBlock not trivially copyable. InterfaceBlock is being used by some app traces for uniform blocks. BufferVariable inherits from sh::ShaderVariable which is very complicated and not trivially copyable. This CL flattens all of these three structs to simple structs without inheritance, and wraps all trivially copyable data into one POD struct, thus load/save are cheaper. Bug: b/275102061 Change-Id: I96f89176ce3d3131cb1d3ea3280c3c36c257560f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4874610 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Christopher Cameron 120e90eb 2023-09-08T11:23:11 Add test for copying GL_SRGB8_ALPHA8 to GL_RGBA8 The pixel values should be the same (no conversion should happen). Include sub-tests with and without alpha premultiplication. Bug: angleproject:7907 Change-Id: I2e3d657d5b8513cd06df357e84027572ebce03ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4852258 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev f5842350 2023-08-21T00:00:00 Vulkan: Flatten secondary fragment output arrays Added a SPIR-V transformation that makes them private and copies their values into regular fragment outputs. Fixed: angleproject:8336 Change-Id: Ide62dd183426e0de70fd4ac6d2b8c6a4b4b33994 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4875327 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Charlie Lao 44c6effd 2023-09-20T11:21:49 Fix potential timeout of FixedQueue.ConcurrentPushPop test The test some times times out in bots. I think what happens is that when dequeue thread went to sleep and then wake up, during sleep the enqueue thread already finished and exited (maybe because of timer runs out), then it will forever stuck in the while loop. This CL adds the check for other thread is finished or not and exit while loop if other thread has finished. Bug: b/301283364 Change-Id: Id6d846600b1749ce0bcb7b080b3b8ce3ad3d1dc4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4879083 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Christopher Cameron b480ba30 2023-09-18T17:30:09 CopySubTexture: Fix premultiplied alpha When copying from an sRGB texture to a non-sRGB texture, un-do the sRGB-to-linear transform independently of the premultiply vs unpremultiply properties of the texture. The sRGB-to-linear transform performed during sampling is performed on the RGB part of the pixel, independent of the alpha channel's value. Un-do this part immediately before examining the alpha channel's value (and its premultiply vs unpremultiply state). Bug: angleproject:7907 Change-Id: I50c8f56182a46957febcd1f7b7887b0956074bb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4872047 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org>
Le Hoang Quyen bfae8072 2023-09-20T06:48:06 Metal: Support RGBA IOSurface pbuffer. Currently only BGRA IOSurface is supported by ANGLE. This CL adds RGBA IOSurface support to Metal backend. - Added GL_RGBX8_ANGLE & GL_UNSIGNED_BYTE attributes combo to specify that the IOSurface is RGBX. Only supported on Metal backend for now. - Added GL_RGBA & GL_UNSIGNED_BYTE combo to specify that the IOSurface is RGBA. Only supported on Metal backend for now. Bug: angleproject:8350 Change-Id: I0e05762870c9c034bca78e8989aedf346406df57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4874484 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll 67350e64 2023-09-20T10:01:54 Roll vulkan-deps from 640b7331b244 to b8fa58ef74a9 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/640b7331b244..b8fa58ef74a9 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a996591b1c..a40483d313 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/a01cfc0b78..1ecbed6db3 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/21ded6ed67..6774c9b24b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8c7da10180..c26ff51102 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I0e0a9cdbb7404fbff02fc7b113c47b938aae39e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4877343 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ea74cc8d 2023-09-20T07:02:14 Roll Chromium from 26ff6b8864ac to 82003a98b373 (614 revisions) https://chromium.googlesource.com/chromium/src.git/+log/26ff6b8864ac..82003a98b373 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a66b1c2c6f..f474ec05a2 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a567506e78..da74596ec9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0f7651344a..6b95b20c49 * third_party/android_toolchain/ndk: 3vHltFqfgIw8wZ38ggGM9c7Eyw_AHZnwCgFIVtc9gngC..vD5FPvy1sIu7nXcWvm7PTF4yfBbjkyJJC-AgjYEdaYQC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/693c3fa3c2..7eff3d6a1f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/36bd52621f..ed9a0819a4 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7cee6b00d3..3e8a3b3c5d * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/d9b4abf6b6..244575ffb6 * third_party/r8: WptUn43oi_BkFPtEyZTdUD9wZo1yy8OPVqFwdP3jmqoC..f6AwZX-cIa-qdx2fK93cJy9cfTg9ZqO2PkBWDNUMZXQC * third_party/turbine: laSnfZnTgkmZynERrjAlU3yeqB5rN446BctGmKQsZ64C..NR31kJWll1NZz_scMvMPtPH_P3wOQ5aKBJ-n8XQ7QrYC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/31a7453f89..ac34945aad * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0e407d39db..45952a2a57 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ia7ec980ff68ff03aa866bb3e921d9990776a3765 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4878593 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Le Hoang Quyen e3054599 2023-09-04T23:20:19 Metal: Don't use implicit MSAA for render buffers. This CL removes the usage of implicit MSAA from render buffers. Implicit MSAA added an extra single-sampled texture & resolve step when clients render to a multisampled render buffer. It is as if EXT_multisampled_render_to_texture extension is always used even though users might not request for it. Not to mention this extension's implementation is incomplete. Furthermore, it is hidden from users. Thus the only way for them to use the render buffer after rendering (presentting to screen, sampling the pixels, etc) is manually resolving the render buffer with glBlitFramebuffer. This results in another redudant texture copy operation. This CL also removes no-longer used function FrameBufferMtl::getReadableViewForRenderTarget() Bug: angleproject:8301 Change-Id: I63053b9e1d1a5cf47a023291b8fcb31d3636d3ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4840154 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop 43130a0a 2023-09-19T14:35:46 Android: Clean up from previous bad rolls See the bug for details, but we think the presence of previous temp directories may be preventing roller CLs. Test: Locally ran roll_aosp.sh Bug: angleproject:8352 Change-Id: I7851185b8c77d1b91c7289e3a13c5c0b4175745c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4877189 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Amirali Abdolrashidi ae9c7857 2023-09-19T13:40:52 Suppress BufferDataInLoopManyTimes for Linux/Intel * Skipped BufferDataInLoopManyTimes for Linux/Intel due to the long execution time, suspected to be causing errors on the bots. Bug: angleproject:8351 Change-Id: Ib7b640800edf5b30e251b47cfabfd34cc1ecea28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4877693 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuxin Hu 53e3ce59 2023-09-08T17:41:56 Add device lost handle after finishImpl It is possible that the during context destroy, when calling finishImpl, the vulkan device is lost, e.g. https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/6447#issuecomment-1711479164. We should check vulkan device lost after finishImpl(). Bug: b/289544394 Change-Id: I75aa650cdd38d81815f7354770639e896e3376a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4854763 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Igor Nazarov ecf11eca 2023-09-19T15:18:04 Add ContextMutex unit tests Test: angle_unittests --gtest_filter=ContextMutex* Bug: angleproject:8226 Change-Id: I55b69ce8bb89d572a2bf5d28f428635505771fa1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4874388 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Igor Nazarov 4b724130 2023-06-27T18:08:27 Rename SharedContexMutex into ContexMutex Follow up after: Replace (Single/Shared)ContextMutex classed with ContextMutex Renamed build option: angle_enable_shared_context_mutex -> angle_enable_context_mutex Renamed because there is no more SharedContexMutex class and ContextMutex is now used for both Shared and not Shared Contexts. Bug: angleproject:8226 Change-Id: I68eea84aa59441d9c5b19870910b2bb499311e08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4650350 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Igor Nazarov ca4dc52e 2023-06-22T15:20:12 Replace (Single/Shared)ContextMutex classed with ContextMutex This CL removes `SingleContextMutex` class and not 100% safe `Context::lockAndActivateSharedContextMutex()` method. `SharedContextMutex<>` was replaced with `ContextMutex` with static mutex type which is defined in "SharedContextMutex.h": - ContextMutexType = std::mutex Above refactoring also allows storing `State::mContext` by value, instead by pointer. Actual mutex is referenced by `ContextMutex::mRoot` member. This removes extra pointer indirection and slightly improves performance. If newly created Context uses shared textures/samplers, then it uses `Display::mManagersMutex` root as its root. Performance in Single/Shared cases now will be the same, and it should be slightly faster then old Shared case (because of the reduced complexity). Bug: angleproject:8226 Change-Id: I7ca4d9ea008c665cbea98ace1c6e7bbc544f54b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4632729 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi eb0d5997 2023-09-15T16:41:13 Move set/get uniform machinery to ProgramExecutable This is done because some uniforms are internally added by the compiler (draw ID, base vertex, and base instance) and are automatically set **on the installed executable**. This change fixes scenarios where a draw is done after a program has failed a relink, and therefore is unable to correctly set the uniforms (as it does not have access to the executable that is installed). It also fixes draws that use those uniforms in a PPO. Bug: angleproject:8297 Change-Id: Id74b4984b88aa09b5b81be1c91412d6c91711136 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4864693 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7cb117e0 2023-09-19T10:01:56 Roll vulkan-deps from dc9947ad4d2b to 640b7331b244 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/dc9947ad4d2b..640b7331b244 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/efc33d1ee5..4c57db1595 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/10f76f75da..21ded6ed67 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/867004beac..8c7da10180 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iae666e69b893afe75f19bc904e1c1b40bbaecc35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4874893 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0