Log

Author Commit Date CI Message
Jamie Madill 54176f07 2022-12-08T15:58:05 Better support for "vulkan-null" backend in trace tests. This allows running the "null" Mock ICD with the Vulkan secondaries version, and allow you to specify "vulkan-null" as an ANGLE back-end generally. Bug: angleproject:7852 Change-Id: Id8c59a167345a6079bd71916ae6ef9c41a6039a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4089449 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
angle-autoroll 9e086ee1 2022-12-09T10:01:06 Roll vulkan-deps from 4affe58949d3 to 89b9b4762b94 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4affe58949d3..89b9b4762b94 Changed dependencies: * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ce45337c51..f846ef57a0 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9788bc1859..934d2bddab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I0f34edc09e839dc73f7850c79d7e0eca92822fbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4092026 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny f7cf3226 2022-12-08T10:08:56 Capture/Replay: Only create active secondary contexts in MEC This finalized the fix attempted in b432c84c2b8cb6d20873e2b33b6684bee76db90d Capture/Replay: Fix collecting the initialized contexts Bug: angleproject:7858 Change-Id: Ie2bbcdb3f23fe4970ce3a9bb46df6f60fe6c8ab6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4084926 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll caccbdc1 2022-12-09T07:00:50 Roll Chromium from eb46dc0d0fce to 3b96c02c7465 (547 revisions) https://chromium.googlesource.com/chromium/src.git/+log/eb46dc0d0fce..3b96c02c7465 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0e5c336082..2c6fbff58d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c9e298613f..770e331176 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e1923458e4..cf97dd948b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..562809c7e4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d259b31644..8e77bba1ae * third_party/r8: 5Ckp25uPxCBEH3n_3JC6k2Jf1STCD2VMtCxHeUDjz6oC..rTXVKiqoOxR4GVJBXkVmN4qH8FbxwXX7Nu1H3X414-MC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/72ab3202b5..6b1d726a99 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0103aeaf9b..b8921723e9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9ed590cee3..49461e5506 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Iebaaa973b89e28e1e064f950c211d5e9a6420a3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4091422 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexis Hétu c9e7fd9c 2022-12-08T22:20:32 Revert "Skip AssignAssignmentToSwizzled on SwS Linux/Win" This reverts commit 0f7471ff610f3de0a9ef7f28b4bfc4bbbf693dc1. Reason for revert: Attempting a Revert to see if the tests are now fixed. Original change's description: > Skip AssignAssignmentToSwizzled on SwS Linux/Win > > Bug: angleproject:7863 > Change-Id: I9921e2e08834f793071ea07b211941bc8887b313 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4082150 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bug: angleproject:7863 Change-Id: I341da5b2c51fe7f22fc1958680cb7a955ee10c7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4090823 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
angle-autoroll 1e9a6726 2022-12-08T18:39:02 Roll vulkan-deps from 5e89361766f7 to 4affe58949d3 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5e89361766f7..4affe58949d3 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/82d4232f0f..b43758588b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1e422524e7..9788bc1859 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com,syoussefi@google.com Change-Id: I2c49fd87433dec41d26c550ea91f74b600a6b37e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087619 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 1193b664 2022-10-11T01:00:40 Vulkan: Use VK_EXT_pipeline_protected_access This extension allows pipelines to be restricted to protected or unprotected command buffers only. Bug: angleproject:7714 Change-Id: Id07be4c2ffd7ca19b8b4a2a869828bc11e89e467 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3943535 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 7e378da9 2022-12-01T16:36:08 Vulkan: Remove synchronous commands from CommandProcessor Some command tokens in CommandProcessor are doing synchronous calls. For example, finishResourceUse() and waitIdle(). They are inserting a token and then wait for CommandProcessor to drain. This CL removes these commands from CommandProcessor and it just ask CommandProcessor to drain and then call into mCommandQueue to finishResourceUse or waitIdle. This is a minor clean up for now, but in future CL we will also avoid waitForWorkComplete if the mUse has already been drained from CommandProcessor. Bug: b/261098465 Change-Id: I7672a9c0b1e477ea3537652cd83350aa97f7caa7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4072223 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao fa45eae4 2022-12-07T10:39:31 Vulkan: Remove QueryVk::hasUnsubmittedUse() QueryVk has a list stashed query helpers and current queryHelper. The mStashedQueryHelpers are always older than mQueryHelper. When we want to check if all queryHelpers has been submitted or not, we really only need to check the last one, which is mQueryHelper. There is no need to check mStashedQueryhelper. This CL turns that check against mStashedQueryhelper into an assertion inside finishRunningCommands. Bug: b/261737134 Change-Id: I2369e6690c46bcd338d4bfcb679a77478d3fdb84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087321 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll 6784fe5d 2022-12-08T16:21:04 Roll vulkan-deps from 7935ee7ccbc0 to 5e89361766f7 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/7935ee7ccbc0..5e89361766f7 Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/b75e5a02b6..bf3b3fb14e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com,syoussefi@google.com Change-Id: I6f7ad7f52c12df8cd1b236133262a1a1e01afb3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087617 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 28290e34 2022-12-08T16:11:55 Skip Texture2DTestES3.NonZeroBaseEmulatedClear/ES3_Vulkan on Win Intel Bug: angleproject:7866 Change-Id: I747d30d9774e237f9733eed0e0007d0c10b553cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4088983 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuly Novikov 81a3c71e 2022-12-01T18:51:39 Enable tests on Win Intel Optiplex 7080 experimental bot Suppress failing end2end tests and run single process Suppress VUID-VkDescriptorImageInfo-imageView-06711 Bug: chromium:1349828, angleproject:7874 Bug: angleproject:7865, angleproject:7866, angleproject:7872 Change-Id: I18c9099af6635cf41f5368960dc1d35d9decc48c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4071925 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll a5fd8ab6 2022-12-08T10:01:35 Roll SwiftShader from 0c98167cb31e to 6ebc3347af9d (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/0c98167cb31e..6ebc3347af9d 2022-12-08 swiftshader.regress@gmail.com Regres: Update test lists @ 6f73609d 2022-12-07 sugoi@google.com Add missing include <string> 2022-12-07 sugoi@google.com Add early exits for OOB index buffer offset or first index 2022-12-07 sugoi@google.com Fix VK_EXT_graphics_pipeline_library related crash 2022-12-07 sugoi@google.com Fix Regres false crash reports 2022-12-07 swiftshader.regress@gmail.com Regres: Update test lists @ 0c98167c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I0e56f3f521f279b6bde5ac8c2bcfed0012d384be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086877 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fee1f5c3 2022-12-08T07:02:26 Roll Chromium from b1141d77c69a to eb46dc0d0fce (599 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b1141d77c69a..eb46dc0d0fce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e3833ca15b..0e5c336082 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/71c674dc56..4fb9b31a5c * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a9779c11d2..e4e39cee1f * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f46bba92c0..25a3d07096 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/fd5b3b5068..09a1f53060 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..562809c7e4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/107142ac38..d259b31644 * third_party/fuchsia-sdk/sdk: version:10.20221201.3.1..version:10.20221207.3.1 * third_party/r8: smgiQDhBHEfz8KVdqBXas7z0ALaukjW3Yh-JVGPsFksC..5Ckp25uPxCBEH3n_3JC6k2Jf1STCD2VMtCxHeUDjz6oC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Iaf899f1cb3f5de88a618d7400a6b2ebb2cc51702 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4088301 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 52b07369 2022-12-08T03:37:56 Roll Chromium from 81e6bda0f261 to b1141d77c69a (1 revision) https://chromium.googlesource.com/chromium/src.git/+log/81e6bda0f261..b1141d77c69a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..932b0825c3 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d866d41e16..18d27fa10b No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ib4ade92aefa677e34e520f81127e3d45464b3a9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087871 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 15ae19c0 2022-12-08T02:50:18 Roll Chromium from 716fac091414 to 81e6bda0f261 (2 revisions) https://chromium.googlesource.com/chromium/src.git/+log/716fac091414..81e6bda0f261 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/21ed928654..c9e298613f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..932b0825c3 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I3fa4b4b3b6699cabd0b7b3bf955a34ad7ffff56f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087869 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll ffe584f1 2022-12-08T00:31:54 Roll Chromium from 1c2e19edc873 to 716fac091414 (3 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1c2e19edc873..716fac091414 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..932b0825c3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5a18712799..9ed590cee3 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I25217eab799bec6dcec7cd5fbee9c65eae9262e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086979 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 40b4fcc0 2022-12-07T23:18:11 Roll vulkan-deps from a497ee9d6755 to 7935ee7ccbc0 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a497ee9d6755..7935ee7ccbc0 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a7603c132d..ed257e2bdf * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/40f5bf59c6..9c6a925c87 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/891c40de1a..b75e5a02b6 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1f2848428c..1e422524e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: If8bf400e994587a5cd0f2a01b50e426664258d9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086969 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f63e5ab3 2022-12-07T23:45:40 Roll Chromium from 9edf8e710ec9 to 1c2e19edc873 (5 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9edf8e710ec9..1c2e19edc873 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..932b0825c3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ef102c057a..0103aeaf9b No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: If85745d89e8547a330cd2b2732a7db449b5ce503 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086975 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll dbbed929 2022-12-07T22:47:13 Roll Chromium from 998dcf5599d0 to 9edf8e710ec9 (8 revisions) https://chromium.googlesource.com/chromium/src.git/+log/998dcf5599d0..9edf8e710ec9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..932b0825c3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/22e920cc38..ef102c057a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/993564df50..5a18712799 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I557cc0f6c65677005e55b5ee39616ba3a524ee7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086968 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton f551faf7 2022-12-01T17:14:14 Use typed UAV loads for pixel local storage, when supported D3D11.3 supports typed UAV/ROV loads on some hardware. Check for this feature and use it when available. I haven't been able to measure a meaningful performance difference from this change, presumably because the bottleneck is memory bandwidth, but it's simple and more consistent with the other backends. Bug: angleproject:7855 Change-Id: I1713fc12842380ef1a685a6878948bc0293074c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4072222 Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll 45a62515 2022-12-07T22:04:57 Roll Chromium from ee01bc900c32 to 998dcf5599d0 (21 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ee01bc900c32..998dcf5599d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7aa5d7d4ea..e3833ca15b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fbed698ae2..21ed928654 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/a7365fc087..0ba8b5fcef * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8fd5368fb8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/32b2e85c08..993564df50 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I2095cde6ed4535cd551bf3350c3772558064d105 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086966 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 302fccd1 2022-12-07T20:54:19 Roll Chromium from ee01bc900c32 to 17b77809b4ca (1 revision) https://chromium.googlesource.com/chromium/src.git/+log/ee01bc900c32..17b77809b4ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/efbf0a9100..fbed698ae2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8fd5368fb8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9f615fd096..72ab3202b5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c58592b8d7..32b2e85c08 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I016442bb4af962a409d0d7dbe9397c0785c76ee7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086933 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao ca263d4a 2022-11-23T12:11:49 Vulkan: Remove UsedInRunningCommands The only difference of UsedInRunningCommands() and hasUnfinishedUse() is the latter excludes the case where it has not submitted yet. But all usages are already checked if it has been submitted or not. This CL removes UsedInRunningCommands and uses hasUnfinishedUse instead. Bug: b/255414841 Change-Id: I94ef0b63a0c888219cffcdfcecfa0a095fee616b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4053262 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll a3808d58 2022-12-07T18:54:35 Roll Chromium from 6a123e5dfc29 to ee01bc900c32 (481 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6a123e5dfc29..ee01bc900c32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d286aa4250..7aa5d7d4ea * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d1379d3f07..71c674dc56 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/8e00079800..a9779c11d2 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/2b51e6f1ec..fd5b3b5068 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/af35c6055b..efbf0a9100 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9181906668..cf8a24d091 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e8b385d860..e1923458e4 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/c5a3f52f05..a7365fc087 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8fd5368fb8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/25334bb18e..107142ac38 * third_party/r8: 0SzbA94FRVtzsELRN30my7jJQTeHVH65wHSU1JF2bQMC..smgiQDhBHEfz8KVdqBXas7z0ALaukjW3Yh-JVGPsFksC * tools/luci-go: git_revision:4814885a05fd7cc925933f614dc6fcc58bc83e4b..git_revision:bac571b5399502fa16ac48a1d3820e1117505085 * tools/luci-go: git_revision:4814885a05fd7cc925933f614dc6fcc58bc83e4b..git_revision:bac571b5399502fa16ac48a1d3820e1117505085 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d9c9c23e02..22e920cc38 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a5b1342192..c58592b8d7 * tools/skia_goldctl/linux: VJBQvPCDWNHadBXHtx4iViP5ju0oF2ZlEK5Zle80ZVUC..GYJyu-6ZtuFKlycWv9v7SFg61ONNNobNlfP0HTV6IGQC * tools/skia_goldctl/mac_amd64: 1EpS2K-VevNOMzNiw1LmYktlqKVv1SyqDm2q4DRQtNkC..SVMraIHmdNooMzoPH_0l0pHjwN9wgULMxNntBbrNQyMC * tools/skia_goldctl/mac_arm64: SXjqn6JoFOUmIaVPnyQWa19dyUeEb00rdwMuL9feyvoC..CklLGpnehytIF37cw7TK3rU3GqE_NzN76x9OERwfrNMC * tools/skia_goldctl/win: GXa5gfPznAu49j4sXrqFvYWFSD0LTIB_TVal2oqGlAIC..jmDxbBm43jkyCFWbnBLpWu8GADl05R5x2kV-ttxKaUgC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I8dbaf77519f111e7ca9763e99f5914d3fa8af1fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4087002 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 64cb7bc0 2022-12-07T11:37:38 infra: Remove toolchain from CI dashboard. With the exception of MSVC and WinUWP, all of our toolchains were "clang". This change makes it so that MSVC/UWP is combined with the OS name to make the dashboard easier to read. Bug: angleproject:7871 Change-Id: I9d86b67504ff6e12b63ddb1f520b4ea6e3f56146 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086742 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 82eba6cd 2022-12-07T11:21:41 infra: Remove UBSAN-specific configs. Because the UBSAN flag is turned on in the ASAN builder, we don't need a separate UBSAN builder. Bug: angleproject:7871 Change-Id: I4f6c8d56bdd209efea381677b2972616b6a6df14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086741 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 2364578f 2022-12-07T10:33:05 infra: Enable UBSAN together with ASAN and LSAN. These flags are compatible. This should save on testing resources. Bug: angleproject:7871 Change-Id: I860e3724f54bdbf06e7530bd6bfe72ec0f53cc54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086283 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 583fc6a7 2022-12-07T16:21:36 Skip FramebufferExtensionsTest.ColorBufferHalfFloat on iOS Bug: angleproject:7853 Change-Id: I25f2a37a64ac2445b4eb5eb567acf32834f5e55f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4085142 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 9dc82cb3 2022-12-07T10:01:47 Roll SwiftShader from 2783f6bf0a03 to 0c98167cb31e (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/2783f6bf0a03..0c98167cb31e 2022-12-06 sugoi@google.com Merge changes I1950088a,Iecb2d8a2,I250a1541,I4dc2e503 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I85f264a26fc8007258d0f89755b9ba4c05cb5ba5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4084529 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi dad69cc7 2022-12-06T12:00:39 Suppress rgb_to_hsl_vertex test on Pixel 6 Bug: angleproject:7867 Change-Id: I2678c0db19fafb780245f818f365e88c7736c5ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4083524 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 3bd0cce8 2022-12-06T09:56:58 Roll Chromium from bdfdd7d2b008 to 6a123e5dfc29 (584 revisions) https://chromium.googlesource.com/chromium/src.git/+log/bdfdd7d2b008..6a123e5dfc29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/988bc9fa63..d286aa4250 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/1547c3fe52..d1379d3f07 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/f92e1b7e40..8e00079800 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/44d54baf42..f46bba92c0 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/fd49ee4ee9..2b51e6f1ec * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2a9f393809..af35c6055b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d8be2db858 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ec1882fbc2..25334bb18e * third_party/turbine: 4Cvss-AYlYPcW_PIdcX45Ew7ZQwsaeurs7mUjS3LFyQC..R-Qp1tMBqIuETMfXNqQU9GB00ij6dsPjVmjDuvH_194C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dabb142daf..9f615fd096 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/828f44d2de..d9c9c23e02 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cb53190619..a5b1342192 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I645582357f53670d974323ff9b3c2d04e3dc5852 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4083106 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Gert Wollny 384ce5cf 2022-11-29T14:18:34 Capture/Replay: Corretly reset the UnpackAlignment at end of MEC Direcly setting the value doesn't set the relevant dirty state, use the appropriate setter call instead. This fixes the reported difference between the UnpackAlignment value stored in the trace and the one recorded ruring validation for MEC. Bug: angleproject:7564 Bug: angleproject:7180 Change-Id: Ic931cac9b7e33519e992ae55ee5cab2adb2958ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4063892 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 701ef3f2 2022-12-06T10:01:53 Roll SwiftShader from e6a3153888f0 to 2783f6bf0a03 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/e6a3153888f0..2783f6bf0a03 2022-12-06 sugoi@google.com Change Chromium's SwiftShader owners 2022-12-06 swiftshader.regress@gmail.com Regres: Update test lists @ e6a31538 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I1e6340f37ef870026e8fb49e575ad9bccc0ce024 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4082295 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll aba757d4 2022-12-06T10:01:08 Roll vulkan-deps from ca8ca2aba961 to a497ee9d6755 (62 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ca8ca2aba961..a497ee9d6755 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/88fd417b0b..a7603c132d * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/c214f6f2d1..1d31a10040 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/46ca66e699..40f5bf59c6 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/b092b2fccc..891c40de1a * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3a092fe869..82d4232f0f * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ec541c410e..ce45337c51 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7a9d51a51c..1f2848428c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2feeac1a9e1fed54d9f57d4f29e926b48efa33e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4083107 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a9464755 2022-12-06T01:50:52 Roll SwiftShader from 6a259c87ef52 to e6a3153888f0 (24 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/6a259c87ef52..e6a3153888f0 2022-12-02 capn@google.com Use helper function for SPIR-V explicit layout storage classes 2022-12-02 sugoi@google.com Add memory allocation checks 2022-11-29 lokokung@google.com Adds some extra comment/documentation for DebugMessenger in VkInstance. 2022-11-28 lokokung@google.com Fixes leaking DebugUtilsMessenger in Instance. 2022-11-28 sugoi@google.com Unify BGRA masks 2022-11-25 sugoi@google.com Add 5/6-bit unorm support to the floating point version of writeColor 2022-11-25 sugoi@google.com Add 4-bit unorm support to the floating point version of writeColor 2022-11-25 sugoi@google.com Add 10-bit unorm support to the floating point version of writeColor 2022-11-25 sugoi@google.com Add sRGB support to the floating point version of writeColor 2022-11-25 sugoi@google.com Add 8-bit unorm support to the floating point version of writeColor 2022-11-25 sugoi@google.com Color write mask refactor 2022-11-24 sugoi@google.com Add utility function to transpose BGRA data 2022-11-24 sugoi@google.com Fix linear to sRGB conversion functions 2022-11-24 swiftshader.regress@gmail.com Regres: Update test lists @ bb5d3bdb 2022-11-24 sugoi@google.com Update SPIR-V Tools to 597631b69 2022-11-24 capn@google.com Output storage class stores have effect in helper invocations 2022-11-24 swiftshader.regress@gmail.com Regres: Update test lists @ 95c2e209 2022-11-24 capn@google.com Fix SPIRV-Tools Android.bp build, part two 2022-11-23 capn@google.com Fix SPIRV-Tools Android.bp build 2022-11-23 capn@google.com infra: Also automatically run win-swangle-try-tot-swiftshader-x64 2022-11-23 swiftshader.regress@gmail.com Regres: Update test lists @ d34588e0 2022-11-21 swiftshader.regress@gmail.com Regres: Update test lists @ d89bb011 2022-11-18 capn@google.com Update SPIR-V Tools to 1a7f71afb 2022-11-18 capn@google.com Update SPIR-V Headers to c214f6f2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I7e9dbb80b332e11c9ea65f0ccf170e00e4440bba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4081062 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 982755e0 2022-12-05T15:32:42 Suppress VUID-vkCmdDraw-None-06887 * Suppressed the following VVLs: * VUID-vkCmdDraw-None-06887 * VUID-vkCmdDrawIndexed-None-06887 Bug: angleproject:7861 Change-Id: I15cdf934bd87b5d5219e69eebc9d339d4c180660 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4082149 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 0f7471ff 2022-12-05T16:28:41 Skip AssignAssignmentToSwizzled on SwS Linux/Win Bug: angleproject:7863 Change-Id: I9921e2e08834f793071ea07b211941bc8887b313 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4082150 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 3b57c2a8 2022-12-05T15:33:43 Add cmnt for VUID-vkDestroySemaphore suppression Bug: angleproject:7729 Change-Id: I46d8afe9702b9263a776e9acfa9a3364b7184579 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4080592 Reviewed-by: Ian Elliott <ianelliott@google.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Charlie Lao 2d87551d 2022-12-05T10:47:40 Vulkan: Make mLargestAllocatedIndex atomic TSAN is complaining mLargestAllocatedIndex not thread safe. This CL makes it atomic and make it mean " the largest queue index we have ever allocated/seen" so that it will be thread safe. It is impossible to use a queueIndex before it been allocated. But it is still possible that some mUse still referencing a queueIndex after it is been released. The only downside is that we may get into slightly less optimal code path for GetBatchCountUpToSerials if we ever get into more than 64 queueIndex and then get bellow 64 again, but that should not a real concern. Bug: angleproject:7860 Change-Id: I4c99bae24e9d72298253e43f8d108444a8f46ebc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4080590 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi bd79968a 2022-12-02T14:17:14 Vulkan: Make sure program's pipeline cache is created The condition to create or use the program's pipeline cache has become quite complicated. This change simplifies things by making sure the pipeline cache is created if and when it's used, instead of guessing how it will be used and pre-create it. Bug: angleproject:7369 Change-Id: I7f3558e55f391da8c701e359d2f88d248c820de4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4076508 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 8181c056 2022-11-22T15:34:48 Vulkan: Remove RenderPassSerial RenderPassSerial was introduced to uniquely identify a RenderPassCommands. With the work of per current context queue serial, now every started RenderPassCommands already have a unique QueueSerial. This CL removes RenderPassSerial and use renderPass's queueSerial instead. Bug: b/255414841 Change-Id: Id0a87319a9132cdb74aba195f1f05aa31454592b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4049966 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev 87815de2 2022-12-01T00:00:00 Adjust GetFramebufferAttachmentParameterivBase validation GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE_EXT state queries should be allowed for ES 2.0 clients when floating-point color buffer extensions are enabled. Bug: angleproject:7853 Change-Id: I4a0a3b336e44648635233be54f598a3ab20cf717 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4071926 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 3fedd435 2022-12-05T10:15:22 Overlay: Switch font to RobotoMono Which has an Apache 2.0 license Bug: b/260423572 Change-Id: Ibc4b664ddfe844be08ccbac57c27e81951940490 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4079268 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll d9c9eede 2022-12-05T15:11:21 Roll VK-GL-CTS from 9d22258ed442 to d90c76e77622 (14 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9d22258ed442..d90c76e77622 2022-12-02 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main 2022-12-02 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main 2022-12-02 rgarcia@igalia.com Remove custom instances from robustness index access tests 2022-12-01 lionel.g.landwerlin@intel.com Fix uninitialized blendConstants in ColorBlendState 2022-12-01 ziga@lunarg.com Add missing extension checks in extended dynamic state tests 2022-12-01 piotr.byszewski@mobica.com Ensure robustness for OOB index buffer accesses 2022-12-01 ziga@lunarg.com Test creating device with promoted feature structures 2022-12-01 rgarcia@igalia.com Avoid passing unsupported structs in mandatory features test 2022-12-01 cturner@igalia.com Adds coverage for gl_PrimitiveID implicit passthrough with GPL. 2022-12-01 rgarcia@igalia.com Avoid using custom instances in robustness tests 2022-12-01 mcanal@igalia.com Allow override of wayland-scanner executable 2022-12-01 rgarcia@igalia.com Add VK_NULL_HANDLE definition to vkDefs.hpp 2022-12-01 zzoon@igalia.com Add tests for buffer device address with buffers bound at offset 2022-12-01 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ic01d46349b71964bd250515d6246a36cc75fee89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4080546 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3269998c 2022-12-05T07:00:43 Roll Chromium from 5d807d6fc7dd to bdfdd7d2b008 (315 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5d807d6fc7dd..bdfdd7d2b008 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d5942868d8..988bc9fa63 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fdc7c13983..1547c3fe52 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2dda3c5c1b..f92e1b7e40 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/952f26fb11..2a9f393809 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..41eec55d82 * third_party/r8: FNMbaJ4o3bVeGVnIwu9D0VSqXEZIi5v2LV9ycHFpqrkC..0SzbA94FRVtzsELRN30my7jJQTeHVH65wHSU1JF2bQMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/65848dccd6..dabb142daf * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ea9a7de758..828f44d2de * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b1111b1e0a..cb53190619 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I38bc3e5b58a3b3b27bde2c2191d7a10fcb20fd1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4078757 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b36e337e 2022-12-02T22:18:18 Roll Chromium from 366b354bb4e3 to 5d807d6fc7dd (318 revisions) https://chromium.googlesource.com/chromium/src.git/+log/366b354bb4e3..5d807d6fc7dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/961774e175..d5942868d8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c1f7bc4f73..952f26fb11 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..550c7afb52 * third_party/r8: NhcNRQ45-HIXvuu5CxFmUsIbvW9Or8_tkceuhByYJywC..FNMbaJ4o3bVeGVnIwu9D0VSqXEZIi5v2LV9ycHFpqrkC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b187174108..b1111b1e0a No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: If29982352c520f9c8076ad51183bcedb6440f935 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4077107 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 2031e215 2022-12-02T15:30:54 Fixes for Vulkan secondaries build. Includes the defined name of the alternate library in every build, so that platforms without Vulkan still have access to the library name define. Also fixes checks for the ANGLE driver in the tests to work with the new secondaries enum. This will let developers run trace tests with the vulkan secondaries library. Bug: angleproject:6811 Change-Id: If3846d68e532238f0b1c1c506638867a23fb4357 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4076513 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 650f2274 2022-12-02T15:51:09 Vulkan: Remove fixed VVL errors Bug: angleproject:7338 Change-Id: I4d2b05c5fd5ad505fda2089dbfa2119e8db8ac16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4076515 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 0790a807 2022-12-01T23:58:36 Capture/Replay: Add ResourcesToDelete For resources that are deleted but not recreated by the app, we need to skip the delete call we've been making for ResourcesToRegen. To support this, track which resources need to be deleted. We've gotten by without this for so long because most apps will immediately recreate a resource after deleting it. When they simply delete starting resources, we can't try to delete them again. Test: MEC of multiple apps Bug: angleproject:4599 Change-Id: I226ba7887e2b7b31d4ce9a75d6a8d0a24f3f32ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4075486 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Charlie Lao f17cb883 2022-11-30T17:23:12 Vulkan: Add two tests for per context queue serial work SubmittingOutsideCommandBufferTriggersEndRenderPass: This test is added to test outside command buffer uploads that triggers endRenderPass works properly. CreateMultiSharedContextAndDraw: This test is added to test draw with shared vertex buffer in the shared context group works properly. Bug: b/255414841 Change-Id: I8b4f343fe220a9f0b7c6e042f4663e23ae6f4c9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4064148 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi 58d7ace2 2022-11-22T16:08:07 Vulkan: Add memory allocation log support in debug * Added a memory tracker to the renderer object to keep track of the memory allocations and deallocations in more detail. * This feature is used for debugging only. * To enable it, set angle_enable_memory_alloc_logging=true in GN args (added in renderer/vulkan/BUILD). * It is related to ANGLE_ENABLE_MEMORY_ALLOC_LOGGING in the code. * The tracker are updated in the memory allocation tracking functions if the feature is enabled. (The counter is always updated, even if the feature is disabled.) * At the end of a RendererVk object, it checks for and logs any remaining allocated memory from MemoryAllocationType members. * The data is stored in the map object "mMemoryAllocationTracker". The key used for it is currently of type angle::BacktraceInfo. * If angle_enable_unwind_backtrace_support is disabled, or not on Android, the key is an empty object. * MemoryAllocInfoMapKey is used as a key to access the allocation information. Bug: b/242641395 Change-Id: If701a4bdea2f8738a830ee47e0c7c5cdacf95b87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4050103 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 66a7117a 2022-11-30T10:34:30 GLES1: Use less precision for color and tex coords Per the GLES1 spec, color and tex coords are satisified by half-precision floats. Bug: angleproject:6644 Change-Id: Ia3f8e45d4c35557a25373f9ad572e87708bc2001 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4067803 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Charlie Lao 2e5ca217 2022-11-18T10:44:49 Vulkan: Let each current context has its own QueueSerial. This CL makes every current context has its own queueSerial. At context creation time or when context becomes current, it allocates a QueueIndex from renderer. When it becomes non-current, it releases QueueIndex for others to reuse. This way we significantly reduces the max number of QueueIndexs for reasonable usage. Each CommandBuffer has its own unique QueueSerial and we use that to determine if a resource is being used by the given CommandBuffer. The QueueSerial for RenderPassCommands is deferred until renderPass starts, and when we generate queueSerial for renderPassCommands, we also reserve a range of serials for outsideRenderPassCommands so that we can do incremental submission of outsideRenderPassCommands without need to close renderPassCommands. In rare situation, if that reserved serials runs out, we also close renderPassCommands to ensure the ordering of serials matches ordering of command buffers. With per current context queue serial, this CL is able to set resource queue serial as it is being used. This CL completely removes usage of ResourceUseList class since it was introduced due to deferred setSerial. This CL also get rid of refCount from ResourceUse since there we no longer add it to a ResourceUseList. With that, we also able to remove SharedResourceUse class since access to ResourceUse itself is now thread safe since we are able to make a copy of it when we add it to GarbageList. Because RenderPassCommands now has its own unique QueueSerial as it encodes command, we can use it to detect if a resource is being used by it or not, thus this CL also removes usage of CommandBufferID. Bug: b/255414841 Change-Id: I36dcbeaa7bc996f04e6c04bf9ad44cd0d630f61a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038096 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi db557905 2022-12-02T11:32:10 Vulkan: Fix -Wbitfield-enum-conversion Bug: chromium:701384 Change-Id: I8c729934365c035a682e81467679fb7149864aac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4076505 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop bdb127da 2022-12-02T10:53:22 Android: Remove smhasher license Removed in: https://chromium-review.googlesource.com/c/angle/angle/+/4066987 Causes the ANGLE to Android roller to fail: https://android-review.git.corp.google.com/c/platform/external/angle/+/2323099 Error: external/angle/Android.bp:6474:1: module "external_angle_license": module source path "external/angle/src/common/third_party/smhasher/LICENSE" does not exist Bug: b/260426695 Change-Id: I974d79f155b1077d8d42555245fed1eed69056f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4073983 Commit-Queue: Solti Ho <solti@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Solti Ho <solti@google.com>
Ian Elliott ec4629d6 2022-12-02T10:53:38 Android: set android:allowBackup="false" in manifset This wasn't previously being set, and a partner pointed out that it causes a security scan issue as explained in https://stackoverflow.com/questions/12648373/what-is-androidallowbackup). Bug: b/242671681 Change-Id: I17a0d9eec4ee7904ebb07bf934c7e2cdd8d61921 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4073982 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Jamie Madill aaee3c23 2022-11-30T14:24:13 Build and test ANGLE with Vulkan secondary CBs. This will allow us to run tests with both permutations of ANGLE (custom secondaries & Vulkan secondaries) in the same build directory. It will also allow us to run these configs as tests on our infra. This CL adds a few simple test to CI. Bug: angleproject:6811 Change-Id: I053f8cc5bafc2a7ab7d0665da9301f0ba7f8417f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4067806 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny b432c84c 2022-12-01T10:40:03 Capture/Replay: Fix collecting the initialized contexts The main context initialization function will be emitted as "Shared" and not based on the context number, so only add the secondary contexts to the list of contexts that need additional setup. Fixes: b301b82235ca686d036a8d29380da22bb2060060 Capture/Replay: emit context setup for pre-MEC contexts only Bug: angleproject:7805 Change-Id: I4ac770a303ac93a448c9b46bf8c4cd58900ddd54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4068124 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 1005639f 2022-12-02T07:01:02 Roll Chromium from 076a539c2991 to 366b354bb4e3 (53 revisions) https://chromium.googlesource.com/chromium/src.git/+log/076a539c2991..366b354bb4e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8d4ff27e86..fdc7c13983 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/ae1fbc4037..2dda3c5c1b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a870c3d506..c1f7bc4f73 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..550c7afb52 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0922aaade1..ec1882fbc2 * third_party/fuchsia-sdk/sdk: version:10.20221201.2.1..version:10.20221201.3.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/83f8830a1d..65848dccd6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bf34997e15..b187174108 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ibdcbe584a94101f4c01b4ec90816a4f9dacf9408 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4075485 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Solti Ho 7e1ed5f1 2022-12-02T02:32:40 Revert "Vulkan: Enable async pipeline cache sync by default" This reverts commit c7414946b84410bfcc8705759a902577c13d9fc4. Reason for revert: b/260752276 Original change's description: > Vulkan: Enable async pipeline cache sync by default > > Bug: b/246683126 > Change-Id: I593650364250f8802e9f546ab9957cf1c30e596a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4031487 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/246683126 Bug: b/260752276 Change-Id: I0ebac7e46e213790ac39e4124e89feda76551011 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4074765 Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 80f030c1 2022-12-02T02:35:39 Roll Chromium from 42032d061a0a to 076a539c2991 (1718 revisions) https://chromium.googlesource.com/chromium/src.git/+log/42032d061a0a..076a539c2991 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0efbd89bb5..961774e175 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f2fe6dda1e..8d4ff27e86 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c2e10323cc..ae1fbc4037 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9231726c61..44d54baf42 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/542427f5ea..a870c3d506 * third_party/android_build_tools/aapt2: -QrdsGmvVhHeoRc5wKCnU2LXEjk1s0ocheitXWf5dhYC..cbNG7g8Sinh-lsT8hWsU-RyXqLT_uh4jIb1fjCdhrzIC * third_party/android_build_tools/lint: PwX3e0EPv-j0ip-tcNNfhy3YcFHle4vxKVo-IbTCtZYC..9qiQ29AZRZapFWdlmgjd22gc1RxJ1oXZKPAsTq_3G88C * third_party/android_build_tools/manifest_merger: 1_tPfyswsXgfbNegip6nTy55E2ASlhsRqA2sKhUo01YC..X4l8RIBEAF108FpSEWRF7UHqq-kY8T3ibSsObGU5u3UC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..550c7afb52 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fc04ff1628..0922aaade1 * third_party/fuchsia-sdk/sdk: version:10.20221128.3.1..version:10.20221201.2.1 * third_party/r8: WqQE6kGnQ571Jtmn-m9LD7Qnd7nOi46mty5n-fZznKQC..NhcNRQ45-HIXvuu5CxFmUsIbvW9Or8_tkceuhByYJywC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a7fe07b40d..83f8830a1d * tools/luci-go: git_revision:f8f64a8c560d2bf68a3ad1137979d17cffb36d30..git_revision:4814885a05fd7cc925933f614dc6fcc58bc83e4b * tools/luci-go: git_revision:f8f64a8c560d2bf68a3ad1137979d17cffb36d30..git_revision:4814885a05fd7cc925933f614dc6fcc58bc83e4b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3750e10528..ea9a7de758 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/797585e74b..5d2efcc932 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0d9e5429c6..bf34997e15 Clang version changed llvmorg-16-init-10736-ged9638c4:llvmorg-16-init-12251-g87d0ff91 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/a7fe07b40dfb6171c4cae3a46c0e0ca2172519e1..83f8830a1d904629e02b8895acccdc98f4e6b3d5/scripts/update.py Bug: angleproject:6430 Tbr: cnorthrop@google.com Change-Id: Ibf75c4d5060d770b7954da32e7a416e7e1aa2abe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4074766 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya eafdf206 2022-12-01T12:33:11 Reset thread context during threadCleanup Once thread cleanup is complete reset its mContext member to nullptr. Running CTS tests in batches sometimes exposes a bug where Thread::mContext is accessed after Display::threadCleanup is complete. Bug: angleproject:6723 Bug: angleproject:6798 Change-Id: Ie252954e60b5d4565697095939fd19d002dfccf3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4072208 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 4eed6b9b 2022-12-01T16:42:54 ubsan: Ignore errors from SwiftShader More errors exposed by the bots when trying to land this roll: https://chromium-review.googlesource.com/c/angle/angle/+/4070947 Test: angle_deqp_gles31_tests --use-angle=swiftshader Bug: angleproject:7852 Change-Id: I38e669817382ee17c403fbfd54ab2282a3f78cf0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4072219 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Chris Dalton 9bd9c1c2 2022-11-03T11:49:33 Workaround for AMD [[raster_order_group()]] bug Metal [[raster_order_group()]] does not work for read_write textures on AMD when the render pass doesn't have a color attachment on slot 0. To work around this we attach one of the PLS textures to GL_COLOR_ATTACHMENT0, if there isn't one already. Bug: angleproject:7792 Bug: angleproject:7803 Bug: angleproject:7818 Change-Id: I7567ed28ed30c7e3ca23dc52778ed90f2fdff965 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4004529 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Egor Pasko c904cba3 2022-11-30T19:22:48 android: Remove uncompress_shared_libraries The Android build assumes uncompress_shared_libraries==true, so this change should have no effect on the build while also allowing to remove the variable from chromium-src. Bug: chromium:1337134 Change-Id: I4b0d15b41b0ee5199f11e7534f7681cc0746df82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4067322 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Nicolas Capens aa7bb157 2022-12-01T00:33:31 Include volk.h from a relative location Previously it was always included from third_party/volk/ This change makes it easier to use an externally provided copy of volk. Bug: b/260093525 Change-Id: I60bdb0ee4f6f6293fce5198af438e9af8d84421f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4066872 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Nicolas Capens 938f4372 2022-11-30T15:30:23 Move trace_event into anglebase This originates from Chromium's base/trace_event/ so it doesn't need to be under a third-party folder. Bug: b/260093525 Change-Id: Iab7a40569b6c1f91454f099c07bf51e3ce4b65df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4068342 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Nicolas Capens c991eb22 2022-12-01T14:05:07 Move the anglebase folder up a level This code originates from Chromium's base/ directory so it doesn't have to be under a third-party folder. Bug: b/260093525 Change-Id: I0bf6950095c685f36c5c237093980a64cf6e74f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4068339 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Yuly Novikov e4054a3f 2022-12-01T16:51:48 Add ANGLE experimental bots for Win Intel Targeting Optiplex 7080. Not running any tests for now. Bug: chromium:1349828 Change-Id: I6e3973c684cbcbefd283f314b2a48bf33f8ce6da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4071104 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop a58ea0ac 2022-12-01T09:32:44 ubsan: Ignore alignment errors We are using unaligned allocations in memory pools to service ANGLE's SecondaryCommandBuffer implementation. Until this is fixed, ignore the ubsan errors. We also are seeing errors from zlib, so including that in the ignore until it is fixed upstream. Test: angle_deqp_gles31_tests Bug: angleproject:7852 Change-Id: Iaa34f12b7da7fa55558ba9ab0eace8fccf081653 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4070985 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Nicolas Capens 0d7a4884 2022-11-30T14:33:12 Use string_view to compute custom string hash C++17 supports std::hash<string_view>, which can be used to compute a hash for the custom sh::TString class. This eliminates the dependency on smhasher. Bug: b/260426695 Change-Id: I2f4044fea4e44396a5d798436ec02da22a37bed7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4066987 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Nicolas Capens 022b52f5 2022-11-30T14:58:01 Include xxhash.h from a relative location Previously it was always included from src/common/third_party/xxhash/ This change makes it easier to use an externally provided copy of xxhash. Bug: b/260093525 Change-Id: I27c375c58ac3776a15d5d68483c235ece235b059 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4066278 Commit-Queue: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill 76ef4207 2022-12-01T10:17:56 Remove trace tests from win-intel. This test configuration is flaky due to non-deterministic rendering. It's also running a very old configuration. We can revisit turning this on when our test machines are updated. Bug: angleproject:7708 Change-Id: I486607f673e49123b3b77e02b335049eb5ab34ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4070224 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Chris Dalton 8ee1b89f 2022-11-04T13:10:37 Refactor pixel local storage options The various different PLS options were getting scattered and unruly. We are also in need of more backend-specific PLS options that would be difficult to add as-is. This CL refactors them into a single "ShPixelLocalStorageOptions" struct that gets initialized all in one place, and shared between the compiler and the backends. Bug: angleproject:7279 Change-Id: Ic58dccb8d1ba350a0b6cc5848ce15bd687e30fad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4006715 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Chris Dalton a4db9477 2022-10-06T10:35:39 Implement pixel local storage with metal::read_write textures Metal's programmable blending feature isn't available on non-Apple Silicon, so on these devices we have to polyfill pixel local storage using read_write textures, which can also be coherent if raster_order_groups are supported. This change leverages the existing PLS transformation to images, and implements just enough shader image functionality in Metal to support the pixel local storage usecase. Missing shader image features are marked with UNIMPLEMENTED(). Bug: angleproject:7279 Bug: angleproject:7792 Bug: angleproject:7794 Bug: angleproject:7797 Bug: angleproject:7803 Change-Id: Ia96a714693d352d57351a1bae4f45437dde000e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3993363 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Shahbaz Youssefi fa37af38 2022-07-12T22:47:22 Translator: Support SSO's built-in redeclaration EXT_separate_shader_objects requires that gl_Position and gl_PointSize be redeclared in the vertex shader. This is not adopted by GLES3.2, but is nevertheless required to be supported if the shader enables this extension explicitly. Bug: angleproject:6590 Change-Id: I3428851ff9f00fb63573e4322bb62fe04bf0a095 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3757918 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Chris Dalton db67df60 2022-10-31T13:01:25 Metal texture cleanups * Record the texture arguments' location in main() instead of inferring their position based on an assumption that the texture pipeline comes last. * Fix one spot that was using mMainSamplerIndex that should have been using mMainTextureIndex. Bug: angleproject:7279 Change-Id: I53af0f016e52217c53d98b560011ffe958746cda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3993362 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Shahbaz Youssefi 2ecb3217 2022-11-28T15:24:39 Vulkan: Turn CPU throttling into fail safe CPU throttling is moved back to after queue present instead of before. Doing it before was a mistake, as the app had already recorded the command buffers, there was no point in delaying its submission. Proper throttling would have been moving the wait from after recording commands (before present of frame i+2) to before recording (after present of frame i+1). However, throttling is the responsibility of the app and this change triggers throttling one frame later (after present of frame i+2) as a fail safe. Currently, CPU throttling is relied upon for acquire semaphore recycling. If the two are untangled, CPU throttling can be removed. CPU throttling can also be trivially weakened by increasing kSwapHistorySize (currently 2). Bug: angleproject:7268 Change-Id: Ib7a8be6f8e72c6b8589d4e8b5de7ceaf6a28bb8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4060454 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 31c40936 2022-11-25T12:28:27 Vulkan: Rework present semaphore recycling Present semaphores and old swapchains are now associated with a fence for clean up. The fence is the one coming from the _next_ acquire of the same image index. See doc/PresentSemaphores.md for more details. Bug: angleproject:7847 Change-Id: I16891ccf6df7ac39d8b17328aac35afc422eede0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4058286 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 90b4541c 2022-11-28T11:39:24 Vulkan: Pass signal semaphore by value to async thread Otherwise the signal semaphore is pointing to whatever was passed in from the main thread. Currently, this is ok because: - For external semaphores, ensureNoPendingWork is called - For surfaces, there's a fixed buffer of semaphores However, an upcoming change passes a semaphore specified on the stack, and the thread should not be referencing it. Bug: angleproject:7847 Change-Id: I9a823214bde59b9d7ff23313694c1749a76e6b8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4060453 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 7f4caaf5 2022-11-23T15:40:53 Vulkan: Fix VulkanPerformanceCounterTest.SubmittingOutsideCom VulkanPerformanceCounterTest.SubmittingOutsideCommandBufferDoesNotCollectRenderPassGarbage depends on the implementation detail on how we flush and submit commands. The recent change crrev.com/c/4038095 fixes one issue that we are now having one less submission on pixel 6 device. This CL adjust the test to account for that. This CL also changed to set mHasDeferredFlush to true only when there is a started renderpass upon FBO bind. This CL also opt in swiftshader into preferSubmitAtFBOBoundary feature for test coverage and ease of debugging since ARM GPU (which enables this flag) is not been tested on CI. Bug: b/255414841 Change-Id: I295cec33a8ca257a5d5a98604b8c4c0c29e97cdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4054101 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Peng Huang 2805e164 2022-11-29T15:16:42 Fix EGLImage related race condition crash Bug: chromium:1383195 Change-Id: Ibd74126f19674dad9425d2c8f5b3a217cfd590e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4062912 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Yuxin Hu 1434697f 2022-11-23T14:47:38 Add a vk feature flag to only enable precision match fixer on IMG According to https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/5273, RelaxedPrecision does not need to match in the interface matching rules. However, removing the precision match is causing triangle clipping issues on IMG hardware. This change adds a feature flag to only run the code path that applies precision match in SpirV if the hardware is IMG. This is a follow-up change to https://crrev.com/c/4049421. Instead of adding back the code path that handles varying precision mismatch for every hardware, only enabling the code path if the vendor is IMG. Test: On Pixel6: $ adb shell setprop debug.angle.feature_overrides_enabled varyingsRequireMatchingPrecisionInSpirv $ out/AndroidDebug/angle_end2end_tests --gtest_filter="GLSLTest_ES3.MismatchPrecision*" --verbose Bug: angleproject:7488 Change-Id: Ia0155f14d523195df2f47b852ed6642918270e2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4054100 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jason Macnak 2de99d47 2022-11-17T12:19:35 Reset instance/device extensions in RendererVk::onDestroy() RendererVk::initialize() adds a nullptr to the end of RendererVk::mEnabledInstanceExtensions (presumably to ensure the VK implementation crashes if it tries to read past?). If RendererVk::onDestroy() fails to clear this nullptr, it can lead to a crash when sorting the extension lists when the renderer is re-initialized the second time. Bug: b/249457381 Test: cvd start --gpu_mode=guest_swiftshader Test: EGLDisplayTest.InitalizeTerminateInitalize/ES3_Vulkan_NoFixture Change-Id: Ib24af11024cad6b28284f3a75cc862c48abec258 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4035646 Commit-Queue: Jason Macnak <natsu@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny b301b822 2022-11-07T09:37:14 Capture/Replay: emit context setup for pre-MEC contexts only When a context is made current for the first time it is added to the shared context set. If this happens after the mid execution capture has started, then the call to the context setup function is created, but the according function implementations was not emitted leading to compilation failure of the so created trace. Since a context that was never current doesn't actually have any setup that needs to be done when starting a MEC replay. Hence, there is no need to emit the calls fot SetupReplayContextXX. So track which context where actually in the shared context set when MEC started, and only emit the according calls to the setup functions. Bug: angleproject:7805 Change-Id: I83f8714733ead5c0d71560013c360b5671f0822a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4008199 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll e691bb4f 2022-11-29T07:02:21 Roll Chromium from a198ee76f3e6 to 42032d061a0a (1195 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a198ee76f3e6..42032d061a0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/31a9827c1c..0efbd89bb5 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9ca2fd2711..f2fe6dda1e * buildtools/linux64: git_revision:1c4151ff5c1d6fbf7fa800b8d4bb34d3abc03a41..git_revision:70d6c60823c0233a0f35eccc25b2b640d2980bdc * buildtools/mac: git_revision:1c4151ff5c1d6fbf7fa800b8d4bb34d3abc03a41..git_revision:70d6c60823c0233a0f35eccc25b2b640d2980bdc * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/cd0a050474..c2e10323cc * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/1a32724f72..9231726c61 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/5870472fdd..fd49ee4ee9 * buildtools/win: git_revision:1c4151ff5c1d6fbf7fa800b8d4bb34d3abc03a41..git_revision:70d6c60823c0233a0f35eccc25b2b640d2980bdc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e0c66183a0..542427f5ea * third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/4838827d12..0f44735461 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ffbead8e41..9181906668 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/216373bd26..1e254c17ed * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..41982a4a32 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/73a26246e5..fc04ff1628 * third_party/fuchsia-sdk/sdk: version:10.20221123.1.1..version:10.20221128.3.1 * third_party/r8: -zz1KNSGZYTw6zwg-o6R2OWhvHaE2AA9nrCpsrR8psYC..WqQE6kGnQ571Jtmn-m9LD7Qnd7nOi46mty5n-fZznKQC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4f8bb52f0a..a7fe07b40d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5d8bcccd51..3750e10528 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/4a3820026f..797585e74b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cd8457b738..0d9e5429c6 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I7cf5b82f29b4ae8541bac172c34f40172cdba45f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4063299 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 000b3bfa 2022-11-28T15:06:06 Vulkan: Init mLast***Serials from CommandQueue::initialize Exposed by a recent test from Jason crrev.com/cl/4035646, If RendererVk gets re-initialized, we can't rely on CommandQueue's constructor to do initalization. We have to manually initialize mLastSubmittedSerials to 0 since destroy will set it to Infinite. Bug: b/249457381 Change-Id: I90e654981fb821324cbfb177712f604b67ccc70c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4063046 Reviewed-by: Jason Macnak <natsu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b00fa5e5 2022-11-23T12:10:47 Vulkan: Pipeline graph dump vs pipeline libraries The pipeline graph dump code is now made aware of partial pipelines. Vertex input and fragment output pipelines are also output. As a collateral, UtilsVk pipelines are also included. Bug: angleproject:7369 Change-Id: I327fbd07b83ae42d27766847d70637ada04d86cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4051623 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Jason Macnak 35d1736f 2022-11-28T09:27:06 Update enabled instance extenion handling - Null terminating the instance extensions at the end of initialize to potentially avoid having the nullptr interact poorly with other initialization code that scans through the enabled instance extensions. - Ensure the enabled instance extension sort happens after all desired instance extensions have been added. Bug: b/249457381 Test: cvd start --gpu_mode=guest_swiftshader Change-Id: I2a479065444ffdfd97ecbf281fe6a777e22d584c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4060238 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jason Macnak <natsu@google.com>
Alexey Knyazev 86a194c3 2022-11-24T00:00:00 Fix expected texture target for 3D blocks ASTC 3D blocks are supported only for TEXTURE_3D targets. Bug: angleproject:3675 Change-Id: I5fa2ee87666bd69272419dc1d604348f7376aa46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4055649 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Junji Watanabe 3cfdb191 2022-11-28T14:42:34 Change ninja path to third_party/ninja/ninja It also removes `.exe` extension as it seems not necessary. Bug: chromium:1338373 Change-Id: Ic94426771d56c54b8c03627cdff6dccccec1a267 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4060128 Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 35247a4d 2022-11-23T17:19:19 Android: Remove java_api_finder from Android.bp No longer used in Android. Mirrors the following change: https://android-review.git.corp.google.com/c/platform/external/angle/+/2316258 Test: None Bug: b/260268418 Change-Id: Idb6c31b9d31a17108979f2ecca0d28cef60a11fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4053263 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 678cce80 2022-11-24T07:00:04 Roll Chromium from 9f3d33d253ac to a198ee76f3e6 (392 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9f3d33d253ac..a198ee76f3e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/88913de942..31a9827c1c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3c8fef071e..9ca2fd2711 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7b5c1435de..e0c66183a0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..07489847d9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6fde0fbe92..73a26246e5 * third_party/fuchsia-sdk/sdk: version:10.20221122.0.1..version:10.20221123.1.1 * third_party/r8: 6IAjJKfUwjFSLKQ31fxSTeXHZXcsGeoUlMKBcirZTbUC..-zz1KNSGZYTw6zwg-o6R2OWhvHaE2AA9nrCpsrR8psYC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/842cb67d55..5d8bcccd51 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7f2b5fe8eb..cd8457b738 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ib37e7ec82be185dadb5f371a5e2c3d640d7775e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4053671 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 541cdcbf 2022-11-23T15:44:53 Fix flakiness in EGL surface multithread tests. This moves the surface acquisition to inside the scoped lock. This should fix the flakiness we see on the linux-tsan-test bot. Bug: angleproject:7791 Change-Id: Idcc0f3c9d6e172b446f10c32bf6fb911fd887658 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4051622 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll e9e0da6a 2022-11-23T19:53:46 Roll VK-GL-CTS from 2db7b0a1c310 to 9d22258ed442 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2db7b0a1c310..9d22258ed442 2022-11-21 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_mutable_descriptor_type into vk-gl-cts/main 2022-11-21 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/dev/VK_EXT_descriptor_buffer into vk-gl-cts/main" into main 2022-11-18 quic_mnetsch@quicinc.com Update json files for postmortem features 2022-11-18 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_device_address_binding_report into vk-gl-cts/main 2022-11-18 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_device_fault into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I449b3a3e46c83084544712efe53fa608fd4c6857 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4052764 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu d5ce0b80 2022-11-23T12:16:46 Skip crashed test on Pixel6 due to a bug in precision matching fixer We recently need to add back the code that does spriv precision match fixer to help IMG fix a triangle clipping issue. However, the code added back is causing Pixel 6 to crash on this test: dEQP-GLES31.functional.shaders.linkage.es31.tessellation.varying.rules.internal_different_precision We are skipping this test for now until we add a feature to enable the code path on IMG only. Bug: angleproject:7488 Change-Id: I0fb2738d2faabe2ca78077e0383af3d100c75b03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4053100 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cody Northrop 71ead7b4 2022-11-20T15:56:42 Tests: Add Diablo Immortal trace Test: angle_trace_tests --gtest_filter="*diablo_immortal*" Bug: angleproject:7402 Bug: angleproject:7837 Change-Id: I7c7ccc0099707714213564740f58f04f7965a275 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4041134 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Charlie Lao 6458178e 2022-11-18T11:39:16 Vulkan: Clean up flushCommandsAndEndRenderPass APIs ContextVk::flushCommandsAndEndRenderPassWithoutQueueSubmit is calling flushCommandsAndEndRenderPassImpl(QueueSubmitType::SkipQueueSubmit). This is a bit odd and creates confusion and trouble with future CLs. This CL removes QueueSubmitType and straight up the submission code and removes some function that was doing little but to call another function. Bug: b/255414841 Change-Id: I0ed2122a98b0fc5b819fd331173bf6945d23ff8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038095 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 7dd8478e 2022-11-17T10:11:02 Vulkan: Make ResourceUse::serial an FastVector of Serials In preparation for per context queue serial, this CL makes ResourceUse::serial a FastVector of Serial. Right now we still limited to one serial index so that it still work the same way as before. This CL adds necessary data type and change the function names to reflect that tracking GPU progress needs a ResourceUse object instead of a single Serial number. Bug: b/255414841 Change-Id: Ic60cdf5ec8da45d1821f65a55947f5c553f65737 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4034548 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>