kc3-lang/angle

Log

Author Commit Date CI Message
Cody Northrop 56ea2edc 2024-08-30T11:01:48 Traces: Update regex for power rails Bug: b/354006406 Change-Id: If014c49ccdbb6e0a57c0dc88833511049c3578ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5828131 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll a2a9c686 2024-08-30T17:56:20 Manual roll Chromium from b5ec9af34e67 to 32ac9da2c5a2 (781 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/b5ec9af34e67..32ac9da2c5a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2c70f3683e..16184cdb32 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/44c93928ad..ce0161ffa0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2b3a90645e..147155281a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ed92bd5a90..99be9e63c8 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/a7f3606481..a828b2c3d4 * third_party/android_build_tools/error_prone/cipd: rFlGLiGUWHZuXRxyaWP5D1dxSJp79SS06p9S0E2HIXoC..VPB1LeLcomm-CeDrV1XZWJ9irPR3kH2viZ3IKZjm5EMC * third_party/android_build_tools/lint/cipd: knwfPKstRSh1B-e2cENtTrOmhehHsYsYeAC_yzBDDY0C..McDb8dEvTYCUAegJWyiNM_wadZHqcKTnf9mRocsu9LcC * third_party/android_build_tools/manifest_merger/cipd: u_GJEAN3XSfdXjiTZMFk5_bR6Jepu0t3K7BIeesb8uwC..h5Atz8TKYBaDMfiwvbH5UT3JFoe0Xfe16LXYdqUW8O0C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0e9c56bbf4..d794c84ff3 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/783f19f6e1..14ebe73674 * third_party/android_sdk/public: fv6JzkTqfxfIbmsRC8u1b2y0EQO7yQDMDzY3-g0NVu4C..B4p95sDPpm34K8Cf4JcfTM-iYSglWko9qjWgbT9dxWQC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9b4fe2aacd..21462dff93 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/22f6c9d8e9..2836a02f55 * third_party/fuchsia-sdk/sdk: version:23.20240823.0.1..version:23.20240830.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d8d9de41d7..e6b5251bf5 * third_party/r8/cipd: bkA7QgnyJtoxOVZ6JF9qXTD-ddmw5xXBnlamEm6kTBkC..jy1tjy7CukaTPONDmbQkYfPQnLhwqa2Si_JlIIVSHLIC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8ed6a7e581..11d66c472e No update to Clang. Bug: None Tbr: abdolrashidi@google.com,ynovikov@google.com Change-Id: I56cce5734dd833472726f1a5868b66c54e00e43b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5828575 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao e4be31ca 2024-08-29T14:30:11 Test: Add VertexAttribPointer test with different offset The first test draw with VertexAttribPointer with smaller offset and then followed by draw with VertexAttribPointer with larger offset. The second test draw with larger offset and then followed by draw with smaller offset. They will exercise logic in backend that may reuse the conversion buffers (when forced format fallback is used). Bug: b/357622380 Change-Id: If325a0547e5f80305125f448e9f987896f3e35bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5827285 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 4167a9a0 2024-08-29T23:38:05 Don't lock the context mutex if no flush in eglClientWaitSync Bug: b/362604439 Change-Id: Ic514bcb3824514b5fd82ebb14ab97286aeb6557c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5828262 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 4e3b4e0c 2024-08-21T16:56:47 Vulkan: Clear conversion buffer's dirtyRange if bufferData called If BufferData is called, the previous dirtyRange on the conversion buffer is no longer valid (the original data in BufferVk is no longer valid). This CL clears the dirty range in conversion buffers so that they do not gets unnecessarily converted. Bug: b/357622380 Change-Id: Ic97c867a8d2141659a0ffd269049f9d4168a421f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5804531 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 27a0a5ed 2024-08-29T23:23:19 Vulkan: Only access ContextVk in EGLSync if asked to flush Bug: b/362604439 Change-Id: Ifec413628de88e9048e8134c2c5e9497970f358c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5828261 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao e4aab5cc 2024-08-13T14:54:19 Vulkan: Reuse the same conversion buffer by adjusting offset In some usage case where app calls bufferSubData and then calls glVertexAttribPointer to source vertex from different offset, we could still just reuse the existing VertexConversionBuffer instead of create a new one. The benefit with this is that all previous converted data are still valid, thus reduce the overall conversion, and reduce the number of conversion buffers and saves memory. Bug: b/357622380 Change-Id: Ifcf626427e2ed500d6ab617541b78a60839d9acd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5785670 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov 4dfba10a 2024-08-30T15:05:44 Skip passmark_complex on Linux Intel Bug: b/362801312 Change-Id: I743261c7f5086d5aaf98d28c1b32fa494c0fc2e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5822715 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 8d6f6c23 2024-08-29T14:56:31 Vulkan: Unsuppress fixed VVL errors Bug: angleproject:361600662 Change-Id: Ic4585f4b38261f69700a9703bdb10b60e18f638a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5826762 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev d886a0fb 2024-08-29T00:00:00 Metal: Remove unused platform macros ANGLE_APPLE_AVAILABLE_XCI and ANGLE_APPLE_AVAILABLE_XI are no longer used. Bug: angleproject:360147119 Change-Id: I872fbe994a352673a6e9ad6468f0141c3ed98694 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5823423 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 2eb9b102 2024-08-30T10:01:42 Roll vulkan-deps from e5360151769c to 183438492d3f (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e5360151769c..183438492d3f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5073d93ec4fa2b8e6ff9b9b889ca9151ced2bf48..12cbda959b6df2af119a76a73ff906c2bed36884 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/edc68950bf725edc89b3e1974c533454cf2ae37c..b21dda0ee7a3ea4e0192a7b2b09db1df1de9d5e7 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/a6a5dc0d078ade9bde75bd78404462509cbdce99..fbda05468ec5956bc4f163b50c18b8df9312cdee https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b1e14da04cbe05cd3030909d247995328512b358..562b182f9c6443020c1d29192e6bc6a57f193e47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2e8b83bcb117b9cfc39f70ceb916e9c5d5903340 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5828129 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 8c211b10 2024-06-20T13:51:20 Metal: Clear depth pbuffers to 1 for robust init Robust resource initialization would init depth pbuffers as 0.0 instead of 1.0. This would differ from the FBO initialization, where the uninitialized depth buffers would be initialized to 1.0. Bug: angleproject:348199042 Change-Id: I0f251e85d6e08ce992fe323b257a0906d237f5b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5642763 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
Alexey Knyazev e2afdd3c 2024-08-29T00:00:00 Metal: Fix depth/stencil FBO attachments validation Simplified and fixed depth/stencil attachments validation to match Metal behavior; added a new error message. Updated allowSeparateDepthStencilBuffers feature condition to enable it on Apple silicon Macs. Fixed: angleproject:362901599 Change-Id: Ib60020f157976240ebfd652254d63380341cddbd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5823534 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi b43f8889 2024-08-29T12:34:46 Vulkan: Fix varyings reserved for xfb At some point in the past, the ANGLEXfbPosition varying was generated unconditionally when the xfb extension is available. The logic that reserved one varying for this was not updated and fails to account for it in recent drivers. Bug: angleproject:362545033 Change-Id: I65fb58cd912b96b2774a7dfbffa4aa656f694e81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5826761 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski 28d82804 2024-08-29T10:05:09 Tests: Add Passmark benchmark Complex trace Add trace of the 'Complex' benchmark test of the Passmark perofrmance test suite. Test: angle_trace_tests --gtest_filter=*passmark_complex* Bug: b/362801312 Change-Id: Ic85874140fa22f97c13b1be043120e8ccc428c96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5826921 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev e850656a 2024-08-29T00:00:00 Add EXT_separate_depth_stencil stubs Bug: angleproject:362780331 Change-Id: I378b5c9ff06a2c5e56d68ef93ed42e0351b5044e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5823195 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll eba5acd1 2024-08-29T09:51:22 Roll Chromium from d0115bcb53a9 to b5ec9af34e67 (674 revisions) Update third_party/flatbuffers per https://chromium-review.googlesource.com/c/chromium/src/+/5806430 https://chromium.googlesource.com/chromium/src.git/+log/d0115bcb53a9..b5ec9af34e67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/162c225df1..2c70f3683e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f8f6777fcf..44c93928ad * testing: https://chromium.googlesource.com/chromium/src/testing/+log/25720e4d35..2b3a90645e * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1b7ed5a193..ed92bd5a90 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/994f942b63..a7f3606481 * third_party/android_build_tools/error_prone/cipd: chEm55HMuY69gy5q0h5Dwo__Wgq8mE9pPTg2DGJL6i8C..rFlGLiGUWHZuXRxyaWP5D1dxSJp79SS06p9S0E2HIXoC * third_party/android_build_tools/lint/cipd: _59t93168d3PRj-YGCRI2tpo3QS8aFxVg7Bto7U3P34C..knwfPKstRSh1B-e2cENtTrOmhehHsYsYeAC_yzBDDY0C * third_party/android_build_tools/manifest_merger/cipd: w5qlHnh4N-npyopimuBuiIXfv4oa58ItAdUWXjAlVYAC..u_GJEAN3XSfdXjiTZMFk5_bR6Jepu0t3K7BIeesb8uwC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/4c82e77bef..0e9c56bbf4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c903c60cb7..9b4fe2aacd * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1f6ef165b7..22f6c9d8e9 * third_party/flatbuffers/src: https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/fb9afbafc7..8db59321d9 * third_party/r8/cipd: Ct5P52jBNitwDrzqSn-X_dyAlLSpDkGgQQgDk6OUUlMC..bkA7QgnyJtoxOVZ6JF9qXTD-ddmw5xXBnlamEm6kTBkC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fb801f8a4b..b8d4c963cc * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bd684abf56..6d4274cb84 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/04e8da746a..8ed6a7e581 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/b732825d28..24773901fd * tools/skia_goldctl/linux: 7zUrlH1M3MAaRzm1RhkaSmVGp8Un0kyaWCfxx2qaotgC..Lha0rEJ7GHU0Fil1gSD6dalZtxzX6uaFjpYvWih41WIC * tools/skia_goldctl/mac_amd64: TzwAr-FmCANd3dayPj5lXV1RggOMcBRmACiTfNjahPQC..KcJIi8wfbLT-tqejE6z9o5wPpCrtBjPhdVuNl2_NyqoC * tools/skia_goldctl/mac_arm64: 5gtgdukOCMKCWJiokKOieIGzR0yrQquV5P6Yzm3fcsMC..Gt9vuY-MHU7Sm1HRXh-XGw7kzNXCTwMpt4LhVmc5I58C * tools/skia_goldctl/win: 8rVMRBKm5tqDx5usdd5xW3wVJJKqL9YmKwFWgJKunEwC..7XZbTrL--iaDvJOdJ21qL6AKnpf2paDm9LmknGHscX8C Clang version changed llvmorg-20-init-1009-g7088a5ed:llvmorg-20-init-3847-g69c43468 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/fb801f8a4b25776becf0119b8b578d9b5a096285..b8d4c963cc945859452b1604c337da445fd3c98e/scripts/update.py Bug: None Change-Id: I40da4670fab2901baa267fea19d66a5e384eaef2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5826634 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Mark Lobodzinski c3309dbd 2024-08-23T15:47:27 Tests: Add Passmark benchmark Simple trace Add trace of the 'Simple' benchmark case of the Passmark performance test suite. Test: angle_trace_tests --gtest_filter=*passmark_simple* Bug: b/362784518 Change-Id: I387efb5cc0d7b1ee8c731f2fdedc56806701169c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5824181 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll fffd48d3 2024-08-29T10:01:47 Roll vulkan-deps from 23ed8d76c58a to e5360151769c (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/23ed8d76c58a..e5360151769c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/df3398078fab37b50ab33192af01cbc5b5d5b377..5073d93ec4fa2b8e6ff9b9b889ca9151ced2bf48 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/69ab0f32dc6376d74b3f5b0b7161c6681478badd..efb6b4099ddb8fa60f62956dee592c4b94ec6a49 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/13c0c4dc619d165b05061702a3c8eb604d21efa4..b1e14da04cbe05cd3030909d247995328512b358 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia372629e2cb15b76ba3dfb27c4661a40fb1fd457 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5825783 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ca20a67c 2024-08-29T08:01:18 Roll VK-GL-CTS from 824d14748364 to f1cd1d841346 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/824d14748364..f1cd1d841346 2024-08-28 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ief0e6f2275bcbcb5d46a7f02dd04ec5b3c1425a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5825778 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gowtham Tammana 79729f7c 2024-08-27T17:13:57 Reapply "Vulkan: Expose float control properties as angle features" This reverts commit 5a8eab96c6b7b99b8568feb902b8b85e2df7e19a. This relands the commit 027cbe1a071f41a09d596c4baa243a0abc3d1a86 with the below changes - add back needed suppressions that were removed erroneously ``` // https://anglebug.com/361600662 "VUID-RuntimeSpirv-OpEntryPoint-08743", "VUID-RuntimeSpirv-OpEntryPoint-07754", "VUID-RuntimeSpirv-maintenance4-06817", ``` Bug: angleproject:360031000 Change-Id: I74ed80b459466bdd8ae638ff875677b089aaa360 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5818733 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Brian Sheedy c094d4bc 2024-08-26T18:00:50 Enable tests on linux-exp-nvidia Enables tests on the new linux-exp-nvidia builder. Bug: chromium:357573052, chromium:362545033, chromium:362486580 Bug: chromium:362728695 Change-Id: Ib2f1c2edb139be1b3b2225dd9a9ec88df2bf1a84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5814931 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Gowtham Tammana 0929a8d7 2024-08-13T10:43:06 CL/Vulkan: Add utility function for clspv compile options Add a utility function for querying the options based on the vulkan renderer for the clspv compiler. Bug: angleproject:361717757 Change-Id: I9722b8a80bcad3f2b799d87b8fbe29c84a686a6e Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5810696 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Geoff Lang 42ea8555 2024-08-28T11:37:39 GL: Sync default VAO attributes for external contexts. When ANGLE touches the default VAO, we need to save and restore all of its state for external contexts. This mirrors what Chrome does in ScopedAppGLStateRestoreImpl. This allows us to use the default VAO and client arrays for external contexts, improving performance by about 10X on client array heavy benchmarks. Bug: chromium:360151048, chromium:361699768, angleproject:355034868 Change-Id: If38eb1090b5b5fdfca183a7ec519d5a8c3df0b4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5823832 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 8522e835 2024-08-26T20:46:45 WebGPU: Avoid poping error scopes too many times The ErrorScope RAII wrapper would pop the webgpu error scope multiple times if the explicit PopScope funciton was called before the destructor. Bug: angleproject:362191737 Change-Id: I8caa7ab39addf03bc09a7cce517cde800c91653c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5815568 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Igor Nazarov 24a3d30d 2024-08-28T14:33:49 Possibly fix FixedQueue.ConcurrentPushPopWithResize flakiness Queue may be empty when `enqueueThreadFinished` become true. Bug: b/302739073 Change-Id: Idb636e3f87c1217520a9e68a69e749f5bcac4d0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5823039 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll f2594877 2024-08-28T10:01:57 Roll vulkan-deps from 7efe15073686 to 23ed8d76c58a (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7efe15073686..23ed8d76c58a Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/25049cde8bf8b0a8053aec5016472d2874e0ef94..2761c159b9325baa5980e028ac081963b5d5dd9c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/be3429c27145a78bcb09c3cdff85aa6787d4c8a4..13c0c4dc619d165b05061702a3c8eb604d21efa4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Iafa6abecf6883fb7756c37a758b747de747e23ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5821732 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 23998c40 2024-08-28T07:00:57 Roll Chromium from 4358bf5ee791 to d0115bcb53a9 (374 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4358bf5ee791..d0115bcb53a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/23a5f2a09a..162c225df1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/67dc3ac32e..25720e4d35 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4917becfcf..c903c60cb7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c1457823a0..1f6ef165b7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/682be9557c..04e8da746a * tools/skia_goldctl/linux: gEqE2FO6iRIbYzXJtbhu6FRkrdGqtPx6XrU4h8pmwEEC..7zUrlH1M3MAaRzm1RhkaSmVGp8Un0kyaWCfxx2qaotgC * tools/skia_goldctl/mac_amd64: Q4WuHUZxKIIzq1OUqXi5Dd_saMZmLnqIRbvnrVoeUUwC..TzwAr-FmCANd3dayPj5lXV1RggOMcBRmACiTfNjahPQC * tools/skia_goldctl/mac_arm64: ZtqPSxqhpVysf1666ZhdkdDn_cDRZXNIvpTOxxfF7cMC..5gtgdukOCMKCWJiokKOieIGzR0yrQquV5P6Yzm3fcsMC * tools/skia_goldctl/win: REwg09_A3MRvXcOWOKRWyN0Rjuf6P__3Mmh8R97hIoQC..8rVMRBKm5tqDx5usdd5xW3wVJJKqL9YmKwFWgJKunEwC No update to Clang. Bug: angleproject:6430,angleproject:7425 Tbr: abdolrashidi@google.com Change-Id: I91f72e099d5cb41774b829c8017f28bed0d0fab6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5821230 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev cd4b8adb 2024-08-20T00:00:00 Remove obsolete macOS availability macros MTLDevice.registryID * macOS 10.13 (min deploy 10.15) kCGLRPRegistryIDLow, kCGLRPRegistryIDHigh * macOS 10.13 (min deploy 10.15) Bug: angleproject:360147119 Change-Id: Ife691a844b73abf0fb877578ad2c29e77cc70397 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5814951 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Alexey Knyazev 3f5ede8f 2024-08-20T00:00:00 Metal: Remove obsolete availability macros from context MTLSharedEvent * macOS 10.14 (min deploy 10.15) * iOS/tvOS 12.0 (min deploy 15.0) MTLDevice.hasUnifiedMemory * macOS 10.15 (min deploy 10.15) * iOS/tvOS 13.0 (min deploy 15.0) Bug: angleproject:360147119 Change-Id: I8c7e09b1fd9d16cf2bc9dcdca50a7fe577ad25a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5816833 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev e39d08b9 2024-08-20T00:00:00 Metal: Remove obsolete code from caps and extensions init MSL 2.1 * macOS 10.14 (min deploy 10.15) * iOS/tvOS 12.0 (min deploy 15.0) MSL 2.2 * macOS 10.15 (min deploy 10.15) * iOS/tvOS 13.0 (min deploy 15.0) Volume BC textures * macOS 10.15 (min deploy 10.15) Depth clipping mode * macOS 10.11 (min deploy 10.15) * iOS/tvOS 11.0 (min deploy 15.0) Dual-source blending * macOS 10.12 (min deploy 10.15) * iOS/tvOS 11.0 (min deploy 15.0) Bug: angleproject:360147119 Change-Id: I00d33d2b6b5c80a305bfbe9316c0ea670b9a4b04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5814950 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 851f949b 2024-08-27T17:55:32 Manual roll Chromium from 28739f6b546a to 4358bf5ee791 (141 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/28739f6b546a..4358bf5ee791 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/130d8fcbd0..23a5f2a09a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7ff01c1496..67dc3ac32e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/12708c50f7..682be9557c No update to Clang. Bug: angleproject:360147119 Tbr: abdolrashidi@google.com,ynovikov@google.com Change-Id: I23af7755e36672751c569a29268ac83b3b5590d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5818251 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 9e8d632a 2024-08-27T11:26:42 Guard against find_bad_constructs on nacl (again) ANGLE's BUILD.gn also referenced find_bad_constructs on nacl builds without a guard. Confirmed locally that gn gen now works on nacl. Bug: chromium:1410835 Change-Id: I1258b2841d5afa4421776ea0c412ff0e9bed135e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5815990 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Mark Lobodzinski fc4f0ac0 2024-08-21T12:54:13 formatutils: Allow 16-bit formats for renderbuffer with ext in GLES1.0 These format/use combinations should be available before ES 2.0 if the GL_OES_framebuffer_object extension is present: GL_RGBA4 GL_RGB565 GL_RGB5_A1 An E2E test is included. Test: angle_end2end_tests --gtest_filter=*FramebufrerObjectTest.RenderBufferObject* Bug: b/361370571 Change-Id: I0bc4cf43733a312c2847ebd63075338b365571d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5805221 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll e9282ae7 2024-08-27T14:44:31 Manual roll Chromium from eaaa9b6d35f9 to 28739f6b546a (100 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/eaaa9b6d35f9..28739f6b546a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5597e471cb..130d8fcbd0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b26c792ed5..7ff01c1496 * third_party/android_build_tools/lint/cipd: lUNkrgd8i-8yn5XP5j3GBmtw_wbbcLVe4ZcxMsgP03cC.._59t93168d3PRj-YGCRI2tpo3QS8aFxVg7Bto7U3P34C * third_party/android_build_tools/manifest_merger/cipd: VOU97ku-mZhXrQUHZ4fQMJVmlvMZcKInINigQJyvQQAC..w5qlHnh4N-npyopimuBuiIXfv4oa58ItAdUWXjAlVYAC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ea8afb2073..12708c50f7 No update to Clang. Bug: None Tbr: abdolrashidi@google.com,ynovikov@google.com Change-Id: I584d752e13ee0d0d81e657fd7484199e45f30cb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5815460 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen b512e42d 2024-08-20T15:12:19 Reland: Metal: Fix availability for kIOMainPortDefault Remove ad hoc deprecation disables for kIOMasterPortDefault. macCatalyst kIOMainPortDefault available 15.0, less than minimum 15.6. Remove the ifdefs. Reland: Guard macOS specific unittests with compile guards. The patch changes the tested function to be macOS only. Bug: angleproject:360147118 Change-Id: Icbcc811a066995e742825a364fc5f0b5a27a59bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5816832 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Alexey Knyazev b52f281a 2024-08-20T00:00:00 Metal: Remove unused and obsolete availability macros * Both usages of ANGLE_APPLE_AVAILABLE_XC are obsolete. * ANGLE_APPLE_AVAILABLE_CI and ANGLE_APPLE_AVAILABLE_I are unused. * iOS and tvOS SDK version ranges are supported without redefinitions. * Mac Catalyst is defined in the supported SDK versions. Bug: angleproject:360147119 Change-Id: I8e7730c31f73c03d491373a0a5d316432513d8a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5817148 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 2609e02c 2024-08-20T00:00:00 Metal: Remove unused branches from StartFrameCapture The used APIs are supported on all deployment targets. Bug: angleproject:360147119 Change-Id: Ieaa8662e97b71e97bdab3cd0f5c5ef6db3d1b305 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5817150 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 8cfb9ea2 2024-08-20T00:00:00 Metal: Align OS macro usage Consistenty used TARGET_OS_* macro instead of ANGLE_PLATFORM_* in the Metal backend code for better searchability. Bug: angleproject:360147119 Change-Id: I754ddc158daa6b1894b0b4fb0489d59f14605b66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5816828 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev be4532be 2024-08-20T00:00:00 Metal: Update availability macros in tests IsMetalTextureSwizzleAvailable is always false on Simulator. IsMetalCompressedTexture3DAvailable is always true on the supported platforms. Bug: angleproject:360147119 Change-Id: I297f7649071143b0cf3c20d5adc8fc3deca88910 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5816830 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll ecdc98f4 2024-08-27T09:53:51 Roll Chromium from eca761dbc106 to eaaa9b6d35f9 (664 revisions) Update locations of: third_party/r8/cipd third_party/r8/d8/cipd per: https://chromium-review.googlesource.com/c/chromium/src/+/5803548 Also update scripts/roll_chromium_deps.py with cipd changes missed in https://chromium-review.googlesource.com/c/angle/angle/+/5804540 https://chromium-review.googlesource.com/c/angle/angle/+/5792313 i.e.: third_party/android_system_sdk/cipd third_party/android_build_tools/aapt2/cipd third_party/android_build_tools/lint/cipd third_party/android_build_tools/manifest_merger/cipd https://chromium.googlesource.com/chromium/src.git/+log/eca761dbc106..eaaa9b6d35f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6a42fd6513..5597e471cb * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4434cfea96..f8f6777fcf * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f96bb12230..b26c792ed5 * third_party/android_build_tools/error_prone/cipd: YqeN_FF5AQD-nio02hA2KgnBCJfq7qvNBckmETpkmVUC..chEm55HMuY69gy5q0h5Dwo__Wgq8mE9pPTg2DGJL6i8C * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f5e1092339..c1457823a0 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6071843cd8..d8d9de41d7 * third_party/siso/cipd: git_revision:250f32bbb04e51117d17db783c9535dd956f7d44..git_revision:10bd8dc16d411e512d5a9d0cfe7435a7cee10071 * third_party/turbine: HLBr7iWMO2VeD_WbrAA1eq33jZZCVxvA3noE3LNzSlQC..0x14qVQmOdhVAM7Sygzzwm0xfTjL7Bl-0I642feaCSkC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f7fd8eedc4..fb801f8a4b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0ba4cb96fe..bd684abf56 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/634176da98..ea8afb2073 No update to Clang. Bug: None Change-Id: Id6e196639482072515595a64e9c557f044c61912 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5815360 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7108f0b4 2024-08-27T10:01:02 Roll vulkan-deps from 38174d6926f6 to 7efe15073686 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/38174d6926f6..7efe15073686 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ffd454c57bdbea8ae493df7a5d2733ae2b02cb81..df3398078fab37b50ab33192af01cbc5b5d5b377 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2b69b240b90bf096848952cecf5de0ff6788cdd6..be3429c27145a78bcb09c3cdff85aa6787d4c8a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I5a448363694278ae16a1652a4539146830e6f582 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5815458 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9bf6fb58 2024-08-27T10:01:32 Roll SwiftShader from dc27069e5d04 to 3c4bdf66d81d (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/dc27069e5d04..3c4bdf66d81d 2024-08-26 swiftshader.regress@gmail.com Regres: Update test lists @ dc27069e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I792bd5dac9dfd86dfd245e8ff14803653b717128 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5816691 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 5a8eab96 2024-08-27T10:07:26 Revert "Vulkan: Expose float control properties as angle features" This reverts commit 027cbe1a071f41a09d596c4baa243a0abc3d1a86. Reason for revert: removes needed suppressions, breaking bots: https://ci.chromium.org/ui/p/angle/builders/ci/win-exp-test/569/overview https://ci.chromium.org/ui/p/angle/builders/ci/linux-exp-test/810/overview https://ci.chromium.org/ui/p/angle/builders/ci/android-arm64-exp-s22-test/1060/overview Original change's description: > Vulkan: Expose float control properties as angle features > > The different fp configuration that a vulkan backend supports are > exposed through `VkPhysicalDeviceFloatControlsProperties`. Expose these > as angle features that api's implementations can query. > > The autogen files are changes as reported by running `python3 > scripts/run_code_generation.py` script. > > Bug: angleproject:360031000 > Change-Id: I038cbf2c9e2b10916697994782ef73b35a1caf12 > Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5798053 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> Bug: angleproject:360031000 Change-Id: I88c0a083725320b5e1a8302a50f67d41cbf5c089 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5816829 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 2177be94 2024-08-26T17:32:22 Manual roll VK-GL-CTS from 21ff94426906 to 824d14748364 (13 revisions) Manual roll requested by syoussefi@google.com * KHR-GLES3: * Removed outdated test names to resolve the unused expectation warning. * (After test name changes, they no longer exist in the mustpass test list.) * KHR-GLES31: * Unsuppressed a test that no longer fails. https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/21ff94426906..824d14748364 2024-08-23 ziga@lunarg.com Fix build on windows 2024-08-23 MengYang.Liu@amd.com Add test cases for maxPushConstantsSize queried from device 2024-08-23 mate@rastergrid.com Fix waiver mechanism for Vulkan SC testing 2024-08-23 gsweet@broadcom.com Check fillModeNonSolid before using non-solid fill modes 2024-08-23 gleese@broadcom.com Add extra fast-math decoration in OpPhi tests 2024-08-23 ziga@lunarg.com Test pipeline using compatible render pass without resolve attachment 2024-08-23 ziga@lunarg.com Fix crash in local read max input attachments test 2024-08-23 gleese@broadcom.com Revert "Test mismatched dimensionality" 2024-08-23 ewerness@nvidia.com Default --deqp-terminate-on-device-lost to enable 2024-08-23 kamil.goras@mobica.com Split KHR-GL46.shading_language_420pack* 2024-08-23 kamil.goras@mobica.com Split KHR-GL46.packed_pixels.* 2024-08-23 syoussefi@google.com Fix missing GL barriers in `LoadStoreMachine` tests 2024-08-23 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: b/350994515 Bug: angleproject:40096882 Tbr: abdolrashidi@google.com,syoussefi@google.com Change-Id: I9db95cedef583120733c34c8630864fbad3c36f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5812210 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Gowtham Tammana 027cbe1a 2024-08-13T17:27:27 Vulkan: Expose float control properties as angle features The different fp configuration that a vulkan backend supports are exposed through `VkPhysicalDeviceFloatControlsProperties`. Expose these as angle features that api's implementations can query. The autogen files are changes as reported by running `python3 scripts/run_code_generation.py` script. Bug: angleproject:360031000 Change-Id: I038cbf2c9e2b10916697994782ef73b35a1caf12 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5798053 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Austin Annestrand a2602533 2024-08-16T15:31:43 CL/VK: Update zero-enqueue validation checks According to the spec: CL_INVALID_GLOBAL_WORK_SIZE if global_work_size is NULL or if any of the values specified in global_work_size[0], …​ global_work_size[work_dim - 1] are 0. Returning this error code under these circumstances is deprecated by version 2.1. Since ANGLE supports OpenCL 3.0, we need to remove our "gws[dim] != 0" assert since this is no longer an error. Also adding missing check for LWS[dim] == 0 case since validationCL does not check for this prior to performing a modulo operation. Bug: angleproject:361750102 Tests-Fixed: OCLCTS.test_api.zero_sized_enqueue Change-Id: I02f302fd988bc37e3b52aeea30586843a47cadfd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5807300 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Austin Annestrand c34e8c75 2024-08-16T14:06:10 CL: Platform check for ValidateCreateContextFromType Bug: angleproject:42266872 Change-Id: Iaf19a2bb6ca1e1a1ce7b02852a3e4fd5290bd557 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5807299 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 6ef39db0 2024-08-20T00:00:00 Metal: Remove obsolete compile guards for texture helpers MTLDevice.supports32BitFloatFiltering - macOS 11.0 (min compile 12.0, min deploy 10.15) - iOS 14.0 (min compile 17.0, min deploy 15.0) - tvOS 16.0 (min compile 17.0, min deploy 17.0) MTLDevice.supportsBCTextureCompression - macOS 11.0 (min compile 12.0, min deploy 10.15) - iOS 16.4 (min compile 17.0, min deploy 15.0) - tvOS 16.4 (min compile 17.0, min deploy 17.0) MTLPixelFormatPVRTC* enums - macOS 11.0 (min compile 12.0) - iOS 8.0 (min compile 17.0) - tvOS 9.0 (min compile 17.0) Bug: angleproject:360147119 Change-Id: Iafb010efc233f9c677a2c6f65cb4efdf0bb9cf9c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5805290 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 939fafc8 2024-08-20T00:00:00 Metal: Remove MSL version compile guards MTLLanguageVersion1_0 - Deprecated MTLLanguageVersion2_3 - macOS 11.0 (min compile 12.0, min deploy 10.15) - iOS/tvOS 14.0 (min compile 17.0, min deploy 15.0) MTLLanguageVersion2_4 - macOS 12.0 (min compile 12.0, min deploy 10.15) - iOS/tvOS 15.0 (min compile 17.0, min deploy 15.0) Bug: angleproject:360147119 Change-Id: I4a0da9d92ef86e899766bc860f3bc6e7e614f4a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5806332 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Geoff Lang fd47e185 2024-08-26T15:52:43 Don't reference find_bad_constructs on nacl builds find_bad_constructs is not defined on nacl and causes gn analyze errors Bug: chromium:1410835 Change-Id: I88297950b05ff084f1c58c23ec34834cbd700a59 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5813088 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang e10e31ed 2024-08-26T12:56:42 WebGPU: Add error handling macros for debugging. Add a ANGLE_WGPU_SCOPED_DEBUG_TRY to create an error scope, execute some commands and pop the scope in builds with assertions enabled. A follow-up with full error handling at frame boundaries is still needed. Bug: angleproject:362191737 Change-Id: I4af9e1587f6d70bf14a3f6435b487e26424624ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5813006 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 95c30276 2024-08-26T18:14:30 Don't use VK_GOOGLE_surfaceless_query on Samsung S24 Xclipse Apply S22 workaround on S24 as well, tentative fix for bad traces. Bug: b/362253922 Change-Id: I5a04741d7465139f86de5baadbf774eed172b4e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5812323 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuly Novikov d51c2516 2024-08-26T14:30:12 Add iOS build instructions. Bug: angleproject:40096751 Change-Id: I3168663374906afbdec5a4ad5398704dbcf3731d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5812088 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 966d0a1a 2024-08-20T00:00:00 Metal: Cleanup memoryless storage mode support detection Bug: angleproject:360147119 Change-Id: Ic47f1d84e748f65194aa819a39418db66b1948c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5802956 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Yuly Novikov 8281af52 2024-08-15T16:26:02 Skip timing out end2end tests on Samsung S24 Xclipse. Add GALAXYS24 expectation tag and skip: FramebufferTest_ES31.ChangeFBOSizeAndAttachmentsCount FramebufferTest_ES31.ChangeFBOSizeWithNoAttachments FramebufferTest_ES31.CreateNoAttachmentFBOWithDifferentSize FramebufferTest_ES31.RenderingLimitToDefaultFBOSizeWithNoAttachments Bug: angleproject:359904354 Change-Id: If88fa3876b7fcf534d99fee75b5aa4fa6da140c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5808948 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev 003737c8 2024-08-20T00:00:00 Metal: Adjust texture storage mode compile guards Used managed mode only for macOS and Mac Catalyst compile targets. Fixed compilation for visionOS. Bug: angleproject:360147119 Change-Id: I88fae28ff6d1ecb5ba303d32c4a3874bf3f8aa87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5802959 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev a36c459e 2024-08-20T00:00:00 Metal: Remove redundant symbol redeclarations MTLBlitOptionRowLinearPVRTC - macOS 11.0 (min compile 12.0) - iOS/tvOS 9.0 (min compile 17.0) MTLBarrierScope - macOS 10.14 (min compile 12.0) - iOS/tvOS 12.0 (min compile 17.0) MTLBarrierScopeRenderTargets - Moved compile guards to call sites MTLRenderStages, MTLRenderStageVertex, MTLRenderStageFragment - macOS 10.13 (min compile 12.0) - iOS/tvOS 10.0 (min compile 17.0) Bug: angleproject:360147119 Change-Id: I7dac46accde63be486a7de918284bbd6e8367a4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5806896 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 1f1b7426 2024-08-20T00:00:00 Metal: Remove compile guards for preserveInvariance MTLCompileOptions.preserveInvariance - macOS 11.0 (min compile 12.0, min deploy 10.15) - iOS/tvOS 14.0 (min compile 17.0, min deploy 15.0) Bug: angleproject:360147119 Change-Id: I54bd75f3136e907ebb738b855f12b80f3c161b41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5806898 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll ddec94e6 2024-08-26T10:01:09 Roll vulkan-deps from d95811d4259d to 38174d6926f6 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d95811d4259d..38174d6926f6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/d205aff40b4e15d4c568523ee6a26f85138126d9..a6a5dc0d078ade9bde75bd78404462509cbdce99 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/cfeba7074a6a0260bbcc8f912a6c51bcc125c546..25049cde8bf8b0a8053aec5016472d2874e0ef94 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/40294f25aa4522fe309504aaf30c1c259e11b75b..7e82aea5fc1394d417a0df6a5680a4cce5c37286 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/9b6e18888be3ac761a3f71594c3949f8dc862ccc..7ea05992a52e96426bd4c56ea12d208e0d6c9a5f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/be0b0bba40ae901c82bbaa47770d629192957a19..2b69b240b90bf096848952cecf5de0ff6788cdd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I7fdfb1747a00aad4aaab2762ed9a5ed6066df918 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5812102 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7c065142 2024-08-26T07:02:31 Roll Chromium from edd99dda0b7b to eca761dbc106 (740 revisions) https://chromium.googlesource.com/chromium/src.git/+log/edd99dda0b7b..eca761dbc106 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0ad9d6f198..6a42fd6513 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a8c444eac6..4434cfea96 * buildtools/linux64: git_revision:d010e218ca7077928ad7c9e9cc02fe43b5a8a0ad..git_revision:225e90c5025bf74f41dbee60d9cde4512c846fe7 * buildtools/mac: git_revision:d010e218ca7077928ad7c9e9cc02fe43b5a8a0ad..git_revision:225e90c5025bf74f41dbee60d9cde4512c846fe7 * buildtools/win: git_revision:d010e218ca7077928ad7c9e9cc02fe43b5a8a0ad..git_revision:225e90c5025bf74f41dbee60d9cde4512c846fe7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1fd2d9c009..f96bb12230 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c530bb2c89..4917becfcf * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4eb5cc887d..f5e1092339 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6491ee32ba..6071843cd8 * third_party/r8: DkEQJQKHFcd_oZaA7BLxJLXPTT-MTlqGRyZ7sN1dTp4C..Ct5P52jBNitwDrzqSn-X_dyAlLSpDkGgQQgDk6OUUlMC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/ff7581fe6b..4f3ee3fd09 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/344cf79356..0ba4cb96fe * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/10e7beb304..634176da98 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I86258630a21e3cf9d64f0e24a93bc6702f15d738 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5810699 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao acf63b9e 2024-08-22T09:52:41 Vulkan: call traceGpuEvent after queueSerial has been allocated traceGpuEvent() will write to mOutsideRenderPassCommands. This means if we destroy context immediately it will flush OutsideRenderPassCommands. This will trigger assertion that the queueSerialIndex is invalid. This CL moves queueSerialIndex allocation before traceGpuEvent. Bug: b/361570359 Change-Id: I70909ebd23c43c05cb793319b255f81e65a17a9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5806203 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Greg Schlomoff <gregschlom@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana 3f1c47bf 2024-08-13T15:06:40 Vulkan: Add VK_KHR_variable_pointers ext if available Add VK_KHR_variable_pointers exetensions to enabled extension if it is supported. This is needed when SPIR-V 1.4 is supported. Bug: angleproject:360031000 Change-Id: Ia93604ae308c9f304acb3bc39457811401a0ca7b Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5789897 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 2e35835b 2024-08-23T11:28:54 Suppress new VUIDs VUID-RuntimeSpirv-OpEntryPoint-08743 VUID-RuntimeSpirv-OpEntryPoint-07754 VUID-RuntimeSpirv-maintenance4-06817 Started reporting after VVL roll https://chromium-review.googlesource.com/c/angle/angle/+/5807076 Bug: angleproject:361600662 Change-Id: Ibdf30bd2506366460009f18a4e1f63559d23eb97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5803266 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll e5802ddc 2024-08-23T10:01:40 Roll vulkan-deps from 2df89413855e to d95811d4259d (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2df89413855e..d95811d4259d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/592de6cf78e0fb359fc3e2854c9dc0f3cf6d4820..ffd454c57bdbea8ae493df7a5d2733ae2b02cb81 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/438875314dc838d130098127c6e908798500fecc..cfeba7074a6a0260bbcc8f912a6c51bcc125c546 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ia8b1b71d33ce0da0f7a1132a32e782085e2025c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5807113 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 58c1e56b 2024-08-23T10:01:50 Roll SwiftShader from 7216df70d311 to dc27069e5d04 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/7216df70d311..dc27069e5d04 2024-08-22 swiftshader.regress@gmail.com Regres: Update test lists @ 7216df70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I074b0c59f24681686631f1ffefa0466059df7680 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5807862 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 54d53342 2024-08-23T07:22:18 Roll Chromium from 6994f4772212 to edd99dda0b7b (526 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6994f4772212..edd99dda0b7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7798ff7e56..0ad9d6f198 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/941596c255..a8c444eac6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7a59f77e6f..1fd2d9c009 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/301a1695a1..994f942b63 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9f91481f1d..c530bb2c89 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f617b4617..4eb5cc887d * third_party/fuchsia-sdk/sdk: version:23.20240815.4.1..version:23.20240823.0.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9c3fb06173..6491ee32ba * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/ccfbe1c82a..4426a8da65 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/116c20dae6..dc70138c3e * third_party/r8: BLP0V0lHIffRLj-o9uhUnvAjMOzA8ZJtIejMb-Kobb8C..DkEQJQKHFcd_oZaA7BLxJLXPTT-MTlqGRyZ7sN1dTp4C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4533290e05..f7fd8eedc4 * tools/luci-go: git_revision:ad7b787aa0ee53a81bc88fb4f7fee7a3ff1e8c29..git_revision:5845c6112f584c023a47776b31c3b6f08f562fb8 * tools/luci-go: git_revision:ad7b787aa0ee53a81bc88fb4f7fee7a3ff1e8c29..git_revision:5845c6112f584c023a47776b31c3b6f08f562fb8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d0d33d43fb..10e7beb304 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I50108fb6d688303018d1b96ba62819af98b1ae1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5807108 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 38d5b4d6 2024-08-21T15:49:33 Vulkan: Clean up the CovertVertexBuffer* API Some minor clean up of the API so that the arguments we passed into these two functions CovertVertexBufferGPU and CovertVertexBufferCPU are symmetrical. This CL also factor out the common logic in these two functions into a helper function CalculateOffsetAndVertexCountForConversion(). Bug: b/357622380 Change-Id: I5339850c99d733dfea5039ba74734290f8326bd3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5804529 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 8fc6d8a8 2024-08-13T09:49:46 Vulkan: Limit vertexBufferConversion to the data within dirtyRange Right now when we do vertex buffer conversion, we always convert from the binding.offset all the way to the end of the buffer, because we do not know who much vertex will be drawn. According to the comment, if we choose to only convert the number of vertices this draw call will be using, then we may end up issuing a lot of conversions in the case that there are many draw calls with small vertex numbers. This CL intends to keep this behavior (i.e, still do the conversion of the data from binding offset to end of the buffer), but apply the optimization that pays attention of mDirtyRange and only convert the portion of data that has actually been modified. Note that the mDirtyRange is the union of all data ranges that has been modified, so may include the unmodified data between two modified ranges. Bug: b/357622380 Change-Id: I91f3dbf4cacb17d3fa4d8d599519865be765557f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5785860 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 267e806b 2024-08-22T16:15:40 Manual roll vulkan-deps from 1863e513f0db to 2df89413855e (11 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/1863e513f0db..2df89413855e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/25b4e42ead9fbea6b74e31aa488dee2e54c23ae8..edc68950bf725edc89b3e1974c533454cf2ae37c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/f993f9722589d339a2e2766332b4d591157b5ade..40294f25aa4522fe309504aaf30c1c259e11b75b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/dee644bbffbd9abd8e677ac96634b25d50df1439..be0b0bba40ae901c82bbaa47770d629192957a19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I49be3110a21a0569477be16890328f0e4bc4f6b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5807076 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 6f97a8b3 2024-08-21T13:25:28 Vulkan: Add two tests for vertex conversion Two glBufferSubData calls and then use the buffer (get down to the vertex conversion code path, at least with forced fallback config). The test will exercise the logic regarding the conversion with multiple dirty ranges. Two tests are added in this CL, one with two overlapping range and another with non-overlapping range. Bug: b/357622380 Change-Id: Id8fa23a6e1511e2f03c002782ab99f167416ca02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5805244 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll 99fa4d4e 2024-08-22T14:14:37 Manual roll vulkan-deps from d8208b108762 to 1863e513f0db (19 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/d8208b108762..1863e513f0db Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d59c84d388c805022e2bddea08aa41cbe7e43e55..592de6cf78e0fb359fc3e2854c9dc0f3cf6d4820 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/1b75a4ae0b4289014b4c369301dc925c366f78a6..69ab0f32dc6376d74b3f5b0b7161c6681478badd https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/87fcbaf1bc8346469e178711eff27cfd20aa1960..25b4e42ead9fbea6b74e31aa488dee2e54c23ae8 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/452b3fd7d3a3ba5449ee45f32695f943460d8c61..438875314dc838d130098127c6e908798500fecc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/494d32f2da0bd8a782d88fdaa98b9e1967148d1b..f993f9722589d339a2e2766332b4d591157b5ade https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ee7aabe61203c57a8123503b985dd603e08fe806..dee644bbffbd9abd8e677ac96634b25d50df1439 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I0041e44811c7320bb29050d283113bffd85ef874 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5807074 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll b78833b1 2024-08-22T09:28:29 Roll Chromium from 79944459a28c to 6994f4772212 (2584 revisions) Update location of: third_party/android_system_sdk/cipd per: https://chromium-review.googlesource.com/c/chromium/src/+/5790209 https://chromium.googlesource.com/chromium/src.git/+log/79944459a28c..6994f4772212 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c21cc4a276..7798ff7e56 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/36b281734a..941596c255 * buildtools/linux64: git_revision:54f5b539df8c4e460b18c62a11132d77b5601136..git_revision:d010e218ca7077928ad7c9e9cc02fe43b5a8a0ad * buildtools/mac: git_revision:54f5b539df8c4e460b18c62a11132d77b5601136..git_revision:d010e218ca7077928ad7c9e9cc02fe43b5a8a0ad * buildtools/reclient: re_client_version:0.157.0.d2566cec-gomaip..re_client_version:0.158.0.ddc2270e-gomaip * buildtools/win: git_revision:54f5b539df8c4e460b18c62a11132d77b5601136..git_revision:d010e218ca7077928ad7c9e9cc02fe43b5a8a0ad * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b28404ae36..7a59f77e6f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ed3733b91e..1b7ed5a193 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/7ae3036e4c..301a1695a1 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/dc4679d47e..783f19f6e1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/799e21b232..9f91481f1d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37a737c1bc..8f617b4617 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/40b967f07b..9c3fb06173 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/eb6567388e..a834cb2539 * third_party/r8: C4UQJ3lVMOKokpVF4Wxbgqb8EdzZ7NSCihUEqDgrlDIC..BLP0V0lHIffRLj-o9uhUnvAjMOzA8ZJtIejMb-Kobb8C * third_party/siso/cipd: git_revision:87262779ecc3482c8c60b070404b225107212d0d..git_revision:250f32bbb04e51117d17db783c9535dd956f7d44 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/4efc34892e..ff7581fe6b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/63b7be17f8..4533290e05 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6abb195855..344cf79356 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/d7a1bee91c..bd3ae34fa1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/167cffa814..d0d33d43fb * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/a69a8ecdbf..b732825d28 * tools/skia_goldctl/linux: 8P9u35-wUJOuCZt7KfoaHql4TnnYfCE6PcMUJaLjcG0C..gEqE2FO6iRIbYzXJtbhu6FRkrdGqtPx6XrU4h8pmwEEC * tools/skia_goldctl/mac_amd64: msDdo7ZqznAXC4geehuff02Ggz-TUFdGe5bqHvnWCQ4C..Q4WuHUZxKIIzq1OUqXi5Dd_saMZmLnqIRbvnrVoeUUwC * tools/skia_goldctl/mac_arm64: neECyUAIg1_QJCcxMv9PgZnZ5iVqoq43ZRTFhE5F12YC..ZtqPSxqhpVysf1666ZhdkdDn_cDRZXNIvpTOxxfF7cMC * tools/skia_goldctl/win: YufvDpBuGUe9YcFanPljAShLJMIp6_OV_XLBY0JrltgC..REwg09_A3MRvXcOWOKRWyN0Rjuf6P__3Mmh8R97hIoQC No update to Clang. Bug: angleproject:361262466, angleproject:361372438 Change-Id: I243291d2be95692138fb60ad0e50b2b420e60079 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5804540 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll bf167aa3 2024-08-22T08:01:27 Roll VK-GL-CTS from f105fd7ea388 to 21ff94426906 (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/f105fd7ea388..21ff94426906 2024-08-19 rgarcia@igalia.com Fix gen_framework.py warnings about invalid escape sequences 2024-08-16 lorenzo@khronosgroup.org Merge branch 'dev/VK_EXT_legacy_vertex_attributes' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I2210977c46e82e60f82b0ceecef169bd48ab4804 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5806317 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 790e0162 2024-08-09T17:11:38 Vulkan: Add dirty range to VertexConversionBuffer class Previously, ConversionBuffer only has a boolean indicates it is dirty or not. This CL adds mDirtyRange to it to indicate which range of data has been modified. The existing dirty boolean has been changed to mEntireBufferDirty so that all the current code will still work. Right now mEntireBufferDirty is always set when we mark it dirty, which means entire buffer gets converted. mDirtyRange has not been used to reduce the data to be converted. Right now the range is always being merged to the existing range and not actually being used in this CL. It will be used in the next CL. Bug: b/357622380 Change-Id: Ibfa702b29011f4e26c511d5db85c07cbf2a4aefb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5778347 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 33c2ff07 2024-08-20T00:00:00 Metal: Remove obsolete watchOS compile guards MTLSamplerAddressModeMirrorClampToEdge: - macOS 10.11 (min compile 12.0, min deploy 10.15) - iOS 14.0 (min compile 17.0, min deploy 15.0) - tvOS 16.0 (min compile 17.0, min deploy 17.0) Bug: angleproject:360147119 Change-Id: I21457e7f0694d09857153199037929f9739eded0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5803986 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Matthew Denton d263945a 2024-08-20T16:32:36 Translator: make replaceChildNode() a little more type-safe If we know the type the child node should be, instead of static_cast<>ing to the expected type, use getAs{ExpectedType}() and crash if nullptr. This would have saved me when the ReplaceVariables() AST transformaton replaced a TIntermSymbol in a TIntermGlobalQualifierDeclaration with a TIntermTyped that was not a TIntermSymbol. But TIntermGlobalQualifierDeclaration can only have a TIntermSymbol as a child, so this caused confusing crashes. Other node types have similar expectations of the types of their children. This doesn't enforce any type safety on TIntermAggregate children as those are a little more flexible and complicated. This CL also doesn't enforce non-nullptr children when the parent can't handle nullptr children. Bug: angleproject:42267100 Change-Id: Ic7fb41039705aa4f6daec052940d9bfc4974d955 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5800264 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
angle-autoroll 41309a2f 2024-08-20T08:01:27 Manual Roll VK-GL-CTS from 50e83129b558 to f105fd7ea388 (16 revs) Added deqp.gni changes for: gl3cPrimitiveRestart.hpp/cpp es3cDriverErrorTests.hpp/cpp https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/50e83129b558..f105fd7ea388 2024-08-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-08-16 ziga@lunarg.com Fix race condition in EGL multithreading tests 2024-08-16 younggwan.kim@arm.com Add coverage for depth bound test without depth attachment 2024-08-16 tomek.bury@broadcom.com Fix dEQP-EGL.functional.fence_sync.valid.egl_fence_persistent_buffer 2024-08-16 okuznetsov@google.com New tests group for known driver error tests 2024-08-16 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (primitive_restart_mode), PART 10 2024-08-16 piotr.byszewski@mobica.com Test DRLR remapping while using shader object 2024-08-16 ziga@lunarg.com Test drawing with stencil test and without vkCmdSetFrontFace 2024-08-16 rgarcia@igalia.com Reuse scratch buffer creating acceleration structures back-to-back 2024-08-16 rgarcia@igalia.com Test preemption with VK_KHR_global_priority 2024-08-16 rgarcia@igalia.com Removed ESO compute tests using Amber 2024-08-16 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.11 into vk-gl-cts/main 2024-08-14 syoussefi@google.com Remove DE_NULL's definition 2024-08-05 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.5 into vk-gl-cts/main 2024-08-05 ziga@lunarg.com Fix broken build on windows 2024-08-04 michal.jakubek@mobica.com VK_DEFINE_PLATFORM_TYPE macro doesn't accept nullptr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I71223610821b102501a78eea2abecb95d10f4910 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5799167 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 1dabe52c 2024-08-20T00:00:00 Metal: Remove texture swizzle compile guards Texture swizzle support: - macOS 10.15 (min compile 12.0, min deploy 10.15) - iOS/tvOS 13.0 (min compile 17.0, min deploy 15.0) Bug: angleproject:360147119 Change-Id: If7e59cc094e5bcdb145a54541662d0fe0a989e8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5803984 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll deba56c2 2024-08-21T14:08:19 Manual roll vulkan-deps from dad70915c62f to d8208b108762 (6 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/dad70915c62f..d8208b108762 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/595c8d4794410a4e64b98dc58d27c0310d7ea2fd..d205aff40b4e15d4c568523ee6a26f85138126d9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/83cd92c725987857a84c871bd8bc11b249d239b1..452b3fd7d3a3ba5449ee45f32695f943460d8c61 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/32379b03f828619cb54eed874a11ab7e5ceafb3a..494d32f2da0bd8a782d88fdaa98b9e1967148d1b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/45b881573538f8e481cb6e1d811a9076be6920c1..9b6e18888be3ac761a3f71594c3949f8dc862ccc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d9e05641700bb3f0537c74a190e9a9183e3b58aa..ee7aabe61203c57a8123503b985dd603e08fe806 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I5931cdade413f4e1a2adb3e9d7c874bf38bd38b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5803902 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev f551a112 2024-08-20T00:00:00 Metal: Remove obsolete compile guards from the command buffer memoryBarrierWithScope and memoryBarrierWithResources: - macOS 10.14 (min compile 12.0, min deploy 10.15) - iOS/tvOS 12.0 (min compile 17.0, min deploy 15.0) dispatchThreads: - macOS 10.13 (min compile 12.0, min deploy 10.15) - iOS 11.0 (min compile 17.0, min deploy 15.0) - tvOS 14.5 (min compile 17.0, min deploy 15.0) Bug: angleproject:360147119 Change-Id: I05e4e5dac81b4e07c47e0f3a1b7d165ff9406cc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5804021 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Yuly Novikov 36f7e03a 2024-08-21T13:49:10 Revert "Metal: Fix availability for kIOMainPortDefault" This reverts commit a712626e940cbd3ff6f279a6e838362392a3fd1d. Reason for revert: breaks iOS https://chromium-review.googlesource.com/c/chromium/src/+/5802272 https://ci.chromium.org/ui/p/chromium/builders/try/ios-simulator/2048194/overview Original change's description: > Metal: Fix availability for kIOMainPortDefault > > Remove ad hoc deprecation disables for > kIOMasterPortDefault. > macCatalyst kIOMainPortDefault available 15.0, > less than minimum 15.6. Remove the ifdefs. > > Bug: angleproject:360147118 > Change-Id: I2ccc08814e267984ff53275cc2886e2bfa8d4c2a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797149 > Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> > Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Bug: angleproject:360147118 Change-Id: Iab3e8d1dece4866732ecbebab4c83f274b99e034 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5803985 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Le Hoang Quyen f102d75a 2024-08-14T19:52:30 Metal: translate IOSurface pbuffer's GL_RGB to RGBX/BGRX format. Currently when IOSurface is bound to a pbuffer with GL_RGB internal format, we asign angle format=B8G8R8A8_UNORM/R8G8B8A8_UNORM to it. And then disable alpha write to the respective MTLTexture. However, when an implicit MSAA texture is created for the above pbuffer, it will be assigned B8G8R8A8_UNORM/R8G8B8A8_UNORM angle format but has no knowledge about alpha write disable. Consequently, when a render pass uses this implicit MSAA texture, its alpha channel won't be cleared properly and would contain garbage values. In order to avoid the above bug, we should use B8G8R8X8_UNORM/R8G8B8X8_UNORM angle format for the IOSurface pbuffer. This will fix the render corruptions found in chromium:358957665. Bug: angleproject:42261786 Bug: chromium:358957665 Change-Id: I8aa1e24ace2de80dd08e21711445515ba4b339ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5788801 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Kimmo Kinnunen 5cf94ffa 2024-08-20T10:41:40 Metal: Use pipeline rasterSampleCount Use MTLRenderPipelineDescriptor rasterSampleCount instead of sampleCount. This avoids the use of the deprecation macro. Availability: iOS 8.0 (min: 15.0), mac Catalyst 13.1 (min: 16.5), macOS 10.11 (min: 10.15), tvOS 11.0 (min: 15.0), visionOS 1.0+ Bug: angleproject:360147118 Change-Id: I7009a7d7b39ecb763e23f4b97441fb45a64a891d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797134 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Kimmo Kinnunen 25237423 2024-08-20T15:22:32 Metal: Remove ifdefs for primitive topology class MTLPrimitiveTopologyClass availability iOS 12.0, minimum runtime 15.0. Remove the ifdefs. Hardcoding ANGLE_IOS_DEPLOY_TARGET is dangerous, likely it has never been correct. Remove. Should use __IPHONE_OS_VERSION_MIN_REQUIRED. Bug: angleproject:360147118 Change-Id: I43d7a364fa0237af1ee1f546015ae884fc373b15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797141 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Kimmo Kinnunen a712626e 2024-08-20T15:12:19 Metal: Fix availability for kIOMainPortDefault Remove ad hoc deprecation disables for kIOMasterPortDefault. macCatalyst kIOMainPortDefault available 15.0, less than minimum 15.6. Remove the ifdefs. Bug: angleproject:360147118 Change-Id: I2ccc08814e267984ff53275cc2886e2bfa8d4c2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797149 Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Charlie Lao 86508e20 2024-08-16T14:56:37 Vulkan: Make VertexConversionBuffer a class And wrap the cache key (i.e, formatID/stride/offset) into a CacheKey struct so that we can easily add more data members. This CL also changes ConversionBuffer from struct to class to have better encapsulation. No functional changes is expected here. Bug: b/357622380 Change-Id: Ieecf5c922b95a940137c8e54657ef3f458c55fc9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5793921 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao a3f9f6c3 2024-08-16T12:12:00 Vulkan: Move VertexConversionBuffer out of BufferVk class This is another preparation CL to make code review easier. In the future CL, VertexConversionBuffer will be used in other files. BufferVk::VertexConversionBuffer is a bit too verbose. Make VertexConversionBuffer a standalone class makes code a bit easier to read. We could potentially merge ConversionBuffer and VertexConversionBuffer into single class, but I am leaving it for future exercise. Bug: b/357622380 Change-Id: I2255a1c9b01f5d6c3846e8017cc667e6a9d66ffc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5787504 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 7080b766 2024-08-16T11:31:39 Vulkan: Move LineLoopHelper from vk to rx namespace There is no line loop support in vulkan. LineLoopHelper is a utility function for backend, not a helper function for vulkan object. So it is better fit in rx namespace instead of vk namespace. This also helps my next CL where I am going to change initBufferForVertexConversion to take a ConversionBuffer instead of BufferHelper. LineLoopHelper uses initBufferForVertexConversion, which means I have to change LineLoopHelper to uses ConversionBuffer. This causes header inclusion problem that now vk namespace object end up have to include rx namespace header. This CL fixes this inclusion problem by moving it to the proper namespace. Bug: b/357622380 Change-Id: I6d6cf1aa926f726bb1b1ab1017bcab092eaf5d37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5787502 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Kimmo Kinnunen e0f790c0 2024-08-20T12:08:40 Metal: Use present APIs for Metal availability Use non-deprecated APIs for checking Metal backend availability. macCatalyst and macOS needs MacFamily2 Availability: - macOS 10.15, minimum runtime 10.15 - macCatalyst 13.1, minimum runtime 16.5 iOS, minimum runtime 15.0, can always use the backend. Bug: angleproject:360147118 Change-Id: Id0b70c81bc8b54a22b94ba514aab148b202d58ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797053 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen eb6c4bfe 2024-08-20T09:58:11 Metal: Fix availabilities of MTLGPUFamily use Fixes compile in case of targeting only the newer SDKS. [MTLDevice supportsFamily:] is supported on all minimum runtimes: - macOS 10.15 (minimum runtime 10.15) - macCatalyst 13.1 (minimum runtime 16.5) - iOS/tvOS 13.0 (minimum runtime 15.0) Remove the ifdefs and fallbacks. MTLGPUFamilyMacCatalyst1 is deprecated on macCatalyst 16.0. Replace with MTLGPUFamilyMac2. MTLGPUFamilyMac1 is deprecated on macOS 13.0. Replace with MTLGPUFamilyMac2. MTLGPUFamilyApple7 is present on iOS/tvOS 14.0, minimum runtime 15.0. Remove ifdefs. MTLGPUFamilyApple6,7 are present on macOS 11.0 SDK, minimum SDK 12.0. Remove ifdefs. Bug: angleproject:360147118 Change-Id: I337d1ad44940a2f39a57ba8a28de0e1d7387658c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797050 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen 2758d4dc 2024-08-20T16:00:07 Metal: Remove shared event related ifdefs Shared events are supported by iOS 12, macOS 10.14, included in the minimum versions iOS 15, macOS 10.15. Bug: angleproject:360147118 Change-Id: I5b62dade045f9d50864ef1906cb22a18fd09e4da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5797150 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang 2f2cdbb8 2024-08-19T11:05:22 D3D11: Fix uniform setting for mat3 followed by float A single float following a float3x3 will pack tightly in the last row of the matrix. The uniform setting code for matricies would write a full row stride's worth of data for the last matrix row, overwriting the float packed at the end. Update ExpandMatrix to only write colsSrc worth of values in the last row. Bug: angleproject:42266878, chromium:345525082 Change-Id: Ieb616972387501cd8c30f02b267f86a7f81cf01a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5796631 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Le Hoang Quyen 1a191b1d 2024-08-16T17:31:38 Metal: add an option to emulate DontCare loadOp with randomized Clear. This is useful for testing undefined initial values caused by DontCare MTLLoadAction on non-tiled GPUs. Bug: angleproject:42261786 Change-Id: Id5c4a9ee8510a8a9143bdd67e276bfcf2bd7eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5791386 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Alexey Knyazev 57a3e9a7 2024-08-15T00:00:00 Prevent compilation with unsupported Apple SDK versions Bug: angleproject:360147119 Change-Id: Ie9924cb49ffa729d454a2869a2d19d957500bd10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5793513 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 4931cab2 2024-08-19T12:47:15 Roll SwiftShader from 65157d32945d to 7216df70d311 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/65157d32945d..7216df70d311 2024-08-19 swiftshader.regress@gmail.com Regres: Update test lists @ 65157d32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ia12a368e4bd750687fb46052c0fa8958c3320dcf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5796985 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 62cc3790 2024-08-19T11:05:52 Metal: Remove UseResource old SDK fallbacks Fixes deprecation compile errors on newer SDKs. Remove the version guards, the useResource API is available on: macOS 10.15, minimum supported version 10.15 iOS 13, minimum supported version 15 macCatalyst 13.1, minimum supported version 16.6 (for macOS 13.5) Bug: angleproject:360147118 Change-Id: I6d2dd7cb510d6134b75d4479ae7159b8fbcfc96b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5796002 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Gowtham Tammana 579a5855 2024-08-13T11:39:54 Vulkan: Add query for 64bit fp support feature check Add a feature check for shaderFloat64 support. If present expose the corresponding feature check. The following files are updated by running the autogen script - `run_auto_code_generation.py` - include/platform/autogen/FeaturesVk_autogen.h - util/autogen/angle_features_autogen.cpp - util/autogen/angle_features_autogen.h Bug: angleproject:360031000 Change-Id: If2a11190729550ad5b84714e0a3aa3b81956c66a signed-off-by: gowtham tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5789896 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana e90cd0c4 2024-08-12T17:07:47 Vulkan: Add check for int8 extension support Vulkan backend currently has a check for float16 part in VK_KHR_shader_float16_int8 extension. Add the int8 support as well. The changes in below files are generated through `scripts/run_code_generation.py` script - include/platform/autogen/FeaturesVk_autogen.h - util/autogen/angle_features_autogen.cpp - util/autogen/angle_features_autogen.h Bug: angleproject:360031000 Change-Id: I8811779299e3d24b4536d1871e1eadcbb87432c2 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5792021 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana 319907d2 2024-04-05T16:05:33 Vulkan: Propagate the support of shaderInt16/64 feature Progate the support of shaderInt16/64 features in to enabled feature list. Bug: angleproject:360031000 Change-Id: I38915a764fb2f1dd31348c01bc2fcfa4913ebdec Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5792019 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0