kc3-lang/angle

Log

Author Commit Date CI Message
Jamie Madill 5ca36d3c 2023-01-05T15:16:35 Trace Interpreter: Properly support resource ID maps. Previously we were using the key value as the resource value. In some cases these values would become mismatched when running a replay, which would cause interpreter errors. Bug: angleproject:7887 Change-Id: I7f8e687986e8282a6df066bdae5ace07e4510b47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4140258 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny 4194dab4 2023-01-09T12:03:47 Capture/Replay: Test the correct context ID when emitting setup Fixes: b432c84c2b8cb6d20873e2b33b6684bee76db90d (origin/chromium/5455) Capture/Replay: Fix collecting the initialized contexts Bug: angleproject:7805 Bug: angleproject:7938 Change-Id: Ia321179bef8fd33c7968177ffcb4da78103a99fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4143840 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Roman Lavrov 4403abc0 2023-01-06T16:14:48 Enable merge script failure detection chromium_swarming.expose_merge_script_failures https://crbug.com/1346781#c96 Bug:chromium:1346781 Change-Id: I33c7fcbaa286f4c0401a16c0a03635054c7330f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4144179 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll b28fa2e4 2023-01-09T12:44:56 Roll VK-GL-CTS from 5aa5b0809f05 to c1ebeb5013f9 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/5aa5b0809f05..c1ebeb5013f9 2023-01-09 piotr.byszewski@mobica.com Fix missing global_priority_transition tests 2023-01-09 zzoon@igalia.com Add tests for BufferView access with all formats supported interacted with fetchTexel and ImageLoad 2023-01-09 cturner@igalia.com Warn if STORAGE_*_ATOMIC_BIT is set on multi-component formats. 2023-01-09 cturner@igalia.com Enable missing dedicated allocation tests in copy_and_blit 2023-01-09 rgarcia@igalia.com Treat DynamicLibrary library list as alternatives 2023-01-09 amber@igalia.com Ensure that some clear commands ignore conditionals. 2023-01-09 amber@igalia.com Add tests for a renderpass with LOAD_OP_CLEAR and STORE_OP_STORE 2023-01-09 piotr.byszewski@mobica.com Test device entry-points from instance extensions 2023-01-09 tapani.palli@intel.com Fix state query tests for desktop GL context 2023-01-09 mykola.piatykop@globallogic.com Support GL 4.5 in the 'negative' tests 2023-01-09 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC srisser@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: srisser@google.com Change-Id: I52d1d4187fd56b86154cc7bf7e8ac7ba8b6c182d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4146546 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d53c520e 2023-01-09T08:14:05 Roll Chromium from 20196e335c59 to 02451be6fd41 (589 revisions) https://chromium.googlesource.com/chromium/src.git/+log/20196e335c59..02451be6fd41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC srisser@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/12734d306c..0c2eadc5bb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/120e9f1884..809529a935 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e38c901c6f..278c5821d6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..163b421317 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/50985d5fdd..6f905470df * third_party/fuchsia-sdk/sdk: version:11.20230105.2.1..version:11.20230108.3.1 * third_party/r8: jyDAFIKO9nDUNWJzgjzSp6qvRE8di6dCoBtierYMedEC..3VqLjArDzdJ3Rgq8SH04G_33VEV5H7Wk5KquOg8OMkUC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5c711ec7ea..e8c31f937f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b09d7430e..0d00eb2837 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/34faa777c7..574936f02f No update to Clang. Bug: angleproject:3685,angleproject:4242,angleproject:5038,angleproject:5223,angleproject:6245,angleproject:7079,angleproject:7234,angleproject:7421 Tbr: srisser@google.com Change-Id: I190b669737645c62d7e4fef7e94071ab62070d91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4146543 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 9c1598af 2023-01-06T14:42:59 Trace Replay: Fix UBO access in the trace fixture. This bug was from the rework to use encapsulated functions. Bug: angleproject:7731 Bug: b/262815739 Change-Id: I3965c04439c8f4c2e67708bd2536b8beb3270880 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4144178 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Yuly Novikov 1f997cef 2023-01-06T19:09:37 Skip crashing final_fantasy trace perf on Pixel 6 native Bug: angleproject:7936 Change-Id: Ied2399e66052d3b3f2b26f39c32aaf3950579eea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4143838 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov cf6a3f09 2023-01-06T12:52:49 Add srisser Bug: None Change-Id: Ibedbbf4068a31c2f1a4cf64848a7fb8a49e72a23 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4143442 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 5c4e1c35 2023-01-06T12:22:48 Fix angle_metrics.json handling Nested for loops work the other way around :S Bug: angleproject:7299 Change-Id: Ic1d21a6a354f9cebca09ae0975eba126ab6406f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4143440 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Roman Lavrov ca56b966 2023-01-06T11:53:08 Update owners (+solti +lpy -lfy -ffz) Bug: None Change-Id: If7da7c7299b31159290222f5be010a174f0bec36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4143439 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuly Novikov e7ded5d9 2023-01-06T14:06:20 Add ANGLE Pixel 6 CQ and Perf bots Keeping the experimental bot to test adding GLES backend tests. Bug: angleproject:6819 Change-Id: I869fc3fe29964756d0231b0a6fc51aa7774963f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4143159 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov ca0489f0 2023-01-06T13:13:55 Skip couple flaky trace perf tests on Win Intel beach_buggy_racing on Vulkan aliexpress on native Bug: angleproject:7934 Change-Id: I78f78174e95aa0a4bab6685efb62b52f87e6e4f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4143158 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 045888db 2023-01-06T07:00:50 Roll Chromium from f676f874381a to 20196e335c59 (511 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f676f874381a..20196e335c59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC srisser@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e273177111..12734d306c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dc4013e8dd..120e9f1884 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ec32355335 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/58a343c88b..50985d5fdd * third_party/fuchsia-sdk/sdk: version:11.20230104.1.1..version:11.20230105.2.1 * third_party/r8: fCfmTCTodJobBFr8fnGgzGEOm8w4aaHiVjWr5Id9cEwC..jyDAFIKO9nDUNWJzgjzSp6qvRE8di6dCoBtierYMedEC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3b54a131a9..5c711ec7ea * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7c3502515b..3b09d7430e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b26e426e04..34faa777c7 No update to Clang. Bug: None Tbr: srisser@google.com Change-Id: I6df15b67c89cfde0259e1eaf1fa01b138a745734 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4141581 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Dan Glastonbury 1d2b20f5 2022-12-23T14:21:10 Metal: Fix Metal API deprecation warnings macOS 13/iphoneOS 16 deprecated Metal APIs, causing warnings when building ANGLE targeting Ventura as the minimum supported OS. WebKit handles deprecated APIs by selectively silencing warnings around the affected code. This change adds ANGLE_APPLE_ALLOW_DEPRECATED_{BEGIN/END} and wraps code generating warnings to silence the warning. Bug: angleproject:7908 Change-Id: I7469652e0f4e0cf41ae3c295c2e3ae6bbd72e949 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4121822 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Charlie Lao 26e28089 2023-01-04T15:15:46 Vulkan: Improve RPCommandHelper::isImageWithLayoutTransition() RenderPassCommandBufferHelper::isImageWithLayoutTransition() was added in crrev.com/c/3366014 to detect if there is a barrier inserted for the renderPass. If yes, we have to endRenderPass before compute shader, since compute dispatch goes into outsideRenderPassCommands, which writes into primary command buffer before renderPassCommands. Otherwise the compute dispatch will be using the image before the actual layout transition occurs, which is wrong. But to detect if the image has a layout/barrier transition in the renderPass, it maintains an angle::FlatUnorderedSet. With recent change for per active context queue serial, we can use the queue serial to detect this. This CL adds a queueSerial for image layout/barrier change and compares it with RenderPassCommands' queueSerial to decide if the renderPass has a layout/barrier for the image. This CL also did some minor clean ups: Removed unused API ContextVk::getActiveImages(). Removed writtenByCommandBuffer() check in CommandBufferHelperCommon::bufferWrite() before calling setWriteQueueSerial, since the check is more expensive than set. Added setQueueSerial call in OutsideRenderPassCommandBufferHelper::imageWrite to be consistent with imageRead. (This might be fixing a bug here). Replaces a few retainResource(image) to image->setQueueSerial for consistency. Bug: b/264472911 Change-Id: I74badd6b8a35f86640e42d330a1a709ccfb961c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4136948 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Yuxin Hu c4b95929 2023-01-05T19:59:07 Revert "Reland "Make ANGLE program version only dependent on data that matters"" This reverts commit 61728827d2e5ecce685578bc54bb2c744b65fc9a. Reason for revert: it breaks aosp build: https://android-review.git.corp.google.com/c/platform/external/angle/+/2374971. Build error: `FileNotFoundError: [Errno 2] No such file or directory: 'angle_code_affecting_program_serialize'` Original change's description: > Reland "Make ANGLE program version only dependent on data that matters" > > This is a reland of commit c303758fbc8d23266be578fae246e5687656b4c6 > > Changes made on top of original commit > 1. Enable execution permission on python script > program_serialize_data_version.py > 2. Remove unused list in libGLESv2.gni > 3. In angle/BUILD.gn, change file path from > "relative to angle_root", to "relative to root_build_dir", > so that inside the script program_serialize_data_version.py, > we don't have to find the absolute path of the code files for > hashing. > > Original change's description > > > This change introduces a new variable ANGLE_PROGRAM_VERSION > > to track the version of ANGLE source files that affect shader > > program serialization/deserialization. This change include more > > source files than necessary, to serve the purpose of a conservative > > jumping off point. We will narrow down the list of files for > > ANGLE_PROGRAM_VERSION hash generation in the future. > > > Add a new script program_serialize_data_version.py that will > > be triggered during the build when the related source files changed. > > The script will generate a hash and the hash size from the related > > source files. In program serialization/deserialization and cache > > key generation, we will use this hash value instead of the entire > > ANGLE git hash. When the hash value changed, we know that the > > related source files changed, and we should invalidate the program > > cache and re-generate the blob cache / program binary. > > > Bug: angleproject:4981 > > Change-Id: I2fb609416738d459d3289190c232c2d797ba58e3 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4072215 > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Cody Northrop <cnorthrop@google.com> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Yuxin Hu <yuxinhu@google.com> > > Bug: angleproject:4981 > Change-Id: Iaa9eb0ab33439197bc30d03064fc245ea7ef1ea8 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4113445 > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:4981 Change-Id: If7d3779c8f40dafa9a9c057f669ab53d0494526e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4140138 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 341f2908 2023-01-04T16:17:17 Vulkan: Remove the car_chase skip This should now be fixed by crrev.com/c/4133548. Re-enable the test for pixel6. Bug: angleproject:7916 Change-Id: Ice0adc2c81c797f31354e086e5606744941de311 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4137290 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Kenneth Russell 43c5849f 2023-01-05T12:29:40 Add colleagues at Apple who have contributed to ANGLE. This is just for bookkeeping purposes. Bug: angleproject:7932 No-Try: True Change-Id: I1e88145c762198e60cc293382ba1c39131b0458c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4136556 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill 18950e64 2023-01-05T11:33:59 Capture/Replay: Fix unpack alignment inconsistency. We were checking the current value of the unpack alignment in the replay when we should have been comparing vs the set value in the context. Bug: angleproject:7816 Change-Id: Ib7e6ed785e07e06a7f55f4b727f640912b75b7a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4139299 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Geoff Lang d2525834 2023-01-05T11:26:46 Metal: Mark ES3.0 as complete Bug: chromium:1322521 Change-Id: I224a25732f759eebd6706b7f5bf26fe78307cb02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4139298 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Charlie Lao 2662f28f 2022-12-30T17:26:22 Vulkan: Fix imageRead from RP and outsideRP simultaneously When a texture is been sampled from both fragment shader and compute shader, you will have the same VkImageLayout. We will not try to end renderPass, which means you end up running into similar situations with OutsideRenderPassCommandBufferHelper::bufferRead where an image is already read accessed by a started renderPass and now read accessed by an outsideRenderPassCommands. Since renderPass has greater queueSerial, we should not tag it with outsideRenderPassCommands' queueSerial. This CL also adds two tests, one for color texture and another for depth texture (which is car_chase uses). Both exposes the same bug. Bug: angleproject:7916 Change-Id: I840ca8947caeb7a96c4c9ccb7c9eca2476837c9c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4133548 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 2e086405 2022-12-23T00:00:00 Metal: Implement ANGLE_clip_cull_distance Emulate clip distance varyings as they are not available in Metal fragment shaders. Drive-by: skip rewriting unused pipelines. Bug: angleproject:7904 Change-Id: Iabc37ffe6e8c9e2d0fb34e508ae2512a200c8351 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4124235 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov d88464de 2023-01-05T17:27:48 Skip 2 slow trace perf tests on Win Intel five_nights_at_freddys on Vulkan pubg_mobile_launch on native Bug: angleproject:7929 Change-Id: Ie6ebcc3db616a55fdbb9f1a0d67c950b80dc2010 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4133268 Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill d0fa9fe2 2023-01-04T12:15:02 Capture/Replay: Fix GetProgramInterfaceiv write location. This was mistakenly writing to the read-only binary data blob. Instead properly write to the read buffer. Bug: angleproject:7887 Change-Id: I039981b0bd03983542f6432d1091651c1d553479 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4135796 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
angle-autoroll 3604f6b8 2023-01-05T07:00:12 Roll Chromium from 9b6c0a64c3c0 to f676f874381a (435 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9b6c0a64c3c0..f676f874381a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC srisser@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/80991d5790..e273177111 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c5a91cd488..dc4013e8dd * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/6a7478b495..e38c901c6f * third_party/android_build_tools/lint: J-5WRwQBFHGawLX-f-wZAyfdYMmyLPTltnrTVG1HrvwC..0X1mSg1M9Q3Dv6pcOnX0mK0YR_LyTxyT3oRbYk5uxQ8C * third_party/android_build_tools/manifest_merger: lUT6vCuXPnPR-G-V3k69iMWuFtVOzwED-IwaHqYT4AcC..7ZPeHZjITxCcJzrEuxb5yznF7h65-RTQrbhzILJz4_gC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..038b25e395 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/252b19866a..58a343c88b * third_party/fuchsia-sdk/sdk: version:11.20230104.0.1..version:11.20230104.1.1 * third_party/r8: GBS8IZ2wumMlodGQUSzolGjJELkBWiZDNIEOLGiV1MsC..fCfmTCTodJobBFr8fnGgzGEOm8w4aaHiVjWr5Id9cEwC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/18d27fa10b..fa5dc47500 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/2c8d802803..7c3502515b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0f2155f845..b26e426e04 * tools/skia_goldctl/linux: GYJyu-6ZtuFKlycWv9v7SFg61ONNNobNlfP0HTV6IGQC..E46nXQa9dcFdViDiaWhmdecJ-XgdTDLkrfaGq45UlsUC * tools/skia_goldctl/mac_amd64: SVMraIHmdNooMzoPH_0l0pHjwN9wgULMxNntBbrNQyMC..rfHNzii-7hBOdsmGW8WeOM_JU0csp7fQgf-6p8cPyZYC * tools/skia_goldctl/mac_arm64: CklLGpnehytIF37cw7TK3rU3GqE_NzN76x9OERwfrNMC..WMPFVGxAsM-r610JEQHRGWzuoZ72se528q3xXCHUeDAC * tools/skia_goldctl/win: jmDxbBm43jkyCFWbnBLpWu8GADl05R5x2kV-ttxKaUgC..NlbXdAFIb05vtC14fXZwj8gK67uZHdlqPVPBbNhpU1QC No update to Clang. Bug: None Tbr: srisser@google.com Change-Id: Ib00b0ef260ec251dd70e782b7bdbe2787ed2924a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4137295 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 5f1ab1d1 2023-01-03T11:48:51 Fix Deferred Flush Bug On Android Hardware Buffer When does app read from Android Hardware Buffer is outside of ANGLE's control. If we defer glFlush, it is possible that when the app is reading from AHB, the commands have not been flushed and executed, causing app to read unexpected data. This change adds a check to not defer glFlush when the Framebuffer draw attachment is Android Hardware Buffer. Bug: b/262886794 Change-Id: Ie0606f71b1a4f4f20511b7327e7ffb8c096ac727 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4126700 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Loic Sharma 32175d8a 2023-01-04T09:53:02 Address Visual Studio 17.4 build issues The `SpirvType` is used as a key in a hash map. When using Visual Studio 17.4, the build fails as `SpirvType`'s equality operator is not defined. This declares `SpirvType`'s equality overload on its header file. Bug: angleproject:7925 Change-Id: If5013df36eb9c33bba88eebe8752df7808b02ff5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4136932 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 968c429e 2023-01-04T14:18:11 Tests: Use ISOLATED_OUTDIR for test artifact directory. This should fix the missing CAS outputs on the bots. Bug: angleproject:7926 Change-Id: Id09e5ccc19a454e2c0bf63076788187f3c7ef24f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4135158 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 056f8044 2022-10-11T11:58:20 Perf tests: write metrics to file and read from merge script. The idea behind is to save metrics in a structured output with full context so that we don't have to parse stdout and reconstruct that context (e.g. which test was running when the output was printed etc). Note: we already have a "histogram" file (addHistogramSample) written but it is structured using some UUID-based ids making its digestion more complicated (https://anglebug.com/7299#c3). This CL just writes events as one-json-per-line simplifying downstream handling and debugging. Just a sanity check / logging in the merge script for now. Bug: angleproject:7299 Change-Id: I56dada643eceef180ce9bb1aa9ae6a641ea41e4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3945112 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Gregg Tavares 91ff986c 2022-12-19T14:30:25 Metal:Switch to NoWait in eglReleaseTexImage Now that eglWaitUntilWorkScheduled is implemented in ANGLE and called in Chromium we can set this to NoWait Bug: angleproject:7890 Change-Id: Ib6fbda18b940873409653a968aa956bc728025a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4117714 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Cody Northrop b354667e 2022-12-24T12:21:17 FrameCapture: Fix tracking of glCopyImageSubData When tracking texture updates during glCopyImageSubData, choose an enum supported by PackedEnum when looking up the textureID. Also add a test for a common pattern used by the Unreal Engine that trips up FrameCapture. Test: CopyImageTestES31.CubeMapCopyImageSubData/* Bug: angleproject:7913 Change-Id: I6c0fee69064cc6dc81177093ec9461dd5ccc152a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4126449 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuly Novikov f2290d80 2023-01-04T17:20:49 Re-enable tests on win10-x64-intel-perf Bot was switched to new GPU and driver in crrev.com/c/4133266, so hopefully BSOD issue is fixed. Bug: angleproject:6332 Change-Id: I4b7d5ab6b8dc559f75b487a85ec453876ac13932 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4133267 Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop a0939325 2023-01-01T17:41:33 Tests: Add Catalyst Black trace Test: angle_trace_tests --gtest_filter="*catalyst_black*" Bug: angleproject:7921 Bug: angleproject:7924 Change-Id: I626d6790ef602f3ca09c9c9a4e03c5df32a985ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4133886 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jason Macnak 2256c548 2022-12-15T20:44:38 Map AHARDWAREBUFFER_FORMAT_R8_UNORM to GL_R8 Bug: b/259551816 Test: cvd start --gpu_mode=guest_swiftshader Test: atest librenderengine_test Change-Id: I32a7b83494426e291cc93fe2b5f245eab6a54b0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4112149 Commit-Queue: Jason Macnak <natsu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Jason Macnak 6fdac95a 2022-12-15T20:36:01 Mirror Android AHB formats in ANGLE owned enum The existing code seems to try to keep all AHB formats defined in android_util.cpp (potentially in an attempt to simplify format conversions?). However, trying to avoid redefinition errors when conditionally re-defining the AHB formats across builds/branches is difficult. IIUC, there are two levels at play when building for Android: 1) "target level": the level of the phone/device you are building for. 2) "build level": the level of the repository/checkout you are building from. The "target level" (__ANDROID_API__) cannot be used to guard the definitions in android_util.cpp because it is possible to build for an older device in a newer branch. For example, suppose AHARDWAREBUFFER_FORMAT_X was introduced in Android T. If ANGLE tried to redefine AHARDWAREBUFFER_FORMAT_X in android_util.cpp with the guard "if __ANDROID_API__ < T", re-definition errors would still occur when building for Android S devices ( __ANDROID_API__ set to S) from inside of an Android T branch because the format would still be defined in android/hardware_buffer.h. A failure of this type can be seen in aosp/2308065 which tried to guard AHARDWAREBUFFER_FORMAT_R8_UNORM with "if __ANDROID_API__ < 33". Additionally, Android sets __ANDROID_API__ to 10000 before releases are cut and it is supposed to be fixed at release time. However, this has been observed to not be fixed on some less maintained side branches. Detecting the "build level" seems to be quite difficult. When building from outside of Android, this is the NDK level which can be detected using __ANDROID_NDK__ and __NDK_MAJOR__. When building from inside of Android, this is the latest level available on your specific branch. I believe this can only be found by incrementally checking for the existence of the various __ANDROID_API_R__, __ANDROID_API_S__, etc defines. This alternative can be seen in https://crrev.com/c/4039066. However, this is very difficult to find and read. Instead, let's just define ANGLE's own enum which mirrors the Android enums which can be used without having to worry about the current build system or release/branch. Bug: b/259551816 Test: cvd start --gpu_mode=guest_swiftshader Test: atest librenderengine_test Test: ANGLE presubmit Test: Android presubmit on aosp/master (aosp/2360445) Test: Android presubmit on aosp/android13-gsi (aosp/2360447) Test: Android presubmit on aosp/android11-gsi (aosp/2360520) Change-Id: I62f12cb0e1cc4b3b24aab7b85f39360a2cd2e438 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4112148 Commit-Queue: Jason Macnak <natsu@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 6382dd74 2023-01-04T13:49:50 Switch Win Intel to Optiplex 7080 by rolling Chromium Optiplex 7050 had HD 630 GPU PCI ID 8086:5912. Optiplex 7060 had UHD 630 GPU PCI ID 8086:3e92. Optiplex 7080 has UHD 630 GPU PCI ID 8086:9bc5. Also upgrading the driver from 26.20.100.8141 to 31.0.101.2111. And the Windows 10 version from 1909 to 21H1. Re-enable angle_restricted_trace_gold_tests on Intel, since they looked stable on the experimental bot. Stop running tests on the experimental win10-x64-exp-intel. Roll chromium_revision 87b7ed3032..9b6c0a64c3 (1088609:1088686) Change log: https://chromium.googlesource.com/chromium/src/+log/87b7ed3032..9b6c0a64c3 Full diff: https://chromium.googlesource.com/chromium/src/+/87b7ed3032..9b6c0a64c3 Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9c112b5654..c5a91cd488 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a404e6d108 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/eb0a826405..2c8d802803 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7e2765e6fa..0f2155f845 DEPS diff: https://chromium.googlesource.com/chromium/src/+/87b7ed3032..9b6c0a64c3/DEPS No update to Clang. Bug: chromium:1349828, angleproject:7708 Change-Id: I8af85de8334c01a5cdd62149ab30be9eaba5d07a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4133266 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 7c08f0a5 2023-12-03T00:00:00 Skip ClipCullDistanceTest.SizeCheckCombined on TSAN Bug: angleproject:7922 Change-Id: I19c9ce729be8bf7a68517f340cd001332f22be08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4134844 Auto-Submit: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 24ac26c3 2023-01-04T07:01:44 Roll Chromium from 0f261e9e8ec1 to 87b7ed3032e5 (483 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0f261e9e8ec1..87b7ed3032e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC srisser@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/51292789ec..80991d5790 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/59f8af36bb..9c112b5654 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a404e6d108 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5b0c934026..252b19866a * third_party/fuchsia-sdk/sdk: version:11.20230103.0.1..version:11.20230104.0.1 * third_party/r8: F3_m_gPJBJRUVJToRwtfZCgFuh5TkWnIGUOD6TaHVfkC..GBS8IZ2wumMlodGQUSzolGjJELkBWiZDNIEOLGiV1MsC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7e4e3bf6f7..eb0a826405 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/522525fc09..7e2765e6fa No update to Clang. Bug: None Tbr: srisser@google.com Change-Id: Ibf692bc002547908507eb3204a991aa032dfe33b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4133899 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 61728827 2022-12-14T15:29:15 Reland "Make ANGLE program version only dependent on data that matters" This is a reland of commit c303758fbc8d23266be578fae246e5687656b4c6 Changes made on top of original commit 1. Enable execution permission on python script program_serialize_data_version.py 2. Remove unused list in libGLESv2.gni 3. In angle/BUILD.gn, change file path from "relative to angle_root", to "relative to root_build_dir", so that inside the script program_serialize_data_version.py, we don't have to find the absolute path of the code files for hashing. Original change's description > This change introduces a new variable ANGLE_PROGRAM_VERSION > to track the version of ANGLE source files that affect shader > program serialization/deserialization. This change include more > source files than necessary, to serve the purpose of a conservative > jumping off point. We will narrow down the list of files for > ANGLE_PROGRAM_VERSION hash generation in the future. > Add a new script program_serialize_data_version.py that will > be triggered during the build when the related source files changed. > The script will generate a hash and the hash size from the related > source files. In program serialization/deserialization and cache > key generation, we will use this hash value instead of the entire > ANGLE git hash. When the hash value changed, we know that the > related source files changed, and we should invalidate the program > cache and re-generate the blob cache / program binary. > Bug: angleproject:4981 > Change-Id: I2fb609416738d459d3289190c232c2d797ba58e3 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4072215 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:4981 Change-Id: Iaa9eb0ab33439197bc30d03064fc245ea7ef1ea8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4113445 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Cody Northrop b5a8cb42 2022-12-30T21:00:54 Tests: Add Cut the Rope trace Test: angle_trace_tests --gtest_filter="*cut_the_rope*" Bug: angleproject:5823 Bug: angleproject:7920 Change-Id: I6c607c593d828623afadff5677e0a8324e6b89f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4129086 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Jamie Madill 71e89320 2023-01-03T09:10:08 Tests: Support multiple filters with ":". Now we can run multiple traces per invocation, e.g.: "trex_200:among_us" Bug: angleproject:7775 Change-Id: I8e8176d444f20ae97234469ab8c553543b81b331 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4132944 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop e5efa2a7 2022-12-30T17:10:37 Tests: Add Portal Knights trace Test: angle_trace_tests --gtest_filter="*portal_knights*" Bug: angleproject:7919 Change-Id: Ie11fd45afdd2cb70d1caef2e0006ba26ac5fdf25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4129107 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 8e2b87ac 2022-12-29T21:19:29 Tests: Add MU Origin 3 trace Test: angle_trace_tests --gtest_filter="*mu_origin_3*" Bug: angleproject:7917 Change-Id: Ic00a42d3c8b7c6c92a66c09c258a32d22e5f4805 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4129866 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Cody Northrop b9e38879 2022-12-28T21:00:57 Tests: Add Agent A: A puzzle in disguise trace Test: angle_trace_tests --gtest_filter="*agent_a*" Bug: angleproject:7914 Change-Id: I3be5192a64c400b341b313e92211126e3ad1fd38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4128940 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill e5e78ab4 2022-12-29T13:16:13 Trace Interpreter: Auto-gen ReplayCustomFunctionCall. This makes it easier to add or remove fixture functions. Bug: angleproject:7775 Change-Id: I1c56465cfa0580414715f562cadc916c4baf3d11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4128718 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 1afc4d5b 2023-01-03T07:00:53 Roll Chromium from 0527f4c37ce4 to 0f261e9e8ec1 (171 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0527f4c37ce4..0f261e9e8ec1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC srisser@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/57f06c162f..51292789ec * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b26bae660a..59f8af36bb * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a404e6d108 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03af44a516..5b0c934026 * third_party/fuchsia-sdk/sdk: version:11.20230101.3.1..version:11.20230103.0.1 * third_party/r8: uAjFIZ9i7MR0q1ZlcUKmq7qr9IS0Ypa2PwO0xPB8W1wC..F3_m_gPJBJRUVJToRwtfZCgFuh5TkWnIGUOD6TaHVfkC * third_party/turbine: 6qP1McD5frsv2QklnzCMFruX8BO9asL49lv_ohhd2DkC..P0XosyjdPaNgW3Am_eNs0rON86r0B11hB3hhwh3_INAC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d1501ddb68..7e4e3bf6f7 No update to Clang. Bug: None Tbr: srisser@google.com Change-Id: I2cf8011dd7e1f791a9b1acbfe25ae3a7c477d455 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4132186 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll efbccf44 2023-01-02T07:00:59 Roll Chromium from 021aa77ec4a7 to 0527f4c37ce4 (232 revisions) https://chromium.googlesource.com/chromium/src.git/+log/021aa77ec4a7..0527f4c37ce4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bd72f1bcd3..57f06c162f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a404e6d108 * third_party/fuchsia-sdk/sdk: version:11.20221229.3.1..version:11.20230101.3.1 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I42c4b9a6f3bf4297f5ca8dd7aaa123d3a41f9337 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4131169 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 03b2c124 2022-12-30T07:00:19 Roll Chromium from 6dd45e16083b to 021aa77ec4a7 (215 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6dd45e16083b..021aa77ec4a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d9fb377a52..bd72f1bcd3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/134af4c91b..cf8d11e411 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d12fb9a66f..6a7478b495 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/3ec81a68ed..226f6e2047 * third_party/android_build_tools/lint: 9qiQ29AZRZapFWdlmgjd22gc1RxJ1oXZKPAsTq_3G88C..J-5WRwQBFHGawLX-f-wZAyfdYMmyLPTltnrTVG1HrvwC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a404e6d108 * third_party/fuchsia-sdk/sdk: version:11.20221229.0.1..version:11.20221229.3.1 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I74f2de398b462559e453ecba87dad7ff15466da7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4129868 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 4a8bc146 2022-12-29T17:26:05 Skip angle_restricted_trace_gold_tests.car_chase asserts on Pixel 6 Assert failed in setSerial Bug: angleproject:7916 Change-Id: I05a91cfd29194e29e6c512c9001c064951dcf466 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4127959 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll 37766750 2022-12-29T07:00:34 Roll Chromium from c546b7bba9bc to 6dd45e16083b (240 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c546b7bba9bc..6dd45e16083b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fe0a447f97..d9fb377a52 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/11a564bce8..b26bae660a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fa82fd2fd9 * third_party/fuchsia-sdk/sdk: version:11.20221227.3.1..version:11.20221229.0.1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a3770c0663..522525fc09 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ic7189f3e847f705054fdb77d6fafa78e5a354731 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4128942 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 35d2fc30 2022-12-28T07:00:12 Roll Chromium from a12033d4d671 to c546b7bba9bc (228 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a12033d4d671..c546b7bba9bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4e331315b6..fe0a447f97 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/991e141f2b..11a564bce8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..816a551043 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0b96058844..03af44a516 * third_party/fuchsia-sdk/sdk: version:11.20221226.3.1..version:11.20221227.3.1 * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/4633bf4311..264c07d7e6 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I4ab4ff1759915e62fe2a0df82bf392538c54e896 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4126243 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov fe704fb5 2022-12-27T18:34:43 Crash end2end tests when loading driver library fails Switch from GTests's ASSERT_NE(), which allowed to continue execution and hid the error from Swarming, to ANGLE's ASSERT(), which makes bots to report this error. Bug: angleproject:7885 Change-Id: I7937a9419f3fbfd9f6ab2d696e40771bde763a1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4126355 Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 6a8cfc6c 2022-12-27T10:01:37 Roll vulkan-deps from 259eec71c7c6 to dae0d442679f (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/259eec71c7c6..dae0d442679f Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/68935bc2c6..d1fc064e79 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bea667d35c..ee3c27451e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I7572ad8bbbe1122a772532f5550bac87a954c045 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4125146 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 919241d6 2022-12-27T07:00:12 Roll Chromium from ab34c72be751 to a12033d4d671 (85 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ab34c72be751..a12033d4d671 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e3bb433e5e..4e331315b6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..27863274a2 * third_party/fuchsia-sdk/sdk: version:11.20221226.0.1..version:11.20221226.3.1 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I2c390e0873d00e05c03ed86af6968429da3167cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4125144 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 03b928db 2022-12-26T10:01:43 Roll vulkan-deps from 70e74a2f82ab to 259eec71c7c6 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/70e74a2f82ab..259eec71c7c6 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8c0817e7e2..bea667d35c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I44a7a66558cb7302fdec3837c5b6d7a4b5e63d7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4125163 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f9aeeaad 2022-12-26T08:28:50 Roll Chromium from 97df6f551756 to ab34c72be751 (292 revisions) https://chromium.googlesource.com/chromium/src.git/+log/97df6f551756..ab34c72be751 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ff6be8b34d..e3bb433e5e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5b6d378fee..991e141f2b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..27863274a2 * third_party/fuchsia-sdk/sdk: version:11.20221222.1.1..version:11.20221226.0.1 * third_party/r8: C6CmrPsLUOOdYOn7_lvtxbjl3ubLoJ-SBVIM2Ig4ALYC..uAjFIZ9i7MR0q1ZlcUKmq7qr9IS0Ypa2PwO0xPB8W1wC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I86830cff0bb16fcfebc99b3d5ffadb0a58b6904e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4125137 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 309269ce 2022-12-23T18:10:22 Fix ReadOnlyFeedbackLoopTestES31 not instantiated on iOS Bug: angleproject:7899 Change-Id: I0641574cae2f74315297df8eac0268ab5676dd3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4116926 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 8cbd7430 2022-12-23T10:01:17 Roll vulkan-deps from 3a028e4c1f4a to 70e74a2f82ab (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3a028e4c1f4a..70e74a2f82ab Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/dcae187376..68935bc2c6 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/077b09c32a..d87f61605b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a0a07df689..8c0817e7e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ic1c46d13cb310d7acdccfff59af7e1624a9ab2e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4123480 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8309ded9 2022-12-23T10:01:06 Roll SwiftShader from bcbc10b1bed4 to 5f9ed9b16931 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/bcbc10b1bed4..5f9ed9b16931 2022-12-23 sugoi@google.com Removing myself from the SwiftShader OWNERS file 2022-12-22 nicolas.capens@gmail.com Remove VK_LUNARG_direct_driver_loading from supported extensions 2022-12-22 nicolas.capens@gmail.com Support LLVM 16+ API change If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I2bb1bbd989497e7f17d7d510cc10736f2fa6b2de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4123518 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 65039487 2022-12-23T07:00:23 Roll Chromium from e376e31a56b1 to 97df6f551756 (274 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e376e31a56b1..97df6f551756 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8284db8978..ff6be8b34d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/df3cc8ecee..dc82f3042d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d29d7feee1..5b6d378fee * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ebbb83f192 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf31045b34..0b96058844 * third_party/fuchsia-sdk/sdk: version:11.20221222.0.1..version:11.20221222.1.1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/804e376f5b..a3770c0663 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ice6099eb79d903edfade5b650ea6db5dc7c15848 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4122347 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 6c41793f 2022-12-20T15:20:50 Vulkan: Use read/write depth/stencil layouts This allows an application to have depth in read-only feedback loop while stencil is being written to for example. Bug: angleproject:7899 Bug: b/192477489 Change-Id: Ic2e11d32da7c7e3a7f3cd86dbafc5c56a0dbbfd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4116730 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 067ace47 2022-12-21T00:00:00 Add ANGLE_clip_cull_distance extension Added an extension spec. Trivially exposed it on GL, Vulkan, and D3D11. Adjusted tests and validation to allow no cull distance support for this extension string. Removed extra built-in variable definitions. Bug: angleproject:7904 Change-Id: Ic60772dfe28132c316eaa29aadc1afd66e3b0fa7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4114290 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Charlie Lao 295f6830 2022-12-21T10:56:03 Vulkan: bufferRead should accommodate deferred endRenderPass ContextVk::onSyncObjectInit() will request end of current renderPass but deferred (in this case, mRenderPassCommandBuffer is nullptr but mRenderPassCommands->started() still returns true). The next draw call will actually end current renderPass and starts a new renderPass. But if next call is glCopyBufferSubData, it will not actually trigger endRenderPass. This CL modifies OutsideRenderPassCommandBufferHelper::bufferRead logic to accommodate this deferred endRenderPass scenario by checking mRenderPassCommands->started() instead of hasStartedRenderPass so that the answer to "if this buffer been used by current renderPass or not" will return correct result. Bug: angleproject:7903 Change-Id: Ie5c9977ccf083e7d355a2cd8fd08e9077049ee9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4119692 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 216cd10b 2022-12-22T11:29:35 Vulkan: Dsiable enableAsyncPipelineCacheCompression There was intermittent failure on bots due to this. Re-disable it for now. Bug: b/246683126 Change-Id: Iba5c0bcacb87336d187b952b47804885ce569f6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4120245 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Yuly Novikov a0b0ec00 2022-12-22T22:19:54 Disable building Mesa by default CQ build broken after crrev.com/c/4117820. Bug: angleproject:7689 Change-Id: Ib40ec5736011c0ae3df2a79a865247168b7bd077 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4123249 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Mohan Maiya cc34aa73 2022-12-19T14:03:27 Move BinaryStream to common and expose ShaderState to compiler This is a refactor change in preparation for adding support for glShaderBinary. Move BinaryStream to common so that it is accessible by both libANGLE and the Compiler. Extract members that hold the result of compilation from ShaderState and move into new CompiledShaderState struct. Move helper functions & classes relevant to ShaderVar serialization to the CompiledShaderState header. Tests: EGLBlobCacheTest* Bug: angleproject:7833 Change-Id: I7ec575247eccb3afbc6ab6bfa24d36e69d4576f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4080998 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll edd9a9a8 2022-12-22T17:16:32 Roll Chromium from fc4e0530422c to e376e31a56b1 (1084 revisions) Manually update flatbuffers per crrev.com/c/4120438 https://chromium.googlesource.com/chromium/src.git/+log/fc4e0530422c..e376e31a56b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8b3f1346a4..8284db8978 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/600a61514a..134af4c91b * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7b20455cbd..7c5e4b4eb3 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/123239cdb6..df3cc8ecee * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9f2ce02847..d29d7feee1 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e9f6c8927d..d12fb9a66f * third_party/android_build_tools/manifest_merger: X4l8RIBEAF108FpSEWRF7UHqq-kY8T3ibSsObGU5u3UC..lUT6vCuXPnPR-G-V3k69iMWuFtVOzwED-IwaHqYT4AcC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2863c8e12d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5decb17543..cf31045b34 * third_party/flatbuffers/src: https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/e301702964..b47ba1d5ff * third_party/fuchsia-sdk/sdk: version:11.20221219.3.1..version:11.20221222.0.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/73f40adc35..3fab077d8c * third_party/r8: vM6tt73p9rPzADct47R7euffv0M9LNSWw6zTyrPtGYgC..C6CmrPsLUOOdYOn7_lvtxbjl3ubLoJ-SBVIM2Ig4ALYC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cab032b11d..3b54a131a9 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/445fe7a42f..d1501ddb68 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b37c1e5869..804e376f5b No update to Clang. Bug: None Tbr: yuxinhu@google.com,ynovikov@google.com Change-Id: Ia1b6ccc06b81263f0f192547e8bfa5810f6914a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4122636 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 9bcb8f7d 2022-10-24T21:13:13 Tests: Add Grimvalor trace Test: angle_trace_tests --gtest_filter="*grimvalor*" Bug: angleproject:7787 Change-Id: I87768d0ca0fd97bc1239841dacdf6f7ae62e588d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3976065 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 7d8cbb60 2022-12-21T00:00:00 Fix typo in EXTClipCullDistanceForFragmentShaderTest Bug: angleproject:5747 Change-Id: I26baa29302472821706c0354ea855183608ebc5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4116721 Auto-Submit: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 645a3753 2022-12-22T10:01:48 Roll vulkan-deps from c4d6d0f52ce0 to 3a028e4c1f4a (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c4d6d0f52ce0..3a028e4c1f4a Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c5d2316430..077b09c32a * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c557a0035f..a0a07df689 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I1364ad1573a1d16b0189462c34e77a682bf57f06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4122393 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bed8383a 2022-12-22T03:32:03 Roll SwiftShader from 67f520305136 to bcbc10b1bed4 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/67f520305136..bcbc10b1bed4 2022-12-21 sugoi@google.com Direct driver loading 2022-12-21 swiftshader.regress@gmail.com Regres: Update test lists @ 8c1e83a1 2022-12-21 swiftshader.regress@gmail.com Regres: Update test lists @ f7de9e06 2022-12-20 sugoi@google.com Update Vulkan headers to version 1.3.238 2022-12-19 sugoi@google.com Reland "Float only writeColor" only If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com,sugoi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com,sugoi@google.com Change-Id: I3a70c64cf453ae339df898b481fd13f136fa1b12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4121510 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Shahbaz Youssefi 626b10c1 2022-12-20T20:22:19 Vulkan: Add read/write depth/stencil layouts This CL only adds the layouts in the list, but does not use them. The layouts are renamed for consistency in this change. Bug: angleproject:7899 Bug: b/192477489 Change-Id: I47986c7252d32626e9f26c6670c0a4e3496fe0c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4116736 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 301ed545 2022-12-20T20:16:22 Vulkan: Pass context to layout getters In preparation for a change that optionally uses read/write depth/stencil layouts. Context is used to test for the supportsMixedReadWriteDepthStencilLayouts feature to know whether those layouts are supported or that a fallback must be chosen. Bug: angleproject:7899 Bug: b/192477489 Change-Id: I1453dc9d060453a3806ad0f261b94368fe01fb29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4116735 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao d6dea33b 2022-12-19T13:39:34 Vulkan: Remove CommandQueue::mGarbageQueue With recent work of per active context queue serial, mGarbageQueue behaves almost identical to normal mSharedGarbage now. This CL removed mGarbageQueue and added garbage into Remove mSharedGarbage instead. Bug: b/263166501 Change-Id: I6bce47b4535283e7bd0f0c8823b9629cc25f9d94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4117712 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Cody Northrop e4935563 2022-12-20T23:34:26 Tests: Add Wayward Souls trace Test: angle_trace_tests --gtest_filter="*wayward_souls*" Bug: angleproject:7905 Change-Id: Ib7922df51411140f71481a0d5bdb4f54274b6f05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4117139 Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov 1e32988c 2022-12-21T15:53:15 Revert "Metal: expose Metal backend only on supported GPUs." This reverts commit 9364246f08d34a378252e517210b68e97282f764. Reason for revert: iOS build fails Original change's description: > Metal: expose Metal backend only on supported GPUs. > > Query all the GPUs on the system during ANGLE's initialization, and do > not expose the EGL_ANGLE_platform_angle_metal client extension unless > all of them support the required GPU families or feature sets. > > Tested locally on a 2015 MacBook Pro with dual Intel Iris Pro and AMD > Radeon R9 M370X GPUs. The AMD GPU supports Metal GPU family macOS 2, > but the Intel GPU, only family macOS 1. With this change, Chrome > properly falls back to using ANGLE's OpenGL backend when > --use-angle=metal is specified, and renders correctly. > > Bug: chromium:1365598 > Change-Id: I2c3533afe733e0d06d7755cae272bbd12aa9e676 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4117716 > Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> > Reviewed-by: Gregg Tavares <gman@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> Bug: chromium:1365598 Change-Id: Iedbe8978f2a2d39a33359fa236a1d305c284266e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4114291 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll d4fd26b3 2022-12-21T10:01:17 Roll vulkan-deps from 29e87c1e6ee6 to c4d6d0f52ce0 (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/29e87c1e6ee6..c4d6d0f52ce0 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/f9b760e6c7..dcae187376 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/cc81529f4b..c5d2316430 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/63637cb1c6..fc90b60663 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/96488e2b2e..bf28c824b8 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/081dc9e60f..c557a0035f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I9242160991c9c0a28e5d9b7df801dbd49373f909 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4119328 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu ebe97eb7 2022-12-20T17:07:21 Add new vulkan_core.h include headers to IGNORE list This is to resolve the presubmit failure in latest vulkan-deps roller: https://crrev.com/c/4115658. The latest vulkan-deps change https://github.com/KhronosGroup/Vulkan-Headers/commit/ 00671c64ba5c488ade22ad572a0ef81d5e64c803 has moved the header inclusion of below files to vulkan_core.h: vk_video/vulkan_video_codec_h264std.h vk_video/vulkan_video_codec_h264std_decode.h vk_video/vulkan_video_codec_h265std.h vk_video/vulkan_video_codec_h265std_decode.h But did not add them to the BUILD.gn file. The presubmit script export_targets.py is complaining about "Included file must be listed in the GN target or its public dependency." Add the above files to the IGNORED_INCLUDES list. Bug: b/263310519 Change-Id: I65cdb6f69fc95809232b9fd3b3ad77b716ad3329 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4119671 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Choi Sungyong 9ded03b4 2022-12-20T07:09:36 Revert "Vulkan: Make available GLInternalFormatToGbmFourCCFormat" This reverts commit 402e7f7a634b1170d0feae52a44168731a7489f9. Reason for revert: Chromium android-binary-size build failed. Original change's description: > Vulkan: Make available GLInternalFormatToGbmFourCCFormat > > GLInternalFormatToGbmFourCCFormat() is not available on Linux > because of the guard with the wrong definition, ANGLE_USES_GBM. > This also fixes build errors that were occurred after enabling. > > Bug: angleproject:7829 > Change-Id: If7c7543270cc127945149927be0fc3ffdd49163b > Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4022963 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Jeff Vigil <j.vigil@samsung.com> > Commit-Queue: mohan maiya <m.maiya@samsung.com> > Reviewed-by: mohan maiya <m.maiya@samsung.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7901 Bug: angleproject:7829 Change-Id: I256d51f78ff0d3ced9920c3ea1d2bfceba43a1ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4113577 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 9ddc3666 2022-12-20T20:15:58 Roll VK-GL-CTS from 9f4465eccb37 to 5aa5b0809f05 (17 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9f4465eccb37..5aa5b0809f05 2022-12-20 marcin.zajac@mobica.com Video tests plan for VK_KHR_video_queue 2022-12-19 amber@igalia.com Add tests for interpolateAtSample with GPL and null MSAA state. 2022-12-19 amber@igalia.com Add tests for dynamic patch control points and multiple pipelines. 2022-12-19 zzoon@igalia.com Set each dyanmic state to proper stage on a pipeline with graphics pipleline library enabled. 2022-12-19 cturner@igalia.com Skip implicit PrimitiveID checks on devices without geometry shader support 2022-12-19 aitor@lunarg.com Fix atomic tests' texture size 2022-12-19 zzoon@igalia.com Fix to enable the robustness extension. 2022-12-19 rgarcia@igalia.com Rename CTS "build" Python module to "ctsbuild" 2022-12-19 rgarcia@igalia.com Fix Android release build due to unused variable 2022-12-19 rgarcia@igalia.com Fix primitive fragment shading rate mesh feature requirements 2022-12-19 amber@igalia.com Add some extra boilerplate handling functions. 2022-12-19 cturner@igalia.com Adds missing coverage of buffer markers with non-zero memory offset 2022-12-19 rgarcia@igalia.com Test unused shader stages with graphics pipeline libraries 2022-12-19 ewerness@nvidia.com Some refactorings to improve wildcard performance on debug CTS builds 2022-12-19 ziga@lunarg.com Fix enabling robustBufferAccess in robust buffer write tests 2022-12-19 ziga@lunarg.com Fix promoted feature structures tests 2022-12-19 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I8909a8550eb8a7288bb2e234870b10d98a9f16d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4118563 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Choi Sungyong b20abb57 2022-12-20T07:09:12 Revert "Fix defines redifintion in angle_common." This reverts commit 9fb8ff63e1593dc5553d8f3015ff2d7420c8140d. Reason for revert: Chromium android-binary-size build failed. Original change's description: > Fix defines redifintion in angle_common. > > Breaks in android rolls where we have both > angle_expose_non_conformant_extensions_and_versions > and > angle_enable_vulkan > > Bug: angleproject:7829 > Change-Id: Iaa163b34e01a31a6872f1158064f685ca6fec958 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4111968 > Reviewed-by: mohan maiya <m.maiya@samsung.com> > Commit-Queue: Roman Lavrov <romanl@google.com> Bug: angleproject:7901 Bug: angleproject:7829 Change-Id: Ic431a61403b57d195ace3cc07df756a277f6efdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4113576 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: mohan maiya <m.maiya@samsung.com>
Kenneth Russell 9364246f 2022-12-19T16:28:44 Metal: expose Metal backend only on supported GPUs. Query all the GPUs on the system during ANGLE's initialization, and do not expose the EGL_ANGLE_platform_angle_metal client extension unless all of them support the required GPU families or feature sets. Tested locally on a 2015 MacBook Pro with dual Intel Iris Pro and AMD Radeon R9 M370X GPUs. The AMD GPU supports Metal GPU family macOS 2, but the Intel GPU, only family macOS 1. With this change, Chrome properly falls back to using ANGLE's OpenGL backend when --use-angle=metal is specified, and renders correctly. Bug: chromium:1365598 Change-Id: I2c3533afe733e0d06d7755cae272bbd12aa9e676 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4117716 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Gregg Tavares <gman@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Choi Sungyong 7466be3c 2022-12-20T07:07:58 Revert "Fix link error with dma_buf_util_sources" This reverts commit e265b318d9fb987b81ca6d3c7cbaf50049f133a1. Reason for revert: Chromium android-binary-size build failed. Original change's description: > Fix link error with dma_buf_util_sources > > Currently, dma_buf_util_sources is only accessible > from the vulkan backend. Fixed this because gl backend > also uses this. > > Bug: angleproject:7829 > Change-Id: I1bd71c191d1a8ae633083d1626d41c58fb6d269b > Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4113745 > Reviewed-by: mohan maiya <m.maiya@samsung.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Commit-Queue: mohan maiya <m.maiya@samsung.com> Bug: angleproject:7901 Bug: angleproject:7829 Change-Id: Ib48ffb0be876c5fe342d578fde1ee63d90e3b132 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4113575 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6bafc5ea 2022-12-20T07:00:18 Roll Chromium from a4da97db4f55 to fc4e0530422c (452 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a4da97db4f55..fc4e0530422c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/09b1b54928..8b3f1346a4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b24fadc5e5..9f2ce02847 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1e43416292 * third_party/fuchsia-sdk/sdk: version:11.20221219.0.1..version:11.20221219.3.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/2d76dcab7a..73f40adc35 * third_party/r8: tfZf7nJNxfwW0aOGBbX1eUmDfQCc4Mdg7XcfzQBiHS8C..vM6tt73p9rPzADct47R7euffv0M9LNSWw6zTyrPtGYgC * third_party/turbine: R-Qp1tMBqIuETMfXNqQU9GB00ij6dsPjVmjDuvH_194C..6qP1McD5frsv2QklnzCMFruX8BO9asL49lv_ohhd2DkC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7356f69af6..cab032b11d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5490be1ce4..b37c1e5869 Clang version changed llvmorg-16-init-12251-g87d0ff91:llvmorg-16-init-14635-ga650f2ec Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/7356f69af6c8ebe933ddc542fd7e27748ee66f3d..cab032b11ddc12804bf4ae8d71a6e0f88bc51ddb/scripts/update.py Bug: None Tbr: yuxinhu@google.com Change-Id: If6b26c8a145c1609a20c0364b736e57cc04f8602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4117820 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 91a5635a 2022-12-16T00:00:00 Support arbitrary clip and cull distance array sizes Removed limitSimultaneousClipAndCullDistanceUsage cap. Enhanced HLSL translator to support all valid combinations of clip and cull distances. Validate that these arrays are sized explicitly or by using only constant indices; adjusted link program error message. Enhanced tests to cover all possible combinations of implicit and explicit array sizes for both built-ins. Bug: angleproject:4452 Change-Id: I704db6dc3c8951e5ba482a3e4dad09e5b0182f9c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4111645 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 28e7adca 2022-12-09T00:00:00 GL: Implement clip distance state emulation Pass the current set of enabled clip distances to vertex shaders via an internal uniform and dynamically set disabled elements to zero. Bug: angleproject:7880 Change-Id: I709d31dc7ca0606decf49adf674460a941837683 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4094314 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 8668cac1 2022-12-17T20:24:13 Tests: Add My Friend Pedro trace Test: angle_trace_tests --gtest_filter="*my_friend_pedro*" Bug: angleproject:7898 Change-Id: Iae0427ac714704214dec292199cd1c5d2097b17f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4114830 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 88e94b20 2022-12-19T12:20:51 Skip Flaky Timeout InstancingTestES3.LargeDivisor on Windows Swangle Bug: angleproject:7900 Change-Id: Ic5522b54b53e3e2eca664a0b7050de0e586e7a51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4117133 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Shahbaz Youssefi b7ec9d03 2022-12-19T12:53:16 Vulkan: Create RenderPass2 by default Previously, ANGLE created core Vulkan 1.0 render passes by default and converted them to render pass 2 objects if necessary. However: - More and more extensions used by ANGLE require this functionality, - Upcoming use of VK_KHR_separate_depth_stencil_layouts makes this path almost always taken. It's time for ANGLE to default to render pass 2 objects instead, especially as support for it is becoming practically ubiquitous. Bug: angleproject:7899 Bug: b/192477489 Change-Id: I6970a017040a2fdc001d4f2e53c1a0d5968a37cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4116675 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi b227cf2f 2022-12-19T12:43:37 Make pending memory allocation type atomic * This is to prevent TSAN failures due to data race in setPendingMemoryAlloc(). Bug: b/262029018 Change-Id: I5f2f13ecbe762102692bb910a5baa5b25fa42abe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4115479 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Cody Northrop d53ba51f 2022-12-17T16:31:31 Tests: Add Disney Mirrorverse trace Test: angle_trace_tests --gtest_filter="*disney_mirrorverse*" Bug: angleproject:7897 Change-Id: I1b49c253e606f08c5af80f8f9b60b8948a0d5121 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4114829 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi abcbd54c 2022-12-19T14:38:49 GLES1: Optimize texcoord varyings Use vec3 instead of vec4. Either 2 or 3 components are used based on 2D or cube map textures. On hardware that can pack the varyings, this can reduce pressure on varyings. Additionally, this is a minor optimization to texture coord calculation (when !draw_texture) as one row of the 4x4 matrix multiplication doesn't need calculation. Bug: angleproject:6644 Change-Id: I2abac511a0ced575c089dfb3a3b506f51a111a54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4116676 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 91d6c3e6 2022-12-05T17:12:49 GLES1: Reduce pressure on vertex input / varyings Typically, not all texture units are used. This change ensures no vertex input / varying is consumed when fewer than maximum textures are used. Bug: angleproject:6644 Change-Id: Iea0e35dc12ec4fcb342818786f307286bf7fc5bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4081116 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi cd540095 2022-12-12T13:13:14 Vulkan: Add memory log at allocation error * Added logging memory allocation information in handleError() in the event of an error from ANGLE_VK_TRY. * Used for the handleError() in ContextVk. * Updated the name and message of the function to log allocations. * checkForCurrentMemoryAllocations() * Added logging memory heap stats, including budget and usage. * logMemoryHeapStats() * In the renderer, added the feature flag indicating whether the platform supports the memory budget extension. * Uses VK_EXT_memory_budget. * Added the enum class MemoryLogSeverity, which is used to select the severity level of the memory log. * Added logging pending memory allocation information. * logPendingMemoryAllocation() * If the last unsuccessful memory allocation was unsuccessful, its information will be added to the log. Bug: b/262029018 Change-Id: I97343c1553936aed23d763f3e0c00d495f9ee810 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4089531 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Kaiyi Li <kaiyili@google.com>
Mohan Maiya 6769ef2b 2022-12-16T15:34:21 Vulkan: Bug fix in setupIndexedDraw Reset ContextVk::mCurrentIndexBufferOffset to 0 after a call to ContextVk::convertIndexBufferCPU(...) irrespective of whether the buffer binding is dirty. Bug: angleproject:7896 Test: DrawElementsTest.DrawElementsWithDifferentIndexBufferOffsets* Change-Id: I70a63b7e432aaa9f8c647e56bd162312143abd65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4113446 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi ea36cf1c 2022-12-19T09:55:45 Vulkan: Feature for VK_EXT_rasterization_order_attachment_access This change just adds the feature. A follow up change will actually start using the extension. Bug: angleproject:7899 Bug: b/192477489 Change-Id: I19c078ebe57a7819b3aa3e95d4436cefa34ba85b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4113912 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 5c8c0347 2022-12-15T15:46:38 Vulkan: Remove ContextVk::retainResource and retainImage() Clean up some retain* APIs. retainImge and retainReadOnlyResource and retainResource are doing exact same thing, they are consolidated into just retainResource. ContextVk::retainResource is removed since mUse can now safely copied from DescriptorSetHelperPool object which tracks mUse. Bug: b/262047600 Change-Id: I56ea08696e870826bd94ccb79dd621f35923bc6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4114500 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Sungyong Choi e265b318 2022-12-19T00:19:59 Fix link error with dma_buf_util_sources Currently, dma_buf_util_sources is only accessible from the vulkan backend. Fixed this because gl backend also uses this. Bug: angleproject:7829 Change-Id: I1bd71c191d1a8ae633083d1626d41c58fb6d269b Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4113745 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi 1a8bcbda 2022-12-17T20:12:41 Vulkan: Re-enable async pipeline cache sync by default This is a reland of c7414946b84410bfcc8705759a902577c13d9fc4 The change here is that the program, shader and blob caches are now reset _after_ the backend is torn down. Otherwise the pipeline cache sync thread's use of the caches races with that. Bug: b/246683126 Change-Id: Ifc3d67279de50a2ee2866476aa5df85d4c10d30d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4111972 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 376d309c 2022-12-15T09:43:00 Vulkan: Remove unnecessary usesBuffer() check There are places that we call setQueueSerial after usesBuffer() check. This was useful when we had the ResourceList where it is more expensive to set serial. But now setQueueSerial is cheap (actually is cheaper than usesBuffer check), so there is no need to do this check any more. This CL removes the check to further reduce the CPU overhead. Because of this, mUsedBufferCount will not be accurate, so this CL also removes the tracking of mUsedBufferCount (was only for informational purpose anyway). This CL also removes commandBufferQueueSerial.valid() check in Resource::usedByCommandBuffer() and turns it into assertion. Some places in contextVk will ensure we only call it on started renderpass so that other places that calls usedByCommandBuffer will not need to eat the if check. Bug: b/262047600 Change-Id: I6b8004b6aa5b567fa94c0eb56801054f818838b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4112145 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0