|
6cd08bc2
|
2022-06-28T22:04:07
|
|
Vulkan: Don't optimize away flush after clear for single buffer
Bug: b/237449314
Change-Id: I04421398e2e68541d4713c7e8b80715be68672b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3733808
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: mohan maiya <m.maiya@samsung.com>
|
|
ac1af388
|
2022-06-23T14:08:50
|
|
Add presubmit check for .gclient file
Bug: angleproject:4905
Change-Id: I6dbb81ed2d2e102869e5d844fed1bb4c1ef4f449
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720557
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
|
|
2d5defc7
|
2022-06-30T17:30:07
|
|
Roll vulkan-deps from 1fe7a0ab555e to 863435cf0898 (7 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/1fe7a0ab555e..863435cf0898
Changed dependencies:
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/ba3e6ffe03..e6925974d1
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/76fe352190..37d2396cab
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/6f57b1fa23..25b838f3a2
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d81e034d0f..e32ec7b051
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com,ynovikov@google.com
Change-Id: Ia7d491733890d8eefeef6d533877f609f0c22fe5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3738639
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
90edbd94
|
2022-06-30T11:49:33
|
|
Metal: Support GL_ANGLE_provoking_vertex
This allows some users to get improved performance while using flat
attributes by avoiding index buffer rewrites.
Bug: chromium:1340620
Change-Id: Ic55dec27e51d8929d6781758104632defc6861c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3738260
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Auto-Submit: Geoff Lang <geofflang@chromium.org>
|
|
c66e1652
|
2022-06-29T21:47:03
|
|
Roll vulkan-deps from 470172656108 to 1fe7a0ab555e (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/470172656108..1fe7a0ab555e
Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6ba32ffc01..d81e034d0f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com,ynovikov@google.com
Change-Id: I767ec40404e08cedefd44cb8dd851635af3f4c0a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3736692
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
1e96beb9
|
2022-06-29T15:18:35
|
|
Suppress the new BestPractice VVL Error
Suppress the new best practice VVL Error
vkCmdBeginRenderPass-ClearValueWithoutLoadOpClear
to unblock the vulken-deps roller. A potential fix
is work in progress.
Bug: angleproject:7470
Bug: b/237542876
Change-Id: Iaea0cef58984acae79210e72b75be527d98e8286
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3736698
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
c7fe4348
|
2022-06-30T10:01:56
|
|
Roll SwiftShader from ec31f547750c to 90fdde382489 (6 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/ec31f547750c..90fdde382489
2022-06-29 capn@google.com Support printing of SIMD types
2022-06-29 capn@google.com Implement lane-independent SIMD operations
2022-06-29 capn@google.com Refactor scalarized vector processing
2022-06-29 capn@google.com Wrap shuffle and constant construction values
2022-06-29 nicolas.capens@gmail.com Implement minimal SIMD::Int functionality
2022-06-29 srisser@google.com Support VK_SUBGROUP_FEATURE_QUAD_BIT
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: I7918b35a9423f4c3ca5920408cef23f70aaa6501
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3737626
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
551a26ae
|
2022-06-10T17:55:54
|
|
Reland "Vulkan: Destroy DescriptorSet cache when it becomes invalid"
This is a reland of commit 0779ccbcd427dcb00e53afa6385fb4e8e2377993 with
the fix for angleproject:7466. When DescriptorPoolhelper gets
release/destroyed, we ensure all sharedCacheKeys are destroyed.
Original change's description:
> Vulkan: Destroy DescriptorSet cache when it becomes invalid
>
> When a new texture descriptorSet is allocated, we store one reference of
> the cache key in ProgramExecutableVk and all TextureVks that it
> associated with. When any of the TextureVk is destroyed or its view
> destroyed, we immediately erase the descriptorSet from the cache and
> track GPU progress and free the descriptorSet when it's GPU completed.
> That way we delete the dead descriptorSet that will for sure never been
> reused ASAP so that its space is avialable for reuse.
>
> Bug: b/235523746
> Change-Id: Ib1b9662a254eea5a3f410dc6d5d89fca6727a647
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700226
> Reviewed-by: Lingfeng Yang <lfy@google.com>
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Ian Elliott <ianelliott@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: b/235523746
Bug: angleproject:7466
Change-Id: I4413bec27ea0ca830010e2ca15036c2e667141c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726964
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
4884e9de
|
2022-05-15T22:57:57
|
|
Add a pls test for maximum capacity
Check that it works to render with the maximum supported data payload:
GL_MAX_LOCAL_STORAGE_PLANES_ANGLE
GL_MAX_LOCAL_STORAGE_BYTES_ANGLE
GL_MAX_FRAGMENT_OUTPUTS_WITH_LOCAL_STORAGE_ANGLE
Bug: angleproject:7279
Change-Id: Ifdaff726edee0378b06ce5562001ad3dfe29284b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654974
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Chris Dalton <chris@rive.app>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
785353fd
|
2022-05-24T12:40:16
|
|
Support Desktop OpenGL context creation in end2end tests
Validation of Desktop GL versions and profile masks is unimplemented.
Bug: angleproject:7360
Change-Id: Ifae94215b6aada895c2b02318a1d05c9515e9b96
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3664916
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
61bcba89
|
2022-06-29T15:00:03
|
|
Roll vulkan-deps from 20ef3c4c476b to 470172656108 (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/20ef3c4c476b..470172656108
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/bffcf209cb..b2d2c9dd3d
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/1f92bbb656..865626abba
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/da369877f9..6ba32ffc01
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com,ynovikov@google.com
Change-Id: I2eb3808e264b7f87a973a63cebd8c89828a9496e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3735722
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
45def3d4
|
2022-06-15T13:49:08
|
|
Remove non-negative offsets restriction in D3D extension
The EGL_ANGLE_d3d_texture_client_buffer extension currently
fails if either EGL_TEXTURE_OFFSET_[X|Y]_ANGLE offsets are
negative. This restriction is unnecessary, as D3D allows
for negative offsets.
Bug: angleproject:7446
Change-Id: I2e258a3a558eae51794f6533e28a0c06532f156d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715956
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
4298a54e
|
2022-06-23T23:17:12
|
|
Clean up OWNERS files
Bug: None
Change-Id: I93726b8e5226d4c3b40c7d3dc865cb7dbe7c17fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3721567
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
fd9301c1
|
2022-06-17T12:25:10
|
|
Capture/Replay: Capture egl surface related calls
Creation from a pbuffer and generalized destruction are
implemented, as well as binding and releasing a TexImage
and making the context current with explicit draw and
read surfaces given.
Bug: angleproject:4964
Bug: angleproject:6180
Bug: angleproject:6512
Change-Id: Id8be6486125d45341905f3aabdbae4366cd568b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711741
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
1fcfe3bb
|
2022-06-29T12:45:03
|
|
Roll vulkan-deps from 137b026580e5 to 20ef3c4c476b (5 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/137b026580e5..20ef3c4c476b
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2eff41e707..76fe352190
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/477fb9e188..1f92bbb656
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a0e0e77a22..da369877f9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com,ynovikov@google.com
Change-Id: I182c7768045635949d9e557ee0fe582fca3b12ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3733901
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
3224b16a
|
2022-06-29T07:30:00
|
|
Roll Chromium from 1bfae54dd233 to 8bf3474ad33a (639 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/1bfae54dd233..8bf3474ad33a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/4e6d71ddc1..5b369fe7f5
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b5f3d3b904..3007992fc7
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/4e9a37120c..7663e0cfff
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c76626ec30
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2f3c96d5e4..a83ac9395c
* third_party/fuchsia-sdk/sdk: version:8.20220627.1.1..version:8.20220627.3.1
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/086948bae5..c8f1e5e5b7
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a1724fdef3..e7effce34f
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0ee7593147..7c096990d7
No update to Clang.
Bug: None
Tbr: ianelliott@google.com
Change-Id: I2aa37a72de18ffc95630a6656ad98fbb037983ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3733893
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
d50b2276
|
2022-06-21T12:05:28
|
|
Reland "Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh"
This is a reland of commit ef60d38ecf12d6663e9ecccacbff9803b1fba7c6
There are no fixes as the revert itself was a speculative one
Original change's description:
> Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh
>
> Cache value of EGL_FRONT_BUFFER_AUTO_REFRESH_ANDROID attribute
> and set swapchain present mode accordingly when recreating
> swapchain in single buffer mode.
>
> Bug: angleproject:7224
> Tests: EGLAndroidAutoRefreshTest.Basic*
> Change-Id: I2dbb92ce5c3fa047e0b02ea9011725311f346027
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707570
> Reviewed-by: Ian Elliott <ianelliott@google.com>
> Commit-Queue: mohan maiya <m.maiya@samsung.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Bug: angleproject:7224
Bug: angleproject:7465
Change-Id: Ia876ea17169c0f1b3afdb7753570e0b1aca985f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3733521
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
fd256b0d
|
2022-06-24T09:58:22
|
|
Tests: Add Uber trace
Test: angle_perftests --gtest_filter="*uber*"
Bug: angleproject:7462
Change-Id: Ie9a6f4c8afbb94e8484dba50b90bfbc7102a3c00
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3723859
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
ba737f47
|
2022-06-27T11:04:21
|
|
Vulkan: Don't sync pipeline cache if warm up is effective
If the pipeline cache is being warmed up at link time, the blobs
corresponding to each program is individually retrieved and stored in
the blob cache. This should be enabled only on platforms where draw
time pipeline creation hits the cache due to said warm up. As a result,
there's no need to store the aggregate cache (the one owned by
RendererVk) in the blob cache too.
Bug: angleproject:5881
Bug: b/215230983
Change-Id: I2da5de835e6667b0b2d5859e6804791671888947
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3727227
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
bb373176
|
2022-06-24T14:19:05
|
|
Roll vulkan-deps from 11ad77222bfe to 137b026580e5 (1 revision)
Suppress new SYNC-HAZARD-READ_AFTER_WRITE.
https://chromium.googlesource.com/vulkan-deps.git/+log/11ad77222bfe..137b026580e5
Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/620b378993..a0e0e77a22
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:7456
Tbr: jonahr@google.com,ynovikov@google.com
Change-Id: I2ef42cccfabd575cd59c90e6f558b6a46202e028
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3723547
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
b2683a3c
|
2022-06-28T11:30:50
|
|
Document angle_restricted_traces
Bug: angleproject:7410
Change-Id: Iab02ca68d76fdd1d04804c85f76f5c251905907b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3732229
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
26a314b4
|
2022-06-21T00:00:00
|
|
Fix typos in multi-draw extension specs
Bug: angleproject:1944
Change-Id: I21d63bab1054c99c55e5836ac08c4cf32dbe79d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3716582
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
1dc3385a
|
2022-06-27T18:13:33
|
|
libstdc++: move FramebufferHelper to cache utils
vk_helper.h includes vk_cache_utils.h. FramebufferHelper was declared
in vk_helper.h. And FramebufferCache, in vk_cache_utils.h, requires
FramebufferHelper for its payload hashmap.
This was solved with a forward declaration. But, with std::pair
definition in libstdc++ this is not enough.
Bug: chromium:957519
Change-Id: I32e3e247c3c8bef8b52806aa2601e4012e6aa79e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3727671
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
3a799ba5
|
2022-05-16T17:26:38
|
|
Fix ValidateES3TexImageParametersBase for glTexImage*D
From the OpenGL ES 3.2 spec: GL_INVALID_VALUE error is generated
if internalformat is not one of the valid formats in tables 8.2 or 8.3.
glTexImage*D should not accept compressed format.
Add check in validation to account for this.
Bug: angleproject:6441
Tests: KHR-GLES31.core.compressed_format.api.invalid_teximage_with_compressed_format
Change-Id: I7152aefa433f42dcc40cf693538639df26c31341
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3648587
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
ce4e11d3
|
2022-06-17T12:21:01
|
|
libANGLE: Add a unique ID to the Surface
This is needed when capturing Pbuffer calls.
Bug: angleproject:4964
Change-Id: Id9f35683bf887f08f916de69bbab8c414e5e8872
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711740
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
2a5193f6
|
2022-06-22T17:46:15
|
|
Textures: Allow compressed texture from PBO
Apex Legends is using a pixel unpack buffer to populate a
compressed 3D texture. We had an explicit check in validation
that prevented it, possibly due to emulated formats.
Rather than prevent it altogether, check whether the format
is emulated and proceed if not.
Also add a test that exposes the problem.
Test: PBOCompressedTexture3DTest
Bug: b/236478448
Bug: angleproject:7464
Change-Id: I90105a396bf0a465c62d67910aad2819ba7f8831
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719161
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
1ae9756e
|
2022-06-22T17:43:15
|
|
Textures: Centralize texture format emulation check
Refactor in order to use the check in multiple places.
Bug: b/236478448
Change-Id: I6df2e0d63c60fa3e8b2d65185fce164be0e7d961
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719160
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
c775dd49
|
2022-02-03T16:51:03
|
|
Allow list of restricted traces to be overriden in gn args
When focused on profiling a single or a few traces, this speeds up build
and upload to Android.
Bug: angleproject:7404
Change-Id: I5234a6fa7e8167f86b5b33b8db526662a7d65bd9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3438425
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
1c825621
|
2022-06-27T19:01:13
|
|
Roll Chromium from 8fdbb85c2176 to 1bfae54dd233 (738 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/8fdbb85c2176..1bfae54dd233
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/2c9721f023..4e6d71ddc1
* buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/b387062642..49191c55bb
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f877072307..4e9a37120c
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/7c2caaa0f4..8b6bc96d32
* third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/70efa78e78..29db1c9bf3
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..17a97abb47
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9a9c40738..2f3c96d5e4
* third_party/fuchsia-sdk/sdk: version:8.20220624.0.1..version:8.20220627.1.1
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/333646c3c0..086948bae5
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/86c4290c3b..a1724fdef3
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/37843dd9a3..0ee7593147
No update to Clang.
Bug: None
Tbr: ianelliott@google.com,ynovikov@google.com
Change-Id: Ideca023b11ec49bcd244ace5f1b9d46d2dcfd1fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726960
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
2adb6327
|
2022-05-13T23:09:31
|
|
Add a pls test for memoryless storage
Bug: angleproject:7279
Change-Id: I4a992d04efa06ac99472d5334a1ac50839a13d06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654973
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Chris Dalton <chris@rive.app>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
f8690429
|
2022-06-27T13:50:44
|
|
Revert "Vulkan: Destroy DescriptorSet cache when it becomes invalid"
This reverts commit 0779ccbcd427dcb00e53afa6385fb4e8e2377993.
Reason for revert: crashes in blink_web_tests on linux-rel
https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1051045/overview
Original change's description:
> Vulkan: Destroy DescriptorSet cache when it becomes invalid
>
> When a new texture descriptorSet is allocated, we store one reference of
> the cache key in ProgramExecutableVk and all TextureVks that it
> associated with. When any of the TextureVk is destroyed or its view
> destroyed, we immediately erase the descriptorSet from the cache and
> track GPU progress and free the descriptorSet when it's GPU completed.
> That way we delete the dead descriptorSet that will for sure never been
> reused ASAP so that its space is avialable for reuse.
>
> Bug: b/235523746
> Change-Id: Ib1b9662a254eea5a3f410dc6d5d89fca6727a647
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700226
> Reviewed-by: Lingfeng Yang <lfy@google.com>
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Ian Elliott <ianelliott@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: b/235523746, angleproject:7466
Change-Id: I7e5067de2f2add08af1f9804cc2e952238b2e942
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726097
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
f5aef011
|
2022-06-27T13:11:16
|
|
Skip CreateFramebufferFetchMidRenderPass on Win SwANGLE
Bug: angleproject:7419
Change-Id: I76b4d08f985abbd482ef1d14cde62bcd5bb41a86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726096
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
|
|
46ddcc44
|
2022-06-27T14:53:31
|
|
Revert "Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh"
This reverts commit ef60d38ecf12d6663e9ecccacbff9803b1fba7c6.
Reason for revert: crashes in end2end tests on Win Intel Vulkan
Original change's description:
> Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh
>
> Cache value of EGL_FRONT_BUFFER_AUTO_REFRESH_ANDROID attribute
> and set swapchain present mode accordingly when recreating
> swapchain in single buffer mode.
>
> Bug: angleproject:7224
> Tests: EGLAndroidAutoRefreshTest.Basic*
> Change-Id: I2dbb92ce5c3fa047e0b02ea9011725311f346027
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707570
> Reviewed-by: Ian Elliott <ianelliott@google.com>
> Commit-Queue: mohan maiya <m.maiya@samsung.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Bug: angleproject:7224, angleproject:7465
Change-Id: Ia48a31124c8e0a3e4bcd4b7dc6f62b0782b42d97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726099
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
10f065e2
|
2022-06-23T13:23:09
|
|
Vulkan: support QCOM_shading_rate on Intel graphics
When querying fragment shading rates, we were limiting the result array
to 6 elements, which was not enough on Intel's Windows graphics drivers.
Those drivers report more than 6 fragment shading rates, including
a bunch of strange ones like 4x1 and 1x4.
Because we limited the list to 6 elements, and the Vulkan specification
requires that the rates be listed in order from largest width to
smallest, the feature check was missing the smaller shading rates
(including 1x2 and 1x1). This caused the supportsFragmentShadingRate
feature to be disabled.
Bug: angleproject:7461
Bug: angleproject:7172
Change-Id: I1b9a2924f93fdb803c20cfa388749754691b6e92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720732
Auto-Submit: Steven Noonan <steven@valvesoftware.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: mohan maiya <m.maiya@samsung.com>
|
|
8f6889a1
|
2022-06-24T13:53:39
|
|
Roll Chromium from 7f32e27c6969 to 8fdbb85c2176 (321 revisions)
Manually added third_party/android_lint dependency.
https://chromium.googlesource.com/chromium/src.git/+log/7f32e27c6969..8fdbb85c2176
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/4dbf5904da..2c9721f023
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/044213afe8..f877072307
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f6dcfa4c72
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1d5d7803fa..d9a9c40738
* third_party/fuchsia-sdk/sdk: version:8.20220623.1.1..version:8.20220624.0.1
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/25de876ad0..86c4290c3b
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/eacae1e7ec..37843dd9a3
No update to Clang.
Bug: chromium:1273512
Tbr: jonahr@google.com,ynovikov@google.com
Change-Id: I4313a93cd35d7317803e0446bdddc7c5afa1a317
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3723546
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
ef37e863
|
2022-06-27T11:18:49
|
|
Skip TextureSampleShadingTest.Basic on Win Intel Vulkan
Bug: angleproject:7465
Change-Id: If1eff8d5f9ad9c159115c5a8ef7f4155c21e9615
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726090
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
89e38b57
|
2022-06-22T15:04:08
|
|
Refactor to use ANGLETest vs ANGLETestWithParam
Bug: angleproject:6747
Change-Id: I72ad52d0268eae0e1a401f12f3e94cc5efa402f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719002
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
de109f9e
|
2022-06-23T11:50:43
|
|
Metal: Maintain BufferPool freelist constraint
BufferPool needs to maintain the requirement of the free list that
buffers in use by the GPU are stored in FIFO order and that after the
first in-use buffer, the rest of the free list is in-use as well.
Bug: angleproject:7453
Change-Id: Ibae45fb0212030217d03fe4623c412d693674fd1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3717663
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
707323c1
|
2022-06-21T18:53:05
|
|
Miscellaneous C++17 refactoring
Bug: angleproject:6747
Change-Id: I792ba74e03145ff6c3cc97d4bff6327ab275a2c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719001
Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
ef60d38e
|
2022-06-21T12:05:28
|
|
Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh
Cache value of EGL_FRONT_BUFFER_AUTO_REFRESH_ANDROID attribute
and set swapchain present mode accordingly when recreating
swapchain in single buffer mode.
Bug: angleproject:7224
Tests: EGLAndroidAutoRefreshTest.Basic*
Change-Id: I2dbb92ce5c3fa047e0b02ea9011725311f346027
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707570
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
|
|
7eb96f2a
|
2022-06-21T18:46:18
|
|
Refactor builtin symbol generation for C++17
Bug: angleproject:6747
Change-Id: I81a87b68298abc32fee7bb843c27a4a1b6009c87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719000
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
4c5e9d47
|
2022-06-21T17:12:56
|
|
Do not defer clear if FBO attachment is AHB image
When application uses Android Hardware Buffer (AHB)
image as the Framebuffer Object (FBO) attachment,
it is possible the app doesn't call glReadPixels
to fetch the FBO color. In this case deferred clears
will not be flushed when the app reads the FBO pixel
color, and the app will read the old FBO color.
This CL fixes the issue by flushing the glClear calls
immediately when any of the FBO color attachments is
AHB image.
Bug: b/236394768
Bug: angleproject:7458
Change-Id: I9151ab57750007c4ac18af39c3fa4abe752ede5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715851
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
d3e4e9ee
|
2022-06-23T15:19:05
|
|
Roll vulkan-deps from 1765af41ecf5 to 11ad77222bfe (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/1765af41ecf5..11ad77222bfe
Changed dependencies:
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/99b59b3528..ba3e6ffe03
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9342a262d9..620b378993
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jonahr@google.com,ynovikov@google.com
Change-Id: Ifc00313898ec1cfd54fe59ecedb8025e8a000db4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720548
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
722c78b0
|
2022-06-23T19:16:59
|
|
Roll Chromium from 19706bf6c7d2 to 7f32e27c6969 (707 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/19706bf6c7d2..7f32e27c6969
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3a562c9e07..4dbf5904da
* buildtools/linux64: git_revision:ae474cc51337c3fe823f936371c5e92891e86b48..git_revision:29accf5ac2eadfc53e687081583b7bc1592a8839
* buildtools/mac: git_revision:ae474cc51337c3fe823f936371c5e92891e86b48..git_revision:29accf5ac2eadfc53e687081583b7bc1592a8839
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/92ef8d47d0..b5f3d3b904
* buildtools/win: git_revision:ae474cc51337c3fe823f936371c5e92891e86b48..git_revision:29accf5ac2eadfc53e687081583b7bc1592a8839
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/d4d70a4321..044213afe8
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/00f782bd3d..62a4d6866a
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d44f2956da
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/39e4055004..1d5d7803fa
* third_party/fuchsia-sdk/sdk: version:8.20220614.2.1..version:8.20220623.1.1
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/6fba7268ea..35de724cf2
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f575df1ded..333646c3c0
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1122520fc4..25de876ad0
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2f10365a2a..eacae1e7ec
Clang version changed llvmorg-15-init-13850-ge2913362:llvmorg-15-init-14188-g4dcb42fa
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/f575df1ded2c30161bca2ff5f90c1e0d6814625f..333646c3c0d7f0332f3d9ebd0bdf4081999f8b77/scripts/update.py
Bug: angleproject:7455
Tbr: jonahr@google.com,ynovikov@google.com
Change-Id: I132a7abada2e301a8e441c47a577650bd3852809
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720553
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
79185677
|
2022-06-22T16:22:35
|
|
Translator: Fix validation of struct with same-name struct field
In the following:
```
struct S
{
S s;
};
```
The `S` in the field refers to a previous declaration of `S` in an outer
scope. The validation code mistakenly attempted to ensure it refers to
the same `S` being declared.
Bug: chromium:1337628
Change-Id: I86184be63bc59e608fe5b24369cd4c40b3bb3b31
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3716965
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e50351cb
|
2022-06-10T22:28:58
|
|
Vulkan: Don't close render pass on framebuffer fetch
For applications that use framebuffer fetch in the same RP as
non-fetch programs, we can save some extra RenderPasses by always
creating our RP objects with input attachments enabled. This works
almost identically except for needing to use the images in a
"GENERAL" layout instead of "COLOR_ATTACHMENT_OPTIMAL". According
to partners it is possible to achieve performance parity even with
GENERAL layout.
To remove any potential negative impacts of using the GENERAL layout,
the context enters this always-framebuffer-fetch mode only and as soon
as a framebuffer fetch program is created. Applications that don't use
framebuffer fetch are thus unaffected.
This eliminates 20 render passes in the Genshin Impact trace (out of
about 58). On a Pixel 6 the resulting benchmark score speeds up by
~25%. For Real Racing 3, the speed up is ~30%.
Based on change by jmadill@chromium.org
Bug: angleproject:7375
Change-Id: Ib6c73e95d06229f8545d502b388ee2a55a582323
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697308
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
91976352
|
2022-06-21T15:41:02
|
|
Use C++17 attributes instead of custom macros
Bug: angleproject:6747
Change-Id: Iad6c7cd8a18d028e01da49b647c5d01af11e0522
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3718999
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
0779ccbc
|
2022-06-10T17:55:54
|
|
Vulkan: Destroy DescriptorSet cache when it becomes invalid
When a new texture descriptorSet is allocated, we store one reference of
the cache key in ProgramExecutableVk and all TextureVks that it
associated with. When any of the TextureVk is destroyed or its view
destroyed, we immediately erase the descriptorSet from the cache and
track GPU progress and free the descriptorSet when it's GPU completed.
That way we delete the dead descriptorSet that will for sure never been
reused ASAP so that its space is avialable for reuse.
Bug: b/235523746
Change-Id: Ib1b9662a254eea5a3f410dc6d5d89fca6727a647
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700226
Reviewed-by: Lingfeng Yang <lfy@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
669d7b75
|
2022-05-25T15:14:35
|
|
Fix validation checks in glCompressedTexSubImage3D
- Add missing ASTC formats to the checklist in
CompressedSubTextureFormatRequiresExactSize.
- Add missing validation checks in ValidateES3TexImageParametersBase
relating to internal formats
Test: KHR-GLES32.core.compressed_format.api.invalid_format_array
Test: KHR-GLES32.core.compressed_format.api.invalid_offset_or_size
Test: *ETC2RGB8_CubeMapValidation*
Test: *CompressedTexture*Test*
Bug: angleproject:6441
Change-Id: Icc80d78602ea997be11606587b43d29e72e48f3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3670768
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Brandon Schade <b.schade@samsung.com>
|
|
338c6539
|
2022-06-22T10:22:22
|
|
Set pixel unpack state in GL backend's CompressedTexImage3D.
A workaround added earlier wasn't applying to the GL backend because
of this missing call.
Covered by existing angle_end2end_test, but only reproduces on ASAN
build. A Chromium-side test is being added separately.
Bug: chromium:1335688
Change-Id: Ia33648054dfa647159ecfc62ca53415de04f625d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715717
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
97e0157a
|
2022-06-21T17:00:07
|
|
Fix compilation errors with deprecated sprintf function
This commit modifies sprintf calls to fix the following
compilation errors using XCode 14.0 beta on MacOS:
> 'sprintf' is deprecated: This function is provided for
> compatibility reasons only. Due to security concerns inherent
> in the design of sprintf(3), it is highly recommended that you
> use snprintf(3) instead.
Bug: angleproject:7448
Change-Id: I2d72e09a1289a3746f457508c3dae9e922fe6b98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3721635
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
6c8bb1f3
|
2022-06-21T06:06:29
|
|
Metal: Fix invalid iosurface texture after base/max lvl changed
Changing base/max lvl invalidated previously bound iosurface's texture.
This caused conformance/canvas/webgl-to-2d-canvas.html failure.
Fix by rebinding the iosurface's texture after base/max lvl changed.
Bug: chromium:1337324
Change-Id: I28f84b0ac28695221997571f71c476e802cbfac3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715729
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
32cb5750
|
2022-06-23T10:01:56
|
|
Roll SwiftShader from 5cb6a639d494 to ec31f547750c (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/5cb6a639d494..ec31f547750c
2022-06-23 sugoi@google.com Fix stale SPIRV_SHADER_DBG statements
2022-06-23 sugoi@google.com Fix warning on Linux
2022-06-22 swiftshader.regress@gmail.com Regres: Update test lists @ 5cb6a639
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: I7b00e1fb33c1031fe69099c1ba3a83f1410c5d13
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720480
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
6d3c6370
|
2022-06-18T00:13:56
|
|
Vulkan: Fix 180 and 270 degree rotated resolve
Bug: angleproject:7197
Bug: b/235877059
Change-Id: I4d4ee622f49bb3218449414a1f0dd91fa4e4f541
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708997
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
72f69e84
|
2022-06-21T16:22:25
|
|
ANGLEPerfTest: Add option to disable GL debug callbacks.
Disable GL debug callbacks on native ARM GLES1.
This fixes native GLES1 replay on Pixel 6 when running debug builds.
Bug: angleproject:7447
Change-Id: I0059c07f4f2fb944e54a5163863b487bc31ab28f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3716584
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
c93b3b32
|
2022-06-10T16:34:00
|
|
Tests: Add Animal Crossing trace.
Test: angle_perftests --gtest_filter="*animal_crossing*"
Bug: angleproject:7306
Change-Id: Ic19adff3915093d86d68f24a5be2c0d2124f2123
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697532
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
329e1f9e
|
2022-06-04T02:30:56
|
|
Ensure pls results are secure even without barriers
We can't guarantee the client will always use local storage barriers
correctly, but we CAN guard local storage passes such that the results
are only nondeterministic within predictable constraints. This CL adds a
test to ensure local storage is still predictable without barriers, and
that no data is random or leaked from other contexts.
Bug: angleproject:7279
Bug: angleproject:7398
Change-Id: I70da58c8ba79b09f560315df3df956d1721ff6b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654265
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Chris Dalton <chris@rive.app>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
21a07210
|
2022-06-22T16:43:44
|
|
Suppress 3 pointcoord tests on Mac Intel Metal
Bug: angleproject:7451
Change-Id: Id03e3a60aca38798ecaec4a74f0b0af64eecc63e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3714602
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
9a6ae13e
|
2022-06-17T23:42:15
|
|
Vulkan: Enable prerotation on multisample tests
Bug: b/235877059
Change-Id: I3a8b8483d7b478e36328ac402539df99e62c18b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708996
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
593ef4c0
|
2022-06-22T14:30:06
|
|
Switch Mac experimental testing to Intel
Bug: chromium:1334335
Change-Id: Iae314c8ab7e177a476fcb95e9332c5f13c1fc070
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3714601
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
683209c4
|
2022-06-22T13:07:59
|
|
Context: Limit max samples to 4 during capture.
In order to be compatible with more devices like the Pixel 4,
GL_MAX_SAMPLES should be set to 4 during capture.
Bug: angleproject:7306
Change-Id: Ie7d67be661bc02e15934b6e561f59696ffd3643a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3714600
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
dfbdc351
|
2022-06-21T13:53:32
|
|
Run trace_tests on DEPS changes
To catch errors when depot_tools are rolled into ANGLE.
Bug: angleproject:7433
Change-Id: Ia89377c493737840b3110cd2f069e590bc190c1f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3716583
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
34f69947
|
2022-06-22T10:01:56
|
|
Roll SwiftShader from ff5356238d86 to 5cb6a639d494 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/ff5356238d86..5cb6a639d494
2022-06-21 srisser@google.com Add StorageTexelBufferArrayDynamicIndexing
2022-06-21 swiftshader.regress@gmail.com Regres: Update test lists @ ff535623
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: I275ad0b01c45c5f59356e3b4556bc80528d0de9d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3717649
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
997c6833
|
2022-06-22T07:21:01
|
|
Roll Chromium from de4095cef87e to 19706bf6c7d2 (495 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/de4095cef87e..19706bf6c7d2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/81c4032773..3a562c9e07
* buildtools/linux64: git_revision:fcda46cf40422284f2e74b770da8b22f7f5d7006..git_revision:ae474cc51337c3fe823f936371c5e92891e86b48
* buildtools/mac: git_revision:fcda46cf40422284f2e74b770da8b22f7f5d7006..git_revision:ae474cc51337c3fe823f936371c5e92891e86b48
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/2dba7d2cc4..92ef8d47d0
* buildtools/win: git_revision:fcda46cf40422284f2e74b770da8b22f7f5d7006..git_revision:ae474cc51337c3fe823f936371c5e92891e86b48
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/18b27b9f5d..d4d70a4321
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b7d9f94af1
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a3c4bc67c..39e4055004
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/4963453edd..6fba7268ea
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9ccf8390c7..f575df1ded
* tools/luci-go: git_revision:df39938896c4603fb2a214a2430450a85d9cca81..git_revision:5d9b6ecf87cdfb928e1112d2838d26bc7ede2b48
* tools/luci-go: git_revision:df39938896c4603fb2a214a2430450a85d9cca81..git_revision:5d9b6ecf87cdfb928e1112d2838d26bc7ede2b48
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/522d263b33..2f10365a2a
* tools/skia_goldctl/linux: OvVEMsHSDcQwu44X8cgC96F-XVZFYKyLTAnIhU4YgRMC..LOLBT9fx6Zp6tPJMXhgMoDZcTPCk-VSNk5gHIOchhIMC
* tools/skia_goldctl/mac_amd64: R3UJ_6wcxlpRWvd-qYlFbqJMdonTU0oOwXbwEeGdXKkC..u6SVSv19aduMZOLqGYkCHbjhnJWwm0WimUYQs4q9mDgC
* tools/skia_goldctl/mac_arm64: 0Q-N1gY2crCQYdezvnNMBarAkwPnVs8ftHgHXBdunhMC..1aHoSQfZbmKtsxSSw_7SIfNuMapnLQb_uHdo237FM88C
* tools/skia_goldctl/win: zaA5e-0b_opOOKLYTWgORdrhX4IWX6NGw1cn6f6gBCsC..0JoR2aK22wezglgiEZQathxIbpRDITqBt6h9rwFMU7QC
No update to Clang.
Bug: None
Tbr: jonahr@google.com
Change-Id: Ia3d8eb3a2aac616928aa654a522eccca84a69825
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3717787
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
d55e0655
|
2022-06-06T20:24:55
|
|
Add pls tests for fragment reject utilities
GL utilities for rejecting fragments should also prevent stores to pls.
(Namely: discard, return from main, depth/stencil, viewport.)
Bug: angleproject:7279
Bug: angleproject:7398
Change-Id: I91aac62fc7eeb703c7bc1ff1bc0c841700fd83d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696676
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Chris Dalton <chris@rive.app>
|
|
714f680f
|
2022-06-08T16:19:20
|
|
Implement GL_EXT_base_instance
* Added the validation functions for
DrawElementsInstancedBaseVertexBaseInstance(),
DrawElementsInstancedBaseInstance(), and
DrawArraysInstancedBaseInstance() according to the specs.
* Added generic implementation for
glDrawElementsInstancedBaseInstance() that can
be called by back-ends.
* Added flags for back-ends so they can enable the extension.
* Added tests for DrawElementsInstancedBaseVertexBaseInstance(),
glDrawElementsInstancedBaseInstance(), and
DrawArraysInstancedBaseInstance().
* Disabled ES3_D3D11__DynamicDraw tests due to
angleproject:7441 bug.
Bug: angleproject:6983
Bug: angleproject:7441
Change-Id: Ia664b01c87bc64c05e29adec23a8f80792eaa037
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697206
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Faye Zhang <ffz@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
be78a0fe
|
2022-02-22T16:11:51
|
|
Capture/Replay: Fix which sync object is deleted
The test decription says:
Secondary (Texture) Thread:
1. Wait for the mMainThreadSyncObj fence object to be created.
2. Once the fence is created, add a
glWaitSync(mMainThreadSyncObj) to the command stream
and then delete it.
Bug: angleproject:6631
Change-Id: Ia477970f64b4e2e48a0884be5e37144dd2f7bd56
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3480995
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
32c38e55
|
2022-06-21T10:01:32
|
|
Roll vulkan-deps from 45c701a7067d to 1765af41ecf5 (6 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/45c701a7067d..1765af41ecf5
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fbcb6cf4c8..2eff41e707
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/e26be655eb..477fb9e188
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/01ad714caf..6f57b1fa23
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6e8fb40b3b..9342a262d9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: Ib840584d33a56cb8ab8b9ca5c38b39368b27f3dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715960
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
072b155a
|
2022-06-21T10:01:38
|
|
Roll SwiftShader from f833544ff898 to ff5356238d86 (5 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f833544ff898..ff5356238d86
2022-06-20 sugoi@google.com Expose Vulkan 1.3
2022-06-20 capn@google.com Fix workgroup builtins size
2022-06-20 nicolascapens@google.com Revert "Patch regression in FSR tests"
2022-06-20 capn@google.com Expose Wayland only when enabled
2022-06-20 swiftshader.regress@gmail.com Regres: Update test lists @ f833544f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: I6f87219908694d907035c82a3f20ac549bbd6034
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715277
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
1aaa61dc
|
2022-06-21T08:10:24
|
|
Roll Chromium from 36bd948bdb66 to de4095cef87e (273 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/36bd948bdb66..de4095cef87e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/ced5024677..81c4032773
* buildtools/linux64: git_revision:e62d4e1938a45babc9afb6db543f388cd1802a52..git_revision:fcda46cf40422284f2e74b770da8b22f7f5d7006
* buildtools/mac: git_revision:e62d4e1938a45babc9afb6db543f388cd1802a52..git_revision:fcda46cf40422284f2e74b770da8b22f7f5d7006
* buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/1644d070bf..b387062642
* buildtools/win: git_revision:e62d4e1938a45babc9afb6db543f388cd1802a52..git_revision:fcda46cf40422284f2e74b770da8b22f7f5d7006
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/8fd1b429aa..18b27b9f5d
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ce5a215b62..00f782bd3d
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4ea19a6a70
* third_party/r8: 9ZYYzSVt4L6QGnf272Wm7wxsJ4VH77Dh2fel6JB9nOcC..iMLEt10uXASDfG2AlATR1fO8xYhBoF24nQvDDXLY6Q8C
* third_party/turbine: A5bkaoLBc1JYa6Xv31jYUCK5TnXYCbxRrA4FBPXXcWgC..RxaW8ZVJZ7rF3dbAGbL1OV6f9ZELjVeiiQbpkDsuxA4C
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/37a3ed940e..9ccf8390c7
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/32ffcd0987..1122520fc4
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/413458109c..522d263b33
Clang version changed llvmorg-15-init-13434-gbd9eed3a:llvmorg-15-init-13850-ge2913362
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/37a3ed940e18960d6979a5beef7870100bfff71c..9ccf8390c7b6a918bca5bc72c53a465b36b15014/scripts/update.py
Bug: None
Tbr: jonahr@google.com
Change-Id: Iacf061a5d3feeb748fd53fab0c8f4da0c6f975f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715955
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
21c89c14
|
2022-06-20T10:01:38
|
|
Roll SwiftShader from 2b79b2f8aec2 to f833544ff898 (8 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/2b79b2f8aec2..f833544ff898
2022-06-17 sugoi@google.com Expose bufferDeviceAddress support
2022-06-17 sugoi@google.com Handle spv::StorageClassPhysicalStorageBuffer
2022-06-17 srisser@google.com Implement descriptor indexing for texel buffers
2022-06-17 sugoi@google.com Allow subzero to cast pointers to integer types
2022-06-17 capn@google.com Adapt for LLVM 15 coroutine change
2022-06-17 sugoi@google.com Load and Store functions for pointers
2022-06-17 sugoi@google.com Implement SPIR-V OpBitcast for pointers
2022-06-17 sugoi@google.com Allow Operand objects to contain pointers
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: Ib36ef2e638b8c719c6d786a34242632b4a36a515
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3713723
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
59b9dde0
|
2022-06-20T10:01:32
|
|
Roll vulkan-deps from 4ede36c4734b to 45c701a7067d (2 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/4ede36c4734b..45c701a7067d
Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/679d107398..6e8fb40b3b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: If639835a647912d2d264b6489b983b6bdfc55f55
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3714001
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
9ea490f5
|
2022-06-20T07:39:24
|
|
Roll Chromium from 58c59e887244 to 36bd948bdb66 (551 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/58c59e887244..36bd948bdb66
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/7b855aae93..ced5024677
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/fdb2b2e62f..8fd1b429aa
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b83d69ffe9
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6cebde7ca2..9a3c4bc67c
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f68dc6bbd6..37a3ed940e
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9018d3c0d4..32ffcd0987
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0d6086926f..413458109c
No update to Clang.
Bug: None
Tbr: ynovikov@google.com
Change-Id: I671aa3564034af772884797405942f53e26cbddc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3712900
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
878bbfaa
|
2022-06-17T11:48:14
|
|
Vulkan: Account for 2DArray textures during robust resource init
Correctly handle layer count and depth when the texture type is
2Darray. Vulkan requires depth of 1 for 2Darray textures.
This also reverts commit c59a22e587e63cbe9942a7f0b78681ee25084cc4.
Bug: angleproject:3189
Bug: angleproject:4691
Bug: angleproject:7389
Bug: angleproject:7438
Test: DXT1CompressedTextureTestES3.CompressedTexSubImage3DValidationPerSlice*Vulkan
Change-Id: Ifb3b9cabd4786dcced750e3c2db90e350d455098
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3712220
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
7f57d12b
|
2022-06-17T22:29:36
|
|
Vulkan: Disable cache warmup on ChromeOS SwANGLE
A number of browser tests fail due to the cache warm up changing the
timing of the tests. The bug is in the tests, but this change unblocks
ANGLE roll into Chromium.
Bug: angleproject:7440
Change-Id: Ie2d7618bfc367bd34f9b99982c9323c99188c626
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708995
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
c59a22e5
|
2022-06-17T17:28:26
|
|
Skip CompressedTexSubImage3DValidationPerSlice capture_replay
DXT1CompressedTextureTestES3.CompressedTexSubImage3DValidationPerSlice/ES3_Vulkan_SwiftShader
reports VUID-vkCmdCopyBufferToImage-srcImage-00201
Bug: angleproject:7438
Change-Id: Ie9b9e8fdf1292d330ed61cbb4791fc7b3e4ab8ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711749
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
2d5b76cf
|
2022-06-17T16:42:31
|
|
Roll vulkan-deps from 21fa1f0acbfa to 4ede36c4734b (10 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/21fa1f0acbfa..4ede36c4734b
Changed dependencies:
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/197a273fd4..99b59b3528
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/76ebfb989f..fbcb6cf4c8
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/ec9b96aae5..3be1df310b
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/71e43122c9..e26be655eb
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/2661f654ad..01ad714caf
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d667189bc8..679d107398
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: I0d1b617136f1d3e6fb800570ad6695932ba22732
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711689
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
0a7cfa08
|
2022-06-16T16:24:54
|
|
Vulkan: Fix marking external images as renderable
Bug: chromium:1266094
Change-Id: Ie8d7b82f859697530f6581c7109d773d6fa35d37
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3710690
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
ca96cba9
|
2022-06-16T11:33:14
|
|
Make ReadEntireFileToString return a std::string.
Note: this makes the method unavailable for export from angle_util,
which is probably why it was designed the way it was in the first
place. However, we import the test utils source file as a static
lib into each test executable and test shared module, so it works.
Bug: angleproject:7404
Change-Id: Ia957268882c2b8529643660d7d4f34d142c0dc43
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708602
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
|
|
5f1d0742
|
2022-06-17T13:11:00
|
|
Increase batch timeout with sanitizer
MemoryBarrierBufferOnlyTest got slow recently
Bug: angleproject:7439
Change-Id: I6f24fa9abb9dcc98ebb8c964860a292e89ec1e19
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711745
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
|
|
88de1405
|
2022-06-17T12:49:09
|
|
Revert "Temporarily remove win-trace from CQ"
This reverts commit f427ae4167421c93544f23e74850ca75d6dba12a.
Reason for revert: compile works now
https://ci.chromium.org/ui/p/angle/builders/try/win-trace/2078/overview
Original change's description:
> Temporarily remove win-trace from CQ
>
> Until compile on it is fixed.
>
> Bug: angleproject:7433
> Change-Id: Id4fc2b5789d0883d3b74ef66d6b6e71cccb1c057
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707273
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Bug: angleproject:7433
Change-Id: I09d841ad207132302b5fbfb4afe9a513fccafa2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711744
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
872d7947
|
2022-06-17T10:01:38
|
|
Roll SwiftShader from cfcb44322bcc to 2b79b2f8aec2 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/cfcb44322bcc..2b79b2f8aec2
2022-06-16 sugoi@google.com Avoid clamping uninitialized values when clearing depth images
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: I2ce4573cb921e2e80b6f09a785b13c054ffecc3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3710819
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
a8b64f2f
|
2022-06-17T07:54:24
|
|
Roll Chromium from 96b247286bab to 58c59e887244 (150 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/96b247286bab..58c59e887244
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/2c0a2cf6d7..7b855aae93
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/35fd5adeea..fdb2b2e62f
* third_party/android_build_tools/aapt2: jziPmg_EUjoj-eSkO24eMaf5ylm449Q7BKO1-ga2tbgC..hf9C5IyJUUGaBnzqu60xiFJSyfAmjqjc_PiNXNVc9l0C
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..110018c8ad
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/505a265e52..6cebde7ca2
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b4df887c08..f68dc6bbd6
No update to Clang.
Bug: None
Tbr: ynovikov@google.com
Change-Id: I3b17a3ba17c78d6504e150487944bd23100e9aab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711285
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
6ca9c55e
|
2022-06-13T10:32:39
|
|
Capture/Replay: Allow capturing of external textures
With the support for EGL textures enabled we can actually capture
the texture content.
Bug: angleproject:5822
Change-Id: I386827456d146a54d9790fdd9eadb39b2a6b87e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702350
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
ea3bd30a
|
2022-06-13T11:44:45
|
|
Capture/Replay: Don't capture tex levels that are out-of-range
Bug: angleproject:6334
Change-Id: I01cb1920154b5fba9554180d2edf5be9dea2b7a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3702351
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
7ac73cc1
|
2022-06-17T06:08:28
|
|
Roll VK-GL-CTS from 893946636054 to e22ec5fc4cbf (13 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/893946636054..e22ec5fc4cbf
2022-06-17 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/github-main into vk-gl-cts/main" into main
2022-06-17 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main" into main
2022-06-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main
2022-06-16 ari.suonpaa@siru.fi Add tests for mul extended using different bit sizes
2022-06-16 rgarcia@igalia.com Test shader group handle alignment
2022-06-16 mika.vainola@siru.fi Test XFB queries without shader writes
2022-06-16 rgarcia@igalia.com Remove duplicate checkPipelineLibraryRequirements call
2022-06-16 jari.komppa@siru.fi Disable IPC primitives on android
2022-06-16 rgarcia@igalia.com Mix dynamic line stipple and dynamic primitive topology
2022-06-16 marcin.zajac@mobica.com isExtensionSupported renaming
2022-06-16 piotr.byszewski@mobica.com Additional tests for UPDATE_AFTER_BIND
2022-06-16 thomas.weber@arm.com Add testing for VK_EXT_subpass_merge_feedback
2022-06-16 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-bots+autoroll-info@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: angle-bots+autoroll-info@google.com,ynovikov@google.com
Change-Id: I0dd6c42fcacf0335102a40849bd41bc11e987ac8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3710221
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
5975eb03
|
2022-06-16T22:17:47
|
|
Roll Chromium from e6f032b42bce to 96b247286bab (303 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/e6f032b42bce..96b247286bab
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com,jwata@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/c05f2b0825..2c0a2cf6d7
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3d43903645..34f9ff8fd5
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f98faec51f..35fd5adeea
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1e84da114a..ce5a215b62
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ad0677e463
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ecb22a6b70..505a265e52
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/aab57889a8..b4df887c08
* tools/luci-go: git_revision:de014227dd270df7c61bfab740eb4ae4b52ac2a7..git_revision:df39938896c4603fb2a214a2430450a85d9cca81
* tools/luci-go: git_revision:de014227dd270df7c61bfab740eb4ae4b52ac2a7..git_revision:df39938896c4603fb2a214a2430450a85d9cca81
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9b4f350017..9018d3c0d4
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/103b863271..0d6086926f
* tools/skia_goldctl/linux: l0eo0uR9oMGZFKDucYLGk3vdNGAunP4tGrDhIfzljdcC..OvVEMsHSDcQwu44X8cgC96F-XVZFYKyLTAnIhU4YgRMC
* tools/skia_goldctl/mac_amd64: 4shFavk40_bOJI9zUzvH2PaMW7tHKuxeEN0zik75F7sC..R3UJ_6wcxlpRWvd-qYlFbqJMdonTU0oOwXbwEeGdXKkC
* tools/skia_goldctl/mac_arm64: Ynx3axT8ZDN7Nl5pNwI5w8PCCt7jax5FGf8jcyjUzt4C..0Q-N1gY2crCQYdezvnNMBarAkwPnVs8ftHgHXBdunhMC
* tools/skia_goldctl/win: 7YFnDYPdgUOTWkaZe19LzWhmwWBuVMM9Q02sTDQtlkgC..zaA5e-0b_opOOKLYTWgORdrhX4IWX6NGw1cn6f6gBCsC
Clang version changed llvmorg-15-init-11722-g3f3a235a:llvmorg-15-init-13434-gbd9eed3a
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/aab57889a872b9210806c5b530c0e23d1aa0b0e7..b4df887c08422a2e98f124c24cef49349272fc24/scripts/update.py
Bug: None
Tbr: ynovikov@google.com,jwata@google.com
Change-Id: I8f6ebe805b34823c69cde2a0aa275acc3dcfd925
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3709408
Reviewed-by: Junji Watanabe <jwata@google.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
72e457fe
|
2022-06-03T15:36:01
|
|
Vulkan: Promptly destroy cached framebuffer when it becomes invalid
When Texture gets respecified, the VkFramebuffer cache created out of it
becomes invalid and will never possibly get used. Before this CL, we
never clear such invalid framebuffer objects from the cache. This CL
keeps a reference to the cache key in each attachment and will
immediately destroy the cached VkFramebuffer object when one of the
attachment has become invalid.
Bug: b/234769934
Change-Id: Ib01f6dffe9211084b1ada340081daf905e3f1bef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3682164
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
bcc39a32
|
2022-06-16T10:54:12
|
|
Enable ExposeNonConformantExtensionsAndVersions
Enable ExposeNonConformantExtensionsAndVersions in
aosp so that these deqp tests that use es version
3.2 can pass on Android CTS:
dEQP.EGL/functional_image_create_gles3_android_native_array_rgb565_texture_array
dEQP.EGL/functional_image_create_gles3_android_native_array_rgb8_texture_array
dEQP.EGL/functional_image_create_gles3_android_native_array_rgba8_texture_array
Bug: angleproject:7351
Change-Id: Ic03ea0e3e46a65134a88dd8dce95611d42427bd9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3709402
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
|
|
6edb385b
|
2022-06-16T18:04:28
|
|
Roll VK-GL-CTS from 50754c3c19c0 to 893946636054 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/50754c3c19c0..893946636054
2022-06-16 quic_mnetsch@quicinc.com Merge pull request #326 from DadSchoorse/VK_EXT_non_seamless_cube_map
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-bots+autoroll-info@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: angle-bots+autoroll-info@google.com,ynovikov@google.com
Change-Id: I47ee99e238ff81b51e04af9649f33f11408b5b97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3709403
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
97a6e581
|
2022-05-30T16:50:26
|
|
Vulkan: Useful implementation of program binaries
ANGLE already serializes the pipeline state for the sake of
OES_get_program_binary. This serialization had limited usefulness
however, since the Vulkan driver hasn't actually created any pipelines
yet (which is a costly part of program creation).
Simultaneously, ANGLE deferred Vulkan pipeline creation to draw time,
which causes hitching.
In this change, a handful of Vulkan pipelines are precreated at
link time; those at least that are sure to create different blobs in the
pipeline cache (different spec consts or SPIR-V generation). These
pipelines are created in the program executable's cache. The cache is
then merged into the shared renderer cache (for potential blob reuse by
other programs).
With this, two goals are achieved:
- Most pipelines created at draw time hit the pipeline cache, avoiding
costly compilation.
- When the program binary is retrieved, the contents of the program
executable's pipeline cache is also returned. On reload, the cache is
recovered, resulting in faster startup.
Bug: angleproject:5881
Change-Id: I46c5451a7d0b16dffd40e44015e094640886880b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3671977
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
0bc70e96
|
2022-06-10T22:27:04
|
|
Vulkan: Rename getShareGroupVk to getShareGroup
+ other miscellaneous clean up
Bug: angleproject:7375
Change-Id: I25690860478a2fd181a67ce2b6cb4d7aac7dbaa7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700197
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
8a8b9665
|
2022-06-08T14:54:37
|
|
Vulkan: Prune superseded staged updates in a texture
Add support for pruning superseded staged updates from a client buffer
to the texture. If the staged update count or the cumulative staged
updates' size exceeds a threshold we check for superseded updates and
prune the list.
Bug: angleproject:4691
Bug: angleproject:7389
Test: Texture2DTest.InterleavedSupersedingTextureUpdates*
Texture2DTest.ManySupersedingTextureUpdates*
Change-Id: I4b84f13fa20004a3dc68baa552a0af656d92c0a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3691092
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
1131f117
|
2022-06-14T11:49:15
|
|
Support BGRX8 for framebuffer blits
For WebGL content, Chrome usually needs to perform MSAA resolve on
the WebGL buffer before compositing via a blit. On ChromeOS, this
read buffer is usually in BGRX as it is the native format for the
display hardware which eventually gets coerced to GL_BGRX8_ANGLEX in
ANGLE.
Unfortunately, ANGLE claims limited support for this format, so the
blit subsequently fails, resulting in a black screen on some WebGL 1
apps. This CL fixes a validation error and marks BGRX8 as filterable
so that ANGLE's blit framebuffer implementation can actually operate
on GL_GBRX8_ANGLEX targets.
Bug: b/233238923
Change-Id: I378c177c9770d98a8fdb8284335ada66f7907a69
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3703621
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Brian Ho <hob@chromium.org>
|
|
c41dae02
|
2022-06-15T19:41:39
|
|
Further suppress MultithreadingTestES3 hanging tests on Linux SwANGLE
Also MultithreadingTestES3.ThreadB*BeforeThreadASyncFlush.
Bug: angleproject:7431
Change-Id: Ib27afb4ed6862580dbe64c38d3eaca2040f7c1ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707272
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
f427ae41
|
2022-06-16T11:56:00
|
|
Temporarily remove win-trace from CQ
Until compile on it is fixed.
Bug: angleproject:7433
Change-Id: Id4fc2b5789d0883d3b74ef66d6b6e71cccb1c057
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707273
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
|
|
a62204c3
|
2022-06-15T14:01:17
|
|
Guard all imports of wayland.gni with angle_use_wayland
Fixes build errors in Skia
Bug: angleproject:7434
Change-Id: I99e8ab741c0128f7327fec08e04979edde4f19e9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707852
Reviewed-by: Antonio Caggiano <antonio.caggiano@collabora.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Brian Osman <brianosman@google.com>
|
|
44b17743
|
2022-06-16T10:01:38
|
|
Roll SwiftShader from 20c04524ee8a to cfcb44322bcc (4 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/20c04524ee8a..cfcb44322bcc
2022-06-15 antto.makinen@siru.fi Fix the linear-to-sRGB conversion on SRGB storage image writes
2022-06-15 capn@google.com Patch regression in FSR tests
2022-06-15 sugoi@google.com OpTypeForwardPointer support
2022-06-15 sugoi@google.com bufferDeviceAddress: opaqueCaptureAddress support
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: I0bcaae2ee70f899e86f5778810a7bfb2974285c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3709813
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
816a1b3a
|
2022-06-16T07:00:14
|
|
Roll Chromium from c8885f7596b7 to e6f032b42bce (339 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/c8885f7596b7..e6f032b42bce
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/0bfcd94506..c05f2b0825
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8b16338d17..3d43903645
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/af4060e181..f98faec51f
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/df429e4f94..1e84da114a
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2b591cc800
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3133f98f3f..ecb22a6b70
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/f8a4cfe4f9..345862f410
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4ca94d228c..103b863271
No update to Clang.
Bug: None
Tbr: ynovikov@google.com
Change-Id: I56d8492b7c3194822894f171251ed2490fd66044
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3709116
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
9ebc1b6a
|
2022-06-15T15:56:33
|
|
Roll vulkan-deps from 1762849caed4 to 21fa1f0acbfa (11 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/1762849caed4..21fa1f0acbfa
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/adbf0d3106..bffcf209cb
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8f7f5024f8..76ebfb989f
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c3601d4d91..71e43122c9
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ef9db7a8ec..2661f654ad
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/088a54d47d..d667189bc8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: Ie13f02c3b783457e44a41f73e1cb83442693d122
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707488
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|