kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 6ffd0105 2025-05-07T10:01:39 Roll vulkan-deps from 82f44a3a6738 to 645c800a7790 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/82f44a3a6738..645c800a7790 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/3786ee89d584f5ba46f31dc5253e6dfaa222e5c1..a5b2bd69fa3ac07412666a3c3b0f4b2f67d056a1 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9693056da58c0deb658a9e5ada88a2cadc4153b4..8ede14d21b4c20658b69aa3cb23a451008db4066 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/c30213060ec65de75116c3f5e5334529a24cd8c8..fefd7ed96ef9994f0080dbd078822b07d8637918 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/441065f6fc75f2aff027432aa5aa96496dac3bdb..17cf8188d8b49bafb6c2f8ecede238f8d2dec5bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If5053131ebc9f6fc379bc0a8851bf2fb3cd6de22 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6519235 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8357b6a2 2025-05-07T07:48:55 Roll Chromium from a753f6d4bddd to 4d44e5915a7e (674 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a753f6d4bddd..4d44e5915a7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2021df387e..27362bc37b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b841ab22bc..4347ca8fd6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/de5f1c8085..c4492b5004 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/91f1a3775e..0f15c850a7 * third_party/android_build_tools/error_prone/cipd: 2t_u1XEjof609BQE4czlCQzEqRliKS_qY35FOu_VckgC..FLtgIzcLepAc87BaSXIELZIJPT4yxnr8K3MmFaEHrK8C * third_party/android_build_tools/lint/cipd: 0xqmMJ1qdP4NPN5s9VmWiNhchvNz_RLBrjXN4jUKN3gC..2fKjMen4v_UU1CDYJqhwJCr6uh-L5w25n9lAKx6SlP0C * third_party/android_build_tools/manifest_merger/cipd: 7lstFdOjh1bFmfSZ8le-aZ1a1COQtwirGzuEWa43tnUC..GnPGgBK8kiq32GuJB3iI20yJbFjgt2dqHsmwoPShJ-4C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f41d65050b..62420678f4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/417522f618..52ad7cf544 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/30d9438e7b..8c9aa83747 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a01c02c9d4..a9cc573e7c * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f2a7f2987f..7ff13dd8c6 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/c8248a038f..d7bdad4ef8 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d40011a810..ec84d8bc89 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/e4c4740810..b137202150 * third_party/siso/cipd: git_revision:70e1167e0e6dad10c8388cace8fd9d9376c43316..git_revision:17b491ae74e86312a96239ff88e852acee83c135 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/63e36d9dbf..29026537c2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/07beeffaa5..c23fee0adb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/860e5b256e..67947ca3cb * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/0fcd33e88f..2ca952fc10 Clang version changed llvmorg-21-init-10502-gb2e2ae87:llvmorg-21-init-10851-gcd6c4b61 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/07beeffaa5d293fc7a627de3bed0027d9ceffb5c..c23fee0adb246c81027f94c01eb5894359ce8a9e/scripts/update.py Bug: None Tbr: syoussefi@google.com Change-Id: I07404c1c9c093437a08afd304b0d36abc088c968 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6516596 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Robic Sun b373892b 2025-04-26T20:59:07 Add test using array of array varyings in tessellation shaders For per-vertex variables in the Tess shader that support two-dimensional arrays, when calling GetResourceName, the string-like tt[0][0] should be returned instead of tt[0]. Bug: angleproject:413447006 Change-Id: Iafd316495ca3c254f9424d84cab71c8385b11e03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6490616 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Robic Sun <Robic.Sun@arm.com>
Amirali Abdolrashidi 5c441a53 2025-05-06T13:00:32 Vulkan: Prefer MSRTSS for QCOM devices The feature flag `preferMSRTSSFlagByDefault` was originally added to avoid allocating extra memory if the images are created with the MSRTSS flag by default. If it is disabled, the image will be recreated with the said flag only if it bound to an MSRTT framebuffer. * preferMSRTSSFlagByDefault is now enabled for QCOM driver versions beyond 0777.0. Bug: b/329911999 Change-Id: Iea72f864eac5ecfa97b5c99de5bd66ef09c54c0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6516037 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu fcfc9760 2025-05-06T11:26:40 Reformat VVL error message The test VulkanPerformanceCounterTest_ES31.TextureSampleByDrawDispatchDraw no longer runs into the VVL error it used to have. Remove the VVL error from the skipped VVL error list. Bug: angleproject:42265504 Change-Id: I8eff929524b3e1bd015d96db2cc45b2c8f331170 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6514411 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Brian Sheedy 4cd5c9be 2025-05-05T14:45:34 Enable Mac/Intel experiment Enables the Mac/Intel experimental tester to test on Mac 15.4. Bug: chromium:414760990 Change-Id: I504a57f4ce81bcabecce50f17410f92ae572a5be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6514293 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Aurora Zhang 3cc099da 2025-03-20T16:47:46 Add tests for texelFetch with samplerExternalOES Add two tests to texelFetch in the vertex shader and fragment shader for YUV with samplerExternalOES. The fetch results are expected to be RGB value. Bug: angleproject:405149439 Change-Id: I0a5809b910ac61c678ab240aea8d303e0c9646e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6382116 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 7447e8ac 2025-05-06T10:33:47 Vulkan: Driver workarounds on Qualcomm Dynamic rendering is disabled on 512.800 due to crashes on some devices. Imageless framebuffers are disabled on 512.805, suspecting cause of crash on some other devices. Bug: chromium:415738891 Bug: chromium:415968761 Change-Id: I71f533c7954b628ce897ed1dac478aed119658e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6512663 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev 1c7fa5f8 2025-04-24T00:00:00 Add missing support checks to robust client memory entry points Ensured that implemented RobustANGLE entry points have the same command support checks as their base variants. * ReadnPixelsRobustANGLE requires OpenGL ES 3.2, or any of the robustness extensions. * GetQueryivRobustANGLE requires OpenGL ES 3.0 or any of the query extensions. * GetQueryObjectuivRobustANGLE requires OpenGL ES 3.0 or any of the query extensions. * GetInteger64vRobustANGLE requires OpenGL ES 3.0 or GL_EXT_disjoint_timer_query. * GetBufferParameteri64vRobustANGLE requires OpenGL ES 3.0. * TexImage3DRobustANGLE requires OpenGL ES 3.0 or GL_OES_texture_3D. * TexSubImage3DRobustANGLE requires OpenGL ES 3.0 or GL_OES_texture_3D. Bug: angleproject:410108264 Change-Id: I7bd4b07331a4eaee2b80232a7e54bd7370cee045 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6508731 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 9812b972 2025-03-05T16:25:45 PLS: Validate rendering feedback loops of PLS planes Validate that active textures are not bound as PLS planes in WebGL compatibility mode using the same validation as for regular framebuffer attachments. Update the PLS spec to not generate an error for feedback loops but update the definition of feedback loops to include PLS planes. The WebGL spec is dependent on this definition and makes this feedback loop an error. Bug: angleproject:40096838 Change-Id: I597efef3685da7bfb2a9d149a9ec3bc9d01e6e4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6330519 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Chris Dalton <chris@rive.app>
Alexey Knyazev 27cfdf8e 2025-04-24T00:00:00 PLS: Allow type conversions in state queries The OpenGL ES spec requires data conversions when a query command is issued that returns a data type different from the actual type of the requested state. * Updated PLS state queries to follow the main spec. * Removed PLS state query dependencies on interruptions. * Fixed non-robust command declarations in the extension spec. * Added missing extension support checks to robust commands. * Drive-by: Fixed invalid use of assertions in PLS tests. Fixed: angleproject:414361744 Fixed: angleproject:414506466 Change-Id: I573ab66d194d5666fd9c8845ac0ab262a714c5cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6507065 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 97445c56 2025-05-06T10:01:46 Roll vulkan-deps from 58ca0630c1c3 to 82f44a3a6738 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/58ca0630c1c3..82f44a3a6738 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/d5042689389ebb001fbcc6b606367f6e0836cabb..9693056da58c0deb658a9e5ada88a2cadc4153b4 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/b7947fe2d51e416666525c4d43a6e4398bb9f8a9..c30213060ec65de75116c3f5e5334529a24cd8c8 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/af3abdf3ec68a517e407c05f259cdadfd2b5cfe2..ba13d38d06830f714a93c5bb159e6e4bacacf0bc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/4e246c56ec5afb5ad66b9b04374d39ac04675c8e..be40e67892c83d4752ccfbee7ce690ea88087d2b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/c552e76e6cccababe0d19bc7b0b04be68541c44b..441065f6fc75f2aff027432aa5aa96496dac3bdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I29f820aacb95a309361310426ca082be5cbbd337 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6516212 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b80b87ab 2025-05-06T03:01:23 Roll SwiftShader from 9dd03f2e4b03 to 093b4d82a49a (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/9dd03f2e4b03..093b4d82a49a 2025-05-05 swiftshader.regress@gmail.com Regres: Update test lists @ 9dd03f2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I452f77d35a4567b5c629ef80df4efc0a28d98e62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6515444 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f5e2a67a 2025-05-06T07:01:41 Roll Chromium from 3ecef9588f01 to a753f6d4bddd (572 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3ecef9588f01..a753f6d4bddd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c386e235bb..2021df387e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f934b96202..b841ab22bc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9d653d0e2f..de5f1c8085 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/36bb88f9b3..f41d65050b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d66abd0ede..30d9438e7b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/629a8149c0..a01c02c9d4 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/e9d9246e8d..c8248a038f * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/1ded46a261..d40011a810 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/739d8d8784..860e5b256e No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Iaae4ef84736f79e17b58077d2a107ef6988751fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6515874 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll db13dbd5 2025-05-06T08:01:28 Roll VK-GL-CTS from eeeebaca3f2e to b2b40c06daf9 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/eeeebaca3f2e..b2b40c06daf9 2025-04-29 rgarcia@igalia.com Remove invalid lines in AndroidGen.bp and AndroidKhronosCTSGen.bp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I83a92274f27cf2fe232582961278e7823ee1cf05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6515986 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 3540a326 2025-05-05T16:47:30 Tests: Skip black_beacon trace on S24 Bug: angleproject:415852525 Change-Id: Ibf4d3f63e96da9cf43c34110654f9383f9ba82f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6512773 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuxin Hu c6e0448b 2025-05-05T10:49:32 Reformat VVL error message The SYNC-HAZARD-WRITE-AFTER-READ VVL error is no longer observed on TraceTest.special_forces_group_2, removed the error message from skipped VVL error list. The TraceTest.special_forces_group_2 now runs into a different SYNC-HAZARD-READ-AFTER-WRITE VVL error, on Linux AMD GPU. An existing entry in the skipped VVL error list already covers this error message. Reformat that entry by adding the extraProperties, and changing the messageContents1/messageContents2 fields to nullptr for ease of clean up later. Bug: angleproject:42264123 Bug: angleproject:397775556 Change-Id: I1681cd7f76dd2090e78584b08c25224d5b05d963 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6514289 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 2ca90dab 2025-05-02T22:38:38 Vulkan: Don't calculate vertex input state when dynamic When vertex input state is dynamic, VkGraphicsPipelineCreateInfo::pVertexInputeState can be nullptr. This change makes sure time is not wasted calculating this state at pipeline creation time. The change also ensures drivers don't rely on info provided at compile time by mistake. Bug: angleproject:42265637 Change-Id: I54da8be7769f0dd0767df6d7774baa956475bf8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6510082 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 95813607 2025-05-05T10:53:08 Manual roll VK-GL-CTS from dd7e71367795 to eeeebaca3f2e (10 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/dd7e71367795..eeeebaca3f2e 2025-04-25 mateusz.bahyrycz@mobica.com Multiple queue test runner 2025-04-25 lorenzo@khronosgroup.org Add missing mandatory features for VK_KHR_cooperative_matrix using auto-generation from XML 2025-04-25 piotr.byszewski@mobica.com Separate tests for gl_BaseVertexARB and gl_BaseInstanceARB 2025-04-25 piotr.byszewski@mobica.com Update spirv-tools and fix validation errors 2025-04-25 kamil.goras@mobica.com Add OpenGL tests for textureQueryLod 2025-04-25 rgarcia@igalia.com Force position-independent code in vulkan-video-samples 2025-04-25 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2 into vk-gl-cts/main 2025-04-23 michal.jakubek@mobica.com Fix "Linux link failures" on Windows build 2025-04-23 michal.jakubek@cognizant.com Linux compile failure when commenting out some test additions 2025-04-23 piotr.byszewski@mobica.com Remove temporary entries from Android*.bp files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I9d56381e80b6a89f307573ffc7f5c790c9ff4153 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6512791 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7d214a73 2025-05-05T15:16:20 Manual roll vulkan-deps from b9aab6c35f37 to 58ca0630c1c3 (72 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/b9aab6c35f37..58ca0630c1c3 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/fc9889c889561c5882e83819dcaffef5ed45529b..963588074b26326ff0426c8953c1235213309bdb https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/b3d30057b15273ce449bb9952e15e65b3f556723..47ee4dce39b5e8b594ed2e9c9cccd10342949683 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/bab63ff679c41eb75fc67dac76e1dc44426101e1..3786ee89d584f5ba46f31dc5253e6dfaa222e5c1 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/b6a83226d75d15b1733d35ee9e26b8f895ecffcb..d5042689389ebb001fbcc6b606367f6e0836cabb https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/409c16be502e39fe70dd6fe2d9ad4842ef2c9a53..9c77de5c3dd216f28e407eec65ed9c0a296c1f74 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/fb78607414e154c7a5c01b23177ba719c8a44909..b7947fe2d51e416666525c4d43a6e4398bb9f8a9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/0b8196724e4ad28cc7459b82a9b75f252c08cb3e..af3abdf3ec68a517e407c05f259cdadfd2b5cfe2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6530df51e0db74d50241c3a0f2c2798e99d0d9dd..c552e76e6cccababe0d19bc7b0b04be68541c44b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If1fbae100ff0ee09b85e5bede53cd6209470fe25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6511713 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 671f55d8 2025-04-03T22:54:44 Vulkan: Fix texelFetch(externalSampler) behavior GLES expects YUV decoding to happen with texelFetch when an external sampler is used, but texelFetch's translation (OpImageFetch) does not do such a thing. A transformation is added to replace that with a texture call at the right coordinate. Bug: angleproject:405149439 Change-Id: I3a8d07a6399705ec07718b38085ee4bc1ad2af6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6431570 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 33a585b8 2025-05-05T07:02:13 Roll Chromium from cf3a960742c3 to 3ecef9588f01 (1146 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cf3a960742c3..3ecef9588f01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/aaf578b4fc..c386e235bb * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6d4e129ac6..f934b96202 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/35b04da37d..9d653d0e2f * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/fe3242a8c8..3ed7629c86 * third_party/android_build_tools/lint/cipd: TEDRB0F7VgCgyepd8FsIxPRqvKjvWQ_YkLV-ybx-GQYC..0xqmMJ1qdP4NPN5s9VmWiNhchvNz_RLBrjXN4jUKN3gC * third_party/android_build_tools/manifest_merger/cipd: fPGWiT0LVG2_ifxOpHb5KNwTL-_7lb7tYOsB_ZoIiskC..7lstFdOjh1bFmfSZ8le-aZ1a1COQtwirGzuEWa43tnUC * third_party/android_build_tools/nullaway/cipd: F6la8NsEkr27_Sm2MswVDBDB7UXVqRtaCMS5YWEQ9dQC..mFkUqdlIqmMQ3rAaTHFmOBYjNFgFUQOmMlPG6PGgmHYC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/a86aaa9531..36bb88f9b3 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/f1b90bf3ad..96ee0e696e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1591e813b6..417522f618 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/354f6026f1..d66abd0ede * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/62724eb55f..629a8149c0 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/bf95cc5da6..e9d9246e8d * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/56b98941c7..1ded46a261 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/7c098b791b..e4c4740810 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e4c0da2094..63e36d9dbf * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5ae6e4bfb4..07beeffaa5 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e3589a5831..28deefa8f1 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/14089a7f57..cc38b4b04f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1a0049ce09..739d8d8784 * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/8ad6d21544..502dcad523 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/7e70cdf64e..0fcd33e88f Clang version changed llvmorg-21-init-9266-g09006611:llvmorg-21-init-10502-gb2e2ae87 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/5ae6e4bfb41f9bf57c91292e40abb4db3469dc67..07beeffaa5d293fc7a627de3bed0027d9ceffb5c/scripts/update.py Bug: None Tbr: syoussefi@google.com Change-Id: Ic32d77560c287256866506bf277f994637353f40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6511597 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Matthew Denton c60d98ce 2025-05-03T01:06:02 WGPU: Ship driver uniforms in the bind groups to the shader This writes driver uniforms to a WGPU buffer and ships that buffer to the shader. Right now this creates a new buffer every time a driver uniform changes. Bug: angleproject:389145696 Change-Id: Icfbce4d995ef593e703a597bb96e72173ec29cda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6477136 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Gavin Mak 7fe53b3c 2025-05-02T09:15:15 Remove --no_auth from download_from_google_storage hooks The flag was deprecated by https://crrev.com/c/6414748 and has no effect besides telling the user that it has no effect. Bug: chromium:414826937 Change-Id: I17e4ed6edca4dc97bd96db0a877bccfdfdfbb5f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6509445 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu ce795fa8 2025-04-28T15:31:25 Reformat VVL error message Set messageContents1 and messageContents2 fields to nullptr, for ease of clean-up in follow-up changes. Make the extra properties fields more specific. Bug: angleproject:42265363 Bug: angleproject:415382790 Bug: angleproject:415383266 Change-Id: I032bc82c6aeb16281c868778db827318fa833005 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6496650 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 18ec8824 2025-05-02T12:42:26 Vulkan: Exclude RADV from global cache preference * Added exception for AMD/RADV machines from the following flag: preferGlobalPipelineCache * (Due to no information regarding the effect of this flag on those platforms) Bug: b/411442610 Change-Id: Ifd9e2fe02e488d51cbb9e070106e86ac21e8533d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6509821 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 16e0dfd9 2025-03-20T10:59:26 Vulkan: Add feature flag to recycle VkEvent This CL adds a feature flag to enable/disable the VkEvent recycling. Given ARM prefers taking CPU overhead of creating and destroying VkEvent when last reference count to VkEvent goes away instead of the extra GPU overhead comes with vkCmdResetEvents, VkEvent recycling is disabled on ARM. Bug: angleproject:409441956 Change-Id: I288be6f7cfcbc4dd9c4701d20fba44349f25befc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6376784 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Junji Watanabe f6e1d4d7 2025-05-02T12:02:09 Fix include header case mismatches This CL fixes the include header names to be aligned with the actual file names. It's problematic for cross compile on Linux, where file system is case sensitive. Context: Goma/Reclient's deps scanner was able to handle those case mismatches. But, Siso's builtin remote execution doesn't resolve them automatically. Bug: b/401959048 Change-Id: I98282899e31ea801058f82d4cad770413634f4f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6508684 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll a8f49cfc 2025-05-02T03:01:13 Roll SwiftShader from fefba0024aa6 to 9dd03f2e4b03 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/fefba0024aa6..9dd03f2e4b03 2025-05-01 syoussefi@google.com Expose VK_EXT_extended_dynamic_state2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I93c68930cfa68ace971513e427a0e267ea0279b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6508755 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu d4c83ace 2025-04-30T12:05:19 Fix the test to use the right uniform location mTexture2DUniformLocation and mTextureCubeUniformLocation are uniform locations retrieved from the TextureCubeTest.mProgram. We should get the location from the shader program that the current test uses. Bug: angleproject:401546698 Change-Id: I7c5f022a9fab58572cae2e78fc328c1c0f74f977 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6502892 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Amirali Abdolrashidi a3b20796 2025-04-25T13:12:08 Vulkan: Add flag to prefer renderer pipeline cache * Added the following feature: preferGlobalPipelineCache * The renderer's pipeline cache will be used to create pipelines, including for warm-up. * mPipelineCache in the program is not saved when this flag is enabled. * Currently enabled for NVIDIA and AMD. * Impact on captured trace (w/ compiling inactive shaders) * Decrease in peak system memory usage on Windows/NVIDIA: * ~7600 MB -> ~3900 MB * Decrease in peak RES memory usage on Linux/NVIDIA: * ~7100 MB -> ~3600 MB Bug: b/411442610 Change-Id: I04929569f0f8d59a77c52505072faa0244ef1393 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6495155 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shashank Sharma 998b5693 2025-04-30T11:05:52 Fix ExternalBufferTest end2end test The application or test should be responsible for managing the lifetime of external buffer ensuring that the external buffer is not deleted as long as there are any GL buffer objects referring to it. https://registry.khronos.org/OpenGL/extensions/EXT/EXT_external_buffer.txt Bug: b/396231708 Change-Id: Ib8e7e2ef0349cadc42b839019e2b2334b4cc5085 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6502674 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Vasiliy Telezhnikov c52183bd 2025-04-11T11:17:10 Reset sample coverage after fbo change on Adreno Adreno drivers cache some internal value based number of samples in currently bound FBO and glSampleCoverage value, but doesn't update it on FBO change. So if we set sample coverage to 1 when FBO with 1 samples bound and then switch to FBO with 4 samples it behaves like coverage is 0.25 instead of 1. To avoid this, reset sample coverage after each FBO change. Bug: chromium:408364831 Change-Id: I7d5e36926e8568f4c652049b43ecdbe382ddc293 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6447878 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
angle-autoroll 6bdbe9cc 2025-05-01T12:33:41 Manual roll Chromium from dd275389e023 to cf3a960742c3 (1975 revisions) Use third_party/depot_tools/gn.py instead of gn to accommodate https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176 Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/dd275389e023..cf3a960742c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/88030b3203..aaf578b4fc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0f32cb9025..6d4e129ac6 * buildtools/linux64: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 * buildtools/mac: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 * buildtools/win: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe092931f1..35b04da37d * third_party/android_build_tools/error_prone/cipd: -IrkxgAkj3RxGNBPp6b4r9OWZC6_dTbI-jC3c3UPgq8C..2t_u1XEjof609BQE4czlCQzEqRliKS_qY35FOu_VckgC * third_party/android_build_tools/lint/cipd: gx4NrAApWUVG5HG3WJRIIzZrTssD6H5uGbKe0g77mucC..TEDRB0F7VgCgyepd8FsIxPRqvKjvWQ_YkLV-ybx-GQYC * third_party/android_build_tools/manifest_merger/cipd: HhXknpcPosMUDHZQD-8Ogve-HaG4HmJ4p082zKKAcnMC..fPGWiT0LVG2_ifxOpHb5KNwTL-_7lb7tYOsB_ZoIiskC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1ea2115b17..a86aaa9531 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/000f47cfa3..1591e813b6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1fcc527019..5982a1aeb3 * third_party/fuchsia-sdk/sdk: version:27.20250424.2.1..version:27.20250501.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/917609c669..62724eb55f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/912274164f..bf95cc5da6 * third_party/r8/cipd: bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC..sxgLKZyJNZMVi8cot5yvRzqCFQxX_HbbR0psaeto5RcC * third_party/r8/d8/cipd: 6qLey8EBp9ivhThnqVPWy2ZDGpsf5Y29EsTbi_rZ1pMC..bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/926ec54499..7c098b791b * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/1e85c01b15..6f9b4e6192 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/60443ebac3..e4c0da2094 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6c4f037a98..5ae6e4bfb4 * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:a9a10995e2889126ace91faf4052949e38c69d33 * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:a9a10995e2889126ace91faf4052949e38c69d33 * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:a9a10995e2889126ace91faf4052949e38c69d33 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b0c718c2d..e3589a5831 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9c8188cae9..1a0049ce09 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/fa679ed68e..7e70cdf64e * tools/skia_goldctl/linux: M9CSmdri8G3miQpGPQeqstBvQ3TtlngrsiF5GdSTYs0C..srGbc-O6bVQmBoT6VLvP66h6Be4A-nffx4UhixUJ9w0C * tools/skia_goldctl/mac_amd64: Txs7Izu5kRGbcoAc9qESynBnBHo8RdRIyim5zF9rWbgC..tZvHxy8AcDJhO9A-5UuZKL_-5vfE_wC-RBkElqWZpM4C * tools/skia_goldctl/mac_arm64: LTzU4UbKV4zw61tWyttEX62vyq7nErr2gD8-jiH8IhgC..2br8hIWKHDAaOt77siYyRUclHBYUZX6dj8jtogL90nwC * tools/skia_goldctl/win: UKiySjywM8juGVuMwWbOdaBXFD1TbzUOWcGGVTYfem0C..zasiUhQIHGZ2e60_M6g41oz8mYgPta5JmOWV5LwFjGMC No update to Clang. Bug: chromium:414330998 Change-Id: I5ce14c5574391c1dd638787c09789f0577ee26a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6503456 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 9bcfb38f 2025-04-30T23:12:19 Vulkan: Disable MSRTSS on buggy qualcomm drivers Bug: chromium:413427770 Change-Id: I62499c3aa04f3786a0deb6afcaafb7976f2a6446 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6501621 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya 3b77a177 2025-04-23T15:47:07 Optimize vertex attribute and buffer state change Bug: angleproject:386749841 Change-Id: I25968902282f6a201510e2ee17ea85fd71ef57c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6483915 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Yuly Novikov 432d1d1e 2025-04-30T12:56:18 Revert "Roll Chromium from dd275389e023 to 83180b816b9e (1315 revisions)" This reverts commit a4c8bf78eae845931343961ef92e2588227a7cb9. Reason for revert: linux builders broken by https://chromium-review.googlesource.com/c/chromium/src/+/6499312 Bug: None Original change's description: > Roll Chromium from dd275389e023 to 83180b816b9e (1315 revisions) > > https://chromium.googlesource.com/chromium/src.git/+log/dd275389e023..83180b816b9e > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/chromium-angle-autoroll > Please CC angle-team@google.com,geofflang@google.com on the revert to > ensure that a human > is aware of the problem. > > To file a bug in Chromium: > https://bugs.chromium.org/p/chromium/issues/entry > To file a bug in ANGLE: > https://bugs.chromium.org/p/angleproject/issues/entry > > To report a problem with the AutoRoller itself, please file a bug: > https://issues.skia.org/issues/new?component=1389291&template=1850622 > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md > > Changed dependencies > * build: https://chromium.googlesource.com/chromium/src/build.git/+log/88030b3203..a746c4fcb7 > * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0f32cb9025..2bf618c359 > * buildtools/linux64: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 > * buildtools/mac: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 > * buildtools/win: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 > * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe092931f1..3291a34ffb > * third_party/android_build_tools/error_prone/cipd: -IrkxgAkj3RxGNBPp6b4r9OWZC6_dTbI-jC3c3UPgq8C..2t_u1XEjof609BQE4czlCQzEqRliKS_qY35FOu_VckgC > * third_party/android_build_tools/lint/cipd: gx4NrAApWUVG5HG3WJRIIzZrTssD6H5uGbKe0g77mucC..TEDRB0F7VgCgyepd8FsIxPRqvKjvWQ_YkLV-ybx-GQYC > * third_party/android_build_tools/manifest_merger/cipd: HhXknpcPosMUDHZQD-8Ogve-HaG4HmJ4p082zKKAcnMC..fPGWiT0LVG2_ifxOpHb5KNwTL-_7lb7tYOsB_ZoIiskC > * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1ea2115b17..6177cd6532 > * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/000f47cfa3..083971e6b0 > * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/917609c669..62724eb55f > * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/912274164f..c43b02cfdb > * third_party/r8/d8/cipd: 6qLey8EBp9ivhThnqVPWy2ZDGpsf5Y29EsTbi_rZ1pMC..bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC > * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/926ec54499..110cb6df61 > * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/1e85c01b15..13aadd5859 > * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/60443ebac3..f73c955140 > * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6c4f037a98..5ae6e4bfb4 > * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:74734688ffc9d2807cda0d1dc7752197480de29e > * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:74734688ffc9d2807cda0d1dc7752197480de29e > * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:74734688ffc9d2807cda0d1dc7752197480de29e > * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b0c718c2d..f053b74423 > * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9c8188cae9..b08d2f11d8 > * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/fa679ed68e..7e70cdf64e > * tools/skia_goldctl/linux: M9CSmdri8G3miQpGPQeqstBvQ3TtlngrsiF5GdSTYs0C..k1BjOmyoXU04uWkPPdUJ0M5Lta0srcmKIzHJ2Drj5FUC > * tools/skia_goldctl/mac_amd64: Txs7Izu5kRGbcoAc9qESynBnBHo8RdRIyim5zF9rWbgC..Sql3pib8FeLV3AdnO-GPEkAXd1NeZc8m7_f0YWnV1h0C > * tools/skia_goldctl/mac_arm64: LTzU4UbKV4zw61tWyttEX62vyq7nErr2gD8-jiH8IhgC..J-0YzIpDw8ezG6JvHcbzOWvz79hJIj9oA_P8yyfA-WkC > * tools/skia_goldctl/win: UKiySjywM8juGVuMwWbOdaBXFD1TbzUOWcGGVTYfem0C..MISb1Ag5QQnBWhfkB8hBDYJRcEPDqzXrQrzBcSKUwx4C > No update to Clang. > > Bug: None > Tbr: geofflang@google.com > Change-Id: I4aa8e491e72d16c37037b8b1d42a3b501b706515 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6500074 > Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> > Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bug: None No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I2b206e6d177001e9381a8f1e45513d7aa9ccfc7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6494624 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Junji Watanabe e93c143a 2025-04-28T15:39:35 tests: Prepare capture_replay_tests for Siso migration - Adds --use_remoteexec as an alias of --use_reclient. - Adds --use_siso to add `use_siso=true` GN arg. - Changes the out dir to out_CaptureReplayTest, so that the build dir depth will be 2 for Siso remote execution rules. - Cleans up build dir when switching from Ninja to Siso. Bug: b/401959048 Change-Id: Id698644f16c161e86d1d1b42828281cb5fb690ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6489896 Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 128c9682 2025-04-24T00:00:00 Make GL_ANGLE_texture_rectangle non-toggleable This extension is not meant to be disabled. Bug: angleproject:40096622 Change-Id: Iea87210ab1bf3800759a3c65c566af67dada75f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6494384 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 1029195f 2025-04-30T03:01:07 Roll SwiftShader from 7905fa19e456 to fefba0024aa6 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/7905fa19e456..fefba0024aa6 2025-04-29 syoussefi@google.com Revert "Make Reactor buildable with LLVM 18" 2025-04-28 brunopitrus@hotmail.com Make Reactor buildable with LLVM 18 2025-04-28 swiftshader.regress@gmail.com Regres: Update test lists @ 7545980c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ic4abeea98614696d2fdd1dbdb77311267d4be4b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6500522 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a4c8bf78 2025-04-30T07:02:45 Roll Chromium from dd275389e023 to 83180b816b9e (1315 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dd275389e023..83180b816b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/88030b3203..a746c4fcb7 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0f32cb9025..2bf618c359 * buildtools/linux64: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 * buildtools/mac: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 * buildtools/win: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe092931f1..3291a34ffb * third_party/android_build_tools/error_prone/cipd: -IrkxgAkj3RxGNBPp6b4r9OWZC6_dTbI-jC3c3UPgq8C..2t_u1XEjof609BQE4czlCQzEqRliKS_qY35FOu_VckgC * third_party/android_build_tools/lint/cipd: gx4NrAApWUVG5HG3WJRIIzZrTssD6H5uGbKe0g77mucC..TEDRB0F7VgCgyepd8FsIxPRqvKjvWQ_YkLV-ybx-GQYC * third_party/android_build_tools/manifest_merger/cipd: HhXknpcPosMUDHZQD-8Ogve-HaG4HmJ4p082zKKAcnMC..fPGWiT0LVG2_ifxOpHb5KNwTL-_7lb7tYOsB_ZoIiskC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1ea2115b17..6177cd6532 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/000f47cfa3..083971e6b0 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/917609c669..62724eb55f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/912274164f..c43b02cfdb * third_party/r8/d8/cipd: 6qLey8EBp9ivhThnqVPWy2ZDGpsf5Y29EsTbi_rZ1pMC..bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/926ec54499..110cb6df61 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/1e85c01b15..13aadd5859 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/60443ebac3..f73c955140 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6c4f037a98..5ae6e4bfb4 * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:74734688ffc9d2807cda0d1dc7752197480de29e * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:74734688ffc9d2807cda0d1dc7752197480de29e * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:74734688ffc9d2807cda0d1dc7752197480de29e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b0c718c2d..f053b74423 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9c8188cae9..b08d2f11d8 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/fa679ed68e..7e70cdf64e * tools/skia_goldctl/linux: M9CSmdri8G3miQpGPQeqstBvQ3TtlngrsiF5GdSTYs0C..k1BjOmyoXU04uWkPPdUJ0M5Lta0srcmKIzHJ2Drj5FUC * tools/skia_goldctl/mac_amd64: Txs7Izu5kRGbcoAc9qESynBnBHo8RdRIyim5zF9rWbgC..Sql3pib8FeLV3AdnO-GPEkAXd1NeZc8m7_f0YWnV1h0C * tools/skia_goldctl/mac_arm64: LTzU4UbKV4zw61tWyttEX62vyq7nErr2gD8-jiH8IhgC..J-0YzIpDw8ezG6JvHcbzOWvz79hJIj9oA_P8yyfA-WkC * tools/skia_goldctl/win: UKiySjywM8juGVuMwWbOdaBXFD1TbzUOWcGGVTYfem0C..MISb1Ag5QQnBWhfkB8hBDYJRcEPDqzXrQrzBcSKUwx4C No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I4aa8e491e72d16c37037b8b1d42a3b501b706515 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6500074 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Matthew Denton cac1e824 2025-04-29T18:27:36 WGSL: Output driver uniform and UBO structs This is the WGSL half of the change to implement driver uniforms. Driver uniforms are implemented as a UBO and reuse the default set of driver uniforms. User-provided UBOs don't yet have variables outputted for them. This requires moving MSL's ReduceInterfaceBlocks to the tree_ops dir in order to change interface block definitions into struct definitions. Bug: angleproject:389145696 Change-Id: I27f3837b3d115f2ffac66cc545f3b60ca9f01cb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6477564 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Matthew Denton 4b69ba93 2025-04-28T16:45:56 WGPU: upload texture bind groups and configured samplers GLSL samplers are split into separate sampler/texture variables in WGSL. Before this CL, the WGSL translator generated shaders that look like: @group(1) @binding(@@@@@@) var ANGLE_sampler_samp2D : sampler; @group(1) @binding(@@@@@@) var ANGLE_texture_samp2D : texture_2d<f32>; @group(1) @binding(@@@@@@) var ANGLE_sampler_sampCube : sampler; @group(1) @binding(@@@@@@) var ANGLE_texture_sampCube : texture_cube<f32>; This CL replaces those with actual binding numbers @group(1) @binding(0) var ANGLE_sampler_samp2D : sampler; @group(1) @binding(1) var ANGLE_texture_samp2D : texture_2d<f32>; ... Such that @binding(n*2) is the WGSL sampler variable corresponding to the n-th GLSL sampler and @binding(n*2+1) is the WGSL texture variable corresponding to the n-th GLSL sampler. This CL then generates binding group layouts matching the above, and uploads textures and configured samplers in bind groups. This makes some of the deqp_gles2 tests 2d texture tests pass, though some fail because they need a flipped y coordinate. Not yet supported: 1. arrays of samplers 2. shadow samplers 3. cube textures Bug: angleproject:389145696 Change-Id: I2ab18ae5ebb4d1289101266bd9451576aa04ce2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6382272 Reviewed-by: Liza Burakova <liza@chromium.org> Auto-Submit: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi c884460a 2025-04-24T16:43:04 Vulkan: Fix deferred clears vs noop multidraw Bug: chromium:407828338 Change-Id: I5da22aeb72605bb7943fa5ae079ae297d00888f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6488794 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 9e6f44bc 2025-04-18T00:00:00 Autogen support checks for extension entry points As a side effect, added missing support checks for the following extension entry points: - GL_ANGLE_memory_object_flags - TexStorageMemFlags2DMultisampleANGLE - TexStorageMemFlags3DANGLE - TexStorageMemFlags3DMultisampleANGLE - GL_EXT_buffer_storage - BufferStorageEXT - GL_EXT_external_buffer - BufferStorageExternalEXT - GL_EXT_robustness - GetnUniformfvEXT - GetnUniformivEXT - ReadnPixelsEXT - GL_EXT_separate_shader_objects - ProgramUniform4ivEXT - ProgramUniform4uivEXT - GL_MESA_framebuffer_flip_y - FramebufferParameteriMESA - GetFramebufferParameterivMESA - GL_OES_matrix_palette - CurrentPaletteMatrixOES - LoadPaletteFromModelViewMatrixOES - MatrixIndexPointerOES - WeightPointerOES - GL_OES_query_matrix - QueryMatrixxOES - GL_OES_texture_cube_map - GetTexGenf*OES - TexGen*OES - GL_QCOM_framebuffer_foveated - FramebufferFoveationConfigQCOM - FramebufferFoveationParametersQCOM - GL_QCOM_texture_foveated - TextureFoveationParametersQCOM Bug: angleproject:409484297 Change-Id: I7fe05afe2a4575ae5d913bf9f60d5575404f808b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6494399 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev f6da7aed 2025-04-18T00:00:00 Fix UniformTest.GetUniformNoCurrentProgram Added the extension check and the result re-initialization. Fixed: angleproject:414491366 Change-Id: I04abc847a7fd48c411e62208e88c19d9d3f6ec50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6494452 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev ae70513d 2025-04-18T00:00:00 Remove NamedBufferStorageExternalEXT entry point OpenGL ES does not support DSA. Bug: angleproject:407932145 Change-Id: If5f544de2b43e05888415a4fc805ad6065d4408b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6495409 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 846dcf86 2025-04-18T00:00:00 Autogen context version checks for 2.0 entry points Bug: angleproject:409484297 Change-Id: I03b323ba5b8f9d45d41c0ff0188b3f7a7004722e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6490226 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Brian Sheedy f75980ad 2025-04-24T13:18:27 Switch Mac builders to Chromium pools Switches Mac builders to use the builderless luci.chromium.gpu.ci and luci.chromium.gpu.try pools. Existing capacity in those pools looks to be sufficient for the ANGLE traffic, so the increased load should be fine for a bit until the ANGLE capacity can get merged into those pools. Bug: chromium:375244064 Change-Id: I36aa7fa621b8472e0146a4510fe8b2bd9df10d7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6489488 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 828bec45 2025-04-26T16:12:56 Vulkan: Fix SPIR-V gen for constant constructors ... inside non-constant constructors of different basic type. The SPIR-V generator proactively casts the elements of the inner constructor to the type of the outer constructor, but it was mistakenly using the original inner constructor's type id for the constant instead of the cast type id. Bug: chromium:413775106 Change-Id: I95e8b1dcc1ba36777eb4475042f0d106a6abe109 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6489041 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 7e1b79c7 2025-04-28T03:01:09 Roll SwiftShader from 0e75e7030ccb to 7905fa19e456 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/0e75e7030ccb..7905fa19e456 2025-04-28 syoussefi@google.com Add present fence nullptr check 2025-04-25 swiftshader.regress@gmail.com Regres: Update test lists @ 0e75e703 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I86af16437003d33d5ee07eb71683d478d5678b73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6493795 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6c450a6f 2025-04-28T07:02:53 Roll Chromium from 85dd9668972f to dd275389e023 (760 revisions) https://chromium.googlesource.com/chromium/src.git/+log/85dd9668972f..dd275389e023 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/712b388807..88030b3203 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/954d9cf09b..0f32cb9025 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d95491c360..fe092931f1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/bb79a34585..917609c669 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/6cc4c9c768..f2a7f2987f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/64a6b82928..912274164f * third_party/r8/cipd: OYELKv1Z-yH4xw9qL3QhIZ6orhoBStNNpyWKTNudpjsC..bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/3e6bb2cf9f..926ec54499 * third_party/siso/cipd: git_revision:9c851ca205f34cd18a79d06619bc464d0adbd8ce..git_revision:70e1167e0e6dad10c8388cace8fd9d9376c43316 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/3c6290c68e..1e85c01b15 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/8bee61ea5a..60443ebac3 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/03e88ec76c..6c4f037a98 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7f2e9ee78a..9c8188cae9 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/9f9ef552e3..fa679ed68e Clang version changed llvmorg-21-init-6681-g5b36835d:llvmorg-21-init-9266-g09006611 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/03e88ec76cae47d81daa0120878ed041be49fe51..6c4f037a983abf14a4c8bf00e44db73cdf330a97/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: I5d281c6a667c56833a95d2d187e591f9d38a3c28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6493788 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kenneth Russell cdb34025 2025-04-25T12:09:14 Move robust APIs for PLS into robust_client_memory sections. These two entry points are at the intersection of GL_ANGLE_shader_pixel_local_storage and GL_ANGLE_robust_client_memory. Move them into the robust_client_memory section to simplify autogenerated validation. Rerun code generation. Fixed: angleproject:413597061 Change-Id: Icac160dbc7ab4088ee90471af60bb2e5ab3e1b87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6492427 Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 50707ca6 2025-04-18T00:00:00 Remove duplicate validation declarations Removed redundant function declarations and aligned function definitions with the autogenerated declarations. Bug: angleproject:409484297 Change-Id: Ieb49399ff28e64c4e6a84180a3190895f3c08e20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6491475 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kenneth Russell 9f49ccaa 2025-04-25T18:01:01 Re-enable clang-format for ANGLE. This was disabled globally for Chromium third-party projects, but ANGLE's code generator requires it in order to keep producing well-formatted code. Add a config file to re-enable it. Fixed: angleproject:413695650 Change-Id: If00ce844e3c98fd973f5414204676b7df8a7e321 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6492321 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org>
Alexey Knyazev 84e3b8f1 2025-04-18T00:00:00 Fix GetInteger64vRobustANGLE validation * Removed incorrect validation code. * Implemented capture support. * Added a new test. Fixed: angleproject:413595073 Change-Id: Ib84ae410fbd7a18d4a8bbb2545fe2952938088e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6491648 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Brian Sheedy 54f2d47b 2025-04-25T10:12:05 Add Chromium pools to shadow buckets Adds the Chromium CI and try pools to the ANGLE shadow buckets, as we are in the process of merging ANGLE builder capacity into those. Bug: chromium:375244064 Change-Id: Ia8e46958fe13dfd7c77f33165a236d83c2fcd362 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6492350 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 99eb1ceb 2025-04-25T10:01:17 Roll vulkan-deps from ac1b0b870946 to b9aab6c35f37 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ac1b0b870946..b9aab6c35f37 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5fc62e82624375e137eb22cddd8ab4fef6e159b1..fc9889c889561c5882e83819dcaffef5ed45529b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/7a6329b34b1652acfd685941ed1f5735200cf522..6530df51e0db74d50241c3a0f2c2798e99d0d9dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I2bc3f88374b8a359cf370be591e71cedb3a505bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6491548 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 34d30914 2025-04-25T08:50:00 Roll Chromium from 66b5465c817a to 85dd9668972f (684 revisions) https://chromium.googlesource.com/chromium/src.git/+log/66b5465c817a..85dd9668972f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bff69c88cf..712b388807 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/11c62a17df..954d9cf09b * buildtools/linux64: git_revision:10a27145cd0770b78745ff536e343bf12c70f6c3..git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c * buildtools/mac: git_revision:10a27145cd0770b78745ff536e343bf12c70f6c3..git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c * buildtools/win: git_revision:10a27145cd0770b78745ff536e343bf12c70f6c3..git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d6227eed1e..d95491c360 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/236644f7ef..91f1a3775e * third_party/android_build_tools/error_prone/cipd: S4diQnIcVdK3MuTHyXN2i5kG0uVfHGyPMBWoY1E6HqcC..-IrkxgAkj3RxGNBPp6b4r9OWZC6_dTbI-jC3c3UPgq8C * third_party/android_build_tools/lint/cipd: vBqKHQdjLFM5l79fpi3L9l7kD9b1FfeyfWbIFjXShSgC..gx4NrAApWUVG5HG3WJRIIzZrTssD6H5uGbKe0g77mucC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/783d02a67a..000f47cfa3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aacf07dc8b..1fcc527019 * third_party/fuchsia-sdk/sdk: version:27.20250417.1.1..version:27.20250424.2.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/89e9b96bc4..bb79a34585 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/1e5d08e2bb..64a6b82928 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/1a4051088b..56b98941c7 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f909247084..3c6290c68e * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/cc435e7883..8bee61ea5a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a52aa43e84..03e88ec76c * tools/luci-go: git_revision:46dc9663c6b2ff7d31445d2c95df66d47a186b3a..git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2 * tools/luci-go: git_revision:46dc9663c6b2ff7d31445d2c95df66d47a186b3a..git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2 * tools/luci-go: git_revision:46dc9663c6b2ff7d31445d2c95df66d47a186b3a..git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6d79107783..7f2e9ee78a * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/185329703b..9f9ef552e3 * tools/skia_goldctl/linux: hKSWrYU9Qzdtrd2pUbZRjTmxwuXcmoEdewPOmc32FGUC..M9CSmdri8G3miQpGPQeqstBvQ3TtlngrsiF5GdSTYs0C * tools/skia_goldctl/mac_amd64: Zbqt94b_gZ1sW3mOdHl8Sx3KJ84RvTXM97EZRfK8GSMC..Txs7Izu5kRGbcoAc9qESynBnBHo8RdRIyim5zF9rWbgC * tools/skia_goldctl/mac_arm64: cl6XLlO9RblHXS0BgfvMFir__8lQkWABqAep9A98wsUC..LTzU4UbKV4zw61tWyttEX62vyq7nErr2gD8-jiH8IhgC * tools/skia_goldctl/win: H07joOaPWSBVl_HtkPVP6Cnr6pB27Q6O0Qvuo68NugIC..UKiySjywM8juGVuMwWbOdaBXFD1TbzUOWcGGVTYfem0C No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I788211c24bab3deedda6b8c314ef9359d4095f9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6491569 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Aurora Zhang ef61ff8d 2025-04-24T16:18:34 Improve the judgement of texture and attachment completeness When the GL_TEXTURE_MIN_FILTER is not mipmap, that is GL_LINEAR or GL_NEAREST, ANGLE should allow the texture's base level greater than the max level. The spec does not consider this situation as texture incomplete. Also, attachment completeness should ignore mipmap completeness when selected level is the base level. Hence, increase a constriction in CheckAttachmentCompleteness and end2end test Texture2DBaseMaxTestES3.Fuzz545ImmutableTexRenderFeedback. Bug: angleproject:42267266 Change-Id: I6a41f7d0716a7c9506b82390e2c0b083ab1626a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6197735 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com>
Cody Northrop 4429afe9 2025-04-23T23:47:26 Tests: Add Black Beacon trace Test: TraceTest.black_beacon Bug: b/413215850 Change-Id: Iecbb4d2b4a251943857fd3d945318cec29c1b37f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6487386 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev d08e9e9c 2025-04-18T00:00:00 Fix use of OpenGL ES 2.0 commands in ES 1.0 tests Bug: angleproject:409484297 Change-Id: I0186e23074ec7ac6cfae9d04645923d6acb163f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6487928 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 272ffbda 2025-04-18T00:00:00 Enhance entry point validation autogen scripts Ensured that complete information about entry point sources is available when generating context checks. Bug: angleproject:409484297 Change-Id: I7a2546c11b212df2ddf194d26be6e0d31d108b29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6488171 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Julie Jeongeun Kim ca959767 2025-04-15T22:28:04 Include IOKit.framework with `is_mac || angle_enable_cgl` This includes IOKit.framework with `is_mac || angle_enable_cgl` since it’s needed from SystemInfo_macos.mm which includes IOKit and the file is included with `is_mac || angle_enable_cgl`. It fixes the compilation error on tvOS. Bug: b/391914246 Change-Id: I6fb8372d50ea16301f20f985cfa0d4835caec9e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6459200 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Neil Zhang e5680ba6 2025-04-14T17:43:07 Fix mInFlightCommands.empty() assert in CommandQueue destroy When initialize a higher priority shared Context, ANGLE internal call updateContextsPriority to submit previously flushed commands. This submission is not tracked by any Context. Add Renderer::mSubmittedResourceUse to record submitted queue serials not belonging to any Context to fix the assertion. Bug: angleproject:410996556 Change-Id: I7a91e47c0233832b8806637f295dffd1ff54f729 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6458623 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Neil Zhang <Neil.Zhang@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya ff110c86 2025-04-23T15:42:34 Early-return instead of rebinding the same subject Bug: angleproject:386749841 Change-Id: I190f9bd7a7c492bdd263a624e835abefabfab560 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6484560 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Greg Schlomoff 88710dc1 2025-04-22T13:57:57 Bumping astc-encoder version to 5.2.0 (latest release) Bug: angleproject:410591544 Change-Id: I8a12be4c0ed60f843fa3c16a8e23693d8fb7a7e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6480556 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll be0788b9 2025-04-24T10:01:21 Roll vulkan-deps from 2e021a754b60 to ac1b0b870946 (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2e021a754b60..ac1b0b870946 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/697683e6b8871420d7d942b1a2fe233242ab5608..5fc62e82624375e137eb22cddd8ab4fef6e159b1 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/4d00ce442899842d428925af30fa602cdd808768..b3d30057b15273ce449bb9952e15e65b3f556723 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/aa6cef192b8e693916eb713e7a9ccadf06062ceb..bab63ff679c41eb75fc67dac76e1dc44426101e1 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/506fee4dfaa52d336ba03225ced30b608ced1a13..b6a83226d75d15b1733d35ee9e26b8f895ecffcb https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/084289634c9294355c87e7ad8e4ae8f7dfa29701..0b8196724e4ad28cc7459b82a9b75f252c08cb3e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/aa63071dd9698b6f76861599f441739d417816f4..7a6329b34b1652acfd685941ed1f5735200cf522 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Icbccf6709ddfa27777433f0d93914b72868ca221 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6485617 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1e4ad682 2025-04-24T07:31:38 Roll Chromium from 90de43ba04db to 66b5465c817a (568 revisions) https://chromium.googlesource.com/chromium/src.git/+log/90de43ba04db..66b5465c817a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1fe2149e04..bff69c88cf * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2f8492decc..d6227eed1e * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/71b107dcca..1ea2115b17 * third_party/android_toolchain/ndk: Idl-vYnWGnM8K3XJhM3h6zjYVDXlnljVz3FE00V9IM8C..KXOia11cm9lVdUdPlbGLu8sCz6Y4ey_HV2s8_8qeqhgC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7479767b38..783d02a67a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f40ddcd8d5..aacf07dc8b * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8c7a5ae5a8..6cc4c9c768 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/161b473211..1e5d08e2bb * third_party/r8/cipd: 6qLey8EBp9ivhThnqVPWy2ZDGpsf5Y29EsTbi_rZ1pMC..OYELKv1Z-yH4xw9qL3QhIZ6orhoBStNNpyWKTNudpjsC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/9fe2e70405..3e6bb2cf9f * third_party/siso/cipd: git_revision:3236848f55721ee59d3cf7c5d3d33c75aaeec4f2..git_revision:9c851ca205f34cd18a79d06619bc464d0adbd8ce * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/780819f635..f909247084 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/dad6969cdc..cc435e7883 * tools/luci-go: git_revision:cd0142e4e2f376bb0bd1b34a3b91167aff5226bf..git_revision:46dc9663c6b2ff7d31445d2c95df66d47a186b3a * tools/luci-go: git_revision:cd0142e4e2f376bb0bd1b34a3b91167aff5226bf..git_revision:46dc9663c6b2ff7d31445d2c95df66d47a186b3a * tools/luci-go: git_revision:cd0142e4e2f376bb0bd1b34a3b91167aff5226bf..git_revision:46dc9663c6b2ff7d31445d2c95df66d47a186b3a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/513c187fa0..6d79107783 * tools/skia_goldctl/linux: 6hngM1Lz4CZyOFlV0d4RR_AL72majX3_at0EXTbss-wC..hKSWrYU9Qzdtrd2pUbZRjTmxwuXcmoEdewPOmc32FGUC * tools/skia_goldctl/mac_amd64: 95q5Vsqlu7ZRlbrgkX4yr1op_sROdXCg-EckuzgcC34C..Zbqt94b_gZ1sW3mOdHl8Sx3KJ84RvTXM97EZRfK8GSMC * tools/skia_goldctl/mac_arm64: unF__7VpyFxTLUwFdsAvqF9qfT7Mfb-s9ldVpIM-0r8C..cl6XLlO9RblHXS0BgfvMFir__8lQkWABqAep9A98wsUC * tools/skia_goldctl/win: HvMKm9gOGQr6oi58UtPQVb5ijKhPEHckXFlWfE3-3mEC..H07joOaPWSBVl_HtkPVP6Cnr6pB27Q6O0Qvuo68NugIC No update to Clang. Bug: angleproject:42267266 Tbr: solti@google.com Change-Id: I07b649a037739be0747319fffdc0ec9e3ef86228 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6485613 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 4c1c7c08 2025-04-18T00:00:00 Include entry point names in error messages Moved entry point name injection to ErrorSet::validationError to ensure that error messages handled via GL_KHR_debug always contain the corresponding entry point names. Updated affected tests. Fixed: angleproject:412384507 Change-Id: I9e898cadca0634505d70b36dbbb00feedb6c10b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6480177 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev 56b62c62 2025-04-18T00:00:00 Include entry point names in context lost error messages Also added "likely" hints to valid context branches. Bug: angleproject:412384507 Change-Id: I6fc2c4a5934b767f55742f4657fec7ae954f1387 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6479959 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d392eeae 2025-04-22T10:54:13 Vulkan: Force host-image-copy for LUMA textures on ARM Bug: angleproject:42266771 Change-Id: I79a8fe14ba389195d5846261752be847bc13bcf4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6479371 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Xin Yuan cdcf6a63 2025-04-22T10:19:33 Add R10X6G10X6B10X6A10X6 support on angle Bug: angleproject:409355677 Change-Id: I8115ca73a038360f673552532e9d9b87ff846867 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6438114 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 555038b8 2025-04-23T12:47:02 Translator Fuzzer: Enable required options Bug: chromium:409603851 Change-Id: I73067fcd3855f6cdcb6eea05b06bafa45d23fb19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6482917 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Peng Huang d698500d 2025-04-08T09:05:42 Fix an ASSERT() crash in ExternalFence SyncWaitFd(). https://registry.khronos.org/vulkan/specs/latest/man/html/vkGetFenceFdKHR.html If pGetFdInfo->handleType is VK_EXTERNAL_FENCE_HANDLE_TYPE_SYNC_FD_BIT and the fence is signaled at the time vkGetFenceFdKHR is called, pFd may return the value -1 instead of a valid file descriptor. So when above scenario happens, ANGLE will get a -1 fd from vkGetFenceFdKHR(), and then Angle will call SyncWaitFd() with the invalid fd, it will cause an ASSERT() crash. Bug:angleproject:409342980 Change-Id: I48d4d21d531e40f8ba275918454632ae14fec04b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6439303 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Igor Nazarov 691140da 2025-04-22T21:05:44 Vulkan: Do not skip VUID-vkQueueSubmit-pSignalSemaphores-00067 ... when "VK_EXT_swapchain_maintenance1" is enabled. Original problem is a VVL bug, introduced in: 62e9314e2eb9c58af42f6f1b613d200d5362598d layers: Track semaphore is in use by swapchain It was later partially fixed in: 88934ae6acf0c8b8ae169df9607e779ac4a70239 layers: Fix waiting on present fence did not have effect Bug is only fixed when using present fences (when "VK_EXT_swapchain_maintenance1" is enabled). Without present fences, VUID error still prints the following: Swapchain image 0 was presented but not re-acquired, so VkSemaphore 0x41c700000041c7 may still be in use and cannot be safely reused with image index 0. a) Use a separate semaphore per swapchain image. Index these semaphores using the index of the acquired image. Since problem only happens in a shared present mode, re-acquiring the image causing "VUID-vkAcquireNextImageKHR-surface-07783". It is also unclear from the Vulkan spec if the image may be re-acquired in shared present mode, but it is currently not necessary. When not using present fences, ANGLE tracks present semaphores by attaching submit serial to the previous present operation when same image is presented. This guarantees to use more than one present semaphore (in a shared present mode) and not to reuse semaphore with signal operation pending. This is more strict synchronization than what is suggested by the VUID error in the item (a). However, it is debatable if this is ANGLE's or VVL error. If it is not a VVL error, it at least should provide correct message of how to fix the problem in case of a shared present mode. Theoretically, ANGLE may fix this error by only using present semaphore for the initial present, and skip it for all subsequent present operations, since image is already shared with the presentation engine and present operation is only used for notification purposes. Bug: angleproject:408190758 Change-Id: Id0dc3c0efcba72e844ba6b2c241d0076f70fcd51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6480175 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 35c550a4 2025-04-23T10:01:46 Roll vulkan-deps from c70bb7aae968 to 2e021a754b60 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c70bb7aae968..2e021a754b60 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/84581c2f9ec4c57775eef9794bc243b1a07c6e5f..697683e6b8871420d7d942b1a2fe233242ab5608 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/ca63ea568b41d461dd25fa588350008b5ab00c89..506fee4dfaa52d336ba03225ced30b608ced1a13 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/0451ee4cdb5f9fa6eeafffa4d5078c7af1764ecf..aa63071dd9698b6f76861599f441739d417816f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ibd2719c03a1587e8b5f06a1d988b7845b5d911e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6478642 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6f80d081 2025-04-23T07:41:58 Roll Chromium from fda9025645de to 90de43ba04db (622 revisions) https://chromium.googlesource.com/chromium/src.git/+log/fda9025645de..90de43ba04db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b053741cf1..1fe2149e04 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/efa06a1b81..11c62a17df * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7e0c9e50bf..2f8492decc * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/37963b19ef..fe3242a8c8 * third_party/android_build_tools/manifest_merger/cipd: YZTHR6AILB1hD0-rYZg-7nxgKXyF3D2jOXsHl2VHS68C..HhXknpcPosMUDHZQD-8Ogve-HaG4HmJ4p082zKKAcnMC * third_party/android_build_tools/nullaway/cipd: Br9gBQM1eYGrSHKahSZ-WTQPlz-YegUJ9mvraq3UajUC..F6la8NsEkr27_Sm2MswVDBDB7UXVqRtaCMS5YWEQ9dQC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/fdc724d718..7479767b38 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/105734247b..89e9b96bc4 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/b3dba614ba..161b473211 * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/a708003188..9f916e90e6 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f2f11f2ee5..dad6969cdc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ae44e0ff54..513c187fa0 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ibd8c113510da1478bebd1b5b0cf5bdc3c59a470d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6478641 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 6f9f343a 2025-04-16T14:45:33 Reland "Vulkan: Prune superseded updates during host-image-copy" This is a reland of commit f8a8adf63c5834a725d1bd752acc6d63c3f45c05 Original change's description: > Vulkan: Prune superseded updates during host-image-copy > > Bug: angleproject:42266771 > Change-Id: I7aa8e85720a54537389df615b575ddfa9951770d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6462475 > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Cody Northrop <cnorthrop@google.com> Bug: angleproject:42266771 Change-Id: I95e6f1d2421327a6394e627f03ef5b4cddf4a1e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6480011 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Mavis Deng 3c554454 2025-04-03T16:55:11 Incorrect BUFFER_DATA_SIZE and UNIFORM_OFFSET for ACB array of array The buffer size and offset calculation for the atomic counter buffer defined as an array of arrays is incorrect. The issue occurs with the following declaration: layout (binding=0, offset=0) uniform atomic_uint ac[2][2]; Observed Results: GL_BUFFER_DATA_SIZE -> 8; GL_UNIFORM_OFFSET of "ac[1][0]" -> 0; Expected Results: GL_BUFFER_DATA_SIZE -> 16; GL_UNIFORM_OFFSET of "ac[1][0]" -> 8; Bug: angleproject:407564097 Change-Id: Ibf99ccd5412629f0feb74a9a34337b82894e74c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6429625 Auto-Submit: Mavis Deng <mavis.deng@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Alex abe3c63a 2025-04-16T15:30:10 Add CubeMapBug2 test to trigger Angle bug in validation Add one extra texture sampler in fragment shader and adjust texture binding unit for textures Bug: angleproject:401546698 Change-Id: Ib5c3482a243075a98f1ce1b1f4d4cc9884f5f980 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6458622 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 61bfe86c 2025-04-04T00:00:00 Autogen context version checks for 1.0 entry points * Added missing extension support checks for glPointSizePointerOES and glDrawTex*OES. * Removed incorrect validation from ValidateDepthRangex. * Removed unused functions. Bug: angleproject:409484297 Change-Id: I9c12be4c0ed60f943fa3c16a8e23693d8fb7a76f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6479833 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Tingwei Guo 3f88a505 2025-04-03T17:29:20 GenerateMipmap encode and decode sRGB when GL_SKIP_DECODE_EXT is set According to the spec, if TEXTURE_SRGB_DECODE_EXT is set before GenerateMipmap for a texture with format sRGB, mipmap generation should skips the encode and decode steps during mipmap generation, matching the mipmap generation for a non-sRGB texture. Bug: angleproject:406829410 Change-Id: Icea8c27a1ab2f20e9fd6c8d79187c0c5cfe8e789 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6428506 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Tingwei Guo <tingwei.guo@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi 50a4ad19 2025-04-22T09:29:17 Revert "Vulkan: Prune superseded updates during host-image-copy" This reverts commit f8a8adf63c5834a725d1bd752acc6d63c3f45c05. Reason for revert: Has a bug in the calculation of image layers whose updates should be dropped. Bug: angleproject:42266771 Original change's description: > Vulkan: Prune superseded updates during host-image-copy > > Bug: angleproject:42266771 > Change-Id: I7aa8e85720a54537389df615b575ddfa9951770d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6462475 > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Cody Northrop <cnorthrop@google.com> Bug: angleproject:42266771 Change-Id: I2b992c8598f58c40386338ade3cf59ffdb03abd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6480413 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Alexey Knyazev 69a0fc24 2025-04-04T00:00:00 Use dedicated error messages for context version checks To highlight that the command itself is not supported rather than any of its parameters. Bug: angleproject:409484297 Change-Id: I573e935b3179bb1001267b383a1efa4cf48a7197 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6479832 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev db12f43b 2025-04-04T00:00:00 Autogen context version checks for 3.0 entry points * Added a missing version check for the GetBufferParameteri64v entry point. * The following commands are now rejected on ES 2.0 even if the GL_OES_texture_3D extension is enabled: * CompressedTexImage3D * CompressedTexSubImage3D * CopyTexSubImage3D * TexImage3D * TexSubImage3D Bug: angleproject:409484297 Change-Id: I82374157596fd292efbf67c6bb582eb874348b73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6469895 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 12fcd01d 2025-04-22T10:01:19 Roll vulkan-deps from 61080f55d11e to c70bb7aae968 (17 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/61080f55d11e..c70bb7aae968 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c4dff68eb4301a1587352150227af2eced0c1017..84581c2f9ec4c57775eef9794bc243b1a07c6e5f https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/611ceb1ec2d608504a6aec450858746500bd78e9..4d00ce442899842d428925af30fa602cdd808768 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/b1fc6158fd3da69cd16b1e261e0e84f1f3bed89f..084289634c9294355c87e7ad8e4ae8f7dfa29701 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/86aab8ea05672b6db3788fc6bbfe166f63581ef0..0451ee4cdb5f9fa6eeafffa4d5078c7af1764ecf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ic72a8ae780fe22dc5f4d66e5055d46c65e25dfcb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6478671 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5bc78fca 2025-04-22T09:03:33 Roll VK-GL-CTS from 76c1572eaba4 to dd7e71367795 (10 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/76c1572eaba4..dd7e71367795 2025-04-22 scerveau@igalia.com Add optional fetch_video_samples.py 2025-04-22 piotr.byszewski@mobica.com Add json file containing cases for which vvl errors are allowed 2025-04-22 pdaniell@nvidia.com Add VK_NV_coverage_reduction_mode support to mixed_attachment_samples tests 2025-04-22 jbolz@nvidia.com Add cooperative matrix test variants that pass coopmat types by value 2025-04-22 lorenzo@khronosgroup.org Update libpng pointers to get it from github 2025-04-22 mateusz.bahyrycz@mobica.com Add tests for api copying with large and unaligned size 2025-04-22 piotr.byszewski@mobica.com Test ShaderNonUniform without runtimeDescriptorArray feature 2025-04-22 rgarcia@igalia.com Use multiple triangles and geometries in RT vertex position fetch tests 2025-04-22 rgarcia@igalia.com Add test for unaligned spec constant access 2025-04-22 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I69607475cf0ab7e3e2a1209e2b6a39c2856be478 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6478790 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3c30881b 2025-04-22T08:40:37 Roll Chromium from ea07a56dbf64 to fda9025645de (411 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ea07a56dbf64..fda9025645de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0e5430a494..b053741cf1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/729495f2ff..efa06a1b81 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ff39f83329..7e0c9e50bf * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/c17f4e2d0d..9fe2e70405 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4bbc1c3d28..ae44e0ff54 * tools/skia_goldctl/linux: t1Emdw6PaIKIs6zuhT4Jv1SVmIPsiB-_OGkwIzc0BtoC..6hngM1Lz4CZyOFlV0d4RR_AL72majX3_at0EXTbss-wC * tools/skia_goldctl/mac_amd64: 6v2TEuvoNIrNOIR3dEzYsXzvNdjmIam5F5qHkGC5g-cC..95q5Vsqlu7ZRlbrgkX4yr1op_sROdXCg-EckuzgcC34C * tools/skia_goldctl/mac_arm64: ZeclbMtb_nac9gGzvgJV0l1UiqLbHCf8r6beXS_CHQEC..unF__7VpyFxTLUwFdsAvqF9qfT7Mfb-s9ldVpIM-0r8C * tools/skia_goldctl/win: 8u2EjPLoMc270uyI6PDDJp7-7MZmdS9dFJWNYnu8XC8C..HvMKm9gOGQr6oi58UtPQVb5ijKhPEHckXFlWfE3-3mEC No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I38be833723ee84d95e3456f659afa01921e72fc8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6478670 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 81f1a733 2025-04-04T00:00:00 Fix use of OpenGL ES 3.0 commands in image tests Fixed tests that used OpenGL ES 3.0 commands instead of extensions when running on lower context versions. Bug: angleproject:409484297 Change-Id: Ie220acbf8d1d287e3e19a52307ac3625d2f29c9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6469896 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 962e147a 2025-04-21T10:01:09 Roll vulkan-deps from 5880b384399b to 61080f55d11e (17 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5880b384399b..61080f55d11e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ba1640446f3826a518721d1f083f3a8cca1120c3..c4dff68eb4301a1587352150227af2eced0c1017 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/1104d6ad976fa118b41b6312521488efad3f004d..611ceb1ec2d608504a6aec450858746500bd78e9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/a8513ac9d0e367c5914095d0b7f09a081a14b4b5..fb78607414e154c7a5c01b23177ba719c8a44909 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/50ace769d381f746d7d6cb75db982fa4d94a112f..b1fc6158fd3da69cd16b1e261e0e84f1f3bed89f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/4ee0833a3cdb834aa71c2b77ce5b01235b7b7170..4e246c56ec5afb5ad66b9b04374d39ac04675c8e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b8771d6a9b7f9ed2c0f42e33fef2c8edbf2e73cb..86aab8ea05672b6db3788fc6bbfe166f63581ef0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I77738a56c4721eef7ac54b1af497f1c4b6200099 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6474855 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b0fc13f8 2025-04-21T08:13:37 Roll Chromium from a3c80076ee75 to ea07a56dbf64 (376 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a3c80076ee75..ea07a56dbf64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/40000cd9de..0e5430a494 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/be957e3dcf..729495f2ff * testing: https://chromium.googlesource.com/chromium/src/testing/+log/bcb6f5005f..ff39f83329 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/cb314c218c..71b107dcca * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/323c3f8758..fdc724d718 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/5803cf1918..105734247b * third_party/siso/cipd: git_revision:55fb4e14c1c6ab0f170fe3cc145c7469c5f2e919..git_revision:3236848f55721ee59d3cf7c5d3d33c75aaeec4f2 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I02b16a38b7484e555feaa812eccaf3c159b4c0de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6474688 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi f355e2b3 2025-04-15T18:58:25 Vulkan: Remove preferDriverUniformOverSpecConst This was practically true for every vendor on Android (where rotation matters). For Qualcomm, it was also true due to a bug in version checking and didn't seem to be causing any concerns. Where pre-rotation is supported, it is better to enable this feature to avoid excessive pipeline creation. This change removes the feature and makes sure ANGLE always uses uniforms for rotation instead of spec consts. While technically this may have an adverse effect on platforms that never need pre-rotation, the ability is retained for all vendors since pre-rotation is finding its way into more platforms and would likely eventually be needed everywhere anyway. Bug: angleproject:42265878 Bug: angleproject:42262166 Change-Id: I4b64c04da46db08cfdd44b60789b66d93d8e8b17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6459025 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: mohan maiya <m.maiya@samsung.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Le Hoang Quyen 07eeca12 2025-04-17T20:58:19 Metal: prevent padding in state cache's structs. Fixed: angleproject:411845677 Change-Id: I8a9635634e66f86c132205f75825a916481f7ad0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6468239 Commit-Queue: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Le Hoang Quyen f6a350de 2025-04-17T20:43:08 Metal: fix rasterSamplecount not used in comparing render passes. RenderPassDesc's rasterSamplecount was not used to comparing two render passes' descriptors. Note: no reported bug found related to this missing comparison yet. This bug most likely affects render passes without any attachment (PLS?). Because if the 2 render passes have the same attachments, their rasterSamplecount values must also be equal. There was also a missing rasterSamplecount comparison in RenderPipelineOutputDesc::operator==. However, this function is not used. When comparing two render pipelines, RenderPipelineDesc::operator== is used instead, which is currently implemented using memcmp. So removing the former to avoid confusions. Bug: angleproject:411845677 Change-Id: Ic9b1867226561d096c1fb8ca2194b657d29daa18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6468238 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll d4336f18 2025-04-18T21:11:15 Manual roll Chromium from 5d2f55eb5444 to a3c80076ee75 (831 revisions) Manual roll requested by yuxinhu@google.com https://chromium.googlesource.com/chromium/src.git/+log/5d2f55eb5444..a3c80076ee75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/01dc1e19fb..40000cd9de * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/015ef44748..be957e3dcf * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a5ca4e9e71..bcb6f5005f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/0c43a32e20..236644f7ef * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/cd3ef01e66..37963b19ef * third_party/android_build_tools/manifest_merger/cipd: V6nA9cUoZlv01Hj7gY0rG-mLJ80GjclSrqcjE2vjamUC..YZTHR6AILB1hD0-rYZg-7nxgKXyF3D2jOXsHl2VHS68C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/00813b8839..cb314c218c * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4c05962192..5803cf1918 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f833dca6f0..8c7a5ae5a8 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/1b77fbeb05..b3dba614ba * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/0234f44c5f..1a4051088b * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/fead5a71b0..c17f4e2d0d * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/4abaa1429e..f2f11f2ee5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f549458617..a52aa43e84 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/05e0bc764a..4bbc1c3d28 * tools/skia_goldctl/linux: Ygv7ZB2vTXUWbXtH1I2DNMSB1D7GkvpabMuyVEJpINAC..t1Emdw6PaIKIs6zuhT4Jv1SVmIPsiB-_OGkwIzc0BtoC * tools/skia_goldctl/mac_amd64: yNIr-9hJd-v5rwyRRQk5z9eBz_Ru52p8YTOc-WHIoBgC..6v2TEuvoNIrNOIR3dEzYsXzvNdjmIam5F5qHkGC5g-cC * tools/skia_goldctl/mac_arm64: zQOaSHuVEWVro28b0D6FdKiq5f8KhkMG_XOFqAdgoIUC..ZeclbMtb_nac9gGzvgJV0l1UiqLbHCf8r6beXS_CHQEC * tools/skia_goldctl/win: DWI5tbnr7u5QE7UFkrzeJI3hqZyLqA8E_xOqOpNU0vgC..8u2EjPLoMc270uyI6PDDJp7-7MZmdS9dFJWNYnu8XC8C No update to Clang. Bug: angleproject:411721483 Tbr: yuxinhu@google.com Change-Id: I812fc9cbdf684bfcb1ab9f23e92a3cdad4566f21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6472633 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi f8a8adf6 2025-04-16T14:45:33 Vulkan: Prune superseded updates during host-image-copy Bug: angleproject:42266771 Change-Id: I7aa8e85720a54537389df615b575ddfa9951770d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6462475 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi a9f2f87f 2025-04-15T13:46:34 Vulkan: Update version macros * Updated the deprecated version macros * VK_VERSION_MAJOR -> VK_API_VERSION_MAJOR * VK_VERSION_MINOR -> VK_API_VERSION_MINOR * VK_VERSION_PATCH -> VK_API_VERSION_PATCH * VK_MAKE_VERSION -> VK_MAKE_API_VERSION * Added a separate case for QCOM drivers in getVersionString(). * The major version is now OR-ed with 512. * (New drivers seems to have a major version of 512, which falls not within the major field, but the variant field, when using the VK_API_VERSION_x macros.) Bug: angleproject:42267006 Change-Id: Ic9b761d182ff49c3ede43c7bd14f366f945fbf36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6460682 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 151a9ed2 2025-04-18T03:01:08 Roll SwiftShader from 2d70dae3d0ca to 0e75e7030ccb (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/2d70dae3d0ca..0e75e7030ccb 2025-04-17 cwallez@chromium.org Add -Wno-unknown-warnings in llvm-10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I32a3d9679c3f05ac10a29c0aba5bc176d6ebe935 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6470944 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4928b7f7 2025-04-18T10:01:01 Roll vulkan-deps from b552240b4d50 to 5880b384399b (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b552240b4d50..5880b384399b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/096bb07f71d33111f9748816cd986e616ec10776..ca63ea568b41d461dd25fa588350008b5ab00c89 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/110b6c989ccb4e874089db777e2b54eb9abb5670..409c16be502e39fe70dd6fe2d9ad4842ef2c9a53 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/eb3cb1d71f5b548bc3cd54af98dd2092d2269b62..b8771d6a9b7f9ed2c0f42e33fef2c8edbf2e73cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Iec6e41c0c966a8fbb4759356f9729766832f707a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6472625 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0