kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi 7691cea7 2024-07-22T13:46:14 Vulkan: Remove seamful cubemap emulation Practically, the Vulkan backend is never expected to run on ES2 hardware. It _may_ for WebGL, but seamful cubemap emulation was disabled for webgl anyway. Bug: angleproject:354729454 Change-Id: Iafa20fbdbe232c4df4c777b12e7698ef7a87cf24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5730143 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Alexey Knyazev 0d458614 2024-07-18T00:00:00 Vulkan: Fix PBO readbacks with small row length Use CPU path when the row length is smaller than the source area width. Fixed: angleproject:354005999 Change-Id: I5c4686ca5387a98c6137868afb19c333aed8ac21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5724591 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 975674ea 2024-07-18T00:00:00 Metal: Fix PBO readback failures with small row length Do not use blits when the row length is smaller than the source area width to avoid Metal validation failures. Bug: angleproject:354005999 Change-Id: Ifa0f29a0d1d2fb3275ea254957c24f36807e6f66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5724790 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Igor Nazarov e37c79d4 2023-11-23T15:59:12 Fix DecompressBlob() when compressed data is invalid Function uses `zlib_internal::GetGzipUncompressedSize()` to calculate the `uncompressedSize`. This size comes directly from `compressedData`. If source data is invalid or has different format, then calculated size may be any value, including 0. Zero `uncompressedSize` cases ASSERT() in `angle::MemoryBuffer::data()` and may case UB in `zlib_internal::GzipUncompressHelper()`. Bug: chromium:1485277 Change-Id: Iaa92d93a5a1b530b8686cfb544eb66075b0874e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5729953 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll fb4cdb18 2024-07-22T10:01:42 Roll vulkan-deps from edbbcd521ef6 to be96f8cab214 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/edbbcd521ef6..be96f8cab214 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/52f68dc6b2a9d017b43161f31f13a6f44636ee7c..dc9f6f61adaec755a09e1943cf7014c688443bcb https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/4c7e1fa5c3d988cca0e626d359d30b117b9c2822..626dfbff49b53a5d054d4437d3bf3aa9ef85a6ee https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/53a6ba7c235cbe0b0f3e85e3de6d9070bcfec710..2cee0d5b1d8c34e26fd6d9992d3d428ac4c5139d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/9479047902e8031210b1bb33a8850e32b313dd25..67522b34edde86dbb97e164280291f387ade55fc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/edcf314e81d9866e783ce55855fd1dc482b263e1..919599474e6e6639527e7c3775ed1064665412d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I5ed6f934ffbdfda3fcfc634e6b0a7b351dd3e93f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5725804 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d44a3032 2024-07-22T08:17:56 Roll Chromium from 06c75e7c6658 to 9739f7f11240 (859 revisions) https://chromium.googlesource.com/chromium/src.git/+log/06c75e7c6658..9739f7f11240 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9ad8e1f7a1..7a8285c06a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/adc2a53a41..3ef44a2b92 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3f18920b3c..926b0906b1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/786400210f..1699936526 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c81122f69..28a7eef132 * third_party/siso/cipd: git_revision:b41f9eaf44dfdaec51ab2d7089aaa4cb6d9e7f5e..git_revision:50a6db5dae3978d2d2e8dce29f6df024dde48d1b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/03072f076e..f808d81be6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3eba5f340c..4dc76da47b * tools/luci-go: git_revision:c9c95dda5f310610a3fc574af44faeed298b3938..git_revision:771ea9a614a104c71655f699ef82219a2a474817 * tools/luci-go: git_revision:c9c95dda5f310610a3fc574af44faeed298b3938..git_revision:771ea9a614a104c71655f699ef82219a2a474817 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f6e1f7aa05..fd08f81f15 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: If591c19a281d6bbb7ca5ab9d9796964b9969c316 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5726770 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 85edb907 2024-07-17T19:09:09 Vulkan: Remove the adjustClearColorPrecision feature for new driver The vulkan driver issue that this feature tries to workaround is resolved in the new driver. Remove the feature workaround. Bug: b/292282210 Change-Id: I541526e71d5312f1a23b5a415e96d5b966e77f2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5719652 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Solti Ho <solti@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 93491ae3 2024-06-21T08:04:24 FrameCapture: Handle active texture in MEC When restoring texture bindings and contents, we need to first set the correct GL_ACTIVE_TEXTURE, otherwise it will use existing active texture bindings and update the wrong textures. Test: Grand Mountain Adventure MEC Bug: angleproject:345851268 Change-Id: I7c6c4a918513d4216405efe51774fcce4b49b45e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5647491 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Devon Loehr 1fe50b44 2024-07-16T20:12:06 Make implicit `this` capture explicit When declaring a lambda with a value-capture default [=, ...], the this pointer is implicitly captured by value as well. This results in potentially-unintuitive behavior and has been deprecated in C++20. It produces a warning in newer versions of clang (https://reviews.llvm.org/D142639). This CL prevents the warning by explicitly `this` for each lambda. To maintain compatibility with previous C++ standards, it also removes the = capture default and captures each variable explicitly. It does not change the compiled code at all, since it's just removing some syntactic sugar. Bug: chromium:351004963, angleproject:42266730 Change-Id: I0f17a442262e2da22a1951d590291806554e66ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5714410 Auto-Submit: Devon Loehr <dloehr@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop 327796df 2024-06-24T10:58:28 FrameCapture: Add a new CapturedTest for glActiveTexture This CL adds a new test focused on Reset of glActiveTexture. It doesn't just add a new frame since the original test was getting quite cluttered. This should provide a blueprint for adding more tests in the future. Test: capture_tests.py Bug: angleproject:345851268 Change-Id: Ieac29031f55ca133d81ce5ba26d45199de38e874 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5714395 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Brian Sheedy 0364ac4a 2024-07-18T13:18:33 Set up ANGLE shadow buckets Sets up ANGLE shadow buckets so that LED jobs can be triggered now that real builds are the only supported path. This was effectively copied from Chromium's configuration but with the relevant pools, service accounts, etc. swapped out for ANGLE ones. Bug: chromium:353904289 Change-Id: Idd958faf73d9d62180151f4a72817fb1543f208f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5723088 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll fa940e36 2024-07-19T10:01:36 Roll vulkan-deps from 4b8a413b6b64 to edbbcd521ef6 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4b8a413b6b64..edbbcd521ef6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/b0bf54958137fcd9800848ef3ecb5fa6be871803..9bd6f95db3076517205b01300c8d37043c5b2dd3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/b379292b2ab6df5771ba9870d53cf8b2c9295daf..fabe9e2672334fdb9a622d42a2e8f94578952082 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/58428b0c0e9cb818ee240857c5b4725df8c5183e..edcf314e81d9866e783ce55855fd1dc482b263e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I2d7bbec905717a5627e3bfee0b5148274d59fc43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5725208 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 16376d10 2024-07-19T07:56:45 Roll Chromium from b5eaffbef1cb to 06c75e7c6658 (597 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b5eaffbef1cb..06c75e7c6658 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ad2f859fc3..9ad8e1f7a1 * buildtools/reclient: re_client_version:0.148.0.41b09b51-gomaip..re_client_version:0.150.1.d9707319-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b42459f242..3f18920b3c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/29445d0e3f..786400210f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b4102e43a0..1c81122f69 * third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/e582d7f0ed..6638e9b0a7 * third_party/six: https://chromium.googlesource.com/chromium/src/third_party/six/+log/32c68ae5c1..580980eb7d * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b9d53fb8e5..03072f076e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a5953b107d..3eba5f340c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/88e2a478ee..f6e1f7aa05 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/e10259da24..f9f02d66ab No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Iea120e253eccb066f4097e11122457aed3fe219b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5724330 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 0e598a0c 2024-07-17T09:49:19 FrameCapture: Unbind PIXEL_UNPACK_BUFFER for texture restore When restoring textures, we need to ensure the PIXEL_UNPACK_BUFFER is not bound, as that will influence where we pull data from. Allow per-context reset to restore the correct binding. Test: Grand Mountain Adventure MEC Bug: angleproject:345851268 Change-Id: I636f3780f8454d04152ff7bf7ba15d039ee41872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5718285 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Cody Northrop 98ff1c14 2024-07-17T09:45:03 FrameCapture: Improve buffer binding reset We aren't correctly tracking and resetting buffer bindings, which are per-context. To restore them, we need to track the bindings at the beginning and mark them dirty. Before this we were doing it in ResetReplayContextShared based on the object dirty state. Test: Grand Mountain Adventure MEC Bug: angleproject:345851268 Change-Id: Ic3db583c88bec9c680197f71ff11fdf69efdf630 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5610332 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop a5db20f7 2024-02-21T10:48:26 Traces: Switch to regex for power rails The rails have been rearranged on some devices. Update the way we scan for output to find them in either case. Bug: angleproject:354006406 Change-Id: Ia3999fc2c07a726f4832e451af93a40949f87335 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5722949 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Devon Loehr 80149a7f 2024-07-18T18:46:08 Replace variable-length array with vector Variable-length arrays allow allocating an unbounded amount of memory on the stack. This replaces a VLA with a vector, also provides better consistency with the rest of the containers in the function. Bug: chromium:349656479 Change-Id: I1e18f9a8985de84b82da58fa5465c98dbca51e8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5721320 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 97a249b7 2024-07-18T15:07:29 Manual roll Chromium from 71adbebaf5b6 to b5eaffbef1cb (807 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/71adbebaf5b6..b5eaffbef1cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/44ddb34bcb..ad2f859fc3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e755567ca2..adc2a53a41 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0d3bfa9445..b42459f242 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/da15da3855..9d1552f25c * third_party/android_toolchain/ndk: wpJvg81kuXdMM66r_l9Doa-pLfR6S26Jd1x40LpwWEoC..h9HeidXTeHQ-oskldbqCZx26-7VrVvXpLfqOI87uy4QC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f101c4275b..29445d0e3f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/88f793b4be..b4102e43a0 * third_party/fuchsia-sdk/sdk: version:22.20240710.1.1..version:22.20240717.4.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/928433a141..6bb75caa13 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/4bbf565be1..b9d53fb8e5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2e473a9f20..a5953b107d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/47ab74a93e..88e2a478ee No update to Clang. Bug: None Tbr: yuxinhu@google.com,ynovikov@google.com Change-Id: I042b026369476e8e71fe712260f340275c334d4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5721836 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov 86b22745 2024-07-17T19:05:51 Vulkan: Fix mPipelineCache is not initialized after terminate Very old regression: https://chromium-review.googlesource.com/c/angle/angle/+/1683807 Problem happens only if call `eglInitialize()` again on terminated display without also calling `eglGetDisplay()`. Note: calling `eglGetDisplay()` on terminated display will call `setupDisplayPlatform()`, which will destroy old `mImplementation`. Test: angle_end2end_tests --gtest_filter=EGLDisplayTest.InitializeDrawSwapTerminateLoop* Bug: angleproject:3318 Change-Id: I94bc7eba97be2d9b194c1a22a37662a2836f60b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5717753 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6c585f85 2024-07-18T10:01:45 Roll vulkan-deps from ace59194583a to 4b8a413b6b64 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ace59194583a..4b8a413b6b64 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/48eaea60b849e3eb9ff970b7d4e873646b658863..52f68dc6b2a9d017b43161f31f13a6f44636ee7c https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/3c355ec439dcf821c50fb4660ef0e50d19ae2b63..db5a00f8cebe81146cafabf89019674a3c4bf03d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/7c778973e5eb56ef735bf1a3ad96865eb261997d..4c7e1fa5c3d988cca0e626d359d30b117b9c2822 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/40b8e6eeead809a62c708cb48fdd9f8f2eab3f15..5892ebe2d7505c2238a643288d9a5b2e68784a36 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/5f26cf65a18bc89a8e3d6569c14314b6fdac8d4d..9479047902e8031210b1bb33a8850e32b313dd25 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ac2e01fc1a67329da0c879ecd2296b76643c49c0..58428b0c0e9cb818ee240857c5b4725df8c5183e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I396a787cb99ddbf77d58cd8ba69d61e366517bba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5720395 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gregg Tavares 62d9f847 2024-07-17T13:27:07 Speed up UniformBuffer support on Metal If the sizes are different but all fields match then only padding remains. So, as long as the buffer can safely handle the offset and size of usage, allow drawing without converting the uniform buffer. Fixed: angleproject:348270693 Change-Id: I91196ca9839cf064b573d912f125ff4879a85b02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5719193 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org> Auto-Submit: Gregg Tavares <gman@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
Alexey Knyazev 9968e98c 2024-07-16T00:00:00 Metal: Fix compute path for 16-bit PBO readbacks Added 16-bit normalized pixel formats to internal copy shaders. Fixed and simplified floatToNormalized usage for signed inputs. Bug: angleproject:352700368 Change-Id: Icbb79381991c6621004d53706b97662d33c25cd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5717929 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 43dc24dd 2024-07-17T16:05:59 Skip couple non-deterministic angle_restricted_trace_gold_tests on Win Intel Vulkan. animal_crossing black_clover_m produce slightly different images each run. Bug: angleproject:353690308 Change-Id: I22f2353b2cd83801b857b281ee873c83804864af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5717931 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 1db80b88 2024-07-10T12:47:42 Reland "Vulkan: Use VK_KHR_dynamic_rendering[_local_read]" This is a reland of commit c379ff48043a47e444c388c45270db40d3172d50 Original change's description: > Vulkan: Use VK_KHR_dynamic_rendering[_local_read] > > Bug: angleproject:42267038 > Change-Id: I1f4eb0f309992a9c1c287a69520dadf5eff23b26 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5637155 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Charlie Lao <cclao@google.com> Bug: angleproject:42267038 Change-Id: I083e6963b5421386695e49a9872edbb2016c9763 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5691342 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev 3fe6cae1 2024-07-16T00:00:00 Fix gl::roundToNearest on x86 * Ensured that (0.5 - 1 ULP) is rounded to zero * Skipped std::copysign for unsigned return types Bug: angleproject:352963106 Change-Id: I803030a630229af187bcf1f6c71b6cb68962cc45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5713472 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 3c21ff7d 2024-07-17T10:01:46 Roll vulkan-deps from 99f840c7c7ad to ace59194583a (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/99f840c7c7ad..ace59194583a Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/7e4873b51d9ac10fea7b4f5762562beff4efbb0f..b0bf54958137fcd9800848ef3ecb5fa6be871803 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/257cacfb3e44bf26b1867840d29116e78affdb32..7c778973e5eb56ef735bf1a3ad96865eb261997d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/811802864150a70de5933179b0c545ec11620679..40b8e6eeead809a62c708cb48fdd9f8f2eab3f15 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/b47676a03827fc0c287409b243b1fd62886e79c0..53a6ba7c235cbe0b0f3e85e3de6d9070bcfec710 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/98d78ad635340c289286e5494ce3fc388e840b55..ac2e01fc1a67329da0c879ecd2296b76643c49c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I5f6a08fd481f980e8f4403fbe348136e25862d5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5714059 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f45494ee 2024-07-17T10:01:29 Roll SwiftShader from 389854967d78 to c4dfa69de7de (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/389854967d78..c4dfa69de7de 2024-07-16 swiftshader.regress@gmail.com Regres: Update test lists @ 38985496 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I7a06e8ba83843bb3e395f07c7e0775a8044cf000 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5716021 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2452e62d 2024-07-17T07:00:14 Roll Chromium from 4be473888de4 to 71adbebaf5b6 (678 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4be473888de4..71adbebaf5b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/37a54f0c34..44ddb34bcb * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e3a05ff85e..e755567ca2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f966f55882..0d3bfa9445 * third_party/android_build_tools/lint: RE2raAkMs2otvvOax0wf9dW4Mhow5lXtfxx88UFHrRcC..v79ZCCwmnRiw_53_BXjDk0gwzTw5er4Epjx31ZnF6x0C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1f5df91e98..f101c4275b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9b51399218..88f793b4be * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/81d177a0a8..928433a141 * third_party/siso/cipd: git_revision:2771ced2186c49911899699f831f96ceea4812f6..git_revision:b41f9eaf44dfdaec51ab2d7089aaa4cb6d9e7f5e * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/3018c371ef..4bbf565be1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6ebc0b9f3f..2e473a9f20 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/173dca7704..47ab74a93e No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ie21f389536f5c058a512f81bfebb3ec63eaebdeb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5714623 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 1f87cbc9 2024-07-15T13:07:35 Vulkan: Fix late-added resolve attachment tracking Resolve attachments may be added after the fact to a render pass due to glBlitFramebuffer or eglSwapBuffer. Previously, only the resolve image views were tracked by the render pass, and otherwise the state tracking (layout, content defined, etc) treated the resolve images as generically written-to by the render pass. As a result, the render pass was unable to finalize the layout of the resolve images early. Optimizing the layout of the swapchain image when the surface is multisampled for example was not done due to this issue. In this change, when resolve attachments are added late, they are tracked identically to when they are added at the beginning of the render pass, fixing the issues described above. Bug: angleproject:42265625 Bug: angleproject:42266019 Change-Id: I765560762bb8caf39ba1096fb028177201c082d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5707470 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 468fcbe0 2024-07-15T15:46:12 Manual roll VK-GL-CTS from 43432bf265e3 to 5b2dfe7c775a (17 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/43432bf265e3..5b2dfe7c775a 2024-07-12 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.5 into vk-gl-cts/main 2024-07-12 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.11 into vk-gl-cts/main 2024-07-12 marcin.zajac@mobica.com MSAA Images in 64 bit Atomic + Shader Storage Images 2024-07-12 piotr.byszewski@mobica.com Add tests for subgroup uniform descriptor indexing 2024-07-12 ziga@lunarg.com Add shader object tests using all stages with nextStage 0 2024-07-12 MengYang.Liu@amd.com Add test cases for 256 bytes PushConstantsSize 2024-07-12 javed@igalia.com Fix 'unused shader' message 2024-07-12 kamil.goras@mobica.com Split KHR-GL46.cull_distance.functional 2024-07-12 syoussefi@google.com Remove incorrect usages of DE_NULL in VK framework 2024-07-12 syoussefi@google.com Remove incorrect usages of DE_NULL in GL tests 2024-07-12 syoussefi@google.com s/DE_NULL/0 in makeStridedDeviceAddressRegionKHR 2024-07-12 rgarcia@igalia.com Test line rasterization parameters do not affect non-lines 2024-07-12 javed@igalia.com Add option to enable/disable spir-v validation 2024-07-12 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-07-11 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-07-08 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-07-01 lorenzo@khronosgroup.org Update KC CTS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: b/353358652 Tbr: yuxinhu@google.com Change-Id: I1c787be2812017f14aff669d42bf55f2696d5de1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5710888 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev 3540f8e8 2024-07-15T00:00:00 Fix gl::floatToNormalized for negative inputs Bug: angleproject:352963106 Change-Id: If353ff4126c6203ef6c1267d2b5c85b927964f15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5710508 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev f9af6f1c 2024-07-11T00:00:00 Add ReadPixelsTextureNorm16PBOTest Test that ReadPixels with a pixel pack buffer object bound works for 16-bit color buffers. Bug: angleproject:352584420 Bug: angleproject:352700368 Bug: angleproject:352963103 Bug: angleproject:352963106 Change-Id: I97457fefa86fad3f9444a24870bfd0431a87d64b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5703580 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Geoff Lang c4274d54 2024-04-29T11:47:34 WebGPU: Add pipeline creation and caching. Bug: angleproject:342213825 Change-Id: I303f193d30fd6b9820efaefcae64e11042888009 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5497535 Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Charlie Lao 58a56ca4 2024-07-16T11:26:44 Vulkan: Restrict VkEvent to TBRs VkEvent has much bigger overhead. Until we know that it helps desktop GPUs, we restrict it to TBRs. Also enabled for SwiftShader so that we get more test coverage in bots. Bug: b/336844257 Change-Id: Ie1859a515c9969ca37f07eae0ff729dd934eb26e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5714391 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 686ed56d 2024-07-16T13:41:12 End ANGLE Mac Intel 14.5 experiment Bug: chromium:350362798 Change-Id: I44b5f66979c09ae1d1d8b792a45fc2dc9e4b907c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5713253 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Geoff Lang 84c77437 2024-07-15T16:41:17 GL: Disable GL_KHR_blend_equation_advanced on various devices Intel desktop OpenGL drivers fail tests for advanced blend. Skia also disables usage of this extension on Intel drivers. Disable on older Qualcomm and ARM devices following Skia's blocklists. Bug: angleproject:42267098 Change-Id: I7642017d06e11ad0651fba6f1ec5cc3f589700ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5709950 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shrek Shao 9880af58 2024-07-09T13:59:54 GL: Fix map input buffer out of range in streamAttributes Early return when validating map range size for input attribute buffer fails. Bug: b/349653220 Change-Id: I75ac73c58abb469f0757978175fde53cd012df31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5690279 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 53ada6b4 2024-07-16T10:01:39 Roll vulkan-deps from 7dc21774dc62 to 99f840c7c7ad (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7dc21774dc62..99f840c7c7ad Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ba5c010c590761d0321bd16e915536ef4f9aad8d..48eaea60b849e3eb9ff970b7d4e873646b658863 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/65c8c768cad2b942b518c42f338696a75138de8f..7e4873b51d9ac10fea7b4f5762562beff4efbb0f https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9f2ccaef5f70c32bcd6c911a2b09dbb26106b437..257cacfb3e44bf26b1867840d29116e78affdb32 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/fc6c06ac529e4b4b6e34c17cc650a8f62dee2eb0..b379292b2ab6df5771ba9870d53cf8b2c9295daf https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/f8616928ee19f6c7fd648c1cf1f456cba3771855..811802864150a70de5933179b0c545ec11620679 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d9fd55f3a3a4cfd2b1a02f1d6bbd38d18d993326..98d78ad635340c289286e5494ce3fc388e840b55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: If3cded31d113e807a24f6592816c5395783e1fed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5711690 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b8d21cd2 2024-07-16T10:01:50 Roll SwiftShader from f23c77132e0b to 389854967d78 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/f23c77132e0b..389854967d78 2024-07-15 dloehr@google.com Make implicit `this` captures explicit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Iddc7894bab85b741c673284b8ac79f33c67e0d14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5711801 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9e60edc7 2024-07-16T07:42:29 Roll Chromium from dcc3741ff616 to 4be473888de4 (519 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dcc3741ff616..4be473888de4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4b616207b1..37a54f0c34 * buildtools/reclient: re_client_version:0.150.0.c8b9fcfa-gomaip..re_client_version:0.148.0.41b09b51-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4fb734b819..f966f55882 * third_party/android_build_tools/aapt2: G1S0vNnfv3f8FD-9mH5RFSUiK-mnSwri_IdiVQKwLP0C..cfGQ9GV4juNnGZIPzTmaL3ehiZM1hs6UsB5HUA8fT6oC * third_party/android_build_tools/manifest_merger: EL_n6z6EIpxqT6t1ZhG8Zx4IgmdTyl_KlPazwMqe0SsC..GGTpgNcW7W4dG6PH1FlPe3ej4jP6pPRyfFs_0rHBfqkC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7534569f99..1f5df91e98 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/791894e4c4..9b51399218 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/0295c716c4..3018c371ef * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/78962c69a5..6ebc0b9f3f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/af2a814a21..173dca7704 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I1df1d34951e62b20f89021a88514d53742463632 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5710197 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 85875b96 2024-07-11T14:59:27 Fix validation regarding cube map array dims When defining cube map array textures, the depth represents the number of layer-faces, and does not change with mip level. * Updated validation for glTexImage3D(). * The width and the height for a mip level should not exceed the max cube map size for that mip level. * The depth limit has been set to max 3D texture size (similar to glTexStorage3D()) * The spec states that this limit should be at least the value of the implementation-based constant MAX_RECTANGLE_TEXTURE_SIZE. * Added unit tests to check multiple cases for cube map array validation for TexStorage3D, TexImage3D, and TexSubImage3D. Bug: b/338621235 Bug: angleproject:42262247 Change-Id: I0857e68de02238ffd288e34879fb7dfa6e3f545f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5698571 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu a8eded77 2024-06-26T12:58:25 Vulkan: remove unused function Bug: b/293297177 Change-Id: I9eeda38b78cc68eae3f65571b82b62e5ea45ad61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5659504 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov faae3c32 2024-07-15T16:12:38 Add necessary MSAN include when ANGLE_WITH_MSAN Tentative fix for https://crrev.com/c/5706150 __msan_scoped_disable_interceptor_checks() is defined in that header, and was presumably pulled in transitively previously. Bug: angleproject:42266508 Change-Id: If64b213f01e98fef6bbed15b2f071bd8032e4987 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5709949 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
Roman Lavrov 43ecf2bd 2024-07-15T12:16:30 dEQP tests: skip comp_swap r32i/r32ui on Pixel 6 Bug: angleproject:352610491 Change-Id: Id4d9c31d08ce4953c022c5314b163d55152edcd9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5707469 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Steven Noonan 06921c61 2024-07-08T12:13:40 vulkan: filter out devices with insufficient API version We weren't taking the version into consideration inside ChoosePhysicalDevice, but RendererVk really cares about that and will error out if the selected device doesn't meet the minimum API version requirements. Frontload some of that API version check work in ChoosePhysicalDevice, giving it the opportunity to find a device that matches the requirements. Bug: angleproject:351866412 Change-Id: I471e93b03eca5e18e98202f9848ba0fd1b55d5a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5686556 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 56861ff1 2024-07-15T14:56:40 Manual roll Chromium from d3a8a2da6ae3 to dcc3741ff616 (894 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/d3a8a2da6ae3..dcc3741ff616 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fe78ad9dee..4b616207b1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/535479cc54..e3a05ff85e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/29a672ff63..4fb734b819 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/07bb902af4..da15da3855 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4b50eadc6b..81d177a0a8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/80fdfd4b7e..af2a814a21 No update to Clang. Bug: None Tbr: yuxinhu@google.com,ynovikov@google.com Change-Id: I2cf06ebe40f93f1fb6d4a6eee8b46983628f5d8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5707352 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e6d43dc1 2024-07-15T10:01:46 Roll vulkan-deps from 9563c7bbc6c9 to 7dc21774dc62 (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9563c7bbc6c9..7dc21774dc62 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/42d9adf50b4ad7db2a7212318068ec614b36414f..ba5c010c590761d0321bd16e915536ef4f9aad8d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/f41928bd4ac3b0451b68898d8e58a6ed5ee99f2b..fc6c06ac529e4b4b6e34c17cc650a8f62dee2eb0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/8e1076d9363787b4e754ac17e7ee6ab806458f7c..f8616928ee19f6c7fd648c1cf1f456cba3771855 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/145675c7915c5041dac106c9827dc0b21992c091..b47676a03827fc0c287409b243b1fd62886e79c0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/d13c1ee715c4674237aca1c775479e1edde87d3c..5f26cf65a18bc89a8e3d6569c14314b6fdac8d4d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/53a86c7d267c325613c9a532b190d964f513402f..d9fd55f3a3a4cfd2b1a02f1d6bbd38d18d993326 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I34d46b0367869b423872db5e185aa0de452e703b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5706990 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov df90bbc5 2024-07-12T18:04:53 Refactoring: move angle::HashMap and HashSet to own header Underlying abseil includes pull in a large set of headers Bug: angleproject:42266508 Change-Id: Icee47143a8a59bb0795a054b67c0aa4ddcfca4d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5704137 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 2997e354 2024-07-09T17:38:56 Start Win Intel UHD 770 experiment - Suppress failing tests. - Disable UHD 630 workarounds on experimental bot - Reduce deqp_gles2_d3d11 and end2end parallelism Use-Permissive-Angle-Pixel-Comparison: True Bug: chromium:331316080, angleproject:352085732, angleproject:352528974 Change-Id: I80eca02f1def11e60b857968a7b0c8fe93a1b4d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5688794 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Charlie Lao a5161f01 2024-06-04T15:46:04 Vulkan: Enable event based image barrier This CL enables VkEvent based image barrier for all GPUs. The testing result on HK3 shows manhattan31_off score impoves ~5%. We can exclude certain barrier insensitive GPUs if needed. Bug: b/336844257 Change-Id: Iebc4957dbb683637c9314e706be31d3376ee15aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5634089 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Imran Ziad 24322b7d 2024-06-28T20:10:34 Vulkan: feature for cached non-coherent for dyn/stream buffers On platforms lacking cached coherent memory, ANGLE falls back to non-cached coherent memory for dynamic/stream buffers. This impacts CPU readback performance. Add VK feature preferCachedNoncoherentForDynamicStreamBufferUsage. When enabled, ANGLE prioritizes cached non-coherent memory for these buffers. Enable this feature for Intel Meteorlake SOCs. Bug: b/347601787 Change-Id: If62af9f3df57c0bcebf18af747cac56e45f93ea7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5667457 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 8ed4d427 2024-07-11T00:00:00 Metal: Remove link tasks dependency on context Bug: angleproject:351165323 Change-Id: If9e5d141cb15a6fc6df8a5fd9a2cfe70efe19dfc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5701902 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Roman Lavrov 245c1243 2024-07-12T14:28:31 Revert "Disallow read color type conversions for norm16 formats" This reverts commit e5b442dedd8030d64a6ca2cb34ba0ec37895adfa. Reason for revert: Broke Skia tests; possibly not going for this any more, as discussed on https://issuetracker.google.com/351644552#comment11 Original change's description: > Disallow read color type conversions for norm16 formats > > OpenGL ES is not supposed to convert 16-bit color buffers to > 8-bit pixel types or vice versa during readPixels operation. > > Fixed: angleproject:351644552 > Change-Id: I9e51ddc82f62f958b983b5d4609f7e983a941e83 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5686233 > Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:351644552 Change-Id: Ib0222e4cc5eae944db96fdd3f72c8980dfe09adf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5702736 Reviewed-by: Solti Ho <solti@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll d89a205d 2024-07-12T10:01:14 Roll vulkan-deps from bc656cdad31e to 9563c7bbc6c9 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bc656cdad31e..9563c7bbc6c9 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/78a92e2c7c5aa1c7b7e6f9c475bd9009977ea8f9..f41928bd4ac3b0451b68898d8e58a6ed5ee99f2b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/38691803018cb2d85194b235faf43119d64c0a66..8e1076d9363787b4e754ac17e7ee6ab806458f7c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/7e13360e42364fdd1f07fe00f19d0432b12db055..145675c7915c5041dac106c9827dc0b21992c091 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d1a44afd0353a82308f1a2a3ff379bca5b0e2368..53a86c7d267c325613c9a532b190d964f513402f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I8b9c369c9b63b5e0bc4fe46fea2b0e35439aa218 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5700806 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 298d55f3 2024-07-12T07:01:47 Roll Chromium from 51ac27c135bf to d3a8a2da6ae3 (571 revisions) https://chromium.googlesource.com/chromium/src.git/+log/51ac27c135bf..d3a8a2da6ae3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4608a1c315..fe78ad9dee * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/97a8409691..535479cc54 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f0dacf7b5b..29a672ff63 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5b83c679ba..07bb902af4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8ebbd5189d..791894e4c4 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6aa2802a07..4b50eadc6b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/dcb70b126e..0295c716c4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8eb5d3af47..78962c69a5 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/a0eeba1c75..87928d7073 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ad128811ea..80fdfd4b7e No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I62a73ad102568c003c3f85950a1ac297e75ad485 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5700645 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev c5ab1ceb 2024-07-11T00:00:00 Metal: Remove library creation dependency on ContextDevice Bug: angleproject:351165323 Change-Id: Idc560a75e569fe917685bb247625d7df8472af46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5698885 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev a93476a1 2024-07-11T00:00:00 D3D11: Pass 3D slice index to Image11::copyWithoutConversion 3D slice range is passed in a D3D11_BOX structure for CopySubresourceRegion. Fixed: angleproject:352467349 Bug: angleproject:352496176 Change-Id: Ie96d9567cf73b0612bfb1cbd7fbacc6c0f01dec4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5697425 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Charlie Lao 6578b9c0 2024-07-09T17:19:47 Vulkan: Exclude compute/preFrag only access images from event This further restricts VkEvent usage for certain usage patterns. If image is only used by compute, use VkEvent also will not benefit it since compute itself can not overlap with compute (assume there is only one compute engine and compute work can not overlap with each other). Similarly this also applies to KPreFragment stages. Basically after this CL, use of VkEvent is limited to usages that crosses different execution units (modeled against tiler based GPUs where there are pre-fragment stages and fragment stages and compute and all others). Before this CL, we are seeing performance regression with antutu_refinery and streets_of_rage_4 due to overhead of VkEvent, which is fixed with this CL. Bug: b/336844257 Change-Id: I5ca5d813daefe9bfcaf48f831340cdf9559f8104 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5692760 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 402c8ccd 2024-06-26T19:28:21 Vulkan: Limit VkEvent for images that has fragment access only One of the problem with VkEvent is that the overhead comes with VkCmdSetEvent causes some app traces regress performance. The goal in this CL is to further limit VkCmdSetEvent to images that that we think are potentially subject to the pipeline bubble. The bubble usually occurs when accesses are alternated between different stages, specifically a mix between vertex/transfer/compute/fragment. If all accesses are from fragment shader or color attachment, then use VkEvent will not be beneficial, but only adds extra overhead. This CL adds the heuristic tracking for image access. Every time an image is used, a bit is used to indicate the usage involves fragment only or not. A bitfield is used to track the window of the history of the usage. When image is used (usually at the time queueSerial is set), we shift the history bits left and the new bit is added to the right most bit. If all accesses are from the fragment shader or color attachment, then no need to use VkEvent. For example, if a texture is always sample from fragment shader only, then VkEvent will not used. Another common usage is you render to it and then texture from it, it will also excluded from VkEvent with this CL. Bug: b/336844257 Change-Id: I175194f30b8f1d9b8fbf38ad594778474548016f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5664170 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Roman Lavrov eda67d7e 2024-07-11T11:16:08 Avoid including fstream from angleutils.h SaveFileHelper is mostly useful for / specific to FrameCapture, so move it there. The other couple of uses just write a string. Bug: angleproject:42266508 Change-Id: Ia1dcd4531f9d5671f40611a1887dcfe7c5dbc1ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5696025 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll a15d4f97 2024-07-11T09:55:32 Roll Chromium from 5748d73603a8 to 51ac27c135bf (686 revisions) Ignore 'contrib/qat/deflate_qat.h' in 'scripts/export_targets.py' after https://chromium-review.googlesource.com/c/chromium/src/+/5419776 https://chromium.googlesource.com/chromium/src.git/+log/5748d73603a8..51ac27c135bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/55c8722b0c..4608a1c315 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a2464aeead..97a8409691 * buildtools/reclient: re_client_version:0.148.0.41b09b51-gomaip..re_client_version:0.150.0.c8b9fcfa-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5f0ab1b223..f0dacf7b5b * third_party/android_build_tools/lint: e_WxdIopgECi7lR7hSDoHgOVaSHP0TtgcfjFowfwUkgC..RE2raAkMs2otvvOax0wf9dW4Mhow5lXtfxx88UFHrRcC * third_party/android_build_tools/manifest_merger: UZ47yEDJAQYl7Uj6uUofbCrmnK8Bycu18fSFQAMO2agC..EL_n6z6EIpxqT6t1ZhG8Zx4IgmdTyl_KlPazwMqe0SsC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b73579b7b0..7534569f99 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6b6a0ff40b..8ebbd5189d * third_party/fuchsia-sdk/sdk: version:22.20240703.0.1..version:22.20240710.1.1 * third_party/kotlin_stdlib: L8N8abd00VyqdzTL4hXOWqSHvY0R7i7ti3TLrfbPZ8gC..8qx9sot30FtFtPSKIpcEu3KhfqtQHpExnueNhpwxd48C * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/37df66525c..6aa2802a07 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/68e57e619c..c2469fdd73 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e887381724..dcb70b126e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/31e7b5378d..edbc860e1b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b16be4632b..ad128811ea No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I981332789b54df0c21668ba5a61c046aad5c910e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5692852 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov e59ae389 2024-07-11T08:37:51 angle_enable_wgpu requires X11 on Linux Reported by ARM, broken build without X11: ld.lld: error: undefined symbol: rx::CreateWgpuWindowSurface(egl::SurfaceState const&, unsigned long) Bug: angleproject:342213844 Change-Id: Ib1972b5ad9a6f14da5b5e7ba8790e4b4cbbdfab1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5688908 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 126275cb 2024-07-11T10:01:14 Roll vulkan-deps from 67847f196c19 to bc656cdad31e (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/67847f196c19..bc656cdad31e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/88194ef2d87683f963e735793f20ad1ebce70bc5..65c8c768cad2b942b518c42f338696a75138de8f https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/41a8eb27f1a7554dadfcdd45819954eaa94935e6..3c355ec439dcf821c50fb4660ef0e50d19ae2b63 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/6c539b2ed2dba2997cdedeac0b376ff2fe382595..78a92e2c7c5aa1c7b7e6f9c475bd9009977ea8f9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d0a37c686014b76cf059a803ebd2a5be7aaa6e15..d1a44afd0353a82308f1a2a3ff379bca5b0e2368 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I3ec91b1b496e5648e34a05d629058273eb899642 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5692853 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Steven Noonan 87e9ee9c 2024-07-08T14:07:05 egl: add missing extension string for D3D LUID This extension was never announcing itself. Bug: angleproject:351866412 Change-Id: I9a6e4aae1ea3a8aba49ed036cb7cc14ec1a9151f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5686555 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net>
Shahbaz Youssefi 584fbcee 2024-07-10T12:43:34 Vulkan: Rework swap-time barrier logic Avoids unnecessary transitions when overlay is enabled Bug: angleproject:42267038 Change-Id: I0534911c0142c5e94cf3be112283fb98fcde0f6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5691346 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 373ac541 2024-07-10T11:14:47 Vulkan: Make surface RP check independent from framebuffer object With dynamic rendering, there is no framebuffer object, so checking whether the currently open render pass belongs to the window surface (at swap time) is made independent from these objects. Bug: angleproject:42267038 Change-Id: I408e2376ba865b64fa1e8890316e8f57c08c695f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5691345 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi f7620039 2024-07-10T10:21:11 Vulkan: Prepare syncval suppressions for dynamic rendering Removing mentions of vkCmdBeginRenderPass and such. Bug: angleproject:42267038 Change-Id: Ibba2c15249b154fb11b116ef75ee6f20e08e4d00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5691343 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Alexey Knyazev 590010b6 2024-07-04T00:00:00 D3D11: Cleanup stale CopyTexImageTestES3 suppressions Bug: angleproject:42262446 Change-Id: Id49b380b4dbf22efc0637605bbf7a67f317e7247 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5691437 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Charlie Lao 867697b7 2024-07-09T10:43:02 Vulkan: Add ImageHelper::onRenderPassAttach helper function RenderPass attachments has one difference compared to other images. The QueueSerial has to be set first so that we can detect an image is being used as attachment. But the layout is delayed until the endRenderPass time. This CL adds a onRenderPassAttach API to set the queueSerial so that we have a central place to adding other code if needed. Bug: b/336844257 Change-Id: I894fff83745691e8167a295c71cbc2e1d22f1343 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5689452 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 9ca3ed37 2024-07-08T16:48:51 Vulkan: Let ContextVk::onResourceAccess uses retainImage Right now ContextVk::onResourceAccess calls retainResource for everything. Mean time we also have a retainImage() function, which adds a bit confusion to why we have two retain API. This CL moves retainImage from CommandBufferHelperCommon to OutsideRenderPassCommandBufferHelper and RenderPassCommandBufferHelper so that ContextVk::onResourceAccess can use retainImage directly. The slightly behavior difference between RenderPassCommandBufferHelper and OutsideRenderPassCommandBufferHelper's retainImage is from compute shader's image access, which we are using VkEvent to track images, mainly due to we tailor VkEvent to the manhattan's usage case, which involves compute. Bug: b/336844257 Change-Id: Id3fb694f683289a4720cc279387dbc27642745de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5686352 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi 95e66307 2024-07-08T15:39:58 Resolve compilation during program link resolve Currently, it seems that Program::resolveLink() itself does not resolve shader compilations (Shader::resolveCompile()). Therefore, in case of many shader compilations without them being destroyed, this can result in extra memory usage. * During resolveLinkImpl() of a program, the compilation of the attached shaders are resolved after successful linking in order to save memory. Bug: b/342012929 Change-Id: Iaa6f02a6d2fb3dbd6306660609faa29e73fe82a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5684826 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov c62c98df 2024-07-09T22:41:18 Revert "Temporarily angle_enable_vulkan_api_dump_layer default false" This reverts commit 3c8a8f7ad9c56192f71f7f8be2d54cbf0457a6a3. Reason for revert: upstream fix merged Original change's description: > Temporarily angle_enable_vulkan_api_dump_layer default false > > Causing flaky build failures. There is a fix upstream but it caused > another issue so we can't roll yet. > > Bug: b/350816748 > Change-Id: I10da65a50988b91fe52f8545bf96a635a43ab438 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5683562 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Auto-Submit: Roman Lavrov <romanl@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/350816748 Change-Id: I74b5ec94cf1f6625f58b3bfb7ccb471c7004dc9c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5688777 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 7d461b21 2024-07-10T14:11:53 Revert "Vulkan: Use VK_KHR_dynamic_rendering[_local_read]" This reverts commit c379ff48043a47e444c388c45270db40d3172d50. Reason for revert: Regresses CPU perf and memory when _not_ using DR Original change's description: > Vulkan: Use VK_KHR_dynamic_rendering[_local_read] > > Bug: angleproject:42267038 > Change-Id: I1f4eb0f309992a9c1c287a69520dadf5eff23b26 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5637155 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Charlie Lao <cclao@google.com> Bug: angleproject:42267038 Change-Id: I3865f0d86813f0eeb9085a92875a33bd449b907f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5691337 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov e208994a 2024-07-09T13:43:54 Add a note about std::aligned_alloc caveats Doesn't seem worth touching: * MSVC remains a special case * aligned_alloc adds a constraint on alloc size Bug: angleproject:352054650 Change-Id: I20caaf96e70898001c2b9aa698446cfe4803ea0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5688795 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll b0bb4186 2024-07-10T10:01:13 Roll vulkan-deps from 1d4b1061b004 to 67847f196c19 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1d4b1061b004..67847f196c19 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d03e2bca31b298fc911f7c89cfaf24d28904492d..d0a37c686014b76cf059a803ebd2a5be7aaa6e15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ib6d72aaa77ddb05707cec37200efed885fb61361 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5691212 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev e5b442de 2024-07-04T00:00:00 Disallow read color type conversions for norm16 formats OpenGL ES is not supposed to convert 16-bit color buffers to 8-bit pixel types or vice versa during readPixels operation. Fixed: angleproject:351644552 Change-Id: I9e51ddc82f62f958b983b5d4609f7e983a941e83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5686233 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 13c93ca9 2024-07-10T07:02:07 Roll Chromium from f0fb088cc7f4 to 5748d73603a8 (622 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f0fb088cc7f4..5748d73603a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b7fc49975c..55c8722b0c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e73bcd11d1..a2464aeead * buildtools/reclient: re_client_version:0.150.0.c8b9fcfa-gomaip..re_client_version:0.148.0.41b09b51-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e6ad538b4a..5f0ab1b223 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/5fff3e91aa..45a95bfa7e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9b20ae8642..b73579b7b0 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/01e29c8b5d..6b6a0ff40b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/604bb086b1..37df66525c * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/8f49d6467f..d09db732ff * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/98c4117f74..e887381724 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/210eabb02a..8eb5d3af47 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/062978f309..31e7b5378d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c38db6bd79..b16be4632b No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Ia7995ce5e3405b88674e7f41d477d920f6f07b4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5690654 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0679b3eb 2024-07-09T18:55:35 Manual roll vulkan-deps from 17d345a0f23d to 1d4b1061b004 (24 revisions) Suppressing a new sync hazard warning Manual roll requested by romanl@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/17d345a0f23d..1d4b1061b004 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5939e32b87487fa9c72ab336ebfcc5ae26d9ab6d..42d9adf50b4ad7db2a7212318068ec614b36414f https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/00c49e3b56cc9748228d2e5b0d1e8e9c4409a02f..88194ef2d87683f963e735793f20ad1ebce70bc5 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/216574bedb80d439c2533d161e7ea7897504bbb6..9f2ccaef5f70c32bcd6c911a2b09dbb26106b437 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/190d2cb24e90e5bf2bec0a75604a9b3586485b6d..6c539b2ed2dba2997cdedeac0b376ff2fe382595 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/df78ee39d2ff6c10b4f7f2ae06c7ca64524f9e25..d13c1ee715c4674237aca1c775479e1edde87d3c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/96fb5396040477fbbffdc1b4439dea9447f59d80..d03e2bca31b298fc911f7c89cfaf24d28904492d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:352094384 Tbr: romanl@google.com Change-Id: If9da3b32eb405aba8472a020be0c3fd732656f27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5689521 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Igor Nazarov 6052d0f4 2024-07-03T15:17:23 Vulkan: Fix EGL_EXT_buffer_age with single buffered surface The specification: 4) What is the buffer age of a single buffered surface? RESOLVED: 0. This falls out implicitly from the buffer age calculations, which dictate that a buffer's age starts at 0, and is only incremented by frame boundaries. Since frame boundary functions do not affect single buffered surfaces, their age will always be 0. Test: angle_end2end_tests --gtest_filter=EGLBufferAgeTest.SingleBuffer* Bug: angleproject:3529 Change-Id: Iab5da26d1bce56d928398cc250d900465fc5d261 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5675986 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 21fc5e87 2024-07-09T09:30:23 Move loadimage SSE includes/defines out of common headers Including x86intrin.h from common headers appears to be making the "include analysis" tool unhappy. Doesn't look like we actually need it, the only possibly relevant place I could find is the loadimage SSE implementation - but even that wasn't enabled outside of Windows anyways. It is not clear there is a need for the ANGLE_USE_SSE define in other places, at least not at this point. The current implementation also appears to be only for Windows. Move all related code to where it is used - loadimage implementation. Bug: angleproject:42266508 Change-Id: I1eac1510e7515cb6cc85c0332f5de91e0494d3da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5688790 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll c68c7dca 2024-07-09T07:02:27 Roll Chromium from b1148c13c7a9 to f0fb088cc7f4 (639 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b1148c13c7a9..f0fb088cc7f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/52f862e694..b7fc49975c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2054b2e6d5..e73bcd11d1 * buildtools/reclient: re_client_version:0.148.0.41b09b51-gomaip..re_client_version:0.150.0.c8b9fcfa-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/601765ed01..e6ad538b4a * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b11653d13e..48452b983b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1ec7890183..9b20ae8642 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9e9fc99280..01e29c8b5d * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/ed9284c473..da2fe725b8 * third_party/turbine: xWEBZuFKl1Dvw_zOpabeMkGVYlEllIxK06D-RoC6wUsC..trOc8ouN-n-XhBQXk58CGsBa_7JlsOD6mv__HNEiiVEC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/3b67584e7f..98c4117f74 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d7d3f62bf4..c38db6bd79 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: If27fa369068ff5e110696fd7969b4e45f89deaf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5685521 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi c379ff48 2024-06-10T22:01:57 Vulkan: Use VK_KHR_dynamic_rendering[_local_read] Bug: angleproject:42267038 Change-Id: I1f4eb0f309992a9c1c287a69520dadf5eff23b26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5637155 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Alexey Knyazev 2763d520 2024-07-04T00:00:00 Do not rely on 16-bit color read conversions in tests, Part 2 These conversions are not specified. ImageClearTestMetal should assert that all bits are cleared. Bug: angleproject:351644552 Change-Id: I362e244078ad44b777cf926e9512c6af9fe48106 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5684692 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 8c546d35 2024-06-25T12:49:40 Vulkan: Limit VkEvent for usage matters for Manhattan31 only If we use VkEvent to track all image operations causes performance regression on some app traces, including manhattan10 trace. This mainly because of CPU overhead comes with VkCmdSetEvent, mostly inside vulkan driver. These app traces likely not benefit from VkEvent because the specific bubble (false dependency) does not manifest on these app traces, but the CPU overhead takes a performance toll on it. In order to strike a balance between benefit and overhead, this CL removes most of VkEvent usage and only leaves the ones that matters for manhattan31. The only we still keeps are generateMipmap, dispatchCompute, texture sampling. We can always add more if more beneficial usage cases comes up and no regression in other traces. Bug: b/336844257 Change-Id: I346fe70bc33e57edf04e933a2db0f79738c4481d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5654737 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Hailin Zhang a68351cb 2024-07-02T15:57:02 vulkan: add workround for speical shadowmap at intel device. this is a dirty quick patch for game TOA at intel device. at game TOA, we saw a special combination could cause the device lost for intel device. the draw call have 2d shadow map texture. if this draw call followed any other drawcall it will cause device lost, the underhood root cause still unknown. it may be related to combined depth stencil layout or any other case. will try to use separate depth stencil image layout to try. Bug: b/349489248 Change-Id: I4f63fff389b8059d68d27aad387a2fd5888d4ce3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5672966 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Hailin Zhang <hailinzhang@google.com>
Yuly Novikov bc38b7ad 2024-07-08T11:39:43 Start ANGLE Intel macOS 14.5 experiment Bug: chromium:350362798 Change-Id: I504318306eb96d6983a366595bbde6cb77c0bb67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5682424 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Roman Lavrov 0a7e1daf 2024-07-05T16:05:20 Tests: fix MultithreadFenceDraw, MultithreadFenceTexImage Before this CL, pixels _after_ swapBuffers() were checked and in a way that was causing a data race on mDrawGreen access. It seems to have passed in certain special-case scenarios but was mostly broken, which might explain the numerous issues that it caused. After this CL, pixels are checked on each of 5 iterations _before_ swapBuffers() and mDrawGreen race is eliminated by ensuring read happens before the background thread is unblocked. Bug: b/338429767 Bug: b/42265212 Bug: b/42264513 Bug: b/267953710 Bug: b/42266622 Bug: b/328156792 Bug: b/42266649 Bug: b/40096752 Bug: b/42263977 Change-Id: Id0fa72ea69e29c6fd5abdb225ff1dbadb18b221b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5675283 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Alexey Knyazev 640e3716 2024-07-04T00:00:00 Do not rely on 16-bit color read conversions in tests These conversions are not specified. D3DTextureClearTest should assert that all bits are cleared. Texture2DNorm16TestES3.TextureNorm16*TextureTest should not use 16-bit framebuffer attachments as they are tested separately. Bug: angleproject:40096653 Bug: angleproject:351644552 Change-Id: Ib22e9fcc3b643725f25f6ed880569888107928ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5683107 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Roman Lavrov 3c8a8f7a 2024-07-08T09:56:49 Temporarily angle_enable_vulkan_api_dump_layer default false Causing flaky build failures. There is a fix upstream but it caused another issue so we can't roll yet. Bug: b/350816748 Change-Id: I10da65a50988b91fe52f8545bf96a635a43ab438 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5683562 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 2a87db69 2024-07-06T22:20:40 Vulkan: Remove unused render pass closure reason Bug: angleproject:42266019 Change-Id: I1c516b88677d7c9d3e97e9fd7525cf727be50cc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5678940 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6c6975af 2024-07-05T12:28:54 Manual roll vulkan-deps from 5fdd3da87369 to 17d345a0f23d (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5fdd3da87369..17d345a0f23d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/704107fda3827377f00e57dff0c21da019bff4ae..5939e32b87487fa9c72ab336ebfcc5ae26d9ab6d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/2acb319af38d43be3ea76bfabf3998e5281d8d12..41a8eb27f1a7554dadfcdd45819954eaa94935e6 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/973e791a9ac122f903c2796349a538b278cbe29b..216574bedb80d439c2533d161e7ea7897504bbb6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/afeb91d6d2110717b8c842081eff410617aed1ef..96fb5396040477fbbffdc1b4439dea9447f59d80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2e1c6204e675eb8e70ed68dbe13b912bd6ffce6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5678939 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll 66f4b76c 2024-07-08T07:01:23 Roll Chromium from a98f22a2505a to b1148c13c7a9 (354 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a98f22a2505a..b1148c13c7a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f0d4b73cd3..52f862e694 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a092d8b8e3..2054b2e6d5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ca782dd95b..601765ed01 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/812e1c5aa6..1ec7890183 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/452fe3be37..9e9fc99280 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/ebabc6deb7..3bd143299e * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/002bae033a..604bb086b1 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e5b130d5dc..a3c7d3e2f3 * third_party/r8: N31NPLsO2NWciwYQ3-i1_ApNlwHV1lv74XrrQY4KfVQC..FkhioB3uZmGFZXh9T_oVHXWyTi8UHB_7BDlrkn8IPpIC * third_party/siso/cipd: git_revision:98713f62d1efa5181177bc506b0941e439f7d6cb..git_revision:2771ced2186c49911899699f831f96ceea4812f6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/303336503e..210eabb02a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2e46e64ec6..d7d3f62bf4 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Ia163ae1f646b5484b2530bf909a13dd6139c1cac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5681862 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi db00dee5 2024-07-05T21:11:53 Vulkan: Fix SPIR-V gen for literally indexed swizzles Translation did not take into account the fact that a swizzled vector can be indexed by a literal (like `vec.zzxy[2]`, which should translate to `vec.x`). Since this issue affects MSL generation too, such expressions are folded before they reach the output generators. Bug: b/351102615 Change-Id: I048aca165cdf22ef8cd7ccd9a8e503ccf636a55f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5680354 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev 58dc069c 2024-07-04T00:00:00 Rename 16-bit EXPECT_PIXEL test helpers Do not use UI suffix as the format is normalized. Bug: None Change-Id: Ib635397f2cdec02806c2c31484820b9b6964a066 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5680605 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 1dd3a4c4 2024-07-04T00:00:00 D3D11: Use built-in position for gl_FragCoord.z on SM 4.0+ If supported, used built-in pixel position input for the gl_FragCoord.z value. Exposed GL_EXT_clip_control only on feature level 10_0 or higher. Fixed: angleproject:347737886 Change-Id: I272ccce04cf6ad7921aa6cd5dc13f0de2f9ae561 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5679787 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Yuly Novikov f22189ec 2024-07-05T15:07:03 Roll chromium_revision c174259bf6..a98f22a250 (1323232:1323712) Manual roll updating android_sdk to 35. Change log: https://chromium.googlesource.com/chromium/src/+log/c174259bf6..a98f22a250 Full diff: https://chromium.googlesource.com/chromium/src/+/c174259bf6..a98f22a250 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c5d8ec8cab..f0d4b73cd3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9cac81256b..a092d8b8e3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/26d2c6829f..ca782dd95b * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/7083198328..dc4679d47e * third_party/android_sdk/public: YK9Rzw3fDzMHVzatNN6VlyoD_81amLZpN1AbmkdOd6AC..DxwAZ3hD551Neu6ycuW5CPnXFrdleRBd93oX1eB_m9YC * third_party/android_sdk/public: HWVsGs2HCKgSVv41FsOcsfJbNcB0UFiNrF6Tc4yRArYC..WihaseZR6cojZbkzIqwGhpTp92ztaGfqq8njBU8eTXYC * third_party/android_sdk/public: u-bhWbTME6u-DjypTgr3ZikCyeAeU6txkR9ET6Uudc8C..kIXA-9XuCfOESodXEdOBkW5f1ytrGWdbp3HFp1I8A_0C * third_party/android_system_sdk: 4QeolYaSKWBtVTgzJU4tHUfzA9OJTDM8YUcD426IctwC..XzzECzCzGLrccJS1U-HdmM5VMh9BotgQ_mWhFQ464PwC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e190315d54..812e1c5aa6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c117716649..452fe3be37 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/450ae0d297..002bae033a * third_party/r8: ghhdiXdRlQvak1W9wGUqI07tD2WFwdgJPVc8guIKXSsC..N31NPLsO2NWciwYQ3-i1_ApNlwHV1lv74XrrQY4KfVQC * tools/luci-go: git_revision:6fb4d5d26773ebddeac2c57506324493e4220007..git_revision:c9c95dda5f310610a3fc574af44faeed298b3938 * tools/luci-go: git_revision:6fb4d5d26773ebddeac2c57506324493e4220007..git_revision:c9c95dda5f310610a3fc574af44faeed298b3938 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6b98f1443e..062978f309 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7395a9f72e..2e46e64ec6 * tools/skia_goldctl/linux: LDPByLYqasHSy5ZxdGy0llSDaUnwdxFfx6L2NvZjxhwC..Tmr9c1O-W7mu7zgVbAgDIpLiDFfiWA2nnWa7FYu0pjgC * tools/skia_goldctl/mac_amd64: Ri84uKWwD6OsP-lJpo7z2X68GibM6ynfZZaSXer2GoYC.._7hIgAZisiST_h_sDMLpXETbV5CzGfmG4Oxm38v4rlEC * tools/skia_goldctl/mac_arm64: 8Yalv78nDvaIEFLlX-HbY-a-QueK4PQzFMEEhzt0bZQC..JFa9d9Q6qO_diHbU_E8cW9EMTEBkDXLlZz8-USH6YLAC * tools/skia_goldctl/win: KhS-PwKl3anmwJCxKIGQYybgN0loA5nw8vVRglJNhngC..VoFA8h7UVLHiMG1OJitx6oYOOdQYwTVztBFAMdPaqywC DEPS diff: https://chromium.googlesource.com/chromium/src/+/c174259bf6..a98f22a250/DEPS No update to Clang. Bug: None Change-Id: I613eb40b3455d11525659d0f0b83f10202dfc55d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5680348 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 7489c5f0 2024-07-05T10:01:00 Roll SwiftShader from a0ec371d8331 to f23c77132e0b (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/a0ec371d8331..f23c77132e0b 2024-07-04 swiftshader.regress@gmail.com Regres: Update test lists @ a0ec371d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I5476042f5c4913c685aeae2a058247d1237953d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5679678 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jordan Brown c46d94d1 2024-07-04T05:45:53 Updating ceval's README.chromium to include Revision Change-Id: Ieca214504cb28daaf944c2dcac7044f413b0bfdc bug: b/350851535 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5677899 Auto-Submit: Jordan Brown <rop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Alexey Knyazev fe02de25 2024-07-04T00:00:00 Metal: Remove MTLGetMSL dependency on context Bug: angleproject:351165323 Change-Id: Idf56665cce67dcf51ac4d6148212786bcc398b67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5678417 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jordan Brown dfec7f4c 2024-07-04T05:50:05 Updating clspv's README.chromium to include Revision Change-Id: Id4204aebbbd9eb61f25982a6acbd783987944016 bug: b/350851535 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5678093 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jordan Brown <rop@google.com>
kmx.io     mail     discord kmxgit v0.4.0