kc3-lang/angle

Log

Author Commit Date CI Message
Jamie Madill 76d52be3 2020-04-07T09:14:29 Vulkan: Add VulkanMemoryAllocator to DEPS. Bug: angleproject:2162 Change-Id: If91ae40c1fe818a59d775bb2fa066227dd52859d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139992 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 4609c4ac 2020-04-06T19:02:29 Feature::condition must not be NULL Since it's returned by eglQueryStringiANGLE, and the doc says: 1. eGLQueryStringiANGLE returns a pointer to a static, null-terminated string 2. On failure, NULL is returned So, we shouldn't be returning NULL when there is no failure. This was breaking 'chrome --enable-gpu-service-logging'. Bug: angleproject:3947 Change-Id: I2dcc7d479899dc1fc5fd59a502e84defe44f64c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2137939 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 2a0c3596 2020-03-31T15:36:45 Vulkan: Clean up robust and emulated image clears. This change consolidates image clears in multiple places into a single site in ImageHelper initialization. It adds support for appending clear image commands as well as prepend (the default). We prepend clears because image initialization happens after data upload. The Vulkan robust clear path now works like the other back-ends. The change flushed out a bug where partially uninitialized CopyTexImage was not correctly initializing a texture before triggering a full resource clear. Texture::copyImage now uses a workaround where we first init the image before clearing it. After the init we upload the new data. We'll use the appending clears path when implementing deferred clears. Bug: angleproject:4517 Change-Id: If9212f3b8cdd0fc8b7e729d364530801a644e164 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2130627 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 78a471ba 2020-04-03T16:21:21 TextureGL: Signal DirtyBitsChanged on dirty bits. This is a refactoring change only in preparation for a change in the Vulkan back-end. We'll need to split the handling for Vulkan and GL into different functions. Bug: angleproject:4517 Change-Id: I2ddf9c70fe247d1dcb4e0aa9ca929bbbd61bd42b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135893 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill c916fe8a 2020-04-02T16:57:49 Don't call syncState inside FBO queries. This prevents a syncState ordering issue that was confusing FBO sync when robust resource init is enabled. Also cleans up some redundant format processing for the half float extensions. Bug: angleproject:4517 Change-Id: Ieb13fc5203cf824a3e8affda96ea5cbbd89d78ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2134411 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill a30c6f35 2020-04-07T11:25:20 Vulkan: Pass RendererVk to BufferHelper::destroy. Bug: angleproject:2162 Change-Id: I7c0090d48b0a5bac222b1edf4c2db280d5b32930 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139993 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
angle-autoroll e4da6f15 2020-04-07T07:01:19 Roll third_party/vulkan-loader/src bb74deab0a4d..122067a02a25 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/bb74deab0a4d..122067a02a25 git log bb74deab0a4d..122067a02a25 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 udknight@gmail.com docs: Improve vkNegotiateLoaderLayerInterfaceVersion's description 2020-04-06 arnfranke@yahoo.com Add newlines to two DXGI files 2020-04-06 udknight@gmail.com docs: Correct one minor discrepancy in "Implicit vs Explicit Layers" 2020-04-06 lenny@lunarg.com build: Enable building static loader on MacOS Created with: gclient setdep -r third_party/vulkan-loader/src@122067a02a25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I3170f0a78d08f6ffa3abe717ce22ba2ef91aff46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139124 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
shrekshao 90e07c73 2020-04-06T17:04:32 Hook up several drawElements variants in Context11 Turns out the issue for the skia bug is not related to index range cache but simply several new drawElemnts variants are not properly hooked up. Change-Id: I2d1ae15c74233185e4fee8a1443ffe0477f9c444 Bug: angleproject:3402, angleproject:4536 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2137943 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll eb298a02 2020-04-07T08:25:52 Roll third_party/glslang/src b5757b95005b..9c3204a1fde0 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b5757b95005b..9c3204a1fde0 Created with: gclient setdep -r third_party/glslang/src@9c3204a1fde0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ib47c20eccdf3543272966d75e2fdf21fe29762c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139375 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d14735b2 2020-04-07T07:02:06 Roll third_party/vulkan-headers/src 0e78ffd1dcfc..b4b0f994204e (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/0e78ffd1dcfc..b4b0f994204e git log 0e78ffd1dcfc..b4b0f994204e --date=short --first-parent --format='%ad %ae %s' 2020-04-06 devrel@oddhack.org Update README.md with warning of pending header changes Created with: gclient setdep -r third_party/vulkan-headers/src@b4b0f994204e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=jonahr@google.com Bug: None Change-Id: I7b5b7a693c6e2e4aa6750643a2fc27be933626eb Tbr: jonahr@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139096 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c8007e14 2020-04-07T07:01:52 Roll third_party/spirv-tools/src e95fbfb1f509..4af38c49bfee (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e95fbfb1f509..4af38c49bfee Created with: gclient setdep -r third_party/spirv-tools/src@4af38c49bfee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I60bbf896f59abb085bc290e6e9c5cc950b49bc43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139126 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8d3f27d1 2020-04-07T07:01:20 Roll third_party/vulkan-validation-layers/src dbd073615280..004b2914bfe3 (5 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/dbd073615280..004b2914bfe3 git log dbd073615280..004b2914bfe3 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 petr_kraus@email.cz layers: Add some headers to cmake 2020-04-06 jbolz@nvidia.com tests: Test for pAccelerationStructures objects 2020-04-06 jbolz@nvidia.com lifetimes: Validate acceleration struture objects 2020-04-06 petr_kraus@email.cz tests: Remove noop from InitSwapchain() 2020-04-06 mikew@lunarg.com build-gn: Keep generate*.py identical across repos Created with: gclient setdep -r third_party/vulkan-validation-layers/src@004b2914bfe3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I01be09bc177a133a33d4cefccb7068e67b051c4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139125 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3f00ec81 2020-04-07T07:01:10 Roll third_party/SwiftShader b8d47928094f..bdb6807825ac (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/b8d47928094f..bdb6807825ac git log b8d47928094f..bdb6807825ac --date=short --first-parent --format='%ad %ae %s' 2020-04-06 sugoi@google.com Don't blend integer formats 2020-04-06 amaiorano@google.com Clamp GLES sine/cosine to [-1,1] 2020-04-06 sugoi@google.com Delete Plane.cpp and Plane.hpp 2020-04-06 bclayton@google.com CMake / Kokoro: Build and run system-unittests. Created with: gclient setdep -r third_party/SwiftShader@bdb6807825ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I556b6e20b1bc02d6b16c7243faaddd5aef423f36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139121 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll de9f945f 2020-04-07T07:01:10 Roll third_party/vulkan-tools/src 698d82e38b39..1fbefe048387 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/698d82e38b39..1fbefe048387 git log 698d82e38b39..1fbefe048387 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 joshua@froggi.es cube: Pick non-SRGB surface formats first 2020-04-06 joshua@froggi.es cube: Remove unncessary VK_FORMAT_UNDEFINED check for surface formats Created with: gclient setdep -r third_party/vulkan-tools/src@1fbefe048387 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I2b0ad5ede6e54cb9e288fdb1e3fa5c52a54c4fd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139122 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 461f9ab1 2020-03-30T12:41:34 Capture/Replay: Implement more GLES entry points Test: Temple Run capture and replay Bug: b:152512564 Bug: angleproject:3662 Change-Id: I4cb5d081e4f590d297dc4af6b49f5dc67584ecb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128329 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Cody Northrop 84323449 2020-03-30T12:40:12 Capture/Replay: Track buffer contents by ID This CL updates how we restore buffer data after the client has unmapped it. We do this because we have no visibility into whether the buffer has been changed while mapped. Tracking a buffer map/unmap pairing by target as we have been is insufficient as apps can bind multiple buffers in succession before rebinding and unmapping selectively. To avoid this, we change our buffer data resource tracking to use the buffer ID instead of target. Also, since the app can map multiple buffers, we need to track the active buffer during MapBufferRange so we can use it during replay to restore from the appropriate handle. This is a deferred operation, so we store it as a new member of the ParamBuffer to preserve the information. Test: Temple Run capture and replay Bug: b:152512564 Bug: angleproject:3662 Change-Id: I1d3f594b496e5675e814b82acb4a238f845e26d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128328 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
angle-autoroll d2de511e 2020-04-06T07:01:46 Roll third_party/SwiftShader f99302c4efe6..b8d47928094f (15 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/f99302c4efe6..b8d47928094f git log f99302c4efe6..b8d47928094f --date=short --first-parent --format='%ad %ae %s' 2020-04-04 bclayton@google.com Vulkan: Destruct the list of vk::Query in QueryPool 2020-04-03 amaiorano@google.com Really fix Android build 2020-04-03 amaiorano@google.com Fix Chromium and Android build 2020-04-03 bclayton@google.com Debug: Add missing include. 2020-04-03 bclayton@google.com Vulkan/Debug: Create a PhysicalFile if DebugSource has no content 2020-04-03 bclayton@google.com Vulkan/Debug: Always provide the dap::Source::path 2020-04-03 bclayton@google.com CMake: Don't always regenerate OpenCLDebugInfo100.h 2020-04-03 amaiorano@google.com CMake: use gtest and gmock targets 2020-04-03 amaiorano@google.com CMake: split out atsc-encoder into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: clean up cppdap usage 2020-04-03 amaiorano@google.com CMake: split out Reactor into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out boost into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out libbacktrace into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out subzero and llvm-subzero into their own CMakeLists 2020-04-03 bclayton@google.com Kokoro: Add the ppa:ubuntu-toolchain-r/test apt-repository Created with: gclient setdep -r third_party/SwiftShader@b8d47928094f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ibef6255d40850dce7a49cc52f7196511c9ac3024 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2137129 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d560ecf0 2020-04-06T07:01:05 Roll third_party/vulkan-tools/src 7844b9b4e180..698d82e38b39 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/7844b9b4e180..698d82e38b39 git log 7844b9b4e180..698d82e38b39 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 charles@lunarg.com vulkaninfo: fix msvc warnings from wrapper classes Created with: gclient setdep -r third_party/vulkan-tools/src@698d82e38b39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I2b080a43e16b6f565a324101b37ddf5748495e3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2137127 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2ba196d8 2020-04-06T07:01:08 Roll third_party/vulkan-validation-layers/src 9a283ae3457f..dbd073615280 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9a283ae3457f..dbd073615280 git log 9a283ae3457f..dbd073615280 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 sam.walls@arm.com tests: Add tests for Arm perfdoc check 17 2020-04-03 sam.walls@arm.com practices: Add implementation of Arm perfdoc check 17 2020-04-03 sam.walls@arm.com tests: Add tests for Arm perfdoc checks 12 + 13 2020-04-03 sam.walls@arm.com practices: Add implementation of Arm perfdoc checks 12 + 13 Created with: gclient setdep -r third_party/vulkan-validation-layers/src@dbd073615280 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ifc7136d37c715be29ed36c5c7aa977e4583fcb4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2137128 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 1c95795f 2020-04-03T14:49:45 Use ImageIndex in ensureSubImageInitialized. Passes an already initialized struct so we don't need to separately pass a level and layer. Also removes some redundant gl:: prefixes in Texture.cpp and adds a new helper function doesSubImageNeedInit. Refactoring change only. Bug: angleproject:4517 Change-Id: Ib2d8a5c9ceaada03cc8d299adcb5aed53a0cf13c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135928 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill c9c4e4ed 2020-04-02T10:29:52 Track rendering feedback loops by-context. This fixes an issue where feedback loops detection would trigger false positives based on texture use in multiple contexts. 1) there are two contexts, C1 and C2, sharing resources 2) in C1, there is a texture T bound to GL_TEXTURE_2D, and a program in use that will sample C1 3) in C2, a framebuffer is created and T is bound to it This fix indexes each set of active bindings in an object by ContextID. We can potentially redo this solution in the future if this proves to have too much tracking overhead. Includes a test writen by Ken Russell. Bug: angleproject:4517 Change-Id: I67012e68947c42d863dca193972576c82d5f3712 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2134406 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Mohan Maiya 96c26c68 2020-04-03T07:52:52 Add support for NV_shader_noperspective_interpolation Added support for GL_NV_shader_noperspective_interpolation on the Vulkan and Desktop OpenGL backends Bug: angleproject:4388 Test: angle_end2end_tests --gtest_filter=ShaderInterpTest.NoPerspective/* Change-Id: I12473830c0ea8b4fffeae9c4a8ec92d979c8e18c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107234 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill e259e7e3 2020-04-02T17:33:17 Pass layer count to robust 2D array texure init. The Vulkan back-end needs the layer count to correctly initialize the whole range of the mip level. Otherwise we were only clearing a single layer of the 2D array. This only popped up when the code started to be lazier about robust resource init. Bug: angleproject:4517 Change-Id: Id5007c877d413dc80d54d9800a5898e130593451 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2134412 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Courtney Goeltzenleuchter 390ef299 2020-03-25T14:10:38 Enable blob cache when debugging We've had several issues with shader caches which are only implemented on Android which makes them challenging to debug. The existing BlobCache object has a default implementation that is disabled by default. When debug layers are enabled resize the default cache so that it gets used and provides behavior closer to Android. This caching will be enabled when debug layers are enabled, e.g. EGL_PLATFORM_ANGLE_DEBUG_LAYERS_ENABLED_ANGLE attribute is true. This is done for angle_end2end_tests and deqp tests. Reland after bugfix angleproject:4535 Bug: b:152292873 Bug: angleproject:4535 Change-Id: Icefa8c55e39985d653d8d8a8bc8c734210025b50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2134449 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
angle-autoroll 78b66a16 2020-04-03T07:01:36 Roll third_party/vulkan-validation-layers/src 499f6df688c9..9a283ae3457f (7 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/499f6df688c9..9a283ae3457f git log 499f6df688c9..9a283ae3457f --date=short --first-parent --format='%ad %ae %s' 2020-04-02 mikes@lunarg.com scripts: Make VU text sanitizing more robust 2020-04-02 jungwan82@naver.com codegen: Fixed encoding errors 2020-04-02 petr_kraus@email.cz layers: Make code Cpp20 compatible 2020-04-02 mark@lunarg.com cmake: Disable WarningsAsErrors on obsolete CLANG versions 2020-04-02 tony@lunarg.com tests: Misc cleanup 2020-04-02 s.fricke@samsung.com tests: Add Disjoint Image Barrier VUID 2020-04-02 s.fricke@samsung.com layers: Add Disjoint Image Barrier VUID Created with: gclient setdep -r third_party/vulkan-validation-layers/src@9a283ae3457f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Icf971eeb37112c462522b3659dcdd9529325c7cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135460 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill e4aa679c 2020-04-01T17:46:31 Texture: Pass explicit unpack buffer to setImage. This will allow us to call setImage internally even if there's an unpack buffer bound. Useful when implementing robust resource init with copyTexImage in some edge cases. Bug: angleproject:4517 Change-Id: I7e8e9536ab9222c620e572f7b6c20b08fa29d646 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2133088 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill dd00f16b 2020-04-02T14:04:44 Vulkan: Fix FBO cache when updating disabled attachments. Fix this by consistently checking if the attachment is enabled when we update the serials. Also includes a regression test and more ASSERTs. Bug: angleproject:4540 Change-Id: I154d23cad71f1674d893390f923f45c643a58925 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2134409 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tobin Ehlis <tobine@google.com>
angle-autoroll 93040c8d 2020-04-03T07:01:42 Roll third_party/vulkan-loader/src ba07fa0be82c..bb74deab0a4d (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ba07fa0be82c..bb74deab0a4d git log ba07fa0be82c..bb74deab0a4d --date=short --first-parent --format='%ad %ae %s' 2020-04-02 rgarcia@igalia.com Allow vkGetInstanceProcAddr to resolve itself with no instance Created with: gclient setdep -r third_party/vulkan-loader/src@bb74deab0a4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I7b5845c4a718ebd3e4b22478ee87d4b00fa77bc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135462 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cf87fa67 2020-04-03T07:01:12 Roll third_party/glslang/src 0b66fa3b62cb..b5757b95005b (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0b66fa3b62cb..b5757b95005b Created with: gclient setdep -r third_party/glslang/src@b5757b95005b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ib1e6f8c1481ba922a12d919586f0a0340986e443 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135458 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7bc4452d 2020-04-03T07:01:38 Roll third_party/SwiftShader cb58662302c8..f99302c4efe6 (7 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/cb58662302c8..f99302c4efe6 git log cb58662302c8..f99302c4efe6 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 capn@google.com Remove the D3D9 and D3D8 source code 2020-04-02 capn@google.com Remove the custom Visual Studio solution and projects 2020-04-02 capn@google.com Fix GN build 2020-04-02 bclayton@google.com Reactor: Fix remove_if brokenness 2020-04-02 capn@google.com Remove the sw::Color<> class 2020-04-02 bclayton@google.com Change for loops to use const refs, per performance-for-range-copy clang-tidy. 2020-04-02 sugoi@google.com Fix ImageView size computation Created with: gclient setdep -r third_party/SwiftShader@f99302c4efe6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I40567974e2ff9e1e7c1a7a0ca2232d251c6cb4da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135461 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cc63328f 2020-04-03T07:01:14 Roll third_party/spirv-tools/src f20c0d7971c6..e95fbfb1f509 (7 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f20c0d7971c6..e95fbfb1f509 Created with: gclient setdep -r third_party/spirv-tools/src@e95fbfb1f509 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ibcab2202a9d4d0322199b354cb496a71c49553f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135459 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 1cc49bb2 2020-04-02T11:57:07 Squash State::mContext and State::mID. These were both id values for the context. This CL consolidates to the monotonically increasing ID since it is both safer and easier to debug. Makes life easier when indexing feedback loops by context ID. Bug: angleproject:4517 Change-Id: I28b40fed4e6e68ea72742f7defde5f8638f4cd47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2134408 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Geoff Lang dd29370c 2020-04-01T10:42:47 Include the fragment output locations in the program cache key. If the user rebinds the output locations and relinks a program, the wrong program may be loaded from the cache. TEST=gl_tests: TranslatorVariants/EXTBlendFuncExtended* BUG=angleproject:4535 Change-Id: If9a9c2ad935ea4d01c3fe4313810d221e9c9ce38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2131252 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Nico Weber a053f340 2020-04-01T16:58:16 Vulkan: Use shader stage specific barrier Followup fix for copy/paste error that ImageLayout::GeometryShaderReadOnly was using VK_PIPELINE_STAGE_VERTEX_SHADER_BIT Bug: angleproject:4467 Change-Id: I5be7f800177c4f36a334f1cc75f876e271ca22b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2133089 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 75a2ee30 2020-04-02T08:10:13 Roll third_party/glslang/src 1fff36235504..0b66fa3b62cb (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1fff36235504..0b66fa3b62cb Created with: gclient setdep -r third_party/glslang/src@0b66fa3b62cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ib9f61c6cd769c6fdea7ee68d683079c498566496 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2133649 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 84b6e0d9 2020-04-02T07:01:39 Roll third_party/SwiftShader 5cf1e9a31c90..cb58662302c8 (7 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/5cf1e9a31c90..cb58662302c8 git log 5cf1e9a31c90..cb58662302c8 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 cwallez@cwallez-macbookpro3.roam.corp.google.com MetalSurface: set layer.device to a ref of the system default device. 2020-04-01 bclayton@google.com Regres: Add invertCommon optimization. 2020-04-01 bclayton@google.com Regres: Move optimization logic to separate file 2020-04-01 bclayton@google.com Regres: Keep coverage span groups stable. 2020-04-01 bclayton@google.com Regres: Split coverage.go into multiple files 2020-04-01 bclayton@google.com Regres: Further optimizations for coverage 2020-04-01 bclayton@google.com Regres: Add cov.ReadJSON() Created with: gclient setdep -r third_party/SwiftShader@cb58662302c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I5045b14bd9f36d571dea44a0b5e4c2cdc97dea25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2133563 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9b1e27a2 2020-04-02T07:01:15 Roll third_party/spirv-tools/src c37c94929bf5..f20c0d7971c6 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c37c94929bf5..f20c0d7971c6 Created with: gclient setdep -r third_party/spirv-tools/src@f20c0d7971c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I4b029be45e80a54dcf5b7980b51aa1f2ac2a3a89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2133561 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e57f1ef8 2020-04-02T07:01:36 Roll third_party/vulkan-validation-layers/src f5504529553f..499f6df688c9 (7 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f5504529553f..499f6df688c9 git log f5504529553f..499f6df688c9 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 rverschelde@gmail.com build: Don't set MSVC pragma for Win32 GCC/Clang 2020-04-01 dsinclair@google.com layers: Add braces around std::array initializers 2020-04-01 jbolz@nvidia.com layers: Add missing AccelerationStructure logic 2020-04-01 tony@lunarg.com docs: CLarify location of debug printf test 2020-04-01 jbolz@nvidia.com tests: Test that VUID 03339 doesn't fire for EXT BDA 2020-04-01 jbolz@nvidia.com layers: Split EXT buffer_device_address features from KHR 2020-04-01 mark@lunarg.com cmake: Add xxhash.c to layer_support_files Created with: gclient setdep -r third_party/vulkan-validation-layers/src@499f6df688c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I8aed9ea18345ce9a9cfb9a8c28eebd06f8753531 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2133562 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Corentin Wallez 1e81dd4a 2020-04-01T17:46:58 Suppress failures after Win Intel driver upgrade. Bug: angleproject:4533 Change-Id: I482c4caa79fb5fdc9cd4a068f7e7e05890121fa2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2130227 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 4db77367 2020-03-03T12:04:26 Vulkan: Don't detach separable shaders in Program::detachShader() To support Program Pipeline Objects, we need to hold on to the shaders in separable programs, rather than detaching them during glDetachShader()/glCreateShaderProgramv(). This is necessary due to requiring the shader information for validating shader interfaces, varyings, etc. Instead, a new ShaderMap of bools will be stored in ProgramState::mAttachedShadersMarkedForDetach to track when a caller attempts to detach a shader from a separable Program. Later, when a new shader is attached, we will first validate that the old shader is marked to be detached, and if so, release it then. Bug: angleproject:3570 Change-Id: I63fac2e5914c1c1a73f0b37863bac0f185ecb44c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2084399 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Mohan Maiya 745e0712 2020-03-21T17:46:05 Vulkan: Enable CPU only buffers for PBOs Add support for a CPU only buffer for PBOs that serve as the destination for all host operations like MapBuffer*. This removes the latency caused by waiting for the in-flight GPU commands to be complete before handing over the buffer to the app. This change removes a ~6ms wait/sleep on the first call to MapBuffer* in each frame of Manhattan Bug: angleproject:4339 Tests: angle_end2end_tests --gtest_filter=BufferDataTest*Vulkan Change-Id: I52016b160af8a670cc30f01c05e48f699521310f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2116874 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Tobin Ehlis <tobine@google.com>
Nico Weber dcd98298 2020-04-01T16:58:16 Remove breaks after returns. No behavior change. Bug: chromium:1066980 Change-Id: I26a5c13a730cbc6cde8e888a8a18bd633bb3f748 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2133087 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
Hyunchang Kim 449d9d76 2020-03-31T17:27:00 Vulkan: Refactor garbarge collection related parameter Use RendererVk instead of VkDevice as a parameter in garbage collection functions. Bug: angleproject:2162 Change-Id: Ifd53e05223d6d603402c9b7fcfa82fe1f896458c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2131882 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 20e375eb 2020-03-14T20:27:09 Vulkan: Use shader stage specific barrier Seperate vertex and fragment shader read/write with shader stage specific barriers Bug: angleproject:4467 Change-Id: Id18909b497b087e58d750023399943bc9d414edf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102957 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Hyunchang Kim 6281e30d 2020-03-31T15:41:23 Vulkan: Add flush condition for the device memory updated by CPU Memory created using HOST_COHERENT_BIT does not need to be explicitly flushed. Bug: angleproject:2162 Change-Id: Idc2001e2254de616d7e7067410d225d0b521f29f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2131881 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Hyunchang Kim d30da072 2020-03-31T15:01:14 Vulkan: Request host uncached memory for some glBuffer objects Uncached memory is an optimal memory type for resources with write-only access from the CPU since it avoids polluting CPU caches with data the CPU will never use. Bug: angleproject:2162 Change-Id: I33d0d91830979990bcdcca3bd9eedde0345fb5a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2131880 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 7b138286 2020-03-31T23:59:18 Add SwANGLE bots to ANGLE CQ. 2 bots are added, linux-swangle-try-tot-angle-x64 and win-swangle-try-tot-angle-x86 Also updated wrangling instructions to keep these CQ bots healthy, and other SwANGLE bots at lower priority. Bug: chromium:1007018 Change-Id: I38a1cc31eb4d787d192da087efce3cc619cb118d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2131567 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Ancheng Qiao afd2cfa6 2020-03-19T17:39:23 Add gles1 covgl tests CovglTest have additional error check in TEST ProbeError(Call* functions, use a tricky method here, alias all ProbeError to ProbeErrorANGLE. add "#define ProbeEror ProbeErrorANGLE" to all covgl source code besides shell.c Currently for win/mac platform block on $gles1_conform_root/platform/platform.h conflict with $angle_root/include/platform/Platform.h Bug: angleproject:2303 Change-Id: I96679968bf539d6ae3bdfc3aa89150381679cbb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2117950 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 38df4ab6 2020-04-01T07:01:12 Roll third_party/glslang/src e157435c1e77..1fff36235504 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e157435c1e77..1fff36235504 Created with: gclient setdep -r third_party/glslang/src@1fff36235504 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I477fe5e51b8125a928d89b96731aa7005f8a7080 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2131706 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7b1df7b8 2020-04-01T07:01:14 Roll third_party/spirv-tools/src fd773eb50d62..c37c94929bf5 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fd773eb50d62..c37c94929bf5 Created with: gclient setdep -r third_party/spirv-tools/src@c37c94929bf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I0474c94b4627946340063f81cf4faafb31b78748 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2131707 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8b408958 2020-04-01T07:01:36 Roll third_party/vulkan-tools/src d712a6b03b9e..7844b9b4e180 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d712a6b03b9e..7844b9b4e180 git log d712a6b03b9e..7844b9b4e180 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 jeremyk@lunarg.com build: Update glslang version in known-good.json Created with: gclient setdep -r third_party/vulkan-tools/src@7844b9b4e180 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I3907c8002f1103cb8e91cbe362f9830f41f20c6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2131709 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 46ee73e0 2020-04-01T07:01:36 Roll third_party/vulkan-validation-layers/src 9a0f2d99fd5d..f5504529553f (30 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9a0f2d99fd5d..f5504529553f git log 9a0f2d99fd5d..f5504529553f --date=short --first-parent --format='%ad %ae %s' 2020-03-31 shannon@lunarg.com build: Update glslang known-good for SDK 1.2.135 2020-03-31 cwallez@chromium.org debug_printf: also suppress -Wformat-security on clang 2020-03-30 dsinclair@google.com layers: Add braces around array initializer 2020-03-30 tony@lunarg.com gpu: Add null terminator to types array 2020-03-30 mark@lunarg.com travis: Remove Vulkan-Tools from known good 2020-03-30 mark@lunarg.com build: Remove VulkanTools from known good 2020-03-30 mark@lunarg.com tests: Add multi-object message output test 2020-03-30 mark@lunarg.com lifetimes: Pass pertinent objects to utils callback 2020-03-30 mark@lunarg.com corechecks: Pass shaderval multiobjs to debug callback 2020-03-30 mark@lunarg.com practices: Enable mutli-object output for utils callback 2020-03-30 mark@lunarg.com corechecks: Expose multiple buffer val objects to dbg callback 2020-03-30 mark@lunarg.com corechecks: Include multiple objects in debug callbacks 2020-03-30 mark@lunarg.com chassis: Add multiobject error message support 2020-03-30 mark@lunarg.com chassis: Fix internal-to-core object conversion function 2020-03-30 tony@lunarg.com gpu: Fix debug printf to use new logging mechanism 2020-03-30 tony@lunarg.com docs: Add doc for debug printf 2020-03-30 tony@lunarg.com gpu: Use enum from headers to enable debug printf 2020-03-30 tony@lunarg.com gpu: Rename shader printf to debug printf 2020-03-30 tony@lunarg.com gpu: Clean up error messages 2020-03-30 tony@lunarg.com gpu: Disable printf if gpu-av is enabled 2020-03-30 tony@lunarg.com gpu: Add printf truncation warning 2020-03-30 tony@lunarg.com gpu: Add buffer size, verbosity and stdout options 2020-03-30 tony@lunarg.com gpu: Share code between gpu-av and shader printf 2020-03-30 tony@lunarg.com tests: Add test for shader printf 2020-03-30 tony@lunarg.com tests: Allow tests to look for Info severity 2020-03-30 tony@lunarg.com gpu: Add settings for shader printf 2020-03-30 tony@lunarg.com gpu: Add shader debug printf object 2020-03-30 jbolz@nvidia.com tests: Test using a sparse image after freeing memory 2020-03-30 jbolz@nvidia.com layers: Make FreeMemory remove memory from sparse_bindings 2020-03-30 joshua@froggi.es logging: Fix building on VS2019 Created with: gclient setdep -r third_party/vulkan-validation-layers/src@f5504529553f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I35dead7f45a082a327c61d4e97cceef342f6d814 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2131708 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 7d8c2f2e 2020-03-26T22:44:15 Hide SwiftShader OS Window in dEQP and end2end tests This prevents a race between starting Xvfb on test bots and X11 calls in X11Window::setVisible(), which used to cause flaky hangs on Linux SwANGLE bots. Unfortunately, in order to hide SwiftShader OS window, it must be a separate window from other backends, so it is no longer possible to have a single window for all backends, even if we don't reuse EGL Display. The only platform that still uses a single OS Window is Android, since there is only one system window per test application. In addition, all the tests that make OS Window visible explicitly, no longer do this for SwiftShader device. Bug: angleproject:4434 Change-Id: I1a067c22bfeee9288046b9d9566740731c0d627c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2125945 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov d2c33b53 2020-03-31T20:04:12 Skip SwANGLE GLES31 tests which flakily crash with Win 32-bit Subzero Bug: angleproject:4482 Change-Id: Ic5ff9a390b004029b1581f5726ab64d85c4ab074 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2131388 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Charlie Lao 6328caf3 2020-03-24T19:31:02 Vulkan: Avoid renderpass break for occlusion query This ensures beginQuery and endQuery only get inserted into renderpasses and will not close renderpass because of query call Bug: angleproject:4381 Change-Id: I690f096b9e8e4b7ea9a67045d1be0fd7a319c98c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119246 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Jonah Ryan-Davis 4b94d7bb 2020-03-24T17:23:19 Split EGL_CHROMIUM_sync_control into EGL_ANGLE_sync_control_rate eglGetMscRateCHROMIUM was added to EGL_CHROMIUM_sync_control based on the original extension GLX_OML_sync_control. However, this new function is not universally implemented. This CL moves it to a new extension, EGL_ANGLE_sync_control_rate, and renames it to eglGetMscRateANGLE. Bug: chromium:1064078 Change-Id: Ia2a29c6776b2b2bf2b98e58ee83b5f141ed01301 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118154 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Kenneth Russell 91ea27ae 2020-03-27T16:22:14 Apply limitMaxMSAASamplesTo4 workaround to macOS. On dual-GPU MacBook Pros, the maximum number of supported samples can differ between the integrated and discrete GPUs, leading to unexpected OpenGL errors in applications. Detected with WebGL conformance tests in Safari with ANGLE as the WebGL backend. Bug: angleproject:4518 Change-Id: I54997cbb83afd76d98b16d138d117d0afdeec5e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2125407 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cody Northrop 06f4f3e1 2020-03-30T10:57:06 Capture/Replay: Disable binary formats when FrameCapture is enabled Rather than capture and replay a format that is not cross platform, limit the number of exposed binary formats to zero when FrameCapture is enabled. Test: Temple Run capture and replay Bug: b:152512564 Bug: angleproject:3662 Change-Id: I4a7bc5a353d2cdb1dceb1276a3c61bfbb74dc2f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128327 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Jamie Madill db32bda4 2020-03-30T17:01:54 Vulkan: Observe staging buffer changes in TextureVk. This switches where we notify the Texture class that the back-end has a dirty staging buffer. Previously we notified in every possible code site in TextureVk. Now we notify in a single centralized location in the staging buffer. This will allow us to stash clears in the staging buffer in the FramebufferVk class via RenderTargetVk. And ultimately let us defer clears to fix Manhattan's rendering feedback loop. Bug: angleproject:4517 Change-Id: I67760f133e2c58feddbba3d1062de0b966bac281 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128546 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ancheng Qiao dbb23ec3 2020-03-30T14:24:53 Vulkan: Remove swiftshader mipmap3d test skip Bug: angleproject:3983 Change-Id: I9c487cc7db5d5e22a6cff00b40e4081498ab771f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128207 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 9120bcae 2020-03-31T07:01:12 Roll third_party/glslang/src 344bd0889ac9..e157435c1e77 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/344bd0889ac9..e157435c1e77 Created with: gclient setdep -r third_party/glslang/src@e157435c1e77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ie7037a9f4ab93c119eacddbfac2ebf8d903da166 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2129394 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4c406f8c 2020-03-31T07:01:36 Roll third_party/vulkan-tools/src bec7b6e29260..d712a6b03b9e (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/bec7b6e29260..d712a6b03b9e git log bec7b6e29260..d712a6b03b9e --date=short --first-parent --format='%ad %ae %s' 2020-03-30 jeremyk@lunarg.com build: Update glslang commit ID in known-good.json 2020-03-30 jeremyk@lunarg.com travis: Add clang-format verions output to travis 2020-03-30 jeremyk@lunarg.com docs: Update clang-format version in docs 2020-03-28 charles@lunarg.com vulkaninfo: Fix lack of display throwing on linux Created with: gclient setdep -r third_party/vulkan-tools/src@d712a6b03b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I3b3438f38c4c1adbe18ddc575b93cba1f85a7fa7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2129395 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b6176ed4 2020-03-31T07:01:39 Roll third_party/SwiftShader 1c29477aa06e..5cf1e9a31c90 (6 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/1c29477aa06e..5cf1e9a31c90 git log 1c29477aa06e..5cf1e9a31c90 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 capn@google.com Fix implicit narrowing cast 2020-03-30 capn@google.com Eliminate the legacy PowerVR SDK 2020-03-30 capn@google.com Integrate PowerVR OpenGL ES samples 2020-03-30 capn@google.com Fix completeness test of OpenGL ES immutable textures 2020-03-30 cwallez@google.com Revert "MetalSurface: set layer.device to a ref of the system default device." 2020-03-30 cwallez@cwallez-macbookpro3.roam.corp.google.com MetalSurface: set layer.device to a ref of the system default device. Created with: gclient setdep -r third_party/SwiftShader@5cf1e9a31c90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I88c367ed84cfe46586020e8c4fdbd06d46ec5b82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2129397 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bf4a734c 2020-03-31T07:01:42 Roll third_party/vulkan-loader/src b0c27ce32864..ba07fa0be82c (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b0c27ce32864..ba07fa0be82c git log b0c27ce32864..ba07fa0be82c --date=short --first-parent --format='%ad %ae %s' 2020-03-30 charles@lunarg.com loader: fix mispelling of implement Created with: gclient setdep -r third_party/vulkan-loader/src@ba07fa0be82c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: If5e74f8cb4e7f7c79bf8d2f8f000f0acdd69a2b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2129398 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 05fa1a99 2020-03-30T22:02:16 Skip test flaky on SwANGLE bots dEQP.EGL/functional_sharing_gles2_multithread_random_egl_server_sync_shaders_compile_9 EGLSurfaceTest.ResizeWindow AttributeLayoutMemoryIndexed.Test Bug: angleproject:4495, angleproject:4453, angleproject:4502 Change-Id: Iad5097412372acc8ac36c742445763451c8122ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2129181 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 1288aa12 2020-03-27T12:24:52 Update the active texture cache before changing the texture binding. When a new texture is bound, the texture binding state is updated before updating the active texture cache. With this ordering, it is possible to delete the currently bound texture when the binding changes and then use-after-free it when updating the active texture cache. BUG=angleproject:1065186 Change-Id: Id6d56b6c6db423755b195cda1e5cf1bcb1ee7aee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2124588 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexis Hetu b83b0f5e 2020-01-31T15:09:17 Add support for NV_read_depth, NV_read_stencil and NV_depth_buffer_float2 extensions This cl adds the ability for the ReadPixels function to read other attachments than the color attachment. Checks were added for both depth and stencil attachments. A new test was added (DepthStencilFormatsTest.DepthStencilReadback) to test this new functionality. As the name mentions, it's used to test reading from the depth and stencil attachments using ReadPixels. Bug: angleproject:4295 Change-Id: I6fe9be11f05d6055a5883b4315f870e7c0ac41ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2031702 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Corentin Wallez 7939e367 2020-03-30T18:52:19 Revert "Enable blob cache when debugging" This reverts commit 617cb015f3e95c3c89090870bae086e92515a91d. Reason for revert: Seems to cause rolls in Chromium to fail: https://chromium-review.googlesource.com/c/chromium/src/+/2127135 Original change's description: > Enable blob cache when debugging > > We've had several issues with shader caches which are only implemented > on Android which makes them challenging to debug. > The existing BlobCache object has a default implementation that is > disabled by default. When debug layers are enabled resize the default > cache so that it gets used and provides behavior closer to Android. > This caching will be enabled when debug layers are enabled, e.g. > EGL_PLATFORM_ANGLE_DEBUG_LAYERS_ENABLED_ANGLE attribute is true. > This is done for angle_end2end_tests and deqp tests. > > Bug: b:152292873 > Change-Id: I9dcd90a1a8da88127bf8dac25031056b7279207e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2113133 > Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=courtneygo@google.com,ianelliott@google.com,jmadill@chromium.org Change-Id: I42a445b93eff1237b05a82d2836c218b9bbbd08b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:152292873 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128106 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cody Northrop 74e816bf 2020-03-26T17:40:25 Vulkan: Expose extension for ETC1 usage with subimage updates This CL implements the GL_EXT_compressed_ETC1_RGB8_sub_texture extension, which was added to relax restrictions on using ETC1_RGB8_OES for subimage updates. Test: Temple Run on Android Bug: b:152512564 Change-Id: I78cfd7dfd54fab36dee59a93b3ec3bfce17e73e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123232 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Courtney Goeltzenleuchter 617cb015 2020-03-25T14:10:38 Enable blob cache when debugging We've had several issues with shader caches which are only implemented on Android which makes them challenging to debug. The existing BlobCache object has a default implementation that is disabled by default. When debug layers are enabled resize the default cache so that it gets used and provides behavior closer to Android. This caching will be enabled when debug layers are enabled, e.g. EGL_PLATFORM_ANGLE_DEBUG_LAYERS_ENABLED_ANGLE attribute is true. This is done for angle_end2end_tests and deqp tests. Bug: b:152292873 Change-Id: I9dcd90a1a8da88127bf8dac25031056b7279207e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2113133 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 50a47bd9 2020-03-30T07:01:37 Roll third_party/vulkan-validation-layers/src 55f01953d6e9..9a0f2d99fd5d (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/55f01953d6e9..9a0f2d99fd5d git log 55f01953d6e9..9a0f2d99fd5d --date=short --first-parent --format='%ad %ae %s' 2020-03-27 jbolz@nvidia.com tests: Test VUID-VkSparseImageMemoryBindInfo-image-02901 2020-03-27 jbolz@nvidia.com layers: Implement VUID-VkSparseImageMemoryBindInfo-image-02901 2020-03-27 jbolz@nvidia.com scripts: Make safe structs 'union' or 'struct' to match the Vulkan headers 2020-03-27 mark@lunarg.com docs: Update clang-format required version Created with: gclient setdep -r third_party/vulkan-validation-layers/src@9a0f2d99fd5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I549a97494f1f9ba332488c6653888aa4920d394b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2126479 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6774f9bd 2020-03-30T07:01:40 Roll third_party/SwiftShader 02e15b249b12..1c29477aa06e (19 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/02e15b249b12..1c29477aa06e git log 02e15b249b12..1c29477aa06e --date=short --first-parent --format='%ad %ae %s' 2020-03-29 capn@google.com Don't expose the sampling routine cache's mutex 2020-03-29 capn@google.com Create PowerVR targets if submodule already exists 2020-03-28 bclayton@google.com Regres: Generate coverage data on nightly runs 2020-03-28 bclayton@google.com Subzero Coroutines: Use ultra-low-level marl APIs 2020-03-28 bclayton@google.com Subzero: Ensure coroutines are same-thread. 2020-03-28 capn@google.com Rename constant cache to snapshot cache 2020-03-28 capn@google.com Add sampling routine documentation 2020-03-27 sugoi@google.com Fix Android.bp following the SPIRV-Tools update 2020-03-27 bclayton@google.com Regres: Switch to building with LLVM 10 2020-03-27 bclayton@google.com Regres: Add llvm.Version.Download() to download and verify a LLVM toolchain 2020-03-27 bclayton@google.com Kokoro: Test LLVM 10 backend for ubuntu 2020-03-27 bclayton@google.com Coverage: Add 'turbo-cov': a faster reimplementation of llvm-cov 2020-03-27 capn@google.com Don't download all submodules for Kokoro tests 2020-03-27 bclayton@google.com Reactor: Disable more warnings to get LLVM 10 building 2020-03-27 bclayton@google.com LLVM 10: Add configs/common and configs/darwin. 2020-03-27 bclayton@google.com LLVM 10: Add configs/common and configs/linux. 2020-03-27 sugoi@google.com Update SPIR-V Tools to fd773eb50 2020-03-27 sugoi@google.com Update SPIR-V Headers to f8bf11a02 2020-03-27 digit@google.com Remove two minor compiler warnings/errors: Created with: gclient setdep -r third_party/SwiftShader@1c29477aa06e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I46d87ba91dbad14dacc8e1aac9994917912edf25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2126481 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8eb3ec7e 2020-03-30T07:01:42 Roll third_party/vulkan-loader/src cc481ef27631..b0c27ce32864 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/cc481ef27631..b0c27ce32864 git log cc481ef27631..b0c27ce32864 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 mikew@lunarg.com tests: Use complete version from header 2020-03-27 mikew@lunarg.com loader: Use complete version from header Created with: gclient setdep -r third_party/vulkan-loader/src@b0c27ce32864 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I4d3d4af2ac995fb18150c03942b4cb3969fef2b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2126482 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 47e3be4e 2020-03-30T07:01:12 Roll third_party/glslang/src 99508c1ce389..344bd0889ac9 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/99508c1ce389..344bd0889ac9 Created with: gclient setdep -r third_party/glslang/src@344bd0889ac9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Id2316c86a9281d419b78fe8f8e48fb601ef6e0a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2126478 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 1b2dd6f9 2020-03-02T16:28:15 Vulkan: Refactor varying validation for separable programs The varying validation is being refactored to better handle separable programs. Some additional validation is being added as well regarding: - Number of varyings (inputs vs outputs) - Precision This refactor will also allow ProgramPipelines to validate varyings between shaders that are in different Programs. Bug: angleproject:3570 Change-Id: I13f324da2ffea039e696962d6971a54f7a7b6f77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2083847 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Tim Van Patten b387ce93 2020-02-21T16:05:41 Vulkan: Move ProgramInfo/ShaderInfo to ProgramExecutableVk The classes ProgramInfo and ShaderInfo are being moved into ProgramExecutableVk along with the ProgramVk members mDefaultProgramInfo and mLineRasterProgramInfo. This refactor is necessary since these members are common between ProgramVks and ProgramPipelineVks. Bug: angleproject:3570 Change-Id: I94cdb1096c6a0c007d858135af694da58d7897ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068901 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten f47dccab 2020-02-21T15:40:36 Vulkan: Create TransformSpirvCode() To support Program Pipeline Objects, the SPIR-V transformations must be completed at draw time once all of the variable locations are known. To achieve this, the transformation work is being refactored into TransformSpirvCode() which can be called separately from GlslangGetShaderSpirvCode(). Bug: angleproject:3570 Change-Id: Ia479cb2e4b4201e37acd0859c70081cecb80d0bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068900 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 85c076ee 2020-02-20T17:54:35 Vulkan: Make mVariableInfoMap a gl::ShaderMap<> The ShaderInterfaceVariableInfoMap information is specific to each shader stage, since the locations are determined for each shader stage. This change makes mVariableInfoMap a gl::ShaderMap<> to handle this, which will make it easier to compile separable programs, determine the variable locations, and transform the SPIR-V. Bug: angleproject:3570 Change-Id: I28b71a37efe54bbcfe1dcd445fa03ee71e74f0a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062741 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Tim Van Patten abaa3573 2020-02-20T10:23:02 Vulkan: Only calculate variable locations once Variable locations and descriptor set/binding values are calculated multiple times: - Compiling GLSL->SPIR-V - Creating the Vulkan pipeline layout - Updating descriptor sets These values should instead be calculated once and reused throughout since they won't change without recompiling the shader program. Bug: angleproject:3570 Change-Id: I5d8767b3b2e2f741aade7fec9991eea53ee2eb98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2067101 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 10ade024 2020-02-13T18:11:54 Create the ProgramExecutableVk Class The ProgramExecutableVk class is being created to collect data structures that are common to both ProgramVks and ProgramPipelineVks, as well as any shared functions. This allows callers to make Program-/ProgramPipeline- specific queries without needing to know exactly which responded by querying the current ProgramExecutableVk. This will also allow the necessary data structures to only be populated and stored within the ProgramExecutableVk when necessary and reused as often as necessary. A few things are being moved into this class: - mVariableInfoMap This information will be required to defer translating the SPIR-V until when the vulkan pipeline layout is determined and the actual locations are known.   This will also allow removing determining these locations twice (during GLSL->SPIR-V compilation and pipeline layout). - createPipelineLayout() - update*DescriptorSet() - Descriptor Set Layout lists - Pipeline Layout - Various other functions/members related to pipeplines, descriptor sets, etc. Bug: angleproject:3570 Change-Id: I4b5ababeafec865148783c8ffd4c15f659f4856d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055656 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov b19000f3 2020-03-27T19:47:08 Skip KHR-GLES31.core.shader_image_load_store.advanced-allMips-* tests Were previosly FAIL, but crash on Windows SwANGLE. Bug: angleproject:4414 Change-Id: Iefe1625f7ad3eec8ba091ec3543e8cb699c62c65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2125370 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill d03b15b2 2020-03-26T17:22:18 Vulkan: Mask out Depth/Stencil RTs in feedback loops. This should enable some cases of limited support for feedback loops with depth/stencil buffers. For example with Manhattan and the Vulkan back-end. Increases the number of RenderPasses in Manhattan slightly. This will regress performance slightly until we can work out a better solution that is also conformant with the spec. Bug: angleproject:4517 Change-Id: I2758e6b4c2a930474c09cdc0950f3b6c34541089 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106670 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Tim Van Patten 68083e89 2020-03-04T15:55:53 Vulkan: Move cached samplers/images and has*() to ProgramExecutable The active samplers and images are being moved from Program into ProgramExecutable to unify interacting with them for Programs and ProgramPipelines Also, create some helper functions for gl::Program that ProgramExecutable can call to make it easier for ProgramPipeline to respond to similar queries for each of the Programs in the ProgramPipeline. Bug: angleproject:3570 Change-Id: I0b37f1a379e56b9659d82d92f6d7a546beee11cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2087648 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill bd2bdf9f 2020-03-26T15:40:09 Fix feedback loop clearing detection. Bug: angleproject:4517 Change-Id: I3231b129718019f83495843404cd011eb2cd480d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2122689 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com>
Jamie Madill 0bba1100 2020-03-27T14:39:44 Update OWNERS information. Also includes some documentation maintenance. Bug: angleproject:4511 Change-Id: I7ecce494909f06387875ff85a10004d0c446bbaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2124597 Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill 13c139e7 2020-03-21T15:25:50 Support masking out DS feedback loops in RenderTargetCache. Currently this is a pure refactor and doesn't change any functionality. In a follow-up we can us this bit to mask out DS RTs when Manhattan and other apps render with feedback loops. Bug: angleproject:4517 Change-Id: I80ccd022d90a781506791110d11be195db8cd3e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112936 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang 0e65abea 2020-03-27T10:32:18 D3D11: Serialize and deserialze mImage2DUniforms. mImage2DUniforms was not saved with the program binary causing shaders with images to fail compilation when loaded from binary. BUG: angleproject:4519 BUG: b:152292873 Change-Id: I51581031ae1f9d4b4d986057ef3f876d809c7f24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2124587 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Tim Van Patten 7e0699a2 2020-02-05T17:04:06 Create the ProgramExecutable Class The ProgramExecutable class is being created to collect data structures that are common to both Programs and ProgramPipelines, as well as any shared functions. This allows callers to request the current ProgramExecutable from the State and make Program-/ProgramPipeline-specific queries without needing to know exactly which responded. This will also allow the necessary data structures to only be populated and stored within the ProgramExecutable when necessary and reused as often as necessary. Bug: angleproject:3570 Change-Id: I101f08ab03421894667b4a426a04d2147489f0e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2040512 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll fd3480d2 2020-03-27T07:01:42 Roll third_party/vulkan-loader/src acbf316040c3..cc481ef27631 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/acbf316040c3..cc481ef27631 git log acbf316040c3..cc481ef27631 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 udknight@gmail.com docs: Fix wrong type name in InterceptFunctionName prototype Created with: gclient setdep -r third_party/vulkan-loader/src@cc481ef27631 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I8ba7480037117cce4e2ba8f5f851fa1cce890b88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123983 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 651fc45d 2020-03-27T07:01:12 Roll third_party/glslang/src 2df8c71258de..99508c1ce389 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2df8c71258de..99508c1ce389 Created with: gclient setdep -r third_party/glslang/src@99508c1ce389 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I9ddd9b7cfdee4b54da8e1a36a8c46283ef09e75d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123981 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6431673e 2020-03-27T07:01:37 Roll third_party/vulkan-validation-layers/src 443c2caa1714..55f01953d6e9 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/443c2caa1714..55f01953d6e9 git log 443c2caa1714..55f01953d6e9 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 s.fricke@samsung.com layers: Fix renderpass2 VUID Created with: gclient setdep -r third_party/vulkan-validation-layers/src@55f01953d6e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ib8b7160e7c1691cec71a50509676fa739919d520 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123982 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c1f94204 2020-03-27T07:01:12 Roll third_party/SwiftShader 77090261dabc..02e15b249b12 (8 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/77090261dabc..02e15b249b12 git log 77090261dabc..02e15b249b12 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 bclayton@google.com third_party: Create scripts for updating spirv-[tools|headers] 2020-03-26 capn@google.com Fix taking aspect into account for image view identifiers 2020-03-26 bclayton@google.com Kokoro: Move llvm configs into 7.0 subdirectory, create 10.0 copies. 2020-03-26 bclayton@google.com Regres: Add support for generating collated coverage info 2020-03-26 bclayton@google.com CMake: Emit coverage-toolchain.txt file next to ICD json 2020-03-26 bclayton@google.com CMake: Add SWIFTSHADER_EMIT_COVERAGE option 2020-03-26 bclayton@google.com CMake: Add option for selecting LLVM version. 2020-03-26 bclayton@google.com Merge "Initial drop of LLVM 10 to third_party/llvm-10.0" Created with: gclient setdep -r third_party/SwiftShader@02e15b249b12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I6250b123e1feed7defddeeb0197b03f7182d43e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123980 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop f2bee304 2020-03-25T22:41:32 Capture/Replay: Implement more GLES entrypoints Tested with several apps that can't be captured otherwise. Bug: angleproject:3611 Change-Id: I2ad18c3bfcab48b0b385b2a868f57369c292b602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1998838 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop d8c1b03c 2020-03-26T07:06:25 Roll glslang and Vulkan validation layers Autoroller for glslang was paused, breaking layer build. Replaces: https://crrev/c//2119884 TBR: courtneygo@google.com Bug: b:152298150 Bug: angleproject:4510 Change-Id: I6c431a76455c991cbbb8621050dbf74acf8eea41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2121903 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll bf6b8d4a 2020-03-26T07:02:22 Roll third_party/vulkan-headers/src fb7f9c9bcd1d..0e78ffd1dcfc (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/fb7f9c9bcd1d..0e78ffd1dcfc git log fb7f9c9bcd1d..0e78ffd1dcfc --date=short --first-parent --format='%ad %ae %s' 2020-03-24 oddhack@sonic.net Update for Vulkan-Docs 1.2.136 Created with: gclient setdep -r third_party/vulkan-headers/src@0e78ffd1dcfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=cnorthrop@google.com Bug: None Change-Id: I17d7b9ba8e96fa1e3dab15260436b71887d55536 Tbr: cnorthrop@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2121708 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll da984675 2020-03-26T07:01:42 Roll third_party/vulkan-loader/src ff44f21a0178..acbf316040c3 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ff44f21a0178..acbf316040c3 git log ff44f21a0178..acbf316040c3 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 charles@lunarg.com scripts: stubs in dispatch table lacked matching return types Created with: gclient setdep -r third_party/vulkan-loader/src@acbf316040c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I5505867022ca850e4b94e1bf4454c03ec93850a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119885 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0ee5eb6d 2020-03-26T07:01:04 Roll third_party/SwiftShader 540bdf92531d..77090261dabc (10 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/540bdf92531d..77090261dabc git log 540bdf92531d..77090261dabc --date=short --first-parent --format='%ad %ae %s' 2020-03-25 capn@google.com Identify image views based on their state 2020-03-25 capn@google.com Provide packed VkFormat to uint8_t mapping 2020-03-25 capn@google.com Uniquely identify sampler state 2020-03-25 capn@google.com Split vk::Sampler state off into a structure 2020-03-25 capn@google.com Fix handling Memset<> assignment and comparison 2020-03-25 bclayton@google.com Add script for updating llvm 10 2020-03-25 amaiorano@google.com regres: add daily run against SwiftShader/Subzero 2020-03-25 bclayton@google.com CMake: Don't export LLVM_INCLUDE_DIR to PARENT_SCOPE 2020-03-25 bclayton@google.com CMake: Move LLVM rules out to third_party/llvm-7.0 2020-03-25 bclayton@google.com Add missing copyright header to CMakeLists.txt Created with: gclient setdep -r third_party/SwiftShader@77090261dabc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ie880cfbad88061a571bedcf2b41a2876275fdd81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119882 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7a58e5b7 2020-03-26T07:01:14 Roll third_party/spirv-tools/src 1346dd5de119..fd773eb50d62 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1346dd5de119..fd773eb50d62 Created with: gclient setdep -r third_party/spirv-tools/src@fd773eb50d62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I6349d641ed962bb159f0659054055896eaa3b9c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119883 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Courtney Goeltzenleuchter 6719f54a 2020-03-24T08:36:41 Update Vulkan header and related repos Vulkan header was updated with non-backward compatible change so need to update all dependencies simultaneously. Bug: b:152298150 Bug: angleproject:4510 Change-Id: I46ac9a3a0ccb52184fd183df617804c866b63453 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118151 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop b69c4e14 2020-03-24T15:02:06 Capture/Replay: Update CaptureReplay sample for compression * Move DecompressBinaryData to a shared helper * Start using it in CaptureReplay sample * Error out if decompress callback isn't set correctly Test: AngryBirds and CandyCrush captures replay on desktop Test: angle_perftests --gtest_filter="*Trace*" Bug: angleproject:4484 Change-Id: I0432004fdb0cfb0fd61f9a66f792591c9aa40d9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118790 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0