kc3-lang/angle

Log

Author Commit Date CI Message
Igor Nazarov 7a81e79d 2024-08-02T19:39:57 Vulkan: Fix mPipelineCache not populated from blob cache Fixes regression introduced in change: Vulkan: Remove support for pipeline cache control https://chromium-review.googlesource.com/c/angle/angle/+/5375102 Returns logic implemented in: Vulkan: pipeline cache not populated as blob cache is not set https://chromium-review.googlesource.com/c/angle/angle/+/1683807 In the current state, call to `ensurePipelineCacheInitialized()` from `getPipelineCache()` is essentially a dead code, since `mPipelineCacheInitialized` will always be `true` after call from `createDeviceAndQueue()`. So if blob functions are not set before `createDeviceAndQueue()` then blob cache data will never be loaded. This change simply removes `ensurePipelineCacheInitialized()` from the `createDeviceAndQueue()`, since cache can only be accessed after the initialization (`mPipelineCacheInitialized` is true). Bug: angleproject:8601 Change-Id: I3db1cd69346ec1aa2c36e4134c77680526b22cc8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5756574 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 721becf2 2024-08-06T17:49:56 Vulkan: Update Renderer::syncPipelineCacheVk() method Add check for `mPipelineCacheInitialized` to avoid overwriting existing pipeline cache data in the blob cache by empty cache data if sync is called before pipeline cache is loaded from the blob cache. Move checking of `mCompressEvent` before getting pipeline size and updating `mPipelineCacheSizeAtLastSync`. This will avoid unnecessary (potentially heavy) vulkan call and fix bug when next sync is skipped, because `mPipelineCacheSizeAtLastSync` is already updated. Bug: angleproject:4722 Change-Id: I7390c4bc53ba57732b659d79c65ed4da8d7a6ba6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5756575 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Liza Burakova 3e4fa128 2024-08-05T16:20:30 Store ImageHelper's queue by mip levels. This change converts ImageHelper's mSubresourceQueue to store a vector of updates for each mip level. This allows updates to be flushed per mip level. This also adds a call in the RenderTargetWgpu to flush updates such that now when a framebuffer is flushing updates to color attachments the associated render target ensures that only updates associated with its mip level are flushed. Bug: angleproject:42267012 Change-Id: I1abdbc842cf18b1bd897037bf11aeea9c6d09e14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5759469 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Shahbaz Youssefi 67d8d8c8 2024-07-29T13:44:37 WebGL: Reject shaders with infinite loops Bug: chromium:350528343 Change-Id: I1b2fc152cf285b0e69c4c294351c1cf2389cc234 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5746714 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll d003d9e2 2024-08-05T16:10:45 Manual roll vulkan-deps from 068847956e41 to 3d8509997599 (49 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/068847956e41..3d8509997599 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3c7b12c643437061aec00a813a7f7ae578ba813f..71c24c1e4b4823cab0919bc062202a42ef6569e8 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/9bd6f95db3076517205b01300c8d37043c5b2dd3..a12be94856baf210bb7ae9457dbdf907148caa0a https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/db5a00f8cebe81146cafabf89019674a3c4bf03d..f013f08e4455bcc1f0eed8e3dd5e2009682656d9 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/e7216170d02921ce8acd49aebed0098adc050d23..246daf246bb17336afcf4482680bba434b1e5557 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/fabe9e2672334fdb9a622d42a2e8f94578952082..595c8d4794410a4e64b98dc58d27c0310d7ea2fd https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/be0e1c3683a39a26b4f1a3859226b07a482d030e..faeb5882c7faf3e683ebb1d9d7dbf9bc337b8fa6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/46df205dcad665b652f57ee580d78051925b296a..7d5cdf62e4f2935425faab1270fe1c9a401fa664 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/67522b34edde86dbb97e164280291f387ade55fc..45b881573538f8e481cb6e1d811a9076be6920c1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/1582614bd3ad31463710af6365a56f04d6788ce6..5436842cd0448e3f47d16c637a15fd2a6f93c88e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: Ifb0ca58e920d01034f268b2414141ca34003176e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5765972 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Stephen White 791970d4 2024-07-30T13:06:13 Fix Dawn Android standalone build. The "compressed_symbols" target depends on "libfeature_support", which is only built if (angle_standalone || build_with_chromium). Apply those same constraints to "compressed_symbols". Bug: b/356360483 Change-Id: I32be647b9594f52d1cc378a67276c7d32977653c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5750002 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Geoff Lang c5d4c16f 2024-08-02T11:27:56 WebGPU: Initialize all GLES 2 and 3 caps Instead of using the min caps, intialize them with limits from the WebGPU limits struct or values from the spec. Bug: angleproject:357017322 Change-Id: I15597b192d915dad7c3f6bacab048cf09999da6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5759280 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 91f57b06 2024-08-06T10:01:43 Roll SwiftShader from f72761e86766 to 65157d32945d (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/f72761e86766..65157d32945d 2024-08-05 swiftshader.regress@gmail.com Regres: Update test lists @ f72761e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Idf2d6deb54edebc3a560080d2ec48bc0204f1cae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5765022 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 81eaa2dd 2024-08-06T07:01:17 Roll Chromium from af4b4ec4b6b5 to 53e46965d0e3 (504 revisions) https://chromium.googlesource.com/chromium/src.git/+log/af4b4ec4b6b5..53e46965d0e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a2631a79c9..fb23fbf986 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d2dedd4c7d..26da134756 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/61c2fc5044..6338483f10 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/40cece20d0..4c050c6f1a * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/ec50115f50..6dd205ff60 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a3c7d3e2f3..70fd25ec55 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/8fab97fa5b..6e2e576c0d * third_party/r8: TXt9fw5bGkmX9AINALSX40kRjJ6kaDOdemMcBcZmheYC..C2Os7rJ1YO_5nKTsVezAQfPzCbkyvxdsBvvBgCa_i-cC * third_party/siso/cipd: git_revision:57e2ea7758b03901b7f3d4da57e673dff55690ba..git_revision:01b7fe4b417043daec607839fdaab864c319d928 * third_party/turbine: EICM7eVhYRyG5-glA6v4B4llD23SycxxXp3bjd_pke8C..HLBr7iWMO2VeD_WbrAA1eq33jZZCVxvA3noE3LNzSlQC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/023f8c071b..a5de1b1a82 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/5a2fc6d03a..d7a1bee91c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/074c158400..899455427d No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ie999303326394a18ac97ddc4d77b023b0ce13e81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5764318 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 2ae68a20 2024-08-05T14:24:06 Add MRT test for foveated rendering feature Bug: angleproject:42266906 Change-Id: Ia98b1a2a0195ec213bc510a3b62c85b0adc630eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5763719 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 9b06e003 2024-08-02T15:47:36 Vulkan: Avoid unnecessary observer changes for Buffers Noticed in black_desert_mobile hat it calls glVertexAttribPointer with some buffer. What we end up doing is remove observer from old buffer and add observer to new buffer. This CL checks if old and new buffer are the same and skip some of the logic if both buffers are the same. Also added check in VertexArrayBufferContentsObservers::disableForBuffer to early out if it was not enabled in the first place. Bug: b/356473483 Change-Id: I872dcee7d87b404f525d0323d2952c8249ef1c9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5760652 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi b7b46eed 2024-08-05T10:22:48 Updates to readme Bug: angleproject:42260731 Change-Id: I3abf81066779f276429283da7d9f5a7f39d9858a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5761608 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Le Hoang Quyen a89ca6c8 2024-07-30T17:14:50 Metal: Fully implement unresolve step for MSRTT. This CL also uses memoryless for implicit MS textures in EXT_multisampled_render_to_texture render passes. Bug: angleproject:42261786 Change-Id: Ic20450574c4c670d05ca846587ced05488012270 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5746181 Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Le Hoang Quyen 1bfe5c57 2024-07-30T15:58:47 Metal: partially implement EXT_multisampled_render_to_texture. Implement by implicitly attaching a multisampled texture to the render pass. The content will be preserved across render passes by loading/storing to the implicit multisampled texture. However this won't work if the single sampled texture is used in multiple render passes with different glFramebufferTexture2DMultisampleEXT's sample counts. For that to work we need to implement unresolve step to load the resolve texture's texels into the implicit multisampled texture. That will be implemented in a separate CL. Bug: angleproject:42261786 Change-Id: I12be75af17ce5b98266946846417d0a43fcba455 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5746180 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Shahbaz Youssefi 9410b29e 2024-08-05T10:49:22 Roll chromium_revision df89992288..af4b4ec4b6 (1336472:1337199) Change log: https://chromium.googlesource.com/chromium/src/+log/df89992288..af4b4ec4b6 Full diff: https://chromium.googlesource.com/chromium/src/+/df89992288..af4b4ec4b6 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1233783ad7..a2631a79c9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4eb7a10ce6..d2dedd4c7d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b201b08248..61c2fc5044 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/240e20ff7f..f7c885fa9e * third_party/android_build_tools/lint: uG3kHGeJabRNjw9Eky3VXo5ykOVG8GddMkhJtB377hcC..XCCX7jYHjGwesaVkM8RQKxLrhZeskTdwJL2b8SNUmeAC * third_party/android_build_tools/manifest_merger: nVcR6k4nXavEey7s0fJVOqBkkBgtRQbAOdltDmvVJHUC..nLIbc20DdJTXml9o_W8sGgw9qy-ARNSGPjpSaK-iE1oC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b4abde9e37..e23781ce24 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7815620b1f..40cece20d0 * third_party/kotlin_stdlib: 7D39_IeRRmlY63nkWblJaEJhtjQwqEk5oTqT9hoZxKsC..qtDQdcYfgSh4FeSY3TnkSjnZ5FqCbP1kjk1Zj1m6Jd4C * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/116395a11e..ec50115f50 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/9f0b3768de..8fab97fa5b * third_party/r8: ILFR2kx4djOku2KBB58TOiYl20p0BacrbuKnvdrKlOYC..TXt9fw5bGkmX9AINALSX40kRjJ6kaDOdemMcBcZmheYC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/51579c516e..aa2f8ad74d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/dfd08b107f..074c158400 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/26be847460..292a940817 DEPS diff: https://chromium.googlesource.com/chromium/src/+/df89992288..af4b4ec4b6/DEPS Clang version changed llvmorg-19-init-14561-gecea8371:llvmorg-20-init-1009-g7088a5ed Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/51579c516e100d8e173fc2b80407b41c98afdadc..aa2f8ad74d0f74a5ffecd920f40a8c882dc4e79a/scripts/update.py TBR=syoussefi@chromium.org, BUG=None Change-Id: I6bb4266c82ec9fe4a4682729c139b5e1b106a1d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5761610 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 26aa4df5 2024-06-20T00:00:00 Metal: Update floating-point texture format caps * Fixed detection of Apple7+ GPUs. Added support for Apple8 and Apple9 GPUs. * Adjusted filterability and resolvability caps for R32F, RG32F, and RGBA32F formats. This enables GL_OES_texture_float_linear on capable devices. * Adjusted RGBA32F blendability cap. This enables GL_EXT_float_blend on capable devices. Bug: angleproject:347739670 Change-Id: I84d23814d119452f47fff5a1d7dc33f614c35bb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5646489 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll fdecaa18 2024-08-05T08:01:15 Roll VK-GL-CTS from 3a103d23fc67 to 50e83129b558 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/3a103d23fc67..50e83129b558 2024-08-01 syoussefi@google.com Remove DE_NULL from the repo 2024-08-01 piotr.byszewski@mobica.com Test VIEW_INDEX_FROM_DEVICE_INDEX_BIT with GPL 2024-08-01 syoussefi@google.com Fix incorrect usages of DE_NULL 2024-08-01 syoussefi@google.com Make VK_NULL_HANDLE strongly typed 2024-08-01 boris.zanin@amd.com Support for raytracing pipeline libraries in Amber 2024-08-01 boris.zanin@amd.com Use proper Amber repo 2024-08-01 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (transform_feedback_geometry), PART 9 2024-08-01 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-08-01 rgarcia@igalia.com Allow fetch_sources.py to properly stop with Ctrl+C 2024-08-01 tomnom@google.com Use latest egl.xml and regen files 2024-07-31 lorenzo@khronosgroup.org Merge vk-gl-cts/github-main into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I0963b6b07195e4b742e35a2376dcf14e6aa10ff6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5762516 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 22ed9877 2024-03-07T15:52:13 Vulkan: Generate fragment shading rates with compute Generating fragment shading rates on the CPU could cause avoidable stalls or increased latencies due to host<->device synchronization. Instead generate the rates using a compute shader. Optimize foveated rendering by treating a foveated draw with focal points whose gainX or gainY is 0 as if it were an un-foveated draw Bug: angleproject:42266906 Change-Id: If8c5504087997666c7d0c1cae8dcc5fab847187e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5754322 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Austin Annestrand 5a159d69 2024-05-03T10:24:01 CL/Vulkan: Pass proper arch flag to clspv Needed to update the processedOptions field so that we append the "-arch=" flag based off the device's address bits value. Bug: angleproject:356328474 Change-Id: I5f42f4cdf30ccef9e9aad8eb040f6cbdf8d3b750 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5753767 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Austin Annestrand cc50c75b 2024-04-19T16:40:26 CL/Vulkan: Fix missing kernel enqueue retain/release According to spec: https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html#clReleaseKernel We also need to implicitly retain/release the Kernel object on Kernel enqueue APIs along with other kernel resource retain/release(s) (i.e. memobjs). Bug: angleproject:356328473 Change-Id: Ie6ca228ebece2988d511d9ffd2a617abdc057d0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5753766 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Austin Annestrand d4f93407 2024-03-25T18:14:26 CL: Conditional enable of Vulkan Validation layers Rather than force YesIfAvailable always, we restrict the Vk validation layers if user specifies it in the GN args: angle_enable_vulkan_validation_layers Bug: angleproject:356320155 Change-Id: I9035d0e7d220ce59db39f1a86f31b403c44088dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5753765 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 31c0f439 2024-08-02T09:18:33 WebGPU: Centralize caps generation All GL and EGL caps can be generated at display creation time for WebGPU. Move all existing logic into a centralized GenerateCaps function. Bug: angleproject:357017322 Change-Id: I7398d4ee539192d64971023d9a598ac1f11592ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5759279 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu ea63e372 2024-08-01T21:10:02 Enable VK_KHR_synchronization2 if it is available If the device supports VK_KHR_synchronization2 and VkPhysicalDeviceSynchronization2Features.synchronization2 queried from the device is VK_TRUE, Enabled the extension VK_KHR_synchronization2 and feature VkPhysicalDeviceSynchronization2Features when calling vkCreateDevice. Bug: b/356985874 Bug: b/336844257 Change-Id: Iac95f373a283f5a97e126770321769e0f760e5f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5759319 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll bf72200f 2024-08-02T07:00:12 Roll Chromium from dcddee8baaea to df8999228884 (576 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dcddee8baaea..df8999228884 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ab6c61c825..1233783ad7 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/693d410074..4eb7a10ce6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/321ac47375..b201b08248 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/6a035f479d..4c87034dc5 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/45a95bfa7e..240e20ff7f * third_party/android_build_tools/lint: TUDJ8S7FzEjpuMB-xxa4SEydVqy-b-CuzRrIB5fMao0C..uG3kHGeJabRNjw9Eky3VXo5ykOVG8GddMkhJtB377hcC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5725f1aa1a..1c61efe64f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/be5ff1a6c4..7815620b1f * third_party/fuchsia-sdk/sdk: version:22.20240725.1.1..version:22.20240801.2.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d425bac1e6..116395a11e * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/d96f9effac..9f0b3768de * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/a80fc95e9f..023f8c071b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/34b3762aab..51579c516e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4d7f44c503..dfd08b107f No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ibd5e1937faf39e5203772b2eb076ad19712c0d7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5759320 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 06ae828f 2024-07-31T16:42:54 Vulkan: Avoid breaking render pass for vertex buffer conversion Adreno driver does not support VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT for VK_FORMAT_R8G8B8A8_USCALED. This cases we hit fallback code path using GPU to do conversion. The conversion buffer gets reused since all access are from GPU, but that causes render pass break since there is a WAR hazard on the conversion buffer. This CL adds the isRenderPassStartedAndUsesBuffer check and allocate a new conversion buffer if reuse current buffer may break the render pass. Bug: b/356473483 Change-Id: Iaa0b9235ba42787f0e3629f0d9174ae768456f8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5754324 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Geoff Lang 59f6d962 2024-07-30T21:36:00 WebGPU: Run dEQP GLES2 tests. Add the flags and platform support needed to initialze the WebGPU backend. Set up initial test expectations with broad suppressions. Current pass rate: 14.27% Bug: angleproject:356399840 Change-Id: I1339cd978ca75b59a2e99ee81d93981dc6066f36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5751601 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4902903e 2024-08-01T10:01:23 Roll SwiftShader from 01b188e56477 to f72761e86766 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/01b188e56477..f72761e86766 2024-07-31 swiftshader.regress@gmail.com Regres: Update test lists @ 01b188e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I11a0d4589c216e2a7cfa2e2c33cd9e3a89a422cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5755793 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e7c5a512 2024-08-01T08:01:25 Roll VK-GL-CTS from 7e90a8e54095 to 3a103d23fc67 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7e90a8e54095..3a103d23fc67 2024-07-31 lordalcol@users.noreply.github.com Merge pull request #470 from nico/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I2341917f0c8d9e554362fb0a58348001ec1e7b93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5753778 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2f9b475a 2024-08-01T07:00:35 Roll Chromium from cedeeaab3123 to dcddee8baaea (623 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cedeeaab3123..dcddee8baaea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/86fe4ace36..ab6c61c825 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/77e7e1bd89..693d410074 * buildtools/reclient: re_client_version:0.148.0.41b09b51-gomaip..re_client_version:0.150.2.a829188f-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/801029c793..321ac47375 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0fe4d6156d..5725f1aa1a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e645ef94ae..be5ff1a6c4 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/17ee1e13e5..d425bac1e6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0d40560837..34b3762aab * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/08e54dc139..4d7f44c503 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/402380629f..26be847460 * tools/skia_goldctl/linux: efI2ezkEAorAWAqkeLa8K3YQAHaXCravE81JjG-QE3YC..dPSh2hSFImVtYVOiMVjHTBEre0Asyy65tgiDL8miZbgC * tools/skia_goldctl/mac_amd64: ayOJemg508kv1NC6bJde9jRScJSZktqEMQwAioD_tFMC..qtaQhHygWRQcSDpg6ZVJNUfceR2EZH3rto0pOFEebzkC * tools/skia_goldctl/mac_arm64: 8Gw2_cQqpZYcZec-gR3XgOJwUp2mbwlqXMNI723fmmkC..VRxzxVSfFBWl3AlTnrcO-4gQY5i6AYveLfh2Eop5-UIC * tools/skia_goldctl/win: NkjoXPJcBl8mK-9bhdDAIfDTGezDnomqQXjCCcUyC-YC..DJGQjlpG-s27CzX1oKqNQtH9fBh6kgVemcGds9How_4C No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I70125f2661921e9280bd2c11d7bb1057d6d207c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5755823 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi cc7d0220 2024-07-31T14:22:38 Vulkan: Fix serial mismatch during mid-loop flush Currently, if the total buffer updates to the image surpasses a certain threshold, it results in a flush. However, this can cause discrepencies in the queue serial, which can result in incorrect behavior on some platforms. * Updated flushStagedUpdatesImpl() so that the image serial after applying the updates matches that of the current outside command buffer. * That includes when there is a flush in the middle of the update loop, resulting in submission and new queue serial for the CB. * Added a unit test to check if a large texture can uploaded and deleted after a second small texture is uploaded. * Texture1UploadThenTexture2UploadThenTexture1Delete * Added a unit test for flushing when uploading cubemap textures. Bug: b/351650806 Bug: b/356192937 Change-Id: I7f9b20e4b7fd49115f22081a9733b4d44b740e4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5744377 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 26cdf621 2024-07-31T14:43:12 Vulkan: Bugfix in dynamic rendering support Fix 2 bugs - 1. Set VkGraphicsPipelineCreateInfo::flags when linking GPLs 2. Chain VkRenderingFragmentShadingRateAttachmentInfoKHR struct in VkRenderingInfo::pNext Bug: angleproject:42267038 Change-Id: I456c75d57ec64926a21dffe93b05e1bbab2cb262 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5754635 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 7c77bb75 2024-07-24T12:05:29 Vulkan: Remove implicit buffer barrier for shader write When app uses shaders to write to SSBO, right now we are inserting an implicit barrier to ensure WAW are in order. But Spec says that "Explicit synchronization is required to ensure that the effects of buffer and texture data stores performed by shaders will be visible to subsequent operations using the same objects". This CL removes the implicit barrier for buffer write if the current write comes from shaders and relies on explicit glMemoryBarrier to insert a global barrier. Bug: angleproject:350994515 Change-Id: I8ab039610be9be2ded27ea60dab54bdad08502f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5719258 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov e932ca24 2024-07-31T15:02:21 Start ANGLE macOS 14.6 experiment on Intel Bug: chromium:355249262 Change-Id: I024ff7adec1b244f594b283eae87c6613b1c01ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5752465 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 279c69e5 2024-07-30T21:30:54 WebGPU: Fix intended/actual format mismatch for textures Update WebGPU texture allocation size to use the actual format instead of intended. Early-out with an UNIMPLEMENTED if the format is not supported yet. Bug: angleproject:356399840 Bug: angleproject:344814096 Change-Id: Idef9ad40c6b1d490964fc398fb077b117612a44b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5748448 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang cab7d1b6 2024-07-30T21:19:15 WebGPU: Obey buffer alignment rules WebGPU buffers require a size aligned to 4 bytes and map buffer offsets aligned to 8 bytes. Hide this requirement in The BufferHelper class by doing the apropriate offsets during buffer creation and map calls. This allows many dEQP tests to run without crashing due to WebGPU buffer creation errors. Bug: angleproject:356399840 Bug: angleproject:42267091 Change-Id: Id71c3b5db31aa712d5a88631efa4897d6205a41d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5748443 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 641bc04a 2024-07-30T21:25:44 WebGPU: Use the correct source format for ReadPixels ReadPixels was using the format of the destination buffer which works correctly for RGBA8 -> RGBA/UNSIGNED_BYTE but runs the wrong conversion functions for other formats. Bug: angleproject:356399840 Bug: angleproject:42267090 Change-Id: I7c46add3f643017f454136135afef697847a2383 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5748446 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 9da7fb15 2024-07-30T21:21:45 WebGPU: Don't log all renderpass closure reasons This logging line spams the console excessively. For now, just make sure there is a message associated with each renderpass closure reason. Bug: angleproject:356399840 Change-Id: I2313d439837ffb11f11cd56194511e80fb312eba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5748444 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 1953c606 2024-07-30T21:28:13 WebGPU: Fix ReadPixels from window surfaces. The intended/actual formats were not initialized in this code path and the created swap chain texture did not have the usage flags needed for copying to a buffer for ReadPixels. Bug: angleproject:356399840 Bug: angleproject:42267090 Change-Id: I8e4279eedb2b23f0d2ed690ccee086ae115969c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5748447 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 0898dab0 2024-07-30T21:34:00 WebGPU: Skip primitive topology conversion for DrawArrays For non-indexed draw calls, no index format is needed for the stripIndexFormat. Bug: angleproject:356399840 Change-Id: Ie2c9805a2c257d94ea5f1bca026287873e4d6781 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5748449 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 8446bbd6 2024-07-30T21:22:50 WebGPU: Remove ASSERT in depth/stencil clears Instead of asserting that we are not clearing depth or stencil, just log an UNIMPLEMENTED and skip the call. This allows many dEQP tests to run without crashing on the ASSERT. Bug: angleproject:356399840 Change-Id: Icfe7a77d7128e679501da42023601217c7b0e6c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5748445 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang d503f580 2024-07-30T21:15:44 WebGPU: Remove UNREACHABLEs in the compiler Update several usages of UNREACHABLE that are hit by dEQP. Change them to UNIMPLEMENTED so that ANGLE does not crash. Bug: angleproject:356399840 Change-Id: I8b4415c9481384761dbe4527acaf986946321c54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5748442 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen aee59926 2024-06-28T17:00:56 Metal: Enable GL_ANGLE_reverse_row_order for Metal The feature is already implemented due to generic pack parameters handling and FramebufferMtl::setFlipY(). Bug: angleproject:349980052 Change-Id: I08cc81dcb26ae81e8d81b060d986e01479487dbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5667597 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll f336dbbb 2024-07-31T08:01:06 Roll VK-GL-CTS from 3d152263d502 to 7e90a8e54095 (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/3d152263d502..7e90a8e54095 2024-07-29 elima@igalia.com Rename video decode tests to extract codec name as new group 2024-07-29 gleese@broadcom.com Add more tests for fmin/fmax with +/-0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I43a51820bad7991f0f9b190f70e8715a8d0976c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5750491 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3e83d188 2024-07-31T07:01:22 Roll Chromium from 230f7abd1f6d to cedeeaab3123 (601 revisions) https://chromium.googlesource.com/chromium/src.git/+log/230f7abd1f6d..cedeeaab3123 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e8d555481d..86fe4ace36 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c92671fe07..77e7e1bd89 * buildtools/linux64: git_revision:b2afae122eeb6ce09c52d63f67dc53fc517dbdc8..git_revision:1b41f0502f87b2056cee5cc9b48f9242693d497b * buildtools/mac: git_revision:b2afae122eeb6ce09c52d63f67dc53fc517dbdc8..git_revision:1b41f0502f87b2056cee5cc9b48f9242693d497b * buildtools/win: git_revision:b2afae122eeb6ce09c52d63f67dc53fc517dbdc8..git_revision:1b41f0502f87b2056cee5cc9b48f9242693d497b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1a51c35324..801029c793 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b6b914a59f..0fe4d6156d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/68c038603f..e645ef94ae * third_party/kotlin_stdlib: 8qx9sot30FtFtPSKIpcEu3KhfqtQHpExnueNhpwxd48C..7D39_IeRRmlY63nkWblJaEJhtjQwqEk5oTqT9hoZxKsC * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d93c143a49..17ee1e13e5 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/d09db732ff..d96f9effac * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c2469fdd73..71660e196b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/5279c44459..a80fc95e9f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7a4c4fcc6f..0d40560837 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c1f1dfbb74..18f2887c9b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/416332d6ef..08e54dc139 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I4e462430e198c081e924ed5c44a66c74d9b35a41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5750490 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 65f08d08 2024-07-26T22:14:49 Vulkan: Work around driver bug with nested switch Bug: chromium:350528343 Change-Id: Ie7bd58934ccb2b8f06f6ad6a8c3bf38e81b84969 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5744620 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 346ba328 2024-07-30T11:42:12 Vulkan: Simplify pulling samplers out of structs The RewriteStructSampler transformation moves samplers out of structs, for example turning this struct: struct Original { sampler2D s1; vec4 f1; sampler2D s2; sampler2D s3; vec4 f2; }; into: struct Modified { vec4 f1; vec4 f2; }; This required modifying the struct-field selection nodes to remap the field indices, causing some complication. Instead, this change makes the struct definition reorder the fields as such right during parse: struct Original { vec4 f1; vec4 f2; sampler2D s1; sampler2D s2; sampler2D s3; }; As a result, the field-selection indices for non-sampler fields don't get changed when the struct is replaced with `Modified`. Bug: angleproject:42262842 Bug: angleproject:349994211 Change-Id: I76986eab780689e9887b094e3c70b87887a8ec92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5748789 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 451d78d9 2024-07-25T11:56:25 Prune trivial infinite loops in WebGL contexts Bug: chromium:350528343 Change-Id: I4be19c1ffe41fc86889b49b4a0e29d8bc9c940ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5738743 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Marcin Radomski 4c883359 2024-07-03T13:50:58 Add dma_buf build support to generate_android_bp Minimized version of go/anglecl/5729843 that limits introduced changes. Make generate_android_bp.py emit a `angle_android_dma_buf` Soong config variable that, when enabled, creates a "Linux-like" build using Android toolchain. The build does not assume the presence of regular Android graphics stack. eglGetDisplay defaults to creating DisplayVkOffscreen. This enables EGL rendering context setup based on an externally allocated DMA-BUF, using EGL_EXT_image_dma_buf_import and GL_OES_EGL_image_external extensions. See ag/28533701 to view the generated code. Also, revert changes from "Add build flag for a "dma_buf" Android build" (commit 4d2b365582669a04224d1e1fa3c92447c359a4ba). The flag added there was submitted a bit prematurely, and as go/anglecl/5729843 was deemed too complex a different approach was necessary. Test: CQ Test: Build the entire CL chain with the new Soong config flag enabled Test: run the system, attach debugger to eglGetDisplay(), see Test: DisplayVkOffscreen getting instantiated Bug: b/353262025 Change-Id: I974d91cff79a0bd8b5059a145f0ae6114b2bcbe5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5746214 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Marcin Radomski <dextero@google.com>
Roman Lavrov 3cda3527 2024-07-30T14:28:17 Capture/Replay: fix CaptureProducedRequiredFiles bottleneck Turns out repeatedly listing/checking files was a huge bottleneck, especially on Windows. Example from win-trace GLES 3.0. Before this change almost 10 minutes!: I09:59:03.198422Z Running 2255 capture tests, worker_count=8 batch_count=1 I10:00:36.627151Z RunCaptureInParallel finished I10:10:20.380077Z CaptureProducedRequiredFiles finished I10:10:20.396174Z Building replay tests After: I11:02:57.679244Z Running 2255 capture tests, worker_count=8 batch_count=1 I11:04:33.078232Z RunCaptureInParallel finished I11:04:35.331878Z CaptureProducedRequiredFiles finished I11:04:35.344066Z Building replay tests win-trace timing expected to improve from ~30 minutes to ~15 minutes. Bug: angleproject:42264614 Change-Id: Ie1903d89d54ab5c6464d3ddb993ec3007e7604ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5749745 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov e413ecaf 2024-07-15T17:44:31 Increase parallelism Win Intel UHD 770 Crashes weren't reproduced with 2 processes, and this improves performance a bit. Bug: angleproject:352528974 Change-Id: I934e4aacdf38a790cad858e79cae683e2a5ed1d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5709048 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Le Hoang Quyen 198de044 2024-07-30T15:44:03 Metal: fix wrong render encoder's serial assignment mtl::RenderCommandEncoder object is created once and reused multiple times. We should re-assign a new serial whenever we reuse it, instead of assigning once in constructor. bug: angleproject:40644888 Change-Id: I18120c91dddd5b279fcec7a9099833e97ec1c37c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5746179 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Le Hoang Quyen 2bc1519c 2024-07-28T05:16:07 Metal: fix base/max level change for mutable textures. Previously, the following scenario would accidentally delete and recreate the native texture storage for a non-immutable TextureMtl: 1. set a texture base/max level. 2. attach the texture to a FBO and clear it. - native storage is created. 3. sample the texture. - native storage is accidentally deleted and recreated. This happened because front-end only notifies the backend about the base/max level dirty bits at step 3. At this point, Metal backend thought that the native storage created at step 2 is no longer valid and attempted to recreate the storage. This CL fixes the bug by checking whether the base/max level is still compatible with the existing native texture storage. If it is then the dirty bits result in no-op. Bug: chromium:355605685 Change-Id: I1daac80a74219109631a101e18e944560606d926 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5741121 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov aaf39d92 2024-07-23T17:56:56 FrameCapture: fix (nil) showing up in linux-trace capture Without this we get the generic fallback ostream << value which apparently works differently across platforms and produces (nil) on Linux but something compile-able on Windows. Bug: angleproject:42264614 Change-Id: I2bce988b661cf65ba0651d78081aaf3240d87d52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5736060 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 7e700344 2024-07-30T10:01:11 Roll SwiftShader from c4dfa69de7de to 01b188e56477 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/c4dfa69de7de..01b188e56477 2024-07-29 swiftshader.regress@gmail.com Regres: Update test lists @ c4dfa69d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ia13d8adb40113367a9075ff00f15e0304576bfca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5748213 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 15b354d5 2024-07-28T21:30:11 Unsuppress ASAN/UBSAN suppressions for fixed tests Bug: angleproject:42265173 Bug: angleproject:42265224 Change-Id: Id695c0893bb7676cb1f129f45932a1c95708e3e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5742430 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 3b5e09ae 2024-07-30T07:18:46 Roll Chromium from 232a6a5422d1 to 230f7abd1f6d (544 revisions) https://chromium.googlesource.com/chromium/src.git/+log/232a6a5422d1..230f7abd1f6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f7f49764b6..e8d555481d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/79699a90c5..1a51c35324 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/af69d904a5..6a035f479d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/484e908fab..b6b914a59f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fca881606e..68c038603f * third_party/r8: mNdD4Yszt_OyPhVNv6ytq3sdKI5svvOE_z5pE1hh76sC..ILFR2kx4djOku2KBB58TOiYl20p0BacrbuKnvdrKlOYC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f2b4517948..5279c44459 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/14ecad3593..7a4c4fcc6f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3e8ff3295b..c1f1dfbb74 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/87928d7073..5a2fc6d03a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7f06da2330..416332d6ef No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I55c228377ece0d6281a601dfd9f352290056eb61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5747816 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 0ef06687 2024-07-29T14:26:15 Stage the angle_commit.h for commit during ANGLE Android Roll Add the missing "git add angle_commit.h" command in roll_aosp.sh so that this file is staged for commit during ANGLE to Android roll. Otherwise it will be missed from the rolled CL e.g. https://android-review.git.corp.google.com/c/platform/external/angle/+/3198314, causing the compiler to fail to find the angle_commit.h Place the code that generates the angle_commit.h into a separate function generate_angle_commit_file() for clear code reading purpose. Bug: b/348044346 Change-Id: I06fc0f91c396218c1d4ab6b8f6aef883380ad7b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5747414 Reviewed-by: Roman Lavrov <romanl@google.com>
Roman Lavrov da864294 2024-07-18T18:44:55 Capture/Replay: rework capture_replay_tests, enable linux-trace Changing the way capture_replay_tests orders its stages. Previously, build, capture and replay would all run concurrently in multiple processes sometimes causing difficult to understand interaction between those stages. This CL changes it so that the test follows stages sequentially: * Build end2end tests * Run all capture tests (in parallel) * Check captured files and produce a single build for replay * Build replay binary and all tests * Run all replay tests (in parallel, but _one by one_) Note that running replay tests one by one avoids the confusing batch failures altogether. Now when a replay test is broken, the logs will specifically identify which one caused the issue. This also noticeably improves CI time as ninja builds of bigger batches are more efficient and possibly less linking is happening. Additionally, xvfb is supported directly in the script without relying on testing/xvfb.py, in a way that reuses xvfb displays instead of starting/stopping xvfb for each test and avoids races that are possible when running testing/xvfb.py concurrently (such as picking which display to use). This appears to significantly improve stability on linux-trace which have had to be disabled due to the flakiness. Bug: angleproject:42264614 Change-Id: I38a5547250cf5f63b8b9e4879f02cd715d8df0a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5721996 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao bd3a3308 2024-07-22T14:03:20 Vulkan: Remove implicit image barrier for shader write When app uses compute or fragment shader to write to an image and makes multiple dispatchCompute or draw calls, right now we are inserting an implicit barrier to ensure WAW is hazard free. But Spec says that "Explicit synchronization is required to ensure that the effects of buffer and texture data stores performed by shaders will be visible to subsequent operations using the same objects". This CL records the bits from the last glMemoryBarrier call and will skip the barrier calls in ContextVk::updateActiveImages if there is no layout change, unless there is requirement from prior glMemoryBarrier. Bug: angleproject:350994515 Change-Id: I8bdeeb658993824369824aaa0f25cb4b6e3785f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5719024 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu c9744617 2024-07-25T14:07:38 Fix Unknown Android Git Hash in Android Builds The ANGLE git hash is generated by running the script src/commit_id.py during compile time. However, in Android repo, access to .git is not guaranteed. This results the "unknown hash" value being generated by src/commit_id.py when compiling ANGLE in Android repo. To fix it, instead of invoking the src/commit_id.py during compile time, invoke the script during ANGLE to Android roll time. This change: 1) Removes the code in generate_android_bp.py that exports the build target angle_commit_id into Android.bp, so that the script src/commit_id.py is not invoked when compiling ANGLE in Android. 2) Invokes src/commit_id.py in aosp_roll.sh, to generate the angle_commit.h when we roll ANGLE changes into Android. Sample results with this change in Android is https://googleplex-android-review.git.corp.google.com/c/platform/external/angle/+/28476591 Bug: b/348044346 Change-Id: I91862ba6ab20ffb2cf9e99ee9b4fa6b83727c634 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5741631 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 554cc484 2024-07-29T10:03:50 Tests: end2end tests process test args before TestSuite() This fixes --use-config=<config> which allows to select a configuration before tests are registered and avoid looping through all configs. Bug: angleproject:42264614 Change-Id: Ia19d52a09debdd738577b8a12da82878302f3888 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5746710 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 568caaa0 2024-07-23T15:07:59 Prune switch(constant) with no matching case Bug: chromium:350528343 Change-Id: Iabb475b230f22086de482bbdcf2fa00b0d986622 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5735815 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Solti b8cc14d7 2024-07-26T21:13:10 skip lib starting with "//" when generating Android bp The issue is http://b/354737043#comment10. Based on the discussion, we would like to skip lib starting with "//", such as "//third_party/llvm-build/Release+Asserts/lib/clang/19/lib/linux/libclang_rt.builtins-xxx" in this case. We can revisit this implementation when we actually need something that starts with "//" Bug: b/354737043 Test: Compare the Android.bp before and after the change. Change-Id: I21f799f1a4946a0662e1190a2e962bc37dc714ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5742651 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll aa8e1e50 2024-07-29T10:07:29 Roll VK-GL-CTS from c66570e674d0 to 3d152263d502 (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c66570e674d0..3d152263d502 2024-07-26 boris.zanin@amd.com Initial implementation Ray Tracing support in Amber 2024-07-26 elima@igalia.com Rename video encode tests to extract codec name as new group 2024-07-26 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-07-25 piotr.byszewski@mobica.com Test local read without mapping 2024-07-25 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.5 into vk-gl-cts/main 2024-07-25 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.11 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Idd88f87327cdc49bc1f366dcded9ee2ea5552bce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5745264 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 506cb7c1 2024-07-29T09:03:38 Roll Chromium from 2e8f18571b3e to 232a6a5422d1 (733 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2e8f18571b3e..232a6a5422d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4be3bd6e98..f7f49764b6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/077b3a8e24..c92671fe07 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5f5094f03b..79699a90c5 * third_party/android_build_tools/lint: 6HiuLpbOXMHuhrrqdM98SceuO7Irim5oDe6SDOuSHSYC..TUDJ8S7FzEjpuMB-xxa4SEydVqy-b-CuzRrIB5fMao0C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2f1b13ed91..484e908fab * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8dde9800ee..fca881606e * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e33039b578..d93c143a49 * third_party/siso/cipd: git_revision:59d7ce479a969e583ba82fbd4e270aa7b1d87750..git_revision:57e2ea7758b03901b7f3d4da57e673dff55690ba * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f6b4d995d2..14ecad3593 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0b618cb994..7f06da2330 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: If8f6c14af24017fdf949940d899f37ccfa54c549 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5746310 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 57202584 2024-07-26T13:07:44 Vulkan: Fix dispatch-after-closed-render-pass bug Bug: b/355567160 Change-Id: I4bc6acec53a50330507bfadcc0a4c1093366aae6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5741786 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov f47a882a 2024-07-26T14:47:48 Cleanup: remove vulkan_clean_old_validation_layer_objects Target removed upstream: https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/8242/commits/12048d7d846e9020a11feb8650587f6898414d50 Bug: angleproject:350816748 Change-Id: I0ea5c4c54960e49c9b6d37f1932c2121bdfc6529 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5741787 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Marcin Radomski b20cd34d 2024-07-18T10:03:17 Add build flag for a "dma_buf" Android build Add angle_android_dma_buf gn flag, defaulting to false. When enabled: - Enables a "linux-like" build of ANGLE while using the Android toolchain, by making the OS detection logic define PLATFORM_OS_POSIX but not PLATFORM_OS_ANDROID. - Makes ANGLE default to using Vulkan backend, and - Enables DMA-BUF based external image support. This allows setting up GL framebuffers backed by DMA-BUFs, enabling rendering without full Android graphics stack. See the bug for details. Bug: b/353262025 Test: treehugger Test: Build the entire CL chain with the new Soong config flag enabled Test: run the system, attach debugger to eglGetDisplay(), see Test: DisplayVkOffscreen getting instantiated Change-Id: I584f9491b188f730f4ee9630173cc486ae7e8908 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5729841 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Geoff Lang a0a832de 2024-07-26T12:33:37 Revert "GL: Forward client-side arrays to the driver when possible" This reverts commit a6c2b4346516f228054b5bdd754bbc6f3ba1cba7. Reason for revert: Fails some Chrome tests on Android after rolling: https://chromium-review.googlesource.com/c/chromium/src/+/5742024 Original change's description: > GL: Forward client-side arrays to the driver when possible > > The OpenGL dirver can handle client-side arrays when the context is > OpenGL ES or a desktop GL compatability profile. When in these > sitatuions, use the driver default VAO for all frontend context VAOs > and forward client-side data directly to the driver. > > Bug: angleproject:355034868 > Change-Id: I21a4459c4f7db780b51441d76e63d17bf737c101 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5736058 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: angleproject:355034868 Change-Id: I76f95d66ca277bcbb67300179e49287b433c1ede No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5742647 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Geoff Lang <geofflang@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 31b2bcd6 2024-07-26T10:01:06 Roll vulkan-deps from 49b5e420b19a to 068847956e41 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/49b5e420b19a..068847956e41 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b88a3ee090ba95db5b7d6f12e926bdc24b265733..1582614bd3ad31463710af6365a56f04d6788ce6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I3a2fd7b9b5c8589cbaf5c59bc8420f198eac3e6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5743279 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2c1d78ef 2024-07-26T07:00:43 Roll Chromium from 15e30105c06e to 2e8f18571b3e (242 revisions) https://chromium.googlesource.com/chromium/src.git/+log/15e30105c06e..2e8f18571b3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7bef53a4a9..4be3bd6e98 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4d40c0826d..077b3a8e24 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e064e66a80..5f5094f03b * third_party/android_build_tools/manifest_merger: PWl6vXHNVVT3uJRejbQuGcgQ8wekHWcExK0-Xw7aS7MC..nVcR6k4nXavEey7s0fJVOqBkkBgtRQbAOdltDmvVJHUC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/64908716d7..8dde9800ee * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/1ac8f1a391..e33039b578 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/29492af8e5..0b618cb994 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I246c2de9973890c93373780c74cb7660c7a7759e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5742851 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski d306e048 2024-07-24T15:03:04 Tests: Add Shovel Knight Pocket Dungeon trace Tests: angle_trace_tests --gtest_filter=*shovel_knight_pocket_dungeon bug: b/355399059 Change-Id: I5b2193db9814d0867ab95efab7588540fca6198d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5742394 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll ca6238fb 2024-07-25T19:45:45 Manual roll Chromium from 99513aa4b41c to 15e30105c06e (813 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/chromium/src.git/+log/99513aa4b41c..15e30105c06e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/35253acb11..7bef53a4a9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c048d3159f..4d40c0826d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/417cb6c72d..e064e66a80 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/c04acbd460..af69d904a5 * third_party/android_toolchain/ndk: h9HeidXTeHQ-oskldbqCZx26-7VrVvXpLfqOI87uy4QC..Idl-vYnWGnM8K3XJhM3h6zjYVDXlnljVz3FE00V9IM8C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/98802e1e92..2f1b13ed91 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8552a27900..64908716d7 * third_party/fuchsia-sdk/sdk: version:22.20240717.4.1..version:22.20240725.1.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/437475caee..1ac8f1a391 * third_party/r8: UaENs6hma4QjyXPcbPwgnF5trTtS8KqZvOSKc3WvBEwC..mNdD4Yszt_OyPhVNv6ytq3sdKI5svvOE_z5pE1hh76sC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/fc8f1176dd..29492af8e5 * tools/skia_goldctl/linux: Tmr9c1O-W7mu7zgVbAgDIpLiDFfiWA2nnWa7FYu0pjgC..efI2ezkEAorAWAqkeLa8K3YQAHaXCravE81JjG-QE3YC * tools/skia_goldctl/mac_amd64: _7hIgAZisiST_h_sDMLpXETbV5CzGfmG4Oxm38v4rlEC..ayOJemg508kv1NC6bJde9jRScJSZktqEMQwAioD_tFMC * tools/skia_goldctl/mac_arm64: JFa9d9Q6qO_diHbU_E8cW9EMTEBkDXLlZz8-USH6YLAC..8Gw2_cQqpZYcZec-gR3XgOJwUp2mbwlqXMNI723fmmkC * tools/skia_goldctl/win: VoFA8h7UVLHiMG1OJitx6oYOOdQYwTVztBFAMdPaqywC..NkjoXPJcBl8mK-9bhdDAIfDTGezDnomqQXjCCcUyC-YC No update to Clang. Bug: angleproject:355034868 Tbr: solti@google.com Change-Id: I1d9b160c6b7a9c882cb225d06c8d5c87d827f739 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5741627 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang a6c2b434 2024-07-23T16:36:10 GL: Forward client-side arrays to the driver when possible The OpenGL dirver can handle client-side arrays when the context is OpenGL ES or a desktop GL compatability profile. When in these sitatuions, use the driver default VAO for all frontend context VAOs and forward client-side data directly to the driver. Bug: angleproject:355034868 Change-Id: I21a4459c4f7db780b51441d76e63d17bf737c101 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5736058 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll f440d17c 2024-07-25T16:50:12 Manual roll Chromium from 834617e372fd to 99513aa4b41c (90 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/chromium/src.git/+log/834617e372fd..99513aa4b41c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9a62bcfa01..35253acb11 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9bcf8df756..417cb6c72d * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/4ecf6edf92..f2b4517948 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2f3ab4339e..f6b4d995d2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/117d61e33f..fc8f1176dd No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ib92d9b381207ddd1cc8fabc658c012e254affe5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5739485 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 48d19755 2024-07-25T16:07:21 Manual roll VK-GL-CTS from 5a542d2049d7 to c66570e674d0 (8 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/5a542d2049d7..c66570e674d0 2024-07-19 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-07-19 piotr.byszewski@mobica.com Two additional tests for local read 2024-07-19 syoussefi@google.com Use VK_NULL_HANDLE where appropriate - Part 3 2024-07-19 syoussefi@google.com Use VK_NULL_HANDLE where appropriate - Part 2 2024-07-19 syoussefi@google.com Use VK_NULL_HANDLE where appropriate - Part 1 2024-07-19 syoussefi@google.com Use VK_NULL_HANDLE instead of (VkSomething)0 2024-07-19 ziga@lunarg.com Test binding VK_NULL_HANDLE to unsupported mesh shader stages 2024-07-19 nathaniel@lunarg.com Add void extent ASTC tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ie3d3c03bdbdbde52e1f094927726bc4b512e8865 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5741619 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov f184de3f 2024-07-25T12:42:03 Don't roll third_party/rust-toolchain into AOSP Bug: angleproject:349994211 Change-Id: I57855c7c950627a2597d56816c3d16b7859d4114 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5741434 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 81086a18 2024-07-23T15:51:35 Manual roll VK-GL-CTS from 5b2dfe7c775a to 5a542d2049d7 (1 revision) Manual roll requested by solti@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/5b2dfe7c775a..5a542d2049d7 2024-07-19 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (CoverageGL21), PART 8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Manual edits - Patchset 2: fetched the original roller generated CL - Patchset 3: added missing parts, and run "python3 scripts/run_code_generation.py" - Patchset 4: suppress the failures: KHR-GLES3.api.coverage and KHR-GL46.api.coverage. see https://anglebug.com/355292302 Bug: b/354737043 Bug: angleproject:355292302 Tbr: solti@google.com Change-Id: Ie38a65c6db0b3330e970971bd1325e3c419b6248 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5739577 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Solti Ho <solti@google.com>
angle-autoroll 5013e199 2024-07-25T10:01:43 Roll vulkan-deps from 8e90204125ac to 49b5e420b19a (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8e90204125ac..49b5e420b19a Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bedbe7481e1e08f4b374d77a34642e995276664d..3c7b12c643437061aec00a813a7f7ae578ba813f https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/a0817526b8e391732632e6a887134be256a20a18..e7216170d02921ce8acd49aebed0098adc050d23 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/27a8c7a33ab376acbcba52e0ceb8224a388ca9a7..b88a3ee090ba95db5b7d6f12e926bdc24b265733 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ibe8a7e04fbc24cc79f2219dc91eb68eb3d85fa21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5739483 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Liza Burakova 4f498eaa 2024-07-24T14:31:23 WebGPU: Add more format support This CL adds a new FormatTable class that initializes webgpu texture and vertex formats. It also adds this class to the display so it can be used in the ImageHelper. This CL changes the previously hardcoded RGBA8 texture format that was initially used when creating textures to use the format passed into the methods. Bug: angleproject:344814096 Change-Id: I768b85335329116496dbf721aac54d1137aaae9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5660397 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Geoff Lang 84e54d88 2024-07-22T14:39:22 WebGPU: Add command buffers and renderpass management Add a CommandBuffer class to serialize and replay WebGPU commands. Only Draw and SetPipeline are implemented in this patch. Manage render pass begin and end events due to framebuffer changes and swapping. Handle the color mask dirty bits so that a non-zero color mask will be used. All togther, this is enough to draw a triangle using a hard-coded shader without inputs. Bug: angleproject:0 Change-Id: I0fbf0296563c02c7f0774ad4197b83f4c93c22bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5731594 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Igor Nazarov 703c5960 2024-07-24T17:02:28 Vulkan: PPO must warmup pipeline cache according to GPL support This commit caused regression: https://chromium-review.googlesource.com/c/angle/angle/+/5366173 `ProgramPipelineVk::link()` uses Complete subset for warmup regardless of the GPL support. However, `ContextVk::createGraphicsPipeline()` will respect the GPL support. Before the above change, PPO was respecting GPL for warmup. This change removed `subset` parameter from the `getPipelineCacheWarmUpTasks()` not only to avoid copy-paste logic, but also to ensure consistency with `waitForGraphicsPostLinkTasks()`. Bug: angleproject:8601 Change-Id: Iab5df1b55921649a8f98a34bb07d8e6a145bfd4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5738153 Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll d10d1c4f 2024-07-24T13:31:28 Manual roll Chromium from 04132ee8f8a5 to 834617e372fd (557 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/04132ee8f8a5..834617e372fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1ad7eaaa40..9a62bcfa01 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/549cb68c48..c048d3159f * buildtools/reclient: re_client_version:0.150.1.d9707319-gomaip..re_client_version:0.148.0.41b09b51-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5fb4ee714b..9bcf8df756 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9d1552f25c..c04acbd460 * third_party/android_build_tools/bundletool: X5yajoh75x5lwpY1-eO4tey50eTX4XkB5JE1WXVal_MC..sZ24OFOduSafn8fvR3ajsGS6KP_oS_Tq0Cw3SA8XiD0C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1b098fc30b..b4abde9e37 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/523ebded2f..98802e1e92 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1a616deaac..8552a27900 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/1a4465110c..437475caee * third_party/r8: 8UxK0Gx2bU0BT44gG8VlK1y8ISbMzcxs2r9ZaxiEPL4C..UaENs6hma4QjyXPcbPwgnF5trTtS8KqZvOSKc3WvBEwC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b72b347df0..4ecf6edf92 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2f9ac3eb19..2f3ab4339e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ba3ddefc83..117d61e33f No update to Clang. Bug: None Tbr: solti@google.com,ynovikov@google.com Change-Id: I91c60df5f95d53fc1ea055886b678379332c3249 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5734666 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 6afff893 2024-07-24T10:05:37 Roll Rust tools with Chromium Bug: angleproject:349994211 Change-Id: I9360b869e59365ff41d35359ce5af47c878fa89f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5736063 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 5a44aa26 2024-07-24T10:01:28 Roll vulkan-deps from 5d0bdd3702f7 to 8e90204125ac (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5d0bdd3702f7..8e90204125ac Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/592aed9c206c283cac98f7a86e5cc237dadb2638..bedbe7481e1e08f4b374d77a34642e995276664d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/c5c24ad66bf1c7b430a86593f10c62d0acf008b4..be0e1c3683a39a26b4f1a3859226b07a482d030e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/84d70cb19863a7dc39d3f5437efeef52179e5791..27a8c7a33ab376acbcba52e0ceb8224a388ca9a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I639e1c72b09e6c619220773bfdf14931c31406ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5734987 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev fc381db4 2024-07-23T00:00:00 Metal: Treat link jobs as thread-safe Fixed: angleproject:351165323 Change-Id: I2ad7b8bd4b89be7d98876287c641b86a33e1108e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5735475 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Mark Lobodzinski b98c4d81 2024-07-23T09:09:37 FrameCapture: Add restore of VAO buffer binding If the VAO was changed before the trace started, but no buffers were bound during replay, the VAO buffer binding was not properly reset. Test: angle_trace_tests --gtest_filter=*shovel_knight_pocket_dungeon Bug: b/354888763 Change-Id: I76f94e5d219b88c641528049034d92ee55161f56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5734653 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 6eda2557 2024-07-22T00:00:00 Metal: Pass an existing context to CompileMslTask Bug: angleproject:351165323 Change-Id: Icd4a2c8f9e158dc1989d720dc8235ba09dc0d82a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5736272 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Marcin Radomski 85264808 2024-07-18T09:53:14 tls.h: check ANGLE_USE_ANDROID_TLS_SLOT to define GL TLS The definitions of ANGLE_ANDROID_GET_GL_TLS() macro were guarded by ANGLE_PLATFORM_ANDROID, but the use by ANGLE_USE_ANDROID_TLS_SLOT. This change makes it so both definition and the use use the same macro. Additionally, make libGLESv2/global_state.h include common/tls.h when ANGLE_USE_ANDROID_TLS_SLOT is defined, even if ANGLE_PLATFORM_ANDROID is missing. This will enable the use of Android TLS in builds that use bionic on systems that are not full Android (see bug for details). The change is supposed to have no impact on existing code. Bug: b/353262025 Test: treehugger Change-Id: I4406aa4642c4a589a53dd8e0ff6c41234942901b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5729840 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll 1b0e74f3 2024-07-23T14:23:33 Manual roll Chromium from 9739f7f11240 to 04132ee8f8a5 (755 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/9739f7f11240..04132ee8f8a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7a8285c06a..1ad7eaaa40 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3ef44a2b92..549cb68c48 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/926b0906b1..5fb4ee714b * third_party/android_build_tools/lint: v79ZCCwmnRiw_53_BXjDk0gwzTw5er4Epjx31ZnF6x0C..6HiuLpbOXMHuhrrqdM98SceuO7Irim5oDe6SDOuSHSYC * third_party/android_build_tools/manifest_merger: GGTpgNcW7W4dG6PH1FlPe3ej4jP6pPRyfFs_0rHBfqkC..PWl6vXHNVVT3uJRejbQuGcgQ8wekHWcExK0-Xw7aS7MC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/48452b983b..1b098fc30b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1699936526..523ebded2f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/28a7eef132..1a616deaac * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6bb75caa13..1a4465110c * third_party/r8: FkhioB3uZmGFZXh9T_oVHXWyTi8UHB_7BDlrkn8IPpIC..8UxK0Gx2bU0BT44gG8VlK1y8ISbMzcxs2r9ZaxiEPL4C * third_party/siso/cipd: git_revision:50a6db5dae3978d2d2e8dce29f6df024dde48d1b..git_revision:59d7ce479a969e583ba82fbd4e270aa7b1d87750 * third_party/turbine: trOc8ouN-n-XhBQXk58CGsBa_7JlsOD6mv__HNEiiVEC..EICM7eVhYRyG5-glA6v4B4llD23SycxxXp3bjd_pke8C * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f808d81be6..b72b347df0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4dc76da47b..2f9ac3eb19 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/edbc860e1b..3e8ff3295b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/fd08f81f15..ba3ddefc83 No update to Clang. Bug: None Tbr: solti@google.com,ynovikov@google.com Change-Id: If8d6cb54bc9145784997481b67d68236d6b147c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5734652 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya 7b0dc666 2024-07-19T15:39:42 Vulkan: Enable explicitlyEnablePerSampleShading for most vendors Bug: b/267953710 Bug: angleproject:40096890 Tests: SampleMultisampleInterpolationTest.SampleMaskInPerSample* Change-Id: I51cc393934e7fd24146ab5c94893bb3014c5c044 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5726628 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 2f05b993 2024-07-23T10:01:31 Roll vulkan-deps from be96f8cab214 to 5d0bdd3702f7 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/be96f8cab214..5d0bdd3702f7 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/dc9f6f61adaec755a09e1943cf7014c688443bcb..592aed9c206c283cac98f7a86e5cc237dadb2638 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/626dfbff49b53a5d054d4437d3bf3aa9ef85a6ee..a0817526b8e391732632e6a887134be256a20a18 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/5892ebe2d7505c2238a643288d9a5b2e68784a36..c5c24ad66bf1c7b430a86593f10c62d0acf008b4 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/2cee0d5b1d8c34e26fd6d9992d3d428ac4c5139d..46df205dcad665b652f57ee580d78051925b296a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/919599474e6e6639527e7c3775ed1064665412d3..84d70cb19863a7dc39d3f5437efeef52179e5791 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I0b1468b96428cc05fb35739ac0c13fff15f4918a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5732885 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 7691cea7 2024-07-22T13:46:14 Vulkan: Remove seamful cubemap emulation Practically, the Vulkan backend is never expected to run on ES2 hardware. It _may_ for WebGL, but seamful cubemap emulation was disabled for webgl anyway. Bug: angleproject:354729454 Change-Id: Iafa20fbdbe232c4df4c777b12e7698ef7a87cf24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5730143 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Alexey Knyazev 0d458614 2024-07-18T00:00:00 Vulkan: Fix PBO readbacks with small row length Use CPU path when the row length is smaller than the source area width. Fixed: angleproject:354005999 Change-Id: I5c4686ca5387a98c6137868afb19c333aed8ac21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5724591 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 975674ea 2024-07-18T00:00:00 Metal: Fix PBO readback failures with small row length Do not use blits when the row length is smaller than the source area width to avoid Metal validation failures. Bug: angleproject:354005999 Change-Id: Ifa0f29a0d1d2fb3275ea254957c24f36807e6f66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5724790 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Igor Nazarov e37c79d4 2023-11-23T15:59:12 Fix DecompressBlob() when compressed data is invalid Function uses `zlib_internal::GetGzipUncompressedSize()` to calculate the `uncompressedSize`. This size comes directly from `compressedData`. If source data is invalid or has different format, then calculated size may be any value, including 0. Zero `uncompressedSize` cases ASSERT() in `angle::MemoryBuffer::data()` and may case UB in `zlib_internal::GzipUncompressHelper()`. Bug: chromium:1485277 Change-Id: Iaa92d93a5a1b530b8686cfb544eb66075b0874e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5729953 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll fb4cdb18 2024-07-22T10:01:42 Roll vulkan-deps from edbbcd521ef6 to be96f8cab214 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/edbbcd521ef6..be96f8cab214 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/52f68dc6b2a9d017b43161f31f13a6f44636ee7c..dc9f6f61adaec755a09e1943cf7014c688443bcb https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/4c7e1fa5c3d988cca0e626d359d30b117b9c2822..626dfbff49b53a5d054d4437d3bf3aa9ef85a6ee https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/53a6ba7c235cbe0b0f3e85e3de6d9070bcfec710..2cee0d5b1d8c34e26fd6d9992d3d428ac4c5139d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/9479047902e8031210b1bb33a8850e32b313dd25..67522b34edde86dbb97e164280291f387ade55fc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/edcf314e81d9866e783ce55855fd1dc482b263e1..919599474e6e6639527e7c3775ed1064665412d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I5ed6f934ffbdfda3fcfc634e6b0a7b351dd3e93f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5725804 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d44a3032 2024-07-22T08:17:56 Roll Chromium from 06c75e7c6658 to 9739f7f11240 (859 revisions) https://chromium.googlesource.com/chromium/src.git/+log/06c75e7c6658..9739f7f11240 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9ad8e1f7a1..7a8285c06a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/adc2a53a41..3ef44a2b92 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3f18920b3c..926b0906b1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/786400210f..1699936526 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c81122f69..28a7eef132 * third_party/siso/cipd: git_revision:b41f9eaf44dfdaec51ab2d7089aaa4cb6d9e7f5e..git_revision:50a6db5dae3978d2d2e8dce29f6df024dde48d1b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/03072f076e..f808d81be6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3eba5f340c..4dc76da47b * tools/luci-go: git_revision:c9c95dda5f310610a3fc574af44faeed298b3938..git_revision:771ea9a614a104c71655f699ef82219a2a474817 * tools/luci-go: git_revision:c9c95dda5f310610a3fc574af44faeed298b3938..git_revision:771ea9a614a104c71655f699ef82219a2a474817 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f6e1f7aa05..fd08f81f15 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: If591c19a281d6bbb7ca5ab9d9796964b9969c316 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5726770 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 85edb907 2024-07-17T19:09:09 Vulkan: Remove the adjustClearColorPrecision feature for new driver The vulkan driver issue that this feature tries to workaround is resolved in the new driver. Remove the feature workaround. Bug: b/292282210 Change-Id: I541526e71d5312f1a23b5a415e96d5b966e77f2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5719652 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Solti Ho <solti@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 93491ae3 2024-06-21T08:04:24 FrameCapture: Handle active texture in MEC When restoring texture bindings and contents, we need to first set the correct GL_ACTIVE_TEXTURE, otherwise it will use existing active texture bindings and update the wrong textures. Test: Grand Mountain Adventure MEC Bug: angleproject:345851268 Change-Id: I7c6c4a918513d4216405efe51774fcce4b49b45e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5647491 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
kmx.io     mail     discord kmxgit v0.4.0