kc3-lang/angle

Log

Author Commit Date CI Message
Gert Wollny 7ea302b6 2022-10-31T09:21:18 Capture/Replay: Special-case EGL image attribute pointer write If we don't special case this, the taken code path may end up writing "(nil)" if we have a null pointer, and compilation of the test will fail. Bug: angleproject:7793 Change-Id: Ic9fe9ccca0304069adbbb996666bc643e7d29278 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3990758 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 822471f0 2022-10-24T08:08:03 retrace: Add a catch-all clause to report all errors With that running the a batch of tests from an external script can bail out early when a trace fails. Bug: angleproject:7800 Change-Id: I5041e863a8cdc212b7057b88e3f0fd68a5115470 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3990621 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 27561f04 2022-10-30T09:38:00 Capture/Replay: Emit always gContextMap2 when capturing traces Bug: angleproject:7800 Change-Id: I12fc39d709527865a9b248a00c95d281c4e4d743 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3993317 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev adcda453 2022-11-01T00:00:00 Suppress new clip distance tests on iOS Bug: angleproject:7768 Change-Id: Ib61efbb97dd9d6b238d4a59fc50983515f9d89fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996442 Auto-Submit: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Shahbaz Youssefi 67ee4976 2022-10-31T15:34:19 Vulkan: Skip BestPractices-ImageBarrierAccessLayout Bug: angleproject:7795 Change-Id: I98f6840f9cd2956f7e73d0496a26f504516c48e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3993364 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev 805e00b8 2022-10-27T00:00:00 D3D11: Add clip and cull distance support Added gl_ClipDistance and gl_CullDistance support to HLSL translator. Added enabled clip distance GL state emulation. Added limitSimultaneousClipAndCullDistanceUsage limitation. Expanded and optimized related end2end tests. Bug: angleproject:4452 Change-Id: Id66312505254ceff43d5258d486ddcdb0462db47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3990944 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi 7b102c18 2022-10-31T10:29:45 Vulkan: Disable logicOp dynamic state on Intel/Mesa Hits a stack overflow inside the driver. Bug: chromium:1379201 Change-Id: I52e5254b37688a027cbcf5ee5752de36b9b2a3aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3993360 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 9d9b8b07 2022-10-24T15:56:42 Docs: Fix up trace replay options The restricted_traces README was missed in prior update. Bug: angleproject:7755 Change-Id: I65380ef902d3b8a39cec16829c3e0e8170e2667b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3975599 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 1d6f100b 2022-10-31T14:26:55 Roll VK-GL-CTS from bfc5b6f54270 to acb25bf242c3 (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/bfc5b6f54270..acb25bf242c3 2022-10-28 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main 2022-10-28 ziga@lunarg.com Fix compile error 2022-10-28 ziga@lunarg.com Add more VK_EXT_depth_clip_control tests 2022-10-28 piotr.byszewski@mobica.com Add MSAA tests for fragment_shader_barycentric 2022-10-28 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main 2022-10-26 piotr.byszewski@mobica.com Update vulkan-docs version 2022-10-18 gleese@broadcom.com Update to the latest glslang If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I20dfde0ca47e1736c3247d5d16827d99dd06bfb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3994282 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 70132045 2022-10-31T10:01:27 Roll SwiftShader from e8d4f9f4d703 to cd9da0fefcef (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/e8d4f9f4d703..cd9da0fefcef 2022-10-28 swiftshader.regress@gmail.com Regres: Update test lists @ e8d4f9f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ic929b45d4dd51f95e68dd1a2ea8fee15afa7369c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3992894 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chia-I Wu 32fb3be6 2022-10-27T16:05:30 Vulkan: disable rasterization order feature if isQualcomm It is simpler to just disable it for Qualcomm. Bug: b/255837430 Change-Id: I884a9635ed2c6049fa4f79e10613f87f3f40f199 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3989644 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Chia-I Wu <olv@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Chia-I Wu 5fc46a22 2022-10-27T16:02:31 Vulkan: Specify rasterization order only when there is fb fetch The original change had a performance impact on Qualcomm open source driver on some traces trex_200 22ms -> 39ms car_chase 80ms -> 190ms because it is expensive to make fb fetch coherent on Qualcomm hardware. This fixes the regression by making sure we specify the rasterization order only when there are indeed fb fetches. But we believe other workloads can still be hit by the issue even after this fix. We will disable rasterization order for Qualcomm driver in the next commit. Bug: b/255837430 Change-Id: If240dcbfd73112a72dc1e537821636ca16290eaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3989166 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Chia-I Wu <olv@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Chris Dalton <chris@rive.app>
Jamie Madill 04cf49bc 2022-10-28T00:16:08 Update Mesa build variables. For gclient: angle_mesa -> checkout_angle_mesa For BUILD.gn: build_angle_mesa gets set automatically. Bug: angleproject:7689 Change-Id: I89ff8a54fc87d9fb28ac998331ffbd0d8eb246ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3989923 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu ce62d52f 2022-10-27T18:41:11 Fix Mid Execution Capture for External Texture How we capture eglCreateImage and eglCreateImageKHR have changed recently. Fix the code that recreate eglCreateImageKHR calls for external texture type in Mid Execution Capture. Bug: angleproject:7758 Change-Id: I2bd35ec3349f1d4f1aef1bf7f76ac50d4abca53d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3989645 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Tiago Vignatti 4abae6f9 2022-10-28T11:09:15 Metal: Fix 8-bit type name This fixes a probable typo for the 8-bit unsigned integer value type. Test: build ANGLE with Metal renderer enabled on iOS. Bug: None Change-Id: I2a332d996633fd81d01eece75817efb5683a5b31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3989426 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Yiwei Zhang fd3bfb77 2022-10-27T23:18:46 EGLWindow: workaround eglQueryString behavior before Android 10 EGL_NO_DISPLAY + EGL_EXTENSIONS returns NULL before angle support introduced in Android 10. See aosp/760681 for the reference. Bug: b/255844932 Test: build and run angle trace on Android Pie Change-Id: I23a8236cbd220ce34ebbcc602d6ced351fc76619 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3988422 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev ac5a9c53 2022-10-26T00:00:00 Metal: Optimize ReplaceClipCullDistanceVariable The intermediate ANGLEClipDistance variable is not needed when generating MSL output directly. Bug: angleproject:6291 Change-Id: Ie3d32a903645be002f21c44a6233f9cd0155605a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3981716 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Jamie Madill a9868110 2022-09-15T17:29:04 Add support for testing with Mesa + Zink. To run a trace test with zink, use --use-gl=zink. Bug: angleproject:7689 Change-Id: I70073756f903db1c224fe6175d55be4cad637aca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3899382 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill d19f8725 2022-10-27T18:08:34 Disable more options in libdrm. Disables man page building and valgrind, for more compatibility. Bug: angleproject:7689 Change-Id: I6249164fa39f3c6dae3b80b4f63c365cb87ddaf5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3988104 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 41184c21 2022-09-29T10:50:39 Add support for building Mesa + Zink. Uses a conditional gclient variable "angle_mesa". You must set this to True in your .gclient to download and configure Mesa. After that you must also set angle_build_mesa=true in your GN args. We call through to meson in order to setup and build. Mesa sources and targets are written into an auto-generated GNI file. We must update this file on the same cadence as Mesa rolls. Because the version of libdrm we use in our sysroot is older than Mesa requires, this CL also includes a custom libdrm build. Also in order to run bison and flex on the old sysroot that Chrome infra runs with, this CL includes a new version of flex and bison that run without newer versions of GLIBC. Bug: angleproject:7689 Change-Id: I1aeeda1e6f3cf1d5f878aeab5209afa7e1fb5324 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3933062 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll f9071973 2022-10-27T10:01:51 Roll SwiftShader from 5634e136d794 to e8d4f9f4d703 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/5634e136d794..e8d4f9f4d703 2022-10-27 capn@google.com Assert VkInstanceCreateInfo::flags is 0 2022-10-26 sugoi@google.com Handle all Vulkan 1.2 promoted structures 2022-10-26 capn@google.com Regres: default to 100 tests per process 2022-10-26 rjodin@chromium.org libVulkan.cpp: add missing struct in vkCreateDevice 2022-10-26 sugoi@google.com Update go tools to go 1.18+ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I8ecacac96bc9c1ce12813e82bf485b34a35c19ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3985688 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 2bc9f1f4 2022-10-26T10:38:02 Lazily create threads in the thread pool The Vulkan backend doesn't use thread pools normally, so creating threads is a waste of CPU time. Additionally, creating threads early causes issues with some sandboxing strategies. Bug: b/250688943 Change-Id: I33f1b73bdc62f6a0c0b2277ce99ba78a87464486 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3982174 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 6bef0630 2022-10-24T10:46:09 Exit on nullptr returned from decompress callback. Decompression failures appear to happen (very) occasionally, resulting in a weird stack trace later down the road. Bug: None Change-Id: I12780f462c7d1a141d0841e1e07acb2d282077e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3970768 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Sean Risser 9b9d8032 2022-10-19T14:57:03 Avoid mExtensions for initializing mExtensions tracks the currently enabled extensions, while nativeExtensions tracks which extensions are available on a platform. This makes nativeExtensions more suitable for initializing data, as extensions may be disabled at initialization and enabled later. Bug: angleproject:7769 Change-Id: I9ee821a931045fc89091473f35e2b306ee653613 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3965610 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Sean Risser <srisser@google.com>
Roman Lavrov a77a80a1 2022-10-25T13:54:33 Wait for DestroyNotify and ConfigureNotify events. There appears to be a race condition where XDestroyWindow+XCreateWindow ignores the new size (the same window normally gets reused but this only happens sometimes on some X11 versions). Wait until we get the destroy notification which should avoid races between termination and initialization. However, it turns out just doing that breaks things because tests get to termination before even giving the window a chance to set up fully (e.g. ConfigureNotify) which only happens after making the window visible.. so additionally block in setVisible until we get ConfigureNotify. aaand turns out RobustBufferAccessBehaviorTest requires setVisible(true) - tests fail when running on my local Linux and pass now that I added setWindowVisible! Bug: angleproject:7620 Change-Id: I93f2f05cb9d1c62776636bec976d94ead4cf0fd1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3979168 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll e8a1e409 2022-10-26T10:01:11 Roll SwiftShader from ea3fc74f3d69 to 5634e136d794 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/ea3fc74f3d69..5634e136d794 2022-10-26 capn@google.com Move format support checks to vk::PhysicalDevice 2022-10-25 swiftshader.regress@gmail.com Regres: Update test lists @ 8aff0c1f 2022-10-25 sugoi@google.com Propagate error to AnalyzeOutput 2022-10-25 sugoi@google.com Temporarily fix dEQP pipeline depth stencil tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Iedaf6936d133b6389a4dd0d87542120d5f4c2a4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3980003 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 53abcf15 2022-10-25T15:26:44 Vulkan: Bug fix in supportsTimestampSurfaceAttribute Move the initialization of "vkGetPastPresentationTimingGOOGLE" and the assert check to after vkDevice creation. Bug: angleproject:7489 Change-Id: I1ef50d64af3bea44a182be95dd182532b2c60d36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3979994 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Greg Schlomoff 81a244de 2022-10-10T15:32:25 Adding a class to perform ASTC texture decompression on the CPU This significantly improves performance by caching and re-using the ASTC decoder context, and using multi-threaded decompression. This code was originally written for gfxstream. Bug: b/250688943 Change-Id: I1727447907f2e25cf9b854ffcc9ccfc04db2fb91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929008 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 1c197e06 2022-10-24T16:53:01 Remove dEQP suppression for tests that already passed Bug: b/224537784 Bug: angleproject:6898 Bug: angleproject:6910 Bug: angleproject:6918 Change-Id: I25f1d0d6fb3147d11cdf352290a683beed5082f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3976789 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Geoff Lang 0c711639 2022-10-25T11:56:12 Add flatbuffers to the tracked chromium deps. Bug: angleproject:7788 Change-Id: Ic126178722a8d58247819af0e4ee83f8be7faca2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3977250 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Constantine Shablya ef8350a6 2022-10-21T06:30:51 GLES1Renderer: Handle GL_BGRA the same way we handle GL_RGBA Fixes minetest Bug: angleproject:7774 Change-Id: Iacbe8cb9aa434ec624bfaf056092b77bda468b3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3970417 Commit-Queue: Constantine Shablya <constantine.shablya@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Constantine Shablya <constantine.shablya@collabora.com>
Alexey Knyazev c97edf51 2022-10-24T00:00:00 Metal: Enable APPLE_clip_distance Adjusted direct-to-Metal shader translator to support gl_ClipDistance built-in. Bug: angleproject:6291 Change-Id: Ice4cc3e4d7c131cbaac9726e845a5c1e59787e69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3976428 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll a9001d17 2022-10-25T10:01:20 Roll SwiftShader from 1ab775a9492b to ea3fc74f3d69 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/1ab775a9492b..ea3fc74f3d69 2022-10-25 syoussefi@google.com Support VK_KHR_get_surface_capabilities2 2022-10-24 capn@google.com Update README for Vulkan 1.3 2022-10-24 swiftshader.regress@gmail.com Regres: Update test lists @ 1ab775a9 2022-10-24 sugoi@google.com Allow running multiple dEQP tests per process If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I6a02f4264edba206b21f8c23ff3d09366167dfac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3975927 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 30439960 2022-10-24T17:30:18 Unbreak run_angle_android_test. Broken by ListTests removed in https://crrev.com/c/3963651 Move helper to angle_test_util. Bug: angleproject:7755 Change-Id: I1eec442cf3e2bf6c24335d4c294a68e7e868b814 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3975353 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Geoff Lang 966f3bae 2022-10-24T13:27:48 Replace sprintf by snprintf in trace_interpreter.cpp sprintf has been deprecated and generates warnings. Bug: angleproject:7752 Change-Id: Id1483585397edba44e03f7e5e925d398882af2f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3975351 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 11a3e06b 2022-10-24T11:26:05 Android: Fix restricted_trace_perf.py Test: restricted_trace_perf.py --fixedtime 10 --power --loop-count 5 Bug: angleproject:7755 Change-Id: Idbd2ccc73bd7409e2538346897b254403c1fd5d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3975592 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Geoff Lang 6c53a562 2022-10-24T10:24:10 Add missing cstring include in gl_enum_utils. Bug: angleproject:7752 Change-Id: I44ac0996673065b9633b35e4b07c5150a1ae3dcd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3970767 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 81fcf70e 2022-10-24T09:53:17 Reduce angle_preftests samples from 10 (new default) to 6. Taking too long on Windows, this should bring it close to other test suites. Bug: angleproject:7782 Change-Id: Ie1e76fffda790c3b5c2e73a22dee92763fa56abb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3970765 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Trevor Black <vantablack@google.com>
angle-autoroll 28dd99dc 2022-10-24T10:01:29 Roll SwiftShader from 554ce0027284 to 1ab775a9492b (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/554ce0027284..1ab775a9492b 2022-10-21 capn@google.com Rename EmitState to SpirvEmitter 2022-10-21 sugoi@google.com Fix shell.Exec calls in git.go If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I1e4686a7ea238e4b25d8912725f274bbe5626424 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3974370 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill dc62b3ee 2022-10-10T21:00:16 Capture/Replay: Add trace interpreter. Also adds a self-test using the retrace script. Bug: angleproject:7752 Change-Id: I1985b47250bef99726d2ca2d90bef859208e357e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3965128 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Jamie Madill bc2e9eea 2022-10-15T14:38:15 Refine sampling of trace perf tests. - The warmup algorithm now computes an accurate steps estimate. - Bump up the trials, samples, and trial time in the runner. Bug: angleproject:7671 Change-Id: I89a73472fd72af73f695c9107119cbc559d2d6e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3956946 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Jamie Madill b4319e49 2022-10-20T10:10:32 Enable flaky retries on SwS ASAN/TSAN. This should compensate for ASAN/TSAN being generally flaky. Bug: angleproject:7772 Change-Id: Ied857321179c06fd9fc9bcf3d58e919b4f2009f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3968319 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Solti 97beb2f7 2022-10-21T18:21:16 disable pixel6 for VertexAttributeTestES31 tests Bug: angleproject:7770 Change-Id: Icc5d750ab222d2757e9551cbe3c2e7816b77a040 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3971009 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Solti Ho <solti@google.com>
Solti f9c58274 2022-10-21T18:00:06 Disable test: FramebufferTest_ES3.DrawWithDifferentPreRotations Bug: angleproject:7778 Change-Id: I02d71e031bb0c8455599014bcae975a1e5f5200f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3971006 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Solti Ho <solti@google.com>
Jamie Madill a41c6173 2022-10-16T08:28:53 Simplify trace test names. Originally we had a lot of conditionally enabled test configs in angle_perftests, that we enabled behind a flag because the total runtime would be too large if we left everything enabled. This CL switches to using a single test set, one for each trace, and using a the same command-line API we use in dEQP and the ANGLE samples to pick a single configuration. This makes it easier to pick exactly what configurations you want from the command line. Because we only run one configuration each time, we don't need to specialize the test name to include the configuration info. We can also simplify TracePerfTest -> TraceTest since these tests are run for both perf and correctness. Old name: TracePerfTest.Run/vulkan_trex_200 New name: TraceTest.trex_200 Example for tests that don't use default arguments: Old args: --enable-all-trace-tests Old name: TracePerfTest.Run/native_offscreen_trex_200 New args: --use-gl=native --offscreen New name: TraceTest.trex_200 Bug: angleproject:7755 Change-Id: Id93cf5725eff2e2c6b3b14804bc2902f38306e7e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3966535 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Jamie Madill 0c3b4fe8 2022-10-21T10:17:31 Reduce --use-angle spam in TracePerfTest. Instead of recalculating the back-end for every trace, we can do it once in the test instantiation and pass the results around. Bug: angleproject:7755 Change-Id: I492c639d91ee6ad6a325cff090813aaeb900b2d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3971080 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 0d635faf 2022-10-21T09:43:13 Enable capture by default on release non-Android bots. This will enable running the trace interpreter tests with ANGLE. Also this cleans up a case where we now default turning off the trace tests when we're building with non-clang. Bug: angleproject:7752 Change-Id: I7019bb969d859e06fafc7621e8620b8a2375261e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3971079 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Roman Lavrov cc35022f 2022-10-21T08:42:31 Only allow missing output file when listing tests. Avoids potentially swallowing an error in non-list-test mode Bug: angleproject:7755 Change-Id: I4e7fba6a5d110d568d71c31585fffdb189ec12a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3971078 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Jamie Madill 06ecc918 2022-10-10T20:59:38 Capture/Replay: Optionally emit C sources. This adds an option that controls if we can write out simplified C replays. Once the work is finished we can remove the option and only allow emitting C instead of both C and CPP. Required emitting multi-line strings differently, as well as conditionalizing a few other language differences. Bug: angleproject:7713 Change-Id: I3303134316ed3fc1b4286bcd32961e8f7ecfbb06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3953339 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill bba47588 2022-10-19T11:59:10 Update ANGLE API loaders to avoid C++ syntax. This replaces "using" with "typedef" in the various loaders. This will allow C traces to use the loaders, which in turn will allow us to implement a C interpreter. Bug: angleproject:7731 Change-Id: I37838bcafc290502fca0038d1b50554b6a301e65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3966533 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 35549c3a 2022-09-19T12:09:08 Add a help preamble for trigger.py. Bug: angleproject:1944 Change-Id: I03929c38512c32204773859479be4b20a35facc0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3905801 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll d722ec38 2022-10-21T10:01:33 Roll SwiftShader from fa1a1fcf0fd2 to 554ce0027284 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/fa1a1fcf0fd2..554ce0027284 2022-10-20 sugoi@google.com Revert "Temporary patch for OOB read issue" 2022-10-20 capn@google.com Eliminate EmitResult 2022-10-20 nicolascapens@google.com Revert "Temporarily fix pipelineStageCreationFeedbackCount = 0 issue" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ia7cf1cc85c226655b669e4f30ef083a6a6df1e2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3970859 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 70ca7bd8 2022-10-19T12:21:08 Capture/Replay: Make fixture work with C and C++. This prepares the trace fixture for simplified C source replays. Bug: angleproject:7731 Change-Id: I1ac55ec95838ece2deb81cca2a5bec2a20d90bd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3966532 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 596c2acf 2022-10-20T18:59:04 FrameCapture: Fix FenceSync for MEC Follow up to: https://chromium-review.googlesource.com/c/angle/angle/+/3957164 Test: MEC for Grimvalor Bug: angleproject:7758 Change-Id: Ia0895e923d9bee41bcfbff48d15bf9aa86e29d17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3969519 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi adde4265 2022-10-19T23:33:48 Vulkan: Separate pipeline cache query and insertion In preparation for VK_EXT_graphics_pipeline_library usage, the query and insertion functions of the graphics pipeline cache are separated. This will allow the implementation using VK_EXT_graphics_pipeline_library to query the monolithic pipeline cache, and if a pipeline is not found, create it through the pipeline library caches. Bug: angleproject:7369 Change-Id: Iebf7669ae3ea95e180646198c4861cc59d67e580 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963854 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 5c0b329e 2022-10-19T16:59:58 Vulkan: Clean up rotation spec const update Update during makeCurrent was done by invalidating the program, and then at pipeline creation time the spec const was updated. This is changed so that makeCurrent updates the spec const directly, and avoid invalidating the pipeline. Also removes spec const usage calculation, as it's unused. Bug: angleproject:7369 Change-Id: I79444ce4173c4db9c6800fb02afd9e8447a25f82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963853 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Mohan Maiya 3245e555 2022-10-19T16:52:36 Expand support in angle_shader_translator 1. Add GLES3.2 support 2. Add support for tessellation control and eveluation shaders 3. Enable "variables" compile option when generating SPIRV Bug: angleproject:7773 Change-Id: I372343bf70edf80d40a410d70ccb63334f2b1450 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3967819 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 6193274a 2022-10-10T21:00:12 Capture/Replay: Redesign in-memory call capture replay. This will allow the replay to use the call captures returned by the interpreter's parser. Bug: angleproject:7752 Change-Id: If1b281d9ce7ccfbdc23bea615e1e2258c8a029f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963367 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Jamie Madill cd10b6d2 2022-10-10T21:00:07 Enum Utils: Add method to return enum value from string. We'll use this in the trace interpreter to parse enum values. Bug: angleproject:7752 Change-Id: I232a00baac2f74c9618029929bbb3e5822654046 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963366 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill fd45cec3 2022-10-10T20:59:58 Entry Points: Move enum helper to registry_xml. This will make it accessible to other generators. Bug: angleproject:7752 Change-Id: I91bc9a4d6c919266ea329f66d271bf881d99d17a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963364 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 873650f4 2022-10-19T16:51:53 run_perf_tests.py: Fix test list unexpected error. The tests were failing because of a failure to pull the test json output from the device after --list-tests. This failure was benign because the test lists still came through to the test runner and it was able to proceed, but it was causing an error message. Also changes the runner to fail early if there's any error during --list-tests. Bug: angleproject:7755 Change-Id: I67bceec6b69fd2856136313d5e456e3c1f1caccf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3964753 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Chris Dalton 01e6be3c 2022-10-19T20:42:30 Actually use EXT_shader_framebuffer_fetch_non_coherent for PLS Bug: angleproject:7279 Change-Id: I37099a917303ab41d86dbe1203183ac55229942f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3966074 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill d25911de 2022-10-10T20:59:53 Capture/Replay: Move trace fixture into util/ This will allow us to cleanly import the fixture headers outside of libANGLE. We'll need to call into the trace fixture in the trace interpreter, which will be in util/. Bug: angleproject:7752 Change-Id: I3438989db8482924272c69e78d7ac5702e510648 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963363 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Robert Mader 5b7113b6 2022-09-21T10:05:42 EGL: Implement EGL_EXT_device_drm and EXT_device_drm_render_node These extensions are needed by Exo for zwp_linux_dmabuf v4 support. Add the needed infrastructure to the EGL backend to support device queries and expose the extensions there. In the future we will want to support the extensions on Vulkan as well, however unfortunately this is not trivial, so leave it out for now. Bug: angleproject:7686 Change-Id: I0a54bf58dbaa9e87c8baac760cb9ac9027fea4c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3964272 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill 4bfb749f 2022-10-10T20:59:48 Capture/Replay: Move shared trace code into src/common. This will let them be accessible to the test harnesses. The trace tests interpreter will need direct access to the classes that we move in this CL. This CL also moves the GLenum utils into the common folder, where they were already used by some other tests. Bug: angleproject:7752 Change-Id: I97ad607938ef29bc316f6d40098478e002ea8128 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963362 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 5ec6f8dd 2022-10-10T20:59:42 Capture/Replay: Only inline strings. This will simplify the trace code and the parsing logic. Previously we wrote some integer data in the cpp file, e.g.: const GLenum glDiscardFramebufferEXT_attachments_0[] = {...}; glDiscardFramebufferEXT(..., glDiscardFramebufferEXT_attachments_0); Bug: angleproject:7731 Change-Id: If7924b1bf231f584f4677a438232bedc7ea9bd69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3953338 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Jamie Madill 8403e4c5 2022-10-10T20:59:29 EGL: Resource IDs for Surface, Context and EGL Image. This will make these classes play nicely with resource maps. As these objects are used in a lot of places, and simplified C can't handle unordered_map, it's necessary to index the maps by simple packed IDs in capture/replay code. This indirection will also have increased safety as we validate EGL resource ID handle values before accessing the memory directly. Also hides some of the other EGL capture methods behind helper methods to simplify the C code and hide assignments and other complex maps. Bug: angleproject:7758 Change-Id: Ibc7bb56430d3068bd38877c9dfb011979d4ea234 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3957164 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Sungyong Choi c6390143 2022-10-12T09:57:55 Vulkan: Make compatible with GCC Resolves below warnings occurred with GCC build. 1) deperecated-copy Overriding an assignment operator without a copy constructor caused the deprecated-copy warnings. 2) unused-function 3) parenthesis Warnings occurred due to missing parenthesis around some logical expressions, add them to quiet the warnings. 4) unused variable 5) 'maybe-unused' attribute ignored Introduces 'ANGLE_MAYBE_UNUSED_PRIVATE_FIELD' macro to avoid 'attribute ignored' warning which is only occurred with GCC because GCC doesn't warn about 'unused non static data member' whereas Clang has Wno-unused-private-field. Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> Bug: angleproject:7764 Change-Id: I8e7410a5ed8cb9b8f8b3202073d779fea63d6b75 Reviewed-by: Jeff Vigil <j.vigil@samsung.com> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963830 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 315b07b2 2022-10-19T22:06:44 FrameCapture: Fix UniformBlockBinding Follow up to: https://chromium-review.googlesource.com/c/angle/angle/+/3953334 Test: MEC for Grimvalor and Wild Arena Survivors Bug: angleproject:7731 Change-Id: I2a246c5701aaf42d77fd45487804f0f21562342e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3967870 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 29624da3 2022-10-20T10:01:03 Roll SwiftShader from fdf41479349b to fa1a1fcf0fd2 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/fdf41479349b..fa1a1fcf0fd2 2022-10-19 sugoi@google.com Fix zlib dependency for Regres 2022-10-19 capn@google.com Store phi variables in a collection of SIMD components 2022-10-19 capn@google.com Limit SPIR-V phi variable lifetimes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I5b7c3d33a03ca3dc1f1de9c839dc97c5aa6235c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3967405 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 7b4b56f0 2022-10-19T00:05:22 Vulkan: Missing output mask in GraphicsPipelineDesc Currently, there's some program state used in creating pipelines alongside what's in GraphicsPipelineDesc. This works because the pipeline cache lives in the program executable. With VK_EXT_graphics_pipeline_library however, we could create vertex input and fragment output partial pipelines that are independent from and are shared between multiple programs. To support this, any program state that's necessary for pipeline creation should be part of the GraphicsPipelineDesc structure. This change places the state affecting fragment output in GraphicsPipelineDesc. Bug: angleproject:7369 Change-Id: I2e48fc9da220475e1b2ed376fc947ce13489610e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963652 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi f0e3d8f9 2022-10-18T13:51:31 Vulkan: Shader component type in GraphicsPipelineDesc Currently, there's some program state used in creating pipelines alongside what's in GraphicsPipelineDesc. This works because the pipeline cache lives in the program executable. With VK_EXT_graphics_pipeline_library however, we could create vertex input and fragment output partial pipelines that are independent from and are shared between multiple programs. To support this, any program state that's necessary for pipeline creation should be part of the GraphicsPipelineDesc structure. This change places the state affecting vertex input in GraphicsPipelineDesc. A follow up change will do the same for state affecting fragment output. Bug: angleproject:7369 Change-Id: Iccf691a1597d786efa1625f7b1c22f906201f2e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3964751 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev d8fe28dd 2022-10-19T00:00:00 Suppress clip distance tests on iOS Bug: angleproject:4452 Bug: angleproject:7768 Change-Id: Iabea037ded6ee3cfa0c325c59099772ac6adbbc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963134 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Shahbaz Youssefi 025504b9 2022-10-17T17:03:03 Pass worker pools to image load functions In preparation for the ASTC decoder using threaded decoding. Bug: b/250688943 Change-Id: I70d669bcb57b900dbb633304182e174aec362203 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3961339 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Greg Schlomoff <gregschlom@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b5929ac6 2022-10-17T18:06:32 Move worker pools to Display It doesn't make sense for each context to have its own set of CPU-count workers. This change also facilitates access to the thread pools where gl::Context is not available (but egl::Display is). Bug: b/250688943 Change-Id: I240353abba26c15338d59631b4179a58dfd662f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3961334 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi fbd7d5fa 2022-10-17T17:20:09 Move thread pool classes to common/ In preparation for access by image_util files. Bug: b/250688943 Change-Id: I24777269a5071eae9a60f939635d01ed7246461f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3961454 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill e495e7fd 2022-10-14T13:52:47 Redo perf and trace test parameters. - Moves common argument parsing code into test_util. - Changes the perf test arg parsing to use the common functions. - Adds new --use-angle and --use-gl parameters to the trace tests. - Also adds new --offscreen and --vsync parameters to the traces. - Removes the now unneeded --enable-all-trace-tests argument. - Both --arg=value and --arg value work in test suites now. Now, instead of using --enable-all-trace-tests you can specify the backend with --use-angle=swiftshader, --offscreen, or combinations of those parameters. The test names are the same as they were before, but only the configured tests will run in a session. We could opt to simplify the test names in later CLs if we want to simplify the test running. Ideally we'd keep the perf reporting the same because then we'd keep the time series the same on the test infra. This also allows us to split up the trace tests into separate targets on the bots, which will better allow us to control the workloads and sampling of the tests. For example: - angle_perftests becomes - angle_perftests (microbenchmarks) - angle_trace_perf_vulkan_tests (traces with vulkan back-end) - angle_trace_perf_native_tests (traces with system GL) Bug: angleproject:7755 Change-Id: I537168f3a6de96425dfda05ed98220eff9b19b76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3956937 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 03eccad2 2022-10-18T10:39:53 Tests: Add reduced crashing shader test Reduced case of a shader that crashes an app during SPIR-V compile. Test: GLSLTest_ES3.NestedPowFromUniform Bug: b/217922015 Change-Id: I8d0ccd8b2c4f4e8e51ac39c9dbfaafbf48423157 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3965051 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill d6ca85bd 2022-10-18T17:10:41 run_perf_tests.py: Remove unneeded Android args. These only apply to the Chromium Android test runner, which we no longer use for this script. Bug: angleproject:7755 Change-Id: I311ac204e1999a77872a76f6d0b9d149f7ac409e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963651 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Jamie Madill <jmadill@chromium.org>
angle-autoroll 9e724d5a 2022-10-19T10:01:22 Roll SwiftShader from 00b601d8ad24 to fdf41479349b (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/00b601d8ad24..fdf41479349b 2022-10-18 capn@google.com Move EmitState out of SpirvShader 2022-10-18 capn@google.com Move Reactor code emission from SpirvShader to EmitState 2022-10-18 capn@google.com Detect OpImageWrite in the analysis pass If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I09d2eb81699bcf804c9864d6518f27a4213ee89a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3966249 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Greg Schlomoff 60592f3c 2022-10-13T17:58:18 Reland "Make ANGLE's Worker Pool actually pool the threads." This is a reland of commit 0a4a7ea77661703e467293bc0f6d79c95061fa76 Original change's description: > Make ANGLE's Worker Pool actually pool the threads. > > When starting a lot of short-lived tasks, this increases performance by > over 70 times on my machine. > > Old code, decoding a 16x16 ASTC texture with 8 threads: > *RESULT AstcDecoderPerfTest.cpu_time: run= 2,847,708 ns > *RESULT AstcDecoderPerfTest.wall_time: run= 1,841,014 ns > > New code: > *RESULT AstcDecoderPerfTest.cpu_time: run= 81,602 ns > *RESULT AstcDecoderPerfTest.wall_time: run= 27,088 ns > > Bug: angleproject:7757 > Change-Id: Ib643405675c50b2ed8ccd24d6caa7e57335130e1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3953905 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Greg Schlomoff <gregschlom@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7757 Change-Id: Ib06b37c8776dac5a2b1ea67921a9cd8687485ee2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963370 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 53fd00c5 2022-10-10T21:00:02 Add missing function prototypes to ANGLE ext headers. Bug: angleproject:7752 Change-Id: I316e181c61fe1daf3611c58b4db0321678d9eba2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963365 Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 1a9882dd 2022-10-19T07:00:12 Roll Chromium from 2ee62a7f9f78 to c8d10c0b09ab (427 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2ee62a7f9f78..c8d10c0b09ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2cf254f018..ef3d15e613 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ca6213a9de..5c1eeb8715 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e6caea47f8..888eff8ec2 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/1111799723..1f633d41a0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/20937c1154..50f814ce03 * third_party/android_build_tools/bundletool: IEZQhHFQzO9Ci1QxWZmssKqGmt2r_nCDMKr8t4cKY34C..sSBNyeRs5Px7nKXDLyQpz24T_OV9_rUkzqgXRNEaH0kC * third_party/android_build_tools/lint: -yqfSSiekeQe-1juzudRLkikLNk6_VZyv6tz2_GiDO4C..PgXTfxO_ExRhHwuAVaMUh48zDVj5bqVPSjecGWZ8TQIC * third_party/android_build_tools/manifest_merger: bfhl7B4_T6dP72d1sF-6RSeAQqwlw1qUx-FDEFh3sKIC..lgqr-qkYSNJxPdYaRg1beYU6to-4LBuHBw3WVO7_ancC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b049f00cff * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dbaca22bdf..64b6175557 * tools/luci-go: git_revision:9f65ffe719f73af390727d369b342c22fa37ea54..git_revision:0b4ca85948120a9e07c81e06386c031a693724c4 * tools/luci-go: git_revision:9f65ffe719f73af390727d369b342c22fa37ea54..git_revision:0b4ca85948120a9e07c81e06386c031a693724c4 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bb43a76d63..cac69ccc90 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0b8f559628..7ab82e1fdc * tools/skia_goldctl/linux: c-P40DdzhvukIRQ1DgesE2cEEU8bTLcd4p_e3LL1--sC..t3TPrZYHYFYj-Uycz4891UuvI29G25cnOuAXx4YKTJEC * tools/skia_goldctl/mac_amd64: OJJWEma6n1Cw5Ja1DQfdwbOFoFVp6071BB8VjklDcyYC..pkodJRDmOHJK-oKhKr3YyRBH-aZDOifqq2f39tyYYkwC * tools/skia_goldctl/mac_arm64: 9sTZ5XDqsy_Dj_v4NU3u4fLI_AGANp-zAJ3sof4rkwQC..MGH9P0-cwU4UFOV-4rkxKLBFEVtXIE8vtynMsKM4O4UC * tools/skia_goldctl/win: wql7tuE1euGE1rj5JPT6w6ev6KYL3hWzY6HggTHgKZ8C..-y4QQFDzRbkTKhmiP7CqEhagCHKtWFdfxwAK6anUvfAC No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ic159993868c30eff184a2ff02b270562618fa69f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3965056 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Sungyong Choi dc741ad6 2022-09-27T13:42:39 Add cstring header for memcpy and strcmp This patch adds cstring header for memcpy and strcmp Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> Change-Id: I8130010a07d43490417302d0aa5557c3224d56ed Bug: angleproject:7765 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963829 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev fec93f40 2022-10-14T00:00:00 GL: Support clip and cull distance extensions Use EXT_clip_cull_distance on OpenGL ES to expose APPLE_clip_distance; use ARB_cull_distance on OpenGL to expose EXT_clip_cull_distance. Added disableClipCullDistance OpenGL workaround. Bug: angleproject:4452 Change-Id: I458cad29c10b9d9193c5233e24bac53361ba104e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3956075 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 11f8f537 2022-10-17T16:59:50 Capture/Replay: Improvements to self-test. - print errors in the replay test - catch missing serialization - clean stale json output files before each replay - add flag to show replay stdout - fix help message Bug: angleproject:7731 Change-Id: Ibeb780f417bdbed4b249038920963dd1bd68f4aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3962248 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e0d2c7f2 2022-10-18T15:07:25 retrace script: Update trace test suite name. Bug: angleproject:7755 Change-Id: I1322543b199aacb4f083b67f0bc4f8bf93ea65b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963359 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov d22edf57 2022-10-18T14:57:55 Perf Tests: fail test on GL_CONTEXT_LOST after glFinish(). Interrupts the test in the case I ran into: ../../src/tests/perf_tests/ANGLEPerfTest.cpp:383: Failure Failed Context lost Warm-up trial took 1.11 seconds. [ FAILED ] TracePerfTest.Run/vulkan_dr_driving, where GetParam() = vulkan_dr_driving (1476 ms) [----------] 1 test from TracePerfTest (1476 ms total) Bug: angleproject:7762 Change-Id: Iaf416dbdaa0eb846b744bdb4d1eb596f0c2bb1a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963360 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Jamie Madill 0d203aef 2022-10-16T10:08:01 EGL: Add ID types for egl::Surface and egl::Image. This is in preparation for using resource maps for Context, Surface and EGLImage. The map change will make it much easier to work with the trace fixture. It will also have a small benefit in safety as we will longer be casting raw pointers for these types. As these objects are used in a lot of places, and simplified C can't handle unordered_map, it's necessary to index the maps by simple packed IDs in capture/replay code. Bug: angleproject:7758 Change-Id: Ib1d19622a4f2a6f0458cc28f5bbe30bb9f349b98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3957163 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tiago Vignatti 4be8294c 2022-10-06T09:50:28 Tests: Enable EGL_ANGLE_iosurface_client_buffer tests on iOS This enables EGL_ANGLE_iosurface_client_buffer extension tests on iOS platform. A few OpenGLES related tests had to be suppressed though. I'm getting the following: [==========] 96 tests from 1 test suite ran. (960 ms total) [ PASSED ] 66 tests. [ SKIPPED ] 30 tests, listed below: [ SKIPPED ] IOSurfaceClientBufferTest.RenderToBGRX8888IOSurface/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToBGRX8888IOSurface/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToRG88IOSurface/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToRG88IOSurface/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToR8IOSurface/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToR8IOSurface/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToR16IOSurface/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToR16IOSurface/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToR16IOSurface/ES2_Metal [ SKIPPED ] IOSurfaceClientBufferTest.RenderToR16IOSurface/ES3_Metal [ SKIPPED ] IOSurfaceClientBufferTest.RenderToBGRA1010102IOSurface/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToBGRA1010102IOSurface/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.ReadFromBGRA1010102IOSurface/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.ReadFromBGRA1010102IOSurface/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToRGBA16FIOSurface/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToRGBA16FIOSurface/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.ReadFromToRGBA16FIOSurface/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.ReadFromToRGBA16FIOSurface/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToYUV420IOSurface/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToYUV420IOSurface/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.ReadFromToYUV420IOSurface/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.ReadFromToYUV420IOSurface/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToP010IOSurface/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.RenderToP010IOSurface/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.ReadFromToP010IOSurface/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.ReadFromToP010IOSurface/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.MakeCurrent/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.MakeCurrent/ES3_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.ReadFromBGRX8888IOSurfaceWithTexBaseMaxLevelSetToZero/ES2_OpenGL [ SKIPPED ] IOSurfaceClientBufferTest.ReadFromBGRX8888IOSurfaceWithTexBaseMaxLevelSetToZero/ES2_Metal Test: iPhone 13 and ./iossim -d 'iPhone 13' -c \ '--gtest_filter=\*IOSurfaceClientBufferTest\*' angle_end2end_tests.app Bug: angleproject:5491 Change-Id: Id7c489ae41b11442a2dd06174b2c279894e83401 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3957539 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll cb52a283 2022-10-18T14:59:08 Roll Chromium from 9ac79e275a41 to 2ee62a7f9f78 (131 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9ac79e275a41..2ee62a7f9f78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC solti@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/58b7594b44..20937c1154 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/89d1071f12..3027824279 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b049f00cff * third_party/fuchsia-sdk/sdk: version:10.20221017.2.1..version:10.20221018.0.1 No update to Clang. Bug: None Tbr: solti@google.com,ynovikov@google.com Change-Id: Ie26224449309bfe1768dd502fca3da75885a1859 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3962679 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Robert Mader 67915fb4 2022-09-19T15:08:54 Reland "Reland "EGL: Implement EGL_EXT_image_dma_buf_import_modifiers"" This is a reland of commit f53eac299fb2e0083fa386af1f04038b32faebe4 New changes: - Disable the extension on old proprietary Mali drivers Original change's description: > Reland "EGL: Implement EGL_EXT_image_dma_buf_import_modifiers" > > This is a reland of commit 1d8dce2587a23b59f911c801856372996bdb2f64 > > New changes: > - fail softly on buggy drivers (which are part of the CI) > > Original change's description: > > EGL: Implement EGL_EXT_image_dma_buf_import_modifiers > > > > This reverts Ifbb0a182171646df8161f6f42eafe2a476fea6b2 and implements > > the previously missing bits. Inspired by the corresponding Vulkan > > implementation. > > > > The extension is used by an upcoming Exo feature which was successfully > > tested with this patch, see > > https://chromium-review.googlesource.com/c/chromium/src/+/3857556 > > > > Bug: angleproject:7664 > > Change-Id: I951d1a787e1db3a77b19fcea6186b7aa0a29872f > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3904345 > > Reviewed-by: Geoff Lang <geofflang@chromium.org> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > Bug: angleproject:7664 > Change-Id: I732fc9dad54366553987104fa035bde2afe08ecd > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3924350 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7664 Change-Id: I1f4cf04eb725d789d3dadb35fb6e59b0d3e470a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3949029 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill bb420af7 2022-10-10T20:59:24 Capture/Replay: Rewrite map buffer calls. This wraps the map calls into simple helper functions that hide the return value assignment, which in turn will simplify C parsing. Allows us to remove storing the mapped buffer ID in the params. Bug: angleproject:7731 Change-Id: I756574cc0fa3d63cce4e0103b8f2861d093de186 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3953335 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Christian Dullweber fba70715 2022-10-18T12:53:53 Revert "Make ANGLE's Worker Pool actually pool the threads." This reverts commit 0a4a7ea77661703e467293bc0f6d79c95061fa76. Reason for revert: Suspected to cause flakiness in angle_unittests on https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI?limit=200 Original change's description: > Make ANGLE's Worker Pool actually pool the threads. > > When starting a lot of short-lived tasks, this increases performance by > over 70 times on my machine. > > Old code, decoding a 16x16 ASTC texture with 8 threads: > *RESULT AstcDecoderPerfTest.cpu_time: run= 2,847,708 ns > *RESULT AstcDecoderPerfTest.wall_time: run= 1,841,014 ns > > New code: > *RESULT AstcDecoderPerfTest.cpu_time: run= 81,602 ns > *RESULT AstcDecoderPerfTest.wall_time: run= 27,088 ns > > Bug: angleproject:7757 > Change-Id: Ib643405675c50b2ed8ccd24d6caa7e57335130e1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3953905 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Greg Schlomoff <gregschlom@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7757 Change-Id: I35c721ca770b4a62aa135fd2f80ae597d7ea14fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963528 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Jamie Madill 4f85f862 2022-10-10T20:59:19 Capture/Replay: Remove references to uniform block indexes. This removes the references in captured traces to the uniform block index map. Because uniform block indexes use a double indirection, we store them in an unordered map. Moving to plain C precludes all uses for templated types, so we need to funnel the calls through a custom function. Bug: angleproject:7731 Change-Id: I35ae010b880ee669df09d750d5fb26d3baf907cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3953334 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi b521be4c 2022-10-14T23:09:26 Vulkan: Decouple shader-set from pipeline caches In preparation for VK_EXT_graphics_pipeline_library, where different pipeline caches (for the complete pipelines and the shaders subset partial pipelines) may create pipelines from the same shader set, the pipeline caches are pulled out of ShaderProgramHelper. In an upcoming change, ProgramExecutableVk will have more than one GraphicsPipelineCache instance, both creating pipelines through the same ShaderProgramHelper. The pipeline creation methods in ShaderProgramHelper are now const. This means a thread would be able to create pipelines using an object of this class while the main thread creates other pipelines using the same object, but in a different pipeline cache. Bug: angleproject:7369 Change-Id: Ib8a76dedf1105ba9dfcad9e972157c92ba18e349 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3956944 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 84156f59 2022-10-18T10:01:09 Roll SwiftShader from 4de33dcbca0e to 00b601d8ad24 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/4de33dcbca0e..00b601d8ad24 2022-10-17 capn@google.com Revert CTS bug workaround If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I3f71064320720ad90743a54c5b38a336942e9db0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3962891 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jiawei Shao e1da4916 2022-10-18T15:29:53 Remove unused enum CacheResult Bug: angleproject:2516 Change-Id: Ib2f4f66279ebb54e05b26559cf5759ca78020f03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3960887 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
angle-autoroll 7a4bdb0e 2022-10-18T07:00:32 Roll Chromium from 19bc4c33cb49 to 9ac79e275a41 (248 revisions) https://chromium.googlesource.com/chromium/src.git/+log/19bc4c33cb49..9ac79e275a41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/869280514d..2cf254f018 * buildtools/linux64: git_revision:b9c6c19be95a3863e02f00f1fe403b2502e345b6..git_revision:57c352b2b03461c24b19c678c61d7aeacc6981f4 * buildtools/mac: git_revision:b9c6c19be95a3863e02f00f1fe403b2502e345b6..git_revision:57c352b2b03461c24b19c678c61d7aeacc6981f4 * buildtools/win: git_revision:b9c6c19be95a3863e02f00f1fe403b2502e345b6..git_revision:57c352b2b03461c24b19c678c61d7aeacc6981f4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/516c2f5629..58b7594b44 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..98d333e8ae * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77e64ae61e..dbaca22bdf * third_party/fuchsia-sdk/sdk: version:10.20221017.1.1..version:10.20221017.2.1 * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/9215e8e1d0..5fd9246276 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f6889b3bff..0b8f559628 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I7215f9a0a288a77edf773d24d2644569a3ae92b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3960885 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gregg Tavares 968041b5 2022-08-19T12:11:23 Metal: Optimized BufferSubData per device Adds a staging buffer path which means there are 4 paths for bufferSubData. 1. direct copy * get a pointer to the buffer * copy the new data to the buffer * if the buffer is managed, tell metal which part was updated 2. use a shadow copy * copy the data to a shadow copy * copy the entire shadow to a new buffer * start using the new buffer 3. use a new buffer * get a new buffer (or unused) * put the new data in the new buffer * blit any unchanged data from the old buffer to the new buffer * start using the new buffer 4. use a staging buffer * get a staging buffer * put the new data in the staging buffer * blit from the staging buffer to the existing buffer. Further, there are 3 types of memory storage modes. Managed, Staged, Private. Based on the GPU type different storage modes and different paths in different sitatutions are more performant. So, add feature flags to select paths by GPU. Bug: angleproject:7544 Change-Id: I741dd1874201043416374194bd2001ded8dbd9b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3842641 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0