kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 8a5f2eeb 2025-05-14T07:00:19 Roll Chromium from b5121f275c34 to 6511b87fb086 (604 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b5121f275c34..6511b87fb086 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9c19bf6fd8..e42f899ae7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3d355ecb9a..e93dc3dea2 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/57733d6412..92623f3f80 * third_party/android_build_tools/error_prone/cipd: FLtgIzcLepAc87BaSXIELZIJPT4yxnr8K3MmFaEHrK8C..bd18Z8-1Y85m4C8xYA3z1J_VIhAaE2qRbkrBzn4_200C * third_party/android_build_tools/lint/cipd: QltgzNfGb4l4ekv1_GjIWtuew1hrBof1WVy2B8zrkYwC..7xZFl5M3w3LIJvhKsJYDQoTh5JZ3vr3I_-VWYXiGJC0C * third_party/android_build_tools/manifest_merger/cipd: hVPp69VTDru05sisN9HcrOf67Tk_Mhu6P6bsR24gOrEC..Ym1eWXywKFRvxsgK0yC4bFj9SwZViDqGEPb_w3mAKqMC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/83c00a37f4..fd624be2fa * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/14bfda1708..032eddc73b * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/5a49db9990..069652e9cb * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/2bd5f3cae1..8575f4ae4f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/a0ab545a0e..27ee073016 * third_party/r8/d8/cipd: bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC..QhYGRVpYYKZmt3f_Zb2HoJ9LIBEnWaeeLXRNei47Z30C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/f08dc30a2b..c523543cf4 * third_party/siso/cipd: git_revision:04b22e60e2aae70fa9d51141c91bf4554d8c5239..git_revision:30ea210712239b874febcadf661f118fc2c0f6d7 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/51ccf34f29..1af78910c3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/02e6512f6b..f7a506e700 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I17feded033b5b47aaabb550107e9dc73904d77cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6545203 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 82c75df3 2025-04-24T00:00:00 Fix GetDebugMessageLog validation Used the same validation for GetDebugMessageLog and GetDebugMessageLogKHR entry points; added tests. Simplified validation redirects for: - ObjectLabel and ObjectLabelKHR - GetObjectLabel and GetObjectLabelKHR - ObjectPtrLabel and ObjectPtrLabelKHR - GetObjectPtrLabel and GetObjectPtrLabelKHR Fixed: angleproject:417493213 Change-Id: Id1fad6c94db78da403e70f40f44630632d375472 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6543489 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 3bbdee0f 2025-03-28T11:55:24 Vulkan: Remove Subject/Observer from BufferImpl Right now the gl::Buffer back end send message to the front end and then gl::Buffer propagate the message to the observers (vertex array, textures, transform feedback). We are seeing many of these kind of message passing (mainly to vertexArray), and each message is a virtual function call. The message call also lacks of context information that we can not do certain optimizations. This CL adopts the new API feedback argument approach for buffer APIs from the back end to the front end. The only difficulty I ran into is D3D backend where the message could be delivered from draw calls. For now the subject/observer code path is still kept in the gl::Buffer, but no back end will use it except D3D11. That will be removed in the later CL when D3D11 switch to use feedback mechanism. BYPASS_LARGE_CHANGE_WARNING Bug: angleproject:400711938 Change-Id: I5fb3b660fd4260b9ba691239ad777b575b31e2ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6408892 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev e4ec23a0 2025-04-24T00:00:00 Fix query object support in EXT_debug_label The GL_EXT_debug_label extension must support labeling timer query objects created on ES 2.0 contexts even if the GL_EXT_occlusion_query_boolean is not supported. Expanded and fixed tests. Bug: angleproject:42263878 Change-Id: If05cf1b6879d44de1cc893ed45d1b877c963dac6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6539570 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 9ddb1b7f 2025-04-24T00:00:00 Disable OES_primitive_bounding_box on unsupported contexts The OES_primitive_bounding_box extension requires OpenGL ES 3.1 and must not be exposed on lower context versions. Also made both EXT and OES versions of this extension enableable. Bug: angleproject:42262238 Bug: angleproject:415495316 Change-Id: I5379daa06dba3b2b09d9656ffab15c010fb4870a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6538627 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten ed4d7278 2025-05-13T10:06:18 Tests: Skip VerifyMutableRenderBufferKHR on Intel+Win The test EGLSingleBufferTest.VerifyMutableRenderBufferKHR/ES*_Vulkan_NoFixture is failing on Intel+Windows and generating VVL errors. ERR: vk_renderer.cpp:968 (rx::vk::(anonymous namespace)::DebugUtilsMessenger): [ VUID-VkSwapchainCreateInfoKHR-presentMode-parameter ] vkCreateSwapchainKHR(): pCreateInfo->presentMode (VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR) requires the extensions VK_KHR_shared_presentable_image. The Vulkan spec states: presentMode must be a valid VkPresentModeKHR value (https://docs.vulkan.org/spec/latest/chapters/VK_KHR_surface/wsi.html#VUID-VkSwapchainCreateInfoKHR-presentMode-parameter) ..\..\src\tests\egl_tests\EGLSurfaceTest.cpp(2036): error: Value of: IsEGLDisplayExtensionEnabled(mDisplay, "EGL_KHR_mutable_render_buffer") Actual: false Expected: true It's not entirely clear where things are going wrong, but appears to be something in the Intel+Windows driver. Skip the test for now to keep win-exp-test green otherwise. Bug: b/417459061 Test: EGLSingleBufferTest.VerifyMutableRenderBufferKHR Change-Id: I3bc21dfa059b1c0d7c4e8f7ae0452a3819bedbb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6541387 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 333395f9 2025-05-13T08:48:38 Roll Chromium from 306f6953a911 to b5121f275c34 (626 revisions) https://chromium.googlesource.com/chromium/src.git/+log/306f6953a911..b5121f275c34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/92d42d9ad2..9c19bf6fd8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ab12b4b4c9..3d355ecb9a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/99e184abf0..57733d6412 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0c5acc073d..83c00a37f4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/977c37458f..14bfda1708 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/1efb5e6d7c..5a49db9990 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/09f6f7b168..2bd5f3cae1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/4a2940b40b..a0ab545a0e * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/e76f2f05fd..f08dc30a2b * third_party/turbine/cipd: scfGptWnO9bwzbg-jr0mcnVO3NG5KQJvlAQd_JSD5QUC..PbV7UFdzFIl6b_4lNwsj4VnlvnoULNAZRDwsndTGXTsC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/6f9b4e6192..86aca59d7b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/72f7346349..92a5f60019 * tools/luci-go: git_revision:4486e4bb411a38fa21ba426d9a89052402fe610f..git_revision:45d1c0a0168f06a2bbde9eca9a03087ed1da523e * tools/luci-go: git_revision:4486e4bb411a38fa21ba426d9a89052402fe610f..git_revision:45d1c0a0168f06a2bbde9eca9a03087ed1da523e * tools/luci-go: git_revision:4486e4bb411a38fa21ba426d9a89052402fe610f..git_revision:45d1c0a0168f06a2bbde9eca9a03087ed1da523e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a0f1169638..02e6512f6b * tools/skia_goldctl/linux: XvA_7L7EBxuteX50DCEOF09vFmi3j5JjHZllbUAhrH0C..bTGNxI6oWidGO0rn_gOIbBQco8hNmWt0yS6ARBqSjlsC * tools/skia_goldctl/mac_amd64: B4z1WT_C_-NfLkHKjxtinLyNC_b3B7r9N_OvGVWhrdsC..uq36HPTxtJXcSA6VRu488Anq19CjDz64IikQoKeegjIC * tools/skia_goldctl/mac_arm64: Nflk7_lewYF5S6u_5uI4QONIXSORkjmS_JxwgEX9mFEC..BpQkTzfhHyLozwZTFhy8nvc_t9VRDDXcaqdjQLA56bcC * tools/skia_goldctl/win: sIE9gbPbfWS2wFcKfjLYZuqk2QbRwaQetYWH8FlaHWkC..Qp03cZtVqA0CskUhi8g8_bciB5Nz1CHp4lpn0cprJWgC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Id1213b5550d62270b6aa31c4e7953ff9ab81fa38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6540346 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev bf837e01 2025-04-24T00:00:00 Disable EXT_multi_draw_indirect on unsupported context versions The EXT_multi_draw_indirect extension requires OpenGL ES 3.1 and must not be exposed on lower context versions. Bug: angleproject:42264951 Change-Id: I7afc4541268f62f58bba33637df74efba47218c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6533713 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu e2352b29 2025-05-12T10:55:39 Reformat VVL Error Message TraceTest.life_is_strange no longer runs into below VVL error: {"SYNC-HAZARD-READ-AFTER-WRITE", "type: VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, " "imageLayout: VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL", "usage: SYNC_FRAGMENT_SHADER_SHADER_"}, Remove the VVL error from the skipped message list. Bug: angleproject:42266180 Change-Id: Iddaea23b3afd8bb6238caa6aaadc49eb8469da51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6534653 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Geoff Lang a9115190 2025-05-12T12:22:42 Add a libGLESv2_thin_static without gl entry points. This static lib has the GL_X and EGL_X functions but not the glX. This saves some binary size and avoids multiply defined symbols with other implementations of GL when static linking. Bug: angleproject:40268378 Change-Id: I2f92388350786a5fcb4b7fa940cf328aacba5d93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6537086 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuxin Hu 40fde5ff 2025-05-09T11:56:28 Handle the action target in GN that has more than 1 python script If the action target requires more than 1 python script to complete the job, they all need to be listed under "tool_files" entry in Android.bp, so that the Android build system is able to place all of the files in the same sandbox, and thus avoids the problem of not able to find the python files needed. This change adds a helper function separate_py_files_from_bp_srcs_entry() that extracts the ".py" files out from "srcs" entry in Android.bp, and place them under "tool_files" entry. This change also adds the workaround to handle action args that have special prefix at the front of the file path. Bug: b/416750698 Change-Id: I6163d7d155fed61e205d69dd8eac37a9c38132ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6533857 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 481000fd 2025-04-30T16:42:39 WebGPU: Move pipeline creation to the C API. Bug: angleproject:414831373 Change-Id: I3c4f7d22bce569d9813a580fd1f3d839ff165976 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6503023 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang ce454fee 2025-04-30T15:24:34 Add RAII wrappers for WebGPU C API objects. To ease the transition, add constructors from the cpp wrappers currently in use. These will be deleted when we have fully moved to the C API. Update the WebGPU CommandBuffer code to use the new wrappers and C API. Bug: angleproject:414831373 Change-Id: I428349d84e1f79725eb836da5bb3d384ae296d75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6501618 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 4e09a4c8 2025-05-12T10:36:13 Roll vulkan-deps from 0b7863549d96 to 6b14cce1d656 (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0b7863549d96..6b14cce1d656 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/e8864edbebe9fb9872c6c95b2363b490c6105a15..feba06f44f682e17e0efcd412dff8de74a23d63a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/9c77de5c3dd216f28e407eec65ed9c0a296c1f74..75ad707a587e1469fb53a901b9b68fe9f6fbc11f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/fefd7ed96ef9994f0080dbd078822b07d8637918..a8bec310845ce80af5c00342243ae972cbe95e3b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/ba13d38d06830f714a93c5bb159e6e4bacacf0bc..60b640cb931814fcc6dabe4fc61f4738c56579f6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/be40e67892c83d4752ccfbee7ce690ea88087d2b..4f628210460c4df62029959cc7fb237ac75f7189 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/17cf8188d8b49bafb6c2f8ecede238f8d2dec5bf..21baa6bb2e0d5f4ae093397733f4534ea6e8cd6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ib7efd7f4fde5a12597859dd593b32cc5d48121f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6536013 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8aa29250 2025-05-12T07:00:57 Roll Chromium from ba1762590c1d to 306f6953a911 (681 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ba1762590c1d..306f6953a911 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f94ef0c502..92d42d9ad2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e25936882c..ab12b4b4c9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/168822b896..0c5acc073d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a7571b1596..977c37458f * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/7ff13dd8c6..1efb5e6d7c * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/81e2cb40a7..09f6f7b168 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/61d7ed3011..4a2940b40b * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/19b5cf7b96..49f482cb46 * third_party/r8/cipd: UDiEQW04Q7U0lSlAQAik0xbIV-AdjAnCHl7GcecroU4C..QhYGRVpYYKZmt3f_Zb2HoJ9LIBEnWaeeLXRNei47Z30C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/2869ca6369..e76f2f05fd * third_party/siso/cipd: git_revision:17b491ae74e86312a96239ff88e852acee83c135..git_revision:04b22e60e2aae70fa9d51141c91bf4554d8c5239 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/16737cc91b..51ccf34f29 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c23fee0adb..72f7346349 * tools/luci-go: git_revision:a9a10995e2889126ace91faf4052949e38c69d33..git_revision:4486e4bb411a38fa21ba426d9a89052402fe610f * tools/luci-go: git_revision:a9a10995e2889126ace91faf4052949e38c69d33..git_revision:4486e4bb411a38fa21ba426d9a89052402fe610f * tools/luci-go: git_revision:a9a10995e2889126ace91faf4052949e38c69d33..git_revision:4486e4bb411a38fa21ba426d9a89052402fe610f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0a94e361be..a0f1169638 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/2ca952fc10..96def2f44c * tools/skia_goldctl/linux: KN2IwZqaE82rq6fqVp3hdruYYJ84LUBLgOVTQRAGtOgC..XvA_7L7EBxuteX50DCEOF09vFmi3j5JjHZllbUAhrH0C * tools/skia_goldctl/mac_amd64: xo66yxZ-zTgqRnY5597wSJpk-3BX2OpElqzYg032slAC..B4z1WT_C_-NfLkHKjxtinLyNC_b3B7r9N_OvGVWhrdsC * tools/skia_goldctl/mac_arm64: ujgOeYoS5cTXHy9h7j_PSg7YsGl9q9TmvkhaM22_Uh4C..Nflk7_lewYF5S6u_5uI4QONIXSORkjmS_JxwgEX9mFEC * tools/skia_goldctl/win: LLNTOh1PJ9ZXVrdmwgWAf0KYOgZgQhfgaldCTjmg1c0C..sIE9gbPbfWS2wFcKfjLYZuqk2QbRwaQetYWH8FlaHWkC Clang version changed llvmorg-21-init-10851-gcd6c4b61:llvmorg-21-init-9266-g09006611 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/c23fee0adb246c81027f94c01eb5894359ce8a9e..72f7346349fe57ce261418ed7ec310706dfd6715/scripts/update.py Bug: None Tbr: ynovikov@google.com Change-Id: Ia9ee953272f5c0195df9d9ae694b19c69a6ae9ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6536011 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu db33baf4 2025-05-09T14:13:08 Reformat VVL Error Message life_is_strange no longer runs into the SYNC-HAZARD-WRITE-AFTER-READ VVL error it used to, remove the VVL from the skipped VVL entries. The trace does run into another VVL error on Linux AMD GPU, update the comment. Bug: angleproject:42266180 Change-Id: I6010ca1540e1d8774992173c853b904c0b3bd117 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6534138 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 73dabb85 2025-04-29T12:39:12 Add end2end test for AdvancedSyncVertexArray This is just a port of the upstream test: KHR-GLES31.core.shader_image_load_store.advanced-sync-vertexArray Test: ComputeShaderTest.AdvancedSyncVertexArray Bug: b/416573908 Change-Id: Id04af0a7efa667b7afc8061a9ccaa044e709fe1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6496293 Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Charlie Lao 506f8a95 2025-05-08T17:03:30 Vulkan: Fix incorrect shaderWrite to shaderWrite detection There is an optimization we added in https://chromium-review.googlesource.com/c/angle/angle/+/5719258 that avoids inserting WAW barrier in between two back to back shaderWrite to the buffer, unless it is app introduced barrier via glMemoryBarrier call (i.e, it is app's responsibility to issue such WAW barrier instead of ANGLE). There is a bug in that logic that if there is a vertex read in between two shaderWrite, we will incorrectly treat it like two shaderWrites. That caused we skipped WAR before the second shaderWrite. This CL fix the logic by also looking at read access on the buffer. Bug: angleproject:350994515 Bug: angleproject:416573908 Change-Id: I5bbbeff4d7222a644d1c994bffda7fd9ea292c17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6526949 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Junji Watanabe 214b7ce2 2025-05-09T11:35:31 Remove --use-reclient flag from capture_replay_tests.py The flag isn't used anymore. Bug: b/401959048 Change-Id: I6bedc9fcb2c5a5ed152b3da4bcbce0ba4785c883 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6528770 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang a3f6a9c8 2025-05-05T10:16:53 WebGPU: Don't call destroy on null textures .Destroy requires a valid texture. Bug: angleproject:414831373 Change-Id: I9d586f38a3f1b910b4c14552d3c9a6b43b4a5e22 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6512850 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cody Northrop 2f1f9568 2025-05-08T12:37:57 Tests: Run respawnables trace on S24 Xclipse native driver Their "native" driver is actually ANGLE. Bug: angleproject:42266627 Change-Id: I53795925219f0be42fbfcb059ce45575f5a98034 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6526326 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Alexey Knyazev d221cf40 2025-04-24T00:00:00 Adjust EXT_base_instance emulation conditions * EXT_base_instance may be emulated only on the GL backend. Other backends either support it directly or do not support at all. * EXT_base_instance is never exposed to WebGL. Bug: angleproject:355645824 Change-Id: I1edea83d83b1e6865eee8022c7110b05ea37d989 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6527730 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 60d6c94f 2025-04-24T00:00:00 Metal: Implement draw_elements_base_vertex extensions Fixed: angleproject:40096829 Change-Id: I288a38fbfa6a39cd9d683302722ebfaf495ba8db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6527729 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll af4c3f9a 2025-05-09T07:02:43 Roll Chromium from 21c94bee8dab to ba1762590c1d (560 revisions) https://chromium.googlesource.com/chromium/src.git/+log/21c94bee8dab..ba1762590c1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0f007e912b..f94ef0c502 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a5a99e2670..e25936882c * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/0f15c850a7..99e184abf0 * third_party/android_build_tools/lint/cipd: 2fKjMen4v_UU1CDYJqhwJCr6uh-L5w25n9lAKx6SlP0C..QltgzNfGb4l4ekv1_GjIWtuew1hrBof1WVy2B8zrkYwC * third_party/android_build_tools/manifest_merger/cipd: GnPGgBK8kiq32GuJB3iI20yJbFjgt2dqHsmwoPShJ-4C..hVPp69VTDru05sisN9HcrOf67Tk_Mhu6P6bsR24gOrEC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e1e4e9d96d..168822b896 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fab0a4296b..a7571b1596 * third_party/fuchsia-sdk/sdk: version:27.20250501.3.1..version:28.20250508.3.1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/e3e030ec6e..61d7ed3011 * third_party/r8/cipd: Is-oa6b7OQ1cVHjvG42iz-Lha-F3MBxBBIyC_eTMTg4C..UDiEQW04Q7U0lSlAQAik0xbIV-AdjAnCHl7GcecroU4C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/dbd65a5556..2869ca6369 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b0d4ef0639..16737cc91b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7fdd6c5778..a6bddebe3e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/346b3e98f1..0a94e361be * tools/skia_goldctl/linux: srGbc-O6bVQmBoT6VLvP66h6Be4A-nffx4UhixUJ9w0C..KN2IwZqaE82rq6fqVp3hdruYYJ84LUBLgOVTQRAGtOgC * tools/skia_goldctl/mac_amd64: tZvHxy8AcDJhO9A-5UuZKL_-5vfE_wC-RBkElqWZpM4C..xo66yxZ-zTgqRnY5597wSJpk-3BX2OpElqzYg032slAC * tools/skia_goldctl/mac_arm64: 2br8hIWKHDAaOt77siYyRUclHBYUZX6dj8jtogL90nwC..ujgOeYoS5cTXHy9h7j_PSg7YsGl9q9TmvkhaM22_Uh4C * tools/skia_goldctl/win: zasiUhQIHGZ2e60_M6g41oz8mYgPta5JmOWV5LwFjGMC..LLNTOh1PJ9ZXVrdmwgWAf0KYOgZgQhfgaldCTjmg1c0C No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Iebdf65706f35ac706e5af96264d7cd3f54be02b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6530161 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu b729fb74 2025-05-08T11:35:46 Reformat VVL Error Message Test Texture2DTest.UploadThenVSThenNewRPThenFS/ES2_Vulkan no longer runs into the VVL error. Remove the VVL error from the skipped VVL message list. Bug: angleproject:42265925 Change-Id: I5d854b8b091847f136c8e57620f8dd8c72d59503 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6525049 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 16b2bf5e 2025-05-06T16:23:24 Vulkan: Only expose ASTC HDR if 3D textures supported Not all hardware supports ASTC HDR for 3D textures. This CL adds a check for each ASTC HDR format, querying the driver for 3D support, and tracking it as a feature. We use that feature when deciding to expose GL_KHR_texture_compression_astc_hdr. Test: dEQP-GLES31.functional.copy_image.compressed.viewclass_astc_8x8_rgba Bug: b/407634958, b/416095435 Change-Id: Iaa6f26e247c7e6c7451f3d4eb8dd7175509bf45f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6515816 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 51dd4087 2025-04-24T00:00:00 Autogen support checks for draw_elements_base_vertex commands Also fixed command support conditions: * With an exception of MultiDrawElementsBaseVertexEXT, command and extension suffixes must match. Updated tests to account for that. * DrawElementsInstancedBaseVertex{EXT,OES} additionally require ES 3.0 or any of the instancing extensions. * DrawRangeElementsBaseVertex{EXT,OES} additionally require ES 3.0. Updated tests to account for that. * MultiDrawElementsBaseVertexEXT additionally requires GL_EXT_multi_draw_arrays. Bug: angleproject:409484297 Change-Id: I50b72ebc7d66128bcfd5671334094b7e90cb329c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6524686 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Geoff Lang 00845fd6 2025-05-06T14:13:18 WebGPU: Do not reuse windows with multiple surfaces Multiple Dawn backends do not handle re-creating a surface for a native window. Instead of working around this by caching in the display, rework our test runner to recreate the OS window and surface instead of just the surface. Release all resources in DisplayWgpu::Terminate. Otherwise they wont be deleted until the display is reinitialized or the test executable terminates. Bug: angleproject:342213844 Change-Id: Ic31264a5e646a54c988ef47ca664d8575fda94eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6515886 Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuxiang Qian 8c8f016a 2025-04-15T17:30:01 Remove part of releaseTexImageInternal in glGenerateMipmap In glGenerateMipmap, actually clearing the ImageDesc and releasing texImage in releaseTexImageInternal is not needed. The following implementation currently is skipped because getImageDesc would return empty ImageInfo. Remove those part and put the part of disconnecting the pbuffer from the texture after generating the mipmap. And end2end test is also added to verify the implementation. Bug: angleproject:410996562 Change-Id: I0d8ccd628b98aa5063df2688e9899319c32fd97d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6461524 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 86ce0f0e 2025-04-24T00:00:00 Add EXT_multi_draw_arrays stubs Bug: angleproject:414506477 Change-Id: Idc3ca950b88c9632268922ec7a311936916c2a43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6522405 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll c03307f4 2025-05-08T03:01:31 Roll SwiftShader from 093b4d82a49a to 930d46d31b5d (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/093b4d82a49a..930d46d31b5d 2025-05-07 aswolfers@google.com BGRA format support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I6a90c0159d61093739e6f32b613082ebe160f8b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6522580 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5b08297d 2025-05-08T10:01:42 Roll vulkan-deps from 645c800a7790 to 0b7863549d96 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/645c800a7790..0b7863549d96 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/a5b2bd69fa3ac07412666a3c3b0f4b2f67d056a1..6d0784e9f1ab92c17eeea94821b2465c14a52be9 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/8ede14d21b4c20658b69aa3cb23a451008db4066..e8864edbebe9fb9872c6c95b2363b490c6105a15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ia044e8186c33614b994ea3dd177e9df4b795a052 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6520914 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 30778d0d 2025-05-08T08:01:32 Roll VK-GL-CTS from b2b40c06daf9 to 73a2c954fb07 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b2b40c06daf9..73a2c954fb07 2025-05-07 dkoch@nvidia.com Update gen_framework.py to handle deprecation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I8fab88627a403395bf5df640311510b650363d0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6521374 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 02bc00c4 2025-05-08T07:01:40 Roll Chromium from 4d44e5915a7e to 21c94bee8dab (644 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4d44e5915a7e..21c94bee8dab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/27362bc37b..0f007e912b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4347ca8fd6..077a66f30f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c4492b5004..a5a99e2670 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/62420678f4..10e676cbfb * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/52ad7cf544..e1e4e9d96d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8c9aa83747..fab0a4296b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a9cc573e7c..a01c02c9d4 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/d7bdad4ef8..e3e030ec6e * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/ec84d8bc89..19b5cf7b96 * third_party/r8/cipd: sxgLKZyJNZMVi8cot5yvRzqCFQxX_HbbR0psaeto5RcC..Is-oa6b7OQ1cVHjvG42iz-Lha-F3MBxBBIyC_eTMTg4C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/b137202150..dbd65a5556 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/29026537c2..b0d4ef0639 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/28deefa8f1..7fdd6c5778 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/67947ca3cb..346b3e98f1 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I208b52eff6324cb7efd3b09b03d1195ea708f56a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6520905 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Junji Watanabe 57c64049 2025-05-01T11:20:45 infra: Switch bots from Reclient to Siso's builtin RBE client This CL stops using Reclient, and starts using Siso's RBE client to be aligned with Chromium's remote execution system. Bug: b/401959048 Change-Id: I3fe764013fc932f39087e5ec73f80fe5d5356686 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6502373 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Tim Van Patten 317f81db 2025-05-01T14:17:47 Fix EGL_RENDER_BUFFER query if EGL_SINGLE_BUFFER unsupported eglCreateWindowSurface() can have the EGL attribute EGL_RENDER_BUFFER specified: EGL_RENDER_BUFFER specifies which buffer should be used by default for client API rendering to the window, as described in section 2.2.2. If its value is EGL_SINGLE_BUFFER, then client APIs should render directly into the visible window. If its value is EGL_BACK_BUFFER, then all client APIs should render into the back buffer. The default value of EGL_RENDER_BUFFER is EGL_BACK_BUFFER. Client APIs may not be able to respect the requested rendering buffer. To determine the actual buffer that a context will render to by default, call eglQueryContext with attribute EGL_RENDER_BUFFER (see section 3.7.4). To support EGL_SINGLE_BUFFER, Vulkan surfaces must support the VkPresentModeKHR value VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR: VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR specifies that the presentation engine and application have concurrent access to a single image, which is referred to as a shared presentable image. The presentation engine is only required to update the current image after a new presentation request is received. Therefore the application must make a presentation request whenever an update is required. However, the presentation engine may update the current image at any point, meaning this mode may result in visible tearing. However, this is only available on Vulkan devices that support the extension VK_KHR_shared_presentable_image. Add checking in Surface::initialize() to update Surface::mRenderBuffer to EGL_BACK_BUFFER if the backend implementation does not support EGL_SINGLE_BUFFER. This includes adding supportsSingleRenderBuffer() to query the backend if it supports single render buffer mode, which defaults to False. The Vulkan backend overrides this and the result is based on support for VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR. Bug: b/412446258 Test: EGLLockSurface3Test.WindowMsaaSurfaceReadTest/ES2_Vulkan_NoFixture Test: EGLSingleBufferTest.VerifyMutableRenderBufferKHR/* Change-Id: I4e6d56f01a895a5bd887580e6ffa34d574c87fad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6506764 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 618bc398 2025-04-24T00:00:00 Add EXT_draw_instanced stubs Bug: angleproject:416241733 Change-Id: I6dfb0ff1e941fdd33387e06920c97ba4232e8820 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6519383 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev df8a7047 2025-04-24T00:00:00 Fix duplicate extension commands autogen If a command exists in two or more extensions with different suffixes but does not exist in any core version, ensured that the command declaration is added to context only once. Bug: angleproject:414506477 Change-Id: I22e5290bd9b89da8fb8dc01647d29cf67d864b8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6519422 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sunny Sachanandani 8ea69d84 2025-05-07T12:26:48 metal: Synchronize imported IOSurfaces with command buffer We want to skip the various Metal waitUntilScheduled calls in Chromium on single GPU systems and use only shared events for synchronization. However, this doesn't work correctly today because ANGLE can do CPU readbacks from the IOSurface without synchronizing with the command buffer which contains the shared event wait. This is because ANGLE doesn't know about the dependency between the IOSurface texture and the shared event wait in the command buffer. This CL makes BindTexImage mark the IOSurface texture as used so that we wait for command buffer execution if we do a CPU readback. It reuses the setWriteDependency mechanism on mtl::CommandBuffer. Bug: chromium:40273077 Change-Id: I5d480f2c28abbd6d36cf1e1045461c84b3e4a1f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6514098 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Andrew Grieve 35356d95 2025-05-06T12:27:32 Use a depfile rather than exec_script to list inputs for commit_id.py Bug: chromium:416002047 Change-Id: Ia7ddd4e5e8ff7cc1e88cce6542f62a314c8e6430 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6511928 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Andrew Grieve 1f0766be 2025-05-06T13:17:12 Don't use exec_script() to get versionCode when build_with_chromium Trying to make "gn gen" faster. Bug: chromium:416002047 Change-Id: I11de9118b29b7ba9d139239730f2e3a23b1dad0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6512333 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Mavis Deng 32f3f043 2025-04-28T16:15:15 Return GL_INVALID_ENUM for invalid target of CopyImageSubData From spec: INVALID_ENUM is generated if either srcTarget or dstTarget - is not RENDERBUFFER or a valid non-proxy texture target - is TEXTURE_BUFFER, or - is one of the cubemap face selectors described in table 3.17, if the target does not match the type of the object. Bug: angleproject:412524049 Change-Id: I2110223059db170e8882efc9666654d318b14ed3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6490614 Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Auto-Submit: Mavis Deng <mavis.deng@arm.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 8b388145 2025-04-24T00:00:00 Autogen support checks for robust client memory entry points No functional changes. Bug: angleproject:409484297 Change-Id: I9d27f8444b01b7881336ffcf3f480018efbe90e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6519381 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Neil Zhang d8ab156b 2025-04-18T10:57:14 Fix glValidateProgram() not work as spec According spec ValidateProgram should detect error: Any two active samplers in the set of active program objects are of different types, but refer to the same texture image unit. Bug: angleproject:414259791 Change-Id: I2ab503b745cffdfb8be1a1ad649432fd8a73f63d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6491669 Auto-Submit: Neil Zhang <Neil.Zhang@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 2d61c576 2025-04-24T00:00:00 Autogen support checks for PLS entry points No functional changes. Bug: angleproject:409484297 Change-Id: I0224ecc29efde87c92c75a8120d0227c95775c1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6512841 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6ffd0105 2025-05-07T10:01:39 Roll vulkan-deps from 82f44a3a6738 to 645c800a7790 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/82f44a3a6738..645c800a7790 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/3786ee89d584f5ba46f31dc5253e6dfaa222e5c1..a5b2bd69fa3ac07412666a3c3b0f4b2f67d056a1 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9693056da58c0deb658a9e5ada88a2cadc4153b4..8ede14d21b4c20658b69aa3cb23a451008db4066 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/c30213060ec65de75116c3f5e5334529a24cd8c8..fefd7ed96ef9994f0080dbd078822b07d8637918 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/441065f6fc75f2aff027432aa5aa96496dac3bdb..17cf8188d8b49bafb6c2f8ecede238f8d2dec5bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If5053131ebc9f6fc379bc0a8851bf2fb3cd6de22 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6519235 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8357b6a2 2025-05-07T07:48:55 Roll Chromium from a753f6d4bddd to 4d44e5915a7e (674 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a753f6d4bddd..4d44e5915a7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2021df387e..27362bc37b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b841ab22bc..4347ca8fd6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/de5f1c8085..c4492b5004 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/91f1a3775e..0f15c850a7 * third_party/android_build_tools/error_prone/cipd: 2t_u1XEjof609BQE4czlCQzEqRliKS_qY35FOu_VckgC..FLtgIzcLepAc87BaSXIELZIJPT4yxnr8K3MmFaEHrK8C * third_party/android_build_tools/lint/cipd: 0xqmMJ1qdP4NPN5s9VmWiNhchvNz_RLBrjXN4jUKN3gC..2fKjMen4v_UU1CDYJqhwJCr6uh-L5w25n9lAKx6SlP0C * third_party/android_build_tools/manifest_merger/cipd: 7lstFdOjh1bFmfSZ8le-aZ1a1COQtwirGzuEWa43tnUC..GnPGgBK8kiq32GuJB3iI20yJbFjgt2dqHsmwoPShJ-4C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f41d65050b..62420678f4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/417522f618..52ad7cf544 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/30d9438e7b..8c9aa83747 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a01c02c9d4..a9cc573e7c * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f2a7f2987f..7ff13dd8c6 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/c8248a038f..d7bdad4ef8 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d40011a810..ec84d8bc89 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/e4c4740810..b137202150 * third_party/siso/cipd: git_revision:70e1167e0e6dad10c8388cace8fd9d9376c43316..git_revision:17b491ae74e86312a96239ff88e852acee83c135 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/63e36d9dbf..29026537c2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/07beeffaa5..c23fee0adb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/860e5b256e..67947ca3cb * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/0fcd33e88f..2ca952fc10 Clang version changed llvmorg-21-init-10502-gb2e2ae87:llvmorg-21-init-10851-gcd6c4b61 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/07beeffaa5d293fc7a627de3bed0027d9ceffb5c..c23fee0adb246c81027f94c01eb5894359ce8a9e/scripts/update.py Bug: None Tbr: syoussefi@google.com Change-Id: I07404c1c9c093437a08afd304b0d36abc088c968 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6516596 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Robic Sun b373892b 2025-04-26T20:59:07 Add test using array of array varyings in tessellation shaders For per-vertex variables in the Tess shader that support two-dimensional arrays, when calling GetResourceName, the string-like tt[0][0] should be returned instead of tt[0]. Bug: angleproject:413447006 Change-Id: Iafd316495ca3c254f9424d84cab71c8385b11e03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6490616 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Robic Sun <Robic.Sun@arm.com>
Amirali Abdolrashidi 5c441a53 2025-05-06T13:00:32 Vulkan: Prefer MSRTSS for QCOM devices The feature flag `preferMSRTSSFlagByDefault` was originally added to avoid allocating extra memory if the images are created with the MSRTSS flag by default. If it is disabled, the image will be recreated with the said flag only if it bound to an MSRTT framebuffer. * preferMSRTSSFlagByDefault is now enabled for QCOM driver versions beyond 0777.0. Bug: b/329911999 Change-Id: Iea72f864eac5ecfa97b5c99de5bd66ef09c54c0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6516037 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu fcfc9760 2025-05-06T11:26:40 Reformat VVL error message The test VulkanPerformanceCounterTest_ES31.TextureSampleByDrawDispatchDraw no longer runs into the VVL error it used to have. Remove the VVL error from the skipped VVL error list. Bug: angleproject:42265504 Change-Id: I8eff929524b3e1bd015d96db2cc45b2c8f331170 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6514411 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Brian Sheedy 4cd5c9be 2025-05-05T14:45:34 Enable Mac/Intel experiment Enables the Mac/Intel experimental tester to test on Mac 15.4. Bug: chromium:414760990 Change-Id: I504a57f4ce81bcabecce50f17410f92ae572a5be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6514293 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Aurora Zhang 3cc099da 2025-03-20T16:47:46 Add tests for texelFetch with samplerExternalOES Add two tests to texelFetch in the vertex shader and fragment shader for YUV with samplerExternalOES. The fetch results are expected to be RGB value. Bug: angleproject:405149439 Change-Id: I0a5809b910ac61c678ab240aea8d303e0c9646e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6382116 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 7447e8ac 2025-05-06T10:33:47 Vulkan: Driver workarounds on Qualcomm Dynamic rendering is disabled on 512.800 due to crashes on some devices. Imageless framebuffers are disabled on 512.805, suspecting cause of crash on some other devices. Bug: chromium:415738891 Bug: chromium:415968761 Change-Id: I71f533c7954b628ce897ed1dac478aed119658e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6512663 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev 1c7fa5f8 2025-04-24T00:00:00 Add missing support checks to robust client memory entry points Ensured that implemented RobustANGLE entry points have the same command support checks as their base variants. * ReadnPixelsRobustANGLE requires OpenGL ES 3.2, or any of the robustness extensions. * GetQueryivRobustANGLE requires OpenGL ES 3.0 or any of the query extensions. * GetQueryObjectuivRobustANGLE requires OpenGL ES 3.0 or any of the query extensions. * GetInteger64vRobustANGLE requires OpenGL ES 3.0 or GL_EXT_disjoint_timer_query. * GetBufferParameteri64vRobustANGLE requires OpenGL ES 3.0. * TexImage3DRobustANGLE requires OpenGL ES 3.0 or GL_OES_texture_3D. * TexSubImage3DRobustANGLE requires OpenGL ES 3.0 or GL_OES_texture_3D. Bug: angleproject:410108264 Change-Id: I7bd4b07331a4eaee2b80232a7e54bd7370cee045 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6508731 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 9812b972 2025-03-05T16:25:45 PLS: Validate rendering feedback loops of PLS planes Validate that active textures are not bound as PLS planes in WebGL compatibility mode using the same validation as for regular framebuffer attachments. Update the PLS spec to not generate an error for feedback loops but update the definition of feedback loops to include PLS planes. The WebGL spec is dependent on this definition and makes this feedback loop an error. Bug: angleproject:40096838 Change-Id: I597efef3685da7bfb2a9d149a9ec3bc9d01e6e4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6330519 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Chris Dalton <chris@rive.app>
Alexey Knyazev 27cfdf8e 2025-04-24T00:00:00 PLS: Allow type conversions in state queries The OpenGL ES spec requires data conversions when a query command is issued that returns a data type different from the actual type of the requested state. * Updated PLS state queries to follow the main spec. * Removed PLS state query dependencies on interruptions. * Fixed non-robust command declarations in the extension spec. * Added missing extension support checks to robust commands. * Drive-by: Fixed invalid use of assertions in PLS tests. Fixed: angleproject:414361744 Fixed: angleproject:414506466 Change-Id: I573ab66d194d5666fd9c8845ac0ab262a714c5cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6507065 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 97445c56 2025-05-06T10:01:46 Roll vulkan-deps from 58ca0630c1c3 to 82f44a3a6738 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/58ca0630c1c3..82f44a3a6738 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/d5042689389ebb001fbcc6b606367f6e0836cabb..9693056da58c0deb658a9e5ada88a2cadc4153b4 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/b7947fe2d51e416666525c4d43a6e4398bb9f8a9..c30213060ec65de75116c3f5e5334529a24cd8c8 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/af3abdf3ec68a517e407c05f259cdadfd2b5cfe2..ba13d38d06830f714a93c5bb159e6e4bacacf0bc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/4e246c56ec5afb5ad66b9b04374d39ac04675c8e..be40e67892c83d4752ccfbee7ce690ea88087d2b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/c552e76e6cccababe0d19bc7b0b04be68541c44b..441065f6fc75f2aff027432aa5aa96496dac3bdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I29f820aacb95a309361310426ca082be5cbbd337 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6516212 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b80b87ab 2025-05-06T03:01:23 Roll SwiftShader from 9dd03f2e4b03 to 093b4d82a49a (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/9dd03f2e4b03..093b4d82a49a 2025-05-05 swiftshader.regress@gmail.com Regres: Update test lists @ 9dd03f2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I452f77d35a4567b5c629ef80df4efc0a28d98e62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6515444 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f5e2a67a 2025-05-06T07:01:41 Roll Chromium from 3ecef9588f01 to a753f6d4bddd (572 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3ecef9588f01..a753f6d4bddd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c386e235bb..2021df387e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f934b96202..b841ab22bc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9d653d0e2f..de5f1c8085 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/36bb88f9b3..f41d65050b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d66abd0ede..30d9438e7b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/629a8149c0..a01c02c9d4 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/e9d9246e8d..c8248a038f * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/1ded46a261..d40011a810 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/739d8d8784..860e5b256e No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Iaae4ef84736f79e17b58077d2a107ef6988751fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6515874 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll db13dbd5 2025-05-06T08:01:28 Roll VK-GL-CTS from eeeebaca3f2e to b2b40c06daf9 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/eeeebaca3f2e..b2b40c06daf9 2025-04-29 rgarcia@igalia.com Remove invalid lines in AndroidGen.bp and AndroidKhronosCTSGen.bp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I83a92274f27cf2fe232582961278e7823ee1cf05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6515986 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 3540a326 2025-05-05T16:47:30 Tests: Skip black_beacon trace on S24 Bug: angleproject:415852525 Change-Id: Ibf4d3f63e96da9cf43c34110654f9383f9ba82f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6512773 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuxin Hu c6e0448b 2025-05-05T10:49:32 Reformat VVL error message The SYNC-HAZARD-WRITE-AFTER-READ VVL error is no longer observed on TraceTest.special_forces_group_2, removed the error message from skipped VVL error list. The TraceTest.special_forces_group_2 now runs into a different SYNC-HAZARD-READ-AFTER-WRITE VVL error, on Linux AMD GPU. An existing entry in the skipped VVL error list already covers this error message. Reformat that entry by adding the extraProperties, and changing the messageContents1/messageContents2 fields to nullptr for ease of clean up later. Bug: angleproject:42264123 Bug: angleproject:397775556 Change-Id: I1681cd7f76dd2090e78584b08c25224d5b05d963 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6514289 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 2ca90dab 2025-05-02T22:38:38 Vulkan: Don't calculate vertex input state when dynamic When vertex input state is dynamic, VkGraphicsPipelineCreateInfo::pVertexInputeState can be nullptr. This change makes sure time is not wasted calculating this state at pipeline creation time. The change also ensures drivers don't rely on info provided at compile time by mistake. Bug: angleproject:42265637 Change-Id: I54da8be7769f0dd0767df6d7774baa956475bf8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6510082 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 95813607 2025-05-05T10:53:08 Manual roll VK-GL-CTS from dd7e71367795 to eeeebaca3f2e (10 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/dd7e71367795..eeeebaca3f2e 2025-04-25 mateusz.bahyrycz@mobica.com Multiple queue test runner 2025-04-25 lorenzo@khronosgroup.org Add missing mandatory features for VK_KHR_cooperative_matrix using auto-generation from XML 2025-04-25 piotr.byszewski@mobica.com Separate tests for gl_BaseVertexARB and gl_BaseInstanceARB 2025-04-25 piotr.byszewski@mobica.com Update spirv-tools and fix validation errors 2025-04-25 kamil.goras@mobica.com Add OpenGL tests for textureQueryLod 2025-04-25 rgarcia@igalia.com Force position-independent code in vulkan-video-samples 2025-04-25 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2 into vk-gl-cts/main 2025-04-23 michal.jakubek@mobica.com Fix "Linux link failures" on Windows build 2025-04-23 michal.jakubek@cognizant.com Linux compile failure when commenting out some test additions 2025-04-23 piotr.byszewski@mobica.com Remove temporary entries from Android*.bp files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I9d56381e80b6a89f307573ffc7f5c790c9ff4153 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6512791 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7d214a73 2025-05-05T15:16:20 Manual roll vulkan-deps from b9aab6c35f37 to 58ca0630c1c3 (72 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/b9aab6c35f37..58ca0630c1c3 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/fc9889c889561c5882e83819dcaffef5ed45529b..963588074b26326ff0426c8953c1235213309bdb https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/b3d30057b15273ce449bb9952e15e65b3f556723..47ee4dce39b5e8b594ed2e9c9cccd10342949683 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/bab63ff679c41eb75fc67dac76e1dc44426101e1..3786ee89d584f5ba46f31dc5253e6dfaa222e5c1 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/b6a83226d75d15b1733d35ee9e26b8f895ecffcb..d5042689389ebb001fbcc6b606367f6e0836cabb https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/409c16be502e39fe70dd6fe2d9ad4842ef2c9a53..9c77de5c3dd216f28e407eec65ed9c0a296c1f74 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/fb78607414e154c7a5c01b23177ba719c8a44909..b7947fe2d51e416666525c4d43a6e4398bb9f8a9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/0b8196724e4ad28cc7459b82a9b75f252c08cb3e..af3abdf3ec68a517e407c05f259cdadfd2b5cfe2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6530df51e0db74d50241c3a0f2c2798e99d0d9dd..c552e76e6cccababe0d19bc7b0b04be68541c44b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If1fbae100ff0ee09b85e5bede53cd6209470fe25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6511713 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 671f55d8 2025-04-03T22:54:44 Vulkan: Fix texelFetch(externalSampler) behavior GLES expects YUV decoding to happen with texelFetch when an external sampler is used, but texelFetch's translation (OpImageFetch) does not do such a thing. A transformation is added to replace that with a texture call at the right coordinate. Bug: angleproject:405149439 Change-Id: I3a8d07a6399705ec07718b38085ee4bc1ad2af6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6431570 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 33a585b8 2025-05-05T07:02:13 Roll Chromium from cf3a960742c3 to 3ecef9588f01 (1146 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cf3a960742c3..3ecef9588f01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/aaf578b4fc..c386e235bb * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6d4e129ac6..f934b96202 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/35b04da37d..9d653d0e2f * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/fe3242a8c8..3ed7629c86 * third_party/android_build_tools/lint/cipd: TEDRB0F7VgCgyepd8FsIxPRqvKjvWQ_YkLV-ybx-GQYC..0xqmMJ1qdP4NPN5s9VmWiNhchvNz_RLBrjXN4jUKN3gC * third_party/android_build_tools/manifest_merger/cipd: fPGWiT0LVG2_ifxOpHb5KNwTL-_7lb7tYOsB_ZoIiskC..7lstFdOjh1bFmfSZ8le-aZ1a1COQtwirGzuEWa43tnUC * third_party/android_build_tools/nullaway/cipd: F6la8NsEkr27_Sm2MswVDBDB7UXVqRtaCMS5YWEQ9dQC..mFkUqdlIqmMQ3rAaTHFmOBYjNFgFUQOmMlPG6PGgmHYC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/a86aaa9531..36bb88f9b3 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/f1b90bf3ad..96ee0e696e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1591e813b6..417522f618 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/354f6026f1..d66abd0ede * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/62724eb55f..629a8149c0 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/bf95cc5da6..e9d9246e8d * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/56b98941c7..1ded46a261 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/7c098b791b..e4c4740810 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e4c0da2094..63e36d9dbf * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5ae6e4bfb4..07beeffaa5 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e3589a5831..28deefa8f1 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/14089a7f57..cc38b4b04f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1a0049ce09..739d8d8784 * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/8ad6d21544..502dcad523 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/7e70cdf64e..0fcd33e88f Clang version changed llvmorg-21-init-9266-g09006611:llvmorg-21-init-10502-gb2e2ae87 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/5ae6e4bfb41f9bf57c91292e40abb4db3469dc67..07beeffaa5d293fc7a627de3bed0027d9ceffb5c/scripts/update.py Bug: None Tbr: syoussefi@google.com Change-Id: Ic32d77560c287256866506bf277f994637353f40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6511597 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Matthew Denton c60d98ce 2025-05-03T01:06:02 WGPU: Ship driver uniforms in the bind groups to the shader This writes driver uniforms to a WGPU buffer and ships that buffer to the shader. Right now this creates a new buffer every time a driver uniform changes. Bug: angleproject:389145696 Change-Id: Icfbce4d995ef593e703a597bb96e72173ec29cda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6477136 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Gavin Mak 7fe53b3c 2025-05-02T09:15:15 Remove --no_auth from download_from_google_storage hooks The flag was deprecated by https://crrev.com/c/6414748 and has no effect besides telling the user that it has no effect. Bug: chromium:414826937 Change-Id: I17e4ed6edca4dc97bd96db0a877bccfdfdfbb5f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6509445 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu ce795fa8 2025-04-28T15:31:25 Reformat VVL error message Set messageContents1 and messageContents2 fields to nullptr, for ease of clean-up in follow-up changes. Make the extra properties fields more specific. Bug: angleproject:42265363 Bug: angleproject:415382790 Bug: angleproject:415383266 Change-Id: I032bc82c6aeb16281c868778db827318fa833005 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6496650 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 18ec8824 2025-05-02T12:42:26 Vulkan: Exclude RADV from global cache preference * Added exception for AMD/RADV machines from the following flag: preferGlobalPipelineCache * (Due to no information regarding the effect of this flag on those platforms) Bug: b/411442610 Change-Id: Ifd9e2fe02e488d51cbb9e070106e86ac21e8533d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6509821 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 16e0dfd9 2025-03-20T10:59:26 Vulkan: Add feature flag to recycle VkEvent This CL adds a feature flag to enable/disable the VkEvent recycling. Given ARM prefers taking CPU overhead of creating and destroying VkEvent when last reference count to VkEvent goes away instead of the extra GPU overhead comes with vkCmdResetEvents, VkEvent recycling is disabled on ARM. Bug: angleproject:409441956 Change-Id: I288be6f7cfcbc4dd9c4701d20fba44349f25befc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6376784 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Junji Watanabe f6e1d4d7 2025-05-02T12:02:09 Fix include header case mismatches This CL fixes the include header names to be aligned with the actual file names. It's problematic for cross compile on Linux, where file system is case sensitive. Context: Goma/Reclient's deps scanner was able to handle those case mismatches. But, Siso's builtin remote execution doesn't resolve them automatically. Bug: b/401959048 Change-Id: I98282899e31ea801058f82d4cad770413634f4f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6508684 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll a8f49cfc 2025-05-02T03:01:13 Roll SwiftShader from fefba0024aa6 to 9dd03f2e4b03 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/fefba0024aa6..9dd03f2e4b03 2025-05-01 syoussefi@google.com Expose VK_EXT_extended_dynamic_state2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I93c68930cfa68ace971513e427a0e267ea0279b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6508755 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu d4c83ace 2025-04-30T12:05:19 Fix the test to use the right uniform location mTexture2DUniformLocation and mTextureCubeUniformLocation are uniform locations retrieved from the TextureCubeTest.mProgram. We should get the location from the shader program that the current test uses. Bug: angleproject:401546698 Change-Id: I7c5f022a9fab58572cae2e78fc328c1c0f74f977 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6502892 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Amirali Abdolrashidi a3b20796 2025-04-25T13:12:08 Vulkan: Add flag to prefer renderer pipeline cache * Added the following feature: preferGlobalPipelineCache * The renderer's pipeline cache will be used to create pipelines, including for warm-up. * mPipelineCache in the program is not saved when this flag is enabled. * Currently enabled for NVIDIA and AMD. * Impact on captured trace (w/ compiling inactive shaders) * Decrease in peak system memory usage on Windows/NVIDIA: * ~7600 MB -> ~3900 MB * Decrease in peak RES memory usage on Linux/NVIDIA: * ~7100 MB -> ~3600 MB Bug: b/411442610 Change-Id: I04929569f0f8d59a77c52505072faa0244ef1393 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6495155 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shashank Sharma 998b5693 2025-04-30T11:05:52 Fix ExternalBufferTest end2end test The application or test should be responsible for managing the lifetime of external buffer ensuring that the external buffer is not deleted as long as there are any GL buffer objects referring to it. https://registry.khronos.org/OpenGL/extensions/EXT/EXT_external_buffer.txt Bug: b/396231708 Change-Id: Ib8e7e2ef0349cadc42b839019e2b2334b4cc5085 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6502674 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Vasiliy Telezhnikov c52183bd 2025-04-11T11:17:10 Reset sample coverage after fbo change on Adreno Adreno drivers cache some internal value based number of samples in currently bound FBO and glSampleCoverage value, but doesn't update it on FBO change. So if we set sample coverage to 1 when FBO with 1 samples bound and then switch to FBO with 4 samples it behaves like coverage is 0.25 instead of 1. To avoid this, reset sample coverage after each FBO change. Bug: chromium:408364831 Change-Id: I7d5e36926e8568f4c652049b43ecdbe382ddc293 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6447878 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
angle-autoroll 6bdbe9cc 2025-05-01T12:33:41 Manual roll Chromium from dd275389e023 to cf3a960742c3 (1975 revisions) Use third_party/depot_tools/gn.py instead of gn to accommodate https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176 Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/dd275389e023..cf3a960742c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/88030b3203..aaf578b4fc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0f32cb9025..6d4e129ac6 * buildtools/linux64: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 * buildtools/mac: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 * buildtools/win: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe092931f1..35b04da37d * third_party/android_build_tools/error_prone/cipd: -IrkxgAkj3RxGNBPp6b4r9OWZC6_dTbI-jC3c3UPgq8C..2t_u1XEjof609BQE4czlCQzEqRliKS_qY35FOu_VckgC * third_party/android_build_tools/lint/cipd: gx4NrAApWUVG5HG3WJRIIzZrTssD6H5uGbKe0g77mucC..TEDRB0F7VgCgyepd8FsIxPRqvKjvWQ_YkLV-ybx-GQYC * third_party/android_build_tools/manifest_merger/cipd: HhXknpcPosMUDHZQD-8Ogve-HaG4HmJ4p082zKKAcnMC..fPGWiT0LVG2_ifxOpHb5KNwTL-_7lb7tYOsB_ZoIiskC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1ea2115b17..a86aaa9531 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/000f47cfa3..1591e813b6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1fcc527019..5982a1aeb3 * third_party/fuchsia-sdk/sdk: version:27.20250424.2.1..version:27.20250501.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/917609c669..62724eb55f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/912274164f..bf95cc5da6 * third_party/r8/cipd: bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC..sxgLKZyJNZMVi8cot5yvRzqCFQxX_HbbR0psaeto5RcC * third_party/r8/d8/cipd: 6qLey8EBp9ivhThnqVPWy2ZDGpsf5Y29EsTbi_rZ1pMC..bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/926ec54499..7c098b791b * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/1e85c01b15..6f9b4e6192 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/60443ebac3..e4c0da2094 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6c4f037a98..5ae6e4bfb4 * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:a9a10995e2889126ace91faf4052949e38c69d33 * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:a9a10995e2889126ace91faf4052949e38c69d33 * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:a9a10995e2889126ace91faf4052949e38c69d33 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b0c718c2d..e3589a5831 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9c8188cae9..1a0049ce09 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/fa679ed68e..7e70cdf64e * tools/skia_goldctl/linux: M9CSmdri8G3miQpGPQeqstBvQ3TtlngrsiF5GdSTYs0C..srGbc-O6bVQmBoT6VLvP66h6Be4A-nffx4UhixUJ9w0C * tools/skia_goldctl/mac_amd64: Txs7Izu5kRGbcoAc9qESynBnBHo8RdRIyim5zF9rWbgC..tZvHxy8AcDJhO9A-5UuZKL_-5vfE_wC-RBkElqWZpM4C * tools/skia_goldctl/mac_arm64: LTzU4UbKV4zw61tWyttEX62vyq7nErr2gD8-jiH8IhgC..2br8hIWKHDAaOt77siYyRUclHBYUZX6dj8jtogL90nwC * tools/skia_goldctl/win: UKiySjywM8juGVuMwWbOdaBXFD1TbzUOWcGGVTYfem0C..zasiUhQIHGZ2e60_M6g41oz8mYgPta5JmOWV5LwFjGMC No update to Clang. Bug: chromium:414330998 Change-Id: I5ce14c5574391c1dd638787c09789f0577ee26a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6503456 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 9bcfb38f 2025-04-30T23:12:19 Vulkan: Disable MSRTSS on buggy qualcomm drivers Bug: chromium:413427770 Change-Id: I62499c3aa04f3786a0deb6afcaafb7976f2a6446 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6501621 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya 3b77a177 2025-04-23T15:47:07 Optimize vertex attribute and buffer state change Bug: angleproject:386749841 Change-Id: I25968902282f6a201510e2ee17ea85fd71ef57c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6483915 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Yuly Novikov 432d1d1e 2025-04-30T12:56:18 Revert "Roll Chromium from dd275389e023 to 83180b816b9e (1315 revisions)" This reverts commit a4c8bf78eae845931343961ef92e2588227a7cb9. Reason for revert: linux builders broken by https://chromium-review.googlesource.com/c/chromium/src/+/6499312 Bug: None Original change's description: > Roll Chromium from dd275389e023 to 83180b816b9e (1315 revisions) > > https://chromium.googlesource.com/chromium/src.git/+log/dd275389e023..83180b816b9e > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/chromium-angle-autoroll > Please CC angle-team@google.com,geofflang@google.com on the revert to > ensure that a human > is aware of the problem. > > To file a bug in Chromium: > https://bugs.chromium.org/p/chromium/issues/entry > To file a bug in ANGLE: > https://bugs.chromium.org/p/angleproject/issues/entry > > To report a problem with the AutoRoller itself, please file a bug: > https://issues.skia.org/issues/new?component=1389291&template=1850622 > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md > > Changed dependencies > * build: https://chromium.googlesource.com/chromium/src/build.git/+log/88030b3203..a746c4fcb7 > * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0f32cb9025..2bf618c359 > * buildtools/linux64: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 > * buildtools/mac: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 > * buildtools/win: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 > * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe092931f1..3291a34ffb > * third_party/android_build_tools/error_prone/cipd: -IrkxgAkj3RxGNBPp6b4r9OWZC6_dTbI-jC3c3UPgq8C..2t_u1XEjof609BQE4czlCQzEqRliKS_qY35FOu_VckgC > * third_party/android_build_tools/lint/cipd: gx4NrAApWUVG5HG3WJRIIzZrTssD6H5uGbKe0g77mucC..TEDRB0F7VgCgyepd8FsIxPRqvKjvWQ_YkLV-ybx-GQYC > * third_party/android_build_tools/manifest_merger/cipd: HhXknpcPosMUDHZQD-8Ogve-HaG4HmJ4p082zKKAcnMC..fPGWiT0LVG2_ifxOpHb5KNwTL-_7lb7tYOsB_ZoIiskC > * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1ea2115b17..6177cd6532 > * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/000f47cfa3..083971e6b0 > * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/917609c669..62724eb55f > * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/912274164f..c43b02cfdb > * third_party/r8/d8/cipd: 6qLey8EBp9ivhThnqVPWy2ZDGpsf5Y29EsTbi_rZ1pMC..bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC > * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/926ec54499..110cb6df61 > * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/1e85c01b15..13aadd5859 > * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/60443ebac3..f73c955140 > * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6c4f037a98..5ae6e4bfb4 > * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:74734688ffc9d2807cda0d1dc7752197480de29e > * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:74734688ffc9d2807cda0d1dc7752197480de29e > * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:74734688ffc9d2807cda0d1dc7752197480de29e > * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b0c718c2d..f053b74423 > * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9c8188cae9..b08d2f11d8 > * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/fa679ed68e..7e70cdf64e > * tools/skia_goldctl/linux: M9CSmdri8G3miQpGPQeqstBvQ3TtlngrsiF5GdSTYs0C..k1BjOmyoXU04uWkPPdUJ0M5Lta0srcmKIzHJ2Drj5FUC > * tools/skia_goldctl/mac_amd64: Txs7Izu5kRGbcoAc9qESynBnBHo8RdRIyim5zF9rWbgC..Sql3pib8FeLV3AdnO-GPEkAXd1NeZc8m7_f0YWnV1h0C > * tools/skia_goldctl/mac_arm64: LTzU4UbKV4zw61tWyttEX62vyq7nErr2gD8-jiH8IhgC..J-0YzIpDw8ezG6JvHcbzOWvz79hJIj9oA_P8yyfA-WkC > * tools/skia_goldctl/win: UKiySjywM8juGVuMwWbOdaBXFD1TbzUOWcGGVTYfem0C..MISb1Ag5QQnBWhfkB8hBDYJRcEPDqzXrQrzBcSKUwx4C > No update to Clang. > > Bug: None > Tbr: geofflang@google.com > Change-Id: I4aa8e491e72d16c37037b8b1d42a3b501b706515 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6500074 > Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> > Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bug: None No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I2b206e6d177001e9381a8f1e45513d7aa9ccfc7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6494624 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Junji Watanabe e93c143a 2025-04-28T15:39:35 tests: Prepare capture_replay_tests for Siso migration - Adds --use_remoteexec as an alias of --use_reclient. - Adds --use_siso to add `use_siso=true` GN arg. - Changes the out dir to out_CaptureReplayTest, so that the build dir depth will be 2 for Siso remote execution rules. - Cleans up build dir when switching from Ninja to Siso. Bug: b/401959048 Change-Id: Id698644f16c161e86d1d1b42828281cb5fb690ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6489896 Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 128c9682 2025-04-24T00:00:00 Make GL_ANGLE_texture_rectangle non-toggleable This extension is not meant to be disabled. Bug: angleproject:40096622 Change-Id: Iea87210ab1bf3800759a3c65c566af67dada75f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6494384 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 1029195f 2025-04-30T03:01:07 Roll SwiftShader from 7905fa19e456 to fefba0024aa6 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/7905fa19e456..fefba0024aa6 2025-04-29 syoussefi@google.com Revert "Make Reactor buildable with LLVM 18" 2025-04-28 brunopitrus@hotmail.com Make Reactor buildable with LLVM 18 2025-04-28 swiftshader.regress@gmail.com Regres: Update test lists @ 7545980c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ic4abeea98614696d2fdd1dbdb77311267d4be4b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6500522 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a4c8bf78 2025-04-30T07:02:45 Roll Chromium from dd275389e023 to 83180b816b9e (1315 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dd275389e023..83180b816b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/88030b3203..a746c4fcb7 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0f32cb9025..2bf618c359 * buildtools/linux64: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 * buildtools/mac: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 * buildtools/win: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe092931f1..3291a34ffb * third_party/android_build_tools/error_prone/cipd: -IrkxgAkj3RxGNBPp6b4r9OWZC6_dTbI-jC3c3UPgq8C..2t_u1XEjof609BQE4czlCQzEqRliKS_qY35FOu_VckgC * third_party/android_build_tools/lint/cipd: gx4NrAApWUVG5HG3WJRIIzZrTssD6H5uGbKe0g77mucC..TEDRB0F7VgCgyepd8FsIxPRqvKjvWQ_YkLV-ybx-GQYC * third_party/android_build_tools/manifest_merger/cipd: HhXknpcPosMUDHZQD-8Ogve-HaG4HmJ4p082zKKAcnMC..fPGWiT0LVG2_ifxOpHb5KNwTL-_7lb7tYOsB_ZoIiskC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1ea2115b17..6177cd6532 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/000f47cfa3..083971e6b0 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/917609c669..62724eb55f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/912274164f..c43b02cfdb * third_party/r8/d8/cipd: 6qLey8EBp9ivhThnqVPWy2ZDGpsf5Y29EsTbi_rZ1pMC..bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/926ec54499..110cb6df61 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/1e85c01b15..13aadd5859 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/60443ebac3..f73c955140 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6c4f037a98..5ae6e4bfb4 * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:74734688ffc9d2807cda0d1dc7752197480de29e * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:74734688ffc9d2807cda0d1dc7752197480de29e * tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:74734688ffc9d2807cda0d1dc7752197480de29e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b0c718c2d..f053b74423 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9c8188cae9..b08d2f11d8 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/fa679ed68e..7e70cdf64e * tools/skia_goldctl/linux: M9CSmdri8G3miQpGPQeqstBvQ3TtlngrsiF5GdSTYs0C..k1BjOmyoXU04uWkPPdUJ0M5Lta0srcmKIzHJ2Drj5FUC * tools/skia_goldctl/mac_amd64: Txs7Izu5kRGbcoAc9qESynBnBHo8RdRIyim5zF9rWbgC..Sql3pib8FeLV3AdnO-GPEkAXd1NeZc8m7_f0YWnV1h0C * tools/skia_goldctl/mac_arm64: LTzU4UbKV4zw61tWyttEX62vyq7nErr2gD8-jiH8IhgC..J-0YzIpDw8ezG6JvHcbzOWvz79hJIj9oA_P8yyfA-WkC * tools/skia_goldctl/win: UKiySjywM8juGVuMwWbOdaBXFD1TbzUOWcGGVTYfem0C..MISb1Ag5QQnBWhfkB8hBDYJRcEPDqzXrQrzBcSKUwx4C No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I4aa8e491e72d16c37037b8b1d42a3b501b706515 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6500074 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Matthew Denton cac1e824 2025-04-29T18:27:36 WGSL: Output driver uniform and UBO structs This is the WGSL half of the change to implement driver uniforms. Driver uniforms are implemented as a UBO and reuse the default set of driver uniforms. User-provided UBOs don't yet have variables outputted for them. This requires moving MSL's ReduceInterfaceBlocks to the tree_ops dir in order to change interface block definitions into struct definitions. Bug: angleproject:389145696 Change-Id: I27f3837b3d115f2ffac66cc545f3b60ca9f01cb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6477564 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Matthew Denton 4b69ba93 2025-04-28T16:45:56 WGPU: upload texture bind groups and configured samplers GLSL samplers are split into separate sampler/texture variables in WGSL. Before this CL, the WGSL translator generated shaders that look like: @group(1) @binding(@@@@@@) var ANGLE_sampler_samp2D : sampler; @group(1) @binding(@@@@@@) var ANGLE_texture_samp2D : texture_2d<f32>; @group(1) @binding(@@@@@@) var ANGLE_sampler_sampCube : sampler; @group(1) @binding(@@@@@@) var ANGLE_texture_sampCube : texture_cube<f32>; This CL replaces those with actual binding numbers @group(1) @binding(0) var ANGLE_sampler_samp2D : sampler; @group(1) @binding(1) var ANGLE_texture_samp2D : texture_2d<f32>; ... Such that @binding(n*2) is the WGSL sampler variable corresponding to the n-th GLSL sampler and @binding(n*2+1) is the WGSL texture variable corresponding to the n-th GLSL sampler. This CL then generates binding group layouts matching the above, and uploads textures and configured samplers in bind groups. This makes some of the deqp_gles2 tests 2d texture tests pass, though some fail because they need a flipped y coordinate. Not yet supported: 1. arrays of samplers 2. shadow samplers 3. cube textures Bug: angleproject:389145696 Change-Id: I2ab18ae5ebb4d1289101266bd9451576aa04ce2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6382272 Reviewed-by: Liza Burakova <liza@chromium.org> Auto-Submit: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi c884460a 2025-04-24T16:43:04 Vulkan: Fix deferred clears vs noop multidraw Bug: chromium:407828338 Change-Id: I5da22aeb72605bb7943fa5ae079ae297d00888f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6488794 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 9e6f44bc 2025-04-18T00:00:00 Autogen support checks for extension entry points As a side effect, added missing support checks for the following extension entry points: - GL_ANGLE_memory_object_flags - TexStorageMemFlags2DMultisampleANGLE - TexStorageMemFlags3DANGLE - TexStorageMemFlags3DMultisampleANGLE - GL_EXT_buffer_storage - BufferStorageEXT - GL_EXT_external_buffer - BufferStorageExternalEXT - GL_EXT_robustness - GetnUniformfvEXT - GetnUniformivEXT - ReadnPixelsEXT - GL_EXT_separate_shader_objects - ProgramUniform4ivEXT - ProgramUniform4uivEXT - GL_MESA_framebuffer_flip_y - FramebufferParameteriMESA - GetFramebufferParameterivMESA - GL_OES_matrix_palette - CurrentPaletteMatrixOES - LoadPaletteFromModelViewMatrixOES - MatrixIndexPointerOES - WeightPointerOES - GL_OES_query_matrix - QueryMatrixxOES - GL_OES_texture_cube_map - GetTexGenf*OES - TexGen*OES - GL_QCOM_framebuffer_foveated - FramebufferFoveationConfigQCOM - FramebufferFoveationParametersQCOM - GL_QCOM_texture_foveated - TextureFoveationParametersQCOM Bug: angleproject:409484297 Change-Id: I7fe05afe2a4575ae5d913bf9f60d5575404f808b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6494399 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev f6da7aed 2025-04-18T00:00:00 Fix UniformTest.GetUniformNoCurrentProgram Added the extension check and the result re-initialization. Fixed: angleproject:414491366 Change-Id: I04abc847a7fd48c411e62208e88c19d9d3f6ec50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6494452 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev ae70513d 2025-04-18T00:00:00 Remove NamedBufferStorageExternalEXT entry point OpenGL ES does not support DSA. Bug: angleproject:407932145 Change-Id: If5f544de2b43e05888415a4fc805ad6065d4408b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6495409 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 846dcf86 2025-04-18T00:00:00 Autogen context version checks for 2.0 entry points Bug: angleproject:409484297 Change-Id: I03b323ba5b8f9d45d41c0ff0188b3f7a7004722e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6490226 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Brian Sheedy f75980ad 2025-04-24T13:18:27 Switch Mac builders to Chromium pools Switches Mac builders to use the builderless luci.chromium.gpu.ci and luci.chromium.gpu.try pools. Existing capacity in those pools looks to be sufficient for the ANGLE traffic, so the increased load should be fine for a bit until the ANGLE capacity can get merged into those pools. Bug: chromium:375244064 Change-Id: I36aa7fa621b8472e0146a4510fe8b2bd9df10d7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6489488 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 828bec45 2025-04-26T16:12:56 Vulkan: Fix SPIR-V gen for constant constructors ... inside non-constant constructors of different basic type. The SPIR-V generator proactively casts the elements of the inner constructor to the type of the outer constructor, but it was mistakenly using the original inner constructor's type id for the constant instead of the cast type id. Bug: chromium:413775106 Change-Id: I95e8b1dcc1ba36777eb4475042f0d106a6abe109 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6489041 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 7e1b79c7 2025-04-28T03:01:09 Roll SwiftShader from 0e75e7030ccb to 7905fa19e456 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/0e75e7030ccb..7905fa19e456 2025-04-28 syoussefi@google.com Add present fence nullptr check 2025-04-25 swiftshader.regress@gmail.com Regres: Update test lists @ 0e75e703 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I86af16437003d33d5ee07eb71683d478d5678b73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6493795 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6c450a6f 2025-04-28T07:02:53 Roll Chromium from 85dd9668972f to dd275389e023 (760 revisions) https://chromium.googlesource.com/chromium/src.git/+log/85dd9668972f..dd275389e023 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/712b388807..88030b3203 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/954d9cf09b..0f32cb9025 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d95491c360..fe092931f1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/bb79a34585..917609c669 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/6cc4c9c768..f2a7f2987f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/64a6b82928..912274164f * third_party/r8/cipd: OYELKv1Z-yH4xw9qL3QhIZ6orhoBStNNpyWKTNudpjsC..bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/3e6bb2cf9f..926ec54499 * third_party/siso/cipd: git_revision:9c851ca205f34cd18a79d06619bc464d0adbd8ce..git_revision:70e1167e0e6dad10c8388cace8fd9d9376c43316 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/3c6290c68e..1e85c01b15 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/8bee61ea5a..60443ebac3 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/03e88ec76c..6c4f037a98 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7f2e9ee78a..9c8188cae9 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/9f9ef552e3..fa679ed68e Clang version changed llvmorg-21-init-6681-g5b36835d:llvmorg-21-init-9266-g09006611 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/03e88ec76cae47d81daa0120878ed041be49fe51..6c4f037a983abf14a4c8bf00e44db73cdf330a97/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: I5d281c6a667c56833a95d2d187e591f9d38a3c28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6493788 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kenneth Russell cdb34025 2025-04-25T12:09:14 Move robust APIs for PLS into robust_client_memory sections. These two entry points are at the intersection of GL_ANGLE_shader_pixel_local_storage and GL_ANGLE_robust_client_memory. Move them into the robust_client_memory section to simplify autogenerated validation. Rerun code generation. Fixed: angleproject:413597061 Change-Id: Icac160dbc7ab4088ee90471af60bb2e5ab3e1b87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6492427 Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 50707ca6 2025-04-18T00:00:00 Remove duplicate validation declarations Removed redundant function declarations and aligned function definitions with the autogenerated declarations. Bug: angleproject:409484297 Change-Id: Ieb49399ff28e64c4e6a84180a3190895f3c08e20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6491475 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kenneth Russell 9f49ccaa 2025-04-25T18:01:01 Re-enable clang-format for ANGLE. This was disabled globally for Chromium third-party projects, but ANGLE's code generator requires it in order to keep producing well-formatted code. Add a config file to re-enable it. Fixed: angleproject:413695650 Change-Id: If00ce844e3c98fd973f5414204676b7df8a7e321 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6492321 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0