kc3-lang/angle

Log

Author Commit Date CI Message
Charlie Lao 8c317940 2025-01-16T17:51:12 Vulkan: Add feature flag to use VkEvent for buffer barriers Bug: angleproject:360274928 Change-Id: Ie6e48a0a57c016571a1e94c0105a231c749c76f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6180394 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 8c298ec9 2025-01-12T22:53:32 Vulkan: Use surfaceless queries with headless EGL configs Bug: angleproject:389342064 Change-Id: If5ec101f5ef5135febe3fe12d5c309fe2a35f07c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6169254 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Artem Kharytoniuk d7ea4b2c 2025-01-06T20:40:48 Vulkan: Use syncval extra properties for error suppression Bug: angleproject:391284743 Change-Id: I594a70e7d06f1d73647407dbac1afece666a7c5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6180310 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alex Dean d926d80d 2025-01-16T09:53:35 CL/VK: Fix enqueueFillImage & enqueueMapImage lock and waitlist Fix in enqueueFillImage and enqueueMapImage. Semantically should be using scoped lock and processWaitlist() instead of enqueueWaitForEvents(). Bug: angleproject:390387802 Change-Id: I86173a079aa7fdd54a8b7158ec8214147cfb7cd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6179619 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand b5c12605 2025-01-22T13:44:13 CL: Limit max work size/offset to UINT32_MAX Set a hard limit of UINT32_MAX on work item/offset for OpenCL's clEnqueueNDRangeKernel cmd for all backends (simplifies handling). Bug: angleproject:42267067 Change-Id: Ied1685609b3818e4c3a366a03770dc361198639c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191436 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Roman Lavrov adb52e06 2025-01-23T17:36:44 Avoid unnecessary copy ctor calls of gl::DepthStencilState That object has a user defined copy ctor to copy padding (https://crrev.com/c/783990). This together with copying instead of using a reference results in a function call (which just wraps memcpy) Bug: b/383305597 Change-Id: Ia92e726a887bd12ab14c1ca53f79c0b13b57a199 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194695 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 41225dc8 2025-01-24T02:01:17 Roll SwiftShader from 73053a0586b0 to a87fa39f6446 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/73053a0586b0..a87fa39f6446 2025-01-24 dneto@google.com tests/kokoro: use clang-format 13 2025-01-24 dneto@google.com tests/kokoro: use gcc 13 instead of gcc 9 2025-01-23 syoussefi@google.com Support VK_GOOGLE_surfaceless_query 2025-01-23 victorvianna@google.com [cpp23] Remove usage of std::aligned_storage/union<> in swiftshader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I5a5bb5bca6819bf57c562def1c3f275e15742aeb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6198020 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c51485be 2025-01-24T10:01:25 Roll vulkan-deps from dcf521eec97a to 1b571b5a7b3c (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/dcf521eec97a..1b571b5a7b3c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/22a33d6742e2edfcdab947179c073428b427be9c..bd1f1c263fc10969eb4a4b393e774a75ffcb2673 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/4aa537a5c6bef1fea7edea718a564bc0a1869450..e02275ec02b68e3d175528f768871c97ae9eee90 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/30169d29b89039700b9fd7d3d01f62f3e2641847..afad70fbb26c643b19cf53a5990852a4d83664b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I81b373f5ab340f134a08d140a61c0d3a8d82e985 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6196640 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 57eee4fa 2025-01-24T07:02:28 Roll Chromium from 098b675df0b0 to 67eb0a3b5a40 (601 revisions) https://chromium.googlesource.com/chromium/src.git/+log/098b675df0b0..67eb0a3b5a40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/962bdd52d3..e13953ced0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cd8c3f3a23..e0898cdec9 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3c28682788..5f29517d08 * third_party/android_build_tools/error_prone/cipd: Q3oiuVxuq1jkWhjfnfCSviXK8BbbB9n6_4jz3x_Mo3kC..DFqEkqm_CBBWylsmJnAMv2md7Kx6X9l3I3y8De6nmuAC * third_party/android_build_tools/manifest_merger/cipd: XR6gkuLVsVOJ1Ysmv0JCjHrWaTNjvh2a6EwSENxyrqsC..ESxV7cNgPg8y2RupSn5lYWBzQQMMK5Ai729X_Zhv_zwC * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/d430128984..16e8416791 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/49e10123de..8c858fc98c * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8205ccf0f2..7e0f3a8471 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/7fb16ccf18..b24bb82dd0 * third_party/r8/cipd: ZTHhAJg0CQvNxfBmE7mECwY-jJDQ7kknVwVvZpQzLLIC..3iC3eGx7wAPZJhIJjRdLvqyiJHhKFVT1Eq6-uccHw9oC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/179c871982..9d0d7c0c17 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/cd073aaae9..0d66cc525a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/facb7d1306..e262f0f889 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d7b110a48a..b3fef6ee99 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I856d7f1e5cbd18294801a544245d12d52377c536 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6196639 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 54b69688 2025-01-21T11:28:59 Vulkan: Add max memory allocation size limit check During memory allocation, we should make sure that the attempted allocation size does not exceed the maximum allowed size. Failure to do so may result in validation errors. * Added the following object to the renderer: mMaintenance3Properties * It holds the following device property: maxMemoryAllocationSize * Inline renderer function: getMaxMemoryAllocationSize() * Buffer and image allocation sizes will now be checked with the function above. * In case of exceeding the maximum allocation size, a device OOM error is returned after issuing a warning: * MemoryAllocationTracker::onExceedingMaxMemoryAllocationSize() * Removed the suppression for the test failing due to this issue. * Removed the maxMemoryAllocationSize VVL skip targeted for MockICD. * Suppressed tests on S22 that now fail due to exceeding this limit: * KHR-GLES[31/32].core.texture_buffer.texture_buffer_max_size Bug: angleproject:391002353 Change-Id: Id271066bd872c80344ef8531653afda3e6b40a93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187981 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao c3f9109e 2025-01-09T17:22:41 Vulkan: Change EventMaps from struct to class For better encapsulation, this CL turns struct EventMaps to class RefCountedEventArray. Bug: angleproject:360274928 Change-Id: Ie28996fdb95d5a830399e6fa6cd5602f403e8725 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6164698 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao c7ad15e3 2025-01-23T13:37:28 Vulkan: de-duplicate ImageHelper::barrierImpl and barrierImplOneOff barrierImpl is renamed to recordBarrierImpl barrierImplOneOff renamed to recordBarrierOneOffImpl barrierImpl contains all the common logic between recordBarrierImpl and recordBarrierOneOffImpl. Bug: angleproject:390443243 Change-Id: I01ce9ea3f1f0acb30fe0efcdd20bd1caaa248a7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6195570 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao fbd230f5 2025-01-23T12:59:06 Vulkan: Split ErrorContext into ErrorContext and Context ErrorContext continue to be context for error handling. vk::Context is added to serve as common base class for ContextVk and CLContextVk. Bug: angleproject:390443243 Change-Id: Ifac0b1d2d714ce610693ce60a35459c6c9cddf1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191438 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1250a7d9 2025-01-23T22:04:25 Manual roll vulkan-deps from e8b712767b9e to dcf521eec97a (52 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/e8b712767b9e..dcf521eec97a Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b5dc38707208efae0b7a1606790ca33d237d950e..22a33d6742e2edfcdab947179c073428b427be9c https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/4446967600048557909231722d2c92212b6ca258..3f129d076b44221b8b56a63215446d33b570ced8 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/b9d5ced92ac454caf526c3b80d5105a1f38878ce..4aa537a5c6bef1fea7edea718a564bc0a1869450 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/315964ad5aabd5b148a484e5fbea8a365c8d1eb3..8ce2501d2511b6f4e6389a03ff08c4e84d54fa25 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/7b23ba7a5f86936a8d783baf64a77c38977d6890..f07e27717a642fa193c967440f21ed634ea17987 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/1ce4b30307301d20d58040e088eb57c5ea8bb6ad..30169d29b89039700b9fd7d3d01f62f3e2641847 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Iccfe07746c3b344b5e5aa48653a9a5f90967f854 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6195571 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi c1214ec2 2025-01-22T14:22:56 Vulkan: Rename Context to ErrorContext In preparation for adding another Context (derived by GL and CL contexts), which includes logic that pertains to command recording (such as barrier tracking). Bug: angleproject:390443243 Change-Id: Idf495b62e63fb9aa901a2f16447fdaf3c2acd90b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191248 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 92cc4e02 2025-01-22T16:07:00 Vulkan: Fix incorrect initial RP layout for shared present Renderpass was using `ImageLayout::ColorWrite` as initial layout for the SharedPresent image. Vulkan validation did not detect errors because of limitations (or bug?): once command buffer with barrier is submitted, layers no longer track the current layout, and therefore skip the check. In other words, it seems like VVL only track layout transitions within a command buffer. Transition to `ImageLayout::SharedPresent` currently performed using one-off command buffer, which is always immediately submitted. This is the reason why VVL was ignoring the error for so long. Bug was discovered in `EGLSingleBufferTest.AcquireImageFromSwapImpl` during local testing, where one-off command buffer was replaced with outside RP commands. Other tests were still working fine, because they are using `glClear()` in the very first flush - no renderpass in the first submission, and so VVL can't track the layout once it is used in a renderpass in the second submission. Bug: angleproject:42262606 Change-Id: I19404b5be706e54e53890c2fec9cb4796296c698 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6182598 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Yuly Novikov 2d71b6b7 2025-01-23T16:56:02 Suppress dEQP failures on S22 dEQP-GLES31.functional.geometry_shading.instanced.geometry_output_different_32_invocations dEQP-GLES31.functional.geometry_shading.instanced.geometry_output_different_max_invocations KHR-GLES31.core.geometry_shader.primitive_counter.* KHR-GLES32.core.geometry_shader.primitive_counter.* Bug: angleproject:386749841 Change-Id: I41f399ab914d000d6b606170b6d191b61840eec8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194732 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Torne (Richard Coles) b2349dbf 2025-01-16T15:51:42 Sync third_party/android_system_sdk metadata with Chromium. ANGLE's DEPS currently reference the same version of the system SDK as the main Chromium repo but the README and OWNERS have lagged behind; copy the current version over from Chromium. Bug: chromium:378273193 Change-Id: I3709b4866ee96377a9e4a95ce2a6228261c9cdcf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6179719 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Richard (Torne) Coles <torne@chromium.org>
Austin Annestrand 55f421f6 2025-01-22T13:47:29 CL/VK: Add missing ArgumentWorkgroup case Missed nop-case when processing kernel resources during enqueueNDRangeKernel (avoids false-reporting of UNIMPLEMENTED during routine). Bug: angleproject:42267067 Change-Id: I0785ab94769fcb9b28ca0ff86d8104cc95056e5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191435 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 47bb7b7e 2025-01-23T02:01:28 Roll SwiftShader from b99f866d5a5c to 73053a0586b0 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/b99f866d5a5c..73053a0586b0 2025-01-22 ynovikov@chromium.org Fix Gerrit authentication If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I96bd9dd038d03cebfaca892f1694dd22f90b5533 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6193757 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 901010cd 2025-01-22T16:09:36 Update the submit access permission group Bug: b/389769530 Change-Id: Ic5fae18b55ccf750aa94779f90b5e959ec406a1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191473 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll fb7f19d8 2025-01-23T07:05:23 Roll Chromium from 3360895f5dfb to 098b675df0b0 (646 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3360895f5dfb..098b675df0b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8fe56cd1b6..962bdd52d3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/debf7b946c..cd8c3f3a23 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5cc19c9883..3c28682788 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9325732da8..6fba8f15dc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a4131b9447..49e10123de * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/a485ddbbb2..7fb16ccf18 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/a4e44a8e44..6f49850910 * third_party/r8/cipd: IeZEJCRJvyn60PrXJLIyw7cb3gwHgcMv3bxkNOh3jZYC..ZTHhAJg0CQvNxfBmE7mECwY-jJDQ7kknVwVvZpQzLLIC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/4029e38509..179c871982 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/99dfe10b67..cd073aaae9 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/594fb4f80b..facb7d1306 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bf624dc83c..d7b110a48a No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I1aa14fb4609d9a46826345fdd04b9a08098f79ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191635 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 40267ddc 2025-01-14T12:51:00 Vulkan: Add bufferWrite for multiple shader stages This is mostly a clean up CL. When a buffer is used in multiple shader stages, it was inserting barrier multiple times by calling bufferWrite in a loop. This creates unnecessary barrier against one shader stage to another shader stage. This CL adds a multiple shader stages version of bufferWrite that takes "const gl::ShaderBitSet &writeShaderStages" as an argument, in consistency to bufferRead. Otherwise this creates a problem in future CLs where we use VkEvent to track the write and you end up with WAW of the VkEvent that has not submitted. Bug: angleproject:360274928 Bug: angleproject:42262235 Change-Id: I923dc9df39318d337f67f4fa0f6a68f336df24f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6180948 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 51cdae04 2025-01-21T18:41:15 Update dEQP-GLES2.functional.shaders.random* test expectations Most tests have been fixed with the latest qualcomm drivers, except 1 test is still failing: dEQP-GLES2.functional.shaders.random.all_features.fragment.39. Bug: b/328156792 Bug: b/338287961 Change-Id: Ib2ff74c6ae7e9f39958617fb8d00b9b1f89878ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188697 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 0acd0a17 2025-01-21T18:31:32 Remove fixed dEQP-EGL.functional.*pbuffer tests from skip list These tests pass with latest ANGLE version d9c0aa4aff. Bug: b/330906568 Bug: b/328156792 Bug: b/332784194 Change-Id: Ib42fe3cfb22f3f7a1bd84609f927cc47613a4920 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188696 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 9867010e 2025-01-21T18:17:37 Remove fixed dEQP renderbuffer test from skipped test list Test passes with the latest ANGLE version d9c0aa4aff. Bug: b/328156792 Bug: b/333959262 Change-Id: I231feb43af69a1dab877fd3d3bd915b73d56d4b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187619 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu fd94ce5b 2025-01-21T18:05:41 Update the deqp blend equation advanced test expectations on qualcomm Some of the dEQP-GLES31.functional.blend_equation_advanced* tests are fixed by the latest qualcomm drivers. There are 9 remaining tests still failing. Update the expectation file with these 9 tests. Bug: b/328156792 Bug: b/345581214 Change-Id: I995b0f8a14d18f8ed4d1cdd27c334bdb09387d97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187617 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuxin Hu e5a4924e 2025-01-21T17:42:50 Remove fixed dEQP copy texture tests from skipped test list Tests passed with the latest qualcomm drivers. Bug: b/347306270 Bug: b/328156792 Change-Id: I8d6c0cb04d13635a91b0d774c56d8f3f72bc0e4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187616 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxiang Qian 308cfc62 2025-01-13T14:54:18 Do not reset buffer age after query The spec doesn't mention that we need to reset the buffer age if no rendering after last call of eglQuerySurface to query EGL_BUFFER_AGE_KHR. Age was also reset after first time of query. Remove it to align with spec. New end2end test is also added. Bug: angleproject:391039188 Change-Id: I00c96e3a71ea2c9abcb86ebaf520243408dedd52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6185135 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Dirk Pranke 072eec08 2025-01-21T13:09:44 Use `exec_script_allowlist` in GN now that it is available. This CL renames the gn dotfile variable `exec_script_whitelist` to `exec_script_allowlist`, in order to be more inclusive. Bug: chromium:40713186 Change-Id: Iaf5ef131a64f3189e675acfd090c7043c3138df8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188240 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Charlie Lao 1d25be59 2025-01-09T11:09:22 Vulkan: Pass Context instead of Renderer to BufferHelper APIs This is preparation CL for later CL. In later CL we need to access context argument in BufferHelper's barrier related functions. release() also preferred to have context argument so that the events can be recycled within share group. Because of this, a lot of functions has to propagate back to pass context as argument instead of renderer. Bug: angleproject:360274928 Change-Id: I13e930666eeeefbcff7b542d0e3126f3b07ce286 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6164686 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 680ff1f4 2025-01-22T19:17:40 Suppress flaky end2end test on Linux NVIDIA Vulkan ClearTextureEXTTestES31Renderable.Clear2DArray ClearTextureEXTTestES31Renderable.ClearCubeMap ClearTextureEXTTestES31Renderable.ClearCubeMapArray Bug: angleproject:362486580 Change-Id: I4254a4c28cb0b201d9e94511d5ddc8cce975d1c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6190629 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Yuly Novikov 4be68add 2025-01-22T18:24:24 Skip OcclusionQueriesTest.WrongSkippedQuery Fails on Win Intel UHD 770 Vulkan Bug: angleproject:388144480 Change-Id: Iee4bbae63991bb7d678bdd0777b45647322f3843 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191327 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov e029a2f2 2025-01-22T14:48:16 Fix llvm-libc README.chromium Bug: chromium:391452992 Change-Id: I0fdc64035a36067b146afb73cd1f684b4496909e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6189887 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
WeiCong Yu 90e3f6bd 2025-01-17T23:10:55 executable path has non-ASCII characters, metal not available On ARM64 MacOS 15.0.x, Metal Shader with newLibraryWithSource didn't work if the executable path contains non-ASCII characters. Bug: chromium:389559087 Change-Id: I0482c01e2a11973f56c712b36062ed78f3cecf9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6174286 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Igor Nazarov d8a95bf7 2024-12-19T17:35:05 Vulkan: Protect OneOff commands recording with pool mutex Bug: angleproject:384940864 Change-Id: I518c54ae4b0fc5da0e58d330f8c531bc8d65529e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108843 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 4237cca5 2025-01-22T07:35:51 Roll Chromium from f7e71ead6201 to 3360895f5dfb (583 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f7e71ead6201..3360895f5dfb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/07bda45dd1..8fe56cd1b6 * buildtools/reclient: re_client_version:0.174.0.d516e7c7-gomaip..re_client_version:0.175.0.98046de5-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8dfce7d0d7..debf7b946c * third_party/android_build_tools/lint/cipd: Tg-Mjqa6mWRSbiUa675M1IqGLmr236y3smiJ-Qdz5gkC..1veHvODGn5XZ5IcxP36LQZ16pvydqdtMVqfm4Bj3EFcC * third_party/android_build_tools/manifest_merger/cipd: yd6w2zQr48NAkrzrzEj2OmMzI-kANsmD6lvKhfXluAsC..XR6gkuLVsVOJ1Ysmv0JCjHrWaTNjvh2a6EwSENxyrqsC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/16be26db22..9325732da8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/40e4ea3b09..a4131b9447 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/12809bfa85..a485ddbbb2 * third_party/r8/cipd: DJU_YH-xmuJ4kRnli6eXC-q9Q21-GPFj4YVZyAqKSWoC..IeZEJCRJvyn60PrXJLIyw7cb3gwHgcMv3bxkNOh3jZYC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/668908cb48..4029e38509 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/8b8933b592..99dfe10b67 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b248a90291..bf624dc83c No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I9f4ff271488b1b3062868e2f15870017840dff5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188711 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 3734b432 2025-01-21T14:24:42 Suppress some clear tests on Linux/Intel/GL * Suppressed the following tests on Linux/Intel/OpenGL due to observed flakiness on the bots: * ClearTextureEXTTestES31Unrenderable.Clear3D * (ismatch in output values) * ClearTextureEXTTestES31Renderable.Clear2DArray * (FBO status is shown as incomplete) Bug: angleproject:384967031 Change-Id: I46e23e95619c6836b03edf6a52514b138f1542dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6182634 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Charlie Lao a5016e31 2025-01-17T17:50:27 Vulkan: Fix typos found by gerrit spellchecker Bug: angleproject:360274928 Change-Id: Idbffd7a4609f28d161bd0a11ace817856dcd750c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6182930 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 0afc3323 2025-01-21T12:46:28 Add fast path to ValidCap for most frequent cases glEnable/Disable are commonly called with the ones that are now on the fast path. GL_POLYGON_OFFSET_FILL seems slightly less common but still frequent enough to be inlined. This noticeably reduces the number of function calls in DO2 trace as well as branch predictor load (confirmed by cpu counter stats from a mobile device), and just this change appears to improve wall_time a bit. Bug: b/383305597 Change-Id: I8fa42de64d79f6638b312891f440d796dd95c57c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6184086 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov e06a8369 2025-01-21T14:56:09 Tests: fix IndexConversionPerfTest using unaligned offset Breaking Win perf bots since https://crrev.com/c/6151227 Bug: angleproject:385264236 Change-Id: I807b9823b5e1dfb12ec4ee7fe48d6addd568c224 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187621 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Neil Zhang 0554e7f0 2025-01-09T10:05:12 Vulkan: Resume render pass queries when render pass reactivates Bug: angleproject:388144480 Change-Id: Ibcf3b247f347705feed4aa43d237406ccb142704 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6185098 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Steven Noonan 801993bc 2025-01-18T21:48:41 handle Qualcomm's mixed vendor IDs This is a weird situation. Up until Qualcomm had a native Vulkan driver for Windows (with the Snapdragon X series chips), the only vendor ID observable on Windows was 0x4D4F4351. This was reported through DXGI, device manager, etc. But with their native Vulkan driver, they now report 0x5143 as well: VkPhysicalDeviceProperties: --------------------------- apiVersion = 1.3.295 (4206887) driverVersion = 0.807.0 (2150789120) vendorID = 0x5143 deviceID = 0x36334330 deviceType = PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU deviceName = Qualcomm(R) Adreno(TM) X1-85 GPU pipelineCacheUUID = 0eba4509-4351-0000-0000-010c05430000 And yet, DXGI still reports 0x4D4F4351. Cool, huh? Let's teach IsQualcomm to understand both vendor IDs to ensure the device is correctly detected as a tile-based renderer in the Vulkan backend. Bug: angleproject:390866623 Change-Id: I9170c30262ace269498f066e922a279c7e981de6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6183621 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net>
angle-autoroll 012d4353 2025-01-21T09:15:22 Roll Chromium from 367ef52f4b2b to f7e71ead6201 (386 revisions) https://chromium.googlesource.com/chromium/src.git/+log/367ef52f4b2b..f7e71ead6201 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/64e296c42a..07bda45dd1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e52ba4f90d..8dfce7d0d7 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3bc6350ea4..5cc19c9883 * third_party/android_build_tools/error_prone/cipd: 7c91BXn6VPvSmr-dFRYaNVkfHjRN1jdMIN4EcrPem9cC..Q3oiuVxuq1jkWhjfnfCSviXK8BbbB9n6_4jz3x_Mo3kC * third_party/android_build_tools/lint/cipd: _77LT8DN3c2A3RPC4ctJk-kOk2K_QEuS3_aQty7g384C..Tg-Mjqa6mWRSbiUa675M1IqGLmr236y3smiJ-Qdz5gkC * third_party/android_build_tools/manifest_merger/cipd: osgd04hyZB3eu5L7oiL6irk9AqRBX9lOxNLsaCmUCowC..yd6w2zQr48NAkrzrzEj2OmMzI-kANsmD6lvKhfXluAsC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b15611f18b..16be26db22 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/80d1969422..40e4ea3b09 * third_party/r8/cipd: PO3aHSPf_6XsPQhr5ej6sRCj8EXUTKutmhlFCLBeak4C..DJU_YH-xmuJ4kRnli6eXC-q9Q21-GPFj4YVZyAqKSWoC * third_party/r8/d8/cipd: U3Jf_ewWOZyxa6vyO3wjNIgm8XIz1yFk-4k3-wqDL44C..DJU_YH-xmuJ4kRnli6eXC-q9Q21-GPFj4YVZyAqKSWoC * third_party/siso/cipd: git_revision:0721be7440a7c67f8369fcce1ca01932638641bb..git_revision:6e20453c920920cade25e28fc443472eb22ddb41 * third_party/turbine/cipd: dz8pRLjwNlToJ0tS14T-TDQJNikmFXEDByMo-OzBbl0C..qNNUfaj7w4cSHTjVawVaZpq0pABVec9LcFebN19wm4EC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b9cb8f8d3e..8b8933b592 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f3f536fa16..594fb4f80b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1d1846688b..b248a90291 * tools/skia_goldctl/mac_amd64: i1pCGOButmwiJERJNRCcVJvvq5eJVXmgn6naqj5pIUwC..aGSV8FRvSVFoQndmtzdgxKhvRR5fHzqV4Out1xJ8IdQC No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I481e1b0915a65ada5c018bb3a64fac1eb1eee42f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6186864 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Xin Yuan c7cfbbc9 2025-01-20T22:31:42 Check if the GLES resources are bound to EGL image Per spec, The resource that will be used to create egl image must not itself be an EGLImage sibling, so validation for the resource in this case should be include. Bug: angleproject:388310036 Change-Id: I2b47e3de4f92beca7ff7a80383a7598c79fdedb0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6170833 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shashank Sharma 0c9ce8c7 2023-09-08T21:34:07 Trace-based testing app Modifying angle_trace_tests app to run traces automatically on invocation and dumps fps information. Also, compares the screenshot with the golden images if provided and dumps the histogram of image diff. Golden image naming format: <trace_name>_golden.png - Run traces - Capture screenshot - Record FPS value - Record image diff histogram Bug: b/270421213 Doc: doc/StandaloneBenchmark.md Change-Id: I42b8d229e1e358d48887f29f2424b9e771093ce9 Commit-Queue: Shashank Sharma <shawshanks@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6072349 Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shashank Sharma <shawshanks@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev a0e36ad5 2025-01-20T00:00:00 Vulkan: Fix image bindings for non-layered textures Layer index must be ignored if the texture does not have multiple layers or faces. Fixed: angleproject:344950165 Change-Id: I4b402ee28d365f0459f980e01488828c80c93527 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6185849 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi 8bf7d458 2025-01-20T09:37:25 Manual roll vulkan-deps from 476cafde9e9d to e8b712767b9e (8 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/476cafde9e9d..e8b712767b9e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/321692686b64873ccf4972754e36185697993e21..b9d5ced92ac454caf526c3b80d5105a1f38878ce https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/35a851d182cdebef408493b9a82ba212d1a2629c..1586f33d6d79eb9ffa5963ce4f70423986b95d8a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/2fe3a7791dc9c34a581dc45522ab9b4363b4f321..7b23ba7a5f86936a8d783baf64a77c38977d6890 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a80bafccd11d2b4e44dee21c530da49b41083682..1ce4b30307301d20d58040e088eb57c5ea8bb6ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I297016b55854913ceda6cc4afb80f67eafe65e26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6183654 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Igor Nazarov 16d8325f 2025-01-16T13:30:07 Vulkan: Make WindowSurfaceVk::setAutoRefreshEnabled thread safe Bug: angleproject:379762019 Change-Id: I20feb72c4777a8dbd2058ced8a958d08b6c218ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6175131 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Roman Lavrov 23ab7dbe 2025-01-17T14:18:32 Add likely and inline hints to getActiveLinkedProgram I noticed that getActiveLinkedProgramPPO gets inlined in some of the functions in Context.cpp, when we intended this to be a fallback path. Explicitly mark PPO as noinline and the base call as inline to minimize dependency on compiler heuristics (there seem to be differences in assembly between implicit and explicit inline). Bug: b/383305597 Change-Id: I2889a61efd4f653e842ce7089d54c51508a37491 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6180084 Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com>
angle-autoroll ed511a9c 2025-01-20T02:01:35 Roll SwiftShader from f6ad529e86e4 to b99f866d5a5c (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f6ad529e86e4..b99f866d5a5c 2025-01-18 swiftshader.regress@gmail.com Regres: Update test lists @ 64af4180 2025-01-17 swiftshader.regress@gmail.com Regres: Update test lists @ 5221bf03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I7122fe07f4c234a9e7ecb9d5bb8c25d0c9f03694 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6180942 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 12fec910 2025-01-20T08:01:52 Roll VK-GL-CTS from 962460e9975c to a9988483c086 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/962460e9975c..a9988483c086 2025-01-17 benjamin.cheng@amd.com Check min/maxCodedExtent for encode tests 2025-01-17 kamil.goras@mobica.com Limit size of elements to 5000 before resize of vector in AtomicCounterTest::checkPath. 2025-01-17 jasuarez@igalia.com Skip texture size promotion for unsupported snorm 2025-01-17 marcin.hajder@mobica.com Fixed negative enhanced layouts tests to prevent optimizing out some variables 2025-01-17 okuznetsov@google.com Limit max sub group size for vktSubgroupsBallotMasksTests to 64 2025-01-17 gleese@broadcom.com Update depth edge-case tests to be extension agnostic 2025-01-17 rgarcia@igalia.com Test pairing a frag shader with PrimitiveID with mesh and vert shaders 2025-01-17 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2025-01-14 elima@igalia.com Fix Android build issue caused by comparison of ints of different sign 2025-01-13 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2025-01-13 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I776361d4c636be481961ae7a339123a55d901fa1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6184845 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 51c42f17 2025-01-20T07:02:35 Roll Chromium from 40f789b3639f to 367ef52f4b2b (765 revisions) https://chromium.googlesource.com/chromium/src.git/+log/40f789b3639f..367ef52f4b2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/287333d912..64e296c42a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c61fa789bb..e52ba4f90d * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/ac0e58959c..567ad21ab4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea75de4c3b..80d1969422 * third_party/fuchsia-sdk/sdk: version:26.20250110.4.1..version:26.20250117.5.1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/4414ade7ba..12809bfa85 * third_party/r8/cipd: CqDcMSHb2wxXTFpn_KVnKoQSUN1HXWOqix19Kgv-oAYC..PO3aHSPf_6XsPQhr5ej6sRCj8EXUTKutmhlFCLBeak4C * third_party/siso/cipd: git_revision:67a8780a72f407b3dffe9e338c368f0b799d004b..git_revision:0721be7440a7c67f8369fcce1ca01932638641bb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/60ae4bee55..1d1846688b * tools/skia_goldctl/mac_amd64: aGSV8FRvSVFoQndmtzdgxKhvRR5fHzqV4Out1xJ8IdQC..i1pCGOButmwiJERJNRCcVJvvq5eJVXmgn6naqj5pIUwC No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I9782abbb13ffe5f0896a605f3bd4f95bbb386945 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6184844 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Aurora Zhang 0dabfe5a 2025-01-16T16:00:51 Tests: Supplement EXT_clear_texture tests * Added negative tests in ClearTextureEXTTest.Validation. * According to spec, divided format lists into color renderable and unrenderable two sets. * Bind the renderable format texture as a color attachment to test EXT_clear_texture. * Sample the unrenderable format texture then call glDraw to test EXT_clear_texture. Bug: angleproject:384967031 Change-Id: I71d77ef57772fbb5b174929e9ac2892e7dc3215f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108999 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Mohan Maiya aa6a9fae 2025-01-16T17:18:59 Vulkan: Selectively enable input attachment usage bit Add VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT iff supportsShaderFramebufferFetchDepthStencil feature is enabled. Also, add noncoherent qualifier in a few FramebufferFetchTest Bug: angleproject:352364582 Change-Id: I09c54a8d738b5cb4cbcf2716cdbff0c0ec9e31cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6181497 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Juston Li 615780e9 2025-01-16T10:50:26 Declare is_desktop_android when building w/o chromium Fixes skia angle build after is_desktop_android was introduced by: commit 3dc3de6225f927cf8e8495322fa201c167e84671 Author: Juston Li <justonli@google.com> Date: Wed Jan 8 16:02:30 2025 -0800 Disable gl backend for desktop android Bug: b/388074349 Change-Id: Id879c5005f1ff685453c8d06c9486541ac4fe5d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6180597 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Hans Wennborg 7ea03db1 2025-01-17T08:11:45 Revert "Suppress false-positive UBSan falures in rsgExpression.cpp" This reverts commit 49e7801b90f8820cc4aec188a2f001703acf2c29. Reason for revert: The UBSan false-positive was fixed by a subsequent Clang roll, see bug. Original change's description: > Suppress false-positive UBSan falures in rsgExpression.cpp > > A recent Clang roll introduced false-positives like > > runtime error: > load of address 0x7f9c4f3ae6c0 with insufficient space for an object > of type 'const IsConversionOkFunc' > (aka 'bool (*const)(ConstValueRangeAccess)') > > Suppress them until a fixed version of Clang has been rolled in. > > Bug: chromium:388039125 > Change-Id: I0823e52bb892feac519b123ae66716c3dc96f6b2 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149452 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: chromium:388039125 Change-Id: Ib8884c9a112e454f4fbb5e964d0192501e61c239 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6179805 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 6dc14ded 2025-01-17T11:25:34 Roll vulkan-deps from 8d2a13cc4374 to 476cafde9e9d (37 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8d2a13cc4374..476cafde9e9d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e43514866f7e0f8265c677039d2fe773c892d44b..b5dc38707208efae0b7a1606790ca33d237d950e https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/a380cd25433092dbce9a455a3feb1242138febee..2b2e05e088841c63c0b6fd4c9fb380d8688738d3 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9064fe8637daf9f694c8a2e035a34da94022f2be..321692686b64873ccf4972754e36185697993e21 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/d4a196d8c84e032d27f999adcea3075517c1c97f..a03d2f6d5753b365d704d58161825890baad0755 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/369f59ad598b60d6ed9f553af651c5cccd20234c..35a851d182cdebef408493b9a82ba212d1a2629c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/5a88b6042edb8f03eefc8de73bd73a899989373f..2fe3a7791dc9c34a581dc45522ab9b4363b4f321 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ea05bf71f2948d64f7d36651ffcad59216401095..a80bafccd11d2b4e44dee21c530da49b41083682 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I8da429f8817a31aa573acb6c39864db8e24b83e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6181014 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bf18d736 2025-01-17T07:59:55 Roll Chromium from 0c0e530859bb to 40f789b3639f (1161 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0c0e530859bb..40f789b3639f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ce61bc84f9..287333d912 * buildtools/reclient: re_client_version:0.172.0.3cf60ba5-gomaip..re_client_version:0.174.0.d516e7c7-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/86b5f23890..c61fa789bb * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9c3ff1b50b..3bc6350ea4 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/11efe26855..ac0e58959c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d25caed4b9..b15611f18b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a90906c74d..ea75de4c3b * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/d1e95b102f..e55d8cf51c * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/b90022fc6a..4414ade7ba * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/7938ad35f6..a4e44a8e44 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/860e334a80..f3f536fa16 * tools/luci-go: git_revision:320a8df0f7934159fda7721f3b507e707531d284..git_revision:e3703a4d1c29e8355653c19b59b0aa793a850956 * tools/luci-go: git_revision:320a8df0f7934159fda7721f3b507e707531d284..git_revision:e3703a4d1c29e8355653c19b59b0aa793a850956 * tools/luci-go: git_revision:320a8df0f7934159fda7721f3b507e707531d284..git_revision:e3703a4d1c29e8355653c19b59b0aa793a850956 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/87dc2b2656..60ae4bee55 * tools/skia_goldctl/linux: GkPik3ZR82JcwVHk-pBTePz2HPYzW8LateYL4h_d-bIC..1TplvrLyzA9FlWhQRWdX9SaTfuZaPdvQ9BMG0wNhy98C * tools/skia_goldctl/mac_amd64: j7rDa6kTN-TMvPfBmX1peSexyGPSajiQ5st1zCqBrEYC..aGSV8FRvSVFoQndmtzdgxKhvRR5fHzqV4Out1xJ8IdQC * tools/skia_goldctl/mac_arm64: BD_Os35akIixtA0Ooa6coXpJ4hjQUVHonW0WJTsPfWAC..J_hsft9STSA1c91EbHgGONUGi_KYtolnyIbXIM_1ps8C * tools/skia_goldctl/win: ByYUybN8CyRSJhmE5wfxU9m1DBFbhBX5-F5M0Cuk84YC..iu7P4Y4eMVlvfq6mCvSlP12RQuqVdmIjndnnxIbxy4IC * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/e684d85901..aa44e7637f No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I6e577ad2a02bf98f019d7b7cf3c790e8be049c19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6181491 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov 6793c5ee 2025-01-16T13:46:48 Vulkan: Simplify WindowSurfaceVk::mMinImageCount tracking `mMinImageCount` is updated in the `WindowSurfaceVk::createSwapChain()` method when "VK_EXT_surface_maintenance1" is enabled, which makes updates outside of this method irrelevant. This CL removes all these updates and makes update in `createSwapChain()` unconditional. The `mMinImageCount` is now only accessed in the `checkForOutOfDateSwapchain()` method outside of the `createSwapChain()` method (without this check `mMinImageCount` might be a local variable). Shared present mode and "forceContinuousRefreshOnSharedPresent" handling is moved just before swapchain creation to properly handle cases when "VK_EXT_surface_maintenance1" is disabled. Bug: b/289274676 Change-Id: I963eab2dfbbb3ebf563183c47167cfd4b60e2f38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6175130 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shufen Ma fc33f0a0 2025-01-15T11:23:25 Add a ReadPixels test for offset alignment check An INVALID_OPERATION error is generated if a pixel pack buffer object is bound and data is not evenly divisible by the number of basic machine units needed to store in memory the corresponding GL data type from table 8.4 for the type parameter. Add a test for this. Bug: angleproject:352963094 Change-Id: I81eda446df5ff29da1326a1f75f5d5aa0825aafd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6170763 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov ab7457db 2025-01-14T11:55:06 Move ResourceMap mHashedResources access to functions Follow up to https://crrev.com/c/6169263 https://chromium-review.googlesource.com/c/angle/angle/+/6169263/comment/43a79fa6_2a24673c/ Moves mHashedResources access out to function calls as this is a fallback that is supposed to be hit very rarely. This makes the likely branch (flat map accessors/modifiers) smaller so they can be easily inlined without adding much bloat. I also moved flat map resize to a function call as it is fairly rare and makes calls and malloc. This further reduces aarch64 .so size by ~12KB (0.2%) and hopefully improves locality a bit (perf tests inconclusive) Also inline Sampler access in ResourceManager which now uses these small inline accessors. Bug: b/383305597 Change-Id: I013eeb27bf619cc9549a977ab92173e799a1466a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6174944 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alex Dean 59ae5b97 2025-01-02T10:50:42 CL: Enable cl_khr_3d_image_writes OpenCL C has __opencl_c_3d_image_writes feature and CL Runtime in ANGLE has image formats supporting 3d image write. Tests-Passing: OCLCTS.consistency_3d_image_writes Bug: angleproject:387234392 Change-Id: Ibb3712845ddddd33f0d770129c9b203d19658e19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6137931 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alex Dean 810c19fa 2025-01-02T15:19:51 CL/VK: NonSemanticClspvReflectionArgumentPodUniform support Missing NonSemanticClspvReflectionArgumentPodUniform support, which gets used when the number of POD arguments exceed the limit of the maximum amount of push constants that can be used. Bug: angleproject:384549637 Change-Id: Ia0e2ea141cfb2c41c492ff4b125a1547c380c1cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6097413 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Takuto Ikuta 0ac0ca36 2025-01-16T16:50:44 Roll third_party/glmark2/src/ 2054465f6..cb550a25c (5 commits) https://chromium.googlesource.com/external/github.com/glmark2/glmark2/+log/2054465f6f7c..cb550a25c75a $ git log 2054465f6..cb550a25c --date=short --no-merges --format='%ad %ae %s' 2025-01-14 atetubou Add missing include headers 2025-01-10 alexandros.frantzis build: Remove WAF build system support 2025-01-10 alexandros.frantzis build: Add dispmanx flavor support in meson build 2025-01-13 alexandros.frantzis NativeStateDispmanx: Support building using GLAD EGL 2025-01-13 alexandros.frantzis NativeStateDispmanx: Fix compiler warning Created with: roll-dep third_party/glmark2/src Bug: chromium:40263312 Change-Id: Id947b2a1971c315f2e89ab493e0ffd3c20a31cf8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6174282 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
jh.eun fbb0f994 2024-10-17T17:24:19 CL/Vulkan: Add check for std430-ubo-layout option for clspv To support 1byte vectors, clspv needs to add std430-ubo-layout option. Related ocl_cts: test_basic parameter_types Bug: angleproject:387306730 Change-Id: Ic00db6fcb3bc69eac455b36c6772dd83111ac06c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6137320 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi efe31ab8 2024-11-29T14:49:29 Revert "Vulkan: Keep old VVL suppression until roll into Chromium" This reverts commit b31f367a9ab885c0cd3b176b8bbcab05b380cc8a. Reason for revert: No longer needed after vulkan-deps rolled into chromium. Original change's description: > Vulkan: Keep old VVL suppression until roll into Chromium > > Bug: angleproject:336652255 > Change-Id: Id12e86862cde613cbf3c87557532b2bf23da1838 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6056751 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: angleproject:336652255 Change-Id: I5287fb70ecbf53124b240a4f9e71cbcba66093c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6058732 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
WeiCong Yu 2f9047cd 2024-10-21T21:56:14 Add CHECK when MTLCommandBufferErrorOutOfMemory occurs Bug: angleproject:374574265 Change-Id: I3c1f6cdf86f9ad73b10f1299f4bd4e348dffb001 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5947983 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Matthew Denton 8ee72cc7 2025-01-13T13:44:31 WGSL: support matCx2 in uniforms matCx2 in WGSL does not match std140 layout and so it needs to be translated as array<ANGLE_wrapped_vec2, C> when in a uniform. On use it needs to be converted to a WGSL-native matCx2. This also includes the optimization of an array<matCx2> in a uniform--when indexing into it, only the indexed element will be converted to a native matCx2, instead of converting the entire array and then indexing. Bug: angleproject:376553328 Change-Id: I1d84471234b3d3cf4cf361ae89cb61675d5bf9a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6157788 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
jh.eun 73e226cb 2024-10-17T16:37:52 Vulkan: Add check for uniform buffer standard layout feature Add to check uniform buffer standard layout is supported. Bug: angleproject:387306731 Change-Id: I543c46a6b504a4df7e9937365c9b28e6328f0619 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6137319 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov f45b9951 2025-01-16T10:05:06 Inline ValidateUniformCommonBase Same way as driver_overhead_2 based PGO does it. It makes sense as the function is small and only has a few callers. This happens to reduce .so size by ~10KB due to ValidateProgramUniform* (ES31) changes: clang no longer inlines ValidateProgramUniformBase into those and it becomes a function call - but a call in the same translation unit instead of a call into ValidateUniformCommonBase in another unit. Seems like we get the same number of calls but better locality. Perf imact difficult to estimate due to effects of section layout changes but I do see an improvement when comparing PGO builds, disabling this optimization for an affected function then re-enabling it with this CL. Bug: b/383305597 Change-Id: Ib76d33d01b165049335e61c007ee79bec53219c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6175711 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Mohan Maiya 38b3f123 2025-01-16T06:55:15 Vulkan: Enable preferDriverUniformOverSpecConst for Samsung Bug: angleproject:386749841 Change-Id: I8e99efe01e1e9152371384d1bf5645b444438c62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6179075 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 062f1fc1 2024-12-17T22:22:04 Vulkan: Use waitFenceUnlocked to finish one command Batch Using `CommandBatch::waitFence()` in finish one command Batch is no longer necessary, since `mQueueSubmitMutex` remains locked, preventing adding new commands when `kInFlightCommandsLimit` is exceeded. The `Locked` suffix is removed from `finishOneCommandBatchLocked()` since it is now accepts the `lock` (similarly to `waitFenceUnlocked()`) and may temporarily unlock it. Test: angle_end2end_tests --gtest_filter=EGLSyncTest.BlockingOnSubmitCPUThrottling/* Bug: b/362604439 Change-Id: I8f39d7b2e6f1b9ce8ed4aa8875375769211572e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6098256 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Kimmo Kinnunen 0cfea380 2025-01-15T10:46:54 Rename sh::TSpan as general purpose angle::Span Span abstraction is useful for making buffer manipulation more consistent. The commit makes the Span available to all code until std::span can be used. Bug: angleproject:389951202 Change-Id: Id0c6b54bb6e75d3cc4e85af854d9e61b66906752 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6170997 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Steven Noonan 49e5f944 2025-01-07T22:27:33 egl_angle_ext: add value for EGL_CONTEXT_MEMORY_USAGE_ANGLE The enum was declared as a dependency of the extension EGL_ANGLE_memory_usage_report, but no value was defined. Bug: angleproject:351866412 Change-Id: I956da38930e69eb83c179ac70c244f0df7ef7f04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6165287 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll b4cb17b8 2025-01-15T10:08:39 Roll VK-GL-CTS from 9509eb274dfe to 962460e9975c (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9509eb274dfe..962460e9975c 2025-01-10 javed@igalia.com Add tests for input assembly primitive stat with tess 2025-01-10 piotr.byszewski@mobica.com Fix promoted extension tests not running correctly 2025-01-10 ziga@lunarg.com Fix supported sample count check in draw_copy_resolve tests 2025-01-10 marcin.zajac@mobica.com Fix validation error in api tests 2025-01-10 nikolaysmirnov@google.com Add multiple_render_targets_overdraw test 2025-01-10 gleese@broadcom.com gen_framework.py: Fix some alignment 2025-01-10 gleese@broadcom.com Update amber version to the latest upstream 2025-01-10 rgarcia@igalia.com Test varying tessellation state in Indirect Execution Sets 2025-01-10 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:390138123 Change-Id: I6b653b347550d4a7d4f75e3ce1a0f7bf20e0d0cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6175280 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop 28fbe4a5 2025-01-15T10:12:05 Docs: Fix CIPD link For whatever reason, markdown wasn't resolving the link. Bug: None Change-Id: I27848b0ddbd579c7faf5832119d6521113dfea13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6172575 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Juston Li 3dc3de62 2025-01-08T16:02:30 Disable gl backend for desktop android Desktop android only uses the vulkan backend Bug: b/388074349 Change-Id: Ib42f04af0ed947cf93d3d891e78aef1ae0a81a63 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6164687 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 29731140 2025-01-15T09:58:10 Roll Chromium from 6920d2f1f699 to 0c0e530859bb (1199 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6920d2f1f699..0c0e530859bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bbdae0b409..ce61bc84f9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/59f9fbaa49..a660247d3c * buildtools/linux64: git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd..git_revision:ed1abc107815210dc66ec439542bee2f6cbabc00 * buildtools/mac: git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd..git_revision:ed1abc107815210dc66ec439542bee2f6cbabc00 * buildtools/win: git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd..git_revision:ed1abc107815210dc66ec439542bee2f6cbabc00 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5b3283646f..86b5f23890 * third_party/android_build_tools/lint/cipd: Q2AdRKMr8eMrKgLZ9CwGTRx4BwGOL2wc6Ad942McdDUC.._77LT8DN3c2A3RPC4ctJk-kOk2K_QEuS3_aQty7g384C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/4c97c49c40..11efe26855 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c4c972c5f0..d25caed4b9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a912cd245b..a90906c74d * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/74dd760826..2e25154d49 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/7681005c62..8205ccf0f2 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/597b2e8c42..b90022fc6a * third_party/r8/cipd: xbInvmbYpySCc5-qVBjQg8Ns8FvdvEyvQFadpxKY1-sC..CqDcMSHb2wxXTFpn_KVnKoQSUN1HXWOqix19Kgv-oAYC * third_party/siso/cipd: git_revision:f9bfa081826a4ffb6f2a96b640d009cef900e69f..git_revision:67a8780a72f407b3dffe9e338c368f0b799d004b * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/b763971bca..5634698162 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/145ae97377..860e334a80 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/efca7ea4f9..87dc2b2656 * tools/skia_goldctl/linux: y4kowbHdyv_7-p0-MB1QlTWy5YWYDclmStirH1GbuCkC..GkPik3ZR82JcwVHk-pBTePz2HPYzW8LateYL4h_d-bIC * tools/skia_goldctl/mac_amd64: tGIX6p4MvgbXFQWrWBCJ-xjSTLxHwW3ShJXRnLQCUdYC..j7rDa6kTN-TMvPfBmX1peSexyGPSajiQ5st1zCqBrEYC * tools/skia_goldctl/mac_arm64: 7m6yrdw10Gle5GlaI-jY2YVIqXxO_8MgLIVhKt9tPzYC..BD_Os35akIixtA0Ooa6coXpJ4hjQUVHonW0WJTsPfWAC * tools/skia_goldctl/win: skMt2xgfOuITCmlSoLbBGHtrtM3geW4ejGVKFtFxTvsC..ByYUybN8CyRSJhmE5wfxU9m1DBFbhBX5-F5M0Cuk84YC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: If8ea027e8634a2fac1953a513d898a2d80872620 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6175015 Reviewed-by: Geoff Lang <geofflang@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Mavis Deng 3675ca04 2025-01-07T17:59:30 Vulkan: Bugfix for xfb GL_SEPARATE_ATTRIBS mode in PPO case The new executable state transformFeedbackBufferMode should hold the result of the link. An end2end test is added. Bug: angleproject:385662281 Change-Id: I52398ad9a9fe76344b94dac787cae7141924d1dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6156277 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya de5286fa 2025-01-14T10:59:17 Add missing include to MemoryBuffer.cpp Details can be found here - https://chromium-review.googlesource.com/c/angle/angle/+/6135238/11#message-d271191140cfc29498701cbbb5ee8c6dc20349d0 Bug: angleproject:386749841 Change-Id: I428a61bafcc2d65d7538e0d1c28ebe39ad40b7fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6169566 Reviewed-by: Brian Johnson <hibrian@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi 1eaeff9b 2025-01-13T21:57:11 Update committer promotion instructions Bug: b/353871674 Change-Id: I2d034974dea2ee5dac65837258571a2151cd69b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6173842 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Xin Yuan 4c1354d9 2025-01-03T14:41:27 Make sure the AHB is not corrupt when bound to egl image The AHB bound to egl image could be corrupt or not a valid ANativeWindowBuffer, it should be validated when creating egl image. Bug: angleproject:387226848 Change-Id: Iefc5506746ceaad92d16b02d5c0838156eee2f9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6126739 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Neil Zhang 0501d32f 2024-12-23T18:02:54 Draw call with un-aligned index buffer should be checked Bug: angleproject:385264236 Change-Id: I1ff7e93bf4b9ea9020e82f3558e4157b74cb7078 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6151227 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Takuto Ikuta d9c0aa4a 2025-01-09T18:08:08 Reland "Roll third_party/glmark2/src/ ca8de51fe..2054465f6 (77 commits)" This is a reland of commit 68b594e859f036b01974f78f8ddca8c419bc8ce3 Includes fixes to glmark2Benchmark.cpp to parse updated output. Original change's description: > Roll third_party/glmark2/src/ ca8de51fe..2054465f6 (77 commits) > > https://chromium.googlesource.com/external/github.com/glmark2/glmark2/+log/ca8de51fedb7..2054465f6f7c > > $ git log ca8de51fe..2054465f6 --date=short --no-merges --format='%ad %ae %s' > 2024-04-25 alexandros.frantzis Use std::filesystem throughout the codebase > 2024-04-25 alexandros.frantzis android: Build native code with C++17 > 2024-04-25 alexandros.frantzis Doc: Recommend meson for building win32 flavors > 2024-04-25 alexandros.frantzis github: Build win32 flavors with msvc in CI > 2024-04-25 alexandros.frantzis github: Build win32 flavors with mingw in CI > 2024-04-25 alexandros.frantzis include/getopt: Always use non-const char array to avoid MSVC errors > 2024-04-25 alexandros.frantzis libmatrix: Add utility function to get idle time > 2024-04-25 alexandros.frantzis libmatrix: Add utility function to get process times > 2024-04-24 alexandros.frantzis libmatrix: Add utility function to get the number of processors > 2024-04-25 alexandros.frantzis libmatrix: Use C++ std::chrono instead of clock_gettime > 2024-04-25 alexandros.frantzis libmatrix: Use C++17 std::filesystem instead of dirent > 2024-04-25 alexandros.frantzis Build: Add support for win32 flavors in meson > 2024-04-24 alexandros.frantzis libmatrix: Provide a copy of the va_list to __android_log_vprint > 2024-04-13 kode54 NativeStateX11: Fix WM_DELETE_WINDOW handling > 2024-02-15 alexandros.frantzis NativeStateWayland: Explicitly destroy all Wayland resources at shutdown > 2024-02-15 alexandros.frantzis Explicitly release GL related resources at shutdown > 2023-06-03 prlw1 src/meson.build: add x11 dependency to glx > 2024-02-07 timchen021 Fix memory leaks using smart pointers > 2024-01-12 daniel.levin Add missing includes in scene-collection.h > 2023-11-01 alexandros.frantzis GLVisualConfig: By default don't care about the stencil config component > 2023-11-01 alexandros.frantzis Options,GLStateEGL,GLStateGLX: Add option to require a good visual config > 2023-07-26 abs GLStateEGL,GLStateGLX: Change failure to get a "good" visual config to warning > 2023-11-01 alexandros.frantzis libmatrix: Add Log::warning() function > 2023-05-20 prlw1 meson.build: fix build and avoid sigsegv > 2023-05-03 ofourdan NativeStateX11: Add winsys option for position > 2023-01-19 alexandros.frantzis Build,Doc: Update files for 2023.01 release > 2023-01-19 alexandros.frantzis NativeStateMir: Remove Mir/mirclient support > 2023-01-03 alexandros.frantzis ResultsFile: Support storing results in an XML file > 2023-01-03 alexandros.frantzis ResultsFile: Support storing results in a CSV file > 2023-01-03 alexandros.frantzis Options,ResultsFile: Add option to set the results file > 2023-01-03 alexandros.frantzis Introduce infrastructure to support saving results to a file > 2023-01-03 alexandros.frantzis CanvasGeneric: Store individual info elements in separate strings > 2023-01-03 alexandros.frantzis MainLoop: Store indivitual result values in separate strings > 2023-01-03 alexandros.frantzis Scene: Remove trailing ':' from scene info string > 2023-01-04 alexandros.frantzis SceneTerrain: Silence unused variable warning > 2022-12-21 pierre-yves.mordret NativeStateGBM: Lock and release the front buffer on flip > 2022-12-21 alexandros.frantzis MainLoop,Scene: Support reporting shader compilation time > 2022-12-20 alexandros.frantzis MainLoop,Scene: Add busy percentage in CPU time results > 2022-12-20 alexandros.frantzis MainLoop,Scene: Support reporting CPU time results > 2022-12-20 alexandros.frantzis Options: Introduce option to specify benchmark results to show > 2022-12-20 alexandros.frantzis Scene: Update elapsed times when a benchmark finishes > 2022-12-19 alexandros.frantzis Scene: Introduce struct to keep track of elapsed time > 2022-12-15 alexandros.frantzis Scene: Introduce infrastructure for more complex scene stats > 2022-12-15 alexandros.frantzis Scene: Move common preparation logic to Scene::prepare > 2022-12-13 alexandros.frantzis Scene: Introduce non-virtual methods to prepare and finish a scene for benchmark > 2022-12-08 alexandros.frantzis GLVisualConfig: Support specifying the config id in --visual-config > 2022-12-08 alexandros.frantzis libmatrix: Support prefix dependent input conversions from string > 2022-12-08 alexandros.frantzis GLStateEGL,GLStateGLX: Fail if no suitable config is found > 2022-12-08 alexandros.frantzis GLStateEGL,GLStateGLX: Don't limit the configs passed to our selection mechanism > 2022-12-08 alexandros.frantzis GLVisualConfig: Penalize configs with components smaller than requested > 2022-11-16 alexandros.frantzis github: Build x11-gl-egl flavor in CI > 2022-11-14 rilian-la-te build: Add x11-gl-egl flavor > 2022-11-10 alexandros.frantzis GLStateGLX: Support multisampled configs > 2022-11-10 l.stach GLStateEGL: Support multisampled configs > 2022-11-10 l.stach GLVisualConfig: Add multisampling support > 2022-09-02 120989324 Add missing newline at end of log messages > 2022-11-10 alexandros.frantzis NativeStateDRM,NativeStateGBM: Support configuring the DRM device > 2022-11-10 alexandros.frantzis Options: Support passing window system specific options > 2022-04-23 nunes.erico NativeStateGBM: Add GBM offscreen backend > 2022-07-07 wuqianhai SceneJellyfish: Fix memory leak > 2022-07-07 wuqianhai SceneRefract: Fix texture leak > 2022-07-07 wuqianhai SceneIdeas: Fix texture leak > 2022-06-14 Martin.Jansa waflib: fix compatibility with python-3.11 > 2022-05-12 jeffy.chen NativeStateDRM: Honor visual configuration > 2022-05-13 alexandros.frantzis GLStateEGL,GLStateGLX: Use SwapInterval 1 for FIFO swap mode > 2022-04-15 alexandros.frantzis NativeStateDrm: Implement swap interval 0 > 2022-02-14 alexandros.frantzis github: Run apt-get update to get latest packages > 2022-02-14 alexandros.frantzis CanvasGeneric,CanvasAndroid: Display surface config info > 2022-02-14 alexandros.frantzis Options: Support --version command line argument > 2022-02-14 alexandros.frantzis libmatrix: Add missing <utility> include > 2022-02-10 hillma libmatrix: avoid -Wimplicit-fallthrough > 2021-12-23 alexandros.frantzis Build,Doc: Update files for 2021.12 release > 2021-12-23 alexandros.frantzis NativeStateDrm: Fix crash when we can't become DRM master > 2021-09-30 jf android: Fix benchmark parameter edition > 2021-08-30 alexandros.frantzis Use highp precision modifier only on GLES > 2021-08-30 alexandros.frantzis GLStateEGL: Support EGL versions < 1.4 > 2021-04-11 maahiuzeon Fix model loading on big endian. > > Created with: > roll-dep third_party/glmark2/src > > Bug: chromium:40263312 > No-Presubmit: true > Change-Id: Ifee506badac67ff5af57605994daff01278c6d56 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6162277 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Test: angle_perftests --gtest_filter="*GLMark2Benchmark*" Bug: chromium:40263312 Change-Id: I54d8982cb37e488f80b7511ad0111d1ff111f004 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6174747 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi bbc0d702 2024-12-27T07:44:01 Vulkan: Add entry points to lock the Vulkan queue ... which can be retrieved via EGL_ANGLE_device_vulkan. Otherwise the application is unable to use the VkQueue that is retrieved out of ANGLE from other threads (such as Chromium's DrDC feature). Bug: chromium:380295059 Change-Id: Ife80f54440777486f72fc61697a68fb0c2b2d0f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6116046 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Zhonghang Chi ac7a85f4 2025-01-10T17:24:48 Vulkan: Replace copy image view with same read view in setStorage 1.Introduce a share flag in ImageViewHelper. 2.Update the share flag when copy view is same as read image view. 3.Only return read view when copy view is same read one. Bug: angleproject:387392704 Change-Id: I6a3a9ca043ba16cdeb430cce53d40197618a0d44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6147667 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 65513240 2025-01-03T17:26:55 Fix initializing output variables ... by compiling a list of TVariables instead of names that are later looked up. The latter results in wrong symbols being initialized when the output variables are shadowed. Bug: chromium:376738756 Bug: chromium:377553431 Change-Id: I76b9688c035476c547ac73cff380629161210406 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6143374 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Chia-I Wu ae12ef68 2025-01-13T16:17:17 Vulkan: default to VK_FILTER_LINEAR for YUV DmaBuf Follow YUV AHB to default to vk::kDefaultYCbCrChromaFilter. Bug: b/388836383 Change-Id: I8883e9c40aa69bd41bec0449d63ac23fe6dadca6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6173191 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Chia-I Wu <olv@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shufen Ma e510bb61 2025-01-08T09:56:39 Check offset alignment for ReadPixels An INVALID_OPERATION error is generated if a pixel pack buffer object is bound and data is not evenly divisible by the number of basic machine units needed to store in memory the corresponding GL data type from table 8.4 for the type parameter. Bug: angleproject:352963094 Change-Id: I057ed0997313daffbb31d19c94e408b600fce03b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6155815 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi fe76d70b 2025-01-10T14:41:06 Vulkan: Enable 16-bit norm support for tex buffers According to the spec for EXT_texture_norm16, it enables texture buffers to support the following additional formats: * GL_R16_EXT * GL_RG16_EXT * GL_RGBA16_EXT All of the above are unsigned short normalized values. * Updated validation to support the aforementioned formats in texture buffers in case of support for the norm16 extension. * Updated AdjustViewFormatForSampler() to also support norm16 values. * Added the condition for advertising textureNorm16EXT that the 16-bit UNORM formats above should have the buffer feature bit for texture buffer support: VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT * Added support check for renderSnormEXT after textureNorm16EXT, since the check for former currently uses the support for latter as a parameter. * Added unit tests to draw using a texture buffer with norm16 formats. * Added TextureBufferTestBase in order to test the API calls in the extensions and the core ES 3.2 version, which the following suites are derived from: * TextureBufferTestES31 (existing) * TextureBufferTestES32 (new) * Extended the tests to similar 8-bit formats. Bug: angleproject:381313704 Change-Id: I49157e8c2c9b5438eaf8d56c1932d12e56489318 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6169006 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop f094a81e 2025-01-07T14:08:11 restricted_trace_perf: Add screenshot support This update allows users to capture screenshots when using restricted_trace_perf.py. * Two new optional arguments are added. If either is set, a screenshot will be captured. --screenshot-dir (host directory to write screenshots, default CWD) --screenshot-frame (specify desired frame, default is 1 or KeyFrame) * If screenshots are requested, we create a temp dir on the device, pull the screenshot, then delete the dir * The screenshot is renamed during pull to reflect the renderer that created it. Otherwise they are all named "native" since we convince the platform to use its default driver, allowing calls to go through the EGL loader. Test: restricted_trace_perf.py --screenshot-dir ~/Screenshots --screenshot-frame 2 Bug: b/377325803 Change-Id: I5be7a1e2f9f557668bff51349654c8c4e093b47a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6154857 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi f72428bb 2025-01-10T22:24:07 Vulkan: Fix MSAA swapchain resolve out of render pass .. vs the optimization that transitions the swapchain image to PRESENT_SRC as part of the render pass. When the swapchain image is the resolve attachment, its layout is decided when the render pass is closed (or through manual calls to finalizeImageLayout()). If the render area forbids the swapchain image from becoming the resolve attachment, it must be resolved after the render pass. Prior to this change, the swapchain image was still marked for transition to PRESENT_SRC by the render pass. This is inefficient, as the following out-of-render-pass resolve would have to transition the image back out of PRESENT_SRC. Nevertheless, this also had a bug exposed by an ASSERT in the dynamic rendering path: * Before the out-of-render-pass resolve, the image layouts are forcefully finalized. * The code in finalizeImageLayout() checks which image is being finalized; if the image is not any of the ones in the render pass, it was silently ignored. * The image marked for transition to PRESENT_SRC (mImageOptimizeForPresent) is not separately checked, as it is expected to be an attachment as well. The code that optimized the final render pass always marked the swapchain image for optimization, even if it was not going to become the resolve attachment. This change makes sure this optimization is done only if the image is definitely an attachment of the render pass. Bug: angleproject:389048224 Change-Id: I9f451d2698944111ac96bd97fefd6efa23859b7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6168388 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Mohan Maiya b3af2e86 2024-12-31T08:51:37 Enhance MemoryBuffer API Add support for - 1. reserve - users can reserve sufficient capacity upfront to minimize subsequent reallocations due to resize 2. append - to append data from a source so user doesn't need to track offsets explicitly Bug: angleproject:386749841 Tests: MemoryBufferTest* Change-Id: Ibf2a3228d5a00ed34a7e0c5e3eb185e42677d676 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6135238 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov b5b2612e 2025-01-13T12:36:39 Tune branching in getProgramResolveLink() Hinting the likely/unlikely branches in related calls. Notably, mShaderProgramManager->getProgram() has a flat resource array and a fallback to a absl::flat_hash_map. As observed in driver_overhead_2 trace based PGO builds, the fallback gets un-inlined by PGO (presumably due to being hit rarely) and becomes a function call. Regular builds without the tuning in this CL inline flat_hash_map implementation, increasing the code size / worsening locality for a fallback case. This change makes the Context::useProgram() aarch64 assembly in regular builds very close to the driver_overhead_2 based PGO, and the code size goes down from 576 to 256 bytes. The total reduction of the .so size is 36KB (0.6%), likely due to all the cases where the inlining is avoided by hinting. There appears to be a ~1% perf improvement in driver_overhead_2 trace wall_time in my tests on a couple of Android devices. Hard to tell if this is due to the improved code locality or some other aspect of the change in assembly. Bug: b/383305597 Change-Id: I85c02cc74a56e7074086965e8d31018bd9ee0040 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6169263 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Neil Zhang cfe87e34 2024-12-16T16:29:39 Add multisample support for glCopyImageSubDataEXT As GL_TEXTURE_2D_MULTISAMPLE/GL_TEXTURE_2D_MULTISAMPLE_ARRAY been introduced by GLES3.1, glCopyImageSubDataEXT should support those types. Bug: angleproject:381727390 Change-Id: Ib3571ea38dc8d8ceb1bc9ad0c8a6e04d28b0ec33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6146194 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxiang Qian 4c60a308 2024-12-30T15:35:07 Change default return value for eglDupNativeFenceFDANDROID According to EGL spec, eglDupNativeFenceFDANDROID should return EGL_NO_NATIVE_FENCE_FD_ANDROID when there is error. However, ANGLE just returns 0 as default value. Now overload the default return value to EGL_NO_NATIVE_FENCE_FD_ANDROID. Also, a end2end test is added. Bug: angleproject:385190296 Change-Id: I214efdeb3ad583989fab5e2244c82cb7295f8b67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6146195 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Aurora Zhang 28270609 2025-01-09T18:08:40 Vulkan: Fix clear texture for unrenderable internalformat Checking whether the texture is renderable or not depends on the output texture's format. If the output format is unrenderable, while format and type indicate the input format as renderable, the clear texture should still go into the unrenderable path. Bug: angleproject:385190304 Change-Id: I2963caad4996547a0aa27fcc37033ca95e2fa21e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6134267 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 4b0f6f06 2025-01-13T10:01:37 Roll vulkan-deps from 58a9b6e76b58 to 8d2a13cc4374 (16 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/58a9b6e76b58..8d2a13cc4374 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f754c852a87988eb097a39480c65f704ceb46274..e43514866f7e0f8265c677039d2fe773c892d44b https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/73995ddc2b38b5653c8eb3b4a0d1cd6cc2cea4c0..4446967600048557909231722d2c92212b6ca258 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/8b39a8b54d55c8737196cdce705f32f94d3b2463..9064fe8637daf9f694c8a2e035a34da94022f2be https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b18ee987c900b7d84908b32add45610032e25d28..ea05bf71f2948d64f7d36651ffcad59216401095 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Iac67f2a480447cb9f19e80ef79e1cde59bfc047c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6172309 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 961939b3 2025-01-13T08:41:35 Roll Chromium from 6678a1628926 to 6920d2f1f699 (726 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6678a1628926..6920d2f1f699 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b2b443d269..bbdae0b409 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c7596937d4..5b3283646f * third_party/android_build_tools/error_prone/cipd: a-wq097LhH9krgIuF0T5waFnHU4KilRItqhJPGFZxtwC..7c91BXn6VPvSmr-dFRYaNVkfHjRN1jdMIN4EcrPem9cC * third_party/android_build_tools/manifest_merger/cipd: T3B_dWqgDISstbC0L7CrQOOf9xe-27KUYK8UCTq6trgC..osgd04hyZB3eu5L7oiL6irk9AqRBX9lOxNLsaCmUCowC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/423f1e1914..a912cd245b * third_party/fuchsia-sdk/sdk: version:26.20250103.4.1..version:26.20250110.4.1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/44258fc58f..597b2e8c42 * third_party/r8/cipd: pTuwP6kf9nJ3wT_GS6XQy5z5xjF3Cb5JDfVapSCBRvcC..xbInvmbYpySCc5-qVBjQg8Ns8FvdvEyvQFadpxKY1-sC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/145029da02..668908cb48 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fc64227b60..145ae97377 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c3b61a49db..efca7ea4f9 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/474e007a4e..05dbbfdcec Clang version changed llvmorg-20-init-16062-g091448e3:llvmorg-20-init-17108-g29ed6000 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/fc64227b60f7887c09283f873eb18b087eb6f0c2..145ae97377dc97a0c5a9ce7ab5709f3492757475/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: I57dc0354c66dadc659693137de02dc90ca43a24c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6171595 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0