Log

Author Commit Date CI Message
angle-autoroll 8edee520 2021-03-15T10:01:28 Roll SwiftShader from 3c4fd15fb075 to 5cdf55ff2084 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/3c4fd15fb075..5cdf55ff2084 2021-03-13 capn@google.com Remove vkGetInstanceProcAddr from exported symbols on Fuchsia 2021-03-12 capn@google.com Remove vkGetInstanceProcAddr from exported symbols on Android 2021-03-12 natsu@google.com Handle semaphore update in vkAcquireImageANDROID 2021-03-12 natsu@google.com Update AHB default YUV range to NARROW 2021-03-12 capn@google.com Regres: Roll dEQP to 1.2.5.2-dev revision 288b9dd 2021-03-12 swiftshader.regress@gmail.com Regres: Update test lists @ 3c4fd15f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ic2eec9679101fe9890fa4d0571f39c28f4cef04f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2760258 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 45ce8d1e 2021-03-15T08:07:12 Roll Chromium from e90a7a4d378a to 1572b5ac9572 (403 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e90a7a4d378a..1572b5ac9572 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8b3a30a92c..5f2e66e38e * buildtools/linux64: git_revision:e0358b49272c8b354eda0a595e1d7887343fab27..git_revision:64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8 * buildtools/mac: git_revision:e0358b49272c8b354eda0a595e1d7887343fab27..git_revision:64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8 * buildtools/win: git_revision:e0358b49272c8b354eda0a595e1d7887343fab27..git_revision:64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/09e6844f48..c6aca9251c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6e87bddf1b * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/84a6931d87..5243354177 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e645571320..91db20bec2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3164db0bf1..cfcc45286b * tools/skia_goldctl/linux: B61Q7uQOsOlRtaowXXUUrD_eSjWCpiKEcrtjT3VFg-cC..jstGnw4Pyb9uiuH75QNEy3f6hJN7ET2TFiOVOUiMokcC * tools/skia_goldctl/mac: RY1cs6o9Gi3j3iBE9XxPDZcR1n4Xvo27QvF_F3wL2r4C..VUCuq1sveo1hxWfABmHwe-nXmh0OuWy4y9PhS3ykvykC No update to Clang. Bug: angleproject:4483 Tbr: ianelliott@google.com Change-Id: Ib54ef0294caddbd741ffe77f9d5259887292f648 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2759740 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott cd881848 2021-03-12T15:26:36 Actually skip a flaky/timeout test Also, create SwANGLE KHR 3.1 expectations section Bug: angleproject:5755 Change-Id: I902b3d3de0c3c4dd190d36c6b5f2def33420efc7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757125 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Tim Van Patten bbed8813 2021-03-05T17:40:27 Create GN arg to enable non-conformant features The GN arg angle_expose_non_conformant_extensions_and_versions is being added to control exposeNonConformantExtensionsAndVersions, which enables non-conformant features and extensions. In particular, this is being done to enable EXT_texture_buffer on devices that don't support all of the necessary formats since many Android games rely on this extension, such as "Special Forces Group 2", "Fortnite", and "PUBG". # Enables non-conformant extensions and features angle_expose_non_conformant_extensions_and_versions = false Users/vendors can now toggle the value with a GN arg, rather than a code change, to make it easier to test the conformant version of ANGLE with CTS, dEQP, etc. and/or app-compatibility. Bug: angleproject:5592 Change-Id: Icbf18b48a2751c03e277ae964e1ec278a43324cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2740643 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Ian Elliott 191bee56 2021-03-12T13:44:19 Suppress flaky test on win-swangle This test times out. It takes a while on my underpowered Windows laptop. Bug: angleproject:5755 Change-Id: Id112c170a5e57c8e765dd94277ce0cf2801fae6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757118 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Pujun Lun ca5dbef0 2021-03-11T00:40:39 Micro-optimization for loading 3-channel images. This reduced the total time spent in LoadToNative3To4 by 10% in our micro-benchmark. Test: passed the CQ dry run. Bug: b/182513949 Change-Id: I5d1b1975f64e5b08bd0e65abc8f94fe62ef54321 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752347 Commit-Queue: Pujun Lun <lunpujun@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott 4f6d4d6f 2021-03-12T10:32:57 Suppress flaky EGL resize failure on Linux Bug: angleproject:5753 Change-Id: I0bf716b09d329e9881bf5ca146ef6839d898a1b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757107 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 89d2a96a 2021-03-09T18:37:57 Vulkan: Add test for UBO descriptor allocations. This performance counter test verifies that re-binding the same two buffers repeatedly doesn't allocate new descriptor sets. Currently the test fails because we don't cache descriptor sets for UBOs. Covers equivalent code patterns in Asphalt 9. Reorganizes the perf counters collected for the program objects. Now they are per-frame reset instead of cumulative. This tracking is now consistent for the different counter types. In the future we can add cumulative tracking for all per-object and global perf counters. Bug: angleproject:5736 Change-Id: I23d04b6453e38af1cf4af7274d24382d136efad3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746176 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 4d7ea943 2021-03-11T21:05:29 Remove old Mac bot from CQ mac-angle-chromium-try + mac-angle-try replace mac-angle-rel, adding dEQP testing on top of it Bug: angleproject:4483 Change-Id: I477b3ef884e4e92c9ab11a55d7a8a3f4f4e0c02b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753491 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jason Macnak 41a2672f 2020-09-03T11:05:54 Vulkan: Use optimal tiling for AHB When running Android on certain GPUs, there are problems creating Vulkan image siblings of AHardwareBuffers because it's currently assumed that the underlying driver can create linear tiling images that have input attachment usage, which isn't supported on NVIDIA for example, resulting in failure to create the image siblings. Yet, we don't currently take advantage of linear elsewhere in ANGLE. To maintain maximum compatibility on Android for such drivers, use optimal tiling for image siblings. Note that while we have switched to optimal unconditionally in this path versus linear, it's possible that previously compatible linear usages might become uncompatible after switching to optimal. However, from what we've seen on NVIDIA/AMD/Intel/Samsung GPUs so far, formats generally have more possible usages in optimal tiling versus linear tiling: http://vulkan.gpuinfo.org/displayreport.php?id=10804#formats_linear http://vulkan.gpuinfo.org/displayreport.php?id=10804#formats_optimal http://vulkan.gpuinfo.org/displayreport.php?id=10807#formats_linear http://vulkan.gpuinfo.org/displayreport.php?id=10807#formats_optimal http://vulkan.gpuinfo.org/displayreport.php?id=10809#formats_linear http://vulkan.gpuinfo.org/displayreport.php?id=10809#formats_optimal http://vulkan.gpuinfo.org/displayreport.php?id=10787#formats_linear http://vulkan.gpuinfo.org/displayreport.php?id=10787#formats_optimal Also, as an aside, in terms of what's generally expected from the Vulkan ICD in Android when determining AHB compatibility, if the vendor wants to declare a particular combinatino of format/tiling/usage/etc as not supported AHB-wise, it's up to the ICD vendor to zero out bits in supportedHandleTypes in the vkGetPhysicalDeviceImageFormatProperties2 query: ``` * [VUID-VkImageCreateInfo-pNext-00990](https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-VkImageCreateInfo-pNext-00990) If the pNext chain includes a VkExternalMemoryImageCreateInfo structure, its handleTypes member must only contain bits that are also in VkExternalImageFormatProperties::externalMemoryProperties.compatibleHandleTypes, as returned by vkGetPhysicalDeviceImageFormatProperties2 with format, imageType, tiling, usage, and flags equal to those in this structure, and with a VkPhysicalDeviceExternalImageFormatInfo structure included in the pNext chain, with a handleType equal to any one of the handle types specified in VkExternalMemoryImageCreateInfo::handleTypes ``` Bug: angleproject:5709 Change-Id: I67b65ab830505a9df4665ccea8e2ba1ca409e0b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729243 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lingfeng Yang <lfy@google.com>
Jeff Vigil cef5b717 2021-03-11T09:22:33 EGL: Add attribute check in ValidateQueryContext Implementation of EGL_IMG_context_priority was missing attribute check in ValidateQueryContext Add test case. Test: angle_end2end_test --gtest_filter=EGLCreateContextAttribsTest Bug: angleproject:5746 Change-Id: Idf5df29fcb343d969a031675b6c5985a9be0a705 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752891 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 5cc32fc9 2021-03-12T10:01:28 Roll SwiftShader from a2fe8e1b2111 to 3c4fd15fb075 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/a2fe8e1b2111..3c4fd15fb075 2021-03-11 capn@google.com Implement timestamp query support 2021-03-11 srisser@google.com Expose Vulkan 1.2 support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ib6b2cce9056177b7b490d650c3344351a010d3d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756348 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bb034e05 2021-03-12T10:01:33 Roll vulkan-deps from a4e10bfde719 to ea8c29e1ee20 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a4e10bfde719..ea8c29e1ee20 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/77eb2b608e..5d8c40399e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/be60dd27b1..f648a59e1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ic58ad0ced49c9ba102605bd14d24dd5466d2ed4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756088 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b775012c 2021-03-12T08:08:11 Roll Chromium from 9e42f9e4abc6 to e90a7a4d378a (458 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9e42f9e4abc6..e90a7a4d378a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cb067b2df4..8b3a30a92c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/368c7dd2c9..69cc9b8a3a * buildtools/linux64: git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3..git_revision:e0358b49272c8b354eda0a595e1d7887343fab27 * buildtools/mac: git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3..git_revision:e0358b49272c8b354eda0a595e1d7887343fab27 * buildtools/win: git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3..git_revision:e0358b49272c8b354eda0a595e1d7887343fab27 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/32c9b4b55a..09e6844f48 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cf138ce6bf * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/348acca950..09490503d0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e65f1a7cc3..e645571320 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4bd62b06a2..3164db0bf1 * tools/skia_goldctl/linux: X8zqgmHchz43Cvw6xwn3VRL5keLdpA3cD_DqweHLRqMC..B61Q7uQOsOlRtaowXXUUrD_eSjWCpiKEcrtjT3VFg-cC * tools/skia_goldctl/mac: 9B5ePukmYbotGUjJuMV-DdjKGW5K0MtKrz8eOpXftu8C..RY1cs6o9Gi3j3iBE9XxPDZcR1n4Xvo27QvF_F3wL2r4C * tools/skia_goldctl/win: tC_p4_R9hLfNMczJQbjawF5kzgXRVNF-XVcN7bJxrEYC..j4rOmbVNLoVaUWWPvzH9y8NIrbGae5OxIInpCD89q0QC No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I740c584e817bf2208aaf3f70211e101d8aa6f826 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756087 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 225e1952 2021-03-11T17:05:43 Tests: Add Plants vs. Zombies 2 trace Test: angle_perftests --gtest_filter="*plants_vs_zombies_2*" TBR: jmadill@google.com,timvp@google.com Bug: b/182512556 Bug: angleproject:5749 Change-Id: Ib6c279f49ac95964f34e430d311a49600928166b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752898 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
James Darpinian efbb5667 2021-03-11T22:41:06 Revert "Update DEP actions for Python 3" This reverts commit e44595f2297d849115a8fcb52428420dd5756ea3. Reason for revert: build/mac_toolchain.py still fails with my local Python 3.9. Let's not make this change until the top level Chromium DEPS file does. Original change's description: > Update DEP actions for Python 3 > > build/mac_toolchain.py was fixed for Python 3 in > https://crrev.com/c/2727724 > > Bug: angleproject:5707 > Change-Id: I2f233157bedc3cc298250b8efc9bd68ac45cdc28 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2731707 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5707 Change-Id: Ib955a6343d886d273d7e949815fba5366b169386 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753335 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cody Northrop d98e436a 2021-03-11T13:32:07 Tests: Add Lineage M trace Test: angle_perftests --gtest_filter="*lineage_m*" TBR: jmadill@google.com,timvp@google.com Bug: b/182491024 Bug: angleproject:5748 Change-Id: I901b68eef1ddac98ce6e1a4640e2b034d1027a45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752894 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi cb5441ed 2021-03-11T16:15:01 Vulkan: Don't let glslang link shaders The translator outputs intermediate shaders for Vulkan that are later to be modified by the SPIR-V transformer. glslang has no business trying to link them. Bug: angleproject:5740 Change-Id: I9ae418f54b91312b5fd0ef794acbc46a40261a0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753096 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 50f411e1 2021-03-09T17:20:29 Capture/Replay: Support DrawElementsBaseVertex Test: Genshin Impact MEC Bug: b/182307835 Bug: b/181794064 Change-Id: Iedaecb6aa7ab7af189534f620549727f60b69ee8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746657 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Ian Elliott c5a7da47 2021-03-11T13:12:04 Suppress flaky MultithreadingTest on Win/Swangle MultithreadingTest.MultiContextDrawWithSwapBuffers/ES3_Vulkan_SwiftShader_NoVirtual Bug: angleproject:5099 Change-Id: I12ab4a6fb7fff8d6bc7358e6017cb10e46362b88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752893 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Yuly Novikov 7c7cf3e5 2021-03-11T14:27:51 Skip dEQP tests flakily timing out on SwANGLE Bug: chromium:1173237 Change-Id: I93810cb7cbaae847848eae0dc050c2c00df956af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753144 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
John Plate 8507b105 2021-03-11T11:30:39 Fix CL_EVENT macro Bug: angleproject:5745 Change-Id: Icbfab0d0bd4b1510b98d5ed746f4d3ddfa5ec36e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752746 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 7c02cfee 2021-03-11T19:01:13 Avoid undefined behavior in BPTCCompressedTextureTest Bug: angleproject:5360, angleproject:5731 Change-Id: Ia883d2d319d7ce4659f4e1e99b5eccf0e01a45e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752747 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
John Plate 8650381e 2021-03-10T20:08:10 Avoid implication that adding the issue number is optional Bug: angleproject:1944 Change-Id: I89867c20c724c8db4d8edeb15fa4e32769f2a578 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749596 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev b7fc9518 2021-03-08T03:55:36 Do not expose emulated ETC1 textures to WebGL Add a new "emulatedEtc1" limitation. Bug: chromium:1048244 Change-Id: Ia04746773db3ad75781a8adfda988d36bd2c57f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2718865 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev fcd7affb 2021-03-07T17:23:33 Remove unused code from ValidateES2CopyTexImageParameters Compressed formats are rejected earlier with ValidateCopyTexImageParametersBase Bug: angleproject:5731 Change-Id: I7809140af84f2c565008e211adf0f998a0e57e91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2741580 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Ian Elliott 92db3c68 2021-03-10T15:09:15 Vulkan: Disable rotating damage rectangles on Android This fixes visual problems with Android games that use eglSwapBuffersWithDamageKHR(). In 90/270-degree cases, the damage rectangles are being double-rotated, leaving them 90-degrees out of alignment with the window. On Android, VK_KHR_incremental_present is built on top of the same platform code as eglSwapBuffersWithDamageKHR(). The platform code rotates all damage rectangles (assuming they are application-provided). Therefore, ANGLE should not also pre-rotate damage rectangles. Test: Black Desert Mobile Test: Grand Theft Auto: San Andreas Test: Extreme Car Driving Simulator Bug: b/181796746 Change-Id: I6510e7540bb00afc75863e8ae8a9ea3841d1641d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2744984 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Lubosz Sarnecki 36770173 2021-03-10T15:23:03 capture_replay_tests: Don't shadow subprocess import. Rename local variable, so using subprocess.Timeout does not result in an exception. This patch fixes the test timeout counter. Bug: angleproject:5742 Change-Id: Ib6991bc58df6ea653f765dfe9f6117add75b85db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2748339 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 6f74a12b 2021-03-11T10:01:28 Roll SwiftShader from 023914a27b63 to a2fe8e1b2111 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/023914a27b63..a2fe8e1b2111 2021-03-10 srisser@google.com Add Vulkan 1.2 entry points If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ia8aba9350c1c0476441da7f9c5eb20a22dfbfe54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752214 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2cf0729a 2021-03-11T10:03:33 Roll vulkan-deps from 6691fcec0bce to a4e10bfde719 (24 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6691fcec0bce..a4e10bfde719 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/159b057080..a36d91e5ac * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d57ab68a21..60aa24566e * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7d514cf1c7..77eb2b608e * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/4fe5828a02..89d366355e * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/237d3dcb5c..1353e80d87 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/461b33cfa2..d1cd265394 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0ec2c7a693..be60dd27b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I65c8200a79763bdcbc0e32d60d7cac0f89ca786b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752528 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 9265d1e2 2021-03-05T17:54:59 frame_capture_utils: Do not serialize 0 bindings. Since we are only interested in the difference to non-default states, bindings with a zero ID should not be serialized. This resolves the comparision error in the GetTexLevelParameterTest.* tests. The test now do not need to be skipped. Bug: angleproject:5645 Change-Id: I887bc22b52a201c467c00c42f6ddb3b38895a7c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739726 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll ff16821c 2021-03-11T07:01:13 Roll Chromium from 075d29b4983b to 9e42f9e4abc6 (425 revisions) https://chromium.googlesource.com/chromium/src.git/+log/075d29b4983b..9e42f9e4abc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/389d3f34d2..cb067b2df4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fb41d7ef20..32c9b4b55a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/357278b25a..8e820e32d0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7a3a7363a7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fc54e6b87c..e65f1a7cc3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d850327d94..4bd62b06a2 * tools/skia_goldctl/linux: fRRnk-3C4PCCGCwZ4hZCeqm9_BnqznTyThRH4XqRVIIC..X8zqgmHchz43Cvw6xwn3VRL5keLdpA3cD_DqweHLRqMC * tools/skia_goldctl/mac: OLq_hZKAgzddlvSP4YR1TK0_2hzZipwLepMP3lOfS28C..9B5ePukmYbotGUjJuMV-DdjKGW5K0MtKrz8eOpXftu8C * tools/skia_goldctl/win: 5CX5n_psRKwMH74v7aAH4AHynDeTitubHLzeWYyCKv8C..tC_p4_R9hLfNMczJQbjawF5kzgXRVNF-XVcN7bJxrEYC No update to Clang. Bug: angleproject:5739 Tbr: ianelliott@google.com Change-Id: Ia21d911e770be49fd98c757feeb87d58bc5d5a1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2750565 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 44b9579c 2021-03-10T08:10:33 Vulkan: Treat varyings in a separable program as active When separable programs are linked, varyings at the separable program's boundary need to be treated as active. Bug: angleproject:5557 Test: ProgramPipelineTest31.VaryingIOBlockSeparableProgram* Change-Id: I28af2bdf6478a408b3a7155ab4376ed6a19192f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2742659 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Ian Elliott 43271b34 2021-03-10T16:26:50 Revert "Roll vulkan-deps from 6691fcec0bce to 32692e5de307 (12 revisions)" This reverts commit 2aed567fb387ba4775fcb08e7b188e20600a76ed. Reason for revert: Per https://bugs.chromium.org/p/angleproject/issues/detail?id=5741, the glslang change causes tests to fail with internal-linker errors. Original change's description: > Roll vulkan-deps from 6691fcec0bce to 32692e5de307 (12 revisions) > > https://chromium.googlesource.com/vulkan-deps.git/+log/6691fcec0bce..32692e5de307 > > Changed dependencies: > * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/159b057080..84e11a858c > * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d57ab68a21..fb1f295aaf > * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7d514cf1c7..c6da5e343c > * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/4fe5828a02..89d366355e > * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0ec2c7a693..d1de19fea5 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/vulkan-deps-angle-autoroll > Please CC ianelliott@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: ianelliott@google.com > Change-Id: I2bf77ebe46a52a285da0e8911a09f3e22067351a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745003 > Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> > Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bug: None Change-Id: I17f29c93e3a778395c02831740684f0e4aeb342f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746842 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Jonah Ryan-Davis bb6e512e 2021-03-09T16:17:54 Mtl: Add Apple vendor ID On M1 Macs we need to extract Apple's vendor ID. Bug: chromium:1131248 Change-Id: Ie0e4006c3005e0a252d7a27a069a3be47ef4a7d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745703 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Ian Elliott 7c9cb3eb 2021-03-10T10:09:15 Revert "Roll vulkan-deps from 32692e5de307 to 28d8c3478e4c (6 revisions)" This reverts commit b2f547f4f423f492c4483d901d1b3ad5f3ad8798. Reason for revert: Reverting this CL so that I can revert another CL that is causing tests to crash (see: http://anglebug.com/5741). A glslang change causes tests to fail with internal-linker errors. The upstream bug is: https://github.com/KhronosGroup/glslang/issues/2567 Bug: angleproject:5740 Change-Id: I8cde0d6c7004b03c130114af67b791e2871b8459 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2748966 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Mohan Maiya 331640e5 2021-03-09T14:36:19 Vulkan: Pass in the correct size to acquireBufferHelper When BufferVk::acquireAndUpdate calls into acquireBufferHelper to allocate a new buffer helper we were passing in the update size instead of the full buffer size. Modified acquireAndUpdate's parameter to better reflect intent. Bug: angleproject:5689 Change-Id: Ic4fbc015651491ec028d747da5d45670264b93fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746066 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
angle-autoroll b2f547f4 2021-03-10T10:01:33 Roll vulkan-deps from 32692e5de307 to 28d8c3478e4c (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/32692e5de307..28d8c3478e4c Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/fb1f295aaf..60aa24566e * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c6da5e343c..4a59fd4763 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d1de19fea5..be60dd27b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I68384f61f4d3290089441645ee456b9bffa808f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2748474 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5f4a3250 2021-03-10T07:02:00 Roll Chromium from 031d7b5c5879 to 075d29b4983b (268 revisions) https://chromium.googlesource.com/chromium/src.git/+log/031d7b5c5879..075d29b4983b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f33045737d..389d3f34d2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/786c1103e3..fb41d7ef20 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4f82770e78 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5f9e9dff87..d850327d94 * tools/skia_goldctl/linux: pVWUmcQ85_lx3kRUwR24iSVp_YTL6Oa3ZUVqn33pXqUC..fRRnk-3C4PCCGCwZ4hZCeqm9_BnqznTyThRH4XqRVIIC * tools/skia_goldctl/mac: P0qLgrCL8oP-jPdw9rs0tWhuvsx8cVqnV8C1DBI4TNAC..OLq_hZKAgzddlvSP4YR1TK0_2hzZipwLepMP3lOfS28C * tools/skia_goldctl/win: MKEUDKNT8DcyLZqnGZ2-o5TvzpNJbgsYtzzVAxVi2v4C..5CX5n_psRKwMH74v7aAH4AHynDeTitubHLzeWYyCKv8C No update to Clang. Bug: angleproject:5739 Tbr: ianelliott@google.com Change-Id: Icbaff9c118bfc065c5a9afd5fe86b83c0f289aa3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2747458 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 04a641ac 2021-03-04T10:57:37 capture_replay_tests: Change status to crashing. Move both SemaphoreTests to crashing. Don't skip passing VulkanExternalImageTest.*. Explicitly list VulkanExternalImageTest.* tests that still crash. All these tests compile now. Bug: angleproject:5721 Change-Id: Ib529dff8895496925001e4649aabcae78ce77236 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739725 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki c9c75b99 2021-03-04T10:21:03 capture_gles_ext_params: Implement glGetIntegervRobustANGLE. Move RobustClientMemoryTest.* to crashed tests, as it builds now. Bug: angleproject:5721 Change-Id: I590f4bd679374ee3302fc985a53747ddd60dd429 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739724 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 920cb58b 2021-03-09T23:02:40 Vulkan: Fix MemoryBarrier function name typos Bug: angleproject:5070 Change-Id: Ic0c3de4380d02d150e2f52690ded9dfcc07b4575 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2747854 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c7c38731 2021-03-04T15:04:07 Vulkan: Move SpirvBlob definition to common/ For use by the translator. Bug: angleproject:4889 Change-Id: Ie95cafd3cfcdde50acc5d26d3c00e6574186a805 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2737276 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 8844599f 2020-09-11T22:41:36 Vulkan: Create unresolve shader directly in SPIR-V Per issue 4889, dependency to glslang is being dropped. This change generates the unresolve UtilsVk shader directly in SPIR-V. This shader is trivial and contains repeating patterns per attachment. As a result, generating its SPIR-V is exceptionally simple. The SPIR-V in this change is first generated by glslang validator and is then adapted for autogeneration. See comments in the code for details. Bug: angleproject:4889 Change-Id: I48dd77ae04e1035c05a8aef7bf2f161e105ae2a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407179 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Mohan Maiya c054008f 2021-03-06T13:33:11 Vulkan: Check buffer usage before unmapping Buffers with dynamic usage will have frequent CPU updates. Don't CPU unmap such buffers after every update. Commits b5af8bde13 and 58c35d421 took care of performing an unmap when we release the buffer either to the renderer or mBufferFreeList. Bug: angleproject:5689 Change-Id: Ib6b8f6a7d0cb36583140e67bf164e074af098b8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2741688 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Cody Northrop 14152cf4 2021-03-09T11:53:41 Tests: Add Extreme Car Driving Simulator trace Test: angle_perftests --gtest_filter="*extreme_car_driving_simulator*" TBR: jmadill@google.com, timvp@google.com Bug: b/180419767 Bug: angleproject:5735 Change-Id: I5c197a71354a0cb3b907718b7ae7161037f7266f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743806 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop a70a6a9d 2021-03-09T10:38:13 Capture/Replay: Fix compressed cube textures We were only tracking one image per level of cube map textures. Instead, we need to track one per face (6). Test: MEC for Extreme Car Driving Simulator Bug: b/180419767 Bug: angleproject:5735 Change-Id: I59e6a5e83a60666a29f44d0a1e1993a1b461e8e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2744293 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mohan Maiya c935ba5b 2021-03-09T08:40:22 Vulkan: Collect inactive varyings by block name for I/O blocks ANGLE only collects inactive varyings by instance name. The SPIR-V transformer expects I/O blocks to be identified by block name. If an I/O block is inactive, an assertion would fire because the block name is not in the shader variable info map. Bug: angleproject:5676 Test: GLSLTest_ES31.VaryingIOBlockNotDeclaredIn*Shader* Change-Id: I40e51c9770b03457e3896dcb2afa4e9525b098d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2742658 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
angle-autoroll 2eae90ab 2021-03-09T17:14:35 Roll Chromium from 76f6150ffdeb to 031d7b5c5879 (832 revisions) https://chromium.googlesource.com/chromium/src.git/+log/76f6150ffdeb..031d7b5c5879 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/33cb2c879e..f33045737d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/523462a3ce..368c7dd2c9 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/fe29ae7178..c93be42a40 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/aba4fb672b..786c1103e3 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e18c2cc4c2..357278b25a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4f82770e78 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/630ab8a35c..fc54e6b87c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/012c6bcee7..5f9e9dff87 * tools/skia_goldctl/linux: FFNvbEArN40QplEcWmMIDG83rNyxP5fmhDHlHdE-Y94C..pVWUmcQ85_lx3kRUwR24iSVp_YTL6Oa3ZUVqn33pXqUC * tools/skia_goldctl/mac: WCRXBnRqP4DfVUcrclUzE5_p_6x3RZZatC2SM1ZRX4IC..P0qLgrCL8oP-jPdw9rs0tWhuvsx8cVqnV8C1DBI4TNAC * tools/skia_goldctl/win: DpXABD34NuP5941cN5RRg-EPNqCxgt0lA_ga3KIZg4AC..MKEUDKNT8DcyLZqnGZ2-o5TvzpNJbgsYtzzVAxVi2v4C No update to Clang. Bug: None Tbr: ianelliott@google.com,jmadill@google.com Change-Id: I57e80b71db92b5040292f28983d4678dc3a541ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743667 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 7f1c0c3b 2021-03-09T08:09:55 Call resolveLink in Program::attachShader and Program::detachShader Previously glAttachShader and glDetachShader would only call resolveLink during validation. Adding the resolveLink in attachShader/detachShader handles the case where glAttachShader and glDetachShader is called with EGL_CONTEXT_OPENGL_NO_ERROR_KHR to skip validation. Tests: angle_end2end_tests --gtest_filter=ContextNoErrorTest.DetachAfterLink* Bug: angleproject:2868 Change-Id: I1e01cf8e6f8a382333226bdef037c46f4c62a119 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745654 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Yuly Novikov 25c084a7 2021-03-09T12:51:34 Update Xcode used by standalone Mac builders to 12.4 12D4e is latest Xcode 12.4 as of http://crrev.com/c/2715984 Bug: angleproject:2634 Change-Id: I0e0412c7911a109d5351b73a4676c018ee461318 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743669 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Ian Elliott d52cf01a 2021-03-05T16:20:53 Work-around eglSwapBuffersWithDamageKHR() bug During startup of the the "Black Desert Mobile" application, there is a time when it shows white on the right-half of the screen, while the left-half of the screen updates. This appears to be a HWC (compositor) bug related to eglSwapBuffersWithDamageKHR() being used with a full-screen damage area. Test: Black Desert Mobile Test: Grand Theft Auto: San Andreas Bug: b/182213414 Bug: b/181796746 Change-Id: I3d85425e92f654d10b75637c91002812131c2154 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739999 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill ac382039 2021-03-08T16:02:18 Allow graceful no-error failure in CastStateValues. Bug: angleproject:5738 Change-Id: Iecc498b35281b8fd676f1168c3a4ed6b407d18a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743668 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Peng Huang 2b7fdb62 2021-03-04T13:20:32 Reland "Fix bindFramebuffer problem with GLES2 devices" This is a reland of 92049513f46e2d4bc09d47d00f63d64fdb25a220 Original change's description: > Fix bindFramebuffer problem with GLES2 devices > > GLES2 and OpengGL 2 don't support GL_{DRAW,READ}_FRAMEBUFFER. > Always uses GL_FRAMEBUFFER for them. > > Bug: chromium:1167731 > Change-Id: Iab75a27b4c47d0bdaa2ec18a9019fd2d2535b04d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2737062 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: chromium:1167731 Change-Id: I530a47fa3367ca98dbde24e3084515d5562ac8b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743664 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Peng Huang 7ee24229 2021-03-03T15:16:07 Reland "Fix two issues with GLES2 devices" This is a reland of c0ed204de972c76a5428834c94aaa34fd2953329 Original change's description: > Fix two issues with GLES2 devices > > * make sure maxColorAttachments is greater than 0 > * Do not sync read buffer if maxDrawBuffers is 0 > > Bug: chromium:1167731 > Change-Id: Icd0fb5e65ec6ffdc0d6f6325ccd1207958922254 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733268 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> Bug: chromium:1167731 Change-Id: Iccd7b0986c4728e362fccaeda6fbeff2860d888c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743665 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Peng Huang b27740f3 2021-03-09T16:15:15 Revert "Vulkan: Support EXT_sRGB_write_control" This reverts commit 6073af536cf627742696823edc82c9b0a481a8bc. Reason for revert: crbug.com/1186140 Original change's description: > Vulkan: Support EXT_sRGB_write_control > > Implement support for EXT_sRGB_write_control. This extension > requires VK_KHR_image_format_list to be supported. > > The spec requires this functionality to work with glBlitFramebuffer > as well but support for that will be added in a follow up change. > As such, this extension is only exposed in non-conformant mode. > > Bug: angleproject:5075 > Tests: SRGBFramebufferTest.*Vulkan* > Change-Id: I59b38f6cd810a3d0d67ec29f4f19c25f65f70862 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617243 > Commit-Queue: Mohan Maiya <m.maiya@samsung.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:5075,chromium:1186140 Change-Id: Ib0d4d60fe7434fb950f99db2c210aab9af7d2d0e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743663 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Peng Huang <penghuang@chromium.org>
Peng Huang 2d07b04d 2021-03-09T15:23:25 Revert "Fix bindFramebuffer problem with GLES2 devices" This reverts commit 92049513f46e2d4bc09d47d00f63d64fdb25a220. Reason for revert: crbug.com/1186140 Original change's description: > Fix bindFramebuffer problem with GLES2 devices > > GLES2 and OpengGL 2 don't support GL_{DRAW,READ}_FRAMEBUFFER. > Always uses GL_FRAMEBUFFER for them. > > Bug: chromium:1167731 > Change-Id: Iab75a27b4c47d0bdaa2ec18a9019fd2d2535b04d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2737062 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: chromium:1167731, chromium:1186140 Change-Id: I1425bc9cf4145887193b7d18f956d6fbf07ce028 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743661 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Peng Huang <penghuang@chromium.org>
Peng Huang 02a9d011 2021-03-09T15:23:52 Revert "Fix two issues with GLES2 devices" This reverts commit c0ed204de972c76a5428834c94aaa34fd2953329. Reason for revert: crbug.com/1186140 Original change's description: > Fix two issues with GLES2 devices > > * make sure maxColorAttachments is greater than 0 > * Do not sync read buffer if maxDrawBuffers is 0 > > Bug: chromium:1167731 > Change-Id: Icd0fb5e65ec6ffdc0d6f6325ccd1207958922254 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733268 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> Bug: chromium:1167731 Change-Id: Ibd05424889feac0bdb7293426ab41eb1f4753b35 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743662 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll f34a788b 2021-03-09T10:01:56 Roll SwiftShader from de7d5775ab25 to 023914a27b63 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/de7d5775ab25..023914a27b63 2021-03-08 srisser@google.com Add all Vulkan 1.2 feature structs 2021-03-08 swiftshader.regress@gmail.com Regres: Update test lists @ de7d5775 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I5862e0f3ea54a5b666c1bb2cf82811a25990ef7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745314 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2aed567f 2021-03-09T10:01:10 Roll vulkan-deps from 6691fcec0bce to 32692e5de307 (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6691fcec0bce..32692e5de307 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/159b057080..84e11a858c * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d57ab68a21..fb1f295aaf * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7d514cf1c7..c6da5e343c * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/4fe5828a02..89d366355e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0ec2c7a693..d1de19fea5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I2bf77ebe46a52a285da0e8911a09f3e22067351a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745003 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peng Huang 9bc9ac8d 2021-03-04T08:18:54 Disable worker contexts on Android emulator Bug: chromium:1184692 Change-Id: I1b15e24d0cddd287f32ecb7f28568658f16b776d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2735375 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 57727c4e 2021-03-08T17:32:25 Further suppress tests failing on Ozone. Since MipmapTest and Texture3DTestES2 fail in testSetUp(), it also needs to be skipped, in addition to the failing tests. Also suppress instantiation error for ES3-only QueryObjectTest Bug: angleproject:5725, angleproject:5728, angleproject:5704 Change-Id: Iac6549afd7609a2aee78bcfdb7c3de41886f3505 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743920 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Peng Huang 92049513 2021-03-04T13:20:32 Fix bindFramebuffer problem with GLES2 devices GLES2 and OpengGL 2 don't support GL_{DRAW,READ}_FRAMEBUFFER. Always uses GL_FRAMEBUFFER for them. Bug: chromium:1167731 Change-Id: Iab75a27b4c47d0bdaa2ec18a9019fd2d2535b04d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2737062 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev ffd80394 2021-03-06T13:32:09 Metal: Enable iOS pixel formats on macOS 11 Bug: angleproject:2634, angleproject:5672 Change-Id: Idd1cc325067e73b02f4f82b2d78d20420e50645b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739729 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 6073af53 2021-03-08T11:21:31 Vulkan: Support EXT_sRGB_write_control Implement support for EXT_sRGB_write_control. This extension requires VK_KHR_image_format_list to be supported. The spec requires this functionality to work with glBlitFramebuffer as well but support for that will be added in a follow up change. As such, this extension is only exposed in non-conformant mode. Bug: angleproject:5075 Tests: SRGBFramebufferTest.*Vulkan* Change-Id: I59b38f6cd810a3d0d67ec29f4f19c25f65f70862 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617243 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang 4efe33e3 2021-03-04T07:45:20 Fix two GL_OES_texture_half_float related problems with GLES2 * Fix incorrect ASSERT in formatutilsgl.cpp * CheckInternalFormatRenderbufferRenderability() and CheckSizedInternalFormatTextureRenderability() may cause GL errors, we should clear them. Bug: chromium:1174074 Change-Id: Ieef5e79b68f317833b459da34cc2e5362f813304 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2735374 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 74562a2d 2021-03-05T16:00:25 Add Win x86 chromium.angle bots to CQ Bug: angleproject:4483 Change-Id: Ib3c1dc81340ac792a2c4aa7a2473688b4a036aef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739386 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Peng Huang c0ed204d 2021-03-03T15:16:07 Fix two issues with GLES2 devices * make sure maxColorAttachments is greater than 0 * Do not sync read buffer if maxDrawBuffers is 0 Bug: chromium:1167731 Change-Id: Icd0fb5e65ec6ffdc0d6f6325ccd1207958922254 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733268 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Alexey Knyazev a272a8ac 2021-03-07T20:04:49 Fix PVRTC1 frontend validation PVRTC1 texture dimensions must always be powers of two. Moreover, Apple hardware requires them to be squares. Bug: angleproject:5731, angleproject:2634 Change-Id: I5fcdc364b37d17b60cf772c21ba38795272236fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2741585 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Mohan Maiya 92b5fccd 2021-03-02T08:43:18 Handle nullptr in GetQueryObjectParameter() There are applications that disable validation using EGL_CONTEXT_OPENGL_NO_ERROR_KHR extension. In such usecases the GetQueryObjectParameter() method needs to account for the possibility that the query object has not yet been created. Bug: angleproject:5704 Tests: angle_end2end_tests --gtest_filter=QueryObjectTest* Change-Id: Ib9e1cb32a6d64f2772124178223cf07cbb84691b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729298 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
angle-autoroll faa3915e 2021-03-08T10:01:28 Roll SwiftShader from 6846389f25ca to de7d5775ab25 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/6846389f25ca..de7d5775ab25 2021-03-05 srisser@google.com Fix missing feature from vkCreateDevice case-list If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I26543003b238a9157f16c756c5f17dd3a4593942 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2740551 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 9bc86c50 2020-10-13T13:26:08 Metal: Implement OES_draw_buffers_indexed Bug: angleproject:2634 Bug: angleproject:4394 Change-Id: Id6e6c6bdea2b1ff3d974e92e067ed63e1b4e4582 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2465919 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 8b1d1fb6 2021-03-06T19:40:45 Roll VK-GL-CTS from a9c07acc33bc to c4e6dbe68e04 (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/a9c07acc33bc..c4e6dbe68e04 2021-03-06 rgarcia@igalia.com Ray query hitT direction length tests 2021-03-06 lionel.g.landwerlin@intel.com Verify submit with wait on timeline semaphore with 0 value 2021-03-06 piotr.byszewski@mobica.com Test timeline semaphore with two threads 2021-03-06 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2021-03-06 alexander.galazin@arm.com Support GL 4.5 in the Texture Filtering Tests 2021-03-06 alexander.galazin@arm.com Support GL 4.5 in the sRGB skip decode tests 2021-03-06 ilkka.saarelainen@siru.fi Use SPV_KHR_physical_storage_buffer extension 2021-03-06 boris.zanin@mobica.com Fix build indirect structure tests 2021-03-06 srisser@google.com Fix wrong semaphore type being queried 2021-03-06 rgarcia@igalia.com Fix fragment shading rate validation errors 2021-03-06 mohd.faisal@arm.com Fix missing check for supported device features 2021-03-06 tom.cooper@arm.com Allow OOM for maxImageExtent swapchain cases 2021-03-06 ilkka.saarelainen@siru.fi Decrease required subgroup size 2021-03-06 slawomir.cygan@intel.com Add needed extension and feature checks in mismatched_write_op test 2021-03-06 piotr.byszewski@mobica.com Fix decoration_group tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jonahr@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com,angle-bots+autoroll-info@google.com Change-Id: Ic8ad7f69f4592b78a8de798718134c6e7c343e03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2740749 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov a0bc2589 2021-03-05T19:27:04 Skip tests failing on Ozone. MipmapTest.DefineValidExtraLevelAndUseItLater MipmapTest.GenerateMipmapAfterModifyingBaseLevel MipmapTest.GenerateMipmapAfterSingleLevelDraw MipmapTest.GenerateMipmapFromInitDataThenRender MipmapTest.GenerateMipmapFromRenderedImage MipmapTest.MipMapGenerationD3D9Bug MipmapTest.MipmapsForTexture3DOES MipmapTest.RenderOntoLevelZeroAfterGenerateMipmap MipmapTest.TextureCubeGeneralLevelZero MipmapTest.TextureCubeRenderToLevelZero MultisampleTest.AlphaToSampleCoverage MultisampleTest.ContentPresevedAfterInterruption MultisampleTest.Line MultisampleTest.Point MultisampleTest.Triangle Texture3DTestES2.CopySubImageAlpha Texture3DTestES2.CopySubImageLuminance Texture3DTestES2.CopySubImageRGBA Texture3DTestES2.Luminance Texture3DTestES2.RGBA Bug: angleproject:5725, angleproject:5727, angleproject:5728 Change-Id: Ibe7d7e44e01ce430e381edd0c83c3e24069b35aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738718 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 9fc51e82 2021-03-06T00:34:46 Roll VK-GL-CTS from 9be79728eafb to a9c07acc33bc (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9be79728eafb..a9c07acc33bc 2021-03-03 gleese@broadcom.com Remove dubious const-casting in mismatched_write_ops tests 2021-03-03 pdaniell@nvidia.com Including testing zw components with fragcoord_msaa tests 2021-03-03 rgarcia@igalia.com Ray tracing hitT direction length tests 2021-03-03 lionel.g.landwerlin@intel.com Don't forget to enable KHR_fragment_shading_rate 2021-03-03 rgarcia@igalia.com Fix compute binding storage buffer alignment 2021-03-02 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jonahr@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com,angle-bots+autoroll-info@google.com Change-Id: I75cd592134f980b30f0d1a88c3fa56f604ec9e80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2740004 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ccfade07 2021-03-05T20:58:12 Roll Chromium from e3e89758c942 to 76f6150ffdeb (205 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e3e89758c942..76f6150ffdeb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/359c085ec7..33cb2c879e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/adb70871cf..aba4fb672b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e5299ca5b7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/791d56c8f0..630ab8a35c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/77e2f88df4..012c6bcee7 * tools/skia_goldctl/mac: 1eS-4K0xTtzfvP8vAOAjti_D7ynUHaksiVFAzZEMShIC..WCRXBnRqP4DfVUcrclUzE5_p_6x3RZZatC2SM1ZRX4IC * tools/skia_goldctl/win: 2dvsgu3V4NQRDUdbOExgmxG2IsdKffTY9pvmduflAWYC..DpXABD34NuP5941cN5RRg-EPNqCxgt0lA_ga3KIZg4AC No update to Clang. Bug: angleproject:4483 Tbr: jonahr@google.com,ynovikov@google.com Change-Id: I360b0f104a02443bcea8a93cf69d2a11b4c4e55a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739996 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll a318b3d6 2021-03-05T16:38:47 Roll VK-GL-CTS from 9cdde06fb38a to 9be79728eafb (18 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9cdde06fb38a..9be79728eafb 2021-03-02 ynovikov@google.com Fix Windows build 2021-03-01 alexander.galazin@arm.com Update Vulkan headers 2021-02-25 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2021-02-25 rgarcia@igalia.com Pipeline bind point tests 2021-02-25 rgarcia@igalia.com Add tests for sparseImageFloat32Atomics 2021-02-25 anholt@google.com Fix more spurious failures in KHR-GL*.transform_feedback.api_errors_test 2021-02-25 anholt@google.com Fix spurious failures on KHR-GL30.transform_feedback.api_errors_test 2021-02-25 tapani.palli@intel.com Print ints for pixel values instead of chars in error message 2021-02-25 thomas.spurden@broadcom.com Fix exit code for cts-runner 2021-02-25 mikko.tiusanen@siru.fi Tests for GLES3 framebuffer completeness 2021-02-25 alexander.galazin@arm.com Support GL 4.5 in the Program interface query tests 2021-02-25 lionel.g.landwerlin@intel.com Silence validation layers warning on missing sType 2021-02-25 mika.vainola@siru.fi Allow wildcards in waiver vendor strings 2021-02-25 boris.zanin@mobica.com Add a list of unused shaders into log 2021-02-25 boris.zanin@mobica.com Add concurrent transform feedback streams query tests 2021-02-24 gleese@broadcom.com Remove a waiver for a non-existant device 2021-02-23 mika.vainola@siru.fi Add tests for implicit unmap on free 2021-02-23 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jonahr@google.com,angle-bots+autoroll-info@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:5684, angleproject:5722 Tbr: jonahr@google.com,angle-bots+autoroll-info@google.com,ynovikov@google.com Change-Id: Ibd432a2135665ed89f93549e24923c108a08f97b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739041 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov a1f86b4d 2021-03-05T16:55:47 Skip vulkan_car_parking_multiplayer on Win Intel Internal Vulkan error (-4): The logical or physical device has been lost. Bug: angleproject:5724 Change-Id: I80eb21d087341fac23393d7365bd5ea4c5ac6e05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739387 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 8a48f4de 2021-03-05T14:33:16 Skip CopyTextureVariationsTest failing on Ozone CopyTextureVariationsTest.CopyTexture CopyTextureVariationsTest.CopySubTexture Bug: angleproject:5723 Change-Id: Iad62344b9bc503a2553647877c5975b03bb6829d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738602 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Amy Liu 0ee360de 2021-03-05T06:02:25 Revert "Compression of the data from vkGetPipelineCacheData." This reverts commit cc5083e071e9e0663979c02376e7848c7de11765. Reason for revert: Re-land this patch after fixing the performance regression of big blob cache (discussed in angle issue 4722). Original change's description: > Compression of the data from vkGetPipelineCacheData. > > The size of pipelineCacheData sometimes is greater than > 64k which cannot be saved because of the Android blob cache > limitation (single cache data size should be < 64k). > Implement the compression to store more cache data. > > Bug: angleproject:4722 > Change-Id: I435b086d70d0e6378f1141464ae2bafbe076f193 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2631511 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:4722 Change-Id: Ie4de10eabf5cd8f0b4748e2c1a4c3ab6b8ea092c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739098 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 32bf7d41 2021-03-05T13:40:53 Fix Apple GPU detection for M1 Renamed supportsIOSGPUFamily to supportsAppleGPUFamily to match official naming. Bug: angleproject:5672 Change-Id: Ic02c0f01bc30c12cef594cc2eb4f9932c22c1e33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739459 Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki d96b9ffa 2021-03-04T09:57:53 capture_replay_tests: Don't skip tests that pass. These tests were skipped due to compilation problems, but do now fully pass on SwiftShader ES2. Remove PointSpritesTest.PointWithoutAttributesCompliance/* Remove ExplicitContextTest.GetProcAddress/* Remove RobustBufferAccessBehaviorTest.EmptyBuffer/* Remove EGLSyncTest.AndroidNativeFence_WaitSync/* Bug: angleproject:5721 Change-Id: I3f50272c69ba78e2432f4278753e5d48d8601910 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739723 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi e366e2c3 2021-02-27T01:00:02 Vulkan: Keep dynamic buffer's free list trimmed ContextVk's staging buffer never gets a chance to free its free buffer list. During application load time, a large amount of memory may be allocated from this buffer to stage texture updates and they would remain throughout the life of the application. This change ensures that the free buffer list doesn't grow unbounded. In the Manhattan trace, this saves >1GB of memory on Linux. There are now three policies for vk::DynamicBuffer: - Always reuse buffers: This is useful for dynamic buffers that make frequent small allocations, such as default uniforms, driver uniforms, default vertex attributes and UBO updates. - Never reuse buffers: This is for situations where the buffer is unlikely to be used after some initial usage, such as texture data upload or vertex format emulation (as the conversion result is cached, so it's never redone). - Limited reuse of buffers: For the staging buffer in the context which is shared by all immutable texture data uploads, it's useful to keep a limited number of buffers (1 in this change) to support future texture streaming while allowing a large number of buffers allocated in a burst to be discarded. Bug: angleproject:5690 Change-Id: Ic39ce61e6beb3165dbce4b668e1d3984a2b35986 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725499 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll b23644d3 2021-03-05T11:23:04 Roll vulkan-deps from c0db6ae3d87d to 6691fcec0bce (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c0db6ae3d87d..6691fcec0bce Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f7043c0de6..7d514cf1c7 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a4cb494bee..0ec2c7a693 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Icb57948ab38a5d6e48e8741dca831cf8148bbfb0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739697 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 40ed11b7 2021-03-05T10:01:22 Roll SwiftShader from 084529f3a9b9 to 6846389f25ca (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/084529f3a9b9..6846389f25ca 2021-03-04 srisser@google.com Implement VK_KHR_timeline_semaphore If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I649661d8859df2f4c26aeac02cf4df06e66e78d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738440 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 97127961 2021-03-05T07:06:54 Roll Chromium from 143c12daa39f to e3e89758c942 (782 revisions) https://chromium.googlesource.com/chromium/src.git/+log/143c12daa39f..e3e89758c942 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/122de421bd..359c085ec7 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b60d41f762..523462a3ce * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8f03866f94..fe29ae7178 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/33e44690c0..adb70871cf * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/800c09f4d7..e18c2cc4c2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cdacb3b199 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6a9fd91d34..791d56c8f0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ee85ae1c83..77e2f88df4 * tools/skia_goldctl/mac: WCRXBnRqP4DfVUcrclUzE5_p_6x3RZZatC2SM1ZRX4IC..1eS-4K0xTtzfvP8vAOAjti_D7ynUHaksiVFAzZEMShIC * tools/skia_goldctl/win: DpXABD34NuP5941cN5RRg-EPNqCxgt0lA_ga3KIZg4AC..2dvsgu3V4NQRDUdbOExgmxG2IsdKffTY9pvmduflAWYC No update to Clang. Bug: angleproject:4483 Tbr: jonahr@google.com Change-Id: I22a31605b07c7308f26833ebbafc9bba5fcb5219 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738465 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya fe2efefa 2021-02-27T08:28:03 Add FramebufferAttachmentPerfTest Two tests are added to measure the overhead involved in the Observer/Subject interface - 1. FramebufferAttachmentBenchmark - stresses repeated attach/detach of observers to subjects. 2. FramebufferAttachmentStateUpdateBenchmark - stresses state updates to subjects and their propagation to observers. Bug: angleproject:5692 Change-Id: I6e573f3a948ef2b20c56091e549eb871051e0103 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725740 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Eng 8092ed72 2021-03-04T21:29:55 Revert "Add support for Linux GPU info with Vulkan backend" This reverts commit 5c09c1f882f15e1a77577f1a62d861355aac90a4. Reason for revert: Breaks the Chrome OS build. Original change's description: > Add support for Linux GPU info with Vulkan backend > > 1. Add support for Linux GPU info with vulkan backend: for > dev board without PCI support, try vulkan backend to get > GPU info. > 2. Fix getVulkanInstance() issue when loading non-exist lib: > return NULL instance if open lib failed. > > Bug: angleproject:5717 > Change-Id: I03c11da25a8787496d098f6c9d6b4c53701383e4 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734375 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5717 Change-Id: I97a27295818371556fd09837485a9132f74748c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2737557 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
Mohan Maiya 58c35d42 2021-03-02T09:00:55 Vulkan: Unmap buffer when adding to mBufferFreeList The commit b5af8bde13 moved the unmap call on a buffer to when it is placed in mBufferFreeList. There was one place that was missed, rectifying that oversight here. Bug: angleproject:5689 Change-Id: Iaed2916de374d55ab59276e2679c23ed7ef9c4e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733476 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jason Macnak 60ad763d 2021-03-01T15:29:51 Vulkan: Enable EGL_ANDROID_recordable for EGL configs on SwiftShader There does not seem to be a way to query the Gralloc and Vulkan drivers for recordable support so keep this as a narrow hack restricted to SwiftShader. Bug: b/181163023 Test: `cts -m CtsMediaTestCases` on Cuttlefish w/ SwANGLE Change-Id: I0bfee01d43ea8e3d9965f5bfaa578a285d37db29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727874 Commit-Queue: Jason Macnak <natsu@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 559cb622 2021-03-04T12:39:24 infra/config: Rename console/list views. The new simpler names "ci" and "try" prevent URLs with space characters. Bug: angleproject:5559 Change-Id: I3e16f88553cc979cdddf2f2e5ff34b2be74b7dae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2737059 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 2f737c25 2021-02-25T16:55:14 Translator: Rename GLSL to SPIR-V in Vulkan and Metal output Preparation for actual SPIR-V output instead of GLSL. Bug: angleproject:4889 Change-Id: Ic279b23d3a817bd5dca66a844905378207afdbac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2721194 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Yuly Novikov a6b16d29 2021-03-02T19:04:57 Suppress UNINSTANTIATED_PARAMETERIZED_TEST failures on Ozone We only support ES2 on Ozone, so tests that depend on ES3 or ES31 support are not instantiated there. Bug: chromium:1183147 Change-Id: Id58bcd9b44a5b9a70b5ae8115e27c44f5dc81226 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726550 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Xiaoxuan Liu 5c09c1f8 2021-03-03T17:56:07 Add support for Linux GPU info with Vulkan backend 1. Add support for Linux GPU info with vulkan backend: for dev board without PCI support, try vulkan backend to get GPU info. 2. Fix getVulkanInstance() issue when loading non-exist lib: return NULL instance if open lib failed. Bug: angleproject:5717 Change-Id: I03c11da25a8787496d098f6c9d6b4c53701383e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734375 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 54294c9a 2021-03-02T22:15:05 Partially upgrade codegen to Python 3 Bug: angleproject:5707 Change-Id: I4e26c2c7ba4a36185b28ecd6e87be1161b60431a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729567 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 8b55a3e5 2021-03-03T16:35:53 Replace Win x64 dEQP GPU.FYI bots with chromium.angle bots Bug: angleproject:4483 Change-Id: I6b09f2c97e07eca90c71211e23ddd931637e7dda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733270 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll d0c8d6a9 2021-03-04T10:01:21 Roll SwiftShader from 106e01583a3a to 084529f3a9b9 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/106e01583a3a..084529f3a9b9 2021-03-03 venni.ihanakangas@siru.fi Add support for internal error status checking in regres If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I7c91c5c9be050ba22d351e0cde05814054007cc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734636 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2429e065 2021-03-04T10:01:04 Roll vulkan-deps from 6c3f8d8c39b9 to c0db6ae3d87d (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6c3f8d8c39b9..c0db6ae3d87d Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/939bc02603..f7043c0de6 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/88ea55de92..461b33cfa2 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b95891b0b1..a4cb494bee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I6ef4cbfc43b39c97bcd683600501ca3cd8b9318a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734694 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 0224e848 2021-03-03T14:31:07 Vulkan: Fix overlay graph widgets Bug: angleproject:5690 Change-Id: I9a63fd91c7403f8bf1ee6ef25fc636aecfbe6ea0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732533 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 49211c31 2021-03-02T11:22:28 Vulkan: Fix Overlay for prerotation Bug: angleproject:5690 Change-Id: I906a259767c54e3ac9f3ac822b6d5ed5dcaa0bd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725768 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>