kc3-lang/angle
Branch :
Log
| Author | Commit | Date | CI | Message |
|---|---|---|---|---|
 |
9ff58ddd | 2020-08-26 01:08:00 | Metal: Support array of matrices varying. MSL doesn't support array of matrices as varying variable. This CL converts array of matrices varying to array of vectors. This fixes WebGL test: conformance/glsl/misc/shader-varying-packing-restrictions.html Bug: angleproject:4846 Bug: angleproject:2634 Change-Id: I3cfc638dc01092ddf1add7df02c131d1a5c8ba1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2392172 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
 |
49f01a53 | 2020-09-18 11:38:14 | Vulkan: Add features to modify sampling parameters Add features to optionally increase the LoD offset of all sampling operations or disable linear filtering. These can be used to compare performance without recompiling ANGLE. These features could be potentially implemented in the frontend it is more difficult because the features are not available at texture initialization time. Bug: b/167404532 Change-Id: Ifcf56fbcf130c24c54834737733bbffa5ade3959 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411475 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
 |
ed899835 | 2020-09-11 21:21:55 | Vulkan: Allocate descriptor pools with layouts Descriptor set layouts and pools are very tightly coupled, since their binding types and counts must match to ensure the number of available descriptor sets within a pool remains accurate. To enforce this, the descriptor pools will now keep a copy of the VkDescriptorSetLayout that the pool was created for, which is verified when a descriptor set is allocated from the pool. If the handles don't match, an ASSERT() will fire. Bug: angleproject:5033 Test: CQ Change-Id: I4faf82c24f31052e57b656c968788bb0c131b619 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407282 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Tim Van Patten <timvp@google.com> | |
 |
cb286073 | 2020-09-20 21:59:24 | Use c++ thread_local for current thread. This solves a race condition using the global context. Sadly we can't use an unprotected variable safely because it can be written/read from multiple threads doing MakeCurrent. Has about a 2 ns regression when tested in Linux/Release per call. "null" benchmark test went from 27 -> 29 ns/iteration. Fixes a TSAN warning that popped up in angle_end2end_tests. Test: DrawCallPerfBenchmark.Run/vulkan_null Test: EGLContextASANTest.DestroyContextInUse/ES3_Vulkan Bug: b/168744561 Change-Id: Ic56f3faae81c1087b942a3cfc0e011b9ab439e0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419641 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
ab0b4b1d | 2020-09-17 13:01:32 | Initialize InternalFormat::blendSupport. Detected by the clang static analyzer. Bug: angleproject:5008 Change-Id: I773c8219b0c7ff63a2a98edefc5bebab7a9aabd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416829 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> | |
|
499173de | 2020-09-20 10:42:56 | Pass #pragma optimize setting down to compilation. This will allow us to disable optimizations in the back-end. This can be useful both for developers and for ANGLE to disable very slow shader compilation on D3D11. Also apply this pragma to VerifyMaxVertexUniformVectorsWithSamplers. Reduces compilation time by half in local testing. Bug: angleproject:5076 Change-Id: I64ad576e11b9cee5b41f8af0d3621570304d65c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2420749 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> | |
|
eed069b3 | 2020-09-22 08:55:32 | Give restricted gold tests executable bit. Bug: angleproject:4090 Bug: b/168049670 Change-Id: Ie3a46d4689e40958460c1f26a228645d84b3305c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423211 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
867358b7 | 2020-09-21 23:40:57 | Test Runner: Improve sharding validation. The prior check was incorrectly flagging index=0/count=2 as invalid. It also missed a few cases like a shard count of 0. Bug: angleproject:3162 Change-Id: Ida4c0f454ece15e4304d024d205475acf0f135e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423207 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
 |
4f6c6d5a | 2020-09-22 10:01:58 | Roll SwiftShader from fe878dedd5ad to 6aadd31a5f98 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/fe878dedd5ad..6aadd31a5f98 2020-09-21 srisser@google.com Implement VK_KHR_image_format_list If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I1eec7e1f6d8f7291f6d7650fd31001a4b8a4a970 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423538 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
a6079e3d | 2020-09-22 10:01:57 | Roll Vulkan-Loader from a148cdd49041 to 8fdc21e4078d (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a148cdd49041..8fdc21e4078d 2020-09-21 shannon@lunarg.com build: Update known-good files for 1.2.154 header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I69990e0ca5dca2aabe692dc26db38353154ed854 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423537 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
44623aec | 2020-09-22 10:01:04 | Roll SPIRV-Tools from 60ce96e2ff10 to 125b64241909 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/60ce96e2ff10..125b64241909 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I4a10c5b8d742413ae3379394eb550acecbf3e91d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423535 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
566821cb | 2020-09-21 23:57:13 | Suppress 3 more Intel/GL/Compute shader fails. Happen when run in different orders. This time with a test variation with 2 shards instead of 4. ComputeShaderTest.DrawTexture1DispatchTexture2/ES3_1_OpenGL ComputeShaderTest.UniformBuffer/ES3_1_OpenGL ComputeShaderTest.BindImageTextureWithMixTextureTypes/ES3_1_OpenGL Bug: angleproject:5072 Change-Id: Iddec2b795dc380e29a0124195491fcf6ec0520bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423208 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
d7149f2a | 2020-08-26 19:44:54 | Metal: Disable unused attribute slots. If an attribute slot is unused and user enables it but doesn't bind any buffer, Metal validation layer will complain that a buffer slot is missing (even though the slot is not used inside shader). Fix: if shader program doesn't use an attribute slot or there is no buffer bound to it, then disable that attribute. Bug: angleproject:2634 Change-Id: Ib56e0bf64bab13efce8b2972bfe386e26f45e50e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2392171 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
 |
f39e0f01 | 2020-09-07 23:07:37 | Vulkan: Use subpass to unresolve render-to-texture attachments GL_EXT_multisampled_render_to_texture allows singlesampled textures to be used with multisampled framebuffers in such a way that the final resolve operation is automatically done. In Vulkan terminology, the render-to-texture GL attachment is used as a Vulkan subpass resolve attachment with an implicit (ideally-)lazy-memory multisampled image as the color attachment. This extension expects that if the texture is drawn to after the automatic resolve, the implicit multisampled image would take its fragment colors from the singlesampled image. In other words, the opposite of a resolve operation should be automatically performed at the start of the render pass. This change refers to this operation as "unresolve". The goal of this extension is to allow tiling GPUs to always keep multisampled data on tile memory and only ever load/store singlesampled data. The latter is achieved by using a subpass resolve attachment and setting storeOp of the multisampled color attachment to DONT_CARE. This change achieves the former by using an initial subpass that uses the resolve attachment as input attachment, draws into the multisampled color attachment and sets loadOp of said attachment to DONT_CARE. Bug: angleproject:4881 Change-Id: I99f410530365963567c77a7d62fc9db1500e5e3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2397206 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
5ec560fb | 2020-09-17 17:18:25 | Add restricted trace golden image script test. The script reads the list of tests from the restricted traces JSON and runs angle_perftests once for each test. Running the tests in a batch seems unstable on some platfroms so running each test separately works around that limitation. It does not yet interact with Skia Gold. The Gold integration will come later once this basic skeleton is running on the bots. Also updates the perf tests to exit more quickly with --one-frame-only. This will speed up the screenshots. Example run with trigger.py: https://chromium-swarm.appspot.com/task?id=4ecb985330a33910 Bug: angleproject:4090 Bug: b/168049670 Test: tested with trigger.py Change-Id: I52820dfba2acfbc5d638673c37297877e8476adb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2417641 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> | |
|
8f7970cb | 2020-09-21 18:25:21 | Trace/Replay: Reset replay after taking a screenshot. This was causing a replay state tracking error that could fail some traces. For example, Mobile Legends. Bug: angleproject:4090 Bug: b/168049670 Change-Id: Ia4c2db795bb861fba77c9c35217ab22c2004c492 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422686 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> | |
 |
a7e03ed7 | 2020-09-21 14:56:00 | Vulkan: Further refine invalidate for depth/stencil Bug: angleproject:5079 Change-Id: Idc732b1e6729b2776d66c63c3ae2bd94e11bdbb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422684 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com> | |
|
edc0d2ee | 2020-09-15 16:02:05 | Vulkan: Disallow loadOp=LOAD for MSRTT depth/stencil textures EXT_multisampled_render_buffer2 specifies that depth/stencil textures are expected to be in a perpetual state of invalidated, except during rendering. This change makes sure that they never use loadOp=LOAD. Additionally fixes a bug where clears applied to MSRTT depth/stencil textures didn't take effect because they were applied to the multisampled image (since the resolved image was not given to the render target). Bug: angleproject:4836 Bug: angleproject:5063 Change-Id: I4506f4de415dca6c222111a1ae62017d2fb1e2b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2412848 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> | |
|
bdecaf33 | 2020-08-04 20:16:27 | Metal: Implement PBO. Bug: angleproject:2634 Change-Id: I77f085227298bf46361825d1886e04830dc9987a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336558 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
7b7e52fa | 2020-09-21 13:17:25 | Vulkan: Fix copy-paste error in hasCopyImageView A previous CL had a copy-and-paste error in hasCopyImageView(). It was calling getFetchImageView().valid() instead of getCopyImageView().valid(). Bug: b/161993151 Change-Id: I40335ad51585735e9d68781557693ede67096e7d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422085 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com> | |
 |
15823ab0 | 2020-09-15 15:21:58 | Metal: Implement ASTC LDR support Bug: angleproject:2634 Change-Id: If7ea09de384c8bc8727523f20fe17641127fcf9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411982 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
|
57193e8b | 2020-09-13 23:58:42 | Vulkan: Optimize Attribute Change Perf (5/5) This patch series optimizes programs that use the pattern: for (;;) { glVertexAttribPointer(...) glDraw(...) } Change 5: Re-check fragment opts on necessary changes. Check on a program binding change and on a sample coverage enabled chagne. This likely could be optimized further for program binding changes. In total the patch series reduces test iteration time by 25%. Test: DrawCallPerfBenchmark.Run/vulkan_attrib_change Bug: angleproject:5045 Bug: b/168493024 Change-Id: I5116f228d5eeef6606136a9a0cc81a4545df9d33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409177 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> | |
|
a9dcf0ea | 2020-09-21 09:44:18 | Fix early fragment tests optimization condition. The optimization should check of "alpha to coverage" is enabled, not just sample coverage. Bug: angleproject:4508 Bug: angleproject:5045 Bug: b/168493024 Change-Id: I0e52ddd4c92f9a6ea8a0e7cf56db71ce9ff3c5de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422078 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
1b436e07 | 2020-09-15 13:37:33 | Metal: Implement BPTC support Use autogen for setting compressed format caps. Bug: angleproject:2634 Change-Id: I8cfb57390751615c08f798f223f4db3deed2fff6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411979 Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> | |
 |
e56ccc49 | 2020-09-21 14:38:39 | Skip Texture2DTest.TexStorageWithPBO on Win NVIDIA GL Fails on 456.38 driver. Bug: angleproject:5081 Change-Id: Ic92f4a9911d97209fd7240f5ba93ee6f81dd3ace Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422083 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> | |
|
5d7de5fd | 2020-09-20 13:09:07 | Test Runner: Fix default config grouping. Running "angle_unittests" with --bot-mode would produce noisy test groupings for each permutation of parameterized tests. Fix this by only splitting configs that begin with "ES". e.g. ES2_Vulkan, ES3_OpenGL, etc. Bug: angleproject:3162 Change-Id: I0b0ebe1c9cef9cbbce0489a2bc3f62761d43a1c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419046 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> | |
|
763e8b81 | 2020-09-20 21:59:23 | Test Runner: Add more timeout logging. Will help diagnose a timeout failure on Windows Intel. Also reduce the significant digits in time output. Bug: angleproject:3162 Change-Id: I6d6a852f572875f613dec8e4ab6e798dfde0ca9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2420331 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
|
e0eb7d2e | 2020-09-21 03:19:07 | Metal: Fix wrong FormatID enum order used by PBO autogen shaders. FormatID_autogen.h's enums' order was altered by CL https://chromium-review.googlesource.com/c/angle/angle/+/2413165 However, Metal default shaders relied on old order thus the result PBO related computation based on enum value has become wrong. This CL reuse gen_angle_format_table.gen_enum_string() function to generate format enums for both - src/libANGLE/renderer/FormatID_autogen.h (used by C++) - src/libANGLE/renderer/metal/shaders/format_autogen.h (used by Metal default shaders) Bug: angleproject:2634 Change-Id: I52fad168d1932e0386dcf789574f06d341dbd9c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418500 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
|
dd0a9ec9 | 2020-09-20 12:50:21 | Test Runner: Allow empty sharding parameters. The prior check was incorrectly validating a shard index of zero and a shard count of one as inconsistent. Bug: angleproject:3162 Change-Id: I63184c16e82f08080b275672a43e6dacf291560d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419045 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> | |
|
7676ec12 | 2020-08-29 10:48:28 | Remove zlib from export_target exceptions. Note: contrib/optimizations/slide_hash_neon.h is inside zlib. It is conditionally included which is why it needs to be in the exceptions. Bug: chromium:1032721 Change-Id: I1da8bb2b12cfe44fca7ce8a423aa33c5e964f05f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419043 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
|
6d1bf2b4 | 2020-09-20 21:59:23 | Give trigger.py executable bit. Bug: angleproject:3162 Change-Id: I4ebd0ccf397568aeaa62a033155e70024a806965 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2420333 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
|
a87964cd | 2020-09-20 21:59:23 | Suppress Linux GL Compute Tests on Intel. ComputeShaderTest.AtomicFunctionsInNonInitializerSingleAssignment/ES3_1_OpenGL ComputeShaderTest.AtomicFunctionsInitializerWithUnsigned/ES3_1_OpenGL ComputeShaderTest.AtomicFunctionsNoReturnValue/ES3_1_OpenGL ComputeShaderTest.AtomicFunctionsReturnWithMultipleTypes/ES3_1_OpenGL ComputeShaderTest.AtomicFunctionsReturnWithUnsigned/ES3_1_OpenGL ComputeShaderTest.DispatchDraw/ES3_1_OpenGL ComputeShaderTest.DrawDispatchDispatchDraw/ES3_1_OpenGL ComputeShaderTest.LoadImageThenStore/ES3_1_OpenGL ComputeShaderTest.NonArraySharedVariable/ES3_1_OpenGL ComputeShaderTest.NonStructArrayAsSharedVariable/ES3_1_OpenGL ComputeShaderTest.StoreImageThenLoad/ES3_1_OpenGL ComputeShaderTest.StructArrayAsSharedVariable/ES3_1_OpenGL ComputeShaderTest.UniformDirty/ES3_1_OpenGL ComputeShaderTest.groupMemoryBarrierAndBarrierTest/ES3_1_OpenGL GLSLTest_ES31.ArraysOfArraysImage/ES3_1_OpenGL GLSLTest_ES31.MixOfAllResources/ES3_1_OpenGL LinkAndRelinkTestES31.RelinkProgramSucceedsFromRenderingToCompute/ES3_1_OpenGL Bug: angleproject:5072 Change-Id: I506c931d7e8714e0393fb5a7b9671b2fc74caeee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2420332 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
|
9f70b6b2 | 2020-09-20 13:28:37 | Disable slow max uniform count test on D3D11/Intel. Bug: angleproject:5076 Change-Id: I21fc0504513e092003e19fb845d6759eba0a3866 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2420750 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
|
d13c9e78 | 2020-09-20 10:51:00 | Rename ShaderImpl::mData to mState. Makes it consistent with the other back-end types. Bug: angleproject:5076 Change-Id: I7a54dd4a0a54e6dc05e257b7b2ac1ec21ceea700 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2420748 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
a25fcc57 | 2020-09-21 10:01:02 | Roll Vulkan-ValidationLayers from d6935becabad to 0a863bc36554 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d6935becabad..0a863bc36554 2020-09-18 tony@lunarg.com gpu: Move vma allocator destroy to after state tracker If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ic5703da73bc1fa6c9244da9e1e3728dcf73221a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2421271 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
467c917c | 2020-09-21 10:03:05 | Roll Vulkan-Headers from f0e102e48197 to 7f9879b1b1fa (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/f0e102e48197..7f9879b1b1fa 2020-09-21 oddhack@sonic.net Update for Vulkan-Docs 1.2.154 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: Ic66b570914960f1fcfbff89c8bcb5f26ccde539b Bug: None Tbr: syoussefi@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2421329 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
c42a0f35 | 2020-09-21 10:01:01 | Roll glslang from 9eaa69c21c45 to 4dcc12d1a441 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9eaa69c21c45..4dcc12d1a441 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ibc5041023628ee57e351478fbf4757f3c5d78a9c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2421270 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
07877632 | 2020-09-21 10:01:03 | Roll SPIRV-Tools from 50ae4c5f4427 to 60ce96e2ff10 (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/50ae4c5f4427..60ce96e2ff10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ief4b7f0e41bc7888163dd923b43161f72b31fb93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2421272 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
 |
48588bd1 | 2020-09-18 17:33:55 | Vulkan: Add GL_EXT_buffer_storage extension entry points Addition of just the entry points for GL_EXT_buffer_storage extension. Bug: angleproject:5056 Change-Id: I7a3d7c151f004f89fd945d5d06dbe7afcd491578 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419951 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
de335c16 | 2020-09-14 12:04:20 | Vulkan: Implement a SharedResourceUse pool When adding a Resource to the ResourceUseList of ContextVk we constructed a new SharedResourceUse object for tracking and update of the Resource's Serial. We would then delete it after releasing the resource. This incurs repeated memory operation costs. Instead we now allocate a pool of SharedResourceUse objects and acquire and release from this pool as needed. VTune profile of the Manhattan 30 offscreen benchmark shows the CPU occupancy of bufferRead decrease from an average of 0.9% -> 0.6% and imageRead decreases from an average of 0.4% -> 0.3%. The bottleneck for both these methods is the retain() method that leverages the new SharedResourceUse pool. Bug: angleproject:4950 Change-Id: Ib4f67c6f101d4b2de118014546e6cc14ad108703 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2396597 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com> | |
|
76e90947 | 2020-09-19 10:48:55 | Test Runner: Really reuse displays with --bot-mode. The prior design didn't pass the correct flag to the subprocess. Instead add a new --reuse-displays flag that forces display reuse on in ANGLE tests. Pass the new flag to the child processes when running with --bot-mode. Bug: angleproject:3162 Change-Id: I5f62125d83d339b5e8b2506b4ca4656976f7398e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419638 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
3f20c713 | 2020-09-19 11:29:56 | Test Runner: Fix "--bot-mode" error level return value. Previously the runner was returning "1" on success and "0" on failure. Swap this so that it correctly returns "0" on success and "1" on fail. This only affected "--bot-mode" which isn't yet enabled. Bug: angleproject:3162 Change-Id: I1ee942223272d24eff137279d5a0638d3a65694e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419639 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
93f58c15 | 2020-09-19 09:58:23 | Vulkan: Allow no validation layers in ExternalImageTest. Similarly to common test init, these specific tests init the Vulkan resources with validation layers when they might not be available. Fix this by checking for the appropriate define. Bug: b/168744561 Change-Id: I93dd3bac839297ced07cb2c4cbbcf64db2e65a1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419041 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
f6f20601 | 2020-09-13 23:29:55 | Vulkan: Optimize Attribute Change Perf (4/5) This patch series optimizes programs that use the pattern: for (;;) { glVertexAttribPointer(...) glDraw(...) } Change 4: Inline ValidateProgramDrawStates. A hotspot in most draw calls that change state. In total the patch series reduces test iteration time by 25%. This change reduces the listed "null" benchmark time from 295 -> 286 ns. Test: DrawCallPerfBenchmark.Run/vulkan_null_attrib_change Bug: angleproject:5045 Bug: b/168493024 Change-Id: I80959c9d06030709d7f4eba696e43614c33d5a8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409176 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
a42a7f06 | 2020-09-16 12:39:09 | Remove setting a default value for use_custom_libcxx Update the .gn to remove forcing use_custom_libcxx = false. Instead, let //build/config/c++/c++.gni determine the value, which should better match Chromium. In particular, this helps with Abseil integration by supporting Windows component builds by better matching the contents of the .def files. Bug: angleproject:4873 Test: CQ Change-Id: If8c064f16459292bfb95113a4d78e14e8923f86f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414739 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> | |
|
d79db259 | 2020-09-13 23:15:40 | Vulkan: Optimize Attribute Change Perf (3/5) This patch series optimizes programs that use the pattern: for (;;) { glVertexAttribPointer(...) glDraw(...) } Change 3: Use FastUnorderedSet for RP XFB buffers. Most of the time this list is empty. This speeds up the count check for empty and non-empty sets considerably. In total the patch series reduces test iteration time by 25%. Test: DrawCallPerfBenchmark.Run/vulkan_attrib_change Bug: angleproject:5045 Bug: b/168493024 Change-Id: Ia43eb11bdd62aa3bf425069b591f9318f519fd4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409175 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
d6806d73 | 2020-09-18 17:56:48 | Test Runner: Fix sharding and --bot-mode. We were using the incorrect test list to set up initial test expectations. Fix this by using the already generated test set in the test suite. Test: angle_unittests with --bot-mode, sharding, and filter Bug: angleproject:3162 Change-Id: Id108943494130410caab404faad25115792e794d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419596 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
357caadb | 2020-09-16 21:44:56 | Vulkan: Optimize Attribute Change Perf (2/5) This patch series optimizes programs that use the pattern: for (;;) { glVertexAttribPointer(...) glDraw(...) } Change 2: Micro-optimize XFB resume CPU overhead. We don't need to set resume on every new command buffer. We only need to set the dirty bit when we have an unexpected pause. In total the patch series reduces test iteration time by 25%. Test: DrawCallPerfBenchmark.Run/vulkan_attrib_change Bug: angleproject:5045 Bug: b/168493024 Change-Id: I8f6c68ff0513be4f405276e395d80bc1a185a061 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409174 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
9b4cfd18 | 2020-09-13 22:45:19 | Vulkan: Optimize Attribute Change Perf (1/5) This patch series optimizes programs that use the pattern: for (;;) { glVertexAttribPointer(...) glDraw(...) } Change 1: Don't null out pipeline on state change. This allows us to use the transition table for reduced CPU overhead. Note that we don't use a transition table for compute pipelines. In total the patch series reduces test iteration time by 25%. This is the most significant patch, reducing test time by 20%. Test: DrawCallPerfBenchmark.Run/vulkan_attrib_change Bug: angleproject:5045 Bug: b/168493024 Change-Id: I3823bb7d83bc2c66357fc5eb8f5dc3e4e54f6a17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407340 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
e8d01272 | 2020-09-18 10:34:06 | Vulkan: Additional "invalidate" white-box tests These are additional tests that were written when trying to refactor mContentDefined and move it from RenderTargetVk to ImageHelper for depth/stencil attachments. We still want to land the tests. Bug: b/167275320 Change-Id: I12f6bf8cece6499e4474a8f114b177626c1aa4d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419117 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com> | |
 |
e1f7e2de | 2020-09-17 08:25:40 | Vulkan: lock around accesses to mSharedGarbage Bug: b/168744476 Change-Id: I26205e7d29260ffdefbd5b2971b570c8bff7187f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416236 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> | |
 |
fbab23e1 | 2020-09-18 12:00:40 | Add CPEPrefix for rapidjson. This will allow automated notification of any vulnerabilities reported against rapidjson. Prior commit history suggests that this is only used for outputting test results and is therefore unlikely to be security-critical, but we're gradually aiming to get 100% coverage of all our dependencies and this should be an easy one. See https://chromium.googlesource.com/chromium/src.git/+/master/docs/adding_to_third_party.md#add-a-readme_chromium Bug: chromium:895969 Change-Id: Ie3f0db3fed525e81e4fa6e84fe96fe6c72575046 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419035 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
3c64fe30 | 2020-09-17 08:27:04 | Vulkan: need to serialize access to mFenceRecycler It's possible for multiple threads to touch mFenceRecycler so need to protect it with a mutex to prevent race conditions. Bug: b/168744476 Change-Id: I9898d2e9ebf0974581a1074cbda5be41a09cd790 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415401 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> | |
|
512059a9 | 2020-09-16 21:33:32 | Tests: Allow tests to function without VVLs. This is necessary to run angle_end2end_tests with sanitizers. We don't currently support building the VVL in sanitized configs. Bug: b/168744561 Change-Id: If16a25ac5786f5f5aeb8ae50d9f7fa22c6c87995 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415513 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
f17cd288 | 2020-09-18 11:36:50 | Refactor IsMipmapFiltered to take the min filter directly. This function is more useful if it takes just the min filter mode instead of the entire sampler struct to read a single member. Bug: b/167404532 Change-Id: Ie8c01c4095a615f06fe046fb175cdfb92fa54cbf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419111 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> | |
|
bda2205d | 2020-09-17 14:37:25 | Traces: Move up from tests/perf_tests/ to tests/. The trace tests aren't strictly for performance. Since we'll be using them for correctenss testing as well it makes sense to move them out of the perf_tests/ folder. Also renames RestrictedTraceTests.md to README.md so it'll load automatically in gitiles. Bug: angleproject:4090 Bug: b/168049670 Change-Id: I8be9f1d831489a9abf534d049a93441687850142 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416913 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> | |
|
5bfca93e | 2020-09-18 09:02:41 | Fix roll script for CIPD deps. Was looking at the Chromium path instead of the ANGLE path. Bug: skia:10572 Change-Id: I7f5dba011a5d446b8f1ef814f89421edfd0f7b95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418420 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
082c0240 | 2020-09-18 11:14:48 | Roll VK-GL-CTS from 6ccc0d9ba0ff to c9f4fb2fccda (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/6ccc0d9ba0ff..c9f4fb2fccda 2020-09-18 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master 2020-09-18 michal.m.pawlowski@mobica.com Issues detected by synchronization validation layer fix 2020-09-18 gleese@broadcom.com Fix memory barriers in image_subresrouce tests 2020-09-18 slawomir.cygan@intel.com Bump fence timeout in Amber test cases to infinity 2020-09-18 anholt@google.com vulkan: Add temporary constant-data shader indexing tests. 2020-09-18 ari.suonpaa@siru.fi Add transform feedback test with NULL offset array 2020-09-14 jessehall@google.com Fix small errors in external/openglcts/README.md If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jmadill@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com,angle-bots+autoroll-info@google.com Change-Id: I0549c327a93685a748e10505f7f0f6a4954eed45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418233 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
97813ea4 | 2020-09-18 10:01:57 | Roll Vulkan-Loader from 399f7fd741f7 to a148cdd49041 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/399f7fd741f7..a148cdd49041 2020-09-17 charles@lunarg.com Revert "loader: Return error if layer loading failed" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I565f036b5aefb25958059a83a40972d3210303fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418353 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
502621d1 | 2020-09-18 10:01:03 | Roll Vulkan-ValidationLayers from 46fc663a1cb3 to d6935becabad (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/46fc663a1cb3..d6935becabad 2020-09-17 lionel.g.landwerlin@intel.com corechecks: Fix validation of VU 03227 2020-09-17 lionel.g.landwerlin@intel.com tests: Fix QueryPerformanceResetAndBegin test 2020-09-17 lionel.g.landwerlin@intel.com tests: Fix QueryPerformanceIncompletePasses 2020-09-17 lionel.g.landwerlin@intel.com tests: Fix QueryPerformanceReleaseProfileLockBeforeSubmit test 2020-09-17 s.fricke@samsung.com tests: Add VUID 03311 and 03312 2020-09-17 s.fricke@samsung.com layers: combine renderpass create logic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I6db2f85ac027cba303fd8d7ced01d2bd6c3e2b79 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418351 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
7db8a19d | 2020-09-18 10:01:03 | Roll SPIRV-Tools from 34ef0c3fdc8e to 50ae4c5f4427 (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/34ef0c3fdc8e..50ae4c5f4427 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ie557a8f0936e468539aa3852c0f66eb22db4ed32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418352 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
2b3764ca | 2020-09-18 09:12:49 | Roll VK-GL-CTS from b045bf7d3b6a to 6ccc0d9ba0ff (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b045bf7d3b6a..6ccc0d9ba0ff 2020-09-18 alexander.galazin@arm.com Merge pull request #227 from kusma/nearest-edge-8-bit-precision If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jmadill@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com,angle-bots+autoroll-info@google.com Change-Id: Iaa532dd819fb8265bbe256d9b924d2d80d839ced Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2417977 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
68c424fe | 2020-09-17 10:34:07 | Vulkan: Workaround oldSwapchin bug on Android When vkCreateSwapchainKHR is called with a valid oldSwapchain, the Android framework destroys the images in oldSwapchain. This is not correct, as it should be deferred to the actual vkDestroySwapchainKHR call performed later by ANGLE. This is because rendering to the oldSwapchain could still be in progress. While this issue affects all of Android, currently only ARM shows any symptoms. A workaround is added for ARM to vkDeviceWaitIdle before recreating the swapchain if oldSwapchain is valid. Bug: angleproject:5061 Change-Id: I308e4798c6418d7891d880218b0ebcfd7a795643 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416238 Reviewed-by: Sunny Sun <sunny.sun@arm.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
4043b9d1 | 2020-09-17 12:03:12 | Guard against data race with MemoryProgramCache. Uses the display global mutex. Caught with angle_end2end_tests MultithreadingTest and TSAN. Bug: b/168744561 Change-Id: I5a60346cb5f95ff506dc166604eeae501863a774 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415182 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
5f8af83f | 2020-09-17 11:06:08 | Vulkan: Add perf warning for mid-RP clear Bug: angleproject:3461 Change-Id: Id80ccc81db3cb66438b6b5e6d504eda613f481d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416244 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
8d4331ee | 2020-09-16 00:42:08 | Vulkan: Free up 5 bits in RenderPassDesc Leveraging the fact that there are only a handful of depth/stencil formats, the last element of RenderPassDesc::mAttachmentFormats can contain other information in addition to the depth/stencil format ID. The FormatID enum is rearranged such that depth/stencil formats are placed first, as a result occupying values in [1, 7]. These values take up 3 bits in an element of RenderPassDesc::mAttachmentFormats (which could be the last element if all color draw buffers are attached). As a result, the upper 5 bits of the last element of RenderPassDesc::mAttachmentFormats is unused. It is intended for these bits to be used in the implementation of multisampled-render-to-texture depth/stencil renderbuffers. Bug: angleproject:4836 Change-Id: I0786e0712539cdbbf5494ec83aeee1dd93f936dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413165 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
32de9efe | 2020-09-17 12:03:12 | Guard against race in perf warnings. Expose the "debug" mutex so insertPerfWarning can use it. This was detected using TSAN and MultithreadingTest. Bug: b/168744561 Change-Id: Idde95a7b217f21f007893192a4a1f0a69b4ed3a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415184 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> | |
|
6939a023 | 2020-09-17 12:03:12 | Vulkan: Fix racy access to VkPipelineCache. Use a mutex to guard against the object init. The accesses to the cache internals are internally synchronized. There is a Vulkan ext that allows for external cache synchronization that we could investigate at some point. Detected by looking at MultithreadingTest with TSAN enabled. Bug: b/168744561 Change-Id: I1d4744e1aa970bcd57cac49f7ecaf8c238ea61c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415183 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> | |
|
f2749096 | 2020-09-17 12:03:12 | Fix racy global in gl::Compiler. We introduce a new Display Global Mutex in egl::Display that can guard access to gActiveCompilers in Compiler.cpp. Was detected by running MultithreadingTest against TSAN. Bug: b/168744561 Change-Id: I97866b60a173f60899cd0406fe0f71000035c0cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415181 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> | |
|
1c79e9ea | 2020-09-17 09:50:46 | Vulkan: Delay vkAcquireNextImageKHR till later Currently, ANGLE calls vkAcquireNextImageKHR() immediately after calling vkQueuePresentKHR(), which can cause the process to stall (even with multi-threading). Delay it until it is absoluately needed. Test: angle_end2end_tests --gtest_filter=*EGLPreRotationSurfaceTest*/* Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.*Invalidate*/* Test: angle_deqp_egl_tests --gtest_filter=dEQP.EGL/functional_query_context_get_current_display_rgba8888_window* --use-angle=vulkan Test: angle_perftests --gtest_filter=GenerateMipmapBenchmark.Run/vulkan_webgl Bug: angleproject:5064 Bug: b/162082698 Change-Id: I466df9237136dd59a9556faa8cf2dbad94e076fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2399509 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com> | |
|
37457d08 | 2020-09-15 14:38:53 | Vulkan: Support MSRTT color renderbuffers Color renderbuffers are similar to multisampled-render-to-texture textures, but much simpler. The same mechanism is used to implement them. Bug: angleproject:4836 Change-Id: I298529c9fd1b03e78b1e37cdbe595e66166ee130 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2412847 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> | |
|
bb96aefa | 2020-09-11 13:50:09 | GN: Componentize D3D back-ends. This also isolates headers for D3D9 / D3D11 from each other. Bug: angleproject:3943 Change-Id: I04edbe7db68461ae4fc78ac7f9c22451debcb768 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405807 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> | |
|
c99c22bb | 2020-09-15 16:53:26 | EGL: Add support for EGL_ANDROID_create_native_client_buffer This EGL extension will add support for creating EGLClientBuffer backed by an Android window buffer (struct ANativeWindowBuffer) which can be later used to create an EGLImage. Bug: angleproject:5018 Tests: angle_end2end_tests --gtest_filter=ImageTest.SourceNativeClientBufferTarget* Change-Id: If78ed7b80ad09629b8c5f5b5a0eb07a548e82e6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404320 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com> | |
 |
83c7e1ae | 2020-09-17 16:42:19 | Fix the regression of color blit. Move the offset aligning code to stencilBlitResolveNoShaderExport to avoid affecting color blit. Test: dEQP-GLES3.functional.fbo.blit.default_framebuffer.*_linear_* Bug: angleproject:5044 Change-Id: Ic2ebef94091853146424d567b0035161611ba32d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416008 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
3b8c957e | 2020-09-17 10:01:03 | Roll SPIRV-Tools from e8ce4355ae1c to 34ef0c3fdc8e (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e8ce4355ae1c..34ef0c3fdc8e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Iabc9534322647983574c505a99b926782df6a904 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416109 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
f6cbbf68 | 2020-09-17 10:01:03 | Roll Vulkan-ValidationLayers from f105898a102f to 46fc663a1cb3 (4 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f105898a102f..46fc663a1cb3 2020-09-16 s.fricke@samsung.com layers: Add function name to renderpass stateless 2020-09-16 s.fricke@samsung.com tests: DisabledProtectedMemory 1.1 check 2020-09-16 s.fricke@samsung.com tests: Fix UnsupportedPnextApiVersion on 1.0 2020-09-16 s.fricke@samsung.com tests: ToolingExtension devsim check If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I282762e32f84fa3ff551dfb61c761fe77b220fd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416108 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
40e0b66a | 2020-09-17 10:01:58 | Roll SwiftShader from b33e0b36a08c to fe878dedd5ad (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/b33e0b36a08c..fe878dedd5ad 2020-09-16 hidehiko@google.com Expand is_linux to is_linux || is_chromeos. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I57f8a3c9d7170b41fb80f9c457d75d8105a62071 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416110 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
8da60e25 | 2020-09-17 07:01:46 | Roll Chromium from e4cbd27e4a55 to d9fa0d469f57 (420 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e4cbd27e4a55..d9fa0d469f57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/42cbd32cfb..ff80cb1d7c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1d2f486547..5b99869e59 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e73d966652..3a81ef17d6 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/8ca19625de..d5148db386 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e075ddd622..92b3622380 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/552c4cfa71..894c57e360 No update to Clang. Bug: angleproject:3162 Tbr: jmadill@google.com Change-Id: I64cc3bf35e95add19696b72f12566cb1578e1a2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415853 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
0a8a3ea2 | 2020-09-14 11:12:43 | Vulkan: Skip nested pow test on NVIDIA, Windows Suspect possible NVIDIA driver issue as unable to repro on some NVIDIA, Windows, NVIDIA configurations. Test: angle_end2end_tests --gtest_filter=GLSLTest.NestedPowStatements/ES3_Vulkan Bug: chromium:1127866 Change-Id: Ic6a95915af72aab086753a0e0199ac1dee8bfb62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2410560 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
233cc31b | 2020-09-15 11:05:17 | Vulkan: Use linkedShaderStages in GlslangGetShaderSpirvCode() The parameter linkedShaderStages is passed to GlslangGetShaderSpirvCode(), but is unused. This CL uses the parameter, rather than gl::AllShaderTypes(). This CL also removes the unused parameter variableInfoMap from the call chain. Bug: angleproject:3570 Change-Id: Ic60084e87cb2aa2a245e3e963598851331379e89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2412364 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
a65a7f3d | 2020-09-16 19:45:55 | GN: Fix CrOS build due to buggy "defines". This config is unfortunately not covered on the ANGLE CQ. Test: local GN CrOS build Bug: angleproject:3943 Bug: chromium:1129075 Change-Id: Ie1a9b2fdfb47f2a4631e118ab88eccfb7ad7eaf8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415186 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
f12e4123 | 2020-08-25 12:01:12 | Vulkan: Match descriptor pool sizes to descriptor set layouts When a descriptor pool is created, a list of descriptor types and counts are given to vkCreateDescriptorPool(). Later, when allocating a descriptor set from the pool, we pass along a descriptor set layout to vkAllocateDescriptorSets() which is used to determine how many of each type of descriptor (i.e. binding) to allocate from the pool. In order for our "free descriptor set" counts to be accurate for each pool, the descriptor pools need to be created with descriptor counts that match the descriptor set layout binding counts. This change fixes a bug where the descriptor set layouts were created with more bindings than the descriptor pool sizes, causing the "free descriptor set" count to be inaccurate, leading to allocating too many descriptor sets from a pool. Bug: angleproject:3570 Test: VulkanDescriptorSetTest Change-Id: I660bf02d29a1291391fb15f39e6479bf348d0f83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2391114 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
58463573 | 2020-09-16 19:30:56 | Test Runner: Fix dirty thread teardown. When the standalone tests shut down they would not wait for the watchdog thread to exit cleanly. Fix this by setting a flag that shuts down the watchdog and attempting to wait. This was detected by running angle_end2end_tests with TSAN. Bug: angleproject:3162 Bug: b/168744561 Change-Id: I765ce7a21c3be11703619470a81adb1882b009e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415175 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> | |
|
a2d670c5 | 2020-08-15 21:13:33 | Run trace tests against Vulkan Mock ICD. Required an upstream fix: https://github.com/KhronosGroup/Vulkan-Tools/pull/437 Also a workaround filed as an issue: https://github.com/KhronosGroup/Vulkan-Tools/issues/445 Bug: angleproject:4950 Change-Id: I21333464d2a8e52d5d85d35654f0e6372f9650db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358517 Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
972441af | 2020-09-16 17:15:45 | GN: Fix missing pkg_config import in GL back-end. This was causing a build break on ChromeOS builers and brekaing the ANGLE roll into Chromium. Bug: chromium:1129075 Bug: angleproject:3943 Change-Id: Ic7976c0b506f5af67823da8de1f8c850e43abee0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415169 Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
 |
07c03b6d | 2020-09-11 14:43:37 | Validate GLSL attribute location range The location index of a vertex shader input's layout qualifier must be less than GL_MAX_VERTEX_ATTRIBS to link successfully. We can check for this during shader compilation to not rely on other layers to handle pathological cases. While strictly speaking only 'active' attributes are considered during shader linking, this is merely intended to allow for 'uber' shaders to declare more inputs than GL_MAX_VERTEX_ATTRIBS but only use a subset of them. There is no known reasonable use case for a manually specified location to exceed the valid range. Note that according to http://opengl.gpuinfo.org, the highest GL_MAX_VERTEX_ATTRIBS value at the time of writing is 32. Also, D3D12_VS_INPUT_REGISTER_COUNT = 32. Hence the unit test's value of 1000 should be sufficiently future proof. Also address the case where the uniform location might be close to INT_MAX and not be detected as out-of-range due to numeric overflow. Bug: chromium:1110800 Change-Id: I9985c8eab3bb8a2a59b8f985e8f5b6884756383c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405368 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> | |
|
23cff4e1 | 2020-09-16 13:41:49 | Test Runner: Handle GTest sharding args. These were messing up the test runner when used in combination with the test runner's specific args. Make it an error if the arguments are used together. Bug: angleproject:3162 Change-Id: I6fa1c0fb346a8c376ca455f7f4bf0492cfc0198a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414931 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
22d30378 | 2020-09-15 23:19:48 | Vulkan: Change VK suffix to Vk For consistency with the rest of the backend. Level index variables were using the VK suffix while color index variables used Vk. Bug: angleproject:4881 Change-Id: I0c2799da34cdfe19cb04adbebba042ac8876af96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413155 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> | |
 |
71e7a5a6 | 2020-09-14 13:56:19 | Vulkan: Move mAttachedColorBufferMask to FramebufferState This moves the bit mask of attached color buffer to front end. No function change is expected. Bug: b/167301719 Change-Id: I4eec3a419560b91875260b812a036ceaaeb6b5bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2410790 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> | |
|
d8b037d6 | 2020-09-15 05:05:14 | Change renderbuffer width/height/sample types to GLsizei This matches the types used by GL and stored in the state. setStorage and setStorageMultisampled calls were using size_t instead with a number of unnecessary casts in places which are now removed. Bug: angleproject:4836 Change-Id: Ibb570f0c088a6f29abe10f513de27c30ba4dd098 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411697 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
30fc7ff2 | 2020-09-16 13:49:54 | Show file in internal errors. Just showing the line and function isn't as useful. Bug: angleproject:3162 Change-Id: Ic8c2425a7a7e9992d2a569abd8ea0b7731fa69c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407834 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> | |
 |
b328e044 | 2020-09-16 10:30:05 | EGL: Add another config for Mali Test: angle_end2end_tests Bug: angleproject:5053 Change-Id: I7aef6b5babe8f582e7500464f53e65721eaf0520 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414733 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> | |
|
99b71417 | 2020-09-16 11:41:24 | Vulkan: Disable BlitStencilWithFlip test on Win These tests fail on the Windows NVIDIA bots Bug: angleproject:5044 Bug: chromium:1128064 Change-Id: Idad4cc33d8e49b0b468b8e560b44f9a9c6a2f37f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414932 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com> | |
|
2d74170f | 2020-09-11 12:30:04 | GN: Componentize GL back-end. Bug: angleproject:3943 Change-Id: I88c2ec8a9f49746f6ce9838b0d1c8e8ea0a8ae9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405806 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> | |
|
ed01473e | 2020-09-12 13:01:05 | Vulkan: Fix blendEnable-02023 VU Enable BlendIntegerTest Add DrawBuffersTest.BlendWithGaps test Add BlendPackedTest Bug: angleproject:4548 Bug: angleproject:4571 Bug: angleproject:4583 Change-Id: I139183099b26f0fe1ac9e43f96d18b8ccb134a2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407772 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> | |
|
3018d5e5 | 2020-09-16 10:01:03 | Roll Vulkan-ValidationLayers from e59713d4edda to f105898a102f (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e59713d4edda..f105898a102f 2020-09-15 s.fricke@samsung.com layers: label VUID 04151 and 04152 2020-09-15 s.fricke@samsung.com layers: label VUID 04441 2020-09-15 tony@lunarg.com gpu: Handle KHR version of CmdDispatchBase 2020-09-14 s.fricke@samsung.com layers: Improve WSI related error messages 2020-09-14 s.fricke@samsung.com layers: label VUID 04448 2020-09-14 jzulauf@lunarg.com syncval: DRY/clean MakeRange computation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I13d028a7007a98f5db0fd4f78b32f8c0aa5c5843 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413555 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
76563a25 | 2020-09-16 10:01:03 | Roll SPIRV-Tools from 726af6f78f80 to e8ce4355ae1c (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/726af6f78f80..e8ce4355ae1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I9b2f0c42cb0a6bf162fc99dd72e91498c002a1bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413556 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
d52a34cb | 2020-09-16 10:01:58 | Roll SwiftShader from dc552fcef1fe to b33e0b36a08c (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/dc552fcef1fe..b33e0b36a08c 2020-09-15 natsu@google.com Support Gralloc4 in SwiftShader 2020-09-15 swiftshader.regress@gmail.com Regres: Update test lists @ dc552fce 2020-09-14 amaiorano@google.com CMake: normalize FOLDER property for third_party targets 2020-09-14 bclayton@google.com SpirvShaderDebugger: Add PRINT_EACH_DEFINED_DBG_INSTRUCTION 2020-09-14 bclayton@google.com SpirvShaderDebugger: Implement DebugValue 2020-09-14 bclayton@google.com SpirvShaderDebugger: Reduce lock contention If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I460dfa92d1606e2877a47b293a009a17d09b32dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413557 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
5453e7b7 | 2020-09-16 07:03:19 | Roll Chromium from 1960f3b23408 to e4cbd27e4a55 (817 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1960f3b23408..e4cbd27e4a55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc90e7d103..42cbd32cfb * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a90362b4fc..3ff4f5027b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/598b9bd5a4..1d2f486547 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9967a97317..e73d966652 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bf815f1a74..e075ddd622 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8d1fa6cbe8..552c4cfa71 No update to Clang. Bug: angleproject:3162 Tbr: jmadill@google.com Change-Id: I0391f5aa9f047264315f7f7da056bef0f1eeeaef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413478 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
4d3a0f60 | 2020-09-11 12:36:05 | GN: Componentize D3D format tables. These tables are used by both the GL and D3D11 back-ends. Also moves them to renderer_utils to be in a shared place. Bug: angleproject:3943 Change-Id: I1f5d79842396a87e795547fa03c6855d6f9c5e9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405805 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> |