kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi a1665d2f 2024-05-10T00:15:31 Reland "Document thread-unsafe iterator access to resource maps" This is a reland of commit d1bb6ed8399dd12e79484f30f9e9ded95c25625a The crash was due to another issue (disabling EGL validation in Chrome) Original change's description: > Document thread-unsafe iterator access to resource maps > > By using a proxy type, everywhere resource maps are iterated are clearly > marked as not being thread safe. In most cases, only destruction and > capture/replay iterate over these maps, which means thread safety is not > an issue (or is externally enforced). > > The only case where iterators are used in the presence of other contexts > is with ANGLE_request_extension, which is changed to explicitly require > the application to ensure thread safety. In practice, the user is > Chrome which already guarantees this. > > Bug: angleproject:8667 > Change-Id: I7af13c6433b6955d9c36f9088b3aa4c065e1cfc1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526428 > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:8667 Change-Id: Id539cabac01df5f242150f6684222577003eef3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5531278 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Charlie Lao df2e7bd7 2024-05-10T19:48:34 Vulkan: Handle the case that VkEvent failed to create. If VkEvent failed to create, we can still fall back to pipeline barrier. This CL changes RefCountedEvent::init to return boolean. Also when it fail, this CL did an immediate garbage clean up in case it will free up more event from garbage list and then retry again. Bug: b/336844257 Change-Id: I28251849a92d1785701c55eb028a8fed63cfc372 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5532869 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov 3b470cf5 2024-05-13T12:43:25 Move PPO executables to ProgramExecutable This will allow to recursively deal with PPO uniforms Bug: angleproject:8666 Bug: b/335295728 Change-Id: Iadc2d009937fb5e8a39b070674ef5d67c9f0fb19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5532715 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Le Hoang Quyen 0044f4d1 2024-05-13T00:29:30 Metal: fix IOSurface's render targets invalidated by max level change. This CL fixes a bug in the following tricky situation: - Client binds an IOSurface to a texture. - Previously this would internally intialize the texture's max level to the default value 1000. - Client changes the texture's max level to 0. - Client attachs the texture to FBO 1. - Client binds FBO 1 and clear it. - This triggers TextureMtl::getAttachmentRenderTarget() that initializes the RenderTargetMtl of the texture. - Client binds FBO 0 and sample the texture. - Previously this could trigger TextureMtl::onBaseMaxLevelsChanged() which would invalidate the texture's RenderTargetMtl. - Client binds FBO 1. - Client blits FBO 0 to FBO 1. - This will set DIRTY_BIT_COLOR_BUFFER_CONTENTS_0 in FBO 1. - Client calls glFlush to restart render command encoder. - Client issues a draw call. - DIRTY_BIT_COLOR_BUFFER_CONTENTS_0 would cause FrameBufferMtl to re-initialize RenderPassDesc from invalid RenderTargetMtl. - A new render encoder would be created from the invalid RenderPassDesc. - the draw call would be encoded to a render command encoder without any valid color attachment. The fix in this CL is that when we bind an IOSurface to a texture, the texture's max level will be automatically set to 0. This will avoid its RenderTargetMtl from being invalidated if users explicitly change the max level to 0 in future. Note: this is not a foolproof fix for every scenario concerning the base/max level in IOSurface bound/or immutable textures. We will fix them in future CLs. Bug: b/335353385 Change-Id: I3a2da6991764f22393178f40c1d7bbe60503cba4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5531388 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Yuly Novikov 53cb3f48 2024-05-11T16:18:22 Fix non-WebGPU component build Need to build abseil as a component, like it was before https://chromium-review.googlesource.com/c/angle/angle/+/5371323 otherwise same symbols are defined in multiple ANGLE libs. Bug: angleproject:8555 Change-Id: Ie7eacb682064e61bf3d5b24953c60e30d33814b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5527302 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 82ddb33b 2024-05-10T00:00:00 Metal: Do not separate vector and matrix constants Do not create temporary variables for already folded constant vector and matrix values. This reduces register usage and partially fixes MSL compilation errors caused by matrices present in constant initializers. Bug: angleproject:8691 Change-Id: Iedfabadd9b7bcb2e6e1e08a5ad39f48305365747 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5533925 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 08365628 2024-05-13T13:55:15 Force logging ANativeWindow events for debugging. Temporarily switch from LOGV to LOGI, so that logs from these events show in release builds of ANGLE: onNativeWindowCreated onNativeWindowDestroyed onNativeWindowRedrawNeeded onNativeWindowResized These are only printed in ANGLE tests. Bug: chromium:339457761 Change-Id: I0d81b05348ee3184fdc90da1a16e69704bcc084a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526470 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 65e25de7 2024-05-13T10:50:26 Manual roll Chromium from e8c93a04c96c to dcf49c3fc3cd (817 revisions) Manual roll requested by ynovikov@google.com Manually update flatbuffers https://chromium.googlesource.com/chromium/src.git/+log/e8c93a04c96c..dcf49c3fc3cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b2163519a9..ef48ed5d95 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/46a35f0196..066811c908 * third_party/android_build_tools/lint: Y5wuGPB-HfFtEVQC_0XI6n88Covm4HFDxnG0uTdV2LcC..LKVTpK4XpEG8B7rQdSi365E60QYERcaYvf2b4kv_JugC * third_party/android_build_tools/manifest_merger: tz8dYQ_yBEZJRVhtzyyCjOlbOfujkHRWcYZy7419o_cC..Uecrn-wUXzvUON7QkiZPlANRvFr6yFM05_M_S7q8IFoC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3a1d1cc096..923a565b97 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6e32e926e9..e1385296c4 * third_party/flatbuffers/src: https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/bcb9ef1876..c696275eaf * third_party/kotlin_stdlib: 05hzFgOi0AqRK3RxbSvGj2TWTFUNeLcwkJwVzwgLttUC..bCpFA9jdfF0zeuOKYuv9n1vqxV_lykSRR1oAYrVKmFsC * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d17298ab09..a37a3aa431 * third_party/siso: git_revision:4524544994f4eac131378143f498ee4d0b7d1f36..git_revision:df7a992166415f66f6958744f149f724df138879 No update to Clang. Bug: angleproject:8434 Change-Id: I43317335b9acc78c133aafe8dcf7ce2a3167eb36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5532860 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Yuly Novikov a24c413d 2024-05-13T10:35:19 Update native_app_glue from NDK 27.0.11718014 Adding these 3 evens handling: onContentRectChanged onNativeWindowRedrawNeeded onNativeWindowResized Bug: chromium:339457761 Change-Id: I7b919d60df2d1bf81745ef4caac6c81238b2c7bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526468 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll decf0e9d 2024-05-13T10:01:43 Roll vulkan-deps from 643408ea2a06 to 7e66c5e2f87e (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/643408ea2a06..7e66c5e2f87e Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/effcbf7893..edca09e3af * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9241a58a80..199038f10c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e74bfc215b..8480f26d3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I4b2366c5e7be1669d64603e9c8790a1125fca4d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5532970 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 4e887491 2024-05-11T18:08:03 Revert "Document thread-unsafe iterator access to resource maps" This reverts commit d1bb6ed8399dd12e79484f30f9e9ded95c25625a. Reason for revert: Checking to see if it's the reason for crbug.com/339948886 Original change's description: > Document thread-unsafe iterator access to resource maps > > By using a proxy type, everywhere resource maps are iterated are clearly > marked as not being thread safe. In most cases, only destruction and > capture/replay iterate over these maps, which means thread safety is not > an issue (or is externally enforced). > > The only case where iterators are used in the presence of other contexts > is with ANGLE_request_extension, which is changed to explicitly require > the application to ensure thread safety. In practice, the user is > Chrome which already guarantees this. > > Bug: angleproject:8667 > Change-Id: I7af13c6433b6955d9c36f9088b3aa4c065e1cfc1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526428 > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:8667 Change-Id: I1245c9e57dfeb27a7f0e5718b1455614c70bc0dc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5532187 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 9eaf12d3 2024-05-10T09:45:03 Roll Chromium from 4fea14b56dd7 to e8c93a04c96c (1172 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4fea14b56dd7..e8c93a04c96c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7796c50af5..b2163519a9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9703d9137f..4e0e9c73a0 * buildtools/linux64: git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789..git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512 * buildtools/mac: git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789..git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512 * buildtools/win: git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789..git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a2a6e48c98..46a35f0196 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/31bdf8fec4..8c54b7dae4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/47d3198a95..3a1d1cc096 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df437783c2..6e32e926e9 * third_party/r8: ntlyos9oLHW_q1AeZovqFuTYzog9dKd2lITTowptHuYC..DcVi2RjfFH55zitouMx3JJtwdiShMM2rWsdAoGYUIRsC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/964cf5c799..091120aa21 * tools/luci-go: git_revision:91ca2f5af39c4feb1c748c353f4d616e1c2332e7..git_revision:0353d07d5edeb62305e13f17d808e8523cd5bac2 * tools/luci-go: git_revision:91ca2f5af39c4feb1c748c353f4d616e1c2332e7..git_revision:0353d07d5edeb62305e13f17d808e8523cd5bac2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/54a120d570..42052bb1dc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7ef4ff5ba3..a38be67561 * tools/skia_goldctl/linux: rnVa2tBzy_bWBzhMbfGN9LWVREg2oX7FIWTizcil9nAC..EYKOn-l9uvmHtsVw_fmqj8vxXKpMyXt2sXvEJ3snsUQC * tools/skia_goldctl/mac_amd64: Y1vx6zBEl8AgYA0BE99RK71LoJPAJMdFcFZUiiH4ItIC..U1MAiUkDGvUVuk6G3tRhjjtmA3gDgW4HkyWhy8xTfrQC * tools/skia_goldctl/mac_arm64: 1QeDGa3HwvjmY-wV4NK81PTGZGJ_uSZ0FSC0dHAosIsC..KzRIDh9i73vYu6zVorKIEt7qrq38TuL9MZEWbf3Glw4C * tools/skia_goldctl/win: qWfDi1N2HXBm5wLJgsy6fImu51jqJ6JafFDWjWJPuMQC..gEDTtt_VQOAPHQedAzUUVJ79216-Wz_H9A-EfvVGYyAC No update to Clang. Bug: angleproject:5038 Tbr: abdolrashidi@google.com Change-Id: I8b5f1641d70bd03e253722264f19f427ed35cf9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5530989 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang c96435ed 2024-05-10T16:06:19 Use Chromium's abseil build files with Dawn. Roll Dawn and set build_with_angle so that it uses chromium's abseil buildfiles when building in an ANGLE checkout. Bug: angleproject:8555 Change-Id: I8fc40fdefad734ef62bce374aa948367a42c03c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5531113 Auto-Submit: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi d1bb6ed8 2024-05-10T00:15:31 Document thread-unsafe iterator access to resource maps By using a proxy type, everywhere resource maps are iterated are clearly marked as not being thread safe. In most cases, only destruction and capture/replay iterate over these maps, which means thread safety is not an issue (or is externally enforced). The only case where iterators are used in the presence of other contexts is with ANGLE_request_extension, which is changed to explicitly require the application to ensure thread safety. In practice, the user is Chrome which already guarantees this. Bug: angleproject:8667 Change-Id: I7af13c6433b6955d9c36f9088b3aa4c065e1cfc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526428 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 8d23fa3f 2024-05-10T15:01:25 Add .gcs_entries to .gitignore Was interfering with uploads to AOSP. Bug: b/324418194, skia:338467531 Change-Id: Ifd170092e71425de2d1dad33f130e74c091bec8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526249 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll dfddb4f7 2024-05-10T10:01:44 Roll vulkan-deps from 7c61bb741fb6 to 643408ea2a06 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7c61bb741fb6..643408ea2a06 Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/4bc77c26ff..5677bafb82 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1ca695d943..e74bfc215b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I92ec06db4f91b9e9d4cc7a26f8602ac163c6695e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5531181 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 4cacc66e 2024-05-09T16:08:58 Remove unused ResourceMap::find Bug: angleproject:8667 Change-Id: I0d0c00337895b247a1f0536f5072fdcf12b7de1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5527560 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 1202055c 2024-05-09T11:25:38 Vulkan: Updates to perf counters 1. don't reset pipeline cache hit / miss counters after every frame 2. bugfix in LinkTaskVk::getResult(...) 3. accumulate counters in WarmUpTaskCommon::getResultImpl(...) Bug: angleproject:8297 Change-Id: I39d7e1a438d78e2e353c5cf8246fb24fb3cfefea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5529942 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Geoff Lang 394e8767 2024-05-08T15:18:37 WebGPU: Fix accumulating mCurrentColorAttachments. mCurrentColorAttachments was not being cleared so multiple clear operations would have incorrect color attachments. Comparing against the previous RenderPassDescriptor also compared the same color attachment memory since the same scratch buffer was used to generate the new descriptor. Bug: angleproject:8582 Change-Id: I9026007607941b92856728b421bc43812195ca57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526978 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org>
Geoff Lang a70ef7fc 2024-04-25T14:19:50 Add EGL_ANGLE_no_error for disabling EGL validation. Chrome makes many small EGL calls that can have proportionally expensive validation. Bug: angleproject:8434 Change-Id: I4f4d0e6eff64839f76a0f7bf48e5c94b8df9d809 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5491459 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Scott Marcy 2ecfc5a1 2024-05-03T18:29:12 Issue 8644: Deeply nested iterator declarations can crash Avoid stack overflow crash when parsing nested iterators (especially `while` statements). Limits the number of nested iterator statements to `mMaxStatementDepth` (defaults to 256). Bug: angleproject:8644 Change-Id: I9b0fd2ab456c3cdd731b41ab97f495ae4dc0b0bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5519169 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Scott M <mscott@apple.com>
angle-autoroll bcb6db5c 2024-05-09T10:01:41 Roll SwiftShader from 76f7f8cfea80 to da334852e705 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/76f7f8cfea80..da334852e705 2024-05-08 dsinclair@chromium.org Fixup CMake after spirv upgrade 2024-05-08 rjodin@chromium.org Update SPIR-V Tools to dd4b663e1 2024-05-08 rjodin@chromium.org Update SPIR-V Headers to 5e3ad389e 2024-05-08 rjodin@chromium.org spirv-tools: revert hand-made changes in spirv-tools to update with upstream 2024-05-08 rjodin@chromium.org update-spirv-tools.sh: add missing rms of Android.mk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I9a7414c10726660b7b2b19669ed23dcd3fcb50d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5529375 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d3b380fc 2024-05-09T10:01:16 Roll vulkan-deps from 44adb2021ffb to 7c61bb741fb6 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/44adb2021ffb..7c61bb741fb6 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ed4446acf1..1ca695d943 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia4caa7e1b421dd511495a861b11e0459769fb71d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5527627 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 602512a0 2024-05-08T20:46:28 Manual roll vulkan-deps from 74fe79763664 to 44adb2021ffb (62 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/74fe79763664..44adb2021ffb Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/f857417c99..effcbf7893 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/5e3ad389ee..49a1fceb9b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dd4b663e13..9241a58a80 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/eaa319dade..4bc77c26ff * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/fa3b7bdefa..eb8c7b071a * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d21838aeaa..df8e710224 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/68780d9b8c..358a107a6f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/397d8fbc0e..ed4446acf1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia5f41d44828dcca8fbed32062a8e9bae606ab835 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5525919 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Liza Burakova 36cd4c1f 2024-05-08T12:27:22 Adding basic readPixels. This change adds to methods in ImageHelper to read texture data. It also implements FramebufferWgpu::readPixels to get the parameters and read the texture data from an ImageHelper that's stored in mRenderTargetCache. Bug: angleproject:8653 Change-Id: I349ed8a0ae3d8d0e187c658f3402c4f8cac23eb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5441353 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Cody Northrop 6a6192c8 2024-05-08T08:42:24 Tests: Add native to EGLPrintEGLinfoTest For comparisons, it is useful to run the EGLPrintEGLinfoTest against native drivers. Test: angle_end2end_tests --gtest_filter=EGLPrintEGLinfoTest.*/ES3_2_EGL Bug: b/337554150 Change-Id: If7c94296fbbd9f3057449d54581f334a37e59216 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5525656 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 071e1e83 2024-05-08T10:33:49 EGL: eglCreateSyncKHR uses a return value for the tail call eglCreateSyncKHR was duplicated in two lists for using a tail call and needing a return value tail call. Bug: angleproject:8434, chromium:338902974 Change-Id: I9dffeaec3468e4ea3f5ed7d885e9ef418e8d8da5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5525854 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4c66e8a4 2024-05-08T07:02:33 Roll Chromium from 7a22cfe5a3e7 to 4fea14b56dd7 (650 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7a22cfe5a3e7..4fea14b56dd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/39e82ca2f8..7796c50af5 * buildtools/reclient: re_client_version:0.138.0.e854224-gomaip..re_client_version:0.141.1.29a9d3c-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/de4f9bcc57..a2a6e48c98 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4cc26001b9..47d3198a95 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4d9ad255f1..df437783c2 * third_party/fuchsia-sdk/sdk: version:20.20240430.3.1..version:20.20240507.3.1 * third_party/r8: a2gKt0z-OOG5sntIiNXVd6LFDWUuvR-rstsrF59EEnIC..ntlyos9oLHW_q1AeZovqFuTYzog9dKd2lITTowptHuYC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/14ba9b58df..964cf5c799 * tools/luci-go: git_revision:69f852c6aea2797c75712d59145efd38d7032196..git_revision:91ca2f5af39c4feb1c748c353f4d616e1c2332e7 * tools/luci-go: git_revision:69f852c6aea2797c75712d59145efd38d7032196..git_revision:91ca2f5af39c4feb1c748c353f4d616e1c2332e7 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/668bf195ba..54a120d570 * tools/skia_goldctl/linux: 4Ox2OXGb8xipJPUsrFptKWJNJelzwWHBB3ORF1iHt94C..rnVa2tBzy_bWBzhMbfGN9LWVREg2oX7FIWTizcil9nAC * tools/skia_goldctl/mac_amd64: -H7DJpIRXUmi9ddRqVRJXThT1nlK7ns94UOnHMmeP4IC..Y1vx6zBEl8AgYA0BE99RK71LoJPAJMdFcFZUiiH4ItIC * tools/skia_goldctl/mac_arm64: FclksBOdZsrGv0dS7P163Fl3zi60z6nQCDXMNOoAYLYC..1QeDGa3HwvjmY-wV4NK81PTGZGJ_uSZ0FSC0dHAosIsC * tools/skia_goldctl/win: CBmdgsk0TAPgochRHBMBS9LZzdhYMOsNaJSAPvA-e-YC..qWfDi1N2HXBm5wLJgsy6fImu51jqJ6JafFDWjWJPuMQC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ib7d612cf0e26d54a0af665f971fe5de881d4e93a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5524111 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brian Sheedy 1dc83614 2024-05-07T14:54:06 Suppress experimental Linux/Intel failure Adds a test skip for a flaky test that was accidentally omitted when enabling the Linux/Intel experiment. Bug: angleproject:8683 Change-Id: I28dea9cb9617f5b8e4cb26d4626a5472608ac398 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5523916 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Liza Burakova 1d0ef518 2024-05-07T16:56:43 Fixing glClear tests. This CL makes a few changes to fix up the basic glClear test RGBA8Framebuffer, as well as adding a test that uploads a texture before clearing a RGBA8 framebuffer. It moves the wgpu::RenderPassDescriptor(RPD), as well as helper methods for comparing RPDs from the context to the framebuffer. The color attachments that are created in when FramebufferWgpu::clear is called are also stored in the framebuffer now as well. This CL also changes texture creation to use the RGBA8Unorm format instead of RGBA8Uint format. It also adds the wgpu viewFormats parameter to an ImageHelper. Future formats support is still TBD. Bug: angleproject:8582 Change-Id: Idfc4182eb4d6de8a771f2f91d337564ee71df010 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5503549 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Shahbaz Youssefi e29d643e 2024-05-07T13:40:18 Vulkan: Fix missing per-present-mode query ... if VK_EXT_surface_maintenance1 is supported but VK_EXT_swapchain_maintenance1 isn't. The code mistakenly made the appropriate query conditional to the presence of swapchain_maint1 instead of surface_maint1. On devices where surface_maint1 was available but swapchain_maint1 wasn't, this caused a VVL error that is now fixed. Bug: angleproject:8680 Change-Id: Ide9a87f0e50887572f693d741d5476361320ea19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5522756 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 3d04180c 2024-05-02T17:30:02 Vulkan: Add a dedicated garbage list for RefCountedEvents Previously each individual RefCountedEvent is wrapped into a GarbageObject. That is the reason behind RefCountedEvent being a subclass from WrappedObject, since vk::GetGarbage call requires garbage object is a subclass of WrappedObject. This CL adds a new garbage list dedicated for RefCountedEvents, named mRefCountedEventGarbageList. With this new change, we no longer limited by the vk::GetGarbage requirements since it no longer called for RefCountedEvents. RefCountedEventCollector is a vector of RefCountedEvents and every time a RefCountedEvent needs to be released, it adds into the collector. Then the event collector entire thing is treated like a garbage object and gets ResourceUse tracked and added into mRefCountedEventGarbageList. This list gets walked and cleaned when GPU is completed. This CL is also a preparation for later CLs that adds event recycle support. Bug: b/336844257 Change-Id: I4eff69b66922dfe5521b6994f240e967ff3726bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5516458 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 5b9e7f20 2024-05-06T14:50:44 Vulkan: Release mCurrentEvent before oneOff surface image copy In ImageHelper::copySurfaceImageToBuffer and ImageHelper::copyBufferToSurfaceImage, which get called from lockSurface, we are doing a one off submission to do the data copy between image and buffer. Surface image may have a current event set earlier, but we do not have a garbage collector to collect it. This will crash in barrierImpl when we try to add mCurrentEvent to the garbage collector. This CL releases mCurrentEvent so that it will fall back to pipelineBarrier. Since this is not on performance critical code path, the impact should be acceptable as well. Bug: b/336844257 Change-Id: Ib85c3038657a1845e86286cdb5f52247c2b9eb73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5519173 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov 0905ac07 2024-05-07T16:21:27 Roll third_party/dawn/ ed2c7c713..5406e9dfb (307 commits; 7 trivial rolls) https://dawn.googlesource.com/dawn.git/+log/ed2c7c7133fd..5406e9dfbe0b $ git log ed2c7c713..5406e9dfb --date=short --no-merges --format='%ad %ae %s' 2024-05-07 cwallez CMake: Fix workaround for CMake < 3.20 generated files. 2024-05-07 arthursonzogni Add missing header declaration to GN/CMake 2024-05-07 cwallez ShaderModule.h: Remove a few references to SPIR-V. 2024-05-07 rharrison Re-enable AF matrix tests 2024-05-07 jrprice [tint] Link libraries for dlopen 2024-05-07 jrprice [tint] Fix TINT_BEGIN_DISABLE_ALL_WARNINGS for GCC 2024-05-07 bclayton [tint][spirv] Remove use of locale 2024-05-07 cwallez Use an internal version of [Static]SamplerBindingLayout. 2024-05-07 cwallez Simplify SampleUtils a bit. 2024-05-07 hitawala [YCbCr Samplers] Use helper for CreateSamplerYcbcrConversion 2024-05-07 arthursonzogni Reorder member around PNextChainBuilder. 2024-05-07 cwallez Simplify CppHelloTriangle and rename depth-stencil from samples 2024-05-07 dawn-autoroll Roll DirectX Shader Compiler from 7db2fc129ab6 to 773b01272719 (1 revision) 2024-05-07 dawn-autoroll Roll Depot Tools from 94f42f8fe3fe to 4d9ad255f1ad (4 revisions) 2024-05-07 dawn-autoroll Roll vulkan-deps from b74ef144e313 to c11038d160c6 (26 revisions) 2024-05-07 dawn-autoroll Roll ANGLE from b0875f124a24 to 5c78d084206f (4 revisions) 2024-05-07 jrprice [ir] Add Function::AppendParam() helper 2024-05-07 bsheedy Expand x86 NVIDIA expectations 2024-05-07 shrekshao [Compat] Fix cube texture for compressed texture 2024-05-07 jrprice [uniformity] Fix ICE for pointer parameters 2024-05-06 shrekshao Refactor Inspector::GetTextureQueries 2024-05-06 cwallez Metal: Allow additional swapchain formats 2024-05-06 bsheedy Suppress additional Win/NVIDIA exp failures 2024-05-06 jrprice [msl] Refactor barrier polyfills 2024-05-06 enga Delete old Metal interop APIs 2024-05-06 cwallez CMake: Compile without -Werror by default. 2024-05-06 dawn-autoroll Roll DirectX Shader Compiler from af955d601dca to 7db2fc129ab6 (1 revision) 2024-05-06 dawn-autoroll Roll Depot Tools from a60f90e38e53 to 94f42f8fe3fe (1 revision) 2024-05-06 hitawala [YCbCr Samplers] Add and use YCbCrVkDescriptor struct 2024-05-06 robertphillips Add "delayimp.lib" linking to fix unresolved external symbol __delayLoadHelper2 issue 2024-05-06 dawn-autoroll Roll ANGLE from 9ccb9b410289 to b0875f124a24 (5 revisions) 2024-05-06 shaobo.yan Support Coord Transformation for TextureLoadExternal() 2024-05-06 jiawei.shao Pretty-print resource usages in resource tracking errors 2024-05-05 dawn-autoroll Roll ANGLE from 28d4c3eb689c to 9ccb9b410289 (1 revision) 2024-05-05 dawn-autoroll Roll ANGLE from ef8d9f10e684 to 28d4c3eb689c (1 revision) 2024-05-04 dawn-autoroll Roll Depot Tools from 58ff1badf92c to a60f90e38e53 (1 revision) 2024-05-04 dawn-autoroll Roll ANGLE from be9e63ad090d to ef8d9f10e684 (8 revisions) 2024-05-03 enga Expand top tier maxTextureArrayLayers to 2048 2024-05-03 dawn-autoroll Roll DirectX Shader Compiler from 381750e25b62 to af955d601dca (1 revision) 2024-05-03 dawn-autoroll Roll Depot Tools from 39c8c75cf6a2 to 58ff1badf92c (1 revision) 2024-05-03 zhusida GPU: Add NV16/NV24/P210/P410 multi-planar format support 2024-05-03 lehoangquyen Make DawnLoadResolveTexture compatible with TransientAttachments 2024-05-03 dawn-autoroll Roll ANGLE from a96e9197f538 to be9e63ad090d (3 revisions) 2024-05-03 ynovikov Suppress flaky WebGPU CTS failure on Android 2024-05-03 amaiorano Add sysroot DEP for standalone builds 2024-05-03 jrprice [spirv-reader] Handle OpIAdd instructions 2024-05-03 jrprice [spirv-reader] Accept DepthReplacing 2024-05-03 jrprice [tint][exe] Use `lower` when reading SPIR-V to IR 2024-05-03 jrprice [ir] Fix TINT_DUMP_IR_WHEN_VALIDATING 2024-05-03 bclayton [tint][ast] Skip ClampFragDepth fuzzer if member offsets collide (...) 2024-04-23 bclayton [tint][fuzz][ast] Add AddEmptyEntryPoint fuzzer 2024-04-23 bclayton [tint][fuzz][ast] Add AddBlockAttribute fuzzer 2024-04-23 bclayton [tint][fuzz] Limit the first_index_offset value 2024-04-22 shrekshao [Compat] Fix a bug when textureDimension with 1 arg is first called 2024-04-22 dawn-autoroll Roll DirectX Shader Compiler from e2f0b9844019 to 7cf175f89bf2 (1 revision) 2024-04-22 bclayton [tint][fuzz] Add fuzzer command line flags 2024-04-22 bclayton [tint][spirv-ast] Fix emission of discard followed by statement 2024-04-22 dawn-autoroll Roll Depot Tools from 6ba67afd6fb7 to b0e2e28a957d (1 revision) 2024-04-22 ynovikov Suppress Pixel 6 Android 14 failures already suppressed on Android T 2024-04-22 albin.bernhardsson Vulkan: Implement fast path for writeBuffer 2024-04-22 hitawala [YCbCr Samplers] Reland Rename SamplerYCbCrVulkanDesc to YCbCrVulkanDesc 2024-04-22 dawn-autoroll Roll ANGLE from 36ae4553287d to f2901ba7c2f6 (1 revision) 2024-04-22 dawn-autoroll Roll vulkan-deps from b7e3beee69a5 to 36da75a01950 (1 revision) 2024-04-21 dawn-autoroll Roll ANGLE from 23b8a833f3da to 36ae4553287d (1 revision) 2024-04-20 dawn-autoroll Roll vulkan-deps from 71b11532ed72 to b7e3beee69a5 (1 revision) 2024-04-20 dawn-autoroll Roll Depot Tools from 1abad43773fe to 6ba67afd6fb7 (3 revisions) 2024-04-20 dawn-autoroll Roll ANGLE from 84b8737394d5 to 23b8a833f3da (1 revision) 2024-04-20 dawn-autoroll Roll vulkan-deps from 4737535cad1a to 71b11532ed72 (6 revisions) 2024-04-20 enga Revert "[YCbCr Samplers] Rename SamplerYCbCrVulkanDesc to YCbCrVulkanDesc" 2024-04-19 dawn-autoroll Roll Depot Tools from b7ed76a09d19 to 1abad43773fe (3 revisions) 2024-04-19 dneto Fix clang-tidy warnings 2024-04-19 hitawala [YCbCr Samplers] Rename SamplerYCbCrVulkanDesc to YCbCrVulkanDesc 2024-04-19 hitawala [YCbCr Samplers] Add SamplerBindingType::YCbCr 2024-04-19 ynovikov Suppress flaky WebGPU CTS failures on Pixel 6 Android 14 2024-04-19 ynovikov Suppress Pixel 6 Android 14 failures already suppressed on Android T 2024-04-19 dawn-autoroll Roll ANGLE from d4abe62268f3 to 84b8737394d5 (5 revisions) 2024-04-19 dawn-autoroll Roll vulkan-deps from a746f1500410 to 4737535cad1a (7 revisions) 2024-04-19 cwallez BackendMTL: Re-add MTLGPUFamily::Mac1 as some builders use it. 2024-04-19 dawn-autoroll Roll Depot Tools from 6aaae8582125 to b7ed76a09d19 (4 revisions) 2024-04-19 jiawei.shao Reland "Implement AlignedAlloc and AlignedFree" 2024-04-19 jie.a.chen Add SharedTextureMemoryD3dSwapchainBeginState 2024-04-19 lokokung Remove extra namespace indent in webgpu_cpp header template 2024-04-19 dawn-autoroll Roll DirectX Shader Compiler from dda80a98c492 to e2f0b9844019 (5 revisions) 2024-04-19 bsheedy Add Win/ARM64 trybot 2024-04-19 dneto Fix clang-tidy warnings 2024-04-19 jie.a.chen Enable SharedTextureMemoryD3D12 concurrentRead 2024-04-19 dawn-autoroll Roll ANGLE from 6861da63bb01 to d4abe62268f3 (10 revisions) 2024-04-18 lokokung [dawn][wire] Make FillReservation release WGPU objects if released. 2024-04-18 dawn-autoroll Roll SwiftShader from 764410d4d655 to 9aec4b969291 (2 revisions) 2024-04-18 hitawala [YCbCr Samplers] Iterate over chain for external format validation 2024-04-18 dawn-autoroll Roll vulkan-deps from aa20d192b8c4 to a746f1500410 (2 revisions) 2024-04-18 dawn-autoroll Roll Depot Tools from af97284b58af to 6aaae8582125 (1 revision) 2024-04-18 dneto Fix clang-tidy misc-include-cleaner warnings 2024-04-18 cwallez Add WGPU[Obj]AddRef and deprecated WGPU[Obj]Reference 2024-04-18 ynovikov Suppress OpenGLES end2end failures on Pixel 6 2024-04-18 geofflang Reland "Use abseil's build targets instead of custom ones." 2024-04-18 hitawala [YCbCr Samplers] Pass VkSamplerYcbcrConversionInfo on creating Sampler 2024-04-18 cwallez Revert "Implement AlignedAlloc and AlignedFree" 2024-04-18 dawn-autoroll Roll DirectX Shader Compiler from 690ec7cd7d8d to dda80a98c492 (2 revisions) 2024-04-18 jrprice [tint] Polyfill fwidthFine for MSL and HLSL Created with: roll-dep third_party/dawn Bug: chromium:329228449 Change-Id: Iff0028a8d391ab8da4ccd8095a8dc0ac24d2ded4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5522774 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Le Hoang Quyen f3089d1d 2024-05-07T00:14:53 Metal: fix UBO data update undetected between draw calls. This CL fixes an issue where an UBO was updated between two draw calls. This would internally allocate a new metal buffer however ContextMtl didn't know that hence it didn't rebind with new buffers. Bug: b/338348430 Change-Id: I3d8ce22921811e49ae1b8016ae4a20d770f6f372 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5515858 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Yuly Novikov 6d10e966 2024-05-07T15:14:02 Switch ANGLE to new GPU Android mixins Bug: chromium:338536265 Change-Id: I25b7ff35ccea3fe8cde1661715f86fc341d2b82e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5522773 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya 62eb8fbe 2024-05-06T07:22:15 Vulkan: Switch to using zlib::crc32_z for CRC generation A CRC is generated to validate blobs that are compressed / decompressed. There was a custom CRC generator being used, switch over to using zlib's crc32_z(...) Also increment kPipelineCacheVersion's version since both the header and structure have been updated. Data collected with dEQP test suite - 1. egl size of blob - 74022 bytes ComputeCRC16 - 0.001683 sec zlib::crc32_z - 0.000008 sec 2. gles2 size of blob - 8709119 bytes ComputeCRC16 - 0.130268 sec zlib::crc32_z - 0.000625 sec 3. gles3 size of blob - 20308078 bytes ComputeCRC16 - 0.433155 sec zlib::crc32_z - 0.002547 sec 4. gles31 size of blob - 11041841 bytes ComputeCRC16 - 0.192512 sec zlib::crc32_z - 0.000452 sec Bug: angleproject:4722 Change-Id: Iaa7026c9c8a748b446ef2320e584a2937336c7b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5518595 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll da1fbbc6 2024-05-07T07:01:36 Roll Chromium from 4beb6b144a74 to 7a22cfe5a3e7 (616 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4beb6b144a74..7a22cfe5a3e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/beb031dae2..39e82ca2f8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3cdb58b684..de4f9bcc57 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a60f90e38e..4d9ad255f1 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/09737b8e11..d17298ab09 * third_party/r8: NvYmFgaDR5pSbEH88fOJRqBbLZT5maGLr_7_iZD3vg4C..a2gKt0z-OOG5sntIiNXVd6LFDWUuvR-rstsrF59EEnIC * third_party/siso: git_revision:70d9e16bcc9dff0264905018f5a5652b37ed0e10..git_revision:4524544994f4eac131378143f498ee4d0b7d1f36 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9e76abab9c..14ba9b58df No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: If874a3a14534903e044f7244f41de4ee582ee12d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5519175 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yiwei Zhang 5c78d084 2024-05-04T23:20:36 Android: explicitly disable stack protection This isn't needed by aosp build angle sp-hal and helps reduce cpu overhead. Bug: b/331680143, b/333235176 Test: 5% gain in gfxbench gl_driver2_off score on x86 Change-Id: I0e8662987ef040b1ac5df34a69e90c158363b36f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5516929 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org>
Yuly Novikov f8f2a10b 2024-05-03T18:11:22 Prepare ANGLE to use new Android mixins Bug: chromium:338536265 Change-Id: I225b79cb1a26b63cb74f0d2bd2c1f14048882722 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5514150 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Shahbaz Youssefi c3a1cae4 2024-04-15T14:58:55 Use angle::SimpleMutex everywhere in libGLESv2 Only cases left that use std::mutex are: - Share group and the context ErrorSet mutexes as they need try_lock() - Anywhere mutexes are used in conjunction with std::condition_variables (as they explicitly require std::mutex) Bug: angleproject:8667 Change-Id: Ib6d68938b0886f9e7c43e023162557990ecfb300 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5453294 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Le Hoang Quyen a951e0e0 2024-05-05T23:29:33 Metal: add test for active blit/compute & render encoder mistracking. The bug was already fixed but we need to add the test to avoid the issue from resurfacing in future. Bug: angleproject:8685 Change-Id: Ia10c0954ef39b20b1d891389b7e7a1c81cdc758d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5514529 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll b0875f12 2024-05-06T08:01:29 Roll VK-GL-CTS from 17c6e3c4dfad to 9d7b4c3d5533 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/17c6e3c4dfad..9d7b4c3d5533 2024-05-04 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-04 marcin.zajac@mobica.com DRM_BUF backed images witch format modifier 2024-05-04 javed@igalia.com Add test coverage for inline uniform blocks of smaller sizes 2024-05-04 cturner@igalia.com Explicitly test layered vs separated dpb images 2024-05-04 rgarcia@igalia.com Skip VVL configuration when using SELECTED_BUILD_TARGETS 2024-05-04 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-01 yuxinhu@google.com Add test log parser for new android activity 2024-05-01 lorenzo@khronosgroup.org Add verbose option to build_spirv_binaries.py 2024-05-01 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-25 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-23 lorenzo@khronosgroup.org Update external sources If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ic4db01e548ae1bbc06b0f4426d0e95eb7e4b5ced Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5516413 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ff0a33cd 2024-05-06T07:00:21 Roll Chromium from dbc600a2b0d5 to 4beb6b144a74 (625 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dbc600a2b0d5..4beb6b144a74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e940249fa3..beb031dae2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/123fabe3ab..3cdb58b684 * third_party/android_build_tools/lint: O1UDDudkb1fHG2uMxzszPWctYiGgjyywsi7Lbkq7roYC..Y5wuGPB-HfFtEVQC_0XI6n88Covm4HFDxnG0uTdV2LcC * third_party/android_build_tools/manifest_merger: wRnJA-ZlBBQipw_wjYJJemxCCPSZHenIFsWKi3GI_FUC..tz8dYQ_yBEZJRVhtzyyCjOlbOfujkHRWcYZy7419o_cC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8ed0817e40..36a6c64282 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0421a22c02..4cc26001b9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/39c8c75cf6..a60f90e38e * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/51fe358446..09737b8e11 * third_party/r8: QA5iuNqPTlPiuU3Vz1wq-t2s8V1IGAKT-qZL9kVWv3YC..NvYmFgaDR5pSbEH88fOJRqBbLZT5maGLr_7_iZD3vg4C No update to Clang. Bug: angleproject:8434 Tbr: abdolrashidi@google.com Change-Id: I95779d6b1786985ac86d1d8b806727ae82dd4f90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5517542 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yiwei Zhang 465f6b7d 2024-05-03T20:52:55 Android: forward visibility flags This results in a 25~35% perf gain for gfxbench gl_driver2_off on x86 platforms. See also https://gcc.gnu.org/wiki/Visibility Bug: b/331680143, b/333235176 Test: 25~35% gain in gfxbench gl_driver2_off score on x86 Change-Id: I5fb1174ae21f9feb33b8350e21f7cc5445b9cf25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5513280 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 58742dfb 2024-05-05T12:46:11 Use trim() instead of resize() ... when decompressing a blob, this prevents a reallocation and copy. Bug: angleproject:4722 Change-Id: Iedc20cb9a41feb754c7f48188e01ab73c5c03c15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5517530 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Le Hoang Quyen 251067ed 2024-05-03T22:36:11 Metal: don't break render pass when uploading a texture. Bug: b/337214693 Change-Id: Ib2dc77c364a72f2973cbc3882f6125bffbc0a11b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5514948 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Le Hoang Quyen 9ccb9b41 2024-05-03T22:23:03 Metal: fix incorrect tracking if blit & render encoder coexist Currently mtl::CommandBuffer tracks only one active command encoder. However this tracking is wrong if a blit/compute encoder is created without ending the current render encoder. Blit/compute and render encoders are allowed to coexist because the actual rendering encoding is deferred. The bug would happen for e.g. if: - There is an active render encoder. - ContextMtl::getBlitCommandEncoderWithoutEndingRenderEncoder() is called. - In this case, active encoder will be set to the blit encoder. - Later when blit encoder is ended, tracked active encoder would be set to null even though it should be the render encoder. This CL fixes the bug by tracking separate active blit/compute & render encoders. Bug: angleproject:7643 Bug: angleproject:8685 Change-Id: I9893402ecd4c0388aa0153acdb2be04315563086 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5514184 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Charlie Lao 28d4c3eb 2024-05-03T13:00:03 Vulkan: Remove BarrierType argument from ImageHelper::barrierImpl Originally I passed the barrierType argument into barrierImpl function to force pipelineBArrier in a few edge cases. Notably when we do a oneoff submission. In that case if we have an event that is pending setEvent call, and we will end up inserting a waitEvent call on an event that has not yet set, which is bad. But this really won't not happen. This CL removed BarrierType from the API and added a few assertions in the caller to ensure we do not have a valid event when doing a oneoff submission (if there is a pending setEvent, mCurrentEvent will be valid). Bug: b/336844257 Change-Id: I7161b844fc1f36993cf7ff6c90a070d9f92930cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5512878 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao ef8d9f10 2024-05-01T11:52:04 Vulkan: Use DEVICE_ONLY VkEvent when available VK_KHR_synchronization2 adds device only event. Since we are not using host operations on the event, this CL adds VK_EVENT_CREATE_DEVICE_ONLY_BIT_KHR bit when create VkEvent for RefCountedEvent. Bug: b/336844257 Change-Id: I0528b7f45b0da162daa228aea2adf5ce06b5fd6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5503644 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 5eb3bca0 2024-05-01T11:47:34 Vulkan: Minor cleanup Bug: b/336844257 Change-Id: I8d93c6dd814a666debf9990d151cad79c45469f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5503645 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Mohan Maiya 4880a6c2 2024-05-03T14:43:20 Enhance VulkanPerformanceCounterTest coverage Enable additional config with PadBuffersToMaxVertexAttribStride feature Bug: b/271915956 Change-Id: I5fe27781fc51cdf477d5c2f453ad05a211788739 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5512875 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao d30e4772 2024-02-02T14:13:33 Vulkan: Add VkCmdWaitEvents for image barriers This CL add EventBarrierArray (sister class of PipelineBarrierArray) that accumulates the event barriers instead of pipeline barriers. ImageHelper::barrierImpl and ImageHelper::updateLayoutAndBarrier has been updated to have a code path that inserts waiting event to EventBarrierArray. PipelineBarrier code path is still kept and is also used when event is invalid or under certain situation as a fallback method from waitEvent. After we generate barrier (regardless it is pipelineBarrier or eventBarrier, we always release ImageHelper::mCurrentEvent. When next barrier/layout call is made, if we see mCurrentEvent is invalid, we always fallback to pipelineBarrier. This way it is safe that if somehow we did not (intentionally or accidentally) insert a new event between two barrier calls, we will not end up with second barrier call wait for old event which creates synchronization hazard. With this approach, second barrier will use pipelineBarrier which is still safe. In this CL the useVkEventForImageBarrier feature flag is still disabled, so no events are created and thus pipelineBarrier is still used. Bug: b/336844257 Change-Id: Idaf5a7200b85f901eae5d376543f189d21522022 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5263701 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Liza Burakova ead98ed9 2024-05-02T14:04:14 Implement basic texture upload. This change modifies ImageHelper's methods to upload textures to fix webgpu API calls, as well as fully implements uploading texture data via TextureWgpu::setImage for RGBA8 formats. Bug: angleproject:8457 Change-Id: I1c5be3d79ad996a709086ca7157cca6229a336ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5398002 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 81c2b6e7 2024-05-03T08:12:18 Vulkan: Account for padBuffersToMaxVertexAttribStride ... in BufferVk::shouldRedefineStorage. For vendors that require additional padding, redefine storage iff the padded size is greater than existing buffer size. Bug: b/271915956 Change-Id: I2acf2bb32f85b71bcfdba6919974dd2922ee787b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5512870 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 9f3e3bff 2024-05-03T17:28:28 Manual roll Chromium from b689a9ee3ba2 to dbc600a2b0d5 (109 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/b689a9ee3ba2..dbc600a2b0d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ce8359ec57..e940249fa3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cdf49d0710..123fabe3ab * third_party/r8: fXvmQSzprkeb1fs3dnkBm_gsAhb5aUtQGRmUq3Oi1WYC..QA5iuNqPTlPiuU3Vz1wq-t2s8V1IGAKT-qZL9kVWv3YC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/17956d4ffb..9e76abab9c No update to Clang. Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: Ie17cfea3a693b71bf9395e3d7004207139ba549a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5513272 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 9aa6d3da 2024-04-26T11:34:10 Add trim support to MemoryBuffer There are usecases where we need a MemoryBuffer to be trimmed to a smaller size. In such cases there is no need to perform a resize, which would trigger a reallocation. Instead just update MemoryBuffer's size. Bug: angleproject:4722 Change-Id: I5b6cca121977903ffa7663591eaec62f6ffda97a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5513269 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Roman Lavrov be9e63ad 2024-05-02T16:04:25 spirv::Print without ANGLE_ENABLE_ASSERTS -> compile error Currently a link error as we have a declaration but no definition Bug: b/338429767 Change-Id: I06175356613c410c8d7652b28b09636244f8b717 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5513002 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Mohan Maiya 97aaad3a 2024-04-20T19:27:13 Vulkan: Pack DescriptorSetLayoutDesc layout Use angle::FastVector instead of arrays to further compact DescriptorSetLayoutDesc layout Bug: angleproject:8677 Tests: VulkanDescriptorSetLayoutDescTest* Change-Id: I5bb7b2ebf0aa5aba3d7c47c45384788245dce3dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5470362 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 04e469bc 2024-05-03T07:58:45 Roll Chromium from 904b00ce27b4 to b689a9ee3ba2 (548 revisions) https://chromium.googlesource.com/chromium/src.git/+log/904b00ce27b4..b689a9ee3ba2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5eb3babb02..ce8359ec57 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9e629115ed..cdf49d0710 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7ababdfe02..39c8c75cf6 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/4da68f31de..4abbe88863 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d62c213c1e..cc51a5ea86 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e28e015fae..17956d4ffb * tools/luci-go: git_revision:01d1863acbd3d4c41da2aa7407a0ea6a195c770f..git_revision:69f852c6aea2797c75712d59145efd38d7032196 * tools/luci-go: git_revision:01d1863acbd3d4c41da2aa7407a0ea6a195c770f..git_revision:69f852c6aea2797c75712d59145efd38d7032196 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8ca02a85c4..668bf195ba * tools/skia_goldctl/linux: AJacKGh5nnjmNZk56j2ia4-QtIE8eEAFELw48t8XinEC..4Ox2OXGb8xipJPUsrFptKWJNJelzwWHBB3ORF1iHt94C * tools/skia_goldctl/mac_amd64: uJJWpJUp-FSzEXlwqzoUD41p5swLKyDhxXdJBLShbMsC..-H7DJpIRXUmi9ddRqVRJXThT1nlK7ns94UOnHMmeP4IC * tools/skia_goldctl/mac_arm64: ekRiJKPFBJKiZ3N4ev_vRuf2X13dgTDcZNXKYt2qZPoC..FclksBOdZsrGv0dS7P163Fl3zi60z6nQCDXMNOoAYLYC * tools/skia_goldctl/win: 4bTyiie8-MG6hBk2yGEE9d8p3HWHGevaAouvGfKKwtQC..CBmdgsk0TAPgochRHBMBS9LZzdhYMOsNaJSAPvA-e-YC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Iec4c2af4a587bb74dd14cf5f65e5e01d134a2d44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5512867 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao a96e9197 2024-04-25T10:35:02 Vulkan: Add RefCountedEvent class and VkCmdSetEvent call This CL defines RefCountedEvent class that adds reference counting to VkEvent. CommandBufferHelper and ImageHelper each holds one reference count to the event. Every time an event is added to the command buffer, the corresponding RefCountedEvent will be added to the garbage list which tracks the GPU completion using ResourceUse. That event garbage's reference count will not decremented until GPU is finished, thus ensures we never destroy a VkEvent until GPU is completed. For images used by RenderPassCommands, As RenderPassCommandBufferHelper::imageRead and imageWrite get called, an event with that layout gets created and added to the image. That event is saved in RenderPassCommandBufferHelper::mRefCountedEvents and that VkCmdSetEvents calls are issued from RenderPassCommandBufferHelper::flushToPrimary(). For renderPass attachments, the events are created and added to image when attachment image gets finalized. For images used in OutsideRenderPassCommands, The events are inserted as needed as we generates commands that uses image. We do not wait until commands gets flushed to issue VkCmdSetEvent calls. A convenient function trackImageWithEvent() is added to create and setEvent and add event to image all in one call. You can add this call after the image operation whenever we think it benefits, which gives us better control. (Note: Even if forgot to insert the trackImageWithEvent call, it is still okay since every time barrier is inserted, the event gets released. Next time when we inserts barrier again we will fallback to pipelineBarrier since there is no event associated with it. But that is next CL's content). This CL only adds the VkCmdSetEvent call when feature flag is enabled. The feature flag is still disabled and no VkCmdWaitEvent is used in this CL (will be added in later CL). Bug: b/336844257 Change-Id: Iae5c4d2553a80f0f74cd6065d72a9c592c79f075 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5490203 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi e4a12a67 2024-05-02T13:25:53 Vulkan: Dynamic depth test + static depth write When depth test changes in such a situation, the static state is still affected (because we mask depth write with depth test) so the graphics pipeline still needs to be invalidated. Bug: b/336386662 Change-Id: Iebba79ffd7d6fa3962a5b20c27efcca3aa35b10a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5511602 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov e8712205 2024-05-02T17:37:12 End ANGLE Mac Intel experiment Bug: chromium:326904538 Change-Id: I0cb2db356bcb7760ca64a51b4bc853fecaf001de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5510844 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Shahbaz Youssefi 04825894 2024-05-02T11:17:33 Vulkan: Turn SPIR-V limitations to crash instead of security bug The input shader can be made complex in a number of different ways, resulting in instructions with a length higher than what can fit in SPIR-V (i.e. 16 bits). Ideally, the translator would catch such complex usage early on and gracefully fail compilation. However, as a safety net, this change makes sure such a case is detected when the SPIR-V instruction is being generated and turned into a crash. This makes sure such bugs are no longer security bugs. Bug: chromium:335613092 Change-Id: I5c0693ac1ead5af04977417f10572018f8aa72bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5510722 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Brian Sheedy e5606471 2024-04-25T14:48:53 Start Linux/Intel experiment Bug: chromium:41496254, angleproject:8680, angleproject:8682 Bug: angleproject:8683 Change-Id: I1956ac642969cae0c17fff87388e899237b9df2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5491789 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
angle-autoroll f2182a71 2024-05-02T14:51:49 Manual roll Chromium from bc4f0a08ba8d to 904b00ce27b4 (619 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/bc4f0a08ba8d..904b00ce27b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0347db4c4f..5eb3babb02 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6ed3b71a7d..9e629115ed * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2c1ad970da..31bdf8fec4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e84a4942dc..0421a22c02 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e75b940aea..7ababdfe02 * third_party/r8: eec4ZxEvkO7Pa1LUWDkVKiCv0bZjS7ctubjxW94ZYVYC..fXvmQSzprkeb1fs3dnkBm_gsAhb5aUtQGRmUq3Oi1WYC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/49bb033593..d62c213c1e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cc8e1423f4..e28e015fae * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/880331b699..8ca02a85c4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/73a1c67b51..7ef4ff5ba3 Clang version changed llvmorg-19-init-8943-gd8503a38:llvmorg-19-init-9433-g76ea5feb Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/cc8e1423f4ade8b4871bc33fa44f061826bff2ff..e28e015fae35a9ff21a2550e8e7cfe9fedd85558/scripts/update.py Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I62b58317a721bca1271f01647ff4b052e699aa50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5509904 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 44bdc2af 2024-04-23T19:43:29 restricted_trace_perf: Write summary for single renderer For use when generating spreadsheets focused on Vulkan. Previously the script would exit without generating a CSV file unless there were two renderers to compare. Test: restricted_trace_perf --renderer vulkan Bug: b/317411251 Change-Id: Ic9872599edb38c738112265b1ce7f252cf3f966a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5508315 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Charlie Lao caebfea1 2024-04-24T16:58:39 Vulkan: Make PipelineBarrierArray a class Right now PipelineBarrierArray is just a angle::PackedEnumMap<PipelineStage, PipelineBarrier>. To make iterate over barrierArray faster we added mPipelineBarrierMask. They are not encapsulated well. This CL makes PipelineBarrierArray a class which internally tracks mPipelineBarrierMask bits. We also moved pipelineBarrier related code into this class. This is a preparation for the later CL that we will have a EventBarrierArray so that the pipelineBarrier and eventBarrier are better separated. Bug: b/336844257 Change-Id: I6002e3fdd584d5a63587f68f13a260b417b3db32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5484711 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 1bb1ee06 2024-04-29T15:27:36 GL: Sync unpack state for glCompressedTexSubImage3D Unpack state is supposed to be ignored for compressed tex image calls but some drivers use it anyways and read incorrect data. Texture3DTestES3.PixelUnpackStateTexSubImage covers this case. Bug: chromium:337766133 Change-Id: Ic11a056113b1850bd5b4d6840527164a12849a22 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5498735 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 53811e86 2024-05-01T08:09:48 Roll Chromium from 83c70f11490d to bc4f0a08ba8d (625 revisions) https://chromium.googlesource.com/chromium/src.git/+log/83c70f11490d..bc4f0a08ba8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc7e21c7b0..0347db4c4f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d0f0285d02..9703d9137f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/79213704bc..6ed3b71a7d * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d64937aec7..8ed0817e40 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/2d7b0a17b7..f80bca53c2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/835aa3e871..e84a4942dc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c87882a7b..e75b940aea * third_party/fuchsia-sdk/sdk: version:20.20240412.2.1..version:20.20240430.3.1 * third_party/r8: 7sVFkxumsokMdM4MavgTQKuAVJ2_MQLCkqc9uln8Gl0C..eec4ZxEvkO7Pa1LUWDkVKiCv0bZjS7ctubjxW94ZYVYC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/2451d1d2b6..49bb033593 * tools/luci-go: git_revision:239be4fd8499df782db6bddb0f55832bf4f01307..git_revision:01d1863acbd3d4c41da2aa7407a0ea6a195c770f * tools/luci-go: git_revision:239be4fd8499df782db6bddb0f55832bf4f01307..git_revision:01d1863acbd3d4c41da2aa7407a0ea6a195c770f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6e4e92a394..73a1c67b51 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ie3ffb90207e23d08cb2e6e322a811b3c3b1cd952 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5503640 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi bb6a5724 2024-04-29T16:01:47 Use vendor ID to check QCOM device for tests * In angle_test_instantiate, IsQualcomm() will now use the vendor ID as well. Bug: b/331271522 Change-Id: Ifb26034516a007472fb2a54f34f332e34b46a365 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5499382 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Charlie Lao 950afec4 2024-04-30T09:38:43 Vulkan: Add VK_KHR_synchronization2 feature flag This CL adds VK_KHR_synchronization2 feature flag and enables the feature if exists. Bug: b/336844257 Change-Id: I201768e32c997125472c6a005c4635141441451e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5499379 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 2d1bb3e1 2024-04-15T00:58:07 CL: Replace Spinlock with angle::SimpleMutex Bug: angleproject:8667 Change-Id: I9b53da920ea743d77c76793522cef826ecc62813 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5446559 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski 6658d5e8 2024-04-25T13:51:43 Tests: Add Modern Combat 5 trace Test: angle_trace_tests --gtest_filter=*modern_combat_5 Bug: b/330861486 Change-Id: I54b22010fdb5be6d1113f4dd6561848b44a413cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5501770 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Gowtham Tammana 298b8739 2024-04-15T13:58:01 Vulkan: Restrict the ContextVk dependency in CommandBufferHelper Updating the interfaces that have no need for ContextVk state and instead passing in the vk::Context. Bug: angleproject:8544 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Change-Id: Id3b72d9eabb7d1d6ee89c46cdc24a23da9e32b5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5492319 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e49b941f 2024-04-30T07:02:15 Roll Chromium from 228731187f89 to 83c70f11490d (641 revisions) https://chromium.googlesource.com/chromium/src.git/+log/228731187f89..83c70f11490d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cc3072434e..dc7e21c7b0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b915e95c06..d0f0285d02 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5ce487451c..79213704bc * third_party/android_build_tools/lint: f5ptuXixKwddKw0rnCKuNjXY9E35_710E7SNxoOLNnMC..O1UDDudkb1fHG2uMxzszPWctYiGgjyywsi7Lbkq7roYC * third_party/android_build_tools/manifest_merger: Xef4nLhp0rWWjXJXt9CTFjQF8S6qRduSY7LZCcJi48QC..wRnJA-ZlBBQipw_wjYJJemxCCPSZHenIFsWKi3GI_FUC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e057d1ff15..d64937aec7 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/bb9e0f87b9..2d7b0a17b7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/11804c96b1..835aa3e871 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4246ba023a..2c87882a7b * third_party/kotlin_stdlib: E67atHdREsWLno-3b4Py3r87C4LB7gpVYDq3Q1z7t90C..05hzFgOi0AqRK3RxbSvGj2TWTFUNeLcwkJwVzwgLttUC * third_party/turbine: agNIST7gEMTmrnvQLPzx2dduGa52uMmOx3fEWm9z5MEC..fYpnoJAvh8-OaNB9k81XWGrwiODb_uTipTBEUeIFM98C * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4852168b7d..6e4e92a394 * tools/skia_goldctl/linux: ZpyLtfuztdYI-RCkvm6kXlmx8ec1wYyrwXNI-lQEJKwC..AJacKGh5nnjmNZk56j2ia4-QtIE8eEAFELw48t8XinEC * tools/skia_goldctl/mac_amd64: FpwpXsMPl8Mets8uet3zfFw8nNBpl69xJoTYESLUjl8C..uJJWpJUp-FSzEXlwqzoUD41p5swLKyDhxXdJBLShbMsC * tools/skia_goldctl/mac_arm64: GuJOsvx5V5z8DvAM_HOVy6eBydQ0sO7dVso_p_L7KTgC..ekRiJKPFBJKiZ3N4ev_vRuf2X13dgTDcZNXKYt2qZPoC * tools/skia_goldctl/win: LT6gNudC207ke0t4qv9IW_s27hoPIafnwpcfrzR8FzMC..4bTyiie8-MG6hBk2yGEE9d8p3HWHGevaAouvGfKKwtQC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I39958fa4d14fcadbc77fe5b5ebffb1e00f9e3b18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5499949 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang b839e05b 2024-04-29T14:35:42 GLSL: Hardcode emulated atan functions These emulated atan functions are generated for every compiled shader, the string generation is particularly costly for small shaders (>30% of total compile time). Instead just hardcode the emualted functions, there are only 4. Bug: angleproject:8434 Change-Id: I3f8b7cc9709ca132fae19953c23d02e54538d4e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5498516 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Charlie Lao 1064b38d 2024-04-24T14:41:59 Vulkan: Move ImageLayout define to earlier in vk_helpers.h file This is the preparation for the later CL. Later in the CL I need to define something like "angle::PackedEnumMap<ImageLayout, RefCountedEvent>" to use in CommandBufferHelperCommon. So I need ImageLayout to be defined earlier. No actual changes involved other than moving the code around for easier code review. Bug: b/336844257 Change-Id: I0a2553ef3aebf4b00d1798e2117fe6ed32ac172d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5484675 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 4929e1df 2024-04-24T14:09:59 Vulkan: Add feature flag for using event for image barrier This is preparation CL that adds a feature flag for using VkEvent for image barriers. Bug: b/336844257 Change-Id: I01a7d779e16e2c259ddd05dca7338b3b18c30ba7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5484708 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f51f2bc5 2024-04-29T16:18:33 Manual roll vulkan-deps from 736920240f0b to 74fe79763664 (13 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/736920240f0b..74fe79763664 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b5672e8e8d..f857417c99 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/9aec60c387..d21838aeaa * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/d0ffc68fe7..68780d9b8c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9911e85d47..397d8fbc0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: Ib28650fa98f33ac7c578b83763a3eb1ca65ad8c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5495021 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 038ad6c7 2024-04-23T13:23:04 EGL: Use unlocked tail calls for surface, sync and img calls EGL surface and sync calls can be expensive to do while holding the global lock on EGL. They are safe because the parameters are captured by value and the underlying EGL driver is also thread safe. EGL image creation also tends to be expensive and is called freqently by Chrome. Bug: angleproject:8434 Change-Id: I7e554fe2e3700d98469de267f7bbff1e96358c78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5478229 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 978cf07b 2024-04-25T14:35:14 Suppress failures on Pixel 6 AP1A.240405.002 Bug: b/336847261 Change-Id: I501f64e22536418715369742f5ec760e23aa2c14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5489759 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 44ce5887 2024-04-11T16:37:27 Allow the backend to do resource init for framebuffers. The frontend framebuffer would loop through attachments which needed to be initialized and call initializeContents on them individually. For the GL backend this is inefficient because each of these resources is bound to a scratch framebuffer and cleared when the entire original framebuffer could have been cleared at once. The frontend now accumulates a set of attachments that need to be cleared and sends it to the FramebufferImpl. The default FramebufferImpl does the old logic of calling initializeContents on each attachment. FramebufferGL has an optimized path to clear the whole framebuffer if possible. Bug: angleproject:8642 Change-Id: I574cd03307794a6c7b2666976784e4d4dca1d08c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5448552 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Mohan Maiya a0b721bc 2024-04-23T17:08:58 Vulkan: Optimize DescriptorSetLayout with no bindings There is no need to unpack bindings of DescriptorSetLayoutDesc and call into vkCreateDescriptorSetLayout when there are no bindings. Insert a placeholder vk::DescriptorSetLayout into DescriptorSetLayoutCache. This reduces the number of Vulkan handles created and can be reused across multiple pipelines that have DescriptorSetLayoutDesc with no bindings. Bug: angleproject:8677 Change-Id: Ifc0d199697a95f3a5c037fd85520220a512d7949 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5483308 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 2eed792c 2024-04-15T01:09:57 Vulkan: Use angle::SimpleMutex with async command queue This change lets ANGLE test the waters with angle::SimpleMutex with functionality that is currently mostly exercised by tests. Bug: angleproject:8667 Change-Id: Icf3a021da1f0a2e1c9235ed518bcb9e378b09cfa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5446560 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Gowtham Tammana acb8b33f 2024-04-16T14:08:34 Vulkan: Enable 8/16 bit storage buffer extensions The support for 8bit and 16bit storage buffers are exposed via VK_KHR_{8,16}bit_storage vulkan extensions. Add checks for these extensions and enable them if present. The changes in FeaturesVk_autogen.h in the change are generated by running the run_code_generation.py script. Bug: angleproject:8676 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Change-Id: Idcda416e3eb6a735e021cd5bb0a182af341e9a16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5491781 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 5907fcfd 2024-04-29T07:00:28 Roll Chromium from 0129806a25c3 to 228731187f89 (630 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0129806a25c3..228731187f89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e797b8d487..cc3072434e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/86bf72c93e..b915e95c06 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/de15ed6974..5ce487451c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e70dca1b50..e057d1ff15 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/774f822ffd..11804c96b1 * third_party/r8: vLf3kX0m10K0jItylIPHXJzX-Df7gLlx0EN_jDuagU0C..7sVFkxumsokMdM4MavgTQKuAVJ2_MQLCkqc9uln8Gl0C * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/a3f7e1c3fd..2451d1d2b6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9570c8ceea..cc8e1423f4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e2665361f3..4852168b7d No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I1bac230028af98edb9ec32034953f1d08d78d211 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5496247 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 8332e5b1 2024-04-26T14:29:32 Use python3 instead of python for bootstrap * In roll_aosp.sh, replaced the remaining python usage with python3. Bug: b/246559064 Change-Id: Iea9737376c34264fec5d60e4cb772eb8c5be81f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5494462 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Mohan Maiya b74de557 2024-04-24T14:35:17 Vulkan: Add a feature related to shader subsets On vendors that support VK_EXT_graphics_pipeline_library the shaders subset of the pipeline can either be combined into a single pipeline or can be decoupled into separate pipelines. Upcoming optimizations require the ability to distinguish between the two options. Add a feature declaring support for only the combined variant. Bug: angleproject:8601 Change-Id: I44fb828d972ca6ebba5549819ce8e41645683e14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5484673 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Dan Glastonbury d9a00875 2024-02-21T16:57:43 Metal: Override internal format of images Add support for overriding the internal format when binding Metal textures to EGL images. Fixed: angleproject:8552 Change-Id: I364a88a2e608e462c5216c92927679814ab91ca5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5310305 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Roman Lavrov 89caa0e1 2024-04-23T15:32:52 Cleanup: replace DirtyObjectType check with constexpr generator Static assert was meant to avoid kDirtyObjectHandlers getting out of sync, but it doesn't achieve that goal as it's just comparing values with ints which is confusing. Replacing with constexpr generated std::array. C++20 allows to easily validate that all values are set by _not_ default-initializing `handlers`. C++17 makes it trickier, addeded static_assert on an additional static constexpr bool (silly but I can't find a more concise way) Bug: angleproject:8666 Bug: b/335295728 Change-Id: Idf9bbd087d09d5ba253a7587ce0503cae3fcf3a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5478231 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 5e37ae35 2024-04-26T10:01:04 Roll vulkan-deps from a4bf9c4e9ffd to 736920240f0b (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a4bf9c4e9ffd..736920240f0b Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/17c8bcb0e8..9911e85d47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ib793e124990695da8ee822d048db427952d13ea0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5493529 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 884dc380 2024-04-24T16:46:01 EGL: Make eglGetCurrent(Context|Surface|Display) lockless. These functions access only egl::Thread state. Bug: angleproject:8434 Change-Id: I3dd6cd1f4fd145613f0be824e4f6e13815422997 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5485526 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll bea8d9dd 2024-04-26T08:13:29 Roll Chromium from ad99ecc02953 to 0129806a25c3 (372 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ad99ecc02953..0129806a25c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dfdfe582f6..e797b8d487 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/571c37f17d..86bf72c93e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/03850de4bf..de15ed6974 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d980d879d2..774f822ffd * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a52511c59..4246ba023a * third_party/r8: mhSwabeiU2ueQeYkj0X1JTg-6ZdtQgiVVXM1bo0yu4IC..vLf3kX0m10K0jItylIPHXJzX-Df7gLlx0EN_jDuagU0C * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e8280e634c..a3f7e1c3fd * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/949930758e..9570c8ceea * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/36708f2aa1..e2665361f3 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I8fccc3876ddee207b9ca39558d343fd724009a08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5493526 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand c62c0c25 2024-01-24T17:29:45 CL/VK: Implement initial enqueueRead/WriteBuffer Bug: angleproject:8638 Change-Id: I1d5b3b15fab24ce35c243a3eb27bcac2104d7f5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5409250 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Austin Annestrand 6cfb5931 2024-03-13T12:31:40 CL/VK: Implement marker and barrier cmds Adding in last remaining marker and barrier cmds: clEnqueueMarker clEnqueueBarrier clEnqueueMarkerWithWaitList clEnqueueBarrierWithWaitList Bug: angleproject:8634 Change-Id: I67e03e379c3f9e40a31bcba34ea85e2739cc97b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406617 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 55affbfd 2024-04-25T17:34:09 Manual roll Chromium from 0543b5c427ca to ad99ecc02953 (246 revisions) Manual roll requested by bsheedy@google.com https://chromium.googlesource.com/chromium/src.git/+log/0543b5c427ca..ad99ecc02953 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,bsheedy@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a1bcbf3070..dfdfe582f6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/89090fdbd1..03850de4bf * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/01d7072ad6..d980d879d2 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fb94001f06..9a52511c59 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0aaac4902f..949930758e No update to Clang. Bug: None Tbr: ynovikov@google.com,bsheedy@google.com Change-Id: Iadac5adc4672786702c5c856114a89f5f54c6300 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5490169 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand 04329fe0 2024-01-24T12:51:05 CL/VK: Implement wait APIs This commit implements: clWaitForEvents clEnqueueWaitForEvents Bug: angleproject:8633 Change-Id: I873310ab11dfac08c165dc36be2400a35be48878 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406616 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Mark Lobodzinski e3a58b25 2024-04-11T09:33:55 FrameCapture: Support deferred linking of shaders Modern Combat 5 creates and attaches programs and shaders but defers compiling and linking until needed. Added support in the tracer for this corner case and updated CapturedTest to exercise this behavior as well. Test: angle_end2end_tests --gtest_filter=CapturedTest.MultiFrame/ES3_Vulkan Bug: b/334030316 Change-Id: Ib7fdf0fe25b11cdb3df33d50e49501f3a51e9510 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5449599 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 37d2277b 2024-04-23T20:00:04 Vulkan: Disable dynamic state on JM based Mali Latest Vulkan driver causes a number of issues on this GPU. Bug: b/336411904 Bug: b/336847261 Change-Id: I34a4842ba501c5f71c8b9c7d97c2bb215b30d7be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5484709 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0