kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll a21631c0 2023-08-02T07:02:03 Roll Chromium from d27b5fe3e6fd to 5b2aecb232a1 (636 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d27b5fe3e6fd..5b2aecb232a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools/linux64: git_revision:3fccef9033b950e8935e8debeba9fbd71617bc74..git_revision:811d332bd90551342c5cbd39e133aa276022d7f8 * buildtools/mac: git_revision:3fccef9033b950e8935e8debeba9fbd71617bc74..git_revision:811d332bd90551342c5cbd39e133aa276022d7f8 * buildtools/win: git_revision:3fccef9033b950e8935e8debeba9fbd71617bc74..git_revision:811d332bd90551342c5cbd39e133aa276022d7f8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/32a858d0c6..5bb46c40d0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2643aac1be * third_party/clang-format/script: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git/+log/f97059df7f..e5337933f2 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a8946f3d83..70d971a135 * third_party/r8: 5zBwrOBV6XLXneCTZuxcrWGyYYZ25ZZC0t4dVtUEnFwC..l5dYfHmu8G4vGM9POQl7UoH_PVAssdiMEQNUmpxsNIAC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/aaaca01444..1fceefa905 No update to Clang. Bug: angleproject:7904 Tbr: yuxinhu@google.com Change-Id: If56510d542fbeffea0b5d3b5c6da758e5df0eb99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4738186 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alan Zhao 5d4b3645 2023-07-31T14:04:01 Fix a missing symbol with ANGLE e2e tests angle_end2end_tests has the same issue as CaptureRelayTests which was fixed in https://crrev.com/c/4728461 where a symbol was not found during link-time on Windows due to __declspec(dllimport). Bug: chromium:1468150 Change-Id: Id943967b0f32d30ff69dfc013aafa69bd812ccaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4735273 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll b53d99d8 2023-08-01T07:01:04 Roll Chromium from 1cd9335ae38e to d27b5fe3e6fd (523 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1cd9335ae38e..d27b5fe3e6fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/300fe30c80..32a858d0c6 * third_party/android_build_tools/manifest_merger: 8fr-1Vf_pfxN9ulzWVaZvIXggDgWDs-0dtlGA1Sue48C..d1tFnzOW6H5xoDN7WWsMuAiHuhkl0kXijQGiO7IU1VQC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fae769bddf * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8424103c4e..a8946f3d83 * third_party/r8: QJNQAx1B3aL7NHHWyWAOLYCzEWfggtFhljm4b2wNk0wC..5zBwrOBV6XLXneCTZuxcrWGyYYZ25ZZC0t4dVtUEnFwC * third_party/turbine: 2I2Nz480QsuCxpQ1lMfbigX8l5HAhX3_ykWU4TKRGo4C..njzYdPKg07o6bisJmD2GAMXIi0p3KPbBy93bLGnp2TYC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/43f8a41f8f..3bb8a70706 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/236e66ffd6..02d5529a3f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/19f0f9d6bf..aaaca01444 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2c5f3235ed..6c7511171d No update to Clang. Bug: angleproject:6430 Tbr: yuxinhu@google.com Change-Id: I875617e13047c35727029fac7437fe928681ce21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4735569 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brian Ho 6dc0c9d6 2023-07-31T22:54:03 Revert "Use DisplayVkSimple on ChromeOS" This reverts commit b8ddba2a674158ec6135eda18c3371be84ad6ff7. Reason for revert: Breaks Chromium Original change's description: > Use DisplayVkSimple on ChromeOS > > Currently, we always use DisplayVkHeadless on ChromeOS which can fail > if the drivers do not support VK_EXT_headless_surface (e.g. Intel). > This CL changes the default to use DisplayVkSimple which requires > VK_KHR_display which is better supported. At the end of the day, CrOS > never really uses Vulkan WSI, so the actual WSI extension used > doesn't matter. > > Bug: b/292249282 > Change-Id: I0f8cfafa635405850cda97c84ad45d3f6aec5103 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4727450 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Brian Ho <hob@chromium.org> Bug: b/292249282 Change-Id: If3ab1a39cb86dae1bf0652ca16bba323f497fcc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4734578 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Brian Ho <hob@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 4e0250f1 2023-07-27T10:51:07 GL: Remove EGL_EXTERNAL_CONTEXT_SAVE_STATE_ANGLE Now that Chromium no longer uses it. Bug: angleproject:5509 Change-Id: Ibb8d9cdc4d67dad77ca50437423b18d81e838203 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4724768 Reviewed-by: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll cb4b1f36 2023-07-31T14:32:41 Manual Roll VK-GL-CTS from e7b180ad5366 to 00cccd7cf562 (37 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/e7b180ad5366..00cccd7cf562 2023-07-28 jbolz@nvidia.com Remove early-outs that break objectreservation counts in VulkanSC 2023-07-28 syoussefi@google.com Fix fence status check in VK_EXT_swapchain_maintenance1 test 2023-07-28 jbolz@nvidia.com Fix extended_dynamic_state tests to run in VulkanSC 2023-07-28 jbolz@nvidia.com Fix shaderexecutor and subgroup supported stage checks 2023-07-28 rgarcia@igalia.com Test PGQ with the availability bit 2023-07-28 rgarcia@igalia.com Check Vulkan version before getting device function pointers 2023-07-28 rgarcia@igalia.com Test dynamic depth clamp and static depth clip 2023-07-28 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2023-07-28 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-07-21 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2023-07-21 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2023-07-21 ziga@lunarg.com Add dynamic state stencil op tests with multiple pipelines 2023-07-21 rgarcia@igalia.com Check acceleration structure creation does not touch buffers 2023-07-21 rgarcia@igalia.com Test VkDescriptorSetVariableDescriptorCountLayoutSupport 2023-07-21 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-07-20 aitor@lunarg.com Advance glslang to fix link error for ndk26 2023-07-14 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-07-14 rgarcia@igalia.com Test strides smaller than vertex attribute sizes 2023-07-14 rgarcia@igalia.com Test RGBA expansion in vertex inputs 2023-07-14 rgarcia@igalia.com Vertex input attribute offset tests 2023-07-14 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-07-14 javed@igalia.com Add tests for 128b multisample color attachments 2023-07-14 rgarcia@igalia.com Test queries with multiview and availability bit 2023-07-14 dneto@google.com Test round-to-zero behaviour of OpConvertFToU 2023-07-14 dneto@google.com Test round-to-zero behaviour of OpConvertFToS 2023-07-10 slawomir.cygan@intel.com Fix checking support in cooperative matrix test 2023-07-07 rgarcia@igalia.com Test sample shading with dynamic sample counts 2023-07-07 ziga@lunarg.com Add more primitives generated query tests 2023-07-07 ewerness@nvidia.com Add testing for VK_KHR_ray_tracing_position_fetch 2023-07-07 aitor@lunarg.com Add required defines for Android builds with SDK33+ 2023-07-07 piotr.byszewski@mobica.com Test pipeline statistics when blitting 2023-07-07 mohd.faisal@arm.com Fix validation errors in ext_shader_tile_image CTS 2023-07-07 michal.jakubek@mobica.com Removal of copying protected image to host visible buffer 2023-07-07 rgarcia@igalia.com More dynamic rasterization sample count tests 2023-07-07 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-07-05 ziga@lunarg.com Update vulkan-docs to current version 2023-07-04 slawomir.cygan@intel.com Build fix for MSVC C++ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ib62a4c52e37902c8f605068f6ca1a786ae58bc49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4732743 Reviewed-by: Solti Ho <solti@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Brian Ho 19671376 2023-07-28T13:37:38 Reland "Search for system libvulkan on CrOS" Currently, ANGLE searches in the "module" directory for libvulkan during init on CrOS. The library doesn't exist at this location (/opt/google/chrome/libvulkan.so), and we should instead just call dlopen(libvulkan.so) to search the system library paths. The original CL was reverted because it broke MSAN builds of ChromeOS-on-Linux (CrOS UI that runs on a generic Linux machine). The original CL caused these builds to use the Linux system Vulkan loader library which is most likely not built with MSAN. This caused MSAN violations when combined with an ANGLE built with MSAN [1]. The reland fixes this issue by only using the system libvulkan on real ChromeOS devices. [1] go/msan#false-positives Bug: b/292249282, chromium:1467779 Change-Id: Iafcd8d315a0baddcfbb847c3ad198f267887c8f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4727448 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
Kenneth Russell d2236b58 2023-07-29T23:50:05 Support substituting translated shaders. Add dumpTranslatedShaders and enableTranslatedShaderSubstitution frontend ANGLE features, which allow ANGLE developers to prototype optimizations and other transforms without fully implementing them in the shader translator. Tested on macOS with ANGLE's Metal backend, but should work with the other source-level translator backends. Add documentation for pre-existing substitution of shader sources, and of translated shaders added in this CL. Fixed: angleproject:8280 Change-Id: I24d5ef88a479b23e81cc8169fe813c263acfc71f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4731553 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Lei Zhang 704469ca 2023-07-31T10:24:59 Remove unused BrokenClampThatShouldNotBeUsed() It has no references. Bug: chromium:1231569,chromium:1373621 Change-Id: Id1477100ed9ec4df28f7d28b09c9e04c1a49125c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4734693 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Lei Zhang <thestig@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Kenneth Russell 28a23231 2023-07-28T13:32:28 Metal: document how to print MSL shaders. I consistently forget how to do this, so writing it down for myself and others. Bug: chromium:1423136 Bug: angleproject:8280 Change-Id: Ibe328f2c154380b49b7d70d810b90fc15a373cb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4727744 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org>
Mark Lobodzinski 0d886b62 2023-07-14T11:24:53 Check that MRTSS bit is supported by format Bit was added without checking ImageFormatProperties causing failures in some end2end tests. Bug: angleproject:8262 Test: Texture2DTestES3.TexStorage2D*/ES3_Vulkan* Change-Id: I7f9a4ee7c14610ee239ab1f86e4ba2c649ce76b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684549 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Brian Ho b8ddba2a 2023-07-28T14:30:53 Use DisplayVkSimple on ChromeOS Currently, we always use DisplayVkHeadless on ChromeOS which can fail if the drivers do not support VK_EXT_headless_surface (e.g. Intel). This CL changes the default to use DisplayVkSimple which requires VK_KHR_display which is better supported. At the end of the day, CrOS never really uses Vulkan WSI, so the actual WSI extension used doesn't matter. Bug: b/292249282 Change-Id: I0f8cfafa635405850cda97c84ad45d3f6aec5103 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4727450 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
Geoff Lang 7f6e5354 2023-07-31T13:02:35 Vulkan: Skip vertex conversion if the draw has 0 vertices. If the draw call start vertex is beyond the end of the buffer, vertex conversion will no-op and no conversion buffer is created. Just skip the entire conversion process in this case and bind the empty buffer. Fix GetVertexCount not taking 0 stride into account. Bug: chromium:1464690 Change-Id: Iaffcd329595c3319fe9cd5317aef2402f9db6b1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4734811 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov faca95f7 2023-07-27T21:28:08 Fix memory leak destroying never current Context Regression from the very old CL: Fix gl::Context::unMakeCurrent crashes https://chromium-review.googlesource.com/c/angle/angle/+/3017210 Memory leak may happen when releasing invalid Contexts in `destroyInvalidEglObjects()`. Bug: chromium:1171371 Change-Id: I282baa92cf3ce7faf1b4239c7ed4b85bd52543a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4732893 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
angle-autoroll 2755f73a 2023-07-28T16:48:00 Manual roll vulkan-deps from 6f1c3384ecb6 to ed9dadbd89cd (23 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/6f1c3384ecb6..ed9dadbd89cd Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/4aa56496d6..4420f9b33b * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/b43c1a1e63..bccaa94db8 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ec90d2872a..c6d0b04802 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/220a00bf95..fc8116bb5c * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ed6820d508..ab9d7a042d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e5f54cc2ea..907292fe35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ib116f06c547e5036bf1e06e4c0195ace3b9e3f6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4730039 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll fb37e054 2023-07-31T07:55:51 Roll Chromium from be53e6b6e597 to 1cd9335ae38e (654 revisions) https://chromium.googlesource.com/chromium/src.git/+log/be53e6b6e597..1cd9335ae38e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7cb37ad9c1..300fe30c80 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fae769bddf * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4e005d51f0..8424103c4e * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/031cdd075f..526382e41c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/12a3758d0c..236e66ffd6 * tools/luci-go: git_revision:a1060b42fa0de9c0d4f1880258b1ad0472155277..git_revision:e608c1f557fceae8eb6cf35ae2ad6f4908e35245 * tools/luci-go: git_revision:a1060b42fa0de9c0d4f1880258b1ad0472155277..git_revision:e608c1f557fceae8eb6cf35ae2ad6f4908e35245 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a38186e7c6..19f0f9d6bf No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I24503bce61ba90b127bfd66bbb424fc3d6f6e447 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4732491 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 143fa68f 2023-07-27T00:00:00 Disallow read type conversions for signed 16-bit color buffers Signed 16-bit color buffers should not be converted to unsigned or 8-bit pixel types during readPixels operations. Bug: angleproject:8048 Change-Id: I27eaeb3d543732b5079bd53ef4fad1711ce3c3ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4727392 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 0abd6f54 2023-07-27T10:48:38 Vulkan: Enable dynamic state on working Android drivers Fixes are flowing out in different channels and versions, so add a bit of Pixel specific logic. Test: angle_trace_tests, deqp Bug: b/287318431, b/285196249, b/286224923, b/285124778 Change-Id: Ifc73e2a42d1d060a83a2fb83bcf8bb999f0990b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4726502 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 35605ca7 2023-07-28T14:01:32 VVL VUID-VkDescriptorImageInfo-imageView update https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+/b6c0e88b9fab7e9a93f8c5391ebb26de38d9b9bc the case that we hit as VUID-VkDescriptorImageInfo-imageView-06711 is now VUID-VkDescriptorImageInfo-descriptorType-06713 Bug: angleproject:7865 Change-Id: Ib2981b49890491719df5b474aad2a7b4e597793a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4727624 Commit-Queue: Solti Ho <solti@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Solti Ho <solti@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
Alan Zhao 391bfa35 2023-07-27T16:43:09 Fix a missing symbol issue with CaptureReplayTests The constructor for PlatformMethods is declared with __declspec(dllimport) when included in CaptureReplayTests.cpp, Ordinarily, this would fail to link on Windows because this test doesn't link against a library that has an exported definition. This test currently builds on Windows because Clang generates an available_externally definition in the object file for CaptureReplayTests.cpp for inlining. However, this doesn't build if inlining is disabled, and will no longer build once an upcoming Clang change is rolled in. To fix this, we add the config libANGLE_config to the test to change the symbol declaration to __declspec(dllexport), which appears to be what other ANGLE tests do. Bug: chromium:1468150 Change-Id: Ia92dde31ab624bbfe64d2e81fad18956abebc41b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4728461 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov c319f34c 2023-07-28T12:30:18 Add VUID-vkCmdDraw-None VUID-vkCmdDrawIndexed-None VUIDs 08753 is now renamed to 09003 https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/6215 as it's being split into multiple cases Bug: angleproject:8242 Change-Id: I64aa75736fdb6ca9664da39f642e64f9f674b696 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4727623 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
angle-autoroll 99f1178a 2023-07-28T07:00:09 Roll Chromium from 1d3454a69e91 to be53e6b6e597 (257 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1d3454a69e91..be53e6b6e597 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/bf0b71be5b..7cb37ad9c1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fae769bddf * third_party/fuchsia-sdk/sdk: version:13.20230714.0.1..version:14.20230727.2.1 * third_party/r8: j866pGqnqFZXTZR0_vWJw2l1LxO2IXjZVwihbQd3jMkC..QJNQAx1B3aL7NHHWyWAOLYCzEWfggtFhljm4b2wNk0wC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/1f457ec480..031cdd075f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7095bf4005..2c5f3235ed No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I7bb62acc74d0696d0d36b366452fe44e09ff0038 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4728185 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Steven Noonan 613eefa3 2023-06-23T03:28:14 D3D11: fix invalidation of depth/stencil attachments This caused a crash when invalidating the depth/stencil attachments of the default framebuffer. But for non-default framebuffers, discarding depth/stencil just did nothing because "rtv.valid()" would be false. Bug: angleproject:8228 Change-Id: Ic22a29f521256af0ed4fc9c203cd6d750fcc00e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4639494 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net>
Roman Lavrov 179924cb 2023-07-27T20:45:26 Revert "Fix ExternalImageTarget EGLImage race" This reverts commit 8aa3ca9d177c0ed54926b769de7d0bce0f8482d3. Reason for revert: Confirmed to break Android's testDrawingHardwareBitmapNotLeaking in this single-commit roll: https://r.android.com/2679397 Original change's description: > Fix ExternalImageTarget EGLImage race > > Race may happen when ExternalImageTarget EGLImage is destroyed while its > GLES Texture/Renderbuffer target is modified/destroyed. > > Fixed by providing `egl::Image` with `egl::ContextMutex` even when > `context` is `nullptr`. > > This CL also changes `SharedContextMutex` merging rules when `mRank` is > equal - now priority goes to the `lockedMutex`. This is done to prevent > unnecessary `mRoot` update of Context mutex when merging with > `egl::Image` only mutex. > > Bug: angleproject:6957 > Change-Id: I823e53b98f70ed3eaca191e8be5b168dc07899f6 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4720835 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Bug: angleproject:6957 Change-Id: I860a8bfd6dd66eb549045391755a83483109ebbb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4727621 Commit-Queue: Roman Lavrov <romanl@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 13842e1c 2023-07-27T19:07:45 Manual roll Chromium from a78d58d81a3c to 1d3454a69e91 (938 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/chromium/src.git/+log/a78d58d81a3c..1d3454a69e91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools/linux64: git_revision:fae280eabe5d31accc53100137459ece19a7a295..git_revision:3fccef9033b950e8935e8debeba9fbd71617bc74 * buildtools/mac: git_revision:fae280eabe5d31accc53100137459ece19a7a295..git_revision:3fccef9033b950e8935e8debeba9fbd71617bc74 * buildtools/win: git_revision:fae280eabe5d31accc53100137459ece19a7a295..git_revision:3fccef9033b950e8935e8debeba9fbd71617bc74 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b946312a89..bf0b71be5b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9544eb36c9..2288062eef * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/a91b365204..9dc45ac9ce * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fae769bddf * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/54e86436a8..4e005d51f0 * third_party/r8: O1BBWiBTIeNUcraX8STMtQXVaCleu6SJJjWCcnfhPLkC..j866pGqnqFZXTZR0_vWJw2l1LxO2IXjZVwihbQd3jMkC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/75c09362db..1f457ec480 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9e679731de..12a3758d0c * tools/luci-go: git_revision:f02582af78f530a7bbfe2f059fa5d211c9517756..git_revision:a1060b42fa0de9c0d4f1880258b1ad0472155277 * tools/luci-go: git_revision:f02582af78f530a7bbfe2f059fa5d211c9517756..git_revision:a1060b42fa0de9c0d4f1880258b1ad0472155277 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4b377433d0..a38186e7c6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e392c02236..7095bf4005 No update to Clang. Bug: angleproject:5509,angleproject:8277,angleproject:8278 Tbr: romanl@google.com Change-Id: I78bdbe9e57abd44be6e219d42737fc3a0f586975 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4724521 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 5446e87e 2023-07-24T16:46:56 Improve ProgramExecutable::load performance We are calling push_back for each vector inside ProgramExecutable. This causes c++ run time to constantly re-allocate storage and copy the vector over to new storage, and impacts performance negatively. Since the vector size is know when we load program from cache, this CL calls resize to the correct size first and then update each element as we walk over, thus reduces the vector storage reallocation. This CL reduces blade_and_soul_revolution frame time from 4.48 ms to 4.35 ms on pixel 7 pro. This CL also changes ProgramBinaryTest tests to use slightly more complicated program instead of the simplest program. Bug: b/275102061 Change-Id: I8d92117b07a9ad2d0851850e473ea1b86f9868f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4713685 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov d5ddb710 2023-07-27T15:27:52 Suppress 2 end2end tests on iOS Metal GLSLTest_ES3.LiteralInfinityOutput/ES3_Metal GLSLTest_ES3.LiteralNegativeInfinityOutput/ES3_Metal Started failing when testing was switched to iPhone 14 iOS 17.0 Bug: angleproject:8278 Change-Id: Ieca08edd02ea4350fc8362cf98d43d8ab4f0adb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4725466 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Igor Nazarov 8aa3ca9d 2023-07-26T19:55:56 Fix ExternalImageTarget EGLImage race Race may happen when ExternalImageTarget EGLImage is destroyed while its GLES Texture/Renderbuffer target is modified/destroyed. Fixed by providing `egl::Image` with `egl::ContextMutex` even when `context` is `nullptr`. This CL also changes `SharedContextMutex` merging rules when `mRank` is equal - now priority goes to the `lockedMutex`. This is done to prevent unnecessary `mRoot` update of Context mutex when merging with `egl::Image` only mutex. Bug: angleproject:6957 Change-Id: I823e53b98f70ed3eaca191e8be5b168dc07899f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4720835 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Brian Ho af5bf5b8 2023-07-26T19:59:01 Revert "Search for system libvulkan on CrOS" This reverts commit b0b71d59391c99e70b40d7f331f530e6ea1970e5. Reason for revert: Broke MSAN build on ChromeOS-for-Linux Original change's description: > Search for system libvulkan on CrOS > > Currently, ANGLE searches in the "module" directory for libvulkan > during init on CrOS. The library doesn't exist at this location > (/opt/google/chrome/libvulkan.so), and we should instead just call > dlopen(libvulkan.so) to search the system library paths. > > Bug: b/292249282 > Change-Id: I7ab4803fe294e69f0ab8533ebc2fa43e25f189eb > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4716242 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Brian Ho <hob@chromium.org> Bug: chromium:1467779 Change-Id: Ib3095b51559660ac438ba9af4327b08d334d19b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4722705 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Brian Ho <hob@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Mohan Maiya 451b3c31 2023-07-26T10:45:36 Account for overridden features in ANGLEPlatformDisplay key Overridden features were not included in ANGLEPlatformDisplay key causing false cache hits when querying for displays with different feature override requirements. On platforms that reuse displays across end2end test runs it resulted in the tests using the wrong display. Bug: angleproject:8275 Change-Id: Id67f3cefb821d4d0be5945f66e34f366d0768346 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4720468 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 58cb5c83 2023-07-26T07:00:33 Roll Chromium from 0143d0520f3f to a78d58d81a3c (602 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0143d0520f3f..a78d58d81a3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/184b068a94..b946312a89 * third_party/android_build_tools/manifest_merger: UwtCH6usmvLSrqbzGSTrjqJ1AJnNh-Vkq4hCEKvDM5oC..8fr-1Vf_pfxN9ulzWVaZvIXggDgWDs-0dtlGA1Sue48C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f588938604..a91b365204 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..84e3795d98 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d3e43dd431..54e86436a8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1b748bc9cb..4b377433d0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ac82fc7dd9..e392c02236 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Ie5eb2c2fb0ef1c963d98533fdc9397a4cd99ecad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4719475 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu a0977311 2023-07-25T12:18:30 Disable the usage of VK_EXT_legacy_dithering Disable the usage of extension VK_EXT_legacy_dithering on ARM until the bugs in this extension is addressed. Bug: b/293136916 Bug: b/292282210 Change-Id: I1a548a2f6c44a78f8c66f706588a9985326217cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4718306 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Kaiyi Li <kaiyili@google.com>
Geoff Lang 84f5295c 2023-07-25T14:24:51 Metal: Flush with NoWait when hitting renderpass count limits This flush was added as an optimization to handle a specific use case where many expensive GPU operations (clears and uploads) were queued without being flushed. The GPU would be idle during these periods. WaitUntilScheduled forced CPU/GPU synchronization when it was not needed. We just want to make sure the work is flushed so the GPU can pick it up later, not synchronize with anything external. WaitUntilScheduled is used on iOS still because the Chrome waterfall does not have coverage of iOS performance. Bug: chromium:1466696 Change-Id: Ia8938eddf5be5ce586a91ad759d1563182176dba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4717367 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Hailin zhang 4cae3b09 2023-06-02T23:52:15 Vulkan: disable pipline cache serialization In old NV drivers, Vulkan pipeline cache will only generate one single huge cache for one process shared by all graphics piplines in the same process, which can be huge. This is temp solution for nvidia driver cache issue. after driver version 520. nvidia fix the cache issue. this might affect second running performance. Bug: b/258207403 Change-Id: I3ea3e9196ad18fb1cec16c931eb744300d6cfdb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4713207 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Geoff Lang 05707391 2023-07-25T14:29:26 Metal: Re-add flush to eglBindTexImage but as NoWait Removing the flush entirely caused performance regressions on a couple of benchmarks because the GPU became idle waiting for work. Re-add the flush but with NoWait so there is no CPU/GPU sychronization. Bug: chromium:1466696, chromium:1467392 Change-Id: I5e2d1ca7b7a4590e3e668d2cd214d09d28c4b085 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4718007 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Brian Ho b0b71d59 2023-07-25T12:53:49 Search for system libvulkan on CrOS Currently, ANGLE searches in the "module" directory for libvulkan during init on CrOS. The library doesn't exist at this location (/opt/google/chrome/libvulkan.so), and we should instead just call dlopen(libvulkan.so) to search the system library paths. Bug: b/292249282 Change-Id: I7ab4803fe294e69f0ab8533ebc2fa43e25f189eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4716242 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
Shahbaz Youssefi 7ea61cb3 2023-07-23T21:53:50 GL: Complete EGL_ANGLE_external_context_and_surface This change implements two new entry points added for EGL_ANGLE_external_context_and_surface: glAcquireExternalContextANGLE and glReleaseExternalContextANGLE. These functions remove the need to overload eglMakeCurrent for the purposes of syncing to and from the external context. Bug: angleproject:5509 Change-Id: I5d46299ee0c8addaef7066914a8a8aacb0ea2c17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706027 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 2d5fb09d 2023-07-22T22:34:20 Stubs for EGL_ANGLE_external_context_and_surface Bug: angleproject:5509 Change-Id: I8e2395784abcd2b4e3e1f888e70a879ef49287bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706026 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang 19dbaf11 2023-07-24T17:38:46 Mention the SwiftShader -> Chromium autoroller for Wranglers The ANGLE team should make sure that the SwiftShader -> Chromium autoroller stays green. If it gets too far out of sync, ANGLE's testing within the ANGLE waterfall and Chromium waterfall will diverge. Keeping this roller green is also critical for security issues fixes to propogate to Chrome. Bug: None Change-Id: I650d906bbbd8c522b85082965f128a1bf071ae78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4711827 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Joanna Wang 7ae6458b 2023-07-21T20:56:58 Temporarily remove repos involved in llvm builds. Add these deps back once the change in chromium/src is merged: https://chromium-review.googlesource.com/c/chromium/src/+/4666325 Bug: chromium:1458042 Change-Id: I63b5b80e5a5a594ce61e9b72eaffb3a87d6719c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706819 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll e8c8c565 2023-07-25T10:01:58 Roll SwiftShader from 66d6b0dd0c39 to 9fbca2df22a8 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/66d6b0dd0c39..9fbca2df22a8 2023-07-24 bclayton@google.com LLVMReactor: Support LLVM 17+ 2023-07-24 bclayton@google.com LLVMReactor: Remove CreateFreeze() call If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I7f76a349321e23f85f8bd72eb4903163c1cb8bb4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4713596 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0b41e4ed 2023-07-25T10:01:20 Roll vulkan-deps from 7db08a9e0a29 to 6f1c3384ecb6 (24 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7db08a9e0a29..6f1c3384ecb6 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/65397339c5..4aa56496d6 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/14914db17a..51b1064617 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/17d9669d51..ec90d2872a * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/6eee20744f..cb7b123f2d * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/fdae336d4f..220a00bf95 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c5ac1413f0..ed6820d508 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/34a5dd9aec..e5f54cc2ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ia8e2491d99cd90b6e68e0b8e62fdde0d55c7e6ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4713573 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1b17c91e 2023-07-25T07:02:25 Roll Chromium from 6eba95b5d89b to 0143d0520f3f (584 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6eba95b5d89b..0143d0520f3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7fb08159d8..860dae780c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7a04c5b9df..184b068a94 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/9ce3e620bd..f588938604 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fa05d995e1 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d411904b84..d3e43dd431 * third_party/r8: Sz7S7AlqFPYB_t29P5b6i5K80Wq00mpvN2y8aNUAqo0C..O1BBWiBTIeNUcraX8STMtQXVaCleu6SJJjWCcnfhPLkC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f819d02e6f..1b748bc9cb * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/9a047fd494..2a4c4ba1f4 * tools/skia_goldctl/linux: Q5cqdj5BQE3eWNCe2CqhLT13X-o0w1ta7V2XnmXIrnEC..yiBOCk-vzyyWi8kF1hfi8_yZoQb5Y5nUrgH-gKy3s_4C * tools/skia_goldctl/mac_amd64: YieDEr0s0SH8j_1Os9w89pblPmGHE2vvLJtvdTYamfAC..IOfj5k7LF0hVZeJ-_iTpGovRg26fblRBMk0wLT1GJnAC * tools/skia_goldctl/mac_arm64: isJD0ZhCCqmn1h8q6_12lvDCcKt_M-8v548oOoQwpN4C..nAEU10uINeZnsOib3LZlcLZgRr3I8YETFJqTpMpw3ukC * tools/skia_goldctl/win: OzmCj3mfsBuDD-gOktZNf1BcL8eg8Ewi8ekcYDI4tsAC..pGeqtL9kCYQirdV-A7YpDFltq8_TFh64j6MuVoc7YswC No update to Clang. Bug: angleproject:7904 Tbr: romanl@google.com Change-Id: I4e89898b8961c7be2a3d85f97101270ddf5efab2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4713571 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 2d999f74 2023-07-24T11:53:02 Android: Add a way to prepare traces without running tests Example: % out/Android/angle_trace_tests --gtest_filter='*gacha_life' --prepare-only ... Prepared traces: {'gacha_life'} Can be used as a setup for running restricted_trace_perf.py Bug: b/292249127 Change-Id: I901c086a19e1d182c64ec4150ced98c198e21c4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4711826 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Igor Nazarov 5e21d7f0 2023-07-14T14:39:04 Vulkan: Remove dead code Dead code remained after this CL: https://chromium-review.googlesource.com/c/angle/angle/+/3998747 Vulkan: Remove unused ShaderAndSerial Bug: b/257116399 Change-Id: Ica3b941fa98886dff309b5eb1734a1718fa8f6fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4711585 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 5a065592 2023-07-20T17:42:02 Metal: Don't flush on eglBindTexImage. There is nothing that needs synchronization at this point. About 30% of ANGLE's CPU time is spent here. Bug: chromium:1466696 Change-Id: I4993804823790ee9cc38530dea334a6fa3abe7f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706926 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Gregg Tavares <gman@chromium.org>
Roman Lavrov e1a34cbf 2023-07-24T09:51:45 Android.bp generation: vulkan-headers LICENSE.txt -> .md Bug: angleproject:8271 Change-Id: I7e31ce26afcf8da22f6aa8518433bb131be4e74b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4711825 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll a6c751f6 2023-07-24T10:01:00 Roll SwiftShader from 4a260c12b8c1 to 66d6b0dd0c39 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/4a260c12b8c1..66d6b0dd0c39 2023-07-23 bclayton@google.com LLVMReactor: Clamp RHS of bit shifts using type width 2023-07-22 bclayton@google.com Fix another 'sign-compare' warning as error 2023-07-22 bclayton@google.com Fix 'sign-compare' warning as error 2023-07-21 bclayton@google.com LLVMReactor: Clamp RHS of bit shifts. 2023-07-21 swiftshader.regress@gmail.com Regres: Update test lists @ 4a260c12 2023-07-21 bclayton@google.com ExecutableMemory: Use VirtualAlloc() instead of `new` on windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I20955bd6b2b74e9a6696848623e010680905cdb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4709812 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e28575f6 2023-07-24T08:00:27 Roll Chromium from 986ed21b8935 to 6eba95b5d89b (527 revisions) https://chromium.googlesource.com/chromium/src.git/+log/986ed21b8935..6eba95b5d89b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/76d3034c73..7fb08159d8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1f5c4581ad..7a04c5b9df * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b119dc414e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/82e4859614..d411904b84 * third_party/fuchsia-sdk/sdk: version:13.20230721.1.1..version:13.20230714.0.1 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d3b3d64f7d..75c09362db * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0a7e1f1b7a..f819d02e6f No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I02990ac903582a30943da0f32f44be4c7f274afc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706095 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 430a4f55 2023-07-21T13:45:52 Fix read size validation for RGBX formats. GL_RGBX8_ANGLE is the only format where the upload format is 3-channel RGB, whilethe download format is 4-channel RGBX. As such, the internal format corresponding to format+type expects 3-byte input/output. The format is fixed here for readPixels to output 4 bytes per pixel. Bug: chromium:1458046 Change-Id: Iec737ed64bade003cfab50dc5f595eb4875e81e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706957 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 938ee1e8 2023-07-21T16:16:23 Vulkan: legacy_dithering disallow reactivate when breaking RP Hitting the assert in dEQP GLES2.functional.fragment_ops.random.0: https://crsrc.org/c/third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp;drc=52fe3116ead9a5de51ddad17fcb14bf8ecb3a69d;l=2347 Bug: b/292259684 Change-Id: Ib40b90dde3b271c714b6181e4ba4d70f3e1b5e86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706174 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Geoff Lang f586ec98 2023-07-20T17:24:09 Metal: Validate max render target size without an allocation We would allocate a MTLRenderPassDescriptor for validating an internal error case only to throw it away immediately afterwards. This happened on every new render pass. This allocation/release amounts to about 10% of ANGLE's CPU time when running Chrome. Bug: chromium:1466696 Change-Id: I0bbe086c0b8006d2ff15ae57f25b591f791acb60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706925 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 085f25bb 2023-07-20T15:24:56 GL: Protect against drivers returning 0 max clip distances. Some Android devices in the wild were hitting the assert that maxClipDistances must be greater than 0 if ANGLE_clip_cull_distance is exposed. Protect against this by disabling various clip/cull extensions if they don't meet the requirements for number of distances. Bug: angleproject:7904 Change-Id: Ic6a5e959437fa7aad5302a12cf8c92d1d18024b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706684 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 82d68c57 2023-07-21T17:14:19 Manual roll Chromium from e3bcada48f45 to 986ed21b8935 (1346 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/e3bcada48f45..986ed21b8935 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/00557a04e4..76d3034c73 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/1cc82962cb..ca163845c7 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/f1c687e0aa..6c0013015b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/454f446791..1f5c4581ad * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f317d51223..9544eb36c9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a02c178207 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/60b21dd193..82e4859614 * third_party/fuchsia-sdk/sdk: version:13.20230714.0.1..version:13.20230721.1.1 * third_party/jdk: 9-e8GxXJduErc9j3s5VUmbAWTorSHxvcn23GNjYtCNwC..IivIDwNBf73mf7UwCOBceRUuDdtizMCgSOQDfUGHArsC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/61dc0bd13f..d3b3d64f7d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b559f90fa3..0a7e1f1b7a No update to Clang. Bug: None Tbr: abdolrashidi@google.com,ynovikov@google.com Change-Id: If602e6f8163e7dd81420ebd20fc1677b68b539f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4707721 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 2e190280 2023-07-20T14:12:03 GL: Extend disable of EXT_clip_control to Mali-G51. The G51 appears to be the only other device with this issue. Bug: chromium:1434317 Change-Id: Iffbc95a7f612c1862e9d129649a6211f488df6c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706564 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org>
angle-autoroll e1887773 2023-07-21T10:01:23 Roll vulkan-deps from e1c3b16d5aa5 to 7db08a9e0a29 (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e1c3b16d5aa5..7db08a9e0a29 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/77417d5c9e..65397339c5 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/883417544b..17d9669d51 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3c3d04d219..34a5dd9aec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I661522c96e889ce5ab93f56e3e5d68170da571e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706476 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b6006800 2023-07-21T10:01:14 Roll SwiftShader from 4e401427f8dd to 4a260c12b8c1 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/4e401427f8dd..4a260c12b8c1 2023-07-20 avi@google.com Don't allow Swiftshader to be compiled as ARC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I4c41c19fb0354a67c3258f0bbb44fa8b2685bfc0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4707174 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Avi Drissman f2e0f8a0 2023-07-14T13:31:06 Don't allow ANGLE to be compiled as ARC Chromium is switching to compilation with ARC. While there are remnants of ARC dual-compilation, ANGLE isn't ready for that, so don't allow it to be compiled with ARC. Bug: chromium:733237, angleproject:8267 Change-Id: If5c8d5ab039fb44e10102df616e72dbcfd55ac70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4698494 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jason Macnak 8138ae9b 2023-07-07T14:16:07 Vulkan: EGL's DISPLAY_P3_PASSTHROUGH -> VK's DISPLAY_P3_NONLINEAR From https://registry.khronos.org/EGL/extensions/EXT/EGL_EXT_gl_colorspace_display_p3_passthrough.txt If its value is EGL_GL_COLORSPACE_DISPLAY_P3_PASSTHROUGH_EXT, then a non-linear, sRGB encoded Display-P3 color space is assumed Bug: b/289125521 Test: cvd start Test: cts -m CtsViewTestCases -t android.view.cts.TextureViewTest#testGetBitmap_8888_PassthroughP3 Change-Id: I07c77c86bbc0d82923ad7435cd2a5558770cd2e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4673910 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Chris Forbes <chrisforbes@google.com> Commit-Queue: Jason Macnak <natsu@google.com>
angle-autoroll a4c283be 2023-07-20T10:01:30 Roll vulkan-deps from 7f74d379edd8 to e1c3b16d5aa5 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7f74d379edd8..e1c3b16d5aa5 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/9b1a0f4d3e..77417d5c9e * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/66e5000344..14914db17a * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6c7e1acc5f..883417544b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/971615e6d8..3c3d04d219 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I1ce7bea364a94bc9e522ecafa25014ef24494b0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4704406 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5e38a31b 2023-07-19T21:37:27 Manual roll vulkan-deps from 831910dbe1f3 to 7f74d379edd8 (38 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/831910dbe1f3..7f74d379edd8 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/f47028995c..9b1a0f4d3e * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/f1ba373ef0..66e5000344 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/29431859f5..6c7e1acc5f * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/bc14fdad60..6eee20744f * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/6837a92c34..fdae336d4f * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/6e7fa4d975..c5ac1413f0 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/32a2af3fd6..971615e6d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: If341ed03d859dc8abaeb9caa3f8d1dcb56cfae2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4703106 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 4515b270 2023-07-18T14:39:42 Account for implementations that support large gl_PointSize values The PointSizeAboveMaxIsClamped end2end test intends to render a point with gl_PointSize that is 2x the implementation's max value to test if this value is clamped correctly. However, when the max gl_PointSize is large enough, like with AMD drivers, it results in the center of the point being outside of the viewport which according to the spec can be discarded. Update the test to render to a framebuffer, instead of the default window surface, one large enough to contain a point of implementation defined max point size. Bug: angleproject:2113 Test: PointSpritesTest.PointSizeAboveMaxIsClamped* Change-Id: I724440495bf5a3c93c76cc28109937a56c45f274 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4697681 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Phan Quang Minh ef4327f6 2023-07-12T09:12:03 Vulkan: Make UtilsVk::copyImage copy YCbCr images properly This changes the descriptor binding for the image from VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE to VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER for YCbCr source textures and ensures that the copy pipelines and descriptor sets for YCbCr source textures are created with the appropriate YCbCr samplers, and use the `texture()` function instead of `texelFetch()` for YCbCr images. Bug: angleproject:8252 Change-Id: Ife3e230d3669b275f4e0fab1922d75b6b6c4f8bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675806 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 4dcaad2a 2023-07-19T10:01:53 Roll SwiftShader from 151fa797ee3e to 4e401427f8dd (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/151fa797ee3e..4e401427f8dd 2023-07-18 tiszka@chromium.org [subzero] Fix integer overflows during alloca coalescing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I47f72bcc6cdeb1901ea16e7f2039c04a6d2f1fdb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4700723 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 255dec88 2023-07-19T07:01:18 Roll Chromium from 8806dade91f0 to e3bcada48f45 (580 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8806dade91f0..e3bcada48f45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ed8697168d..00557a04e4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a2c493455a..454f446791 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ae5ee2a38f..f317d51223 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/e197e4c396..02f9cdf1a9 * third_party/android_build_tools/lint: OPMAEfzTB1WPytaO0pMOPg9GHVByubIOUvOsCwKS1oQC..cLtgSrpk1a4zUb-XNIAaxmKn2OAZ-fnG9kZBqI3n9XEC * third_party/android_build_tools/manifest_merger: kxzD7gkXhEJiL_u2jVkpX0Npl2MLoSvbnBezhq29dAgC..UwtCH6usmvLSrqbzGSTrjqJ1AJnNh-Vkq4hCEKvDM5oC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..707e9093f7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/94f76acc94..60b21dd193 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/aa4075f116..30bdb85e30 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f1f08a05ad..43f8a41f8f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a7a6e86ea5..9e679731de * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a8b8553345..b559f90fa3 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Iad1a7d705668ce848aa8442e89cc3d73d983b894 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4699572 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b32d6613 2023-07-18T21:12:32 Manual roll vulkan-deps from aa35b58fce7d to 831910dbe1f3 (8 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/aa35b58fce7d..831910dbe1f3 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/b8e742c91b..b43c1a1e63 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/2565ffa31e..bc14fdad60 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/80679543ad..32a2af3fd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I5e24d509cf13b3a110f84ffeecc228ac7e83ba54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4697917 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Hailin Zhang 6eea5ff4 2023-07-18T12:52:37 Vulkan: fix default MSAA framebuffer clear issue. Bug: b/290813597 Change-Id: I134c5a99382ca30dbd885a17dfa3c7ac227480ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4698113 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Hailin Zhang <hailinzhang@google.com>
Shahbaz Youssefi 52fe3116 2023-07-17T16:20:54 Vulkan: Deduplicate share group's context set tracking Bug: angleproject:8224 Change-Id: I7a59a37229682fb91ff777f31e02e05d7ab2b80f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4690345 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Phan Quang Minh 5eb30562 2023-07-17T07:23:03 Reland "Vulkan: Remove platform restriction of EGL_ANDROID_native_fence_sync" Instead of enabling it on all non-Mac platforms, this time enable it only on Linux-kernel based platforms (Linux, ChromeOS, Android). This should avoid interfering with Fuchsia. Original change description: > Remove platform restriction of EGL_ANDROID_native_fence_sync > extension except for Mac OS. > > Bug: angleproject:7834 > Change-Id: I116f44d8baca9cdcdd90013ca173b04461d06ae1 > Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4027707 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: mohan maiya <m.maiya@samsung.com> > Commit-Queue: mohan maiya <m.maiya@samsung.com> Bug: angleproject:7834 Change-Id: Ida89100e8c30c3a2df5a0a8d6d0c9b7e7ce3e412 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4687427 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 85095480 2023-07-17T12:31:48 Android: Update script with sync progress When running lots of traces, there can be a long pause when syncing traces to the device. Add a small update so it is clear that work is happening. Example output: I12:21:51.806619Z Syncing 1945_air_force trace (1/238) I12:21:52.178401Z Syncing 20_minutes_till_dawn trace (2/238) I12:21:52.463608Z Syncing 2_3_4_player_mini_games trace (3/238) ... Test: angle_trace_tests Bug: b/276742336 Change-Id: Id81d69b3fc678cb94c2e683a907c44950ead2117 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4690745 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Saifuddin Hitawala a64537f9 2023-07-14T17:06:37 Angle: Copy multiplanar d3d11 texture for readPixels This change performs a copy to an intermediate texture for multiplanar d3d11 textures before reading from the source texture. This is needed as we cannot read a plane directly from a multiplanar d3d11 texture. It also passes the correct format for the plane for multiplanar formats when initializing the texture instead of getting the format using the internal format. We also add a unittest performing glReadPixels for NV12/P010/P016 formats. Bug: angleproject:7998, chromium:1463924 Change-Id: I9a1708f5a846ace28ac3b6593ea80f1863348333 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4688118 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Saifuddin Hitawala <hitawala@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll fe541ddb 2023-07-18T08:09:33 Roll Chromium from 48a8f73f303f to 8806dade91f0 (572 revisions) https://chromium.googlesource.com/chromium/src.git/+log/48a8f73f303f..8806dade91f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a158d61f27..ed8697168d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d6ce172e32..d4760c0af9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b98bc2989c..a2c493455a * third_party/android_build_tools/bundletool: LbB0aRQ3VKjRJZmc_PD0VTZ1O34_zD92rh71aOEOEcEC..2PJKytTLILAjCO3G7sCO27FO48XB9qrRTHp420zr5G0C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7a8318124d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b389d031a2..94f76acc94 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/80da587681..f1f08a05ad * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c05e52187e..a7a6e86ea5 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5ce938841d..a8b8553345 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a2303f1c72..ac82fc7dd9 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I72354d9bc7c667d070a68544dcc17cb9ae9f38dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4693482 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brian Sheedy ec2948c5 2023-07-13T13:38:52 Start Mac Intel 13.4.1 experiment Bug: chromium:1464635 Change-Id: Ie7cf5d68fff54b0b58ca1a4c102ab8c8368bd3ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684014 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 9f9284b7 2023-07-17T15:41:27 Move ShareGroup to its own files Bug: angleproject:8224 Change-Id: Id6d272018bb5ee8c3e35488f641efa4d99fa836d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4690003 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 9aadc7aa 2023-07-13T11:44:51 Metal: Require MSL 2.1. We had previously shipped both MSL 2.0 and 2.1 shaders to support MacOS 10.13 (MSL 2.0 only) while also supporting the stencil blit fast path that MSL 2.1 provides with the has_shader_stencil_output feature. Each configuration of precompiled shaders is ~300kb so we will drop support for MacOS 10.13 and only ship the MSL 2.1 shaders. Rework of the disablement for NVIDIA and GPU family 1 to be more readable. The features themselves are always true because "disable on NVIDIA" is always true and the check for "is NVIDIA" is moved to the code which fails the initialization. Bug: angleproject:8258 Change-Id: Icc8c69540e43fd2b0b237fffbfe170bb3422903f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4681130 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang d40669bb 2023-07-17T11:49:13 Android: Use ALooper_pollOnce instead of ALooper_pollAll ALooper_pollAll can cause potential deadlocks. These calls are only made by our test suites. Bug: chromium:1464077 Change-Id: Id56c0db67e10d6df00c3e6b9126952ffa1d40d48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4690382 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 0518a3ff 2023-07-14T14:53:39 Android: Simplify power metrics collection Also check for missing values and dupes Bug: b/291604008 Change-Id: I909ca2bf53d3aa0bf5ba66f7168e9925cfd7da3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685323 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi bebb83d9 2023-07-14T12:30:15 Translator: Limit variable sizes vs uint overflow Bug: chromium:1464680 Change-Id: I90e204db1ce57c87ed5fe19912e4c157cee18a90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685236 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 05ea1147 2023-07-14T16:49:24 Vulkan: Bugfix in gl_FragData array redeclaration Both OpenGL ES and Vulkan spec allows implementations to limit the number of output attachments when dual-source blending is enabled. Account for this limit when setting gl_FragData array length by re-declaring the gl_FragData array size to match maxFragmentDualSrcAttachments value. Bug: angleproject:5537 Test: EXTBlendFuncExtendedDrawTest.FragData/ES2_Vulkan Change-Id: I5a462344f4c4faf850f56e9c5d4c392370d3d010 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4688396 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi bd8001e5 2023-07-17T11:32:23 Fix deadlock on device loss Some backends generate a device loss (propagated to all contexts) while querying the device status. The latter is held under a lock, and the former would attempt to hold the lock when marking the calling context with device loss. Bug: chromium:1465262 Change-Id: I55fd96f3573732953daf2a305b0120dbcae6ea30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4690063 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov e8e17211 2023-07-17T15:20:14 Retry angle_deqp_gles2_metal_tests Flaky crashes in OSXWindow::messageLoop(), like the other GTest based tests on Mac, which already have retries enabled. Bug: angleproject:6570 Change-Id: I65ffc4b09a6ece68dcfe404055fcfe50d013c000 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685573 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop a04d5443 2023-07-17T09:09:02 Docs: Add a couple of Android pointers Hit some rough edges while setting up a clean install. Bug: angleproject:4347 Change-Id: I241cddac0c86d0eb00195e42304f50e2c7bba5e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4688533 Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov c0f2f71e 2023-06-27T16:00:09 Use VK_EXT_legacy_dithering when available instead of emulation Yields improvement in gpu power: http://b/284462263#comment45 Bug: b/284462263 Change-Id: I5bfd115557b6baac17c05639118feaebf19c5cd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4652590 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuly Novikov d04dda15 2023-07-17T14:29:44 Skip WebGL2CompatibilityTest.DrawWithZeroSizedBuffer on iOS GL Bug: angleproject:8264 Change-Id: Icac83200b8e9aa35ba3e85be8b34bd45e616a8bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685572 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll a18246ac 2023-07-17T07:26:08 Roll Chromium from 68d783529187 to 48a8f73f303f (690 revisions) https://chromium.googlesource.com/chromium/src.git/+log/68d783529187..48a8f73f303f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7565823755..a158d61f27 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2bac855313..b98bc2989c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/6514de5457..9ce3e620bd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..394c179782 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/abbd5858fa..b389d031a2 * third_party/fuchsia-sdk/sdk: version:13.20230711.2.1..version:13.20230714.0.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4786f206b4..c05e52187e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f8f7cb6141..5ce938841d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/86375f9e21..a2303f1c72 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/27e9a92f3b..e10259da24 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I3f305f69842c73569aad368fb3fb7d222c91d231 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4688527 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Dave Tapuska 507f67cc 2023-07-14T15:23:48 Fix cfi issue with Angle invoking worker pool Mark the function as ignoring cfi-icall because of broken upstream builds. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20CFI/25615/overview Bug: angleproject:8256 Change-Id: I63b5fee27bc0565dc6881bd83fd284abc7a9f1f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685324 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Roman Lavrov c5b7fc36 2023-07-14T15:39:25 Ensure settings get cleaned up on exceptions Before this change, Ctrl-C or another exception leaves settings behind Bug: b/284462263 Change-Id: I5694cbb2ca7d43a4173099d126e6695e07ec9d2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685238 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov d6dc46db 2023-07-14T17:51:26 Revert "Add minimal setup for Go codegen in Android.bp." This reverts commit 9f7b6babe1fd7313a6a344d037aed542505d126e. Reason for revert: No longer appears needed as 1) number of diffs was greatly reduced via cc_default 2) build configs got simpler with switching to platform zlib. No recent conflicts introduced by build scripts Original change's description: > Add minimal setup for Go codegen in Android.bp. > > Based on Cody's http://ag/19603310. > > Only adds libEGL_angle_codegen to libEGL_angle and is a no-op. > > Tested in an aosp checkout. Hopefully this doesn't cause merge conflicts > with internal master as all diffs are close to the top of the file. > > Android.bp diff: https://paste.googleplex.com/6626641357832192 > > Bug: b/242929755 > Change-Id: I6d7ac9f3dd502074c41838bd1aa10075a8c99145 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3876890 > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: b/242929755 Change-Id: Id4cbdf68e9704138396ee1bef7a4f1edef3f50cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685320 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 97368229 2023-07-14T17:09:15 Skip dEQP-EGL.functional.native_[color|coord]_mapping.native_window.* Skip on all platforms instead of the individual suppressions, that let test failures to slip into build failures. Bug: angleproject:8261 Change-Id: I16a5eaceb5fe49dc4e23233bfe4fe146b77a95f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685567 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Geoff Lang 972f8107 2023-07-14T12:05:40 Reject program binaries when the renderer string changes If the underlying driver changes, reject program binaries from the old versions. The driver is supposed to do this for us (on OpenGL, at least) but this adds some extra protection. Bug: angleproject:4981 Change-Id: Id9486d8e6f9136970c0d7c37d59dea5d43b0a50e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685317 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang c0cd00e8 2023-07-12T13:51:11 Sync all framebuffer attachments when checking completeness. If the backend requires that a framebuffer is synchronized before checking backend completeness, make sure all attachments are synchronized too. GL has completeness rules based on GL_BASE_LEVEL and GL_MAX_LEVEL of texture attachments which are not syncrhonized until the textures are. If they are left un-sychronized during completeness checks, the driver will tell us that the framebuffer isn't complete. Bug: chromium:1455725 Change-Id: I7c3bf6a38f63feaa863f4d8914c3655e286dd768 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678286 Reviewed-by: Brian Ho <hob@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 5032f08b 2023-07-13T15:23:49 Translator: Unconditionally limit variable sizes ... instead of just for WebGL. This is to avoid hitting driver bugs that were prevented with this check for WebGL on a compromised renderer that can create non-WebGL contexts. Bug: chromium:1464682 Change-Id: I47a9d9690bd1ca9d701391fb7d70932f2dbe7334 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685307 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 35c077b1 2023-07-14T13:22:24 Remove obsolete VUID suppressions 02859 was renamed to 08608 and 06538 was renamed to 08753 in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/6008/commits/0cc78b9c282aa3e97316e739b88641a5d45f9463 Bug: angleproject:8242, angleproject:8119, angleproject:7105 Change-Id: Icde11d7c5b598bfb617d899daa795d3e19c8a178 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4687419 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang cc8ea4c2 2023-07-13T12:41:56 Metal: Call terminate if display initialization fails. This ensures that any resources that were partially initialized are cleaned up. This is a speculative fix for dual GPU macs not falling back to the low power GPU. DisplayMtl leaks the metal device if it fails to initialize due to unsupported GPU families or vendors. Bug: chromium:1322521 Change-Id: I93930de8c07bb94318ac41c67513a3b1c8bd3bf0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4681842 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 8f76a7eb 2023-06-20T16:15:22 Metal: Use the pipeline cache for RenderUtils compute shaders This ensures that all pipelines created in the Metal backend are stored in the single pipeline cache. Bug: chromium:1329376 Change-Id: I99db93426acb3467be41d1fca5238b34553f6684 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4628680 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 75dd634d 2023-07-14T10:01:08 Roll vulkan-deps from ad8a66bf7d69 to aa35b58fce7d (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ad8a66bf7d69..aa35b58fce7d Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/44779f508a..f47028995c * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9ab811a125..29431859f5 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8b94e87bff..6837a92c34 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c3065a7aed..80679543ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I5edc436c35669da2ddddd038c9895216781c211c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684021 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll da9ccc01 2023-07-14T07:00:12 Roll Chromium from de1153f640b8 to 68d783529187 (590 revisions) https://chromium.googlesource.com/chromium/src.git/+log/de1153f640b8..68d783529187 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4c5f2bf0f3..7565823755 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8d21803b90..d6ce172e32 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a59ee3caa2..2bac855313 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..afb1d77b69 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7265d88a45..abbd5858fa * third_party/fuchsia-sdk/sdk: version:13.20230629.2.1..version:13.20230711.2.1 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/ffa8abcd30..80da587681 * tools/luci-go: git_revision:1b0aa1222dd6e11673230e5b093d0a8ed6244e95..git_revision:f02582af78f530a7bbfe2f059fa5d211c9517756 * tools/luci-go: git_revision:1b0aa1222dd6e11673230e5b093d0a8ed6244e95..git_revision:f02582af78f530a7bbfe2f059fa5d211c9517756 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f7c0d5e54a..f8f7cb6141 * tools/skia_goldctl/linux: rm5mLaL8XD6eQvwq5a1oqtyfUbbjnUo1uQlcF6zoxLAC..Q5cqdj5BQE3eWNCe2CqhLT13X-o0w1ta7V2XnmXIrnEC * tools/skia_goldctl/mac_amd64: D2Xn7R8I-IEY0P-2JklhAHVSbuuUizevvyMlfXENjKkC..YieDEr0s0SH8j_1Os9w89pblPmGHE2vvLJtvdTYamfAC * tools/skia_goldctl/mac_arm64: xKGurBAqifTBoPNsTYQDrb9o_k5Twba5Dh1qwgE3iR8C..isJD0ZhCCqmn1h8q6_12lvDCcKt_M-8v548oOoQwpN4C * tools/skia_goldctl/win: rpb78oS4WtlmYjaFPtWhEWaEIOXmzXAoSTnFu9WwSmsC..OzmCj3mfsBuDD-gOktZNf1BcL8eg8Ewi8ekcYDI4tsAC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I96f28cdabed15d6d46736d0dfc49a7eba527f655 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684436 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 19c4e885 2023-07-13T15:24:03 Update input color in YUVSampleLinearFiltering test This test uses narrow range encoding (as can be seen from the color value for black) but the Cr component for red is greater than 240. On some platforms with different clamping logic the output color after conversion ends up not being red. Update the input colors to account for different implementations. Bug: b/210526871 Test: ImageTestES3.SourceYUVAHBTargetExternalYUVSampleLinearFiltering* Change-Id: Ib9b76c9433b07f5ce8a129779e77bc682bb341ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684018 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 817f4b81 2023-07-10T00:00:00 Restrict color writemasks for RGB9_E5 color buffers Per-channel write operations to shared exponent color buffers are loosely defined and may cause driver validation errors. Restricted the set of allowed color writemasks for RGB9_E5 color buffers so that RGB channels must be either all enabled or all disabled. Added a Metal-specific adjustment to ignore alpha writemask for RGB9_E5 color buffers. Removed an unused function from RenderPipelineColorAttachmentDesc. Bug: angleproject:8043 Change-Id: I902c3b70ddc6d8e65069d98a4a02a82122f413a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685566 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 6ffd0d20 2023-07-12T12:09:45 Vulkan: Clean up depth stencil feedback mode part 2 Right now the tracking of depth stencil buffer readOnly or feedback loop is in FramebufferVk class. This really belongs to ContextVk, since it is not a permanent state of framebuffer, but current state of context. This CL moves it to ContextVk and changes to use BitSet instead of four boolean. Bug: b/289436017 Change-Id: I955c439259935f82eff30ddfff776a69723e5d0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679886 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
kmx.io     mail     discord kmxgit v0.4.0