|
c9bf5465
|
2024-08-12T11:47:16
|
|
Reland "Remove the linkage-specification on `main`"
This is a reland of commit b60dc9d59aad03e641b86431c277c877d4ca9d7a
Original change's description:
> Remove the linkage-specification on `main`
>
> According to the standard, the main function should have no
> linkage-specification [1]. New version of clang will enforce
> this via a warning [2] which causes build failure if building
> with `-Werror` which treats warnings as error.
>
> Remove the superfluous linkage-specification to fix the error.
>
> [1]: https://eel.is/c++draft/basic.start#main-3
> [2]: https://github.com/llvm/llvm-project/pull/101853
>
> Fixed: chromium:358427300
> Change-Id: I541166cbd122c7e296ecdd2b5a9f9a107fe82872
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782349
> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Fixed: chromium:358427300
Change-Id: I380fdf74dc2a056f94af35c5c6c566a88d750c7d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5785953
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
f0465cac
|
2024-08-12T15:46:14
|
|
Revert "Remove the linkage-specification on `main`"
This reverts commit b60dc9d59aad03e641b86431c277c877d4ca9d7a.
Reason for revert: Fails to roll into Chromium
https://chromium-review.googlesource.com/c/chromium/src/+/5782182
https://cr-buildbucket.appspot.com/build/8739800008401884241
Original change's description:
> Remove the linkage-specification on `main`
>
> According to the standard, the main function should have no
> linkage-specification [1]. New version of clang will enforce
> this via a warning [2] which causes build failure if building
> with `-Werror` which treats warnings as error.
>
> Remove the superfluous linkage-specification to fix the error.
>
> [1]: https://eel.is/c++draft/basic.start#main-3
> [2]: https://github.com/llvm/llvm-project/pull/101853
>
> Fixed: chromium:358427300
> Change-Id: I541166cbd122c7e296ecdd2b5a9f9a107fe82872
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782349
> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Change-Id: Id9f99c21480e7f72617b2907c35356e5033a3ce4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782859
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
b60dc9d5
|
2024-08-12T11:47:16
|
|
Remove the linkage-specification on `main`
According to the standard, the main function should have no
linkage-specification [1]. New version of clang will enforce
this via a warning [2] which causes build failure if building
with `-Werror` which treats warnings as error.
Remove the superfluous linkage-specification to fix the error.
[1]: https://eel.is/c++draft/basic.start#main-3
[2]: https://github.com/llvm/llvm-project/pull/101853
Fixed: chromium:358427300
Change-Id: I541166cbd122c7e296ecdd2b5a9f9a107fe82872
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782349
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
0dbe7cdd
|
2020-12-08T12:24:35
|
|
iOS testing support
angle_white_box_tests build and runs and passes on the iOS
simulator with this change. angle_end2end_tests builds and runs but
crashes.
Bug: angleproject:4256
Bug: angleproject:5417
Change-Id: I8817e46415c4598cbfae49804727a2e9b21baff1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600361
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|