kc3-lang/angle

Log

Author Commit Date CI Message
Charlie Lao a96e9197 2024-04-25T10:35:02 Vulkan: Add RefCountedEvent class and VkCmdSetEvent call This CL defines RefCountedEvent class that adds reference counting to VkEvent. CommandBufferHelper and ImageHelper each holds one reference count to the event. Every time an event is added to the command buffer, the corresponding RefCountedEvent will be added to the garbage list which tracks the GPU completion using ResourceUse. That event garbage's reference count will not decremented until GPU is finished, thus ensures we never destroy a VkEvent until GPU is completed. For images used by RenderPassCommands, As RenderPassCommandBufferHelper::imageRead and imageWrite get called, an event with that layout gets created and added to the image. That event is saved in RenderPassCommandBufferHelper::mRefCountedEvents and that VkCmdSetEvents calls are issued from RenderPassCommandBufferHelper::flushToPrimary(). For renderPass attachments, the events are created and added to image when attachment image gets finalized. For images used in OutsideRenderPassCommands, The events are inserted as needed as we generates commands that uses image. We do not wait until commands gets flushed to issue VkCmdSetEvent calls. A convenient function trackImageWithEvent() is added to create and setEvent and add event to image all in one call. You can add this call after the image operation whenever we think it benefits, which gives us better control. (Note: Even if forgot to insert the trackImageWithEvent call, it is still okay since every time barrier is inserted, the event gets released. Next time when we inserts barrier again we will fallback to pipelineBarrier since there is no event associated with it. But that is next CL's content). This CL only adds the VkCmdSetEvent call when feature flag is enabled. The feature flag is still disabled and no VkCmdWaitEvent is used in this CL (will be added in later CL). Bug: b/336844257 Change-Id: Iae5c4d2553a80f0f74cd6065d72a9c592c79f075 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5490203 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi e4a12a67 2024-05-02T13:25:53 Vulkan: Dynamic depth test + static depth write When depth test changes in such a situation, the static state is still affected (because we mask depth write with depth test) so the graphics pipeline still needs to be invalidated. Bug: b/336386662 Change-Id: Iebba79ffd7d6fa3962a5b20c27efcca3aa35b10a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5511602 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov e8712205 2024-05-02T17:37:12 End ANGLE Mac Intel experiment Bug: chromium:326904538 Change-Id: I0cb2db356bcb7760ca64a51b4bc853fecaf001de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5510844 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Shahbaz Youssefi 04825894 2024-05-02T11:17:33 Vulkan: Turn SPIR-V limitations to crash instead of security bug The input shader can be made complex in a number of different ways, resulting in instructions with a length higher than what can fit in SPIR-V (i.e. 16 bits). Ideally, the translator would catch such complex usage early on and gracefully fail compilation. However, as a safety net, this change makes sure such a case is detected when the SPIR-V instruction is being generated and turned into a crash. This makes sure such bugs are no longer security bugs. Bug: chromium:335613092 Change-Id: I5c0693ac1ead5af04977417f10572018f8aa72bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5510722 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Brian Sheedy e5606471 2024-04-25T14:48:53 Start Linux/Intel experiment Bug: chromium:41496254, angleproject:8680, angleproject:8682 Bug: angleproject:8683 Change-Id: I1956ac642969cae0c17fff87388e899237b9df2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5491789 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
angle-autoroll f2182a71 2024-05-02T14:51:49 Manual roll Chromium from bc4f0a08ba8d to 904b00ce27b4 (619 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/bc4f0a08ba8d..904b00ce27b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0347db4c4f..5eb3babb02 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6ed3b71a7d..9e629115ed * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2c1ad970da..31bdf8fec4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e84a4942dc..0421a22c02 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e75b940aea..7ababdfe02 * third_party/r8: eec4ZxEvkO7Pa1LUWDkVKiCv0bZjS7ctubjxW94ZYVYC..fXvmQSzprkeb1fs3dnkBm_gsAhb5aUtQGRmUq3Oi1WYC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/49bb033593..d62c213c1e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cc8e1423f4..e28e015fae * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/880331b699..8ca02a85c4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/73a1c67b51..7ef4ff5ba3 Clang version changed llvmorg-19-init-8943-gd8503a38:llvmorg-19-init-9433-g76ea5feb Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/cc8e1423f4ade8b4871bc33fa44f061826bff2ff..e28e015fae35a9ff21a2550e8e7cfe9fedd85558/scripts/update.py Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I62b58317a721bca1271f01647ff4b052e699aa50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5509904 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 44bdc2af 2024-04-23T19:43:29 restricted_trace_perf: Write summary for single renderer For use when generating spreadsheets focused on Vulkan. Previously the script would exit without generating a CSV file unless there were two renderers to compare. Test: restricted_trace_perf --renderer vulkan Bug: b/317411251 Change-Id: Ic9872599edb38c738112265b1ce7f252cf3f966a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5508315 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Charlie Lao caebfea1 2024-04-24T16:58:39 Vulkan: Make PipelineBarrierArray a class Right now PipelineBarrierArray is just a angle::PackedEnumMap<PipelineStage, PipelineBarrier>. To make iterate over barrierArray faster we added mPipelineBarrierMask. They are not encapsulated well. This CL makes PipelineBarrierArray a class which internally tracks mPipelineBarrierMask bits. We also moved pipelineBarrier related code into this class. This is a preparation for the later CL that we will have a EventBarrierArray so that the pipelineBarrier and eventBarrier are better separated. Bug: b/336844257 Change-Id: I6002e3fdd584d5a63587f68f13a260b417b3db32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5484711 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 1bb1ee06 2024-04-29T15:27:36 GL: Sync unpack state for glCompressedTexSubImage3D Unpack state is supposed to be ignored for compressed tex image calls but some drivers use it anyways and read incorrect data. Texture3DTestES3.PixelUnpackStateTexSubImage covers this case. Bug: chromium:337766133 Change-Id: Ic11a056113b1850bd5b4d6840527164a12849a22 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5498735 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 53811e86 2024-05-01T08:09:48 Roll Chromium from 83c70f11490d to bc4f0a08ba8d (625 revisions) https://chromium.googlesource.com/chromium/src.git/+log/83c70f11490d..bc4f0a08ba8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc7e21c7b0..0347db4c4f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d0f0285d02..9703d9137f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/79213704bc..6ed3b71a7d * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d64937aec7..8ed0817e40 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/2d7b0a17b7..f80bca53c2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/835aa3e871..e84a4942dc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c87882a7b..e75b940aea * third_party/fuchsia-sdk/sdk: version:20.20240412.2.1..version:20.20240430.3.1 * third_party/r8: 7sVFkxumsokMdM4MavgTQKuAVJ2_MQLCkqc9uln8Gl0C..eec4ZxEvkO7Pa1LUWDkVKiCv0bZjS7ctubjxW94ZYVYC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/2451d1d2b6..49bb033593 * tools/luci-go: git_revision:239be4fd8499df782db6bddb0f55832bf4f01307..git_revision:01d1863acbd3d4c41da2aa7407a0ea6a195c770f * tools/luci-go: git_revision:239be4fd8499df782db6bddb0f55832bf4f01307..git_revision:01d1863acbd3d4c41da2aa7407a0ea6a195c770f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6e4e92a394..73a1c67b51 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ie3ffb90207e23d08cb2e6e322a811b3c3b1cd952 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5503640 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi bb6a5724 2024-04-29T16:01:47 Use vendor ID to check QCOM device for tests * In angle_test_instantiate, IsQualcomm() will now use the vendor ID as well. Bug: b/331271522 Change-Id: Ifb26034516a007472fb2a54f34f332e34b46a365 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5499382 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Charlie Lao 950afec4 2024-04-30T09:38:43 Vulkan: Add VK_KHR_synchronization2 feature flag This CL adds VK_KHR_synchronization2 feature flag and enables the feature if exists. Bug: b/336844257 Change-Id: I201768e32c997125472c6a005c4635141441451e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5499379 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 2d1bb3e1 2024-04-15T00:58:07 CL: Replace Spinlock with angle::SimpleMutex Bug: angleproject:8667 Change-Id: I9b53da920ea743d77c76793522cef826ecc62813 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5446559 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski 6658d5e8 2024-04-25T13:51:43 Tests: Add Modern Combat 5 trace Test: angle_trace_tests --gtest_filter=*modern_combat_5 Bug: b/330861486 Change-Id: I54b22010fdb5be6d1113f4dd6561848b44a413cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5501770 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Gowtham Tammana 298b8739 2024-04-15T13:58:01 Vulkan: Restrict the ContextVk dependency in CommandBufferHelper Updating the interfaces that have no need for ContextVk state and instead passing in the vk::Context. Bug: angleproject:8544 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Change-Id: Id3b72d9eabb7d1d6ee89c46cdc24a23da9e32b5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5492319 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e49b941f 2024-04-30T07:02:15 Roll Chromium from 228731187f89 to 83c70f11490d (641 revisions) https://chromium.googlesource.com/chromium/src.git/+log/228731187f89..83c70f11490d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cc3072434e..dc7e21c7b0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b915e95c06..d0f0285d02 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5ce487451c..79213704bc * third_party/android_build_tools/lint: f5ptuXixKwddKw0rnCKuNjXY9E35_710E7SNxoOLNnMC..O1UDDudkb1fHG2uMxzszPWctYiGgjyywsi7Lbkq7roYC * third_party/android_build_tools/manifest_merger: Xef4nLhp0rWWjXJXt9CTFjQF8S6qRduSY7LZCcJi48QC..wRnJA-ZlBBQipw_wjYJJemxCCPSZHenIFsWKi3GI_FUC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e057d1ff15..d64937aec7 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/bb9e0f87b9..2d7b0a17b7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/11804c96b1..835aa3e871 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4246ba023a..2c87882a7b * third_party/kotlin_stdlib: E67atHdREsWLno-3b4Py3r87C4LB7gpVYDq3Q1z7t90C..05hzFgOi0AqRK3RxbSvGj2TWTFUNeLcwkJwVzwgLttUC * third_party/turbine: agNIST7gEMTmrnvQLPzx2dduGa52uMmOx3fEWm9z5MEC..fYpnoJAvh8-OaNB9k81XWGrwiODb_uTipTBEUeIFM98C * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4852168b7d..6e4e92a394 * tools/skia_goldctl/linux: ZpyLtfuztdYI-RCkvm6kXlmx8ec1wYyrwXNI-lQEJKwC..AJacKGh5nnjmNZk56j2ia4-QtIE8eEAFELw48t8XinEC * tools/skia_goldctl/mac_amd64: FpwpXsMPl8Mets8uet3zfFw8nNBpl69xJoTYESLUjl8C..uJJWpJUp-FSzEXlwqzoUD41p5swLKyDhxXdJBLShbMsC * tools/skia_goldctl/mac_arm64: GuJOsvx5V5z8DvAM_HOVy6eBydQ0sO7dVso_p_L7KTgC..ekRiJKPFBJKiZ3N4ev_vRuf2X13dgTDcZNXKYt2qZPoC * tools/skia_goldctl/win: LT6gNudC207ke0t4qv9IW_s27hoPIafnwpcfrzR8FzMC..4bTyiie8-MG6hBk2yGEE9d8p3HWHGevaAouvGfKKwtQC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I39958fa4d14fcadbc77fe5b5ebffb1e00f9e3b18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5499949 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang b839e05b 2024-04-29T14:35:42 GLSL: Hardcode emulated atan functions These emulated atan functions are generated for every compiled shader, the string generation is particularly costly for small shaders (>30% of total compile time). Instead just hardcode the emualted functions, there are only 4. Bug: angleproject:8434 Change-Id: I3f8b7cc9709ca132fae19953c23d02e54538d4e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5498516 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Charlie Lao 1064b38d 2024-04-24T14:41:59 Vulkan: Move ImageLayout define to earlier in vk_helpers.h file This is the preparation for the later CL. Later in the CL I need to define something like "angle::PackedEnumMap<ImageLayout, RefCountedEvent>" to use in CommandBufferHelperCommon. So I need ImageLayout to be defined earlier. No actual changes involved other than moving the code around for easier code review. Bug: b/336844257 Change-Id: I0a2553ef3aebf4b00d1798e2117fe6ed32ac172d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5484675 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 4929e1df 2024-04-24T14:09:59 Vulkan: Add feature flag for using event for image barrier This is preparation CL that adds a feature flag for using VkEvent for image barriers. Bug: b/336844257 Change-Id: I01a7d779e16e2c259ddd05dca7338b3b18c30ba7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5484708 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f51f2bc5 2024-04-29T16:18:33 Manual roll vulkan-deps from 736920240f0b to 74fe79763664 (13 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/736920240f0b..74fe79763664 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b5672e8e8d..f857417c99 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/9aec60c387..d21838aeaa * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/d0ffc68fe7..68780d9b8c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9911e85d47..397d8fbc0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: Ib28650fa98f33ac7c578b83763a3eb1ca65ad8c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5495021 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 038ad6c7 2024-04-23T13:23:04 EGL: Use unlocked tail calls for surface, sync and img calls EGL surface and sync calls can be expensive to do while holding the global lock on EGL. They are safe because the parameters are captured by value and the underlying EGL driver is also thread safe. EGL image creation also tends to be expensive and is called freqently by Chrome. Bug: angleproject:8434 Change-Id: I7e554fe2e3700d98469de267f7bbff1e96358c78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5478229 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 978cf07b 2024-04-25T14:35:14 Suppress failures on Pixel 6 AP1A.240405.002 Bug: b/336847261 Change-Id: I501f64e22536418715369742f5ec760e23aa2c14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5489759 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 44ce5887 2024-04-11T16:37:27 Allow the backend to do resource init for framebuffers. The frontend framebuffer would loop through attachments which needed to be initialized and call initializeContents on them individually. For the GL backend this is inefficient because each of these resources is bound to a scratch framebuffer and cleared when the entire original framebuffer could have been cleared at once. The frontend now accumulates a set of attachments that need to be cleared and sends it to the FramebufferImpl. The default FramebufferImpl does the old logic of calling initializeContents on each attachment. FramebufferGL has an optimized path to clear the whole framebuffer if possible. Bug: angleproject:8642 Change-Id: I574cd03307794a6c7b2666976784e4d4dca1d08c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5448552 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Mohan Maiya a0b721bc 2024-04-23T17:08:58 Vulkan: Optimize DescriptorSetLayout with no bindings There is no need to unpack bindings of DescriptorSetLayoutDesc and call into vkCreateDescriptorSetLayout when there are no bindings. Insert a placeholder vk::DescriptorSetLayout into DescriptorSetLayoutCache. This reduces the number of Vulkan handles created and can be reused across multiple pipelines that have DescriptorSetLayoutDesc with no bindings. Bug: angleproject:8677 Change-Id: Ifc0d199697a95f3a5c037fd85520220a512d7949 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5483308 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 2eed792c 2024-04-15T01:09:57 Vulkan: Use angle::SimpleMutex with async command queue This change lets ANGLE test the waters with angle::SimpleMutex with functionality that is currently mostly exercised by tests. Bug: angleproject:8667 Change-Id: Icf3a021da1f0a2e1c9235ed518bcb9e378b09cfa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5446560 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Gowtham Tammana acb8b33f 2024-04-16T14:08:34 Vulkan: Enable 8/16 bit storage buffer extensions The support for 8bit and 16bit storage buffers are exposed via VK_KHR_{8,16}bit_storage vulkan extensions. Add checks for these extensions and enable them if present. The changes in FeaturesVk_autogen.h in the change are generated by running the run_code_generation.py script. Bug: angleproject:8676 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Change-Id: Idcda416e3eb6a735e021cd5bb0a182af341e9a16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5491781 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 5907fcfd 2024-04-29T07:00:28 Roll Chromium from 0129806a25c3 to 228731187f89 (630 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0129806a25c3..228731187f89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e797b8d487..cc3072434e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/86bf72c93e..b915e95c06 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/de15ed6974..5ce487451c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e70dca1b50..e057d1ff15 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/774f822ffd..11804c96b1 * third_party/r8: vLf3kX0m10K0jItylIPHXJzX-Df7gLlx0EN_jDuagU0C..7sVFkxumsokMdM4MavgTQKuAVJ2_MQLCkqc9uln8Gl0C * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/a3f7e1c3fd..2451d1d2b6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9570c8ceea..cc8e1423f4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e2665361f3..4852168b7d No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I1bac230028af98edb9ec32034953f1d08d78d211 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5496247 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 8332e5b1 2024-04-26T14:29:32 Use python3 instead of python for bootstrap * In roll_aosp.sh, replaced the remaining python usage with python3. Bug: b/246559064 Change-Id: Iea9737376c34264fec5d60e4cb772eb8c5be81f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5494462 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Mohan Maiya b74de557 2024-04-24T14:35:17 Vulkan: Add a feature related to shader subsets On vendors that support VK_EXT_graphics_pipeline_library the shaders subset of the pipeline can either be combined into a single pipeline or can be decoupled into separate pipelines. Upcoming optimizations require the ability to distinguish between the two options. Add a feature declaring support for only the combined variant. Bug: angleproject:8601 Change-Id: I44fb828d972ca6ebba5549819ce8e41645683e14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5484673 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Dan Glastonbury d9a00875 2024-02-21T16:57:43 Metal: Override internal format of images Add support for overriding the internal format when binding Metal textures to EGL images. Fixed: angleproject:8552 Change-Id: I364a88a2e608e462c5216c92927679814ab91ca5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5310305 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Roman Lavrov 89caa0e1 2024-04-23T15:32:52 Cleanup: replace DirtyObjectType check with constexpr generator Static assert was meant to avoid kDirtyObjectHandlers getting out of sync, but it doesn't achieve that goal as it's just comparing values with ints which is confusing. Replacing with constexpr generated std::array. C++20 allows to easily validate that all values are set by _not_ default-initializing `handlers`. C++17 makes it trickier, addeded static_assert on an additional static constexpr bool (silly but I can't find a more concise way) Bug: angleproject:8666 Bug: b/335295728 Change-Id: Idf9bbd087d09d5ba253a7587ce0503cae3fcf3a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5478231 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 5e37ae35 2024-04-26T10:01:04 Roll vulkan-deps from a4bf9c4e9ffd to 736920240f0b (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a4bf9c4e9ffd..736920240f0b Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/17c8bcb0e8..9911e85d47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ib793e124990695da8ee822d048db427952d13ea0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5493529 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 884dc380 2024-04-24T16:46:01 EGL: Make eglGetCurrent(Context|Surface|Display) lockless. These functions access only egl::Thread state. Bug: angleproject:8434 Change-Id: I3dd6cd1f4fd145613f0be824e4f6e13815422997 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5485526 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll bea8d9dd 2024-04-26T08:13:29 Roll Chromium from ad99ecc02953 to 0129806a25c3 (372 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ad99ecc02953..0129806a25c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dfdfe582f6..e797b8d487 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/571c37f17d..86bf72c93e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/03850de4bf..de15ed6974 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d980d879d2..774f822ffd * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a52511c59..4246ba023a * third_party/r8: mhSwabeiU2ueQeYkj0X1JTg-6ZdtQgiVVXM1bo0yu4IC..vLf3kX0m10K0jItylIPHXJzX-Df7gLlx0EN_jDuagU0C * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e8280e634c..a3f7e1c3fd * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/949930758e..9570c8ceea * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/36708f2aa1..e2665361f3 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I8fccc3876ddee207b9ca39558d343fd724009a08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5493526 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand c62c0c25 2024-01-24T17:29:45 CL/VK: Implement initial enqueueRead/WriteBuffer Bug: angleproject:8638 Change-Id: I1d5b3b15fab24ce35c243a3eb27bcac2104d7f5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5409250 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Austin Annestrand 6cfb5931 2024-03-13T12:31:40 CL/VK: Implement marker and barrier cmds Adding in last remaining marker and barrier cmds: clEnqueueMarker clEnqueueBarrier clEnqueueMarkerWithWaitList clEnqueueBarrierWithWaitList Bug: angleproject:8634 Change-Id: I67e03e379c3f9e40a31bcba34ea85e2739cc97b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406617 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 55affbfd 2024-04-25T17:34:09 Manual roll Chromium from 0543b5c427ca to ad99ecc02953 (246 revisions) Manual roll requested by bsheedy@google.com https://chromium.googlesource.com/chromium/src.git/+log/0543b5c427ca..ad99ecc02953 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,bsheedy@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a1bcbf3070..dfdfe582f6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/89090fdbd1..03850de4bf * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/01d7072ad6..d980d879d2 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fb94001f06..9a52511c59 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0aaac4902f..949930758e No update to Clang. Bug: None Tbr: ynovikov@google.com,bsheedy@google.com Change-Id: Iadac5adc4672786702c5c856114a89f5f54c6300 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5490169 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand 04329fe0 2024-01-24T12:51:05 CL/VK: Implement wait APIs This commit implements: clWaitForEvents clEnqueueWaitForEvents Bug: angleproject:8633 Change-Id: I873310ab11dfac08c165dc36be2400a35be48878 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406616 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Mark Lobodzinski e3a58b25 2024-04-11T09:33:55 FrameCapture: Support deferred linking of shaders Modern Combat 5 creates and attaches programs and shaders but defers compiling and linking until needed. Added support in the tracer for this corner case and updated CapturedTest to exercise this behavior as well. Test: angle_end2end_tests --gtest_filter=CapturedTest.MultiFrame/ES3_Vulkan Bug: b/334030316 Change-Id: Ib7fdf0fe25b11cdb3df33d50e49501f3a51e9510 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5449599 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 37d2277b 2024-04-23T20:00:04 Vulkan: Disable dynamic state on JM based Mali Latest Vulkan driver causes a number of issues on this GPU. Bug: b/336411904 Bug: b/336847261 Change-Id: I34a4842ba501c5f71c8b9c7d97c2bb215b30d7be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5484709 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang ab0140b0 2024-04-25T10:23:51 Update CLA contact information in the documentation. Bug: angleproject:0 Change-Id: Iefc4527fd6ddf79e319cef8ff8a92a791fb47547 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5489679 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll d0a2525d 2024-04-25T10:01:54 Roll vulkan-deps from 8ff7d8bf1899 to a4bf9c4e9ffd (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8ff7d8bf1899..a4bf9c4e9ffd Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/e94cd2e354..fa3b7bdefa * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a9ec5ff430..17c8bcb0e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ia413312da0d33be24caf5b1c06a2fe9d1808ccda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5487461 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 75c14ed6 2024-04-25T07:01:10 Roll Chromium from 3bff690c506f to 0543b5c427ca (360 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3bff690c506f..0543b5c427ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f7bf3dec53..a1bcbf3070 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d5da953756..89090fdbd1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/48216439d9..01d7072ad6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3d170cb6ce..fb94001f06 * third_party/siso: git_revision:366e623c64429778827e021672a260553c7bd068..git_revision:70d9e16bcc9dff0264905018f5a5652b37ed0e10 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c05ed83254..0aaac4902f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/918fef0e46..880331b699 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3f41393fee..36708f2aa1 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ib3ffe0b0fdb0e569faa9099839b2ccfc818084d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5484713 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jose Dapena Paz 47fc356b 2024-04-09T11:20:07 GCC: move warm up tasks out of anonymous namespace GCC anonymous namespace is set per file. So forward declaring in the anonymous namespace of .h will not be valid in the .cpp file. Bug: chromium:40565911 Change-Id: I10bd94f035761602d69e59a94dfde5dc774a6776 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5475346 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 9c2632b3 2024-04-24T16:54:27 Manual roll Chromium from 4433c533fffb to 3bff690c506f (214 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/4433c533fffb..3bff690c506f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cd430bd4b2..f7bf3dec53 * buildtools/linux64: git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25..git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789 * buildtools/mac: git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25..git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789 * buildtools/win: git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25..git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3070e96403..d5da953756 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ca84904bdc..2c1ad970da * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/277a3849eb..c05ed83254 Clang version changed llvmorg-19-init-8091-gab037c4f:llvmorg-19-init-8943-gd8503a38 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/277a3849ebe4f41beb773614cc4bad839870cfcf..c05ed83254645402a98ed838a2fe98cc1bf67fb2/scripts/update.py Bug: None Tbr: ynovikov@google.com Change-Id: Ic28626e4ae751a408feaffafabc0ebc213684693 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5483590 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov a4439599 2024-04-24T14:49:14 End Win Intel experiment. Bug: chromium:41496254 Change-Id: I0385d8f9840341cfad979f0fbee181f6eb0013ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5483086 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Charlie Lao d2e5eeef 2024-04-23T17:47:03 Vulkan: UNASSIGNED-CoreValidation-DrawState-InvalidImageLayout Supress the above VVL error. What happened is that the test creates a single buffer context. Since it only has one buffer for both render and present, we always immediately put it in VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR. Then when we render to it, we got the above VVL error. According to vulkan spec 6) What should the layout of the shared presentable image be? RESOLVED: After acquiring the shared presentable image, the application must transition it to the VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR layout prior to it being used. After this initial transition, any image usage that was requested during swapchain creation can be performed on the image without layout transitions being performed. And we always include VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT usage flags when creating swapchain images, so this should be okay. Bug: b/336652255 Change-Id: I8a04f94c9a7b6dcc1818697f45630cb0a6ee8811 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5479840 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0e7d735b 2024-04-24T10:01:38 Roll SwiftShader from 9aec4b969291 to 76f7f8cfea80 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/9aec4b969291..76f7f8cfea80 2024-04-23 wangqing-hf@loongson.cn llvm-16.0: Remove build dependencies for <valgrind/valgrind.h>. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I383ccffa6a733f8daa557edde02f41a01362561c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5482031 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b8e7860f 2024-04-24T07:00:56 Roll Chromium from b00758dcbb7a to 4433c533fffb (891 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b00758dcbb7a..4433c533fffb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c7d168ab6d..cd430bd4b2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fdc7df36c5..3070e96403 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a64dd87cec..ca84904bdc * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e939ac77bb..48216439d9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/917a57459b..3d170cb6ce * third_party/r8: jiR3Cmr6zLjEDaMOALv35_EoVDJbl5Mdza1IRQLevjAC..mhSwabeiU2ueQeYkj0X1JTg-6ZdtQgiVVXM1bo0yu4IC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/628a8e6856..e8280e634c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bca0c9f60a..277a3849eb * tools/skia_goldctl/linux: SQswrvGi674ASEtZKS6NGrcxzcOAx9fdEvxSUwNCVkIC..ZpyLtfuztdYI-RCkvm6kXlmx8ec1wYyrwXNI-lQEJKwC * tools/skia_goldctl/mac_amd64: vuB-Klm2s3uWsshi6g4r4l4fZox0RrWCgtSRKTxev3QC..FpwpXsMPl8Mets8uet3zfFw8nNBpl69xJoTYESLUjl8C * tools/skia_goldctl/mac_arm64: sqWmO8LOK7GgLCYuZo_PWkn6BcuBSgv16TPYoV44QUsC..GuJOsvx5V5z8DvAM_HOVy6eBydQ0sO7dVso_p_L7KTgC * tools/skia_goldctl/win: 4Y2pcWzsEQOJJ76XA1eaNSwef4YuyOrnQ-lSK1-71PkC..LT6gNudC207ke0t4qv9IW_s27hoPIafnwpcfrzR8FzMC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I06abb5fe90d122d9f444db12b73b25fc49d6d371 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5481531 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d4519fdc 2024-04-24T10:01:37 Roll vulkan-deps from 91b20c9cf5fd to 8ff7d8bf1899 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/91b20c9cf5fd..8ff7d8bf1899 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b9b8fd917b..b5672e8e8d * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/4f7b471f1a..5e3ad389ee * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8e5a28304e..a9ec5ff430 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I2ca5e6aecc37b4e99dd70d8b1995e037567d1b76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5481612 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao c74d2634 2024-04-19T12:19:51 Vulkan: Update mSurfaceCaps with per-present mode caps. Vulkan spec says "The per-present mode image counts may be less-than or greater-than the image counts returned when VkSurfacePresentModeEXT is not provided". Riht now we are using the generic surfaceCaps information which has smaller minImageCount. This triggers VVL error VUID-VkSwapchainCreateInfoKHR-presentMode-02839.. This CL updates mSurfaceCaps and mMinImageCount with per-present mode caps and create swapChain with proper minImageCount. Bug: angleproject:8672 Change-Id: I6061d2db8e98032dcb2c3225f2976013a99336a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5467850 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Yuly Novikov 94179bed 2024-04-23T13:57:45 Roll chromium_revision 39c16b7a37..b00758dcbb (1290535:1290830) Update scripts/roll_chromium_deps.py to ignore GCS DEPS entries. Change log: https://chromium.googlesource.com/chromium/src/+log/39c16b7a37..b00758dcbb Full diff: https://chromium.googlesource.com/chromium/src/+/39c16b7a37..b00758dcbb Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f381a5d258..c7d168ab6d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5eb927f0a9..571c37f17d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/844489d5bf..fdc7df36c5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6ba67afd6f..917a57459b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/31ab5f9786..628a8e6856 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e0d0c28dbe..bca0c9f60a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8f37fed0b7..918fef0e46 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8bf48ae269..3f41393fee DEPS diff: https://chromium.googlesource.com/chromium/src/+/39c16b7a37..b00758dcbb/DEPS No update to Clang. Bug: b/328065301 Change-Id: Ied690fe00ca0f82d4c5e17092ea96a6bc0f9b7d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5476868 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0d1dab2c 2024-04-23T10:01:16 Roll vulkan-deps from 36da75a01950 to 91b20c9cf5fd (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/36da75a01950..91b20c9cf5fd Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/68df223056..b9b8fd917b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dadb3012d5..dd4b663e13 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f0c17604ed..e94cd2e354 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/12f7fa5ed7..8e5a28304e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: If4ebc7d3360ad898df44ea79f71f567aa3bea468 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5475603 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 6fe8a399 2024-04-22T18:11:30 Metal: Fix rewritten out variables with underscores Fix compilation in case of output variables start with underscores. Make name emission always emit MSL name ANGLE_{name}, so that GLSL `_e` and `e` cannot clash. This regressed in angleproject:8558. Bug: chromium:335744344 Change-Id: Ibae4dba4a24888acc1461582e69d48218ba11176 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5473412 Reviewed-by: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Charlie Lao 2905a6a6 2024-04-19T15:09:41 Vulkan: Fix read pixel to cached non-coherent memory The bug here is that when we use cached non-coherent memory for image read, we must wait until DMA to finish before calling invalidate(). Otherwise CPU pre-fetching might end up populate the cache line again with old data between invalidate and DMA and causes CPU reads get the stale data from cache. This CL moves invalidate() call after we wait for copy to finish and removes requireCachedBitForStagingBuffer feature flag. Bug: b/335937565 Bug: b/315836169 Bug: b/324953979 Change-Id: Ie8a1854e17a5fe9c534c5102b2e0d51bd35c131a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5468597 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 64e97940 2024-04-22T11:41:05 Presubmit: improve bug tag check message * list acceptable options regardless of failure type * add a note when multiple Change-Id tags are detected (this can happen, for example, in case of chained CLs) * add extra info to the same error instead of adding it as another error Example output: ** Presubmit ERRORS: 1 ** Please ensure that your description contains Bug: bugtag directly above the Change-Id tag (no empty line in-between) Acceptable bugtags: project:bugnumber - where project is one of (angleproject, chromium, dawn, fuchsia, skia, swiftshader, tint) b/bugnumber - for Buganizer/IssueTracker bugs None - for minor changes with full context in description Bug: None Change-Id: I9b5fc5db2896bfd332570fa78ba67bd622cd876e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5472983 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 219f7762 2024-04-22T10:01:16 Roll vulkan-deps from 4737535cad1a to 36da75a01950 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4737535cad1a..36da75a01950 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c684aed192..f0c17604ed * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/bfdd09240f..9aec60c387 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/d0670f9ff0..d0ffc68fe7 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d1316e5423..12f7fa5ed7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ic374bc06225366e1a52b8a61ecbdaf1b5e73632b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5472162 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 40c6ba52 2024-04-22T08:01:46 Roll VK-GL-CTS from 669273b1098a to 17c6e3c4dfad (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/669273b1098a..17c6e3c4dfad 2024-04-19 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-19 piotr.byszewski@mobica.com Create RT pipeline with empty pipeline layout 2024-04-19 rgarcia@igalia.com Test interaction between minSampleShading and dynamic sample counts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I571c9e0cbffbe76b24f1e064234b960b3dcecc43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5470274 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f2901ba7 2024-04-22T08:37:10 Roll Chromium from e191335efc2d to 39c16b7a3740 (747 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e191335efc2d..39c16b7a3740 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9d1f98961a..f381a5d258 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0d2ca4d99e..844489d5bf * third_party/android_build_tools/bundletool: XoK0RwIzanpFScg7dU_8th5zMvLgKvk7c_PmhZ5LSEQC..CaAT7TJbLQC0LVo1i2TXtaMjK4SZBQ33n-s6DcBbZfgC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1a61eb625d..6ba67afd6f * third_party/r8: XZtdTveVY7h3SeKbeq0RkkuR7_zt6EH_sKJDUDK08NAC..jiR3Cmr6zLjEDaMOALv35_EoVDJbl5Mdza1IRQLevjAC * third_party/siso: git_revision:44d2b8f5b840adf521bb4912ccac31848f6d1448..git_revision:366e623c64429778827e021672a260553c7bd068 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/10697c9ce8..31ab5f9786 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/591cd4bd88..e0d0c28dbe * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8a642fb36d..8f37fed0b7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3928518a52..8bf48ae269 No update to Clang. Bug: angleproject:7904 Tbr: ynovikov@google.com Change-Id: I5bf19bf376862453f4494f499d68542ca2211acf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5470909 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 36ae4553 2024-04-21T05:18:17 Vulkan: Remove unnecessary member from ProgramExecutableVk Bug: None Change-Id: I896cd67c0ca41d146d8f1cd5494404bbd30b8264 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5469555 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 23b8a833 2024-04-19T18:03:17 Suppress VUID-VkSwapchainCreateInfoKHR-presentMode-02839 Breaks experimental Pixel 6 Android U bot https://ci.chromium.org/ui/p/angle/builders/ci/android-arm64-exp-test/4979/overview Bug: angleproject:8672 Change-Id: I2968dd1ed4ed7e2bc636d762b6d1fb884733a264 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5466741 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 84b87373 2024-04-19T10:01:03 Roll vulkan-deps from aa20d192b8c4 to 4737535cad1a (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/aa20d192b8c4..4737535cad1a Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2904985aee..dadb3012d5 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/1e7b8a6d03..eaa319dade * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b11c199a3a..d1316e5423 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I60b146950090923f2ff6746ebc68035570b5861c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5466018 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f0f4edfc 2024-04-19T10:01:49 Roll SwiftShader from 764410d4d655 to 9aec4b969291 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/764410d4d655..9aec4b969291 2024-04-18 wangqing-hf@loongson.cn llvm-16.0: Fix some issues in Reactor/LLVMJIT for LoongArch. 2024-04-18 wangqing-hf@loongson.cn Reactor: loongarch64 is not supported in subzero. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I82139f4ec7fce382d2df9a9a164effc0e4b2a69f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5467950 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 602a6a9a 2024-04-19T07:19:09 Roll Chromium from b07526b70da5 to e191335efc2d (579 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b07526b70da5..e191335efc2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fc6b52cdab..9d1f98961a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d47dd4e908..0d2ca4d99e * third_party/android_build_tools/lint: kt0D0n2B3KP5Ptno-stWIuNnhvCfms_w-8iZrMgSS8sC..f5ptuXixKwddKw0rnCKuNjXY9E35_710E7SNxoOLNnMC * third_party/android_build_tools/manifest_merger: q4q38FXedJ-uNPtYpwR--VhUglwaiG95Nz1aNXyOL9gC..Xef4nLhp0rWWjXJXt9CTFjQF8S6qRduSY7LZCcJi48QC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6aaae85821..1a61eb625d * third_party/r8: vLrV1g3mole2jBVpiMB13SquCOCucEVK_ImpPqXYIR8C..XZtdTveVY7h3SeKbeq0RkkuR7_zt6EH_sKJDUDK08NAC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/78c03ab18c..591cd4bd88 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b31325ceb7..3928518a52 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Id9d00956eb0401958e6433b18eb3d9b7ec1139ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5466013 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand cc770518 2024-03-28T18:05:00 CL/VK: Implement flush & finish Bug: angleproject:8632 Change-Id: I139e463c0b1c947cee68e65c40503e52f01e988b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406615 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi c75b03ad 2024-04-18T16:09:48 Vulkan: Remove duplicated fallback entry in vk_format_map.json Bug: b/335496851 Change-Id: Id5fe805a15ae4fa4b09ffbf05fcf7b6d3d79b1ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5463921 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Austin Annestrand d4abe622 2024-04-03T17:46:38 CL/VK: Implement enqueue NDRangeKernel & Task Adding support for: clEnqueueNDRangeKernel clEnqueueTask Bug: angleproject:8631 Change-Id: If57002be3ea00a55215e89ca47ab8fe9a422c6e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406614 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 48132950 2024-04-17T17:05:07 Vulkan: Optimize DescriptorSetLayoutDesc layout Separate out immutable samplers into its own array so we can remove padding from PackedDescriptorSetBinding which reduces the size of that struct from 16 bytes to 4 bytes. Bug: angleproject:2462 Change-Id: I79d1ab584178202c9b7f34b0c7926edced4e21a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5464162 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 80c8b6f0 2024-04-17T10:06:45 Revert "Vulkan: Only enable DS dynamic state if there is DS attachment." This reverts commit 471b50407d7d1c22491d066df77060cb8b9b2f89. The reverted change does not correctly handle UtilsVk functions, leading to validation failures. UtilsVk could be made to not set dynamic state when the depth/stencil attachments are missing, but instead the change is reverted because: - The original issue that prompted this is easily fixable (and fixed in this change) - Disabling depth/stencil dynamic state is not necessarily a performance improvement; every time a pipeline in such a render pass is bound, the driver would have to make sure to no-op the relevant state change if static, which is also costly. Instead, dynamic state may need to be set only once in the entire render pass. Bug: b/223456677 Bug: b/315353258 Bug: angleproject:8242 Change-Id: I8282b87857d6b9285dbcf307c3c6ecf69df5fadb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5462079 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu d0b01c81 2024-04-17T14:40:10 Remove duplicated fallback entry in vk_format_table_autogen Bug: b/335496851 Change-Id: Iff6a095aaffac099779b093e02b1a818b510dc0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5464161 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov 4109a90e 2024-04-16T17:31:11 LinkedUniform: avoid frequent GLenum -> index conversion Certain functions such as getElementComponents() are frequently called in driver_overhead benchmark, causing repeated GLenum -> index conversion of the uniform type which shows up in profiling (driver_overhead_2 trace) Change LinkedUniform.pod.type to LinkedUniform.pod.typeIndex storing the UniformTypeInfo index with conversion helpers. Bug: b/335295728 Change-Id: Iae5cd58f4e2703589d23b8e52991fc4b97c5fb08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5458741 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 00fa9af9 2024-04-18T10:55:34 Disable the BasicNoOpMutex test It's flaky by nature, and the flake rate turned out to be much higher than anticipated (i.e. it cannot be ignored). Bug: b/335541479 Change-Id: Ic29c549aa761230e1d8aa8156c66e78aae939e53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5463920 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bruno BELANYI 7523c5df 2024-04-18T14:22:22 Make 'ANGLE_CAPTURE_OUT_DIR' doc clearer The `chmod` issue was something I experienced when trying to record an application recently. And making it explicit that `ANGLE_CAPTURE_OUT_DIR` (and its sibling `debug.angle.capture.out_dir`) support absolute path would probably have avoided that issue in the first place. Bug: angleproject:1944 Change-Id: Ia853be244a6884f5b77c01cc67b561cc2cb45443 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5465701 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Yuly Novikov 5f532b75 2024-04-18T09:19:23 Roll chromium_revision 0abb3a90f2..b07526b70d (1287851:1289209) Unpin abseil-cpp and related DEPS, since Mac Skia bots older than macOS 10.15 were removed, so ANGLE can update abseil-cpp now without breaking roll into Skia. Roll third_party/dawn/ 66f38fda8..ed2c7c713 (212 commits; 6 trivial rolls) https://dawn.googlesource.com/dawn.git/+log/66f38fda85fe..ed2c7c7133fd in order to fix build with updated Clang, https://dawn-review.googlesource.com/c/dawn/+/182582 Change log: https://chromium.googlesource.com/chromium/src/+log/0abb3a90f2..b07526b70d Full diff: https://chromium.googlesource.com/chromium/src/+/0abb3a90f2..b07526b70d Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fffc0b385f..fc6b52cdab * buildtools/linux64: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25 * buildtools/mac: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25 * buildtools/win: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/87207dd445..d47dd4e908 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b3ae305fd5..a64dd87cec * third_party/android_build_tools/manifest_merger: UiE3IQmTjQyDp6olH-K75Gup3wY_WezHKM9riMylXVcC..q4q38FXedJ-uNPtYpwR--VhUglwaiG95Nz1aNXyOL9gC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/12e53bce03..e939ac77bb * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/22de5fb717..6aaae85821 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/80307e66e7..e3b94d0e5b * third_party/r8: 4lmbDFBqkP3D6DWu4MC8eiktQ4wuHyTMVJIWoU_q30AC..vLrV1g3mole2jBVpiMB13SquCOCucEVK_ImpPqXYIR8C * third_party/siso: git_revision:437716714a744e272fabdf1377b8878ccac26b43..git_revision:44d2b8f5b840adf521bb4912ccac31848f6d1448 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/84f141bb4e..10697c9ce8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/279d79a374..78c03ab18c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bcadedd547..b31325ceb7 * tools/skia_goldctl/linux: ZpyLtfuztdYI-RCkvm6kXlmx8ec1wYyrwXNI-lQEJKwC..SQswrvGi674ASEtZKS6NGrcxzcOAx9fdEvxSUwNCVkIC * tools/skia_goldctl/mac_amd64: FpwpXsMPl8Mets8uet3zfFw8nNBpl69xJoTYESLUjl8C..vuB-Klm2s3uWsshi6g4r4l4fZox0RrWCgtSRKTxev3QC * tools/skia_goldctl/mac_arm64: GuJOsvx5V5z8DvAM_HOVy6eBydQ0sO7dVso_p_L7KTgC..sqWmO8LOK7GgLCYuZo_PWkn6BcuBSgv16TPYoV44QUsC * tools/skia_goldctl/win: LT6gNudC207ke0t4qv9IW_s27hoPIafnwpcfrzR8FzMC..4Y2pcWzsEQOJJ76XA1eaNSwef4YuyOrnQ-lSK1-71PkC DEPS diff: https://chromium.googlesource.com/chromium/src/+/0abb3a90f2..b07526b70d/DEPS Clang version changed llvmorg-19-init-2941-ga0b3dbaf:llvmorg-19-init-8091-gab037c4f Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/279d79a37479b4b12bb4c4c27d224fd8503fbee7..78c03ab18cb89612654b8faf957eb30635316466/scripts/update.py Bug: skia:330350366, angleproject:8555, angleproject:8474 Change-Id: I70d907d78339dac9a0c0e7c6b96819c5cd62aa9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5465699 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll f696652f 2024-04-18T10:01:19 Roll vulkan-deps from bb53ad5f34d9 to aa20d192b8c4 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bb53ad5f34d9..aa20d192b8c4 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/9001ec9aa5..68df223056 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/9fc3b7bfac..bfdd09240f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6bb4f91788..b11c199a3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I71968b8da27700f0f5a43d6b880446f1f2305065 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5464287 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 51c58003 2024-04-18T10:01:34 Roll SwiftShader from 1eaac56def92 to 764410d4d655 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/1eaac56def92..764410d4d655 2024-04-17 wangqing-hf@loongson.cn llvm-16.0: Add BUILD.gn for loongarch64. 2024-04-17 wangqing-hf@loongson.cn llvm-16.0: Add configs/common and configs/linux for loongarch64. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ifce61ed70ff6636afdde189b3a4f083a3b4313d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5465800 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 6861da63 2024-04-17T15:52:27 Vulkan: Don't cache staging buffers on PowerVR Seeing flakiness in simple tests. Narrowed it down to cached coherent memory. There is likely something ANGLE is doing wrong but broaden the workaround until it is root caused. Test: angle_end2end_tests Bug: b/315836169 Bug: b/324953979 Change-Id: I15e50781f746ffb24b0a12b1e28df04a3822b556 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5464283 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mohan Maiya b2aad1bb 2024-04-17T06:12:14 Vulkan: Track valid descriptor set layouts Instead of looping through kMaxDescriptorSetLayoutBindings in `DescriptorSetLayoutDesc::unpackBindings` track valid descriptor set layouts in `DescriptorSetLayoutDesc::update` Bug: angleproject:2462 Change-Id: I1ca2ba72875d9306b6059b14cde39c5d16250be6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5464160 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi d71b8ee0 2024-04-17T10:00:27 Vulkan: Fix dynamic depth/stencil in UtilsVk when unused Dynamic state still needs to be set even if depth/stencil test is disabled. Bug: angleproject:8151 Bug: b/323708819 Change-Id: Ic470fabd84c71b026152b6bee2e6a2c803514106 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5462059 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 313c73c3 2024-04-17T12:14:40 Roll vulkan-deps from 8dc5cb57074c to bb53ad5f34d9 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8dc5cb57074c..bb53ad5f34d9 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/05ba15169e..9001ec9aa5 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/6d9e995cb6..c684aed192 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/a78460f66b..d0670f9ff0 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c64f16a640..6bb4f91788 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I6be046ebb5ac2a6b57ca297fab9d9638c82413e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5457866 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 03c88d33 2024-04-17T03:03:17 Revert "Vulkan: Suppress VUID-VkSwapchainCreateInfoKHR-pNext-07781" This reverts commit 99ac37cf7bad44d43f0c18da0410bde1073b62ea. Reason for revert: Fixed upstream https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/7851 Original change's description: > Vulkan: Suppress VUID-VkSwapchainCreateInfoKHR-pNext-07781 > > Only failing on windows x86. Unknown if ANGLE bug, VVL bug, or an > inherently racy check as it happens only in the window resize tests. > > Bug: angleproject:8668 > Change-Id: I0f928883647a4dc701d58e2df99e647e1397c773 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5453692 > Reviewed-by: Roman Lavrov <romanl@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:8668 Change-Id: I8831b5011ed3a7f5bf48af25f8933d50b5c4e1ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5459521 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll c4880865 2024-04-16T22:54:12 Manual roll VK-GL-CTS from b529676d0523 to 669273b1098a (11 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b529676d0523..669273b1098a 2024-04-12 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-04-11 slawomir.cygan@intel.com Add fragment shading barycentric for mesh shading, interpolation and provoking vertices 2024-04-11 rgarcia@igalia.com Test occlusion queries with no attachments 2024-04-11 javed@igalia.com Add coverage for creating a 2D image view of a sparse 3D image. 2024-04-11 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-10 rgarcia@igalia.com Do not build VVL when using SELECTED_BUILD_TARGETS 2024-04-05 javed@igalia.com Add coverage for mutable descriptor type list being out of range. 2024-04-05 ziga@lunarg.com Add missing resolve image in rasterization tests with multisampling 2024-04-05 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-03 yuxinhu@google.com Add the instruction to run new ES32GetTestParamActivity 2024-04-03 slawomir.cygan@intel.com Add tests for clipping in mesh shading, with provoking vertices and multiview If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I511b15edb5750f2065da5b039ce5447a9f0d4689 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5458196 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi e92b8e8d 2024-04-16T13:27:19 Manual roll VK-GL-CTS from 491cfc2dbec9 to b529676d0523 (1 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/491cfc2dbec9..b529676d0523 2024-03-29 yuxinhu@google.com Move external/openglcts/data into a new subdirectory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I5e07217cca190ec243f1b700348cde0384dbf052 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5457892 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e344c4bc 2024-04-16T13:48:04 Manual roll VK-GL-CTS from 393ca590ec21 to 491cfc2dbec9 (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/393ca590ec21..491cfc2dbec9 2024-03-29 lorenzo@khronosgroup.org Limit Vulkan validation layers compilation to Linux and Android 2024-03-29 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-03-29 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-03-29 gleese@broadcom.com Remove deIsInf, deIsNaN and variants 2024-03-29 gleese@broadcom.com Stop generating (some?) empty test groups 2024-03-29 lionel.g.landwerlin@intel.com Fix protected memory allocations with unprotected buffers 2024-03-29 yuxinhu@google.com Add a new Android Activity that exports ES32 Test Run Params 2024-03-29 yuxinhu@google.com Add scripts to generate Android bp for compiling both dEQP and KHR GLES tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: Ida602870bf73d362b3b82dab003c78626e825321 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5459013 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 1264c9cc 2024-04-16T13:22:16 Manual roll VK-GL-CTS from caf989d22e07 to 393ca590ec21 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/caf989d22e07..393ca590ec21 2024-03-29 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (transform_feedback3), PART 4 2024-03-29 marcin.zajac@mobica.com Test depth with VK_EXT_fragment_density_map 2024-03-29 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-03-28 skr@nvidia.com Consider layer index when retrieving decoded frame 2024-03-26 rgarcia@igalia.com Share test configuration between case and instance in EDS tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I562b77d2dab2e949a2562c1bb0e655e1ed8bb5df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5459012 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 97cb3eb8 2024-04-16T10:25:49 Split ASSERT and logs into separate header This is because SimpleMutex.h wants to ASSERT, which was defined in debug.h. That file has a function that returns a reference to a mutex that would eventually be changed to SimpleMutex. The circular dependency cannot be resolved with a forward declaration with SimpleMutex being defined with `using`. Bug: angleproject:8667 Change-Id: I9a3acb6d07c6702048b47a72d8411b0fc2166922 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5458631 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d9d583bf 2024-04-15T00:24:47 Implement a lock/unlock-only mutex based on futex Pthread mutexes are expensive due to their numerous features. When a mutex only needs to support lock and unlock, its implementation can be much simpler. The implementation in this change is "inspired" by a similar mutex in mesa. Expected uses of this mutex are: - Allowing some OpenGL calls to avoid the share group lock and instead lock the specific shared object they operate on. - Replacing SpinLock in the OpenCL implementation (spin-lock in user space is a bad idea [1]) - Generally anywhere we use std::mutex just to do lock/unlock Tests based on patch authored by Igor Nazarov <i.nazarov@samsung.com> [1]:https://www.realworldtech.com/forum/?threadid=189711&curpostid=189723 Bug: angleproject:8667 Change-Id: I52278c9d19616338c499bbcef6684746caead6ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5446558 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 0c5f973d 2024-04-16T10:01:56 Roll vulkan-deps from ec0c320a8ca1 to 8dc5cb57074c (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ec0c320a8ca1..8dc5cb57074c Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2db79056b4..05ba15169e * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/77d1f98036..6d9e995cb6 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d14404b26e..9fc3b7bfac * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/72696f2782..a78460f66b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d89ce7ad87..c64f16a640 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I74dfb724815b76ba76e3bccd077c5f01442cce80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5455455 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cfcfc9ea 2024-04-16T10:01:42 Roll SwiftShader from 62c59c41e194 to 1eaac56def92 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/62c59c41e194..1eaac56def92 2024-04-15 alex@alexrp.com Fix some build issues on Windows Arm64. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I68045aca1f17423dfafd37a1edcee2a74f4ebb77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5457238 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2a294103 2024-04-16T07:01:22 Roll Chromium from 3405d3e2c23c to 0abb3a90f21c (691 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3405d3e2c23c..0abb3a90f21c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/861d460c5d..87207dd445 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0d108157e1..e70dca1b50 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/88367fd8c7..12e53bce03 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/495b23b39a..22de5fb717 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/932d253fed..51fe358446 * third_party/turbine: wWCZ6axEx90bs9sDY6jPFmdmO-FZfbp9nWunhqrozoIC..agNIST7gEMTmrnvQLPzx2dduGa52uMmOx3fEWm9z5MEC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/5f31812eda..84f141bb4e * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/c6d669e138..2448d81f97 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c3ff5bb6a9..bcadedd547 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I8b7524ba2f6398fc8c5a5754c1165e571b62b13e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5455454 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Matthew Denton 6557da03 2024-03-22T05:49:59 Implement TextureWgpu::getAttachmentRenderTarget() Most of this is copied from TextureVk::getAttachmentRenderTarget() with parts removed to make it simpler to start. Need to check what happens when running a clear test. Bug: angleproject:8582 Change-Id: Ia3b1f057add7714c7b192af1a3bf0edb41ccb649 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5388077 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 50d95bfe 2024-04-15T19:37:04 Manual roll vulkan-deps from 3ba43743089e to ec0c320a8ca1 (34 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/3ba43743089e..ec0c320a8ca1 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/8a3ea594c7..2db79056b4 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ade1f7cfd7..2904985aee * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/cfebfc96b2..1e7b8a6d03 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/2cb930f7f7..77d1f98036 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c5da01ee0a..d14404b26e * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/0519e66f42..72696f2782 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/dc9a7170f2..d89ce7ad87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I028b7c0497a345465bfef86c2a58682f230ee864 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5455451 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Liza Burakova 041b0a4d 2024-04-15T13:42:17 Begin initializing caps for webgpu Bug: angleproject:8457 Change-Id: Idde0673297ec675a13bd3e4fd4d220ec47392153 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5391987 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Liza Burakova 2218db2b 2024-04-10T13:41:17 Add error callback for webgpu device Bug: angleproject:8547 Change-Id: I9946311a1f93cc5f49fb0e17e65c92789bdb3b6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5443428 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi f4d3041a 2024-04-13T22:37:11 Remove double-serialization for glGetProgramBinary The applications get the binary length first, and then get the binary itself. Prior to this change, ANGLE was serializing the program binary twice. What's more, if the blob cache is enabled, ANGLE serialized the program binary yet another time for that. With this change, the program binary is serialized only once. If the application queries the program binary, serialization is done the first time needed, is cached and then discarded as soon as the binary itself is returned. Bug: angleproject:7393 Change-Id: If6e3011097ca4d4a1cdcd2dcc23496901196d999 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5448090 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 24ba48eb 2024-04-13T23:07:11 Do not cache program binary in blob cache redundantly with app If the application has specified the GL_PROGRAM_BINARY_RETRIEVABLE_HINT hint, let the application itself cache the program binary and skip ANGLE's implicit caching. This saves time in serializing the binary, and memory and disk space storing these binaries. If the application sets the hint, but does not actually restore the binary, they will suffer instead. This change also adds a perf warning for applications that retrieve the binary without setting this hint. Bug: angleproject:7393 Change-Id: I05aa880a31fa2fbbd61447c257c990a57137e1e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5448089 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 99ac37cf 2024-04-15T09:38:07 Vulkan: Suppress VUID-VkSwapchainCreateInfoKHR-pNext-07781 Only failing on windows x86. Unknown if ANGLE bug, VVL bug, or an inherently racy check as it happens only in the window resize tests. Bug: angleproject:8668 Change-Id: I0f928883647a4dc701d58e2df99e647e1397c773 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5453692 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 49e434db 2024-04-15T07:00:10 Roll Chromium from f4477677b54e to 3405d3e2c23c (816 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f4477677b54e..3405d3e2c23c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ab58dcc10c..861d460c5d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/56a59ba627..495b23b39a * third_party/fuchsia-sdk/sdk: version:20.20240404.3.1..version:20.20240412.2.1 * third_party/r8: mAYyilKWner49rPgknc41cEwNY3tx1ZLz7iQcNPl8aQC..4lmbDFBqkP3D6DWu4MC8eiktQ4wuHyTMVJIWoU_q30AC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6a278682b5..c3ff5bb6a9 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I0d3a7dd13c551649ae0e7b6cb3eb8558a1db4632 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5452939 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao e229afad 2024-04-12T16:15:42 Vulkan: Disable setting_sync_queue_submit In this CL we basically ignored all SyncVal errors from VkQueueSubmit. https://chromium-review.googlesource.com/c/angle/angle/+/5137081 But this validation is still enabled. This validation is super slow right now (tracked by https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/7285). There is no need to waset bots time to do this validation and then ignore its result. Bug: b/316013423 Bug: b/334183919 Change-Id: I1f6c53f484c088e684d2686422f33539b31b8b7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5450955 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 08d9d5cc 2024-04-12T16:04:34 Vulkan: VK_EXT_validation_features was deprecated and is replaced with VK_EXT_layer_settings. This allows all VVL settings to be controlled programmatically. See more detail in https://vulkan.lunarg.com/doc/sdk/1.3.280.0/windows/khronos_validation_layer.html Bug: angleproject:5290 Bug: b/334183919 Change-Id: I7dce52711260ee874bbd70bc0d351e5aa840dffa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5450954 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0