kc3-lang/angle

Log

Author Commit Date CI Message
Geoff Lang ab0140b0 2024-04-25T10:23:51 Update CLA contact information in the documentation. Bug: angleproject:0 Change-Id: Iefc4527fd6ddf79e319cef8ff8a92a791fb47547 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5489679 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll d0a2525d 2024-04-25T10:01:54 Roll vulkan-deps from 8ff7d8bf1899 to a4bf9c4e9ffd (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8ff7d8bf1899..a4bf9c4e9ffd Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/e94cd2e354..fa3b7bdefa * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a9ec5ff430..17c8bcb0e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ia413312da0d33be24caf5b1c06a2fe9d1808ccda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5487461 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 75c14ed6 2024-04-25T07:01:10 Roll Chromium from 3bff690c506f to 0543b5c427ca (360 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3bff690c506f..0543b5c427ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f7bf3dec53..a1bcbf3070 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d5da953756..89090fdbd1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/48216439d9..01d7072ad6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3d170cb6ce..fb94001f06 * third_party/siso: git_revision:366e623c64429778827e021672a260553c7bd068..git_revision:70d9e16bcc9dff0264905018f5a5652b37ed0e10 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c05ed83254..0aaac4902f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/918fef0e46..880331b699 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3f41393fee..36708f2aa1 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ib3ffe0b0fdb0e569faa9099839b2ccfc818084d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5484713 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jose Dapena Paz 47fc356b 2024-04-09T11:20:07 GCC: move warm up tasks out of anonymous namespace GCC anonymous namespace is set per file. So forward declaring in the anonymous namespace of .h will not be valid in the .cpp file. Bug: chromium:40565911 Change-Id: I10bd94f035761602d69e59a94dfde5dc774a6776 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5475346 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 9c2632b3 2024-04-24T16:54:27 Manual roll Chromium from 4433c533fffb to 3bff690c506f (214 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/4433c533fffb..3bff690c506f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cd430bd4b2..f7bf3dec53 * buildtools/linux64: git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25..git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789 * buildtools/mac: git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25..git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789 * buildtools/win: git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25..git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3070e96403..d5da953756 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ca84904bdc..2c1ad970da * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/277a3849eb..c05ed83254 Clang version changed llvmorg-19-init-8091-gab037c4f:llvmorg-19-init-8943-gd8503a38 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/277a3849ebe4f41beb773614cc4bad839870cfcf..c05ed83254645402a98ed838a2fe98cc1bf67fb2/scripts/update.py Bug: None Tbr: ynovikov@google.com Change-Id: Ic28626e4ae751a408feaffafabc0ebc213684693 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5483590 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov a4439599 2024-04-24T14:49:14 End Win Intel experiment. Bug: chromium:41496254 Change-Id: I0385d8f9840341cfad979f0fbee181f6eb0013ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5483086 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Charlie Lao d2e5eeef 2024-04-23T17:47:03 Vulkan: UNASSIGNED-CoreValidation-DrawState-InvalidImageLayout Supress the above VVL error. What happened is that the test creates a single buffer context. Since it only has one buffer for both render and present, we always immediately put it in VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR. Then when we render to it, we got the above VVL error. According to vulkan spec 6) What should the layout of the shared presentable image be? RESOLVED: After acquiring the shared presentable image, the application must transition it to the VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR layout prior to it being used. After this initial transition, any image usage that was requested during swapchain creation can be performed on the image without layout transitions being performed. And we always include VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT usage flags when creating swapchain images, so this should be okay. Bug: b/336652255 Change-Id: I8a04f94c9a7b6dcc1818697f45630cb0a6ee8811 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5479840 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0e7d735b 2024-04-24T10:01:38 Roll SwiftShader from 9aec4b969291 to 76f7f8cfea80 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/9aec4b969291..76f7f8cfea80 2024-04-23 wangqing-hf@loongson.cn llvm-16.0: Remove build dependencies for <valgrind/valgrind.h>. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I383ccffa6a733f8daa557edde02f41a01362561c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5482031 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b8e7860f 2024-04-24T07:00:56 Roll Chromium from b00758dcbb7a to 4433c533fffb (891 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b00758dcbb7a..4433c533fffb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c7d168ab6d..cd430bd4b2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fdc7df36c5..3070e96403 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a64dd87cec..ca84904bdc * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e939ac77bb..48216439d9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/917a57459b..3d170cb6ce * third_party/r8: jiR3Cmr6zLjEDaMOALv35_EoVDJbl5Mdza1IRQLevjAC..mhSwabeiU2ueQeYkj0X1JTg-6ZdtQgiVVXM1bo0yu4IC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/628a8e6856..e8280e634c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bca0c9f60a..277a3849eb * tools/skia_goldctl/linux: SQswrvGi674ASEtZKS6NGrcxzcOAx9fdEvxSUwNCVkIC..ZpyLtfuztdYI-RCkvm6kXlmx8ec1wYyrwXNI-lQEJKwC * tools/skia_goldctl/mac_amd64: vuB-Klm2s3uWsshi6g4r4l4fZox0RrWCgtSRKTxev3QC..FpwpXsMPl8Mets8uet3zfFw8nNBpl69xJoTYESLUjl8C * tools/skia_goldctl/mac_arm64: sqWmO8LOK7GgLCYuZo_PWkn6BcuBSgv16TPYoV44QUsC..GuJOsvx5V5z8DvAM_HOVy6eBydQ0sO7dVso_p_L7KTgC * tools/skia_goldctl/win: 4Y2pcWzsEQOJJ76XA1eaNSwef4YuyOrnQ-lSK1-71PkC..LT6gNudC207ke0t4qv9IW_s27hoPIafnwpcfrzR8FzMC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I06abb5fe90d122d9f444db12b73b25fc49d6d371 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5481531 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d4519fdc 2024-04-24T10:01:37 Roll vulkan-deps from 91b20c9cf5fd to 8ff7d8bf1899 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/91b20c9cf5fd..8ff7d8bf1899 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b9b8fd917b..b5672e8e8d * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/4f7b471f1a..5e3ad389ee * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8e5a28304e..a9ec5ff430 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I2ca5e6aecc37b4e99dd70d8b1995e037567d1b76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5481612 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao c74d2634 2024-04-19T12:19:51 Vulkan: Update mSurfaceCaps with per-present mode caps. Vulkan spec says "The per-present mode image counts may be less-than or greater-than the image counts returned when VkSurfacePresentModeEXT is not provided". Riht now we are using the generic surfaceCaps information which has smaller minImageCount. This triggers VVL error VUID-VkSwapchainCreateInfoKHR-presentMode-02839.. This CL updates mSurfaceCaps and mMinImageCount with per-present mode caps and create swapChain with proper minImageCount. Bug: angleproject:8672 Change-Id: I6061d2db8e98032dcb2c3225f2976013a99336a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5467850 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Yuly Novikov 94179bed 2024-04-23T13:57:45 Roll chromium_revision 39c16b7a37..b00758dcbb (1290535:1290830) Update scripts/roll_chromium_deps.py to ignore GCS DEPS entries. Change log: https://chromium.googlesource.com/chromium/src/+log/39c16b7a37..b00758dcbb Full diff: https://chromium.googlesource.com/chromium/src/+/39c16b7a37..b00758dcbb Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f381a5d258..c7d168ab6d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5eb927f0a9..571c37f17d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/844489d5bf..fdc7df36c5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6ba67afd6f..917a57459b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/31ab5f9786..628a8e6856 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e0d0c28dbe..bca0c9f60a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8f37fed0b7..918fef0e46 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8bf48ae269..3f41393fee DEPS diff: https://chromium.googlesource.com/chromium/src/+/39c16b7a37..b00758dcbb/DEPS No update to Clang. Bug: b/328065301 Change-Id: Ied690fe00ca0f82d4c5e17092ea96a6bc0f9b7d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5476868 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0d1dab2c 2024-04-23T10:01:16 Roll vulkan-deps from 36da75a01950 to 91b20c9cf5fd (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/36da75a01950..91b20c9cf5fd Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/68df223056..b9b8fd917b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dadb3012d5..dd4b663e13 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f0c17604ed..e94cd2e354 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/12f7fa5ed7..8e5a28304e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: If4ebc7d3360ad898df44ea79f71f567aa3bea468 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5475603 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 6fe8a399 2024-04-22T18:11:30 Metal: Fix rewritten out variables with underscores Fix compilation in case of output variables start with underscores. Make name emission always emit MSL name ANGLE_{name}, so that GLSL `_e` and `e` cannot clash. This regressed in angleproject:8558. Bug: chromium:335744344 Change-Id: Ibae4dba4a24888acc1461582e69d48218ba11176 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5473412 Reviewed-by: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Charlie Lao 2905a6a6 2024-04-19T15:09:41 Vulkan: Fix read pixel to cached non-coherent memory The bug here is that when we use cached non-coherent memory for image read, we must wait until DMA to finish before calling invalidate(). Otherwise CPU pre-fetching might end up populate the cache line again with old data between invalidate and DMA and causes CPU reads get the stale data from cache. This CL moves invalidate() call after we wait for copy to finish and removes requireCachedBitForStagingBuffer feature flag. Bug: b/335937565 Bug: b/315836169 Bug: b/324953979 Change-Id: Ie8a1854e17a5fe9c534c5102b2e0d51bd35c131a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5468597 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 64e97940 2024-04-22T11:41:05 Presubmit: improve bug tag check message * list acceptable options regardless of failure type * add a note when multiple Change-Id tags are detected (this can happen, for example, in case of chained CLs) * add extra info to the same error instead of adding it as another error Example output: ** Presubmit ERRORS: 1 ** Please ensure that your description contains Bug: bugtag directly above the Change-Id tag (no empty line in-between) Acceptable bugtags: project:bugnumber - where project is one of (angleproject, chromium, dawn, fuchsia, skia, swiftshader, tint) b/bugnumber - for Buganizer/IssueTracker bugs None - for minor changes with full context in description Bug: None Change-Id: I9b5fc5db2896bfd332570fa78ba67bd622cd876e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5472983 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 219f7762 2024-04-22T10:01:16 Roll vulkan-deps from 4737535cad1a to 36da75a01950 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4737535cad1a..36da75a01950 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c684aed192..f0c17604ed * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/bfdd09240f..9aec60c387 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/d0670f9ff0..d0ffc68fe7 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d1316e5423..12f7fa5ed7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ic374bc06225366e1a52b8a61ecbdaf1b5e73632b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5472162 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 40c6ba52 2024-04-22T08:01:46 Roll VK-GL-CTS from 669273b1098a to 17c6e3c4dfad (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/669273b1098a..17c6e3c4dfad 2024-04-19 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-19 piotr.byszewski@mobica.com Create RT pipeline with empty pipeline layout 2024-04-19 rgarcia@igalia.com Test interaction between minSampleShading and dynamic sample counts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I571c9e0cbffbe76b24f1e064234b960b3dcecc43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5470274 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f2901ba7 2024-04-22T08:37:10 Roll Chromium from e191335efc2d to 39c16b7a3740 (747 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e191335efc2d..39c16b7a3740 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9d1f98961a..f381a5d258 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0d2ca4d99e..844489d5bf * third_party/android_build_tools/bundletool: XoK0RwIzanpFScg7dU_8th5zMvLgKvk7c_PmhZ5LSEQC..CaAT7TJbLQC0LVo1i2TXtaMjK4SZBQ33n-s6DcBbZfgC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1a61eb625d..6ba67afd6f * third_party/r8: XZtdTveVY7h3SeKbeq0RkkuR7_zt6EH_sKJDUDK08NAC..jiR3Cmr6zLjEDaMOALv35_EoVDJbl5Mdza1IRQLevjAC * third_party/siso: git_revision:44d2b8f5b840adf521bb4912ccac31848f6d1448..git_revision:366e623c64429778827e021672a260553c7bd068 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/10697c9ce8..31ab5f9786 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/591cd4bd88..e0d0c28dbe * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8a642fb36d..8f37fed0b7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3928518a52..8bf48ae269 No update to Clang. Bug: angleproject:7904 Tbr: ynovikov@google.com Change-Id: I5bf19bf376862453f4494f499d68542ca2211acf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5470909 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 36ae4553 2024-04-21T05:18:17 Vulkan: Remove unnecessary member from ProgramExecutableVk Bug: None Change-Id: I896cd67c0ca41d146d8f1cd5494404bbd30b8264 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5469555 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 23b8a833 2024-04-19T18:03:17 Suppress VUID-VkSwapchainCreateInfoKHR-presentMode-02839 Breaks experimental Pixel 6 Android U bot https://ci.chromium.org/ui/p/angle/builders/ci/android-arm64-exp-test/4979/overview Bug: angleproject:8672 Change-Id: I2968dd1ed4ed7e2bc636d762b6d1fb884733a264 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5466741 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 84b87373 2024-04-19T10:01:03 Roll vulkan-deps from aa20d192b8c4 to 4737535cad1a (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/aa20d192b8c4..4737535cad1a Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2904985aee..dadb3012d5 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/1e7b8a6d03..eaa319dade * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b11c199a3a..d1316e5423 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I60b146950090923f2ff6746ebc68035570b5861c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5466018 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f0f4edfc 2024-04-19T10:01:49 Roll SwiftShader from 764410d4d655 to 9aec4b969291 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/764410d4d655..9aec4b969291 2024-04-18 wangqing-hf@loongson.cn llvm-16.0: Fix some issues in Reactor/LLVMJIT for LoongArch. 2024-04-18 wangqing-hf@loongson.cn Reactor: loongarch64 is not supported in subzero. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I82139f4ec7fce382d2df9a9a164effc0e4b2a69f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5467950 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 602a6a9a 2024-04-19T07:19:09 Roll Chromium from b07526b70da5 to e191335efc2d (579 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b07526b70da5..e191335efc2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fc6b52cdab..9d1f98961a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d47dd4e908..0d2ca4d99e * third_party/android_build_tools/lint: kt0D0n2B3KP5Ptno-stWIuNnhvCfms_w-8iZrMgSS8sC..f5ptuXixKwddKw0rnCKuNjXY9E35_710E7SNxoOLNnMC * third_party/android_build_tools/manifest_merger: q4q38FXedJ-uNPtYpwR--VhUglwaiG95Nz1aNXyOL9gC..Xef4nLhp0rWWjXJXt9CTFjQF8S6qRduSY7LZCcJi48QC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6aaae85821..1a61eb625d * third_party/r8: vLrV1g3mole2jBVpiMB13SquCOCucEVK_ImpPqXYIR8C..XZtdTveVY7h3SeKbeq0RkkuR7_zt6EH_sKJDUDK08NAC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/78c03ab18c..591cd4bd88 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b31325ceb7..3928518a52 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Id9d00956eb0401958e6433b18eb3d9b7ec1139ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5466013 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand cc770518 2024-03-28T18:05:00 CL/VK: Implement flush & finish Bug: angleproject:8632 Change-Id: I139e463c0b1c947cee68e65c40503e52f01e988b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406615 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi c75b03ad 2024-04-18T16:09:48 Vulkan: Remove duplicated fallback entry in vk_format_map.json Bug: b/335496851 Change-Id: Id5fe805a15ae4fa4b09ffbf05fcf7b6d3d79b1ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5463921 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Austin Annestrand d4abe622 2024-04-03T17:46:38 CL/VK: Implement enqueue NDRangeKernel & Task Adding support for: clEnqueueNDRangeKernel clEnqueueTask Bug: angleproject:8631 Change-Id: If57002be3ea00a55215e89ca47ab8fe9a422c6e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406614 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 48132950 2024-04-17T17:05:07 Vulkan: Optimize DescriptorSetLayoutDesc layout Separate out immutable samplers into its own array so we can remove padding from PackedDescriptorSetBinding which reduces the size of that struct from 16 bytes to 4 bytes. Bug: angleproject:2462 Change-Id: I79d1ab584178202c9b7f34b0c7926edced4e21a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5464162 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 80c8b6f0 2024-04-17T10:06:45 Revert "Vulkan: Only enable DS dynamic state if there is DS attachment." This reverts commit 471b50407d7d1c22491d066df77060cb8b9b2f89. The reverted change does not correctly handle UtilsVk functions, leading to validation failures. UtilsVk could be made to not set dynamic state when the depth/stencil attachments are missing, but instead the change is reverted because: - The original issue that prompted this is easily fixable (and fixed in this change) - Disabling depth/stencil dynamic state is not necessarily a performance improvement; every time a pipeline in such a render pass is bound, the driver would have to make sure to no-op the relevant state change if static, which is also costly. Instead, dynamic state may need to be set only once in the entire render pass. Bug: b/223456677 Bug: b/315353258 Bug: angleproject:8242 Change-Id: I8282b87857d6b9285dbcf307c3c6ecf69df5fadb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5462079 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu d0b01c81 2024-04-17T14:40:10 Remove duplicated fallback entry in vk_format_table_autogen Bug: b/335496851 Change-Id: Iff6a095aaffac099779b093e02b1a818b510dc0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5464161 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov 4109a90e 2024-04-16T17:31:11 LinkedUniform: avoid frequent GLenum -> index conversion Certain functions such as getElementComponents() are frequently called in driver_overhead benchmark, causing repeated GLenum -> index conversion of the uniform type which shows up in profiling (driver_overhead_2 trace) Change LinkedUniform.pod.type to LinkedUniform.pod.typeIndex storing the UniformTypeInfo index with conversion helpers. Bug: b/335295728 Change-Id: Iae5cd58f4e2703589d23b8e52991fc4b97c5fb08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5458741 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 00fa9af9 2024-04-18T10:55:34 Disable the BasicNoOpMutex test It's flaky by nature, and the flake rate turned out to be much higher than anticipated (i.e. it cannot be ignored). Bug: b/335541479 Change-Id: Ic29c549aa761230e1d8aa8156c66e78aae939e53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5463920 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bruno BELANYI 7523c5df 2024-04-18T14:22:22 Make 'ANGLE_CAPTURE_OUT_DIR' doc clearer The `chmod` issue was something I experienced when trying to record an application recently. And making it explicit that `ANGLE_CAPTURE_OUT_DIR` (and its sibling `debug.angle.capture.out_dir`) support absolute path would probably have avoided that issue in the first place. Bug: angleproject:1944 Change-Id: Ia853be244a6884f5b77c01cc67b561cc2cb45443 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5465701 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Yuly Novikov 5f532b75 2024-04-18T09:19:23 Roll chromium_revision 0abb3a90f2..b07526b70d (1287851:1289209) Unpin abseil-cpp and related DEPS, since Mac Skia bots older than macOS 10.15 were removed, so ANGLE can update abseil-cpp now without breaking roll into Skia. Roll third_party/dawn/ 66f38fda8..ed2c7c713 (212 commits; 6 trivial rolls) https://dawn.googlesource.com/dawn.git/+log/66f38fda85fe..ed2c7c7133fd in order to fix build with updated Clang, https://dawn-review.googlesource.com/c/dawn/+/182582 Change log: https://chromium.googlesource.com/chromium/src/+log/0abb3a90f2..b07526b70d Full diff: https://chromium.googlesource.com/chromium/src/+/0abb3a90f2..b07526b70d Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fffc0b385f..fc6b52cdab * buildtools/linux64: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25 * buildtools/mac: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25 * buildtools/win: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/87207dd445..d47dd4e908 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b3ae305fd5..a64dd87cec * third_party/android_build_tools/manifest_merger: UiE3IQmTjQyDp6olH-K75Gup3wY_WezHKM9riMylXVcC..q4q38FXedJ-uNPtYpwR--VhUglwaiG95Nz1aNXyOL9gC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/12e53bce03..e939ac77bb * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/22de5fb717..6aaae85821 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/80307e66e7..e3b94d0e5b * third_party/r8: 4lmbDFBqkP3D6DWu4MC8eiktQ4wuHyTMVJIWoU_q30AC..vLrV1g3mole2jBVpiMB13SquCOCucEVK_ImpPqXYIR8C * third_party/siso: git_revision:437716714a744e272fabdf1377b8878ccac26b43..git_revision:44d2b8f5b840adf521bb4912ccac31848f6d1448 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/84f141bb4e..10697c9ce8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/279d79a374..78c03ab18c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bcadedd547..b31325ceb7 * tools/skia_goldctl/linux: ZpyLtfuztdYI-RCkvm6kXlmx8ec1wYyrwXNI-lQEJKwC..SQswrvGi674ASEtZKS6NGrcxzcOAx9fdEvxSUwNCVkIC * tools/skia_goldctl/mac_amd64: FpwpXsMPl8Mets8uet3zfFw8nNBpl69xJoTYESLUjl8C..vuB-Klm2s3uWsshi6g4r4l4fZox0RrWCgtSRKTxev3QC * tools/skia_goldctl/mac_arm64: GuJOsvx5V5z8DvAM_HOVy6eBydQ0sO7dVso_p_L7KTgC..sqWmO8LOK7GgLCYuZo_PWkn6BcuBSgv16TPYoV44QUsC * tools/skia_goldctl/win: LT6gNudC207ke0t4qv9IW_s27hoPIafnwpcfrzR8FzMC..4Y2pcWzsEQOJJ76XA1eaNSwef4YuyOrnQ-lSK1-71PkC DEPS diff: https://chromium.googlesource.com/chromium/src/+/0abb3a90f2..b07526b70d/DEPS Clang version changed llvmorg-19-init-2941-ga0b3dbaf:llvmorg-19-init-8091-gab037c4f Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/279d79a37479b4b12bb4c4c27d224fd8503fbee7..78c03ab18cb89612654b8faf957eb30635316466/scripts/update.py Bug: skia:330350366, angleproject:8555, angleproject:8474 Change-Id: I70d907d78339dac9a0c0e7c6b96819c5cd62aa9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5465699 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll f696652f 2024-04-18T10:01:19 Roll vulkan-deps from bb53ad5f34d9 to aa20d192b8c4 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bb53ad5f34d9..aa20d192b8c4 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/9001ec9aa5..68df223056 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/9fc3b7bfac..bfdd09240f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6bb4f91788..b11c199a3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I71968b8da27700f0f5a43d6b880446f1f2305065 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5464287 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 51c58003 2024-04-18T10:01:34 Roll SwiftShader from 1eaac56def92 to 764410d4d655 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/1eaac56def92..764410d4d655 2024-04-17 wangqing-hf@loongson.cn llvm-16.0: Add BUILD.gn for loongarch64. 2024-04-17 wangqing-hf@loongson.cn llvm-16.0: Add configs/common and configs/linux for loongarch64. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ifce61ed70ff6636afdde189b3a4f083a3b4313d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5465800 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 6861da63 2024-04-17T15:52:27 Vulkan: Don't cache staging buffers on PowerVR Seeing flakiness in simple tests. Narrowed it down to cached coherent memory. There is likely something ANGLE is doing wrong but broaden the workaround until it is root caused. Test: angle_end2end_tests Bug: b/315836169 Bug: b/324953979 Change-Id: I15e50781f746ffb24b0a12b1e28df04a3822b556 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5464283 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mohan Maiya b2aad1bb 2024-04-17T06:12:14 Vulkan: Track valid descriptor set layouts Instead of looping through kMaxDescriptorSetLayoutBindings in `DescriptorSetLayoutDesc::unpackBindings` track valid descriptor set layouts in `DescriptorSetLayoutDesc::update` Bug: angleproject:2462 Change-Id: I1ca2ba72875d9306b6059b14cde39c5d16250be6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5464160 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi d71b8ee0 2024-04-17T10:00:27 Vulkan: Fix dynamic depth/stencil in UtilsVk when unused Dynamic state still needs to be set even if depth/stencil test is disabled. Bug: angleproject:8151 Bug: b/323708819 Change-Id: Ic470fabd84c71b026152b6bee2e6a2c803514106 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5462059 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 313c73c3 2024-04-17T12:14:40 Roll vulkan-deps from 8dc5cb57074c to bb53ad5f34d9 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8dc5cb57074c..bb53ad5f34d9 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/05ba15169e..9001ec9aa5 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/6d9e995cb6..c684aed192 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/a78460f66b..d0670f9ff0 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c64f16a640..6bb4f91788 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I6be046ebb5ac2a6b57ca297fab9d9638c82413e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5457866 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 03c88d33 2024-04-17T03:03:17 Revert "Vulkan: Suppress VUID-VkSwapchainCreateInfoKHR-pNext-07781" This reverts commit 99ac37cf7bad44d43f0c18da0410bde1073b62ea. Reason for revert: Fixed upstream https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/7851 Original change's description: > Vulkan: Suppress VUID-VkSwapchainCreateInfoKHR-pNext-07781 > > Only failing on windows x86. Unknown if ANGLE bug, VVL bug, or an > inherently racy check as it happens only in the window resize tests. > > Bug: angleproject:8668 > Change-Id: I0f928883647a4dc701d58e2df99e647e1397c773 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5453692 > Reviewed-by: Roman Lavrov <romanl@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:8668 Change-Id: I8831b5011ed3a7f5bf48af25f8933d50b5c4e1ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5459521 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll c4880865 2024-04-16T22:54:12 Manual roll VK-GL-CTS from b529676d0523 to 669273b1098a (11 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b529676d0523..669273b1098a 2024-04-12 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-04-11 slawomir.cygan@intel.com Add fragment shading barycentric for mesh shading, interpolation and provoking vertices 2024-04-11 rgarcia@igalia.com Test occlusion queries with no attachments 2024-04-11 javed@igalia.com Add coverage for creating a 2D image view of a sparse 3D image. 2024-04-11 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-10 rgarcia@igalia.com Do not build VVL when using SELECTED_BUILD_TARGETS 2024-04-05 javed@igalia.com Add coverage for mutable descriptor type list being out of range. 2024-04-05 ziga@lunarg.com Add missing resolve image in rasterization tests with multisampling 2024-04-05 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-03 yuxinhu@google.com Add the instruction to run new ES32GetTestParamActivity 2024-04-03 slawomir.cygan@intel.com Add tests for clipping in mesh shading, with provoking vertices and multiview If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I511b15edb5750f2065da5b039ce5447a9f0d4689 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5458196 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi e92b8e8d 2024-04-16T13:27:19 Manual roll VK-GL-CTS from 491cfc2dbec9 to b529676d0523 (1 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/491cfc2dbec9..b529676d0523 2024-03-29 yuxinhu@google.com Move external/openglcts/data into a new subdirectory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I5e07217cca190ec243f1b700348cde0384dbf052 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5457892 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e344c4bc 2024-04-16T13:48:04 Manual roll VK-GL-CTS from 393ca590ec21 to 491cfc2dbec9 (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/393ca590ec21..491cfc2dbec9 2024-03-29 lorenzo@khronosgroup.org Limit Vulkan validation layers compilation to Linux and Android 2024-03-29 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-03-29 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-03-29 gleese@broadcom.com Remove deIsInf, deIsNaN and variants 2024-03-29 gleese@broadcom.com Stop generating (some?) empty test groups 2024-03-29 lionel.g.landwerlin@intel.com Fix protected memory allocations with unprotected buffers 2024-03-29 yuxinhu@google.com Add a new Android Activity that exports ES32 Test Run Params 2024-03-29 yuxinhu@google.com Add scripts to generate Android bp for compiling both dEQP and KHR GLES tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: Ida602870bf73d362b3b82dab003c78626e825321 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5459013 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 1264c9cc 2024-04-16T13:22:16 Manual roll VK-GL-CTS from caf989d22e07 to 393ca590ec21 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/caf989d22e07..393ca590ec21 2024-03-29 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (transform_feedback3), PART 4 2024-03-29 marcin.zajac@mobica.com Test depth with VK_EXT_fragment_density_map 2024-03-29 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-03-28 skr@nvidia.com Consider layer index when retrieving decoded frame 2024-03-26 rgarcia@igalia.com Share test configuration between case and instance in EDS tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I562b77d2dab2e949a2562c1bb0e655e1ed8bb5df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5459012 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 97cb3eb8 2024-04-16T10:25:49 Split ASSERT and logs into separate header This is because SimpleMutex.h wants to ASSERT, which was defined in debug.h. That file has a function that returns a reference to a mutex that would eventually be changed to SimpleMutex. The circular dependency cannot be resolved with a forward declaration with SimpleMutex being defined with `using`. Bug: angleproject:8667 Change-Id: I9a3acb6d07c6702048b47a72d8411b0fc2166922 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5458631 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d9d583bf 2024-04-15T00:24:47 Implement a lock/unlock-only mutex based on futex Pthread mutexes are expensive due to their numerous features. When a mutex only needs to support lock and unlock, its implementation can be much simpler. The implementation in this change is "inspired" by a similar mutex in mesa. Expected uses of this mutex are: - Allowing some OpenGL calls to avoid the share group lock and instead lock the specific shared object they operate on. - Replacing SpinLock in the OpenCL implementation (spin-lock in user space is a bad idea [1]) - Generally anywhere we use std::mutex just to do lock/unlock Tests based on patch authored by Igor Nazarov <i.nazarov@samsung.com> [1]:https://www.realworldtech.com/forum/?threadid=189711&curpostid=189723 Bug: angleproject:8667 Change-Id: I52278c9d19616338c499bbcef6684746caead6ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5446558 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 0c5f973d 2024-04-16T10:01:56 Roll vulkan-deps from ec0c320a8ca1 to 8dc5cb57074c (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ec0c320a8ca1..8dc5cb57074c Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2db79056b4..05ba15169e * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/77d1f98036..6d9e995cb6 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d14404b26e..9fc3b7bfac * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/72696f2782..a78460f66b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d89ce7ad87..c64f16a640 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I74dfb724815b76ba76e3bccd077c5f01442cce80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5455455 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cfcfc9ea 2024-04-16T10:01:42 Roll SwiftShader from 62c59c41e194 to 1eaac56def92 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/62c59c41e194..1eaac56def92 2024-04-15 alex@alexrp.com Fix some build issues on Windows Arm64. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I68045aca1f17423dfafd37a1edcee2a74f4ebb77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5457238 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2a294103 2024-04-16T07:01:22 Roll Chromium from 3405d3e2c23c to 0abb3a90f21c (691 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3405d3e2c23c..0abb3a90f21c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/861d460c5d..87207dd445 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0d108157e1..e70dca1b50 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/88367fd8c7..12e53bce03 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/495b23b39a..22de5fb717 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/932d253fed..51fe358446 * third_party/turbine: wWCZ6axEx90bs9sDY6jPFmdmO-FZfbp9nWunhqrozoIC..agNIST7gEMTmrnvQLPzx2dduGa52uMmOx3fEWm9z5MEC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/5f31812eda..84f141bb4e * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/c6d669e138..2448d81f97 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c3ff5bb6a9..bcadedd547 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I8b7524ba2f6398fc8c5a5754c1165e571b62b13e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5455454 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Matthew Denton 6557da03 2024-03-22T05:49:59 Implement TextureWgpu::getAttachmentRenderTarget() Most of this is copied from TextureVk::getAttachmentRenderTarget() with parts removed to make it simpler to start. Need to check what happens when running a clear test. Bug: angleproject:8582 Change-Id: Ia3b1f057add7714c7b192af1a3bf0edb41ccb649 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5388077 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 50d95bfe 2024-04-15T19:37:04 Manual roll vulkan-deps from 3ba43743089e to ec0c320a8ca1 (34 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/3ba43743089e..ec0c320a8ca1 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/8a3ea594c7..2db79056b4 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ade1f7cfd7..2904985aee * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/cfebfc96b2..1e7b8a6d03 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/2cb930f7f7..77d1f98036 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c5da01ee0a..d14404b26e * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/0519e66f42..72696f2782 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/dc9a7170f2..d89ce7ad87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I028b7c0497a345465bfef86c2a58682f230ee864 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5455451 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Liza Burakova 041b0a4d 2024-04-15T13:42:17 Begin initializing caps for webgpu Bug: angleproject:8457 Change-Id: Idde0673297ec675a13bd3e4fd4d220ec47392153 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5391987 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Liza Burakova 2218db2b 2024-04-10T13:41:17 Add error callback for webgpu device Bug: angleproject:8547 Change-Id: I9946311a1f93cc5f49fb0e17e65c92789bdb3b6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5443428 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi f4d3041a 2024-04-13T22:37:11 Remove double-serialization for glGetProgramBinary The applications get the binary length first, and then get the binary itself. Prior to this change, ANGLE was serializing the program binary twice. What's more, if the blob cache is enabled, ANGLE serialized the program binary yet another time for that. With this change, the program binary is serialized only once. If the application queries the program binary, serialization is done the first time needed, is cached and then discarded as soon as the binary itself is returned. Bug: angleproject:7393 Change-Id: If6e3011097ca4d4a1cdcd2dcc23496901196d999 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5448090 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 24ba48eb 2024-04-13T23:07:11 Do not cache program binary in blob cache redundantly with app If the application has specified the GL_PROGRAM_BINARY_RETRIEVABLE_HINT hint, let the application itself cache the program binary and skip ANGLE's implicit caching. This saves time in serializing the binary, and memory and disk space storing these binaries. If the application sets the hint, but does not actually restore the binary, they will suffer instead. This change also adds a perf warning for applications that retrieve the binary without setting this hint. Bug: angleproject:7393 Change-Id: I05aa880a31fa2fbbd61447c257c990a57137e1e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5448089 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 99ac37cf 2024-04-15T09:38:07 Vulkan: Suppress VUID-VkSwapchainCreateInfoKHR-pNext-07781 Only failing on windows x86. Unknown if ANGLE bug, VVL bug, or an inherently racy check as it happens only in the window resize tests. Bug: angleproject:8668 Change-Id: I0f928883647a4dc701d58e2df99e647e1397c773 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5453692 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 49e434db 2024-04-15T07:00:10 Roll Chromium from f4477677b54e to 3405d3e2c23c (816 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f4477677b54e..3405d3e2c23c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ab58dcc10c..861d460c5d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/56a59ba627..495b23b39a * third_party/fuchsia-sdk/sdk: version:20.20240404.3.1..version:20.20240412.2.1 * third_party/r8: mAYyilKWner49rPgknc41cEwNY3tx1ZLz7iQcNPl8aQC..4lmbDFBqkP3D6DWu4MC8eiktQ4wuHyTMVJIWoU_q30AC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6a278682b5..c3ff5bb6a9 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I0d3a7dd13c551649ae0e7b6cb3eb8558a1db4632 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5452939 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao e229afad 2024-04-12T16:15:42 Vulkan: Disable setting_sync_queue_submit In this CL we basically ignored all SyncVal errors from VkQueueSubmit. https://chromium-review.googlesource.com/c/angle/angle/+/5137081 But this validation is still enabled. This validation is super slow right now (tracked by https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/7285). There is no need to waset bots time to do this validation and then ignore its result. Bug: b/316013423 Bug: b/334183919 Change-Id: I1f6c53f484c088e684d2686422f33539b31b8b7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5450955 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 08d9d5cc 2024-04-12T16:04:34 Vulkan: VK_EXT_validation_features was deprecated and is replaced with VK_EXT_layer_settings. This allows all VVL settings to be controlled programmatically. See more detail in https://vulkan.lunarg.com/doc/sdk/1.3.280.0/windows/khronos_validation_layer.html Bug: angleproject:5290 Bug: b/334183919 Change-Id: I7dce52711260ee874bbd70bc0d351e5aa840dffa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5450954 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 67fc293a 2024-04-05T13:25:12 WebGPU: Add shader translation and program linking stubs. Add a TranslatorWGSL which outputs the same translated shaders every time. Implement the compile and link tasks. Bug: angleproject:8662 Change-Id: I62bbd6c528e1d671d0f4becc38f15f1eceb0336c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5428807 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Marius Kintel 5e790bfb 2024-04-11T14:58:58 Remove unnecessary D3D include Bug: b/329414677 Change-Id: If96e10f3762fe849485f52783565658889491c97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5444810 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang f4485224 2024-04-05T10:29:23 WebGPU: Implement glBufferData and glBufferSubData Define several usages for WebGPU buffers that map to wgpu buffer usage flags. Maintain a set of buffers by usage and a serial of the one with the most recent data. Defer creation of the buffer as long as possible to take advantage of the WebGPU mapAtCreation flag for data upload. If we ever have to unmap these buffers, staging buffers must be used to upload afterwards. Add some helpers for getting Device and Instance from a gl::Context. Bug: angleproject:8654 Change-Id: Ibb8147119af8a98738fc4d579830a02ccaa1d7c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5426813 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org>
Scott Marcy e088af30 2024-03-28T15:30:59 Parsing very long array declarations crash Avoid stack overflow crash when parsing arrays with a huge number of dimensions. Limits the number of array dimensions to `mMaxExpressionComplexity` (typically 256). Use `YYABORT` to abort parsing. Bug: angleproject:8610 Change-Id: Icf3914871b167c820b84ae8f3acba80dbd698af3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5424330 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 34bb0ebf 2024-04-12T07:45:08 Roll Chromium from 625a985b39f7 to f4477677b54e (679 revisions) https://chromium.googlesource.com/chromium/src.git/+log/625a985b39f7..f4477677b54e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5384d31f9e..5eb927f0a9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0829658117..ab58dcc10c * third_party/android_build_tools/lint: KDj5mDBFUzEQm9A0ycRaZZWiYR5SbJFZiuZx3t8Vc5cC..kt0D0n2B3KP5Ptno-stWIuNnhvCfms_w-8iZrMgSS8sC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/ffb5ee628c..0d108157e1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/24c482ad9c..88367fd8c7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7894b0d681..56a59ba627 * third_party/r8: a-chFQzHp-ekYJLRLkCL8KMcrUwsI7IYmdj7Lh6I-wUC..mAYyilKWner49rPgknc41cEwNY3tx1ZLz7iQcNPl8aQC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ee3bdb9f82..6a278682b5 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I4dd92848341fca8de2a5c9b4eaf259dfa6ce541e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5449064 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 1152f9d1 2024-04-10T22:05:35 Remove PPO as observer of its own executable No messages from PPOs observer come to the PPO for processing anymore. All messages come from the attached programs. Bug: angleproject:4559 Bug: angleproject:6358 Change-Id: I55a6884d843655c4dfabd33ea370c61ec27183d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5444726 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1153a17e 2024-04-11T08:24:23 Roll Chromium from 3e1171173a70 to 625a985b39f7 (729 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3e1171173a70..625a985b39f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/aaab0bb753..5384d31f9e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/eb52dfd13f..0829658117 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6e7b54bc42..24c482ad9c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eea30870b8..7894b0d681 * third_party/r8: bq7w2bmLhe4u4VCiCliPuhaupJB-lu2mW9gr5dB16ekC..a-chFQzHp-ekYJLRLkCL8KMcrUwsI7IYmdj7Lh6I-wUC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/77cdbae19b..5f31812eda * tools/luci-go: git_revision:06dc7a1f2eeb1d095f7876799458328a44438df1..git_revision:239be4fd8499df782db6bddb0f55832bf4f01307 * tools/luci-go: git_revision:06dc7a1f2eeb1d095f7876799458328a44438df1..git_revision:239be4fd8499df782db6bddb0f55832bf4f01307 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3b4680b3b6..ee3bdb9f82 * tools/skia_goldctl/linux: rNawAlFBeJd8sJp4qBBL82OcdNnUmP3v9ZVqfNoTF00C..ZpyLtfuztdYI-RCkvm6kXlmx8ec1wYyrwXNI-lQEJKwC * tools/skia_goldctl/mac_amd64: j7toaABq50u3jos-EDWtdQTMWqfL13NLW195Lym7izsC..FpwpXsMPl8Mets8uet3zfFw8nNBpl69xJoTYESLUjl8C * tools/skia_goldctl/mac_arm64: lQQEKOiiJjPAeU5wKrwdMSD06O3bDT823qka8hjN0JcC..GuJOsvx5V5z8DvAM_HOVy6eBydQ0sO7dVso_p_L7KTgC * tools/skia_goldctl/win: nwSzcEIJ0Hmc8k_W7vcYqs0KW88pnufM8vXJfkbm8dEC..LT6gNudC207ke0t4qv9IW_s27hoPIafnwpcfrzR8FzMC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ib26477a03baf07e8f41c16556213ca10e8e0a20a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5447046 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi e41286e1 2024-04-10T11:05:09 Vulkan: Fix internal caching missing Since the backend wait for post-link tasks was made possible [1], the front-end may never get a chance to internally cache its binary. This is because the decision to cache the binary was based on the existence of post-link tasks, and the backend clearing that list made the front-end confused. In this change, a specific bool tracks whether binary is cached, and that is checked at various times to make sure the binary cache is eventually done. [1]:https://chromium-review.googlesource.com/c/angle/angle/+/5427001 Bug: angleproject:8297 Change-Id: Iceefd0bca79d570d4910983be3660d6e725684a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5445484 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi bc53f360 2024-04-10T16:08:23 Vulkan: Improve pipeline warmup hit rate without GPL When VK_EXT_graphics_pipeline_library is not in use, warmup would practically always hit a perf warning about it mismatching the graphics desc of the current draw call. This is because the color mask is not set appropriately, which is what this change does. Bug: angleproject:8297 Change-Id: Ie84660e493baf4370c09f43d50d57fc911bd1390 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5445483 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d9943e44 2024-04-09T23:53:48 Remove Program::syncState The last bit of responsibility still left in Program::syncState was to wait for post-link tasks for the sake of EGLBlobCacheTest tests. A new extension, GL_ANGLE_program_binary_readiness_query is created so that the wait can be done in the test itself. This extension is ultimately useful for applications as well, so they can avoid blocking the CPU by calling glGetProgramBinary prematurely. Bug: angleproject:8297 Change-Id: Ied6b755cb9b060198f82c7948bfd03441435a578 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5440302 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Mohan Maiya c1397510 2024-04-07T21:05:34 Vulkan: Fix data race in WarmUpGraphicsTask std::unordered_map doesn't support simultaneous read and write. Cache placeholder PipelineHelper in WarmUpGraphicsTask and std::move the newly created PipelineHelper when warm up is complete. Bug: angleproject:8297 Change-Id: I1cc4b3cd48147d0080666d5669d61de006c2252d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5431830 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 392eca60 2024-04-10T15:36:07 Revert "GL: Support KHR_blend_equation_advanced" This reverts commit c632fae01ced6712d31c4665288eb306a980fb10. Reason for revert: Crashes on a few different devices. Bug: chromium:40277080, chromium:333443447 Original change's description: > GL: Support KHR_blend_equation_advanced > > Combine blend equation setting when they are equal. It is invalid to > set advanced blend equations for color/alpha separately. > > Emit blend equation layout qualifiers. > > Bug: angleproject:8660 > Change-Id: I1d8a88594c80027b564eed70d3b540e0b065968d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5415033 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Bug: angleproject:8660 Change-Id: I27ac64c7343831e42f5412d6c17facd0de8cd9e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5443404 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 4af8dafb 2024-03-10T20:14:18 Vulkan: Enable MSRTT emulation tests on swiftshader Bug: b/309355117 Change-Id: I2d842bc52f9b6af340025654111dfd3f8e9c58a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5359654 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll bedc75d9 2024-04-10T07:00:37 Roll Chromium from 8853d900c3dd to 3e1171173a70 (343 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8853d900c3dd..3e1171173a70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8919328651..aaab0bb753 * buildtools/linux64: git_revision:f07499aebcf5b1b8f09f27f705e1b6e463ecdba1..git_revision:d823fd85da3fb83146f734377da454473b93a2b2 * buildtools/mac: git_revision:f07499aebcf5b1b8f09f27f705e1b6e463ecdba1..git_revision:d823fd85da3fb83146f734377da454473b93a2b2 * buildtools/reclient: re_client_version:0.134.1.2c9285b-gomaip..re_client_version:0.138.0.e854224-gomaip * buildtools/win: git_revision:f07499aebcf5b1b8f09f27f705e1b6e463ecdba1..git_revision:d823fd85da3fb83146f734377da454473b93a2b2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/46e070f755..eb52dfd13f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0b9e7b8830..6e7b54bc42 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f85dd800c7..eea30870b8 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d076d8bd08..7d77fb7fd6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/743467d32a..3b4680b3b6 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I89ed90d790c98a690e2ba0c7d908c77d28172392 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5442672 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya d1bffdb6 2024-04-09T08:22:18 Vulkan: Bugfix in WarmUpComputeTask 1. An early return caused compute warm up tasks to not be scheduled 2. There are usecases where a program is marked separable post-link. Perform waitForPostLinkTasksImpl unconditionally during save(...) Bug: angleproject:8297 Tests: ProgramBinaryES31Test.SeparableProgramLinkedUniforms* Change-Id: I499f397b938677b4fcdb486001e0a75e202aaf5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5439732 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 22644819 2024-04-09T18:23:31 Manual roll Chromium from a20bd3962f16 to 8853d900c3dd (278 revisions) Manual roll requested by bsheedy@google.com https://chromium.googlesource.com/chromium/src.git/+log/a20bd3962f16..8853d900c3dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,bsheedy@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools/linux64: git_revision:415b3b19e094cd4b6982147693485df65037f942..git_revision:f07499aebcf5b1b8f09f27f705e1b6e463ecdba1 * buildtools/mac: git_revision:415b3b19e094cd4b6982147693485df65037f942..git_revision:f07499aebcf5b1b8f09f27f705e1b6e463ecdba1 * buildtools/win: git_revision:415b3b19e094cd4b6982147693485df65037f942..git_revision:f07499aebcf5b1b8f09f27f705e1b6e463ecdba1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5ec3f53855..46e070f755 * third_party/android_build_tools/manifest_merger: wtRWPCJVk_NA2GQp0fI-1i-JaPzYJwp6w3udjEhgni4C..UiE3IQmTjQyDp6olH-K75Gup3wY_WezHKM9riMylXVcC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d248c3571b..ffb5ee628c * third_party/kotlin_stdlib: 8ap4rwZkKWCv2SPYRERFhMf-wVSsLCAE3fAFe7smZsoC..E67atHdREsWLno-3b4Py3r87C4LB7gpVYDq3Q1z7t90C * third_party/r8: vS0S3VF_56MDd3mARnkGERRFeaUdiFZV5EkMkTUTZQIC..bq7w2bmLhe4u4VCiCliPuhaupJB-lu2mW9gr5dB16ekC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6ca0dfd477..743467d32a No update to Clang. Bug: None Tbr: geofflang@google.com,bsheedy@google.com Change-Id: I152436dc441b05801a6b425021c26f15603b1186 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5441013 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand 646f5d19 2024-04-03T15:28:40 CL/VK: Implement eventVk routines Adding routines: clGetEventInfo [CL_EVENT_COMMAND_EXECUTION_STATUS] clSetEventCallback clWaitForEvents [USER_EVENT_STATUS] We also trigger event callback on exec-status update. Bug: angleproject:8574 Change-Id: I470d9758de22a552bd9cf9565594b3049e21835d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5421575 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 0a67bbaf 2024-04-08T10:14:45 SPIR-V: Fix const constructors with single scalar These constructors may be generated because of RemoveArrayLengthTraverser. Bug: chromium:332546345 Change-Id: I5b81ded59ba91b0083b14280f5a61b03b9d4ca43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5435713 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 84613b97 2024-04-09T12:36:55 Vulkan: Suppress Undefined-Value-ShaderInputNotProduced If the app doesn't write to an attachment from the shader, it'll get undefined values. Bug: angleproject:8401 Change-Id: I60f2bf510f0f0f9779f00dafbeee3b7364283bf4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5440653 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Geoff Lang 0e19adb2 2024-04-08T13:21:09 Validate non-negative vertex attribute offsets. When robust buffer access is enabled, validat that buffers cannot be read with a negative index. Bug: chromium:323699974 Change-Id: I05beb72c60832ab4decbf16c47b3d92bd374286b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5435736 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Charlie Lao d3aaf795 2024-04-05T15:57:38 Vulkan: Early out ImageHelper::updateLayoutAndBarrier when possible If one image is attached to more than one attach points, when render pass closes we end up calling ImageHelper::updateLayoutAndBarrier multiple times. The first one is required since it does the layout transition etc. But the second call is unnecessarily inserting memory barriers. This is optimization itself, but will also fix the other bigger problem when we start using VkEvent instead of PipelineBarrier: we may end up waiting for an event that has not been set (since setEvent gets called after we end render pass but waitEvent is before render pass. Calling this sequence twice on the same image for the same render pass means second waitEvent is called before setEvent). Bug: b/333391804 Change-Id: Ic7b409c71806e63cb56c25e10b0bd0bfc9f6086d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5431033 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov e73c0c6d 2024-04-09T11:20:18 EGLProtectedContentTest: move sleep behind compile-time var Multiple tests with multiple steps wasting ~20s in automated runs Bug: b/333113001 Change-Id: I494f6e3ea373945ad79edbc23eb267dfef71ef87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5440412 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 126f8269 2024-04-05T22:00:02 Additional fix for link task worker pool race See [1] for context. While that change fixed the race condition, it was not great that the task held on to the worker pool for so long. This change avoids the race condition as well by releasing the worker pool as soon as the link task has no further use for it. [1]:https://chromium-review.googlesource.com/c/angle/angle/+/5428806 Bug: angleproject:8661 Change-Id: Ibcbad0afe518e649a63dfdf938bd566c8f80e368 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5431154 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll fda475e5 2024-04-09T10:01:30 Roll vulkan-deps from 4c9bdb52e642 to 3ba43743089e (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4c9bdb52e642..3ba43743089e Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c1ec8e0492..dc9a7170f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Id60d5e6b93cb41444e8bdf9554e00bda7fa3bfbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5434582 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll dd81a3df 2024-04-09T07:00:32 Roll Chromium from 0f9a02e29ab9 to a20bd3962f16 (586 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0f9a02e29ab9..a20bd3962f16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/665175f82f..5ec3f53855 * third_party/android_build_tools/lint: 2G2-Tyftl7Vi8AaG3FHYZHQcOL1_2nD5sNSKrVbN3O0C..KDj5mDBFUzEQm9A0ycRaZZWiYR5SbJFZiuZx3t8Vc5cC * third_party/clang-format/script: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git/+log/e5337933f2..3c0acd2d4e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/246580c7b8..f85dd800c7 * third_party/r8: p-D1sg3S51t1mFujFoZ07E0A98DNXPA2JvwF_2yXMjQC..vS0S3VF_56MDd3mARnkGERRFeaUdiFZV5EkMkTUTZQIC * third_party/siso: git_revision:3cec541372ec0556127a641d9c6e4a90d46ba1b8..git_revision:437716714a744e272fabdf1377b8878ccac26b43 * third_party/turbine: wdLjzY3JXKbaWmI4EB_0s8PaCDwCQzRrPZfPpXmamGUC..wWCZ6axEx90bs9sDY6jPFmdmO-FZfbp9nWunhqrozoIC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/59aa0524dc..6ca0dfd477 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I0fe4393d0610bb49cad214e93c01782faa9742bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5434581 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya ba208b45 2024-04-06T21:08:15 Vulkan: wait for post-link tasks in resetLayout Wait for post-link tasks before resetting ProgramExecutableVk. Otherwise mGraphicsProgramInfos, which post-link tasks use to create pipeline, can be prematurely invalidated. Bug: angleproject:8297 Tests: Texture2DTestES3YUV*DisableProgramCaching Change-Id: Ib84cebad252777ae4c37cb32c455c326911416a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5430927 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang c632fae0 2024-04-02T15:03:17 GL: Support KHR_blend_equation_advanced Combine blend equation setting when they are equal. It is invalid to set advanced blend equations for color/alpha separately. Emit blend equation layout qualifiers. Bug: angleproject:8660 Change-Id: I1d8a88594c80027b564eed70d3b540e0b065968d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5415033 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 92633457 2024-04-08T10:01:13 Roll vulkan-deps from 4f8c21f6ae9d to 4c9bdb52e642 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4f8c21f6ae9d..4c9bdb52e642 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/24f2cdad8e..ade1f7cfd7 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3492699f49..c1ec8e0492 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I71c6a00e97538fe18c485ff9d04c4ebfc10b99a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5431352 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bd822f29 2024-04-08T07:01:17 Roll Chromium from 87ec061ede78 to 0f9a02e29ab9 (736 revisions) https://chromium.googlesource.com/chromium/src.git/+log/87ec061ede78..0f9a02e29ab9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8df2ddae7c..665175f82f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6dc6690a96..0b9e7b8830 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f1098b6bfe..246580c7b8 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/da4c1b626a..4da68f31de * third_party/r8: AHRbRtHGM288ov0Xn4zb06FS39RLyC5lrNg4mBtQ8xMC..p-D1sg3S51t1mFujFoZ07E0A98DNXPA2JvwF_2yXMjQC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/0e58d440d6..d076d8bd08 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/ef7d05287c..77cdbae19b * tools/luci-go: git_revision:a84377ac0800e2330d02c3dcbf7b4b74a06d6a5b..git_revision:06dc7a1f2eeb1d095f7876799458328a44438df1 * tools/luci-go: git_revision:a84377ac0800e2330d02c3dcbf7b4b74a06d6a5b..git_revision:06dc7a1f2eeb1d095f7876799458328a44438df1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/416fed2499..8a642fb36d * tools/skia_goldctl/linux: -c3Xyfk44hE2J_zUzQNt1bIUIHf5kZ8FqgbE-pzM9Z4C..rNawAlFBeJd8sJp4qBBL82OcdNnUmP3v9ZVqfNoTF00C * tools/skia_goldctl/mac_amd64: PKeo3po--uNQ-GeRTWkE5PthiPZQGwRW1vSOgC8l86AC..j7toaABq50u3jos-EDWtdQTMWqfL13NLW195Lym7izsC * tools/skia_goldctl/mac_arm64: p9oWy9kXG4mSxYGunp3sZfxGN3B5zIUCuYDq8Dq_chgC..lQQEKOiiJjPAeU5wKrwdMSD06O3bDT823qka8hjN0JcC * tools/skia_goldctl/win: rh0cl_Ojif2FMLKYC_rxvrzwn11qPjj9d-wiqC62egAC..nwSzcEIJ0Hmc8k_W7vcYqs0KW88pnufM8vXJfkbm8dEC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I7886629a881d3b24770639b6ccc8fa0bf6890542 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5431349 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi d55464ff 2024-04-04T14:13:02 Vulkan: Remove the supportsDepthClipEnable feature This feature is unused since: https://chromium-review.googlesource.com/c/angle/angle/+/4545084 Bug: angleproject:3970 Change-Id: I78acfda80d4ae04d1387a452e9f52a55a4298a4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5426530 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 49e63e07 2024-04-03T13:22:30 Vulkan: Selectively wait for WarmUp tasks If the GraphicsPipelineDesc used by a draw call differs from the one being used by the WarmUp tasks there is no need to wait for their completion. Bug: angleproject:8297 Change-Id: Ibbf3ee710036936060990455bb8657d83c7b6faf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5421594 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Mohan Maiya ad13fec3 2024-03-30T15:31:49 Vulkan: warmUpGraphicsPipelineCache(...) shouldn't set state The prepareForWarmUpPipelineCache(...) method would have already setup all necessary state for the warm up task. Make that intent explicit by calling into a method that sets no state. Bug: angleproject:8297 Change-Id: I959d8591045ff05ddb2a410fd0e0eda8dd692d37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5408796 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 13829f20 2024-03-26T23:03:12 Vulkan: Optimize depth/stencil resolve with glBlitFramebuffer Like color resolve, depth/stencil resolve is now also possibly done by modifying the render pass and attaching a depth/stencil resolve attachment. Bug: angleproject:7551 Change-Id: I045e3875e24006d2473a55b6c3856dd768fe8b84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5398004 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 924b40dc 2024-04-04T18:44:21 Selectively wait for post-link tasks in the frontend The frontend waits for post-link tasks only for a relink or in syncState when `disableProgramCaching` feature is not enabled. Bug: angleproject:8297 Change-Id: If7a3b8a10a2d01f82fd2bebac5c8f378be56e19e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5427001 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 06472a7e 2024-04-04T21:07:02 Extend ProgramExecutableImpl API waitForPostLinkTasks(...) will be called into by the frontend. Backends can now choose to defer or avoid waiting for post-link tasks. Also, move warmUp task code to ProgramExecutableVk in the Vulkan backend Bug: angleproject:8297 Change-Id: Ia8a0682923e2f8c6287d62a606eed7f481cda08f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5427000 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 76636ddb 2024-04-04T15:39:08 CL/VK: Update missing reflection ops & DS creation Adding CLProgramVk routine to allocate DS. Also adding reflection parsing support for WGS IDs and PushConstantGlobalSize. Additionally, we now check VK implementation if non-semantic reflection data (in SPIR-V) is supported. If not, we strip that data from binary (via vk_feature check). Bug: angleproject:8631 Change-Id: Ife02867c7c30b919abf663865adc92858e1bff8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5421574 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Austin Annestrand 7a78c2c9 2024-04-03T14:32:35 CL/VK: Add helper to select LWS In the case where user passes NULL for LWS, the runtime has the responsibility to select an appropriate LWS for user. Bug: angleproject:8631 Change-Id: I89048c57880a5a4f18d4ef46340b73338cee933e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5421573 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Austin Annestrand 2dc9d0cd 2024-04-04T14:38:31 CL/VK: Add workgroup size/count types Replacing existing CompiledWorkgroupSize type with "WorkgroupSize" and "WorkgroupCount". (since CompiledWorkgroupSize == WorkgroupSize). Bug: angleproject:8631 Change-Id: I4094d10e6ad5db51a56ae92fe4f2fb4a6e72bdc7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5425447 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya ac654931 2024-04-04T15:42:47 ProgramExecutable manages post-link tasks Post-link tasks are now owned and managed by ProgramExecutable. Also, update `LinkTask::link` API so backends have a choice to populate either the linkSubTask or postLinkSubTask containers (but not both). Bug: angleproject:8297 Change-Id: I5dbed6a070efe851fc1376699e9eccd3a21bd03f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5406487 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov c0386ad4 2024-04-05T11:56:17 AsyncWorkerPool releases shared_ptr<Closure> before notifying Parallel compile (MainLinkLoadTask, Program::LinkingState) is dependent on destructor getting called before the event is notified Repro: https://crrev.com/c/5425924 More details on the parallel compile case, provided by syoussefi@: """ A race condition caused the worker pool to sometimes be destroyed from a worker thread instead of the main thread. The race condition triggered in the following scenario: - The MainLinkLoadTask holds on to the worker pool - This is necessary for the main task to spawn further tasks asynchronously - The reference to the worker pool in MainLinkLoadTask is released by its destructor - The worker thread dequeues a task (i.e. MainLinkLoadTask) to execute and holds a reference to it. - Once the task is run by the worker thread, the worker thread signals its completion - (1) At this point, the scope holding the reference to the task closes and the task is released. However, this is done after signaling the task's completion. - On program destruction, the program ensures that all its tasks are complete - This uses the signal coming from the worker thread - (2) On display destruction, the worker pool is destroyed (by dereferencing it through the shared_ptr) - The destructor of the worker pool waits for the worker thread, with the expectation that this wait is done in the main thread. The race condition led to the assert firing when (2) was done before (1). Because the task is already signaled complete, the main thread considers it done and goes ahead with the destruction of the display. However, until the scope of the worker thread closes, the task itself is still not destroyed. Since the task is holding a reference to the worker pool, that prevents the worker pool from getting destroyed too. Once the display is destroyed, the worker thread closes its scope, causing the task to be destroyed. In turn, this leads to the worker pool itself to be destroyed. On destruction, the worker pool would wait for the worker thread to end which is a deadlock. Fortunately, this was caught earlier with an ASSERT that wanted to ensure destruction happens on the main thread. In this change, the worker thread ensures it releases the task before signalling it complete, avoiding this issue. Other possible solutions would have been: - Release the worker pool from MainLinkLoadTask as soon as the subtasks are scheduled - Explicitly call a "destroy" method on the pool, instead of relying on the destructor to clean up. """ Bug: angleproject:8661 Change-Id: I37c9bc8e8f05bce4062d794df449cc3d2c80a093 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5428806 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
kmx.io     mail     discord kmxgit v0.4.0