|
96f66089
|
2024-03-19T14:08:04
|
|
Tests: Update color values for Unsized/Unsigned in texture tests
Some of the values don't make sense, appear to be copy/paste errors.
Likely pass on non-Android due to sizable error tolerance.
Also turn on float tests that just work.
Test: angle_end2end_tests --gtest_filter=Texture*Copy*/ES3_Vulkan
Bug: angleproject:4756
Bug: angleproject:8620
Change-Id: I3fffb7859421bc179e3e5dd6bca14b4e2ac378ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5381400
Reviewed-by: Roman Lavrov <romanl@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
f8b18577
|
2024-03-15T16:31:02
|
|
Set the Dawn proc addresses at in DisplayWgpu initialization
This allows the display to fully initialize and some tests to pass!
Bug: angleproject:8485
Change-Id: I83176c572793ba8a6992264e873f7d24d3698d35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372136
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
21ef298e
|
2024-03-13T11:06:22
|
|
Consider textures without an attached Buffer as incomplete
There are apps that perform a draw call using GL_TEXTURE_BUFFER
but without binding a valid buffer thus causing a crash. Instead
consider them as incomplete textures and fail validation checks.
Also, there is no need to explicitly track the buffer associated with
an incomplete buffer texture, the owning texture will handle cleanup.
Bug: b/328846669
Tests: TextureBufferTestES31.DrawIncomplete*
Tests: TextureBufferTestES31.DrawComplete*
Change-Id: Id0b68e8048ba582d677e6767272a86761913ea3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5369639
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
d4d34781
|
2024-03-14T13:03:55
|
|
Multisampling support check: sampleCounts > 1 and createFlags
At least two drivers are returning VK_SUCCESS from
vkGetPhysicalDeviceImageFormatProperties2
but also set sampleCounts to 1 which supposedly means no MSRTT
Qualcomm reference device driver fails vkCreateImageView
when enabling the multisampling bit one cubemaps which have
sampleCounts == 1
Additionally,
* include vk::GetMinimalImageCreateFlags() in createFlags - we don't get
the cubemap bit without that
* check both the image format and the additional view format
(linear+srgb) as we set both of these when creating the image
This fixes a bunch of cubemap and 3D tests on Qualcomm reference device
Bug: b/329286011
Change-Id: I6d3ddea0cd997cf37b503050063f42d69723bd50
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372826
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
a55f91b5
|
2024-03-05T16:36:49
|
|
Switch Pixel 6 experimental bot to Android U
Use-Permissive-Angle-Pixel-Comparison: True
Bug: chromium:41489949, angleproject:8598
Change-Id: Ibe0190f82dc82c1ef1699f2393c9459b2318d143
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5344713
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
1452c195
|
2024-03-04T22:03:21
|
|
Android: Add Qualcomm Mobile Reference Device support
Adreno based, Snapdragon 8 Gen3
Test: end2end, dEQP
Bug: b/328156792
Change-Id: I8cd47313fbd39f9f69a0eb4730bd2fbf92818d0f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5341381
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
b2773c11
|
2024-03-01T11:24:44
|
|
Vulkan: Bug fix in immutable sampler pipeline layout recreation
An immutable sampler is tied to a sampler index and changing sampler
uniform location value should force a recreation of the pipeline layout
Bug: b/155487768
Bug: angleproject:5033
Bug: angleproject:5773
Tests: Texture2DTestES3.TexStorage2DMultipleYuvSamplersSwitch*Vulkan
Change-Id: I82aaed332d7f87f11a2fd4923cfc004403ff0bd2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3657480
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
95294b24
|
2024-02-28T16:11:45
|
|
Android: Add Galaxy S22 support (Xclipse)
Test: angle_tests
Bug: b/267953710
Change-Id: I53ac424bce23a93fe980539f0946c04aeae6e91e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5333957
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
f4d5644c
|
2024-02-16T18:13:18
|
|
Instantiate dawn backend in angle_end2end_tests
Bug: angleproject:8485
Change-Id: I07a5c5c221c6b50b839929a824753a662aa163f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5286835
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Liza Burakova <liza@chromium.org>
|
|
b8e56d5d
|
2023-11-20T15:41:44
|
|
Fix an assert when overwriting TexImage binding
Fix an assert when overwriting a image binding with
multiple eglBindTexImage calls on the same texture.
Bug: angleproject:8521
Change-Id: Ie7247017fd73c523b889278ec19a09ecf0683692
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5272912
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
c70c329e
|
2024-01-31T15:59:19
|
|
Vulkan: Fix texture copy vs pre-rotation
A minor error where the destination offsets were swapped based on source
rotation.
Bug: b/319336510
Change-Id: I5541f8d0bf0b7306b951d2601c8c27ffedb8470e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5254238
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ecc35205
|
2024-01-25T23:58:25
|
|
Move uniform block dirty bits to State
When glUniformBlockBinding changes the mapping from a program uniform
block to a buffer binding, all contexts in the share group need to
reprocess the affected block index. Prior to this change, the dirty
bits that indicated which blocks have their mapping redefined were
placed in the program executable, and were reset by the first context
that processed them. As a result, the other contexts in the share group
where not aware of such modifications.
Similarly, when a buffer changed in one context, the mapped program
blocks were marked dirty, with similar cross-context issues.
In this change, the dirty bits are moved to State, so every context
would react to these changes.
Bug: angleproject:8493
Change-Id: I5712002224cbc4a576bf2ac46e8e75f26ebc5b2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5238991
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
0ea24ef2
|
2024-01-26T16:50:39
|
|
Unsuppress passing tests
Bug: angleproject:3871
Bug: angleproject:3872
Bug: angleproject:3879
Bug: angleproject:4686
Bug: angleproject:4704
Bug: angleproject:4718
Bug: angleproject:4721
Bug: angleproject:4792
Bug: angleproject:5086
Bug: angleproject:5313
Bug: angleproject:6109
Change-Id: I0d0f88a388cd2f19da99a7defd0ab8d98db0e6e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5241306
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
66de8492
|
2024-01-23T12:56:30
|
|
GL: Fix UBO binding mapping change
In the absence of any other state change, the GL backend did not bind
buffers (previously unused) that are used after a UBO binding mapping
change.
This also triggered assertion errors in the Vulkan backend.
Additionally, this change improves cross-context programs, though the
Vulkan backend is still affected by some bugs. A follow up change will
rework the dirty bits for this change to fix that.
Bug: angleproject:8493
Bug: b/318806125
Change-Id: I8f0ed4b5f666818f4fda9ec272c6b66419d64638
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5228599
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
81a43bd7
|
2024-01-23T17:15:54
|
|
Tests: skip TexelFetchLodOutOfBounds on SwS
Shabi says it might after SwS rolls into Chromium
But SwS is currently blocked by another issue
Bug: angleproject:8495
Change-Id: I2aba1d652e868de28b258e79c74d2bd252e41f86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5230142
Commit-Queue: Roman Lavrov <romanl@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
755372c8
|
2024-01-23T13:41:01
|
|
Tests: skip UniformUsageCombinations test on SwS
Failing on swangle builders: https://crrev.com/c/5228780
Bug: angleproject:5792
Change-Id: Id3cb22641b3b5a5ce1fee96f59111c6e48bc1742
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5228602
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
f43db42c
|
2024-01-17T15:18:41
|
|
Enable LogGles32Capabilities test for vulkan backend
Allow for LogGles32Capabilities test to no longer
be skipped for the vulkan backend.
Test: angle_end2end_tests.exe --gtest_filter=*PrintGLESCapabilities*
Bug: angleproject:4093
Change-Id: I1711f016f63fa58ce3521cc8d2a2e75f189fb877
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5214007
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3a33cbb0
|
2024-01-15T15:40:54
|
|
Test for making context current before surface creation
Support for this use-case is currently broken.
Bug: angleproject:8478
Change-Id: I62fa6b6ac4481e36ce488a4667aa7edb7ff35e33
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5200241
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
eedf3e9e
|
2024-01-12T00:00:00
|
|
Metal: Limit raster order groups workaround to affected GPUs
Do not enable renderPassNeedsAMDRasterOrderGroupsWorkaround
on GPUs that do not support raster order groups.
Bug: angleproject:8263
Change-Id: I94a22fce9dd7084f397d8d54d4f8e4d33baa3608
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5198688
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
c0dae760
|
2024-01-10T18:37:03
|
|
Wildcards instead of redundant API specification in expectations
The expectations already specify the API they relate to. As such,
specifying the API tag in the gtest name is redundant. For example, it
is preferred to specify:
1234 MAC OPENGL : Foo.Bar/* = SKIP
instead of:
1234 MAC OPENGL : Foo.Bar/ES2_OpenGL = SKIP
1234 MAC OPENGL : Foo.Bar/ES3_OpenGL = SKIP
This change also adds a presubmit to make sure the latter is not
reintroduced. The only possibly legitimate use case for being specific
about the test name is if only a variant of the test fails (such as
ES3_OpenGL_SomeWorkaround). Note that if the opposite is the case
(i.e. ES3_OpenGL fails, but ES3_OpenGL_SomeWorkaround passes), it's an
indication that the feature that made the test pass should have been
enabled by default.
Bug: angleproject:8465
Change-Id: I11476e36c83cbbeb8148b6e934c42ccd9b988de1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5185675
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
950d054a
|
2024-01-11T00:00:00
|
|
Metal: Do not defer global const initializers
Since MSL supports constant global variables, they should
not be included in the DeferGlobalInitializers operation.
This reduces temporary register usage and thus makes shaders
that use large const arrays more compatible with Apple GPUs.
Fixed: angleproject:8479
Change-Id: If1cd17a0a194173e60e6b5152297054fc384c0b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5189165
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
473dd389
|
2024-01-04T00:00:00
|
|
Metal: Fix out/inout parameter aliasing
Ensured that MSL-internal structs are included
in the parameter aliasing checks.
Fixed the following tests:
dEQP-GLES2.functional.shaders.function
.global_variable_aliasing_fragment
.global_variable_aliasing_vertex
dEQP-GLES3.functional.shaders.function
.global_variable_aliasing_fragment
.global_variable_aliasing_vertex
Fixed: angleproject:7145
Change-Id: Ia1e40e72a69e2f91b480ef5fbb75ff0f0a1a772a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5176988
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
a6b9a744
|
2023-12-21T00:00:00
|
|
Metal: Implement vertex attribute aliasing
When vertex attribute aliasing is supported, the
external vertex input struct is filled post-link
to account for potentially aliased attributes.
Fixed the following tests:
dEQP-GLES2.functional.attribute_location.bind_aliasing
.cond_float
.cond_vec2
.cond_vec3
.cond_vec4
.cond_mat2
.cond_mat2_offset_1
.cond_mat3
.cond_mat3_offset_1
.cond_mat4
.cond_mat4_offset_1
dEQP-GLES3.functional.attribute_location.bind_aliasing
.cond_float
.cond_vec2
.cond_vec3
.cond_vec4
.cond_mat2
.cond_mat2_offset_1
.cond_mat3
.cond_mat3_offset_1
.cond_mat4
.cond_mat4_offset_1
.max_cond_float
.max_cond_vec2
.max_cond_vec3
.max_cond_vec4
.max_cond_mat2
.max_cond_mat3
.max_cond_mat4
Fixed: angleproject:6297
Change-Id: Ifa6b82e0d7d4e12115ec19e342cfb82ab4389f5a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5148210
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
3c8501b3
|
2023-12-21T00:00:00
|
|
Metal: Handle embedded uniform struct arrays
Preserve arrayness type information
when replacing uniform declarations.
Fixed: angleproject:6525
Change-Id: I09ea79ffa5bf74e06503985d4f90ccbe0bf25570
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5150729
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
706b5abe
|
2023-12-21T00:00:00
|
|
Avoid UB in 16-bit IOSurface tests
* Removed incorrect R16UI mappings from backends
* Fixed the enum used in RenderToR16IOSurface
* Added more 16-bit tests
Fixed: angleproject:7445
Change-Id: I7d5fb8b6a5fc7a57de8f988fdcc21e66606f875d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5148211
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
e9c0241d
|
2023-12-19T10:23:13
|
|
Vulkan: Rely on Vulkan 1.1 entry points in tests
Some KHR entry points that were promoted to Vulkan 1.1 no longer seem to
be loadable with their KHR symbols.
Bug: angleproject:8464
Change-Id: Id5417e5b047e6bd34d144fead518f771c17658e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5135676
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9f148c41
|
2023-12-14T00:00:00
|
|
Metal: Fix triangle fan indices generation
* Ensured that the second index is preserved when
skipping leading primitive restart values
* Restricted the search loop to the index count
* Ensured that draw calls are skipped when the
generated index buffer is empty to avoid Metal
validation errors, also for line loops
Fixed: angleproject:6458
Change-Id: I3194eb9db3e7e225448901edce167a2091563cd5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5132092
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
|
66da618c
|
2023-12-19T16:25:35
|
|
Skip UniformBufferTest.BufferBlockBindingChange on Mac NVIDIA GL
Flaky
Bug: angleproject:8465
Change-Id: Ic923a3af4937a346fdba0b80d486a9ed8e46402e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5136275
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
18a68f6d
|
2023-12-07T16:23:10
|
|
Fix vertex attribute limit check
Bug: angleproject:8448
Change-Id: Ie5d2b71f0be86b31ec74a1d55501b60a25245668
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5101508
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
5e63cee5
|
2023-12-12T20:59:44
|
|
update e2e expectation
Bug: b/316013423
Change-Id: I4a70fdc0b38d8e412c0ca1035564aecb1f1dbc32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5118119
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Solti Ho <solti@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
5c8cb8a6
|
2023-12-07T00:00:00
|
|
Update WebGLReadOutsideFramebufferTest tests
Enabled robust resource init for these tests as they access
out-of-bounds values. This flag is required to pass some of
the tests on Vulkan backend. WebGL clients always set it.
Fixed subresource index computation on D3D11 to
pass CopyTexSubImage3D with 3D textures there.
Added a similar test for 2D array textures.
Bug: angleproject:4092
Fixed: angleproject:4136
Change-Id: I191c6df3c672e583568aadecac5885da015cfa8b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106511
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
0b0b4b22
|
2023-12-07T00:00:00
|
|
Avoid UB in VertexAttributeTestES3.DrawWithUnalignedData
The test uses a signed normalized vertex attribute,
which requires a floating point vertex input.
Bug: angleproject:7001
Fixed: angleproject:7068
Change-Id: I97afc97b03a58130e0d6ee63ec7ee3e44f1e0230
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5105194
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b8ca8de4
|
2023-12-05T13:36:53
|
|
Vulkan: Don't crash when glCopyTexImage2D redefines itself
The Vulkan backend marks a level being redefined as such before doing
the copy. If a single-level texture was being redefined, it releases it
so it can be immediately reallocated. If the source of the copy is the
same texture, this causes a crash.
This can be properly supported by using a temp image to do the copy, but
that is not implemented in this change.
Bug: chromium:1501798
Change-Id: I9dde99aa0b88bc7d5f582ff15772f70b36f424e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5089150
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
dc4b1acd
|
2023-11-30T15:42:32
|
|
Translator: Limit private variable size to 64KB
This is indirectly fixing an issue where passing large arrays in SPIR-V
such that an internal cast is needed (such as array inside interface
block copied to local varaible) causes an overflow of the instruction
length limit (in the absence of OpCopyLogical).
By limiting the size of private variables to 32KB, this limitation is
indirectly enforced. It was observed that all the test shaders added in
this CL fail on the Nvidia OpenGL drivers, so such a limit seems to be
reasonble.
Bug: chromium:1505009
Change-Id: Ia36134b2bf8501a5b875814db3566be28b183e0f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077408
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d7077e9f
|
2023-12-05T00:00:00
|
|
Update macOS end2end expectations
Bug: angleproject:2273
Bug: angleproject:2408
Bug: angleproject:3837
Bug: angleproject:5325
Bug: angleproject:5360
Bug: angleproject:5594
Bug: angleproject:6358
Bug: angleproject:6418
Bug: angleproject:6454
Bug: angleproject:6457
Bug: angleproject:6540
Bug: angleproject:6702
Bug: angleproject:6751
Bug: angleproject:7068
Bug: angleproject:7309
Bug: angleproject:7445
Change-Id: I7f4c012ed2de6af83188ed69170b19f8d2bb19de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5087774
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
6df603ed
|
2023-11-30T13:53:00
|
|
Translator: Optimize field-name-collision check
As each field of the struct was encountered, its name was linearly
checked against previously added fields. That's O(n^2).
The name collision check is now moved to when the struct is completely
defined, and is done with an unordered_map.
Bug: chromium:1505009
Change-Id: If28d738254a541450912eba4ed168424dad9d8be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077407
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Roman Lavrov <romanl@google.com>
|
|
|
64eb87af
|
2021-05-12T00:02:22
|
|
Add test for VectorizeVectorScalarArithmetic bug
Bug: chromium:1201084
Change-Id: Icfb659ae5195f8dd80fecd0904cb90b77697fa70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2889601
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
9a5d75de
|
2023-10-30T11:59:19
|
|
Vulkan: Fix incompatible redefinition of cube faces
The TextureVk::mRedefinedLevels bitmask tracked which levels are
incompatibly redefined, greatly reducing the complexity of dealing with
GL's mutable textures.
It did not however take into account the fact that GL allows each
cubemap face to be separately redefined (unlike 2D arrays, where all
layers are defined together). This change turns the bitmask into an
array of bitmasks. Previously, a single bit represented whether the
level is incompatibly redefined. Now, elements of the array track the
same information for each cube face. For non-cube-map textures, only
element 0 is used.
Bug: chromium:1494664
Change-Id: I69568d3da2391796bf5f01505861fee42c6c8924
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4986289
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
c0c20673
|
2023-10-31T09:03:16
|
|
Remove expections for some AHB tests which are now fixed
Bug: b/223456677
Change-Id: Ibdc5b529e249c39c241a8e8e2b78ac10ff3d5ad2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4988292
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
b6607672
|
2023-10-30T00:00:00
|
|
Test sampling from a texture with renderable levels below base
Bug: angleproject:8378
Change-Id: Id847849e1920c0d1706a4b3441c907ea2451cb6e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4994791
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
36f41997
|
2023-10-30T15:14:09
|
|
D3D11: CopySubTexture: Handle sRGB source with D3D11
Use typeless formats for sRGB textures that can be reinterpreted as
linear. Add a parameter to SRV creation to request samplers that
do not do sRGB for copying sRGB textures.
Bug: angleproject:7907
Change-Id: I3d94dfa5b25a1c2c531cd9bef4247097aa4bfb61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4986290
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
118a9b14
|
2023-10-30T00:00:00
|
|
Test sampling from a texture with extra renderable levels
Bug: angleproject:8378
Change-Id: I4790d59ce193a2aa4ba9e468debf0933a6e3fe47
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4987639
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a7882c41
|
2023-10-27T09:32:07
|
|
Skip InstancingTestES3.LargeDivisor on Linux ASAN
Tests a large divisor and hits an emulation path on SwiftShader, causing
flaky timeouts on asan bots.
Bug: angleproject:7900
Change-Id: Ia82941e67867816c8330472f4f2ea8d897fa9636
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4982910
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Roman Lavrov <romanl@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
65f6c2ea
|
2023-10-22T18:07:55
|
|
Metal: always implicitly resolve MSAA render buffers on tiled GPUs.
On tile based GPUs, implicitly resolving MSAA render buffers to
single-sampled is preferred. Because it would save bandwidth by avoiding
storing the MSAA textures to memory. Furthermore resolving as
StoreAction is almost a free operation on these GPUs.
Traditional desktop GPUs almost always store MSAA textures to memory
anyway, so this feature would have no benefit besides adding additional
resolve step as well as memory overhead of the hidden single-sampled
textures.
Bug: chromium:1486094
Change-Id: I5eb3b1314560024dd5c0834b0c0b43a6b4d3d51b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4962114
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
cfc40d2b
|
2023-07-19T17:47:13
|
|
Vulkan: Adjust clear color precision for GL_RGB5_A1 FBO
When clear color has more precision than the framebuffer
format can hold, dithering is automatically applied on
some hardware.
This issue causes below dEQP tests to fail when the FBO
color attachment format is RGB5_A1:
KHR-GLES31.core.draw_buffers_indexed.color_masks
KHR-GLES32.core.draw_buffers_indexed.color_masks
Adjust the clear color precision for RGB5_A1 format to
workaround the issue.
We can remove this workaround once the vulkan driver
fixes the auto-dithering problem.
Bug: b/292282210
Change-Id: Ic3ffebd2d20c8782612619a60d1ec2cc6d613c22
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4937472
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
65e8ae30
|
2023-10-06T09:42:45
|
|
Vulkan: ANGLE_device_vulkan is incompatible w/ asyncCommandQueue
The application may use EGL_ANGLE_device_vulkan to retrieve ANGLE's
Vulkan queue for direct usage. There is no mechanism for the
application to synchronize with the internal thread that uses the same
queue when the asyncCommandQueue feature is enabled.
This was causing flakiness where VVL reported this error. This change
makes sure an ASSERT catches this incompatible usage.
Bug: angleproject:7204
Bug: b/299693666
Change-Id: Idf349f99d80b7bbddeb9a0b2d72e3dd7c707fa5c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4915594
Reviewed-by: Roman Lavrov <romanl@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8c341cfd
|
2023-10-04T12:49:59
|
|
Vulkan: Fix blits involving 3D images
The layer vs depth value involved with 3D images when calling
vkCmdBlitImage is fixed in this change.
However, that brought to light that the combination of
VUID-vkCmdBlitImage-srcImage-00240 and
VUID-vkCmdBlitImage-dstImage-00252 make it impossible to blit between 3D
and 2D array images, which is likely a spec oversight.
This change makes 3D<->2DArray blits fall back to draw-based blit. This
in turn exposed the fact that 3D images as src were not handled in
BlitResolve.frag. A new Blit3DSrc.frag shader is added which shares
code with BlitResolve.frag to implement this. This is a separate shader
to avoid creating unnecessary and invalid combinations of shaders.
VK_EXT_image_2d_view_of_3d could have been used to avoid this new
shader, but that is not ubiquitous.
Bug: angleproject:7291
Bug: dawn:1962
Change-Id: I6a96162f95829304b4731d43208d9d054f538105
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4911800
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
6b0ddce0
|
2023-09-22T13:13:38
|
|
Backends need to handle invalid render area during a clear
1. Frontend no longer noops empty scissors during clear
2. FramebufferVk is updated to handle invalid render area by restaging
deferred clears in clearImpl(...) if render area is invalid
Bug: angleproject:8348
Tests: EGLSurfaceTest*WindowThenScissoredClear*
Change-Id: Iec51914a083a59bad7f939798c932dffada56a6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4867641
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
e1d2e88a
|
2023-09-20T11:53:15
|
|
Check pending garbage after some buffer releases
* Embedded BufferHelper::releaseBufferAndDescriptorSetCache() inside
a new ContextVk method: releaseBufferAllocation()
* After releasing the buffer, there is a check for excess pending
garbage. If the tracked pending garbage size is larger than the
threshold, the context will be flushed.
* Unskipped the test "BufferDataInLoopManyTimes", which was failing
on Android devices.
Bug: b/280304441
Change-Id: Ib34319f3291dd2200fc1a92e30645f9d1da8e2b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4879086
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
a1e3abc0
|
2023-09-22T10:14:43
|
|
Add ES2 support for copying GL_SRGB8_ALPHA8 to GL_RGBA8
Bug: angleproject:7907
Change-Id: I02ae9785ea1f942e85983c18155cfd75ec39b5c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4887271
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
120e90eb
|
2023-09-08T11:23:11
|
|
Add test for copying GL_SRGB8_ALPHA8 to GL_RGBA8
The pixel values should be the same (no conversion should happen).
Include sub-tests with and without alpha premultiplication.
Bug: angleproject:7907
Change-Id: I2e3d657d5b8513cd06df357e84027572ebce03ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4852258
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
f5842350
|
2023-08-21T00:00:00
|
|
Vulkan: Flatten secondary fragment output arrays
Added a SPIR-V transformation that makes them private
and copies their values into regular fragment outputs.
Fixed: angleproject:8336
Change-Id: Ide62dd183426e0de70fd4ac6d2b8c6a4b4b33994
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4875327
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
ae9c7857
|
2023-09-19T13:40:52
|
|
Suppress BufferDataInLoopManyTimes for Linux/Intel
* Skipped BufferDataInLoopManyTimes for Linux/Intel due to the long
execution time, suspected to be causing errors on the bots.
Bug: angleproject:8351
Change-Id: Ib7b640800edf5b30e251b47cfabfd34cc1ecea28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4877693
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
a1f52f1b
|
2023-09-07T14:44:24
|
|
Vulkan: Flush pending image garbage more often
* Added a counter to the context object to keep track of the size of
the pending image garbage: mEstimatedPendingImageGarbageSize.
* Modified hasExcessPendingGarbage() to use the sum of the size of
the image and and suballocation garbage.
* RendererVk::calculatePendingGarbageSizeLimit() provides the limit.
* Currently the limit is based on the available heap sizes. It will
use a fraction of the largest memory heap size.
* The portion is currently kGarbageSizeLimitCoefficient = 0.2f.
* Unskipped the test "TextureDataInLoopManyTimes", which was failing
on Android devices.
Bug: b/280304441
Change-Id: Ibcced1d118ea8a1f347028b62d29cfbd9e38e8c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4851252
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
22b6ca1c
|
2023-08-21T00:00:00
|
|
Remove obsolete EXT_blend_func_extended expectations
Bug: angleproject:5981
Bug: angleproject:6585
Bug: angleproject:7177
Change-Id: I25da401f03ff0bfa7a77c3ce7a3fecd0a119d6a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4870916
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9d99f85f
|
2023-09-14T15:01:14
|
|
Add multithreaded texture upload test
Bug: angleproject:8341
Change-Id: I8561a64fb28681509a1d65c490888dfa1a423835
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4864467
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
ffd6ec26
|
2023-09-07T15:39:19
|
|
Reland "Make egl surface uncurrent when being destroyed"
This relands commit 497440cdcb7d2ee59bca612dd07fc13cf09a6a57.
This is to workaround errors when app does below behaviors:
1) while there is a context still bound to the current
rendering thread and the surface, call eglDestroySurface()
2) create a new surface eglCreateWindowSurface()
3) call eglMakeCurrent() with the surface created in step 2)
4) does work on the new surface
The old surface won't be destroyed in step 1) because
it was still bound by the context of the current rendering
thread. When creating new surface on step 2), some hardware
will return error code EGL_BAD_ALLOC, because the old egl
surface is still associated with the native window.
To workaround, when destroying surface, if the surface
is still bound by the context of the current rendering
thread, release the context and surface by passing
EGL_NO_CONTEXT and EGL_NO_SURFACE to eglMakeCurrent().
The workaround is controlled by a frontend feature
uncurrentEglSurfaceUponSurfaceDestroy. This feature
is only enabled on vulkan backends.
Bug: b/292285899
Change-Id: Id4c47f1b20e0f90d1013a68893fd70e917c030e2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4867066
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
e7418836
|
2023-08-16T14:25:52
|
|
Vulkan: Add context flushing as OOM fallback
* As a new fallback for out-of-memory errors, if an allocation results
in device OOM, the context is flushed and the allocation is retried.
* Functions related to buffer/image allocations now return a VkResult
value instead of angle::Result, which will be bubbled up to a higher
level for safer handling.
* The OOM is no longer handled at the level where the allocation
happens, but is moved up to the context.
* Added two functions to ContextVk for allocating memory for images and
buffer suballocations, which also include the fallback options.
* initBufferAllocation(): Uses BufferHelper::initSuballocation()
* initImageAllocation(): Uses ImageHelper::initMemory()
* Moved initNonZeroMemory() out of the following functions:
* BufferHelper::initSuballocation()
* Moved to ContextVk::initBufferAllocation().
* ImageHelper::initMemory()
* Moved to ContextVk::initImageAllocation().
* Also moved to new function:
ImageHelper::initMemoryAndNonZeroFillIfNeeded().
This function replaced the rest of initMemory() usages outside
initImageAllocation().
* New macros for memory allocation
* VK_RESULT_TRY()
* If the output of the command inside it is not VK_SUCCESS, it will
return with the error result from the command.
* VK_RESULT_CHECK()
* If the output of the command inside it is not VK_SUCCESS, it will
return with the input error.
* Added a test in which allocation would fail due to too much pending
garbage without the fix on some platforms. The test ends once there
has been a submission.
* New suite: UniformBufferMemoryTest
* Added a similar test for flushing texture-related pending garbage.
* New suite: Texture2DMemoryTestES3
Bug: b/280304441
Change-Id: I60248ce39eae80b5a8ffe4723d8a1c5641087f23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4787949
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9624db05
|
2023-08-21T00:00:00
|
|
Validate missing fragment outputs for dual-source blending
* A secondary fragment output must be declared when
dual-source blending is enabled in WebGL contexts.
* Omitting locations for multiple fragment
outputs is not allowed in WebGL contexts.
Bug: angleproject:1085
Change-Id: I57febdc02c9ccc571971a81b6671869f19b0aa96
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4834672
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
7c3c7b7b
|
2023-08-29T16:40:50
|
|
Add more test for GL_SRGB8 format
And follow up changes from crrev.com/c/4819053
Bug: b/298037344
Change-Id: Ib27cc2fb8418d05d0b25f4abbdcf052d1f51c9ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4824046
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
d4756a94
|
2023-08-29T15:26:15
|
|
D3D11: Fix register index of read-only storage images
On D3D11 read-only storage images should consume SRV registers ("t")
instead of UAV registers ("u"), so baseUAVRegister shouldn't be
related to read-only storage images.
fixed: angleproject:4404
Bug: angleproject:7121
Change-Id: I3ca35497992de599d0427fae10d750aff7cf7d9e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4819797
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9f258f8a
|
2023-08-21T00:00:00
|
|
GL: Add disableRenderSnorm workaround
Disable the extension on Mesa versions that
clamp negative snorm values to zero on read.
Fixed: angleproject:8315
Change-Id: I5459db40cb08c546fba15f5e6d70578029a8218a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4804324
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
1bd45c4f
|
2023-07-17T14:18:53
|
|
Add tiling mode for GL_EXT_memory_objects
Add set and get TexParameter for pName GL_TEXTURE_TILING_EXT
Add test case to VulkanImageTest for import LINEAR memory object
Bug: angleproject:8274
Change-Id: I4432093e41f45e3926a27e3dee00d48c0438cae5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4752793
Reviewed-by: Jeff Vigil <j.vigil@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: mohan maiya <m.maiya@samsung.com>
|
|
be60f879
|
2023-06-28T17:29:45
|
|
Workaround for tex buffer type mismatch
In the event of a mismatch between a texture buffer format (eg GL_R32F)
and the shader sampler type (eg usamplerBuffer), adjust the tex buffer
format to match the sampler (eg GL_R32UI).
Test: angle_end2end_tests \
--gtest_filter="TextureBufferTestES31.TexBufferFormatMismatch*"
Bug: b/233119699
Change-Id: I3461bcecabfe1d96be6350c43c15b32d35265b23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4769137
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Mike Schuchardt <mikes@lunarg.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ba41a4d8
|
2023-08-16T13:52:57
|
|
Suppress parallel-link tests on Asan/Windows/SwiftShader
They are flaky with no clear reason.
Bug: angleproject:8306
Change-Id: I1331c6d792417edccad6b337e55b3816df2c2f12
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4783055
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
833f7f69
|
2023-08-09T10:49:51
|
|
Vulkan: improve XFB feature dependency checks
Some features need to account for the possible override of
supportsTransformFeedbackExtension == false.
Since we now frontload the overrides, we also can remove the explicit
overrides for the dependent features in TransformFeedbackTest.
Bug: angleproject:8291
Change-Id: I0ec54dc0fce440ef3e7bfe9987d0ea19fb9dafaa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4763096
Auto-Submit: Steven Noonan <steven@uplinklabs.net>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e50d3876
|
2023-08-04T14:47:41
|
|
Vulkan: Retain loadOp when there is a resolve attachment
Rendertargets with resolve attachments cannot optimize away loadOp
Load or Clear even if they are marked ResourceAccess::Unused and
storeOp is RenderPassStoreOp::DontCare.
Bug: angleproject:4836
Bug: angleproject:5981
Tests: ImageTest.SourceAHBTarget2DMSRTTInteraction*
Change-Id: I39ec67a457de6876ed0bd47d66a963cc59fab064
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4753735
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
0d886b62
|
2023-07-14T11:24:53
|
|
Check that MRTSS bit is supported by format
Bit was added without checking ImageFormatProperties causing
failures in some end2end tests.
Bug: angleproject:8262
Test: Texture2DTestES3.TexStorage2D*/ES3_Vulkan*
Change-Id: I7f9a4ee7c14610ee239ab1f86e4ba2c649ce76b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684549
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d5ddb710
|
2023-07-27T15:27:52
|
|
Suppress 2 end2end tests on iOS Metal
GLSLTest_ES3.LiteralInfinityOutput/ES3_Metal
GLSLTest_ES3.LiteralNegativeInfinityOutput/ES3_Metal
Started failing when testing was switched to iPhone 14 iOS 17.0
Bug: angleproject:8278
Change-Id: Ieca08edd02ea4350fc8362cf98d43d8ab4f0adb5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4725466
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
d04dda15
|
2023-07-17T14:29:44
|
|
Skip WebGL2CompatibilityTest.DrawWithZeroSizedBuffer on iOS GL
Bug: angleproject:8264
Change-Id: Icac83200b8e9aa35ba3e85be8b34bd45e616a8bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685572
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
4e6124da
|
2023-06-23T14:46:28
|
|
GL: Ensure all instanced attributes have a buffer with data
Apple OpenGL drivers sometimes crash when given an instanced draw with
a buffer that has never been given data.
It's not efficient to check if the attribute is both zero-sized and
instanced so just ensure that every time a zero-sized buffer is bound
to an attribute, it gets initialized with some data.
Bug: chromium:1456243
Change-Id: I66b7c7017843153db2df3bc50010cba765d03c5f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4642048
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f5ad056b
|
2023-07-10T22:13:34
|
|
GL: Fix ScalarizeVecAndMatConstructorArgs and move to gl/
This transformation was buggy and was disabled. Originally, it was
intended to be used everywhere. It is now needed for a GL driver
workaround.
This change reimplements this transformation and uses it as a GL
workaround.
Bug: chromium:1420130
Change-Id: I42d63fa5844bcf683ac41e61925aa637e033ca2e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4676634
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
b0e262fb
|
2023-07-10T11:33:53
|
|
Group Texture3DTestES2 skips on iOS GL
Bug: angleproject:8213
Change-Id: Ib00bd8d28aa58a56012f2b46f4ac153481d1be38
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674080
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
b2b1363a
|
2023-07-10T12:29:03
|
|
Skip Texture3DTestES2.DefineTexture2DArrayShouldFail on iOS GL
Bug: angleproject:8213
Change-Id: I5487bd7b0a8033445d5552bb8d86dc3af80f1305
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674340
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
20cc4a9b
|
2023-06-26T00:00:00
|
|
D3D11: Fix non-trivial blits for snorm buffers
Bug: angleproject:8048
Change-Id: Ifec7ea71e0ab88f545ae088b0faae4b95512a207
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4654315
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
b1b12d4a
|
2023-06-22T15:27:48
|
|
Vulkan: Move device OOM tests to new test suite
* Moved the device OOM tests from VulkanImageTest to a new test suite,
VulkanMemoryTest.
* It is instantiated for ES3.
* Moved the slow tests in the expectation file to the end.
Bug: b/280304441
Change-Id: Icc958b5eb071567f8e6671661302760c7f5e3621
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4639041
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
5f6d7848
|
2023-06-15T12:31:26
|
|
Android: Add/update MaliG710 expectations and tests
Fixed End2End tests causing valiadation errors where
VK_EXT_primitives_generated_query was being enabled without enabling
VK_EXT_transform_feedback.
Consolidated the DEQP-GLES3 expectations for the
functional.transform_feedback* tests, updated some changed
test names.
These test expectations were collected from the 43.0 driver
version.
Bug: b/285628492
Bug: angleproject:8212
Change-Id: I224a2eec33ee56b7303d17aebd998de65354106c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4626241
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
|
|
|
232506e1
|
2023-05-15T19:19:39
|
|
Vulkan: Free the garbage memory before realloc
The previous CL added the feature of freeing garbage memory in the
event of device OOM. However, it was for image allocations only.
* Extended finishing commands and freeing the garbage to buffers.
* Added unit test to allocate buffer after freeing memory space on the
device.
Bug: b/280304441
Change-Id: I540b27a41b34d1ceb1cd3119213341c9f290ea38
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4540209
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
5f9548c3
|
2023-05-19T11:51:04
|
|
Vulkan: Free the garbage memory before realloc
Currently image allocations fall back to system memory in case of
a device OOM. However, in some cases, it is also possible to gain
some memory by freeing garbage memory from the device. This allows
us to keep the allocation on the device memory.
* Updated the image allocation fallback, so we will try cleaning the
garbage memory through the renderer before retrying the allocation.
* finishOneCommandBatchAndCleanup() in RendererVk, which will call a
similar function in its CommandQueue. It will be called until there
are no more in-flight submissions.
* The existing finishOneCommandBatchAndCleanup() in CommandQueue has
been renamed to finishOneCommandBatchAndCleanupImpl().
* Updated the flags used for VMA image allocations. If any device memory
is freed after garbage cleanup to make enough space for the new
allocation, it will take precedence over the system memory.
* Added unit tests in which a new image allocation could happen on the
device after freeing the garbage memory.
* They use a 2D texture and a 2D texture array for garbage.
Bug: b/280304441
Change-Id: Ia5e605e180833b44af8c77550ab1b0b8ba21724e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4547941
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
cba77bce
|
2023-06-26T14:30:58
|
|
Disable device OOM tests for Linux/NVIDIA
* Disabled the device OOM test in VulkanImageTest for Linux/NVIDIA
systems, due to potentially affecting other tests with flakiness.
Bug: angleproject:8236
Change-Id: I4dc0e4f22149507350093708031e05ded5e5c18e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4647294
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
61eda436
|
2023-06-15T14:47:35
|
|
Fix TexImage3D validation for 2D arrays below ES3
Currently if we try to define a 2D texture array in ES2, a crash
occurs during its validation. Since texture3DOES only adds support to
3D textures, we should make sure the validation only passes if ES3 and
above are used.
* Added check for 2D texture array usage in validating glTexImage3D().
Bug: angleproject:8213
Change-Id: Ib477d8b6eec89c35d605a1b575bfb5519d19452e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4618955
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
bbcf54bc
|
2023-06-16T16:02:08
|
|
Vulkan: Refactor uniform/block binding duplication code
Previously, resource binding assignment was done as such:
```
for each shader stage
assign bindings to textures
assign bindings to blocks
assign bindings to images
etc
```
To deduplicate bindings when the same resource was used in multiple
stages, a map was used, keyed by the resource's name, to detect when an
already visited resource is encountered in a future stage. This was
both inefficient and unnecessarily complicated.
With this change, resource binding assignment is done as such:
```
for each texture
assign one binding to all shader stages
for each block
assign one binding to all shader stages
for each image
assign one binding to all shader stages
etc
```
The aforementioned map is removed.
Because the resource bindings are now changed, the rest of the code
(which sets up the pipeline layout, updates descriptor sets, sets
dynamic buffer offsets, etc) are all updated to follow the above
pattern. As a result, nested loops are avoided and duplicate entries in
the variable map are never visited.
Bug: angleproject:7220
Change-Id: Iaff7b5f8b2bada8ac5078d21e5c790bf0d27aca7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4622011
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
262784f4
|
2023-06-19T17:56:04
|
|
D3D11: unbreak instanced indirect multidraw with ushort indices
The baseInstance parameter was not being passed in the unsigned short
index case.
Bug: angleproject:8216
Change-Id: If660c6d4125bfd2aff8f4fd3a9171194635d21c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4627281
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
de28b89a
|
2023-06-15T12:31:26
|
|
Android: Add Pixel 7 entries to End2End expectations
Bug: b/285628492
Bug: angleproject:8212
Change-Id: I205ff24f53c03c0a0634b35b6a7e76b79f21d622
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4617583
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
3a3a3c65
|
2023-05-31T23:06:57
|
|
Remove override test31Context.cpp
Remove the override test31Context so that
1) we can run deqp test suites on Pixel devices
with the same configuration as Android CTS test
runner.
2) those deqp tests that require a GLES 3.2
context will not be skipped and can execute on
devices that supports GLES 3.2.
Since the deqp test runner overrides the feature
exposeNonConformantExtensionsAndVersions with "true" value,
a context is created regardless of whether the device supports
GLES 3.2. However, not all of the devices are GLES 3.2
conformant, we will suppress those tests that
are failing on non-conformant devices.
Bug: b/224537784
Bug: angleproject:3687
Bug: angleproject:3688
Bug: angleproject:6678
Change-Id: I2a549537bdbb2c0356fcccaa96291229c699ed0f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4559445
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
|
|
14339812
|
2023-06-13T10:00:39
|
|
Merge Galaxy A23 and S23 e2d expectations where can
Many of the Samsung Galaxy A23 and S23 (all Qualcomm GPU) expectations
were common, and so they are merged into a common GALAXYQUALCOMM ID.
Bug: b/285045753
Bug: angleproject:8185
Change-Id: I5eb44f5de969763df290a938935a3a76ea3aab98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4610479
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
7e075469
|
2023-06-12T18:34:05
|
|
A23: Improve end2end SKIP lines and add FAIL lines
Bug: b/285045753
Bug: angleproject:8185
Change-Id: I863878e06495c0431c07113d9de702b0bb7dd8ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4606370
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9f734b5e
|
2023-06-07T10:23:39
|
|
Galaxy A23: add end2end expectations for crashing tests
Bug: b/285045753
Bug: angleproject:8185
Change-Id: I5b58f8220589a9bc8b366932b6aaa06d1fe84024
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4597750
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
6e40ce00
|
2023-06-05T11:47:29
|
|
Do not call postResolveLink in Program::deserialize.
postResolveLink assumes the program is currently linked, which is not
the case in Program::deserialize. It makes calls to set uniforms which
is not always expected by the backend.
Call postResolveLink after the backend has linked when loading
program binaries.
Bug: angleproject:6073, angleproject:8183
Change-Id: Idacb81040ea79a7df51917aaa27c77b25df7d5cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4588410
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ad1f58aa
|
2023-05-30T09:41:41
|
|
Tests: skip RGBTextureBufferTestES31 on Linux intel vulkan
vk_icdNegotiateLoaderICDInterfaceVersion crashes (possibly Mesa bug?)
Bug: angleproject:8179
Change-Id: I05812f436ab4f4ac2755c20bddc1cc33a28b5d8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4574146
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
ff110417
|
2023-04-21T15:16:03
|
|
Vulkan: Emulate RGB32 uniform texel buffers when unsupported
Applies to: GL_RGB32F, GL_RGB32I, GL_RGB32UI
When VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT is specified for these
formats by the Vulkan driver, behavior is the same as before.
When it is not speficied: previously ANGLE wouldn't enable
GL_EXT_texture_buffer unless exposeNonConformantExtensionsAndVersions
was enabled; now ANGLE always enables it and does the RGB->RGBA
conversion (GPU) under the hood and tracks buffer content updates using
the paths added for tracking this for Vertex Arrays.
Bug: b/278585075
Bug: angleproject:8128
Change-Id: I4605719bf3f51c5a10c1a35ecae767833dcd45d7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4456498
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
055c72ac
|
2023-05-25T09:22:26
|
|
Suppress AllocateVMAImageWhenDeviceOOM for AsyncCQ
Bug: angleproject:8174
Change-Id: I28e7e8bdc26055f2ad03f2842676330430b579b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4568283
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
7abc5248
|
2023-05-19T00:00:00
|
|
Vulkan: Enable VK_EXT_depth_clamp_zero_one
Replaced the 'depth_clamping' workaround
with the dedicated extension or explicit
fragment depth clamping.
Fixed: angleproject:3970
Bug: angleproject:8077
Change-Id: Ia7666fcb3e0e949922c13a3fd11b818cbc5a8e26
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4545084
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3d455fe4
|
2023-05-03T15:35:47
|
|
Android: Galaxy S23 support
This CL:
* Adds detection of the device
* Adds end2end test support
* end2end test expectations for Vulkan backend
* Works around driver issue with vkCmdSetLogicOpEXT
Test: angle_end2end_tests, angle_trace_tests
Bug: b/277717225, b/281128706
Bug: angleproject:8157
Change-Id: If6caa5b2ba0b9d7f94e1be0841bcff2ea1c34d89
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4509693
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
e27759f9
|
2023-04-20T00:00:00
|
|
D3D11: Ignore sample mask and A2C for single-sampled rendering
Also fixed alpha-to-coverage for single-sampled
rendering and simplified sample coverage code
in the Vulkan backend.
Fixed: angleproject:8102
Change-Id: Ieea03dfdc13c6105ddf916dca6d0fea593eb3a62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4455508
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
5c9821fd
|
2023-04-21T00:00:00
|
|
GL: Fix readPixels for snorm color buffers
Bug: angleproject:8048
Change-Id: Ie4f6c5abb6d53c195f4bf460f179ae24fffd0102
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4464157
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
23ff85fe
|
2023-04-20T13:32:37
|
|
Suppress newly added PixelLocalStorageTest.TextureLevelsAndLayers
on iOS Metal
Bug: angleproject:7994
Change-Id: I9d3a1e2af99e3127d74b96c0740054e47fd4b661
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4455107
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
|
|
|
6deca89e
|
2023-03-22T22:33:40
|
|
Add Spirv Instruction to explicitly cast mediump float to 16 bit
If the GLSL shader code expects the comparison between
two mediump float values returning true, but the SpirV
compiler treats one of them as 32-bit, and treats the
other one as 16-bit, the comparison would return false
instead. The SpirV compiler may not automatically cast
the mediump float values to 16 bits, because it may
utilize the RelaxedPrecision decoration to keep a mediump
float as 32-bit, so that the compiler can avoid the
type cast from 32-bit highp to 16-bit mediump.
This change adds an additional OpQuantizeToF16 SpirV
instruction to explicitly cast mediump float scalar
or mediump float vector to 16 bit, if they are assigned
with a highp float value. This ensures that if the
GLSL shader code ever compares two meiump float values,
the SpirV shader compiler is not accidentally comparing
a 16 bit with a 32 bit float value.
This fixe the deqp test failure on Pixel 6 and Pixel 7:
dEQP-GLES2.functional.shaders.algorithm.rgb_to_hsl_vertex.
Bug: b/274859104
Bug: b/274408172
Change-Id: Ifd996cea14c0f77f45ae90f38c8e53cf5035139f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4400404
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
443ac5b4
|
2023-04-17T00:00:00
|
|
GL: Enable OES_shader_multisample_interpolation
Drive-by:
* Fixed validity of the related state queries
* Added SampleMultisampleInterpolationTest
* Removed unused OES_sample_variables code
Bug: angleproject:8097
Bug: angleproject:8131
Change-Id: I816d2096759a96d8691acd0a8c5ecdedf880201b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4440826
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
fdbd6488
|
2023-04-12T14:02:44
|
|
metal: allow unequal size attachments.
OpenGLES3.0 allows FBO with attachments that have unequal size.
In Metal, an FBO is represented by a render pass pipeline, which
is created using MTLRenderPassDescriptor descriptor. The render
pass can have color attachments as well as depth and stencil
attachments. Those individual attachments must have a texture
attached, which works as a buffer. However, the documentation
does not specify any dimension restrictions for those textures.
Test: verify the FramebufferTest_ES3.AttachmentsWithUnequalDimensions
passes.
Test2: made a simple metal app that renders using an offscreen
render pass pipeline to a texture that has size of 32x16 with
a depth buffer attached (size of 16x32) and verified the
pixels on that. The content outside the common area had
undefined pixel data.
Bug: angleproject:7994, angleproject:6447
Change-Id: I257f8e3aad497772cfc7de08314818ee5f434b84
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4418266
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|