|
aed3d65b
|
2020-07-29T22:23:00
|
|
Tests: Add NBA2K20 trace
Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*"
Bug: b/160014453
Bug: angleproject:4048
Change-Id: I4899af05d48ad2900e6d5e44adc5f5e0bdba157e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2326911
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
248d754a
|
2020-07-29T16:50:03
|
|
Capture/Replay: Limit string lengths in capture
MSVC can't handle string lengths longer than 16380 according to:
https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2026
Example build failure without this CL:
https://logs.chromium.org/logs/angle/buildbucket/cr-buildbucket.appspot.com/8873410048312858000/+/steps/compile_with_ninja/0/stdout
Test: Compile NBA2K20 MEC with MSVC
Bug: b/160014453
Bug: angleproject:4048
Change-Id: Ie14d40e8c3eea35d08d4be32455b327a311f1bcc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2327702
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
a9504808
|
2020-07-29T16:33:45
|
|
Vulkan: ATrace marker fix-ups
Fix a couple of mislabled atrace markers and add explicit markers
for inside/outside renderpass flushes.
Bug: b/156403378
Change-Id: I4045846e54ff54bc8fc3dd6ef47339f6f5eb8e87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2327828
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
dcc56215
|
2020-07-19T01:12:09
|
|
Vulkan: Implement GL_EXT_multisampled_render_to_texture
This change allows the use of resolve attachments in the Vulkan backend.
GL_EXT_multisampled_render_to_texture is implemented using this feature.
The infrastructure for specifying resolve attachments is designed with
eventual support for GL_EXT_multisampled_render_to_texture2 in mind as
well as optimizations to glBlitFramebuffer() and multisampled
backbuffers.
Proper support for glRenderbufferStorageMultisampledEXT is still missing
from this change. All tests use this for the depth/stencil attachment
and don't read back the data. Currently, the depth/stencil attachment
is created as a normal multisampled image.
Bug: angleproject:4836
Change-Id: I110a7f63312ae61a657b6094adf7d97c92bd5843
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304170
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
d56ed7cf
|
2020-07-30T08:13:07
|
|
Support EGL_ANGLE_display_semaphore_share_group for DisplayNULL
Bug: angleproject:4877
Change-Id: I811ff57625a6bac749a50a1a53da48e62f5b8222
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2329285
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
19aac801
|
2020-07-28T11:18:53
|
|
Vulkan: Remove unnecessary endRenderPass calls.
In both onImageRead and onImageWrite, there's a call to
endRenderPassAndGetCommandBuffer when necessary to record a command.
There was an extraneous call to endRenderPass in both functions for no
good reason.
Bug: angleproject:4882
Change-Id: I8f3b18dbb3cb9a8b92dedcc603eaf44b1e485986
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2323642
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
8138cbbd
|
2020-07-30T07:01:31
|
|
Roll SwiftShader from dc8e77f0e521 to 08a3cc4cfbaa (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/dc8e77f0e521..08a3cc4cfbaa
2020-07-29 amaiorano@google.com Add doc for testing with SWANGLE
2020-07-29 amaiorano@google.com Add doc on using ANGLE instead of SwiftShader GL
2020-07-29 swiftshader.regress@gmail.com Regres: Update test lists @ dc8e77f0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I2095ca8e1b7522978836385c37ba49d2ddcfe363
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2328507
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
754562c7
|
2020-07-30T07:01:36
|
|
Roll Vulkan-ValidationLayers from c0bf676837e4 to 4400cab64b22 (7 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c0bf676837e4..4400cab64b22
2020-07-29 s.fricke@samsung.com tests: Add format check for YCbCr swizzle
2020-07-29 s.fricke@samsung.com tests: Add depth stencil format check
2020-07-29 jzulauf@lunarg.com syncval: Fix typo in usage doc
2020-07-29 locke@lunarg.com syncval: Use floor instead of ceil
2020-07-29 jzulauf@lunarg.com syncval: Correct write_barrier 0 and layout in log
2020-07-29 karen@lunarg.com docs: Reference Vulkan Configurator
2020-07-29 mark@lunarg.com scripts: Remove unmaintained test results script
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: Ie914e610feac8d9cac5e9882b9b1a7fe3ff7e720
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2328508
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
8d09e376
|
2020-07-30T07:01:30
|
|
Roll SPIRV-Tools from f9b088fe0dbf to c6e6597c4f51 (5 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f9b088fe0dbf..c6e6597c4f51
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: Ib5dac3eb3539926325fe19d6a6d4ebe999fea39e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2328506
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
fd60950e
|
2020-07-29T13:31:11
|
|
Samples: Fix Capture/Replay sample
New header required to compile. It mirrors one used by
our perf tests, but this one will remain basic.
Test: Replay a new trace
Bug: angleproject:4845
Change-Id: If42bba6a91bf37ed063b5828b4cbc80373108b2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2327292
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
1c1c6b4e
|
2020-07-29T13:17:16
|
|
Vulkan: Cache/re-use vkImageView's per max level
For applications that frequently switch a texture's max level, cache
and re-use "read view" vkImageViews per max-level.
Test: NBA 2K20
Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_texture_mipmap_*_max_level_* --use-angle=vulkan
Bug: b/161993151
Change-Id: I9a6a81d5234196040bc6c264ec627a073ba73293
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321370
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
4cf2501c
|
2020-07-27T13:19:27
|
|
Add extension EGL_ANGLE_display_semaphore_share_group
For sharing semaphores globally.
Bug: angleproject:4877
Change-Id: I472e0902fd04ca8350d74e6c0ae6925ee930ccf9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319370
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
5f6f47f6
|
2020-07-29T14:26:37
|
|
Tests: Update gfxbench traces
Use new capture calls to support offscreen mode.
Test: run_angle_perftests --gtest_filter="*Trace*"
Bug: angleproject:4845
Change-Id: I6d9ea79bd8339b7d5398e34b0407425e80ce1d32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2327699
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
cc846039
|
2020-07-27T21:05:11
|
|
Capture/Replay: Fix GetTexImage on Luminance
GetTexImageANGLE and GetRenderbufferImageANGLE use ReadPixels to
pull texture data. Luminance is not a renderable format, so it is
not supported by ReadPixels. To support this, override Luminance
formats to their underlying internal format.
Test: angle_end2end_test --gtest_filter="*GetTexImage*"
Bug: b/160014453
Bug: angleproject:4058
Change-Id: Id19344c2e2c06386a871338833e35b7747cb966b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321740
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
d019af80
|
2020-07-29T11:30:34
|
|
Capture/Replay: Fix missing header.
This was missing from a prior commit.
Bug: angleproject:4845
Change-Id: Iff2b0f300270df4c2e26265c5af81af8ae7e5e54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2325032
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
ab07b2be
|
2020-07-29T07:01:36
|
|
Roll Vulkan-ValidationLayers from 171e04fac342 to c0bf676837e4 (3 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/171e04fac342..c0bf676837e4
2020-07-28 jzulauf@lunarg.com syncval: Update 'most recent' explanation
2020-07-28 sam.walls@arm.com tests: add tests for PerfDoc checks 18-20
2020-07-28 sam.walls@arm.com practices: add PerfDoc checks 18-20 with SPIRV analysis
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I6b6b1620925aab4c7cbf35e6b08ef2ba8d6f2420
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2325650
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
ad3974af
|
2020-07-29T07:01:30
|
|
Roll glslang from 3ee5f2f1d331 to 7ab4564696a7 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3ee5f2f1d331..7ab4564696a7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I653f0f3fed6ac56d9310c243c90ee54efb5b8a87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2325567
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
020b32e4
|
2020-07-29T07:01:31
|
|
Roll Vulkan-Tools from 3b36fdc64014 to a4505d37ffe7 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/3b36fdc64014..a4505d37ffe7
2020-07-28 charles@lunarg.com vulkaninfo: fix device ext list having bad items
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I9ca11a039f82712be3d3f8cd65623304bbe92f30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2325569
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
affcfa8d
|
2020-07-29T07:01:31
|
|
Roll SwiftShader from 12c9d4ac61f2 to dc8e77f0e521 (6 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/12c9d4ac61f2..dc8e77f0e521
2020-07-29 sugoi@google.com Work around dEQP-VK output_location test flakiness
2020-07-28 capn@google.com Expose VK_EXT_image_robustness support
2020-07-28 capn@google.com Perform texel replacement on out-of-bounds OpImageFetch accesses
2020-07-28 capn@google.com Perform out-of-bounds checks on texel pointers
2020-07-28 amaiorano@google.com Add CMake script to setup and build ANGLE
2020-07-28 amaiorano@google.com Add ANGLE as submodule
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I14b66c52d2e3bb6c240ffa2eca1b12c5a94a78cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2325568
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
592c94cd
|
2020-07-29T07:01:30
|
|
Roll SPIRV-Tools from 150be20d4334 to f9b088fe0dbf (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/150be20d4334..f9b088fe0dbf
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I68a63f4923340c7657055c56e08ae5843b944a11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2325566
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
c20449a8
|
2020-07-28T14:27:13
|
|
DEPS: Remove use_relative_hooks.
This flag is deprecated and folded into use_relative_paths.
Bug: chromium:1107325
Change-Id: I2bb185185d2d345d5acb5e51142cde0e2cfee3cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2324601
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
e4ceee97
|
2020-07-17T15:57:37
|
|
Capture/Replay: Break up SetupContext
While getting NBA2K20 MEC to work, discovered that
SetupContext was so large, it was causing a stack
overflow. To fix, simply break up the function into
a series of helpers if the number of calls exceeds
a set limit.
Test: NBA2K20 MEC
Bug: b/160014453
Bug: angleproject:4048
Change-Id: I332d5dea5fc4e14700b68150cbe31a4c88cdae89
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321739
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
84eb7d87
|
2020-07-27T16:27:36
|
|
Add mac_xcode_version gclient arg to DEPS
Chromium's //build/ requires the DEPS file to produce gclient_args.gni
that contains a mac_xcode_version variable
Bug: angleproject:4878
Change-Id: I24421173347e1b508913d49793a065ccd52a47e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321395
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
bba8daea
|
2020-07-27T20:07:53
|
|
Perf Tests: Use timestamp queries for GPU time.
Testing shows that using timestamp queries and deferring the
query get calls until after the frame produces little overhead.
Also this fixes a missing GPU time reset between iterations.
Bug: angleproject:4879
Change-Id: I2a566548add1536aab689cd969594a15f0628da3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321573
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
07cdf421
|
2020-07-28T09:08:46
|
|
Vulkan: Add new validation skips
Skip new error UNASSIGNED-CoreValidation-Shader-InputNotProduced
and best practices warning
UNASSIGNED-BestPractices-vkCmdClearAttachments-clear-after-load
Bug: b/156661359
Bug: angleproject:4883
Change-Id: I05bf5cac46c54bfb32fa47ea6d3398bd534450f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2323641
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
2918eade
|
2020-07-28T13:08:05
|
|
Remove context id serialization
Serializing context id causes many tests to fail capture replay test.
Remove it from the the GL context state's serialization.
Bug: angleproject:4817
Change-Id: Ide04f24c54d1f1fced532e49e85c0c2970816f5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2323645
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
|
|
44bb4d7a
|
2020-07-22T13:58:50
|
|
D3D11: Fix bug with static vertex attributes.
In some specific cases after binding a zero size buffer we could end
up trying to use a buffer storage that was no longer valid. Fix this
by ensuring we don't flush dirty bits when we have an early exit due
to a zero size buffer.
Also adds a regression test.
Bug: chromium:1107433
Change-Id: I9db560e8dd3699abed2bb7fe6d91060148ba1817
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314216
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
50a27257
|
2020-07-22T22:14:16
|
|
Adds sampler serialization capability
Adds the ability to serialize sampler objects.
Adds serialization of sampler objects to serializeContext method so
that capture replay regression testing now compares the states of
samplers too.
Bug: angleproject:4817
Change-Id: Ic32d442eac9aa3afc5c9eea577522fe7054a755a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315048
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
68791f89
|
2020-07-20T17:42:23
|
|
Vulkan: Fix sub invalidate marking render targets undefined
When glInvalidateSubFramebuffer is called, the framebuffer is only
partially invalidated. FramebufferVk::invalidateImpl was nevertheless
marking the render targets as undefined, which would lead the subsequent
render pass have loadOp=DONT_CARE. This is not correct, as the rest of
the framebuffer is expected to still be valid.
Bug: angleproject:4859
Change-Id: I2e64baa32b1fc84beb8008411b564cd7619af962
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309111
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
d1afcd96
|
2020-07-28T07:01:26
|
|
Roll Vulkan-ValidationLayers from 361fb5311b9b to 171e04fac342 (8 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/361fb5311b9b..171e04fac342
2020-07-27 jglines@nvidia.com Allow KHR extension for timeline semaphore
2020-07-27 tony@lunarg.com gpu: Fix validator settings for instrumentation
2020-07-27 tony@lunarg.com tests: Add copyright to gpu tests
2020-07-27 tony@lunarg.com tests: Add debug printf mesh shader test
2020-07-27 tony@lunarg.com tests: Add gpu-av mesh shader test
2020-07-27 tony@lunarg.com gpu: Add missing stages
2020-07-27 tony@lunarg.com gpu: Add missing draw calls
2020-07-27 tony@lunarg.com build: Update Android known-good
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I8aff86ee0ccb099558a2ee5e3e209b889eadaed2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2322081
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
397bc43c
|
2020-07-28T07:01:36
|
|
Roll SPIRV-Tools from 8b5ed4448dfe to 150be20d4334 (33 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8b5ed4448dfe..150be20d4334
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers from ac638f181542 to 979924c8bc83
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I9cf7e01b69c399bf5c16142b210f1e61f97f8a10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2322082
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
cb418acb
|
2020-07-28T07:01:14
|
|
Roll SwiftShader from 3b2cd31c7400 to 12c9d4ac61f2 (4 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/3b2cd31c7400..12c9d4ac61f2
2020-07-27 sugoi@google.com Manual changes required for SPIR-V update
2020-07-27 sugoi@google.com Merge changes Icf7b69da,I2c88ee38
2020-07-27 sugoi@google.com Merge changes Id54668de,I200b4417
2020-07-27 caramelli.devel@gmail.com Add Wayland support for Vulkan WSI
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I84eb84e7126860ff32b8679feced78b63a213a26
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2322080
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
de309a42
|
2020-07-21T17:19:17
|
|
Vulkan: Make staging buffer per context
Right now staging buffers are per BufferVk. This will make it per
ContextVk so that it can be shared among all objects that needs a
staging buffer.
Bug: b/161846868
Change-Id: I9c436acdacaf429a43cbdfa216927df0796f7a28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310962
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
db88baa8
|
2020-07-23T11:12:46
|
|
Serializes GL context states and reformats frame_capture_utils
Adds the ability to serialize GL context states.
Adds serialization of GL context states to serializeContext method so
that capture replay regression testing now compares the GL context
states.
Reformats frame_capture_utils to make most serialization methods
private, except for the ones called by other classes and template
methods.
Bug: angleproject:4817
Change-Id: I2d53c88be3d503268bd6e2e5058b5fabe0644f67
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314829
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
52d25633
|
2020-07-27T17:37:46
|
|
Disable GPU time tracking in trace tests.
Adds considerable overhead to wall time on Adreno. Not tested on
other platforms.
Bug: angleproject:4879
Change-Id: Ib219f14162fb5768e484f717ed2a870478bd1c86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321404
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
afdea864
|
2020-07-20T17:03:31
|
|
Vulkan: Add cache for driver uniform descriptor set
As we have done for default uniforms and textures, we should cache
descriptorset for driver uniforms to avoid repeatedly create them.
Bug: b/161750230
Change-Id: I0afabb226d5a8e8c7838fa2484ec7f9689ed5fa0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309349
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
248119b3
|
2020-07-20T16:05:45
|
|
Vulkan: Fix render target's tracking of content defined
Imagine the following scenario:
1. Clear draw framebuffer
2. Invalidate draw framebuffer
3. Update texture attached to draw framebuffer
4. Draw again into draw framebuffer
Step 3 could be a number of things, such as glCopyTex[Sub]Image,
glBlitFramebuffer, glTex[Sub]Image2D, glGenerateMipmap etc.
In the above scenario, at step 2, the framebuffer's render target
remembers it being invalidated (mContentDefined = false). This is used
to set the loadOp of the next render pass to DONT_CARE.
However, mContentDefined was implemented for a very specific
optimization regarding the swapchain's depth buffer. The reuse of this
variable for glInvalidateFramebuffer was erroneous as this variable
didn't track whether the contents are defined for the general case.
With this change, mContentDefined is set to true during
FramebufferVk::syncState for each render target whose contents are
marked dirty.
This change additionally makes glBlitFramebuffer signal the contents of
the blit targets as dirty, as well as textures that are used as storage
images.
Bug: angleproject:4859
Change-Id: I68c829f75ff4a3d03bb293ec72c609384983026d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309110
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
2c3ff0a0
|
2020-07-25T11:35:19
|
|
Vulkan: Enable VK_KHR_get_memory_requirements2 extension
Don't assume support for VK_KHR_get_memory_requirements2,
enable the extension, if supported, during device creation.
Bug: angleproject:4830
Change-Id: I0faf955aac8a2ae4dea636f349225672e6717662
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319079
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
cf49403e
|
2020-07-21T11:40:56
|
|
Vulkan: Increase default uniform buffer size to 64K
Since these are per context, we can increase it (and subject to the
driver maxUniformBufferRange limit) to reduce the amount of descriptor
set allocated.
Bug: b/161391337
Change-Id: I89e5cf16ee377735c412e9a9a22c651e1c677ded
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310910
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
308078b0
|
2020-07-24T11:02:21
|
|
Tests: Add getProcAddress method to GLWindowBase.
This will allow the Trace tests to load a custom GL after the GL
window has already loaded the default entry points.
Bug: angleproject:4845
Change-Id: Ic1b65b6cf1a582ea7c2f58a9f76077760e5cf0d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315626
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
dcdd6b6a
|
2020-05-14T14:36:31
|
|
Vulkan:Enable Validation best practices layer
When Vulkan Validation layers are enabled, also enable the
validation best practices layer which includes ARM's perfdoc
layer. Initially adding skips for all of the best practices
errors that are triggered so that these can be enabled by default.
Bug: b/156661359
Change-Id: I7eab9710bf9632d07ff6b80375d3ad1789d58f7c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2202634
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
8765b46a
|
2020-07-15T17:10:35
|
|
Vulkan: Make mDefaultUniformStorage per ContextVk
Right now the dynamic buffer for default uniform is per program. Most of
time the buffer is unused. That is a huge waste of memory (and these
memory are wired memory). This CL moves the mDefaultUniformStorage from
per ProgramVk to ContextVk so that we all share with each other.
Bug: b/161391337
Change-Id: I1fe8523b2b2dbc39bec3509a3432e38e34bd5713
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2274870
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
d92c4ab6
|
2020-07-24T15:26:53
|
|
Add GGP to Platform Support table
Bug: angleproject:4874
Change-Id: I0a497719b00330407b5755d64153315115a95b48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2318047
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
62b11a47
|
2020-07-23T16:35:29
|
|
X11: cast native display type to XDisplay.
This is required to have use_x11 && use_ozone builds at the same time.
Bug: chromium:1085700
Change-Id: I3d4cdf590e1ecf79af9e2d4bd585955c3f1b7af6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315031
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
3b0c9918
|
2020-07-21T11:52:13
|
|
Update CaptureAndReplay.md and Python script with links
Links to the Python script in CaptureAndReplay.md
Links to CaptureAndReplay.md's testing section in the Python script
Bug: angleproject:4817
Change-Id: I584f8508661950e4907dae1adb8f0fe300387198
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309226
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
4ccf4d0a
|
2020-07-27T07:01:14
|
|
Roll SwiftShader from 6a8a74986c35 to 3b2cd31c7400 (9 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/6a8a74986c35..3b2cd31c7400
2020-07-26 capn@google.com Update Vulkan headers to version 1.2.148
2020-07-26 capn@google.com Refactor native instruction intrinsics
2020-07-24 amaiorano@google.com Delete third_party/llvm-7.0
2020-07-23 sugoi@google.com Add basic support for VK_EXT_debug_utils
2020-07-23 srisser@google.com Add support for depthBiasClamp
2020-07-23 spang@chromium.org Silence warnings on dedicated external memory allocations
2020-07-23 capn@google.com Regres: Roll dEQP to 1.2.3
2020-07-23 amaiorano@google.com Fix CMake failure on MacOS when PowerVR submodule is checked out
2020-07-23 capn@google.com Don't update CMake for Windows Kokoro builds
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I51df404988b223be4c2e2a3d30891c86797e4b8f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319979
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
45de2793
|
2020-07-27T07:01:26
|
|
Roll Vulkan-ValidationLayers from adf938680697 to 361fb5311b9b (13 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/adf938680697..361fb5311b9b
2020-07-24 jzulauf@lunarg.com syncval: Update ordering/most recent hazard checks
2020-07-24 mikes@lunarg.com build: Handle glslang static lib dependency cycles
2020-07-23 christophe@lunarg.com doc: Highlight Vulkan Configurator
2020-07-23 christophe@lunarg.com doc: Fix links on LunarXchange
2020-07-23 jeremyk@lunarg.com tests: Add test for corner sampled with CtE
2020-07-23 jeremyk@lunarg.com layers: Add check for corner sampled with CtE
2020-07-23 jeremy@lunarg.com tests: Fix push-constant test
2020-07-23 s.fricke@samsung.com tests: Add export AHB positive tests
2020-07-23 s.fricke@samsung.com layers: Fix exported AHB checking allocationSize
2020-07-23 s.fricke@samsung.com tests: AHB test for bindBufferMemory
2020-07-23 s.fricke@samsung.com layers: Remove AHB bindBuffer VUs
2020-07-23 mark@lunarg.com chassis: Move layer option handling into separate files
2020-07-23 mark@lunarg.com chassis: Localize config and env settings handling
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Ibb4a62f4c004feb6aaac60e9612c33d7c78205d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319980
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
c3ccd3a7
|
2020-07-27T07:01:51
|
|
Roll Vulkan-Headers from 83825d55c7d5 to a0f1f5149d91 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/83825d55c7d5..a0f1f5149d91
2020-07-23 git@haasn.xyz Fix enum order for backwards compatibility
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Change-Id: I25985607c096ddf8f17736410e7224a805f2b0e4
Bug: None
Tbr: timvp@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319864
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
3f851efa
|
2020-07-24T14:54:37
|
|
Vulkan: Fix overflow in maxCombinedUniformComponents
The value is capped to INT_MAX to avoid overflow when queried with
glGetIntegerv().
Bug: angleproject:4554
Bug: angleproject:4788
Change-Id: I36d52fc608ef5adc2bc0b73e379db66cbfd9bb54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2318046
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
07ae186b
|
2020-07-24T10:55:33
|
|
Capture/Replay: Update headers.
Instead of including "angle_trace_gl.h" in shared capture header
we can include it in each cpp file. This prevents a header conflict
with the "old" way of using the util GL loader.
Bug: angleproject:4845
Change-Id: Ia00a2beffc77446c779ceec8995fce9704e7b8af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315625
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
8adc5469
|
2020-07-02T10:15:17
|
|
Vulkan: Generate mipmap in compute
An initial implementation based on AMD's FFX SPD (Single Pass
Downsampler).
Apart from requiring STORAGE_IMAGE support for the image format, the
following limitations are in place due to FFX SPD:
- Image must be 2D or 2D array (including cube maps)
- Image must be single-sampled
The following _can_ be supported, but not yet implemented:
- sRGB formats
- Integer formats
- depth/stencil formats
Bug: angleproject:4551
Change-Id: Ibc4d5cea701cca31e55e3d651540872bbd3b473f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2278713
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
bef908ee
|
2020-07-24T12:53:13
|
|
Enable KHR GLES31 tests blocked on Issue 4146
The KHR GLES31 tests disabled and marked with Issue 4146 are passing,
likely due to the work for Issue 3570: Vulkan: Implement separate
shader objects or program pipeline objects. This CL re-enables the
tests.
Bug: angleproject:4146
Bug: angleproject:3570
Test: KHR-GLES31.core.shader_storage_buffer_object.basic-syntaxSSO
Test: KHR-GLES31.core.vertex_attrib_binding.advanced-bindingUpdate
Test: KHR-GLES31.core.vertex_attrib_binding.advanced-largeStrideAndOffsetsNewAndLegacyAPI
Change-Id: I4e42129c873604c937cf03412a105170755413e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2318265
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
43b951c8
|
2020-07-21T17:36:06
|
|
Remove third_party/angle/ from generate_android_bp.py
Android builds are failing due to .git/HEAD being listed in the
Android.bp, which generate_android_bp.py is supposed to remove. The
problem is that the blacklist contains '//third_party/angle/.git/HEAD'
rather than '//.git/HEAD', due to generating the GN files from
chromium/src/ rather than angle/. This CL cleans this up.
Bug: b/160727922
Test: Manual script execution and building in AOSP
Change-Id: Ia1682605097791d20b28686f3043ddc08d49ca52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310960
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
df5ed61d
|
2020-07-23T07:01:26
|
|
Roll Vulkan-ValidationLayers from d92ddcef72ef to adf938680697 (9 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d92ddcef72ef..adf938680697
2020-07-22 jeremy@lunarg.com layers: Improve push constant error logging
2020-07-22 jzulauf@lunarg.com syncval: Cleanup of extraneous tags, user doc revs
2020-07-22 jzulauf@lunarg.com syncval: Style cleanup design/add user doc
2020-07-22 jakub@okonski.org Revert "Simplify the guard around ValidateMaxTimelineSemaphoreValueDifference"
2020-07-22 jakub@okonski.org Add a test for binary semaphore value difference checks
2020-07-22 jakub@okonski.org Simplify the guard around ValidateMaxTimelineSemaphoreValueDifference
2020-07-22 jakub@okonski.org Fix timeline semaphore value difference validations on binary semaphores
2020-07-22 christophe@lunarg.com doc: Add links to per-feature docs
2020-07-22 tony@lunarg.com tests: Skip test if limits are very large
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Ie3197c42fb6e55018ec373f6851424596ba03252
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315295
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
3c3470b9
|
2020-07-23T07:01:20
|
|
Roll glslang from 11fa4d0d5694 to 3ee5f2f1d331 (3 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/11fa4d0d5694..3ee5f2f1d331
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I659c87076350acbd56ccbfdcb0751bb152fa72d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315294
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
201d43ae
|
2020-07-23T07:01:14
|
|
Roll SwiftShader from f272427bda39 to 6a8a74986c35 (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f272427bda39..6a8a74986c35
2020-07-22 amaiorano@google.com Fix ReactorDebugInfo off by one line issues
2020-07-22 amaiorano@google.com Fix GN debug builds of SwiftShader on LLVM 10
2020-07-22 tommek@google.com Fix copying between images and buffers with padding
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: angleproject:4861
Tbr: timvp@google.com
Change-Id: I4a7da511bda78aa04b627cb3ba3ac79bc74a0c48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315293
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
f359cb66
|
2020-07-02T15:15:54
|
|
Reland: Refactor DisplayGbm::generateConfigs
We should explicitly set EGL_SURFACE_TYPE to EGL_DONT_CARE.
Otherwise, it's default value is EGL_WINDOW_BIT. However,
on some platforms, only EGL_PBUFFER_BIT is supported.
In this case, no matching config is found. So mWindowSurface
and mPbufferSurface will be nullptr. That's why we see
the bot failed.
Bug: chromium:1105208
Change-Id: I8ee2487fd24bab86a5ec22fbe7b8ff68081bc15c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304429
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
074bc23f
|
2020-07-21T18:11:57
|
|
Implement DRM_FORMAT to GL format conversion
Bug: chromium:1096442
Change-Id: I79722073bd1f2674b40e7eaa8d5311a09bc36416
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309636
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
ca8f856a
|
2020-07-22T13:56:40
|
|
Tests: Update gfxbench traces
Migrate from traces recorded on desktop to traces recorded
on a Pixel 4 XL. This impacts the resolution and framebuffer
config used for the tests. They now more accurately reflect
the numbers seen from running the benchmark directly.
Test: angle_perftests --gtest_filter=TracePerfTest.Run/*
Bug: angleproject:4048
Change-Id: Ib013dfb35c32c6f97bcae76a74cc16d9a5d1a369
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314896
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
ffb31229
|
2020-07-22T12:02:54
|
|
Capture/Replay: Enable capturing slingshot scenes
Implemented parameter capture functions for:
glGetActiveUniformsiv
glGetActiveUniformBlockName
glGetActiveUniformBlockiv
Added a check for bound unused locations when capturing glLinkProgram
Changed CaptureGetParameter to always request a gReadBuffer allocation
of the maximum reported possible array size needed to query
GL_COMPRESSED_TEXTURE_FORMATS. Recording the value on the capturing
device would previously have buffer overflow issues when the replaying
the capture on a device with more formats available.
Changed VertexAttribType::UnsignedInt2101010's string to reflect the
correct type
Bug: angleproject:4834
Change-Id: Icd1ff404369ae9f18cad7cd4f56fbcccc89e7e98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306735
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
a4535c18
|
2020-07-22T14:52:26
|
|
Fix trace tests auto-generation.
This moves the trace header inclusion to the cpp file so that the
test itself doesn't need to look at the individual trace headers.
This fixes an include directory dependency. Also removes the FBO
change callback from the generated traces.
Bug: angleproject:4845
Change-Id: I019f0d347a62a81b92bf32110572911111212689
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314217
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
9faf0cdc
|
2020-07-20T10:30:55
|
|
Capture/Replay: Use custom GL header.
This will let us override the util loader for all new traces. It will
also be easier to maintain going forward if we have to change the
header again.
The end goal is to run the trace tests with a custom GL layer that can
intercept certain API calls.
Bug: angleproject:4845
Change-Id: I028a1afdadf638998805d7b9a2cc6717cf5f0148
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2308029
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
ab95a449
|
2020-07-20T12:12:18
|
|
Textures that have bound surfaces are always renderable.
Chrome still tends to use ES2 contexts for most rasterization. This is a
problem when trying to use FP16 IOSurfaces for rendering HDR because
GL_RGBA16F is not renderable in ES2. Since a surface is always
renderable, allow rendering to any textures with a bound surface.
Update the tests to verify that ES3 formats can be used with ES2
contexts.
Add tests for RGBA16F IOSurfaces.
BUG: chromium:1103112
Change-Id: I9e8c082fc97a0e072289b097e71fc944988d4872
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307454
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
ee9c4fe4
|
2020-07-14T15:29:40
|
|
D3D: Make possible to build angle without D3D11
A few files inside the D3D11 tree are used by D3D9 and WGL backends. We
add these files to the build system even when D3D11 is disabled.
Also, we fix the use the of ANGLE_DEFAULT_D3D11 symbol.
Bug: angleproject:4839
Change-Id: I981f4bfc60d973c02549caa737c5aed5ccf31282
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2298143
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
f3c72fdf
|
2020-07-22T07:01:20
|
|
Roll glslang from b99a6a727318 to 11fa4d0d5694 (3 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b99a6a727318..11fa4d0d5694
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Ic08523541b7efe21d00e2b410ca014cc18f6f661
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311940
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
d17b53d1
|
2020-07-22T07:01:32
|
|
Roll Vulkan-Tools from 50e737c82347 to 3b36fdc64014 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/50e737c82347..3b36fdc64014
2020-07-20 shannon@lunarg.com build: Update known-good files for 1.2.148 header
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I34c9270fdfc6581e546f7861cd7294e0213d45ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311941
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
c0482a16
|
2020-07-22T07:01:14
|
|
Roll SwiftShader from 97f9923235cf to f272427bda39 (7 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/97f9923235cf..f272427bda39
2020-07-21 capn@google.com Eliminate dead host/target feature code for Subzero
2020-07-21 amaiorano@google.com Fix ENABLE_RR_DEBUG_INFO on LLVM 10
2020-07-21 amaiorano@google.com Remove support for LLVM < 10
2020-07-21 amaiorano@google.com Delete LLVM 7 Kokoro configs
2020-07-21 amaiorano@google.com Fix LLVM-10 CMake build
2020-07-21 swiftshader.regress@gmail.com Regres: Update test lists @ 97f99232
2020-07-21 capn@google.com Regres: Don't test changes with negative scores
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I7a23451d6fef9da2f33b5d62b078ce9b0072ac27
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311730
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
62b67239
|
2020-07-22T07:01:26
|
|
Roll Vulkan-ValidationLayers from 7cc0ead05174 to d92ddcef72ef (3 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7cc0ead05174..d92ddcef72ef
2020-07-21 jzulauf@lunarg.com syncval: Cleanup document from autogeneration
2020-07-21 mark@lunarg.com tests: Add test for non-device concurrent buffer qfamily
2020-07-21 mark@lunarg.com corechecks: Check CONCURRENT_MODE against ALL pdev qfamilies
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Id0295628171dae6f3198bbe1dcb5fa55496ad115
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311731
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
f6659b3d
|
2020-07-20T15:55:52
|
|
Vulkan: Fix invalidate + deferred clear
Imagine the following scenario:
1. Clear draw framebuffer
2. Invalidate draw framebuffer
3. Copy from read framebuffer into texture that is attached to draw
framebuffer
4. Draw again into draw framebuffer
At step 2, FramebufferVk::syncState is called which extracts the clear
and stores it in mDeferredClears, but since the framebuffer description
hasn't changed, a new render pass is not started.
At step 3, the texture attached to the draw framebuffer is used as copy
destination, but its clear which is stored in the (apparently
irrelevant) draw framebuffer is not flushed.
At step 4, a new render pass is started which clears the draw
framebuffer, trampling the copy in step 3.
This change makes sure invalidate results in a flushDeferredClears().
With glInvalidateFramebuffer() (not glInvalidateSubFramebuffer()), the
deferred clears for invalidated framebuffers are discarded first.
It is unknown whether there are similar situations where syncState
gathers deferred clears, but they are not flushed before the attachments
are updated outside the framebuffer. To catch similar bugs in the
future, assertions are added to FramebufferVk::syncState such that if a
dirty bit is set for the contents of an attachment, we can make sure
there are no prior deferred clears stored for that attachment.
Bug: angleproject:4862
Change-Id: Idb1a08b53e7f011f0fc9a54d478289030b6d77a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2308034
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
c757e607
|
2020-07-21T10:18:41
|
|
Vulkan: Fix deferred clears and noop clear and blit
Imagine the following situation:
1. Clear draw framebuffer
2. Noop operation on the framebuffer (Clear, ClearBuffer,
BlitFramebuffer with flags specifying non-existing attachments)
3. Change framebuffer's attachment
4. Draw into framebuffer
At step 2, FramebufferVk::syncState was called before noop-ing the
operation. During syncState, deferred clears were stored in the
framebuffer and weren't flushed because the actual operation was not
performed.
At step 4, the deferred clear meant for the prior attachment gets
applied to the new attachment.
Bug: angleproject:4865
Change-Id: I5b096bacf00356b4dccd4cbc9561b87b1bb557d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309224
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
93eb633c
|
2020-07-07T15:41:38
|
|
Inline depth/stencil clear if in middle of renderpass
Some apps have a pattern where they clear the depth & stencil buffers
in the middle of the frame which causes the Vulkan backend to stop the
existing render pass and start a new one. This causes more loads &
stores of buffer contents than if we inline that clear with a draw.
Bug: b/159808300
Bug: angleproject:4695
Change-Id: I7a15af22f47a81051fa33fa19eaa123d8b66597c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289945
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
964c4089
|
2020-07-21T14:08:21
|
|
Vulkan: fix RenderPassDesc::mColorAttachmentRange
This variable tracks the index range of color attachments. A previous
change (d8ce865b5fd113d8e0cec4368a9a192a524566a1) made the range
inclusive so it can fit in 3 bits, but that's incorrect as it's no
longer possible to specify a range where no color attachments are
present.
This change partially reverts d8ce865b5fd113d8e0cec4368a9a192a524566a1
to restore the previous semantics of
RenderPassDesc::mColorAttachmentRange.
Bug: chromium:1107884
Change-Id: I08da2568b5e63a48a672edd499a8b6653060eadb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310578
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
6ca2c116
|
2020-07-17T13:07:24
|
|
Make trace tests a shared library.
This will facilitate intercepting the GL calls and implementing
emulation paths for offscreen redering. Or other EGL/GL features.
It does not yet override the GLES loader and uses the shared
'angle_util' loader as it did before.
Bug: angleproject:4845
Change-Id: I68806c307f59e1852999299e88dc358781817f12
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305042
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
4fa75b5c
|
2020-07-17T12:58:50
|
|
Move restricted trace functions to cpp file.
This is a refactoring change only. It will facilitate moving these
functions to a shared library. A shared library will allow us to more
easily override GL functions with an interception layer. The intercept
layer will allow us to do emulation for features like offscreen tests.
Bug: angleproject:4845
Change-Id: I0e00c0c22a26f1bb8faec30a825c71953033f8a9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305039
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
23211585
|
2020-07-21T10:08:03
|
|
Roll chromium_revision b0410bba02..fb6cbaf6e5 (763000:790363)
Also updates a Vulkan back-end file to not return error.
Change log: https://chromium.googlesource.com/chromium/src/+log/b0410bba02..fb6cbaf6e5
Full diff: https://chromium.googlesource.com/chromium/src/+/b0410bba02..fb6cbaf6e5
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/45ab3c89af..1ee11394cf
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/204a35a2a6..9e121212d4
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3993ef1f52..f126fc6578
* third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/36657c103c..9c8566e047
* third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/217407c478..defbf92951
* third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/{chromium_..ec647b85b6
* third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/4fa54ca5f7..19f3fad68d
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/ae385786ed..89bddfee9c
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/04b99e7bf9..6412135b39
* tools/md_browser: https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/aae45d8d82..be8cf5a17d
DEPS diff: https://chromium.googlesource.com/chromium/src/+/b0410bba02..fb6cbaf6e5/DEPS
Clang version changed 4e0d9925d6a3561449bdd8def27fd3f3f1b3fb9f:04b9a46c842f793a2baedcad64de35fcbd3e93b7
Details: https://chromium.googlesource.com/chromium/src/+/b0410bba02..fb6cbaf6e5/tools/clang/scripts/update.py
Bug: angleproject:4867
Change-Id: I184945ad4d1fc39f4ad9b37cbf411b2c2b74a3ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309223
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
1cfc6f0a
|
2020-07-20T16:03:38
|
|
Add test for deferred clear + attachment gaps
This test makes sure the list of clear values given to the render pass
(for deferred clears) are correctly passed.
Bug: angleproject:4862
Change-Id: I4830a72a6f2b01570f6d4427ffb025429b5aa03c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309109
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
16856027
|
2020-07-08T13:47:33
|
|
Support EXT_shader_texture_lod on Vulkan.
Bug: angleproject:2899,b/161716126
Change-Id: Ia850cbda948c8f6da9ced0bf46fd7f8371125032
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2288333
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
10e9e9a1
|
2020-07-13T17:02:38
|
|
Apply multiprocessing to capture_replay_tests.py
Multiple tests are run in paralell to squeeze the most out of CPUs.
Tests are stored in a work queue. Whenever a CPU becomes available,
the next unrun test is grabbed and run on a spawn process on that CPU.
Each cpu gets their own environment and build folders and trace folders
so that tests don't overwrite each other.
Bug: angleproject:4817
Change-Id: Ifd35c9c75522e480b0257d090d5af70f2a3428ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2296040
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
7c79945a
|
2020-07-21T11:30:01
|
|
Roll VK-GL-CTS from 30aa06f22718 to 4b40207be32d (6 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/30aa06f22718..4b40207be32d
2020-07-21 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master
2020-07-21 alexander.galazin@arm.com Remove Amber example test
2020-07-20 slawomir.cygan@intel.com Reintroduce excluded dEQP-VK.binding_model.descriptorset_random tests
2020-07-20 alexander.galazin@arm.com Update Vulkan headers
2020-07-20 gary.sweet@broadcom.com VK_EXT_image_robustness tests
2020-07-20 alexander.galazin@arm.com Update glslang, SPIR-V Headers and tools
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-bots+autoroll-info@google.com,timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: angle-bots+autoroll-info@google.com,timvp@google.com
Change-Id: Ie3adac45f59f362fefc67f759356d26924e84d1f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309638
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
0dd63428
|
2020-07-21T07:01:55
|
|
Roll Vulkan-Loader from dd3511549b18 to bfe4f378aee6 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/dd3511549b18..bfe4f378aee6
2020-07-20 shannon@lunarg.com build: Update known-good files for 1.2.148 header
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I71939d8fdd18bdf762eaa8f76106bdc801cd26cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309668
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
3045ca3a
|
2020-07-21T07:01:55
|
|
Roll SPIRV-Tools from 717e7877cac1 to 8b5ed4448dfe (3 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/717e7877cac1..8b5ed4448dfe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I7d8f1390f84432f7f5409e869d1c4ecd4dca3653
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309789
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
a27692d1
|
2020-07-21T07:01:58
|
|
Roll SwiftShader from ea6f21a052c9 to 97f9923235cf (4 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/ea6f21a052c9..97f9923235cf
2020-07-20 mark@chromium.org Fix macOS arm64 GN build by building llvm RWMutex.cpp
2020-07-20 ddorwin@google.com Update tests/presubmit.sh with modern syntax for Fuchsia bugs
2020-07-20 amaiorano@google.com Update to latest PowerVR to keep cmake source clean
2020-07-20 capn@google.com Support _PACK32 storage image formats and fix asserts
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I33b83dbecc68115347b146721180c628bfd3c998
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309790
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
d0057db3
|
2020-07-21T07:01:09
|
|
Roll Vulkan-ValidationLayers from b1346703979e to 7cc0ead05174 (5 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b1346703979e..7cc0ead05174
2020-07-20 locke@lunarg.com syncval: Add descriptor type and image layout
2020-07-20 jzulauf@lunarg.com syncval: Add heuristic to suppress safe WAW msg
2020-07-20 jzulauf@lunarg.com syncval: Add additional access info to hazard msg
2020-07-20 shannon@lunarg.com build: Update known-good files for 1.2.148 header
2020-07-20 tony@lunarg.com tests: Avoid "abort, retry, ignore" dialog boxes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I502f7d36f6e4aad6f3b51a93b8d69ec45461dea0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309666
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
4ce72e14
|
2020-07-21T07:01:44
|
|
Roll glslang from 9eef54b2513c to b99a6a727318 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9eef54b2513c..b99a6a727318
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Ib84d914c6ab19a88a93ea9662dc09ecae50e581d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309667
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
d9818fd6
|
2020-07-19T00:37:21
|
|
Vulkan: Improve RenderTargetVk's getImage interface
Prior to this change, RenderTargetVk had getImage() and
getImageForWrite(). This change introduces getImageForCopy() and
renames getImage() to getImageForRenderPass().
Currently, all three functions do the same thing. However, with
upcoming changes the semantics will be different:
- getImageForRenderPass(): This is the image used as the non-resolve
attachment. When resolve attachments are introduced, there will be a
corresponding getResolveImageForRenderPass().
- getImageForCopy(): When GL_EXT_multisampled_render_to_texture is
implemented, this will return the image that owns the data.
- getImageForWrite(): Similar to getImageForCopy(), but should set
mContentDefined. This is currently missing, and is a bug that will be
resolved in a follow up.
This split change gets the mechanical rename out of the way to make
future changes simpler.
Bug: angleproject:4836
Bug: angleproject:4859
Change-Id: I5f7657cc049c0e1772a7c510e74289e685ba93c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306516
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
20eb9be5
|
2020-07-07T16:24:55
|
|
Generate Android.bp from multiple gn descriptions
With the introduction of ABI-specific build targets (zlib), the script
generate_android_bp.py needs to be updated to consume ABI-specific gn
descriptions and generate ABI-specific build rules for each target.
The roll_aosp.sh script was updated to generate ABI-specific gn
descriptions for each:
arm
arm64
x86
x64
Bug: b/160727922
Test: Manual script execution and building in AOSP
Change-Id: I459b388176f8fcc010f9f5668535d941b931cdd4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2285272
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
80d7725d
|
2020-07-15T15:14:17
|
|
Use Subject/Observer pattern for Programs/Executables in PPOs
This CL updates the frontend to use the subject/observer pattern for
Programs and ProgramExecutables in PPOs.
This allows us to remove the hack that iterated through all PPOs and
marking them all dirty when a Program is re-linked. Instead, just the
PPOs the Program is bound to are signalled, and only when the Program
is in a PPO.
Additionally the necessary PPOs are signalled when an Executable's
textures are updated, rather than iterating through all PPOs and
signalling them.
Bug: angleproject:4559
Test: CQ
Change-Id: Iaefb88c64c13259e921c8dfe95cf640247d17f85
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300705
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
d8ce865b
|
2020-07-19T00:20:17
|
|
Vulkan: Make room in RenderPassDesc for resolve attachments
Data in RenderPassDesc is packed better to make room for resolve
attachments (9 bits made available; 8 for color and 1 for
depth/stencil).
mColorAttachmentRange contains values in [0, 8). The right side of the
range is made inclusive (i.e. [0, 7]) so it will fit in 3 bits.
The number of samples is always a power of 2, and below 128 (for the
foreseeable future), so its log is stored instead in 3 bits.
This change doesn't add support for resolve attachments yet, but is
split off the one that does to simplify it.
Bug: angleproject:4836
Change-Id: I2856286d5239499d0ab0c78b8154881c003309bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306515
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
7e2a9820
|
2020-07-20T12:38:05
|
|
Vulkan: Make explicitly-[non-]rotated get methods
Split FramebufferVk::getCompleteRenderArea() into 2, [non-]rotated,
explicitly-named methods. Simplify the uses of these methods, and fix
some rotation cases. Also explicitly-name
FramebufferVk::getScissoredRenderArea().
Bug: b/151111296
Change-Id: I1754ec2796fd8625b916a2dba2e723e70ecba419
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305389
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
bdc79361
|
2020-07-15T17:01:05
|
|
Vulkan: No need to add current buffer into mResourceUseList
This is follow up to
https://chromium-review.googlesource.com/c/angle/angle/+/2288325. There
is no need to add current buffer to mResourceUseList for the per context
dynamic buffers. These dynamic buffers always shut down after we
call finishImpl.
Bug: b/160777679
Change-Id: I013cb3c30b4d31804cee13ce9e42da381fd1ae1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300208
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
|
|
cd5489ad
|
2020-07-19T00:05:21
|
|
Vulkan: Faster FramebufferDesc compare
Objects of this class are used as keys to a hash map and contain 10
serials. Prior to this change, operator== would compare all 10 serials.
This change tracks the maximum index set and only compares up to that
many serials.
To make sure this maximum index stays low in the presence of
depth/stencil attachment, this class stores the depth/stencil
attachment's serial before the color attachments. The update API of the
class is improved so this implementation detail is not leaked.
This is in preparation for supporting resolve attachments, which would
add another 8 serials to the class. With this change, the performance
of cases that don't use resolve attachments won't be affected.
Bug: angleproject:4836
Change-Id: Ia4874ab79163901fb86f5bee4120e9f19babdc09
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306514
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
234be194
|
2020-07-15T14:55:18
|
|
Vulkan: Move mEmptyBuffer from program to ContextVk
And merge that with TheNUllBuffer as well so that you only have one
dummy buffer per context.
Bug: b/161391337
Change-Id: I75fddb5c48393876e745ff237e11d9c5672ae10e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300707
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
0df0b79c
|
2020-07-17T16:26:21
|
|
Vulkan: Optimize changing texture max level
For applications that frequently change the texture max level, to a
value that is a subset of the texture's maximum levels, just recreate
the VkImageView's.
Test: NBA 2K20 game play
Bug: b/160976091
Change-Id: I62a05a90cdb90147056ba8cec960c2114479ec37
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300532
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
49108a12
|
2020-06-30T11:53:23
|
|
Support BGRA_1010102 IOSurfaces in CGL and Vulkan.
Bug: chromium:1100599
Change-Id: I7bc2c2e35490e28e9f6fe8f2e0c26cdea50650b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2275731
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
5671c2bd
|
2020-07-17T13:32:22
|
|
Capture/Replay: Fix vertex array objects for MEC
While debugging NBA2K20 MEC, fixed the following issues:
* Don't bind built-in attributes locations.
* Don't emit glGenBuffers for the default VAO.
* Include element array buffer in MEC.
Test: NBA2K20 MEC
Bug: b/160014453
Change-Id: I1b809946d67b6748b0670814be8dd090278dc38f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307276
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
55e85549
|
2020-07-17T14:02:36
|
|
Lift warning from trace tests.
Noticed when working on a related feature.
Bug: angleproject:3630
Change-Id: I82638d37ee6d27dc824d5782c96387f0d000d585
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305040
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
0d8a4da6
|
2020-07-20T07:01:10
|
|
Roll Vulkan-ValidationLayers from 412b1b7dd18c to b1346703979e (3 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/412b1b7dd18c..b1346703979e
2020-07-17 40687079+rumblehhh@users.noreply.github.com corechecks: Default init ACCELERATION_STRUCTURE_STATE members
2020-07-17 locke@lunarg.com syval: Get sub extent by aspect
2020-07-17 locke@lunarg.com tests: Add comment
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: I72073f78cd0df32d9695b84222dfb96174dd3f51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307057
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
b9411968
|
2020-07-20T08:20:41
|
|
Roll Vulkan-Headers from 858b13a1220a to 83825d55c7d5 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/858b13a1220a..83825d55c7d5
2020-07-20 oddhack@sonic.net Update for Vulkan-Docs 1.2.148
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Change-Id: I8963f84e3fac3b06974e23843617c9014ba0f39f
Bug: None
Tbr: timvp@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307169
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
a4b01730
|
2020-07-20T07:01:58
|
|
Roll SwiftShader from 0a8f44c514ce to ea6f21a052c9 (9 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/0a8f44c514ce..ea6f21a052c9
2020-07-18 capn@google.com Fix GN UBSanVPtr build of LLVM 10 JIT
2020-07-17 amaiorano@google.com Fix Win32 Chromium and ANGLE builds
2020-07-17 capn@google.com Remove Travis CI and AppVeyor build badges
2020-07-17 capn@google.com Update Kokoro's clang-format to version 10
2020-07-17 amaiorano@google.com Fix MacOS Chromium build (source_set dupe)
2020-07-16 amaiorano@google.com Fix MacOS (darwin) Chromium build on LLVM 10
2020-07-16 amaiorano@google.com Added Fuchsia support to LLVM 10 update script and updated configs
2020-07-16 amaiorano@google.com Use LLVM 10 instead of 7 for GN builds
2020-07-16 cwallez@chromium.org Fix B<->T copies of multiple array layers and unpacked rowpitch
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: angleproject:4851
Tbr: jonahr@google.com
Change-Id: I516b970e7a306734cd85238c405e9ba7a87c68bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307061
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
a48e333f
|
2020-07-20T07:01:55
|
|
Roll Vulkan-Tools from d093d9723b7c to 50e737c82347 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d093d9723b7c..50e737c82347
2020-07-17 tony@lunarg.com cube: Add option to select phys device
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: I6e85f604ceb2b24bd27a649ff3c7a6abdf4c478b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307060
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|