kc3-lang/angle

Branch :


Log

Author Commit Date CI Message
b7d441e6 2021-02-09 10:01:12 Roll vulkan-deps from d6c9a9f3f705 to f640b7005a0c (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/d6c9a9f3f705..f640b7005a0c 2021-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from db287d4ad474 to b2c81e3615bf (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ifd3d52b5f8828aa3d1f8cf3be6d4aecec0adfb82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683856 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
cd5c27d6 2021-02-09 10:01:07 Roll SwiftShader from 266614a36dbd to 9d35d544ce96 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/266614a36dbd..9d35d544ce96 2021-02-08 amaiorano@google.com Make vk-unittests use VulkanWrapper If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I1a87604249b72aab496adfef32e05ef29cd5aba0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683822 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
80335a11 2021-02-09 07:00:22 Roll Chromium from 82fe35376dee to 02dbd1fa1c75 (492 revisions) https://chromium.googlesource.com/chromium/src.git/+log/82fe35376dee..02dbd1fa1c75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a2a134032e..44961f39c0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f86e30675a..dfd112748a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cf4c59a332 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fae3adcf16..8f265d6ddf No update to Clang. Bug: angleproject:5499 Tbr: syoussefi@google.com Change-Id: I8edd0b6d67fd6c01cad722ebc0a719ef44cb3c0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683547 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
4968f6f2 2021-02-04 16:40:36 Move getRendererDescription from ContextImpl to DisplayImpl The other backend description strings are in DisplayImpl. This will help with caching the result of glGetString in the GL backend. Also Update the getters to not be const in order to allow caching. Bug: chromium:1173672 Change-Id: I43df35688762b23429f47f169c04482cf4cd089a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676881 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
e174c358 2021-02-04 15:14:10 GL: Consolidate glGetString calls First step for cacheing the result of glGetString calls is mostly cleanup. Bug: chromium:1173672 Change-Id: I47281a09b9bd5859655d16376977a6eabcfbb3c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676203 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
0ccf1010 2021-02-08 18:13:13 Roll vulkan-deps from 38d88d12b2fd to d6c9a9f3f705 (29 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/38d88d12b2fd..d6c9a9f3f705 2021-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 264cce03f6e4 to db287d4ad474 (2 revisions) 2021-02-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 047a6b59c90b to 264cce03f6e4 (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 6ee1006a4ec9 to 047a6b59c90b (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 773871cc7e99 to 6ee1006a4ec9 (2 revisions) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 3ad7e5fcc0ee to f0c96f40c79d (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 2292623a4339 to 773871cc7e99 (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 4b8c885ffebf to 2292623a4339 (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f11f74348158 to 3ad7e5fcc0ee (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from c91a25af13e1 to f11f74348158 (1 revision) 2021-02-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d68ee750eb0b to 4b8c885ffebf (1 revision) 2021-02-04 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from e3025c6cdeba to d68ee750eb0b (2 revisions) 2021-02-04 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 1c3d365b1008 to e3025c6cdeba (1 revision) 2021-02-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 5c4f421121c4 to 386b4fcb28e5 (1 revision) 2021-02-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from fd5cc6962213 to 6fcd515be5b3 (1 revision) 2021-02-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 5f585ae240dd to 1c3d365b1008 (1 revision) 2021-02-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 669dfd5ce67f to 5f585ae240dd (1 revision) 2021-02-02 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 6668e1afddc9 to 669dfd5ce67f (7 revisions) 2021-02-02 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from d61a7d110d93 to c91a25af13e1 (1 revision) 2021-02-02 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 2b9a7b114eaa to fd5cc6962213 (1 revision) 2021-02-02 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 9166a0677e44 to ec2db85225ab (1 revision) 2021-02-02 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f074521d88d4 to 6668e1afddc9 (2 revisions) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from aa59169d542d to f074521d88d4 (2 revisions) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d825d6bd2084 to aa59169d542d (1 revision) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7687a48e8da0 to d825d6bd2084 (1 revision) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 480d27774986 to 7687a48e8da0 (1 revision) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 81dd1f107ba6 to 480d27774986 (1 revision) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 6d68720cbb5e to 5c4f421121c4 (1 revision) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f7c43377f095 to 6d68720cbb5e (1 revision) 2021-02-01 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 297723d75af4 to d61a7d110d93 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: I5d8c5c6da16d84d92e49299fb5f101417c154eef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679047 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
281c6552 2021-02-05 16:55:09 infra: Remove ssd:0 from builderless config. Unsure why we added this requirement in the past. We shouldn't need to explicitly specify a ssd dimension for the bots. Removing to simplify the migration to .star files. Bug: angleproject:5559 Change-Id: I55484dec74e4274013390d378678824a3ed0778a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2678865 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
9d5fd2e4 2021-02-08 10:01:24 Roll SwiftShader from ff010f9f0131 to 266614a36dbd (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/ff010f9f0131..266614a36dbd 2021-02-05 amaiorano@google.com Fix crash during llvm_shutdown due to init order fiasco 2021-02-05 capn@google.com Reactor: fix using -x86-asm-syntax only on x86 compilations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I15489c0713bb9e11ea828715dd663c358e279791 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2682220 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
5712107a 2021-02-08 07:01:28 Roll Chromium from 19ae187233a0 to 82fe35376dee (607 revisions) https://chromium.googlesource.com/chromium/src.git/+log/19ae187233a0..82fe35376dee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/57d7d0ceae..a2a134032e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b56fbac691..f86e30675a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ab8a40f411 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f18ba70b3a..fae3adcf16 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5c2436468d..de0632cfad * tools/skia_goldctl/linux: 76SWgiS8ELcHcnzwLeB2gpoF28Vg1-g2TYKAteSZ8tUC..RCW4v6H43n2nkU3V54jWsXz5Q1h_OZaV_DcRQNXMV4sC * tools/skia_goldctl/mac: JlJ5LLfSRnkBI9WIgbkLC1xkaj8vjPP2YrpHHnI1XZcC..hwxykGQN8q1I4nBPA93MSwNqdynaW_gYQ3CJwZJLyngC * tools/skia_goldctl/win: EwtBCz0Ab6XGWqTptLtETY6O4_Q1aq96--G4dMUuup0C..XMdzQyfm6ZBS1E6dZSblabBo-_I49Cf38UhKjkyukC8C No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I8b976d1675dc3ee12744f4a5027852bdaa3b306e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679266 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
6b20e1c8 2021-02-07 14:42:54 Tests: Add Hill Climb Racing trace Test: angle_perftests --gtest_filter="*hill_climb_racing*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5626 Change-Id: I64a52a56569ef1e1a219c5d7e931620dcb438f4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2681837 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
8dae4007 2021-02-07 14:18:22 Tests: Add Worms Zone io trace Test: angle_perftests --gtest_filter="*worms_zone_io*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5625 Change-Id: I38bf148409aec4ae15bdf0759676518f44a98359 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2681835 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
580961fb 2021-02-02 10:27:48 Micro-optimizations for setUniform* This CL improves the setUniform* call for the case where the niform component size is 4. In that case, we can issue a single memcpy. This reduces the average wall time of setUniform4fv in our test app by ~20%. Test: Run the dEQP shader tests. Bug: b/179160884 Change-Id: I9352f6188bc87449719aac522d1a2323adf7fca5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2667592 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Doug Horn <doughorn@google.com>
d820ec7b 2021-02-05 10:39:25 Use __system_property* to read Android props ... instead of popen to avoid needing shell_exec permission. Bug: b/179041465 Test: roll_aosp.sh && m && launch Cuttlefish w/ SwANGLE Test: aosp/1574848 presubmit Change-Id: Ie64d2730fd2ea00a1b5089459297ef7ffe98bc59 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676271 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Jason Macnak <natsu@google.com>
0bb520ad 2021-02-05 11:53:11 Tests: Add Romancing Saga trace Test: angle_perftests --gtest_filter="*romancing_saga*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5622 Change-Id: I9f35fd0e0b9897e77f8d56547c2c134638b8b685 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679323 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
ab1f516d 2021-02-05 21:13:25 Skip happy_color trace on Windows AMD Vulkan Bug: angleproject:5623 Change-Id: I75338183c5c1321efd2516ac3a27a83d47c8d29b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679246 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
ce540d8c 2021-02-01 17:38:10 Create MSAA-swapchain windows' VkImages differently The actual VkImage needs to have rotated extents, but the ImageHelper needs to have non-rotated extents in order for the rest of ANGLE's pre-rotation to work. Bug: b/175793022 Change-Id: I6fa25ab8c636886787ac50b194e566111308f30b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2666514 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
d3c00f95 2021-02-05 11:09:27 Tests: Add Rise of Kingdoms trace Test: angle_perftests --gtest_filter="*rise_of_kingdoms*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5621 Change-Id: I148d7ae0c23e0ce8ecf75d12affb4c8dfdc04e1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679221 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
3bb5f1ff 2021-02-04 22:45:33 Tests: Add Clash Royale trace Test: angle_perftests --gtest_filter="*clash_royale*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5620 Change-Id: I13eb10dc84deffa31f0e7fd1f0382e87bf69e46e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2677621 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
b2de0688 2021-02-05 10:01:18 Roll SwiftShader from 14dcbed947ce to ff010f9f0131 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/14dcbed947ce..ff010f9f0131 2021-02-05 capn@google.com Limit Subzero routine stack size to 512 KiB 2021-02-05 capn@google.com Limit LLVM routine stack size to 512 KiB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I22a9fb120bc9965efe370bca7393469e7734bf90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2678021 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
82df8034 2021-02-05 07:00:48 Roll Chromium from f5e138b74576 to 19ae187233a0 (532 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f5e138b74576..19ae187233a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fc04613723..57d7d0ceae * testing: https://chromium.googlesource.com/chromium/src/testing/+log/967a8819da..b56fbac691 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/602133a964..73458740c0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..138dc4ba2e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4ee065a4cc..f18ba70b3a * tools/skia_goldctl/linux: 6LF5F6aXrWP5GXP59OtHK-18DPO1aPrWT-5XYQEaYBMC..76SWgiS8ELcHcnzwLeB2gpoF28Vg1-g2TYKAteSZ8tUC * tools/skia_goldctl/mac: wKJl4xmBqSYjy0jV-1mXCtsx-D8if80AIBo9uiP-nrEC..JlJ5LLfSRnkBI9WIgbkLC1xkaj8vjPP2YrpHHnI1XZcC * tools/skia_goldctl/win: pUKrWuFOfyPuNAzRy9gRHv-8dvvUOzMEHO9KvF9dRMIC..EwtBCz0Ab6XGWqTptLtETY6O4_Q1aq96--G4dMUuup0C No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I478a9000c2cfe454836021163cbd73f67c4ceb9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2677624 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
cf9ca55f 2021-02-04 21:28:17 Tests: Add Happy Color trace Test: angle_perftests --gtest_filter="*happy_color*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5619 Change-Id: I199c066c18412701b710eab66689107b07ec51f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2677219 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
ac8d7807 2021-02-04 20:24:35 Tests: Add Sniper 3D trace Test: angle_perftest --gtest_filter="*sniper_3d*" TBR: jmadill@google.com,timvp@google.com Bug: angleproject:5618 Change-Id: Ie190dea3d5f233fb7f7ed2b10aaab939da4b374e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676790 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
95143f11 2021-02-04 19:32:51 Tests: Add Coin Master trace TBR: jmadill@google.com,timvp@google.com Test: angle_perftest --gtest_filter="*coin_master*" Bug: angleproject:5617 Change-Id: Ief6b9cdb4bc3b52f4085ba08dc32e62db1f8db8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676789 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
e5c5efc0 2021-02-05 02:39:55 Revert "Test Runner: Pick single/multi-process mode automatically." This reverts commit 573d7f34a462fa5b2ca767dd84773ae6fa460d8a. Reason for revert: Breaking ANGLE roll. No-try: true Original change's description: > Test Runner: Pick single/multi-process mode automatically. > > This enables multi-process when running with more than one test > config. This saves developers from remembering to add the arg. > It can also simplify our test configurations by allowing us to omit > the default arguments. On Android by default we stay with single > process. It also changes the --bot-mode flag into --single-process > and --multi-process which override the default behaviour. > > Bug: angleproject:5585 > Change-Id: I3dd885a8a8e6604c224693c546ff5d15224e016e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2664246 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=kbr@chromium.org,syoussefi@chromium.org,jonahr@google.com,jmadill@chromium.org,jonahr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:5585 Change-Id: I11ee1034c301aa246c4b03e29ff9b56235a1005c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676247 Reviewed-by: Jamie Madill <jmadill@chromium.org>
af70ceac 2021-02-04 15:55:43 Tests: Add Fallout Shelter Online trace The trace includes calls to glDrawElements with zero count, but since that causes erros on QCOM, we have commented them out. To see them, grep for the following: glDrawElements(GL_TRIANGLES, 0, Test: angle_perftests --gtest_filter="*fallout_shelter_online*" Bug: angleproject:5615 Change-Id: I7e6a7d99f614884104df7d87dab082bef6d179e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676208 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
953e001e 2021-02-03 14:37:57 Move metadata in OWNERS files to DIR_METADATA files Bug: chromium:1113033 Change-Id: I62504dff4c421eafe2dd23465a85f73c6b8c5a21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673686 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
df48c027 2021-02-02 13:34:29 Vulkan: Don't request aliased FB attachments. This produces undefined pixel values in GL. We can also return UNSUPPORTED if required and still be conformant. This fixes an assert in the gfx-rs portability implementation. Bug: angleproject:5601 Change-Id: Ifb84ad9b5e2365360a81cddba766b0bea81f2d51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2668311 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
18a5e7a6 2021-02-04 11:19:21 Enable packing extensions for the Vulkan backend The following extensions are ES2 extensions which become core in ES3: - EXT_unpack_subimage - NV_pack_subimage Since the Vulkan backend already fully supports ES3, it should be ok to enable these for ES2 contexts. This fixes all YUV related viz_unittests failures when using SwANGLE with the passthrough command decoder. Bug: chromium:1060139 Change-Id: I24ffd7a58f576799b93fe91e6be4032ca3175eda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676201 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
72815904 2021-02-04 07:00:04 Roll Chromium from 6b006f95bb79 to f5e138b74576 (467 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6b006f95bb79..f5e138b74576 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/46a0056a44..fc04613723 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d2dcdd0691..967a8819da * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5c5a2976d5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/455d077360..4ee065a4cc * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7b1875ee59..5c2436468d * tools/skia_goldctl/linux: IVFOp-Te_OC8Hb0U5-sVhId98p1bYPyyIfuRG1_azZEC..6LF5F6aXrWP5GXP59OtHK-18DPO1aPrWT-5XYQEaYBMC * tools/skia_goldctl/mac: A1gA-0qf7jDyzvaC64y1M7gCo29AH4NKhihm_wregxsC..wKJl4xmBqSYjy0jV-1mXCtsx-D8if80AIBo9uiP-nrEC * tools/skia_goldctl/win: blyrcy7Sj3SVM1D1ALLFTRtSxoOKvF0OWnGXubSAbyQC..pUKrWuFOfyPuNAzRy9gRHv-8dvvUOzMEHO9KvF9dRMIC No update to Clang. Bug: angleproject:5236 Tbr: geofflang@google.com Change-Id: I9548e0c201b7befc3aedbfc8124a8b1cd18e3eba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2674782 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
4e8a848d 2021-02-03 14:59:16 Tests: Add Shadow Fight 2 trace TBR: jmadill@google.com,timvp@google.com Test: angle_perftests --gtest_filter="*shadow_fight_2*" Bug: angleproject:5610 Change-Id: I80c6c44e19d77124096ed5970f99fbb6157bf03b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2674482 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
fff0a72e 2021-02-03 14:03:57 Tests: Add Hay Day trace TBR: jmadill@google.com,timvp@google.com Test: angle_perftests --gtest_filters="*hay_day*" Bug: angleproject:5608 Change-Id: Ib0e259f193ed08ac80f1ae7b1a738c62a235d572 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673070 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
63e7ab8d 2021-02-03 13:05:41 Tests: Add One Punch Man trace Full app name is: ONE PUNCH MAN: The Strongest (Authorized) Test: angle_perftests --gtest_filter="*one_punch_man*" Bug: angleproject:5607 Change-Id: Ib887fb06e53238e56ff5b3e2d45e5d37522a87e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673881 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
54367a3e 2021-02-02 19:31:33 Capture/Replay: Support glCopyImageSubData with compressed formats Special Forces Group 2 uses glCopyImageSubData() to copy compressed texture data, which requires special handling for ANGLE's frame capture since compressed texture data can't be read back. To support this, when glCopyImageSubData() is called with textures using compressed formats, a new mCachedTextureLevelData entry will be created for the destination texture which is a copy of the source texture data. Note that this implementation only supports copying the full level data. http://anglebug.com/5604 will track adding support for partial level copies if an app requires that in the future. Bug: angleproject:5592 Bug: angleproject:5604 Change-Id: Ibce13f91f838fd691269c796fbeb5b9c6133c6aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2669955 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
2dfb3fcd 2021-02-03 10:55:58 Tests: Add 8 Ball Pool trace Test: angle_perftests --gtest_filter="*eight_ball_pool*" Bug: angleproject:5606 Change-Id: Ied7392ecb5148280e1b4cee65c7c63a0baee24fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673064 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
2c685a41 2021-02-03 11:20:20 Fix the perf test runner calibration. This path was broken for the white box unit tests. Also adds argparse handling to the runner so we can more flexibly override command line arguments. Previously the broken calibration was causing some of the tests to run only a single test iteration when measuring. This could lead to low quality measurements. Bug: angleproject:5573 Change-Id: Ic1cb2b2553774a361325f290440c40b2ff90db5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2672702 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
89f50584 2021-02-03 08:51:04 Vulkan: Add ExtendedDirtyBitType bitset ExtendedDirtyBitType qualifies DIRTY_BIT_EXTENDED dirtybit. Clip control code path can now set the appropriate ExtendedDirtyBitType when there is a change in state. Also remove the ClipSpaceOrigin member in the Vulkan backend that cached front-end state. Bug: angleproject:5471 Tests: dEQP-GLES2.functional.clip_control.* Change-Id: I8dbb509ef940e7905439d32483fd67a8fc171a6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673062 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
573d7f34 2021-02-01 10:36:56 Test Runner: Pick single/multi-process mode automatically. This enables multi-process when running with more than one test config. This saves developers from remembering to add the arg. It can also simplify our test configurations by allowing us to omit the default arguments. On Android by default we stay with single process. It also changes the --bot-mode flag into --single-process and --multi-process which override the default behaviour. Bug: angleproject:5585 Change-Id: I3dd885a8a8e6604c224693c546ff5d15224e016e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2664246 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
ffb36559 2021-02-03 10:22:43 Tests: Add Temple Run 2 trace TBR: jmadill@google.com,timvp@google.com Test: angle_perftests --gtest_filter="*temple_run_2*" Bug: angleproject:5605 Change-Id: I4b60b5f258e57dda44df9186c981764d4633a277 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673063 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
ad985fcd 2021-02-02 21:35:04 Tests: Add Minecraft trace Test: angle_perftests --gtest_filter="*minecraft*" Bug: angleproject:5603 Change-Id: I8befbbb49762a14beea1863f4bb76e676cde0d8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2669959 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
4e1aa85e 2021-02-02 16:51:39 Tests: Add RAID: Shadow Legends trace Test: angle_perftests --gtest_filter="*raid_shadow_legends*" Bug: angleproject:5602 Change-Id: I4df06d09db57bb3d6ab0dcaf86e84f418c248a0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2668066 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
442472e8 2021-02-03 10:01:18 Roll SwiftShader from 51045556acd0 to 14dcbed947ce (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/51045556acd0..14dcbed947ce 2021-02-03 liyl@google.com Fix macOS arm64 cross compiling. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I71afb0186711130c54362760730df05f0ec4b545 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2671980 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2e54a1e7 2021-02-03 07:54:38 Roll Chromium from 3535b64d3f52 to 6b006f95bb79 (528 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3535b64d3f52..6b006f95bb79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/43a97d34a6..46a0056a44 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1be79fc37c..d2dcdd0691 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5b022f3c5e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ec98581604..455d077360 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ba0ad048f1..7b1875ee59 * tools/skia_goldctl/linux: AyPgwgutb8buiGKwMyMGU2SGR5H8h1Y2XDfiIN2BtzwC..IVFOp-Te_OC8Hb0U5-sVhId98p1bYPyyIfuRG1_azZEC * tools/skia_goldctl/mac: tIfvKvCHGv4G8z3DzRxNQ7W7G95EP9N0R1wbJ_ezmwkC..A1gA-0qf7jDyzvaC64y1M7gCo29AH4NKhihm_wregxsC * tools/skia_goldctl/win: kET1R1m5NBszkTdWAJUnKHE6R3DkKz59FxiaENTn_QgC..blyrcy7Sj3SVM1D1ALLFTRtSxoOKvF0OWnGXubSAbyQC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ic8ac55dba3ba117c7547fd958e317110a586fc80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2671599 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
6cc845bb 2020-12-07 18:14:50 Vulkan: Add support for EXT_blend_func_extended This implementation utilizes vulkan's dualSrcBlend feature. Expose this extension if the underlying vulkan backend allows the use of this feature. Test: angle_end2end_tests --gtest_filter=EXTBlendFuncExtendedDrawTest* Bug: angleproject:5074 Change-Id: I7d2f611df89d65e5cac35158cb5f41a0ebd58aae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2593151 Commit-Queue: Brandon Schade <b.schade@samsung.com> Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
926d1cea 2021-02-01 11:21:23 testing: Add dEQP test merge script. This script will allow ANGLE to process custom logic when we complete a suite of dEQP tests on the bots. The first customization step we can do is merge the myriad batch QPA files into one master QPA file. This script is currently a no-op and will let us set up the merge step so we can test the logic pre-commit. Bug: angleproject:5236 Change-Id: I38d0e359ff7fc6f6f91b5193387c13ff0fc77aa6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2664247 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
4a09df13 2021-02-02 17:52:56 Vulkan:Fix wrong outputCount of emulated RGB copies. The output count of shaderParams equals componentCount divided by Ed. To avoid losing the last data,replace division with UnsignedCeilDivide function. Bug: angleproject:5598 Change-Id: I079d72f4eefa3d6b0f5d80ada25829fea673410c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2666869 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
74761212 2021-02-02 10:01:18 Roll SwiftShader from df5dee645ab5 to 51045556acd0 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/df5dee645ab5..51045556acd0 2021-02-01 capn@google.com Clarify DepthGreater/Less/Unchanged execution modes are unused 2021-02-01 noreply@google.com Replace deprecated llvm::VectorType usage with FixedVectorType 2021-02-01 capn@google.com Silence dead code warning If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Iec15cd02c3b53bd446b1cd0b594ae7a459a801a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2667712 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
b5bbc9fd 2021-02-02 07:00:02 Roll Chromium from 532fea9e2fd2 to 3535b64d3f52 (466 revisions) https://chromium.googlesource.com/chromium/src.git/+log/532fea9e2fd2..3535b64d3f52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dce1147a27..43a97d34a6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/990491572d..fc5af1ac75 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0b33acd751..1be79fc37c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4920147e90 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c876c8f871..bf44340d1b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/df7daef465..ec98581604 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7c835a619b..ba0ad048f1 No update to Clang. Bug: angleproject:5581 Tbr: geofflang@google.com Change-Id: I270987e795ce876c2084fee43354ab5b30226bcd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2667129 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
43e39e1e 2021-01-29 13:41:56 Tests: Add Manhattan 3.1 trace Note: This trace is longer than most at 100 frames. This is to help get more accurate data on how transform feedback is behaving. It also allows us the opportunity to trim to smaller sections if we wish, and get more reliable results on unstable systems. Test: angle_perftests --gtest_filter="*manhattan_31*" Bug: angleproject:5589 Bug: angleproject:5591 Change-Id: I76db8a56832d04ea4d335bd81ff98ba1679add5f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2659850 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
7e81056a 2021-02-01 11:16:14 Vulkan: Support integer type incomplete texture Support both signed and unsigned integer type incomplete textures. Bug: angleproject:5502 Bug: angleproject:4432 Tests: IncompleteTextureTestES3.*IntegerType* dEQP.KHR_GLES31/core_sample_variables_mask_rgba8*i_* Change-Id: Ic8c972aac0ca8589b26333b66dd0cc5fb5134043 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613245 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
572afd90 2021-01-29 22:45:29 Disable SH_SCALARIZE_VEC_AND_MAT_CONSTRUCTOR_ARGS workaround. It causes incorrect compilation of some shaders. The original graphics driver bugs that motivated enabling it have been fixed, at least on one of the platforms (macOS). Tested with new WebGL conformance test in https://github.com/KhronosGroup/WebGL/pull/3214 . Bug: chromium:1165751 Change-Id: Iee9747769ca918aab143592d6cf158ce02a75ee0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2661024 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
4a426e1f 2021-02-01 12:10:46 Vulkan: Add missing variable inits to ContextVk. This was preventing testing with the viewport flip disabled. Bug: angleproject:5596 Change-Id: I5cc39eb2e1b431625f2f1498ab73828961af42ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2664249 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
729139c9 2021-02-01 13:32:07 Fix gn check on iOS for dEQP and trace targets Bug: angleproject:5417 Change-Id: I0e445eb4c5f3a88fbaea4599fa3d2f87b8632fb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2665267 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
0d175f30 2021-01-20 16:34:40 Tests: Add eFootball PES 2021 trace Test: angle_perftests --gtest_filter=TracePerfTest.Run/*efootball_pes_2021* Bug: angleproject:5564 Bug: angleproject:5517 Change-Id: I9738876b6a6c365984cecce01f2f09e0260b41cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2656989 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
85efb9d5 2021-01-26 14:39:19 Log dEQP QPA files as test artifacts. This adds artifact output to the test runner. We add a fake test at the start of a test run that owns the artifacts. Bug: angleproject:5236 Change-Id: Ice8001bf1f2aafbd8123fee76e0e7fcc3e5a8a0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2657535 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
e3096d07 2021-02-01 10:01:18 Roll SwiftShader from 5830d745b1b2 to df5dee645ab5 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/5830d745b1b2..df5dee645ab5 2021-01-31 liyl@google.com Allow sampling usage when querying linear image format properties. 2021-01-30 capn@google.com Pool Subzero constant data 2021-01-30 capn@google.com Finalize Reactor Function creation at Routine acquisition 2021-01-29 amaiorano@google.com Fix Reactor memory leaks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:5377 Tbr: jmadill@google.com Change-Id: Ifa400697c8afdc49d133a3bc7d1639355698678c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2662689 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
fa41c227 2021-02-01 10:01:41 Roll vulkan-deps from e02583244aad to 38d88d12b2fd (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e02583244aad..38d88d12b2fd 2021-01-29 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 85caecfecec3 to 81dd1f107ba6 (1 revision) 2021-01-29 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 84a41cd4883d to 4741bbaa641d (1 revision) 2021-01-29 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 47940fbfe0ad to 2b9a7b114eaa (1 revision) 2021-01-29 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c327f81e35a4 to 85caecfecec3 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I6d6f9019c39d7f0334734688bf7869533632055c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2662401 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
85a9ec10 2021-02-01 07:01:00 Roll Chromium from 0c6211fe862e to 532fea9e2fd2 (584 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0c6211fe862e..532fea9e2fd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9007e0a586..dce1147a27 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c4fefcb646..0b33acd751 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..91735e2e67 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/2c183c9f93..c876c8f871 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cc8d00af13..df7daef465 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/78b89e3bb2..7c835a619b No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: Id51490606be8b8935c24ab0afb6b0efa5ce8dcd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2662399 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
b15de455 2021-01-27 13:58:42 Remove extension check in validation of ES3.2 entry points Bug: angleproject:3582 Change-Id: I563c6d77b825afd44809db0d08dc4842a5f93b6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653914 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
0be050a4 2020-09-23 15:12:56 Pass GL_VERSION info through ANGLE's GL_RENDERER string Chrome needs ANGLE to pass through the underlying driver vendor and version, which cannot always be determined by the SystemInfo library. This is done by construction GL_RENDERER in the frontend through combining GL_VENDOR, GL_RENDERER, and GL_VERSION from the backends. Example changes are in the doc: https://docs.google.com/document/d/1p0dvrLlu8NKhO-RCU5gqlQ_LvcQj-ZqhvfwSk1n3Sz8/edit?usp=sharing Bug: chromium:1126526 Bug: chromium:1131248 Bug: chromium:1134669 Bug: chromium:1169861 Change-Id: Ia618ebcd7f3caaeb376b4b6a03446732efdaeecb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2427383 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
62387fc6 2021-01-27 13:58:01 Vulkan: Enable geometry/tessellation deqp KHR 3.2 tests Preliminary triaging is done for the failing tests. Additionally, the tests are only enabled for windows for now, due to failures on the Android and Linux bots, likely due to old drivers. Locally, the failures on Linux match the expectations for windows. Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: I72d998097fad495c21414917ef09e132274f7c8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653913 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
61f60161 2021-01-27 13:57:13 Vulkan: Set missing geometry/tessellation limits Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: Idb8ebc0c3beee8f273d0df3b4e0d84722a8590b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653912 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
c6a8bc4a 2021-01-30 14:58:22 Fix a crash in DynamicBuffer::~DynamicBuffer() The crash is because mBufferFreeList is not moved from the rhs value for DynamicBuffer's move constructor. Bug: chromium:1170339 Change-Id: I7d41b775ab56af8fa9412369d5a4008f59da3053 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2661615 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
eae262e7 2021-01-27 13:56:49 Vulkan: Fix image layout barriers for tessellation shaders Also fixes a bug where invalid stages may be specified for example if AllGraphicsReadOnly or DepthStencilReadOnly layouts are used and geometry or tessellation shaders are not supported by the implementation. Bug: angleproject:5557 Change-Id: Ia25a6aec8138c67701c63da65783263d8a7bda27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653911 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
6d86a0fe 2021-01-29 11:08:04 Fix mActiveImageShaderBits not updated in PPO's executable Allows the backend to rely on this bitset always being valid, instead of working around the bug. Bug: angleproject:5587 Change-Id: I25e1304c0e5e34b5fc1677a819315574603ed034 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2658885 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
d5ca645e 2021-01-29 13:29:49 Capture/Replay: Set uniform buffer offset alignment During capture, we need to set a common uniform buffer offset alignment so the trace will be more portable. The offset used by the trace needs to be divisible by the device's actual value for GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT. Empirically I've seen the following values supported by devices: ARM (16), Intel (32), Qualcomm (128), Nvidia (256) Test: Manhattan 3.1 MEC Bug: angleproject:5589 Change-Id: I071b6ae7be4c827eb8df4a8b39db901226d0f00b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2659849 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
37a0dced 2021-01-28 17:52:05 Vulkan: Disable clip space transform based on EXT_clip_control When depth is set to "ZERO_TO_ONE_EXT" using EXT_clip_control API, don't transform the z position in shader since it now matches Vulkan's depth range. Toggle transformPositionToVulkanClipSpace accordingly. Bug: angleproject:5471 Tests: dEQP-GLES2.functional.clip_control.depth_mode_zero_to_one Change-Id: I7e715cb3c98cecf5aaa5cdc3822a3a83bae9c720 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615864 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
b1deba2f 2021-01-28 16:06:51 Vulkan: Don't emit spec const declaration in compute shaders Bug: angleproject:5070 Change-Id: I74becfeac88b4a8ff66dd36670792082d0b941cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2658882 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
a5ab7974 2021-01-28 12:32:10 Turn on vulkan backend for android ndk level < 26 Fixes two issue for build Vulkan backend for android ndk level < 26, * Disable Vulkan validation layers for android ndk level < 26 * Share vulkan memory allocator implementation with chrome to avoid duplicated symbols link errors. * Only run vulkan backend test with Android P or newer Note: This change will break android-binary-size try bot, we need to update expected_static_initializer_count to 4 at [1] while rolling this change into chromium. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/static_initializers.gni;l=19?q=expected_static_initializer_count&ss=chromium%2Fchromium%2Fsrc Bug: chromium:1170339 Change-Id: Idb9238d8f339724c4d8f9ac136305b95ff06fae4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2656980 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
b4fd4628 2021-01-27 15:56:58 Revise WebGL's shaderSource validation. Per discussion in the WebGL working group, shaderSource no longer generates INVALID_VALUE for sources containing characters outside the ESSL character set. Compilation and/or linking is still specified to fail when illegal constructs are used. With this change, https://github.com/KhronosGroup/WebGL/pull/3206 passes with the passthrough command decoder. Revise WebGL compatibility tests to follow the new rules. Bug: chromium:1171506 Change-Id: Id132e0b64fa94b373f2732acf2a7071f38f0d4ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2654264 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org>
80a4223e 2021-01-28 17:51:31 Vulkan: Handle changes to viewport when clip origin is modified The expected view port is different from current viewport translation when the clip origin is the upper left. So now, it has four different view port translations based on clip origin and y-flip of framebuffer. - add query and state management for EXT_clip_control - add dirty bit for clip control - change viewport, scissor and cull face when clip origin changes Bug: angleproject:5471 Tests: dEQP-GLES2.functional.clip_control.* Change-Id: I78dc752c3287b09f25496034e0d0d2724138010c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615863 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
6cfbe252 2021-01-27 13:42:55 Fix geometry/tessellation checks to account for ES3.2 Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: Iae54940cefb5ba516dc173413b35b646e1968ba6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653906 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
74f7be6d 2021-01-28 14:04:47 Vulkan: Rectify typo in EXT_texture_format_sRGB_override The extension string for EXT_texture_format_sRGB_override was missing the "format" substring. Bug: angleproject:4561 Change-Id: I19788191b589b64639b036d2bb54508077fca7e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2658355 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
312ffba8 2021-01-28 20:53:16 Roll third_party/vulkan_memory_allocator/ 065e73907..b1d65a2b3 (2 commits) https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/+log/065e739079d9..b1d65a2b3373 $ git log 065e73907..b1d65a2b3 --date=short --no-merges --format='%ad %ae %s' 2021-01-27 shawn.p.huang Add vma.cpp contains vma's implementation. 2021-01-27 shawn.p.huang Add a new target with the VmaUsage.cpp and VmaUsage.h Created with: roll-dep third_party/vulkan_memory_allocator Bug: chromium:1170339 Change-Id: I4db27eb0674d1da3157a1081aec3b7db6d7433fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2657724 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
a29ef612 2021-01-29 10:01:41 Roll vulkan-deps from 5f7a1ace1a5e to e02583244aad (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5f7a1ace1a5e..e02583244aad 2021-01-29 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from aed40d52837d to 47940fbfe0ad (2 revisions) 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d602a4f75d3c to c327f81e35a4 (2 revisions) 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from e8bd26e1f835 to 297723d75af4 (1 revision) 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from b812fd634ea5 to e8bd26e1f835 (1 revision) 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 36df92e4a0ef to f7c43377f095 (1 revision) 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 31e95c1707c5 to d602a4f75d3c (2 revisions) 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 7c25ce965b92 to a03938051ff6 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I1c193acab56bb55f8f35b1f1afe3592d15637eac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2658883 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
0ab4987a 2021-01-29 10:01:18 Roll SwiftShader from 3e9b79ff42de to 5830d745b1b2 (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/3e9b79ff42de..5830d745b1b2 2021-01-29 capn@google.com Enable named mmap usage for CMake builds 2021-01-28 capn@google.com Enable named mmap usage for Chromium 2021-01-28 capn@google.com Only enable naming anonymous mmap on Linux 2021-01-28 sugoi@google.com Add utility function to count input components 2021-01-28 sugoi@google.com Support SampleId and SamplePosition builtins 2021-01-28 sugoi@google.com Store interpolation data in routine 2021-01-28 sugoi@google.com Per sample shading If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I24d107b9cb69e860c55abce571e670b2181adc8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2657929 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
67a84f34 2021-01-29 07:00:38 Roll Chromium from 34154bd58dcb to 0c6211fe862e (430 revisions) https://chromium.googlesource.com/chromium/src.git/+log/34154bd58dcb..0c6211fe862e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/80d8522df9..9007e0a586 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e3db55b463..990491572d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4f733a4525..c4fefcb646 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f43a84ba66..602133a964 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9d5ec46922 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/ec1e3f2e46..84a6931d87 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0d2b89124b..cc8d00af13 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c3a074da20..78b89e3bb2 * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/203790d797..0bdacc0246 * tools/skia_goldctl/linux: opL5N0hiBtWxiOFaEhRqXpJWh70uurNTInvkY8NHr8oC..AyPgwgutb8buiGKwMyMGU2SGR5H8h1Y2XDfiIN2BtzwC * tools/skia_goldctl/mac: pmlVeVFuSc7Re0D7Efu2pAh2Oo5rEAnlg1rFIfp1RncC..tIfvKvCHGv4G8z3DzRxNQ7W7G95EP9N0R1wbJ_ezmwkC * tools/skia_goldctl/win: GRI6-L-7YmnYGw8gs2jXZDqvI5KIFIgsj_GvzZ4krYQC..kET1R1m5NBszkTdWAJUnKHE6R3DkKz59FxiaENTn_QgC No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I045d83ff08e004e18b81cc20fb37f0e4c58ed492 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2658880 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
e419222d 2021-01-28 17:14:02 MSAA PreRot: Make MultisampleTest use rectangular window This will make it easier to fix/prevent bugs with MSAA-swapchain windows, which are not currently pre-rotated properly on Android. Bug: b/175793022 Change-Id: Ia51446db62c8ec94313ae75fd87ad8e9477f76e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2656997 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
2dae09e8 2021-01-27 13:54:25 Fix draw mode validation of PPOs with geometry/tessellation The properties related to geometry and tessellation shaders were not being copied from the Program's exectuble to the Program Pipeline's. Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: Ied6ff82c7e30f24504c9a3f5c008181b179b07ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653909 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
ddba70da 2021-01-27 13:52:12 Fix xfb mode validation with geometry/tessellation In the presence of geometry and/or tessellation shaders, transform feedback mode must match what these shaders produce, instead of what's passed to glDrawArrays. Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: I6a21621e66b31553ed6a3a50c3aebf60e1ac7be5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653908 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
a685db2e 2021-01-26 14:45:58 Update README.md for Fuchsia Bug: angleproject:1944 Change-Id: I823ffba6b67e65dbf4b24e8863a117fcdff76657 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2648638 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org>
122a1cc5 2021-01-26 20:06:24 Fix several vulkan backend problem on Android. * Load AHardwarebuffer API dynamically, so vulkan backend can be built with old NDK, but can work with newer android releases. * Do not link with libvulkan on android. * Expose EGL_ANDROID_get_native_client_buffer extension with vulkan backend. Bug: chromium:1170339 Change-Id: Idf7f6867a86ae40ba6d57a86e419c610ba404ba8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653506 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
4ec7021c 2021-01-27 16:41:45 Report angle_restricted_trace_gold_tests as interrupted on Exception Otherwise step is reported as failed but build as succeeded Bug: chromium:1153299 Change-Id: Id21d7ceafd04553634463be5acb64c070d251abb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653859 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
2baa6288 2021-01-27 13:55:36 Fix validation of glCreateShaderProgramv for geometry/tessellation Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: I581d7485d0e8771f3f23dea4255139d56052bee9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653910 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
53105997 2021-01-28 07:42:15 Initialize some missing vulkan function pointers Those methods are used by VMA. However VMA can get those methods by itself, if null function pointers are provided for creating the VMA. But it will cause problem, when ANGLE & Chromium are sharing one VMA implementation, since the VMA implementation in chromium will be built with VMA_STATIC_VULKAN_FUNCTIONS=0 & VMA_DYNAMIC_VULKAN_FUNCTIONS=0. Bug: chromium:1170339 Change-Id: I5bf435698e4e361bfa7a6afce84390ccc4355b53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2655795 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
a408ce83 2021-01-27 13:48:27 Fix geometry shader draw mode validation The draw mode (as passed to glDrawArrays) was being compared with the transform feedback mode in the presence of geometry shaders, but the two are completely unrelated. Bug: angleproject:5579 Change-Id: I03bff97f79fe8d8a4354a6ea3abfed58c1e600eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653907 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
07f16f00 2021-01-28 10:01:57 Roll vulkan-deps from 01ef7ce6f449 to 5f7a1ace1a5e (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/01ef7ce6f449..5f7a1ace1a5e 2021-01-28 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from a4f97da409f2 to b812fd634ea5 (3 revisions) 2021-01-27 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from a61600c7639c to a4f97da409f2 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ie4aad65246d623241089cc3bd42b73ef2d8fa0dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2655326 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
b28f1c44 2021-01-28 10:01:24 Roll SwiftShader from aec0826aba0d to 3e9b79ff42de (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/aec0826aba0d..3e9b79ff42de 2021-01-27 capn@google.com Enable named mmap usage on Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Idceb84d5d63afab8efe3ab2f50e46ba4b30ac46a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2655345 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
5e0a8f9b 2021-01-27 13:46:08 Translator: Enable geometry and tessellation in ES3.2 Symbols that these extensions introduced were only accepted if the extension directive was present. This is not necessary for es 320 shaders. This change adds a new tag to builtin variable and function declarations in the translator, namely "essl_extension_becomes_core_in" which makes gen_builtin_symbols.py automatically create two entries for the builtin; one with the specified level and extension, one with the core level and without extension. Entries in builtin_function_declarations.txt can potentially be deduplicated as a follow up to take advantage of this tag, though likely an anologous "glsl_extension_becomes_core_in" needs to be introduced. Bug: angleproject:5557 Bug: angleproject:5579 Change-Id: I84c19f48a3ccc89d82d80a4f35f7833205bbc88f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2649449 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
badcf3bd 2021-01-27 17:14:43 Vulkan: Enable fbo.invalidate.whole.unbind_blit_msaa_[color|stencil] These test failures were fixed with a recent SwS CL: https://swiftshader-review.googlesource.com/c/SwiftShader/+/52088 Bug: angleproject:5044 Test: dEQP-GLES3.functional.fbo.invalidate.whole.unbind_blit_msaa_color Test: dEQP-GLES3.functional.fbo.invalidate.whole.unbind_blit_msaa_stencil Change-Id: I36034c72e28fc07ecff0eaca31745c97f054b77e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2654526 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
4ce2e213 2021-01-28 07:00:42 Roll Chromium from 9ac53d238b0c to 34154bd58dcb (208 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9ac53d238b0c..34154bd58dcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/60c7f94b29..80d8522df9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d573d8d1be..4f733a4525 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9d5ec46922 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eb5ab41f38..0d2b89124b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6806d508f7..c3a074da20 * tools/skia_goldctl/linux: 5uRd0nSbglRL_SlkzkofedmMPgK-1F0ICeAPyhneOY4C..opL5N0hiBtWxiOFaEhRqXpJWh70uurNTInvkY8NHr8oC * tools/skia_goldctl/mac: jH1EXicKWfNsK_lsEmfi4_MozROrG68ybn4yGmcDj_oC..pmlVeVFuSc7Re0D7Efu2pAh2Oo5rEAnlg1rFIfp1RncC * tools/skia_goldctl/win: n1MqOqpTysNu10SmTHGk7eHIIUMoy2SErGFxHZBoZNIC..GRI6-L-7YmnYGw8gs2jXZDqvI5KIFIgsj_GvzZ4krYQC No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: Iecafd7f85dd36b0a1c7fe6c67fdd26876af9780b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2654433 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
a12edfa5 2021-01-27 21:27:07 Roll Chromium from 4bbaf376844e to 9ac53d238b0c (270 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4bbaf376844e..9ac53d238b0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fcaf1b1b36..60c7f94b29 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/71044dffd0..e3db55b463 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/001e33eea6..d573d8d1be * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f0c0aae6f2..f43a84ba66 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9d5ec46922 No update to Clang. Bug: angleproject:5417 Tbr: jmadill@google.com,ynovikov@google.com Change-Id: I5f4b945ca375385c2974c06f6b727080a731b421 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2654082 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
5006a573 2021-01-26 17:15:10 Capture/Replay: Capture glUniformBlockBinding() eFootball PES 2021 uses glBindBufferRange(), which requires glUniformBlockBinding() to create the pairing of uniform block indexes to buffer bindings. The uniform buffer indexes that are assigned when each program is linked can differ between drivers, so the glUniformBlockBinding() calls need to be recorded to get the correct index values for the glBindBufferRange() calls. Bug: angleproject:5564 Change-Id: I909e05d5b1cc50e592b887bd130aa80cdb1bb40f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2650993 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
351e6e8c 2021-01-26 17:08:59 Add 'UniformBlockIndex' struct Add the new structure 'UniformBlockIndex'. This is in preparation for capturing glUniformBlockBinding() calls, which requires the (new) corresponding ParamType::TUniformBlockIndex. Bug: angleproject:5564 Change-Id: I88613dd96d058659dd253e8088fab49670c32316 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2651287 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
bc7554f9 2021-01-27 14:41:18 Remove extension files that are not written by ANGLE. We inconsistantly added some extension txt files to our extensions folder that are not maintained but possibly implemented by ANGLE. Some of these extensions trip up Android's automatic license detection. Bug: None Change-Id: I9bde4235c7ad2bf4d9bcf5385f4138296cef2c13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653848 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
8f6c328d 2021-01-27 18:40:56 Roll vulkan-deps from 3849583848aa to 01ef7ce6f449 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/3849583848aa..01ef7ce6f449 2021-01-27 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c47ac8e1cc37 to 31e95c1707c5 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com,syoussefi@google.com Change-Id: I18291ddfe3171db0bbdb7d27d9a2290468d85926 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653847 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
ea0f3496 2021-01-25 12:47:27 GL: Update VertexArrayGL to not store per-context state. Move StateManagerGL and FunctionsGL members out of VertexArrayGL and query them directly from the context in methods. Bug: angleproject:5577, chromium:1167179 Change-Id: I376f3eff15fbd9855c5956737064f56d54acbceb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2647868 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
f6925344 2021-01-25 13:13:33 Trace Tests: Update expectations. Bug: angleproject:5530 Change-Id: I48a6dc5753406e6dd6cd1845f1f28fcbfc485e34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2647871 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
52afb6f1 2021-01-26 22:22:07 Fix angle_unittests build on iOS Link failed because libfeature_support symbols were private Bug: angleproject:5417 Change-Id: I04c4056e1a887a9ad7bde692c7c2780b5d1dd387 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2649122 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
e7ca0aa2 2021-01-24 17:46:26 Fix crash in multi-context D3D11 backend. The crash occured due to a lack of marking a context dirty on eglMakeCurrent(), resulting in a situation where a thread B would call eglMakeCurrent() but before issuing additional GL calls, thread A would issue a draw command. Prior to this change, context state would only be marked dirty on gl calls. Test: dEQP-EGL.functional.sharing.gles2.multithread.* dEQP-EGL.functional.multithread.* dEQP-EGL.functional.render.multi_thread.* dEQP-EGL.functional.color_clears.multi_thread.* Bug: b/177602915 Change-Id: I765e0423002a373f94ea459b81b6e6f6942870d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2646609 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Doug Horn <doughorn@google.com>
fdf441ce 2021-01-27 10:01:27 Roll SwiftShader from ea1f7d10db1f to aec0826aba0d (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ea1f7d10db1f..aec0826aba0d 2021-01-26 amaiorano@google.com VulkanBenchmarks: split out benchmark classes into separate files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Icd0d171ea312f0b2cd3e905b7ba75f8d5fb0e977 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2652288 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>