kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi b8c64f3e 2024-05-21T15:34:26 Fix build on compilers that get confused with templates - part 2 Bug: angleproject:8667 Change-Id: I1db327643f0b16bea5dc59635ac51c2398fdedf6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5554174 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Charlie Lao e5fe13df 2024-05-20T11:03:49 Vulkan: Destroy VkEvent instead of putting into recycler VVL is complaining about SYNC-vkCmdSetEvent-missingbarrier-reset (See https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/8032). I am not sure if the way I did VkCmdResetEvent followed by VkCmdSetEvent is correct either. So destroy VkEvent instead of put it into recycler for now until I sort this out. Bug: b/336844257 Change-Id: I8baf87fa6f6e8c5ed9e2f7e0a29226caa85ebb31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5549896 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 9ed415e5 2024-05-16T14:28:31 Vulkan: Clean up in ImageHelper::updateLayoutAndBarrier There was a duplicated pipelineBarrier wait in ImageHelper::updateLayoutAndBarrier that possibly come from bad code merge. It is removed in this CL. The check of hasEvent and subsequently call addAdditionalStageAccess has moved out of addMemoryEvent and make its own function so that it only affects the specific case where the image is used in different shader stage in the *same* render pass. Bug: b/336844257 Change-Id: I78b0c952be32124cb0fb6a2cf750df41f6c8259d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5544450 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov e83dd780 2024-05-21T12:08:38 Skip texture_lod_bias_all on tsan SwS Flaky timeouts at 120s, green builds barely make it https://ci.chromium.org/ui/p/angle/builders/try/linux-tsan-test/12609/overview Bug: b/332383430 Change-Id: I4abde927b3cd42805164de0e0efd97835000ab71 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5554983 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi b257da86 2024-05-21T12:04:21 Fix build on compilers that get confused with templates Bug: angleproject:8667 Change-Id: Ie3d35b617ceb5bb6c0e13e0dfda370bbe18d888a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5554982 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll bfc643a4 2024-05-21T07:24:26 Roll Chromium from c0ebbbf61129 to 6d8ddfd58532 (401 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c0ebbbf61129..6d8ddfd58532 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dbd3873447..9fb898bb7b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/94d09ea5ff..e107e1aa30 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1bce0121e3..b3d1241f77 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d32e1cb571..b4fbce4794 * third_party/turbine: fYpnoJAvh8-OaNB9k81XWGrwiODb_uTipTBEUeIFM98C..JA8o86DtHkYnsW4v8F9pdcvi7uqN1WB-L1XFLggZdtAC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c4fb2112b3..f143139396 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a4d482252d..5987869b30 No update to Clang. Bug: angleproject:8434 Tbr: yuxinhu@google.com Change-Id: Ibeffbc3df4df0105916bcd1fe2ec035454eb2987 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5553753 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao c4d266cc 2024-05-17T15:07:43 Vulkan: Use std::deque for EventBarrierArray::mBarriers Most time mBarriers is small, only ~1.5% time the vector size is greater than 4. So more complicated optimization for it may not worth it. In very rare time it could be over 100. But there is no need for storage to be continuous, so switch to std::deque here so that the overhead for occasionally large barrier array size won't be too bad. Bug: b/336844257 Bug: b/293297177 Change-Id: I79b91128a1a9e460b9687862f00fed51e4258511 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5545884 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 6f8b736e 2024-05-20T11:19:55 Manual roll VK-GL-CTS from 13344922ae81 to fd5cc7b1e075 (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/13344922ae81..fd5cc7b1e075 2024-05-17 marcin.hajder@mobica.com Run clip and cull distance tests on OpenGL ES 2024-05-17 cturner@igalia.com Add coverage for transfer-only copies with multiplanar formats 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-16 gleese@broadcom.com Remove 'decor' specialisation in SPIR-V tests 2024-05-16 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-16 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-15 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_NV_raw_access_chains' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:341780527 Tbr: yuxinhu@google.com Change-Id: Idddeb19e94307f2313ab572432c547a76e0e7f91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5547022 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 9ce8d3ba 2024-05-20T07:01:17 Roll Chromium from cc575e3cad82 to c0ebbbf61129 (706 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cc575e3cad82..c0ebbbf61129 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1664b9f470..dbd3873447 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a7e42299f3..94d09ea5ff * third_party/android_build_tools/manifest_merger: tL_JG7yL7RqVT4RB2rD5aN3xhRGKPh-V87_YnzX_eSwC..let00MLFVBLhc9quEKtUuTMxC_vL8cvLoxiRSF2M4nkC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a8c80ca55..d32e1cb571 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a37a3aa431..fc3fb0729e * third_party/r8: kzC9Crg5Zd3tLTZPUByQQOz0ma4VeK4QN_T2P7RrnFoC..CCWS0qWaAWt-cT_itG4vFNt7tuI0FjLHwr9kd8GllPYC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/29b73ebcd5..aa1c946d23 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/95b2bde5a7..c4fb2112b3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5347b775c5..a4d482252d No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I437e9fb531a8646db37a1bba5a51df3fa3adf34a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5549875 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yiwei Zhang a00babd8 2024-05-17T20:38:56 Vulkan: disable supportsShaderFramebufferFetchNonCoherent on Android Not just ARM or QC, but also Intel and AMD are impacted. So just disable this for Android as a whole since it's for app compat but not specific to a particular impl. Bug: b/340665604 Test: LIMBO, Diablo Immortal, Real Racing 3, etc are running properly Change-Id: Id11ad4cd541166c9e6c6d84bb09d9c06a175d5a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5547687 Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Lepton Wu <lepton@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 519d6d7e 2024-05-15T15:08:54 Vulkan: Remove AMD deqp expectations We no longer test on AMD. These expectations were added when AMD drivers were very old, so they likely don't apply anymore anyway. Bug: angleproject:3586 Bug: angleproject:3588 Bug: angleproject:5276 Bug: angleproject:7415 Change-Id: Ic7e172186abaf034ef28d87dfd40e21b8298e6ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5539021 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c73d0776 2024-05-15T15:07:56 Vulkan: Enable ASTC tests on Nvidia ANGLE emulates ASTC, so we are able to run these tests fine. Bug: angleproject:6441 Change-Id: I641a729db5c00d203c857710b17754161251d785 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5539020 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Charlie Lao b4562086 2024-05-16T12:22:47 Vulkan: Remove std::vector from EventBarrier::mEvents mEvents and mImageMemoryBarriers field of EventBarrier never being more than 1. This CL removes std::vector and just store the handle. Similarly max count for mImageMemoryBarriers is 1, so std::vector also removed. mImageMemoryBarrierCount added (which can be either 0 or 1) to indicate if mImageMemoryBarrier is valid or nullptr should be send to VK driver. Bug: b/336844257 Change-Id: Ib367c649d3a9d790c5e15d4129cde6673bca6cae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5545883 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov ee9ed4a4 2024-05-17T14:58:59 End Mac AMD experiment Bug: chromium:327017900 Change-Id: I163b41605e3ebcf65d111d011fd3927ee08a186a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5546124 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Charlie Lao 7cbac5de 2024-05-16T10:01:41 Vulkan: Switch RefCountedEventCollector to use std::deque Right now it is using std::vector. The vector could potentially grow big. The grow is costly with vector when storage has to resize. This CL switches it to use std::deque. Bug: b/293297177 Bug: b/336844257 Change-Id: Ia407e7d4e1b68bd0cb7cf76ccc5e7523c0e83415 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5545882 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao f82d812d 2024-05-16T15:46:05 Vulkan: Fix EventBarrier bug when asyncSubmission is enabled Since we have moved RefCountedEvent garbage collection into ShareGroupVk, we have changed the reference counting to use non-atomic. There is a bug with async submission code path where the executeSetEvents gets called from submission thread which does not have share group lock. This CL fixes this bug by storing VkEvent in RenderPassCommandBufferHelper so that executeSetEvents uses VkEvent instead of RefCountedEvent when async submission is enabled. This CL also adds assertion that RefCountedEvent::releaseImpl does not get called from async submission thread. Bug: b/336844257 Change-Id: Ifcbd5a09d2bc7636cc15b2c6728dbbca103d4d9c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5544449 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 2d0e92ee 2024-05-16T09:36:44 Vulkan: Let Recycler class use std::deque instead of vector Vector is expensive when storage has to be expanded. The Recycler only use the storage as a stack operation, there is no requirements of storage being continuous, thus deque works perfectly. Bug: b/293297177 Change-Id: I89f02b4a7e7f356942bb6606e3d38dcbdcc8bb4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5545881 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll 8f6b295a 2024-05-17T13:49:07 Manual roll Chromium from 2758cfd7767d to cc575e3cad82 (737 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/2758cfd7767d..cc575e3cad82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9c1517ab97..1664b9f470 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f8695d2beb..a7e42299f3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c2f740d532..1bce0121e3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/274689c4a5..9a8c80ca55 * third_party/r8: COW7cFK6pwOVeM1EEvoEXOYDwDbWVkPQDC63mlyb3m4C..kzC9Crg5Zd3tLTZPUByQQOz0ma4VeK4QN_T2P7RrnFoC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e576783b41..199ddb534b * tools/luci-go: git_revision:0ff3a23429edb67778b350e6ccbf9c9efdd0e51f..git_revision:a60c8017241731d109e8909b5ecbb7b6d6f54af3 * tools/luci-go: git_revision:0ff3a23429edb67778b350e6ccbf9c9efdd0e51f..git_revision:a60c8017241731d109e8909b5ecbb7b6d6f54af3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f307c691ae..5347b775c5 * tools/skia_goldctl/linux: EYKOn-l9uvmHtsVw_fmqj8vxXKpMyXt2sXvEJ3snsUQC..POF6EHjK2ABZjWG8M_kH0eR8pQSZ29p4yA3H8EbR3CkC * tools/skia_goldctl/mac_amd64: U1MAiUkDGvUVuk6G3tRhjjtmA3gDgW4HkyWhy8xTfrQC..DsWZ6Md4C0PbdllkonvRIJ_zdXUVvUAuZaGkkyH__3IC * tools/skia_goldctl/mac_arm64: KzRIDh9i73vYu6zVorKIEt7qrq38TuL9MZEWbf3Glw4C..f79BgDTVjc4x-Q-SYfX-GuXxOK_aezuZ-tjwQ85T2fIC * tools/skia_goldctl/win: gEDTtt_VQOAPHQedAzUUVJ79216-Wz_H9A-EfvVGYyAC..D1kXDOnp7MBbgxkE6rvufF3H7zHEYUGc1F8m8zUgpvIC No update to Clang. Bug: None Tbr: romanl@google.com,ynovikov@google.com Change-Id: I59818a609411f04c1971e230e94adae13696faef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5547944 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov b71fe1c5 2024-05-16T15:10:09 Flatten vulkan-deps. Sub-repos will be now checked out in third_party directly, instead of under third_party/vulkan-deps. Bug: chromium:341002187 Change-Id: Ia1c10ce5e7865c164b29bdcabb6ab8a7e4ae35b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5545577 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 698f51d9 2024-05-15T16:03:48 Don't build OpenCL with msvc msvc builds of llvm take way too long. We make sure ANGLE builds with msvc to support existing users of it as a GLES implementation, but we have no intention to support the OpenCL implementation with that compiler. Bug: None Change-Id: I1c370fd843fc25cccacabbbfb4727ef830fa45e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5539191 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 7ac85733 2024-05-15T15:06:31 Vulkan: Enable advanced blend emulation on Intel/Linux Only Intel/windows drivers miss the required functionality. Bug: angleproject:3586 Change-Id: I53eeb100c7ac7ee469e0bb35c19ae42d21f79ed2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5539019 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b1267bf3 2024-05-15T15:05:10 Skip concurrent ResourceMap tests in Chromium Chromium builds ANGLE with locking disabled because it ensures concurrent access doesn't happen. So testing that concurrent access works in unit tests is meaningless in those builds. Bug: angleproject:8667 Change-Id: I30f36ed72d64303a590afd727bbe9875d06b3d96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5539018 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0f1c8ac6 2024-05-16T07:01:47 Roll Chromium from 075ed4a6344d to 2758cfd7767d (617 revisions) https://chromium.googlesource.com/chromium/src.git/+log/075ed4a6344d..2758cfd7767d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4eca45df04..9c1517ab97 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6206ead2d5..efa920ce14 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/506cd72a25..f8695d2beb * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8c54b7dae4..f81f6c011b * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f79d3898d8..2888a739e9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/923a565b97..c2f740d532 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2b6524b208..274689c4a5 * third_party/fuchsia-sdk/sdk: version:20.20240507.3.1..version:20.20240515.2.1 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d1dc2a57c8..e576783b41 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a937e8028f..29b73ebcd5 * tools/luci-go: git_revision:0353d07d5edeb62305e13f17d808e8523cd5bac2..git_revision:0ff3a23429edb67778b350e6ccbf9c9efdd0e51f * tools/luci-go: git_revision:0353d07d5edeb62305e13f17d808e8523cd5bac2..git_revision:0ff3a23429edb67778b350e6ccbf9c9efdd0e51f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8441b20b2a..f307c691ae Clang version changed llvmorg-19-init-9433-g76ea5feb:llvmorg-19-init-10646-g084e2b53 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/a937e8028ff14e705d1c9a59fa1287a7f62ea6b5..29b73ebcd5d8eab37eed507251fce48bd15d9f50/scripts/update.py Bug: None Tbr: romanl@google.com Change-Id: Ibf38c849b388f85d5af6fa61c305e21391b2e5e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5543622 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 8884cf06 2024-05-09T11:21:38 Vulkan: Use QueueSerial to track RefCountedEvent garbage RefCountedEvent garbage are only used on one command buffer, so it is a single QueueSerial is enough to track it. Bug: b/336844257 Change-Id: Icafeee722fe19f41dd863a2e6aca6ddd981d28a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5529952 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 4629bf6c 2024-05-08T17:43:59 Vulkan: Move RefCountedEvent GC and recycler to ShareGroupVk (3/3) With previous CLs, RefCountedEvents are increment/decrement only within contexts in the same ShareGroup, thus we no longer needs atomic operation. This CL switchs RefCountedEvent to use RefCounted instead of AtomicRefCounted. Bug: b/336844257 Change-Id: Ic5aa9b0f28b8f817f820f595d3de945ce37dbd0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5527617 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi 44db69ab 2024-05-06T17:12:17 Add Qualcomm version with fixed CmdClearAttachment * Added QualcommDriverVersion (angle::VersionTriple) to make comparing versions more clear. * Added ParseGenericVulkanDriverVersion() to parse the version of drivers using the generic Vulkan format. * Updated the condition for the following feature to no longer apply to more recent drivers. * preferDrawClearOverVkCmdClearAttachments Bug: b/339054824 Change-Id: I0016c6c19ef1606b7c9475d684d98134494d8524 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5514933 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Charlie Lao 0636b509 2024-05-06T12:36:20 Vulkan: Move RefCountedEvent GC and recycler to ShareGroupVk (2/3) One of the problem we had with RefCountedEvents is CPU overhead comes with it, and some part of the CPU overhead is due to atomic reference counting. The RefCountedEvents are only used by ImageHelper and ImageHelpers are per share group, so they are already protected by front end context share lock. The only reason we needs atomic here is due to garbage cleanup, which runs in separate thread and will decrement the refCount. The idea is to move that garbage list from RendererVk to ShareGroupVk so that access of RefCountedEvents are all protected already, thus we can remove the use of atomic. The down side with this approach is that a share group will hold onto its event garbage and not available for other context to reuse. But VkEvents are expected to be very light weighted objects, so that should be acceptable. This is the second CL in the series. In this CL, we added RefCountedEventsGarbageRecycler to the ShareGroupVk which is responsible to garbage collect and recycle RefCountedEvent. Since most of ImageHelper code have only access to Context argument, for convenience we also stored the RefCountedEventsGarbageRecycler pointer in the vk::Context for easy access. vk::Context argument is also passed to RefCounteEvent::init and release function so that it has access to the recycler. The garbage collection happens when RefCountedEvent is needed. The per renderer recycler is still kept to hold the RefCounteEvents that gets released from ShareGroupVk or when it is released without access to context information. Bug: b/336844257 Change-Id: I36fe5d1c8dacdbe35bb2d380f94a32b9b72bbaa5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5529951 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 2e0aefe9 2024-05-06T11:03:19 Vulkan: Move RefCountedEvent GC and recycler to ShareGroupVk (1/3) One of the problem we had with RefCountedEvents is CPU overhead comes with it, and some part of the CPU overhead is due to atomic reference counting. The RefCountedEvents are only used by ImageHelper and ImageHelpers are per share group, so they are already protected by front end context share lock. The only reason we needs atomic here is due to garbage cleanup, which runs in separate thread and will decrement the refCount. The idea is to move that garbage list from RendererVk to ShareGroupVk so that access of RefCountedEvents are all protected already, thus we can remove the use of atomic. The down side with this approach is that a share group will hold onto its event garbage and not available for other context to reuse. But VkEvents are expected to be very light weighted objects, so that should be acceptable (If not, we can add some limit to the number of events it can hold in the garbage list). This is the first CL in the series. Before this CL, the RefCounteEvents are garbage collected at flushToPrimrary time, at which time we have lost ContextVk information. In order for us to do garbage collect to ShareGroupVk, we need to move the garbage collection process early, before command buffers leaving ContextVk's visibility. For OutsideRenderPassCommands, this is easy to do, we just call flushSetEvents before we call mRenderer->flushRenderPassCommands. For RenderPassCommands, that flushSetEvents call will simply make another copy of RefCountedEvents and add to the garbage list and the actual VkCmdSetEvents are defered at the executeSetEvents call that get called from flushToPrimrary time. Bug: b/336844257 Change-Id: I1948cd8240ff61d407931083b7584a54b1dc6b0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5517891 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e547126a 2024-05-15T13:46:10 Disable ResourceMapTest.ConcurrentAccessLargeIds ... until I figure out why it's failing on some bots. Bug: angleproject:8667 Change-Id: I4399739b257a8e49da0d94ed162f472ed84c41c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5539016 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang d0bdec30 2024-05-13T18:11:17 EGL: Handle null resultOut for sync tail call destruction Syncs can be destroyed during eglDestroySync or as part of display destruction. During display distruction there is no result so swallow any errors. Bug: angleproject:8434 Change-Id: I172d268c91fd0d6ba534eceff8914f9c719bdf39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5533777 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 5332ab8c 2024-05-10T19:48:34 Vulkan: Add RefCountedEventRecycler to vk::Renderer This CL adds event recycler in vk::Renderer to avoid the constant create and destroy of VkEvents. When RefCountedEvent is destroyed previously, it now goes into per renderer recycler. When RefCountedEvent is created previously, it now dips into this recycler and fetch it. Before we issue VkCmdSetEvent, if this event was from recycler, we also issue VkCmdResetEvent before VkCmdSetEvebt. When glFinish/EGLSwapBuffer is called or context gets destroyed, this recycler is purged to keep the free count under limit. Bug: b/336844257 Change-Id: I92ec1b183f708112a96c3d06fcfa265024f5aa04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5519174 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev 0ac0603e 2024-05-14T00:00:00 Fold nested std::max calls When a maximum of three values is needed, an initializer list with all three values is more readable than two std::max calls. Fixed: angleproject:8695 Change-Id: I073ea1af07b215610c85981eea03f6e73107bce6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5541974 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev b98b2c34 2024-05-14T00:00:00 Minor TextureState::getEnabledLevelCount cleanup The return value of TextureState::getMipmapMaxLevel() is by definition less than or equal to the return value of TextureState::getEffectiveMaxLevel(). Bug: None Change-Id: I5cea291bb786adb698f0c66435ac09b2e40221c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5541970 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e6dd34d0 2024-05-15T09:07:57 Roll Chromium from a749eb77d113 to 075ed4a6344d (656 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a749eb77d113..075ed4a6344d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e6bad9d579..4eca45df04 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4e0e9c73a0..6206ead2d5 * buildtools/reclient: re_client_version:0.141.1.29a9d3c-gomaip..re_client_version:0.143.0.518e369-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0f6fe5350b..506cd72a25 * third_party/android_build_tools/lint: LKVTpK4XpEG8B7rQdSi365E60QYERcaYvf2b4kv_JugC..Xnap6swAQawTjX1djXDa7Y6utr3To_5vWeNljRgbTHgC * third_party/android_build_tools/manifest_merger: Uecrn-wUXzvUON7QkiZPlANRvFr6yFM05_M_S7q8IFoC..tL_JG7yL7RqVT4RB2rD5aN3xhRGKPh-V87_YnzX_eSwC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/691416e512..f79d3898d8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8479869311..2b6524b208 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e3b94d0e5b..852bc6746f * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/7d77fb7fd6..4f653ff1af * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cef4fc680f..a937e8028f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/42052bb1dc..95b2bde5a7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a38be67561..8441b20b2a No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Ia45fcc42e80307eeeddea2b62356822379b418e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5540244 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1409a05a 2024-05-14T08:01:10 Manual roll VK-GL-CTS to 13344922ae81 (14 revisions) Added new test files to gni and skipped BGRA and SwS failures glcUniformBlockNegativeTests.cpp/hpp glcBufferObjectsTests.cpp/hpp https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9d7b4c3d5533..13344922ae81 2024-05-10 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (buffer_objects), PART 5 2024-05-10 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-09 cturner@igalia.com Add consistency checks for video format query interactions 2024-05-09 rgarcia@igalia.com Check pipeline libraries are supported if RT pipelines are 2024-05-09 rgarcia@igalia.com QPA image viewer improvements 2024-05-09 eric@igalia.com scripts/ctsbuild: fix backslash escapes 2024-05-09 russellc@nvidia.com Reduce host memory in VK_EXT_host_image_copy tests 2024-05-09 scerveau@igalia.com EncodeTests: use the correct align for bitStreamBufferOffset 2024-05-09 javed@igalia.com Fix mesh shader to avoid reading output variables. 2024-05-09 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (uniform_buffer_object_structure_declaration), PART 6 2024-05-09 rgarcia@igalia.com Add test for scalarized flat saturation 2024-05-09 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-08 nathaniel@lunarg.com Fixup some VK_EXT_debug_utils references 2024-05-08 erik.faye-lund@collabora.com Test BGRA when supported If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8692 Bug: angleproject:8693 Tbr: romanl@google.com Change-Id: Idc2ad8d21825754ee58a7e27ce6f21f20fe5d637 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5536541 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi f4140c76 2024-05-10T16:56:13 Remove share group lock from glBindBuffer This is a very hot function. Removing the share group lock from this function improves the driver_overhead_2 execution time by ~1ms on Pixel 6. Bug: angleproject:8667 Change-Id: I9ea04f48aa1d2d0efec21407374393e88a1316e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5533081 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 49317d73 2024-05-10T16:11:59 Prepare resource map for being potentially thread-safe Resource maps are used for both shared and context-private resources. Context-private resource maps do not need any locking. Once glBind* and similar commands are made free of the share group lock, the resource map of the corresponding type must be made thread safe, especially for look up. This change adds the ability to the resource map to be either thread safe or not, based on the type of the resource it contains. Currently, only a test type (unsigned int) is thread safe (used in unit tests). This is achieved by a combination of the following: - For resource maps that need a lock, the flat part of the map has an initially reasonable size, but is _never_ reallocated. This makes access to that part of the map lockfree. - The hash-map that contains large ids is always protected by a mutex. Follow up changes will start enabling thread-safety for resources as their corresponding glBind command is made lockless. Bug: angleproject:8667 Change-Id: Ia4ffffee41f021d833d31f296bc883bf12f1135f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5527771 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang cbeaebf1 2024-05-13T17:53:25 eglCreateContext: always fail for invalid versions Since error generation can be disabled in EGL, it's not always possible for a client to detect if a context client version is valid. Always validate the context version after resolving backwards compatible versions so that the application can handle unsupported versions. Bug: chromium:339948886 Change-Id: I438fa1fcf5160a491f2b996797c29c69b1ab71b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5533776 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll e490387d 2024-05-14T10:01:18 Roll vulkan-deps from 7e66c5e2f87e to 2957dc1863e3 (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7e66c5e2f87e..2957dc1863e3 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/edca09e3af..541733a66b * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/eb8c7b071a..a1a7377964 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/df8e710224..137b3612d6 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/358a107a6f..777358fdad * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8480f26d3f..dcc6123bf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I5f48a3ba11cdac35d940b881f471c7966a319e9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5537548 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 670f6d86 2024-05-14T09:06:53 Roll Chromium from dcf49c3fc3cd to a749eb77d113 (548 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dcf49c3fc3cd..a749eb77d113 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ef48ed5d95..e6bad9d579 * buildtools/linux64: git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512..git_revision:df98b86690c83b81aedc909ded18857296406159 * buildtools/mac: git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512..git_revision:df98b86690c83b81aedc909ded18857296406159 * buildtools/win: git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512..git_revision:df98b86690c83b81aedc909ded18857296406159 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/066811c908..0f6fe5350b * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/36a6c64282..691416e512 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e1385296c4..8479869311 * third_party/r8: DcVi2RjfFH55zitouMx3JJtwdiShMM2rWsdAoGYUIRsC..COW7cFK6pwOVeM1EEvoEXOYDwDbWVkPQDC63mlyb3m4C * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/cc51a5ea86..d1dc2a57c8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/091120aa21..cef4fc680f No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I3d997e3109bc54467f87fbea281920f2d992f923 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5536364 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi a1665d2f 2024-05-10T00:15:31 Reland "Document thread-unsafe iterator access to resource maps" This is a reland of commit d1bb6ed8399dd12e79484f30f9e9ded95c25625a The crash was due to another issue (disabling EGL validation in Chrome) Original change's description: > Document thread-unsafe iterator access to resource maps > > By using a proxy type, everywhere resource maps are iterated are clearly > marked as not being thread safe. In most cases, only destruction and > capture/replay iterate over these maps, which means thread safety is not > an issue (or is externally enforced). > > The only case where iterators are used in the presence of other contexts > is with ANGLE_request_extension, which is changed to explicitly require > the application to ensure thread safety. In practice, the user is > Chrome which already guarantees this. > > Bug: angleproject:8667 > Change-Id: I7af13c6433b6955d9c36f9088b3aa4c065e1cfc1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526428 > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:8667 Change-Id: Id539cabac01df5f242150f6684222577003eef3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5531278 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Charlie Lao df2e7bd7 2024-05-10T19:48:34 Vulkan: Handle the case that VkEvent failed to create. If VkEvent failed to create, we can still fall back to pipeline barrier. This CL changes RefCountedEvent::init to return boolean. Also when it fail, this CL did an immediate garbage clean up in case it will free up more event from garbage list and then retry again. Bug: b/336844257 Change-Id: I28251849a92d1785701c55eb028a8fed63cfc372 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5532869 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov 3b470cf5 2024-05-13T12:43:25 Move PPO executables to ProgramExecutable This will allow to recursively deal with PPO uniforms Bug: angleproject:8666 Bug: b/335295728 Change-Id: Iadc2d009937fb5e8a39b070674ef5d67c9f0fb19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5532715 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Le Hoang Quyen 0044f4d1 2024-05-13T00:29:30 Metal: fix IOSurface's render targets invalidated by max level change. This CL fixes a bug in the following tricky situation: - Client binds an IOSurface to a texture. - Previously this would internally intialize the texture's max level to the default value 1000. - Client changes the texture's max level to 0. - Client attachs the texture to FBO 1. - Client binds FBO 1 and clear it. - This triggers TextureMtl::getAttachmentRenderTarget() that initializes the RenderTargetMtl of the texture. - Client binds FBO 0 and sample the texture. - Previously this could trigger TextureMtl::onBaseMaxLevelsChanged() which would invalidate the texture's RenderTargetMtl. - Client binds FBO 1. - Client blits FBO 0 to FBO 1. - This will set DIRTY_BIT_COLOR_BUFFER_CONTENTS_0 in FBO 1. - Client calls glFlush to restart render command encoder. - Client issues a draw call. - DIRTY_BIT_COLOR_BUFFER_CONTENTS_0 would cause FrameBufferMtl to re-initialize RenderPassDesc from invalid RenderTargetMtl. - A new render encoder would be created from the invalid RenderPassDesc. - the draw call would be encoded to a render command encoder without any valid color attachment. The fix in this CL is that when we bind an IOSurface to a texture, the texture's max level will be automatically set to 0. This will avoid its RenderTargetMtl from being invalidated if users explicitly change the max level to 0 in future. Note: this is not a foolproof fix for every scenario concerning the base/max level in IOSurface bound/or immutable textures. We will fix them in future CLs. Bug: b/335353385 Change-Id: I3a2da6991764f22393178f40c1d7bbe60503cba4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5531388 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Yuly Novikov 53cb3f48 2024-05-11T16:18:22 Fix non-WebGPU component build Need to build abseil as a component, like it was before https://chromium-review.googlesource.com/c/angle/angle/+/5371323 otherwise same symbols are defined in multiple ANGLE libs. Bug: angleproject:8555 Change-Id: Ie7eacb682064e61bf3d5b24953c60e30d33814b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5527302 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 82ddb33b 2024-05-10T00:00:00 Metal: Do not separate vector and matrix constants Do not create temporary variables for already folded constant vector and matrix values. This reduces register usage and partially fixes MSL compilation errors caused by matrices present in constant initializers. Bug: angleproject:8691 Change-Id: Iedfabadd9b7bcb2e6e1e08a5ad39f48305365747 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5533925 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 08365628 2024-05-13T13:55:15 Force logging ANativeWindow events for debugging. Temporarily switch from LOGV to LOGI, so that logs from these events show in release builds of ANGLE: onNativeWindowCreated onNativeWindowDestroyed onNativeWindowRedrawNeeded onNativeWindowResized These are only printed in ANGLE tests. Bug: chromium:339457761 Change-Id: I0d81b05348ee3184fdc90da1a16e69704bcc084a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526470 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 65e25de7 2024-05-13T10:50:26 Manual roll Chromium from e8c93a04c96c to dcf49c3fc3cd (817 revisions) Manual roll requested by ynovikov@google.com Manually update flatbuffers https://chromium.googlesource.com/chromium/src.git/+log/e8c93a04c96c..dcf49c3fc3cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b2163519a9..ef48ed5d95 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/46a35f0196..066811c908 * third_party/android_build_tools/lint: Y5wuGPB-HfFtEVQC_0XI6n88Covm4HFDxnG0uTdV2LcC..LKVTpK4XpEG8B7rQdSi365E60QYERcaYvf2b4kv_JugC * third_party/android_build_tools/manifest_merger: tz8dYQ_yBEZJRVhtzyyCjOlbOfujkHRWcYZy7419o_cC..Uecrn-wUXzvUON7QkiZPlANRvFr6yFM05_M_S7q8IFoC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3a1d1cc096..923a565b97 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6e32e926e9..e1385296c4 * third_party/flatbuffers/src: https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/bcb9ef1876..c696275eaf * third_party/kotlin_stdlib: 05hzFgOi0AqRK3RxbSvGj2TWTFUNeLcwkJwVzwgLttUC..bCpFA9jdfF0zeuOKYuv9n1vqxV_lykSRR1oAYrVKmFsC * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d17298ab09..a37a3aa431 * third_party/siso: git_revision:4524544994f4eac131378143f498ee4d0b7d1f36..git_revision:df7a992166415f66f6958744f149f724df138879 No update to Clang. Bug: angleproject:8434 Change-Id: I43317335b9acc78c133aafe8dcf7ce2a3167eb36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5532860 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Yuly Novikov a24c413d 2024-05-13T10:35:19 Update native_app_glue from NDK 27.0.11718014 Adding these 3 evens handling: onContentRectChanged onNativeWindowRedrawNeeded onNativeWindowResized Bug: chromium:339457761 Change-Id: I7b919d60df2d1bf81745ef4caac6c81238b2c7bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526468 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll decf0e9d 2024-05-13T10:01:43 Roll vulkan-deps from 643408ea2a06 to 7e66c5e2f87e (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/643408ea2a06..7e66c5e2f87e Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/effcbf7893..edca09e3af * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9241a58a80..199038f10c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e74bfc215b..8480f26d3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I4b2366c5e7be1669d64603e9c8790a1125fca4d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5532970 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 4e887491 2024-05-11T18:08:03 Revert "Document thread-unsafe iterator access to resource maps" This reverts commit d1bb6ed8399dd12e79484f30f9e9ded95c25625a. Reason for revert: Checking to see if it's the reason for crbug.com/339948886 Original change's description: > Document thread-unsafe iterator access to resource maps > > By using a proxy type, everywhere resource maps are iterated are clearly > marked as not being thread safe. In most cases, only destruction and > capture/replay iterate over these maps, which means thread safety is not > an issue (or is externally enforced). > > The only case where iterators are used in the presence of other contexts > is with ANGLE_request_extension, which is changed to explicitly require > the application to ensure thread safety. In practice, the user is > Chrome which already guarantees this. > > Bug: angleproject:8667 > Change-Id: I7af13c6433b6955d9c36f9088b3aa4c065e1cfc1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526428 > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:8667 Change-Id: I1245c9e57dfeb27a7f0e5718b1455614c70bc0dc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5532187 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 9eaf12d3 2024-05-10T09:45:03 Roll Chromium from 4fea14b56dd7 to e8c93a04c96c (1172 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4fea14b56dd7..e8c93a04c96c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7796c50af5..b2163519a9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9703d9137f..4e0e9c73a0 * buildtools/linux64: git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789..git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512 * buildtools/mac: git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789..git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512 * buildtools/win: git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789..git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a2a6e48c98..46a35f0196 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/31bdf8fec4..8c54b7dae4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/47d3198a95..3a1d1cc096 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df437783c2..6e32e926e9 * third_party/r8: ntlyos9oLHW_q1AeZovqFuTYzog9dKd2lITTowptHuYC..DcVi2RjfFH55zitouMx3JJtwdiShMM2rWsdAoGYUIRsC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/964cf5c799..091120aa21 * tools/luci-go: git_revision:91ca2f5af39c4feb1c748c353f4d616e1c2332e7..git_revision:0353d07d5edeb62305e13f17d808e8523cd5bac2 * tools/luci-go: git_revision:91ca2f5af39c4feb1c748c353f4d616e1c2332e7..git_revision:0353d07d5edeb62305e13f17d808e8523cd5bac2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/54a120d570..42052bb1dc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7ef4ff5ba3..a38be67561 * tools/skia_goldctl/linux: rnVa2tBzy_bWBzhMbfGN9LWVREg2oX7FIWTizcil9nAC..EYKOn-l9uvmHtsVw_fmqj8vxXKpMyXt2sXvEJ3snsUQC * tools/skia_goldctl/mac_amd64: Y1vx6zBEl8AgYA0BE99RK71LoJPAJMdFcFZUiiH4ItIC..U1MAiUkDGvUVuk6G3tRhjjtmA3gDgW4HkyWhy8xTfrQC * tools/skia_goldctl/mac_arm64: 1QeDGa3HwvjmY-wV4NK81PTGZGJ_uSZ0FSC0dHAosIsC..KzRIDh9i73vYu6zVorKIEt7qrq38TuL9MZEWbf3Glw4C * tools/skia_goldctl/win: qWfDi1N2HXBm5wLJgsy6fImu51jqJ6JafFDWjWJPuMQC..gEDTtt_VQOAPHQedAzUUVJ79216-Wz_H9A-EfvVGYyAC No update to Clang. Bug: angleproject:5038 Tbr: abdolrashidi@google.com Change-Id: I8b5f1641d70bd03e253722264f19f427ed35cf9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5530989 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang c96435ed 2024-05-10T16:06:19 Use Chromium's abseil build files with Dawn. Roll Dawn and set build_with_angle so that it uses chromium's abseil buildfiles when building in an ANGLE checkout. Bug: angleproject:8555 Change-Id: I8fc40fdefad734ef62bce374aa948367a42c03c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5531113 Auto-Submit: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi d1bb6ed8 2024-05-10T00:15:31 Document thread-unsafe iterator access to resource maps By using a proxy type, everywhere resource maps are iterated are clearly marked as not being thread safe. In most cases, only destruction and capture/replay iterate over these maps, which means thread safety is not an issue (or is externally enforced). The only case where iterators are used in the presence of other contexts is with ANGLE_request_extension, which is changed to explicitly require the application to ensure thread safety. In practice, the user is Chrome which already guarantees this. Bug: angleproject:8667 Change-Id: I7af13c6433b6955d9c36f9088b3aa4c065e1cfc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526428 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 8d23fa3f 2024-05-10T15:01:25 Add .gcs_entries to .gitignore Was interfering with uploads to AOSP. Bug: b/324418194, skia:338467531 Change-Id: Ifd170092e71425de2d1dad33f130e74c091bec8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526249 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll dfddb4f7 2024-05-10T10:01:44 Roll vulkan-deps from 7c61bb741fb6 to 643408ea2a06 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7c61bb741fb6..643408ea2a06 Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/4bc77c26ff..5677bafb82 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1ca695d943..e74bfc215b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I92ec06db4f91b9e9d4cc7a26f8602ac163c6695e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5531181 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 4cacc66e 2024-05-09T16:08:58 Remove unused ResourceMap::find Bug: angleproject:8667 Change-Id: I0d0c00337895b247a1f0536f5072fdcf12b7de1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5527560 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 1202055c 2024-05-09T11:25:38 Vulkan: Updates to perf counters 1. don't reset pipeline cache hit / miss counters after every frame 2. bugfix in LinkTaskVk::getResult(...) 3. accumulate counters in WarmUpTaskCommon::getResultImpl(...) Bug: angleproject:8297 Change-Id: I39d7e1a438d78e2e353c5cf8246fb24fb3cfefea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5529942 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Geoff Lang 394e8767 2024-05-08T15:18:37 WebGPU: Fix accumulating mCurrentColorAttachments. mCurrentColorAttachments was not being cleared so multiple clear operations would have incorrect color attachments. Comparing against the previous RenderPassDescriptor also compared the same color attachment memory since the same scratch buffer was used to generate the new descriptor. Bug: angleproject:8582 Change-Id: I9026007607941b92856728b421bc43812195ca57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526978 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org>
Geoff Lang a70ef7fc 2024-04-25T14:19:50 Add EGL_ANGLE_no_error for disabling EGL validation. Chrome makes many small EGL calls that can have proportionally expensive validation. Bug: angleproject:8434 Change-Id: I4f4d0e6eff64839f76a0f7bf48e5c94b8df9d809 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5491459 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Scott Marcy 2ecfc5a1 2024-05-03T18:29:12 Issue 8644: Deeply nested iterator declarations can crash Avoid stack overflow crash when parsing nested iterators (especially `while` statements). Limits the number of nested iterator statements to `mMaxStatementDepth` (defaults to 256). Bug: angleproject:8644 Change-Id: I9b0fd2ab456c3cdd731b41ab97f495ae4dc0b0bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5519169 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Scott M <mscott@apple.com>
angle-autoroll bcb6db5c 2024-05-09T10:01:41 Roll SwiftShader from 76f7f8cfea80 to da334852e705 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/76f7f8cfea80..da334852e705 2024-05-08 dsinclair@chromium.org Fixup CMake after spirv upgrade 2024-05-08 rjodin@chromium.org Update SPIR-V Tools to dd4b663e1 2024-05-08 rjodin@chromium.org Update SPIR-V Headers to 5e3ad389e 2024-05-08 rjodin@chromium.org spirv-tools: revert hand-made changes in spirv-tools to update with upstream 2024-05-08 rjodin@chromium.org update-spirv-tools.sh: add missing rms of Android.mk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I9a7414c10726660b7b2b19669ed23dcd3fcb50d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5529375 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d3b380fc 2024-05-09T10:01:16 Roll vulkan-deps from 44adb2021ffb to 7c61bb741fb6 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/44adb2021ffb..7c61bb741fb6 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ed4446acf1..1ca695d943 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia4caa7e1b421dd511495a861b11e0459769fb71d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5527627 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 602512a0 2024-05-08T20:46:28 Manual roll vulkan-deps from 74fe79763664 to 44adb2021ffb (62 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/74fe79763664..44adb2021ffb Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/f857417c99..effcbf7893 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/5e3ad389ee..49a1fceb9b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dd4b663e13..9241a58a80 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/eaa319dade..4bc77c26ff * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/fa3b7bdefa..eb8c7b071a * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d21838aeaa..df8e710224 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/68780d9b8c..358a107a6f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/397d8fbc0e..ed4446acf1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia5f41d44828dcca8fbed32062a8e9bae606ab835 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5525919 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Liza Burakova 36cd4c1f 2024-05-08T12:27:22 Adding basic readPixels. This change adds to methods in ImageHelper to read texture data. It also implements FramebufferWgpu::readPixels to get the parameters and read the texture data from an ImageHelper that's stored in mRenderTargetCache. Bug: angleproject:8653 Change-Id: I349ed8a0ae3d8d0e187c658f3402c4f8cac23eb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5441353 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Cody Northrop 6a6192c8 2024-05-08T08:42:24 Tests: Add native to EGLPrintEGLinfoTest For comparisons, it is useful to run the EGLPrintEGLinfoTest against native drivers. Test: angle_end2end_tests --gtest_filter=EGLPrintEGLinfoTest.*/ES3_2_EGL Bug: b/337554150 Change-Id: If7c94296fbbd9f3057449d54581f334a37e59216 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5525656 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 071e1e83 2024-05-08T10:33:49 EGL: eglCreateSyncKHR uses a return value for the tail call eglCreateSyncKHR was duplicated in two lists for using a tail call and needing a return value tail call. Bug: angleproject:8434, chromium:338902974 Change-Id: I9dffeaec3468e4ea3f5ed7d885e9ef418e8d8da5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5525854 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4c66e8a4 2024-05-08T07:02:33 Roll Chromium from 7a22cfe5a3e7 to 4fea14b56dd7 (650 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7a22cfe5a3e7..4fea14b56dd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/39e82ca2f8..7796c50af5 * buildtools/reclient: re_client_version:0.138.0.e854224-gomaip..re_client_version:0.141.1.29a9d3c-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/de4f9bcc57..a2a6e48c98 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4cc26001b9..47d3198a95 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4d9ad255f1..df437783c2 * third_party/fuchsia-sdk/sdk: version:20.20240430.3.1..version:20.20240507.3.1 * third_party/r8: a2gKt0z-OOG5sntIiNXVd6LFDWUuvR-rstsrF59EEnIC..ntlyos9oLHW_q1AeZovqFuTYzog9dKd2lITTowptHuYC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/14ba9b58df..964cf5c799 * tools/luci-go: git_revision:69f852c6aea2797c75712d59145efd38d7032196..git_revision:91ca2f5af39c4feb1c748c353f4d616e1c2332e7 * tools/luci-go: git_revision:69f852c6aea2797c75712d59145efd38d7032196..git_revision:91ca2f5af39c4feb1c748c353f4d616e1c2332e7 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/668bf195ba..54a120d570 * tools/skia_goldctl/linux: 4Ox2OXGb8xipJPUsrFptKWJNJelzwWHBB3ORF1iHt94C..rnVa2tBzy_bWBzhMbfGN9LWVREg2oX7FIWTizcil9nAC * tools/skia_goldctl/mac_amd64: -H7DJpIRXUmi9ddRqVRJXThT1nlK7ns94UOnHMmeP4IC..Y1vx6zBEl8AgYA0BE99RK71LoJPAJMdFcFZUiiH4ItIC * tools/skia_goldctl/mac_arm64: FclksBOdZsrGv0dS7P163Fl3zi60z6nQCDXMNOoAYLYC..1QeDGa3HwvjmY-wV4NK81PTGZGJ_uSZ0FSC0dHAosIsC * tools/skia_goldctl/win: CBmdgsk0TAPgochRHBMBS9LZzdhYMOsNaJSAPvA-e-YC..qWfDi1N2HXBm5wLJgsy6fImu51jqJ6JafFDWjWJPuMQC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ib7d612cf0e26d54a0af665f971fe5de881d4e93a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5524111 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brian Sheedy 1dc83614 2024-05-07T14:54:06 Suppress experimental Linux/Intel failure Adds a test skip for a flaky test that was accidentally omitted when enabling the Linux/Intel experiment. Bug: angleproject:8683 Change-Id: I28dea9cb9617f5b8e4cb26d4626a5472608ac398 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5523916 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Liza Burakova 1d0ef518 2024-05-07T16:56:43 Fixing glClear tests. This CL makes a few changes to fix up the basic glClear test RGBA8Framebuffer, as well as adding a test that uploads a texture before clearing a RGBA8 framebuffer. It moves the wgpu::RenderPassDescriptor(RPD), as well as helper methods for comparing RPDs from the context to the framebuffer. The color attachments that are created in when FramebufferWgpu::clear is called are also stored in the framebuffer now as well. This CL also changes texture creation to use the RGBA8Unorm format instead of RGBA8Uint format. It also adds the wgpu viewFormats parameter to an ImageHelper. Future formats support is still TBD. Bug: angleproject:8582 Change-Id: Idfc4182eb4d6de8a771f2f91d337564ee71df010 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5503549 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Shahbaz Youssefi e29d643e 2024-05-07T13:40:18 Vulkan: Fix missing per-present-mode query ... if VK_EXT_surface_maintenance1 is supported but VK_EXT_swapchain_maintenance1 isn't. The code mistakenly made the appropriate query conditional to the presence of swapchain_maint1 instead of surface_maint1. On devices where surface_maint1 was available but swapchain_maint1 wasn't, this caused a VVL error that is now fixed. Bug: angleproject:8680 Change-Id: Ide9a87f0e50887572f693d741d5476361320ea19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5522756 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 3d04180c 2024-05-02T17:30:02 Vulkan: Add a dedicated garbage list for RefCountedEvents Previously each individual RefCountedEvent is wrapped into a GarbageObject. That is the reason behind RefCountedEvent being a subclass from WrappedObject, since vk::GetGarbage call requires garbage object is a subclass of WrappedObject. This CL adds a new garbage list dedicated for RefCountedEvents, named mRefCountedEventGarbageList. With this new change, we no longer limited by the vk::GetGarbage requirements since it no longer called for RefCountedEvents. RefCountedEventCollector is a vector of RefCountedEvents and every time a RefCountedEvent needs to be released, it adds into the collector. Then the event collector entire thing is treated like a garbage object and gets ResourceUse tracked and added into mRefCountedEventGarbageList. This list gets walked and cleaned when GPU is completed. This CL is also a preparation for later CLs that adds event recycle support. Bug: b/336844257 Change-Id: I4eff69b66922dfe5521b6994f240e967ff3726bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5516458 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 5b9e7f20 2024-05-06T14:50:44 Vulkan: Release mCurrentEvent before oneOff surface image copy In ImageHelper::copySurfaceImageToBuffer and ImageHelper::copyBufferToSurfaceImage, which get called from lockSurface, we are doing a one off submission to do the data copy between image and buffer. Surface image may have a current event set earlier, but we do not have a garbage collector to collect it. This will crash in barrierImpl when we try to add mCurrentEvent to the garbage collector. This CL releases mCurrentEvent so that it will fall back to pipelineBarrier. Since this is not on performance critical code path, the impact should be acceptable as well. Bug: b/336844257 Change-Id: Ib85c3038657a1845e86286cdb5f52247c2b9eb73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5519173 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov 0905ac07 2024-05-07T16:21:27 Roll third_party/dawn/ ed2c7c713..5406e9dfb (307 commits; 7 trivial rolls) https://dawn.googlesource.com/dawn.git/+log/ed2c7c7133fd..5406e9dfbe0b $ git log ed2c7c713..5406e9dfb --date=short --no-merges --format='%ad %ae %s' 2024-05-07 cwallez CMake: Fix workaround for CMake < 3.20 generated files. 2024-05-07 arthursonzogni Add missing header declaration to GN/CMake 2024-05-07 cwallez ShaderModule.h: Remove a few references to SPIR-V. 2024-05-07 rharrison Re-enable AF matrix tests 2024-05-07 jrprice [tint] Link libraries for dlopen 2024-05-07 jrprice [tint] Fix TINT_BEGIN_DISABLE_ALL_WARNINGS for GCC 2024-05-07 bclayton [tint][spirv] Remove use of locale 2024-05-07 cwallez Use an internal version of [Static]SamplerBindingLayout. 2024-05-07 cwallez Simplify SampleUtils a bit. 2024-05-07 hitawala [YCbCr Samplers] Use helper for CreateSamplerYcbcrConversion 2024-05-07 arthursonzogni Reorder member around PNextChainBuilder. 2024-05-07 cwallez Simplify CppHelloTriangle and rename depth-stencil from samples 2024-05-07 dawn-autoroll Roll DirectX Shader Compiler from 7db2fc129ab6 to 773b01272719 (1 revision) 2024-05-07 dawn-autoroll Roll Depot Tools from 94f42f8fe3fe to 4d9ad255f1ad (4 revisions) 2024-05-07 dawn-autoroll Roll vulkan-deps from b74ef144e313 to c11038d160c6 (26 revisions) 2024-05-07 dawn-autoroll Roll ANGLE from b0875f124a24 to 5c78d084206f (4 revisions) 2024-05-07 jrprice [ir] Add Function::AppendParam() helper 2024-05-07 bsheedy Expand x86 NVIDIA expectations 2024-05-07 shrekshao [Compat] Fix cube texture for compressed texture 2024-05-07 jrprice [uniformity] Fix ICE for pointer parameters 2024-05-06 shrekshao Refactor Inspector::GetTextureQueries 2024-05-06 cwallez Metal: Allow additional swapchain formats 2024-05-06 bsheedy Suppress additional Win/NVIDIA exp failures 2024-05-06 jrprice [msl] Refactor barrier polyfills 2024-05-06 enga Delete old Metal interop APIs 2024-05-06 cwallez CMake: Compile without -Werror by default. 2024-05-06 dawn-autoroll Roll DirectX Shader Compiler from af955d601dca to 7db2fc129ab6 (1 revision) 2024-05-06 dawn-autoroll Roll Depot Tools from a60f90e38e53 to 94f42f8fe3fe (1 revision) 2024-05-06 hitawala [YCbCr Samplers] Add and use YCbCrVkDescriptor struct 2024-05-06 robertphillips Add "delayimp.lib" linking to fix unresolved external symbol __delayLoadHelper2 issue 2024-05-06 dawn-autoroll Roll ANGLE from 9ccb9b410289 to b0875f124a24 (5 revisions) 2024-05-06 shaobo.yan Support Coord Transformation for TextureLoadExternal() 2024-05-06 jiawei.shao Pretty-print resource usages in resource tracking errors 2024-05-05 dawn-autoroll Roll ANGLE from 28d4c3eb689c to 9ccb9b410289 (1 revision) 2024-05-05 dawn-autoroll Roll ANGLE from ef8d9f10e684 to 28d4c3eb689c (1 revision) 2024-05-04 dawn-autoroll Roll Depot Tools from 58ff1badf92c to a60f90e38e53 (1 revision) 2024-05-04 dawn-autoroll Roll ANGLE from be9e63ad090d to ef8d9f10e684 (8 revisions) 2024-05-03 enga Expand top tier maxTextureArrayLayers to 2048 2024-05-03 dawn-autoroll Roll DirectX Shader Compiler from 381750e25b62 to af955d601dca (1 revision) 2024-05-03 dawn-autoroll Roll Depot Tools from 39c8c75cf6a2 to 58ff1badf92c (1 revision) 2024-05-03 zhusida GPU: Add NV16/NV24/P210/P410 multi-planar format support 2024-05-03 lehoangquyen Make DawnLoadResolveTexture compatible with TransientAttachments 2024-05-03 dawn-autoroll Roll ANGLE from a96e9197f538 to be9e63ad090d (3 revisions) 2024-05-03 ynovikov Suppress flaky WebGPU CTS failure on Android 2024-05-03 amaiorano Add sysroot DEP for standalone builds 2024-05-03 jrprice [spirv-reader] Handle OpIAdd instructions 2024-05-03 jrprice [spirv-reader] Accept DepthReplacing 2024-05-03 jrprice [tint][exe] Use `lower` when reading SPIR-V to IR 2024-05-03 jrprice [ir] Fix TINT_DUMP_IR_WHEN_VALIDATING 2024-05-03 bclayton [tint][ast] Skip ClampFragDepth fuzzer if member offsets collide (...) 2024-04-23 bclayton [tint][fuzz][ast] Add AddEmptyEntryPoint fuzzer 2024-04-23 bclayton [tint][fuzz][ast] Add AddBlockAttribute fuzzer 2024-04-23 bclayton [tint][fuzz] Limit the first_index_offset value 2024-04-22 shrekshao [Compat] Fix a bug when textureDimension with 1 arg is first called 2024-04-22 dawn-autoroll Roll DirectX Shader Compiler from e2f0b9844019 to 7cf175f89bf2 (1 revision) 2024-04-22 bclayton [tint][fuzz] Add fuzzer command line flags 2024-04-22 bclayton [tint][spirv-ast] Fix emission of discard followed by statement 2024-04-22 dawn-autoroll Roll Depot Tools from 6ba67afd6fb7 to b0e2e28a957d (1 revision) 2024-04-22 ynovikov Suppress Pixel 6 Android 14 failures already suppressed on Android T 2024-04-22 albin.bernhardsson Vulkan: Implement fast path for writeBuffer 2024-04-22 hitawala [YCbCr Samplers] Reland Rename SamplerYCbCrVulkanDesc to YCbCrVulkanDesc 2024-04-22 dawn-autoroll Roll ANGLE from 36ae4553287d to f2901ba7c2f6 (1 revision) 2024-04-22 dawn-autoroll Roll vulkan-deps from b7e3beee69a5 to 36da75a01950 (1 revision) 2024-04-21 dawn-autoroll Roll ANGLE from 23b8a833f3da to 36ae4553287d (1 revision) 2024-04-20 dawn-autoroll Roll vulkan-deps from 71b11532ed72 to b7e3beee69a5 (1 revision) 2024-04-20 dawn-autoroll Roll Depot Tools from 1abad43773fe to 6ba67afd6fb7 (3 revisions) 2024-04-20 dawn-autoroll Roll ANGLE from 84b8737394d5 to 23b8a833f3da (1 revision) 2024-04-20 dawn-autoroll Roll vulkan-deps from 4737535cad1a to 71b11532ed72 (6 revisions) 2024-04-20 enga Revert "[YCbCr Samplers] Rename SamplerYCbCrVulkanDesc to YCbCrVulkanDesc" 2024-04-19 dawn-autoroll Roll Depot Tools from b7ed76a09d19 to 1abad43773fe (3 revisions) 2024-04-19 dneto Fix clang-tidy warnings 2024-04-19 hitawala [YCbCr Samplers] Rename SamplerYCbCrVulkanDesc to YCbCrVulkanDesc 2024-04-19 hitawala [YCbCr Samplers] Add SamplerBindingType::YCbCr 2024-04-19 ynovikov Suppress flaky WebGPU CTS failures on Pixel 6 Android 14 2024-04-19 ynovikov Suppress Pixel 6 Android 14 failures already suppressed on Android T 2024-04-19 dawn-autoroll Roll ANGLE from d4abe62268f3 to 84b8737394d5 (5 revisions) 2024-04-19 dawn-autoroll Roll vulkan-deps from a746f1500410 to 4737535cad1a (7 revisions) 2024-04-19 cwallez BackendMTL: Re-add MTLGPUFamily::Mac1 as some builders use it. 2024-04-19 dawn-autoroll Roll Depot Tools from 6aaae8582125 to b7ed76a09d19 (4 revisions) 2024-04-19 jiawei.shao Reland "Implement AlignedAlloc and AlignedFree" 2024-04-19 jie.a.chen Add SharedTextureMemoryD3dSwapchainBeginState 2024-04-19 lokokung Remove extra namespace indent in webgpu_cpp header template 2024-04-19 dawn-autoroll Roll DirectX Shader Compiler from dda80a98c492 to e2f0b9844019 (5 revisions) 2024-04-19 bsheedy Add Win/ARM64 trybot 2024-04-19 dneto Fix clang-tidy warnings 2024-04-19 jie.a.chen Enable SharedTextureMemoryD3D12 concurrentRead 2024-04-19 dawn-autoroll Roll ANGLE from 6861da63bb01 to d4abe62268f3 (10 revisions) 2024-04-18 lokokung [dawn][wire] Make FillReservation release WGPU objects if released. 2024-04-18 dawn-autoroll Roll SwiftShader from 764410d4d655 to 9aec4b969291 (2 revisions) 2024-04-18 hitawala [YCbCr Samplers] Iterate over chain for external format validation 2024-04-18 dawn-autoroll Roll vulkan-deps from aa20d192b8c4 to a746f1500410 (2 revisions) 2024-04-18 dawn-autoroll Roll Depot Tools from af97284b58af to 6aaae8582125 (1 revision) 2024-04-18 dneto Fix clang-tidy misc-include-cleaner warnings 2024-04-18 cwallez Add WGPU[Obj]AddRef and deprecated WGPU[Obj]Reference 2024-04-18 ynovikov Suppress OpenGLES end2end failures on Pixel 6 2024-04-18 geofflang Reland "Use abseil's build targets instead of custom ones." 2024-04-18 hitawala [YCbCr Samplers] Pass VkSamplerYcbcrConversionInfo on creating Sampler 2024-04-18 cwallez Revert "Implement AlignedAlloc and AlignedFree" 2024-04-18 dawn-autoroll Roll DirectX Shader Compiler from 690ec7cd7d8d to dda80a98c492 (2 revisions) 2024-04-18 jrprice [tint] Polyfill fwidthFine for MSL and HLSL Created with: roll-dep third_party/dawn Bug: chromium:329228449 Change-Id: Iff0028a8d391ab8da4ccd8095a8dc0ac24d2ded4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5522774 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Le Hoang Quyen f3089d1d 2024-05-07T00:14:53 Metal: fix UBO data update undetected between draw calls. This CL fixes an issue where an UBO was updated between two draw calls. This would internally allocate a new metal buffer however ContextMtl didn't know that hence it didn't rebind with new buffers. Bug: b/338348430 Change-Id: I3d8ce22921811e49ae1b8016ae4a20d770f6f372 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5515858 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Yuly Novikov 6d10e966 2024-05-07T15:14:02 Switch ANGLE to new GPU Android mixins Bug: chromium:338536265 Change-Id: I25b7ff35ccea3fe8cde1661715f86fc341d2b82e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5522773 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya 62eb8fbe 2024-05-06T07:22:15 Vulkan: Switch to using zlib::crc32_z for CRC generation A CRC is generated to validate blobs that are compressed / decompressed. There was a custom CRC generator being used, switch over to using zlib's crc32_z(...) Also increment kPipelineCacheVersion's version since both the header and structure have been updated. Data collected with dEQP test suite - 1. egl size of blob - 74022 bytes ComputeCRC16 - 0.001683 sec zlib::crc32_z - 0.000008 sec 2. gles2 size of blob - 8709119 bytes ComputeCRC16 - 0.130268 sec zlib::crc32_z - 0.000625 sec 3. gles3 size of blob - 20308078 bytes ComputeCRC16 - 0.433155 sec zlib::crc32_z - 0.002547 sec 4. gles31 size of blob - 11041841 bytes ComputeCRC16 - 0.192512 sec zlib::crc32_z - 0.000452 sec Bug: angleproject:4722 Change-Id: Iaa7026c9c8a748b446ef2320e584a2937336c7b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5518595 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll da1fbbc6 2024-05-07T07:01:36 Roll Chromium from 4beb6b144a74 to 7a22cfe5a3e7 (616 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4beb6b144a74..7a22cfe5a3e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/beb031dae2..39e82ca2f8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3cdb58b684..de4f9bcc57 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a60f90e38e..4d9ad255f1 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/09737b8e11..d17298ab09 * third_party/r8: NvYmFgaDR5pSbEH88fOJRqBbLZT5maGLr_7_iZD3vg4C..a2gKt0z-OOG5sntIiNXVd6LFDWUuvR-rstsrF59EEnIC * third_party/siso: git_revision:70d9e16bcc9dff0264905018f5a5652b37ed0e10..git_revision:4524544994f4eac131378143f498ee4d0b7d1f36 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9e76abab9c..14ba9b58df No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: If874a3a14534903e044f7244f41de4ee582ee12d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5519175 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yiwei Zhang 5c78d084 2024-05-04T23:20:36 Android: explicitly disable stack protection This isn't needed by aosp build angle sp-hal and helps reduce cpu overhead. Bug: b/331680143, b/333235176 Test: 5% gain in gfxbench gl_driver2_off score on x86 Change-Id: I0e8662987ef040b1ac5df34a69e90c158363b36f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5516929 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org>
Yuly Novikov f8f2a10b 2024-05-03T18:11:22 Prepare ANGLE to use new Android mixins Bug: chromium:338536265 Change-Id: I225b79cb1a26b63cb74f0d2bd2c1f14048882722 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5514150 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Shahbaz Youssefi c3a1cae4 2024-04-15T14:58:55 Use angle::SimpleMutex everywhere in libGLESv2 Only cases left that use std::mutex are: - Share group and the context ErrorSet mutexes as they need try_lock() - Anywhere mutexes are used in conjunction with std::condition_variables (as they explicitly require std::mutex) Bug: angleproject:8667 Change-Id: Ib6d68938b0886f9e7c43e023162557990ecfb300 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5453294 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Le Hoang Quyen a951e0e0 2024-05-05T23:29:33 Metal: add test for active blit/compute & render encoder mistracking. The bug was already fixed but we need to add the test to avoid the issue from resurfacing in future. Bug: angleproject:8685 Change-Id: Ia10c0954ef39b20b1d891389b7e7a1c81cdc758d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5514529 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll b0875f12 2024-05-06T08:01:29 Roll VK-GL-CTS from 17c6e3c4dfad to 9d7b4c3d5533 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/17c6e3c4dfad..9d7b4c3d5533 2024-05-04 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-04 marcin.zajac@mobica.com DRM_BUF backed images witch format modifier 2024-05-04 javed@igalia.com Add test coverage for inline uniform blocks of smaller sizes 2024-05-04 cturner@igalia.com Explicitly test layered vs separated dpb images 2024-05-04 rgarcia@igalia.com Skip VVL configuration when using SELECTED_BUILD_TARGETS 2024-05-04 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-01 yuxinhu@google.com Add test log parser for new android activity 2024-05-01 lorenzo@khronosgroup.org Add verbose option to build_spirv_binaries.py 2024-05-01 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-25 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-04-23 lorenzo@khronosgroup.org Update external sources If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ic4db01e548ae1bbc06b0f4426d0e95eb7e4b5ced Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5516413 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ff0a33cd 2024-05-06T07:00:21 Roll Chromium from dbc600a2b0d5 to 4beb6b144a74 (625 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dbc600a2b0d5..4beb6b144a74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e940249fa3..beb031dae2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/123fabe3ab..3cdb58b684 * third_party/android_build_tools/lint: O1UDDudkb1fHG2uMxzszPWctYiGgjyywsi7Lbkq7roYC..Y5wuGPB-HfFtEVQC_0XI6n88Covm4HFDxnG0uTdV2LcC * third_party/android_build_tools/manifest_merger: wRnJA-ZlBBQipw_wjYJJemxCCPSZHenIFsWKi3GI_FUC..tz8dYQ_yBEZJRVhtzyyCjOlbOfujkHRWcYZy7419o_cC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8ed0817e40..36a6c64282 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0421a22c02..4cc26001b9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/39c8c75cf6..a60f90e38e * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/51fe358446..09737b8e11 * third_party/r8: QA5iuNqPTlPiuU3Vz1wq-t2s8V1IGAKT-qZL9kVWv3YC..NvYmFgaDR5pSbEH88fOJRqBbLZT5maGLr_7_iZD3vg4C No update to Clang. Bug: angleproject:8434 Tbr: abdolrashidi@google.com Change-Id: I95779d6b1786985ac86d1d8b806727ae82dd4f90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5517542 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yiwei Zhang 465f6b7d 2024-05-03T20:52:55 Android: forward visibility flags This results in a 25~35% perf gain for gfxbench gl_driver2_off on x86 platforms. See also https://gcc.gnu.org/wiki/Visibility Bug: b/331680143, b/333235176 Test: 25~35% gain in gfxbench gl_driver2_off score on x86 Change-Id: I5fb1174ae21f9feb33b8350e21f7cc5445b9cf25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5513280 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 58742dfb 2024-05-05T12:46:11 Use trim() instead of resize() ... when decompressing a blob, this prevents a reallocation and copy. Bug: angleproject:4722 Change-Id: Iedc20cb9a41feb754c7f48188e01ab73c5c03c15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5517530 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Le Hoang Quyen 251067ed 2024-05-03T22:36:11 Metal: don't break render pass when uploading a texture. Bug: b/337214693 Change-Id: Ib2dc77c364a72f2973cbc3882f6125bffbc0a11b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5514948 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Le Hoang Quyen 9ccb9b41 2024-05-03T22:23:03 Metal: fix incorrect tracking if blit & render encoder coexist Currently mtl::CommandBuffer tracks only one active command encoder. However this tracking is wrong if a blit/compute encoder is created without ending the current render encoder. Blit/compute and render encoders are allowed to coexist because the actual rendering encoding is deferred. The bug would happen for e.g. if: - There is an active render encoder. - ContextMtl::getBlitCommandEncoderWithoutEndingRenderEncoder() is called. - In this case, active encoder will be set to the blit encoder. - Later when blit encoder is ended, tracked active encoder would be set to null even though it should be the render encoder. This CL fixes the bug by tracking separate active blit/compute & render encoders. Bug: angleproject:7643 Bug: angleproject:8685 Change-Id: I9893402ecd4c0388aa0153acdb2be04315563086 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5514184 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Charlie Lao 28d4c3eb 2024-05-03T13:00:03 Vulkan: Remove BarrierType argument from ImageHelper::barrierImpl Originally I passed the barrierType argument into barrierImpl function to force pipelineBArrier in a few edge cases. Notably when we do a oneoff submission. In that case if we have an event that is pending setEvent call, and we will end up inserting a waitEvent call on an event that has not yet set, which is bad. But this really won't not happen. This CL removed BarrierType from the API and added a few assertions in the caller to ensure we do not have a valid event when doing a oneoff submission (if there is a pending setEvent, mCurrentEvent will be valid). Bug: b/336844257 Change-Id: I7161b844fc1f36993cf7ff6c90a070d9f92930cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5512878 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao ef8d9f10 2024-05-01T11:52:04 Vulkan: Use DEVICE_ONLY VkEvent when available VK_KHR_synchronization2 adds device only event. Since we are not using host operations on the event, this CL adds VK_EVENT_CREATE_DEVICE_ONLY_BIT_KHR bit when create VkEvent for RefCountedEvent. Bug: b/336844257 Change-Id: I0528b7f45b0da162daa228aea2adf5ce06b5fd6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5503644 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 5eb3bca0 2024-05-01T11:47:34 Vulkan: Minor cleanup Bug: b/336844257 Change-Id: I8d93c6dd814a666debf9990d151cad79c45469f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5503645 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Mohan Maiya 4880a6c2 2024-05-03T14:43:20 Enhance VulkanPerformanceCounterTest coverage Enable additional config with PadBuffersToMaxVertexAttribStride feature Bug: b/271915956 Change-Id: I5fe27781fc51cdf477d5c2f453ad05a211788739 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5512875 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao d30e4772 2024-02-02T14:13:33 Vulkan: Add VkCmdWaitEvents for image barriers This CL add EventBarrierArray (sister class of PipelineBarrierArray) that accumulates the event barriers instead of pipeline barriers. ImageHelper::barrierImpl and ImageHelper::updateLayoutAndBarrier has been updated to have a code path that inserts waiting event to EventBarrierArray. PipelineBarrier code path is still kept and is also used when event is invalid or under certain situation as a fallback method from waitEvent. After we generate barrier (regardless it is pipelineBarrier or eventBarrier, we always release ImageHelper::mCurrentEvent. When next barrier/layout call is made, if we see mCurrentEvent is invalid, we always fallback to pipelineBarrier. This way it is safe that if somehow we did not (intentionally or accidentally) insert a new event between two barrier calls, we will not end up with second barrier call wait for old event which creates synchronization hazard. With this approach, second barrier will use pipelineBarrier which is still safe. In this CL the useVkEventForImageBarrier feature flag is still disabled, so no events are created and thus pipelineBarrier is still used. Bug: b/336844257 Change-Id: Idaf5a7200b85f901eae5d376543f189d21522022 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5263701 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Liza Burakova ead98ed9 2024-05-02T14:04:14 Implement basic texture upload. This change modifies ImageHelper's methods to upload textures to fix webgpu API calls, as well as fully implements uploading texture data via TextureWgpu::setImage for RGBA8 formats. Bug: angleproject:8457 Change-Id: I1c5be3d79ad996a709086ca7157cca6229a336ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5398002 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 81c2b6e7 2024-05-03T08:12:18 Vulkan: Account for padBuffersToMaxVertexAttribStride ... in BufferVk::shouldRedefineStorage. For vendors that require additional padding, redefine storage iff the padded size is greater than existing buffer size. Bug: b/271915956 Change-Id: I2acf2bb32f85b71bcfdba6919974dd2922ee787b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5512870 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 9f3e3bff 2024-05-03T17:28:28 Manual roll Chromium from b689a9ee3ba2 to dbc600a2b0d5 (109 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/b689a9ee3ba2..dbc600a2b0d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ce8359ec57..e940249fa3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cdf49d0710..123fabe3ab * third_party/r8: fXvmQSzprkeb1fs3dnkBm_gsAhb5aUtQGRmUq3Oi1WYC..QA5iuNqPTlPiuU3Vz1wq-t2s8V1IGAKT-qZL9kVWv3YC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/17956d4ffb..9e76abab9c No update to Clang. Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: Ie17cfea3a693b71bf9395e3d7004207139ba549a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5513272 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 9aa6d3da 2024-04-26T11:34:10 Add trim support to MemoryBuffer There are usecases where we need a MemoryBuffer to be trimmed to a smaller size. In such cases there is no need to perform a resize, which would trigger a reallocation. Instead just update MemoryBuffer's size. Bug: angleproject:4722 Change-Id: I5b6cca121977903ffa7663591eaec62f6ffda97a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5513269 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Roman Lavrov be9e63ad 2024-05-02T16:04:25 spirv::Print without ANGLE_ENABLE_ASSERTS -> compile error Currently a link error as we have a declaration but no definition Bug: b/338429767 Change-Id: I06175356613c410c8d7652b28b09636244f8b717 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5513002 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Mohan Maiya 97aaad3a 2024-04-20T19:27:13 Vulkan: Pack DescriptorSetLayoutDesc layout Use angle::FastVector instead of arrays to further compact DescriptorSetLayoutDesc layout Bug: angleproject:8677 Tests: VulkanDescriptorSetLayoutDescTest* Change-Id: I5bb7b2ebf0aa5aba3d7c47c45384788245dce3dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5470362 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 04e469bc 2024-05-03T07:58:45 Roll Chromium from 904b00ce27b4 to b689a9ee3ba2 (548 revisions) https://chromium.googlesource.com/chromium/src.git/+log/904b00ce27b4..b689a9ee3ba2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5eb3babb02..ce8359ec57 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9e629115ed..cdf49d0710 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7ababdfe02..39c8c75cf6 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/4da68f31de..4abbe88863 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d62c213c1e..cc51a5ea86 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e28e015fae..17956d4ffb * tools/luci-go: git_revision:01d1863acbd3d4c41da2aa7407a0ea6a195c770f..git_revision:69f852c6aea2797c75712d59145efd38d7032196 * tools/luci-go: git_revision:01d1863acbd3d4c41da2aa7407a0ea6a195c770f..git_revision:69f852c6aea2797c75712d59145efd38d7032196 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8ca02a85c4..668bf195ba * tools/skia_goldctl/linux: AJacKGh5nnjmNZk56j2ia4-QtIE8eEAFELw48t8XinEC..4Ox2OXGb8xipJPUsrFptKWJNJelzwWHBB3ORF1iHt94C * tools/skia_goldctl/mac_amd64: uJJWpJUp-FSzEXlwqzoUD41p5swLKyDhxXdJBLShbMsC..-H7DJpIRXUmi9ddRqVRJXThT1nlK7ns94UOnHMmeP4IC * tools/skia_goldctl/mac_arm64: ekRiJKPFBJKiZ3N4ev_vRuf2X13dgTDcZNXKYt2qZPoC..FclksBOdZsrGv0dS7P163Fl3zi60z6nQCDXMNOoAYLYC * tools/skia_goldctl/win: 4bTyiie8-MG6hBk2yGEE9d8p3HWHGevaAouvGfKKwtQC..CBmdgsk0TAPgochRHBMBS9LZzdhYMOsNaJSAPvA-e-YC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Iec4c2af4a587bb74dd14cf5f65e5e01d134a2d44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5512867 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0