Log

Author Commit Date CI Message
Clemen Deng bcae3828 2019-08-19T09:37:18 Auto-generated variables detected as mutable constants Need to rename kVar* variables to just var Bug: angleproject:3823 Change-Id: I34b9f4eec4ee7829d47dcac2f06f1acc6b35f867 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1758601 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Clemen Deng <clemendeng@google.com>
angle-autoroll f3ccfba7 2019-08-19T07:01:57 Roll ./third_party/spirv-tools/src 7b4e5bd5ec82..bc62722b80a6 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7b4e5bd5ec82..bc62722b80a6 Created with: gclient setdep -r ./third_party/spirv-tools/src@bc62722b80a6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=syoussefi@chromium.org Change-Id: Icc053f2d4f640868fa010e835f1c9c98e2b1bdcd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1760588 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Glenn Watson 13cc0fce 2019-08-02T07:11:16 Fix occasional corruption of vertex textures in HD4600 GPUs. This appears to be caused by the UpdateSubResource call, which is worked around by enabling the other image upload path that ANGLE supports. The workaround doesn't include a driver version, since the bug is occurring in the most recent driver that is currently available (15.40.42.5063, released 19th Mar 2019). Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1562462 Change-Id: I5135dcf6da6ef530c99124a04003d54f99e4cd7c Bug: angleproject:3764 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1731975 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
James Darpinian 153f3c22 2019-08-16T15:24:30 Miscellaneous build fixes for WebKit Add a USE_SYSTEM_EGL define to allow compilation on Unix systems without X11. Feature detect __popcnt using Microsoft-specific _MSC_VER rather than _M_X64/_M_IX86, which can be set by the Dinkumware stdlib on non-Microsoft systems. Apple's clang is too old to have -Wextra-semi-stmt Ran generate_parser.sh using Cygwin64 bison 3.0.4, flex 2.6.4 Bug: 3439 Change-Id: Ie0d01a112a17f70ef60c120063a958b8f1a094f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1759135 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
James Dong 2f07e4fb 2019-08-02T10:41:56 Add test for array of arrays of samplers This test fails on the Vulkan backend because Vulkan does not allow arrays of arrays of samplers. Also adds a few other tests relating to arrays of arrays. Test: ./angle_end2end_tests --gtest_filter='GLSLTest_ES31.*' Bug: angleproject:3604 Change-Id: I5c47119b6ba6d26fe30fdd9c6730caac6f222696 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1733476 Commit-Queue: James Dong <dongja@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill b8482ab7 2019-08-15T09:49:29 Clean up trace output. Removes the "EVENT: " prefix from every trace message. Also removes the extra blank line between trace entries. And fixes a missing space in EGL_WaitSyncKHR. Bug: angleproject:3815 Change-Id: Id6321357a56477da29de121abb51c721b11d99da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1756084 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Clemen Deng 486f381f 2019-07-18T15:47:31 Add desktop GL built-in functions to symbol table Added GL built-in functions to symbol table autogeneration Built-in lookup now checks against spec and returns GL symbols when appropriate. Bug: angleproject:3719 Change-Id: I74786150f6063b40e13aebcb2eb9ea35e4ecaa53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1731550 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Clemen Deng <clemendeng@google.com>
Jeff Vigil 265fdf0c 2019-07-31T15:10:44 EGL: Set errors per spec for eglCreateContext Per spec, in eglCreateContext when client version attributes are invalid - set EGL_BAD_ATTRIBUTE. Set EGL_BAD_MATCH when config is not compatible. Rename config variables in ValidateCompatibleConfigs to distinguish context from surface configs. Context config handled differently when EGL_NO_CONFIG. Bug: angleproject:3755 Test: angle_end2end_tests --gtest_filter=EGLCreateContextAttribsTest* Change-Id: Iaea57653cf643ff60c8d4eabd3f022306bf1f4ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1747298 Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Mohan Maiya 46be1a60 2019-08-16T10:39:23 Vulkan: Enable an fbo attachment query test in dEQP These tests are now passing with vulkan backend. Remove them from the expectations file Bug: angleproject:3679 Test: dEQP-GLES3.functional.state_query.fbo.framebuffer_attachment_texture_layer Change-Id: Ifb07b3743bf4ea0a7a98c33ae15cce46f6f2f75b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1758683 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 609d45f6 2019-08-14T15:16:49 Capture/Replay: Use Renderbuffer ID map. This should give a more robust replay. Devices are not guaranteed to return IDs in the same order in each instance of a program. Also for mid-execution capture we often won't have the same resources available. Once the Renderbuffer implementation lands we can switch to using more resource maps for different types of resources. Bug: angleproject:3611 Change-Id: I84a5b84856be3e8eb13e424e1990a39553adb82e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1719066 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ian Elliott cc25d9fb 2019-08-15T15:13:02 Vulkan: Update copy_tex_image test failure bug ids Splitting out two bugs from 3458. Most of failing tests are failing because of Vulkan validation errors in the ANGLE glDrawArrays code. In those csaes, the copy_tex_image test code actually passes, but the ANGLE test-runner code is marking the tests as failing because of Vulkan validation errors. Bug: angleproject:3458 Bug: angleproject:3817 Bug: angleproject:3818 Change-Id: Idd91d9e44fa7eb6f527425dd77d6cbf949aa5e61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1756816 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 12515425 2019-08-15T11:54:18 Remove context from linking state. This Context could already be deleted from another thread. Better to use save/load with the current thread. Bug: angleproject:2464 Change-Id: Id7879a53bdfb7d1c86b09bb3e779a87afdefa873 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1756086 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 791e19e7 2019-08-16T07:01:56 Roll ./third_party/spirv-tools/src ff872dc6bf9f..7b4e5bd5ec82 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ff872dc6bf9f..7b4e5bd5ec82 Created with: gclient setdep -r ./third_party/spirv-tools/src@7b4e5bd5ec82 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=syoussefi@chromium.org Change-Id: Id2cd2aa4e98750f80dc7b023e48d4708c12a6b7d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1757865 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
shrekshao cdecd97c 2019-06-25T14:22:41 Add Draw base vertex and base instance function entrypoints Split from https://chromium-review.googlesource.com/c/angle/angle/+/1705035/27 This patch adds entrypoints glDrawArraysInstancedBaseInstanceANGLE, glDrawElementsInstancedBaseVertexBaseInstanceANGLE, glMultiDrawArraysInstancedBaseInstanceANGLE, and glMultiDrawElementsInstancedBaseVertexBaseInstanceANGLE Implementation will come in a later separate patch. Bug: chromium:891861, angleproject:3402 Change-Id: I18e19b850cddd79be4798b9ae7efe0680a050c7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1750125 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 0a3c8246 2019-08-15T13:24:20 Vulkan: Write preprocessed shaders with // instead of #if 0 Bug: 993965 Change-Id: I4fd357bdebc73b7256ae4b34bd1c6aa2f4418e27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1756503 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott 29b2fc4a 2019-08-15T09:25:04 Vulkan: Expect more texture-specification tests to pass. Recent changes allow these tests to pass. Bug: angleproject:3190 Bug: angleproject:2905 Change-Id: I549b3d0cc7beced756c2b44e9a72d399b51aa8f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1756284 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Jamie Madill 7c1af2d5 2019-08-14T15:16:49 Capture/Replay: Use GL types for packed types. Previously we were trying to use the packed enum types for our replay. This wouldn't work as the packed enum types don't exist outside of ANGLE. Bug: angleproject:3611 Change-Id: Id0d5c9f37304b30c204bac9bc7873661b035f918 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1754324 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Clemen Deng 1d742ce8 2019-08-13T10:33:36 Deleted unnecessary built-in conditions A few built-in variables are checking against overly complicated extension conditions, deleting these will make the array lookup easier to implement. Also changed functionality to always enable GL_OVR_multiview when GL_OVR_multiview2 is enabled Bug: angleproject:3805 Change-Id: I10fc7db0fa8b496fbba8b2c27a7311ac3c24dbe4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1752082 Commit-Queue: Clemen Deng <clemendeng@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill 188b679b 2019-08-15T09:02:43 Remove GL/EGL function pointers from tests. The auto-gen loader code should be able to handle all these cases. Bug: angleproject:3393 Change-Id: If0a90fb29d79f2892fdf76fe0cb91ed0036ee1e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1756083 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Jamie Madill be74c47d 2019-08-13T13:54:15 Capture/Replay: Also capture on postSubBuffer. Necessary to capture from Chrome. Bug: angleproject:3611 Change-Id: Ia9330e0c273e65adaa4171020d0aebb05e100260 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1752013 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 611663f4 2019-08-15T07:01:46 Roll ./third_party/glslang/src 37fc4d27d612..95609e6d923a (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/37fc4d27d612..95609e6d923a Created with: gclient setdep -r ./third_party/glslang/src@95609e6d923a The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=syoussefi@chromium.org Change-Id: I3c9a4bf1bd3594a46359f7ddb41e9fc927858600 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1755323 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a59888cc 2019-08-15T07:02:05 Roll ./third_party/spirv-tools/src f701237f2d88..ff872dc6bf9f (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f701237f2d88..ff872dc6bf9f Created with: gclient setdep -r ./third_party/spirv-tools/src@ff872dc6bf9f The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=syoussefi@chromium.org Change-Id: I111edf50b76557c575dc4ac0aa6d268076e7e36a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1755510 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jiacheng Lu 3ea90d60 2019-07-26T15:20:53 Fix compile error on capture with client array 1. The current implementation misused the offset in gBinaryData as the memcpy size. This CL fixed it by adding the byte size into the UpdateClientArrayPointer call. 2. Trying passing a pointer to a C-style array parameter which causes compiling error. This CL fixed by simply use const void * to do memcpy. 3. Able to run frame capture successfully for the first 100 frames of glmark2. Bug: angleproject:3611 Change-Id: Ibaef224c2a2d124b681757d9ecd187a5f9b7079b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1721207 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Stuart Morgan 9d737966 2019-08-14T12:25:12 Standardize copyright notices to project style For all "ANGLE Project" copyrights, standardize to the format specified by the style guide. Changes: - "Copyright (c)" and "Copyright(c)" changed to just "Copyright". - Removed the second half of date ranges ("Y1Y1-Y2Y2"->"Y1Y1"). - Fixed a small number of files that had no copyright date using the initial commit year from the version control history. - Fixed one instance of copyright being "The ANGLE Project" rather than "The ANGLE Project Authors" These changes are applied both to the copyright of source file, and where applicable to copyright statements that are generated by templates. BUG=angleproject:3811 Change-Id: I973dd65e4ef9deeba232d5be74c768256a0eb2e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1754397 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tobin Ehlis a2ec1344 2019-08-13T14:13:35 Add shared mutex to frontend Add shared mutex to frontend API entrypoints that is only enabled when ANGLE is being used with a shared context. Bug: angleproject:2464 Change-Id: I0d918e37d9579dccd013dc88f563bed7de7ee55f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1685712 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Courtney Goeltzenleuchter bc0a7b58 2019-08-05T09:26:23 Add support for sampling stencil texture Suspect a potential driver issue with integer sampling from stencil so skip dEQP-GLES31.functional.stencil_texturing.misc.compare_mode_effect in the expectations file. Will follow-up with more directed tests. Also skip dEQP-GLES31.functional.stencil_texturing.misc.base_level Blocking Bug: angleproject:3148 Test: dEQP-GLES31.functional.stencil_texturing* Bug: angleproject:3575 Change-Id: I9547406b44ec16629631c1bf50907e6a24f1a20e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1736946 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 5a2553a7 2019-08-07T14:44:12 Vulkan: Emulate subgroup ops in seamful cubemap emulation Where subgroup ops are not available, they are emulated as such: Code with subgroup ops: float lH = subgroupQuadSwapHorizontal(layer); float lV = subgroupQuadSwapVertical(layer); float lD = subgroupQuadSwapDiagonal(layer); bool isHelperH = subgroupQuadSwapHorizontal(gl_HelperInvocation); bool isHelperV = subgroupQuadSwapVertical(gl_HelperInvocation); if (gl_HelperInvocation) { layer = !isHelperH ? lH : !isHelperV ? lV : lD; } Emulated code: float nonHelperLayer = gl_HelperInvocation ? 0.0 : layer; float lH = abs(dFdxFine(nonHelperLayer)); float lV = abs(dFdyFine(nonHelperLayer)); float lD = abs(dFdxFine(lV)); float isHelperDiffH = abs(dFdxFine(float(gl_HelperInvocation))); bool isNonHelperH = isHelperDiffH > 0.5; float isHelperDiffV = abs(dFdyFine(float(gl_HelperInvocation))); bool isNonHelperV = isHelperDiffV > 0.5; if (gl_HelperInvocation) { layer = isNonHelperH ? lH : isNonHelperV ? lV : lD; } Both paths are supported as on nvidia devices the emulated code misbehaves. This change therefore effectively only enables seamful cube map emulation on Android where subgroup operations are not supported. Bug: angleproject:3243 Bug: angleproject:3732 Change-Id: I9664d9760756758748183eb121c626f176789f3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1742222 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott 20141940 2019-08-14T11:46:49 Vulkan: Enable copy_tex_image_conversions tests to run A recent change(s) eliminated the crash that was occuring with the KHR-GLES3.copy_tex_image_conversions.required.* and KHR-GLES3.copy_tex_image_conversions.forbidden.* tests. The still-failing tests are getting 2 types of Vulkan validation errors. 1) The "required" tests get errors about using the VK_FORMAT_R8G8B8A8_UNORM descriptor-set format when an SINT/UINT component type is required. 2) The "forbidden" tests are getting errors about using more valid memory objects than allowed. Bug: angleproject:3458 Bug: angleproject:3800 Change-Id: I9536da6a2c888413ba0ab789a4dc9559d40fcf1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1754391 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Courtney Goeltzenleuchter 01867144 2019-07-19T14:51:29 Vulkan: Add support for D32F_S8 depth_texture Test: angle_deqp_khr_gles3_tests --deqp-egl-display-type=angle-vulkan --gtest_filter=dEQP.KHR_GLES3/packed_depth_stencil_verify_read_pixels_depth24_stencil8 angle_deqp_khr_gles3_tests --deqp-egl-display-type=angle-vulkan --gtest_filter=dEQP.KHR_GLES3/packed_depth_stencil_clear_buffer_depth32f_stencil8 Full passing results are blocked by suspected driver issues: Bug: angleproject:3683 Bug: angleproject:3689 Bug: angleproject:3457 Change-Id: I7ce1a7824802ebca2c0479a3467fac26013829eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1704791 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Fei Yang 4346c8b1 2019-04-09T14:50:23 Vulkan: pipeline cache not populated as blob cache is not set 1. Use vkMergePipelineCaches to recreate pipeline cache after blob cache callbacks are set after eglInititalize. 2. Use a more proper way to save the cache data to disk. Bug: angleproject:3318 Change-Id: Ied1fb572813198b51e02ed9629cbf34e2d9159b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1683807 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop a25c15c5 2019-08-08T19:47:47 Implement FramebufferTexture3D Bug: angleproject:3188 Bug: angleproject:3797 Test: KHR-GLES2.texture_3d.framebuffer_texture.rgba8 (with patch from 3797) Change-Id: Id44938504df00c3aba3fe733e7c71ad37ce1aab7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1745838 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 4bb50faa 2019-08-14T11:23:57 Suppress flaky SwapInterval test Bug: angleproject:3807 Change-Id: If44223e39a30a93358392b22b98beaa31ef220d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1753587 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 2971fd34 2019-08-12T16:53:21 Roll glmark2. Includes build for Android, test fixes, and swapInterval 0 for WGL. Bug: angleproject:3806 Change-Id: Ied8f221fc3002cff2ccdc83dc6d45bc8640a4a4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1752017 Reviewed-by: James Dong <dongja@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 99cffe5d 2019-08-01T17:10:50 Vulkan: Fix glCopyTexSubImage3D() Update glCopyTexSubImage3D() to account for the requirements necessary for VK_IMAGE_TYPE_3D. Bug: angleproject:3765 Test: KHR-GLES2.texture_3d.copy_sub_image.rgba8 Test: angle_end2end_tests CopyTexImageTestES3 Change-Id: Ife3d768323d0cfe2a53e5ae4c47a0747d65981bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1730637 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
James Darpinian 7e48c9eb 2019-08-06T17:17:19 Add explicit integer casts WebKit uses the -Wshorten-64-to-32 flag which warns on these cases. Bug: 3439 Change-Id: I8c1de60da0f173ca2036e2120e79b857f5f2775f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1740866 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Geoff Lang b3eeb2a4 2019-08-05T17:02:43 Emulate RGB textures using BGRX IOSurfaces. When the user requests an IOSurface Pbuffer with an RGB format, emulate the missing alpha channel by clearing it to 1.0 and masking reads and writes in shaders. BUG=angleproject:3766 Change-Id: I58c992bf641d9ece0f923603f32640615150e4f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1737437 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Jamie Madill 22511021 2019-08-13T09:17:52 Vulkan: Remove unused GetDepthStencilAspectFlagsForCopy. Was incorrect and causing a Clang warning. Bug: chromium:992863 Change-Id: Ieff7b332ee11a6330bd5879d73b53ad374f40664 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1751622 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2ab08edc 2019-08-12T16:20:21 Use TextureID in place of GLuint handles. Bug: angleproject:3611 Change-Id: Ie6156e8732b3ca4dc6c4439c059a5481a4dfd250 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1738753 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 95677002 2019-08-13T07:01:57 Roll ./third_party/spirv-tools/src 95386f9e45a2..f701237f2d88 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/95386f9e45a2..f701237f2d88 Created with: gclient setdep -r ./third_party/spirv-tools/src@f701237f2d88 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=syoussefi@chromium.org Change-Id: I594c11907c62b541cf5090c5368493dd6d4996cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1750896 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 9e4b116c 2019-08-12T16:55:23 Use official EGL.h. We upstreamed the changes here so it is no longer necessary to maintain a fork. Bug: angleproject:3706 Change-Id: I21cc63cb94f8b3603d75ce8ec86b856514a8cb5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1749335 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jiacheng Lu 9e14a19b 2019-08-09T10:03:24 EVENT trace to print GLenum as string reland Reland of CL https://chromium-review.googlesource.com/c/angle/angle/+/1737141 Bug: angleproject:3778 Change-Id: I2a43c618de032d6e6286d707fbc88241ad4c19ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1745837 Commit-Queue: Jiacheng Lu <lujc@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 1d0a778f 2019-08-12T09:15:15 Vulkan: Enable a few integer state query tests in dEQP These tests are now passing with vulkan backend. Remove them from the expectations file Bug: angleproject:3680 Test: dEQP-GLES3.functional.state_query.integers.max_elements_indices_getfloat dEQP-GLES3.functional.state_query.integers.max_elements_vertices_getfloat dEQP-GLES3.functional.state_query.integers.max_program_texel_offset_get* dEQP-GLES3.functional.state_query.integers.min_program_texel_offset_get* Change-Id: I65b189929553750e22b15ea3b83b88f72a6c9795 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1748885 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3b3fe837 2019-08-06T17:44:12 Use BufferID in place of GLuint handles. Introduces enable_if handling for "FromGL". Avoids the use of any macro code to handle resource id casting. Bug: angleproject:3611 Change-Id: I1a6d10c3c9cc6ba0dc072bad1d62c33551f05d87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1736127 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Fei Yang d7500aa8 2019-08-02T15:52:39 Vulkan: Regression issue on AngryBird for read bandwidth Use AllGraphicsShaderReadOnly as the image layout for graphics path. Bug: angleproject:3473 Change-Id: I1e653890e69f347b2aba4a0156a5d5b86109fd0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1732617 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4248e115 2019-08-12T07:01:46 Roll ./third_party/glslang/src 3cea2e5882e3..37fc4d27d612 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3cea2e5882e3..37fc4d27d612 Created with: gclient setdep -r ./third_party/glslang/src@37fc4d27d612 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=ynovikov@chromium.org Change-Id: I93044555595ec89246df6a704ad90811222f84c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1748611 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 07bd0434 2019-08-12T07:01:57 Roll ./third_party/spirv-tools/src 22ce39c8e1ec..95386f9e45a2 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/22ce39c8e1ec..95386f9e45a2 Created with: gclient setdep -r ./third_party/spirv-tools/src@95386f9e45a2 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=ynovikov@chromium.org Change-Id: I851e3f1d0177ba53cb403aae1dbc372f98cf9f20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1748612 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott b90755ba 2019-08-09T10:53:22 Vulkan: Remove a call to addReadDependency() that shouldn't be done. Bug: angleproject:3798 Change-Id: I516e6b0766ba0fe7c0bc7f6cd9f4aea91c7536f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1745839 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Cody Northrop d48d38ce 2019-08-09T11:03:35 Vulkan: Restore DrawBuffersTestES3.3DTextures on Intel Linux The test was failing due to ANGLE changes, not the target itself. It is unclear why this was the only one showing Vulkan validation errors, but it is passing now. I believe we were using recycled rendertarget views. Bug: anglebug:3784 Change-Id: I256165954c9933b211bcc04b94172e13fa5a3a70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1745850 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi d53944cc 2019-08-09T12:09:32 Disable AtomicCounterBuffer tests on Vulkan If a shard executes a Vulkan test first, it sets the window's pixel format to something that the gl backend doesn't agree with. This causes subsequent OpenGL tests to all fail, and eventually leads to a crash. This disables AtomicCounterBuffer tests on Vulkan so that every shard starts with some OpenGL test first (note that AtomicCounterBuffer is alphabetically the first test suite). Bug: angleproject:3738 Change-Id: Ifc32e7884e53ec2a10eb939cf23e5db7fa66f8b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1745359 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
James Darpinian efa898ac 2019-08-07T17:05:35 Enable some compiler warnings used by WebKit. This will make it easier to roll ANGLE in WebKit. Bug: angleproject:3439 Change-Id: Icd4a5a2d5dcabb6cf13d4b46a7547f49610fa4b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1743057 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 08b1e660 2019-08-09T15:31:19 Revert "Enable EVENT trace to print GLenum as string" This reverts commit 048547e743b655d12ad44bb3e63766b7b96cd9a0. Reason for revert: crashes on Debug bots (at least Mac) Original change's description: > Enable EVENT trace to print GLenum as string > > Bug: angleproject:3778 > Change-Id: Ib3a4bd6ba631e0165d571789bbfab9b4b1905d8d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1737141 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Tobin Ehlis <tobine@google.com> TBR=tobine@google.com,jmadill@chromium.org,lujc@google.com Change-Id: Ib72f932f9b99bf981399759b17cec456b3ffafc1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:3778 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1745835 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov ba72f9a9 2019-08-07T15:38:07 Avoid calling debug annotator during D3D shader compilation In Renderer11::compileToExecutable and HLSLCompiler::compileToBinary. Because they are called from a worker thread, there are problems with D3D debug annotator being accessed from multiple threads. Previous fix to guard annotator accesses by a mutex reduced flakiness, but not completely, maybe due to a D3D erroneously thinking there is multithreaded access while there is none. Bug: angleproject:3780 Change-Id: I8beea76b6d21f3378462992bbfab916c9db6b1ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1742642 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya abce77a6 2019-08-07T15:22:03 Add tex2d half float tests to expectations file GL_HALF_FLOAT and GL_HALF_FLOAT_OES have different values and only the latter is valid in GLES 2.0. However, angle_deqp_khr_gles2_tests expects these two enums to be treated as interchangable. This is a bug in deqp, so the affected tests should be expected to fail until the bug is fixed. Bug: angleproject:3451 Test: dEQP.KHR_GLES2/core_internalformat_texture2d_*_half_float_* Change-Id: If3a8078e592b18c60c883dfebd246435761a4423 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1743051 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 90958e35 2019-08-07T16:26:14 Implement ValidateFramebufferTexture3DOES Bug: angleproject:3188 Test: KHR-GLES2.texture_3d.framebuffer_texture.negative Change-Id: I9a27c713bd7ea18b9f7d9943c6c180f92856c643 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1743079 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Robert Iannucci 221a1b5d 2019-08-08T20:46:58 [infra/config] Add cache for XCode on the mac builders Change-Id: Ib4918c58aa63775c63b8d6852cf99264e629c040 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1745721 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Robert Iannucci da8dad17 2019-08-08T19:40:48 Rolling 11 dependencies Roll ./build/ 680f9ea3d..5262b9094 (10 commits) https://chromium.googlesource.com/chromium/src/build.git/+log/680f9ea3db81..5262b9094642 $ git log 680f9ea3d..5262b9094 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 chromium-autoroll Roll Fuchsia SDK from 890571594499 to 890568639186 2019-08-08 chromium-autoroll Roll Fuchsia SDK from 890574089166 to 890571594499 2019-08-08 chromium-autoroll Roll Fuchsia SDK from 890577289982 to 890574089166 2019-08-07 gogerald [StartSurface] Move the tab_ui strings to the feature module 2019-08-07 tiborg [build] Remove dont_load_shared_libraries GN parameter 2019-08-07 chromium-autoroll Roll Fuchsia SDK from 890579756157 to 890577289982 2019-08-07 chromium-autoroll Roll Fuchsia SDK from 890582331998 to 890579756157 2019-08-07 chromium-autoroll Roll Fuchsia SDK from 890585497544 to 890582331998 2019-08-07 yucliu [Fuchsia][EME] Correct CDM service name 2019-08-07 hmohit Add gn arg to overwrite rpath. Roll ./buildtools/ d5c58b84d..74cfb5700 (19 commits; 3 trivial rolls) https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d5c58b84d50d..74cfb57006f8 $ git log d5c58b84d..74cfb5700 --date=short --no-merges --format='%ad %ae %s' 2019-07-25 thomasanderson List natvis files as inputs 2019-07-23 tikuta Roll GN from 972ed755 to 152c5144 2019-07-19 tsniatowski ensure_gn_version.py: don't die if existing gn is very old 2019-07-16 bratell Before trying to overwrite the gn binary, make it writable 2019-07-12 vapier ensure_gn_version.py: reinstall if tool is missing 2019-07-11 vapier ensure_gn_version.py: fix exception printing 2019-06-24 brettw Roll GN from 8c7f4910 to 972ed755 2019-06-21 thomasanderson Reland "Roll GN from 81ee1967 to 8c7f4910" 2019-06-17 sdy Revert "Roll GN from 81ee1967 to 8c7f4910" 2019-06-16 thomasanderson Roll GN from 81ee1967 to 8c7f4910 2019-06-14 mstensho Revert "Roll src/buildtools/third_party/libc++/trunk/ 5938e0582..ad464887b (53 commits)" 2019-06-13 mstensho Revert "Roll src/buildtools/third_party/libc++/trunk/ 5938e0582..78822a685 (48 commits)" 2019-06-07 oysteine Tracing: Moved the tracing sampling profiler to the tracing service 2019-05-23 wychen Exclude AndroidStudioDefault folder in Java import checking 2019-05-19 rsesek Roll GN from 64b846c9 to 81ee1967. 2019-05-13 jbudorick checkdeps: encode input to os.walk as utf-8. Roll ./testing/ 32e614b7e..58990c945 (420 commits) https://chromium.googlesource.com/chromium/src/testing/+log/32e614b7ec7b..58990c945ffa $ git log 32e614b7e..58990c945 --date=short --no-merges --format='%ad %ae %s' 2019-07-01 cduvall@chromium.org Update NavigationLoaderOnUI browser_tests filter again 2019-07-01 dewittj@chromium.org [EoS] Update fieldtrial testing config 2019-07-01 rdevlin.cronin@chromium.org [Extensions] De-flake MultiActionAPITest.DynamicSetIcon 2019-07-01 hypan@google.com Add the "remote" arg for chromeos-kevin-perf-fyi 2019-07-01 yliuyliu@google.com [code coverage] Merge Java coverage files to avoid duplicate names 2019-07-01 bsheedy@chromium.org Change revision passed to V8 GPU pixel tests 2019-07-01 jbudorick@chromium.org Add filter file for services_unittests on android-asan. 2019-07-01 michaelpg@chromium.org Fix WelcomeScreenBrowserTest keyboard selection 2019-07-01 tikuta@chromium.org [testing/buildbot] switch to use xenial for some test 2019-06-29 rmhasan@google.com Make metadata an optional field that does not need to be the same for all shard's JSON results 2019-06-29 cduvall@chromium.org Update NavigationLoaderOnUI browser_tests filter 2019-06-29 jbudorick@chromium.org luci: add android-asan back to consoles. 2019-06-28 jbudorick@chromium.org perf: run internal resource_sizes_* targets on both android builders. 2019-06-28 ynovikov@chromium.org Re-enable tests on Linux Experimental NVIDIA and Intel bots. 2019-06-28 hypan@google.com [perf] Add performance_test_suite for chromeos-kevin-perf-fyi tester 2019-06-28 ynovikov@chromium.org Use targeted OS version for GPU bots. 2019-06-28 tbansal@chromium.org Enable PredictivePrefetchingAllowedOnAllConnectionTypes 2019-06-28 danakj@chromium.org Add android_browsertests to the set of all builds and run it on the bots 2019-06-28 sgilhuly@chromium.org Disable reflection-on-composited test for Vulkan FYI 2019-06-28 estevenson@chromium.org Revert "Reland #2: "Trichrome Proguard: Fix locale pak selection."" 2019-06-28 edwardjung@chromium.org Add security interstititial dark mode experiment to field trial testing config 2019-06-28 cduvall@chromium.org Make DataReductionProxyURLLoaderThrottle work on UI thread 2019-06-28 hypan@google.com Reduce the shard number to 4 for android-pixel2-perf-fyi tester 2019-06-28 cblume@chromium.org Add more flaky tests to SKV content_browsertests 2019-06-28 cduvall@chromium.org Convert URLLoaderRequestInterceptors to work on UI thread 2019-06-27 ahemery@chromium.org Fix for the fyi bot runs of BF Cache tests. 2019-06-27 cduvall@chromium.org Fix CaptivePortalBrowserTest when NavigationLoaderOnUI is enabled 2019-06-27 bsheedy@chromium.org Stream goldctl output on V8 builders 2019-06-27 bpastene@chromium.org Disable failing AutotestPrivateWithPolicyApiTest on linux-chromeos-google-rel. 2019-06-27 cduvall@chromium.org Fix CrossSiteDocumentBlockingTest when NavigationLoaderOnUI is enabled 2019-06-27 jbudorick@chromium.org android: move android-asan to hammerhead+kitkat. 2019-06-27 sinhak@chromium.org Fix Chrome OS Account Manager Settings page UI tests 2019-06-27 bpastene@chromium.org Disable failing MultiActionAPITest.DynamicSetIcon tests on linux-chromeos-google-rel. 2019-06-27 rsesek@chromium.org Delete MojoChannelMac fieldtrial_testing_config.json entry. 2019-06-27 cduvall@chromium.org Update NavigationLoaderOnUI test filter file 2019-06-27 ahemery@chromium.org Add test runs with BackForwardCache on linux-fieldtrial-rel. 2019-06-27 hao.x.li@intel.com Run dawn_end2end_tests with backend validation layers 2019-06-26 meacer@chromium.org Enable Lookalike URLs interstitial by default 2019-06-26 bpastene@chromium.org Duplicate all src-side configs for chromium.chrome bots as chrome. 2019-06-26 yliuyliu@google.com [code coverage] Move Java coverage files from --task-output-dir to --coverage-dir 2019-06-26 jbudorick@chromium.org android: add test filter for breakpad_unittests on ASAN. 2019-06-26 estevenson@chromium.org Reland #2: "Trichrome Proguard: Fix locale pak selection." 2019-06-26 estevenson@chromium.org Android: Remove "jni_package" from JNI templates. 2019-06-26 horo@chromium.org Move http_structured_header and SignedExchangeRequestMatcher to blink/common 2019-06-26 tby@chromium.org [Cros SR] Add Finch flag to the field trial testing config. 2019-06-26 cduvall@chromium.org Run tests for NavigationLoaderOnUI on mojo FYI bots 2019-06-25 btolsch@chromium.org Add empty json config for openscreen bots 2019-06-25 sajjadm@google.com Removing references to deleted fuzzers. 2019-06-25 harringtond@chromium.org fieldtrial testing OfflineContentOnDino -> AutoFetchOnNetErrorPage 2019-06-25 kaznacheev@google.com Fix AppListClientImplBrowserTest.OpenSearchResult on branded builds 2019-06-25 dougarnett@chromium.org [Previews] Increases default slow page trigger max threshold to 3G (...) 2019-05-07 jarrydg@chromium.org Quota: Update fieldtrial testing config with new suffix. 2019-05-07 rbpotter@chromium.org Reland Extensions Web UI: Use HTML Imports Polyfill 2019-05-07 fdegans@chromium.org [fuchsia] Re-enable disabled content unittests 2019-05-07 fhorschig@chromium.org [NTP Suggestions] Clean up unused feature 2019-05-07 jochen@chromium.org Add content_shell_crash_test to Android 2019-05-07 yuzus@chromium.org Enable OomIntervention v2 by default 2019-05-06 ender@google.com Add fieldtrial configuration entry for NewAnswersLayoutAndroidOmniboxM74 2019-05-06 metzman@chromium.org [libFuzzer] Fix condition so that seed corpus is built if specified 2019-05-06 martiniss@chromium.org Set default merge for isolated scripts 2019-05-06 iclelland@chromium.org Revert "Remove chrome_elf_import_unittests and add delayloads_unittests" 2019-05-06 metzman@chromium.org [libFuzzer][LPM] Refer to libprotobuf-mutator as LPM 2019-05-06 cliffsmo@microsoft.com Remove chrome_elf_import_unittests and add delayloads_unittests 2019-05-06 rsesek@chromium.org macOS Signing Scripts: Configure unittests to run on CI. 2019-05-06 magchen@chromium.org Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase 2019-05-06 wanderview@chromium.org Blob: Add testing config for BlobReaderEagerCompletion feature. 2019-05-06 nyquist@chromium.org [feature_engagement] Make it possible to check in configurations 2019-05-06 hofbauer@chromium.org Add FieldTrial testing config for WebRTC-BweAllocProbingOnlyInAlr. 2019-05-04 caseq@chromium.org Revert "Extensions Web UI: Use HTML Imports Polyfill" 2019-05-04 bpastene@chromium.org Replace chrome_kevin_tast_tests with chrome_all_tast_tests. 2019-05-04 tmathmeyer@chromium.org Remove BackgroundSrcVideoTrackDisable Experiment 2019-05-04 rbpotter@chromium.org Extensions Web UI: Use HTML Imports Polyfill 2019-05-03 jbudorick@chromium.org Run resource_sizes on the luci android perf bots. 2019-05-03 findit-for-me@appspot.gserviceaccount.com Revert "Make breakpad_unittests use Chrome's test runner instead of gtest's" 2019-05-03 iclelland@chromium.org Add fuzzer coverage for the feature policy values parser. 2019-05-03 davidben@chromium.org Unwind Socket::kReadIfReadyExperiment. 2019-05-03 fdegans@chromium.org [fuchsia] Re-enable disabled content_unittests 2019-05-03 mark@chromium.org Make breakpad_unittests use Chrome's test runner instead of gtest's 2019-05-02 behdadb@chromium.org Added missing dependency 2019-05-02 jonross@chromium.org Cleanup Viz Test Configs 2019-05-02 smaier@chromium.org Proguard flag files cleanup 2019-05-02 rbpotter@chromium.org Web UI HTML Imports: Add interactive_ui_tests suite 2019-05-02 behdadb@chromium.org Added the representative perf tests to the test suites 2019-05-02 ynovikov@chromium.org Disable webgl_conformance_vulkan_passthrough_tests on Win10 NVIDIA GTX 1660 2019-05-02 rbpotter@chromium.org Print Preview: Use HTML Imports Polyfill 2019-05-02 rsesek@chromium.org Delete testing/scripts/gyp_flag_compare.py 2019-05-01 martiniss@chromium.org Set default merge script for gtests 2019-05-01 huangdarwin@chromium.org Docs: Mention that libprotobuf-mutator is LPM 2019-05-01 jbudorick@chromium.org Tear down src configs for cronet buildbots. 2019-05-01 brlong@microsoft.com Regression fix: don't add virtual files for drags starting in renderer 2019-05-01 rmcilroy@chromium.org Revert "Reland "[Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab."" 2019-05-01 mmoroz@chromium.org [snappy] Get rid of //base dependency in snappy_compress_fuzzer. 2019-04-30 wez@chromium.org [Fuchsia] Build and run the gfx_unittests suite. 2019-04-30 enga@chromium.org Remove dawn_end2end_tests from GPU FYI bots 2019-04-30 sahel@chromium.org Rename NoCreditCardAbort field trial to match the finch experiment name. 2019-04-30 rmcilroy@chromium.org Reland "[Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab." 2019-04-30 behdadb@chromium.org Logic needed for representative performance tests. 2019-04-30 mastiz@chromium.org Remove legacy sync codepath prior to pseudo-USS 2019-04-30 sky@chromium.org Disables SingleProcessMash by default 2019-04-30 perezju@chromium.org [testing] Remove --output-trace-tag arg in Telemetry args 2019-04-30 bpastene@chromium.org chromeos: Run all Tast tests via the host-side tast bin. Roll ./third_party/Python-Markdown/ b08af21eb..36657c103 (1 commit) https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/b08af21eb795..36657c103ce5 $ git log b08af21eb..36657c103 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 efoo OWNERS files updated with latest COMPONENT and TEAMS. Roll ./third_party/fuchsia-sdk/ 8e8db13b5..5fd29151c (3 commits) https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk.git/+log/8e8db13b538e..5fd29151cf35 $ git log 8e8db13b5..5fd29151c --date=short --no-merges --format='%ad %ae %s' 2019-06-18 sergeyu [Fuchsia] Fix gen_build_defs.py to recognize device_profile sdk parts 2019-04-17 wez [Fuchsia] Switch from 'new_parts' to 'parts' when generating GN. 2019-04-11 kmarshall [Fuchsia] Use the "new_parts" section from the SDK manifest. Roll ./third_party/googletest/ d5024103c..c721b68dd (1 commit) https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/d5024103c8a8..c721b68ddecc $ git log d5024103c..c721b68dd --date=short --no-merges --format='%ad %ae %s' 2019-07-31 efoo OWNERS files updated with latest COMPONENT and TEAMS. Roll ./third_party/jsoncpp/ fd0ac8ce6..48246a099 (5 commits) https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/fd0ac8ce63a4..48246a099549 $ git log fd0ac8ce6..48246a099 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 efoo OWNERS files updated with latest COMPONENT and TEAMS. 2019-07-16 mbonadei Do not pass -Wno-implicit-fallthrough to MSVC. 2019-07-15 mbonadei Do not use -Wno-deprecated-declarations on MSVC. 2019-07-12 jophba Update JsonCPP dependency + owners 2019-05-09 metzman [jsoncpp] Add fuzzer. Roll ./third_party/jsoncpp/ f572e8e42e22..645250b66907 (799 commits) https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/f572e8e42e22..645250b66907 $ git log f572e8e42e22..645250b66907 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 jophba@chromium.org \#979 Fix parseFromStream definition 2019-07-11 jophba@chromium.org Add new JSON_USE_NULLREF flag 2019-07-09 jophba@chromium.org \#964 Delete JSONCPP_NORETURN for [[noreturn]] 2019-07-02 chenguopingdota@163.com pop the root node after readValue() 2019-07-02 chenguopingdota@163.com adjust some codes position 2019-07-01 jophba@chromium.org Update version.h.in header comments 2019-06-28 jophba@chromium.org Fix comments on Json Reader 2019-06-28 jophba@chromium.org Update minimum CMake version requirement 2019-06-28 jophba@chromium.org Issue #633: Fix issue with maxInt 2019-06-27 jophba@chromium.org Run clang-format on the repository 2019-06-26 security-tps@google.com Add fuzz.cpp to jsoncpp_test 2019-06-26 security-tps@google.com Update main.cpp 2019-06-26 security-tps@google.com added fuzz.cpp to macro in main.cpp 2019-06-24 security-tps@google.com Update jsontest.cpp 2019-06-24 security-tps@google.com Update jsontest.cpp 2019-06-24 security-tps@google.com Update jsontest.cpp 2019-06-24 security-tps@google.com Update CMakeLists.txt 2019-06-24 security-tps@google.com Update CMakeLists.txt 2019-06-24 security-tps@google.com Update main.cpp 2019-06-24 security-tps@google.com Update main.cpp 2019-06-24 security-tps@google.com Update main.cpp 2019-06-24 security-tps@google.com Added include fuzz.cpp 2019-06-24 security-tps@google.com added llvm 2019-06-24 security-tps@google.com fix llvm 2019-06-24 security-tps@google.com Update fuzz.cpp 2019-06-24 security-tps@google.com Update fuzz.h 2019-06-24 security-tps@google.com Update fuzz.cpp 2019-06-24 security-tps@google.com Update fuzz.h 2019-06-24 security-tps@google.com Update fuzz.cpp 2019-06-24 security-tps@google.com Update fuzz.h 2019-06-24 security-tps@google.com Update fuzz.h 2019-06-24 security-tps@google.com Update fuzz.cpp 2019-06-24 security-tps@google.com Updated fuzz.h 2019-06-24 security-tps@google.com Updated header and fixed the bug 2019-06-12 security-tps@google.com Add a simple fuzz test for jsoncpp. 2019-06-03 olivier.liess@eurodecision.com version.h : wrong file was deployed, added required include path and 2019-06-25 cmlchen@tencent.com extract variable 2019-06-21 cmlchen@tencent.com fix compile problem 2019-06-21 cmlchen@tencent.com use fpclassify to test a float number is zero or nan 2019-05-31 chenguopingdota@163.com repair a typo error 2019-06-24 jophba@chromium.org Issue 920: Fix android build with casting fix 2018-05-28 BillyDonahue@users.noreply.github.com Add WideString test for Issue #756 2019-06-25 jophba@chromium.org Update appveyor to use build images 2019-06-25 jophba@chromium.org Update travis scripts 2019-06-25 jophba@chromium.org Modernize Travis and Appveyor configs 2019-06-24 jophba@chromium.org Update issue templates 2019-06-24 jophba@chromium.org Update issue templates 2019-06-24 jophba@chromium.org Run clang format 2019-06-24 jophba@chromium.org Update CONTRIBUTING.md 2019-06-24 jophba@chromium.org Update README.md 2019-06-24 jophba@chromium.org Create CONTRIBUTING.md (...) 2014-07-01 aaronjjacobs@gmail.com Gave the amalgamated source section a makeover. 2014-07-01 aaronjjacobs@gmail.com Gave the documentation section a makeover. 2014-07-01 aaronjjacobs@gmail.com Gave the testing section a makeover. 2014-07-01 aaronjjacobs@gmail.com Gave the scons section a makeover. 2014-07-01 aaronjjacobs@gmail.com Gave the cmake section a makeover. 2014-07-01 aaronjjacobs@gmail.com Gave the using section a makeover. 2014-07-01 aaronjjacobs@gmail.com Gave the introduction section a makeover. 2014-07-01 aaronjjacobs@gmail.com Began converting the README to Markdown. 2014-07-01 aaronjjacobs@gmail.com Ran clang-format again. 2014-07-01 aaronjjacobs@gmail.com Fixed some clang-format weirdness. 2014-07-01 aaronjjacobs@gmail.com Ran clang-format over all .h and .cpp files. 2014-07-01 aaronjjacobs@gmail.com Set BinPackParameters to false. 2014-07-01 aaronjjacobs@gmail.com Added a clang-format config file, in preparation for formatting jsoncpp. 2014-06-30 aaronjjacobs@gmail.com Fixed some cruft in the Travis CI config file. 2014-06-30 aaronjjacobs@gmail.com Updated notification settings for Travis CI. 2014-05-13 cdunn2001@gmail.com fix stdexcept 2014-04-23 aaronjjacobs@gmail.com Fixed a test that causes a crash when exceptions are disabled. 2014-04-23 aaronjjacobs@gmail.com Added structured error reporting to Reader. 2014-04-23 aaronjjacobs@gmail.com Added features that allow the reader to accept common non-standard JSON. 2014-04-19 cdunn2001@gmail.com vim modeline 2014-04-19 cdunn2001@gmail.com Comment reading/write improvements 2014-04-19 cdunn2001@gmail.com JSON_ASSERT -> JSON_ASSERT_MESSAGE 2014-01-29 aaronjjacobs@gmail.com Added missing includes for std::istream. 2013-09-23 baptiste.lepilleur@gmail.com Fixed broken build on VS 2012 2013-08-08 aaronjjacobs@gmail.com Fixed some snprintf-related build breakages in Visual Studio. 2013-08-08 aaronjjacobs@gmail.com Updated two calls to sprintf that I missed in r269. 2013-08-08 aaronjjacobs@gmail.com Replaced the complex implementation of valueToString(double). 2013-08-08 aaronjjacobs@gmail.com Added more floating point tests. 2013-08-08 aaronjjacobs@gmail.com Added further floating point tests. 2013-08-06 aaronjjacobs@gmail.com Switched away from sprintf, which is prone to buffer overflows. 2013-05-09 baptiste.lepilleur@gmail.com - CMake: added option to turn fail compilation if warning occurs, and warning level 4 with MSVC. - Fixed some warnings 2013-05-09 baptiste.lepilleur@gmail.com - disabled warning 4786 for VS6 caused by STL (identifier was truncated to '255' characters in the debug information) - added batchbuild config for XP VM 2013-05-09 baptiste.lepilleur@gmail.com Added simple batch build script for CMake. 2013-05-09 baptiste.lepilleur@gmail.com Added missing source file to CMakeLists.txt. 2013-05-09 baptiste.lepilleur@gmail.com 2013-05-08 baptiste.lepilleur@gmail.com Fixed continuous integration matrix for debug/release build. Made static debug build verbose. 2013-05-08 baptiste.lepilleur@gmail.com Added continuous integration matrix for debug/release build. Made static debug build verbose. 2013-05-08 baptiste.lepilleur@gmail.com Added continuous integration matrix for shared/static library (specified through environment variables). 2013-05-08 baptiste.lepilleur@gmail.com Added continuous integration failure e-mail notification. 2013-05-08 baptiste.lepilleur@gmail.com Added clang compiler for continuous integration. 2013-05-08 baptiste.lepilleur@gmail.com Added basic Travis CI integration contributed by Igor Okulist. 2013-05-08 baptiste.lepilleur@gmail.com Fixed CMake / Unix build instructions. 2013-05-08 baptiste.lepilleur@gmail.com - New CMake based build system. Based in part on contribution from Igor Okulist and Damien Buhl (Patch #14). Added support for running tests and building with DLL on Windows. - added missing JSON_API - Visual Studio DLL: suppressed warning "C4251: <data member>: <type> needs to have dll-interface to be used by..." via pragma push/pop in json-cpp headers. - New header json/version.h now contains version number macros (JSONCPP_VERSION_MAJOR, JSONCPP_VERSION_MINOR, JSONCPP_VERSION_PATCH and JSONCPP_VERSION_HEXA). While this header is generated by CMake, it is committed to ease build with alternate build system (CMake only update the file when it changes avoid issues with VCS). 2013-04-12 baptiste.lepilleur@gmail.com - Patch #3393345: BOOST_FOREACH compatibility. Made Json::iterator more standard compliant, added missing iterator_category and value_type typedefs (contribued by Robert A. Iannucci). - Patch #3474563: added missing JSON_API on some classes causing link issues when building as a dynamic library on Windows (contributed by Francis Bolduc). 2013-04-12 baptiste.lepilleur@gmail.com Patch #3600941: Missing field copy in Json::Value::iterator causing infinite loop when using experimental internal map (#define JSON_VALUE_USE_INTERNAL_MAP) (contributed by Ming-Lin Kao). 2013-04-12 baptiste.lepilleur@gmail.com Patch #3539678: Copy constructor does not initialize allocated_ for stringValue (contributed by rmongia). 2013-02-18 baptiste.lepilleur@gmail.com Fix gcc -Wall warnings (patch from Matt McCormick) 2012-12-20 baptiste.lepilleur@gmail.com Fixed warning(error?) on #if testing value of _MSC_VER without checking that it was defined. 2012-07-27 baptiste.lepilleur@gmail.com Added missing "include/json/assertions.h" header in amalgamate.py. 2012-03-12 aaronjjacobs@gmail.com Made it possible to drop null placeholders from array output. Roll ./third_party/yasm/ 86b605814..15439370a (1 commit) https://chromium.googlesource.com/chromium/src/third_party/yasm/+log/86b6058141a4..15439370afd9 $ git log 86b605814..15439370a --date=short --no-merges --format='%ad %ae %s' 2019-03-14 thomasanderson More fixes necessary for Windows/libc++ Roll ./third_party/zlib/ f95aeb0fa..0f820c1d7 (24 commits) https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f95aeb0fa7f1..0f820c1d7165 $ git log f95aeb0fa..0f820c1d7 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 adenilson.cavalcanti Allow disabling Castagnoli compression optimization 2019-08-05 adenilson.cavalcanti Increasing the expected compressed output size 2019-08-01 adenilson.cavalcanti Using the same hash function in compression on both x86 and ARM 2019-07-25 thakis Make chromeconf.h use opt-out instead of opt-in. 2019-07-19 darin Avoid 'internal_state' macro pollution from zlib.h. 2019-06-24 tsniatowski zlib: fix gn error when is_clang=false target_cpu="arm" 2019-06-11 scroggo Simplify sharing third_party/zlib with AOSP 2019-06-10 jose.dapena zlib: fix ARMv8 CRC32 compilation in GCC 2019-05-14 huangs [DOM Distiller] Compress resources to save 86 kB on Android. 2019-04-18 richard.townsend Tidy and further integrate Arm feature detection for Windows 2019-04-15 richard.townsend Correct zlib build logic for Windows on Arm 2019-04-15 noel [zlib] Add OS_FUCHSIA feature detection and enable zlib NEON crc32 2019-04-08 thomasanderson Make //third_party/zlib a component 2019-03-29 drubery Pass file_length to UpdateArchiveAnalyzer 2019-03-28 dcheng Update include paths for //base/hash/md5.h 2019-03-28 wnwen Android: Remove build/secondary 2019-02-15 noel [zlib] Add Android ARM aarch64 feature detection 2019-02-14 lizeb blink/bindings: Use PartitionAlloc for zlib's temporary data. 2019-02-13 noel [zlib_bench] improve program options handling 2019-01-31 adenilson.cavalcanti Enable decode input reads in 64 bit chunks 2019-01-11 lizeb blink/bindings: Use PartitionAlloc for compressing strings. 2019-01-08 avi Use base::size rather than arraysize in third_party/zlib/. 2019-01-02 avi Use base::size rather than arraysize in third_party/zlib/. 2018-12-20 msalama Avoid uncompressing if uncompressed size is too big. Roll ./tools/md_browser/ e94626962..0bfd826f8 (2 commits) https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/e9462696241f..0bfd826f8566 $ git log e94626962..0bfd826f8 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 ntfschr Docs: correctly slugify escaped chars 2019-06-01 ntfschr Better regex for md_browser.py Created with: roll-dep ./build ./buildtools ./testing ./third_party/Python-Markdown ./third_party/fuchsia-sdk ./third_party/googletest ./third_party/jsoncpp ./third_party/jsoncpp/source ./third_party/yasm ./third_party/zlib ./tools/md_browser Change-Id: Iac134649e58cf3b1d5ed13dc26e8c2bf3ebdba7b Bug: angleproject:3792 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1744175 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jiacheng Lu 048547e7 2019-08-05T11:55:54 Enable EVENT trace to print GLenum as string Bug: angleproject:3778 Change-Id: Ib3a4bd6ba631e0165d571789bbfab9b4b1905d8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1737141 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com>
angle-autoroll e54c3e3a 2019-08-09T07:01:57 Roll ./third_party/spirv-tools/src b029d3697ea3..22ce39c8e1ec (5 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b029d3697ea3..22ce39c8e1ec Created with: gclient setdep -r ./third_party/spirv-tools/src@22ce39c8e1ec The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=ynovikov@chromium.org Change-Id: I23e306f0a23e08870b16c016f0e2f2118fa3d3b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1746189 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop eb0479e2 2019-07-24T14:15:56 Vulkan: Texture 3D and 2DArray layers as framebuffer attachments Support glFramebufferTextureLayer by correctly handling layers from 3D and 2DArray textures. Modeled after CubeMap layers support. Bug: angleproject:3188 Bug: angleproject:3189 Change-Id: Ic73a6017134e9d2b49beed103487454397a97167 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1738436 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill bd203b57 2019-08-08T17:25:45 Vulkan: Correct generated shader paths. This was showing up as a GN error with a newer version of GN. Bug: angleproject:3792 Change-Id: I1993ccfe079c1768217f704cc9ba036ec67024bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1745226 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi c9ba782a 2019-08-05T16:14:22 Vulkan: Support atomic counter array of arrays Previously, it was assumed that a function argument is either AC or AC[i], and it was converted to AC or AC+i respectively. The code is changed to support any number of dimensions and subscripts, using array size information from AC's type. If AC is an array of array (atomic_uint AC[N][M][R]), the following index calculations are done. AC -> AC.arrayIndex AC[i] -> AC.arrayIndex + i*M*R AC[i][j] -> AC.arrayIndex + i*M*R + j*R AC[i][j][k] -> AC.arrayIndex + i*M*R + j*R + k A test is added to exercise these various forms of indexing: AtomicCounterBufferTest31.AtomicCounterArrayOfArray Bug: angleproject:3566 Change-Id: I1e181a7363463d1d0ee4916f35006ed7c58e0f7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1739488 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Yuly Novikov a1f0d234 2019-08-08T14:32:59 Suppress functional.fbo.*.repeated_clear.* dEQP tests on Win NVIDIA Vulkan Fail on 431.02 driver version. Bug: angleproject:3748 Change-Id: I1115f0432e772ca41aaa28e834cd7aaa4e3ba56f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1744340 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Courtney Goeltzenleuchter b8ec98fe 2019-08-08T10:19:50 Fix build issue with tracing enabled Global destructors are no longer allowed, thus need to use NoDestructor template on static objects to build correctly. Bug: angleproject:3790 Change-Id: I54b81d21b40649cb014636c7ed147f2c8cab33df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1744199 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Ian Elliott 54d51f32 2019-08-07T15:15:10 Vulkan: Fix crash with glBeginTransformFeedback The TransformFeedbackVk::onBeginEnd() method wasn't calling updateQueueSerial(), which was causing CommandGraphResource::hasChildlessWritingNode() to use an old mCurrentWritingNode, which had already been freed (i.e. Visual Studio showed it pointing to memory that is 0xdddddddd--which means that mCurrentWritingNode has been freed, but is still being used). Unfortunately, there are still other crashes affecting these tests, but they are the same set (and yes, there are multiple, and they are random) that cause most of the "KHR-GLES3.copy_tex_image_conversions.required.*" tests to crash). Bug: angleproject:3674 Change-Id: I5cd44018ea0beb25cb218e562d5b863be6cbd450 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1742972 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Clemen Deng e7970c3e 2019-08-07T14:43:17 BasicMangledName class Need a class for basic mangled names since with the addition of GLSL types the number of basic types is > 52 (a-z, A-Z), so we need more than one character to represent a type Bug: angleproject:3719 Change-Id: I98beee9d42a016cb0c017f56ab82538c89212e33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1742221 Commit-Queue: Clemen Deng <clemendeng@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Robert Iannucci bca3e7b2 2019-08-06T17:07:31 Roll ./build/ 54ea0e7fd..680f9ea3d (665 commits) https://chromium.googlesource.com/chromium/src/build.git/+log/54ea0e7fd122..680f9ea3db81 $ git log 54ea0e7fd..680f9ea3d --date=short --no-merges --format='%ad %ae %s' 2019-08-06 iannucci [build/toolchain] Add individual vpython spec to win/tool_wrapper.py 2019-08-06 jdonnelly Revert "Proguard conditional keeps for layouts" 2019-08-06 awolter [Fuchsia] Remove fuchsia.net.SocketProvider from manifests 2019-08-06 chromium-autoroll Roll Fuchsia SDK from 890588017156 to 890585497544 2019-08-06 harshpa Proguard conditional keeps for layouts 2019-08-06 chromium-autoroll Roll Fuchsia SDK from 890591001924 to 890588017156 2019-08-06 chromium-autoroll Roll Fuchsia SDK from 890593631659 to 890591001924 2019-08-05 liaoyuke [code coverage] Skip instrumenting files that has triggers a SI bug 2019-08-05 chromium-autoroll Roll Fuchsia SDK from 890596874171 to 890593631659 2019-08-05 bpastene chromeos: Point TMPDIR to /usr/local/tmp during VM/DUT tests. 2019-08-05 chromium-autoroll Roll Fuchsia SDK from 890600805183 to 890596874171 2019-08-05 chromium-autoroll Roll Fuchsia SDK from 890603479401 to 890600805183 2019-08-04 chromium-autoroll Roll Fuchsia SDK from 890606035392 to 890603479401 2019-08-04 chromium-autoroll Roll Fuchsia SDK from 890608527889 to 890606035392 2019-08-04 chromium-autoroll Roll Fuchsia SDK from 890611617821 to 890608527889 2019-08-03 chromium-autoroll Roll Fuchsia SDK from 890614483854 to 890611617821 2019-08-03 chromium-autoroll Roll Fuchsia SDK from 890617289215 to 890614483854 2019-08-03 chromium-autoroll Roll Fuchsia SDK from 890619875909 to 890617289215 2019-08-03 chromium-autoroll Roll Fuchsia SDK from 890622382381 to 890619875909 2019-08-03 sergeyu [fuchsia] Fix exe_runner.py 2019-08-02 smaier Give longer oatdump timeout in class verification failure script 2019-08-02 tsniatowski Fix android shared_library metadata output_extension handling 2019-08-02 chromium-autoroll Roll Fuchsia SDK from 890625413366 to 890622382381 2019-08-02 vtsyrklevich Create separate gwp_asan_unittests target 2019-08-02 csharp Reland "Reland "Remove references to MessagePump::Type"" 2019-08-02 csharp Revert "Reland "Remove references to MessagePump::Type"" 2019-08-02 carlscab Reland "Remove references to MessagePump::Type" 2019-08-02 cjgrant crashpad_stackwalker: Specify Android platform when generating symbols 2019-08-02 chromium-autoroll Roll Fuchsia SDK from 890628039446 to 890625413366 2019-08-02 chromium-autoroll Roll Fuchsia SDK from 890630742147 to 890628039446 2019-08-01 thakis Replace global NO_TCMALLOC and USE_TCMALLOC defines with BUILDFLAG(USE_TCMALLOC). 2019-08-01 chromium-autoroll Roll Fuchsia SDK from 890633683590 to 890630742147 2019-08-01 tiborg [build] Move logic selecting feature module libraries into Chrome layer 2019-08-01 thakis Disable Wimplicit-int-float-conversion on the clang tot bots in nocompile tests as well. 2019-08-01 thakis Disable Wimplicit-int-float-conversion on the clang tot bots. 2019-08-01 chromium-autoroll Roll Fuchsia SDK from 890643698313 to 890633683590 2019-08-01 eliribble Properly handle transient communication errors with gsutil.py 2019-08-01 ianloic Reland "[Fuchsia] Update to new FIDL string and vector APIs" 2019-07-31 zmin Revert "[Fuchsia] Update to new FIDL string and vector APIs" 2019-07-31 wez [Fuchsia] Fix update-sdk.py not to re-download the same SDK. 2019-07-31 enne Allow Android to be built in an out-of-repo build dir 2019-07-31 efoo OWNERS files updated with latest COMPONENT and TEAMS. 2019-07-31 ianloic [Fuchsia] Update to new FIDL string and vector APIs 2019-07-31 jbudorick android: add a local emulator environment. 2019-07-31 findit-for-me Revert "Remove references to MessagePump::Type" 2019-07-31 chromium-autoroll Roll Fuchsia SDK from 890646710525 to 890643698313 2019-07-31 carlscab Remove references to MessagePump::Type 2019-07-31 chromium-autoroll Roll Fuchsia SDK from 890647868040 to 890646710525 2019-07-30 dpursell [Fuchsia] initialize async_wait_t options field 2019-07-30 chromium-autoroll Roll Fuchsia SDK from 890650128659 to 890647868040 (...) 2019-05-07 raul //build/util/lastchange.py: Decode Git output for Python 3 support 2019-05-07 chromium-autoroll Roll Fuchsia SDK from 891418129671 to 891415132646 2019-05-07 xhwang Set |is_cast_using_cma_backend| to false by default on Android 2019-05-06 chromium-autoroll Roll Fuchsia SDK from 891421020977 to 891418129671 2019-05-06 agrieve Android: Filter out ijar build messages about "Passing class through" 2019-05-06 estevenson Android: Remove unused firebase_app_id from BuildConfig.java. 2019-05-06 oprypin Support Python 3 in jni_generator.py 2019-05-06 thakis win: Re-enable libc++ on Windows. 2019-05-06 estevenson Android: Set Firebase app IDs at runtime. 2019-05-06 chromium-autoroll Roll Fuchsia SDK from 891423780675 to 891421020977 2019-05-06 msalama Orderfile: Caller-callee instrumentation to improve performance. 2019-05-06 chromium-autoroll Roll Fuchsia SDK from 891426706836 to 891423780675 2019-05-06 robliao Revert "Make Visual Studio version selection more smart" 2019-05-06 chromium-autoroll Roll Fuchsia SDK from 891429647473 to 891426706836 2019-05-05 chromium-autoroll Roll Fuchsia SDK from 891432088534 to 891429647473 2019-05-05 chromium-autoroll Roll Fuchsia SDK from 891434892022 to 891432088534 2019-05-05 yang.gu Make Visual Studio version selection more smart 2019-05-05 chromium-autoroll Roll Fuchsia SDK from 891437836392 to 891434892022 2019-05-04 chromium-autoroll Roll Fuchsia SDK from 891440437628 to 891437836392 2019-05-04 chromium-autoroll Roll Fuchsia SDK from 891443015083 to 891440437628 2019-05-04 chromium-autoroll Roll Fuchsia SDK from 891461844150 to 891443015083 2019-05-03 estevenson Android: Fix resource_ids_provider_dep for TrichromeChrome.[apk/aab] 2019-05-03 estevenson Android: Turn proguard flags expectation file back on. 2019-05-03 agrieve Fix emma_coverage=true GN gen failure 2019-05-03 jbudorick Revert "Reland "base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag"" 2019-05-03 xhwang Reland "base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag" 2019-05-03 thakis win: Don't build /FORCE:DuplicateRes targets with /WX. 2019-05-03 thakis Switch use_lld from whitelist to blacklist 2019-05-02 bjoyce Fix Ignore_proguard_configs paramter in android_aar_prebuilt(). 2019-05-02 yliuyliu Include all classes for jacoco agent 2019-05-02 thakis Enable LLD in 32-bit Chrome OS ARM builds. 2019-05-02 thakis Make exclude_unwind_tables only dependent on is_official_build 2019-05-02 thakis linux/32-bit: Use lld as linker. 2019-05-02 chromium-autoroll Roll Fuchsia SDK from 891464457253 to 891461844150 2019-05-01 sergeyu [Fuchsia] Implement SysmemBufferManager and SysmemBufferCollection 2019-05-01 xhwang Revert "base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag" 2019-05-01 chromium-autoroll Roll Fuchsia SDK from 891467542177 to 891464457253 2019-05-01 xhwang base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag 2019-05-01 estevenson Trichrome Proguard: Handle Java locale lists in the library. 2019-05-01 chromium-autoroll Roll Fuchsia SDK from 891470157719 to 891467542177 2019-05-01 chromium-autoroll Roll Fuchsia SDK from 891473642618 to 891470157719 2019-05-01 bjoyce android_aar_prebuilt: Add ignore_proguard_config as flag. 2019-05-01 justincohen Reland "[ios] Disable custom libcxx with xcode clang." 2019-05-01 sunnyps viz: Change OutputSurface and BeginFrameSource creation order 2019-04-30 carlosk Revert "Reland "[ios] Disable custom libcxx with xcode clang."" 2019-04-30 justincohen Reland "[ios] Disable custom libcxx with xcode clang." 2019-04-30 chromium-autoroll Roll Fuchsia SDK from 891475811432 to 891473642618 2019-04-30 mastiz Remove legacy sync codepath prior to pseudo-USS 2019-04-30 bpastene chromeos: Run all Tast tests via the host-side tast bin. 2019-04-30 tiborg [bundles] Add install script and its dependencies to runtime deps Created with: roll-dep ./build Bug: 973721 Change-Id: I0a05e26c7f2836b4a261eaa59db7bc0111755935 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1740510 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tobin Ehlis 4c833efb 2019-07-11T11:29:35 Vulkan: Enable sampler objects This is the initial implementation to get GLES3.0 Sampler Objects working on the Vulkan backend. When samplers are dirty, a corresponding Vulkan sampler object will be created with associated state and textures are flagged as dirty anytime sampler bindings change. Then when handling textures dirty, any bound sampler objects are pulled from active texture units. When sampler objects are bound, their state is used instead of the built-in texture's sampler state. This change also adds a test that uses the same texture object with different sampler objects to test a corner case that dEQP misses. Bug: angleproject:3208 Change-Id: I643d9c9d5cb92fecc02dad815a07bcf349534c70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1706897 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Robert Iannucci 23c0463b 2019-08-08T07:55:06 [infra/config] Actually set properties_j in the right place. Add PRESUBMIT check to ensure these config files stay correct. Bug: 973721 Change-Id: Ife5884d39ca22c55fdc58b65220ed0c34c85fb6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1743048 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tobin Ehlis 31ab533e 2019-07-19T15:31:01 Sampler::syncState now returns angle::Result This is a foundational refactor in preparation for implementing sampler objects in the Vulkan backend. Bug: angleproject:3208 Change-Id: I5970f141d3f825aee1f8b713be8e162c7d0f8bbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1710961 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
Mohan Maiya 8400d05c 2019-08-07T14:52:54 Vulkan: Support the vertex_type_2_10_10_10_rev format - Modify the python script and json file to generate the code which adds the function for vertex_type_2_10_10_10_rev. These functions handle the loading and conversion for vertex_type_2_10_10_10_rev. - Modify ConvertVertex.comp and ConvertVertex.comp.json to perform a GPU based conversion for vertex format of type 2_10_10_10_rev - Modify BindingIsAligned function to check that both stride and binding offset is aligned to the format size when the component size is not aligned to 8 bits. - Modify deqp3 expectations file to enable type_2_10_10_10_rev format vertex array tests. Bug: angleproject:3193 Test: dEQP-GLES3.functional.vertex_arrays.single_attribute.*2_10_10_10* Change-Id: I2358d0d8888f7dfd7eac999dc150f643167de817 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1709035 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
James Darpinian 64751a0b 2019-08-07T15:08:51 Reenable extra_warnings config for angle_utils Originally disabled in https://crrev.com/c/1738438. Bug: angleproject:1459 Change-Id: I95172dc95a5d3e9d838c542ee6bcfb2338ffc9a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1743078 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi e86a8560 2019-08-07T11:55:01 Vulkan: Fewer subgroup ops in seamful cubemap emulation Two values were retrieved from quad neighbors; layer and ma. The value of ma was retrieved as the helper invocations would otherwise have a different value as the major axis. This change makes the helpers rechoose ma based on the layer, which removes a number of subgroup operations. This is also more precise as the major axis value could be slightly different from the neighbor. Bug: angleproject:3732 Change-Id: I3c8ca724e91c52ca2f7edc03bb0e5dca67610ff4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1742215 Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen 7270a6d5 2019-08-06T16:01:42 Fix ShaderStorageBufferTest31.LoadAndStoreBooleanVarAndArray to be more correct The test contained bugs which made it fail on multiple platforms. After mapping SSBO, access the data with GLuint instead of GLboolean. The elements in the SSBO are 4 machine units, even though the SSB talks about bools. A bvec2 declared after bool in the SSB has alignment requirements. The test asserts that a shader written result is zero. In this case it needs to initialize the result buffer to non-zero in order to prove that the shader put the zero there. Bug: angleproject:3749, angleproject:1951 Change-Id: Iad8301be7f9e9df6bbed6b390d9c415d4e437c1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1738909 Commit-Queue: Kimmo Kinnunen FI <kkinnunen@nvidia.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0fec5eab 2019-08-08T07:01:54 Roll ./third_party/spirv-tools/src 698b56a8f024..b029d3697ea3 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/698b56a8f024..b029d3697ea3 Created with: gclient setdep -r ./third_party/spirv-tools/src@b029d3697ea3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=ynovikov@chromium.org Change-Id: I25c62c4e6f905331fb658ab2b1cb2f5556bd3513 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1743588 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 7424fe8b 2019-08-07T18:29:13 Skip BufferDataOverflowTest.VertexBufferIntegerOverflow on Win NVIDIA D3D11. Due to flaky timeout. Bug: angleproject:3786 Change-Id: I9881dcf4bcb2c958c7e5d26cba635d9cf3ff7f1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1743050 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Robert Iannucci 1d25ed29 2019-08-07T14:06:33 [infra/config] Bump OS X SDK on mac builders to version 10.1 Bug: 973721 Change-Id: Iaead721362a0d19912f0d365654c613ff861c842 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1742543 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
James Darpinian 22ec7dc9 2019-08-06T10:10:52 Remove all global constructors and exit time destructors. WebKit compiles with -Wglobal-constructors, so they want this. I decided to do -Wexit-time-destructors at the same time. Bug: angleproject:3439 Bug: angleproject:1459 Change-Id: I4b44ae4f8e6f066e07dc7f9f6ced9a5d49dc8f8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1738438 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 7c7dec01 2019-08-06T17:44:11 Use RenderbufferID in place of GLuint handles. This will allow frame capture/replay to more easily emulate object handle manipulation. It also provides a bit of type safety. Also generalizes ResourceMap to handle non-GLuint IDs. Bug: angleproject:3611 Change-Id: I174fd260f326e0dbe2aca3f818215c91d82cf48c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1706559 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 93560ef5 2019-07-25T16:13:02 Vulkan: Seamful cube map emulation In GLSL, a cube texture is sampled with one of textureCube* functions. This function takes a 3D coordinate which is a vector from the center of the cube and identifies a direction to sample from. GLES2.0 has the following table that translates this 3D coordinate (Rx, Ry, Rz) to a face and ST coordinates within that face. This table can be found in Section 3.7.5 (Cube Map Texture Selection). A compiler pass is implemented in ANGLE that replaces samplerCube declarations with a sampler2DArray. The textureCube* functions are replaced with the corresponding texture* functions with the translated coordinates according to that table. Gradients provided to textureCubeGrad are translated using the same formulae, which is not precise but the spec specifies this projection to be implementation dependent. Helper invocations enabled through WQM (whole quad mode) cause a nuisance in that the extrapolated varyings used as coordinates in a textureCube call could have a different major axis (and therefore face) from the non-helper invocations that lie within the geometry. subgroupQuadSwap* operations are used in conjunction with gl_HelperInvocation to make sure the helper threads calculate texture UVs in the same face as the non-helper invocations. Bug: angleproject:3300 Bug: angleproject:3240 Bug: angleproject:3243 Bug: angleproject:3732 Change-Id: I0cb6a9b1f2e1e6a392b5baca1c7118ed1c502ccf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1715977 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Clemen Deng 44f518b5 2019-08-06T13:31:01 Have run_code_generation only call vpython when needed gen_builtin_symbols.py uses a vpython module to generate a perfect hash function Also seeded the perfect hash function to make it deterministic Bug: angleproject:3747 Change-Id: I660fe71bd6b2213be9d4ccc2f68641637a49a047 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1738747 Commit-Queue: Clemen Deng <clemendeng@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen 483ee3fa 2019-08-07T14:53:37 Remove ShaderStorageBufferTest test skips for bug 2990, bug is marked fixed Unskip ShaderStorageBufferTest tests that reference bug angleproject:2990, the bug is marked fixed and the tests pass. Bug: angleproject:2990 Change-Id: I378f648baa1caf44c5e5280c1580abaefcbe6cba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1742146 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Dustin Green 415bb0cd 2019-08-06T17:26:14 IWYU - zircon/assert.h without stdlib.h Bug: None Change-Id: I524d9c97ebe0f58487bff47631ffc68073f665f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1740871 Reviewed-by: Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org>
Jamie Madill 798f6c61 2019-08-05T15:10:28 Strip extension from packed GLenum data. This reduces the code duplication in this json file. It should make the packed enum map easier to maintain going forward as we add more entry point permutations. Bug: angleproject:3611 Change-Id: Ideab630584f0a41892262660fc1e0aedcc5dd639 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1736126 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ian Elliott b13c38c1 2019-08-06T09:50:49 Vulkan: Enable GL_UNPACK_SKIP_IMAGES in the Tex*Image* code A boolean was hard-coded to false to disable the use of GL_UNPACK_SKIP_IMAGES disabled in ImageHelper::stageSubresourceUpdate() (I assume because 3D textures wasn't yet supported). The boolean is now set based on type type of the texture. Bug: angleproject:3781 Change-Id: I09d9fd142cceb3bebfa341fd0ff9179241c61a9c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1738433 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 0296e169 2019-08-02T14:38:45 Vulkan: Refactor atomic counter retype code A generic "retyper" class is extracted out of the atomic counter retype code to be used with coverting samplerCube to sampler2DArray for seamful cubemap sampling emulation. Bug: angleproject:3732 Change-Id: I8b5f835125b9513afcfe7baeea48afaf1299a027 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1733807 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jiacheng Lu ed5f7e4d 2019-06-07T15:54:00 Vulkan: Use a persistent CommandPool Previously transient CommandPool is used for CommandBuffer allocation, it is created and destroyed per frame. However, profiling found that CommandPool destroy is very inefficient. So this commit removed the previous logic and use two preallocated resetable CommandPools (One for Primary and One for Secondary) Bug: angleproject:3508 Change-Id: I8b36f2738b082811c3177935c61b10e01acb6947 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1648667 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 44e690ca 2019-07-22T16:42:55 Vulkan: Support unaligned atomic counter buffer binding GLES doesn't require any implementation-specified alignment requirement for atomic counter buffers. They are emulated with Vulkan storage buffers, which do have restrictions. The storage buffers are bound at aligned offsets, and the remaining offsets are passed to the shader as uniform values. This means that the driver uniforms are now also bound to the compute pipeline. Bug: angleproject:3566 Change-Id: I1a3429438f76d95e33cb5c6ef2c9370a10d900d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1713095 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 6201d134 2019-08-06T09:01:45 Vulkan: Suppress KHR-GLES2 ASTC 3D Texture Tests The following tests are failing on 64b Pixel 2 devices: KHR-GLES2.texture_3d.compressed_texture.rgba_astc_8x6_khr KHR-GLES2.texture_3d.compressed_texture.srgb8_alpha8_astc_8x6_khr These will be marked "SKIP" while the failures are investigated. Bug: angleproject:3779 Test: angle_deqp_khr_gles2_tests Change-Id: Idd5ebd992cd2d0b459a9eec0f2960265248700b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1739486 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott 99f494e4 2019-08-05T13:53:41 Vulkan: Enable GL_NV_pixel_buffer_object extension Now that PBOs are implemented, expose the NVIDIA PBO extension. Bug: angleproject:3233 Change-Id: Ie69e49fb0cefad7b55abcc57b2cb3284c196b158 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1737277 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
angle-autoroll 74ec0afe 2019-08-06T07:01:53 Roll ./third_party/spirv-tools/src 4f14b4c8cc25..698b56a8f024 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4f14b4c8cc25..698b56a8f024 Created with: gclient setdep -r ./third_party/spirv-tools/src@698b56a8f024 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=ynovikov@chromium.org Change-Id: I2f060affd28ad48d0bd6ceb283cbe71f669d5d35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1738326 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten bf176a0d 2019-08-05T12:33:58 Vulkan: Suppress KHR-GLES2 ASTC 3D Texture Tests The following tests are failing on 64b Pixel 2 devices: KHR-GLES2.texture_3d.compressed_texture.rgba_astc_8x6_khr KHR-GLES2.texture_3d.compressed_texture.srgb8_alpha8_astc_8x6_khr These will be marked "FAIL" while the failures are investigated. Bug: angleproject:3779 Test: angle_deqp_khr_gles2_tests Change-Id: I6248833e3c136123a41fafa24f4f528060fc016d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1737099 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Jiacheng Lu 7c8928d0 2019-07-24T10:39:40 Add more tests covering gl::vertexAttribPointer 1. Add tests ensuring VBO binding with format requiring conversion in vulkan backend is converted correctly after binding and offset changes. 2. Add tests ensuring VBO binding switching between CPU and GPU handles correctly in vulkan. As for vulkan, it transfers CPU side memory into tightly packed buffer and may causing a stride change. Bug: angleproject:3256 Change-Id: I5d9d78670b28bec286b96d3b6a9c6211da3f3d9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1716614 Commit-Queue: Jiacheng Lu <lujc@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jiacheng Lu f3dbf0a7 2019-07-29T11:31:20 FrameCapture dump GLenum to enum instead of value Add functionality to capture GLenum and GLbitfield parameters as enum names instead of values. Bug: angleproject:3611 Change-Id: I7ddc21093d44d1480b205563f30d89f82779b1f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1724460 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill b8c0dc04 2019-07-30T17:22:23 Capture/Replay: Capture entry point enum when possible. This should save on a few string comparisons. This CL also adds a helper function that converts from an entry point enum ID to a string entry point name. Bug: angleproject:3611 Change-Id: I47434235ca25203ef1d6814897d81afab444a7fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1719065 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi c13ca2af 2019-07-17T15:46:29 Vulkan: Allow more than one atomic counter buffer binding dEQP assumes there are more than one atomic counter buffers available. This is technically not a requirement by the standard, but nevertheless could be what applications expect as well. This change adds support for multiple atomic counter buffer bindings. This is done by declaring an array of storage buffers for the atomic counter buffers (instead of declaring only one) and passing the (binding, offset) pair around to functions instead of just the offset. The atomic counter is found by indexing `binding` into the storage buffer array first before indexing `offset` into its `uint[]`. ProgramVk's default uniform collection is also fixed not to include atomic counter uniforms. A remaining issue is that atomic counter buffer offsets don't have alignment requirements in GLES, but Vulkan does for storage buffers. Similar to emulated transform feedback buffer offsets, these should be sent to the shader through uniform values. This will be done in a follow up change. Bug: angleproject:3566 Change-Id: I5600225c24c38f1a8ecf5c64388073055733197d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1707931 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Ian Elliott 2a53d83a 2019-08-05T10:42:14 Vulkan: Enable more tests to run (and in most cases pass). Some of this set of expectation-file changes are due to PBO implementation. Bug: angleproject:3628 Bug: angleproject:3455 Bug: angleproject:3209 Bug: angleproject:3210 Change-Id: Ie74913f22600b967c2a239f8a6452f9a99b2a00a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1736134 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Jamie Madill af69179c 2019-07-30T17:22:22 Capture/Replay: Capture return values. This will allow us to record resource IDs as they are created and bound to OpenGL. This in turn will enable implementing mid-execution capture. Bug: angleproject:3611 Change-Id: I9f12eb0025d90ad86327cf5181efd831662c2e3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1706562 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Clemen Deng 9031bdd9 2019-07-26T14:51:23 Use perfect-hash module in gen_builtin_symbols.py The script currently takes ~4 minutes to run Using this module instead of manually hashing will improve runtime significantly Bug: angleproject:3747 Change-Id: I7e2d2ef5bbfd136b0299d571e0acc11f334c80b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1724667 Commit-Queue: Clemen Deng <clemendeng@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll b8a27c5e 2019-08-05T07:01:09 Roll ./third_party/glslang/src a0eb5efd2bad..3cea2e5882e3 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a0eb5efd2bad..3cea2e5882e3 Created with: gclient setdep -r ./third_party/glslang/src@3cea2e5882e3 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=geofflang@google.com Change-Id: I11d337682184083a98cdea36ed94441897250c74 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1736398 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 73ec5b06 2019-08-05T07:01:53 Roll ./third_party/spirv-tools/src 0b70972a29c7..4f14b4c8cc25 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0b70972a29c7..4f14b4c8cc25 Created with: gclient setdep -r ./third_party/spirv-tools/src@4f14b4c8cc25 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=geofflang@google.com Change-Id: If2f37d2752f5e32b85081df915fdfa541872df4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1736399 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>