kc3-lang/angle

Log

Author Commit Date CI Message
Bo Liu bcc03bd6 2022-05-01T14:47:11 Remove limit_max_texture_size_to_4096 workaround Chromium will apply workaround to gpu command buffer clients only. So removing it from angle which is no longer needed. See crbug.com/1319451 and in particular crrev.com/c/3626252 Bug: chromium:1319451 Change-Id: I723e525600aa7b93e784c98348e060a503c09657 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3618501 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 2fae9482 2022-05-02T11:05:36 Vulkan: Use heuristic to decide how many empty buffers to keep Instead of rely on static information (16 max empty buffers and not been used for a given period of time), this CL keeps track of how many new buffers are needed (either reused from empty buffer list or allocated new) since last prune. We use this heuristic information to decide how many empty buffers to keep around and trim the excessive empty buffers. Combined with the next few CLs, on pixel6 I am seeing 11.7M reduction with vsync_angry_birds_2_1500. The memory_max minus memory_median reduced from 49M to 38M. Bug: b/230538246 Change-Id: I51da745afe4bfdbff0ba165418531803bdce681b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3622264 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki 0afa5b9f 2022-05-03T12:27:56 Tests: Add Alto's Odyssey trace. Test: angle_perftests --gtest_filter="*altos_odyssey*" Bug: angleproject:7275 Change-Id: Ibd5c5517ccde8e18e2b5cc39535605be428512fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3629543 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Peter Kasting 2ce60b52 2022-05-05T08:23:07 Fixes for C++20 support. * The compiler grew smart enough to warn about value changes due to casting to float inside floatToNormalized(). Make it smart enough to realize this isn't a problem by using constexpr if. * Types on both sides of a comparison operator should be the same. * Structs with user-declared constructors are no longer aggregates. Provide a constructor and call it. * std::result_of<F(x)> is gone, use std::invoke_result<F, x> instead. Bug: chromium:1284275 Change-Id: I6487bb18c65837a6d7d2661f65e097dc6a7605b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3630478 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org>
Amirali Abdolrashidi 3f216ee7 2022-05-04T19:37:13 Vulkan: Set timeout for MultiContextDrawWithSwap* Bug: angleproject:7270 Change-Id: Ie36a6a8eb796cd49c32a21a9bace8f9b0efa5a90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3627484 Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll bd44b29d 2022-05-05T09:54:27 Roll Chromium from 6db3a94387ed to 1c301e690de1 (550 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6db3a94387ed..1c301e690de1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/113378f9b3..7208eddba1 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/393e3eee99..f1108b6ba3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/78e25c11f6..fe2c48dd06 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e1bf83383b..8bb2630eef * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7caeea5854 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/13acea3645..b9dca865af * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/75625c6906..3e15bc0c33 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7593122778..f5c731071f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/78265207a0..a05da12d55 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I5fdcdaccef295079f45478d541b15076863d3a87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3629119 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov d7346867 2022-05-04T16:58:17 Decommission win7-x86-amd and win7-x64-nvidia Bug: chromium:1322538 Change-Id: I36a46eb8351a151b46e860c7c1c3311f0843e067 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3628110 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Doug Horn 9865ed8b 2022-05-03T16:06:56 Check in //build files needed. Previously, only //third_party was actually `git add`ed. This change checks in the build files needed to access test scripting. Test: ./scripts/roll_aosp.sh m -j32 ANGLE Bug: b/231365398 Change-Id: Ib4bf75bc96e089bf7fe5d7b4d2304829c293c8ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3625833 Commit-Queue: Doug Horn <doughorn@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Antonio Caggiano 9053a641 2022-01-17T11:32:41 Vulkan: Wayland dmabuf extensions Implement EGL extensions image dmabuf import and import modifiers in Vulkan Wayland Display. Bug: angleproject:7065 Change-Id: I91535db3581cbe51f0eddc429e2752641c568148 Signed-off-by: Antonio Caggiano <antonio.caggiano@collabora.com> Signed-off-by: Constantine Shablya <constantine.shablya@collabora.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3525093 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 77cd0b5a 2022-04-14T13:32:07 Re-land: "Vulkan: Cache ImageView serials on texture changes." Re-land fixes BindTexImage serial caching. This significantly reduces overhead when changing textures before draw calls in the Vulkan back-end. Bug: angleproject:6776 Change-Id: I2cc03cb8a70e8c181f7658ab45df780e412bfc57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3623860 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Maiorano b72cff8c 2022-05-04T09:54:30 Fix build flags not in declare_args when angle_has_build is true Required so that these can be overridden in .gn files. Will allow us to fix roll of ANGLE into Dawn. Bug: angleproject:6902 Change-Id: I8636778969ae489fdc7420414957d43fcfb634a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3627120 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Shahbaz Youssefi 14c483f1 2022-05-03T21:33:32 Presubmit: Verify comment before new tests A new presubmit check is added that looks for lines adding tests, i.e. matching `+TEST_P(`, and makes sure they are preceded by a pattern such as: ``` // ... - ... (optional removals) +TEST_P(...) ``` or ``` +// ... - ... (optional removals) +TEST_P(...) ``` If no comment is found before the test, an error is generated. Bug: angleproject:2626 Change-Id: Ibf76ae76ad3b1bb0efcf7eab8273153dd5c5162e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3626929 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll dc1ab34c 2022-05-04T10:01:19 Roll SwiftShader from cdf43bd816d7 to 643179694ec7 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/cdf43bd816d7..643179694ec7 2022-05-04 capn@google.com Always enable MemorySanitizer instrumentation for compute routines 2022-05-04 capn@google.com Always enable MemorySanitizer instrumentation for sampling routines 2022-05-03 capn@google.com Handle instrumentation of scalar single-precision (_ss) intrinsics 2022-05-03 nicolascapens@google.com Revert "Always enable MemorySanitizer instrumentation for vertex routines" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Iac0ec36bf22440318a3777613c2ac8fc727d89ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3627218 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 34fb4f79 2022-05-04T07:01:36 Roll Chromium from 55c89a3a09ac to 6db3a94387ed (508 revisions) https://chromium.googlesource.com/chromium/src.git/+log/55c89a3a09ac..6db3a94387ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a6ea5816b1..c812b8d227 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c7888dd707..ce96725bdd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ee8a311434..78e25c11f6 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ae9f091e95..460d235b06 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/933a62529e..e1bf83383b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..05b7cd33df * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e06e307750..13acea3645 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/b55552138c..9979c19f11 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/85c62c07aa..7593122778 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ea7a03c31e..78265207a0 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Icfeabafe0dc677d678048d1140e36c723b64ccb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3625681 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi edd331eb 2022-04-28T09:47:51 Traces: Add a device arg to restricted_trace_perf In case of multiple available devices, we can use either this argument or setting $ANDROID_SERIAL to select the device to run tests on. * Added the option to run restricted_trace_perf with more than one connected device. * The device serial can be entered either by using the --device arg or setting $ANDROID_SERIAL. If both are used at the same time, the former has more priority. * Neither is required if there is only one connected device. Bug: angleproject:6970 Change-Id: Id80398b82ea5b905f3dbfa4651d5f5246a3ccbe8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615082 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya a7238b52 2022-04-28T12:04:51 Consolidate handle list before pushing to mReleasedList Walk mUnallocatedList and try consolidating the range before pushing the to-be-released handle onto mReleasedList. This avoids a buggy behavior with dEQP which can be reproduced by running the following tests in this order - dEQP.GLES3/functional_samplers_single_cubemap_diff_wrap_t dEQP.GLES3/functional_negative_api_buffer_framebuffer_texture_layer Test: HandleAllocatorTest.ConsolidateRangeDuringRelease Bug: angleproject:7248 Change-Id: I8d2701f193fc6a2f36151c09719284a7832ab2d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3617198 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Jamie Madill 064fc64a 2022-05-03T13:49:50 infra: Remove some slow *SAN tests. This removes GLES-CTS 3.1 tests from TSAN/ASAN/UBSAN, and also removes some of the rotation-specific tests. We're running out of capacity on these configs. We can always add them back to ASAN and UBSAN as we see fit. Bug: angleproject:7264 Change-Id: Ic60df1ba36811b69c20f23e180485d932ae93ea2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3623864 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Stephen White 9ab47074 2022-05-02T11:51:31 D3D11: fix BufferToTexture copy when UNPACK_ROW_LENGTH is set. The BufferToTexture fast path rasterizes a point per pixel when copying buffer to texture, and uses the vertexID to determine the buffer location. However, the math is wrong if UNPACK_ROW_LENGTH is set. The fix is to use UNPACK_ROW_LENGTH (if specified) rather than the width in the Draw() call. Bug: angleproject:5542 Change-Id: If0bbc0d7ae3ecbb2211cfb27263324d23c5ff0af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621319 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Antonio Caggiano 9ad43bdd 2021-12-09T16:52:35 Re-land: "Vulkan: Support Wayland" Implement DisplayVkWayland and WindowSurfaceVkWayland. Get window size from native window and check egl config is just empty. An EGL wayland test is added for testing rendering and buffers swapping. Re-land fixes: - link failure in systems with no libwayland installed. - XCB display availability check. Bug: angleproject:6902 Change-Id: I5daecf3591493308ac71a7dd3bc0802f492e6fed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621059 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuxin Hu 5c9f676d 2022-04-28T18:43:38 Basis Universal Texture Experiment Adding a test to read KTX image data. Adding the inlined image data adapted from KTX file with ETC1_RGB compressed format. Bug: angleproject:7250 Change-Id: I96d704f27875fc01bcd31ac8657627f4e3a71755 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3616109 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Chris Forbes <chrisforbes@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 84e42c3b 2022-05-02T15:42:23 Fix validation cache when deleting a Transform Feedback. Bug: chromium:1320024 Change-Id: I76ef85a3c65c663c138d8caebd4ef2c0da53cd4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621780 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov b5f0fd1b 2022-05-03T09:03:59 Skip flaky tests on Win ASAN MemoryBarrierBufferTest.VertexAtrribArrayBitWriteThenVertexRead flaky timeout TimerQueriesTest.TimeElapsed flaky failure Bug: angleproject:7261, angleproject:7262 Change-Id: Ibd6e80bf71a7fe1702248f995d9d07851018a916 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621058 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll c0942c2d 2022-05-03T10:01:39 Roll vulkan-deps from 1cde45b8d7aa to 4ca7acf89869 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1cde45b8d7aa..4ca7acf89869 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/a9d23d7652..0c8a79b0b5 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/155ca6b868..191e261495 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2d83cbf35b..75a5d5459f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Id9df168fab4c492010dd5ac41d8b1c406b94911c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3622650 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c92d69d7 2022-05-03T10:01:18 Roll SwiftShader from adef92e7b4c6 to cdf43bd816d7 (8 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/adef92e7b4c6..cdf43bd816d7 2022-05-02 swiftshader.regress@gmail.com Regres: Update test lists @ 6fb4e049 2022-05-02 capn@google.com Remove legacy build defines 2022-05-02 capn@google.com Document the vk::DescriptorSet memory layout 2022-05-02 capn@google.com Always enable MemorySanitizer instrumentation for vertex routines 2022-05-02 nicolascapens@google.com Revert "Always enable MemorySanitizer instrumentation for sampling routines" 2022-04-29 capn@google.com Always enable MemorySanitizer instrumentation for sampling routines 2022-04-29 ari.suonpaa@siru.fi Fix heap corruption for empty descriptor pools 2022-04-29 capn@google.com Always enable MemorySanitizer instrumentation for blitter routines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I7af60f5411725bc07c046752c91f95fd07212c0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3623022 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 4bbc55f4 2022-05-03T08:19:55 Revert "Re-land: "Vulkan: Support Wayland"" This reverts commit e0dd196a0e0aace17dfaa204163d798f504ea94e. Reason for revert: blocks ANGLE roll into Chromium Original change's description: > Re-land: "Vulkan: Support Wayland" > > Implement DisplayVkWayland and WindowSurfaceVkWayland. Get window size > from native window and check egl config is just empty. An EGL wayland > test is added for testing rendering and buffers swapping. > > Re-land fixes link failure in systems with no libwayland installed. > > Bug: angleproject:6902 > Change-Id: I4f091d4f479a537d0390caedce88a5d39f8b356f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3608088 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:6902, angleproject:7260 Change-Id: I7e92bf811b191eee6679d577006cddc0e1286fad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621057 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 58526dea 2022-05-03T07:01:03 Roll Chromium from 929311ac6298 to 55c89a3a09ac (470 revisions) https://chromium.googlesource.com/chromium/src.git/+log/929311ac6298..55c89a3a09ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/35387279e4..a6ea5816b1 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/d8a47466e3..393e3eee99 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6039be79b9..ee8a311434 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/61ba3de9aa..933a62529e * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/36c15805b9..5ecb4635f0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..eebb0a0e63 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fccf35cb8e..e06e307750 * third_party/turbine: y4x80kUnDOxC5QyG48MlVoiRIEn09eaHcIJQFavlqgMC..zB1ls771w8S0URcjvMWxOHJ33pmUKq5Zr8zkbIMfvcsC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e53d3f018a..b55552138c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/12653c4be0..85c62c07aa * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/ca7c1ec42a..c8563c1c1d No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ibd9c8bb0ee709e4007a65db735542d0eadabd50d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621391 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 5113ae8e 2022-04-29T22:42:59 Vulkan: Explicitly enable per-sample shading if `sample` used The Vulkan spec is not explicit about the `Sample` decoration implicitly enabling per-sample shading. While this is being corrected in the spec, the ARM Vulkan driver does not have this implicit behavior. A workaround is added such that the usage of the `sample` qualifier is reported, and used to explicitly enable per-sample shading through the API. Bug: angleproject:6876 Change-Id: Idb8345aacdcfa45cb37fefcd30aa5405168d21e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615738 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Brian Osman 9200ba53 2022-04-26T12:05:07 Reland "Make SPIRV optional for Metal backend" Updated default conditions to match old behavior. This is a reland of commit 29287e1fc7ad3dff0619736a89e64b3598af8659 Original change's description: > Make SPIRV optional for Metal backend > > This allows clients (ie Skia) to build ANGLE without needing > all of the additional Vulkan dependencies. Developer builds > will continue to include both the direct and SPIRV paths, for > debugging purposes. > > Bug: angleproject:7155 > Change-Id: I1c38ee19e747df8b25fd2f8e8efa3b420a4d7766 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3605764 > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Auto-Submit: Brian Osman <brianosman@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7155 Change-Id: I439160f2e1f05a3dbe22df82336246a73a0a7d0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615012 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Charlie Lao 802504ad 2022-04-29T20:22:53 Vulkan: Add log for buffer pool stats For debugging purpose, this will calculate stats of buffer pool and output string to log. Set ANGLE_ENABLE_BUFFER_POOL_STATS_LOGGING to 1 will log stats into INFO() stream. Bug: b/230538246 Change-Id: I68f83af547e782ca7cb6cb222967ba02b8005083 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3617229 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Charlie Lao 4d26c66d 2022-04-29T17:39:22 Vulkan: Call cleanupGarbage only if mLastCompletedQueueSerial changed RendererVk::cleanupGarbage() walks through all garbage objects and check its serial with mLastCompletedQueueSerial. If it is completed then garbage gets destroyed. Right now it gets called from CommandQueue::queueSubmit(). But queueSubmit only submit new work, it does not mean anything have completed. Garbage clean up does not depend on submission, but depends on anything have finished. This CL moves the cleanupGarbage call to CommandQueue::retireFinishedCommands() where we update mLastCompletedQueueSerial. Bug: b/230921364 Change-Id: Ib07c4cc75a1d2bd243377fa1215588d8ea4e3f36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3617227 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Brandon Schade 527557b9 2022-04-28T14:35:30 Fix ValidateFramebufferTextureLayer for cubemap arrays GL_INVALID_VALUE is generated if texture is a cube map array texture and layer is larger than MAX_ARRAY_TEXTURE_LAYERS-1. GL_INVALID_VALUE is generated if texture is a cube map array texture and level is larger than the log base 2 of MAX_CUBE_MAP_TEXTURE_SIZE. Fix validation to account for the spec. Bug: angleproject:3584 Tests: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.framebuffer_texture_layer Change-Id: I51028145fa83ef5eb46c39030a28984411ca801e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615613 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Doug Horn e6662832 2022-04-28T17:30:41 Re-land fixing of commit ID for Android builds. Android infra does not store the .git directory alongside the checked out code, instead using a gitdir directive to point elsewhere. This caused the commit_id script to fail, which could cause issues with disk-backed program caches on updates when the serialization format changes. Tested: 1) Verified that cached binaries do not load when the ANGLE hash is "unknown hash". This fixes a bug where the serialization format could change but we are unaware of a change because the hash is technically the same. 2) Verified that Android infra correctly generates the git hash. Bug: b/206109660 Test: Run script on Android infra, verify hash is gathered properly. Change-Id: I114fc8edb9459592cab45c6726f9d946cf6d17d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615014 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Doug Horn <doughorn@google.com>
Amirali Abdolrashidi 3e05b93a 2022-04-12T19:39:19 Vulkan: MSAA swapchain resolve based on renderArea * Updated the MSAA resolve subpass so it can only be performed if the render pass is covering the entire area (e.g., not scissored). * Added test to make sure that the subpass resolve does not occur when the render pass does not cover the entire area. Bug: angleproject:6762 Bug: angleproject:7196 Change-Id: Iac3ab4b655dfeb7bff1348cc5e289a77a4dc0b83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3584942 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov c6e6e284 2022-05-02T11:16:19 Update Android deqp and end2end sharding end2end now the bottleneck, taking a tad too long so bump up Some of the deqp suites running way too fast so bump down end2end on trybot after this change (before: ~9m/shard): Max shard runtime (4m 38s) + overhead (10s): 4m 49s (shard #0) Min shard runtime (4m 18s) + overhead (10s): 4m 29s (shard #2) Bug: angleproject:7242 Change-Id: Ie75afba6c920da3602fb82c69ed90efef4197ead Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621393 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov 237479a2 2022-05-02T14:22:11 Fix presubmit following https://crrev.com/c/3611486 Switch to python3 for to get expected dict.keys() ordering python behavior/spec changed around ~3.6-3.7 https://stackoverflow.com/a/40007169 Reorder mixins that got out of order. Bug: angleproject:7242 Change-Id: I5fbc973ccc52b11f7db55c50e2ae7af54361dd40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3622053 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Stephen White bc929e6e 2022-05-02T11:00:20 D3D11: recompile all shaders using 10.0.20348.0 toolchain. Bug: angleproject:5542 Change-Id: I604de49c62c0a1c3882946a7bdf9e7d1171e94ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621833 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop b953bc13 2022-04-01T09:14:28 Tests: Add GFXBench Tessellation trace Test: angle_perftests --gtest_filter="*tessellation*" Bug: angleproject:7154 Change-Id: I8b5284dc32aff2631b8d3c6b726c174738cf1a5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3564075 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev f7615d0a 2022-05-02T18:59:22 OpenGL: Add allow_astc_formats workaround Enable ASTC on Mesa only for supported hardware Bug: angleproject:7259 Change-Id: I872ebdead1206ee911c5e0f0f10b6985022dbe47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621055 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi 4dc4c0f0 2022-05-02T11:03:57 Remove whitespace from features json files Bug: angleproject:6435 Change-Id: I7f653a9836180d0f2e0198302e11ae2b0ca49d3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621315 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Brian Osman df163d71 2022-05-02T11:02:52 Test both MSL translators in APPLEClipDistanceTest This test failed with the SPIRV translator disabled (the ifdef being checked didn't match up with the requested compiler output). Bug: angleproject:7155 Change-Id: Ic89bf4035b0ada43ec249dbbca4626ae2eab2006 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621314 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 06fa7e39 2022-05-02T14:07:53 Expand Intel GPU detection - Updated references - Switched array types to 16-bit - Added missing entries to Kaby Lake - Added Gemini Lake and Coffee Lake - Added Gen11 and Gen12 Bug: angleproject:7259 Change-Id: I0e074333f98fad801f4fad289d7b5ae2876160e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621053 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano e0dd196a 2021-12-09T16:52:35 Re-land: "Vulkan: Support Wayland" Implement DisplayVkWayland and WindowSurfaceVkWayland. Get window size from native window and check egl config is just empty. An EGL wayland test is added for testing rendering and buffers swapping. Re-land fixes link failure in systems with no libwayland installed. Bug: angleproject:6902 Change-Id: I4f091d4f479a537d0390caedce88a5d39f8b356f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3608088 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny ea9a2dbe 2022-05-01T17:30:55 Capture/Replay: handle glGetVertexAttrib parameter value Bug: angleproject:7153 Change-Id: I56cbe833268a6d1f6d184c90b7fbe1a345e5f012 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3614518 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Roman Lavrov 41adabc4 2022-04-29T15:04:27 Use app data dir instead of /sdcard for writing qpa file Appears to drastically reduce runtime variability. Example: Max shard runtime (28m 15s) + overhead (10s): 28m 24s (shard #8) Min shard runtime (3m 5s) + overhead (20s): 3m 24s (shard #6) --> Max shard runtime (4m 6s) + overhead (11s): 4m 17s (shard #0) Min shard runtime (3m 7s) + overhead (10s): 3m 17s (shard #6) --deqp-log-flush is enabled by default (only disabled for multi-process execution http://anglebug.com/5157) and together with --deqp-log-shader-sources which is also enabled by default results in a huge number of line-by-line flushes degradng filesystem performance. Example strace capture in a degraded state: [pid 21208] 10:55:51.194033 write(77, "</ShaderSource>\n <InfoLog>", 28) = 28 <0.181028> [pid 21208] 10:55:51.375879 write(77, "</InfoLog>\n</FragmentShader>\n</S"..., 78) = 78 <0.179196> [pid 21208] 10:55:51.555790 write(77, "\" Description=\"Vertex shader com"..., 41) = 41 <0.177602> ~180ms *per line written* !!! (28, 78, 41 characters...) Under normal conditions these are way down in the microsecond range: [pid 11412] 10:55:56.689894 write(72, "</ShaderSource>\n <InfoLog>", 28) = 28 <0.000020> [pid 11412] 10:55:56.689957 write(72, "</InfoLog>\n</FragmentShader>\n</S"..., 78) = 78 <0.000026> I think that the reason for this is some peculiarity of the /sdcard filesystem which uses fuse: % df -h /sdcard/chromium_tests_root/ /dev/fuse 50G 3.7G 46G 8% /mnt/user/0/emulated As opposed to block/dm-N of the (non-app accessible) temp directory: % df -h /data/local/tmp/ /dev/block/dm-9 50G 3.7G 46G 8% /data_mirror/cur_profiles And the app data directory appears to be using the same filesystem: % df -h /data/data/com.android.angle.test/ /dev/block/dm-9 50G 3.7G 46G 8% /data_mirror/cur_profiles As far as I can tell the degradation of performance does not happen on this filesystem despite the huge amount of small writes. Disabling deqp log flushes when running on bots probably makes sense too but I'd like to first confirm the impact of this CL separately. Bug: chromium:1217662 Bug: angleproject:7242 Change-Id: I507e4c330fd4e1f4ce05f9768506f905e142f835 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615081 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Antonio Caggiano 5b4f180c 2022-04-29T16:56:34 Fix formatting Unrelated changes created by running "git cl format" Bug: None Change-Id: I880c7d50aead70353f22502d953efa7aa60ff5d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3616882 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll f1c5e2b1 2022-05-02T10:01:42 Roll vulkan-deps from 7b51f5f85aad to 1cde45b8d7aa (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7b51f5f85aad..1cde45b8d7aa Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/984ed30008..2d83cbf35b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I62cb3b0bea58563ff2f897d101cd80582b21e098 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3619898 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fd57d8f0 2022-05-02T08:11:47 Roll Chromium from 3a1ff9044aec to 929311ac6298 (541 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3a1ff9044aec..929311ac6298 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7da32be821..35387279e4 * buildtools/linux64: git_revision:48b013c9d9debc0f5fc1dd71a257b3c38c5acb43..git_revision:53ef169800760fdc09f0773bf380fe99eaeab339 * buildtools/mac: git_revision:48b013c9d9debc0f5fc1dd71a257b3c38c5acb43..git_revision:53ef169800760fdc09f0773bf380fe99eaeab339 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c055932162..c7888dd707 * buildtools/win: git_revision:48b013c9d9debc0f5fc1dd71a257b3c38c5acb43..git_revision:53ef169800760fdc09f0773bf380fe99eaeab339 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c259b4a75c..6039be79b9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9ba02ee5ca * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8a87603683..fccf35cb8e * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e28c5403fb..e53d3f018a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/942772f588..75625c6906 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f9c72277fe..12653c4be0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a8517e8784..ea7a03c31e Clang version changed llvmorg-15-init-8945-g3d7da810:llvmorg-15-init-9074-gc62b014d Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/942772f588fccbc36cae0c85862e4aca0d463840..75625c6906f3949b63684dabbc6aca220247e703/scripts/update.py Bug: angleproject:7200,angleproject:7246 Tbr: cnorthrop@google.com Change-Id: Ia0f2cb96d5f51fe0b1bcca6524d159e7909c9c22 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3619895 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny e55990e3 2021-10-20T19:32:59 Capture/Replay: Handle arrays with uniform block indices When we update the uniform block indices we have to take into accountg that there may be arrays and that the indices of array elements can be retrived by querying with an index. Consider a layout layout(std140) uniform Data { vec4 plainData; vec4 arrayData[3]; } buffers; Then the loop for updating the uniform block indices will see [ "plainData", "arrayData", "arrayData", "arrayData" ] and we have to take care to add the array indices if they are greaten than zero, otherwise we would always query the index of the first array element. Bug: angleproject:6180 Change-Id: I21f96ab49c1c33bc4024711b72df961377afea4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3198881 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 1aa4c120 2022-04-29T09:36:37 gl_tests: Fix formatting "git cl format" updated some formatting in code unrelated to the change set. Bug: None Change-Id: I4f63db03328356964c2e7c3a9785affa1078a82b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3613919 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Shahbaz Youssefi c7a9f0c6 2022-04-27T16:20:51 Vulkan: Remove syncval suppressions no longer triggering Bug: angleproject:6422 Bug: angleproject:6424 Bug: angleproject:6566 Change-Id: If4d6cf097108f71732d093f3debfc30475a3c90c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3612183 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e39dfe0f 2022-04-29T18:14:48 Roll VK-GL-CTS from a22069b4e3b7 to 106df4122297 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/a22069b4e3b7..106df4122297 2022-04-29 quic_mnetsch@quicinc.com Merge pull request #314 from etra0/patch-1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,cnorthrop@google.com Change-Id: Ia6fea2a9d7524ce100ca1b02cf7546baa61c27e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3616985 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 3eb2bcf7 2022-04-27T16:13:04 Vulkan: Fix syncval errors with DONT_CARE for unused attachments DONT_CARE is a write operation for synchronization purposes. ANGLE doesn't synchronize depth/stencil attachments that are not written to, as it uses the read-only layout. This change makes sure LOAD/STORE_OP_NONE are used instead of DONT_CARE for attachments that are not used, even if they don't have defined contents. This allows ANGLE to continue to not do additional synchronization. Bug: angleproject:5371 Bug: angleproject:5962 Bug: angleproject:6411 Bug: angleproject:6584 Change-Id: I539379aa34f6655f00e798e8c4a5c57f40f7a12d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3612182 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 3eb89196 2022-04-29T16:23:41 Roll Chromium from 1e97e6cd1c3c to 3a1ff9044aec (639 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1e97e6cd1c3c..3a1ff9044aec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8d186c298b..7da32be821 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f0d740e4e2..113378f9b3 * buildtools/linux64: git_revision:ecec350e71ea4600f7bde967854e083fbc53a37f..git_revision:48b013c9d9debc0f5fc1dd71a257b3c38c5acb43 * buildtools/mac: git_revision:ecec350e71ea4600f7bde967854e083fbc53a37f..git_revision:48b013c9d9debc0f5fc1dd71a257b3c38c5acb43 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a53022fa7e..c055932162 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/43a7a256a0..d8a47466e3 * buildtools/win: git_revision:ecec350e71ea4600f7bde967854e083fbc53a37f..git_revision:48b013c9d9debc0f5fc1dd71a257b3c38c5acb43 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fd65c024d7..c259b4a75c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1af344e3fa..61ba3de9aa * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ef89d1327c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/381db68adc..8a87603683 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/0078980ac6..e28c5403fb * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3c4a622d9f..942772f588 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a51dba1207..f9c72277fe * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4d3e7e0884..a8517e8784 Clang version changed llvmorg-15-init-8609-g3254f468:llvmorg-15-init-8945-g3d7da810 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/3c4a622d9f0b0ce5ec2a438189d46c695216b324..942772f588fccbc36cae0c85862e4aca0d463840/scripts/update.py Bug: None Tbr: cnorthrop@google.com Change-Id: I839822f59675f7626c0e2f57b63d0703aa8f2b36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615827 Commit-Queue: Cody Northrop <cnorthrop@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brian Osman 31f84138 2022-04-29T13:51:49 Add option for Metal output to angle_shader_translator Bug: angleproject:7254 Change-Id: Idbccae3aaf11043940c53f4239e402aaa8b240b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615078 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 394fb0d3 2022-04-26T17:17:58 Vulkan: Don't take lock for getLastCompletedQueueSerial getLastCompletedQueueSerial() is simply returning a uint64_t serial number. There is no need to take a mutex lock. This CL uses atomic for mLastCompletedQueueSerial and removed the lock as well as removed the virtual function call. This also avoid the annoyance with mutex lock, that if you call getLastCompletedQueueSerial in places that has other lock held, you may end up with deadlock. This CL avoids that trouble all together other than improves performance. Bug: b/230759914 Change-Id: I9dc688d410e4c6bca7fc70ae4f9fe0c3acc2e005 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3607500 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 5e4c141c 2022-04-28T15:59:25 Tests: Add GFXBench Driver Overhead 2 trace Bug: angleproject:7249 Test: angle_perftests --gtest_filter="*driver_overhead_2*" Change-Id: I29af5cd4afa442b223968f68ec24cd72a7b5bf90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615612 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki 7184fe38 2022-04-27T10:58:39 Tests: Add Jetpack Joyride trace. Test: angle_perftests --gtest_filter="*jetpack_joyride*" Bug: angleproject:7253 Change-Id: I4823e13ba4543ed19d91631de2cef21a320b813f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3613925 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 8b26c14c 2022-04-29T10:01:35 Roll SwiftShader from b92f7acb7e81 to adef92e7b4c6 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/b92f7acb7e81..adef92e7b4c6 2022-04-28 capn@google.com Fix CMake build using Clang 13 compiler 2022-04-28 capn@google.com Remove 'partial precision' intrinsics 2022-04-28 capn@google.com Run the MemorySanitizer pass after optimizations 2022-04-28 capn@google.com Revert to using LLVM's O0 pipeline for coroutines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I11f0b6599761bbc7f8d5d55c30b32d372668d0d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615347 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2d3ad8ec 2022-04-29T10:01:08 Roll vulkan-deps from 1963b94c99e8 to 7b51f5f85aad (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1963b94c99e8..7b51f5f85aad Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/c52333b984..a9d23d7652 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/671f6e633f..46492aa45a * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5c384fa7e0..984ed30008 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I8fc9575edd7aa52e6d33a171381934a59af754a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615625 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 1c4c9fe9 2022-04-28T15:38:22 Capture/Replay: Fix formatting These unrelated changes were created by running "git cl format" Bug: None Change-Id: I5a263818c3a94c40993312716d5782c5b9beb595 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3613909 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Brian Osman 2c58e7a5 2022-04-27T09:50:01 Reduce console spam from Metal shader translation Skia is seeing this for every test, and it's polluting the logs. Realistically, a developer only needs this once per process. Bug: angleproject:7155 Change-Id: Ied4df3af4024ec542c6a9fd8c33d36f4e82b69cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3611062 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 437053a1 2022-04-28T09:05:43 Revert "Make SPIRV optional for Metal backend" This reverts commit 29287e1fc7ad3dff0619736a89e64b3598af8659. Reason for revert: Possible root cause of Mac failures http://crbug.com/1320588 Original change's description: > Make SPIRV optional for Metal backend > > This allows clients (ie Skia) to build ANGLE without needing > all of the additional Vulkan dependencies. Developer builds > will continue to include both the direct and SPIRV paths, for > debugging purposes. > > Bug: angleproject:7155 > Change-Id: I1c38ee19e747df8b25fd2f8e8efa3b420a4d7766 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3605764 > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Auto-Submit: Brian Osman <brianosman@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: chromium:1320588 Change-Id: Id160118146dad1b8f1af40c60ddefd717516cd1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3614527 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Jamie Madill f9729598 2022-04-28T16:36:50 Revert "Fix commit ID gathering on Android builds." This reverts commit 1835e5d895f7f75435c2eddf3f87a88ef534c237. Reason for revert: Breaks Skia integration in linkImpl. Original change's description: > Fix commit ID gathering on Android builds. > > Android infra does not store the .git directory alongside the > checked out code, instead using a gitdir directive to point > elsewhere. This caused the commit_id script to fail, which > could cause issues with disk-backed program caches on updates > when the serialization format changes. > > This CL also makes it a build failure to fail to get the commit id, > and removes the ANGLE_DISABLE_PROGRAM_BINARY_LOAD fallback (which > was broken anyway due to not being used anywhere). > > Bug: b/206109660 > Test: Run script on Android infra, verify hash is gathered properly. > Change-Id: Ie28dc9278b6fbd3dd4f09232c0a88d602fca6980 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3604710 > Commit-Queue: Doug Horn <doughorn@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: b/206109660 Change-Id: I64ac0831a46b9e1ff2e2738624650d67d0609f3c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615009 Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Doug Horn <doughorn@google.com>
angle-autoroll c1d0e139 2022-04-28T10:01:08 Roll vulkan-deps from 4f93dbdc6060 to 1963b94c99e8 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4f93dbdc6060..1963b94c99e8 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d7cae5e7cd..c52333b984 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I56488ff6081391fd8953869c89dc44df1a3e38d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3611918 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d5ceba0b 2022-04-28T10:01:36 Roll SwiftShader from f88fc3b53c52 to b92f7acb7e81 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f88fc3b53c52..b92f7acb7e81 2022-04-27 capn@google.com Merge coroutine pass manager run into a single pipeline 2022-04-27 capn@google.com Skip optimization passes when generating debug info 2022-04-27 capn@google.com Validate LLVM IR before running passes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I99e766d644a0a4c08dda86d4d67dd73ebb62dee7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3613155 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3e406929 2022-04-28T08:25:21 Roll Chromium from c7e51a124fab to 1e97e6cd1c3c (915 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c7e51a124fab..1e97e6cd1c3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1323d36646..8d186c298b * buildtools/linux64: git_revision:d0f8bc99e0584cd33ea8030441d58ee875af7842..git_revision:ecec350e71ea4600f7bde967854e083fbc53a37f * buildtools/mac: git_revision:d0f8bc99e0584cd33ea8030441d58ee875af7842..git_revision:ecec350e71ea4600f7bde967854e083fbc53a37f * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/7d9bbeb389..a53022fa7e * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/fe26c4b100..43a7a256a0 * buildtools/win: git_revision:d0f8bc99e0584cd33ea8030441d58ee875af7842..git_revision:ecec350e71ea4600f7bde967854e083fbc53a37f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d0fbcee500..fd65c024d7 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8a8842cb53..ae9f091e95 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f7b1f51269..1af344e3fa * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ef89d1327c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7feb245cf5..381db68adc * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/69bda632e1..0078980ac6 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b63fdb15ca..a51dba1207 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/4bec803ccb..ca7c1ec42a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e77900edf8..4d3e7e0884 No update to Clang. Bug: angleproject:7079,angleproject:7200 Tbr: cnorthrop@google.com Change-Id: I9a7ea4452e54cbc43d7aedacc760b7c75ed1c40c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3611917 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 2a6e123b 2022-04-27T15:27:46 Vulkan: Move pruneOrphanedBufferBlocks to last RendererVk::cleanupGarbage() should call pruneOrphanedBufferBlocks() after clean up mSuballocationGarbage, so that we will be able to find the orphaned buffer block being empty if mSuballocationGarbage actually made it empty. Bug: chromium:1318110 Change-Id: I0cc6e45c192f406e7bbb15c7427d30e06208dd06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3611648 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 266111a5 2022-04-22T21:52:19 Vulkan: Fix SemaphoreCount best practice warning Bug: angleproject:7231 Change-Id: Ifd02084887aca44aade96474a45f3060b276226e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3603701 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 1ef90012 2022-04-26T16:25:58 Vulkan: Remove API access for mTotalBufferToImageCopySizen Don't expose mTotalBufferToImageCopySize via API if it is unnecessary, for better encapsulation. Bug: angleproject:6354 Change-Id: If69a5a78cc40d54feee6f3474aef6292d60b89c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3609016 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 454efd1d 2022-04-26T23:57:46 Add forceDepthAttachmentInitOnClear frontend workaround AMD on D3D11 skips depth buffer updates in some cases. Bug: angleproject:7246 Bug: angleproject:7200 Change-Id: I27bbea30fbf4173470063a670b9c43a805286c39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3608092 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Brian Osman 29287e1f 2022-04-26T12:05:07 Make SPIRV optional for Metal backend This allows clients (ie Skia) to build ANGLE without needing all of the additional Vulkan dependencies. Developer builds will continue to include both the direct and SPIRV paths, for debugging purposes. Bug: angleproject:7155 Change-Id: I1c38ee19e747df8b25fd2f8e8efa3b420a4d7766 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3605764 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 3b65b803 2022-04-27T11:04:22 Vulkan: Work around Qualcomm imprecision with dithering On qualcomm, sometimes the output is ceil()ed instead of round()ed. With ditering emulation affecting values, some dEQP tests fail due to the excessive change in value when dithering bumps the value slightly over to the next quantum. In this change, a workaround is added to round() the value before outputting it. Bug: angleproject:6953 Change-Id: Iae7df5ca20055b4db3185c6153f3c0bf4ba07f68 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3611064 Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jeff Vigil 6c248691 2022-04-21T10:10:03 Enable SINGLE_BUFFER with eglCreateWindowSurface Enable core EGL feature for Vulkan using: VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR Test: angle_end2end_test --gtest_filter=EGLSingleBufferTest Bug: angleproject:7224 Change-Id: I3e85f932471f7b3c97bbc5c2f5314f25eb9b2867 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3610975 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Doug Horn 1835e5d8 2022-04-25T14:42:31 Fix commit ID gathering on Android builds. Android infra does not store the .git directory alongside the checked out code, instead using a gitdir directive to point elsewhere. This caused the commit_id script to fail, which could cause issues with disk-backed program caches on updates when the serialization format changes. This CL also makes it a build failure to fail to get the commit id, and removes the ANGLE_DISABLE_PROGRAM_BINARY_LOAD fallback (which was broken anyway due to not being used anywhere). Bug: b/206109660 Test: Run script on Android infra, verify hash is gathered properly. Change-Id: Ie28dc9278b6fbd3dd4f09232c0a88d602fca6980 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3604710 Commit-Queue: Doug Horn <doughorn@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Roman Lavrov c9794d6c 2022-04-27T14:20:47 Run a smoke test in each shard and crash on timeouts. The smoke test (words_with_friends_2) typically takes only a few seconds to run. Run it first to check that everything is working as intended. As we know it's a short test, we can set a small timeout (60s) and fail early in case something goes wrong. This will speed up tests failures when something is completely broken. I also changed the main shard run to crash when timeout is detected instead of just dumping debug info as if the tests didn't finish in 10 minutes they're also unlikely to finish in the 20 minutes after which swarming times out the shard. Bug: angleproject:7242 Change-Id: Ia99ca4b2e1676d09b9ff7d67ab116aba94f66512 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3611446 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 80d50b99 2022-04-26T17:29:08 Add build arg to automatically attach renderdoc Macro ANGLE_TEST_ENABLE_RENDERDOC_CAPTURE was defined only for files under src/libANGLE, however, we need to use this Macro in filed under src/tests/. Move the Macro config from BUILD.gn to src/tests/BUILD.gn. Also add a new gn arg angle_enable_renderdoc to control enable/disable the Macro. Bug: angleproject:6072 Change-Id: I3879015e9bdfe2530012ea39729a31c47129ce4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3609024 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 7d31a47f 2022-04-23T00:19:15 Vulkan: Optimize away eglSwapBuffers for single buffer surfaces For single buffer surfaces, eglSwapBuffers serves two purposes: - Switch to/from single buffer mode - Implicitly issue a glFlush Simultaneously, for single buffer surfaces, glFlush serves three purposes: - Submit the commands - Call queue present (if necessary) - Throttle the CPU In this mode, ContextVk::flush() already redirects to the surface, calling WindowSurfaceVk::swapImpl() which calls back to ContextVk::flushImpl() (to submit the commands), calls queue present and throttles the CPU. If the application calls eglSwapBuffers(), the exact same thing happens (i.e. WindowSurfaceVk::swapImpl() is called to the same effect). Calling swapImpl() leads to an addition of the corresponding submit serial to the "swap history". The CPU throttling code always throttles the CPU to the serial of two swaps ago. Unnecessary calls to eglSwapBuffers() (when there is no command to be flushed) in single buffer mode would thus lead to the CPU throttled to the end of the last submission, effectively turning into a glFinish(). In this change, eglSwapBuffers() in single buffer mode, when not switching to/from this mode, is redirected to glFlush() as it's functionally equivalent. Simultaneously, ContextVk now tracks whether it has any pending commands for submission at all, and skips glFlush() altogether if there are none. Together, this results in the unnecessary eglSwapBuffers() to become no-op. Bug: b/229908040 Change-Id: I0e3b4a8b7eb4f6b0e0ed22260644825fc67dd330 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3603841 Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Charlie Lao 5c756bc1 2022-04-26T14:31:47 Perf Tests: Compute GPU time periodically If you specify `--fixed-test-time 30` while running app perftest and watch for GPU memory allocation, you see GPU memory keeps growing. This is due to we generate timestamp query for every frame, but don't calculate the GPU time at the end of run. We accumulate all these queries over the entire test run. Even though this is technically not a leak, it does grow monotonically while test is running. This CL calls computeGPUTime every 16 frames (steps) and changed the mTimestampQueries to a queue structure and clean up the completed query as GPU time is computed. Bug: angleproject:7243 Change-Id: I283ee24c4835fe0fb4d15f8d1975c85b64e16443 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3609011 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Roman Lavrov c402f002 2022-04-26T12:31:06 Android perf tests shards 20->6 (only --smoke-test-mode) try 4470: Max shard runtime (5m 14s) + overhead (19s): 5m 34s (shard #2) Min shard runtime (4m 41s) + overhead (10s): 4m 51s (shard #1) Total shard runtime (29m 21s) + overhead(1m 37s): 30m 58s Bug: angleproject:6854 Change-Id: Ia1664bd56f502a81eaa4b2f0e35722b2ff5bea3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3605765 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Roman Lavrov 6930184e 2022-04-27T10:34:28 Log runTests so that it shows up in logcat dumps. 04-27 14:41:32.303 11507 11538 I NativeTest: runTests: --list-tests 04-27 14:41:32.321 11507 11538 I NativeTest: runTests finished ... 04-27 14:41:34.742 11585 11615 I NativeTest: runTests: --gtest_filter=TracePerfTest.Run/native_trex_200 --verbose --calibration-time 2 --calibration --warmup-loops 2 --isolated-script-test-output=/sdcard/Download/temp_file-cbce720a15e62e25 04-27 14:41:56.628 11585 11615 I NativeTest: runTests finished Bug: angleproject:7242 Change-Id: I5c03501982d6b268c0dd83d71ce82080fb3c551a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3611063 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll c45aff4f 2022-04-27T10:01:35 Roll SwiftShader from 5f5faa3a2aad to f88fc3b53c52 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/5f5faa3a2aad..f88fc3b53c52 2022-04-26 capn@google.com Always enable MemorySanitizer instrumentation for setup routines 2022-04-26 capn@google.com Replace rr::Config with an integer optimization level pragma 2022-04-26 capn@google.com Implement ScopedPragma 2022-04-26 stha09@googlemail.com GCC: add explicit template instantiation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I25719dec252c5d565650112fb52d8fa19558a5c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3609802 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cc834907 2022-04-27T10:01:08 Roll vulkan-deps from f685346e2e51 to 4f93dbdc6060 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f685346e2e51..4f93dbdc6060 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/af9e2e43a0..5c384fa7e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Id44c3cb4094de1878dce761aaf775681dcc22731 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3609695 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jeff Vigil 95c1ff52 2022-02-24T08:31:52 EGL: Fix EGL_KHR_mutable_render_buffer Fixes for eglSurfaceAttrib error cases. Improve query for render buffer Add test case to EGLSurfaceTest Test: angle_end2end_test --gtest_filter=EGLSingleBufferTest Bug: angleproject:7134 Change-Id: I4fa568c9530312003dc17111be212bf5b66d97fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3556088 Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 0c59b5d9 2022-04-26T19:20:49 Log debuggerd $PID output when instrumentation gets stuck. Bug: angleproject:7242 Change-Id: I2b12e94177bce65acf68e4420fd1fcabffdb993e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3607499 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu fe2c82ad 2022-04-26T12:39:44 check integer overflow in Texture copyImage The code that checks forceCopySubImage could run into integer overflow error for these values: sourceArea.x + sourceArea.width sourceArea.y + sourceArea.height With gn arg is_ubsan=true, these two equations lead to crash. Add the code to check integer overflow Bug: chromium:1314268 Bug: angleproject:5246 Change-Id: I6dee98457a44797ffb806ef8bd05f052c9aaa733 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3597713 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov cdcf1715 2022-04-26T14:48:10 Add missing result_skip and result_fail. Missing result_skip results in tests missing from json.output in perf CI builders. Not sure if the missing result_fail actually happens. Bug: angleproject:6854 Change-Id: I0d70a93be0d595c45e23558345481e749ba128bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3606921 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Gregg Tavares 1a144edf 2022-04-13T17:15:29 Metal:ReadPixels AMD Copy Texture to Buffer optimization On AMD GPUs it's faster to copy a texture to a buffer for read back than to read via a texture. For reading from a normal texture 24-27ms -> 6-9ms For reading from a IOSurface texture 17-20ms -> 7-10ms Bug: angleproject:7117 Change-Id: I7c7f276a3121e87f5c52a1a4287d13203a6b1b37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3584423 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com> Commit-Queue: Gregg Tavares <gman@chromium.org>
Charlie Lao 6b9c5c8d 2022-04-22T11:06:16 Vulkan: Improve GetStorageMemoryType logic This is follow up from previous CL. For discrete GPU (preferDeviceLocalMemoryHostVisible is disabled), we will get HostVisible memory if any map can be created on it. For non discrete GPU, this CL also adds the check if the buffer will never gets updated, we just use DeviceLocal memory without HostVisible bit. Bug: angleproject:7047 Change-Id: I73bdc133badbf01c098db23563b30898d4d16a41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3602943 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Cody Northrop cbdefd93 2022-04-26T08:54:53 Roll chromium_revision 192db13f85..c7e51a124f (995097:996181) Change log: https://chromium.googlesource.com/chromium/src/+log/192db13f85..c7e51a124f Full diff: https://chromium.googlesource.com/chromium/src/+/192db13f85..c7e51a124f Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/60cda7a32c..1323d36646 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c2e4795660..f0d740e4e2 * buildtools/linux64: git_revision:0d6d1310d005cb9bace909cb8352e83113c6fc51..git_revision:d0f8bc99e0584cd33ea8030441d58ee875af7842 * buildtools/mac: git_revision:0d6d1310d005cb9bace909cb8352e83113c6fc51..git_revision:d0f8bc99e0584cd33ea8030441d58ee875af7842 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e025ba5dc8..7d9bbeb389 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/1acfbbb474..fe26c4b100 * buildtools/win: git_revision:0d6d1310d005cb9bace909cb8352e83113c6fc51..git_revision:d0f8bc99e0584cd33ea8030441d58ee875af7842 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4b98991268..d0fbcee500 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b0f34841af..8a8842cb53 * third_party/android_build_tools/bundletool: zQILIUnCaQ93HTtR07m4ahlE9mrkkwks52L5vFaUaUUC..AqsPZpWJh-ZyGraHKlbH8XgjRnmyDmolX4HhwPEo9XUC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/7876d5194b..f7b1f51269 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..820618f8e6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5e49eda5c4..7feb245cf5 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/b3054f7a3a..dea66ed25b * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/32e65ef975..69bda632e1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ea2f00c10b..3c4a622d9f * tools/luci-go: git_revision:6da0608e4fa8a3c6d1fa4f855485c0038b05bf72..git_revision:2aa3d7e5e8662c5193059a490f07b7d91331933e * tools/luci-go: git_revision:6da0608e4fa8a3c6d1fa4f855485c0038b05bf72..git_revision:2aa3d7e5e8662c5193059a490f07b7d91331933e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fb3d891815..b63fdb15ca * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/087c7630a3..4bec803ccb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c2a5ea3c68..e77900edf8 DEPS diff: https://chromium.googlesource.com/chromium/src/+/192db13f85..c7e51a124f/DEPS Clang version changed llvmorg-15-init-7570-gba4537b2:llvmorg-15-init-8609-g3254f468 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/ea2f00c10b135a0db7299d6247d46d4d36180aec..3c4a622d9f0b0ce5ec2a438189d46c695216b324/scripts/update.py TBR=cnorthrop@google.com, BUG=None Change-Id: I383174415b5fd092b01e54cabf3721d9e5d77281 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3607435 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov d0c8363e 2022-04-26T11:51:47 Dump logcat if instrumentation doesn't finish in 10 minutes. Let's see if this helps us understand stuckness as described in https://anglebug.com/6854#c46 Normally each instrumentation call takes way less than 10 minutes as we run tests individually or in small batches. When stuck, runner times out after 20 minutes. Bug: angleproject:6854 Change-Id: I20074db0fb3e783555a530b9ecef3765f1911fd9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3605763 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Roman Lavrov ebfb9b9f 2022-04-26T10:37:52 Configure logging in perf and gold tests to include time. Currently no timestamp is logged: [I2022-04-25T18:45:14.761163Z 548 0 cmd_stream.go:336] {cmd} INFO:root:adb --version ... Before switching to android_helper relative timestamps in seconds were printed, set up by catapult. Timestamps proposed in this CL are more consistent with outer logging but keep prefix short. Example: [I2022-04-25T18:45:14.761163Z 548 0 cmd_stream.go:336] {cmd} I18:45:14.999999Z adb --version ... Bug: angleproject:6854 Change-Id: I8ef7c9ae44eb5dba564a41456ce9417e3fe0f06c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3606913 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop 7555a159 2022-04-25T22:13:39 DEPS: Remove deprecated chromium dep Bug: angleproject:7241 Change-Id: Ib9be0987dbf63d54f92469ff93bd25c6dc09beb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3606941 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi fc828287 2022-04-24T00:12:11 Tests for Nvidia/Vulkan bugs with tessellation control Bug: angleproject:7236 Change-Id: I9fec5ef0fe03e1bb5e11067d6d3cf2e7c0b560fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3604077 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7ca11287 2022-04-26T10:01:35 Roll SwiftShader from f13461dbb23c to 5f5faa3a2aad (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/f13461dbb23c..5f5faa3a2aad 2022-04-26 capn@google.com Delete src/SwiftShader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I5558e8b3a40cfca14cbbece1c9c4bab8ce5e31d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3607433 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 9d6b3a7e 2022-04-22T21:43:14 Vulkan: Move overlay draw after swap's implicit flush While this introduces a render pass for drawing the overlay, it isolates it from the rest of code associated with the implicit flush on swap and relevant optimizations. This makes the overlay counters more accurate when it comes to said optimizations. Bug: angleproject:7084 Change-Id: I3298612923fe07139891a4252cd2a88de1783ee7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3602839 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 4aae5815 2022-04-22T13:21:03 Vulkan: Overlay widgets for submission statistics Bug: angleproject:7084 Change-Id: I68e69bda43862f9f2711c25a28dbe4745c19a45c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3602832 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 02b96848 2022-04-21T16:32:31 Vulkan: Add support for GL_QCOM_shading_rate Layer GL_QCOM_shading_rate over VK_KHR_fragment_shading_rate Test: ShadingRateQcomTest* Bug: angleproject:7172 Change-Id: I3f040dbfad3906facd4349937fed2ce9a464b824 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3599874 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Arthur Eubanks 69705e5c 2022-04-22T20:55:55 Add -Wno-deprecated-non-prototype This is one of two directories in Chromium where the warning triggers, sink suppression flag so we can remove the global suppression. Bug: chromium:1314867 Change-Id: Iffbd3f3f0caaf050c9a758eb4f968ff5a4f30dff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3602951 Auto-Submit: Arthur Eubanks <aeubanks@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov c0ac374f 2022-04-25T14:06:58 Replace `adb exec-out cat` with pull to temp location. Flaked here: https://chromium-swarm.appspot.com/task?id=5a7a6cbff20e8510 File "/b/swarming/w/ir/src/tests/py_utils/android_helper.py", line 86, in _ReadDeviceFile assert len(out) == expected_size, 'exec-out mismatch' AssertionError: exec-out mismatch Bug: angleproject:6854 Change-Id: I846474cb64c436a67bbc559839d41967108be8c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3606328 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano 01811839 2022-03-17T15:08:38 Refactor platform code Use switch constructs instead of if-else to allow reuse of code and simplify addition of other platforms as new cases. Bug: angleproject:6902 Change-Id: Ia941d0d7bc03538bbc8d96ebece60224994a6c66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3532260 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Antonio Caggiano <antonio.caggiano@collabora.com> Commit-Queue: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0