kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll bf52137b 2022-07-08T10:01:14 Roll SwiftShader from 1d6a1036bdb3 to 16e026a959f1 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/1d6a1036bdb3..16e026a959f1 2022-07-07 swiftshader.regress@gmail.com Regres: Update test lists @ 1d6a1036 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I0a9ddccd653aef0269d3483e42cc7ec3a794df27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3751844 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ac838109 2022-07-08T08:20:19 Roll Chromium from 84d7af71045d to 14abb4e33fdf (505 revisions) https://chromium.googlesource.com/chromium/src.git/+log/84d7af71045d..14abb4e33fdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ea8947ab37..91f4f755f5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/65ee7c4dc1..7cb0c1ac02 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d7cbf23b7d * third_party/fuchsia-sdk/sdk: version:8.20220706.2.1..version:8.20220707.3.1 * third_party/r8: rjJlU5IP2VfVMVMEzQ8fMaA6vkqr15VmfRYimpm4TeIC..Zmb3PQpaMmxHLKO-7rV_Zl3UzVWX40QwqDQQibl5kkYC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4d8117825a..9dfcf9de8e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2195cf7110..3464548264 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I50345a4e21379ccf1256ad7ce00647b7013ff29c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3751903 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 94bbb40a 2022-07-04T00:00:00 GL: Enable pack skip emulation on all Apple drivers * conformance2/reading/read-pixels-pack-parameters.html is failing in WebKit on M1 without this workaround Bug: angleproject:4849 Change-Id: I710386d29c120e59338cd56fc9843cd6232ff96c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3743445 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Charlie Lao a1f8049a 2022-07-06T13:12:20 Vulkan: Remove VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT Some virtual machine drivers have performance cost with VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT. This CL keeps the individually freed descriptorSet in the pool and try to reuse rather than free it. This CL also removes descriptorSetCount from some API since it always allocate one at a time. Bug: b/237848471 Change-Id: I029d651101fa1050770eba9e733a166e56a69684 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3749797 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 9931dfd5 2022-05-02T00:00:00 D3D9: Implement float sources for Image9::copyFromRTInternal Bug: angleproject:5038 Bug: angleproject:6257 Change-Id: I4f21fb1e37a985e2179d9c06101fa5bd2fedb100 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3738143 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Alexey Knyazev 925ec6b5 2022-07-07T00:00:00 Clamp viewport dimensions on store Bug: angleproject:7486 Bug: chromium:1130759 Change-Id: I6131baacc940b5df7e33ba10fca8e6e148cb8670 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3751056 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Mark Lobodzinski fb3e2def 2022-05-24T15:47:01 Extend labelObject functionality Modify interface to fully support labelObject return codes. Fix issues with texture implementation, including handling deferred Vulkan object creation. Bug: b/229105865 Change-Id: I0c64b72dd0b54642fb643ee7f5ccbb2a134c6787 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3703184 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
angle-autoroll 929a3752 2022-07-07T10:01:13 Roll SwiftShader from 7987bda077c8 to 1d6a1036bdb3 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/7987bda077c8..1d6a1036bdb3 2022-07-06 sugoi@google.com Always perform depth test using floating point values 2022-07-06 swiftshader.regress@gmail.com Regres: Update test lists @ 7987bda0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I279f7c726a5384ed575587e668a1a8d92d9541d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3750998 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev a4e00c64 2022-06-30T00:00:00 Expose EXT_compressed_ETC1_RGB8_sub_texture on Metal and GL Updated the test to ensure that this extension is exposed on Apple GPUs when using Metal. Updated emulatedEtc1 limitation to hide this extension when the main ETC1 extension is hidden. Real WebGL apps cannot enable this extension because it is not exposed in WebIDL. Removed bogus entry from IsETC1Format and use the helper consistently in all validation functions. Simplified GetNativeCompressedFormat. Bug: angleproject:7471 Change-Id: I61321fadad7d962358d0fefecd08aaddaedd2ec2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3737762 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll cd1b22ee 2022-07-07T10:01:23 Roll vulkan-deps from 34e0281e9664 to c119749eff1f (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/34e0281e9664..c119749eff1f Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5f4284aa78..05de650371 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a83fbb9594..c9ceaf94e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I1a9363d441a49209641a6aff4c7adc7d1b36af6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3750937 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3a52a796 2022-07-07T07:01:17 Roll Chromium from 0820cef93768 to 84d7af71045d (436 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0820cef93768..84d7af71045d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4b4fefbabb..ea8947ab37 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ffe4aea6f0..65ee7c4dc1 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9cf14c268d..e44b3e77a9 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8b6bc96d32..f2fc4aff7a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6f2de7bf2d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/78c53d11a0..bb07d9eb0b * third_party/fuchsia-sdk/sdk: version:8.20220705.3.1..version:8.20220706.2.1 * third_party/r8: HmHfvTcsLzsBa_zD-K3mzWcLgCCjj2q2C0G7yLng82wC..rjJlU5IP2VfVMVMEzQ8fMaA6vkqr15VmfRYimpm4TeIC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c8f1e5e5b7..8bd72d6250 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/36f2d375a8..2195cf7110 Clang version changed llvmorg-15-init-14188-g4dcb42fa:llvmorg-15-init-15116-g7c4b90a9 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/c8f1e5e5b7722962ecb28ba041775939d451ed82..8bd72d6250bbb3a2c30151a5920ebc6f644dc51c/scripts/update.py Bug: None Tbr: abdolrashidi@google.com Change-Id: Ib2d3764495e9c0eec94a84fda2aab292dea79879 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3750133 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brandon Schade afcca86c 2022-07-05T11:25:04 Fix ValidateCompressedTexSubImage3D compressed format check Fix the ValidateCompressedTexSubImage3D to perform compressed format validation only when we have a compressed format Bug: chromium:1341624 Change-Id: I5c8b3ef548cfa63b86e077f3c9e4c15e83dc7988 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3747203 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Quyen Le 0f688d62 2022-07-04T15:49:53 Metal: Allow Surfaces to be created without depth & stencil Previously, egl::Config with depthSize=0 & stencilSize=0 wasn't added to DisplayMtl's configSets. Thus every surface would be created with at least stencilSize=8 although users requested DONT_CARE. This led to wasteful memory being used to created stencil buffers even though they were not used. Fixes: - dEQP-EGL.*.query_surface.simple.pbuffer.rgba8888_depth_stencil - dEQP-EGL.*.query_surface.simple.pbuffer.rgba8888_depth_no_stencil - dEQP-EGL.*.query_surface.simple.pbuffer.rgba8888_no_depth_stencil Bug: chromium:1329376 Change-Id: Iba13b527640a6b8ce6c4b3a63346b41730a83891 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3739868 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Quyen Le <le.hoang.q@gmail.com> Reviewed-by: Gregg Tavares <gman@chromium.org>
Shahbaz Youssefi 053d152d 2022-07-04T21:20:34 Vulkan: Resolve GoogleX MSRTSS conflict with EXT Now that the extension is public, rename the old symbols to GoogleX as they have shipped previously. This reverts defd99dc4. Bug: chromium:1088005 Change-Id: I5ac7f73e24084e26a8b2d9cf742c7ab9b3c80984 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3744362 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Mohan Maiya 81a69da6 2022-06-30T09:56:54 Vulkan: min/mag filters follow chroma filter value The Vulkan spec states that for those formats lacking support for VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_SEPARATE_RECONSTRUCTION_FILTER_BIT the min and mag filter must be equal to the sampler YCbCr conversion's chroma filter. Having the min/mag filters follow the chroma filter leads to simpler and more efficient code. Also update getPreferredFilterForYUV function to return existing filter value when preferLinearFilterForYUV feature is disabled. Bug: angleproject:7382 Bug: angleproject:7392 Tests: Texture2DTestES3YUV.TexStorage2DYuvFilterModes* Tests: ImageTestES3.SourceYUVAHBTargetExternalYUVSampleLinearFiltering/ES3_Vulkan Change-Id: I550ef8feede1dc6c3a0d8e32f790113e90ef7a4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3739582 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Eddie Hatfield 916a35dd 2022-06-28T14:40:53 Merge getTempPath and CreateTemporaryFile Also includes moving these two (and some helpers) to common/system_utils.h Bug: angleproject:5095 Change-Id: I7d2fcbd27a67dc13215265ac5b5e8391b15a980b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3733519 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Eddie Hatfield <eddiehatfield@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Rafael Cintron 39e88e6e 2022-06-29T13:48:14 Handle OOM in SwapChain11::getRenderTargetShaderResource SwapChain11::getRenderTargetShaderResource has a code path where it allocates a new texture if the current one has insufficient flags. When this happens, the return value of the texture allocation is not checked, leading to a nullptr crash. Since texture allocation can fail in the case of OOM, we need to handle the failure and propogate the error to callers. Bug: angleproject:7442 Change-Id: I686d84ace669c461e8f7ef66bb0e6c4466f1c5ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3736687 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi 5a65a2b1 2022-07-06T11:46:17 Fix samples' arguments to SampleApplication Two new parameters were added in https://chromium-review.googlesource.com/c/angle/angle/+/3664916 with default values, but not all samples were updated to accomodate them. As a result, many samples passed in the major version for client type and thus couldn't run. This change introduces an enum class for the client type + version to make sure such a mistake is impossible. Bug: angleproject:7360 Change-Id: I450edee612d08a7b67530b61615f63268fefb200 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3748413 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Caggiano 007a4f06 2022-04-22T11:07:05 Vulkan: Wayland resize callback Handle client resize requests and resize the swapchain accordingly after next buffer swap. Bug: angleproject:6902 Change-Id: I8bd6b0d4efac041606f15eccb6befa28594905b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3608089 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jeff Vigil <j.vigil@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Chris Dalton 3e5de4ac 2022-07-05T10:22:54 Add a test that passes image2D handles as function args Bug: angleproject:7484 Change-Id: I3565bd42deeefa22566d4556a25ec9778c6f8550 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3747098 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a29353f0 2022-07-06T10:01:13 Roll SwiftShader from d1116fa9e9dc to 7987bda077c8 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/d1116fa9e9dc..7987bda077c8 2022-07-05 nicolas.capens@gmail.com Compute vertex clip flags using scalable SIMD If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I671d990bcfd4195341d569db554539b3025e4c67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3747898 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 514abb06 2022-07-06T10:01:23 Roll vulkan-deps from 24ed8b7a6bd7 to 34e0281e9664 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/24ed8b7a6bd7..34e0281e9664 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/36c0c15962..0bcc624926 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8ec4a0772b..5f4284aa78 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0ad591fa3c..26921924d6 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/46f5d6ba1d..a83fbb9594 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Iae9224b5abdfffd399b1c8a8fc95aa3f4c2975f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3748076 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2437b73b 2022-07-06T09:30:19 Roll Chromium from 532c25a8e2ac to 0820cef93768 (270 revisions) https://chromium.googlesource.com/chromium/src.git/+log/532c25a8e2ac..0820cef93768 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/46a98712b8..4b4fefbabb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/34674445e6..ffe4aea6f0 * third_party/android_sdk/public: PGPmqJtSIQ84If155ba7iTU846h5WJ-bL5d_OoUWEWYC..IPzAG-uU5zVMxohpg9-7-N0tQC1TCSW1VbrBFw7Ld04C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6f2de7bf2d * third_party/fuchsia-sdk/sdk: version:8.20220701.2.1..version:8.20220705.3.1 * third_party/r8: YYmB-DSqgEMUFtrSQw6plpnZygVruQmxrc3Qqeac8ZEC..HmHfvTcsLzsBa_zD-K3mzWcLgCCjj2q2C0G7yLng82wC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f8fe4d9502..4d8117825a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e764c64cc4..36f2d375a8 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I5437b152df0b50c3448fbf73af5bf77a1051013d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3747215 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 9070e279 2022-06-30T09:35:59 Vulkan: Handle platforms that have imprecise float division issues Even when the dividend and divisor have the same value some platforms do not return 1.0f. We need to emit sepcial division code on such platforms. Bug: angleproject:3586 Tests: KHR-GLES31.core.blend_equation_advanced.blend*HSL* Change-Id: Ibb81f57c959ae2c8edb6d361bf6241c019dfb988 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3738439 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 5ef62fa1 2022-07-05T13:38:00 Roll chromium_revision b1ab0fbd60..532c25a8e2 (1020158:1020841) Manually added third_party/android_build_tools/manifest_merger DEP Change log: https://chromium.googlesource.com/chromium/src/+log/b1ab0fbd60..532c25a8e2 Full diff: https://chromium.googlesource.com/chromium/src/+/b1ab0fbd60..532c25a8e2 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/473484fe92..46a98712b8 * buildtools/linux64: git_revision:ecaaf4b9e58a312a1610a37999eeccf58f73e264..git_revision:03ce92df5f9875bd9929b564be4b612713569aa9 * buildtools/mac: git_revision:ecaaf4b9e58a312a1610a37999eeccf58f73e264..git_revision:03ce92df5f9875bd9929b564be4b612713569aa9 * buildtools/win: git_revision:ecaaf4b9e58a312a1610a37999eeccf58f73e264..git_revision:03ce92df5f9875bd9929b564be4b612713569aa9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b97d5810aa..34674445e6 * third_party/android_build_tools/lint: f5g1G8eyExIUPHk4lH3xx_xV4pza9WSBaITgmLPgF2cC..OkpY7I7TtDs4jihQ9SmckN-GEVBpZ2y9xr4M7TimTqoC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6f2de7bf2d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9af90cb59e..78c53d11a0 * third_party/r8: iMLEt10uXASDfG2AlATR1fO8xYhBoF24nQvDDXLY6Q8C..YYmB-DSqgEMUFtrSQw6plpnZygVruQmxrc3Qqeac8ZEC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4db7e4a8a7..f8fe4d9502 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d43fc430b2..e764c64cc4 DEPS diff: https://chromium.googlesource.com/chromium/src/+/b1ab0fbd60..532c25a8e2/DEPS No update to Clang. Bug: chromium:1341026, chromium:1326906 Change-Id: I6f53a4df5ccab4ad162ceb51280b174de6b18bf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3745583 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 1154cc46 2022-07-04T14:45:25 Vulkan: Fix round-after-dither logic | was used instead of &, effectively enabling this on all platforms. Bug: angleproject:6953 Change-Id: I73846368c689d70ad9679e0caa47b7004177d678 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3744361 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Fumitoshi Ukai 06bd0c11 2022-06-30T01:58:15 angle: set $build/goma["use_luci_auth"] = True without use_luci_auth=true, goma will use global service account, which uses exported service account key. use task service account by use_luci_auth=true instead. angle-ci-builder@chops-service-accounts.iam.gserviceaccount.com angle-try-builder@chops-service-accounts.iam.gserviceaccount.com are added to goma-rbe-chromium c-i-a group https://chrome-infra-auth.appspot.com/auth/groups/goma-rbe-chromium Bug: chromium:1105814 Change-Id: Ia31c297e77fe2451958a64f2caf2ffeb85864a26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3737242 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Fumitoshi Ukai <ukai@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 4a5c1e1f 2022-07-05T10:01:04 Roll vulkan-deps from 8e3184380881 to 24ed8b7a6bd7 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8e3184380881..24ed8b7a6bd7 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/e6925974d1..d8d051381f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I9a59b8a52a4c0ca0c6e1376d1e6e830fb6a61dd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3745601 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 86c735bf 2022-07-01T18:27:10 pls: Rename GL_DISABLED_ANGLE -> GL_DISABLE_ANGLE Match the other loadOps by using the imperative form. Bug: angleproject:7279 Change-Id: I9f3a33961f640ea5dff1da7dcea12517cfdcd461 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3741221 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Caggiano 44d8bf76 2022-03-16T14:38:37 Vulkan: Support EGL_EXT_platform_wayland Improve GetPlatformDisplay by supporting EGL_PLATFORM_WAYLAND_EXT. Bug: angleproject:6902 Change-Id: Ia4c342097f47b7c41778ac02517451f51a94d8be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3528758 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Caggiano 0c46c2d9 2022-05-19T16:16:54 Vulkan: Support DRM_FORMAT_MOD_LINEAR Fix a bug while checking for dmabuf image image format support. The value 0 is used for DRM_FORMAT_MOD_LINEAR, which is perfectly valid. DRM_FORMAT_MOD_INVALID could be used instead for bail out. Bug: angleproject:7065 Change-Id: If8eb366873b8f0fe2fd84de745a55171036093d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645124 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 2a941833 2022-07-04T10:01:04 Roll vulkan-deps from cf47f3e49a61 to 8e3184380881 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/cf47f3e49a61..8e3184380881 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/68e5bdc58f..0ad591fa3c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a9711d2135..46f5d6ba1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I03b97059ffc3527c7c2b505560b3acc4bb64bc60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3743183 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton da984303 2022-05-13T21:05:48 Add a pls test for in-shader coherency Stores and loads in a single shader invocation should be coherent. Bug: angleproject:7279 Change-Id: I1a4af6fdbef21f5506bb40c9eb8f5e76c12dd6cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654267 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Chris Dalton 85b05601 2022-06-08T14:05:47 Add a pls test for load-only storage It's conceivable that an implementation may need to be careful to preserve the pls contents when a shader doesn't call pixelLocalStore(). Bug: angleproject:7279 Change-Id: I7b7fb25dced49902fd68685d2f5aa82219ced686 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696503 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Chris Dalton <chris@rive.app> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll bd6d1e17 2022-07-01T21:14:32 Roll VK-GL-CTS from e22ec5fc4cbf to 867b77cee987 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/e22ec5fc4cbf..867b77cee987 2022-07-01 quic_mnetsch@quicinc.com Merge pull request #330 from polarina/maxiterations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,ianelliott@google.com Change-Id: Iaa4cfd82c59302618751cdeb56c6e8cc965f5c28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3741213 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8e79a222 2022-07-01T18:07:12 Roll Chromium from 8bf3474ad33a to b1ab0fbd602a (1173 revisions) Moves third_party/android_lint to third_party/android_build_tools/lint Essentialy squashing in these Chromium CLs: https://chromium-review.googlesource.com/c/chromium/src/+/3735152 https://chromium-review.googlesource.com/c/chromium/src/+/3707459 https://chromium-review.googlesource.com/c/chromium/src/+/3738921 https://chromium.googlesource.com/chromium/src.git/+log/8bf3474ad33a..b1ab0fbd602a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5b369fe7f5..473484fe92 * buildtools/clang_format/script: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git/+log/e435ad79c1..8b525d2747 * buildtools/linux64: git_revision:29accf5ac2eadfc53e687081583b7bc1592a8839..git_revision:ecaaf4b9e58a312a1610a37999eeccf58f73e264 * buildtools/mac: git_revision:29accf5ac2eadfc53e687081583b7bc1592a8839..git_revision:ecaaf4b9e58a312a1610a37999eeccf58f73e264 * buildtools/win: git_revision:29accf5ac2eadfc53e687081583b7bc1592a8839..git_revision:ecaaf4b9e58a312a1610a37999eeccf58f73e264 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7663e0cfff..b97d5810aa * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/62a4d6866a..9cf14c268d * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/29766b5d64..c3471b21c1 * third_party/android_build_tools/bundletool: AqsPZpWJh-ZyGraHKlbH8XgjRnmyDmolX4HhwPEo9XUC..qLkNwA6wjoqznVqaa151GelgGBP4X495n0z-jluACPcC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0f40847086 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a83ac9395c..9af90cb59e * third_party/fuchsia-sdk/sdk: version:8.20220627.3.1..version:8.20220701.2.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/35de724cf2..ee5f422273 * tools/luci-go: git_revision:5d9b6ecf87cdfb928e1112d2838d26bc7ede2b48..git_revision:be5d9aacf8987c0826223264f0427cd0b530b6a4 * tools/luci-go: git_revision:5d9b6ecf87cdfb928e1112d2838d26bc7ede2b48..git_revision:be5d9aacf8987c0826223264f0427cd0b530b6a4 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e7effce34f..4db7e4a8a7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7c096990d7..d43fc430b2 * tools/skia_goldctl/linux: LOLBT9fx6Zp6tPJMXhgMoDZcTPCk-VSNk5gHIOchhIMC..ae24MBF5YbEEwpnfCm1dgu86m0StdnqA5BuDV09VyR4C * tools/skia_goldctl/mac_amd64: u6SVSv19aduMZOLqGYkCHbjhnJWwm0WimUYQs4q9mDgC..k-LraF0EyymBQiGapRFxHW3QchEFhcw8Uz1C9EaQES8C * tools/skia_goldctl/mac_arm64: 1aHoSQfZbmKtsxSSw_7SIfNuMapnLQb_uHdo237FM88C..UU5Fs5VQoMBiiUttczNdC1YbiiL2dTmU0j55Lg-J-r0C * tools/skia_goldctl/win: 0JoR2aK22wezglgiEZQathxIbpRDITqBt6h9rwFMU7QC..n3jvsDMl43swXVzULALv9Wh0kHahqZ4VSy7_i3wO1LgC No update to Clang. Bug: chromium:1273512, chromium:1326906 Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: If3202d42fec891ad1620fbd5dd8519686415c5e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3741205 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Charlie Lao 723cc880 2022-06-10T17:55:54 Reland "Reland "Vulkan: Destroy DescriptorSet cache when it becomes invalid"" This is a reland of commit 551a26aeedbfd971d6199c8eddb433a4f4ff871c Original change's description: > Reland "Vulkan: Destroy DescriptorSet cache when it becomes invalid" > > This is a reland of commit 0779ccbcd427dcb00e53afa6385fb4e8e2377993 with > the fix for angleproject:7466. When DescriptorPoolhelper gets > release/destroyed, we ensure all sharedCacheKeys are destroyed. > > Original change's description: > > Vulkan: Destroy DescriptorSet cache when it becomes invalid > > > > When a new texture descriptorSet is allocated, we store one reference of > > the cache key in ProgramExecutableVk and all TextureVks that it > > associated with. When any of the TextureVk is destroyed or its view > > destroyed, we immediately erase the descriptorSet from the cache and > > track GPU progress and free the descriptorSet when it's GPU completed. > > That way we delete the dead descriptorSet that will for sure never been > > reused ASAP so that its space is avialable for reuse. > > > > Bug: b/235523746 > > Change-Id: Ib1b9662a254eea5a3f410dc6d5d89fca6727a647 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700226 > > Reviewed-by: Lingfeng Yang <lfy@google.com> > > Commit-Queue: Charlie Lao <cclao@google.com> > > Reviewed-by: Ian Elliott <ianelliott@google.com> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Bug: b/235523746 > Bug: angleproject:7466 > Change-Id: I4413bec27ea0ca830010e2ca15036c2e667141c0 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726964 > Reviewed-by: Ian Elliott <ianelliott@google.com> > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/235523746 Bug: angleproject:7466 Change-Id: I6b88b884841c5dbc625ee7e0c52c45af09dec199 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3741027 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
angle-autoroll 3b107ee1 2022-07-01T16:12:04 Roll vulkan-deps from 863435cf0898 to cf47f3e49a61 (19 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/863435cf0898..cf47f3e49a61 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/37d2396cab..8ec4a0772b * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/3be1df310b..2c823b7f27 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/865626abba..68e5bdc58f * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/25b838f3a2..1987cb2331 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e32ec7b051..a9711d2135 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: I35d24d82d38aa6ce5f4d6001fde1a1504a640e6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3741026 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 4a5fe6fb 2022-07-01T10:01:56 Roll SwiftShader from 90fdde382489 to d1116fa9e9dc (13 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/90fdde382489..d1116fa9e9dc 2022-07-01 capn@google.com Replace sw::SIMD aliases of 4-wide vectors with rr::SIMD types 2022-07-01 capn@google.com Temporarily support xyzw component swizzling for SIMD types 2022-07-01 capn@google.com Implement SIMD helper functions using 128-bit operations 2022-07-01 capn@google.com Implement 128-bit insert/extract 2022-07-01 capn@google.com Use SIMD types throughout graphics and compute pipelines 2022-07-01 capn@google.com Replace static SIMD::Width asserts with dynamic ones 2022-06-30 capn@google.com Make shader math functions SIMD width agnostic 2022-06-30 nicolas.capens@gmail.com Omit dynamic checks for equal or sequential pointer offsets 2022-06-30 nicolas.capens@gmail.com Construct SIMD pointers from an std::vector instead of array 2022-06-30 nicolas.capens@gmail.com Move rr::Pointer4 to SIMD source and header files 2022-06-30 nicolas.capens@gmail.com Avoid broadcasting data fields to 4-wide vectors 2022-06-30 swiftshader.regress@gmail.com Regres: Update test lists @ 90fdde38 2022-06-30 sugoi@google.com Prevent recompiling programs on changes to compareMask or writeMask If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I05bcf89dfbe6478a2ae16dd069b734417060dad6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3740490 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 7cb0622c 2022-06-30T00:00:00 BlitGL: Fix LUMAWorkaround for half-float copies Use desktop HALF_FLOAT enum when running on desktop OpenGL. Bug: angleproject:5038 Change-Id: I829f28ca51caa1f98b653d1a456ed775f8d362cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3738261 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Mike Schuchardt defd99dc 2022-06-30T16:18:30 Update MSRTSS vulkan struct to final version The public version of VK_EXT_multisampled_render_to_single_sampled released in the 1.3.219 header does not include resolve modes in the VkMultisampledRenderToSingleSampledInfoEXT struct. Remove them to unblock the Chromium auto-roller. Bug: None Change-Id: I9d185a486227edfd3276ccb0df7063ca5101797b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3739583 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Ian Elliott 4b745c2b 2022-07-01T01:25:36 Revert "Reland "Vulkan: Destroy DescriptorSet cache when it becomes invalid"" This reverts commit 551a26aeedbfd971d6199c8eddb433a4f4ff871c. Reason for revert: Blink test failures at: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20MSAN/15546/overview Original change's description: > Reland "Vulkan: Destroy DescriptorSet cache when it becomes invalid" > > This is a reland of commit 0779ccbcd427dcb00e53afa6385fb4e8e2377993 with > the fix for angleproject:7466. When DescriptorPoolhelper gets > release/destroyed, we ensure all sharedCacheKeys are destroyed. > > Original change's description: > > Vulkan: Destroy DescriptorSet cache when it becomes invalid > > > > When a new texture descriptorSet is allocated, we store one reference of > > the cache key in ProgramExecutableVk and all TextureVks that it > > associated with. When any of the TextureVk is destroyed or its view > > destroyed, we immediately erase the descriptorSet from the cache and > > track GPU progress and free the descriptorSet when it's GPU completed. > > That way we delete the dead descriptorSet that will for sure never been > > reused ASAP so that its space is avialable for reuse. > > > > Bug: b/235523746 > > Change-Id: Ib1b9662a254eea5a3f410dc6d5d89fca6727a647 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700226 > > Reviewed-by: Lingfeng Yang <lfy@google.com> > > Commit-Queue: Charlie Lao <cclao@google.com> > > Reviewed-by: Ian Elliott <ianelliott@google.com> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Bug: b/235523746 > Bug: angleproject:7466 > Change-Id: I4413bec27ea0ca830010e2ca15036c2e667141c0 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726964 > Reviewed-by: Ian Elliott <ianelliott@google.com> > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/235523746 Bug: angleproject:7466 Change-Id: Icdde2752c462b7ebbb51d46fd35ce749b5caf377 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3739585 Reviewed-by: Ian Elliott <ianelliott@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 6cd08bc2 2022-06-28T22:04:07 Vulkan: Don't optimize away flush after clear for single buffer Bug: b/237449314 Change-Id: I04421398e2e68541d4713c7e8b80715be68672b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3733808 Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: mohan maiya <m.maiya@samsung.com>
Eddie Hatfield ac1af388 2022-06-23T14:08:50 Add presubmit check for .gclient file Bug: angleproject:4905 Change-Id: I6dbb81ed2d2e102869e5d844fed1bb4c1ef4f449 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720557 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
angle-autoroll 2d5defc7 2022-06-30T17:30:07 Roll vulkan-deps from 1fe7a0ab555e to 863435cf0898 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1fe7a0ab555e..863435cf0898 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/ba3e6ffe03..e6925974d1 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/76fe352190..37d2396cab * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/6f57b1fa23..25b838f3a2 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d81e034d0f..e32ec7b051 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: Ia7d491733890d8eefeef6d533877f609f0c22fe5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3738639 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 90edbd94 2022-06-30T11:49:33 Metal: Support GL_ANGLE_provoking_vertex This allows some users to get improved performance while using flat attributes by avoiding index buffer rewrites. Bug: chromium:1340620 Change-Id: Ic55dec27e51d8929d6781758104632defc6861c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3738260 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Auto-Submit: Geoff Lang <geofflang@chromium.org>
angle-autoroll c66e1652 2022-06-29T21:47:03 Roll vulkan-deps from 470172656108 to 1fe7a0ab555e (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/470172656108..1fe7a0ab555e Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6ba32ffc01..d81e034d0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: I767ec40404e08cedefd44cb8dd851635af3f4c0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3736692 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuxin Hu 1e96beb9 2022-06-29T15:18:35 Suppress the new BestPractice VVL Error Suppress the new best practice VVL Error vkCmdBeginRenderPass-ClearValueWithoutLoadOpClear to unblock the vulken-deps roller. A potential fix is work in progress. Bug: angleproject:7470 Bug: b/237542876 Change-Id: Iaea0cef58984acae79210e72b75be527d98e8286 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3736698 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll c7fe4348 2022-06-30T10:01:56 Roll SwiftShader from ec31f547750c to 90fdde382489 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/ec31f547750c..90fdde382489 2022-06-29 capn@google.com Support printing of SIMD types 2022-06-29 capn@google.com Implement lane-independent SIMD operations 2022-06-29 capn@google.com Refactor scalarized vector processing 2022-06-29 capn@google.com Wrap shuffle and constant construction values 2022-06-29 nicolas.capens@gmail.com Implement minimal SIMD::Int functionality 2022-06-29 srisser@google.com Support VK_SUBGROUP_FEATURE_QUAD_BIT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I7918b35a9423f4c3ca5920408cef23f70aaa6501 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3737626 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 551a26ae 2022-06-10T17:55:54 Reland "Vulkan: Destroy DescriptorSet cache when it becomes invalid" This is a reland of commit 0779ccbcd427dcb00e53afa6385fb4e8e2377993 with the fix for angleproject:7466. When DescriptorPoolhelper gets release/destroyed, we ensure all sharedCacheKeys are destroyed. Original change's description: > Vulkan: Destroy DescriptorSet cache when it becomes invalid > > When a new texture descriptorSet is allocated, we store one reference of > the cache key in ProgramExecutableVk and all TextureVks that it > associated with. When any of the TextureVk is destroyed or its view > destroyed, we immediately erase the descriptorSet from the cache and > track GPU progress and free the descriptorSet when it's GPU completed. > That way we delete the dead descriptorSet that will for sure never been > reused ASAP so that its space is avialable for reuse. > > Bug: b/235523746 > Change-Id: Ib1b9662a254eea5a3f410dc6d5d89fca6727a647 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700226 > Reviewed-by: Lingfeng Yang <lfy@google.com> > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Ian Elliott <ianelliott@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/235523746 Bug: angleproject:7466 Change-Id: I4413bec27ea0ca830010e2ca15036c2e667141c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726964 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Chris Dalton 4884e9de 2022-05-15T22:57:57 Add a pls test for maximum capacity Check that it works to render with the maximum supported data payload: GL_MAX_LOCAL_STORAGE_PLANES_ANGLE GL_MAX_LOCAL_STORAGE_BYTES_ANGLE GL_MAX_FRAGMENT_OUTPUTS_WITH_LOCAL_STORAGE_ANGLE Bug: angleproject:7279 Change-Id: Ifdaff726edee0378b06ce5562001ad3dfe29284b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654974 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Chris Dalton <chris@rive.app> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Geoff Lang 785353fd 2022-05-24T12:40:16 Support Desktop OpenGL context creation in end2end tests Validation of Desktop GL versions and profile masks is unimplemented. Bug: angleproject:7360 Change-Id: Ifae94215b6aada895c2b02318a1d05c9515e9b96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3664916 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 61bcba89 2022-06-29T15:00:03 Roll vulkan-deps from 20ef3c4c476b to 470172656108 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/20ef3c4c476b..470172656108 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/bffcf209cb..b2d2c9dd3d * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/1f92bbb656..865626abba * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/da369877f9..6ba32ffc01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: I2eb3808e264b7f87a973a63cebd8c89828a9496e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3735722 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Patrick To 45def3d4 2022-06-15T13:49:08 Remove non-negative offsets restriction in D3D extension The EGL_ANGLE_d3d_texture_client_buffer extension currently fails if either EGL_TEXTURE_OFFSET_[X|Y]_ANGLE offsets are negative. This restriction is unnecessary, as D3D allows for negative offsets. Bug: angleproject:7446 Change-Id: I2e258a3a558eae51794f6533e28a0c06532f156d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715956 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 4298a54e 2022-06-23T23:17:12 Clean up OWNERS files Bug: None Change-Id: I93726b8e5226d4c3b40c7d3dc865cb7dbe7c17fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3721567 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Gert Wollny fd9301c1 2022-06-17T12:25:10 Capture/Replay: Capture egl surface related calls Creation from a pbuffer and generalized destruction are implemented, as well as binding and releasing a TexImage and making the context current with explicit draw and read surfaces given. Bug: angleproject:4964 Bug: angleproject:6180 Bug: angleproject:6512 Change-Id: Id8be6486125d45341905f3aabdbae4366cd568b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711741 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 1fcfe3bb 2022-06-29T12:45:03 Roll vulkan-deps from 137b026580e5 to 20ef3c4c476b (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/137b026580e5..20ef3c4c476b Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2eff41e707..76fe352190 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/477fb9e188..1f92bbb656 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a0e0e77a22..da369877f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: I182c7768045635949d9e557ee0fe582fca3b12ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3733901 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3224b16a 2022-06-29T07:30:00 Roll Chromium from 1bfae54dd233 to 8bf3474ad33a (639 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1bfae54dd233..8bf3474ad33a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4e6d71ddc1..5b369fe7f5 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b5f3d3b904..3007992fc7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4e9a37120c..7663e0cfff * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c76626ec30 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2f3c96d5e4..a83ac9395c * third_party/fuchsia-sdk/sdk: version:8.20220627.1.1..version:8.20220627.3.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/086948bae5..c8f1e5e5b7 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a1724fdef3..e7effce34f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0ee7593147..7c096990d7 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I2aa37a72de18ffc95630a6656ad98fbb037983ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3733893 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya d50b2276 2022-06-21T12:05:28 Reland "Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh" This is a reland of commit ef60d38ecf12d6663e9ecccacbff9803b1fba7c6 There are no fixes as the revert itself was a speculative one Original change's description: > Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh > > Cache value of EGL_FRONT_BUFFER_AUTO_REFRESH_ANDROID attribute > and set swapchain present mode accordingly when recreating > swapchain in single buffer mode. > > Bug: angleproject:7224 > Tests: EGLAndroidAutoRefreshTest.Basic* > Change-Id: I2dbb92ce5c3fa047e0b02ea9011725311f346027 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707570 > Reviewed-by: Ian Elliott <ianelliott@google.com> > Commit-Queue: mohan maiya <m.maiya@samsung.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Bug: angleproject:7224 Bug: angleproject:7465 Change-Id: Ia876ea17169c0f1b3afdb7753570e0b1aca985f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3733521 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Faye Zhang fd256b0d 2022-06-24T09:58:22 Tests: Add Uber trace Test: angle_perftests --gtest_filter="*uber*" Bug: angleproject:7462 Change-Id: Ie9a6f4c8afbb94e8484dba50b90bfbc7102a3c00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3723859 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi ba737f47 2022-06-27T11:04:21 Vulkan: Don't sync pipeline cache if warm up is effective If the pipeline cache is being warmed up at link time, the blobs corresponding to each program is individually retrieved and stored in the blob cache. This should be enabled only on platforms where draw time pipeline creation hits the cache due to said warm up. As a result, there's no need to store the aggregate cache (the one owned by RendererVk) in the blob cache too. Bug: angleproject:5881 Bug: b/215230983 Change-Id: I2da5de835e6667b0b2d5859e6804791671888947 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3727227 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll bb373176 2022-06-24T14:19:05 Roll vulkan-deps from 11ad77222bfe to 137b026580e5 (1 revision) Suppress new SYNC-HAZARD-READ_AFTER_WRITE. https://chromium.googlesource.com/vulkan-deps.git/+log/11ad77222bfe..137b026580e5 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/620b378993..a0e0e77a22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7456 Tbr: jonahr@google.com,ynovikov@google.com Change-Id: I2ef42cccfabd575cd59c90e6f558b6a46202e028 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3723547 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi b2683a3c 2022-06-28T11:30:50 Document angle_restricted_traces Bug: angleproject:7410 Change-Id: Iab02ca68d76fdd1d04804c85f76f5c251905907b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3732229 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 26a314b4 2022-06-21T00:00:00 Fix typos in multi-draw extension specs Bug: angleproject:1944 Change-Id: I21d63bab1054c99c55e5836ac08c4cf32dbe79d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3716582 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Jose Dapena Paz 1dc3385a 2022-06-27T18:13:33 libstdc++: move FramebufferHelper to cache utils vk_helper.h includes vk_cache_utils.h. FramebufferHelper was declared in vk_helper.h. And FramebufferCache, in vk_cache_utils.h, requires FramebufferHelper for its payload hashmap. This was solved with a forward declaration. But, with std::pair definition in libstdc++ this is not enough. Bug: chromium:957519 Change-Id: I32e3e247c3c8bef8b52806aa2601e4012e6aa79e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3727671 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Brandon Schade 3a799ba5 2022-05-16T17:26:38 Fix ValidateES3TexImageParametersBase for glTexImage*D From the OpenGL ES 3.2 spec: GL_INVALID_VALUE error is generated if internalformat is not one of the valid formats in tables 8.2 or 8.3. glTexImage*D should not accept compressed format. Add check in validation to account for this. Bug: angleproject:6441 Tests: KHR-GLES31.core.compressed_format.api.invalid_teximage_with_compressed_format Change-Id: I7152aefa433f42dcc40cf693538639df26c31341 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3648587 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny ce4e11d3 2022-06-17T12:21:01 libANGLE: Add a unique ID to the Surface This is needed when capturing Pbuffer calls. Bug: angleproject:4964 Change-Id: Id9f35683bf887f08f916de69bbab8c414e5e8872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711740 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 2a5193f6 2022-06-22T17:46:15 Textures: Allow compressed texture from PBO Apex Legends is using a pixel unpack buffer to populate a compressed 3D texture. We had an explicit check in validation that prevented it, possibly due to emulated formats. Rather than prevent it altogether, check whether the format is emulated and proceed if not. Also add a test that exposes the problem. Test: PBOCompressedTexture3DTest Bug: b/236478448 Bug: angleproject:7464 Change-Id: I90105a396bf0a465c62d67910aad2819ba7f8831 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719161 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Cody Northrop 1ae9756e 2022-06-22T17:43:15 Textures: Centralize texture format emulation check Refactor in order to use the check in multiple places. Bug: b/236478448 Change-Id: I6df2e0d63c60fa3e8b2d65185fce164be0e7d961 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719160 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi c775dd49 2022-02-03T16:51:03 Allow list of restricted traces to be overriden in gn args When focused on profiling a single or a few traces, this speeds up build and upload to Android. Bug: angleproject:7404 Change-Id: I5234a6fa7e8167f86b5b33b8db526662a7d65bd9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3438425 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1c825621 2022-06-27T19:01:13 Roll Chromium from 8fdbb85c2176 to 1bfae54dd233 (738 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8fdbb85c2176..1bfae54dd233 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2c9721f023..4e6d71ddc1 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/b387062642..49191c55bb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f877072307..4e9a37120c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/7c2caaa0f4..8b6bc96d32 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/70efa78e78..29db1c9bf3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..17a97abb47 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9a9c40738..2f3c96d5e4 * third_party/fuchsia-sdk/sdk: version:8.20220624.0.1..version:8.20220627.1.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/333646c3c0..086948bae5 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/86c4290c3b..a1724fdef3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/37843dd9a3..0ee7593147 No update to Clang. Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: Ideca023b11ec49bcd244ace5f1b9d46d2dcfd1fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726960 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 2adb6327 2022-05-13T23:09:31 Add a pls test for memoryless storage Bug: angleproject:7279 Change-Id: I4a992d04efa06ac99472d5334a1ac50839a13d06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654973 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Chris Dalton <chris@rive.app> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Yuly Novikov f8690429 2022-06-27T13:50:44 Revert "Vulkan: Destroy DescriptorSet cache when it becomes invalid" This reverts commit 0779ccbcd427dcb00e53afa6385fb4e8e2377993. Reason for revert: crashes in blink_web_tests on linux-rel https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1051045/overview Original change's description: > Vulkan: Destroy DescriptorSet cache when it becomes invalid > > When a new texture descriptorSet is allocated, we store one reference of > the cache key in ProgramExecutableVk and all TextureVks that it > associated with. When any of the TextureVk is destroyed or its view > destroyed, we immediately erase the descriptorSet from the cache and > track GPU progress and free the descriptorSet when it's GPU completed. > That way we delete the dead descriptorSet that will for sure never been > reused ASAP so that its space is avialable for reuse. > > Bug: b/235523746 > Change-Id: Ib1b9662a254eea5a3f410dc6d5d89fca6727a647 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700226 > Reviewed-by: Lingfeng Yang <lfy@google.com> > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Ian Elliott <ianelliott@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/235523746, angleproject:7466 Change-Id: I7e5067de2f2add08af1f9804cc2e952238b2e942 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726097 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov f5aef011 2022-06-27T13:11:16 Skip CreateFramebufferFetchMidRenderPass on Win SwANGLE Bug: angleproject:7419 Change-Id: I76b4d08f985abbd482ef1d14cde62bcd5bb41a86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726096 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 46ddcc44 2022-06-27T14:53:31 Revert "Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh" This reverts commit ef60d38ecf12d6663e9ecccacbff9803b1fba7c6. Reason for revert: crashes in end2end tests on Win Intel Vulkan Original change's description: > Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh > > Cache value of EGL_FRONT_BUFFER_AUTO_REFRESH_ANDROID attribute > and set swapchain present mode accordingly when recreating > swapchain in single buffer mode. > > Bug: angleproject:7224 > Tests: EGLAndroidAutoRefreshTest.Basic* > Change-Id: I2dbb92ce5c3fa047e0b02ea9011725311f346027 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707570 > Reviewed-by: Ian Elliott <ianelliott@google.com> > Commit-Queue: mohan maiya <m.maiya@samsung.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Bug: angleproject:7224, angleproject:7465 Change-Id: Ia48a31124c8e0a3e4bcd4b7dc6f62b0782b42d97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726099 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Steven Noonan 10f065e2 2022-06-23T13:23:09 Vulkan: support QCOM_shading_rate on Intel graphics When querying fragment shading rates, we were limiting the result array to 6 elements, which was not enough on Intel's Windows graphics drivers. Those drivers report more than 6 fragment shading rates, including a bunch of strange ones like 4x1 and 1x4. Because we limited the list to 6 elements, and the Vulkan specification requires that the rates be listed in order from largest width to smallest, the feature check was missing the smaller shading rates (including 1x2 and 1x1). This caused the supportsFragmentShadingRate feature to be disabled. Bug: angleproject:7461 Bug: angleproject:7172 Change-Id: I1b9a2924f93fdb803c20cfa388749754691b6e92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720732 Auto-Submit: Steven Noonan <steven@valvesoftware.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com>
angle-autoroll 8f6889a1 2022-06-24T13:53:39 Roll Chromium from 7f32e27c6969 to 8fdbb85c2176 (321 revisions) Manually added third_party/android_lint dependency. https://chromium.googlesource.com/chromium/src.git/+log/7f32e27c6969..8fdbb85c2176 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4dbf5904da..2c9721f023 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/044213afe8..f877072307 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f6dcfa4c72 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1d5d7803fa..d9a9c40738 * third_party/fuchsia-sdk/sdk: version:8.20220623.1.1..version:8.20220624.0.1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/25de876ad0..86c4290c3b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/eacae1e7ec..37843dd9a3 No update to Clang. Bug: chromium:1273512 Tbr: jonahr@google.com,ynovikov@google.com Change-Id: I4313a93cd35d7317803e0446bdddc7c5afa1a317 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3723546 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov ef37e863 2022-06-27T11:18:49 Skip TextureSampleShadingTest.Basic on Win Intel Vulkan Bug: angleproject:7465 Change-Id: If1eff8d5f9ad9c159115c5a8ef7f4155c21e9615 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3726090 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Eddie Hatfield 89e38b57 2022-06-22T15:04:08 Refactor to use ANGLETest vs ANGLETestWithParam Bug: angleproject:6747 Change-Id: I72ad52d0268eae0e1a401f12f3e94cc5efa402f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719002 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Dan Glastonbury de109f9e 2022-06-23T11:50:43 Metal: Maintain BufferPool freelist constraint BufferPool needs to maintain the requirement of the free list that buffers in use by the GPU are stored in FIFO order and that after the first in-use buffer, the rest of the free list is in-use as well. Bug: angleproject:7453 Change-Id: Ibae45fb0212030217d03fe4623c412d693674fd1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3717663 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Eddie Hatfield 707323c1 2022-06-21T18:53:05 Miscellaneous C++17 refactoring Bug: angleproject:6747 Change-Id: I792ba74e03145ff6c3cc97d4bff6327ab275a2c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719001 Commit-Queue: Eddie Hatfield <eddiehatfield@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mohan Maiya ef60d38e 2022-06-21T12:05:28 Vulkan: Support EGL_ANDROID_front_buffer_auto_refresh Cache value of EGL_FRONT_BUFFER_AUTO_REFRESH_ANDROID attribute and set swapchain present mode accordingly when recreating swapchain in single buffer mode. Bug: angleproject:7224 Tests: EGLAndroidAutoRefreshTest.Basic* Change-Id: I2dbb92ce5c3fa047e0b02ea9011725311f346027 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707570 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Eddie Hatfield 7eb96f2a 2022-06-21T18:46:18 Refactor builtin symbol generation for C++17 Bug: angleproject:6747 Change-Id: I81a87b68298abc32fee7bb843c27a4a1b6009c87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719000 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Eddie Hatfield <eddiehatfield@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 4c5e9d47 2022-06-21T17:12:56 Do not defer clear if FBO attachment is AHB image When application uses Android Hardware Buffer (AHB) image as the Framebuffer Object (FBO) attachment, it is possible the app doesn't call glReadPixels to fetch the FBO color. In this case deferred clears will not be flushed when the app reads the FBO pixel color, and the app will read the old FBO color. This CL fixes the issue by flushing the glClear calls immediately when any of the FBO color attachments is AHB image. Bug: b/236394768 Bug: angleproject:7458 Change-Id: I9151ab57750007c4ac18af39c3fa4abe752ede5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715851 Reviewed-by: Lingfeng Yang <lfy@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll d3e4e9ee 2022-06-23T15:19:05 Roll vulkan-deps from 1765af41ecf5 to 11ad77222bfe (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1765af41ecf5..11ad77222bfe Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/99b59b3528..ba3e6ffe03 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9342a262d9..620b378993 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com,ynovikov@google.com Change-Id: Ifc00313898ec1cfd54fe59ecedb8025e8a000db4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720548 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 722c78b0 2022-06-23T19:16:59 Roll Chromium from 19706bf6c7d2 to 7f32e27c6969 (707 revisions) https://chromium.googlesource.com/chromium/src.git/+log/19706bf6c7d2..7f32e27c6969 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3a562c9e07..4dbf5904da * buildtools/linux64: git_revision:ae474cc51337c3fe823f936371c5e92891e86b48..git_revision:29accf5ac2eadfc53e687081583b7bc1592a8839 * buildtools/mac: git_revision:ae474cc51337c3fe823f936371c5e92891e86b48..git_revision:29accf5ac2eadfc53e687081583b7bc1592a8839 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/92ef8d47d0..b5f3d3b904 * buildtools/win: git_revision:ae474cc51337c3fe823f936371c5e92891e86b48..git_revision:29accf5ac2eadfc53e687081583b7bc1592a8839 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d4d70a4321..044213afe8 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/00f782bd3d..62a4d6866a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d44f2956da * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/39e4055004..1d5d7803fa * third_party/fuchsia-sdk/sdk: version:8.20220614.2.1..version:8.20220623.1.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/6fba7268ea..35de724cf2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f575df1ded..333646c3c0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1122520fc4..25de876ad0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2f10365a2a..eacae1e7ec Clang version changed llvmorg-15-init-13850-ge2913362:llvmorg-15-init-14188-g4dcb42fa Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/f575df1ded2c30161bca2ff5f90c1e0d6814625f..333646c3c0d7f0332f3d9ebd0bdf4081999f8b77/scripts/update.py Bug: angleproject:7455 Tbr: jonahr@google.com,ynovikov@google.com Change-Id: I132a7abada2e301a8e441c47a577650bd3852809 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720553 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 79185677 2022-06-22T16:22:35 Translator: Fix validation of struct with same-name struct field In the following: ``` struct S { S s; }; ``` The `S` in the field refers to a previous declaration of `S` in an outer scope. The validation code mistakenly attempted to ensure it refers to the same `S` being declared. Bug: chromium:1337628 Change-Id: I86184be63bc59e608fe5b24369cd4c40b3bb3b31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3716965 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e50351cb 2022-06-10T22:28:58 Vulkan: Don't close render pass on framebuffer fetch For applications that use framebuffer fetch in the same RP as non-fetch programs, we can save some extra RenderPasses by always creating our RP objects with input attachments enabled. This works almost identically except for needing to use the images in a "GENERAL" layout instead of "COLOR_ATTACHMENT_OPTIMAL". According to partners it is possible to achieve performance parity even with GENERAL layout. To remove any potential negative impacts of using the GENERAL layout, the context enters this always-framebuffer-fetch mode only and as soon as a framebuffer fetch program is created. Applications that don't use framebuffer fetch are thus unaffected. This eliminates 20 render passes in the Genshin Impact trace (out of about 58). On a Pixel 6 the resulting benchmark score speeds up by ~25%. For Real Racing 3, the speed up is ~30%. Based on change by jmadill@chromium.org Bug: angleproject:7375 Change-Id: Ib6c73e95d06229f8545d502b388ee2a55a582323 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697308 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Eddie Hatfield 91976352 2022-06-21T15:41:02 Use C++17 attributes instead of custom macros Bug: angleproject:6747 Change-Id: Iad6c7cd8a18d028e01da49b647c5d01af11e0522 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3718999 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 0779ccbc 2022-06-10T17:55:54 Vulkan: Destroy DescriptorSet cache when it becomes invalid When a new texture descriptorSet is allocated, we store one reference of the cache key in ProgramExecutableVk and all TextureVks that it associated with. When any of the TextureVk is destroyed or its view destroyed, we immediately erase the descriptorSet from the cache and track GPU progress and free the descriptorSet when it's GPU completed. That way we delete the dead descriptorSet that will for sure never been reused ASAP so that its space is avialable for reuse. Bug: b/235523746 Change-Id: Ib1b9662a254eea5a3f410dc6d5d89fca6727a647 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3700226 Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Brandon Schade 669d7b75 2022-05-25T15:14:35 Fix validation checks in glCompressedTexSubImage3D - Add missing ASTC formats to the checklist in CompressedSubTextureFormatRequiresExactSize. - Add missing validation checks in ValidateES3TexImageParametersBase relating to internal formats Test: KHR-GLES32.core.compressed_format.api.invalid_format_array Test: KHR-GLES32.core.compressed_format.api.invalid_offset_or_size Test: *ETC2RGB8_CubeMapValidation* Test: *CompressedTexture*Test* Bug: angleproject:6441 Change-Id: Icc80d78602ea997be11606587b43d29e72e48f3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3670768 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Kenneth Russell 338c6539 2022-06-22T10:22:22 Set pixel unpack state in GL backend's CompressedTexImage3D. A workaround added earlier wasn't applying to the GL backend because of this missing call. Covered by existing angle_end2end_test, but only reproduces on ASAN build. A Chromium-side test is being added separately. Bug: chromium:1335688 Change-Id: Ia33648054dfa647159ecfc62ca53415de04f625d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715717 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Frédéric Wang 97e0157a 2022-06-21T17:00:07 Fix compilation errors with deprecated sprintf function This commit modifies sprintf calls to fix the following compilation errors using XCode 14.0 beta on MacOS: > 'sprintf' is deprecated: This function is provided for > compatibility reasons only. Due to security concerns inherent > in the design of sprintf(3), it is highly recommended that you > use snprintf(3) instead. Bug: angleproject:7448 Change-Id: I2d72e09a1289a3746f457508c3dae9e922fe6b98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3721635 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Le Hoang Quyen 6c8bb1f3 2022-06-21T06:06:29 Metal: Fix invalid iosurface texture after base/max lvl changed Changing base/max lvl invalidated previously bound iosurface's texture. This caused conformance/canvas/webgl-to-2d-canvas.html failure. Fix by rebinding the iosurface's texture after base/max lvl changed. Bug: chromium:1337324 Change-Id: I28f84b0ac28695221997571f71c476e802cbfac3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3715729 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll 32cb5750 2022-06-23T10:01:56 Roll SwiftShader from 5cb6a639d494 to ec31f547750c (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/5cb6a639d494..ec31f547750c 2022-06-23 sugoi@google.com Fix stale SPIRV_SHADER_DBG statements 2022-06-23 sugoi@google.com Fix warning on Linux 2022-06-22 swiftshader.regress@gmail.com Regres: Update test lists @ 5cb6a639 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I7b00e1fb33c1031fe69099c1ba3a83f1410c5d13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720480 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 6d3c6370 2022-06-18T00:13:56 Vulkan: Fix 180 and 270 degree rotated resolve Bug: angleproject:7197 Bug: b/235877059 Change-Id: I4d4ee622f49bb3218449414a1f0dd91fa4e4f541 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708997 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Lubosz Sarnecki 72f69e84 2022-06-21T16:22:25 ANGLEPerfTest: Add option to disable GL debug callbacks. Disable GL debug callbacks on native ARM GLES1. This fixes native GLES1 replay on Pixel 6 when running debug builds. Bug: angleproject:7447 Change-Id: I0059c07f4f2fb944e54a5163863b487bc31ab28f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3716584 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Lubosz Sarnecki c93b3b32 2022-06-10T16:34:00 Tests: Add Animal Crossing trace. Test: angle_perftests --gtest_filter="*animal_crossing*" Bug: angleproject:7306 Change-Id: Ic19adff3915093d86d68f24a5be2c0d2124f2123 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697532 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Chris Dalton 329e1f9e 2022-06-04T02:30:56 Ensure pls results are secure even without barriers We can't guarantee the client will always use local storage barriers correctly, but we CAN guard local storage passes such that the results are only nondeterministic within predictable constraints. This CL adds a test to ensure local storage is still predictable without barriers, and that no data is random or leaked from other contexts. Bug: angleproject:7279 Bug: angleproject:7398 Change-Id: I70da58c8ba79b09f560315df3df956d1721ff6b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3654265 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Chris Dalton <chris@rive.app> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 21a07210 2022-06-22T16:43:44 Suppress 3 pointcoord tests on Mac Intel Metal Bug: angleproject:7451 Change-Id: Id03e3a60aca38798ecaec4a74f0b0af64eecc63e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3714602 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0