kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll c2aa8b58 2023-03-09T10:01:24 Roll SwiftShader from 0ba0b45490cd to 3764eb85917a (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/0ba0b45490cd..3764eb85917a 2023-03-07 ossu@google.com Fix vkWaitSemaphores when VK_SEMAPHORE_WAIT_ANY_BIT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I6dbe95243fb3f84113af6a0554ac9eadd7a34993 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4323777 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 475025e3 2023-03-09T07:00:31 Roll Chromium from 52ec1cb28f1b to a811a4fbb723 (335 revisions) https://chromium.googlesource.com/chromium/src.git/+log/52ec1cb28f1b..a811a4fbb723 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1185a77c82..80a7bc6cb0 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c86761b030..55fa81c88a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/764c1fa4e4..2d94ed0895 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2da767c6c1 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d4c6cbeb61..2f5bdd5aea * third_party/fuchsia-sdk/sdk: version:12.20230308.2.1..version:12.20230308.3.1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f6ecbe5ac2..0e2c22bd54 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/12d39d4fd8..6bc78c3c28 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I20a5e3dff94ba6eaca97329a6602fb6e333d7870 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4322398 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Dan Glastonbury aa5b97de 2023-03-06T17:59:43 ANGLE_metal_shared_event_sync: Control signaling external events It was assumed that the external MTLSharedEvent passed to eglCreateSync should be signaled by the GL. This change adds EGL_SYNC_METAL_SHARED_EVENT_SIGNALED_ANGLE, which when passed as the value for EGL_SYNC_CONDITION during eglCreateSync, changes the behavior to not insert a fence command into the command stream. Test: angle_end2end_tests --gtest_filter=EGLSyncTestMetalSharedEvent.AngleMetalSharedEventSync_WaitSync_ExternallySignaled Bug: angleproject:8064 Change-Id: Ia1b8615b976f293d411b7d2be506b0ac87d64dee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4307152 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cody Northrop b78a0c49 2023-03-08T09:49:28 Tests: Add Street Fighter: Duel trace Test: angle_trace_tests --gtest_filter="*street_fighter_duel*" Bug: b/271876811 Change-Id: I9930169c046e9b86bfac0b27c5286e1241e34601 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4320445 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mike Schuchardt f1717ba9 2023-03-08T08:59:25 Tests: Add Merge Dragons trace Test: angle_trace_tests --gtest_filter=TraceTest.merge_dragons Bug: b/272197630 Change-Id: I786ad03bf38b9d3269644bb0038d9848035b0f5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4321866 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mike Schuchardt <mikes@lunarg.com>
Roman Lavrov 2c835845 2023-03-08T16:51:14 Fix race condition in ProgramUseAndDestroyInTwoContexts thread0 and thread1 call threadSynchronization.waitForStep(Step::Start) but then thread0 does threadSynchronization.nextStep(Step::Thread0CreatePrograms); so if thread0 happens to run to this line before thread1 gets to waitForStep(Step::Start), thread1 gets blocked forever Bug: angleproject:8071 Change-Id: Ida4773d5d196f3e64e14689a8f6f16dc9ca3b509 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4321809 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 0cb09074 2023-03-08T19:18:22 Manual roll Chromium from 4d26ea50cec7 to 52ec1cb28f1b (235 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/4d26ea50cec7..52ec1cb28f1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/984f82d89c..1185a77c82 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c20dc6aaed..2cdfeaa2d0 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e136ec5032..3cf0fe4445 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e943c1ba28..764c1fa4e4 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/28c6deacab..6b9c63c69a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2da767c6c1 * third_party/fuchsia-sdk/sdk: version:11.20230307.3.1..version:12.20230308.2.1 * third_party/kotlin_stdlib: Mg7371mEUwDQH4_z29HdWqYWVlXN6t2dXX0kIutg_SwC..zeFlVAEGvnpaj3JJujWHzRlUiBEm4XeeaMQzVsdW6D4C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2a70735180..ef1eb208a2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7ee68c5321..12d39d4fd8 No update to Clang. Bug: None Tbr: romanl@google.com,ynovikov@google.com Change-Id: I0d0010c35b9692a3726ccf7871376199b188662d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4321865 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 52ba6071 2023-03-06T00:00:00 Add EXT_texture_filter_minmax stubs Bug: angleproject:8072 Change-Id: Idfc2f2ff0eff7b0f6c131c37aeb53fb04019257d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4315865 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 397f89dc 2023-03-01T00:00:00 Support stencil texturing in WebGL Updated WebGL sampler format validation to support sampling from stencil textures and combined depth/stencil textures in stencil mode. Bug: angleproject:3231 Bug: angleproject:8051 Change-Id: Ib35dfd91f7ce77fc50bd749f49602ffe86837c67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4315864 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Igor Nazarov e6ac77d9 2023-02-27T16:13:29 Tests: Enable RunLockStepThreads OpenGL/GLES backend support. Added "EGL_CONTEXT_VIRTUALIZATION_GROUP_ANGLE" attribute if display has "EGL_ANGLE_context_virtualization" extension enabled. Bug: angleproject:8032 Change-Id: I482475950b9d8d63891c74fc832cc13d93921e21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4291436 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Igor Nazarov 244e1931 2023-01-17T19:22:10 Vulkan: Fix use of pending Outside RenderPass CommandBuffer. Regression from this commit: 730c127102b540ce2c4ec086b037c8b732706e26 "Vulkan: Submit queue more often for texture data" Bug: angleproject:6354 Test: angle_end2end_tests --gtest_filter=*SubmittingOutsideCommandBufferAssertIsOpen* Change-Id: I5f72f499cd7153c94c8e5f8a3415df2182726c8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296802 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll bfa2fe36 2023-03-08T10:01:43 Roll vulkan-deps from eca4b370b5aa to fb9155b074e3 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/eca4b370b5aa..fb9155b074e3 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3033cf428e..690a9a4060 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3db19f3e3d..e4895e86f7 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/847b09025f..b5e47d22c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ic817e94610404d1de63b624872eca6b2204ba8e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4317957 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1023c18f 2023-03-08T07:28:19 Roll Chromium from 2821f7bf7cf2 to 4d26ea50cec7 (587 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2821f7bf7cf2..4d26ea50cec7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fabcecef46..984f82d89c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e8606bdcca..e943c1ba28 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2da767c6c1 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2cbe95c7c8..d4c6cbeb61 * third_party/fuchsia-sdk/sdk: version:11.20230307.0.1..version:11.20230307.3.1 * third_party/r8: mRUkTlTS7E_w8qjT2TecH9YczFjvU8P_d3NFdrM3kygC..dapol0ILZtTgGEQGfNsvmcFZMjD56XbJH5eo7kG0lAMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/72c1f3e0e8..2a70735180 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e655e0b2d5..f6ecbe5ac2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c5750fd314..7ee68c5321 * tools/skia_goldctl/linux: bLGZaTfxaQn13OKJRrAdm408JOt4CwR_Whnp7PotYCUC..uu72l9rwYReKqlKTHTUE26N6gMAt6YHvdysfn6rcAvgC * tools/skia_goldctl/mac_amd64: yj8Sf8C8Ow0HPFCcDzmiBKT8HYzDbzTJWPCqp7V9fdAC..EPIsKRgwINCn8DCzCmRC1ZH3EivSehuq2ymx_qN6MhMC * tools/skia_goldctl/mac_arm64: hRXH9mU2WXp1Fs7FPeLbgvJ_Cbn7oG_dbBgTvxTyEdAC..NcrJgtTlI-mdqmPTl4LBprsY9nhx_5nzK08RLKJG9CAC * tools/skia_goldctl/win: UsXhImRO65quoDjrqQKVTUF3roXPJlI0dNN8xWU7COAC..DxsfuVWQrwfkUxTCKXzhO_Wh4OYOLWM-sSQpfx92DxwC No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I0048106821d3adae5e50f6bb20bdb4fe87feee27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4316180 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton a65f6a9d 2023-03-07T16:11:44 Make PLS queries robust There's no reason not to mirror the ANGLE_robust_client_memory API here. Bug: chromium:1421437 Change-Id: Ifb8b1a9675abe2ceb35272dc905f3c38f29dceda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4317485 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Mark Lobodzinski 2143c146 2023-03-06T14:38:58 Tests: Add Jackpot World Trace Test: angle_trace_tests --gtest_filter=TraceTest.jackpot_world bug: b/271891383 Change-Id: Ib0ff8197c98c8dc7e97e760968306a6c1d3c5878 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4313680 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi 156efe9e 2023-02-23T14:07:23 Fix the alloc error with enabled backtrace feature When angle_enable_unwind_backtrace_support is enabled, an assertion occurs on memory allocation with the following message: "constructed value does not match the lookup key" The assertion comes from PolicyTraits::apply() in the hash map. * In MemoryTracking.h, the type of mMemoryAllocationRecord is now std::unordered_map instead of angle::HashMap. Bug: b/262029018 Change-Id: I11a6d8e99a129759c046e37cef9e74f7db193066 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4289947 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi b0d99f72 2023-02-22T13:48:16 Move the memory tracking classes to new files * Moved the classes, functions, and constants related to memory tracking to MemoryTracking.h and MemoryTracking.cpp. Main classes include the following: * MemoryAllocationTracker * MemoryReport * MemoryAllocationType * MemoryAllocationInfo * MemoryLogSeverity * New static function added in RendererVk to get the Vulkan object type name (GetVulkanObjectTypeName()). Bug: b/262029018 Change-Id: I619001e3c24114c4fe7bf024498338bce146fced Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4284639 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Saifuddin Hitawala 877cd04c 2023-03-02T10:24:14 Reland "Add vulkan format image fallback for R16G16B16" Suppressed misbehaving trace test in https://crrev.com/c/4317088 This is a reland of commit 71f6d54c8d3662693283281651e57c994a10cf08 Original change's description: > Add vulkan format image fallback for R16G16B16 > > This change adds a vulkan format image mapping fallback from R16G16B16 > to R16G16B16A16, R32G32B32_FLOAT and R32G32B32A32_FLOAT for both > UNORM and SNORM variants. > > This is done because in Chrome we want to use R16/RG16 formats which > are exposed to Skia over the EXT_texture_norm16. Currently, > EXT_texture_norm16 requires RGB16_EXT which if not present is not > supported even if R16_EXT and RG16_EXT are supported. This fallback > helps us support R16/RG16 as well over RGBA16. > > It also updates validationES checks for GL_RGBA signed and unsigned > normalized checking if type is GL_SHORT or GL_UNSIGNED_SHORT. > > It adds a method LoadToFloat that allows a type (GLushort or GLshort) > to be loaded into float format types. This is then used as part of > fallbacks for load_functions_data.json. > > Bug: None > Change-Id: I5c6879cd2ed5dd6e3440877f4891f269d96d88a1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4294694 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: None Change-Id: I101dd9e8c62e6794692c9f89c4944297e195f710 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4317089 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Gert Wollny bd08c309 2023-02-20T08:17:31 Capture/Replay: Don't serialize shader refcount with context The shader and program reference count is not an OpenGL state, it is only an implementation dependent value and should, therefore, not be part of the context serialization. In fact, it is actually misleading, because for shared contexts its value depends on the state of all contexts and not just the current one. Especially with MEC this may lead to validation errors, because a sequence Context 1 (shared): create program A Context 2: use program A -> start MEC will result in a refcount of "1" when the state of context 1 is serialized during MEC startup, because at this time context 2 already holds a reference. However, when the valiation checkpoint at the end of the setup for context 1 is executed during replay, then the setup for context 2 has not yet been run and the refcount will be "0". Bug: angleproject:8029 Change-Id: Ia7236e5f35634ba1506117abc19efa94b816e572 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4270930 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov cf1bf3e4 2023-03-07T18:41:13 Skip TextureNorm16R16RenderTest and variants Replay corrupts memory by writing past readBufferSize due to GL_PACK_SKIP_ROWS etc Bug: angleproject:8070 Change-Id: I7db1ef9dadf3735841c96f242e9bd9a993b5d16e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4317088 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 1174582a 2023-03-06T00:00:00 GL: Implement EXT_clip_control The extension is trivially exposed if the current context supports it. * Added packed clip control enums * Removed unused state query code * Aligned symbol names with the specs Bug: angleproject:8066 Change-Id: I9d106f39800658ecc75f4525ee93cb534dc49f9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4306770 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 56259f30 2023-03-07T17:28:50 Manual roll vulkan-deps from 5d7ca659e804 to eca4b370b5aa (34 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/5d7ca659e804..eca4b370b5aa Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/9cdfc5a511..204812694c * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/aa331ab0ff..295cf5fb3b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9d71fb6764..3033cf428e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b8eae8a7c8..847b09025f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I3badcd14bbd5ac01d8894472e6a9a62f4a2fa414 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4316603 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Igor Nazarov ad7949c6 2023-01-17T19:24:59 Vulkan: Remove "rx::vk::ImageHelper" move constructor. Move constructor was only used in the "rx::SwapchainImage" structure. This CL replaces "image" member with "std::unique_ptr<vk::ImageHelper>". This will remove source of bugs. Bug: angleproject:8052 Change-Id: Ic16f674095233baaa56fbe8a8fb7ef3e323a7331 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4294905 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Alexey Knyazev 815a4aae 2023-03-01T00:00:00 Fix stencil format exposure * Removed invalid STENCIL format table entry * Removed incorrect OpenGL ES 2.0 validation * Removed obsolete end2end test suppressions * Hid GL_OES_texture_stencil8 from ES 2.0 contexts * Marked unsized STENCIL_INDEX as never texturable * Marked unsized STENCIL_INDEX as never renderable Bug: angleproject:3231 Fixed: angleproject:5136 Change-Id: I3f2cb8240344db410773b6a5bde460a43eb32a2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4307120 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Igor Nazarov 267c556e 2023-03-06T18:03:36 Vulkan: Move PersistentCommandPool out of the CommandsState. Refactoring before the actual fix. Bug: angleproject:8039 Change-Id: Ib240cb9a2e9b92eab120c946b15ac285b939c7db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4307875 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll b84737c1 2023-03-07T14:08:00 Roll VK-GL-CTS from 49ce61395065 to 4ac540bc62cf (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/49ce61395065..4ac540bc62cf 2023-03-07 alexander.galazin@imgtec.com Notice of withdrawal of Vulkan SC CTS 1.0.0.x If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I793997cdee81c84ad49514d933d88d479b31c90b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4315382 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 8abf7153 2023-03-01T00:00:00 GL: Complete EXT_blend_func_extended * Increased test threshold to 2 to avoid failures on some GPUs * Skipped desktop name bindings when running on OpenGL ES * Adjusted extension exposure conditions to avoid failures on older platforms * Adjusted webgl_FragData array size Bug: angleproject:1085 Bug: angleproject:2833 Change-Id: Ic72ba42b024de276d3586446e03013e6063d15ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4307122 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Igor Nazarov ac8513fa 2023-03-03T16:10:32 Vulkan: Add and use ScopedQueueSerialIndex helper class. This is a follow up for CL: eb0475c05425d94a4516b708c1c9075e3bc423a7 Vulkan: Cleanup RendererVk::allocateQueueSerialIndex method. Made private "allocateQueueSerialIndex(SerialIndex *)" method and renamed to "allocateQueueSerialIndexImpl" to limit incorrect API usage. Bug: b/267806287 Change-Id: I4d1a9875d454c29f930a5e844161d2a10dc2675b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4306720 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 4256c022 2023-03-01T00:00:00 Metal: Implement ANGLE_stencil_texturing Used texture views to sample stencil values from combined depth/stencil textures. Texture2DDepthStencilTestES3.TexSampleModes* tests were split into swizzled and non-swizzled variants to suppress only swizzled cases on some platforms. Added a new avoidStencilTextureSwizzle workaround to skip creating swizzled texture views of stencil-only textures on platforms that fail to sample from them. Fixed: angleproject:8051 Change-Id: I0b1148f8d30fc6459239efcdaeee6c0364633cc8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4304058 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov b3178411 2023-03-07T15:08:46 Revert "Add vulkan format image fallback for R16G16B16" This reverts commit 71f6d54c8d3662693283281651e57c994a10cf08. Reason for revert: crashing win-trace https://ci.chromium.org/ui/p/angle/builders/ci/win-trace/3527/overview Also reproducible on Linux: % src/tests/capture_replay_tests.py --gtest_filter="Texture2DNorm16TestES3.TextureNorm16R16 Original change's description: > Add vulkan format image fallback for R16G16B16 > > This change adds a vulkan format image mapping fallback from R16G16B16 > to R16G16B16A16, R32G32B32_FLOAT and R32G32B32A32_FLOAT for both > UNORM and SNORM variants. > > This is done because in Chrome we want to use R16/RG16 formats which > are exposed to Skia over the EXT_texture_norm16. Currently, > EXT_texture_norm16 requires RGB16_EXT which if not present is not > supported even if R16_EXT and RG16_EXT are supported. This fallback > helps us support R16/RG16 as well over RGBA16. > > It also updates validationES checks for GL_RGBA signed and unsigned > normalized checking if type is GL_SHORT or GL_UNSIGNED_SHORT. > > It adds a method LoadToFloat that allows a type (GLushort or GLshort) > to be loaded into float format types. This is then used as part of > fallbacks for load_functions_data.json. > > Bug: None > Change-Id: I5c6879cd2ed5dd6e3440877f4891f269d96d88a1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4294694 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: None Change-Id: I8373aee3a1d2c2279a3882ff7203d88483e29f4e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4316422 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 01d78586 2023-03-07T09:41:10 Roll Chromium from 868e24501649 to 2821f7bf7cf2 (569 revisions) https://chromium.googlesource.com/chromium/src.git/+log/868e24501649..2821f7bf7cf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ccb49e8018..fabcecef46 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b66292cfac..c20dc6aaed * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/49c1b48fc5..e136ec5032 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/cff1f2def8..c86761b030 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/7b03cc568d..d101cb5933 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ed811b1a53..e8606bdcca * third_party/android_build_tools/lint: NrP_GizJsQ_kr9O0WQlncRx1xdicjU4BFHi9pLPeTSIC.._XhNBPsSXTzuwyrRGz4aM29jhQdbk2f-KPyVyhmYHwAC * third_party/android_build_tools/manifest_merger: saMCpz15quEEWToMloh-A_rMqC0WSdJlyYTFvwAd840C..-MEtSi1dPRGwJdR_aJbVAJ75_Kb8QMDJXBXrRIQlO70C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/58c60a8997..f433915516 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c4b5fb350b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b4b22453f3..2cbe95c7c8 * third_party/fuchsia-sdk/sdk: version:11.20230303.4.1..version:11.20230307.0.1 * third_party/r8: zT9mfajcm9pyKVWq6l9s8cGITXxjeL90Zrw18CwIUusC..mRUkTlTS7E_w8qjT2TecH9YczFjvU8P_d3NFdrM3kygC * third_party/turbine: YQC-btuan_DTe9V9dv_e1LxgYSWeOoDfrd-VSqzIvHkC..epnqx7Yf9QxgyDaU87KJ1fLQvdZ_Mho_JjfpjmIBYWYC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/64e9f9321c..72c1f3e0e8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df4de5b4f6..e655e0b2d5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/650d0f0bf2..c5750fd314 Clang version changed llvmorg-17-init-3170-g6e30dffe:llvmorg-17-init-3874-g93a2fecc Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/64e9f9321c450d938fec79ef8e4431fd1a08f5ce..72c1f3e0e850a48f634c8e96a0d1f84b331660cc/scripts/update.py Bug: angleproject:8067 Tbr: romanl@google.com Change-Id: I7b4da9b26416897960121a6efe7da8cf09d420fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4314564 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny a8ba5112 2023-02-10T10:04:41 Capture/Replay: Deal with swap called in different contexts Move recording the context setup of the main context to the same location where all other context setups are recorded and drop the assertion that checks that swap is always called from the same context. Invoke the context setup at the time the secondary contexts are set up, and make sure the main context is correctly mapped. Bug: angleproject:7911 Change-Id: I327bce318b1a0e26ffdbf096343f99cedd78c116 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4236541 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Gert Wollny 4448ce5c 2023-02-09T17:48:40 Capture/Replay: Add fixture SetCurrentContextID This is needed for better context handling Bug: angleproject:7911 Change-Id: Ieccb0f9660a8d607fe2bcee87b7a9b4ff2e25a50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4236543 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Trevor Black <vantablack@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
Gert Wollny 0e9b8f36 2023-02-08T13:39:09 Capture/Replay: Drop context ID from file and frame func names This is needed when we want to be able to deal with swap called from different contexts. Bug: angleproject:7911 Change-Id: I83023308109852179f434be2290b33b7844ddcda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4236540 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi cee1237c 2023-03-06T15:39:03 Vulkan: Fix reserved UBOs for default uniforms Only 3 were reserved, which is not correct with tessellation support included. The limit is now adjusted based on whether geometry and/or tessellation is supported. Bug: angleproject:6858 Change-Id: I7530a60b4b6bc9d4f4561303615c52c63bab1045 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4312559 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 868b63ab 2023-03-06T15:21:25 Vulkan: Remove reserved UBO for driver uniforms from limits ANGLE no longer uses UBO for driver uniforms, but uses push constants instead. Bug: angleproject:6858 Change-Id: I3e01c75a19bb333428f2dd1cd732022f1e740c4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4306885 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 991fca06 2023-03-06T10:31:48 Vulkan: Minor clean up in CommandProcessor.cpp Minor clean up per the feedback from already merged CLs. Bug: b/255411748 Change-Id: I3d0148700cf79fa597e260e7192d419198f9749f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4311756 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 5331491b 2023-03-06T17:26:30 SYNC-HAZARD-READ-AFTER-WRITE: VkNonDispatchableHandle on x86 Also link to the new bug. Bug: angleproject:8054 Change-Id: I2421d625f64a2530768ea35497a45091a0317025 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4312523 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Charlie Lao 5b63e1dc 2023-02-03T15:14:00 Vulkan: SurfaceVk should only wait for GPU work that uses it Right now when we destroy swapchain, we call mRenderer->finish() to finish everything, even though the work is unrelated to this surface. This CL changes it to only wait for ResourceUse of all images in the swapChain. Bug: b/267806287 Change-Id: I33d136ad50961fbf5fbb200ff0f89f1dbf23585d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4220723 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Roman Lavrov 569a881f 2023-03-06T16:43:18 Make SYNC-HAZARD-READ-AFTER-WRITE case less specific. SYNC_VERTEX_SHADER_SHADER_STORAGE_READ added in https://crrev.com/c/4306772 Different prior_usage in TransformFeedbackTest Bug: angleproject:8054 Change-Id: Ia79fc0edd52dff49255906158a5621d4860d7df5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4313319 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov 8ba78abd 2023-02-28T11:16:08 Reland "MSRTSS uses AppendToPNextChain due to non-NULL pNext." Also fix msrtss->pNext being set to a pointer to a pointer (void* yay!) This is a reland of commit 33df630f9c8944061902b2e38fe65b280f731802 Original change's description: > MSRTSS uses AppendToPNextChain due to non-NULL pNext. > > As discussed in: > https://chromium-review.googlesource.com/c/angle/angle/+/4116675/comment/3097cb31_16922d39/ > > Not currently causing issues as it requires very recent drivers but I > saw the `ASSERT(ptr->pNext == nullptr);` in AddToPNextChain fail > somewhere. > > Bug: angleproject:7899 > Change-Id: Id46162a5aacd3d8599382ce1dfca25aca5e730e1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296801 > Auto-Submit: Roman Lavrov <romanl@google.com> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:7899 Change-Id: I597b6633123f161e05e1a5a28b2e8c6c61835e29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4306827 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov dbece66f 2023-01-17T19:25:24 Vulkan: Fix move constructor/assignment of Resource classes. Bug in "DynamicallyGrowingPool<Pool>::PoolResource" causes real problems with queries. "QueryPool" may be reused without waiting for the previous use. Bugs "QueryHelper" may affect "mInFlightGpuEventQueries" (not used in "QueryVk"). Updated "FramebufferHelper" move assignment so it uses "Resource" assignment instead of protected member access. Bug: angleproject:8053 Change-Id: I441b62102fcf232456027fb42eefa97ed8958676 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300050 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Charlie Lao 7eb6869a 2022-08-30T16:28:08 Vulkan: Change ResourceAccess::Write to ResourceAccess::ReadWrite AS a preparation for the next CL which will optimize for WriteOnly access, this CL changes Write to ReadWrite and adds WriteOnly access (but not used yet). Mechanical changes only and no function difference is expected. Bug: b/243711628 Change-Id: I509d6045ae87635e24076b646af42f35d88d52cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3866672 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Igor Nazarov 4f87f4e9 2023-03-03T13:19:09 Vulkan: Add useResetCommandBufferBitForSecondaryPools feature. Currently ANGLE does not use "vkResetCommandBuffer()" on Vulkan Secondary Command Buffers. Instead it uses "vkFreeCommandBuffers()" and "vkAllocateCommandBuffers". According to spec, "VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT" is required only for command buffer reset operations. However, some ARM drivers may not free memory in "vkFreeCommandBuffers()" without this flag. Bug: angleproject:8059 Change-Id: Ibfe45bca345dc48484b625c450369d30805cec77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4306722 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Igor Nazarov 0eea2893 2023-03-03T18:55:21 Vulkan: Use *_POOL_CREATE_TRANSIENT_BIT in OneOffCommandPool Bug: angleproject:8061 Change-Id: Ib1f851e83e681ee369cac8da0ff52cd3951c5749 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4306724 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov 390fa116 2023-03-06T10:51:24 Suppress another SYNC-HAZARD-READ-AFTER-WRITE case. Starts at: https://github.com/KhronosGroup/Vulkan-ValidationLayers/commit/dd401219bdb982046bb235160c29643c597d6f16 --gtest_filter='MemoryBarrierBufferTest.TransformFeedbackBitWriteThenCapture/ES3_1_Vulkan_SwiftShader*' Bug: angleproject:8054 Change-Id: Ie57665a757c6664a29d351d43fbad9e4743b57f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4306772 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Saifuddin Hitawala 71f6d54c 2023-03-02T10:24:14 Add vulkan format image fallback for R16G16B16 This change adds a vulkan format image mapping fallback from R16G16B16 to R16G16B16A16, R32G32B32_FLOAT and R32G32B32A32_FLOAT for both UNORM and SNORM variants. This is done because in Chrome we want to use R16/RG16 formats which are exposed to Skia over the EXT_texture_norm16. Currently, EXT_texture_norm16 requires RGB16_EXT which if not present is not supported even if R16_EXT and RG16_EXT are supported. This fallback helps us support R16/RG16 as well over RGBA16. It also updates validationES checks for GL_RGBA signed and unsigned normalized checking if type is GL_SHORT or GL_UNSIGNED_SHORT. It adds a method LoadToFloat that allows a type (GLushort or GLshort) to be loaded into float format types. This is then used as part of fallbacks for load_functions_data.json. Bug: None Change-Id: I5c6879cd2ed5dd6e3440877f4891f269d96d88a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4294694 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Igor Nazarov fee173f9 2023-01-17T18:45:41 Vulkan: Fix freeing Command Buffers with wrong Pool. Problem: - Multiple Contexts flushes it's commands to the Primary Command buffer; - Secondary Command Buffers from all Contexts end-up in the single "CommandBufferRecycler::mSecondaryCommandBuffersToReset" list; - One of the Contexts submits all these commands, and attaches it's "VkCommandPool" to the "CommandBatch". - This "VkCommandPool" will be used to free "VkCommandBuffer"s from all Contexts and pools. Fix: - Attaching "VkCommandPool" to each "VulkanSecondaryCommandBuffer" instance. - "vkFreeCommandBuffers()" is called from the new "VulkanSecondaryCommandBuffer::free()" method. Bug: angleproject:6100 Change-Id: Ic4d66d8b0f71e5ff06047004ed21428d6dce385b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300870 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Cody Northrop 06aaa0c0 2023-03-05T17:40:38 Tests: Add Harry Potter: Hogwarts Mystery trace Test: angle_trace_tests --gtest_filter="*harry_potter_hogwarts_mystery*" Bug: b/271766619 Change-Id: I3efffb191b97b5fcc4d1d0626cba2127a309d157 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4311481 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Igor Nazarov 24eb3fcf 2023-01-17T19:26:49 Vulkan: Condition in "collectGarbage()" replaced with "ASSERT". Very minor optimization. Most places already check for empty garbage before calling "RendererVK::collectGarbage()". Added missing check into "ContextVk::submitCommands()". Bug: None Change-Id: Ie2660b4cc413e17c4b6ba39c0711745e9f48d70d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300052 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 957bb8f5 2023-03-06T12:26:40 Roll VK-GL-CTS from 04e5d38379bd to 49ce61395065 (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/04e5d38379bd..49ce61395065 2023-03-06 gleese@broadcom.com Simplify descriptor_indexing test binding usage 2023-03-06 rgarcia@igalia.com Test alphaToCoverage with depth, stencil or sample mask exports 2023-03-06 rgarcia@igalia.com Test all dynamic color blend states simultaneously 2023-03-03 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2023-03-03 rgarcia@igalia.com Convert ray gen. robustness tests from NV to KHR 2023-03-03 marcin.zajac@mobica.com Acceleration structure updates 2023-03-03 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.5 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia96381d7a935a747c66bc8fcf79e7ae209491a04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4311748 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3105ca09 2023-03-06T07:00:50 Roll Chromium from 1ad22b27f996 to 868e24501649 (579 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1ad22b27f996..868e24501649 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bdadc3003b..ccb49e8018 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e0c6f981d5..b66292cfac * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2213f1846f..49c1b48fc5 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ff8e691cbc..cff1f2def8 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c5e861c7b4..7b03cc568d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/235da77944..ed811b1a53 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/344f5518bf..58c60a8997 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5b6fd28397 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1fc4378acc..b4b22453f3 * third_party/fuchsia-sdk/sdk: version:11.20230303.1.1..version:11.20230303.4.1 * third_party/r8: I0UuO9JN5nvsk_NBcrLoDugx0jHvHvmqp-hBSM9DvLgC..zT9mfajcm9pyKVWq6l9s8cGITXxjeL90Zrw18CwIUusC * tools/luci-go: git_revision:67696c7e93f9dbf03f7bcf7f8fafe9c5728e1ebe..git_revision:e260f2e6d3531f534378dd1017e140374ba8df48 * tools/luci-go: git_revision:67696c7e93f9dbf03f7bcf7f8fafe9c5728e1ebe..git_revision:e260f2e6d3531f534378dd1017e140374ba8df48 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4e96219dca..650d0f0bf2 * tools/skia_goldctl/linux: CJ4GdxYYG3v_NJn3Wlkh0THbvMsigwNH76hC9E-vfG0C..bLGZaTfxaQn13OKJRrAdm408JOt4CwR_Whnp7PotYCUC * tools/skia_goldctl/mac_amd64: DcfjZ6EhCOk0P7xz4rYDWoj14bHQsuZW8aKIGQnVB44C..yj8Sf8C8Ow0HPFCcDzmiBKT8HYzDbzTJWPCqp7V9fdAC * tools/skia_goldctl/mac_arm64: pAgE9V5S1KE5SuFadTLlVQ5yHfCm2OjtbEKyuzo2xdsC..hRXH9mU2WXp1Fs7FPeLbgvJ_Cbn7oG_dbBgTvxTyEdAC * tools/skia_goldctl/win: Yt2iV6sDnXhLYyn1QpkZ06DAg-yY1Eedw90iVDOvgwAC..UsXhImRO65quoDjrqQKVTUF3roXPJlI0dNN8xWU7COAC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I86cc8cef77555970305ad79d36c7b1706a38691e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4311746 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 3aa64876 2023-03-06T04:17:57 Revert "Vulkan: Attempt to fix the tsan complain regarding volk." This reverts commit 62e5870452e1e2d4a55ee1307ada27b101d89dbf. Reason for revert: Suspected to be causing the win-trace bot flakiness (https://anglebug.com/8063) Original change's description: > Vulkan: Attempt to fix the tsan complain regarding volk. > > In certain cases, I am seeing volk function pointer been set while it is > still being accessed. See > https://chromium-swarm.appspot.com/task?id=60b37aa811f8b410. My guess it > is related to some tests configs that end up with RendererVk gets > initialized while other instance is still running. This is attempt to > fix the tsan complain by only load volk function pointer if needed. > > Bug: angleproject:8055 > Change-Id: I5dcc62876bf93a250080de1f8e1b97d2b7570ab8 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300072 > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: angleproject:8055 Change-Id: Ie9fe707113656bcc803aacbf9559671564944b69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4309928 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Chris Dalton 51ddcabf 2023-03-02T17:52:46 Enable pixel local storage by default We're ready to start hooking this extension up in Chrome. Bug: angleproject:7279 Change-Id: I5cb887a6641aa61c2da0dfcc24d2195cf0494f20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4305361 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Roman Lavrov 8a9ed265 2023-03-03T18:01:09 Call XFlush after XDestroyWindow. A second gold test crashes in a flaky manner in some of the gold test batches. Possibly another destroy/create race. This CL seems to fix my repro (with gold patched out) and presubmit passed too (though it's flaky) Bug: angleproject:8060 Change-Id: I7641cea801cf0e0df48bf2aac8ef132f54e025b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4307695 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov 84644dd3 2023-03-03T12:30:35 Improve logging to make batch failures more clear. When logging suddenly interrupts it's hard to tell what's going on (see bug) Bug: angleproject:8060 Change-Id: I83c33818d79e442956045772913c6418ac705466 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4307774 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Peng Huang d9fa5524 2023-03-01T12:11:06 Temporarily disable multisampled render to texture on Android Using MSRTT causes rendering issues on Android. So disable it temporarily until it is fixed. Bug: chromium:1417485 Change-Id: I0def01f257a303b315ba333917d820cea44cd8a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300729 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Charlie Lao 256e7d6d 2023-03-02T13:23:11 Vulkan: Always checkCompletedCommands from finishResourceUse There is one difference in crrev.com/c/4244823, that before the CL, we always check every command to see if it finished or not. After the CL, we stop as soon as we find ResourceUse is finished. This CL gets back old behavior to help speed up garbage collection. Bug: chromium:1420669 Change-Id: I6bf833bd3347ee683b6b9d78628ac9618845c9e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4304802 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Igor Nazarov 764cdbad 2023-01-25T18:25:57 Vulkan: Add missing mutex lock into resetCommandBuffer(). Regression after the commit: 77d19e39794cc2de28f33a714f27af5a7de128ae Vulkan: Add ThreadSafeCommandQueue class Bug: b/261106868 Change-Id: I083b1bdc42a1382d32ab9087c92adbb963ff7d1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300869 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Roman Lavrov a2a30eac 2023-03-03T14:41:39 Revert "MSRTSS uses AppendToPNextChain due to non-NULL pNext." This reverts commit 33df630f9c8944061902b2e38fe65b280f731802. Reason for revert: appears to crash angle_CtsSkQPTestCases_internal_main_presubmit on panther-userdebug https://r.android.com/2466997 Original change's description: > MSRTSS uses AppendToPNextChain due to non-NULL pNext. > > As discussed in: > https://chromium-review.googlesource.com/c/angle/angle/+/4116675/comment/3097cb31_16922d39/ > > Not currently causing issues as it requires very recent drivers but I > saw the `ASSERT(ptr->pNext == nullptr);` in AddToPNextChain fail > somewhere. > > Bug: angleproject:7899 > Change-Id: Id46162a5aacd3d8599382ce1dfca25aca5e730e1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296801 > Auto-Submit: Roman Lavrov <romanl@google.com> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:7899 Change-Id: Ib59bee567b4249077b67f52dcf763d55dc9a7811 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4307769 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 6967b40e 2023-03-03T09:32:06 Roll Chromium from 051119636a02 to 1ad22b27f996 (594 revisions) https://chromium.googlesource.com/chromium/src.git/+log/051119636a02..1ad22b27f996 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ff22f91e3b..bdadc3003b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2512e92cc4..e0c6f981d5 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/f8109050ec..2213f1846f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b5e5cc8b48..235da77944 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..dabfa7bf23 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/56a18a86fe..1fc4378acc * third_party/fuchsia-sdk/sdk: version:11.20230301.3.1..version:11.20230303.1.1 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/0b6e6a1522..aa4075f116 * third_party/r8: larGcS88hqCbkUMuwF9pf72G_5IkYPBu87ltJ5Pbgt8C..I0UuO9JN5nvsk_NBcrLoDugx0jHvHvmqp-hBSM9DvLgC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/697c297330..64e9f9321c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/243f1b198e..df4de5b4f6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/501367a46c..4e96219dca No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I42af151c4f29e3ee53dbe183f1c228c661b7cc6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4306525 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 3fed0866 2023-02-22T00:00:00 Implement EXT_texture_mirror_clamp_to_edge Support GL_MIRROR_CLAMP_TO_EDGE_EXT address mode when native support is available. Adjusted validation, sorted switch cases by target enums order. Added new TextureMirrorClampToEdge* end2end tests. Drive-by: fixed texture address computation for integer formats with GL_MIRRORED_REPEAT on D3D11. Fixed: angleproject:7968 Change-Id: Iaf29c8b4b32a7630c2a871f832d171f4bc4e2672 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4289137 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 044612ec 2023-02-27T14:59:29 Vulkan: Remove iterator from FixedQueue class Previously there was code that still walking each element of FixedQueue, that was mostly removed in previous CLs. The only remaining usage is for assertion which the value is minimal. This CL removes the iterator from FixedQueue so that it behaves just like queue, thus avoiding potential risk of misuse. Bug: b/255411748 Change-Id: I4c0debf5b6c8b603e384c681f1a123c2ee06dcbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4294695 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 31bd0c58 2023-03-01T10:52:30 Vulkan: Do immediate cleanup after finishOneCommandBatch This is follow up for crrev.com/c/4244823. This adds postSubmitCheck in RendererVk::queueSubmitOneOff(). It adds immediate clean up in finishOneCommandBatch and renamed to finishOneCommandBatchAndCleanup. Bug: b/255411748 Change-Id: I1d3dbd7dfe9642f4bc77b17552281a4c7b6c2d69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300098 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 62e58704 2023-03-01T14:46:54 Vulkan: Attempt to fix the tsan complain regarding volk. In certain cases, I am seeing volk function pointer been set while it is still being accessed. See https://chromium-swarm.appspot.com/task?id=60b37aa811f8b410. My guess it is related to some tests configs that end up with RendererVk gets initialized while other instance is still running. This is attempt to fix the tsan complain by only load volk function pointer if needed. Bug: angleproject:8055 Change-Id: I5dcc62876bf93a250080de1f8e1b97d2b7570ab8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300072 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll 839cfa13 2023-03-02T08:07:24 Roll Chromium from 03859909b0fa to 051119636a02 (640 revisions) https://chromium.googlesource.com/chromium/src.git/+log/03859909b0fa..051119636a02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bb2ff97c7a..ff22f91e3b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3d5742efd7..2512e92cc4 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e136ec5032..f8109050ec * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c7e279e566..b5e5cc8b48 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/c2dbcdae89..28c6deacab * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1ccf7c039e..344f5518bf * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4003278e8c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/424814829a..56a18a86fe * third_party/fuchsia-sdk/sdk: version:11.20230228.1.1..version:11.20230301.3.1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/efe38512d6..243f1b198e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/eb620dd29c..501367a46c * tools/skia_goldctl/linux: 1oPah2i45aewEBGsa68o67Y0KibAkUhc8dfDIVTj-TgC..CJ4GdxYYG3v_NJn3Wlkh0THbvMsigwNH76hC9E-vfG0C * tools/skia_goldctl/mac_amd64: LNbaoDsQEefkZnHbXNqyXSyOmpBQdSXqAV0zIYsUui8C..DcfjZ6EhCOk0P7xz4rYDWoj14bHQsuZW8aKIGQnVB44C * tools/skia_goldctl/mac_arm64: EKPxep9bQLvxK9a9FgA1AZcrhUvEiVmnjatSKI4K5vwC..pAgE9V5S1KE5SuFadTLlVQ5yHfCm2OjtbEKyuzo2xdsC * tools/skia_goldctl/win: ygU62PsZ1JG8ebL8lmvO0n9iquvcvZWX7WX0g0cXByEC..Yt2iV6sDnXhLYyn1QpkZ06DAg-yY1Eedw90iVDOvgwAC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I9f7c668f66cc55e8a780d05644a2211655fcec35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4302630 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 8019f293 2023-03-01T14:43:53 Manual roll vulkan-deps from 385df753e370 to 5d7ca659e804 (62 revisions) Manual roll requested by abdolrashidi@google.com * Added "vulkan_sci.h" to the ignore list in export_targets.py to fix a presubmit error. https://chromium.googlesource.com/vulkan-deps.git/+log/385df753e370..5d7ca659e804 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/6d41bb9c55..9cdfc5a511 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/4e2fdb2567..7512345f61 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c9947cc8d5..9d71fb6764 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e8b8e06d09..a3dd2655a3 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/2015474294..3db19f3e3d * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/27c28d4b40..5bcfa1605e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a632681567..b8eae8a7c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8049 Tbr: abdolrashidi@google.com Change-Id: Ibda969b6a7db3ea8d41de8fc28c7caf5fb79ed45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4301769 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 18a1022e 2023-03-01T13:55:41 Manual roll VK-GL-CTS from c0a0038a1bed to 04e5d38379bd (12 revisions) Manual roll requested by abdolrashidi@google.com * Skipped the following test from KHR-GLES3* * shaders.negative.non_precision_qualifiers_in_struct_members https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c0a0038a1bed..04e5d38379bd 2023-02-24 anna.lesniewska@intel.com Add depth tests running on local heap with host visible memtype 2023-02-24 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main 2023-02-24 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2023-02-24 rgarcia@igalia.com Add GLES_ALLOW_DIRECT_LINK CMake option 2023-02-24 piotr.byszewski@mobica.com Test textureSize for oob lod 2023-02-24 syoussefi@google.com Tests for surface/swapchain maintenance1 2023-02-24 michal.jakubek@mobica.com Add coverage of vkGetImageMemoryRequirements2 for multiplanar formats 2023-02-24 Andrew.Fobel@amd.com Fix BufferView access tests for scaled types 2023-02-24 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.5 into vk-gl-cts/main 2023-02-22 piotr.byszewski@mobica.com Merge vk-gl-cts/dev/VK_EXT_pipeline_library_group_handles into vk-gl-cts/main 2023-02-14 ziga@lunarg.com Remove invalid new linked pipeline test with null layout 2023-02-13 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8045 Tbr: abdolrashidi@google.com Change-Id: Ie7e145113c58ede9ba718499b54b0cb32b36f268 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4301430 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov 6e58328d 2023-03-01T19:12:28 Add Mac AMD experimental bot Bug: chromium:1382149 Change-Id: I4652585abee747d4a9a738a679deefb7ae57f64f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300871 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov 024114b2 2022-12-16T11:32:30 Reland "Replace zlib from chrome by Android's zlib." Add zlib to delete_only_deps, otherwise gclient seems to choke on it https://crbug.com/skia/14155#c3 Also git add $root_add_dep instead of "$root_add_dep/*" as the latter wouldn't add deleted directories like third_party/zlib in this case. We also need zlib in unsupported_third_party_deps so that it gets deleted after gclient sync. When a file from a nested git repo was already added to the tree previously, git no longer relies on .git subdirectory detection and works as if .git wasn't there. This is a reland of commit 39f0eaf8095b303b09951ceb6ffda8254ed24c8d Original change's description: > Replace zlib from chrome by Android's zlib. > > Implements Elliott's https://r.android.com/2360448 in our codegen. The > only diffs are ordering and third_party_android_ndk_cpu_features. > We only seem to depend on cpufeatures for zlib. > > //third_party/zlib/google:compression_utils_portable is the root > dependency, so cutting it makes other zlib libs disappear from > Android.bp > > zlib_google_compression_utils_portable and libz_static > that this CL depends on were added in https://r.android.com/2359720 > > Tested by running roll_aosp.sh in Android tree and building. > third_party/zlib got deleted locally so presumably it should > get deleted by the roller > > Bug: b/262603863 > Change-Id: I2651cc21121d741526055fa2b0288d0dcfa5c62a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4111891 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Roman Lavrov <romanl@google.com> Bug: b/262603863 Change-Id: I87226e294a3e293ed5fcdeb2f0cf52f55917c1f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300169 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Alexey Knyazev a2efea13 2023-03-01T00:00:00 Add ANGLE_stencil_texturing This extension allows texturing of the stencil component of a packed depth stencil texture on OpenGL ES 3.0 contexts. Trivially exposed on backends that support OpenGL ES 3.1, which requires this feature. Adjusted the tests to check for the new extension string instead of the context version. Bug: angleproject:8051 Change-Id: I4d833acbc72e7374bde91d4c861598a0fdaf9b90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4295312 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Hans Wennborg 35c44b40 2023-02-28T14:47:38 PoolAlloc: unpoison memory before potentially re-using it std::vector uses special ASan annotations to catch accesses to memory between v.data()+v.size() and v.capacity() -- which are valid memory locations but outside the container. A recent libc++ change [1] made these annotations work with custom allocators as well. This caused a problem when PoolAlloc re-used memory that previously held a std::vector with such annotations without having run the vector's destructor. To fix it, this change makes PoolAlloc unpoison memory when it's returned to the allocator via the pop() method. [1] https://reviews.llvm.org/D136765 Bug: chromium:1419798 Change-Id: I919dd7d7734b36bf770f25e096a94669703d75d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296797 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov a0736135 2023-03-01T15:17:07 Revert "Replace zlib from chrome by Android's zlib." This reverts commit 39f0eaf8095b303b09951ceb6ffda8254ed24c8d. Reason for revert: Broke roller https://crbug.com/skia/14155 Original change's description: > Replace zlib from chrome by Android's zlib. > > Implements Elliott's https://r.android.com/2360448 in our codegen. The > only diffs are ordering and third_party_android_ndk_cpu_features. > We only seem to depend on cpufeatures for zlib. > > //third_party/zlib/google:compression_utils_portable is the root > dependency, so cutting it makes other zlib libs disappear from > Android.bp > > zlib_google_compression_utils_portable and libz_static > that this CL depends on were added in https://r.android.com/2359720 > > Tested by running roll_aosp.sh in Android tree and building. > third_party/zlib got deleted locally so presumably it should > get deleted by the roller > > Bug: b/262603863 > Change-Id: I2651cc21121d741526055fa2b0288d0dcfa5c62a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4111891 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Roman Lavrov <romanl@google.com> Bug: b/262603863 Change-Id: Ie17cb5b63a2c86a7414230bf9b0e8ef16e8734bb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4298280 Commit-Queue: Roman Lavrov <romanl@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuly Novikov 5fd68d59 2023-03-01T14:31:15 Skip FramebufferTest_ES3.RenderSharedExponent on iOS Metal Bug: angleproject:8043 Change-Id: Ib7e28ac1a2d658056e960272783ef322e1f009d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4294902 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Igor Nazarov eb0475c0 2023-02-23T22:59:14 Vulkan: Cleanup RendererVk::allocateQueueSerialIndex method. Currently this method makes 2 distinct tasks: - allocates QueueSerialIndex. - gets LastSubmittedSerial. In case of "queueSubmitOneOff()" (and future uses) "LastSubmittedSerial" is not necessary. This produces extra work and makes code more complex. This CL makes two separate functions: angle::Result allocateQueueSerialIndex(SerialIndex *indexOut); angle::Result allocateQueueSerialIndex(QueueSerial *queueSerialOut); The "queueSubmitOneOff()" was simplified. Additionally, fixed possible SerialIndex leak if method fails before "releaseQueueSerialIndex()". Bug: b/267806287 Change-Id: I1dfb91b9f409aa17e8f1de222f7b01345109e6d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4289749 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll d0056bc5 2023-03-01T07:01:29 Roll Chromium from dc2706bd2987 to 03859909b0fa (653 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dc2706bd2987..03859909b0fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0c4c8e9d71..bb2ff97c7a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/121e823614..3d5742efd7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7bb027b853..c7e279e566 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/17fd178419..1ccf7c039e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a589e9031f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7bf7e06945..424814829a * third_party/fuchsia-sdk/sdk: version:11.20230227.1.1..version:11.20230228.1.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6e18cb4ad3..697c297330 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/27f2bb9970..efe38512d6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5f34c57074..eb620dd29c * tools/skia_goldctl/linux: Y_kEjj2xNjDDzIdGOexbyqLLOhJCcncyCu5lC51g5AsC..1oPah2i45aewEBGsa68o67Y0KibAkUhc8dfDIVTj-TgC * tools/skia_goldctl/mac_arm64: dImBH_u2g-eDmw3VFCZ0E70ynaXS2QWXSEvComqAx9MC..EKPxep9bQLvxK9a9FgA1AZcrhUvEiVmnjatSKI4K5vwC * tools/skia_goldctl/win: huSAWf6X6Ecewacj_voW4JDySIedvh6nH3ePRAn3YW0C..ygU62PsZ1JG8ebL8lmvO0n9iquvcvZWX7WX0g0cXByEC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Iec4bf1959a7df367d033c3d172ee67ab81c4a7db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4298001 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 1ca860ac 2023-02-22T00:00:00 Add extension stubs * GL_EXT_conservative_depth * GL_EXT_depth_clamp * GL_EXT_render_snorm Bug: angleproject:8046 Bug: angleproject:8047 Bug: angleproject:8048 Change-Id: I7deb4f25f76008103c2754747db2d90be880b6ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296803 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mike Schuchardt 190a3214 2023-02-20T17:42:02 Tests: Add Arknights trace Test: angle_trace_tests --gtest_filter=TraceTest.arknights Bug: b/270523023 Change-Id: I147927e5ada7470a91d8aee540cf217fcb1e4ec1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4294655 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mike Schuchardt <mikes@lunarg.com>
Alexey Knyazev e2cf65ed 2023-02-22T00:00:00 Implement QCOM_render_shared_exponent Fixed: angleproject:8043 Change-Id: Ia76b8e4b60a640180bae77cba523142749051398 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4289140 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Charlie Lao e180ed5e 2023-02-27T14:40:10 Vulkan: Apply postSubmitCheck to async submission code path postSubmitCheck is doing CPU throttling if we accumulate excessive amount of garbage. There is no good reason this should not apply in async submission. This CL moves the call so that it applies to both cases. Bug: b/255411748 Change-Id: Ib36344dfe9e6f1c0120734302c0d4083073e004c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4295366 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao e88b061c 2023-02-17T13:36:24 Vulkan: Follow up fix and enable asyncCommandBufferReset flag This CL makes any follow up fix for crrev.com/c/4244823 and enables asyncCommandBufferReset feature flag. It changes CommandQueue::checkCompletedCommands only do the check and update mLastCompletedSerials. It makes async command processor thread always call checkCompletedCommands if mNeedCommandsAndGarbageCleanup is true so that we can clean up more garbages. This CL also makes garbage clean up always done in async thread even if asyncCommandBufferReset is disabled. Bug: b/255411748 Change-Id: I1d63aa9f1f565d81780a39c29b919da3dd5a68be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4264175 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Charlie Lao <cclao@google.com>
Roman Lavrov 39f0eaf8 2022-12-16T11:32:30 Replace zlib from chrome by Android's zlib. Implements Elliott's https://r.android.com/2360448 in our codegen. The only diffs are ordering and third_party_android_ndk_cpu_features. We only seem to depend on cpufeatures for zlib. //third_party/zlib/google:compression_utils_portable is the root dependency, so cutting it makes other zlib libs disappear from Android.bp zlib_google_compression_utils_portable and libz_static that this CL depends on were added in https://r.android.com/2359720 Tested by running roll_aosp.sh in Android tree and building. third_party/zlib got deleted locally so presumably it should get deleted by the roller Bug: b/262603863 Change-Id: I2651cc21121d741526055fa2b0288d0dcfa5c62a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4111891 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll d3fcf08d 2023-02-28T19:33:13 Manual roll vulkan-deps from 3c1556cc7322 to 385df753e370 (1 revision) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/3c1556cc7322..385df753e370 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5d2b7d957e..a632681567 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Iab5e7d0a0763f40a4100e1ef0f0bb8936b311932 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4298190 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 33df630f 2023-02-28T11:16:08 MSRTSS uses AppendToPNextChain due to non-NULL pNext. As discussed in: https://chromium-review.googlesource.com/c/angle/angle/+/4116675/comment/3097cb31_16922d39/ Not currently causing issues as it requires very recent drivers but I saw the `ASSERT(ptr->pNext == nullptr);` in AddToPNextChain fail somewhere. Bug: angleproject:7899 Change-Id: Id46162a5aacd3d8599382ce1dfca25aca5e730e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296801 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 6d282d62 2023-02-08T16:51:07 Vulkan: Move retireFinishedCommands/garbageCleanup to worker thread This CL separate out the logic of mLastCompletedQueueSerial update and retireFinishedCommands and garbage clean up into different functions. At submission, previously we are always check fence and update mLastCompletedQueueSerials and calling reset on finished commands and do garbage clean up. With this CL, we only do the fence check and update mLastCompletedQueueSerials. Then it request worker thread to do the command buffer reset and garbage cleanup. We uses the CommandProcessor's thread for the reset and cleanup, since async submission path needs to handle this clean up anyway. This CL also added a new feature flag asyncCommandBufferReset and it is disabled right now. This will be enabled in the follow up CL. Bug: b/255411748 Change-Id: I6da558f8d4c962eb038e2378ccc76c464101cde2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4244823 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov dd6d8302 2023-02-28T14:24:43 Suppress VUID-vkCmdEndDebugUtilsLabelEXT-commandBuffer-01912 New VUID added in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/5277 Bug: chromium:1420265 Change-Id: I139815fdfd90439c5a2ea79e467a60ba54ecbc0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296799 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll df642b98 2023-02-28T10:01:38 Roll SwiftShader from dca80fc3a894 to 0ba0b45490cd (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/dca80fc3a894..0ba0b45490cd 2023-02-27 bclayton@google.com marl: Remove spurious semicolons 2023-02-27 bclayton@google.com marl: emulate thread_local with pthreads If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I03686ca41e7972e7e6a158afbb4c4b56cbc511db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4297000 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0a4af608 2023-02-28T07:00:09 Roll Chromium from 59912d50f1af to dc2706bd2987 (606 revisions) https://chromium.googlesource.com/chromium/src.git/+log/59912d50f1af..dc2706bd2987 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/60a5c0d8b7..0c4c8e9d71 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/bdd20ec72c..121e823614 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/900cd89794..7bb027b853 * third_party/android_build_tools/lint: MSpv-kFDDSPO0SY0dLdHegUJcJT1Yy8cL9r3vlAZ9vkC..NrP_GizJsQ_kr9O0WQlncRx1xdicjU4BFHi9pLPeTSIC * third_party/android_build_tools/manifest_merger: EbRaK62t9grqlZqL-JTd_zwM4t1u9fm1x4c2rLE0cqQC..saMCpz15quEEWToMloh-A_rMqC0WSdJlyYTFvwAd840C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f8b0a646b3..17fd178419 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..dc83184d4c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9144b67c7f..7bf7e06945 * third_party/fuchsia-sdk/sdk: version:11.20230226.3.1..version:11.20230227.1.1 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/ab0d470309..90e67ba3f8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/59d4a6deb0..6e18cb4ad3 * tools/luci-go: git_revision:8a8b4f2ea65c7ff5fde8a0c522008aed78d42d9d..git_revision:67696c7e93f9dbf03f7bcf7f8fafe9c5728e1ebe * tools/luci-go: git_revision:8a8b4f2ea65c7ff5fde8a0c522008aed78d42d9d..git_revision:67696c7e93f9dbf03f7bcf7f8fafe9c5728e1ebe * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/abe19ba5c7..27f2bb9970 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4ff9da4f7e..5f34c57074 * tools/skia_goldctl/linux: -G9gUusEGDPsbf_GULdyJo9DYyeNBuqD8gHfdxCvIbYC..Y_kEjj2xNjDDzIdGOexbyqLLOhJCcncyCu5lC51g5AsC * tools/skia_goldctl/mac_amd64: 0GVvuvDBNt6KJ7UzxBRUW5ShTWCliifyzaCkudNzmrkC..LNbaoDsQEefkZnHbXNqyXSyOmpBQdSXqAV0zIYsUui8C * tools/skia_goldctl/mac_arm64: 8vKG1ZGA0f7asv5AHh_7yBxVD2h-I-yR2oY4TOjwo6kC..dImBH_u2g-eDmw3VFCZ0E70ynaXS2QWXSEvComqAx9MC * tools/skia_goldctl/win: BZ0EL-KSkwCzJciJf9MbwmZAJPRhlKOp0LEYiTV6lWIC..huSAWf6X6Ecewacj_voW4JDySIedvh6nH3ePRAn3YW0C Clang version changed llvmorg-17-init-2387-g68e81d7e:llvmorg-17-init-3170-g6e30dffe Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/59d4a6deb0f4f0ec8a7d134f94a2b2fef14d444f..6e18cb4ad383a988ece5108d1a74c9da0746ce58/scripts/update.py Bug: None Tbr: abdolrashidi@google.com Change-Id: I5b5eb3e6501e2126e894b6ff1ed8cbd1855c80e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296679 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev a1f9b9aa 2023-02-20T00:00:00 Implement more texture border color adjustments D3D11: * Exposed EXT_texture_border_clamp extension string, to ensure that the relevant CTS tests are running. * Updated StateManager11::setSamplerState to adjust the border color based on the texture format. * Refactored ShaderConstants11::updateSamplerMetadata to correctly adjust the border color for integer formats. * Removed unused SamplerMetadata.internalFormatBits D3D9: * Updated Renderer9::setSamplerState to adjust the border color value based on the current texture format. * Added borderColorSrgb feature required for some drivers. GL: * Copy alpha value to green for A and LA legacy formats to workaround driver bugs when lumaWorkaround is not used. Tests: * Added ES 2.0 tests for texture formats that require border color adjustments. Fixed: angleproject:7969 Change-Id: I3d36cce43e76e6d5069a51865152c2250ecbb017 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4291000 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 9ee816c9 2023-02-28T01:29:35 Manual roll vulkan-deps from d03d09324f14 to 3c1556cc7322 (1 revision) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/d03d09324f14..3c1556cc7322 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/956114df28..c9947cc8d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I612b60f217ef170365f9786e185e18294e293b8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296998 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 2c7447e2 2023-01-19T16:17:39 Always keep track of memory allocation counts * Memory allocation counts are now tracked at all times, similar to allocation sizes. * Changed the per-heap allocation trackers from vectors to arrays of atomic variables. * Added asserts to the getter functions related to memory allocation. * mMemoryAllocationMutex is now used for enabled debug layers only. * Added memory type index in allocation and deallocation debug logs. * Capitalized static functions regarding memory allocation in RendererVk.cpp. Bug: b/262029018 Bug: b/266466279 Change-Id: Idb740048f934f3d725240c78c978341697895f6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4182550 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll a841f24a 2023-02-27T21:05:40 Manual roll VK-GL-CTS from 16e24521578d to c0a0038a1bed (5 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/16e24521578d..c0a0038a1bed 2023-02-13 zzoon@igalia.com Add tests for sampling depth/stencil formats interacted with border color swizzle tests. 2023-02-13 cturner@igalia.com Add xfb tests covering different streams with same location 2023-02-13 amber@igalia.com Compare primitives_generated and transform_feedback(written) 2023-02-13 piotr.byszewski@mobica.com Expand cull distance test coverage 2023-02-13 anholt@google.com Log the image in GL texture border tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I84d2b11ec96deaa3117116d655f6c82de4a096f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4295362 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Rafael Cintron 6f7fec7b 2023-02-24T18:17:26 Convert all raw pointers in Renderer11 to ComPtr In preparation for refactoring of device caps, found a couple of memory leaks in error conditions due to incorrect COM lifetime management. Rather than wrestle with manual AddRef/Release during the refactoring, decided to first convert all manual AddRef/Release to angle::ComPtr. Bug: angleproject:8041 Change-Id: I1211fcd0afd0c629793cebd3051b98fbece70a26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4292695 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll d2bd5ee3 2023-02-27T19:26:38 Manual roll VK-GL-CTS from a13cbc855993 to 16e24521578d (1 revision) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/a13cbc855993..16e24521578d 2023-02-13 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.5 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ib1ed7408187f315969f5d22cbb955161bbecf0cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4295355 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov aa97369f 2023-02-23T18:40:16 Use C++20 for MSVC builds as well Build only ANGLE libraries on MSVC, as there are many failures in tests, which are beyond our scope to fix. Bug: chromium:1380553 Change-Id: I7142730bfa1fc847630ff8115709e435aecf487a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4286569 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Igor Nazarov 1365f5b3 2022-09-09T17:19:26 Vulkan: Fix Swapchain Acquire Image Semaphore wait stage flags. There is a screen tearing on G996B with single "glClear(GL_COLOR_BUFFER_BIT)" no scissor in the frame. Fixed by defining "kSwapchainAcquireImageWaitStageFlags" and adding "VK_PIPELINE_STAGE_TRANSFER_BIT" stage flag. Also added "VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT" stage, because first use of the Swapchain Image after Acquire may be in the "glBlitFramebuffer()" command. This fix may slightly affect performance. In such case, a better fix should be implemented (include only stages based on the actual first use). However, this may be not trivial. Additionally, "kSwapchainAcquireImageWaitStageFlags" is used as a source stage mask in the "ImageLayout::Present" pipeline barrier. This is needed in order to build a dependency chain from the Acquire Image Semaphore to the layout transition's first synchronization scope, so that layout transition happens after acquire semaphore is signaled. Reference: https://github.com/KhronosGroup/Vulkan-Docs/wiki/Synchronization-Examples#combined-graphicspresent-queue https://vulkan-tutorial.com/Drawing_a_triangle/Drawing/Rendering_and_presentation Alternative fix of both issues is to define: kSwapchainAcquireImageWaitStageFlags = VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT This might potentially delay command buffer execution relative to the Swapchain Acquire Image Semaphore signal operations, but will relax the pipeline barrier. Bug: angleproject:8030 Test: angle_end2end_tests --gtest_also_run_disabled_tests --gtest_filter=EGLSurfaceTest.DISABLED_RandomClearTearing* Change-Id: I29f58862c4b369524b2555dd944e2fb67eebe956 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4271377 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Kenneth Russell 8875ba4e 2023-02-24T22:40:22 Rename WebSwapCGLLayer to ANGLESwapCGLLayer outside WebKit. WebKit doesn't use gn or ninja, so these changes will not affect it. Verified locally that this silences the warning in the bug. Fixed: angleproject:7123 Change-Id: Iff28c0f5b9274543ee7724e023461d31c8ad4aa6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4292705 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll f524e4b8 2023-02-27T07:01:34 Roll Chromium from 37f4bbb7be8f to 59912d50f1af (435 revisions) https://chromium.googlesource.com/chromium/src.git/+log/37f4bbb7be8f..59912d50f1af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9801b54237..60a5c0d8b7 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d1127a2c8d..bdd20ec72c * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/87d8fe050b..ff8e691cbc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d40f31ade6..900cd89794 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8a26fb906e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eee53367c1..9144b67c7f * third_party/fuchsia-sdk/sdk: version:11.20230224.1.1..version:11.20230226.3.1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5290e7b1df..abe19ba5c7 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Id75573d4a5523db7f9ac7f3a947b619680be370a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4293029 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop ef6d1473 2023-02-24T08:27:33 Tests: Add Into the Dead 2 trace Test: angle_trace_tests --gtest_filter="*into_the_dead_2*" Bug: b/270605668 Change-Id: I80d1aa8058a8d970888725ca850ed934a100588b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4290021 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 5bc6bf32 2023-02-20T00:00:00 Include DXT1 sRGB in RGBDXT1TexturesSampleZeroAlpha Bug: angleproject:3729 Change-Id: Id5404e4601a3165051ee4b249646b7ca000bedbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4290988 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
kmx.io     mail     discord kmxgit v0.4.0