kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi c3def6fa 2022-05-10T14:28:04 Vulkan: Dynamic state for stencil compare mask Bug: angleproject:5906 Change-Id: Ie581c6e9fe15c90c7a6d0c7c246dd5b1b30b6507 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3638988 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Stephen White e9dc0f86 2022-05-10T12:44:28 Cleanup from glBlitFramebuffer() 3D texture fix. Some minor refactoring. Move skips to test expectations and add a bug ID. Bug: angleproject:7291 Change-Id: I8d900a26508a28f6202a009c770cffb0e623dc5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3638985 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi dcaa18b9 2022-05-10T12:27:15 Vulkan: Dynamic state for blend color Bug: angleproject:5906 Change-Id: If450e0d84410069126027142414586181fd5f0de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3638986 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 536d6f57 2022-05-10T11:44:58 Vulkan: Dynamic state for depth bias Bug: angleproject:5906 Change-Id: I8fd7e3262fddf3aec855afdd3e4c1b9801040da1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3638983 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Stephen White 42789b63 2022-05-11T11:56:43 Use GLTexture in TextureTest for RAII goodness. Change-Id: I2a9fd5ddeacb9f7947a8090748b2e1cbbabb4fe6 Bug: angleproject:7266 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3623862 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 780f1a41 2022-05-10T00:30:35 Vulkan: Dynamic state for line width Bug: angleproject:5906 Change-Id: Iacf9c14d9d255c8048c71c725173e4764bcfe166 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3634733 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Stephen White 9b15e1c2 2022-05-11T11:47:52 D3D11: clean up ES31 test expectations. Remove expectations for now-passing tests. Make some expectations more precise. Bug: angleproject:1442, angleproject:1729 Change-Id: I9843b7ef438599d121d3dd028273ae50fcf89e2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3641181 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill f6610106 2022-05-10T12:05:52 Add a draw call perf test for changing a single uniform. Bug: angleproject:6776 Change-Id: I0621c813a654b3378b48d03219620627605b24a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3638984 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi e73121b1 2022-05-10T22:47:20 Vulkan: Fix VulkanPipelineCachePerfTest Bug: angleproject:5906 Change-Id: Ide86708df10679309cc2aca0df088e8595d2a8c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3641142 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Stephen White dd9b4afe 2022-05-10T17:57:29 D3D: minor cleanup for image load/store. Change-Id: I633d51f01845b92f864df1229d501d572b96b314 Bug: angleproject:7121 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3638991 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Shahbaz Youssefi 1fa4442b 2022-05-10T14:31:28 Vulkan: Set dynamic state after binding pipeline The helper function that binds the graphics pipeline also resets dynamic state. This refactoring change moves dynamic state setting to after pipeline bind, for future CLs that may override what would be reset. Bug: angleproject:5906 Change-Id: I28e5bfd7a7a5492f066df98604489808dafd560b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3638987 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 089f2871 2022-05-10T13:05:18 PerfTests: Add support for eglCreateImage and eglDestroyImage Bug: angleproject:4964 Change-Id: I7a028b72cf7a44230f8d129753daef8c04f2fac5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3636061 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 5b623dd4 2022-05-10T00:00:00 D3D9: Enable OES_fbo_render_mipmap Bug: angleproject:905 Change-Id: I82a4eac47950ea35387857d7f7b79d326bbfdbd3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3639204 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 25ebc3b8 2022-05-11T10:01:07 Roll vulkan-deps from 27ef4a0d9701 to b768d03422ea (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/27ef4a0d9701..b768d03422ea Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/0c8a79b0b5..940efca099 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ad3514b732..f74b85853c * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/8ba8294c86..33d4dd987f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/40437fb6ed..817dd5363e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I0e18c0d85b43fd9aebd8b1d2529c8f8e81ad327b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3641475 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll eea6366c 2022-05-11T10:01:50 Roll SwiftShader from e4a6f2d74d3c to e0a1188d7652 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/e4a6f2d74d3c..e0a1188d7652 2022-05-10 syoussefi@google.com Fix dynamic state for line width If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:5906 Tbr: romanl@google.com Change-Id: I8278223fc3b1cc9acf32d7fdc8410a594540aa85 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3640554 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 029a4c94 2022-05-10T13:02:03 util: Add calls for createImage* and destroyImage* to GLWindow This adds the interface to the GLWindowBase, an implementation to EGLWindow, and placeholder functions to WGLWindow. Bug: angleproject:4964 Change-Id: Ia13f5237500cece9564910c95c6c5eea67ca022d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3637559 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll 486ae89e 2022-05-11T07:01:16 Roll Chromium from 46c13be19f0f to 693c7419bd5c (567 revisions) https://chromium.googlesource.com/chromium/src.git/+log/46c13be19f0f..693c7419bd5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9042b6dc2d..1c34f36484 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ac1834f0f9..ecff200716 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a5ef65301b..2325b300ba * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d1ddc12119 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1bc3cd228e..31bfd51995 * third_party/fuchsia-sdk/sdk: version:8.20220509.2.1..version:8.20220510.2.1 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/299c223073..af7b288c8f * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/dea66ed25b..d31fefe9c4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cd2b9e3fc9..9da9510586 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/410a89315b..25ed892f84 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/33d416b156..60720e89b6 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Ic2030211488c58688492139467cb2c2dc83160ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3641464 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu a8ebdf2b 2022-05-05T19:01:22 Basis Universal Texture Experiment Adding ETC1 image decoder code to decompress the ETC1 data into RGBA data, so that we can compare the pixel values in the test Bug: angleproject:7250 Change-Id: I0b8d6143473c38818407c42db3227d1f93e1c0a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3631572 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Geoff Lang 6ddbfa39 2022-05-09T09:06:16 Metal: Log the shader source when a shader fails to translate Refactor Metal logging to include a message string. Bug: chromium:1322521 Change-Id: I3a7b5c36fcf140b3664ad96a9da924819326bf94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3634725 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Alexey Knyazev 52904367 2022-05-10T00:00:00 D3D: Mark images clean after syncing from storage Bug: angleproject:2192 Change-Id: I114da8962f6f7aec3134d39bc51c62455e4a62ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3637565 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
John Stiles f1640db8 2022-05-10T11:13:48 Fix crash when calling certain gl APIs before initialization. ANGLE attempts to report an error if various APIs (incl. glClearStencil) are used before the context is set up. On Mac, when ANGLE attempts to report the error, if the egl platform is still uninitialized, it attempts to access NULL thread information via GenerateContextLostErrorOnCurrentGlobalContext. This leads to an assertion/crash. We can guard against this by calling egl::GetCurrentThread() first, which will do the lazy-initialization work that is needed. If egl is already initialized, this is harmless and very inexpensive. Bug: angleproject:7290 Change-Id: Iadc89dba52f8da1dff17610099a0c0a38d947571 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3638982 Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 66b9214f 2022-05-03T14:48:07 Capture/Replay: rename ANGLE_CAPTURE to ANGLE_CAPTURE_GL In addition gunning "git cl format" on the current tree resulted in additional changes. Bug: angleproject:4964 Change-Id: I3df4888aef763d06f91227409dbd943d0d25689e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3634699 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano 2fb58a95 2022-02-15T15:40:23 Re-land: "Vulkan: GBM platform" Add support for GBM platform by implementing a Display with no WSI extension. Re-land fixes build script, including GBM Vulkan backend whenever ozone platform GBM is enabled. Bug: angleproject:7217 Change-Id: Icbf2d034b700e22ab4c351e479f472d65d832ebe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3637562 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 4ecb1e3e 2022-05-09T23:59:10 Vulkan: Support wide lines The supported range of wide lines was set to [1, 1] previously while the Vulkan feature was not queried. Now that the features are correctly queried and enabled, wide lines can be properly exposed. Bug: angleproject:2706 Change-Id: Ieb646c7d10eb6690009d17a7acf43780fb26bc5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3634732 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 18089dff 2022-05-09T07:09:46 Vulkan: Clean up flag passing in ImageView init. Refactoring change only. Bug: angleproject:7269 Change-Id: I7323c3171d669a20858dc48863ee1d715bd126ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3634719 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Stephen White 8e121571 2022-05-06T13:27:06 D3D11: fix 3D texture blits. Change-Id: Icf8b061bb8f5d3e1cdd03f75fdecf16157abc0e5 Bug: angleproject:7272 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3631348 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 464f30f4 2022-05-09T16:33:08 Vulkan: Refactor UtilsVk dynamic state handling Dynamic state dirty bit handling is centralized in UtilsVk to reduce the risk of errors as more dynamic state is taken into account. Bug: angleproject:5906 Change-Id: Ib33554ff36f9249129a8f1650047dd987fe81982 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3634731 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 86d9d66d 2022-05-04T12:21:32 Vulkan: Determined sized-ness of format in initImageViews. Bug: angleproject:7269 Change-Id: I1f1f58a0079c8ead28cc2bf7f9aa91cd3f9dc7bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3628019 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov 9872c1d6 2022-05-09T12:09:57 Switch deqp merge to python3 Got broken by https://crrev.com/c/3600911 and that somehow doesn't break builds, just says "json.output (invalid)" as the script raised an exception (ImportError: No module named pathlib). The script is executed using sys.executable so changing shebang doesn't work. Bug: angleproject:6854 Change-Id: I38d72755ed9d1d0983439e017c616cfbe8c52b17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3634727 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 5fa8f904 2022-05-10T10:01:06 Roll vulkan-deps from 626b2fd72bde to 27ef4a0d9701 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/626b2fd72bde..27ef4a0d9701 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ffc8f2d455..ad3514b732 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/14155d96ed..40437fb6ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I065dab0913268d24c7566907e2a8010f04820389 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3636160 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c8c2664a 2022-05-10T10:01:51 Roll SwiftShader from 1dd93361b1d9 to e4a6f2d74d3c (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/1dd93361b1d9..e4a6f2d74d3c 2022-05-09 swiftshader.regress@gmail.com Regres: Update test lists @ f5cda783 2022-05-09 swiftshader.regress@gmail.com Regres: Update test lists @ 1dd93361 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ia1a48bdfcf73b63df254a934f459a86606e20fee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3637382 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6bf0e620 2022-05-10T07:00:21 Roll Chromium from 7f78f00fdc5c to 46c13be19f0f (273 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7f78f00fdc5c..46c13be19f0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d0853d6aba..9042b6dc2d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fda484aa24..a5ef65301b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..406c287087 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6a1494e5d7..1bc3cd228e * third_party/fuchsia-sdk/sdk: version:8.20220509.1.1..version:8.20220509.2.1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/523694f5a4..410a89315b * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/c8563c1c1d..be0b201de9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/14b56ab359..33d416b156 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I5695b07518d8a3142e35a397c9b2d0384ae48ad9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3637026 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 2b8172b9 2022-05-09T14:20:25 Vulkan: Add missing initialization for mTotalMemorySize Looks like a bad merge. Bug: b/230538246 Change-Id: I66869ebb856606dc6acd5da4e919024efe62aa79 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3635159 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 31321cb7 2022-05-09T16:17:25 Vulkan: Remove suppressions and workarounds for old AMD/Windows The old AMD/Windows bots are decomissioned. This change removes suppressions and workarounds that were added for that bot. Bug: angleproject:2463 Bug: angleproject:2809 Bug: angleproject:2847 Bug: angleproject:3243 Bug: angleproject:4720 Bug: angleproject:6123 Bug: angleproject:6652 Bug: angleproject:7144 Bug: angleproject:7227 Bug: chromium:1224996 Change-Id: I333ed6d76dfa2916b713ccb49127deceb5b1b551 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3634728 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 0db4c39b 2022-05-09T20:02:58 Revert "Vulkan: GBM platform" This reverts commit 825d5b2c59b463253c82262a0c50f75d28860db4. Reason for revert: Fails link rolling into Chrome crrev.com/c/3635013 https://ci.chromium.org/ui/p/chromium/builders/try/chromeos-amd64-generic-rel/1149608/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-chromeos-compile-dbg/1013047/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-chromeos-rel/1189185/overview Original change's description: > Vulkan: GBM platform > > Add support for GBM platform by implementing a Display with no WSI > extension. > > Bug: angleproject:7217 > Change-Id: Ia9089131c5984dfdd926d2f85f1c218df1e84d9a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3596042 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7217 Change-Id: Ia8a4ca753a8f18d6a2c607010b5afabf6a78fe9a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3636059 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 26a2e147 2022-05-09T18:34:22 Roll Chromium from bc117969dbb5 to 7f78f00fdc5c (162 revisions) https://chromium.googlesource.com/chromium/src.git/+log/bc117969dbb5..7f78f00fdc5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dbc99398f7..d0853d6aba * buildtools/linux64: git_revision:53ef169800760fdc09f0773bf380fe99eaeab339..git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35 * buildtools/mac: git_revision:53ef169800760fdc09f0773bf380fe99eaeab339..git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/fb82ddb71c..ac1834f0f9 * buildtools/win: git_revision:53ef169800760fdc09f0773bf380fe99eaeab339..git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ce3f74eb9a..fda484aa24 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/49fe556aa1..65c55bd4b2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0f76f22a35 * third_party/fuchsia-sdk/sdk: version:8.20220508.3.1..version:8.20220509.1.1 * third_party/turbine: zB1ls771w8S0URcjvMWxOHJ33pmUKq5Zr8zkbIMfvcsC..FJ-IOPRGQsHUZwVeYmVw_idRk5mUUP6_Uj2i6mKQlEMC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/66c77e1fb3..14b56ab359 No update to Clang. Bug: None Tbr: romanl@google.com,ynovikov@google.com Change-Id: Id21ea3b3c87a63837c66db343fa51342f806b8b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3635699 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang d4442f53 2022-04-28T15:23:19 Reset the program executable if async linking fails. In this case, there is no exectuable to reset back to and the current executable is filled with state that is "valid" because the program failed to link for implementation specific reasons. Bug: chromium:1319332 Change-Id: I1aeb4f22394a0b5d1127eb313e4d550e4fc8af66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615016 Reviewed-by: Lingfeng Yang <lfy@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Antonio Caggiano 825d5b2c 2022-02-15T15:40:23 Vulkan: GBM platform Add support for GBM platform by implementing a Display with no WSI extension. Bug: angleproject:7217 Change-Id: Ia9089131c5984dfdd926d2f85f1c218df1e84d9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3596042 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 0b0744f3 2022-05-05T16:22:28 Vulkan: Fix VVL error for black desert mobile When a depth stencil attachment is sampled in fragment shader and followed by sample from vertex shader, we are not hitting the readOnly to readOnly but with different shader stage code path. This is because IsShaderReadOnlyLayout is not counting VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL as shader read only, even though we are picking this layout for depth texture texture sampling just to avoid renderpass break when transit depth texture from read only depth attachment to shader read. Bug: angleproject:7186 Change-Id: I98c782ce85125a2ade953440145d6cc71d2c1dc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3629953 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev b51bbe24 2022-05-06T00:00:00 Add CopyTextureTest.ClearAfterCopySubTexture Bug: angleproject:2192 Change-Id: I75d13e089e6e47f1fd3ce62eba48e531c24abcff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3634704 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Jamie Madill b54b1146 2022-05-04T10:45:15 Vulkan: Use ImageView layer count functions in TextureVk. Refactoring change only. Bug: angleproject:7269 Change-Id: Iccc271afdee30d1c8df982f713083fabc7848bb4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3625523 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Geoff Lang c8c4109c 2022-05-02T11:29:24 HLSL: Disambiguate functions that have int/uint parameters. If a bit-shift expression is passed as a function parameter in HLSL, the compiler cannot tell if it is intended as a uint or int when doing overload resolution. Explicitly disambiguate functions that have int and uint parameters when generating the HLSL. Bug: chromium:1319332 Change-Id: I11c9518e060e9940550bbb04dd7cb953d99c2bb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621316 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill e1de0950 2022-05-04T09:37:50 Vulkan: Always init image views using image format. The same format is already in the image helper. Refactoring change only, no functional change. Bug: angleproject:7269 Change-Id: Ifdd1d71045602ed41cf642ec0b3e1282fcbd6e49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3625522 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 8b4e7412 2022-05-09T10:01:11 Roll SwiftShader from 74e34ab97aeb to 1dd93361b1d9 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/74e34ab97aeb..1dd93361b1d9 2022-05-07 capn@google.com Always enable MemorySanitizer instrumentation for vertex routines 2022-05-07 capn@google.com Don't make use of roundps in MSan builds 2022-05-07 capn@google.com Don't make use of cvtps2dq in MSan builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: If1a73b10ac5b7f60224e14253fde5a34bb678195 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3634418 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 78d88796 2022-05-09T09:29:27 Roll Chromium from 333c8248b125 to bc117969dbb5 (506 revisions) https://chromium.googlesource.com/chromium/src.git/+log/333c8248b125..bc117969dbb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/129f40a5db..dbc99398f7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1a91b3f90b..ce3f74eb9a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0f76f22a35 * third_party/fuchsia-sdk/sdk: version:8.20220506.0.1..version:8.20220508.3.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/59264cc01a..cd2b9e3fc9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2103a9a85a..66c77e1fb3 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I301bde40e691178cb7bb7b25f1a48d49a8cf9032 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3634195 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yiwei Zhang e316203a 2022-05-07T21:31:52 Vulkan: add forceContinuousRefreshOnSharedPresent feature Android EGL wrapper filters EGL_FRONT_BUFFER_AUTO_REFRESH_ANDROID, making it impossible for angle to provide an implementation for EGL_ANDROID_front_buffer_auto_refresh. Thus angle currently is only able to choose demand refresh for swapcahin present mode. This change adds a feature to force angle to create the swapchain with continuous refresh mode without affecting angle internal tracking for shared present. This feature will be enabled on integrations without the auto_refresh hint passthrough to angle, as well as before the platform allows angle to implement EGL_ANDROID_front_buffer_auto_refresh on its own. Bug: b/229267970 Test: angle_end2end_tests --gtest_filter="EGLSingleBufferTest*" Test: smooth draw with gpu accelerated low latency stylus in ChromeOS Change-Id: I29d72830d4e3d9fd5cdd44b8e1ce51fd7d9789fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3633358 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 225d8f83 2022-05-04T11:34:56 Tests: Add Mortal Kombat App Trace Test: angle_perftests --gtest_filter="*mortal_kombat*" Bug: angleproject:6997 Bug: b/218515707 Change-Id: Ie1d4ab498239308761aab55a92f1280cb52dd0a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3627126 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll fa4523cf 2022-05-06T21:26:04 Roll vulkan-deps from 4ca7acf89869 to 626b2fd72bde (22 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4ca7acf89869..626b2fd72bde Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/e3bca2add6..14f6e27304 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/46b7918218..b765c355f4 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/46492aa45a..ffc8f2d455 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/191e261495..08cad0c015 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/75a5d5459f..14155d96ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Idd76b9846e9ad4d26ac1d17d838ae537d2c6651e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3632660 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll cadb933f 2022-05-06T18:13:20 Roll Chromium from 3bc34dd4d819 to 333c8248b125 (124 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3bc34dd4d819..333c8248b125 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/75ef0df86b..1a91b3f90b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..778ecbcb2a * third_party/fuchsia-sdk/sdk: version:8.20220504.0.1..version:8.20220506.0.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3e15bc0c33..59264cc01a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/159461b27b..523694f5a4 Clang version changed llvmorg-15-init-9074-gc62b014d:llvmorg-15-init-9576-g75f9e83a Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/3e15bc0c33d1b05433e5dd05b247dc9b971c6be8..59264cc01ad990a0079be09bf0985ab32790ae0e/scripts/update.py Bug: None Tbr: abdolrashidi@google.com,ynovikov@google.com Change-Id: Ia0bf8e108fa5469a345d8f1d346c6172f509c565 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3632651 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 1d073482 2022-05-04T23:25:23 Tests: Add Basemark GPU trace Test: angle_perftests --gtest_filter="*basemark_gpu*" Bug: angleproject:7274 Change-Id: I5adbc16ab7a6f5d3b51de3b31614fb1acb75a9f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3628950 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Amirali Abdolrashidi 38a53d65 2022-05-06T18:06:05 Revert "Remove limit_max_texture_size_to_4096 workaround" This reverts commit bcc03bd62200ffb0301fbcaa7e7984a06232c83d. Reason for revert: ANGLE autoroller fails on some Pixel 4 web conformance tests. Original change's description: > Remove limit_max_texture_size_to_4096 workaround > > Chromium will apply workaround to gpu command buffer clients only. So > removing it from angle which is no longer needed. > > See crbug.com/1319451 and in particular crrev.com/c/3626252 > > Bug: chromium:1319451 > Change-Id: I723e525600aa7b93e784c98348e060a503c09657 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3618501 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Lingfeng Yang <lfy@google.com> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: chromium:1319451 Change-Id: I0db424e97ebb0f9141076b409667aa49faeb2ec4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3630919 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov bec809fe 2022-05-06T17:40:27 [Fuchsia] Download the gn sdk instead of core Copy Chromium's crrev.com/c/3627316 into ANGLE Bug: fuchsia:99205 Change-Id: If00f26726091a4a88c0574170255fa7f585e8b34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3632109 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 5f2ad153 2022-05-06T09:42:00 Tests: Add Puzzles and Survival trace Test: angle_perftests --gtest_filter="*puzzles_and_survival*" Bug: angleproject:7285 Change-Id: If09e3bdc60f71e7b8610731251fc0c6e8e4642cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3630168 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll b33d1555 2022-05-06T16:53:12 Roll VK-GL-CTS from 106df4122297 to acf70aaf3fdb (12 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/106df4122297..acf70aaf3fdb 2022-05-06 quic_mnetsch@quicinc.com Merge vk-gl-cts/github-main into vk-gl-cts/main 2022-05-06 olv@google.com Verify rectangular lines using the strict rule 2022-05-06 piotr.byszewski@mobica.com Remove unneeded commented block of code 2022-05-06 gleese@broadcom.com Fix some status code clarifications 2022-05-06 piotr.byszewski@mobica.com Run FSR tests with secondary command buffers 2022-05-06 gleese@broadcom.com Expand the list of format for image store tests 2022-05-06 toni.merilehti@siru.fi Test single-path switch statements 2022-05-06 ilkka.saarelainen@siru.fi Add tests for VK_EXT_image_2d_view_of_3d 2022-05-06 antto.makinen@siru.fi Add coverage for MSAA copies with BindImageMemory(offset != 0) 2022-05-06 ari.suonpaa@siru.fi Add test for depth comparison with texel replacement 2022-05-06 charles@lunarg.com Support VK_KHR_portability_enumeration 2022-05-06 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com,angle-bots+autoroll-info@google.com Change-Id: Ibb6d9346232bcb188c96b2606d39a6f89b943f96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3632486 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 950db602 2022-05-06T16:49:10 Roll SwiftShader from 643179694ec7 to 74e34ab97aeb (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/643179694ec7..74e34ab97aeb 2022-05-06 capn@google.com Override the SPIRV-Headers path to use local copy 2022-05-06 capn@google.com Fix SPIRV-Tools Android.bp build 2022-05-05 amaiorano@google.com Update SPIR-V Headers to b765c355f 2022-05-05 amaiorano@google.com Update SPIR-V Tools to 7014be600 2022-05-05 amaiorano@google.com update-spirvheaders: run Gerrit hook on generated CLs 2022-05-05 amaiorano@google.com update-sprivtools: run Gerrit hook on generated CLs 2022-05-04 pkasting@chromium.org Remove use of std::iterator, which is gone in C++20. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I09d85b64d3021add4089fae993a5f5fd31c74421 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3632627 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop dbbfac65 2022-05-05T23:07:09 Tests: Add Monument Valley trace Test: angle_perftests --gtest_filter="*monument_valley*" Bug: angleproject:7284 Change-Id: I673624f259e281354260b90a45e4236af476631b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3630485 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop b365a606 2022-05-05T22:28:26 Tests: Add Dead Cells trace Test: angle_perftests --gtest_filter="*dead_cells*" Bug: angleproject:7282 Change-Id: I96b3a5e3499e71c9ecf482cb43aebf0ae56d1052 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3631998 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Chong Gu 72cc8cbc 2022-05-04T09:47:00 Migrate Fuchsia sdk checkout from using script to CIPD Bug: fuchsia:99205 Change-Id: I37157852864c35724ee57f59cb6f003e158a6229 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3627125 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e0d00563 2022-05-03T17:02:06 Vulkan: Simplify external format Chroma code. The prior code used a const_cast and some other twiddling when we really just needed to add a separate small setting function. Also encapsulates the YcbcrConversionDesc string into a class with private data. The end goal is to refactor image view init and caching. The const_cast and the SamplerState were getting in the way. Bug: angleproject:7269 Change-Id: Ie2fb4ba848c46adc63618f313f7a68a1df5cef8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3625492 Reviewed-by: Trevor Black <vantablack@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 51d6a1d9 2022-05-06T10:25:33 Roll Chromium from 617cd3226543 to 3bc34dd4d819 (40 revisions) https://chromium.googlesource.com/chromium/src.git/+log/617cd3226543..3bc34dd4d819 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a1147fb865..129f40a5db * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b4d6fd5093..75ef0df86b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..778ecbcb2a No update to Clang. Bug: None Tbr: abdolrashidi@google.com,ynovikov@google.com Change-Id: I1b6fd75bb6c60767e22b323df4ef51236916efe6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3632132 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki a78eca2c 2022-03-08T14:47:14 util/X11Window: Set PMinSize and PMaxSize hints. Before this patch replay windows were down-sized to match the default screen size in case their extent was greater than the screen size. Setting a PMinSize on XSizeHints resolves the issue on modern window managers. Tested with GNOME Shell 41.3 with both native X11 and Wayland (over XWayland) backends. Setting PMaxSize was also requried to pass the BlitFramebufferANGLETest tests. This fixes retracing with correct extents and resolves a VVL performance warning. Bug: angleproject:6808 Bug: angleproject:7083 Change-Id: I00ee149ec02efe08c5801e4231913049d31e262b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3507514 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 332c9ad0 2022-05-06T07:00:33 Roll Chromium from 7a60295b6324 to 617cd3226543 (278 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7a60295b6324..617cd3226543 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d59764ea23..a1147fb865 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ce96725bdd..fb82ddb71c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4b60cffe3e..b4d6fd5093 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8bb2630eef..49fe556aa1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..778ecbcb2a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b9dca865af..6a1494e5d7 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f5c731071f..159461b27b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4b070df729..2103a9a85a No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I326163d2300b31199c85f46813308f324b680001 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3630490 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 1d5d09e4 2022-05-04T12:33:34 Vulkan: Prefer MAILBOX over IMMEDIATE present mode When swap interval is 0, either MAILBOX or IMMEDIATE present modes could be chosen. MAILBOX produces no tearing, so this change prefers that. Bug: angleproject:3163 Change-Id: I80b3c5820358b398ddf0eeba546d1ec10bae3d84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3628018 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao d075dfe2 2022-05-03T16:25:26 Vulkan: Reduce kMaxBufferToImageCopySize to 64M Bug: b/230538246 Change-Id: Id2ef9c35f74fb6f526744903402562f9354bfcdb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3625834 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 333da2cf 2022-05-03T16:21:41 Vulkan: Limit the total bytes of suballocation garbages in flight This CL tracks the total number of bytes of suballocation garbage. It checks against the limit so that when there are excessive garbages in flight, we will wait for GPU to finish and free up some of these memory before continue. That way we will ensure we do not end up accumulating too much memory and end up with low memory kill on mobile devices. Bug: b/230538246 Change-Id: Ic8292db5617bcee4ec3abe8632f54edfd249cfaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3617226 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki 98488a19 2022-04-28T11:53:21 FramebufferTest: Add FramebufferChangeTest test. Add an end2end test that reproduces VVL error seen in Black Desert Mobile that states "Render pass closed due to framebuffer change". The test passes on OpenGL/ES. Add Vulkan test to expectations. Test: angle_end2end_tests --gtest_filter="FramebufferTest_ES3.FramebufferChangeTest/*" Bug: angleproject:7139 Bug: angleproject:7186 Bug: b/181797364 Change-Id: I661a55a5d9322c51cbed20de1ffcc477cb6a4dc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3560601 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop b79178a3 2022-05-05T14:16:40 Scripts: Strip prebuilt debug APK from AOSP roll The //build dir was recently added to AOSP roll. We can't merge it due to inclusion of a prebuilt debuggable APK. Failing roll: https://android-review.googlesource.com/c/platform/external/angle/+/2086946 File in question: angle/build$ find . -name "*.apk*" ./android/CheckInstallApk-debug.apk This CL adds it explicitly to the files to strip before committing. Test: ./scripts/roll_aosp.sh and inspect //build Bug: b/231365398 Change-Id: Ic5487a88dd50a0ff54311b4870682671a5ebc080 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3629943 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 8dcba9ae 2022-05-05T18:18:43 Roll Chromium from 1c301e690de1 to 7a60295b6324 (184 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1c301e690de1..7a60295b6324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c812b8d227..d59764ea23 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/f1108b6ba3..3d54d41c27 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe2c48dd06..4b60cffe3e * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/460d235b06..758568c7d1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..81c0ef0a06 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a05da12d55..4b070df729 No update to Clang. Bug: None Tbr: abdolrashidi@google.com,ynovikov@google.com Change-Id: I8c5c3f547ab8b9a13dae224d1b589a4c9985956b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3630480 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 51dc3c3e 2022-05-02T18:11:26 Vulkan: Force prune when there are lots of suballocations destroyed If there are a lot of suballocations destroyed, there is bigger chance that some buffers become empty and we might able to trim down excessive empty buffers. This CL tracks the suballocations destroyed at each cleanupGarbage call and use that information to force immediate pruneEmptyBuffers call. Bug: b/230538246 Change-Id: Icca2ea731639545c635c09d58a8606d67405e1a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3620981 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Bo Liu bcc03bd6 2022-05-01T14:47:11 Remove limit_max_texture_size_to_4096 workaround Chromium will apply workaround to gpu command buffer clients only. So removing it from angle which is no longer needed. See crbug.com/1319451 and in particular crrev.com/c/3626252 Bug: chromium:1319451 Change-Id: I723e525600aa7b93e784c98348e060a503c09657 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3618501 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 2fae9482 2022-05-02T11:05:36 Vulkan: Use heuristic to decide how many empty buffers to keep Instead of rely on static information (16 max empty buffers and not been used for a given period of time), this CL keeps track of how many new buffers are needed (either reused from empty buffer list or allocated new) since last prune. We use this heuristic information to decide how many empty buffers to keep around and trim the excessive empty buffers. Combined with the next few CLs, on pixel6 I am seeing 11.7M reduction with vsync_angry_birds_2_1500. The memory_max minus memory_median reduced from 49M to 38M. Bug: b/230538246 Change-Id: I51da745afe4bfdbff0ba165418531803bdce681b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3622264 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki 0afa5b9f 2022-05-03T12:27:56 Tests: Add Alto's Odyssey trace. Test: angle_perftests --gtest_filter="*altos_odyssey*" Bug: angleproject:7275 Change-Id: Ibd5c5517ccde8e18e2b5cc39535605be428512fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3629543 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Peter Kasting 2ce60b52 2022-05-05T08:23:07 Fixes for C++20 support. * The compiler grew smart enough to warn about value changes due to casting to float inside floatToNormalized(). Make it smart enough to realize this isn't a problem by using constexpr if. * Types on both sides of a comparison operator should be the same. * Structs with user-declared constructors are no longer aggregates. Provide a constructor and call it. * std::result_of<F(x)> is gone, use std::invoke_result<F, x> instead. Bug: chromium:1284275 Change-Id: I6487bb18c65837a6d7d2661f65e097dc6a7605b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3630478 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org>
Amirali Abdolrashidi 3f216ee7 2022-05-04T19:37:13 Vulkan: Set timeout for MultiContextDrawWithSwap* Bug: angleproject:7270 Change-Id: Ie36a6a8eb796cd49c32a21a9bace8f9b0efa5a90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3627484 Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll bd44b29d 2022-05-05T09:54:27 Roll Chromium from 6db3a94387ed to 1c301e690de1 (550 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6db3a94387ed..1c301e690de1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/113378f9b3..7208eddba1 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/393e3eee99..f1108b6ba3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/78e25c11f6..fe2c48dd06 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e1bf83383b..8bb2630eef * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7caeea5854 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/13acea3645..b9dca865af * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/75625c6906..3e15bc0c33 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7593122778..f5c731071f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/78265207a0..a05da12d55 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I5fdcdaccef295079f45478d541b15076863d3a87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3629119 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov d7346867 2022-05-04T16:58:17 Decommission win7-x86-amd and win7-x64-nvidia Bug: chromium:1322538 Change-Id: I36a46eb8351a151b46e860c7c1c3311f0843e067 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3628110 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Doug Horn 9865ed8b 2022-05-03T16:06:56 Check in //build files needed. Previously, only //third_party was actually `git add`ed. This change checks in the build files needed to access test scripting. Test: ./scripts/roll_aosp.sh m -j32 ANGLE Bug: b/231365398 Change-Id: Ib4bf75bc96e089bf7fe5d7b4d2304829c293c8ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3625833 Commit-Queue: Doug Horn <doughorn@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Antonio Caggiano 9053a641 2022-01-17T11:32:41 Vulkan: Wayland dmabuf extensions Implement EGL extensions image dmabuf import and import modifiers in Vulkan Wayland Display. Bug: angleproject:7065 Change-Id: I91535db3581cbe51f0eddc429e2752641c568148 Signed-off-by: Antonio Caggiano <antonio.caggiano@collabora.com> Signed-off-by: Constantine Shablya <constantine.shablya@collabora.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3525093 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 77cd0b5a 2022-04-14T13:32:07 Re-land: "Vulkan: Cache ImageView serials on texture changes." Re-land fixes BindTexImage serial caching. This significantly reduces overhead when changing textures before draw calls in the Vulkan back-end. Bug: angleproject:6776 Change-Id: I2cc03cb8a70e8c181f7658ab45df780e412bfc57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3623860 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Antonio Maiorano b72cff8c 2022-05-04T09:54:30 Fix build flags not in declare_args when angle_has_build is true Required so that these can be overridden in .gn files. Will allow us to fix roll of ANGLE into Dawn. Bug: angleproject:6902 Change-Id: I8636778969ae489fdc7420414957d43fcfb634a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3627120 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Shahbaz Youssefi 14c483f1 2022-05-03T21:33:32 Presubmit: Verify comment before new tests A new presubmit check is added that looks for lines adding tests, i.e. matching `+TEST_P(`, and makes sure they are preceded by a pattern such as: ``` // ... - ... (optional removals) +TEST_P(...) ``` or ``` +// ... - ... (optional removals) +TEST_P(...) ``` If no comment is found before the test, an error is generated. Bug: angleproject:2626 Change-Id: Ibf76ae76ad3b1bb0efcf7eab8273153dd5c5162e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3626929 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll dc1ab34c 2022-05-04T10:01:19 Roll SwiftShader from cdf43bd816d7 to 643179694ec7 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/cdf43bd816d7..643179694ec7 2022-05-04 capn@google.com Always enable MemorySanitizer instrumentation for compute routines 2022-05-04 capn@google.com Always enable MemorySanitizer instrumentation for sampling routines 2022-05-03 capn@google.com Handle instrumentation of scalar single-precision (_ss) intrinsics 2022-05-03 nicolascapens@google.com Revert "Always enable MemorySanitizer instrumentation for vertex routines" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Iac0ec36bf22440318a3777613c2ac8fc727d89ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3627218 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 34fb4f79 2022-05-04T07:01:36 Roll Chromium from 55c89a3a09ac to 6db3a94387ed (508 revisions) https://chromium.googlesource.com/chromium/src.git/+log/55c89a3a09ac..6db3a94387ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a6ea5816b1..c812b8d227 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c7888dd707..ce96725bdd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ee8a311434..78e25c11f6 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ae9f091e95..460d235b06 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/933a62529e..e1bf83383b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..05b7cd33df * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e06e307750..13acea3645 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/b55552138c..9979c19f11 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/85c62c07aa..7593122778 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ea7a03c31e..78265207a0 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Icfeabafe0dc677d678048d1140e36c723b64ccb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3625681 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi edd331eb 2022-04-28T09:47:51 Traces: Add a device arg to restricted_trace_perf In case of multiple available devices, we can use either this argument or setting $ANDROID_SERIAL to select the device to run tests on. * Added the option to run restricted_trace_perf with more than one connected device. * The device serial can be entered either by using the --device arg or setting $ANDROID_SERIAL. If both are used at the same time, the former has more priority. * Neither is required if there is only one connected device. Bug: angleproject:6970 Change-Id: Id80398b82ea5b905f3dbfa4651d5f5246a3ccbe8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615082 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya a7238b52 2022-04-28T12:04:51 Consolidate handle list before pushing to mReleasedList Walk mUnallocatedList and try consolidating the range before pushing the to-be-released handle onto mReleasedList. This avoids a buggy behavior with dEQP which can be reproduced by running the following tests in this order - dEQP.GLES3/functional_samplers_single_cubemap_diff_wrap_t dEQP.GLES3/functional_negative_api_buffer_framebuffer_texture_layer Test: HandleAllocatorTest.ConsolidateRangeDuringRelease Bug: angleproject:7248 Change-Id: I8d2701f193fc6a2f36151c09719284a7832ab2d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3617198 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Jamie Madill 064fc64a 2022-05-03T13:49:50 infra: Remove some slow *SAN tests. This removes GLES-CTS 3.1 tests from TSAN/ASAN/UBSAN, and also removes some of the rotation-specific tests. We're running out of capacity on these configs. We can always add them back to ASAN and UBSAN as we see fit. Bug: angleproject:7264 Change-Id: Ic60df1ba36811b69c20f23e180485d932ae93ea2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3623864 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Stephen White 9ab47074 2022-05-02T11:51:31 D3D11: fix BufferToTexture copy when UNPACK_ROW_LENGTH is set. The BufferToTexture fast path rasterizes a point per pixel when copying buffer to texture, and uses the vertexID to determine the buffer location. However, the math is wrong if UNPACK_ROW_LENGTH is set. The fix is to use UNPACK_ROW_LENGTH (if specified) rather than the width in the Draw() call. Bug: angleproject:5542 Change-Id: If0bbc0d7ae3ecbb2211cfb27263324d23c5ff0af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621319 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Antonio Caggiano 9ad43bdd 2021-12-09T16:52:35 Re-land: "Vulkan: Support Wayland" Implement DisplayVkWayland and WindowSurfaceVkWayland. Get window size from native window and check egl config is just empty. An EGL wayland test is added for testing rendering and buffers swapping. Re-land fixes: - link failure in systems with no libwayland installed. - XCB display availability check. Bug: angleproject:6902 Change-Id: I5daecf3591493308ac71a7dd3bc0802f492e6fed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621059 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuxin Hu 5c9f676d 2022-04-28T18:43:38 Basis Universal Texture Experiment Adding a test to read KTX image data. Adding the inlined image data adapted from KTX file with ETC1_RGB compressed format. Bug: angleproject:7250 Change-Id: I96d704f27875fc01bcd31ac8657627f4e3a71755 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3616109 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Chris Forbes <chrisforbes@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 84e42c3b 2022-05-02T15:42:23 Fix validation cache when deleting a Transform Feedback. Bug: chromium:1320024 Change-Id: I76ef85a3c65c663c138d8caebd4ef2c0da53cd4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621780 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov b5f0fd1b 2022-05-03T09:03:59 Skip flaky tests on Win ASAN MemoryBarrierBufferTest.VertexAtrribArrayBitWriteThenVertexRead flaky timeout TimerQueriesTest.TimeElapsed flaky failure Bug: angleproject:7261, angleproject:7262 Change-Id: Ibd6e80bf71a7fe1702248f995d9d07851018a916 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621058 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll c0942c2d 2022-05-03T10:01:39 Roll vulkan-deps from 1cde45b8d7aa to 4ca7acf89869 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1cde45b8d7aa..4ca7acf89869 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/a9d23d7652..0c8a79b0b5 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/155ca6b868..191e261495 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2d83cbf35b..75a5d5459f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Id9df168fab4c492010dd5ac41d8b1c406b94911c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3622650 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c92d69d7 2022-05-03T10:01:18 Roll SwiftShader from adef92e7b4c6 to cdf43bd816d7 (8 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/adef92e7b4c6..cdf43bd816d7 2022-05-02 swiftshader.regress@gmail.com Regres: Update test lists @ 6fb4e049 2022-05-02 capn@google.com Remove legacy build defines 2022-05-02 capn@google.com Document the vk::DescriptorSet memory layout 2022-05-02 capn@google.com Always enable MemorySanitizer instrumentation for vertex routines 2022-05-02 nicolascapens@google.com Revert "Always enable MemorySanitizer instrumentation for sampling routines" 2022-04-29 capn@google.com Always enable MemorySanitizer instrumentation for sampling routines 2022-04-29 ari.suonpaa@siru.fi Fix heap corruption for empty descriptor pools 2022-04-29 capn@google.com Always enable MemorySanitizer instrumentation for blitter routines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I7af60f5411725bc07c046752c91f95fd07212c0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3623022 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 4bbc55f4 2022-05-03T08:19:55 Revert "Re-land: "Vulkan: Support Wayland"" This reverts commit e0dd196a0e0aace17dfaa204163d798f504ea94e. Reason for revert: blocks ANGLE roll into Chromium Original change's description: > Re-land: "Vulkan: Support Wayland" > > Implement DisplayVkWayland and WindowSurfaceVkWayland. Get window size > from native window and check egl config is just empty. An EGL wayland > test is added for testing rendering and buffers swapping. > > Re-land fixes link failure in systems with no libwayland installed. > > Bug: angleproject:6902 > Change-Id: I4f091d4f479a537d0390caedce88a5d39f8b356f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3608088 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:6902, angleproject:7260 Change-Id: I7e92bf811b191eee6679d577006cddc0e1286fad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621057 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 58526dea 2022-05-03T07:01:03 Roll Chromium from 929311ac6298 to 55c89a3a09ac (470 revisions) https://chromium.googlesource.com/chromium/src.git/+log/929311ac6298..55c89a3a09ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/35387279e4..a6ea5816b1 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/d8a47466e3..393e3eee99 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6039be79b9..ee8a311434 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/61ba3de9aa..933a62529e * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/36c15805b9..5ecb4635f0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..eebb0a0e63 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fccf35cb8e..e06e307750 * third_party/turbine: y4x80kUnDOxC5QyG48MlVoiRIEn09eaHcIJQFavlqgMC..zB1ls771w8S0URcjvMWxOHJ33pmUKq5Zr8zkbIMfvcsC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e53d3f018a..b55552138c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/12653c4be0..85c62c07aa * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/ca7c1ec42a..c8563c1c1d No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ibd9c8bb0ee709e4007a65db735542d0eadabd50d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621391 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 5113ae8e 2022-04-29T22:42:59 Vulkan: Explicitly enable per-sample shading if `sample` used The Vulkan spec is not explicit about the `Sample` decoration implicitly enabling per-sample shading. While this is being corrected in the spec, the ARM Vulkan driver does not have this implicit behavior. A workaround is added such that the usage of the `sample` qualifier is reported, and used to explicitly enable per-sample shading through the API. Bug: angleproject:6876 Change-Id: Idb8345aacdcfa45cb37fefcd30aa5405168d21e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615738 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Brian Osman 9200ba53 2022-04-26T12:05:07 Reland "Make SPIRV optional for Metal backend" Updated default conditions to match old behavior. This is a reland of commit 29287e1fc7ad3dff0619736a89e64b3598af8659 Original change's description: > Make SPIRV optional for Metal backend > > This allows clients (ie Skia) to build ANGLE without needing > all of the additional Vulkan dependencies. Developer builds > will continue to include both the direct and SPIRV paths, for > debugging purposes. > > Bug: angleproject:7155 > Change-Id: I1c38ee19e747df8b25fd2f8e8efa3b420a4d7766 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3605764 > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Auto-Submit: Brian Osman <brianosman@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7155 Change-Id: I439160f2e1f05a3dbe22df82336246a73a0a7d0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615012 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Charlie Lao 802504ad 2022-04-29T20:22:53 Vulkan: Add log for buffer pool stats For debugging purpose, this will calculate stats of buffer pool and output string to log. Set ANGLE_ENABLE_BUFFER_POOL_STATS_LOGGING to 1 will log stats into INFO() stream. Bug: b/230538246 Change-Id: I68f83af547e782ca7cb6cb222967ba02b8005083 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3617229 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Charlie Lao 4d26c66d 2022-04-29T17:39:22 Vulkan: Call cleanupGarbage only if mLastCompletedQueueSerial changed RendererVk::cleanupGarbage() walks through all garbage objects and check its serial with mLastCompletedQueueSerial. If it is completed then garbage gets destroyed. Right now it gets called from CommandQueue::queueSubmit(). But queueSubmit only submit new work, it does not mean anything have completed. Garbage clean up does not depend on submission, but depends on anything have finished. This CL moves the cleanupGarbage call to CommandQueue::retireFinishedCommands() where we update mLastCompletedQueueSerial. Bug: b/230921364 Change-Id: Ib07c4cc75a1d2bd243377fa1215588d8ea4e3f36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3617227 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Brandon Schade 527557b9 2022-04-28T14:35:30 Fix ValidateFramebufferTextureLayer for cubemap arrays GL_INVALID_VALUE is generated if texture is a cube map array texture and layer is larger than MAX_ARRAY_TEXTURE_LAYERS-1. GL_INVALID_VALUE is generated if texture is a cube map array texture and level is larger than the log base 2 of MAX_CUBE_MAP_TEXTURE_SIZE. Fix validation to account for the spec. Bug: angleproject:3584 Tests: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.framebuffer_texture_layer Change-Id: I51028145fa83ef5eb46c39030a28984411ca801e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615613 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0