kc3-lang/angle/infra

infra

Log

Author Commit Date CI Message
Yuly Novikov b12d4867 2023-11-13T19:35:54 Revert "Temporarily remove trace bots from CQ" This reverts commit 0f7c39a2abbf516443d6e11ba90bc6a3d084e8ca. Reason for revert: trace bots switched to reclient Original change's description: > Temporarily remove trace bots from CQ > > Reclient doesn't work yet > Goma is slower than local today > > Bug: angleproject:8309 > Change-Id: I03c337dab5ee82adc8e03d4f5f52bf2b26aa7cad > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4818506 > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Roman Lavrov <romanl@google.com> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Roman Lavrov <romanl@google.com> Bug: angleproject:8309 Change-Id: Ia64d089b759f61570b467e44d566d56e0d0c1534 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5025974 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Takuto Ikuta a46cc37f 2023-08-17T16:35:14 infra/config: remove goma property Bug: angleproject:8309 Change-Id: Ia657986ebc3bc49423736af743983bec6467775a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4787413 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuxin Hu c22f46b5 2023-10-23T11:52:20 Update rgb-565-no-depth-no-stencil test suite names Replace the "-" with "_" in the test suite names to be consistent with other test suite name formats. Bug: b/297901032 Change-Id: Idbfc1bc7aa7cef4382e3cdd3e223db28f414f15e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4968792 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuxin Hu 43acadab 2023-10-06T15:05:36 Add missing configurations for khr tests KHR-GLES* tests are ran with configurations defined in glcKhronosMustpassEs.hpp: https://github.com/KhronosGroup/VK-GL-CTS/blob/main/external/openglcts/modules/runner/glcKhronosMustpassEs.hpp, when launching the conformance test from Khronos Conformance Package. This change adds the missing configurations in test_suites.pyl, for vulkan backends and swiftshader backends. Bug: b/297901032 Change-Id: I87e77ca8756b883ef08551919f67904ecf21aa97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4918582 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 856a6ec0 2023-10-03T17:17:35 Enable rgb-565-no-depth-no-stencil tests on Android Bots Enable gles3 and gles31 rgb-565-no-depth-no-stencil tests on Android Bots. Khronos conformance package ran the gles3 and gles31 tests with rgb-565-no-depth-no-stencil configurations on Android devices: https://github.com/KhronosGroup/VK-GL-CTS/blob/main/external/openglcts/modules/runner/glcAospMustpassEs.hpp#L41 Enable the rgb-565-no-depth-no-stencil configuration tests on Android bots to cover them. Non-Android platforms do not support rgb-565-no-depth-no-stencil configuration. We should not enable it on non-Android platforms. This CL also disables this configuration from building on non-android platforms in src/tests/BUILD.gn. Bug: b/297901032 Change-Id: I23d83213818884ea679dd76bf4b001c3b636dffc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4908171 Reviewed-by: Roman Lavrov <romanl@google.com>
Yuxin Hu 8b9500ae 2023-09-28T16:15:21 Enable multisample deqp tests on bots Enable gles3 and gles31 deqp multisample tests on bots. Khronos conformance package ran the tests in gles3 and gles31 mustpass list with multisample config rgba8888d24s8ms4: https://github.com/KhronosGroup/VK-GL-CTS/blob/main/external/openglcts/modules/runner/glcAospMustpassEs.hpp#L24 Enable the multisample config tests on bots cover the tests. This CL only enables the multisample tests on Vulkan backends (including swiftshader) on Android, Linux, Windows, as we are prioritizing vulkan backend development. Bug: b/297901032 Change-Id: Iaa830bd466e3564bb1e83c98cc360bd5a85abf86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4903430 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll e3794967 2023-09-15T07:36:40 Roll Chromium from a50e493e11b5 to 0324498f6cbf (556 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a50e493e11b5..0324498f6cbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7aea0d4843..7070803978 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/692dc363e0..7d64f08b6b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5cf0cb5238..a43f7b6121 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e407b66e5f..1eb44db04a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4a4428445d..f2e3352a0e * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/68a6f0b882..55030e041c * third_party/r8: 3kYZB8oSh1P15bfu_s8B4M_5KPhjLhyidp2lyRVqWroC..g3ZKfFfRYNZNHJUs07J5hb92ua_jvjdrbo7I1R585uwC * tools/luci-go: git_revision:fcec56a73e7375ba26e10e053cee92e06b4636ca..git_revision:8b73cff3b780a7136c4904103f19124d2be3dee1 * tools/luci-go: git_revision:fcec56a73e7375ba26e10e053cee92e06b4636ca..git_revision:8b73cff3b780a7136c4904103f19124d2be3dee1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/18e77c0dbd..24e9980b2f * tools/skia_goldctl/linux: FdyOkAznuQ7k2iieFXsUTpz6jBaUHPGw8fNxb1-0JLMC..ESgfYW4L5Q_Q2351ztbGdFg0Ah6n00uuT_oMYgXyH8gC * tools/skia_goldctl/mac_amd64: 9RuiM5HJiEHkr27MLsTx04jOTEYQG-D_3P1BCrM03q4C..iCXL6g3XKCBXYlkzMZDeqGgTdEW9yRzsVCcs2W-37DUC * tools/skia_goldctl/mac_arm64: tDNHYe-tSHHr68Th6urfIcXLngT2yJ2jCyZBQLAB5mYC..bggzdegdOzNu60PwM5sfR-MkL2LWBAHCHhsnyOuHO-UC * tools/skia_goldctl/win: 3VsnMzWsw1jy9-ZgvgPjR5emUA1IwrCNkX8xYK8oxFgC..Y82RNxTKD09wbNGEQlGS9HJf4fZRrSVq9cX6AZB7Q00C No update to Clang. Bug: angleproject:8317 Tbr: ianelliott@google.com Change-Id: Ia07bc5caac8acd337ea5f4725301b45371369347 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4867445 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b4848e85 2023-09-13T08:05:26 Roll Chromium from c661891ca003 to 459a6b238bc8 (608 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c661891ca003..459a6b238bc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1a25429fe3..4420c4de06 * buildtools/linux64: git_revision:cc56a0f98bb34accd5323316e0292575ff17a5d4..git_revision:991530ce394efb58fcd848195469022fa17ae126 * buildtools/mac: git_revision:cc56a0f98bb34accd5323316e0292575ff17a5d4..git_revision:991530ce394efb58fcd848195469022fa17ae126 * buildtools/win: git_revision:cc56a0f98bb34accd5323316e0292575ff17a5d4..git_revision:991530ce394efb58fcd848195469022fa17ae126 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ce02ccbb6e..f79e60f037 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/ff414082cc..7ebbd1ea9b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4ca9d0910a..ddbdff3f20 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8babcb7e2e..bcba178212 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d5209a75b3..d3ed8c086c * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/0568576055..d9b4abf6b6 * third_party/r8: fR4aBtFTaohfSjV_Y54-1MC5dV2cTK7iZrFUiGoVivgC..oP1tOCigL9cN6j-dfqmgRtMV5zOSZQ2IgaG11GSyNP0C * third_party/siso: git_revision:d967f854b8fcd36e484df1b6677fb003a8f48a8b..git_revision:412571deccd76eb54f681963ca14e13c3efc63e1 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/438abc2caa..4bead2e08b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bea2565145..18e77c0dbd No update to Clang. Bug: angleproject:8315 Tbr: ianelliott@google.com Change-Id: Ica0a5bc156efd51b6b8ea07c28113944b15a40f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4860376 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov a469a5d3 2023-09-12T17:28:14 Hide mac-exp-test from LUCI console Experiments were finished Bug: chromium:1456549, chromium:1462473, chromium:1464635 Change-Id: I55f3da2578c84f3d622a5027c07aafed6d02241b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4859442 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Yuly Novikov 8cca7db3 2023-09-12T15:23:35 Stop Mac experimental bots, restore CQ testing on NVIDIA Mac NVIDIA machines were upgraded from 10.14 to 11.7.9 and are stable on experimental bot, so CQ testing can resume. Mac Intel and AMD were upgraded to 13.5 on stable bots, experimental testing can be shut down. Bug: chromium:1456549, chromium:1462473, chromium:1464635 Change-Id: Iea572008ac7edc494df657f02ed063a83096de37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4859441 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Roman Lavrov 1249fc1f 2023-09-07T14:39:26 Tests: Support capture_tests on Android and enable on CI Enables angle_with_capture_by_default = true on Android bots similarly to Linux and Windows. Enables the capture test on Pixel 4 and 6 bots (it takes only a few seconds to run) Enables support for capture in android_helper in general. For example, this now works the same way it would on say Linux, but runs the capture on the device an pulls files to OUT_DIR. % ANGLE_CAPTURE_LABEL=gacha_club ANGLE_CAPTURE_OUT_DIR=/tmp/capt2 ANGLE_CAPTURE_FRAME_START=16 ANGLE_CAPTURE_FRAME_END=16 out/AndroidPerformance/angle_trace_tests --gtest_filter=TraceTest.gacha_club --use-angle=vulkan --retrace-mode --max-steps-performed=20 For end2end tests it's a bit trickier as we're still using the Chromium wrappers for e.g. out/AndroidPerformance/angle_end2end_tests - which is why capture_tests.py is currently using angle_android_test_runner.py Bug: b/296397568 Change-Id: I2606e74a17c90e381bb49ec8d555a6d24851b4f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4850889 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll c7b7972d 2023-09-11T07:00:48 Roll Chromium from 5a5b1cec68d0 to 9cc28010e63d (748 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5a5b1cec68d0..9cc28010e63d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d674d1e8c1..75d51b6a24 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/05a91b5126..ded28ebda2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6bd9179603..2d15e4bbe7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7f5b53ff8d..80226254ea * third_party/fuchsia-sdk/sdk: version:14.20230902.2.1..version:15.20230909.2.1 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/331847d7a5..e9c37571a1 * third_party/r8: 3phdyAHwQKjlTdh7tE5hbtnIUOYawn0ewGrKJdykjf8C..fBg5UVKZ-YCVie2gVbsVuh6YoknsrBf6z4-Ca61O2p8C * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/7cd7332af2..438abc2caa * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/193e3617a6..5c46fabf81 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3895d9dc40..2508903706 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8bed384b0f..b662560f84 Clang version changed llvmorg-17-init-16420-g0c545a44:llvmorg-18-init-4631-gd50b56d1 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/193e3617a6f436a57a0eda57ce3ebc6c1d6a6b0e..5c46fabf81887bcf9e6292551e38b8d0fd03548f/scripts/update.py Bug: None Tbr: syoussefi@google.com Change-Id: Ic03ac056ca4d1eeec11bd675898f841204335224 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4856257 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 83030fed 2023-09-08T10:18:57 Tests: rename isolated_scripts groups isolated_scripts_group_pixel6 currently has one item but more is coming Bug: b/296397568 Change-Id: I404cc24331c8d31a51e21c15d28040a7c7507945 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4850870 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 265f3d36 2023-09-07T09:52:21 Roll Chromium from e89c33139c50 to 4ae31457f4f5 (1177 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e89c33139c50..4ae31457f4f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b60aaa976e..aeaf972223 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6830d4d2f7..5b92cc5301 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7affa303ea..d7df3f77cd * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/23d868f674..801bc6657b * third_party/android_build_tools/lint: Bd9m0RpzuCbbURLUADcdPsU2Yrrfg453Djw_jY7kVEYC..2ilHXL8jElnQimOXXEaawIQ9Gn2FY6ZWfBl34Ico_owC * third_party/android_build_tools/manifest_merger: kkbYOGsVRXhtxBiXuTufY0puTnG5QAfyxvFTBHFWL08C..ki-ikxybU11aNNE3tvffa5JaDIUy7dGTBAtWRz_O6Q4C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f16ca3c78e..3e023e6fe1 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6715758ed9..68ccac685a * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/a321409e66..0568576055 * third_party/r8: pPu68_FQSs0xNMEZVIArwK8p8SkQ5XgGXxrBGVOI5FQC..LrWtF7Gfts11G550w5xD61mhL5_0R9IxcPm-0bj735EC * third_party/siso: git_revision:c15d52005df612e58accf13efde4d99ffcdfe38f..git_revision:50cf1b4292c8c1398608409f5c79db3ecae0dab8 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/c6b57c49ce..7cd7332af2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9fc887ccde..193e3617a6 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/51e8fbac5d..8656ad6936 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/702d2ac502..346d862fa0 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ied7e09db45636194269e80dcdf04e1a6f68f1c1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4849368 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 0f7c39a2 2023-08-28T16:14:10 Temporarily remove trace bots from CQ Reclient doesn't work yet Goma is slower than local today Bug: angleproject:8309 Change-Id: I03c337dab5ee82adc8e03d4f5f52bf2b26aa7cad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4818506 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Takuto Ikuta 7ede4232 2023-08-18T17:39:10 infra: switch angle builders to use reclient Bug: angleproject:8309 Change-Id: I1270611d13e9c8041414b2e00dfd3eec1b616bc4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4787412 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Takuto Ikuta 3a5d67ce 2023-08-17T16:25:52 infra/config: add reclient property This CL is no-op but updated config is used in later CL. Bug: angleproject:8309 Change-Id: I49b6ae34ff9abc4eb30c864c5eac3d816b0a4298 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4787411 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Takuto Ikuta 065c93dd 2023-08-17T11:03:08 infra/config: remove unused property This is to reland https://crrev.com/c/4778427. Bug: None Change-Id: I01d9ee2e55a649a235a91f9e78698bd5803d5d7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4787408 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi d7d78adb 2023-08-15T10:07:39 Infra: Use more shards for SwANGLE/end2end tests on TSAN Bug: angleproject:8297 Change-Id: I11e70e7af63abf8c1ed37dcb2812091d09cf5434 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4780391 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 370e9ca0 2023-08-09T17:07:48 Add experimental Mac NVIDIA bot specs Bug: chromium:1456549 Change-Id: Ia7565bf6de02e36ee82affec64f27ee591a6cce7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4765134 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 3ad8d912 2023-08-08T17:44:03 Roll chromium_revision 2140415f50..e37ae34e9f (1179456:1181024) Rename third_party/android_toolchain to third_party/android_toolchain/ndk due to https://chromium-review.googlesource.com/c/chromium/src/+/4728129 Change log: https://chromium.googlesource.com/chromium/src/+log/2140415f50..e37ae34e9f Full diff: https://chromium.googlesource.com/chromium/src/+/2140415f50..e37ae34e9f Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7dd254d602..a5321f10c9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/79ab87fa54..a9a6f0c49d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7a3b32e55f..9ae730e481 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d7f301be80 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fc36eba70b..2f873f7c22 * third_party/fuchsia-sdk/sdk: version:14.20230727.2.1..version:14.20230804.1.1 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d4760c0af9..cc2a32ba83 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/e5a9c50e5e..b113f23e4c * third_party/r8: OdhGaLChEyG23to4T8_V2aMCAZi970T4B4t8ih0tNGsC..dbml4pnGIsEBy3dFYki-S8IYt4jxxqZXaUDwtY3Q-SgC * third_party/turbine: njzYdPKg07o6bisJmD2GAMXIi0p3KPbBy93bLGnp2TYC..HFp7iOu-n4-CdEasFTQZvD1Vg1L-q1URqRTOM-iZ2AMC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/7cd5bbdfe4..e309c7523b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/02d5529a3f..078c92947e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bee2ccad89..988a4dec39 DEPS diff: https://chromium.googlesource.com/chromium/src/+/2140415f50..e37ae34e9f/DEPS No update to Clang. Bug: chromium:1469911 Change-Id: I5ac8510d880a092e838c4fa797dd3748976d358c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4760727 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Solti 135a24fc 2023-08-04T17:18:31 update Wrangler runbook Test: default presubmit Bug: b/289824244 Change-Id: Ia3e91196a6b1ede51d1ae55b7a2f76357010e782 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4753732 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Solti Ho <solti@google.com>
angle-autoroll b53d99d8 2023-08-01T07:01:04 Roll Chromium from 1cd9335ae38e to d27b5fe3e6fd (523 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1cd9335ae38e..d27b5fe3e6fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/300fe30c80..32a858d0c6 * third_party/android_build_tools/manifest_merger: 8fr-1Vf_pfxN9ulzWVaZvIXggDgWDs-0dtlGA1Sue48C..d1tFnzOW6H5xoDN7WWsMuAiHuhkl0kXijQGiO7IU1VQC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fae769bddf * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8424103c4e..a8946f3d83 * third_party/r8: QJNQAx1B3aL7NHHWyWAOLYCzEWfggtFhljm4b2wNk0wC..5zBwrOBV6XLXneCTZuxcrWGyYYZ25ZZC0t4dVtUEnFwC * third_party/turbine: 2I2Nz480QsuCxpQ1lMfbigX8l5HAhX3_ykWU4TKRGo4C..njzYdPKg07o6bisJmD2GAMXIi0p3KPbBy93bLGnp2TYC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/43f8a41f8f..3bb8a70706 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/236e66ffd6..02d5529a3f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/19f0f9d6bf..aaaca01444 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2c5f3235ed..6c7511171d No update to Clang. Bug: angleproject:6430 Tbr: yuxinhu@google.com Change-Id: I875617e13047c35727029fac7437fe928681ce21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4735569 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 19dbaf11 2023-07-24T17:38:46 Mention the SwiftShader -> Chromium autoroller for Wranglers The ANGLE team should make sure that the SwiftShader -> Chromium autoroller stays green. If it gets too far out of sync, ANGLE's testing within the ANGLE waterfall and Chromium waterfall will diverge. Keeping this roller green is also critical for security issues fixes to propogate to Chrome. Bug: None Change-Id: I650d906bbbd8c522b85082965f128a1bf071ae78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4711827 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Brian Sheedy ec2948c5 2023-07-13T13:38:52 Start Mac Intel 13.4.1 experiment Bug: chromium:1464635 Change-Id: Ie7cf5d68fff54b0b58ca1a4c102ab8c8368bd3ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684014 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov e8e17211 2023-07-17T15:20:14 Retry angle_deqp_gles2_metal_tests Flaky crashes in OSXWindow::messageLoop(), like the other GTest based tests on Mac, which already have retries enabled. Bug: angleproject:6570 Change-Id: I65ffc4b09a6ece68dcfe404055fcfe50d013c000 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685573 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll a18246ac 2023-07-17T07:26:08 Roll Chromium from 68d783529187 to 48a8f73f303f (690 revisions) https://chromium.googlesource.com/chromium/src.git/+log/68d783529187..48a8f73f303f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7565823755..a158d61f27 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2bac855313..b98bc2989c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/6514de5457..9ce3e620bd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..394c179782 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/abbd5858fa..b389d031a2 * third_party/fuchsia-sdk/sdk: version:13.20230711.2.1..version:13.20230714.0.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4786f206b4..c05e52187e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f8f7cb6141..5ce938841d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/86375f9e21..a2303f1c72 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/27e9a92f3b..e10259da24 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I3f305f69842c73569aad368fb3fb7d222c91d231 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4688527 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop cdb822e7 2023-07-13T09:45:00 Revert "Android: Assert that CFI is disabled" This reverts commit 43ef50f389e97131dc487081d6c8c02373e4a22c Reason for revert: LLVM bug is fixed upstream. Fix: https://reviews.llvm.org/rG92fbb602f3b635110417e40e2f774b31798b0b1d LLVM Roll: https://chromium.googlesource.com/chromium/src/tools/clang/+/243d4473a3739d43cab35eeb0b4934bf5f7a7d05 CLs in the roll: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/7586aeab..0c545a44 Original change's description: > Android: Assert that CFI is disabled > > There appears to be a bug in the interaction of CFI and > relative vtables. On armv9 it results in a crash with SIGILL > when loading traces. > > Since we can't overwrite the flags used to control this > just assert that it is correct in GN args. > > To avoid the assert, add the following to your GN args: > > arm_control_flow_integrity = "none" > > Test: Build and run traces on armv9 devices > Bug: b/278955379 > Bug: chromium:1441148 Test: angle_trace_tests on ARM v9 device with flag removed from GN Bug: b/278955379 Bug: chromium:1441148 Change-Id: Ib90405a143503896041c2522f484c234a943a6fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684008 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Yuxin Hu 759027e8 2023-07-07T14:51:56 Enable the new deqp khr test suites on Bot This CL enables the deqp khr test suites added in https://chromium-review.googlesource.com/c/angle/angle/+/4654841 on below bots: pixel4 vulkan backend pixel6 vulkan backend windows vulkan backend linux swiftshader backend linux swiftshader backend tsan linux swiftshader backend asan The current linux driver on bot does not support the new test suites on vulkan backend. We will enable the test suites on linux vulkan backend after we upgrade the bot machine driver to a newer version: https://bugs.chromium.org/p/chromium/issues/detail?id=1271688 Bug: b/286921997 Bug: angleproject:8251 Change-Id: I659424efc09028f685edff076711c9089ec635d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4673582 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 648f24c9 2023-07-10T17:59:29 Start Mac AMD 13.4.1 experiment Bug: chromium:1462473 Change-Id: Ic30d5f5a0999c10949581aff813febdb83a8cef9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675805 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
angle-autoroll db6b0357 2023-07-10T16:24:53 Manual roll Chromium from 8a1e61637248 to 749d653d9a36 (139 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/8a1e61637248..749d653d9a36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/11876f21fd..24349b4e60 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7d7df42f80 * third_party/turbine: 9rSngS4o9OIlNubLcU1zXF_w0dPYif6AS-_k1pPAV1kC..2I2Nz480QsuCxpQ1lMfbigX8l5HAhX3_ykWU4TKRGo4C No update to Clang. Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I7fd7532722aca9f5a7d7bdd42bf3a0ef92fe95f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675961 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 55279449 2023-07-03T19:42:52 Roll chromium_revision 2e0371f07e..ad19957265 (1162850:1165395) Don't update testing beyond https://chromium.googlesource.com/chromium/src/testing/+/8e38c8e8a6b4251a2f9584d9d9bfbf261d0c1835 Remove $mixin_append usage due to https://chromium.googlesource.com/chromium/src/testing/+/a5415f3c674a065cc541c618df12262073d4d10e Change log: https://chromium.googlesource.com/chromium/src/+log/2e0371f07e..ad19957265 Full diff: https://chromium.googlesource.com/chromium/src/+/2e0371f07e..ad19957265 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e4262406c0..e0690c7c78 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f089c59d7c..6d00f8d8c5 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/b272a1c128..84fb809dd6 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/b5a43ecdac..f1c687e0aa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/46c0754180..ac3cb62a5a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/66a5ea107e..7d4c4bf473 * third_party/android_build_tools/lint: kqQgSDAgfuKTUIT8gpYlhM9gvajbtIDs_ApDbh3wdNIC..DjoXGsdMeTwnppye9Nwe5ozhXIqKyJQDzgb0nTFH8SAC * third_party/android_build_tools/manifest_merger: pRHDE8UAgipcDQINCUsRz94lgm5BHQjiL-BLF6d6xC4C..MN3CF2GQ8xeB6obj4qf5J6l15-NoA43u4__RQTTe8I4C * third_party/android_toolchain: version:2@r25c.cr1..R_8suM8m0oHbZ1awdxGXvKEFpAOETscbfZxkkMthyk8C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..48b31edbfc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f0fba1d307..872ac9bd3d * third_party/fuchsia-sdk/sdk: version:13.20230626.3.1..version:13.20230629.2.1 * third_party/turbine: G8Cku1fztaDd9to_8gk3PNWM2iRacAxD9zcUAgUPUEAC..9rSngS4o9OIlNubLcU1zXF_w0dPYif6AS-_k1pPAV1kC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f81f385906..f999826d2d * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/5c2008090e..39d4cc4ec8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/053092c268..36a80749cf * tools/luci-go: git_revision:39f255d5875293d3e1d978888b819ac124a8b0cc..git_revision:15be1e7f953cb4ef6d88aba86f57ca28724d1c9a * tools/luci-go: git_revision:39f255d5875293d3e1d978888b819ac124a8b0cc..git_revision:15be1e7f953cb4ef6d88aba86f57ca28724d1c9a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f80577ef22..33899440a1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/daed2f7981..422351564c * tools/skia_goldctl/linux: tVDltUu_xw7_tk4k-rnp7Ua8pKhf3EEHmTwX5c6BS4AC..209WoWuXITgke_BJDnvM7aTy7wu2jFOUPYs4uIoJ3CAC * tools/skia_goldctl/mac_amd64: ov_DuOSHCneWQSTW6AZ9gWHEeoJxXEYDX9dl_0rA_d0C..vEHTSSZiGWhNdCjMGZ22sj4PfyPzgoIIkV97YXOJeKEC * tools/skia_goldctl/mac_arm64: 3wDkZAVD4vV1dNhXfRNMOUBvODbzJ23AVmmsFbTsbkQC..CcHM6-LZ7_b-Api718RTCYQPD0v17lWKuQBaz42b8r4C * tools/skia_goldctl/win: yW7os_HVMoE-wq04olb6B7GNgEmaYZYPN0ecTzPPBdkC..u5j7yik1xZdFc9dECFfFDX9vRP9go2GpqukfJwOLCbgC DEPS diff: https://chromium.googlesource.com/chromium/src/+/2e0371f07e..ad19957265/DEPS No update to Clang. Bug: chromium:1456553 Change-Id: I1c18e6c6f68c7d24ae72a6754c707397a4c739d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4660052 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll bcfc214f 2023-06-27T09:49:12 Roll Chromium from 14fa1a826dad to 2e0371f07e01 (1224 revisions) Manually update third_party/flatbuffers https://chromium.googlesource.com/chromium/src.git/+log/14fa1a826dad..2e0371f07e01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4438010153..e4262406c0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ad9b993f2f..f089c59d7c * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/745104ff4a..b272a1c128 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/75c78f8f64..46c0754180 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8f8f07bdce..66a5ea107e * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/3b0115d9f8..4cb10f1315 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1a0894f20f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98d3bb27f0..f0fba1d307 * third_party/flatbuffers/src: https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/13fc75cb6b..28861d1d7d * third_party/fuchsia-sdk/sdk: version:13.20230622.3.1..version:13.20230626.3.1 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/9b4ea9e0d4..5c2008090e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ff9b9e9ce2..053092c268 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/31a576a999..daed2f7981 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I7bf9a5c427845ac28e9cc70051c9b07381313cc9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4649047 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov f834ba7f 2023-06-23T13:48:44 Switch Linux SwANGLE testing to Ubuntu22.04 Turn off experimental builders at the same time. Bug: chromium:1380082 Change-Id: I1cf5f3efef791819ad01af63197bb931af10e019 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4639183 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Yuly Novikov 74cf0be3 2023-06-21T15:25:28 Temporarily remove NVIDIA testing from mac-test To facilitate removing macOS 10.14 support while MacBook Pro 2013 machines are being upgraded to a newer OS version. Bug: chromium:1456549 Change-Id: Ibb3e597d82482c1c86010f94aa4c75cd9bf44995 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4632818 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 46ff02f8 2023-05-18T13:52:29 Capture/Replay: Initial setup for angle_capture_tests Implements the first part (FrameCapture) of the proposal go/frame-capture-and-interpreter-testing Adds a basic test (CapturedTest) with a few frames. This test gets captured by capture_tests.py into a temporary directory and the resulting files are diff'ed with the files under expected/ A diff fails the test. When capture changes, the workflow would be to run the command indicated by the error message in the test which will overwrite the files with new ones so that they can be added to the CL. Example test failure on capture change: https://chromium-swarm.appspot.com/task?id=62b5f4034527c610 when testing https://crrev.com/c/4598046/3 Tests in CI: https://screenshot.googleplex.com/77o8vZVuj8AbFRj Also adds a "angle_capture_tests_trace" lib with the trace just to test that this capture also builds, the lib is not currently loaded by anything. Bug: b/286067106 Change-Id: I7d5f6eed088d84f9e3eb8a72b24b1d92515fff38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4545408 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov f102184d 2023-06-13T14:34:07 Make Test spec JSON generator hashless. Removes scripts/code_generation_hashes/Test_spec_JSON.json Instead, run codegen in --verify-only mode and compare content. This run during presubmits and is fast (~0.2s in my tests) Similar to https://crrev.com/c/4604579 With this, should be able to auto-resolve conflicts in infra/specs/angle.json Also testing/buildbot/mixins.pyl seems to have had hashes routinely updated by autorolls. Bug: angleproject:8193 Change-Id: Ic1a657dbf464e6f4a8066ea8c5e18297e27a3b4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4605467 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov df787cf0 2023-06-14T17:56:11 Add ANGLE experimental SwiftShader builders For testing Ubuntu 22.04 Recipe-side CL http://crrev.com/c/4614428 Testers: linux-exp-swiftshader linux-exp-swiftshader-asan linux-exp-swiftshader-tsan Builders: linux-exp-asan-test linux-exp-tsan-test Modify LUCI MILO console to show only the active experimental builders. Bug: chromium:1380082 Change-Id: Iac74b606fca7b1762028cebf4868e691b3ed074c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4614533 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cody Northrop 43ef50f3 2023-06-08T15:35:17 Android: Assert that CFI is disabled There appears to be a bug in the interaction of CFI and relative vtables. On armv9 it results in a crash with SIGILL when loading traces. Since we can't overwrite the flags used to control this just assert that it is correct in GN args. To avoid the assert, add the following to your GN args: arm_control_flow_integrity = "none" Test: Build and run traces on armv9 devices Bug: b/278955379 Bug: chromium:1441148 Change-Id: I71bf93dca9bd15d6c66ad2a7223d9bbd0c54392e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4602027 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 3e4f4cae 2023-06-09T12:02:52 Tests: reduce load on perf bots by collecting less data Collecting this data takes a significant amount of resources but we do not actively use it at the moment. Disable --split-shard-samples (will avoid separate calibration on each shard) Reduce samples to 6 (from default 10) Bug: angleproject:7671 Change-Id: I87d45f21badb30ed44de9b9854c94fe7f67ecdc8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4605335 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 9208efb6 2023-05-19T16:56:59 Stop ANGLE Mac Intel 13.3 experiment Bug: chromium:1429033 Change-Id: I2a4cf72d68855c54b87fc33bc6b0c150ad5246ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4549123 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll d238e8b9 2023-05-17T21:20:43 Manual roll Chromium from 79f85a216141 to bc320a94824d (1646 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/79f85a216141..bc320a94824d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/44a4b24b05..36246d88fa * buildtools/linux64: git_revision:26aa46c283e40199b6f847ecca088dcea7099ded..git_revision:6975103d9f59ed9f3cfbc6d2201298f2c2fde046 * buildtools/mac: git_revision:26aa46c283e40199b6f847ecca088dcea7099ded..git_revision:6975103d9f59ed9f3cfbc6d2201298f2c2fde046 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f2cb09f94e..7454e17b0d * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/129773dde5..55ceecab99 * buildtools/win: git_revision:26aa46c283e40199b6f847ecca088dcea7099ded..git_revision:6975103d9f59ed9f3cfbc6d2201298f2c2fde046 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9d1f44540f..7e91557f2b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/534624edd1..72efcb2452 * third_party/android_build_tools/aapt2: fFfHyo80O9opPFsbOisSHF4d3tV4GGxLgxXWzGRuY2IC..aidBg3POIv_jPt-kZ7O9aQ6-UdFSuLd8uBgGg4REBjsC * third_party/android_build_tools/lint: MTFSl9JaPMnHhDPun-Ry9w5lM4HeEVlSFebjgzoraCQC..AS57ntD4VO2MAIu0pkI0b3c3cFkdGt0cAkmSkiRimZkC * third_party/android_build_tools/manifest_merger: VcQAPv15h63jZcRobvLMBWCiuDXUdmwB8OH1x6W1aJMC..HW7DJwNOXl50MEneaQnyD1Yg1sy_0Eej5E1nKepXq40C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f1f7a299cb * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a1e578320b..cdefe67b38 * third_party/fuchsia-sdk/sdk: version:12.20230512.2.1..version:12.20230517.1.1 * third_party/turbine: j0GanRK31QhKNs04PYT0D3ls32n6IrjrAL8bR4dv9jMC..sTawWbD0GN8RYp6JHHFxxGNi2nNPvuNSuBjIpS4GaD0C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/062d938956..096dcd2735 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d0e45e54c3..f4fa549a2b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/25bb7e161f..c278749207 No update to Clang. Bug: angleproject:8081 Tbr: yuxinhu@google.com,ynovikov@google.com Change-Id: I6d78dc2cd54eac092554bb3792a32561a39f00ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4545305 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 39ac3fab 2023-05-10T17:43:17 Start ANGLE Mac Intel 13.3 experiment Bug: chromium:1429033 Change-Id: I8c640004f3255b8c563e172b8bbce9c516437277 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4517830 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Yuly Novikov a7b26adf 2023-05-09T18:12:27 Revert "Retry flaky failures on SwiftShader *SAN builds." This reverts commit f0d2dbec74362c07806d9adb57f27bfa2ff6e91c. Reason for revert: flakiness root cause expected to be fixed Original change's description: > Retry flaky failures on SwiftShader *SAN builds. > > This should green up the TSAN builder. > > Bug: chromium:1275223 > Change-Id: Id8dc2e35b739caa6688d13fcabfefb9833940d79 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3804745 > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Auto-Submit: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1275223 Change-Id: I53645f859d7288fb82c258a0540259ae8a9e7138 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4517644 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 1a847d4a 2023-05-08T07:01:47 Roll Chromium from 16e9449c3c88 to d08108198321 (723 revisions) https://chromium.googlesource.com/chromium/src.git/+log/16e9449c3c88..d08108198321 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/54bd39c0c5..d609da478e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/dd3595d173..a26ff314e9 * buildtools/linux64: git_revision:5a004f9427a050c6c393c07ddb85cba8ff3849fa..git_revision:3dadaf0ee3ee07d7c29ad926e1a42d90068d7e6b * buildtools/mac: git_revision:5a004f9427a050c6c393c07ddb85cba8ff3849fa..git_revision:3dadaf0ee3ee07d7c29ad926e1a42d90068d7e6b * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/737446fc52..f8279b0108 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/66967963e9..d5e79e117c * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/88bd83fe09..229ff3e232 * buildtools/win: git_revision:5a004f9427a050c6c393c07ddb85cba8ff3849fa..git_revision:3dadaf0ee3ee07d7c29ad926e1a42d90068d7e6b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7a97f0e3c4..74258afcd3 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/eec484b5a6..2248225726 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7924448af6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/71ab1b77a7..4931c18599 * third_party/fuchsia-sdk/sdk: version:12.20230504.4.1..version:12.20230505.3.1 * third_party/r8: 7-lseJ9e9PfiZg_2LgyaUA4ru9NwaTGoDwYGMYP0BeYC.._FuL1VmaJnETpwNIaiuiSLxVNzzt0qXGmsfAck4CPCkC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/dc8628ce87..0377ee52d9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/02f2a2edd4..5b4a9ede47 No update to Clang. Bug: angleproject:5223,angleproject:6430 Tbr: cnorthrop@google.com Change-Id: I319fdde69f4ff5b854a86f45c70175a2eb03cf77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4511879 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll df8733c9 2023-05-05T09:08:55 Roll Chromium from becaac9672a0 to 16e9449c3c88 (618 revisions) https://chromium.googlesource.com/chromium/src.git/+log/becaac9672a0..16e9449c3c88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1345fb9c5d..54bd39c0c5 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fe9a4e4107..dd3595d173 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9460fb138d..737446fc52 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/19470647da..7a97f0e3c4 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/f0c7b47622..f312145c41 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/5353fa6142..d8e55758cb * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6b573b0676 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dbcecc9017..71ab1b77a7 * third_party/fuchsia-sdk/sdk: version:12.20230503.3.1..version:12.20230504.4.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9969814713..448305bbeb * tools/luci-go: git_revision:e91834850a06011c64eb9a24f317371194bde3de..git_revision:55cc876158c057cd64677f1a1a2573c36c6c3025 * tools/luci-go: git_revision:e91834850a06011c64eb9a24f317371194bde3de..git_revision:55cc876158c057cd64677f1a1a2573c36c6c3025 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/295d9239b1..dc8628ce87 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ce6519bca3..02f2a2edd4 * tools/python: https://chromium.googlesource.com/chromium/src/tools/python/+log/00ecbd0693..64dd0e593f * tools/skia_goldctl/linux: CxdbSDz7x0X2t_Dg2V1hC-j5REZM59AmMDtLZNg9J_8C..a-YJwLTxkjqd2RiPjLgNKQrPzZY4CwqYLxtiQmB1KM8C * tools/skia_goldctl/mac_amd64: 66xq4FM7P4vA4N6oUkuUIEHz8vHWRjxClUgkjPZ71pQC..UVEHL3UFZ4Zyc_SiQYiOWInJuMcA4GAcLMlCWyEH6W0C * tools/skia_goldctl/mac_arm64: d3aWqZUdjjbgmIsOh-iK7HRZKaYz672JkzWg-0BkauUC..AwMNPFd_J5v55oBqSbV3MzxaPtyLyLmtEA_e1KMQ_PcC * tools/skia_goldctl/win: 5HtHEYI8MUjySHqpU8-ewiaPfNEVcY0SamdPah6R0CYC..rZtqSPxHMFApdEuqDjW0FlpdEQJTl335JOkoHTawxtkC Clang version changed llvmorg-17-init-8029-g27f27d15:llvmorg-17-init-10134-g3da83fba Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/996981471300dc79bd41808d4b02bc44ee1112e7..448305bbeb6dfddd88b74a016c6aeeb16d6de1cd/scripts/update.py Bug: angleproject:6430 Tbr: cnorthrop@google.com Change-Id: Ifa152a1d4e8239666c070cf1353efe708938a0e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4508558 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov d4aacb29 2023-05-02T10:39:47 angle_end2end_tests Pixel 6 shards: 4 -> 8 There are much more Pixel 6 bots now and even without the current slowdown we should be running this in more shards. Bug: angleproject:8150 Change-Id: Id688f27f77dcc4181e21a1d7b2b8c50fd0363278 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4497730 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov fbf0e025 2023-05-01T14:21:01 Re-enable angle_restricted_trace_gold_interpreted_tests Works again once libangle_trace_interpreter is handled the same way as other trace libraries. Bug: b/276742336 Change-Id: Idc55c502c05cabbc38b766823ddfaa92cf2144b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4492537 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov 25d57e41 2023-04-24T18:46:16 Disable angle_restricted_trace_gold_interpreted_tests Blocking Cody's changes to move .so outside of the apk. Will fix and reland later. Bug: b/276742336 Change-Id: I726f8ea71db26b29606bb7395d6ca54fba1e7990 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4470388 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov f2d1958e 2023-04-20T09:42:26 Trace Interpreter: disable angle_trace_interpreter_tests on bots Interpreter handles tokens too loosely which makes failures in this suite hard to understand and debug. Bug: angleproject:8137 Change-Id: Ibd1ca9de29cf43a819d6fb292a4af6e3c144053a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4455147 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 25f843f8 2023-04-18T17:51:38 Remove unused angle_trace_tests from isolate We use wrappers instead: angle_trace_perf_tests angle_restricted_trace_gold_tests Bug: b/276474703 Change-Id: I6741f4f1453e6d9321bc6dd59f0ba05f926598e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4444286 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 4e073356 2023-04-13T15:16:53 Trace Interpreter: gzip cpp and run gold tests. New test step: angle_restricted_trace_gold_interpreted_tests similar to existing angle_restricted_trace_gold_tests but runs a subset of newest traces that have the right format. Currently there are 8 of them and the filter is hard-coded in test_suites.pyl. rise_of_empires can also be run interpreted but happened to flake during testing so it's not included for now. Trace cpp files are concatenated and gzipped as a build step producing gen/tracegz_{trace}.gz and these gz files are then distributed as part of the build --trace-interpreter flag changes from boolean to string to support: --trace-interpreter=gz: * this uses the gz file above * gold tests added in this CL use this option --trace-interpreter=c: * using uncompressed c/cpp file * existing angle_trace_interpreter_tests runs a retrace saving .c files and uses this option Bug: b/276742336 Change-Id: I69544f25bda873af191978195d02ffbdd34363c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4424690 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuly Novikov 7b92fa4f 2023-04-14T17:08:18 Stop running tests on experimental Mac AMD bot Bug: chromium:1382149 Change-Id: Ibcfa4d5e00c6fb5c62409ef801adf8acacc885ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4428870 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Jamie Madill 735fb480 2023-04-13T09:34:57 Trace Interpreter: Support \\ escape sequences. This enables the 'catalyst_black' trace. Cloned from https://crrev.com/c/4178022 Bug: b/276742336 Change-Id: I9df703150504e7fcf4e18ff0a538aa3f6caddfdb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4423269 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 32fa1392 2023-04-13T11:42:19 Manual roll Chromium from 902dbf2d8350 to f048076954b4 (61 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/902dbf2d8350..f048076954b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/54cb62e9f8..123963cbd6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8024c48463..768eecf603 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c5af5d5bf5 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ibef7902dc57f9c6d79dccde118ca1441d33f63a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4422932 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill f093a9b3 2023-04-11T18:09:00 Trace Interpreter: Support gClientArrays Needed to run cut_the_rope, fishdom, other traces. Add cut_the_rope and fishdom to interpreter CI. CL cloned from https://crrev.com/c/4178021 Bug: b/276742336 Change-Id: If7da78ba3fd7c19262692d1386c5eaa47df2ca6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4415246 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov cef7dcbf 2023-04-11T16:12:12 Trace Interpreter: support harry_potter_hogwarts_mystery Handling of calls like: glGetBooleanv(GL_DEPTH_WRITEMASK, (GLboolean *)gReadBuffer); glGetFloatv(GL_DEPTH_CLEAR_VALUE, (GLfloat *)gReadBuffer); Add interpreted test to CI. Bug: b/276742336 Change-Id: Iae3ff9035044461ca1a208980c170d5d48d1a424 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4416166 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll c8b32849 2023-04-10T08:52:14 Roll Chromium from 8701b5ed1d64 to 837a7f0f9df1 (574 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8701b5ed1d64..837a7f0f9df1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c43c0192b6..00bbfdfba0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/64c9f314b8..64174283d0 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/ab37483b42..049d48aa99 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/041196414a..2868dcda2b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/be2d6d3f7a..e7cf8e76e3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fdeb9d47a8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bf6e21d9d7..019e73a13b * third_party/fuchsia-sdk/sdk: version:12.20230406.3.1..version:12.20230409.3.1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/89a6caa12c..26ed975357 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3d8a315223..66b61ae669 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ie1513ea1fe724f66e4e9b2695c82baa536b178ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4410571 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c3c41889 2023-03-31T07:07:00 Roll Chromium from f7c2a70f23b1 to 1393a98c62ae (1678 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f7c2a70f23b1..1393a98c62ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/052437a6e1..0cdf15da5b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c97a3b8902..76bdd92e1c * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/26ace673c4..6f868b2003 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9643f2cf13..4a9d0560b4 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/29a6dda8c6..f3464caa6a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/df3b0c9f14..5e393c2f70 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b5b8912f72..20c8ae002d * third_party/android_build_tools/aapt2: 36NqCian2RIwuM6SFfizdUgKoXyZhy3q6pFfsws0szYC..fFfHyo80O9opPFsbOisSHF4d3tV4GGxLgxXWzGRuY2IC * third_party/android_build_tools/lint: E86vFKi4re9HwIfUW9yq_Ig_hc7Vr0lcl-bO3BtPQLYC..-QeaXYm6b9vGTpMVBhnqlwODS7YvC3vNdvA0KVEz0TwC * third_party/android_build_tools/manifest_merger: _aoHU11YhUwqKZXVXsn5otnhI-ZVGFT7h1Z9eCcAZM0C..zrC8AzHP0aIX3PNRmyIUO6hidQryUwSv65YE8KQEZa0C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/115fe1141d..c17c192772 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fdcbdb2b3e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df528a9d7a..0c99af9051 * third_party/fuchsia-sdk/sdk: version:12.20230327.3.1..version:12.20230330.3.1 * third_party/kotlin_stdlib: XON2v801ZWS7FjApXO8Ev7Me7cOsIAnmqzyCXJuMwJ0C..gizyEP29NQpAimwviO2pgSrqvx0YgAvSUNc5V6hvfroC * third_party/r8: BTs9W6pUBDK8YTePjjF3Q0-ZQo1snO7GBCT6frWMIj8C..pt0cSjlfhgFLaZ3goeJsF_ejKlOjod7amOkEGzTWIkwC * tools/android/errorprone_plugin: https://chromium.googlesource.com/chromium/src/tools/android/errorprone_plugin/+log/71a32a2f82..a848535fa4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/04d87bfe25..f686247260 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/993b50afde..eeb51e8ca2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/892ad5cc94..18e0d7aac4 * tools/skia_goldctl/mac_arm64: Jh19SHnigVXYxpk7Fp4ZDMF_ZvLpQUie2NMaK5aEISMC..432GgeQWQIAz1NADw1ssxRVYDIKzNs1i3tKIITtxDdcC * tools/skia_goldctl/win: pUOVquC14y84RkNMzEAPw_7tztey-kvH7KBwGsFViuIC..aW-NZ8C8eVMaPmBAILqVE-mOxYdoUXfiDHShsTeZMwkC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I336b2c934561c9824eab0b97bcdd5278a8831363 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4385566 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 34a06e25 2023-03-15T18:46:55 Start MacBook Pro AMD 2019 experiment on ANGLE bots Suppress failing tests Bug: chromium:1382149, angleproject:8091 Change-Id: I817d3db8badc35a12ecc9650750ca9190c617f6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4341695 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 0cb09074 2023-03-08T19:18:22 Manual roll Chromium from 4d26ea50cec7 to 52ec1cb28f1b (235 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/4d26ea50cec7..52ec1cb28f1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/984f82d89c..1185a77c82 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c20dc6aaed..2cdfeaa2d0 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e136ec5032..3cf0fe4445 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e943c1ba28..764c1fa4e4 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/28c6deacab..6b9c63c69a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2da767c6c1 * third_party/fuchsia-sdk/sdk: version:11.20230307.3.1..version:12.20230308.2.1 * third_party/kotlin_stdlib: Mg7371mEUwDQH4_z29HdWqYWVlXN6t2dXX0kIutg_SwC..zeFlVAEGvnpaj3JJujWHzRlUiBEm4XeeaMQzVsdW6D4C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2a70735180..ef1eb208a2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7ee68c5321..12d39d4fd8 No update to Clang. Bug: None Tbr: romanl@google.com,ynovikov@google.com Change-Id: I0d0010c35b9692a3726ccf7871376199b188662d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4321865 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 6e58328d 2023-03-01T19:12:28 Add Mac AMD experimental bot Bug: chromium:1382149 Change-Id: I4652585abee747d4a9a738a679deefb7ae57f64f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300871 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Brian Sheedy 9566011b 2023-02-23T15:01:59 Add support for permissive pixel comparison Adds support for running ANGLE pixel tests with a more permissive inexact matching algorithm. This is done by passing in --use-permissive-pixel-comparison=1 to the test runner. This is intended to reduce the amount of manual triage work required on CLs that are expected to have a larger amount of differences, such as SwiftShader rolls. On the bots, this will normally be disabled, but will be enabled if "Use-Permissive-Angle-Pixel-Comparison: True" is present as a CL footer. This footer is not yet included automatically anywhere, so there should be no functional change as a result of this CL yet. Bug: angleproject:7985 Change-Id: Ie815fac42edb2198dd4d115fc50650504df136c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4288612 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 2678b830 2023-02-23T18:19:30 Reenable GLES 1.0 conformance tests on Win/Intel Hopefully blue screen and timeouts are fixed by the new driver. Bug: angleproject:7750 Change-Id: Ic84f3080aeac689fa04f4fc8fc2f7f9c582abc10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4286568 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill e960355a 2023-01-05T14:56:48 Trace Interpreter: Support DOTA underlords. Supports zero pointer parameters, which are used to indicate unwritten parameters. Bug: angleproject:7887 Change-Id: Ibee1d558567020eeeeb2ed6ac98f38cf985d87a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4140259 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2c4de3a7 2023-01-03T16:07:35 Trace Interpreter: Support Genshin Impact. Includes a couple fixes: - parsing hexidecimal values instead of enums - support sharing strings and functions between modules - support 32-bit int pointers Bug: angleproject:7887 Change-Id: I6e20a64a862c45c17ccde78a58d6069d83b31867 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4135797 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 2c582dcb 2023-01-03T10:27:03 Trace Interpreter: Support Manhattan trace. Adds the following fixes and features: - support transform feedback varying strings - support infinity and NaN constants - support for sampler and query resources Bug: angleproject:7887 Change-Id: Ib01afe66e4fda9bc77d0cb5eed52fa83a694a7d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4126885 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill f7b5d5d1 2022-12-15T10:52:07 Capture/Replay: Remove inline variable declarations. This makes parsing easier for the "simplified C" interpreter. We introduce a resource ID buffer as a way to manage a list of resource IDs to replace the inline resource lists. Turns on the Among Us trace in the interpreter tests. Bug: angleproject:7775 Change-Id: I1bb9c0e9b087965a18691bc99b2e9947610b9eaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4128719 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill f609d294 2023-01-12T12:59:00 Infra: Re-enable TSAN on CV. The flakiness in this config is mitigated by retries now. Putting it on CV should help prevent the regressions that happen often in this config. Bug: angleproject:7944 Change-Id: Ie9d5443bda2031785a5c3d81fb45986272da8b58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4162558 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov 4403abc0 2023-01-06T16:14:48 Enable merge script failure detection chromium_swarming.expose_merge_script_failures https://crbug.com/1346781#c96 Bug:chromium:1346781 Change-Id: I33c7fcbaa286f4c0401a16c0a03635054c7330f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4144179 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuly Novikov e7ded5d9 2023-01-06T14:06:20 Add ANGLE Pixel 6 CQ and Perf bots Keeping the experimental bot to test adding GLES backend tests. Bug: angleproject:6819 Change-Id: I869fc3fe29964756d0231b0a6fc51aa7774963f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4143159 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov f2290d80 2023-01-04T17:20:49 Re-enable tests on win10-x64-intel-perf Bot was switched to new GPU and driver in crrev.com/c/4133266, so hopefully BSOD issue is fixed. Bug: angleproject:6332 Change-Id: I4b7d5ab6b8dc559f75b487a85ec453876ac13932 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4133267 Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 6382dd74 2023-01-04T13:49:50 Switch Win Intel to Optiplex 7080 by rolling Chromium Optiplex 7050 had HD 630 GPU PCI ID 8086:5912. Optiplex 7060 had UHD 630 GPU PCI ID 8086:3e92. Optiplex 7080 has UHD 630 GPU PCI ID 8086:9bc5. Also upgrading the driver from 26.20.100.8141 to 31.0.101.2111. And the Windows 10 version from 1909 to 21H1. Re-enable angle_restricted_trace_gold_tests on Intel, since they looked stable on the experimental bot. Stop running tests on the experimental win10-x64-exp-intel. Roll chromium_revision 87b7ed3032..9b6c0a64c3 (1088609:1088686) Change log: https://chromium.googlesource.com/chromium/src/+log/87b7ed3032..9b6c0a64c3 Full diff: https://chromium.googlesource.com/chromium/src/+/87b7ed3032..9b6c0a64c3 Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9c112b5654..c5a91cd488 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a404e6d108 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/eb0a826405..2c8d802803 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7e2765e6fa..0f2155f845 DEPS diff: https://chromium.googlesource.com/chromium/src/+/87b7ed3032..9b6c0a64c3/DEPS No update to Clang. Bug: chromium:1349828, angleproject:7708 Change-Id: I8af85de8334c01a5cdd62149ab30be9eaba5d07a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4133266 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 104faff5 2022-12-09T15:01:54 Enable angle_restricted_trace_gold_tests retries on Win Intel UHD630 Flaky 4x8 pixel artifacts like with older GPU/driver. Also expand flaky Texture2DTestES3.NonZeroBaseEmulatedClear skip. Bug: angleproject:5415, angleproject:7866 Change-Id: Iea11f7dcb75e71f89dcf83f0cdde7ff74d6385f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4092005 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 81a3c71e 2022-12-01T18:51:39 Enable tests on Win Intel Optiplex 7080 experimental bot Suppress failing end2end tests and run single process Suppress VUID-VkDescriptorImageInfo-imageView-06711 Bug: chromium:1349828, angleproject:7874 Bug: angleproject:7865, angleproject:7866, angleproject:7872 Change-Id: I18c9099af6635cf41f5368960dc1d35d9decc48c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4071925 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 64cb7bc0 2022-12-07T11:37:38 infra: Remove toolchain from CI dashboard. With the exception of MSVC and WinUWP, all of our toolchains were "clang". This change makes it so that MSVC/UWP is combined with the OS name to make the dashboard easier to read. Bug: angleproject:7871 Change-Id: I9d86b67504ff6e12b63ddb1f520b4ea6e3f56146 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086742 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 82eba6cd 2022-12-07T11:21:41 infra: Remove UBSAN-specific configs. Because the UBSAN flag is turned on in the ASAN builder, we don't need a separate UBSAN builder. Bug: angleproject:7871 Change-Id: I4f6c8d56bdd209efea381677b2972616b6a6df14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086741 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 2364578f 2022-12-07T10:33:05 infra: Enable UBSAN together with ASAN and LSAN. These flags are compatible. This should save on testing resources. Bug: angleproject:7871 Change-Id: I860e3724f54bdbf06e7530bd6bfe72ec0f53cc54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086283 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov e4054a3f 2022-12-01T16:51:48 Add ANGLE experimental bots for Win Intel Targeting Optiplex 7080. Not running any tests for now. Bug: chromium:1349828 Change-Id: I6e3973c684cbcbefd283f314b2a48bf33f8ce6da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4071104 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 76ef4207 2022-12-01T10:17:56 Remove trace tests from win-intel. This test configuration is flaky due to non-deterministic rendering. It's also running a very old configuration. We can revisit turning this on when our test machines are updated. Bug: angleproject:7708 Change-Id: I486607f673e49123b3b77e02b335049eb5ab34ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4070224 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 658a4b6b 2022-11-18T07:00:34 Roll Chromium from 2c9d51705f3b to 54894332d13c (577 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2c9d51705f3b..54894332d13c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a6b135f6dc..316bdbb4f8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1f8966e6e2..fd493f4659 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/3f159e715e..c5a3f52f05 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..79ba9244e5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fadcbfdb27..1f67d5573f * third_party/fuchsia-sdk/sdk: version:10.20221116.3.1..version:10.20221117.0.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eea11ec5d2..d21aa5eb7e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9d3a5eb0dd..4fc30da878 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d900152808..35428c527a No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I5a46ba74c1edcd0946de7255d16cb5107692de3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4035041 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 7013bc86 2022-11-09T21:57:51 Use Python3 for infra/config/PRESUMBIT.py Bug: chromium:1313804 Change-Id: Ie327b1bc5babd0198f06398e1390843c7e3159c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4018964 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll e449439e 2022-11-03T19:31:27 Roll Chromium from 35e93669b8f2 to 1d02faaf3aaa (59 revisions) https://chromium.googlesource.com/chromium/src.git/+log/35e93669b8f2..1d02faaf3aaa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/33b52eafd5..404e2d0fd7 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/fc6bbc5eb0..08ea445fb5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/aedf4723b9..3af95eaf05 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..67ccd32ad3 * third_party/fuchsia-sdk/sdk: version:10.20221103.0.1..version:10.20221103.1.1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/458fbce5e4..3ab161438c No update to Clang. Bug: None Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: Ic465ac476f41e0288fb394560ee779430a2e1b70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4004438 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brian Sheedy f98eecda 2022-11-02T13:05:40 Migrate ANGLE regexp filters Migrates the ANGLE trybot location filter regular expressions to use the newer lucicfg format. The old version was automatically translated to the new version under the hood so this is functionally a no-op change, but this brings the non-generated code in line with now new filters should be added. Bug: chromium:1380568 Change-Id: I5f0c8ece5015d2fc3bdb456fbe2499a335663d79 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4000546 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Solti 809a4ff2 2022-11-01T16:16:45 add tips in ANGLE wrangling doc Bug: angleproject:1944 Change-Id: I9b5b7968453d55aab000608a44c2790eea4496b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3995491 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Roman Lavrov 81fcf70e 2022-10-24T09:53:17 Reduce angle_preftests samples from 10 (new default) to 6. Taking too long on Windows, this should bring it close to other test suites. Bug: angleproject:7782 Change-Id: Ie1e76fffda790c3b5c2e73a22dee92763fa56abb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3970765 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Trevor Black <vantablack@google.com>
Jamie Madill dc62b3ee 2022-10-10T21:00:16 Capture/Replay: Add trace interpreter. Also adds a self-test using the retrace script. Bug: angleproject:7752 Change-Id: I1985b47250bef99726d2ca2d90bef859208e357e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3965128 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Jamie Madill b4319e49 2022-10-20T10:10:32 Enable flaky retries on SwS ASAN/TSAN. This should compensate for ASAN/TSAN being generally flaky. Bug: angleproject:7772 Change-Id: Ied857321179c06fd9fc9bcf3d58e919b4f2009f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3968319 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill a41c6173 2022-10-16T08:28:53 Simplify trace test names. Originally we had a lot of conditionally enabled test configs in angle_perftests, that we enabled behind a flag because the total runtime would be too large if we left everything enabled. This CL switches to using a single test set, one for each trace, and using a the same command-line API we use in dEQP and the ANGLE samples to pick a single configuration. This makes it easier to pick exactly what configurations you want from the command line. Because we only run one configuration each time, we don't need to specialize the test name to include the configuration info. We can also simplify TracePerfTest -> TraceTest since these tests are run for both perf and correctness. Old name: TracePerfTest.Run/vulkan_trex_200 New name: TraceTest.trex_200 Example for tests that don't use default arguments: Old args: --enable-all-trace-tests Old name: TracePerfTest.Run/native_offscreen_trex_200 New args: --use-gl=native --offscreen New name: TraceTest.trex_200 Bug: angleproject:7755 Change-Id: Id93cf5725eff2e2c6b3b14804bc2902f38306e7e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3966535 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Jamie Madill 0d635faf 2022-10-21T09:43:13 Enable capture by default on release non-Android bots. This will enable running the trace interpreter tests with ANGLE. Also this cleans up a case where we now default turning off the trace tests when we're building with non-clang. Bug: angleproject:7752 Change-Id: I7019bb969d859e06fafc7621e8620b8a2375261e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3971079 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Jamie Madill e495e7fd 2022-10-14T13:52:47 Redo perf and trace test parameters. - Moves common argument parsing code into test_util. - Changes the perf test arg parsing to use the common functions. - Adds new --use-angle and --use-gl parameters to the trace tests. - Also adds new --offscreen and --vsync parameters to the traces. - Removes the now unneeded --enable-all-trace-tests argument. - Both --arg=value and --arg value work in test suites now. Now, instead of using --enable-all-trace-tests you can specify the backend with --use-angle=swiftshader, --offscreen, or combinations of those parameters. The test names are the same as they were before, but only the configured tests will run in a session. We could opt to simplify the test names in later CLs if we want to simplify the test running. Ideally we'd keep the perf reporting the same because then we'd keep the time series the same on the test infra. This also allows us to split up the trace tests into separate targets on the bots, which will better allow us to control the workloads and sampling of the tests. For example: - angle_perftests becomes - angle_perftests (microbenchmarks) - angle_trace_perf_vulkan_tests (traces with vulkan back-end) - angle_trace_perf_native_tests (traces with system GL) Bug: angleproject:7755 Change-Id: I537168f3a6de96425dfda05ed98220eff9b19b76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3956937 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 0e0ea026 2022-10-13T18:29:33 Split trace tests out into angle_trace_tests. This makes angle_perftests strictly for microbenchmarks. The trace tests are a better separated target because they are for both gold correctness tests and performance. You can now use the GN arg "build_angle_trace_tests" to control building the trace tests. "build_angle_trace_perf_tests" is still supported for compatibility. Updates the infra scripts to use this new trace tests target. Also updates the build so by default we'll build the trace tests if you check them out, without needing a custom arg. Also updates docs. Bug: angleproject:7755 Change-Id: I2b1ae67799234cc1aefe7cda5f3af945c3f867fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3953340 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 7d76160b 2022-10-14T09:03:12 Remove GLES 1.0 conformance tests on Win/Intel. Now this test suite is causing timeouts. e.g.: https://ci.chromium.org/ui/p/angle/builders/ci/win-test/2637/overview Bug: angleproject:7750 Change-Id: I62c0ca237d7a0f618823fbe5ff15070c21a9cdd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3956495 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 96bbc80b 2022-10-13T15:09:12 Restore default angle_gles1_conformance_tests Win Intel batch size Low batch size suspect for causing blue screen on this platform. Bug: angleproject:7750 Change-Id: I331f3aef22e313e318aeabb84b1277f4bf1678c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3953493 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill f8930fd8 2022-10-11T09:20:24 infra: Increase timeout on perf bots. This sets an explicit 3 hour timeout for all bots, and bumps the timeout for the perf bots to 5 hours. Bug: angleproject:7738 Change-Id: I2ed3ce319046ef8a9ec61128f4970c03ec1d2ecf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3945072 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 70244096 2022-10-10T10:20:12 Perf Tests: Enable --split-shard-samples on the bots. This should make all sharts run at most one sample for each test. This in turn should mitigate inter-run variance because we'll sample from a wider pool of machines for each test. Bug: angleproject:7738 Change-Id: Ied96235edff81c8ea6f3fb8ac0e4fb21d6254d4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3942604 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 8bac3563 2022-10-07T17:36:53 infra: Update timeout for perf tests. Changes 200 minutes to 120 minutes. Also applies the timeout to the Pixel 4 perf tests which are now timing out with the latest increase in warmup time. Bug: angleproject:7738 Change-Id: Ib43d61cb218aac24a5d9ae190813256a72b9eccc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3937050 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Jamie Madill d8489db5 2022-10-05T12:57:06 Perf Tests: Reduce resource usage. This halves the amount of time spent running the tests on desktop platforms. It also reduces the number of shards used on desktop platforms, to reduce resource utilization. It also bumps up the test timeout to keep from getting infra errors. Bug: angleproject:7738 Change-Id: Ie487c06452a39bb9ad1fe29b0d682e9c1bf297d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3936448 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi fb83e6c5 2022-10-03T18:25:42 Infra: Use smaller batches for GLES1 tests The GLES1 conformance tests are few, but each take a long time. As such, --bot-mode only divides them by platform and otherwise the tests run serially. This change uses a smaller batch size to increase parallelism. Bug: angleproject:6644 Change-Id: I1401db0899d4f57735cbfdfb4b051a2d19f8e2a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3933829 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill c5fc9c22 2022-01-18T09:15:13 Don't use run_gtest_angle_test. Instead use the wrapper script in the run directory, and process sharding args directly in the test runner. Also removes passing --bot-mode, instead using the Chrome-based wrapper script to implicitly pass --test-launcher-bot-mode. Bug: angleproject:5417 Bug: angleproject:6937 Change-Id: I11882e10eb2e4d86ba9333326e7aab8eeb64e8db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3399045 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0