kc3-lang/angle

Log

Author Commit Date CI Message
Jamie Madill c789169b 2021-11-26T15:21:43 Fix export_targets presubmit on Windows. It was checking for the vs toolchain in the wrong folders. Bug: angleproject:6735 Change-Id: Ia64f85b33fb6a1b30ca2ebf8ec86eee579e1e835 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304634 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 60e3dc12 2021-11-26T15:05:45 infra: Trigger win-trace on angle_end2end_tests changes. This should prevent a common class of unexpected CQ breakage. Bug: angleproject:6670 Change-Id: Ic5706caedcb2ca326ec87883d695574e5450083c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304555 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 14f55a7f 2021-11-02T10:16:58 infra: Enable TSAN and UBSAN tests. These tests are not yet enabled on the CQ. Bug: angleproject:5795 Change-Id: I3fc58ab800ebbc0840da8221b03b4ab145d28028 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258003 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 2797227b 2021-11-26T08:48:30 dEQP: Add flaky result handling. A flaky expectation will allow the test harness to retry a failing test one extra time. If the second run passes the flaky test will be considered a passing result. Bug: angleproject:5795 Change-Id: I09fc4ed34ee09548ab14f46dfce35f900be5550f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3303712 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e0b4cf6c 2021-11-26T10:23:24 Fix Python3 usage with perf tests/gold tests. Bug: angleproject:6733 Change-Id: I9d1baf78ed182db77c6a6d8e896737413ca417f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304012 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cheryl Wei 268653c9 2021-11-25T13:37:58 Vulkan: Update a test to triger large dirty bit handling Some traces bind one VBO to a large number of VAOs,and use glBufferData to change buffer size frequently,this will cause glBufferData spending a lot of time doing VAO dirty bit handling, which leads to high cpu load in these traces.This test could triger this issue. Bug: angleproject:6371 Change-Id: I99292825b8cb5bba58cc6b37e3baa7adcd02c780 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301536 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll d3aa873c 2021-11-26T10:01:32 Roll SwiftShader from 1d924bd00379 to edeff1f2e7db (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/1d924bd00379..edeff1f2e7db 2021-11-25 sugoi@google.com Make Win32SurfaceKHR::present() more robust If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I1ac5717a5358b8077a9f26a9e98bb74fe545c408 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3303136 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 48aab127 2021-11-26T07:01:20 Roll Chromium from 1f986773b3b2 to b510b0864113 (93 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1f986773b3b2..b510b0864113 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/209a6891b4..26881c1164 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/038090f742..f51a154281 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/af043a3d65..103f40247e * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8b7dd344d7..457dbf3362 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..75423c310e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d04fad9221..be66670475 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Iaabbb97fe8330f9d2c0b0aeb6f93e28e4ecae74b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3300997 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Stephan Hartmann 7f1ab9be 2021-11-25T21:59:51 Vulkan: add explicit template specialization for barrierImpl ImageHelper::barrierImpl with primary command buffer is used in other translation units (SurfaceVk::acquireNextSwapchainImage()). Linking fails if compiler has optimized out symbol for primary command buffer. Bug: chromium:819294 Change-Id: I91d79788ae51d24472e8bd1d20cdb1a375e86300 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301705 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Stephan Hartmann 43ae7834 2021-11-25T21:52:45 GCC: fix type conversion in FramebufferGL GCC has some problems deducing template argument. Help with assigning the value to a new const variable before using it. Error message: ../../third_party/angle/src/libANGLE/renderer/gl/FramebufferGL.cpp:308:70: error: default type conversion cannot deduce template argument for 'template<class Dst, typename std::enable_if<angle::base::internal:: IsNumericRangeContained<Dst, unsigned int, void>::value, void>::type* <anonymous> > constexpr angle::base::internal::StrictNumeric<T>::operator Dst() const [with Dst = Dst; typename std::enable_if<angle::base::internal:: IsNumericRangeContained<Dst, T>:: value>::type* <anonymous> = <anonymous>; T = unsigned int]' 308 | tmpPixels = new GLubyte[checkedAllocatedBytes. ValueOrDie()]; | Bug: chromium:819294 Change-Id: I3e720fea4a8e24aab0a9a9b3dedf9abdebaa44a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301704 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6eb3f661 2021-11-25T20:11:23 Roll Chromium from ad511b3c5051 to 1f986773b3b2 (589 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ad511b3c5051..1f986773b3b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/493ce927d2..209a6891b4 * buildtools/linux64: git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e..git_revision:b79031308cc878488202beb99883ec1f2efd9a6d * buildtools/mac: git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e..git_revision:b79031308cc878488202beb99883ec1f2efd9a6d * buildtools/win: git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e..git_revision:b79031308cc878488202beb99883ec1f2efd9a6d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/16f9b84af1..af043a3d65 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/13257ba994..8b7dd344d7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..75423c310e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/646c3cd4d6..2ffa1bde79 * third_party/r8: nqWomZTwNDoogX26WeCSoFGg6aQN1FrwzoU4hCS0duEC..CokGsfuGfcV-GjGwN98h28Phet4ai_xhPGZkGCqotWMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/994ccaf614..ace657580d * tools/luci-go: git_revision:2dfe2f218f0395673f336d17b841edf629907ae3..git_revision:03f7c59feeac59c211e5b06fbbbc7405861b482e * tools/luci-go: git_revision:2dfe2f218f0395673f336d17b841edf629907ae3..git_revision:03f7c59feeac59c211e5b06fbbbc7405861b482e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/25bed66ea8..5d2edce177 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b841fa72c2..d04fad9221 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/daf835c78a..79ec84517e No update to Clang. Bug: chromium:1273901 Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: Ie372f87f4e06e1f7425b9744137efc494b7605f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301911 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jonah Ryan-Davis 870f458f 2021-11-22T14:30:52 Ignore the pixel unpack state for compressed textures. From OpenGL ES 3 spec: All pixel storage modes are ignored when decoding a compressed texture image This was causing a bad access when calling compressedTexImage3D with GL_UNPACK_IMAGE_HEIGHT greater than the image height. Bug: chromium:1267496 Change-Id: I9b1f4c645548af64f2695fd23262225a1ad07cd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296622 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang e00ad443 2021-11-15T20:16:16 Add EGL_ANGLE_vulkan_image extension This extension is for exporting VkImage from EGLImage. The VkImage must be used with the same VkDevice used by ANGLE Vulkan backend. Bug: chromium:1264439 Change-Id: I222d900465cf2716d94fc64f06e240390ec518ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285025 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll 9f87adc2 2021-11-25T10:01:53 Roll vulkan-deps from 6402aa39e588 to b497675b7cba (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6402aa39e588..b497675b7cba Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/042aaea516..083bdc838a * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4b092d2ab8..8c155b364c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/cdf2f56fae..dcd1e40ebb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Iaf5bb69e1f21301c6195d7db89cad2f8d308429d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301910 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 49456ec4 2021-11-25T10:01:32 Roll SwiftShader from 17a11cfeb5f1 to 1d924bd00379 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/17a11cfeb5f1..1d924bd00379 2021-11-24 capn@google.com Assert that casting memory sizes to 32-bit doesn't overflow 2021-11-24 capn@google.com Use size_t for methods returning memory sizes 2021-11-24 capn@google.com Add a GN build option for the startup dialog If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I5a56e0dbdc015452d907830605c6eb6e3992ccf5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3302138 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gregg Tavares a0924015 2021-11-22T19:44:05 Metal:Fix GLSLTest_ES3.GLVertexIDIntegerTextureDrawElements Metal The test was failing if the "first" argument to glDrawElements was odd. When odd the offset was not a multiple of 2 bytes and the code was going down a different path than when the offset was event. The fix for that just removes a check for alignment to 4 bytes. Checking with UNSIGNED_BYTE indices though and it still failed. That was because it was encoding the index conversion path on one command buffer and the provoking index prep on another and so they were happening out of order. Putting both on the same command buffer fixes that. Bug: angleproject:6688 Change-Id: I89b68ba965d073e0fa70b6d5b444dc743b5e34a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296631 Commit-Queue: Gregg Tavares <gman@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 110ac03a 2021-11-23T09:36:08 Vulkan: Revert change to sRGB override support. An accidental testing change slipped into a fix for base/max level updates. This reverts the unintended change. Bug: angleproject:6728 Change-Id: I61e371149be590ce506cfc88165c4391538e54b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3298428 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ian Elliott 2fa1adf0 2021-11-24T18:29:13 Revert "Vulkan: Use vkResetQueryPoolEXT when available" This reverts commit 97aa5187ed164f1e9a22b64c966f2a747f651bfb. Reason for revert: This apparently caused crbug.com/1273344 Original change's description: > Vulkan: Use vkResetQueryPoolEXT when available > > ANGLE currently uses vkCmdResetQueryPool to reset a query pool. As > reported by Arm, this can cause GPU bubbles. It is better to use > vkResetQueryPoolEXT() when available (either by Vulkan 1.2 or by the > VK_EXT_host_query_reset extension). > > Bug: angleproject:6692 > Change-Id: I650d7d0f55bdf6587b75be43cc7bed2dc3eb935a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294061 > Commit-Queue: Ian Elliott <ianelliott@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> Bug: angleproject:6692 Change-Id: I70d5eeb0b98f016fd262935194f8f4abee2a72b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3300309 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Mohan Maiya 6c172e4b 2021-11-20T16:27:14 Add support for memory cleanup on process exit This patch adds a callback to cleanup memory on process exit. Bug: angleproject:6723 Test: Android CTS WrapperTest.testThreadCleanup Change-Id: Ia517d4c6ae280ddc1f17a3b6f77d437aaaad0678 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294581 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
angle-autoroll f9097e1f 2021-11-24T10:01:53 Roll vulkan-deps from 8d493b8df0d4 to 6402aa39e588 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8d493b8df0d4..6402aa39e588 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/7a0b9b212c..042aaea516 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/833b949972..cdf2f56fae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I3d52a478ca682c1ccb99b4841837149d9b4f2477 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3299785 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5fb45c12 2021-11-24T10:01:31 Roll SwiftShader from 9e727fadeb66 to 17a11cfeb5f1 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/9e727fadeb66..17a11cfeb5f1 2021-11-23 capn@google.com Regres: Update test lists @ 9e727fad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ief890c723a6b6ec526352fd45cfc727c700cb5c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3299959 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0828d207 2021-11-24T07:53:21 Roll Chromium from 592e51326747 to ad511b3c5051 (470 revisions) https://chromium.googlesource.com/chromium/src.git/+log/592e51326747..ad511b3c5051 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/831603f4ab..493ce927d2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/83d4511de4..16f9b84af1 * third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/2bb7b23b63..6a8f3a2781 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..606d87e172 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a29f589a15..646c3cd4d6 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/49836d72bd..02959c3ee1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/649f6b9fa4..994ccaf614 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/48aec494aa..25bed66ea8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/abf7a4bd0b..b841fa72c2 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I7d82fb50261a739b04874cb8a7e2ea45f8a0341a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3299783 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 79f9d163 2021-11-15T08:51:41 Vulkan: Implement GL_EXT_multi_draw_indirect * Optimized the implementations of multiDrawArraysIndirect() and multiDrawElementsIndirect() for Vulkan * Added helper functions to support drawArraysIndirect() and drawElementsIndirect() as special cases of multiDraw*Indirect functions. * Added the flag to enable the multiDrawIndirect feature (drawCount > 1). The generic implementation is used if the flag is disabled. Bug: angleproject:6439 Change-Id: Ibc653d93d355657f828de9c33da22428629e450f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276044 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 6233dc7e 2021-11-24T04:11:51 Roll vulkan-deps from b638c7fb7440 to 8d493b8df0d4 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b638c7fb7440..8d493b8df0d4 Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/83e1a9ed8c..a152371654 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e30862971d..833b949972 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I6729251aa0a27749265cc74230cdc730dcdda9a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3299828 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 924c8d8a 2021-11-18T22:58:04 Vulkan: Fix image tiling when DRM format modifiers are specified Bug: angleproject:6679 Change-Id: I5198a180608535131b127c135423fb80c6478140 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292027 Reviewed-by: Craig Stout <cstout@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 17bf6e98 2021-11-11T20:53:31 Implement GL_EXT_multi_draw_indirect * Added the validation functions for multiDrawArraysIndirect() and multiDrawElementsIndirect() according to the specs. * Added generic implementation for the two functions that can be called by back-ends. * Added unit tests for the multiDrawIndirect functions. * Added flags for back-ends so they can enable the extension. * Minor cleanup in MultiDrawTest.cpp Bug: angleproject:6439 Change-Id: I4e5f1cab05c6de330aef82d115492dcc9d2fad44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276043 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Maksim Sisov 2be4f04a 2021-11-23T12:11:53 linux: enable angle gl for wayland only builds. Chromium is unable to use angle gl implementation if it's a wayland only build as angle_use_x11 is false then. This CL fixes that and allows Chromium Wayland only build use angle GL. Bug: chromium:1231934 Change-Id: Ic4363b986abd6453865f63111032ac810fafc8de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295616 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jeff Vigil 8b60855b 2021-09-15T15:16:10 EGL: implement EGL_KHR_mutable_render_buffer Pass render buffer mode change to WindowSurfaceVk. On mode change trigger OUT_OF_DATE. Then in CreateSwapchain, if new mode, set the Presentation mode and the Image count. OffscreenSurfaceVk ignores mode change. Add MUTABLE_RENDER_BUFFER_BIT to GenerateDefaultConfig. Test: dEQP-EGL.functional.mutable_render_buffer.* Bug: angleproject:3966 Change-Id: I7b59708514bcda10f8d45ce5f9528aa840fcccfa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3171822 Commit-Queue: Brandon Schade <b.schade@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Ian Elliott 97aa5187 2021-11-22T13:26:53 Vulkan: Use vkResetQueryPoolEXT when available ANGLE currently uses vkCmdResetQueryPool to reset a query pool. As reported by Arm, this can cause GPU bubbles. It is better to use vkResetQueryPoolEXT() when available (either by Vulkan 1.2 or by the VK_EXT_host_query_reset extension). Bug: angleproject:6692 Change-Id: I650d7d0f55bdf6587b75be43cc7bed2dc3eb935a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294061 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 4ae30a63 2021-11-22T16:25:11 Vulkan: Don't attempt to convert vertices in empty buffers Bug: chromium:1271671 Change-Id: I869f30fd9c8a52c07263bb7a72978a31f2aceb9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3297026 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill ce6f9c8f 2021-11-19T14:52:48 Update checked numerics library. This library hadn't been updated in quite some time and had bugs which affected UBSAN in some operators. Bug: angleproject:5795 Change-Id: I40f658655034ce03df29cf4c71acb3f6fe96bef0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289941 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Sergey Ulanov 6e2e36cc 2021-11-19T00:57:29 [Fuchsia] Fix SwiftShader ICD discovery ANGLE needs to set VK_ICD_FILENAMES for the Vulkan loader to discover SwiftShader's ICD. Enable this logic on Fuchsia. Also updated ConcatenatePath() to handle absolute paths correctly. Bug: chromium:1225002 Change-Id: Ib69be0d7dcaef09f1da9d411023e90a3b7b4fca2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292347 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f2bf9954 2021-11-23T10:01:52 Roll vulkan-deps from 8e41c1d91f9d to b638c7fb7440 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8e41c1d91f9d..b638c7fb7440 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2c54c20813..7a0b9b212c * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b21acf16e7..ef2429635d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5c2548a01b..e30862971d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I3df892e30797d4c6cd0f1593301574efa47990d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296788 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f8661920 2021-11-23T10:01:32 Roll SwiftShader from 6e23c082b73a to 9e727fadeb66 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/6e23c082b73a..9e727fadeb66 2021-11-22 capn@google.com Assert that the descriptor set is not null 2021-11-22 capn@google.com Implement Assert() for Reactor 2021-11-22 ari.suonpaa@siru.fi Fix green bits for R5G6B5_UNORM_PACK16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I144730c236f9daed403615b1310d9cc0127f7793 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3297691 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 1d555687 2021-11-09T11:16:24 Capture/Replay: Set FBO ID when generated on bind GLES allows FBO ID's to be reserved on bind, so if a FBO is bound with and ID that was not yet reserved by a glGenFramebuffers call, update the resource tracking and the resource map to account for this resources that was created on bind. Bug: angleproject:6425 Change-Id: I343fc17bfbbfd9c8c47d6fe207a4f3817acb835d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3190970 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll b9e96af0 2021-11-23T07:01:14 Roll Chromium from 53373ae01d32 to 592e51326747 (437 revisions) https://chromium.googlesource.com/chromium/src.git/+log/53373ae01d32..592e51326747 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b8e6a02717..831603f4ab * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e21de6f7d1..83d4511de4 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/ebda326985..05738da13b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7ae3bc4766 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b6c1ed40d5..a29f589a15 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/fd8a7c7c2b..5227e7d830 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6a6ee955de..649f6b9fa4 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3eb0936d98..48aec494aa * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d0f3e129d7..abf7a4bd0b No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: If58fcb08e19c8dc53c6ad97cc8ac0adabdace32a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295872 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
shrekshao 5859bb10 2021-11-19T13:25:38 Make D3D11 non instanced draw path explict To make sure instanceCount == 0 is no-op according to OpenGL ES 3.2 spec section 10.5. Before the fix the behavior on linux (gl) and win (d3d) are inconsistent. Bug: angleproject:3402 Change-Id: I70ec215d8b65c1591b4c816f76c92e88e9f0dc61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3293749 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com>
Yuxin Hu ef637366 2021-11-19T22:38:56 Revert the order of texture sync and frame buffer object sync This change reverts the sync order swap done in CL a280c671f178daf73da447d1030773b58b534998, to address a performance issue in TRex. The crash that sync order swap was trying to resolve was addressed by another CL 0fcad6260a3e3943fb84657a3a7f488d1e155fb7. Bug: angleproject:6014 Change-Id: Ie49628295b6dcd5d012dc795bf123865b1a7f893 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292636 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 9de37b58 2021-11-20T21:45:02 Vulkan: Fix draw with emulated xfb without xfb active When transform feedback is not active, make sure the code that captures xfb is not generated, even though it's guarded against with an if. This is because no buffer is bound to the capture buffer, and by avoiding generation of code that references that buffer, SwiftShader will not attempt to access the missing descriptor set. Currently, the actual declaration of the buffer is left in the SPIR-V, which seems to be benign. If that causes issues in the future, the SPIR-V transformer can be modified to remove that variable as well. Bug: chromium:1209285 Change-Id: I83da8d1dea5390ecacc681f8ada9f586932deaa4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294661 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang b6e2e8a0 2021-11-16T13:13:14 GL: Fix share groups for display texture sharing. Chrome uses display-level texture share groups for WebGL contexts. When this extension is in use, make sure all internal contexts are created in the same share group. Bug: chromium:1268830, chromium:1268389, chromium:1268218 Change-Id: I3925dffb9bb23fbbc7adcd3bee8cd62323b993e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285213 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi d781ef09 2021-11-22T11:12:10 Roll VK-GL-CTS from 234f8a066b4d to bfede065f419 (18 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/234f8a066b4d..bfede065f419 2021-11-20 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master 2021-11-19 ari.suonpaa@siru.fi Add tests for buffer size requirements 2021-11-19 jari.komppa@siru.fi Extend interpolateAt* tests 2021-11-19 jari.komppa@siru.fi Add power of two checks for physical device limits 2021-11-19 jari.komppa@siru.fi Modify dual source blend tests to use discard 2021-11-19 juha.heiskanen@siru.fi Add fragment operations occlusion query tests 2021-11-19 mohd.faisal@arm.com Fix wrong conversion from shared pointer to int. 2021-11-19 arkadiusz.sarwa@amd.com Enable anisotropic tests for mipmap images 2021-11-19 jason.ekstrand@intel.com Remove invalid semaphore import/export tests 2021-11-18 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-11-15 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master 2021-11-13 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-11-13 michal.jakubek@mobica.com Various methods passing of PhysicalStorageBuffer tests 2021-11-13 venni.ihanakangas@siru.fi Improve coverage of MSAA copies 2021-11-13 michal.jakubek@mobica.com Fix Buffer Memory Requirements tests compilation errors 2021-11-13 r.potter@samsung.com Mirror existing ANGLE waiver for Samsung devices 2021-11-13 ruoyu@amd.com Support FP16 CPU Rendering 2021-11-09 alex.lan@arm.com Add yuv420 format to EGL AHB tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:6724 Change-Id: Ied03caaa16832597f9a694398577a4b24e11ce90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296262 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 41a8981e 2021-11-21T21:52:37 Use AttributeMap in eglLockSurfaceKHR's validation Bug: angleproject:6062 Change-Id: I0eea431313700b11184265a9ff895417ce4b1d4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295164 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: (use @chromium please) Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny ff89ba1b 2021-11-19T11:52:55 Capture/Replay: Repeat logs for unexpected results The Ci logs are quite long and it is difficult to find the log for the actual CI failures, so repeat the logs for unexpected failures, crashes, compile errors, and timeouts at the end of the log. Bug: angleproject:6542 Change-Id: Id9dff4cc70649d0d9cc8bd4509477fbe3ef10de8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291653 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 135362c9 2021-11-22T10:01:53 Roll vulkan-deps from f2ad120142ed to 8e41c1d91f9d (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f2ad120142ed..8e41c1d91f9d Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/dd83c37b98..2c54c20813 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/22e9c7c538..b21acf16e7 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/fc509008c8..5c2548a01b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: If584af98e308f3f0eea50b16ba1c3419a3a6b4c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294973 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b13dbe75 2021-11-22T10:01:31 Roll SwiftShader from f5cf2d08ff9c to 6e23c082b73a (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f5cf2d08ff9c..6e23c082b73a 2021-11-19 sugoi@google.com Make line stipple related tests pass 2021-11-19 capn@google.com Run clang-format-all.sh as a Bash script 2021-11-19 swiftshader.regress@gmail.com Regres: Update test lists @ 210fe010 2021-11-19 capn@google.com Update testslists to match the dEQP revision If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I1c60eb549494f81c25cfefad4594a1f1e605d393 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295338 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bf2d35a0 2021-11-22T07:00:10 Roll Chromium from ebb70a6ec0bc to 53373ae01d32 (460 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ebb70a6ec0bc..53373ae01d32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/13d46663be..b8e6a02717 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a63bbc1389..e504863f9e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b632243411..e21de6f7d1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8a112e2bdf * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/29a2573216..6a6ee955de * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9e42d0c22f..3eb0936d98 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c8ce774f11..d0f3e129d7 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I0ecc2e7e645ec972a45561b27a719578bad1ac47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294972 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 647026fa 2021-11-19T19:08:14 Reland "Fix unused variable "useSwiftShader"" This is a reland of d721cdefdcf4c3e62ae364f0dc525e3ca54042a3 Adding a missing include. Original change's description: > Fix unused variable "useSwiftShader" > > -Wunused-but-set-variable when rolling into Chromium crrev.com/c/3293895 > > Bug: angleproject:6496 > Change-Id: I02f7de303b52319c6a1821d7b697b7ee9bea8f89 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292034 > Reviewed-by: Tim Van Patten <timvp@google.com> > Commit-Queue: Tim Van Patten <timvp@google.com> Bug: angleproject:6496 Change-Id: Id39e10a8f343600ea6b2f023442b4d8c7e1856dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292036 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 18b9f2dc 2021-11-20T02:52:05 Revert "Fix unused variable "useSwiftShader"" This reverts commit d721cdefdcf4c3e62ae364f0dc525e3ca54042a3. Reason for revert: missing include Original change's description: > Fix unused variable "useSwiftShader" > > -Wunused-but-set-variable when rolling into Chromium crrev.com/c/3293895 > > Bug: angleproject:6496 > Change-Id: I02f7de303b52319c6a1821d7b697b7ee9bea8f89 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292034 > Reviewed-by: Tim Van Patten <timvp@google.com> > Commit-Queue: Tim Van Patten <timvp@google.com> Bug: angleproject:6496 Change-Id: I12748620cc20348bbcbe0304609a19ab65052b0e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292035 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov d721cdef 2021-11-19T19:08:14 Fix unused variable "useSwiftShader" -Wunused-but-set-variable when rolling into Chromium crrev.com/c/3293895 Bug: angleproject:6496 Change-Id: I02f7de303b52319c6a1821d7b697b7ee9bea8f89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292034 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill 98a49220 2021-11-19T15:02:47 GLES 1: Fix missing validation returns. The validation was correctly generating an error but ANGLE was not aborting the API calls for several validation calls. This was detected by UBSAN tests which would trip a division by zero. Test: GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays/* Bug: angleproject:5795 Change-Id: I5d5d8448454ce19cb4bdf1cd76a6ce513a6e9c6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3293821 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill de5e8577 2021-11-19T15:05:12 MultithreadingTest: Initialize an atomic bool. This variable was getting garbage data in UBSAN. Fix it by setting an initial value of false. Bug: angleproject:5795 Change-Id: I0a40bea427d7c02c8a12616c472c8d9ce70cb937 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3293822 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill edc2cfe5 2021-11-19T14:57:16 Fix signed integer overflow in angle_end2end_tests. The test math was causing an signed overflow in the most extreme case. Test: GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays/ES3_Vulkan_SwiftShader Bug: angleproject:5795 Change-Id: Id6b845577cb6ce585ec67251dcb6111d5773012f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289942 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 8d51bd4b 2021-11-19T00:34:22 Capture/Replay: Add default return path for AccessParamValue Some versions of MSVC have a bug that it will not detect when all values of an enum are exhausted in a switch statement, which leads to a warning that not all code path return a value, and since the warning is treated as an error, compilation fails. Bug: angleproject:6721 Change-Id: I4d62191ce83a04ba554dd804f13e7d428afd86a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291649 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten e28083ad 2021-11-09T18:00:17 Enable RenderDoc capture for debug builds Enable RenderDoc capture in builds where Vulkan Validation Layers are enabled. This essentially enables the '--renderdoc' flag for debug builds when running end2end/deqp tests to make it easier to debug tests. This CL also add the '--no-renderdoc' flag to force disabling RenderDoc capture. Bug: angleproject:6072 Change-Id: Iae7aae30aae9bdc58a7546118d156aef2047c210 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270600 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Cody Northrop f44a6fd2 2021-11-18T20:15:31 GLES1: Hard code integer values in the ubershader This CL continues the process of removing uniform values from the GLES1 ubershader to increase speed on mobile platforms. The first phase removed bools 2091451e. We've identified integers (enums) as providing the biggest bang for buck to optimize speed while having acceptable program generation. Allowing floats as well proved too much specialization. Many GLES1 conformance tests would grind to a halt while providing little to no benefit to app traces. This CL does the following: * Create a GLES1ShaderState class that contains hashable data * Populate it with all states influencing ubershader generation * Hash the class to perform the lookup of existing programs Frame times on Android ARM with locked GPU clocks: Trace Before After dr_driving: 4.2986 -> 0.8155 sonic_the_hedgehog: 2.8223 -> 0.6254 summoners_war: 15.9810 -> 2.3937 wordscapes: 7.6167 -> 1.1496 zillow: 2.9368 -> 1.9318 Test: end2end, perftests, gles1_conformance Bug: angleproject:6644 Change-Id: I060280e282d7b514d3e410c4f8c5e09659e85d3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3280355 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 0d67a4fa 2021-11-18T20:12:34 infra: Increase gles1_conformance_tests timeout In anticipation of GLES1 ubershader updates that result in faster frame times, but more compiles. The GLES1 conformance tests iterate through every state and render one frame, which is slower when you link a new program for each. Bug: angleproject:6644 Change-Id: I70501ea38505428569ba518710ecb03ce198db18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292511 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com>
Lubosz Sarnecki 1cc5d096 2021-10-21T19:58:58 mathutil: Add roundDownPow2. Bug: angleproject:5857 Change-Id: I6c7ae92a41957e9e6b40b6449f763a49493488d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3236996 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill a00ce2ca 2021-11-19T10:23:53 Vulkan: Fix CFI ignore config. This was being applied to "vulkan" when it should be higher in the chain of depedencies. This CL moves it to "vulkan_icd". Bug: angleproject:6496 Bug: chromium:1271193 Change-Id: I064caac6afe237d7008389f444d6ef9f37cff286 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289937 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 6a70398c 2021-11-19T09:41:58 GN: Ensure using_sanitizer is declared even without //build. Bug: angleproject:5795 Change-Id: If37375a9925d8449a15a63e98caf60d7dc75a751 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289936 Owners-Override: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll bb75eac0 2021-11-19T14:32:30 Roll Chromium from c801e56b48b9 to ebb70a6ec0bc (399 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c801e56b48b9..ebb70a6ec0bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b0986a849c..13d46663be * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/81212d29a2..a63bbc1389 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/7f068e554e..038090f742 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4cd7b34100..b632243411 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b4277291f8..ebda326985 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..153af62da5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c7dec337d..b6c1ed40d5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8caa4c5164..29a2573216 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/19145774c9..c8ce774f11 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I05cd27f276e1bd11999f55ac994a1b1a4ab10e05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292491 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 6168e303 2021-11-18T08:55:22 infra: Enable flaky retries on Mac end2end_tests. These tests are heavily flaking and causing CQ churn. Mark them as retriable until we can root cause the flakiness. Bug: angleproject:6570 Change-Id: I9886a655b88737acbe7ce728fa32573ac4d6145f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289104 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 7e40d556 2021-11-19T10:01:25 Roll SwiftShader from 4c687cc2f8ea to f5cf2d08ff9c (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/4c687cc2f8ea..f5cf2d08ff9c 2021-11-18 swiftshader.regress@gmail.com Regres: Update test lists @ 4c687cc2 2021-11-18 ari.suonpaa@siru.fi Fix border color when sampling normalized texture formats If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I8c360dc440c00167d08aaa51c80b312ec51250e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292965 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b03d7f77 2021-11-19T10:01:46 Roll vulkan-deps from 478aa76e7d38 to f2ad120142ed (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/478aa76e7d38..f2ad120142ed Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/0d468a7eee..dd83c37b98 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b20a8243ad..fc509008c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I143b2e9657800ac1d9d0475c187b364f6baa95e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292981 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott 1f5eb6b8 2021-11-17T16:42:20 Avoid Android vkEnumerateDeviceExtensionProperties() bug This works around a race-condition during Android start-up, when ANGLE is used as the default GLES driver and when render engine (RE) is using SkiaGL (which uses ANGLE, which uses Vulkan). The race condition occassionally results in different numbers of extensions between ANGLE's first and second calls to vkEnumerateDeviceExtensionProperties(). In that case, the second call would return VK_INCOMPLETE instead of VK_SUCCESS. That caused ANGLE to fail to initialize, causing RE to fail to initialize. This change works around this problem by increasing the number of extensions asked for in the second call to vkEnumerateDeviceExtensionProperties(). Background: Surface Flinger uses Hardware Composer (HWC) for hardware-based composition (e.g. using overlays), and RE for GPU composition (e.g. rendering to combine multiple app and system windows together). SF, RE, and HWC all start about the same time. HWC sets a property if it can support display timing. This gets passed through SF to RE's Vulkan loader. The Vulkan loader uses that property to determine whether to enable the VK_GOOGLE_display_timing extension. The Vulkan loader used to make a synchronous call to SF in vkEnumerateDeviceExtensionProperties() in order to get this property. That took some number of milliseconds to complete and affected the start-up time of every Vulkan/ANGLE app. To eliminate that performance problem, the property now propogates in an asynchronous manner. At that time, it was thought that RE would always get the property in time. However, a partner's experience is that VK_INCOMPLETE is happening 0.5% of the time. ANGLE doesn't need to use the VK_GOOGLE_display_timing extension. This is because the Android EGL loader provides the related EGL_ANDROID_get_frame_timestamps extension. The issue that ANGLE is working around is that it shouldn't fail to initialize in this situation. Bug: angleproject:6715 Bug: b/206733351 Change-Id: I4eb2197cdcc9692518b1bf5984d06fc8a1a7d145 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3290506 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Geoff Lang 1bcbbd3b 2021-11-18T10:53:04 Roll chromium_revision 426f5c5607..c801e56b48 (941724:943107) Change log: https://chromium.googlesource.com/chromium/src/+log/426f5c5607..c801e56b48 Full diff: https://chromium.googlesource.com/chromium/src/+/426f5c5607..c801e56b48 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cfe2150f91..b0986a849c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b138e6ce86..075dd7e228 * buildtools/linux64: git_revision:90294ccdcf9334ed25a76ac9b67689468e506342..git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e * buildtools/mac: git_revision:90294ccdcf9334ed25a76ac9b67689468e506342..git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/707d75f53e..81212d29a2 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/51ffc5ed5c..7f068e554e * buildtools/win: git_revision:90294ccdcf9334ed25a76ac9b67689468e506342..git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/65e053eeaf..4cd7b34100 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/312bb312c9..13257ba994 * third_party/android_sdk/public: AuYa11pULKT8AI14_owabJrkZoRGuovL-nvwmiONlYEC..Ez2NWws2SJYCF6qw2O-mSCqK6424l3ZdSTpppLyVR_cC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e6e1eb6895 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7b33514431..1c7dec337d * third_party/r8: CgqKHWrPllIffdVKV209JAStQqR93hUpTzSwKQ5Mth8C..nqWomZTwNDoogX26WeCSoFGg6aQN1FrwzoU4hCS0duEC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/32d7c383a4..8caa4c5164 * tools/luci-go: git_revision:0e76392e6557cc3ff8d95c3bc012540e0dbc128a..git_revision:2dfe2f218f0395673f336d17b841edf629907ae3 * tools/luci-go: git_revision:0e76392e6557cc3ff8d95c3bc012540e0dbc128a..git_revision:2dfe2f218f0395673f336d17b841edf629907ae3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e1dd5dfb7b..9e42d0c22f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ffa11379f7..19145774c9 DEPS diff: https://chromium.googlesource.com/chromium/src/+/426f5c5607..c801e56b48/DEPS No update to Clang. TBR=geofflang@google.com, BUG=None Change-Id: I628302cee721b340b722ffff2be0bf45645ac13e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289108 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill 5f755c29 2021-11-17T16:29:37 Vulkan: Lock around handle counter. TSAN showed we could have a data race when multiple threads were releasing objects because of the singleton handle counter. Bug: angleproject:6714 Change-Id: I23b5d343bec421a663198e7efc30c78dab2bde8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3288328 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 8700d9cc 2021-11-17T16:17:59 Vulkan: Lock around debug annotator. TSAN showed thread contention could happen during make current calls and when inserting debug markers. Bug: angleproject:6714 Change-Id: I343b0bd6efbd46621f9e69bd8a329c135aed0d90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3288327 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 8c634492 2021-11-17T11:06:23 Updates to perf test running script. - Fixes logging (needed reload) - Improves logging messages (less spam) - Reduces time in test calibration & sampling - Record failures on test errors more robustly - Redesign the result recording class Bug: angleproject:6090 Change-Id: I53fd86e9e009bd52ec98507334c69b05e711d83e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3288206 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 06d34598 2021-11-17T16:16:27 Vulkan: Add mutex around cache stats. TSAN showed thread contention could happen in multithreading tests because of the singleton cache stats object. Bug: angleproject:6714 Change-Id: I701aa0079b5eb9d60ef557b13ce57efba17df2fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3288326 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 5e6089d6 2021-11-18T12:50:30 Roll SwiftShader from f0e8ec2da282 to 4c687cc2f8ea (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f0e8ec2da282..4c687cc2f8ea 2021-11-18 srisser@google.com Regres fetches HEAD and truncates deqp.json 2021-11-17 swiftshader.regress@gmail.com Regres: Update test lists @ e068963d 2021-11-17 capn@google.com Add support for VK_FORMAT_B8G8R8A8_UNORM|SRGB as storage image formats 2021-11-16 swiftshader.regress@gmail.com Regres: Update test lists @ f0e8ec2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I6b21e07b8845b9ac9dd640ef296f46488e5abcc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291351 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b59d71fa 2021-11-18T12:54:56 Roll vulkan-deps from 50e341fc93fd to 478aa76e7d38 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/50e341fc93fd..478aa76e7d38 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/d51d01ccfb..0d468a7eee * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/447f2289f0..22e9c7c538 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/bfdd0c8753..a01b76b168 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/21286f81b8..b20a8243ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I1391304359eef0626b6af0993ac6189af1fde7ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291235 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 71bffb8a 2021-11-09T11:16:07 Capture/Replay: Handle newly generated FBOs in tracker Bug: angleproject:6425 Change-Id: I39d22a6770290a0c407ac358b1c059c6a2ddeefa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3269886 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Jamie Madill 9a36c3b6 2021-11-15T13:46:06 infra: Update NVIDIA to 1660 testing. Bug: angleproject:6694 Change-Id: I2580b53e45e633af98be757d9bb081461c06de95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3283163 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 83fa1890 2021-11-17T12:17:31 Disable variable shadow warnings on more ES1 conformance tests The list of gles1 sources is used in several targets without a common config. Bug: angleproject:6703 Change-Id: Ib78719c9dc322075dfba05380e99ec1ada8a3265 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289616 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Lingfeng Yang e9f9fa17 2021-11-09T18:13:15 Add cpu time measurement to perf tests Bug: angleproject:6667 Change-Id: I16570a7b51d363dd1c0f35789b985520cb76d488 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270601 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Gert Wollny 30c03b56 2021-10-28T12:54:39 Capture/Replay: Capture GetTexLevelParameter return param Bug: angleproject:6180 Change-Id: Ia063d297bab85d6cb559642b9be213cc6f10a9bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3250884 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 613f0361 2021-11-13T14:19:16 Fix typo in SystemInfo_libpci.cpp Bug: angleproject:6691 Change-Id: I26d4cdc3839b71002c40ff114e5cb43d60ef2e81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3279232 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 82cccf04 2021-10-28T12:49:55 Capture/Replay: Additional tests that now compile Bug: angleproject:6108 Change-Id: I010ae0cd276fcd5093860400c2f7436c9b0bfedf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3250883 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 89e3de97 2021-11-11T10:18:36 GN: Add symbolizer data for sanitizer builds. This is necessary to produce correct stack traces. Bug: angleproject:5795 Bug: chromium:1268935 Change-Id: I011d0948779718ed38305624c87a193a6ad0f8bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276512 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 3979383c 2021-11-17T12:53:56 Roll vulkan-deps from 459e5e53952a to 50e341fc93fd (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/459e5e53952a..50e341fc93fd Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/8a7860e4cb..d51d01ccfb * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ccdf836207..4b092d2ab8 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/8c1c27d5a9..83e1a9ed8c * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4f78f14c05..447f2289f0 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8d361dd235..bfdd0c8753 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/81dfeef144..21286f81b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I15362a111afb709dedd04f8061015e9fc9d1e476 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289228 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny fc5fe46d 2021-10-28T12:47:15 Capture/Replay: Capture GetProgramResourceLocation name param Bug: angleproject:6180 Change-Id: I5f27c695c31a32989c579b54e31cccc5b337bd58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3250882 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 95e1d244 2021-10-28T12:24:59 Capture/Replay: Capture GetProgramResource params correctly If a non-nullpointer is passed for length then the the number of param entries that is written is returned in *length. Otherwise, just capture the full buffer size as specified by bufSize. Bug: angleproject:6180 Change-Id: If7c3084e56c990477ddb6e93b8682e27004ba1e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3250881 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3ce1abd8 2021-11-16T14:38:15 Test Runner: Print output snippet in test timeout. This will be helpful in diagnosing test failures. Bug: angleproject:6694 Change-Id: I0ea491fe8ab48dfd017ce40150f606c571f3fa6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285805 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill c664c9fc 2021-11-16T12:22:47 Vulkan: Generalize barrier VVL suppression. Seems to pop up in other tests as well. Seems to only affect SwiftShader configs. Run capture_replay_tests.py with the below test. Test: BuiltinVariableVertexIdTest.LineLoop/ES3_Vulkan_SwiftShader Bug: angleproject:6701 Change-Id: I857d4785d6e04edf96fb137a492548ed4d9fbcc4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285445 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill de5a290d 2021-11-16T15:29:31 infra: Increase sharding on SwANGLE trace tests. These tests were timing out in test infra. Bug: angleproject:6496 Change-Id: Idd9b36051e1d0327602fa148d7a8c7b44d918b30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285807 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ian Elliott b9c0194c 2021-11-16T11:36:52 Add EVENT0 markers for why we call vkAcquireNextImage This will help when looking at AGI system traces. Bug: angleproject:6696 Change-Id: Ic4b06f1a1ec155076cfcb47299afe451cd325327 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3283428 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Lingfeng Yang 27bc56c6 2021-11-15T18:18:53 Vulkan: MAP_UNSYNCHRONIZED_BIT: Skip ghosting/idling Respect the following spec language: No GL error is generated if pending operations which source or modify the buffer overlap the mapped region, but the result of such previous and any subsequent operations is undefined Test: cpu time improves in unsync case in perf-tests/MapBufferRange.cpp Bug: angleproject:6680 Change-Id: I6133952546735aced6e6ee8468ef2ac695316fb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3272018 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Lingfeng Yang 647a703e 2021-11-12T13:48:06 Vulkan: Reorder logic in BufferVk::mapRange This CL flattens the logic, ordering read case first, then write, and simpler cases before more complex ones. This is to prepare for an optimization where we ignore certain paths if MAP_UNSYNCHRONIZED_BIT is set. No change in functionality or performance is expected. Bug: angleproject:6680 Change-Id: I0a2e9ee969216c90353eac7af6dabf648dea2173 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3279615 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang b9a8f092 2021-11-16T10:44:26 Disable variable shadow warnings on ES1 conformance tests Bug: angleproject:6703 Change-Id: Ie66b5afc12c4f29f69b8d7e205de02cadd5268a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285383 Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 353b62c9 2021-11-16T09:04:52 Use Python 3 in trigger.py. Bug: angleproject:5707 Change-Id: I7b1281711133ef3a60257c602f1af1db7f3af85f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3284395 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 316dcb56 2021-10-06T09:31:49 Add SwANGLE Skia Gold testing. Required updating our system info helper to be able to retrieve SwiftShader device information. Bug: angleproject:6496 Change-Id: Ib38ea4da65d199433e17b87df2630c3fd77cb619 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208646 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill f525d155 2021-11-16T08:31:04 Update DEPS roller script to use 'main'. It was still using the 'master' branch. Bug: angleproject:6700 Change-Id: I6b0d94f049b46741853ef07ba4f8f8ff7d156622 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3282687 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 9e4ade68 2021-11-16T10:01:29 Roll SwiftShader from 6885768e737f to f0e8ec2da282 (10 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/6885768e737f..f0e8ec2da282 2021-11-15 capn@google.com Implement shaderStorageImageWriteWithoutFormat support 2021-11-15 capn@google.com Perform image write from a static function 2021-11-15 capn@google.com Support writing to storage images with packed formats 2021-11-15 capn@google.com Provide StorageImageDescriptor with an image view identifier 2021-11-15 capn@google.com Make GetTexelAddress() independent from SPIR-V parsing 2021-11-15 srisser@google.com Detemplatize hasExtendedFeatures 2021-11-15 msisov@igalia.com Rename use_x11 to ozone_platform_x11 2021-11-15 capn@google.com Allow dereferencing of constant Reactor pointers 2021-11-15 capn@google.com Parse the OpTypeImage information into ImageInstructionSignature 2021-11-15 capn@google.com Parse OpImageTexelPointer into an ImageInstruction If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I5dbd59f245011d407f512754625532e4c1ae9ffe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3284636 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 376d8136 2021-11-16T10:01:28 Roll vulkan-deps from 712bb5b10bcf to 459e5e53952a (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/712bb5b10bcf..459e5e53952a Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/f669f13998..8a7860e4cb * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/7c3cb0b12c..37dfb3f45f * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/6912527562..8d361dd235 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a9101d35aa..81dfeef144 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Id788e890e8ebf5865b487c75727e9407bfc9d616 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3284591 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 5c6998e4 2021-03-30T09:33:55 Mark objects as initialized when robust init is disabled. If a context with robust resource init disabled allocates a texture, make sure it's marked as initialized or else the texture may be reinitialized later by a context with robust resource init enabled. Bug: chromium:1192632 Change-Id: I643f616c89420312f341b53cedbd1a4e4dc58675 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2794621 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org>
Jamie Madill d27552f2 2021-11-11T11:43:30 Re-land: "Vulkan: Allow SystemInfo to pick ICD." Re-land fixes build on iOS and Android with ANGLE/Vulkan. This will be used in conjunction with SwiftShader. Bug: angleproject:6496 Change-Id: Id38403da1e377bba293dc8368d1c1aac29bf56a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3282426 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 7d33e71a 2021-11-15T11:20:25 Vulkan: SPIR-V Gen: Don't generate names for constants Multiple constant variables can have the same value, and they are coalesced to the same SPIR-V id. It's not useful to attempt to generate multiple constants with different names, especially as those names don't make it into the SPIR-V-Cross-generated GLSL. Additionally, most constants in the translator don't retain their name, only the ones that are not folded do (and which are folded is a rather arbitrary decision). By generating names for these constants, the SPIR-V gen code was introducing a bug where multiple OpNames could be generated for the same OpConstant* id. This change removes OpNames generated for constants in the first place. Bug: angleproject:6644 Change-Id: Ife2f4bee8e2eb095dc0b22994420ee1dfc6023c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3282425 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 96bce6bd 2021-11-15T14:12:32 infra: Fix UBSAN build. The compilation of the trace tests would fail in UBSAN with optimization disabled. Fix this by allowing optimization of the large traces when running under UBSAN. Bug: angleproject:5795 Change-Id: Ib11514a00495ed1af4faeecca81283f4c98da135 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3283164 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Vadim Shtayura bc2ca15c 2021-11-11T16:29:59 Declare "role/configs.validator" binding. It defines who is allowed to call LUCI Config validation API to validate this LUCI project's configs. This is usually done by presubmit jobs, and thus configs.validator role is assigned to try job task accounts. Previously this ACL was defined in the global "config-validation" group. It is deprecated and being replaced with per-project ACLs defined in per-project configs (like in this CL). There's still a global ACL to allow any googler to call the validation API in any LUCI project they are allowed to see. Thus the per-project binding applies only to service accounts (they are not googlers). Note that this CL was generated semi-automatically and reviewers are picked automatically based on OWNERS file. Bug: chromium:1068817 Change-Id: Iadd19a74e3b0bce330ee0d6fd29046ab03d5c2cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276460 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 58f84494 2021-11-15T17:30:53 Roll Chromium from 06cb60827cd5 to 426f5c560740 (142 revisions) https://chromium.googlesource.com/chromium/src.git/+log/06cb60827cd5..426f5c560740 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d134d68f00..cfe2150f91 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/076f0a1173..65e053eeaf * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..45cccc688e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7ca4f55087..7b33514431 * third_party/r8: nqWomZTwNDoogX26WeCSoFGg6aQN1FrwzoU4hCS0duEC..CgqKHWrPllIffdVKV209JAStQqR93hUpTzSwKQ5Mth8C * third_party/turbine: KbLQUR_KFiUEzVt1lMTORY96bz_PbMwC3GwIb1oGJmAC..mlH0GH_teB71nsyjwL_if7NtARJdHnf6-4VXRFyGujgC * tools/luci-go: git_revision:4cf9fa8105d30e3a6855bbfca50c5d6f88efb6b2..git_revision:0e76392e6557cc3ff8d95c3bc012540e0dbc128a * tools/luci-go: git_revision:4cf9fa8105d30e3a6855bbfca50c5d6f88efb6b2..git_revision:0e76392e6557cc3ff8d95c3bc012540e0dbc128a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ebec44a7a2..e1dd5dfb7b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f701cecc7c..ffa11379f7 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I995b833756f9b195ad840b9e2391b0886e336c92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3282950 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0