kc3-lang/angle

Log

Author Commit Date CI Message
Lingfeng Yang c88a73c8 2021-12-02T12:49:00 Fix flakiness in CpuTimeSleepy Looks like we can't really rely on the direct wall comparison---probably different resolutions are tripping us up here. Bug: chromium:1272977 Change-Id: Ie3691c59eb5b3765b79f1861200436d9c5acd609 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3313481 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 6f96a189 2021-12-01T11:14:33 FrameCapture: Clean up 'WriteCppReplayFunctionWithParts'. This function was using two extra temporary streams that it didn't need. Clean this up and remove the extra streams and repeated code. Bug: angleproject:5133 Change-Id: I8065a189211ba9030fee523dc7145dc5daf71d92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3311577 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 6c00068c 2021-12-03T10:01:52 Roll vulkan-deps from 933bb8aaaef9 to 9970c397e55e (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/933bb8aaaef9..9970c397e55e Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/a152371654..ea61f32f24 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/737b390a4c..876a1b9c34 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ae1ef56fc9..81195dfecb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ie5c3405f5b0c3f751aab52f3464f0b4d9037ba71 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3314498 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9498d04b 2021-12-03T10:01:32 Roll SwiftShader from f9c39655a610 to a465cca8ec8d (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f9c39655a610..a465cca8ec8d 2021-12-02 nicolascapens@google.com Add bclayton to OWNERS 2021-12-02 swiftshader.regress@gmail.com Regres: Update test lists @ f9c39655 2021-12-02 capn@google.com Update SPIR-V Tools to c75a1a46f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ib9b5187cb028e6f87b48806d0849c8a8622dbfac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3314172 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f58b8aba 2021-12-03T07:02:45 Roll Chromium from d666676e2702 to 840fab92609d (514 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d666676e2702..840fab92609d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/83e1eefbf9..b651c3285d * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/a281fd3d4c..0f447a3138 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c70310ef4a..9044f53831 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8ccce98a2e..db126cca75 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..dbf853603c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fc79a33466..98be56f2e0 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e8c257c917..efd9399ae0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/401e727f2a..16279ec9aa * tools/luci-go: git_revision:91cbdea8898ac2d498f2412d35279b00784a1ece..git_revision:2892a4983327fe6862e8657e5fac8e976e6265e9 * tools/luci-go: git_revision:91cbdea8898ac2d498f2412d35279b00784a1ece..git_revision:2892a4983327fe6862e8657e5fac8e976e6265e9 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/33b0162246..58b6f08974 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f102ca3bc2..6bdbc14474 * tools/skia_goldctl/linux: CseaUnLJ7HPr--xryu13CF7Iir6n0b8qmCJXm6gyZ4oC..wdkOk4Hhfdk2f0Fn4TnicgWCxDVdkOK0W71K0ivXMaEC * tools/skia_goldctl/mac: VY8wueKQ3PgFlxfrtkyEqIEUBvFjmyowZ9aUNYRyEhcC..gJSgm5xIzq6ePie9lIvMfyt3vEXbiVb5NreHTEkFS58C * tools/skia_goldctl/win: W_IYtpGZzolSY2j4xqryufwbZeApZYaqqcn4-CTtpL0C..BkeCwTnJJi2hffEKlsGWTiP5quyDianpBWnloFZ49ZEC Clang version changed llvmorg-14-init-8564-g34b903d8:llvmorg-14-init-11072-gb1bc627e Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/401e727f2ae6663c4e13dfd3e1006cc9fa34bb10..16279ec9aa9650adc022985ea0831c9ca0c62fd9/scripts/update.py Bug: None Tbr: ynovikov@google.com Change-Id: I150b951cc16b0bbc50fe3ca696b6f10cadda8129 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3314496 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jeff Vigil fe42ac4d 2021-11-29T15:45:40 EGL: deferredFlush fix for PRESENT_MODE_SHARED Add work around to deferredFlush for SINGLE_BUFFER Fixes issue with EGL_KHR_mutable_render_buffer and deferredFlush feature. Bug: angleproject:6739 Change-Id: I81f87899f2c92a7e001b6aee2f88ecf7ba0d40a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308224 Commit-Queue: Brandon Schade <b.schade@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f3052589 2021-12-02T17:38:51 Roll vulkan-deps from cb8be59599df to 933bb8aaaef9 (25 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/cb8be59599df..933bb8aaaef9 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/febbeb4f83..ec5ea2d6cb * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/37dfb3f45f..e9cc640334 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/814e728b30..29414ae1fd * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d0a827a9f3..c75a1a46f3 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3c1ad4b0d5..737b390a4c * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/b50a0f786e..08f87babad * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/00e8145e37..ae1ef56fc9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ia3341deca9184161c8e1f0897b54f9b1397a4388 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3313476 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 8e6f38e5 2021-12-02T17:24:32 Revert "Vulkan: Implement GL_EXT_multi_draw_indirect" This reverts commit 79f9d163b4227115a3e60e027ec4d7dbe0495f64. Reason for revert: Breaks dEQP-GLES31.functional.draw_indirect* on Pixel devices: https://blackbox.googleplex.com/dashboard/cts-graphics/target/git_master/oriole-userdebug/3/cts-angle-host-test-arm64-v8a/4 Original change's description: > Vulkan: Implement GL_EXT_multi_draw_indirect > > * Optimized the implementations of multiDrawArraysIndirect() > and multiDrawElementsIndirect() for Vulkan > * Added helper functions to support drawArraysIndirect() and > drawElementsIndirect() as special cases of multiDraw*Indirect > functions. > * Added the flag to enable the multiDrawIndirect feature > (drawCount > 1). The generic implementation is used if the > flag is disabled. > > Bug: angleproject:6439 > Change-Id: Ibc653d93d355657f828de9c33da22428629e450f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276044 > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:6439 Change-Id: Ia4d54ef3e7652febf4d77fdaf6809f57e8e29127 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312829 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll 38b96fcc 2021-12-02T10:01:31 Roll SwiftShader from ff91ac52f4b7 to f9c39655a610 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ff91ac52f4b7..f9c39655a610 2021-12-02 srisser@google.com Expose support for VK_KHR_swapchain_mutable_format If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I07818cef0b8f03f3d36caf2ab3e632d03f7439b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312055 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 29babe0f 2021-12-02T07:01:19 Roll Chromium from d2d61620103d to d666676e2702 (101 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d2d61620103d..d666676e2702 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ac23806e2b..c70310ef4a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5695a8426c * tools/luci-go: git_revision:e4c95e4e4cdc987f1860e4111589606bcd3a8f32..git_revision:91cbdea8898ac2d498f2412d35279b00784a1ece * tools/luci-go: git_revision:e4c95e4e4cdc987f1860e4111589606bcd3a8f32..git_revision:91cbdea8898ac2d498f2412d35279b00784a1ece No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I9c9dd687124af08fe729cdfe08d0f2363a2b0651 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312817 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7107f8aa 2021-12-02T00:57:17 Roll Chromium from 5bf1cc589ddf to d2d61620103d (907 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5bf1cc589ddf..d2d61620103d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dcea344303..83e1eefbf9 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/665b74f7d1..89f2e82120 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c936d73ff7..a281fd3d4c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f1bdd0ee5c..ac23806e2b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/457dbf3362..8ccce98a2e * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/72e09e98a6..abc362f16d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5695a8426c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/804165b445..fc79a33466 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/2231b7c84b..e8c257c917 * tools/luci-go: git_revision:7422359d33c606e8adb0e9cf461837eb9b49431f..git_revision:e4c95e4e4cdc987f1860e4111589606bcd3a8f32 * tools/luci-go: git_revision:7422359d33c606e8adb0e9cf461837eb9b49431f..git_revision:e4c95e4e4cdc987f1860e4111589606bcd3a8f32 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4c93694b28..33b0162246 * tools/md_browser: https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/9772d4c05b..b61dc90769 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/bfbdc93fb6..0639a8c19c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b4c2add623..f102ca3bc2 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I9b98c846e8400c5e28ae0370d71dc08b98bae2bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3312364 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shrek Shao 36bf1ebe 2021-11-17T13:31:17 Decouple gl_BaseVertex/gl_BaseInstance uniforms These are builtin uniforms removed in https://github.com/KhronosGroup/WebGL/pull/3278 Decouple them from the original ANGLE_base_vertex_base_instance extension. Make a new ANGLE_base_vertex_base_instance_shader_builtin extension for these builtin uniforms. Bug: angleproject:3402 Change-Id: I77b93917976ce435db9c578c0ade37bff18a42b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3290304 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Lingfeng Yang 8815245a 2021-12-01T08:58:01 Vulkan: Don't retain in buffer/imageRead unnecessarily mUsedBuffers/images already tracks whether a buffer/image is used in a render pass, so we can add to ContextVk's resource use list only once. Bug: angleproject:6717 Change-Id: Idd528c7f0f3fcb4d8d8879ab6cc7055260ecb45d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3310523 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jonah Ryan-Davis 2d41e0f7 2021-11-30T16:14:03 Rework compressed texture pixel unpack state handling. Compressed images do not use the pixel unpack parameters. Instead of handling this in Context, move this to formatutils, where it's already handled for the 2D case. Also, update the test to generate an ASAN error if not ignored for the 2D case. Bug: chromium:1267496 Change-Id: Ib93bae00a2b0b75eafd74c267f737da225afd993 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308825 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 8f6f5a4b 2021-11-30T23:48:30 Vulkan: Fix image respecify's usage tracking When respecifying an image due to mip level count changes, the previous image is staged as an update to the new image. The resource usage info was not being transferred to the image being staged as an update, causing it to be prematurely deleted. Test based on one authored by sugoi@google.com. Bug: chromium:1270658 Bug: angleproject:4835 Change-Id: I215c65ba700d7be608d0910d3cb37fcfdf297a2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308921 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 609eb31a 2021-12-01T10:24:59 Skip MultithreadingTestES3.MultithreadFenceTexImage on TSAN Bug: angleproject:6718 Change-Id: If67662dfb2ade1c87e9b4ba22e65efabf17f096c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3310485 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 9d91064d 2021-11-30T17:56:31 Document using Rubber Stamper for test expectations CLs Also includes a small update about FLAKY expectations. Bug: angleproject:6740 Change-Id: I4df6534412e3720fb9f7bdeeadc555892016b7fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308830 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill f84dc44f 2021-11-30T12:22:21 Add a test for changing an XFB buffer after Begin. Bug: chromium:1274316 Change-Id: I4ba240ff4cc383b157a64a0c92e8ce8ab2d8061e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309101 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 3b6f80b7 2021-11-23T10:07:43 Capture/Replay: eliminate redundant parameters in GenOnBind The template parameter already defines the parameter value name and the parameter value type, so add some traits to simplify the call interface of the function. Bug: angleproject:6425 Change-Id: I037bed8e5cc2e7367d8faa3af5d4fba2bfbb52c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295617 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 5f67a941 2021-12-01T10:01:31 Roll SwiftShader from f12305c3a0d9 to ff91ac52f4b7 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f12305c3a0d9..ff91ac52f4b7 2021-11-30 capn@google.com Prevent exit-time destructors in src/WSI, Pipeline, and System 2021-11-30 capn@google.com Update SPIR-V Tools to d0a827a9f 2021-11-30 capn@google.com Update SPIR-V Headers to 20b02de99 2021-11-30 capn@google.com Don't handle vendor-specific SPIR-V instructions 2021-11-30 capn@google.com Don't consider OpType* instructions to be statements 2021-11-30 capn@google.com Eliminate SpirvShaderInstructions.inl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I4beaf0c50689731ac1d05bd2b44867d806b8be8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309214 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov fc860bc1 2021-11-30T17:39:42 Skip *Vulkan_AsyncQueue angle_end2end_tests on TSAN Bug: angleproject:6746 Change-Id: If8bbf8ffc4c6d5df376ebd7c3d51c98c6990ea0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308829 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Ben Pastene 8e430236 2021-11-30T12:43:40 Enable the chromium recipe RDB results experiment for all builds. This experiment has been enabled at 100% for all chromium builds for months now. And the more builders are on it, the more we're able to refactor the chromium recipe. This was attempted in crrev.com/c/3307244, but had to be reverted since angle builds re-use much of chromium's recipe code but don't have the experiment rolled out to them. So this rolls it out to angle builds to allow for further clean-up in chromium's recipe code. Since all angle tests are wrapped via result_adapter, they should already have RDB integration (meaning their results are already uploaded to RDB). A LED run of a build with this experiment applied: https://ci.chromium.org/swarming/task/578b98d07382dd10?server=chromium-swarm.appspot.com Another LED run with that experiment and the recipe CL relanded: https://ci.chromium.org/swarming/task/578b9939cfccdb10?server=chromium-swarm.appspot.com This matches its original build: https://ci.chromium.org/ui/p/angle/builders/try/win-test/1026/overview Bug: chromium:1135718 Change-Id: Ief4993fa9c027f9c2c6c3c352eb4e65ce74b628c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309479 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 45028d29 2021-11-30T10:37:06 D3D11: Fix OOB access in vertex conversion code. This could happen when using certain combinations of stride and offset. Fix the issue by using checked math. Bug: chromium:1274499 Change-Id: Idba3beedad10b0c0cac2dcbecba8e420c5baa6da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309035 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Alexis Hetu 7817761a 2021-11-23T22:47:44 Vulkan: Use the correct format when binding a pBuffer. Vulkan would get the texture format from the pBuffer's config but some pBuffer types use different formats which are queried with getBindTexImageFormat. This CL also removes nativeSizedExternalFormat. nativeSizedExternalFormat was only used when the format/type is GL_RGB/GL_UNSIGNED_BYTE. This is now obsolete since the real fix was the pBuffer fix mentioned above, so this CL cleans up the now unnecessary code. Bug: angleproject:4369 Bug: chromium:1237561 Bug: chromium:1099979 Change-Id: Ibfedea60d10856831e3a1975ac20ae5eb6a73786 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3298352 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Yuly Novikov d7b3c6d1 2021-11-30T15:25:36 Don't build dEQP tests on MSVC temporarily dEQP fails compile on MSVC Due to build switching to C++17. Temporarily stop building them while VK-GL-CTS is being fixed upstream. Bug: angleproject:6737 Change-Id: I288aab95cb76104fde7635eafb37d56b4ed0a600 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308820 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 1125db99 2021-11-30T09:58:19 Roll Chromium from b510b0864113 to 5bf1cc589ddf (826 revisions) Manually restrict "build" dep to dcea3443035f48d58193788e0bc56daca4e5db33 due to anglebug.com/6737 And skip updating "abseil-cpp" https://chromium.googlesource.com/chromium/src.git/+log/b510b0864113..5bf1cc589ddf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/26881c1164..dcea344303 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e504863f9e..665b74f7d1 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/f51a154281..c936d73ff7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/103f40247e..f1bdd0ee5c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8cf0922154 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2ffa1bde79..804165b445 * third_party/r8: CokGsfuGfcV-GjGwN98h28Phet4ai_xhPGZkGCqotWMC..KOlWWUU4CAY1EqgiZ6iljOP7ycIjceTEFcwWxL14HFoC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f8964a5ccf..2231b7c84b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ace657580d..401e727f2a * tools/luci-go: git_revision:03f7c59feeac59c211e5b06fbbbc7405861b482e..git_revision:7422359d33c606e8adb0e9cf461837eb9b49431f * tools/luci-go: git_revision:03f7c59feeac59c211e5b06fbbbc7405861b482e..git_revision:7422359d33c606e8adb0e9cf461837eb9b49431f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5d2edce177..4c93694b28 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/be66670475..b4c2add623 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/79ec84517e..ff9c7dc63d No update to Clang. Bug: angleproject:6737 Tbr: ynovikov@google.com Change-Id: I1c58d844163803dc2e861112dbc867e070d29476 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308639 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop ce854632 2021-11-29T10:48:48 FrameCapture: Fix Gen on Bind for MEC The logic for detecting whether a resource has been generated was not accounting for starting resources, which would only be populated if using MEC. We also weren't tracking framebuffer creation correctly in CaptureMidExecutionSetup. Test: Asphalt 9 MEC Bug: angleproject:5883 Bug: angleproject:6425 Change-Id: I8a7dfa4736c4d735dec8cd26ffa329f051927de6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3307778 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 440e5458 2021-11-27T19:55:06 FrameCapture: Integer attribs in MEC If the component type of a vertex attribute is integer, we need to use the appropriate VertexAttribI* functions to set it up. Test: Asphalt 9 MEC Bug: angleproject:5883 Change-Id: I2ab2248e5a36cc6636b081acf6474b5dbe2484db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3305057 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Peng Huang 65720272 2021-11-26T17:42:16 Add end2end gl test for *_ANGLE_vulkan_image extensions Bug: chromium:1264439,angleproject:6741 Change-Id: I12d332995138a020ba514fba34024c3e666b8e6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304396 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 2020ec2b 2021-11-18T16:49:35 Capture/Replay: run tests that will crash or fail compilation These tests have to run in one-sized batches so that they do not bring down other tests run in the same batch, but it is useful to run these tests to see whether chenges to the code fix these tests. In addition, update the expectations to reflect that more tests do not crash or even pass. Mark one more test as FLAKY because a change of the batch allocation seems to change this test. Leave timeouts as skip to not burden the CI too much. Bug: angleproject:6180 Bug: angleproject:6267 Bug: angleproject:6267 Bug: angleproject:6313 Bug: angleproject:6314 Bug: angleproject:6315 Bug: angleproject:6324 Bug: angleproject:6329 Bug: angleproject:6333 Bug: angleproject:6334 Bug: angleproject:6335 Bug: angleproject:6399 Bug: angleproject:6400 Bug: angleproject:6605 Bug: angleproject:6611 Bug: angleproject:6631 Change-Id: I973ec43feff8ca51de698e0aade3d7102b193166 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291643 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Yuly Novikov 17261f3b 2021-11-29T19:53:39 Remove not needed constexpr definitions, deprecated in C++17 Bug: angleproject:6737 Change-Id: I38ead1bd8e5eaace78750505b93a2576e19d0f83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3307535 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 739c414f 2021-11-30T10:01:53 Roll vulkan-deps from 81bb0c5b367f to cb8be59599df (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/81bb0c5b367f..cb8be59599df Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/083bdc838a..febbeb4f83 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ef2429635d..3c1ad4b0d5 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/a01b76b168..b50a0f786e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/dcd1e40ebb..00e8145e37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I6fdcf724e60d785842e83e1c2a3df72bd5848409 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308640 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 949624bf 2021-11-29T16:57:35 Skip MultisampleTest on Mac Metal ContentPresevedAfterInterruption/ES2_Metal_NoFixture__NoStoreAndResolve Bug: angleproject:6702 Change-Id: Iefff376ec8f3fb140825ad239bf8a2b560c8effb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3307346 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tim Van Patten ef65edf2 2021-11-22T14:23:35 Add extension: ANGLE_rgbx_internal_format Add the extension ANGLE_rgbx_internal_format, which exposes the ANGLE internal format GL_RGBX8_ANGLE. The format GL_RGBX8_ANGLE enables emulating RGB8 formats with RGBA8 within ANGLE. This also renames the format GL_RGBX8_ANGLEX to GL_RGBX8_ANGLE, since it's being exposed. Bug: angleproject:6690 Test: Texture2DTestES3.TextureRGBXImplicitAlpha1 Change-Id: I5548a3578a14e2f2a4006bbf59983b01f694b7f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296625 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 44d0ef69 2021-11-25T14:37:38 Vulkan: Enhance SamplerDesc for YUV formats In order to uniquely identify a VkSamplerYcbcrConversion, having just the format is insufficient. We need to account for conversion model and color component range. Refactor SamplerDesc by encapsulating YUV related fields into its own YcbcrConversionDesc. Bug: angleproject:6732 Test: Texture2DTestES3.*Yuv*Vulkan Change-Id: I23114c50646232dccde988a52b0649778ad72a90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301899 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Jonah Ryan-Davis 568a350e 2021-11-29T14:17:31 Suppress Texture3dTestES3.PixelUnpackStateTex[Sub]Image3D on Mac This test was newly added in the fix for https://crbug.org/1267496 It crashes similarly on Mac. Suppress for now while I work on the fix. Bug: angleproject:6738 Change-Id: Ifbdbb790b2f60fe91362ee47d1165165cb5c5382 TBR=ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3307478 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Peng Huang a5e391d7 2021-11-19T17:35:06 Add GL_ANGLE_vulkan_image extension glAcquireTextures & glReleaseTextures are added for sharing texture ownership with an external API. Bug: chromium:1264439 Change-Id: If46d8d230b4f611768b5ff1187674509e42f01e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3293921 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Mohan Maiya 00d0b79f 2021-11-26T14:38:20 Bug fix in BitSetArray iterator Account for gaps spanning multiple BaseBitSet while iterating. Bug: angleproject:3877 Tests: BitSetArrayTest*IterationWithGaps* Change-Id: I64a0393bf117678b0a7855904a6ac328a13bb40c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304108 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill f893c61b 2021-11-26T14:58:28 Update capture_replay_expectations.txt. Adds expectation for new skipped test. Also consolidates expectations into just SwiftShader since we cannot yet support multiple Vulkan implementations. Bug: angleproject:6688 Change-Id: I736d28f3e452624eae4cde8058a6c1acdaae1263 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304554 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a56d3c13 2021-11-29T10:01:31 Roll SwiftShader from edeff1f2e7db to f12305c3a0d9 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/edeff1f2e7db..f12305c3a0d9 2021-11-26 capn@google.com Statically allocate function pointer tables for libXCB 2021-11-26 capn@google.com Statically allocate function pointer tables for libX11 2021-11-26 capn@google.com Refactor libXCB and libX11 wrappers 2021-11-26 ari.suonpaa@siru.fi Fix component normalization for texture gather If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I37c1985f0aa8be3004b5be2d34ff258ee8ef714e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3306222 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 460cb0d5 2021-11-29T10:00:52 Roll vulkan-deps from b497675b7cba to 81bb0c5b367f (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b497675b7cba..81bb0c5b367f Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8c155b364c..d0a827a9f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I8e8257d6d7c19e89edf35626d38b6f8887a7f32e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3306232 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill c789169b 2021-11-26T15:21:43 Fix export_targets presubmit on Windows. It was checking for the vs toolchain in the wrong folders. Bug: angleproject:6735 Change-Id: Ia64f85b33fb6a1b30ca2ebf8ec86eee579e1e835 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304634 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 60e3dc12 2021-11-26T15:05:45 infra: Trigger win-trace on angle_end2end_tests changes. This should prevent a common class of unexpected CQ breakage. Bug: angleproject:6670 Change-Id: Ic5706caedcb2ca326ec87883d695574e5450083c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304555 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 14f55a7f 2021-11-02T10:16:58 infra: Enable TSAN and UBSAN tests. These tests are not yet enabled on the CQ. Bug: angleproject:5795 Change-Id: I3fc58ab800ebbc0840da8221b03b4ab145d28028 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258003 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 2797227b 2021-11-26T08:48:30 dEQP: Add flaky result handling. A flaky expectation will allow the test harness to retry a failing test one extra time. If the second run passes the flaky test will be considered a passing result. Bug: angleproject:5795 Change-Id: I09fc4ed34ee09548ab14f46dfce35f900be5550f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3303712 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e0b4cf6c 2021-11-26T10:23:24 Fix Python3 usage with perf tests/gold tests. Bug: angleproject:6733 Change-Id: I9d1baf78ed182db77c6a6d8e896737413ca417f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304012 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cheryl Wei 268653c9 2021-11-25T13:37:58 Vulkan: Update a test to triger large dirty bit handling Some traces bind one VBO to a large number of VAOs,and use glBufferData to change buffer size frequently,this will cause glBufferData spending a lot of time doing VAO dirty bit handling, which leads to high cpu load in these traces.This test could triger this issue. Bug: angleproject:6371 Change-Id: I99292825b8cb5bba58cc6b37e3baa7adcd02c780 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301536 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll d3aa873c 2021-11-26T10:01:32 Roll SwiftShader from 1d924bd00379 to edeff1f2e7db (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/1d924bd00379..edeff1f2e7db 2021-11-25 sugoi@google.com Make Win32SurfaceKHR::present() more robust If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I1ac5717a5358b8077a9f26a9e98bb74fe545c408 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3303136 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 48aab127 2021-11-26T07:01:20 Roll Chromium from 1f986773b3b2 to b510b0864113 (93 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1f986773b3b2..b510b0864113 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/209a6891b4..26881c1164 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/038090f742..f51a154281 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/af043a3d65..103f40247e * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8b7dd344d7..457dbf3362 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..75423c310e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d04fad9221..be66670475 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Iaabbb97fe8330f9d2c0b0aeb6f93e28e4ecae74b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3300997 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Stephan Hartmann 7f1ab9be 2021-11-25T21:59:51 Vulkan: add explicit template specialization for barrierImpl ImageHelper::barrierImpl with primary command buffer is used in other translation units (SurfaceVk::acquireNextSwapchainImage()). Linking fails if compiler has optimized out symbol for primary command buffer. Bug: chromium:819294 Change-Id: I91d79788ae51d24472e8bd1d20cdb1a375e86300 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301705 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Stephan Hartmann 43ae7834 2021-11-25T21:52:45 GCC: fix type conversion in FramebufferGL GCC has some problems deducing template argument. Help with assigning the value to a new const variable before using it. Error message: ../../third_party/angle/src/libANGLE/renderer/gl/FramebufferGL.cpp:308:70: error: default type conversion cannot deduce template argument for 'template<class Dst, typename std::enable_if<angle::base::internal:: IsNumericRangeContained<Dst, unsigned int, void>::value, void>::type* <anonymous> > constexpr angle::base::internal::StrictNumeric<T>::operator Dst() const [with Dst = Dst; typename std::enable_if<angle::base::internal:: IsNumericRangeContained<Dst, T>:: value>::type* <anonymous> = <anonymous>; T = unsigned int]' 308 | tmpPixels = new GLubyte[checkedAllocatedBytes. ValueOrDie()]; | Bug: chromium:819294 Change-Id: I3e720fea4a8e24aab0a9a9b3dedf9abdebaa44a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301704 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6eb3f661 2021-11-25T20:11:23 Roll Chromium from ad511b3c5051 to 1f986773b3b2 (589 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ad511b3c5051..1f986773b3b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/493ce927d2..209a6891b4 * buildtools/linux64: git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e..git_revision:b79031308cc878488202beb99883ec1f2efd9a6d * buildtools/mac: git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e..git_revision:b79031308cc878488202beb99883ec1f2efd9a6d * buildtools/win: git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e..git_revision:b79031308cc878488202beb99883ec1f2efd9a6d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/16f9b84af1..af043a3d65 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/13257ba994..8b7dd344d7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..75423c310e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/646c3cd4d6..2ffa1bde79 * third_party/r8: nqWomZTwNDoogX26WeCSoFGg6aQN1FrwzoU4hCS0duEC..CokGsfuGfcV-GjGwN98h28Phet4ai_xhPGZkGCqotWMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/994ccaf614..ace657580d * tools/luci-go: git_revision:2dfe2f218f0395673f336d17b841edf629907ae3..git_revision:03f7c59feeac59c211e5b06fbbbc7405861b482e * tools/luci-go: git_revision:2dfe2f218f0395673f336d17b841edf629907ae3..git_revision:03f7c59feeac59c211e5b06fbbbc7405861b482e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/25bed66ea8..5d2edce177 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b841fa72c2..d04fad9221 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/daf835c78a..79ec84517e No update to Clang. Bug: chromium:1273901 Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: Ie372f87f4e06e1f7425b9744137efc494b7605f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301911 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jonah Ryan-Davis 870f458f 2021-11-22T14:30:52 Ignore the pixel unpack state for compressed textures. From OpenGL ES 3 spec: All pixel storage modes are ignored when decoding a compressed texture image This was causing a bad access when calling compressedTexImage3D with GL_UNPACK_IMAGE_HEIGHT greater than the image height. Bug: chromium:1267496 Change-Id: I9b1f4c645548af64f2695fd23262225a1ad07cd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296622 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang e00ad443 2021-11-15T20:16:16 Add EGL_ANGLE_vulkan_image extension This extension is for exporting VkImage from EGLImage. The VkImage must be used with the same VkDevice used by ANGLE Vulkan backend. Bug: chromium:1264439 Change-Id: I222d900465cf2716d94fc64f06e240390ec518ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285025 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll 9f87adc2 2021-11-25T10:01:53 Roll vulkan-deps from 6402aa39e588 to b497675b7cba (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6402aa39e588..b497675b7cba Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/042aaea516..083bdc838a * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4b092d2ab8..8c155b364c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/cdf2f56fae..dcd1e40ebb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Iaf5bb69e1f21301c6195d7db89cad2f8d308429d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301910 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 49456ec4 2021-11-25T10:01:32 Roll SwiftShader from 17a11cfeb5f1 to 1d924bd00379 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/17a11cfeb5f1..1d924bd00379 2021-11-24 capn@google.com Assert that casting memory sizes to 32-bit doesn't overflow 2021-11-24 capn@google.com Use size_t for methods returning memory sizes 2021-11-24 capn@google.com Add a GN build option for the startup dialog If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I5a56e0dbdc015452d907830605c6eb6e3992ccf5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3302138 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gregg Tavares a0924015 2021-11-22T19:44:05 Metal:Fix GLSLTest_ES3.GLVertexIDIntegerTextureDrawElements Metal The test was failing if the "first" argument to glDrawElements was odd. When odd the offset was not a multiple of 2 bytes and the code was going down a different path than when the offset was event. The fix for that just removes a check for alignment to 4 bytes. Checking with UNSIGNED_BYTE indices though and it still failed. That was because it was encoding the index conversion path on one command buffer and the provoking index prep on another and so they were happening out of order. Putting both on the same command buffer fixes that. Bug: angleproject:6688 Change-Id: I89b68ba965d073e0fa70b6d5b444dc743b5e34a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296631 Commit-Queue: Gregg Tavares <gman@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 110ac03a 2021-11-23T09:36:08 Vulkan: Revert change to sRGB override support. An accidental testing change slipped into a fix for base/max level updates. This reverts the unintended change. Bug: angleproject:6728 Change-Id: I61e371149be590ce506cfc88165c4391538e54b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3298428 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ian Elliott 2fa1adf0 2021-11-24T18:29:13 Revert "Vulkan: Use vkResetQueryPoolEXT when available" This reverts commit 97aa5187ed164f1e9a22b64c966f2a747f651bfb. Reason for revert: This apparently caused crbug.com/1273344 Original change's description: > Vulkan: Use vkResetQueryPoolEXT when available > > ANGLE currently uses vkCmdResetQueryPool to reset a query pool. As > reported by Arm, this can cause GPU bubbles. It is better to use > vkResetQueryPoolEXT() when available (either by Vulkan 1.2 or by the > VK_EXT_host_query_reset extension). > > Bug: angleproject:6692 > Change-Id: I650d7d0f55bdf6587b75be43cc7bed2dc3eb935a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294061 > Commit-Queue: Ian Elliott <ianelliott@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> Bug: angleproject:6692 Change-Id: I70d5eeb0b98f016fd262935194f8f4abee2a72b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3300309 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Mohan Maiya 6c172e4b 2021-11-20T16:27:14 Add support for memory cleanup on process exit This patch adds a callback to cleanup memory on process exit. Bug: angleproject:6723 Test: Android CTS WrapperTest.testThreadCleanup Change-Id: Ia517d4c6ae280ddc1f17a3b6f77d437aaaad0678 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294581 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
angle-autoroll f9097e1f 2021-11-24T10:01:53 Roll vulkan-deps from 8d493b8df0d4 to 6402aa39e588 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8d493b8df0d4..6402aa39e588 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/7a0b9b212c..042aaea516 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/833b949972..cdf2f56fae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I3d52a478ca682c1ccb99b4841837149d9b4f2477 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3299785 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5fb45c12 2021-11-24T10:01:31 Roll SwiftShader from 9e727fadeb66 to 17a11cfeb5f1 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/9e727fadeb66..17a11cfeb5f1 2021-11-23 capn@google.com Regres: Update test lists @ 9e727fad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ief890c723a6b6ec526352fd45cfc727c700cb5c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3299959 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0828d207 2021-11-24T07:53:21 Roll Chromium from 592e51326747 to ad511b3c5051 (470 revisions) https://chromium.googlesource.com/chromium/src.git/+log/592e51326747..ad511b3c5051 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/831603f4ab..493ce927d2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/83d4511de4..16f9b84af1 * third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/2bb7b23b63..6a8f3a2781 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..606d87e172 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a29f589a15..646c3cd4d6 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/49836d72bd..02959c3ee1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/649f6b9fa4..994ccaf614 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/48aec494aa..25bed66ea8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/abf7a4bd0b..b841fa72c2 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I7d82fb50261a739b04874cb8a7e2ea45f8a0341a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3299783 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 79f9d163 2021-11-15T08:51:41 Vulkan: Implement GL_EXT_multi_draw_indirect * Optimized the implementations of multiDrawArraysIndirect() and multiDrawElementsIndirect() for Vulkan * Added helper functions to support drawArraysIndirect() and drawElementsIndirect() as special cases of multiDraw*Indirect functions. * Added the flag to enable the multiDrawIndirect feature (drawCount > 1). The generic implementation is used if the flag is disabled. Bug: angleproject:6439 Change-Id: Ibc653d93d355657f828de9c33da22428629e450f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276044 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 6233dc7e 2021-11-24T04:11:51 Roll vulkan-deps from b638c7fb7440 to 8d493b8df0d4 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b638c7fb7440..8d493b8df0d4 Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/83e1a9ed8c..a152371654 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e30862971d..833b949972 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I6729251aa0a27749265cc74230cdc730dcdda9a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3299828 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 924c8d8a 2021-11-18T22:58:04 Vulkan: Fix image tiling when DRM format modifiers are specified Bug: angleproject:6679 Change-Id: I5198a180608535131b127c135423fb80c6478140 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292027 Reviewed-by: Craig Stout <cstout@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 17bf6e98 2021-11-11T20:53:31 Implement GL_EXT_multi_draw_indirect * Added the validation functions for multiDrawArraysIndirect() and multiDrawElementsIndirect() according to the specs. * Added generic implementation for the two functions that can be called by back-ends. * Added unit tests for the multiDrawIndirect functions. * Added flags for back-ends so they can enable the extension. * Minor cleanup in MultiDrawTest.cpp Bug: angleproject:6439 Change-Id: I4e5f1cab05c6de330aef82d115492dcc9d2fad44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276043 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Maksim Sisov 2be4f04a 2021-11-23T12:11:53 linux: enable angle gl for wayland only builds. Chromium is unable to use angle gl implementation if it's a wayland only build as angle_use_x11 is false then. This CL fixes that and allows Chromium Wayland only build use angle GL. Bug: chromium:1231934 Change-Id: Ic4363b986abd6453865f63111032ac810fafc8de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295616 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jeff Vigil 8b60855b 2021-09-15T15:16:10 EGL: implement EGL_KHR_mutable_render_buffer Pass render buffer mode change to WindowSurfaceVk. On mode change trigger OUT_OF_DATE. Then in CreateSwapchain, if new mode, set the Presentation mode and the Image count. OffscreenSurfaceVk ignores mode change. Add MUTABLE_RENDER_BUFFER_BIT to GenerateDefaultConfig. Test: dEQP-EGL.functional.mutable_render_buffer.* Bug: angleproject:3966 Change-Id: I7b59708514bcda10f8d45ce5f9528aa840fcccfa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3171822 Commit-Queue: Brandon Schade <b.schade@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Ian Elliott 97aa5187 2021-11-22T13:26:53 Vulkan: Use vkResetQueryPoolEXT when available ANGLE currently uses vkCmdResetQueryPool to reset a query pool. As reported by Arm, this can cause GPU bubbles. It is better to use vkResetQueryPoolEXT() when available (either by Vulkan 1.2 or by the VK_EXT_host_query_reset extension). Bug: angleproject:6692 Change-Id: I650d7d0f55bdf6587b75be43cc7bed2dc3eb935a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294061 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 4ae30a63 2021-11-22T16:25:11 Vulkan: Don't attempt to convert vertices in empty buffers Bug: chromium:1271671 Change-Id: I869f30fd9c8a52c07263bb7a72978a31f2aceb9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3297026 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill ce6f9c8f 2021-11-19T14:52:48 Update checked numerics library. This library hadn't been updated in quite some time and had bugs which affected UBSAN in some operators. Bug: angleproject:5795 Change-Id: I40f658655034ce03df29cf4c71acb3f6fe96bef0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289941 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Sergey Ulanov 6e2e36cc 2021-11-19T00:57:29 [Fuchsia] Fix SwiftShader ICD discovery ANGLE needs to set VK_ICD_FILENAMES for the Vulkan loader to discover SwiftShader's ICD. Enable this logic on Fuchsia. Also updated ConcatenatePath() to handle absolute paths correctly. Bug: chromium:1225002 Change-Id: Ib69be0d7dcaef09f1da9d411023e90a3b7b4fca2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292347 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f2bf9954 2021-11-23T10:01:52 Roll vulkan-deps from 8e41c1d91f9d to b638c7fb7440 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8e41c1d91f9d..b638c7fb7440 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2c54c20813..7a0b9b212c * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b21acf16e7..ef2429635d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5c2548a01b..e30862971d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I3df892e30797d4c6cd0f1593301574efa47990d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296788 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f8661920 2021-11-23T10:01:32 Roll SwiftShader from 6e23c082b73a to 9e727fadeb66 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/6e23c082b73a..9e727fadeb66 2021-11-22 capn@google.com Assert that the descriptor set is not null 2021-11-22 capn@google.com Implement Assert() for Reactor 2021-11-22 ari.suonpaa@siru.fi Fix green bits for R5G6B5_UNORM_PACK16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I144730c236f9daed403615b1310d9cc0127f7793 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3297691 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 1d555687 2021-11-09T11:16:24 Capture/Replay: Set FBO ID when generated on bind GLES allows FBO ID's to be reserved on bind, so if a FBO is bound with and ID that was not yet reserved by a glGenFramebuffers call, update the resource tracking and the resource map to account for this resources that was created on bind. Bug: angleproject:6425 Change-Id: I343fc17bfbbfd9c8c47d6fe207a4f3817acb835d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3190970 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll b9e96af0 2021-11-23T07:01:14 Roll Chromium from 53373ae01d32 to 592e51326747 (437 revisions) https://chromium.googlesource.com/chromium/src.git/+log/53373ae01d32..592e51326747 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b8e6a02717..831603f4ab * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e21de6f7d1..83d4511de4 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/ebda326985..05738da13b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7ae3bc4766 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b6c1ed40d5..a29f589a15 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/fd8a7c7c2b..5227e7d830 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6a6ee955de..649f6b9fa4 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3eb0936d98..48aec494aa * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d0f3e129d7..abf7a4bd0b No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: If58fcb08e19c8dc53c6ad97cc8ac0adabdace32a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295872 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
shrekshao 5859bb10 2021-11-19T13:25:38 Make D3D11 non instanced draw path explict To make sure instanceCount == 0 is no-op according to OpenGL ES 3.2 spec section 10.5. Before the fix the behavior on linux (gl) and win (d3d) are inconsistent. Bug: angleproject:3402 Change-Id: I70ec215d8b65c1591b4c816f76c92e88e9f0dc61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3293749 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com>
Yuxin Hu ef637366 2021-11-19T22:38:56 Revert the order of texture sync and frame buffer object sync This change reverts the sync order swap done in CL a280c671f178daf73da447d1030773b58b534998, to address a performance issue in TRex. The crash that sync order swap was trying to resolve was addressed by another CL 0fcad6260a3e3943fb84657a3a7f488d1e155fb7. Bug: angleproject:6014 Change-Id: Ie49628295b6dcd5d012dc795bf123865b1a7f893 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292636 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 9de37b58 2021-11-20T21:45:02 Vulkan: Fix draw with emulated xfb without xfb active When transform feedback is not active, make sure the code that captures xfb is not generated, even though it's guarded against with an if. This is because no buffer is bound to the capture buffer, and by avoiding generation of code that references that buffer, SwiftShader will not attempt to access the missing descriptor set. Currently, the actual declaration of the buffer is left in the SPIR-V, which seems to be benign. If that causes issues in the future, the SPIR-V transformer can be modified to remove that variable as well. Bug: chromium:1209285 Change-Id: I83da8d1dea5390ecacc681f8ada9f586932deaa4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294661 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang b6e2e8a0 2021-11-16T13:13:14 GL: Fix share groups for display texture sharing. Chrome uses display-level texture share groups for WebGL contexts. When this extension is in use, make sure all internal contexts are created in the same share group. Bug: chromium:1268830, chromium:1268389, chromium:1268218 Change-Id: I3925dffb9bb23fbbc7adcd3bee8cd62323b993e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285213 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi d781ef09 2021-11-22T11:12:10 Roll VK-GL-CTS from 234f8a066b4d to bfede065f419 (18 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/234f8a066b4d..bfede065f419 2021-11-20 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master 2021-11-19 ari.suonpaa@siru.fi Add tests for buffer size requirements 2021-11-19 jari.komppa@siru.fi Extend interpolateAt* tests 2021-11-19 jari.komppa@siru.fi Add power of two checks for physical device limits 2021-11-19 jari.komppa@siru.fi Modify dual source blend tests to use discard 2021-11-19 juha.heiskanen@siru.fi Add fragment operations occlusion query tests 2021-11-19 mohd.faisal@arm.com Fix wrong conversion from shared pointer to int. 2021-11-19 arkadiusz.sarwa@amd.com Enable anisotropic tests for mipmap images 2021-11-19 jason.ekstrand@intel.com Remove invalid semaphore import/export tests 2021-11-18 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-11-15 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master 2021-11-13 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-11-13 michal.jakubek@mobica.com Various methods passing of PhysicalStorageBuffer tests 2021-11-13 venni.ihanakangas@siru.fi Improve coverage of MSAA copies 2021-11-13 michal.jakubek@mobica.com Fix Buffer Memory Requirements tests compilation errors 2021-11-13 r.potter@samsung.com Mirror existing ANGLE waiver for Samsung devices 2021-11-13 ruoyu@amd.com Support FP16 CPU Rendering 2021-11-09 alex.lan@arm.com Add yuv420 format to EGL AHB tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:6724 Change-Id: Ied03caaa16832597f9a694398577a4b24e11ce90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296262 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 41a8981e 2021-11-21T21:52:37 Use AttributeMap in eglLockSurfaceKHR's validation Bug: angleproject:6062 Change-Id: I0eea431313700b11184265a9ff895417ce4b1d4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295164 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: (use @chromium please) Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny ff89ba1b 2021-11-19T11:52:55 Capture/Replay: Repeat logs for unexpected results The Ci logs are quite long and it is difficult to find the log for the actual CI failures, so repeat the logs for unexpected failures, crashes, compile errors, and timeouts at the end of the log. Bug: angleproject:6542 Change-Id: Id9dff4cc70649d0d9cc8bd4509477fbe3ef10de8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291653 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 135362c9 2021-11-22T10:01:53 Roll vulkan-deps from f2ad120142ed to 8e41c1d91f9d (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f2ad120142ed..8e41c1d91f9d Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/dd83c37b98..2c54c20813 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/22e9c7c538..b21acf16e7 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/fc509008c8..5c2548a01b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: If584af98e308f3f0eea50b16ba1c3419a3a6b4c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294973 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b13dbe75 2021-11-22T10:01:31 Roll SwiftShader from f5cf2d08ff9c to 6e23c082b73a (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f5cf2d08ff9c..6e23c082b73a 2021-11-19 sugoi@google.com Make line stipple related tests pass 2021-11-19 capn@google.com Run clang-format-all.sh as a Bash script 2021-11-19 swiftshader.regress@gmail.com Regres: Update test lists @ 210fe010 2021-11-19 capn@google.com Update testslists to match the dEQP revision If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I1c60eb549494f81c25cfefad4594a1f1e605d393 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3295338 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bf2d35a0 2021-11-22T07:00:10 Roll Chromium from ebb70a6ec0bc to 53373ae01d32 (460 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ebb70a6ec0bc..53373ae01d32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/13d46663be..b8e6a02717 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a63bbc1389..e504863f9e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b632243411..e21de6f7d1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8a112e2bdf * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/29a2573216..6a6ee955de * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9e42d0c22f..3eb0936d98 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c8ce774f11..d0f3e129d7 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I0ecc2e7e645ec972a45561b27a719578bad1ac47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294972 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 647026fa 2021-11-19T19:08:14 Reland "Fix unused variable "useSwiftShader"" This is a reland of d721cdefdcf4c3e62ae364f0dc525e3ca54042a3 Adding a missing include. Original change's description: > Fix unused variable "useSwiftShader" > > -Wunused-but-set-variable when rolling into Chromium crrev.com/c/3293895 > > Bug: angleproject:6496 > Change-Id: I02f7de303b52319c6a1821d7b697b7ee9bea8f89 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292034 > Reviewed-by: Tim Van Patten <timvp@google.com> > Commit-Queue: Tim Van Patten <timvp@google.com> Bug: angleproject:6496 Change-Id: Id39e10a8f343600ea6b2f023442b4d8c7e1856dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292036 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 18b9f2dc 2021-11-20T02:52:05 Revert "Fix unused variable "useSwiftShader"" This reverts commit d721cdefdcf4c3e62ae364f0dc525e3ca54042a3. Reason for revert: missing include Original change's description: > Fix unused variable "useSwiftShader" > > -Wunused-but-set-variable when rolling into Chromium crrev.com/c/3293895 > > Bug: angleproject:6496 > Change-Id: I02f7de303b52319c6a1821d7b697b7ee9bea8f89 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292034 > Reviewed-by: Tim Van Patten <timvp@google.com> > Commit-Queue: Tim Van Patten <timvp@google.com> Bug: angleproject:6496 Change-Id: I12748620cc20348bbcbe0304609a19ab65052b0e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292035 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov d721cdef 2021-11-19T19:08:14 Fix unused variable "useSwiftShader" -Wunused-but-set-variable when rolling into Chromium crrev.com/c/3293895 Bug: angleproject:6496 Change-Id: I02f7de303b52319c6a1821d7b697b7ee9bea8f89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292034 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill 98a49220 2021-11-19T15:02:47 GLES 1: Fix missing validation returns. The validation was correctly generating an error but ANGLE was not aborting the API calls for several validation calls. This was detected by UBSAN tests which would trip a division by zero. Test: GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays/* Bug: angleproject:5795 Change-Id: I5d5d8448454ce19cb4bdf1cd76a6ce513a6e9c6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3293821 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill de5e8577 2021-11-19T15:05:12 MultithreadingTest: Initialize an atomic bool. This variable was getting garbage data in UBSAN. Fix it by setting an initial value of false. Bug: angleproject:5795 Change-Id: I0a40bea427d7c02c8a12616c472c8d9ce70cb937 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3293822 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill edc2cfe5 2021-11-19T14:57:16 Fix signed integer overflow in angle_end2end_tests. The test math was causing an signed overflow in the most extreme case. Test: GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays/ES3_Vulkan_SwiftShader Bug: angleproject:5795 Change-Id: Id6b845577cb6ce585ec67251dcb6111d5773012f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289942 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 8d51bd4b 2021-11-19T00:34:22 Capture/Replay: Add default return path for AccessParamValue Some versions of MSVC have a bug that it will not detect when all values of an enum are exhausted in a switch statement, which leads to a warning that not all code path return a value, and since the warning is treated as an error, compilation fails. Bug: angleproject:6721 Change-Id: I4d62191ce83a04ba554dd804f13e7d428afd86a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291649 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten e28083ad 2021-11-09T18:00:17 Enable RenderDoc capture for debug builds Enable RenderDoc capture in builds where Vulkan Validation Layers are enabled. This essentially enables the '--renderdoc' flag for debug builds when running end2end/deqp tests to make it easier to debug tests. This CL also add the '--no-renderdoc' flag to force disabling RenderDoc capture. Bug: angleproject:6072 Change-Id: Iae7aae30aae9bdc58a7546118d156aef2047c210 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270600 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Cody Northrop f44a6fd2 2021-11-18T20:15:31 GLES1: Hard code integer values in the ubershader This CL continues the process of removing uniform values from the GLES1 ubershader to increase speed on mobile platforms. The first phase removed bools 2091451e. We've identified integers (enums) as providing the biggest bang for buck to optimize speed while having acceptable program generation. Allowing floats as well proved too much specialization. Many GLES1 conformance tests would grind to a halt while providing little to no benefit to app traces. This CL does the following: * Create a GLES1ShaderState class that contains hashable data * Populate it with all states influencing ubershader generation * Hash the class to perform the lookup of existing programs Frame times on Android ARM with locked GPU clocks: Trace Before After dr_driving: 4.2986 -> 0.8155 sonic_the_hedgehog: 2.8223 -> 0.6254 summoners_war: 15.9810 -> 2.3937 wordscapes: 7.6167 -> 1.1496 zillow: 2.9368 -> 1.9318 Test: end2end, perftests, gles1_conformance Bug: angleproject:6644 Change-Id: I060280e282d7b514d3e410c4f8c5e09659e85d3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3280355 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 0d67a4fa 2021-11-18T20:12:34 infra: Increase gles1_conformance_tests timeout In anticipation of GLES1 ubershader updates that result in faster frame times, but more compiles. The GLES1 conformance tests iterate through every state and render one frame, which is slower when you link a new program for each. Bug: angleproject:6644 Change-Id: I70501ea38505428569ba518710ecb03ce198db18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292511 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com>
Lubosz Sarnecki 1cc5d096 2021-10-21T19:58:58 mathutil: Add roundDownPow2. Bug: angleproject:5857 Change-Id: I6c7ae92a41957e9e6b40b6449f763a49493488d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3236996 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill a00ce2ca 2021-11-19T10:23:53 Vulkan: Fix CFI ignore config. This was being applied to "vulkan" when it should be higher in the chain of depedencies. This CL moves it to "vulkan_icd". Bug: angleproject:6496 Bug: chromium:1271193 Change-Id: I064caac6afe237d7008389f444d6ef9f37cff286 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289937 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 6a70398c 2021-11-19T09:41:58 GN: Ensure using_sanitizer is declared even without //build. Bug: angleproject:5795 Change-Id: If37375a9925d8449a15a63e98caf60d7dc75a751 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289936 Owners-Override: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0