|
cbab97d4
|
2022-07-29T11:03:21
|
|
Remove needless IOSurface alignment validation
IOSurface buffers are copied instead of imported directly into Vulkan,
since they're not guaranteed to satisfy alignment and padding
requirements (see minImportedHostPointerAlignment and
vkGetMemoryHostPointerPropertiesEXT).
So we don't need to check its alignment as part of
eglCreatePbufferFromClientBuffer() validation.
Bug: angleproject:7538
Change-Id: Ic449e7cdd60e62cd3009854897ffcd369e32fc7c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3792178
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Auto-Submit: Nicolas Capens <nicolascapens@google.com>
|
|
9c6c072c
|
2022-07-29T10:01:38
|
|
Roll vulkan-deps from d28e244d3e12 to 2d409ca4e3b6 (5 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/d28e244d3e12..2d409ca4e3b6
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/cc5fca057e..8dc0030ecb
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/87d2aa9d77..ff92049ebd
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/fe3ea8d5f7..0bcddf345f
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/cd379e6992..e734be0bb5
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c55f470906..cbdb019150
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I6491ec0a8d80a984e94a437c54e7655ecccaf816
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3793768
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
326441d0
|
2022-07-29T10:01:52
|
|
Roll SwiftShader from e8c074d7684b to 80aaa8a74b74 (6 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e8c074d7684b..80aaa8a74b74
2022-07-29 capn@google.com Assert the minMemoryMapAlignment value
2022-07-29 capn@google.com Increase memory allocation alignment to 256
2022-07-29 capn@google.com Separate allocation alignment from offset alignment
2022-07-29 capn@google.com Increase minImportedHostPointerAlignment to 4096
2022-07-29 capn@google.com Report the maximum buffer offset alignment requirement
2022-07-29 capn@google.com Rename getDepthValue to readDepth
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: If2cd4f43727d8cadb57fb383960549c78fbf9ed9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3792593
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
3ccaddf9
|
2022-07-26T10:02:01
|
|
Vulkan: EXT_YUV_target: layout(yuv) support
This CL adds support for layout(yuv) in the shader, via a new
decoration.
The SPIRV decoration enum number is WIP and depends on final spec.
The decoration is only active if enabled via a flag in ShaderLang, which
will be connected with the feature supports_yuv_target in a future CL.
Bug: b/223456677
Change-Id: I29a724e689d1336a3e42c83d7afa944a11e07353
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3765890
Auto-Submit: Lingfeng Yang <lfy@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Lingfeng Yang <lfy@google.com>
|
|
f000215d
|
2022-07-26T21:16:14
|
|
Vulkan: Optimize transform feedback buffer tracking
Prior to this CL, if transform feedback was active at the time of render
pass closure, its buffers were cached in ContextVk. Later, these
buffers were used to close the render pass if they were used for any
other reason (such as vertex attribute).
However, this meant that the render pass could close unnecessarily if
transform feedback was ended right after the render pass is closed. The
closure of the render pass was an awkward place to cache the used
transform feedback buffers (because at that point, the buffers are
actually no longer used).
Instead, this change makes sure that the buffers are cached when
transform feedback buffers are first used by the render pass, and the
cache is cleared at the end of the render pass.
Bug: angleproject:4622
Change-Id: I31c0a1e20d48f2e261e2cf37adb0a46db683e6fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788309
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
6142b839
|
2022-07-26T13:57:53
|
|
Vulkan: EXT_YUV_target: add vk feature
This Vulkan feature will be set to true once we detect support
from underlying Vk driver (method TBD).
Bug: b/223456677
Change-Id: I5003068c3119f43befb92579d4b656e3a9346363
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788564
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Lingfeng Yang <lfy@google.com>
|
|
3dd6f5f7
|
2022-07-24T18:49:44
|
|
Reland "Disable share context lock for Chromium"
This is a reland of commit e1741f4ba7dae4f6f09829b9152360544c912d1f
Original change's description:
> Disable share context lock for Chromium
>
> Bug: chromium:1336126
> Change-Id: I93b4e738a8816e6b318e5d5823bc9130f17deb37
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3781368
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Peng Huang <penghuang@chromium.org>
Bug: chromium:1336126,angleproject:7537
Change-Id: I15811bc2fef0ba22f6ac13d51c72ed96b2a12507
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3792046
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
5db09e9b
|
2022-07-21T10:45:12
|
|
Vulkan: Try allocate from existing DescriptorPool before create new
When we allocate a new descriptorSet, right now we only look at current
bound pool or the last pool, or allocate a new pool. We never look at
the other pools for the possibility of allocation. This is likely due to
we never free descriptorSet in the past. With the recent CLs, we now
release invalid descriptorSets when texture or buffer gets deleted or
re-specified. This opens up opportunity to allocate from other existing
pools before allocating a new pool. This CL changes the allocation logic
to add the pass to iterate over existing pools for allocation before
allocating a new pool, thus reducing the number of descriptorSetPools.
This CL also consolidates
DynamicDescriptorPool::getOrAllocateDescriptorSet()'s actual
descriptorSet allocation logic with
DynamicDescriptorPool::allocateDescriptorSet().
This CL also moves mEmptyDescriptorSets from ProgramExecutableVk to
DynamicDescriptorPool so that we will only have one empty descriporSet
per pool instead of per program.
Bug: b/235523746
Change-Id: I012346acce17f785ee6683ec55fdf21be00ea1a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780847
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Auto-Submit: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
c48cfa02
|
2022-07-28T16:07:34
|
|
Revert "Disable share context lock for Chromium"
This reverts commit e1741f4ba7dae4f6f09829b9152360544c912d1f.
Reason for revert: Breaks SwANGLE tests when rolled into Chrome:
https://chromium-review.googlesource.com/c/chromium/src/+/3789604/
Original change's description:
> Disable share context lock for Chromium
>
> Bug: chromium:1336126
> Change-Id: I93b4e738a8816e6b318e5d5823bc9130f17deb37
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3781368
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Peng Huang <penghuang@chromium.org>
Bug: chromium:1336126
Change-Id: Id3484b79aa9f8b914eca0f72c20d286ec1c03857
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3792164
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
08df7ce4
|
2022-07-28T10:59:30
|
|
Test Runner: Disable --bot-mode on Fuchsia.
This flag is a bit hard to get going because of the differences in
the Fuchsia system APIs. Disable it explicitly for now to avoid
issues when we switch bot configs.
Bug: angleproject:7312
Change-Id: I47cd038b198f265a6b60893faf6f50f02be49fda
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3792163
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
39c5f321
|
2022-07-28T10:01:38
|
|
Roll vulkan-deps from 7158d6e8eaad to d28e244d3e12 (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/7158d6e8eaad..d28e244d3e12
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/7b75c5dc7d..f0ce653a25
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b15de0fef2..c55f470906
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I74c0c197b204fdaa07e5b0a57be0364ad23db41a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3790474
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
6fb8d909
|
2022-07-28T10:01:52
|
|
Roll SwiftShader from 1739966fee2a to e8c074d7684b (4 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/1739966fee2a..e8c074d7684b
2022-07-28 capn@google.com Refactor float to fixed-point conversion
2022-07-27 swiftshader.regress@gmail.com Regres: Update test lists @ 1739966f
2022-07-27 srisser@google.com Expose shaderUniformTexelBufferArray* indexing
2022-07-27 srisser@google.com Expose uniformBufferArray dynamic indexing
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I68cf3f4b273ed28e07531bafc33f86c50ceebbb5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3790237
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
a04f8c58
|
2022-07-28T07:00:34
|
|
Roll Chromium from 85c57e6023c8 to e810ac85e1c8 (442 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/85c57e6023c8..e810ac85e1c8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/faf85adb8b..1404d7f2be
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/844e20e207..7975a43bbd
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/c3a4a17539..53bd4e2349
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..84a7988038
* third_party/fuchsia-sdk/sdk: version:9.20220726.2.1..version:9.20220727.1.1
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/184bc29dd8..37aede243e
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8c41d19417..6440bc4b73
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8f4235f7ff..94f4798869
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: Idcfce9695e1de7d4856bc05e70102e76bcefca92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3790472
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
e7affd55
|
2022-06-23T13:49:18
|
|
d3d11: allow selecting render device by PCI vendor/device ID
Similar my change in the Vulkan backend, we can match by PCI
vendor/device ID in D3D11 device selection.
Bug: angleproject:7460
Change-Id: I6f7bff1dad5b589357693bf747157b2dacb1f69f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720734
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Auto-Submit: Steven Noonan <steven@valvesoftware.com>
Reviewed-by: Steven Noonan <steven@valvesoftware.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e3701f90
|
2022-07-19T15:19:50
|
|
Remove WARN() in getPixelFormatInfo()
This WARN() cause log flood on Android while playing youtube videos
in Chrome.
Bug: angleproject:7509
Change-Id: I42e046d5b0908ef7d3ca0704c27236198026a637
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3773873
Auto-Submit: Peng Huang <penghuang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
80022b96
|
2022-07-26T21:07:04
|
|
Vulkan: Fix xfb buffer redefine to smaller size
In 89e11878b275b15735eaf273ababfa6fd43a2e3d, a use-after-free bug was
fixed where glBufferData redefined a buffer, leading to a change in
storage. This was only tested for the case where the new buffer was
larger than the old buffer.
When the new buffer is smaller however, another issue remains where the
buffer size as cached by the transform feedback object used the old
object's size. This is worked around in this change, with a fix for the
real issue (that the buffer state is updated after calling into the
backend instead of before) coming up.
Bug: chromium:1345042
Change-Id: I6c9e9344705fefe49926a14cf6ce73ce84305872
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788308
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
fb97cfcd
|
2022-07-27T11:49:41
|
|
Roll chromium_revision 1201dfbc62..85c57e6023 (1027387:1028671)
Skip failing dEQP-EGL.functional.image.api.create_image_gles2_android_native_* tests
Change log: https://chromium.googlesource.com/chromium/src/+log/1201dfbc62..85c57e6023
Full diff: https://chromium.googlesource.com/chromium/src/+/1201dfbc62..85c57e6023
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/f14f6d206b..faf85adb8b5817fd75744e98c450f2b9e46ed7a2
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fe57e98eeb..af18ab7c6f
* buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/eb79671bfb..6c8f712bc4
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b954e3e656..039323b945
* buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/955e2ff5fb..2a908eebb7
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/1f497ac0b0..844e20e207
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/13bb7f697c..fabdc7fefb
* third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/8f37aa7698..d76d39e8c8
* third_party/android_sdk/public: tRoD45SCi7UleQqSV7MrMQO1_e5P8ysphkCcj6z_cCQC..-VRKr36Uw8L_iFqqo9nevIBgNMggND5iWxjidyjnCgsC
* third_party/android_sdk/public: gMHhUuoQRKfxr-MBn3fNNXZtkAVXtOwMwT7kfx8jkIgC..9lGp8nTUCRRWGMnI_96HcKfzjnxEJKUcfvfwmA3wXNkC
* third_party/android_sdk/public: g7n_-r6yJd_SGRklujGB1wEt8iyr77FZTUJVS9w6O34C..RSI3iwryh7URLGRgJHsCvUxj092woTPnKt4pwFcJ6L8C
* third_party/android_sdk/public: lL3IGexKjYlwjO_1Ga-xwxgwbE_w-lmi2Zi1uOlWUIAC..eo5KvW6UVor92LwZai8Zulc624BQZoCu-yn7wa1z_YcC
* third_party/android_system_sdk: oSfDIvHlCa6W0gS79Q5OOfB9E4eBg3uAvi3BEDN21U0C..RGY8Vyf8jjszRIJRFxZj7beXSUEHTQM90MtYejUvdMgC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..84a7988038
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/debf6402b3..2cd48234f1
* third_party/fuchsia-sdk/sdk: version:9.20220720.2.1..version:9.20220726.2.1
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3d8d88e8bb..184bc29dd8
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/15fc47eb8b..8c41d19417
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8e7aadf254..8f4235f7ff
DEPS diff: https://chromium.googlesource.com/chromium/src/+/1201dfbc62..85c57e6023/DEPS
Clang version changed llvmorg-15-init-15652-g89a99ec9:llvmorg-15-init-17529-ga210f404
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/3d8d88e8bb600789ba3e798f38ff314521aac524..184bc29dd86c3994a02b4f3feca125ffe785319c/scripts/update.py
Bug: chromium:1347817
Change-Id: I6b80fc411a6986d116e121921fcb5223c1964184
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3789322
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
b8e741d2
|
2022-06-23T13:36:17
|
|
Vulkan: allow selecting render device by PCI device/vendor IDs
The EGL_ANGLE_platform_angle_device_id extension is deliberately vague
about the meaning of "device ID high" and "device ID low", stating it's
platform-specific. We can use these for representing the PCI
device/vendor IDs that can be discovered via various (OS-specific)
external means.
Bug: angleproject:7460
Change-Id: Iff462687749e815fa074ef8ff392b6730ef46fa8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720733
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e1741f4b
|
2022-07-24T18:49:44
|
|
Disable share context lock for Chromium
Bug: chromium:1336126
Change-Id: I93b4e738a8816e6b318e5d5823bc9130f17deb37
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3781368
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
0dc29af9
|
2022-07-26T19:16:16
|
|
Context: Also disable ASTC on mState when emulation is disabled.
GL_KHR_texture_compression_astc_ldr was incorrectly exposed on the
GL_EXTENSIONS string in cases where no native support was available and
the emulation was not built.
To prevent this the context must disable it on mState.mExtensions in
addition to mSupportedExtensions.
Bug: angleproject:7415
Change-Id: I1161e460b0b224a03557053b5804c104e270f388
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788402
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
630e50c3
|
2022-07-27T10:01:25
|
|
Roll SwiftShader from b6ddcf331865 to 1739966fee2a (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b6ddcf331865..1739966fee2a
2022-07-26 swiftshader.regress@gmail.com Regres: Update test lists @ b6ddcf33
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I8db29c92febb3840d716ce53fe5f175e9bb769e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788618
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
255893f6
|
2022-07-27T10:01:38
|
|
Roll vulkan-deps from 03d4f8e01303 to 7158d6e8eaad (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/03d4f8e01303..7158d6e8eaad
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/607771c362..7b75c5dc7d
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e4cfa190df..cc5fca057e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I98498fb257b98d353a89591f6949f430bbf3f754
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788146
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
b968b6c9
|
2022-07-26T14:34:41
|
|
Test Utils: Get executable path from command line.
This simplifies the process fork test and will allow the test to
work on Fuchsia.
Bug: angleproject:3161
Change-Id: I5bb5424c44957f2faef1970b3cbc5e52b8aff630
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788297
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
3f59c285
|
2022-07-12T17:29:36
|
|
D3D11: implement image load/store format reinterpretation.
Reinterpretation requires all UAV textures to be in a TYPELESS
format. Implement an ensureUnorderedAccess() that converts the
texture's storage to one with the D3D11_BIND_UNORDERED_ACCESS
flag, which, prior to this change, was set unconditionally for
all textures in an >= ES 3.1 context. If this flag is set at
D3D texture creation time, use the appropriate TYPELESS format.
Implementation uses a BindFlags struct, which subsumes the
existing renderTarget for clarity. Factor out the relevant bits
of ensureRenderTarget() into an ensureBindFlags() helper function,
and make ensureRenderTarget() and ensureUnorderedAccess() wrappers
around it.
Add the corresponding typeless formats to the texture format table.
Bug: angleproject:7501, angleproject:7520
Change-Id: Id21b9db3229aceca121da6ba6507704417034ec4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780588
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
|
|
|
83dfd839
|
2022-06-07T11:57:07
|
|
dEQP: Allow running against system GL.
Bug: angleproject:7396
Change-Id: I6d6231ebfdea0f1df483c5764b086b14f8384d3d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3692266
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
a78c01b2
|
2022-07-22T13:52:55
|
|
[Cast Convergence] Remove is_chromecast in ANGLE.
is_chromecast is going to be removed from Chromium. This is_chromecast
with is_castos, which will be set for builds that target Nest Linux
devices.
Upstream bug: https://crbug.com/1337084
Umbrella bug: https://crbug.com/1219802
Design doc (internal only): https://go/unified-cast-web-runtime
Bug: angleproject:7521
Change-Id: Id1a0df72e37868eabd1f851123eec615f6657570
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782573
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
5c5a14c3
|
2022-07-19T16:03:08
|
|
Tests: Add Battle Of Polytopia trace.
Test: angle_perftests --gtest_filter="*battle_of_polytopia*"
Bug: angleproject:7529
Change-Id: Ib9ad862fa5d2a3cd761bdbf42b2b91c2fe63f99b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780915
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
4e046256
|
2022-07-25T17:17:28
|
|
Translator: Fix deep copy of loops and branches
Fixed nullptr dereference when the loop or branch doesn't have an
expression.
Bug: angleproject:7518
Change-Id: Ib888634e409dcbc27ef060bb46017e8911097eef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785294
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
313884ce
|
2022-06-30T08:49:08
|
|
Vulkan: Move dmabuf extensions support
Moves dmabuf support functions from DisplayVkWayland to DisplayVkLinux
to support other linux winsys.
Bug: angleproject:7480
Signed-off-by: Sungyong Choi <sywow.choi@samsung.com>
Change-Id: I2a36557815b8e5c4bab7ec1d9248989345e536c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3735863
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Antonio Caggiano <antonio.caggiano@collabora.com>
Reviewed-by: Jeff Vigil <j.vigil@samsung.com>
|
|
|
39119a8b
|
2022-07-26T10:01:38
|
|
Roll vulkan-deps from 50a58c2a73cb to 03d4f8e01303 (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/50a58c2a73cb..03d4f8e01303
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/6ef2e49216..607771c362
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bbff1dc594..b15de0fef2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I1015186b364a8d9bf4249ed3565acedded6d2587
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3787784
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
54da2952
|
2022-07-25T16:00:47
|
|
Remove suppressions added due to VK_ATTACHMENT_UNUSED bug
This was affecting old Qualcomm-based phones only.
Bug: angleproject:3423
Change-Id: Id18c95f8df562d572177035a8cb88327d9f2d200
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785292
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
a3cda607
|
2022-07-26T10:01:25
|
|
Roll SwiftShader from 16e026a959f1 to b6ddcf331865 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/16e026a959f1..b6ddcf331865
2022-07-25 srisser@google.com Expose float preserve capability
2022-07-25 swiftshader.regress@gmail.com Regres: Update test lists @ 16e026a9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I95e1010e049c3e4f4a66b0a308cbac6b441483fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3787801
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
88dd868f
|
2022-07-25T06:44:38
|
|
FrameCapture: Fix and optimize multi-context reset
Follow on to fd89020c
This CL:
- Fixes missing eglMakeCurrent calls when switching contexts to
reset container state
- Optimizes when those calls are made, so we only call
eglMakeCurrent in Reset when we absolutely have to
- Moves MaybeResetContextState to the end, after any per-context
reset work has been done
Test: Asphalt 9 MEC
Bug: angleproject:4599
Bug: angleproject:7507
Change-Id: I52912aa13e3a11735ed3ec93080a21e9cbff113a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3784728
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
be708446
|
2022-07-25T15:24:52
|
|
Vulkan: Remove the bindEmptyForUnusedDescriptorSets workaround
Only applied to older Qualcomm-based phones.
Bug: angleproject:2727
Change-Id: I37a611e2ff79d898eff9401467407543f3c690b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785290
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
673a41ae
|
2022-07-25T12:41:40
|
|
dEQP: Isolate headers in tcuANGLEPlatform.h.
Refactoring change only. Will simplify future dEQP changes.
Bug: angleproject:7396
Change-Id: I034bf5c421902c53f279e01b0727490909da3990
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785286
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8e63c6e8
|
2022-07-25T15:10:11
|
|
Remove suppressions for tests which pass with Intel Mesa 20.0.8
Bug: angleproject:3616, angleproject:3614, angleproject:2782
Change-Id: I220d71593270164f77bda92f533608e431c6c9b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780159
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
|
|
df879d49
|
2022-07-22T00:00:00
|
|
Return INVALID_VALUE for online BC compression
As per discussion with OpenGL ES WG, implementations
are allowed to generate INVALID_VALUE when online BC
compression is not supported.
Bug: angleproject:6441
Change-Id: I0e282c970f1e03afbc590dc9a46b8ce38d869691
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780923
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
4a14030d
|
2022-07-22T10:09:53
|
|
Avoid streaming a wide string to a (narrow) ostringstream.
This stream overload was removed in C++20.
Bug: chromium:1284275
Change-Id: I73188e09cc93c7bd475ab1536dac74e92ea12605
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3781611
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
8d2988f7
|
2022-07-25T12:06:51
|
|
infra: Add sheriff_rotations to luci properties.
This should allow ANGLE builders to show up in Sheriff-o-Matic.
Bug: chromium:1288021
Change-Id: Ic3ab746160a2249362b64bbc063e88848a5b23c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785285
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
da2d1e0a
|
2022-07-25T16:12:14
|
|
Update extension support (July 25, 2022).
Linux Intel testing was switched from HD630 to UHD630 GPU.
Bug: chromium:1342945
Change-Id: Ic02e71a9ee3d5cdb2a6808405551bf3f60512914
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780158
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
|
|
|
3b020cc1
|
2022-07-25T13:59:21
|
|
Roll VK-GL-CTS from cb1dc55bc044 to e3066ef682d7 (11 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/cb1dc55bc044..e3066ef682d7
2022-07-23 quic_mnetsch@quicinc.com Merge dev/VK_EXT_shader_module_identifier to vk-gl-cts/main
2022-07-23 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_multisampled_render_to_single_sampled to vk-gl-cts/main
2022-07-22 quic_mnetsch@quicinc.com Notice of withdrawal of Vulkan CTS 1.2.7.x
2022-07-22 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/github-main into vk-gl-cts/main" into main
2022-07-22 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
2022-07-22 piotr.byszewski@mobica.com Fix validation errors for DR multiview tests
2022-07-22 jbolz@nvidia.com Support commandPoolResetCommandBuffer==VK_FALSE for VulkanSC
2022-07-22 vidar.lillebo@arm.com Add tests for VK_EXT_image_compression_control_swapchain
2022-07-22 antto.makinen@siru.fi Add coverage of indirect dispatches on the compute queue
2022-07-22 rgarcia@igalia.com Test dynamic patch control points without tessellation
2022-07-22 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-bots+autoroll-info@google.com,yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: angle-bots+autoroll-info@google.com,yuxinhu@google.com
Change-Id: Ic3bdc4c896e144cadb5dd5b049763a649b9ac126
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3784727
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
4fdc3754
|
2022-07-25T10:01:38
|
|
Roll vulkan-deps from f00ffae9c319 to 50a58c2a73cb (6 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/f00ffae9c319..50a58c2a73cb
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/7e6b7c26a2..6ef2e49216
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d8d051381f..0cccd0a65a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC romanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: romanl@google.com
Change-Id: I2e12b09f11d2e43e8dc73cac7f6f5089c6cc1a90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3784025
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e3933465
|
2022-07-21T11:35:17
|
|
Vulkan: Allow dither for some color blend modes
Some color blend modes are known to work with our dither emulation.
Test: Candy Crush on Pixel 6
Bug: b/232574868
Change-Id: I1b57e243afcf4643e2cd12f862408050751fa987
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780846
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
fd89020c
|
2022-07-18T20:26:38
|
|
FrameCapture: Reset VertexArray state
This change includes three things:
- Tracking resources by context
- Resetting VertexArray state
- Splitting ResetReplay into per-context
All three are needed to properly Reset Vertex Array objects.
Vertex Arrays are considered container objects, which means
they are not shared with other contexts. We've had a hole
in Reset where we did not take multiple contexts into account.
To address this, we now also track which contextID was used
to modify a resource. For objects that need to know which
context they are bound to, we track them in a map and
return the correct index when getTrackedResource is called.
To generate the calls to reset Vertex Array state, we are able
to mirror what has been done for other ResourceTypeIDs.
In order to properly Reset resources in multiple contexts,
we have to bind the correct context before emitting the
Reset calls. This has been done for Setup already, so we
have a template to follow. With this CL, we now emit
multiple functions to Reset state, similar to the following:
void ResetReplayContextShared()
{
// Reset shared objects
...
}
void ResetReplayContext5()
{
// Bind the right context
eglMakeCurrent(EGL_NO_DISPLAY, EGL_NO_SURFACE, EGL_NO_SURFACE, context5);
// Reset container objects for context5
...
}
void ResetReplayContext6()
{
// Bind the right context
eglMakeCurrent(EGL_NO_DISPLAY, EGL_NO_SURFACE, EGL_NO_SURFACE, context6);
// Reset container objects for context6
...
}
void ResetReplay()
{
EGLContext context = eglGetCurrentContext();
ResetReplayContextShared();
ResetReplayContext5();
ResetReplayContext6();
eglMakeCurrent(EGL_NO_DISPLAY, EGL_NO_SURFACE, EGL_NO_SURFACE, context);
}
Test: Ni no Kuni MEC
Bug: angleproject:4599
Bug: angleproject:7507
Change-Id: Ic585534f07172474aab0ce1d0396b0b064379f88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3761874
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
00e48c13
|
2022-07-20T17:35:01
|
|
Vulkan: Destroy DescriptorPoolHelper when its unused.
DynamicDescriptorPool keeps an array of DescriptorPoolHelpers. Right now
we only grow this array of pools, we never shrink the pool count. This
is partly due to we never release descriptorSet. But in the past few
CLs, we now release invalid descriptorSet when texture/buffer gets
deleted or re-specified. This means we could now have a pool with no
valid descriptorSets. This CL adds the ability to actually release the
pool when all of its descriptorSets has been released, thus reduce the
pool count when a lot of textures have been deleted.
Bug: b/235523746
Change-Id: I2d5047269154cc8ece8305408f08f2ad7c9dd8a6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780845
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
b23ea680
|
2022-07-22T12:06:42
|
|
Vulkan: Re-enable multisample framebuffer fetch
Bug: angleproject:7351
Bug: angleproject:3586
Bug: angleproject:6195
Bug: angleproject:7512
Bug: b/234173199
Change-Id: Ib70732f8c075de777e534f950a7e421e75969f59
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3781613
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
6d6b9967
|
2022-07-22T20:16:18
|
|
Roll Chromium from d2f8d8516036 to 1201dfbc6265 (220 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/d2f8d8516036..1201dfbc6265
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC romanl@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/1d40290874..f14f6d206b
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8b46ec0615..fe57e98eeb
* buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/49e658031b..eb79671bfb
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/9222b02eb9..1f497ac0b0
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5bf30e53b5..c3a4a17539
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3384fbd903
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0ba2fd429d..debf6402b3
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9f9696f98f..8e7aadf254
No update to Clang.
Bug: None
Tbr: romanl@google.com,ynovikov@google.com
Change-Id: I09ec0218b7dab0e1a7607148b23de436dd6fdebd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782572
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
2b43d630
|
2022-07-22T14:19:05
|
|
Remove unused (and incorrect on Android) mTestSuiteName.
On Android it ends up being just: _
Bug: angleproject:7299
Change-Id: I3dabcfcbacc3f43338b6fa91ebd9917e43f783ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780587
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
c2aaeadb
|
2022-07-14T13:27:38
|
|
Vulkan: Skip nonexistent attachments when calculating samples
When FBO 0 is bound, FramebufferVk can get into a state where the color
attachment is considered null (such as surfaceless).
Then, getSamples() is called with null color attachment, resulting in an
assertion or nullptr crash.
Fix getSamples() to respect the color attachments mask.
The entry point that brought this about was also a dispatch, not a draw.
In a future CL, we should also optimize syncState to not consider draw
related state if the task is a dispatch.
Also fixes b/234620157
Bug: b/223456677
Change-Id: I8cc969de941f43a2eb66871033d6ec7ddf8b8a66
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3764435
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Lingfeng Yang <lfy@google.com>
|
|
|
72795eb0
|
2022-07-22T14:27:38
|
|
Roll Chromium from 9d88fd8904e8 to d2f8d8516036 (510 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/9d88fd8904e8..d2f8d8516036
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC romanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/bed2979286..1d40290874
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d4d55fbf05..8b46ec0615
* buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/88bf407048..49e658031b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/cbe80d6926..9222b02eb9
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/bbffded4b5..5bf30e53b5
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..07e4a3d3cc
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/39e33e6eca..0ba2fd429d
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0ca99b7456..3d8d88e8bb
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b453316b9e..15fc47eb8b
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6786537981..9f9696f98f
No update to Clang.
Bug: None
Tbr: romanl@google.com
Change-Id: I5ec8ebbca47422958b75e05fa32b2fea232043c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782858
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
788c5454
|
2022-07-22T14:45:21
|
|
Roll VK-GL-CTS from 692df061716d to cb1dc55bc044 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/692df061716d..cb1dc55bc044
2022-07-22 quic_mnetsch@quicinc.com Merge pull request #338 from PanGao-h/patch-1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-bots+autoroll-info@google.com,romanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: angle-bots+autoroll-info@google.com,romanl@google.com
Change-Id: I7a1522977d7b5df19ab32bf1e29e4152ca415502
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782859
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
90fa855b
|
2022-07-22T10:11:01
|
|
Suppress the early_fragment_tests PLS test on Pixel 6
Bug: angleproject:7279
Change-Id: Id56d43f9061e9f6d08388ff49b2f65a88408c145
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782862
Commit-Queue: Chris Dalton <chris@rive.app>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
adeb750d
|
2022-07-21T18:49:00
|
|
Validate that skipped tests are skipped by suite.
Before this change, any test failing to produce trace files
would be marked as "Skipped" regardless of whether it was skipped by
suite or just failed to produce trace files for some other reason.
This change adds FailedToTrace status to differentiate between the two
cases. If a test is FailedToTrace it will need to be explicitly added
to the capture_replay expectation file (probably SKIP_FOR_CAPTURE).
This change caught that
OcclusionQueriesNoSurfaceTestES3.SwitchingContextsWithQuery/*
was incorrectly specified as NOT_RUN when the intent was to SKIP.
Bug: angleproject:5133
Bug: angleproject:7516
Change-Id: I451b4d5fd799d15ef92fab678aa20d2b6cc42c9f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3781902
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Roman Lavrov <romanl@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
08df2000
|
2022-07-22T10:01:38
|
|
Roll vulkan-deps from 5cb0a31b27bf to f00ffae9c319 (7 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/5cb0a31b27bf..f00ffae9c319
Changed dependencies:
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a13608020f..fe3ea8d5f7
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8b603f8d06..cd379e6992
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/52aadfabb5..bbff1dc594
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC romanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: romanl@google.com
Change-Id: Iab940a361c1e26fc9b8fa5b47ee636a430bb1941
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782616
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
7d6f3d94
|
2022-07-14T13:25:04
|
|
glValidateProgramPipelines: Skip draw state error check
Certain apps will call this API while having a surfaceless context,
making it improperly fail.
dEQP tests that previously relied on the full draw states check
were actually relying on the part where the draw state check included a
check that the pipeline object had programs/shaders. Relax the
validation of the pipeline to only include that validation, and not also
the framebuffer state / VBO state / etc.
Bug: b/223456677
Change-Id: I9211761934668aae8a20f07ac4f36b7f6c1281da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3764434
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
c95e2b7d
|
2022-07-21T17:03:19
|
|
Remove a few cases that are skipped by end2end.
Following https://crrev.com/c/3780583.
A few obvious NOT_RUN cases where bugs and skipped tests match those in
angle_end2end_tests_expectations.txt
Bug: angleproject:7516
Change-Id: I63a78b0800d2e4fedfe7d4730df6b55b22508dc4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3779645
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Roman Lavrov <romanl@google.com>
|
|
|
d57ce815
|
2022-07-16T16:33:08
|
|
Use "readwrite" PLS images when possible
We actually only need readonly/writeonly aliases on ESSL, non
r32f/r32ui. For all other cases, this change updates the compiler to
emit a single readwrite image. We also optimize this image with the
"restrict" qualifier since PLS specifically disallows aliasing.
Removing the aliased load and store also eliminates our issue with an
Intel driver bug, and all the PLS tests now pass without any
workarounds.
Bug: angleproject:7279
Bug: angleproject:7398
Change-Id: I350b239793647da33add96509b8f4b1bbef02245
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3767537
Commit-Queue: Chris Dalton <chris@rive.app>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
aa7e6751
|
2022-07-15T23:33:30
|
|
Automatically enable early_fragment_tests when PLS is declared
When PLS is polyfilled by shader images, we need early_fragment_tests in
order to match the same depth/stencil behavior as when it is implemented
as framebuffer fetch.
Bug: angleproject:7279
Change-Id: I37f5a8682cc96a14ef247d53ed243e4aceb15f39
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3767535
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
|
77aa34ae
|
2022-07-16T13:08:00
|
|
Add support for PLS as function arguments
Bug: angleproject:7279
Change-Id: I89d5c02148cbdbbd02dc4840ffada2c96c2a849b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3767534
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
|
3a0d7249
|
2022-07-21T13:38:21
|
|
Ignore tests skipped by the suite.
This way we don't have to add skipped tests to
capture_replay_expectations as well.
Bug: angleproject:5133
Bug: angleproject:7512
Bug: angleproject:7516
Change-Id: Iabc5f4738b51ce23890c07b8a0548cbc6bec1274
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780583
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
d0fe12db
|
2022-07-20T10:16:38
|
|
Vulkan: Disable Multisample Framebuffer Fetch
Disable the multisample framebuffer fetch temporarily
to unblock the angle to chromium roller. Will re-enable after
https://ci.chromium.org/ui/p/chromium/builders/try/win10_chromium_x64_rel_ng/1240846/overview
is resolved.
Bug: angleproject:7351
Bug: angleproject:3586
Bug: angleproject:6195
Bug: angleproject:7512
Bug: b/234173199
Change-Id: I435b257dd07d973d06d5cacd779e943eed32097b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3777059
Reviewed-by: Roman Lavrov <romanl@google.com>
|
|
|
b78d471a
|
2022-07-21T09:53:37
|
|
Add angle_enable_share_context_lock build flag
This flags can be used to enable the share context lock.
Without this lock, the client need to use gl calls in
a threadsafe way. It is true by default.
Bug: chromium:1336126
Change-Id: I984f8cfb0379195f6ebe11b0997e401f2421affa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780582
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
|
115d8361
|
2022-07-21T13:59:48
|
|
Switch Linux Intel testing to UHD 630 GPU
Replacing 0x5912 HD 630 with 0x9bc5 UHD 630.
Also updating Mesa from 19.0.2 to 20.0.8.
Since no problems were observed on the new configuration during the
experiment, removing max-processes and flaky-retries workarounds.
Bug: chromium:1342945
Change-Id: I51150092c67802ffd54796dd3b067cd6473dfb86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780922
Reviewed-by: Roman Lavrov <romanl@google.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
c460c299
|
2022-06-21T11:20:45
|
|
Implement GLSL additions for ANGLE_shader_pixel_local_storage
Specs out, implements, and thoroughly tests the GLSL additions for
ANGLE_shader_pixel_local_storage. Adds a simple transformation that
rewrites PLS directly into shader images. Updates the existing PLS tests
to use the newly built-in PLS features and ensures they continue
passing.
For now, applications call glBindImageTexture to configure their pixel
local storage. The OpenGL ES API side of this extension will follow
shortly.
Bug: angleproject:7279
Change-Id: I141183069b5cbfcca01cbb77b5b36d3e5f834bf5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3761876
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
25f7d39f
|
2022-07-21T10:01:38
|
|
Roll vulkan-deps from c42337d9ef75 to 5cb0a31b27bf (10 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/c42337d9ef75..5cb0a31b27bf
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/93ebf698a0..e4cfa190df
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/16847a6100..87d2aa9d77
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/eb67f9bbef..52aadfabb5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC romanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: romanl@google.com
Change-Id: Iaaa8bdbee6b56f8e1e07722c690548ad46533a5a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3778411
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
dba01bdc
|
2022-07-21T07:25:29
|
|
Roll Chromium from 16ae342caefb to 9d88fd8904e8 (515 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/16ae342caefb..9d88fd8904e8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC romanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/60d303b648..bed2979286
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a4506d5d63..d4d55fbf05
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe41fffbb7..cbe80d6926
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9cb6988560..bbffded4b5
* third_party/android_build_tools/lint: OkpY7I7TtDs4jihQ9SmckN-GEVBpZ2y9xr4M7TimTqoC..INnGGTfg5gGJutJiBtWI6-QwusHDDnKvZzI53Q3UiecC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..abcd8ba23e
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f3edc50445..39e33e6eca
* third_party/fuchsia-sdk/sdk: version:9.20220719.3.1..version:9.20220720.2.1
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d9a213cebd..b453316b9e
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/264e097ed4..6786537981
No update to Clang.
Bug: None
Tbr: romanl@google.com
Change-Id: I98dbfe79734915da7b6f1d70870cf85c28fc782b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3779248
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
992018c7
|
2022-07-20T17:31:47
|
|
Suppress VUID-VkGraphicsPipelineCreateInfo-pStages-06896.
Bug: angleproject:7513
Change-Id: I2877c069e33d2ec5e92cf759dc3ab1d270e1a414
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3776759
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
1e619503
|
2022-07-20T11:55:49
|
|
Skip TracePerfTest vulkan_car_chase on Linux Intel
Flaky VK_ERROR_DEVICE_LOST on Intel UHD 630 Mesa 20.0.8
Bug: angleproject:7125
Change-Id: I7e99819a586e3f146728f49dfdeebf9e8ddcb219
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3777097
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
84bfb6ce
|
2022-07-20T07:43:28
|
|
Roll Chromium from 806fa2d991d9 to 16ae342caefb (283 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/806fa2d991d9..16ae342caefb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC romanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/f304e1f508..60d303b648
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/1307a6e5be..fe41fffbb7
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ab2ff5cdd4
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f05fcf7051..f3edc50445
* third_party/fuchsia-sdk/sdk: version:9.20220719.1.1..version:9.20220719.3.1
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/2b481239f6..37eadcf61d
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/394db6d2a8..264e097ed4
* tools/skia_goldctl/linux: Ri4sbgofBQTekhs0H-MmBCEBFmTBIzjMFWjrISXy44QC..BquSeorcTU84O2_A8IoWetGrcfLWxLfZCo9sve1Wt2IC
* tools/skia_goldctl/mac_amd64: 2FFjh0Xtg__05cZwoN_kBY9gONiqBgS4k96j4PiERwQC..-t3YY_sZ-jtMAYZ2PlhjudFnEUgk4m-HjlIwSip4tOAC
* tools/skia_goldctl/mac_arm64: CDhGE0xDG5UpFXKhktNh4Hn1ahNh3qpRQ1KDKvRjuWgC..x_xKUnqrgizoTO8mxX4RkyhpQ-nUp_x_go9YH-tc--QC
* tools/skia_goldctl/win: 2hLrGJKgXQCcX5OqtWO__r1MDSY-ix-DaFzXPUcuOJQC..AOoQr1u4-cOIEYJDAgVxGWoTiPaRcjrSsjjAaB-u_ggC
No update to Clang.
Bug: None
Tbr: romanl@google.com
Change-Id: Id9bff94ea34661824d0b45739a7f45dc1fdf0f3d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3775142
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
fc97b2da
|
2022-07-14T13:18:56
|
|
Vulkan: Always use depth<=256 AHB image siblings
Android will sometimes use an uninitialized value for the layerCount,
which results in huge, many-GB allocations down the line.
If we see a big value there, force to 1.
Bug: b/223456677
Change-Id: I201e9901d9c726a9af73d025ac33850d11a5a38a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3764433
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Lingfeng Yang <lfy@google.com>
Commit-Queue: Lingfeng Yang <lfy@google.com>
|
|
|
b860fa45
|
2022-07-14T13:14:06
|
|
Vulkan: account for yuvCscStandard in switch validation
The previous condition only accounted for ints, but needs to account for
yuvCscStandard in order to support the new emulated yuv<->rgb builtins.
Bug: b/223456677
Change-Id: I25e0c88b9c8eb5f8caf3e7640fe391a9b9c10bf1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3764431
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Lingfeng Yang <lfy@google.com>
|
|
|
be24acbd
|
2022-07-14T13:16:33
|
|
Vulkan: Support GL_REQUIRED_TEXTURE_IMAGE_UNITS_OES
This CL adds basic support for GL_REQUIRED_TEXTURE_IMAGE_UNITS_OES to
the Vulkan backend, and also allows the enum through validation.
Bug: b/223456677
Change-Id: If0dcb467bb72bdfc9ced4862231a676eef471a6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3764432
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
bd82a5e4
|
2022-07-07T17:03:27
|
|
Vulkan: __samplerExternal2DY2YEXT-aware ProgramExecutableVk
This CL incorporates __samplerExternal2DY2YEXT into the Vulkan objects
involved in ProgramExecutableVk. Specifically, we need:
1. TextureVk to create and return a VkSampler imbued with identity
conversion model, so we can create an immutable sampler from it.
2. Access to the identity conversion desc so that it can be traced in
mImmutableSamplerIndexMap.
Bug: b/223456677
Change-Id: Ia302226a8aa4a97d4a42f79c79ce47af3abec37c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3753294
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Lingfeng Yang <lfy@google.com>
|
|
|
6c418f8c
|
2022-07-07T14:28:06
|
|
Vulkan: __samplerExternal2DY2YEXT-aware TextureVk
This CL adds the ability for TextureVk to return an ImageView that is
created with a VkSamplerYcbcrConversion object that uses an identity
conversion model.
This allows direct sampling of YUV values without RGB conversion, which
is needed for __samplerExternal2DY2YEXT.
Bug: b/223456677
Change-Id: Ie1d4e12375b7808a1f060747bc2d74baeda3fdea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3751889
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
53d40aed
|
2022-07-15T15:03:25
|
|
Vulkan: Destroy descriptorSet cache when BufferHelper destroyed
For atomic counter buffers or other cases, dynamic descriptor is not
been used. Right now when such buffer is destroyed, the cache is still
lingers around. With this CL, when a new cache entry has been created,
we record the cache entry in the BufferHelper. When BufferHelper is
destroyed, we also immediately destroy the cache entry since the cache
will no longer reused.
Bug: b/237686097
Change-Id: I26eee96318fbc003e65318c0b8263dc61092f350
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3764044
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
c7459a46
|
2022-07-15T09:55:03
|
|
Vulkan: Destroy descriptorSet cache when BufferBlock destroyed
When a new cache entry has been created, we record the cache entry in
the BufferBlock. When BufferBlock is destroyed, we also immediately
destroy the cache entry since the cache will no longer reused.
This CL also removes DescriptorCacheResult from various APIs since it is
now redundant with newSharedCacheKey argument.
Bug: b/237686097
Change-Id: I14fa8906fdbe7d9226c8e8ecddef2beb05fbaa5c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3756694
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Auto-Submit: Charlie Lao <cclao@google.com>
|
|
|
3fbd4e40
|
2022-07-19T18:58:24
|
|
Roll Chromium from a1cfdbdf4c3b to 806fa2d991d9 (256 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/a1cfdbdf4c3b..806fa2d991d9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC romanl@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/f7ac2ecbd4..f304e1f508
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/0a224ca590..1307a6e5be
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1240e973d5
* third_party/fuchsia-sdk/sdk: version:8.20220713.3.1..version:9.20220719.1.1
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4e30c7daa4..394db6d2a8
No update to Clang.
Bug: None
Tbr: romanl@google.com,ynovikov@google.com
Change-Id: I7f58ef83fe7c9c7760b200a7142a98709c5aac47
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3773447
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
8df0c53e
|
2022-07-11T16:56:26
|
|
Vulkan: Split suballocation out into it's own file
Right now Suballocation and BufferBlock classes are in vk_utils.h, which
is included by other header files. This made it difficult to have these
two classes use variables defined in other headers. And vk_utils.h is
really designed for utilities, it isn't the best place for
bufferBlock/suballocation by definition. This CL split out suballocation
code into its own file to make future CLs much easier. No functional
change is expected other than move the code around.
Bug: b/237686097
Change-Id: I36733468b4bed152a19d9c9bca8e7459c11c3b43
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3756761
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
45e5cf01
|
2022-06-03T14:29:23
|
|
Vulkan: Implement ASTC emulation.
Implement ASTC emulation using the astc-encoder library.
Add copy_image tests to deqp_gles31_test_expectations for desktop cards.
Add emulatedAstc limitation.
Don't expose emulated ASTC from WebGL contexts.
Introduce ANGLE_HAS_ASTCENC define to check for build availability.
Only build on angle_standalone configurations.
DEPS: Add astc-encoder.
image_util: Decode ASTC to RGBA.
TracePerfTest: Skip car_chase and genshin_impact on NVIDIA.
Bug: angleproject:7415
Change-Id: Ib2f3fd3f710164a2ecd5d5edf780227031bbfb84
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697999
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
3d369ac6
|
2022-07-19T10:01:26
|
|
Roll vulkan-deps from b22fee44bf09 to c42337d9ef75 (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/b22fee44bf09..c42337d9ef75
Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e81f04ef6b..eb67f9bbef
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC romanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: romanl@google.com
Change-Id: I542e96efb29d937dc33c534df037607a943509a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3771432
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
86160236
|
2022-07-19T07:36:28
|
|
Roll Chromium from 14dcb8bf5432 to a1cfdbdf4c3b (455 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/14dcb8bf5432..a1cfdbdf4c3b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC romanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/679de1ec39..f7ac2ecbd4
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5cee6a2f1c..a4506d5d63
* buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/b1269813ea..88bf407048
* buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/49191c55bb..955e2ff5fb
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/e94a13ab1c..0a224ca590
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/fd07f9469a..9cb6988560
* third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/c3471b21c1..a4bb552cde
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1240e973d5
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8168f76753..f05fcf7051
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/352f404545..4e30c7daa4
No update to Clang.
Bug: None
Tbr: romanl@google.com
Change-Id: I2355b322e8a11b25b7b3a6bd17ac298ec259fddf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3771426
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
a3899c53
|
2022-07-15T08:39:32
|
|
Capture/Replay: drop context capture call in EGL capture templ
Using the context provided by the thread variable is not correct, it
worked only by accident. The only call that uses a context is
eglCreateImage and here we have to use the context passed into the
call.
Bug: angleproject:4964
Change-Id: I78250050cc8f7271be8c91c2d09d99210aaead21
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3762458
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Faye Zhang <ffz@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
645ee194
|
2022-07-18T21:48:59
|
|
Vulkan: Only modify input attachment images for FF MSAA fix up
Previously all OpTypeImages were changed to MSAA, but only the ones with
the SubpassData dimension should have been.
Bug: angleproject:6195
Change-Id: I1caadd23420f0d9cffdee4e3b9d63cf6fa93982e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3770645
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d4e54b81
|
2022-07-17T22:56:51
|
|
Vulkan: Clean up garbage of last completed submission too
Due to an off-by-one error, the garbage of the very last completed
submission was not actually cleaned up.
Bug: b/172704839
Change-Id: I4fb6a77af4379568990853e4bf3fd945fcde657c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3769547
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
5f7e0e50
|
2022-07-15T21:58:11
|
|
Translator: Remove early fragment tests transformation
We no longer add early_fragment_tests as an optimization.
Bug: angleproject:7347
Change-Id: Ic12d8491a4d24d546b6b19257cd63c71074ba3a6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3769546
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
f1dac70d
|
2022-07-12T15:56:10
|
|
Remove platform skips for cookie_run and real_cricket
These traces now work after being updated in restricted_traces.json.
Bug: angleproject:7420
Change-Id: I57be700afb0a9232ce88bf2eed5f5104256b94f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3759428
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
3baa867c
|
2022-07-14T23:08:42
|
|
Vulkan: Fix image arguments passed to functions in GLSL
It's impossible to provide the format qualifier to an image function
parameter in GLSL, because `layout()` is not acceptable there. SPIR-V
doesn't accept formatless image parameters without the
StorageImageReadWithoutFormat and StorageImageWriteWithoutFormat
capabilities, which are not universally available.
Instead, this change monomorphizes functions with image parameters.
Note that this was already previously done for R32F images for emulation
purposes.
Bug: angleproject:7484
Change-Id: Id287c4a93b32deb3fd8be982c32fa58fd2c848d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3763074
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
2c3c45ee
|
2022-07-18T12:37:57
|
|
Roll VK-GL-CTS from ef9a6635208b to 692df061716d (12 revisions)
Includes suppression of new render_sample_texture_array dEQP tests on Android.
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ef9a6635208b..692df061716d
2022-07-15 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main
2022-07-15 jan-harald.fredriksen@arm.com Avoid dependency on geometry shaders for VK_ARM_rasterization_order_attachment_access
2022-07-15 michal.jakubek@mobica.com Global Priority Queue Families Tests
2022-07-15 rgarcia@igalia.com Test resetting queries after copying results
2022-07-15 piotr.byszewski@mobica.com Remove some RT SkipTriangles tests
2022-07-15 piotr.byszewski@mobica.com Enable FSR basic tests for Vulkan SC
2022-07-15 toni.merilehti@siru.fi Add tests for array comparisons
2022-07-15 yiyfan01@arm.com Add Texture2D array test in which Texture2D array is rendered and sampled.
2022-07-15 michal.jakubek@mobica.com Fix for attachment count in EXT_color_write_enable tests.
2022-07-15 piotr.byszewski@mobica.com Fix maxImageView(MipLevels/ArrayLayers) bug in SC
2022-07-15 skirank@nvidia.com Fix vkwsi Display control tests
2022-07-15 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-bots+autoroll-info@google.com,romanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:7506
Change-Id: I0b674a424cc109126b5a590430546942c6db3740
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3769550
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
466fc0c6
|
2022-06-30T15:47:14
|
|
Add new prerequisite type for GL_ENUM integers
This check is not applied in this commit.
Bug: angleproject:7420
Change-Id: Ie84600c21aa4829c8d8c798643719c3084597af4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3759423
Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
bf369285
|
2022-07-18T15:12:13
|
|
Suppress SYNC-HAZARD-WRITE_AFTER_READ in vulkan_car_chase
Bug: angleproject:7125
Change-Id: Ibebe363bcc98413f259db9cb959b0ef816ed5ee2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3768935
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
e7269490
|
2022-07-06T09:48:41
|
|
Remove python version check in presubmit
This script should now always be run under python3 due to
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3739269
Bug: angleproject:7475
Change-Id: I12ddb42b074959aec36731d121282a81c46bc5ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3749136
Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
68879b81
|
2022-07-18T10:59:37
|
|
Minor fixes: typos, links.
Bug: None
Change-Id: Ic1d8df51bb32da2fbb675021318f40bb495d3f4e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3769549
Commit-Queue: Roman Lavrov <romanl@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
b569fc1a
|
2022-07-18T10:01:26
|
|
Roll vulkan-deps from 3204c0c798d3 to b22fee44bf09 (5 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/3204c0c798d3..b22fee44bf09
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e2cf769302..93ebf698a0
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/30cb46bf7e..a13608020f
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/427d39742f..e81f04ef6b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: Idc729bd4c2c2c144d38dbb0b4176aa6d34d65b1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3768047
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
c210f881
|
2022-07-18T07:00:09
|
|
Roll Chromium from d19b3e76906e to 14dcb8bf5432 (534 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/d19b3e76906e..14dcb8bf5432
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/62186a2b91..679de1ec39
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/866e5a3d6a..e94a13ab1c
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1240e973d5
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/26bc518eae..8168f76753
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/75964e1dea..352f404545
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I2be7317af4463543f925cd6a77ea7efbba413a56
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3768044
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
c4004751
|
2022-06-23T14:35:21
|
|
Metal: texture allocation failures handled incorrectly
When allocating large textures, allocation may fail
if textures exceed the Metal memory limit. When a nil
texture is returned, we should check texture allocation before
assigning it as a backing object
ANGLE port of the following bug
https://bugs.webkit.org/show_bug.cgi?id=240790
Bug: angleproject:7459
Change-Id: Ib94f42d25df28a31513ab78fc42c6523bfbc5f76
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3722601
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Gregg Tavares <gman@chromium.org>
|
|
496bddf3
|
2022-07-14T20:58:03
|
|
Skip mutable texture upload tests through feature
* Added a condition in the mutable texture upload tests in
VulkanPerformanceCounterTest.cpp, to skip the test if the feature
`MutableMipmapTextureUpload` is disabled on that platform.
Bug: angleproject:7308
Change-Id: Iff1985cabb463dc82ef15340cf3c485a0b680f0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3765180
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
15cc0013
|
2022-07-14T23:32:05
|
|
Add a GL_ANGLE_shader_pixel_local_storage extension
Plumbs through "GL_ANGLE_shader_pixel_local_storage" and
"GL_ANGLE_shader_pixel_local_storage_coherent" extension strings
advertised by ANGLE and stubs out an initial spec document. This change
doesn't add any new procedures or shader constructs, but it does allow
the PLS tests to start checking for the real extension strings and
requiring the GL_ANGLE_shader_pixel_local_storage extension.
Bug: angleproject:7279
Change-Id: I36877fe4117185a2121f803288123cd69a447cf3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3739590
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Chris Dalton <chris@rive.app>
|
|
|
1ae7a56c
|
2022-07-14T13:11:16
|
|
Vulkan: Fix double clear of AHBs
Originally when deferred clears were implemented, it was assumed that
it's impossible at glClear time to have a render pass open without any
commends. This assumption was broken under two circumstances:
- Clear of 3D attachments that don't include all layers
- Clear of AHBs
In these cases, the clear immediately opened a render pass with nothing
but loadOp=CLEAR. If another clear followed, an assertion would fire.
In this change, open render passes without commands are handled such
that clears are accumulated in the loadOps.
Bug: b/223456677
Change-Id: If99bcf9e24454b0c9e140cb93df7e7f76f175363
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3763169
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Lingfeng Yang <lfy@google.com>
|
|
|
8f2fbbeb
|
2022-07-14T11:30:12
|
|
Inline all metal command buffer decoder methods
It should improve command buffer decoding slightly.
Bug: angleproject:7296
Change-Id: I2481d0760c937a26c7c998131b398dd83bd0eaf9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3763063
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
|
|
|
ebf14fe3
|
2022-07-14T17:19:15
|
|
Return EXIT_FAILURE from run_perf_tests.py if any test failed
Previosly EXIT_FAILURE was returned only for exceeding max_errors,
which made Swarming erroneously believe that the task succeeded,
even though some tests in it could have failed.
Bug: angleproject:7498
Change-Id: I896fe97e7d24549202663351d5b61b206afbe6b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3762456
Commit-Queue: Roman Lavrov <romanl@google.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Roman Lavrov <romanl@google.com>
|