kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll ccfade07 2021-03-05T20:58:12 Roll Chromium from e3e89758c942 to 76f6150ffdeb (205 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e3e89758c942..76f6150ffdeb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/359c085ec7..33cb2c879e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/adb70871cf..aba4fb672b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e5299ca5b7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/791d56c8f0..630ab8a35c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/77e2f88df4..012c6bcee7 * tools/skia_goldctl/mac: 1eS-4K0xTtzfvP8vAOAjti_D7ynUHaksiVFAzZEMShIC..WCRXBnRqP4DfVUcrclUzE5_p_6x3RZZatC2SM1ZRX4IC * tools/skia_goldctl/win: 2dvsgu3V4NQRDUdbOExgmxG2IsdKffTY9pvmduflAWYC..DpXABD34NuP5941cN5RRg-EPNqCxgt0lA_ga3KIZg4AC No update to Clang. Bug: angleproject:4483 Tbr: jonahr@google.com,ynovikov@google.com Change-Id: I360b0f104a02443bcea8a93cf69d2a11b4c4e55a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739996 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll a318b3d6 2021-03-05T16:38:47 Roll VK-GL-CTS from 9cdde06fb38a to 9be79728eafb (18 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9cdde06fb38a..9be79728eafb 2021-03-02 ynovikov@google.com Fix Windows build 2021-03-01 alexander.galazin@arm.com Update Vulkan headers 2021-02-25 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2021-02-25 rgarcia@igalia.com Pipeline bind point tests 2021-02-25 rgarcia@igalia.com Add tests for sparseImageFloat32Atomics 2021-02-25 anholt@google.com Fix more spurious failures in KHR-GL*.transform_feedback.api_errors_test 2021-02-25 anholt@google.com Fix spurious failures on KHR-GL30.transform_feedback.api_errors_test 2021-02-25 tapani.palli@intel.com Print ints for pixel values instead of chars in error message 2021-02-25 thomas.spurden@broadcom.com Fix exit code for cts-runner 2021-02-25 mikko.tiusanen@siru.fi Tests for GLES3 framebuffer completeness 2021-02-25 alexander.galazin@arm.com Support GL 4.5 in the Program interface query tests 2021-02-25 lionel.g.landwerlin@intel.com Silence validation layers warning on missing sType 2021-02-25 mika.vainola@siru.fi Allow wildcards in waiver vendor strings 2021-02-25 boris.zanin@mobica.com Add a list of unused shaders into log 2021-02-25 boris.zanin@mobica.com Add concurrent transform feedback streams query tests 2021-02-24 gleese@broadcom.com Remove a waiver for a non-existant device 2021-02-23 mika.vainola@siru.fi Add tests for implicit unmap on free 2021-02-23 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jonahr@google.com,angle-bots+autoroll-info@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:5684, angleproject:5722 Tbr: jonahr@google.com,angle-bots+autoroll-info@google.com,ynovikov@google.com Change-Id: Ibd432a2135665ed89f93549e24923c108a08f97b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739041 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov a1f86b4d 2021-03-05T16:55:47 Skip vulkan_car_parking_multiplayer on Win Intel Internal Vulkan error (-4): The logical or physical device has been lost. Bug: angleproject:5724 Change-Id: I80eb21d087341fac23393d7365bd5ea4c5ac6e05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739387 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 8a48f4de 2021-03-05T14:33:16 Skip CopyTextureVariationsTest failing on Ozone CopyTextureVariationsTest.CopyTexture CopyTextureVariationsTest.CopySubTexture Bug: angleproject:5723 Change-Id: Iad62344b9bc503a2553647877c5975b03bb6829d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738602 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Amy Liu 0ee360de 2021-03-05T06:02:25 Revert "Compression of the data from vkGetPipelineCacheData." This reverts commit cc5083e071e9e0663979c02376e7848c7de11765. Reason for revert: Re-land this patch after fixing the performance regression of big blob cache (discussed in angle issue 4722). Original change's description: > Compression of the data from vkGetPipelineCacheData. > > The size of pipelineCacheData sometimes is greater than > 64k which cannot be saved because of the Android blob cache > limitation (single cache data size should be < 64k). > Implement the compression to store more cache data. > > Bug: angleproject:4722 > Change-Id: I435b086d70d0e6378f1141464ae2bafbe076f193 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2631511 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:4722 Change-Id: Ie4de10eabf5cd8f0b4748e2c1a4c3ab6b8ea092c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739098 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 32bf7d41 2021-03-05T13:40:53 Fix Apple GPU detection for M1 Renamed supportsIOSGPUFamily to supportsAppleGPUFamily to match official naming. Bug: angleproject:5672 Change-Id: Ic02c0f01bc30c12cef594cc2eb4f9932c22c1e33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739459 Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki d96b9ffa 2021-03-04T09:57:53 capture_replay_tests: Don't skip tests that pass. These tests were skipped due to compilation problems, but do now fully pass on SwiftShader ES2. Remove PointSpritesTest.PointWithoutAttributesCompliance/* Remove ExplicitContextTest.GetProcAddress/* Remove RobustBufferAccessBehaviorTest.EmptyBuffer/* Remove EGLSyncTest.AndroidNativeFence_WaitSync/* Bug: angleproject:5721 Change-Id: I3f50272c69ba78e2432f4278753e5d48d8601910 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739723 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi e366e2c3 2021-02-27T01:00:02 Vulkan: Keep dynamic buffer's free list trimmed ContextVk's staging buffer never gets a chance to free its free buffer list. During application load time, a large amount of memory may be allocated from this buffer to stage texture updates and they would remain throughout the life of the application. This change ensures that the free buffer list doesn't grow unbounded. In the Manhattan trace, this saves >1GB of memory on Linux. There are now three policies for vk::DynamicBuffer: - Always reuse buffers: This is useful for dynamic buffers that make frequent small allocations, such as default uniforms, driver uniforms, default vertex attributes and UBO updates. - Never reuse buffers: This is for situations where the buffer is unlikely to be used after some initial usage, such as texture data upload or vertex format emulation (as the conversion result is cached, so it's never redone). - Limited reuse of buffers: For the staging buffer in the context which is shared by all immutable texture data uploads, it's useful to keep a limited number of buffers (1 in this change) to support future texture streaming while allowing a large number of buffers allocated in a burst to be discarded. Bug: angleproject:5690 Change-Id: Ic39ce61e6beb3165dbce4b668e1d3984a2b35986 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725499 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll b23644d3 2021-03-05T11:23:04 Roll vulkan-deps from c0db6ae3d87d to 6691fcec0bce (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c0db6ae3d87d..6691fcec0bce Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f7043c0de6..7d514cf1c7 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a4cb494bee..0ec2c7a693 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Icb57948ab38a5d6e48e8741dca831cf8148bbfb0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739697 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 40ed11b7 2021-03-05T10:01:22 Roll SwiftShader from 084529f3a9b9 to 6846389f25ca (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/084529f3a9b9..6846389f25ca 2021-03-04 srisser@google.com Implement VK_KHR_timeline_semaphore If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I649661d8859df2f4c26aeac02cf4df06e66e78d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738440 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 97127961 2021-03-05T07:06:54 Roll Chromium from 143c12daa39f to e3e89758c942 (782 revisions) https://chromium.googlesource.com/chromium/src.git/+log/143c12daa39f..e3e89758c942 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/122de421bd..359c085ec7 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b60d41f762..523462a3ce * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8f03866f94..fe29ae7178 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/33e44690c0..adb70871cf * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/800c09f4d7..e18c2cc4c2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cdacb3b199 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6a9fd91d34..791d56c8f0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ee85ae1c83..77e2f88df4 * tools/skia_goldctl/mac: WCRXBnRqP4DfVUcrclUzE5_p_6x3RZZatC2SM1ZRX4IC..1eS-4K0xTtzfvP8vAOAjti_D7ynUHaksiVFAzZEMShIC * tools/skia_goldctl/win: DpXABD34NuP5941cN5RRg-EPNqCxgt0lA_ga3KIZg4AC..2dvsgu3V4NQRDUdbOExgmxG2IsdKffTY9pvmduflAWYC No update to Clang. Bug: angleproject:4483 Tbr: jonahr@google.com Change-Id: I22a31605b07c7308f26833ebbafc9bba5fcb5219 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738465 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya fe2efefa 2021-02-27T08:28:03 Add FramebufferAttachmentPerfTest Two tests are added to measure the overhead involved in the Observer/Subject interface - 1. FramebufferAttachmentBenchmark - stresses repeated attach/detach of observers to subjects. 2. FramebufferAttachmentStateUpdateBenchmark - stresses state updates to subjects and their propagation to observers. Bug: angleproject:5692 Change-Id: I6e573f3a948ef2b20c56091e549eb871051e0103 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725740 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Eng 8092ed72 2021-03-04T21:29:55 Revert "Add support for Linux GPU info with Vulkan backend" This reverts commit 5c09c1f882f15e1a77577f1a62d861355aac90a4. Reason for revert: Breaks the Chrome OS build. Original change's description: > Add support for Linux GPU info with Vulkan backend > > 1. Add support for Linux GPU info with vulkan backend: for > dev board without PCI support, try vulkan backend to get > GPU info. > 2. Fix getVulkanInstance() issue when loading non-exist lib: > return NULL instance if open lib failed. > > Bug: angleproject:5717 > Change-Id: I03c11da25a8787496d098f6c9d6b4c53701383e4 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734375 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5717 Change-Id: I97a27295818371556fd09837485a9132f74748c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2737557 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
Mohan Maiya 58c35d42 2021-03-02T09:00:55 Vulkan: Unmap buffer when adding to mBufferFreeList The commit b5af8bde13 moved the unmap call on a buffer to when it is placed in mBufferFreeList. There was one place that was missed, rectifying that oversight here. Bug: angleproject:5689 Change-Id: Iaed2916de374d55ab59276e2679c23ed7ef9c4e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733476 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jason Macnak 60ad763d 2021-03-01T15:29:51 Vulkan: Enable EGL_ANDROID_recordable for EGL configs on SwiftShader There does not seem to be a way to query the Gralloc and Vulkan drivers for recordable support so keep this as a narrow hack restricted to SwiftShader. Bug: b/181163023 Test: `cts -m CtsMediaTestCases` on Cuttlefish w/ SwANGLE Change-Id: I0bfee01d43ea8e3d9965f5bfaa578a285d37db29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727874 Commit-Queue: Jason Macnak <natsu@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 559cb622 2021-03-04T12:39:24 infra/config: Rename console/list views. The new simpler names "ci" and "try" prevent URLs with space characters. Bug: angleproject:5559 Change-Id: I3e16f88553cc979cdddf2f2e5ff34b2be74b7dae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2737059 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 2f737c25 2021-02-25T16:55:14 Translator: Rename GLSL to SPIR-V in Vulkan and Metal output Preparation for actual SPIR-V output instead of GLSL. Bug: angleproject:4889 Change-Id: Ic279b23d3a817bd5dca66a844905378207afdbac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2721194 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Yuly Novikov a6b16d29 2021-03-02T19:04:57 Suppress UNINSTANTIATED_PARAMETERIZED_TEST failures on Ozone We only support ES2 on Ozone, so tests that depend on ES3 or ES31 support are not instantiated there. Bug: chromium:1183147 Change-Id: Id58bcd9b44a5b9a70b5ae8115e27c44f5dc81226 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726550 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Xiaoxuan Liu 5c09c1f8 2021-03-03T17:56:07 Add support for Linux GPU info with Vulkan backend 1. Add support for Linux GPU info with vulkan backend: for dev board without PCI support, try vulkan backend to get GPU info. 2. Fix getVulkanInstance() issue when loading non-exist lib: return NULL instance if open lib failed. Bug: angleproject:5717 Change-Id: I03c11da25a8787496d098f6c9d6b4c53701383e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734375 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 54294c9a 2021-03-02T22:15:05 Partially upgrade codegen to Python 3 Bug: angleproject:5707 Change-Id: I4e26c2c7ba4a36185b28ecd6e87be1161b60431a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729567 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 8b55a3e5 2021-03-03T16:35:53 Replace Win x64 dEQP GPU.FYI bots with chromium.angle bots Bug: angleproject:4483 Change-Id: I6b09f2c97e07eca90c71211e23ddd931637e7dda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733270 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll d0c8d6a9 2021-03-04T10:01:21 Roll SwiftShader from 106e01583a3a to 084529f3a9b9 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/106e01583a3a..084529f3a9b9 2021-03-03 venni.ihanakangas@siru.fi Add support for internal error status checking in regres If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I7c91c5c9be050ba22d351e0cde05814054007cc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734636 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2429e065 2021-03-04T10:01:04 Roll vulkan-deps from 6c3f8d8c39b9 to c0db6ae3d87d (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6c3f8d8c39b9..c0db6ae3d87d Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/939bc02603..f7043c0de6 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/88ea55de92..461b33cfa2 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b95891b0b1..a4cb494bee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I6ef4cbfc43b39c97bcd683600501ca3cd8b9318a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734694 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 0224e848 2021-03-03T14:31:07 Vulkan: Fix overlay graph widgets Bug: angleproject:5690 Change-Id: I9a63fd91c7403f8bf1ee6ef25fc636aecfbe6ea0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732533 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 49211c31 2021-03-02T11:22:28 Vulkan: Fix Overlay for prerotation Bug: angleproject:5690 Change-Id: I906a259767c54e3ac9f3ac822b6d5ed5dcaa0bd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725768 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 90db6049 2021-03-02T13:02:07 Vulkan: Workaround Overlay draw issue on Android On Android vector[n] translates to vector[0] likely due to a driver bug. This resulted in text such as: 12345678abcdefghijklmnopqrstuvwx to render as: 1234123412341234ijklijklijklijkl It also made graph data flicker. As a workaround, the shader now does an if-else on the value of n and uses a constant to load the appropriate component of the vector. Bug: angleproject:5690 Change-Id: Idb891e726fafa896a1064ef7b2941b8fd1c41ed1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725769 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Stephen White d8557cc8 2021-03-03T10:17:46 Fix for readPixels() to PBO fast path. Include the "pixels" (data) pointer as offset. Bug: angleproject:5702 Change-Id: Idc9f3ee4c0dbb1cc9308393bbf877d6137598486 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732789 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Cody Northrop 71c7e346 2021-03-02T21:52:35 Tests: Add Rope Hero: Vice Town trace Test: angle_perftests --gtest_filter="*rope_hero_vice_town*" TBR: jmadill@google.com,timvp@google.com Bug: b/181727986 Bug: angleproject:5711 Change-Id: I11021ae91f968bd453b98a35c60cab90d71e5ed6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2731288 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Peng Huang a73818aa 2021-03-03T12:41:58 Workaround a GL_OES_depth32 bug on Android emulator Bug: chromium:1184261 Change-Id: I7aac7c696ff2d08dc2aaac86abc1c3b0e54cda1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733287 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev e44595f2 2021-03-03T13:11:19 Update DEP actions for Python 3 build/mac_toolchain.py was fixed for Python 3 in https://crrev.com/c/2727724 Bug: angleproject:5707 Change-Id: I2f233157bedc3cc298250b8efc9bd68ac45cdc28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2731707 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 18314bce 2021-03-03T10:28:07 Tests: Skip car_parking_multiplayer on Nvidia The trace doesn't cause any errors, which would have blocked landing it. But it does spew undefined behavior warnings which fills the log. See the bug for details, skipping for now. Test: angle_perftests --gtest_filter="*car_parking_multiplayer*" Bug: angleproject:5613 Change-Id: I54bf63eeb7c5212b6ce40cf2b45354822e8456e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733089 Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 07025aa3 2021-03-02T00:28:32 Overlay: Widget for vk::DynamicBuffer allocations Bug: angleproject:5690 Change-Id: Idfa591903627bbebffe306b387e95cbec1195338 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725767 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 9946051a 2021-03-03T15:09:41 Roll Chromium from 2a5fa9108962 to 143c12daa39f (878 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2a5fa9108962..143c12daa39f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ed3af53eea..122de421bd * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/aa09fa7659..b60d41f762 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/6918862bfc..8f03866f94 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4138b13c16..33e44690c0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9b6e926feb * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b3546dc126..ee85ae1c83 * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/0bdacc0246..4d4e1824fc No update to Clang. Bug: None Tbr: jonahr@google.com,jmadill@google.com Change-Id: I8401b1ba1a585527879f4cd8f0e5b90cfc896b72 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732747 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jonah Ryan-Davis cdef22a5 2021-03-03T10:19:31 Skip TransformFeedbackTest.MultiContext on Metal This test is flaky on the metal backend. Bug: angleproject:5713 Change-Id: I1d789825e0322f00b017a60f8fd1cef02b5b3088 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732787 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop fbbd143b 2021-02-27T17:42:05 Tests: Add Talking Tom Hero Dash trace Test: angle_perftests --gtest_filter="*talking_tom_hero_dash*" TBR: jmadill@google.com,timvp@google.com Bug: b/181415750 Bug: angleproject:5614 Change-Id: I6110f5e3e6bbc60706c448ad3643de73b3c2eca2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726134 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 159d600e 2021-03-03T10:01:04 Roll vulkan-deps from 64e40ae7572f to 6c3f8d8c39b9 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/64e40ae7572f..6c3f8d8c39b9 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/42ddfbd3d5..159b057080 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0bd920eb9d..939bc02603 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/c428484bc8..4fe5828a02 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c5678a03db..237d3dcb5c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bbe724bcf1..b95891b0b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I834954df829eeebd64666c56b1e105f0f499d84b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2730671 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 1de8b5a6 2021-03-02T14:42:22 Tests: Add Car Parking Multiplayer trace Test: angle_perftests --gtest_filter="*car_parking_multiplayer*" TBR: jmadill@google.com,timvp@google.com Bug: b/181696940 Bug: angleproject:5710 Change-Id: I50366e0bb993c1f19906aa5d96f47a00247a24f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729605 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuly Novikov 95b086b4 2021-03-02T13:21:52 Pull buildtools DEPS directly instead of via recursedeps libc++abi will be required after http://crrev.com/c/2729355 Switching others preemptively Bug: chromium:1177288 Change-Id: I4d6dd8415b63de21bef8c750b9cf5c7cf23c9022 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727647 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 210a464e 2021-03-02T12:05:08 Test: Add Standoff 2 trace Test: angle_perftests --gtest_filter="*standoff_2*" TBR: jmadill@google.com,timvp@google.com Bug: b/181681788 Bug: angleproject:5708 Change-Id: I36314d1addc880cc4fb0dc321cda4ba3eabab000 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2728662 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jeff Vigil 22fc9523 2021-02-03T15:32:48 EGL: implement EGL_EXT_buffer_age Add extension flag. Add Validation check to surface query. Enable extension for vulkan. Modify AcquireNextImage to ++frame count and tag images with frame number. Buffer age is the difference between current frame count and the tagged frame number on the buffer. getBuffeAge may need to trigger AcquireNextImage to be current. Pass through egl extension and query. Add EGLBufferAgeTest Test: angle_end2end_test --gtest_filter=EGLBufferAgeTest Test: angle_deqp_egl_tests --deqp-case=dEQP-EGL.functional.buffer_age.* Bug: angleproject:3529 Change-Id: I0cb94be1c3e85d6f33e82a6a1ccdc9731b6a7f23 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2684724 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Lubosz Sarnecki c11186c2 2021-03-02T14:42:08 capture_replay_tests: Fix MemoryObjectTest. Add gles_ext_params Capture functions for MemoryObjectsEXT. Add case for GLCreateMemoryObjectsEXT to MaybeCaptureUpdateResourceIDs. Don't skip MemoryObjectTest, as it passes now on SwiftShader ES2. Bug: angleproject:5703 Change-Id: I930fab675cf0848f46a846388955a6bd3274a587 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729004 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 9d091b66 2021-02-25T15:07:30 Add Chrome Canary ANGLE injection steps Bug: angleproject:1944 Change-Id: I89ade8230271378cd8b2a5a7cb58ad6c0e4f1fde Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2724271 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis 6edba641 2021-03-02T11:36:59 VK: Suppress VUID-vkCmdBindDescriptorSets-pDescriptorSets-01979 This validation is blocking the vulkan-deps roll. Suppressing until we fix the issue. Bug: chromium:1183542 Change-Id: I05ca95af8bcf77ddb70f01049e5cb07967420c25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727645 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 87b1875c 2021-03-01T19:17:35 Tests: Add Among Us trace Test: angle_perftests --gtest_filter="*among_us*" TBR: jmadill@google.com,timvp@google.com Bug: b/181616715 Bug: angleproject:5698 Change-Id: If52ee0e989c6b4a3c21b4a2bc0b77dbbea2a3d6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2728564 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Peng Huang 6b6da203 2021-03-02T00:22:36 Include a Makefile which contains some useful command lines Bug: angleproject:5697 Change-Id: I48c487d218183aa10823127beb40384f4debd6db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727921 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cody Northrop 3e017cfe 2021-02-26T15:37:41 Tests: Use context version from trace Test: Capture and replay ES 3.2 apps Bug: angleproject:5652 Change-Id: Ib46250acd8a50390f0cbd40853623cdf31bd0203 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698392 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 264eab21 2021-03-01T21:57:04 Roll vulkan-deps from 3ca55e802f5b to 64e40ae7572f (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3ca55e802f5b..64e40ae7572f Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/51d672b8a8..42ddfbd3d5 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/621884d709..d57ab68a21 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ef3290bbea..0bd920eb9d * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/1d99b835ec..c428484bc8 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4fdcd0eebf..bbe724bcf1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com,ynovikov@google.com Change-Id: I368f58c35d7407301ec33dda1360549c618dcb73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727870 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott 6af0c03f 2021-02-25T18:15:21 Vulkan: Always write to swapchain alpha channel This fixes an issue with the "Ragnarok M: Eternal Love" game, which uses a GL_RGB8 format for its window, which is actually backed by a GL_RGBA8 format (a.k.a. "emulated alpha"). The game does no explicit clear per frame. Therefore, ANGLE selects a render pass loadOp=DONT_CARE, which leaves the alpha channel undefined (0.0 on a Pixel 4 XL). That causes SurfaceFlinger to show (blend or alternate vsyncs) what should have been covered up by the game (e.g. the Android launcher and live wallpaper). The solution is to prevent loadOp=DONT_CARE for emulated alpha. Test: ClearTest.ChangeFramebufferAttachmentFromRGBAtoRGB Test: dEQP-GLES2.functional.fbo.render.stencil_clear.tex2d_rgb_stencil_index8 Bug: b/180139027 Change-Id: Ied97b57c93d41326cb3294ff246691e09f316791 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2704949 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Gert Wollny 79f24110 2021-02-12T09:36:18 build: Add -Wdeprecated-copy to the C++ build flags Define is_gcc and enable the warning flag if it is true. Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Bug: angleproject:4486 Change-Id: Ie3271cad5cd7de7b45a48d520eeadfe85e742254 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690954 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 5b82fa2e 2021-02-28T11:11:34 Suppress UNINSTANTIATED_PARAMETERIZED_TEST failures on Win AMD GTest complains that we don't run some tests on D3D/Vulkan backends. They only run on GL backend, which is disabled on Win AMD per http://anglebug.com/5123 Bug: chromium:1183147 Change-Id: I95fdd9a24aff69aa60e2f60613d8300ae1019a27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726576 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Gert Wollny fb7a2445 2021-02-12T09:29:11 libANGLE: Declare copy operator if copy constructor is defined If the copy constructor is defined then the copy assignment must also be defined, but we can use the default here. v2: Don't inline because the chromium-style errors out on this Bug: angleproject:4486 Change-Id: Iec0f63342244249da32b455b49a0b89b6558cab9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690953 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 0e11e49d 2021-03-01T10:01:22 Roll SwiftShader from 349abccec8f7 to 106e01583a3a (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/349abccec8f7..106e01583a3a 2021-02-26 noreply@google.com Support LLVM 11+ atomic instruction alignment change 2021-02-26 natsu@google.com Update PhysicalDevice::getProperties(<AHB properties>) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I5f83ed06d32f6e702e63ce8f4195b05697a1c7be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726141 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5030228a 2021-03-01T07:45:58 Roll Chromium from 61aec087e2f8 to 2a5fa9108962 (430 revisions) https://chromium.googlesource.com/chromium/src.git/+log/61aec087e2f8..2a5fa9108962 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3232c09f5a..ed3af53eea * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fd1ca3e65e..aa09fa7659 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/284ae5fcab..4138b13c16 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..df7850dcfe * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3f5eed8e80..b3546dc126 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Idb69c5794799d96f0d21b672d0c6bb443bd0cae1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727178 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop a6d46239 2021-01-25T11:40:47 Capture/Replay: Support CaptureGetQueryObject Test: Fortnite MEC Bug: b/180418810 Bug: angleproject:5658 Change-Id: Icc95faeebbe1fa850f25252c90a5ef8b68634ea0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2702153 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuly Novikov 4f639a7e 2021-02-27T17:36:25 Fix Ozone backend build flags. Broken by http://crrev.com/c/2405806 ANGLE_USE_GBM must be defined in Display.cpp, not just GL backend. This also requires depending on libdrm for its headers. Bug: angleproject:3943, chromium:1181952 Change-Id: I4650d7806435413184b36c820cc6d06992f7f5cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726575 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 73afaf1e 2021-02-26T18:08:08 Add EGL_WINDOW_BIT to all Ozone configs' EGL_SURFACE_TYPE Ozone's EGL windows are emulated, so we can always create one, thus setting EGL_WINDOW_BIT in all configs is safe. This is now required because in http://crrev.com/c/2378922 EGL_WINDOW_BIT becomes a requirement to be able to run tests. Previously Ozone's configs copied native EGL_SURFACE_TYPE, which was either 0 or having just EGL_PBUFFER_BIT. Bug: chromium:1181952, chromium:1034840 Change-Id: Ic2b14b43b3c32b47ea05d9d8da9fba7439f14d19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725273 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya c508e707 2021-02-25T15:40:11 Vulkan: Avoid using assign with BitSets FastIntegerSet::clear() now calls reset() instead of assign(). std::vector::assign(...) invokes the copy-constructor. For better performance, especially with BitSet*, we can leverage the reset() method. This removes 1.2% CPU overhead from a Manhattan30 offscreen run Bug: angleproject:5689 Change-Id: Ib1a760587ffe18341b8ed892a732c506fc50c82b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2723494 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shrek Shao 2b55f876 2021-01-29T18:02:21 Reland "Workaround for Mac Intel drawArraysInstanced with first > 0" This is a reland of 027bc47ca5b7b291fbda907173eefa05ad3d45a8 Original change's description: > Workaround for Mac Intel drawArraysInstanced with first > 0 > > Workaround by forcefully set instanced arrays (divisor > 0) > as streaming attributes and apply extra offset at front. Recover > those attribute bindings when first == 0 and other draw calls > (drawElementsInstanced) > > Bug: chromium:1144207, chromium:1144247, chromium:1144373 > Change-Id: Ie7836cc71b45a290513f34f90d49bd15b14ddba8 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2661095 > Commit-Queue: Shrek Shao <shrekshao@google.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: chromium:1144207 Bug: chromium:1144247 Bug: chromium:1144373 Bug: angleproject:5271 Change-Id: Id0b818b25a605376c98c2366c1f2029e2490c6cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2704799 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi da4aa8b8 2021-02-25T16:26:53 Vulkan: Move SPIR-V validation function to common/ For future use by the translator. Bug: angleproject:4889 Change-Id: I051ad48e6edb58ce3055c5fd276c18a6e29a66ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2717020 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 67333608 2021-02-25T14:15:33 Vulkan: Check texture type before calling into feedbackloop check In ContextVk::updateActiveTextures we end up calling this method shouldSwitchToReadOnlyDepthFeedbackLoopMode(...) for every active texture. Since color textures are more numerous than depth, check the texture type beforehand to decrease function stack depth. This removes 0.5% CPU overhead from a Manhattan30 offscreen run Bug: angleproject:5689 Change-Id: I14758b031e58b269392b4f450a5bb1ba8edabb44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2723493 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Mohan Maiya b5af8bde 2021-02-24T09:47:43 Vulkan: No need to unmap buffer when adding to mInFlightBuffers When we move a BufferHelper to the mInFlightBuffers list don't try to unmap it there, instead do that when it gets added to mBufferFreeList This removes 0.75% CPU overhead from a Manhattan30 offscreen run Bug: angleproject:5689 Change-Id: I01a52cdf4803fb8364140b01bedbd3d0e6cc61fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2723492 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Stephan Hartmann 46df78dc 2021-02-25T20:30:42 GCC: add missing static constexpr member definition C++14 requires to definition of static constexpr members to emit a linker symbol. Bug: chromium:819294 Change-Id: I06b7f1f7a6260982cf07a71c67295789c1f03084 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2720261 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Stephen White a476d16b 2021-02-24T12:58:56 Check that pixel store params are 0 for fastUnpack path on D3D. Bug: angleproject:5679 Change-Id: I4b4d0e2340592383e20849ad6be99c1608c048c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2716705 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Cody Northrop bdd1ac23 2021-02-25T16:31:25 Capture/Replay: Add CubeMapArray support Test: Recapture Lego Legacy: Heroes Unboxed Bug: angleproject:5685 Change-Id: I41a5ceb72724ab28ce3d57a85108d3dd806d976f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2721103 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuly Novikov f9c595b4 2021-02-26T11:53:30 Skip 3 SimpleStateChangeTestES31 DrawWithTextureThenDrawWithImage on Win Intel GL ClearThenSampleWithCompute on Linux AMD GL TransformFeedbackThenReadWithCompute on Win AMD Vulkan Bug: angleproject:5686, angleproject:5687, angleproject:5688 Change-Id: If380074389382bc7e9a8b8668c83fb9c8ef2084d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2723291 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Lubosz Sarnecki 4f07f9b8 2021-02-24T13:50:18 gles_ext_params: Implement CaptureGetTexLevelParameterivANGLE. As seen in CaptureGetTexParameteriv_params from capture_gles_2_0_params.cpp. Bug: angleproject:5645 Change-Id: Id687f73fd5d898e64e8a8bebe92ca50a0e096990 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2718044 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Drew Davenport 868a41e9 2021-02-17T11:34:22 Query revision id for GPU devices Add revisionID to GpuDeviceInfo and populate it through libpci. Bug: b/170372516 Change-Id: I0953ba5dfc7d973c7b7216d942952a3ffd908bcb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2703734 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki 33907625 2021-02-24T12:41:07 gl_angle_ext: Add param groups to glGetTexLevelParameterivANGLE. As seen in glGetTexLevelParameteriv from gl.xml. Bug: angleproject:5645 Change-Id: I1d8445f2178632b0edb0652e63984b31a1e34c48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2718043 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 97cbd0d9 2021-02-26T10:01:56 Roll vulkan-deps from 55434360b05d to 3ca55e802f5b (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/55434360b05d..3ca55e802f5b Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2e99822c14..51d672b8a8 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/521bc47360..4fdcd0eebf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I085620e36e5c84d516892d195c01ab85dfa104b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2721587 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll aacb8ccd 2021-02-26T10:01:51 Roll SwiftShader from 22186f076bf3 to 349abccec8f7 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/22186f076bf3..349abccec8f7 2021-02-24 sugoi@google.com Conditionally enable the XCB WSI extension 2021-02-24 sugoi@google.com Conditionally enable the Xlib WSI extension 2021-02-24 sugoi@google.com New mechanism to easily disable extensions 2021-02-24 capn@google.com Remove legacy optimization passes. 2021-02-24 amaiorano@google.com Kokoro: fix Windows builds to correctly use %BUILD_TYPE% 2021-02-24 amaiorano@google.com VulkanWrapper: fix failure to load headless surface extension If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I48c29492ee57ae8c3f78f83907baa23ed28a8b3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2721621 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 23462996 2021-02-26T09:24:47 Roll Chromium from b90646417bd3 to 61aec087e2f8 (994 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b90646417bd3..61aec087e2f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/72bbbc35a8..3232c09f5a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4c78ef9c38..fd1ca3e65e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/677f5aa5b0..284ae5fcab * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/4a1e66d2e5..800c09f4d7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9105610c5f * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/fa0de07678..7b4981b650 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cfd0f62809..6a9fd91d34 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bf8d1f051b..3f5eed8e80 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I7457b77e060711f84daea316ff054c9bbf468589 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2721429 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki d24398b3 2021-02-25T15:07:00 gl.xml: Annotate glDiscardFramebufferEXT with param groups. Remove tests from expectations list, as it now passes on SwiftShader for ES2 and ES3. Bug: angleproject:4401 Change-Id: If05b16e40632154a0ba2c22f1c3bf29e12113389 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2720259 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 77637f2d 2021-02-19T15:18:52 Vulkan: Generate xfb support code in SPIR-V for emulation path This change moves the code generation at link time from source code to SPIR-V. As a result, transform feedback extension and emulation paths are more similarly handled before SPIR-V transformation (they both store information identically in the ShaderInterfaceVariableInfoMap). This change gets rid of the @@ XFB-OUT @@ marker. With no source code generation at link time, shader compilation can be moved to glCompileShader time. Bug: angleproject:4888 Change-Id: I8cdb89c22b57ce48cf5d226b8e41622d9d550d46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2713269 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Ian Elliott b3fb450c 2021-02-22T17:22:28 Vulkan: Add GPU memory report and analysis documentation This information should be generally searchable and available. Bug: b/173636655 Change-Id: I5f8cad0f34f96c085ceea369d320863f20373c99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2714232 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Yuly Novikov d3cde02d 2021-02-24T16:50:35 Cleanup EGLMakeCurrentPerfTest instantiation Bug: angleproject:2735, chromium:1180570 Change-Id: Iddf97121c36a0e27bda5676212690574efe8a83d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2716613 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov ba233b6a 2021-02-25T13:44:32 Suppress 1 VulkanExternalImageTest on Linux AMD Vulkan VulkanExternalImageTest.TextureFormatCompatChromiumMutableNoStorageFd Bug: angleproject:5682 Change-Id: Id2aa15f4943f9132d133eeb540e35e405896a3b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2718530 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Lubosz Sarnecki 46a955f8 2021-02-25T16:06:05 gen_vk_internal_shaders: Don't include full path on Python 3.4+. Since Python 3.4 `__file__` represents an absolute file path: https://docs.python.org/3.4/whatsnew/3.4.html#other-language-changes We only want the basename in the generated scripts. Bug: angleproject:5516 Change-Id: Ia4009419ef627aa1ce12f9a944539c054edc3a6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2720260 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 9b1c569b 2021-02-24T11:32:39 Vulkan: Handle vertex count and primitive mode error cases in TS When handling tessellation shaders these 2 requirements need to be met - 1. TCS - vertex count should be declared at least once 2. TES - primitive mode should be declared at least once After translating TCS/TES check whether these requirements are met and error out if they are not. Bug: angleproject:5557 Test: dEQP-GLES31 - functional.shaders.linkage.es31.tessellation.varying.rules.unspecified_* KHR-GLES32 - core.tessellation_shader.compilation_and_linking_errors.te_lacking_primitive_mode_declaration Change-Id: I727d548ad446646bbece1fb78197639537b5f395 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2714465 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Mohan Maiya 550f2a3e 2021-02-24T09:49:42 Vulkan: Shader support for EXT_shader_framebuffer_fetch_non_coherent Translator can accept gl_LastFragData and 'inout' variable to gain access to framebuffer attachment data. The Vulkan translator replaces it with the SubpassInput type variable. Note that this works only for the noncoherent version of the extension. Bug: angleproject:5454 Test: *EXTShaderFramebufferFetchNoncoherent*.* Change-Id: I392f84ee3ad3eb9fbd09d0b7ff83731a9a3f33f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598060 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Shahbaz Youssefi 3013f27c 2021-02-23T22:37:42 Vulkan: Fix missing visibility barrier for glReadPixels glReadPixels uses a temporary buffer for readback and was missing an onBufferTransferWrite() call. Bug: angleproject:5669 Change-Id: I3c6daba176e332711fa1ab51e279526717486dd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2717005 Reviewed-by: Jie A Chen <jie.a.chen@intel.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 4a24786e 2021-02-23T23:32:48 Vulkan: Fix PBO read pixels with unaligned output pitch Vulkan takes the output pitch in texels instead of bytes in VkBufferImageCopy::bufferRowLength. This means that it's impossible to use vkCmdCopyImageToBuffer when the pitch is not a multiple of texel size. This change makes sure the fallback path is taken. Bug: angleproject:5667 Change-Id: I3f2ef312bb8288de8ca3c6730d85a3c14858812e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2717006 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 999da35e 2021-02-18T17:29:20 Vulkan: Optimize glMemoryBarrier more The implementation assumed that the X_BARRIER_BIT bits implied two barriers; write->X and X->write. However, they only imply write->X, with the exception of SHADER_IMAGE_ACCESS_BARRIER_BIT and SHADER_STORAGE_BARRIER_BIT which handle X->write for images and buffers respectively. As a result, the other bits no longer set the MEMORY_BARRIER dirty bit as they don't guard against X->write usage. Bug: angleproject:5070 Change-Id: Id23904c455a5f56dc45fc6832a74fdfbba6a4827 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705702 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 7ff605a5 2021-02-23T21:45:40 Capture/Replay: Fix compressed texture level caching Before this commit, the following sequence would cause an assert: glCompressedTexImage2D(GL_TEXTURE_2D, 0, GL_COMPRESSED_RGBA_ASTC_8x8, ...); glCompressedTexImage2D(GL_TEXTURE_2D, 1, GL_COMPRESSED_RGBA_ASTC_8x8, ...); This is due to code we added that clears the compressed texture cache when it detects we already have an entry for the texture level. This is allowed in GL, to respecify a texture level by simply calling glCompressedTexImage on it again. The problem is we would clear the entire texture from the cache, not just the level being respecified. Test: Recapture Asphalt 8 Bug: angleproject:5678 Change-Id: I473d6ea1cb8823bfec680ddd78c3457b93ecc431 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2716639 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop a833f200 2021-02-23T17:23:31 Docs: Update ANGLE trace creation steps Bug: angleproject:5677 Change-Id: I76ff3991f2124b27cd5c0cd9bad3754ae875cfc4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2717102 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Paul Thomson <paulthomson@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Amy Liu 49babcbc 2021-02-20T17:49:22 Fix crash of MultithreadingTest end2end tests. Extension platformANGLEContextVirtualization is currently only supported in the OpenGL backend, it's confused to validate it when the test is set up by WithNoVirtualContexts(). It'll generate crash when it's not OpenGL backend. Bug: angleproject:5636 Change-Id: Ib04fb4a3d29beaac5162e63af5ef1fd80c8a420c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2709821 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6623a70f 2021-02-19T17:28:10 Stubs for OpenCL entry points. Bug: angleproject:5653 Change-Id: I7ec9692a47be2556fef5bdd7630b422cc2d369b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2708343 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Lubosz Sarnecki 4a782eaf 2021-02-11T16:13:33 Remove redundant (c) from license headers. According to the Chromium C++ style guide, there must be no `(c)` after `Copyright`. Bug: angleproject:5516 Change-Id: Id5b170b99a1aaf95ab7fabb35ed644b99b756ce1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690948 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 9b9d683e 2021-02-24T10:02:40 Roll vulkan-deps from ca177df9b948 to 55434360b05d (16 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ca177df9b948..55434360b05d Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/e56beaee73..2e99822c14 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1b35745ad1..ef3290bbea * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4edde62bf0..521bc47360 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I363fe8f165cfbc38bd06c08284384c6674113c94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2717864 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 838fc2df 2021-02-24T08:02:08 Roll Chromium from d163fd7c6905 to b90646417bd3 (481 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d163fd7c6905..b90646417bd3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ac7b73c91d..72bbbc35a8 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/80d14c91e9..4c78ef9c38 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cadb271846..677f5aa5b0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..370c3d98a6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bf8c8f36a1..cfd0f62809 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/29685916ca..bf8d1f051b * tools/skia_goldctl/linux: ncanHC47RONr4iiaFn-Jh-KAhwJd11MQrAXp6Noh9x0C..FFNvbEArN40QplEcWmMIDG83rNyxP5fmhDHlHdE-Y94C * tools/skia_goldctl/win: lfHdYxTMV17X3ADPkkVY0dyrgWWuUv9zJhTPER5ocbcC..DpXABD34NuP5941cN5RRg-EPNqCxgt0lA_ga3KIZg4AC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ibd3819829738d7915fb34215974115d36d7a35e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2717686 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi d81e5d17 2021-02-18T16:02:35 Add a test for sample after deferred clear To ensure that deferred clears are flushed before sampling. Bug: angleproject:5070 Change-Id: I72bfef752074eb1e722c669edaa2d0b5ddfd20b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705027 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 39d7fc18 2021-02-17T00:18:41 Vulkan: Don't break the render pass on dispatch calls The only reason a dispatch call may need to break the render pass implicitly is for read-after-writes where the write originates from the render pass but is not through a storage buffer/image. There are only two such scenrios possible: - Framebuffer attachment write -> texture sample - Transform feedback write -> ubo read All other uses of the buffers and textures that require breaking the render pass are handled by `glMemoryBarrier`. Bug: angleproject:5070 Change-Id: I92b50d69d8782097ee8ff477ac57da6209c326a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698998 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 5d7f4e80 2021-02-18T17:06:12 Remove incorrect memory barrier tests The tests were written with the assumption that the X_BARRIER_BIT implied two barriers, write->X and X->write. However, they only imply write->X, with the exception of SHADER_IMAGE_ACCESS_BARRIER_BIT and SHADER_STORAGE_BARRIER_BIT which handle X->write for images and buffers respectively. Bug: angleproject:5070 Change-Id: Ic9bfac997d0663b70f1d40baca6c111a4dc300c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705701 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Lubosz Sarnecki 08bfc351 2021-02-11T17:22:57 Add Collabora, Ltd. to AUTHORS and CONTRIBUTORS This change adds Collabora, Ltd. to the AUTHORS file as described in the ContributingCode guide. Also adds Collabora, Ltd. and myself to CONTRIBUTORS. Bug: angleproject:5516 Change-Id: Ie24ef8ec01720d9d207d36c4a4c21fab96d08dcd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690949 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 016c5ff0 2021-02-23T11:34:30 Roll VK-GL-CTS from 1a524349f06b to 9cdde06fb38a (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/1a524349f06b..9cdde06fb38a 2021-02-23 alexander.galazin@arm.com Merge pull request #241 from enunes/gles2-EXT_texture_rg If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:5674 Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com Change-Id: Ie6e73c958321b224de7338c1bd5c3e7c719accb1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2714485 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi df0a92e6 2021-02-22T06:39:32 Assert valid when using SPIR-V ids Useful for debugging when an uninitialized id is used in the SPIR-V transformer. Bug: angleproject:4888 Change-Id: If446187a8a27a06f5958d5df5bc00d02e98d20e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2713268 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki 1330aa2c 2021-02-12T15:21:31 capture_replay_tests: Fix repository path retrieval. Use relation to retrieve angle repository path. The previous way of detecting the root repository folder failed to detect a correct path if the angle directory was in a path that contained the string angle. e.g. `/home/user/code/angle/angle` Other paths that would fail with the current implementation: `/home/user/my-angle-workspace/angle` `/home/tangled/workspace/angle/` `/home/user/code/angle-android` This way the path is constructed with the known relation of the script path inside the repository. Another advantage of this way is that the `angle` repository could be checked out with a different name. The disadvantage of this method is that whenever the script was moved, the relative path must be updated. Bug: angleproject:5645 Change-Id: I9a56aeba449b248273087382adceb0d6fba5a494 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2715323 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki 37752956 2021-02-11T16:12:48 Generators: Use fixed year in license headers. Remove dynamic year generation from generator scripts, as required by the Chromium C++ style guide. The dynamic year values were replaced by the current year at the time the file was created according to git log. The code to dynamically generate the year was removed. This patch also refreshes generated files and hashes. Bug: angleproject:5516 Change-Id: I735028bccb5c83217e92c380538f1abf0a906b2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690950 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 918b22df 2021-02-22T19:56:31 Remove old Win x64 bots from CQ win-angle-chromium-x64-try + win-angle-x64-try replace win-angle-rel-64 + win-angle-deqp-rel-64 Bug: angleproject:4483 Change-Id: I30145f15758b5e9ceac4bfaedf7566f909173f24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2713272 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 7b7e5cad 2021-02-19T13:46:06 Clean up entry point generation script. The main refactor from this change is to replace statements like this: decls, defs, export_defs, _, _, _, _ = get_entry_points( apis.EGL, eglxml.all_commands, egl_version_commands, False, egl_param_types, cmd_packed_egl_enums, EGL_PACKED_TYPES, egl_ep_to_object, TEMPLATE_EGL_ENTRY_POINT_EXPORT) With statements like this: eps = EGLEntryPoints(eglxml, egl_version_commands) This will make the script easier to maintain and extend. Bug: angleproject:5653 Change-Id: Ibd0930d45b8629702b7782f43a2d7ebfa4dac9b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705156 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll f19f319a 2021-02-23T10:01:00 Roll SwiftShader from d85a7a27b272 to 22186f076bf3 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/d85a7a27b272..22186f076bf3 2021-02-22 capn@google.com Remove color interpolation from image sampling benchmark 2021-02-22 capn@google.com Revert sampling parameter initialization workaround 2021-02-22 capn@google.com Eliminate stores succeeded by another store 2021-02-22 capn@google.com Implement propagation of stores to loads in single basic blocks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Id249f4e2fff10d900b9e31f65d01a2c3ee107214 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2714624 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0