kc3-lang/angle

Log

Author Commit Date CI Message
Jamie Madill ce22ad10 2021-06-18T15:23:11 infra: Add symbol_level=1 in Release. This should enable better crash file/line information. Bug: angleproject:6070 Change-Id: I54280461160f2ac6404dbd4b88abdcfd31f3814e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2971956 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 851fbedb 2021-06-10T21:27:01 Vulkan: Switch viewport and scissor to dynamic state Heavily based on http://crrev/c/1316888 Some apps are creating a large number of viewport combinations and are running out of graphics memory. This CL drops their graphics pipeline use from tens of thousands to tens. Performance testing shows little impact to application traces. Bug: b/190026813 Bug: angleproject:3143 Change-Id: Ib7415be1128f8fedae4a7ca72e067b2815201223 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954925 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Doug Horn 4e1fd371 2021-06-17T10:26:26 Ensure GLES1 state is cleared on context switch. GLES1 support in multi-context D3D mode is broken prior to this change as state in the GLES1Renderer is not being properly dirtied on context switch. The immediate result is a crash on draw commands due to a null program. Introduce a new dirty bit to specify that the program is dirty and should be re-initialized. Test: GLES1 applications work with the D3D11 backend in multi-context mode. Bug: b/191158936 Change-Id: Ib53c1471514ff2cf36ef9fc0d6bfb99a8bb7cf66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2969789 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Doug Horn <doughorn@google.com>
angle-autoroll d5e86bb0 2021-06-18T10:01:57 Roll SwiftShader from 84bc198202e5 to 4a304244dd86 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/84bc198202e5..4a304244dd86 2021-06-18 mikko.tiusanen@siru.fi Skip wait on already signalled timeline semaphore 2021-06-18 jari.komppa@siru.fi Remove assert to enable indexless access chains 2021-06-17 sugoi@google.com Increase maximum framebuffer size 2021-06-17 pkasting@chromium.org Fix -Wdeprecated-copy. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Id4f71546f99ca3633a7f9a6c02354a25d6cb148d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2970673 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 910fce1a 2021-06-18T10:01:36 Roll vulkan-deps from 7304bd043edc to 65149e19efd9 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7304bd043edc..65149e19efd9 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/71612a7e5d..b38100f6bc * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/bcf55210f1..07f259e68a * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4d22f58a81..bcef913745 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ec76459d6f..a680671d95 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ae3d0c3217..16db450293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Idae09b2ee1e3a631391cdcf813cccc131fc54d60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2970618 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f6efb013 2021-06-18T07:00:23 Roll Chromium from 681ec5b77d1d to 4c77f83b612d (360 revisions) https://chromium.googlesource.com/chromium/src.git/+log/681ec5b77d1d..4c77f83b612d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8a2885963d..11f1e3d2cd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b97bee9f24..965c815e32 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/816daa2545..ea5c2c2838 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2573cff725 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/74ef838a40..59140d436a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/66b4484319..0e774456f5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/657824459c..a61c45df6b No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ic1e6b2b37b1fa47508d8623e276bdeb3395602a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2970925 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 24155b13 2021-06-17T18:09:29 Vulkan: Free DynamicBuffer buffers after dip in allocation size In a pattern like this: - allocate 100 bytes - allocate 200 bytes - allocate 50 bytes - allocate 100000000 bytes - allocate 100 bytes - allocate 200 bytes - allocate 50 bytes The DynamicBuffer class switches to making 100MB allocations even if that allocation was a one-off. A small future allocation would then tie up 100MB in memory for future allocations. Another 100MB is also left tied up in the free list. With this change, if an allocation is made that's less than a quarter of the DynamicBuffer's current allocation size, it's taken as a sign that the previous large allocation was a one-off and the size is moved back to the DynamicBuffer's original initial size. Bug: b/187757166 Change-Id: I0c6f00eec7c81298f9dc41a41cc308510ce76623 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2971004 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
John Plate 69562546 2021-06-11T19:12:11 CL: Refactor info structs and fix conformance bug - Remove variable name prefix from Info structs to be more consistent with other ANGLE structs. - Fix CL object validation check with magics, since the Mesa solution doesn't work without RTTI. - Add support for some extensions required by OpenCL 1.1 and for some optional extensions. - Fix more conformance bugs. Bug: angleproject:6015 Change-Id: I41b1c45d95059a9994f5dc78bf9b74476cc6f2d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2956349 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang dc334829 2021-06-17T10:37:56 Disable ANGLE's VK backend on official Chrome Android builds. ANGLE's VK backend induces a memory and binary size regression due to global initializers in glslang/spirvtools. Disable it on Android Chrome official builds. Bug: chromium:1172451 Change-Id: I08d77cf11e20b393c0faf7c85d08c92061e5a09b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2969385 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 97fca0c6 2021-06-17T10:01:36 Roll vulkan-deps from 734228fd0093 to 7304bd043edc (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/734228fd0093..7304bd043edc Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a23e143636..71612a7e5d * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/f1f5bdbd1b..ec76459d6f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/adb3eb0e78..ae3d0c3217 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I2f4effc6a35486f3eaa7440486ba0ee4ea08bc51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2967886 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cc0dabfd 2021-06-17T10:01:56 Roll SwiftShader from 72e6254a135d to 84bc198202e5 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/72e6254a135d..84bc198202e5 2021-06-16 capn@google.com Disable -warn-stack-size for LLVM older than version 12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ia9f7162c121a6e6aa9698c4a24c9423f9d280de3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2968203 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 82038dc4 2021-06-17T09:16:13 Roll Chromium from 3b095d2c5438 to 681ec5b77d1d (186 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3b095d2c5438..681ec5b77d1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9ccd2d2400..8a2885963d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/be7dcbc361..466954eda3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/701dca6ebd..b97bee9f24 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a21dc91204 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/592d5ec077..74ef838a40 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/71b29b465c..27f119ee39 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9a55c7fe60..657824459c No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: If172aad9f25a34b034312b0c03dbf8f2adefe264 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2967885 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott f89f244d 2021-06-16T13:03:20 Doc: Add component info for filing Chromium bugs Bug: None Change-Id: I7b8517e2312174a2e2b9221b7c99425978406024 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2966011 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
angle-autoroll be741569 2021-06-16T21:53:12 Roll Chromium from b136d87fc6ad to 3b095d2c5438 (90 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b136d87fc6ad..3b095d2c5438 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/94441aacf6..9ccd2d2400 * buildtools/linux64: git_revision:72d5a6e15d868abc8451fe0a3b6596e86a2ffc40..git_revision:d2dce7523036ed7c55fbb8d2f272ab3720d5cf34 * buildtools/mac: git_revision:72d5a6e15d868abc8451fe0a3b6596e86a2ffc40..git_revision:d2dce7523036ed7c55fbb8d2f272ab3720d5cf34 * buildtools/win: git_revision:72d5a6e15d868abc8451fe0a3b6596e86a2ffc40..git_revision:d2dce7523036ed7c55fbb8d2f272ab3720d5cf34 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cbc508d9f5..701dca6ebd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..70bf08ecdb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/73cc951f87..9a55c7fe60 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I24a6d338b014c61d5b872af2d7a7a889759d8128 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965335 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott ecf27c71 2021-06-16T13:13:31 GL: Fix bug with: Skip redundant flushes. The ANGLE-into-Skia autoroller is blocked because of the following CL: https://chromium-review.googlesource.com/c/angle/angle/+/2956453 Michael Ludwig, a Skia engineer, found that this change fixes the problem and will unblock the auto-roller. Bug: chromium:1181068 Change-Id: I514b2762f6643e25b36aab0290a57af4abf3c660 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965615 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Mohan Maiya b77a6c25 2021-06-16T11:01:14 Vulkan: Avoid using VK_WHOLE_SIZE when using dynamic offsets Binding descriptor sets that use VK_WHOLE_SIZE with a dynamic offset results in the VUID-vkCmdBindDescriptorSets-pDescriptorSets-01979 validation error. Updated the updateDefaultUniformsDescriptorSet function to use the uniform's size instead of using VK_WHOLE_SIZE. Bug: angleproject:5924 Tests: dEQP-GLES31.functional.shaders.multisample_interpolation.* SimpleStateChangeTest.UniformUpdateTest*Vulkan UniformTestES3.MatrixUniformUpload*Vulkan Change-Id: Ie4633af61d59a9401f599d336a5b9040cdf18004 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950309 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 33b5ff4c 2021-06-16T18:59:22 Roll Chromium from 2d9121fa2280 to b136d87fc6ad (70 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2d9121fa2280..b136d87fc6ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1c1a1626e9..cbc508d9f5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..70bf08ecdb * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e319aba2ba..592d5ec077 * third_party/r8: o1uegxayAMktc600LZ1gX5ZzkC_qhU-frNcWJfmBg98C..gXyBDv_fM87KnLcxvF5AGV5lwnm-JXIALYH8zrzdoaMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4d45e0aeb2..66b4484319 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b6e0ed244f..71b29b465c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1337efa12c..73cc951f87 Clang version changed llvmorg-13-init-12576-g643b6407:llvmorg-13-init-12881-g4017d033 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/4d45e0aeb2eb02a24c60048b11de5d65b87d0c73..66b4484319f05867883d6f59f86fbf5cb07b0099/scripts/update.py Bug: None Tbr: ianelliott@google.com Change-Id: I1dc772e81192999b7c3776d20cf080a3aa722c3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965334 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Tim Van Patten 3707b01f 2021-06-16T09:43:39 Be more specific when deleting unused third_party/ dirs The command to delete unused third_party/ directories needs to be more specific to delete unused third_party/vulkan-deps/ directories. Additionally, use the flag '-path', since that's more portable than '-wholename' which is GNU-specific. Bug: b/187342779 Change-Id: Ie8b02360d0d86f9b42141212aaa6c2aa27a063c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965605 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 99a98963 2021-06-10T16:11:13 Vulkan: SPIR-V Gen: Support discard This is simply done with OpKill. If-else blocks now check if the block is already terminated (through return, discard, continue or break) before adding the branch to merge block. Bug: angleproject:4889 Change-Id: I713286cf38e40f9048486d2914a4355ddbc686ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953369 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 1529a30c 2021-06-16T16:37:52 Roll VK-GL-CTS from 7f2ec8531b64 to 7329723d8103 (10 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7f2ec8531b64..7329723d8103 2021-06-16 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master 2021-06-16 antto.makinen@siru.fi Add a GraphicsFuzz test 2021-06-16 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2021-06-16 rgarcia@igalia.com Skip unsupported allocations in invariance test 2021-06-15 jbolz@nvidia.com Subgroup and workgroup reconvergence tests. 2021-06-15 alanbaker@google.com Tests for VK_KHR_shader_subgroup_uniform_control_flow 2021-06-15 alexander.galazin@arm.com Update glslang, SPIR-V Tools and headers 2021-06-14 antto.makinen@siru.fi Shared memory layout tests 2021-06-11 siglesias@igalia.com Add VK_FORMAT_B10G11R11_UFLOAT_PACK32 vertex input tests 2021-06-11 rgarcia@igalia.com Test null fragment shading rate attachment pointers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ianelliott@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com,angle-bots+autoroll-info@google.com Change-Id: I3bc22f404b4822410248fa9c9a63e35d1a8ff900 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2966861 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 350ca026 2021-06-16T15:18:18 Roll Chromium from a47f97f33178 to 2d9121fa2280 (292 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a47f97f33178..2d9121fa2280 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bc2162111e..94441aacf6 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/6c2969375e..f4328ad7c0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2dac35d518..1c1a1626e9 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/bd17c406ba..8f8817d6f6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6434229377 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ecdc362593..e319aba2ba * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c6949cb1f9..4d45e0aeb2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f463e5ab39..b6e0ed244f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f059cd2376..1337efa12c No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ibb6ea3b03d3459b67468a21a304a1504508df0e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2964191 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 9c500951 2021-06-10T15:48:57 Vulkan: SPIR-V Gen: Fix user-defined blocks The _u prefix was missing from blocks and their fields. Bug: angleproject:4889 Change-Id: I31f3b393bc81352c8cf7a433dd652692833fc3f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953368 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 5a737833 2021-06-10T15:19:59 Vulkan: SPIR-V Gen: Fix row-major matrices Prior to this change, row-major and column-major matrices generated different types. That is not correct. With this change, the same type is generated for both. Row-major only comes into account when calculating the alignment and offset of fields in a block. Bug: angleproject:4889 Change-Id: Ifa03e1799a2510b90323d9d4fc2f681a3184069b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953367 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 74c6c144 2021-06-16T10:01:57 Roll SwiftShader from 9559e5836cc1 to 72e6254a135d (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/9559e5836cc1..72e6254a135d 2021-06-15 capn@google.com Regres: Fix testing external contributions if reviewed by Googler If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Idfa3c5889ed8df3f1fb98d54f4839e8f9280f5f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2963848 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b27c596b 2021-06-16T10:01:36 Roll vulkan-deps from f43437ab3f52 to 734228fd0093 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f43437ab3f52..734228fd0093 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b848fd6a94..a23e143636 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ecdd9a3e6b..4d22f58a81 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/7501ad708e..f1f5bdbd1b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/dafb955601..adb3eb0e78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I859d7377d0e5ed650e315b9f9963555ba4d19b94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965287 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi e48f2210 2021-06-10T13:23:34 Vulkan: SPIR-V Gen: Support short-circuiting && and || When short-circuiting is necessary (because the right-hand side has side effects), the following code is generated in SPIR-V: // For left && right: result = left if (left) result = right // For left || right: result = left if (!left) result = right Bug: angleproject:4889 Change-Id: Id87b56dc4a1463ed781852a23d2ba6eb2015d700 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953366 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi a76f224f 2021-06-16T00:43:55 Fix build Two CLs went in at the same time, causing a build breakage. Bug: angleproject:4889 Change-Id: I0dacda7263959014fb4ad9bd83733f58a5e98fe6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965319 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: John Plate <jplate@google.com>
angle-autoroll 9b92aa56 2021-06-16T03:42:27 Roll Chromium from a4467e2bcd67 to a47f97f33178 (736 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a4467e2bcd67..a47f97f33178 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b59724c60a..bc2162111e * buildtools/linux64: git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c..git_revision:72d5a6e15d868abc8451fe0a3b6596e86a2ffc40 * buildtools/mac: git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c..git_revision:72d5a6e15d868abc8451fe0a3b6596e86a2ffc40 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e5f25a39b9..6c2969375e * buildtools/win: git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c..git_revision:72d5a6e15d868abc8451fe0a3b6596e86a2ffc40 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3c85e0a05c..2dac35d518 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/fa47598982..9f92effa4e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1f843f3975 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ef579a1192..ecdc362593 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/174c500478..cb29a121b4 * third_party/r8: gXyBDv_fM87KnLcxvF5AGV5lwnm-JXIALYH8zrzdoaMC..o1uegxayAMktc600LZ1gX5ZzkC_qhU-frNcWJfmBg98C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/aee8160f9a..c6949cb1f9 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4c1cd5039e..f463e5ab39 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3205ddf75e..f059cd2376 No update to Clang. Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: If34b372383f4415cfbf635cf05c5cfddb089d4c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965789 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 8b869a95 2021-06-13T01:09:27 Translator: Generate Ops for all built-in functions EOpCallBuiltInFunction is removed in this change, as well as the "op": "auto" property in builtin_function_declarations.txt. Instead, gen_builtin_symbols.py automatically generates Ops for every built-in function and generates the TOperator enum accordingly. This simplifies SPIR-V code generation by allowing switches to be used on operators instead of string comparisons. Bug: angleproject:4589 Bug: angleproject:4889 Change-Id: Ia351524400b0e12a10a5572e27e9b88c6ec2e61c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2958869 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 64ca25f1 2021-06-08T17:15:49 Vulkan: SPIR-V Gen: Unary operators The line raster emulation coded uses round() which was previously not translated. This change implements all operations supported by TIntermUnary nodes. Bresenham line emulation is now allowed. Bug: angleproject:4889 Change-Id: I1ffbe3f9bf0299f7efa2c6d1e8f011fefdbb2ddb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2951624 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 0297779c 2021-06-08T01:06:21 Vulkan: SPIR-V Gen: Handle invariant variables The Invariant decoration is applied to variable declarations and block members as necessary. When invariant is applied to a gl_PerVertex built-in, it's applied to the appropriate member in DeclarePerVertexBlocks. Bug: angleproject:4889 Change-Id: Idaa8d4ab92f975381a0237d372f0a4044ff983e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946116 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Peter Kasting f33a41be 2021-06-15T16:59:57 Another fix for -Wc++11-narrowing. Bug: chromium:1216696 Change-Id: I65955fe818917a1909c3d1af391718aaa82652bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965535 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 3f9dcb00 2021-06-12T01:37:32 Translator: Prune trivial dead code Code after discard, return, break and continue is discarded with this change. This simplifies SPIR-V generation as no code is allowed after a branch instruction and no special handling is necessary after this change. Bug: angleproject:4889 Change-Id: Ife9c8de8a6d0db9d682561daf44366aad9b1cf61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2957811 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Dirk Pranke 3824f2ad 2021-06-15T10:47:47 Set gclient arg to not generate location tags. This updates ANGLE to handle a Chromium //DEPS change from https://crrev.com/c/2957335; there is a way to generate component and file location metadata using `dirmd` in chromium test isolates, but we don't currently want to use this in ANGLE. This change updates the ANGLE DEPS file to propagate the right gclient variable into the gclient_gn_args_file so that the build continues to work. Bug: chromium:1218056 Change-Id: I0b27e08d3b7b35a17ba7dca6b6e032175637e8ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2963837 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com>
Peter Kasting e62195c9 2021-06-15T10:48:49 Fix another -Wc++11-narrowing issue. Bug: chromium:1216696 Change-Id: I18ceae2d6bdd689830fafbfd12b1185c680f2e33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965192 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi a1d43971 2021-06-12T23:11:48 Translator: Pack TSymbol and TFunction fields Shaves ~45KB off of binary size in an ANGLE build on Linux, coming from the built-in TVariable and TFunction variables. Bug: angleproject:4889 Change-Id: I5466c9e26b069a07bf52d00fc2a9c5d49f3c0feb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2958868 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 18ddd131 2021-06-07T14:59:43 Vulkan: SPIR-V Gen: Support mediump/lowp The mediump and lowp precisions translate to a RelaxedPrecision decoration in SPIR-V. This change implements this decoration and enables SPIR-V generation when emulating Bresenham lines. Prior to this change, Bresenham line emulation resulted in a validation error due to the vertex shader output being without RelaxedPrecision but the fragment shader input (translated by glslang) with it. The function that produces a new id is given a list of decorations to apply, which itself is automatically deriven from the TType where applicable, to minimize the risk of any id missing this decoration. Bug: angleproject:4889 Change-Id: I30cc5a278634c5d83d63cd65b057336f9f573baa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946113 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 33aa7ef0 2021-06-15T10:01:36 Roll vulkan-deps from 0edfab1c0897 to f43437ab3f52 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0edfab1c0897..f43437ab3f52 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/fe15158676..b848fd6a94 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/53231a96c0..7501ad708e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b82d4bc692..dafb955601 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I2101dc30e15183595ad879029509a3173557d1ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2962280 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi af1eed2e 2021-06-10T01:55:59 Vulkan: Generate gl_FragColor/Data declarations in AST gl_FragColor and gl_FragData are not available in Vulkan. Prior to this change, their declaration as webgl_FragColor and webgl_FragData was done in text. This change implements an AST transformation that declares a normal fragment output variable and replaces all references to these built-ins with those variables. Bug: angleproject:4889 Change-Id: If224e089dec25e4aa580beb135e1be2890de7887 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953042 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexis Hetu 4fbb6f43 2021-06-14T18:20:06 Vulkan: Fix accessing index buffer with uninitialized memory This was discovered by Clusterfuzz on MacOS. The issue was that is index buffer of a draw indexed call was missing, causing SwiftShader to access uninitialized memory, leading to the ASAN crash. The missing index buffer was caused by DIRTY_BIT_INDEX_BUFFER not being set. This was in turn caused by ContextVk::flushDirtyGraphicsRenderPass() not setting dirty bits not included in the dirtyBitMask, despite needing to be set for future processing. Bug: chromium:1183068 Bug: chromium:1190493 Change-Id: I65b398d8737b3df5fd51a03a2c8074a774a94a81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2961690 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 8333d061 2021-06-14T11:01:35 GL: Respect TexSubImage upload limits for robust init The chunked_texture_upload splits texture uploads for glTexSubImage calls but ANGLE uses glTexSubImage internally for robust resource initialization. Also chunk those uploads. Bug: chromium:1181068 Change-Id: Ia6eaac8117173946630f420b396cbc54c163b7ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2961230 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Tim Van Patten c40262dc 2021-06-10T17:27:45 Remove unused third_party/ deps from Android checkin Remove unused third_party/ deps from the Android checkins to reduce the license burden from unused libraries. Bug: b/187342779 Change-Id: I87358377d0dbbc644cb85555464f4afad9d5c333 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954924 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Tim Van Patten 7b14e506 2021-06-10T14:13:41 Rename ANGLE APK label to: com.android.angle Rename the ANGLE APK to com.android.angle, since ANGLE is a headless APK. Bug: b/184757175 Change-Id: I8aae318a1882ee1b55e495b053374c9ebdecb94b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953509 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
John Plate 2c8d9a9a 2021-06-09T16:09:35 CL: Remaining functions for OpenCL 1.2 Add support for the remaining functions for OpenCL 1.2 for the front end and pass-through back end. Also fix several bugs discovered by the conformance tests. Bug: angleproject:6015 Change-Id: I1dca1c3f4c1d9aea7f0501094c171116ea01381f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954259 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: John Plate <jplate@google.com>
angle-autoroll 88631e50 2021-06-14T10:01:36 Roll vulkan-deps from 7e098c965711 to 0edfab1c0897 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7e098c965711..0edfab1c0897 Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/07c4a37bcf..9d10a96f2d * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1021540dc2..53231a96c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I654e9265e8050316c8565fe27993e8c5966d6bf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2959019 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3aea00c8 2021-06-14T07:00:53 Roll Chromium from 5aaab2e1ec76 to a4467e2bcd67 (434 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5aaab2e1ec76..a4467e2bcd67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/eb4ebdf32c..b59724c60a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c1cef4e23c..be7dcbc361 * buildtools/linux64: git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa..git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c * buildtools/mac: git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa..git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c * buildtools/win: git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa..git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2438adcd35..3c85e0a05c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2f46970950 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e5d455cca7..ef579a1192 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fd14318cc9..aee8160f9a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/de888be9c5..4c1cd5039e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cd44a3b1ea..3205ddf75e Clang version changed llvmorg-13-init-12491-g055770d5:llvmorg-13-init-12576-g643b6407 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/fd14318cc948b67e5ec8a0f2f7563142ccd6dac2..aee8160f9ac4d833283a35f1088f94c17d523a16/scripts/update.py Bug: angleproject:4841 Tbr: syoussefi@google.com Change-Id: If2031c2773a3bc6a0c5d52f0177329397b18191e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2959016 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 222a81cf 2021-06-11T14:34:52 Reland: GL: Skip redundant flushes. Skip flushes when there is no work submitted since the last flush. Bug: chromium:1181068 Change-Id: Iab31f8949f7eb07dffb7b0930069cbb3ca69ef57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2956453 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Ian Elliott ebf75698 2021-06-10T18:55:04 Vulkan: Fix AGI clear hierarchy bug for clear commands This approach properly handles outside-render-pass clears. Bug: b/190622922 Change-Id: Ia4a9d6ec13d7da8c4a445af1127e82c03f37e8b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2951960 Reviewed-by: Mark Lobodzinski <mark@lunarg.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
angle-autoroll bc913c70 2021-06-11T10:01:36 Roll vulkan-deps from d19e20ee6d7d to 7e098c965711 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/d19e20ee6d7d..7e098c965711 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bbc660edab..ecdd9a3e6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I6fe973a3d143e05ddfece8d845627ed7c1c4c7bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954709 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a4fa7a66 2021-06-11T10:01:57 Roll SwiftShader from 81ba5f47b66c to 9559e5836cc1 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/81ba5f47b66c..9559e5836cc1 2021-06-10 nicolascapens@google.com Revert "Remove git submodules before rolling into Android" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I0752c72acb33ef73bbd4162dff753f35d23fbd12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2955222 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
John Plate 55df3ec1 2021-06-08T18:57:15 CL: Add remaining enqueue commands Add support for remaining OpenCL 1.2 enqueue commands to front end and pass-through back end. Bug: angleproject:6015 Change-Id: Iab650e42d51e2105dc826088d3606c56d5cd0fd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2944966 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: John Plate <jplate@google.com>
angle-autoroll 5e5d17cd 2021-06-11T07:00:39 Roll Chromium from 399855f4bba6 to 5aaab2e1ec76 (226 revisions) https://chromium.googlesource.com/chromium/src.git/+log/399855f4bba6..5aaab2e1ec76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2192a63c23..eb4ebdf32c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9d8449e380..c1cef4e23c * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/2c53623d59..e5f25a39b9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ab567bcc84..2438adcd35 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2f46970950 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6d099d543d..e5d455cca7 * tools/luci-go: git_revision:725192cc79f07ea946e10a64baac06625c206968..git_revision:2adc53281f4a72ecb71e84a8af5acc0fced04cc9 * tools/luci-go: git_revision:725192cc79f07ea946e10a64baac06625c206968..git_revision:2adc53281f4a72ecb71e84a8af5acc0fced04cc9 * tools/luci-go: git_revision:725192cc79f07ea946e10a64baac06625c206968..git_revision:2adc53281f4a72ecb71e84a8af5acc0fced04cc9 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/12c8fa872b..de888be9c5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2e6477d751..cd44a3b1ea No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I692a13429e5eda59471aa2197beb185cdf1f9113 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2955399 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov c7c3cac0 2021-06-09T15:05:17 Add Android chromium.angle bots to CQ Bug: angleproject:4483 Change-Id: I5a2d76bb9f5183752cbcd6f9381c4aef83edecd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950267 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Ian Elliott 1fcbf77c 2021-06-10T16:02:31 Vulkan: Fix AGI hierarchy for query commands Treat glBeginQuery* and glEndQuery* commands the same as glDraw* commands, generating a hierarchy. This results in vkCmdBeginQuery and vkCmdEndQuery commands being nested under gl*Query*, instead of being a peer of glDraw* commands. This change necessitated plumbing some of the existing "end" path to return angle::Result. Bug: b/190512191 Change-Id: I898d3fdd9b4b7d86e76dfae2ffc5d6f7316a55ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950926 Reviewed-by: Mark Lobodzinski <mark@lunarg.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 29227eef 2021-06-05T22:25:01 Vulkan: SPIR-V Gen: Specialization constants With specialization constant qualifier and ids set in the node types, the SPIR-V generation for these variables are trivially handled. This is in preparation for enabling line raster emulation as well as fragment shaders in general. Bug: angleproject:4889 Change-Id: Ie4d4e47b222ac66d1e0eee29f55ac09990313580 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939337 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Yuly Novikov 166dd0c7 2021-06-10T16:09:01 Roll chromium_revision 6c5859c895..399855f4bb (890175:891326) Manual changes: 1. Fix generate_test_spec_json.py to correctly handle ADDITIONAL_MIXINS Needed after angle_skia_gold_test mixin removed from Chromium in crrev.com/890333 2. Copy third_party/logdog from Chromium Needed after crrev.com/890539 in order to create isolates on Android and for tools/perf/process_perf_results.py Change log: https://chromium.googlesource.com/chromium/src/+log/6c5859c895..399855f4bb Full diff: https://chromium.googlesource.com/chromium/src/+/6c5859c895..399855f4bb Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8870cb4120..2192a63c23 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c793cca886..9d8449e380 * buildtools/linux64: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa * buildtools/mac: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/7e3b76855b..2c53623d59 * buildtools/win: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a62f8260df..ab567bcc84 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7949d87093..bd17c406ba * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/887e8d9009..fa47598982 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/1cfc90728e..816daa2545 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..17cf72ca75 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b508ecd932..6d099d543d * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/19f3fad68d..e9be5fd6d7 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/82f8803671..f4241bd0f2 * third_party/turbine: _iPtB_ThhxlMOt2TsYqVppwriEEn0mp-NUNRwDwYLUAC..Om6yIEXgJxuqghErK29h9RcMH6VaymMbxwScwXmcN6EC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/09481f56be..fd14318cc9 * tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968 * tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968 * tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/94630dfc19..12c8fa872b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5c84710692..2e6477d751 DEPS diff: https://chromium.googlesource.com/chromium/src/+/6c5859c895..399855f4bb/DEPS Clang version changed llvmorg-13-init-11999-g50c0aaed:llvmorg-13-init-12491-g055770d5 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/09481f56be7b1bbaf5a466be5d81691902825fcf..fd14318cc948b67e5ec8a0f2f7563142ccd6dac2/scripts/update.py Bug: angleproject:4483, angleproject:6037 Change-Id: I9035126bce55642d4dfce54eeace85093bdd1782 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954241 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi ac704c80 2021-06-10T17:51:07 Roll VK-GL-CTS from d17a353c6cd4 to 7f2ec8531b64 (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/d17a353c6cd4..7f2ec8531b64 2021-06-10 siglesias@igalia.com Check resource limits properly 2021-06-10 rgarcia@igalia.com Capture early errors on instance creation 2021-06-10 ilkka.saarelainen@siru.fi Add depth execution mode tests 2021-06-10 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-06-09 rgarcia@igalia.com Test instance matrix update after command recording 2021-06-09 rgarcia@igalia.com Test null miss shader group handles work 2021-06-09 rgarcia@igalia.com Test tracing rays from inside AABBs 2021-06-09 siglesias@igalia.com Fix wait semaphore count value 2021-06-09 marcin.kantoch@amd.com Fix internal error for fragment stage in RT tests 2021-06-09 alexander.galazin@arm.com Add GL_ARB_separate_shader_objects requirement 2021-06-09 alexander.galazin@arm.com Raise glsl version to 420 for compute shaders 2021-06-09 alexander.galazin@arm.com Raise glsl version to 410 core for shaders with GL_ARB_shader_atomic_counters 2021-06-09 alexander.galazin@arm.com Remove shaders.switch from the Khronos mustpasses 2021-06-07 zzyiwei@google.com Add a test for VK_EXT_global_priority_query 2021-06-07 alexander.galazin@arm.com Update Vulkan headers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC syoussefi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com,angle-bots+autoroll-info@google.com Change-Id: Iac5faae807430cb114617f77543768ea6047f3a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953060 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 31641b8e 2021-06-05T02:17:47 Declare specialization constants in the AST A new qualifier (EvqSpecConst) is added so that specialization constants can be declared in tree. This enables TVariable references to specialization constants to be validated, which were in fact invalid as every reference declared a new variable. That is fixed. Bug: angleproject:4889 Change-Id: I1711e41cbc5a1260843d2d004d3568bdae11e963 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2941451 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
John Plate 82654e5d 2021-06-06T15:46:53 CL: Add program build commands Add program build commands to front end and pass-through back end. Bug: angleproject:6015 Change-Id: I1175646d35ff050796b718d7f0e269520292b319 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940839 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 5fd72bd3 2021-06-10T11:22:26 Use Chromium mirror of tools/perf. This will keep ANGLE in sync with Chromium changes and reduce the maintenance burden. Bug: angleproject:6037 Change-Id: Ibed4031d8cb3468e6be6501bda21404c42fb2be6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953043 Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
John Plate 2e772e04 2021-06-04T14:01:42 CL: Add image enqueue commands Add image enqueue commands to front end and pass-through back end. Bug: angleproject:6015 Change-Id: I133e84020975679fafd29432c965cd19f086d2b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940837 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
Sergey Ulanov c670917c 2021-06-02T14:43:03 [Fuchsia] Cleanup vulkan_fuchsia_ext.h Removed defintions of fuchsia-specific vulkan types from vulkan_fuchsia_ext.h . Instead, the types provided by vulkan_fuchsia.h are used now. Also re-enabled vulkan validation on Fuchsia. Bug: chromium:1215736 Change-Id: I795347b7fb61d90033749533cefd42cf180730fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2934718 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 9b142b64 2021-06-10T10:01:36 Roll vulkan-deps from 4d0e65d25f37 to d19e20ee6d7d (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4d0e65d25f37..d19e20ee6d7d Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/3d935ea224..fe15158676 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d07505c761..bbc660edab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ic216efdfdd40d3bafd3f74c3494400592aa3abb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950831 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2a42e869 2021-06-10T10:01:56 Roll SwiftShader from 5ecc95a00e2b to 81ba5f47b66c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/5ecc95a00e2b..81ba5f47b66c 2021-06-10 srisser@google.com Prevent BC6h decoder from using global constructor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ie5c73bca485ecc3809c0b1f9a7d73082f400b86f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2952621 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny eb882040 2021-06-08T11:17:59 test/ImageTest: Clear back buffer when test cleanup Many tests don't actually use the back buffer, so uninitialized data is used when capturing leading to failure. Hence, clear the back buffer when the test ends and before swap is called triggering the capture. Bug: angleproject:6035 Change-Id: I0a500ae9f5203feaf0b492dc18e84c5a92ee1497 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2944953 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Shahbaz Youssefi d769742c 2021-06-03T19:43:58 Vulkan: SPIR-V Gen: Default uniforms Default uniforms are gathered in a uniform block, so treat them like other nameless uniform block fields. Bug: angleproject:4889 Change-Id: If340040ab4c59f3243c40de7daba530b2289e147 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939333 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7108e069 2021-06-08T09:55:11 Roll Chromium from 3bcc8fd7c291 to 6c5859c895f5 (510 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3bcc8fd7c291..6c5859c895f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e353b02625..8870cb4120 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0b443d31ef..c793cca886 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a45949a818..a62f8260df * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/42884eb2ac..887e8d9009 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d598390f02 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a5b6b2f8b7..b508ecd932 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/9523daa51d..82f8803671 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0c64e8349d..09481f56be * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d5d794a9f5..94630dfc19 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/71214b910d..84ad259424 No update to Clang. Manually added tools/android/modularization/convenience/lookup_dep.py from crrev.com/889754 And updated .gn to use python3 in GN build by default Bug: angleproject:6042 Tbr: syoussefi@google.com Change-Id: I00384f4d38d14b54778d334aec9c633f54d619bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946825 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Gert Wollny cb4f8a79 2021-06-08T10:39:47 Capture: Add a specialization for TGLeglImageOES When writing out the parameter TGLeglImageOES an additional cast is needed. Bug: angleproject:6036 Change-Id: I7470a58a6ae17b0185d0c2e3fe1184b698f3efaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2944952 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Peter Kasting 19209666 2021-06-09T07:55:04 Fix -Wc++11-narrowing in ANGLE. This adds a few explicit casts where necessary and changes some double constants to floats to avoid truncation. Bug: chromium:1216696 Change-Id: Ie1a3ad94284185fb20a6feff75290cabb7ee09e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950320 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 87b8d32a 2021-06-09T10:01:36 Roll vulkan-deps from 11d5b8e51262 to 4d0e65d25f37 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/11d5b8e51262..4d0e65d25f37 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1fa21491bc..3d935ea224 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/87a2867976..d07505c761 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/3ae088978f..1021540dc2 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/46de0cdb74..b82d4bc692 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I96591b5d42b648f807d185d07ae4d1da825d3fea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2948447 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brandon Schade 69f2fb00 2021-03-08T10:49:31 Vulkan: Expose OES_geometry_shader extension Modify the symbol table generation script to accept a list of supported extensions. This allows for the EXT and OES versions of the geometry shader extension to be exposed. Test: angle_deqp_khr_gles31_tests --deqp-case=*geometry_shader* Bug: angleproject:3571 Change-Id: Ia7127a03dbd3fce78957f0505d3ce0c9bab6cb15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2765011 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill c778f93f 2021-06-07T13:10:15 infra: Reduce sharding on GLES3 GL/Metal tests. Bug: None Change-Id: I56593374d027db20a5ed0ebf09ca2210e219f244 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2945431 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi ac2fc259 2021-06-03T17:11:14 Vulkan: SPIR-V Gen: Support function forward declaration The generation of function-related ids is moved to visitFunctionPrototype to support forward declarations. The DeferGlobalInitializers AST transformation produces such code. Bug: angleproject:4889 Change-Id: Iefee534575092ca25ff86e416e35703d7022bc07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939332 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 013613ea 2021-06-08T01:33:30 Translator: Allow invariant on I/O block members The GLSL ES 3.2 spec says: > Only variables output from a shader can be candidates for invariance. And: > All uses of invariant must be at global scope or on block members, and > before any use of the variables being declared as invariant. As a result, it's possible to specify `invariant` on a member of an output I/O block. Bug: angleproject:4889 Change-Id: I8822ed214813db8424d6a67dfef7f069a448b19d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946115 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski 4bafc503 2021-06-01T10:59:17 Vulkan: Fix AGI hierarchy for clear commands Treat mid-render-pass glClear* commands the same as glDraw* commands, generating a hierarchy. This results in vkCmdClearAttachment commands being nested under glClear, instead of being a peer of glDraw* commands. Bug: b/183547523 Change-Id: Ibc6900b0485fd174d79c8fe6c94ea17dbefa520b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2941364 Reviewed-by: Mark Lobodzinski <mark@lunarg.com> Reviewed-by: Mike Schuchardt <mikes@lunarg.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Michael Yu 7c253fca 2021-06-02T13:18:44 D3D11 additional context-loss logging This makes logging more consistent when we encounter context loss. In Renderer11::testDeviceLost, note DXGI_ERROR_INVALID_CALL is a valid GetDeviceRemovedReason, but was not detected prior. SwapChain11::resize and SwapChain11::reset added more logging, likewise with Context11::handleResult. This covers everywhere d3d11::isDeviceLostError is invoked, though that might not be exhaustive of all cases we detect device loss. Bug: b/188291915 Test: Manually trigger conditions to test logging. Change-Id: Idd57363101b53bc2d3c4c306ee78a42012a1a320 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2935696 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Doug Horn <doughorn@google.com> Commit-Queue: Michael Yu <warty@google.com>
Shahbaz Youssefi df977aaf 2021-06-08T01:04:32 Translator: Validate global qualifier declaration's symbol Global qualifier declarations (invariant, precise) apply to already-declared variables. This is now validated. Bug: angleproject:4889 Change-Id: I9889f2d68dcd6a2fc0de2b20a1291899397982d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946114 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski 1b2000f5 2021-06-07T17:29:22 Docs: Update CONTRIBUTORS with LunarG info Add LunarG, Inc. and Mark Lobodzinski to the CONTRIBUTORS file and LunarG, Inc. to the AUTHORS file. Bug: None Change-Id: Id3f9ff2075498532280d4a652a5fffa85dd77f45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2945696 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 0c26ff11 2021-06-03T17:09:22 Vulkan: SPIR-V Gen: Support initializers in declarations If the initializer is a constant, it's specified directly in the OpVariable instruction. Otherwise an OpStore is generated where the declaration is visited. Bug: angleproject:4889 Change-Id: I79291552ecc50c0878f921aff9f6d8618be34116 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939331 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi c3e397c6 2021-06-07T17:25:59 Use float clamp unconditionally for indirect index clamping Suspecting a Qualcomm driver bug with integer clamp affecting WebGL2 tests. Bug: chromium:1217167 Change-Id: I6b323a9de5828b3a11cbe2650d66c7627b90a9f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946111 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll d6f344c2 2021-06-08T12:43:57 Roll SwiftShader from 3da42a3a2cd6 to 5ecc95a00e2b (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/3da42a3a2cd6..5ecc95a00e2b 2021-06-08 swiftshader.regress@gmail.com Regres: Update test lists @ 3da42a3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I8f127154cac665383aa2d776709b801c20b3b22e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946992 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 6746e5dd 2021-06-01T22:48:14 Vulkan: SPIR-V Gen: Basic support for compute shaders This change enables direct SPIR-V generation for compute shaders and enables a few tests. A handful of built-in functions are translated to support said tests. Bug: angleproject:4889 Change-Id: I8fd6dc50ff31559a738ba680a993fb197e29fcf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939330 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Gert Wollny 1ab6d214 2021-06-07T08:49:09 Capture: Create group variable for BlockMemberInfo Also declare GroupScope as NO_DISCARD. Bug: angleproject:6016 Change-Id: I738f137727d52a0930cd8c400fbc05f1cc8cfdad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2943927 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi ee4a5266 2021-06-01T14:57:24 Vulkan: SPIR-V Gen: Function calls This change implements function calls. As a result, transform feedback tests are enabled as well as support for transform feedback emulation (which contains functions and if blocks). `const` and opaque uniform function arguments take intermediate values, while the rest take memory objects. If the argument being passed is an unindexed lvalue, it can be directly given to the function. Otherwise a temporary variable is made which is initialized by the parameter if necessary (in and inout parameters) and later overwrites the parameter if necessary (out and inout parameters). Bug: angleproject:4889 Change-Id: I8976cdd17870c35d5a2daeed3c38de57ada931d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2930363 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny c1932fb5 2021-06-07T12:25:47 Serializer: Print FBO attachment name instead of a number Bug: None Change-Id: I419a0ca6d1c2e3c47dc84b106baf40dc0abb85cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2943930 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3bc28a27 2021-06-07T13:03:39 infra: Add flaky retries to Metal GLES 3 tests. These have been somewhat flaky on the waterfall. Bug: angleproject:6019 Change-Id: I4d76411ab54ad5fbfb9c49775c44a12b99def846 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2945430 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill d99864c0 2021-06-07T12:48:01 Gold Tests: Fix flaky test handling. Indead of just retrying the batch, retry individual tests. This should correctly handle the Intel flake pattern. Bug: angleproject:5415 Change-Id: I029c2514ff8e7a45184c5c105bf2d0350171da29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940049 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill f03f7bdb 2021-06-07T12:30:29 infra: Don't run trace tests in perf smoke tests. These test were already being run more safely in the gold tests step. Bug: angleproject:5977 Change-Id: I4fb1062926fcda19384835723555d0fab0b42aae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939469 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2917ab34 2021-06-07T11:41:54 infra: Override Gold mixin. This mixin is being removed from the Chromium version of the mixins. Therefore we have to move it into the additional mixins option of the generator. Bug: angleproject:6037 Change-Id: I605b7cbf35d6282754bf5fb26246e32b2edcea10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939466 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mark Lobodzinski 0a6c6c00 2021-06-01T10:59:17 Vulkan: Submit Dispatch commands outside renderpass Compute dispatch commands must be submitted outside a renderpass, but their associated debug event markers were being submitted on the renderpass commandbuffer. The dispatch debug event markers are now handled separately from those for draw calls and are now submitted on the correct commandbuffer. Failure manifested in malformed AGI traces for Ragnarok M: Eternal Love Bug: b/181611786 Change-Id: I768eeccd76be38818fc99d6d56f5899290c8fc5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2930818 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Jamie Madill 052713da 2021-06-07T12:25:53 Lift OpenGL Win/Intel test expectation. This was fixed in a prior patch. Bug: angleproject:5444 Change-Id: I6df4b71b8dabd66eb151d94d757f89d88a864dab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939468 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 7231c705 2021-06-07T14:03:45 Tests: Skip genshin_impact on Intel Linux Bug: angleproject:6029 Change-Id: I2f25dcedf36d9f341d134baeb9752fb3e3aada6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2944621 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll bb6e12a3 2021-06-07T15:58:07 Roll vulkan-deps from 95b967c506f6 to 11d5b8e51262 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/95b967c506f6..11d5b8e51262 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6d5c5677e1..87a2867976 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/7fe877c90a..07c4a37bcf * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/34ee418b3a..46de0cdb74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ib38948aad433ec022a3d551bfc85f5d4c89dd5d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2944220 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b20581b9 2021-06-07T14:19:08 Roll vulkan-deps from 7fd6569e6ad3 to 95b967c506f6 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7fd6569e6ad3..95b967c506f6 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/6bdcb4be34..1fa21491bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I75895dc7986e207cd69522e8a0fb182a5e9db66a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2942471 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2d72c99f 2021-06-07T12:58:50 Roll SwiftShader from efe254de5d88 to 3da42a3a2cd6 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/efe254de5d88..3da42a3a2cd6 2021-06-07 swiftshader.regress@gmail.com Regres: Update test lists @ efe254de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I9bf9af0182722b3b065222f55eaf410bb44ff8ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2944667 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a5b302d3 2021-06-07T07:01:22 Roll Chromium from 5c4073be350e to 3bcc8fd7c291 (49 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5c4073be350e..3bcc8fd7c291 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/eb65cc3594..0b443d31ef * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8dc98b062a..a45949a818 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8bf7a0b3c8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/30cbc5cd01..0c64e8349d No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I9ad3a0d25fc5d8a09f90be71f5347366e97496b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2943659 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b4b27e45 2021-06-06T18:44:24 Roll Chromium from fed1a144db8a to 5c4073be350e (25 revisions) https://chromium.googlesource.com/chromium/src.git/+log/fed1a144db8a..5c4073be350e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2c2106e1f4..8dc98b062a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8bf7a0b3c8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d9e38c7cd4..d5d794a9f5 No update to Clang. Bug: angleproject:5941 Tbr: ynovikov@google.com Change-Id: I2c59786a5a190770f475b3027bcb4f3668403e00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2941371 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 77831a6d 2021-05-31T22:41:58 Vulkan: SPIR-V Gen: If-else blocks This change implements if-else blocks as well as a few simple binary operations (equality, less-than etc). It builds on prior work to generate the function in separate blocks and introduces a "conditionals" stack to support nesting of if-else blocks, switches and loops. Bug: angleproject:4889 Change-Id: If7694000487811837ed5946753568b41d67199f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2929660 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 934fc56e 2021-06-06T01:09:35 Roll Chromium from 5ffd2ab3bece to fed1a144db8a (423 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5ffd2ab3bece..fed1a144db8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bf4ecd926c..e353b02625 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f39abc2692..2c2106e1f4 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/baaf1482ba..42884eb2ac * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..092e09c1f7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9705687c25..a5b6b2f8b7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/af7a363dfe..30cbc5cd01 * tools/luci-go: git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0..git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418 * tools/luci-go: git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0..git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418 * tools/luci-go: git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0..git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/42ddcb0299..d9e38c7cd4 * tools/skia_goldctl/linux: fVbmAq5SyEKlNV_cPvOrlJbBRmDAWApv309sIMdbgq8C..SB2wGV5iqWiiLLc3ZLU2sn1CcUnFefPLkUKPCgQ9swkC * tools/skia_goldctl/mac: SGAjTHEDDOpAgPQYJcSEmMh4E6afvlKQKzBjwSTf5dwC..3aDI3FukPbExUrKO2_xiMcP1_2EEcWDoL1X9tb3N1ucC * tools/skia_goldctl/win: hySBvc3hf9NRFmfS2oG52F9ZzLpvX9bFuyybtZ92CNAC..C5XvIOVnzzsQevJZRD08B1C_6mhdpxvY9vPiHf4iZJ0C Clang version changed llvmorg-13-init-11649-g4d788fb8:llvmorg-13-init-11999-g50c0aaed Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/af7a363dfec994581ed076c5023f110e079459f9..30cbc5cd01393d596002061be5cfe50ab66efef1/scripts/update.py Bug: None Tbr: ynovikov@google.com,syoussefi@google.com Change-Id: Iabfa6247c45eaff47a4664e5b08bbdabbb5f1155 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2942218 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 1b680b77 2021-06-02T22:04:45 Reland "Make SH_CLAMP_INDIRECT_ARRAY_BOUNDS do proper AST transformation" This is a reland of a474fd7de769ae817db83490d410510cdbed75b2 The integer clamp used in this transformation is not available in es100 shaders, and float clamp is used instead. Original change's description: > Make SH_CLAMP_INDIRECT_ARRAY_BOUNDS do proper AST transformation > > This translator flag adds a clamp to non-literal indices to arrays. Two > strategies were provisioned, using the clamp intrinsic or a hand-written > function. The latter is ununsed in angle, chromium, firefox and > webkit, so this change removes this option and uses the clamp intrinsic > unconditionally. > > The clamp itself was added at output generation time with special flags > set on the index node. This is changed such that a proper AST > transformation is done and no-special handling would be necessary. > > Bug: angleproject:4361 > Bug: angleproject:4889 > Change-Id: Ieccfd2c1c347563fb5282e9fa66d39304e62f2ca > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2935041 > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:4361 Bug: angleproject:4889 Change-Id: I9397ec7e6bdfb706c2a891b33fd3b2b79e883ccc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940902 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
kmx.io     mail     discord kmxgit v0.4.0