kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll d1b1ef9a 2022-02-01T10:01:03 Roll vulkan-deps from 69f4b9c09e48 to 9ee740d2e9ef (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/69f4b9c09e48..9ee740d2e9ef Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/20b122b2e0..b846f8f1dc * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f4aeed4464..be7c48c0e9 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/af13a29d6f..9d0dda35c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: If9003fea29b9acffe1764981e333c6ba24a92377 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3429085 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Sergey Ulanov 3c727e44 2022-01-31T22:18:22 Allow GL_RGBX8_ANGLE for texture copy destination Updated IsValidCopyTextureDestinationInternalFormatEnum() to allow GL_RGBX8_ANGLE. Bug: chromium:1269826 Change-Id: I07533560d8f0d6f9d114e7c05927f670c6f96891 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3426820 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 06926954 2022-02-01T08:02:23 Roll Chromium from 97a33ab1a078 to a210f891a450 (477 revisions) https://chromium.googlesource.com/chromium/src.git/+log/97a33ab1a078..a210f891a450 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/251d3d7d45..6b20164497 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/91b483090a..b17e15aa1a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ce12c7a75a..fd8e6f276e * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/3d6486f686..e935cea6e2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1c33cd6890 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8dd74d4f85..98cf932814 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/2dc9e853e1..d29d689c1d * third_party/turbine: RkSl7-UvBXltU55m5zi387oPTAJqTj3Oz6nIpQkOI4wC..g7lRRNWdEQAksTvScmHd-o0PUx4ts7kioIdeDtQ-ifMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/00a9400ecf..cb91247d81 * tools/luci-go: git_revision:9c88febc5ab63469baf5aae05a74f8e419970ef3..git_revision:d46a9c7ad4e38935bbacb01602fc1d09a162884b * tools/luci-go: git_revision:9c88febc5ab63469baf5aae05a74f8e419970ef3..git_revision:d46a9c7ad4e38935bbacb01602fc1d09a162884b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4ccc066727..0182d6f78c * tools/skia_goldctl/linux: a94AbgYafC6yjxWNmJJ4cHUWWXNhjFUQLcU79HycYjkC..EOs8AExsqXFWldVpuKUhohthnzRRSh8f1iOAv5ZTMaMC * tools/skia_goldctl/mac_amd64: IEdOBXQmFOksbZa16aKIWU6uYVYJlgvPwyX3wktMkkIC..eq2tMMf-q6AOpCv5MS-RFvueRyU6T_uvZrMA_EsM_cAC * tools/skia_goldctl/mac_arm64: XtI7k09JHcA8aaaRNlOF92uDqOXfr8HMmepwH0q9uk0C..-AnHHiBmUZNDkYjj6DIHVHg8N2LuttcBm9gUQx5Yrt8C * tools/skia_goldctl/win: 3uvz7bDTL-QoL5KPX-caB_HxcvVE7JamyMibu71hqHAC..YNpvcNJRmWf1tWoS-tcsyhjqBG_mHDeGeur5IZYx0hEC No update to Clang. Bug: angleproject:6358 Tbr: jonahr@google.com Change-Id: Iea28347b9dabc57716e73d380bfe8f853a9fb865 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3429080 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill f810e998 2022-01-31T11:39:37 Use a temporary timeout multipler for trace tests. The trace tests upload is frequently timing out on our test infra because of the size of the test suite. Until we can find a better solution we can increase the timeout non-invasively using an environment variable. Bug: angleproject:6854 Change-Id: Ifbe43c4d9dc8928cf35df8a26b844f884c90eb9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3427560 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 508a8a02 2022-01-31T15:12:55 Remove old spellings for SYNC-HAZARD-WRITE_AFTER_READ skips Obsoleted by VVL roll crrev.com/c/3426000 Bug: chromium:1292106 Change-Id: I360dea6f97e75a25245597e96553aa86d655c340 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3428099 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 2d3ce72d 2022-01-20T10:13:06 Refactor shared library load to avoid allocations. Fixes a leak of an angle::Library detected in the EGL loader. Bug: angleproject:6937 Change-Id: I623aa6172b98a35465e1d2641b92f67bdc5d24e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3403060 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 665ddccd 2021-12-09T23:06:39 Vulkan: Emulate dithering Dithering in OpenGL is vaguely defined, to the extent that no dithering is also a valid dithering algorithm. Dithering is enabled by default, but emulating it has a non-negligible cost. Similarly to some other GLES drivers, ANGLE enables dithering only on low-bit formats where visual banding is particularly common; namely RGBA4444, RGBA5551 and RGB565. Dithering is emulated in the fragment shader and is controlled by a spec constant. Every 2 bits of the spec constant correspond to one attachment, with the value indicating: - 00: No dithering - 01: Dither for RGBA4444 - 10: Dither for RGBA5551 - 11: Dither for RGB565 The translator appends code to the shader that, based on the format specified by the specialization constant, adds dithering to each color attachment output. A 2x2 Bayer matrix is used for dithering, indexed by gl_FragCoord.xy % 2. Bug: angleproject:6755 Change-Id: Ib45da5938e299b6626bff921119d63e7357dd353 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3374261 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 29d087df 2022-01-28T16:44:14 Fix ANGLE_rgbx_internal_format's extension file name Bug: angleproject:6690 Change-Id: I67abec8a58d216e97ecaed82126005dc3deae214 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3424663 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill 471f1852 2022-01-31T11:22:49 D3D11: Fix underflow with computing small strides. When an attribute stride was less than the size of a vertex element, and the D3D11 back-end emulates this vertex format, our vertex streaming logic could decide that an unsigned int underflow means our element count in a buffer is not computable and return zero. Fix this bug by using signed integers in the element conversion. Bug: angleproject:6958 Change-Id: Ibd9a3599d780e953d492db739c7443662c7e6b82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3427559 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 84470eb3 2022-01-31T10:01:08 Roll SwiftShader from 518c5780ac4f to 4db20a80409b (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/518c5780ac4f..4db20a80409b 2022-01-28 srisser@google.com Regres queries gerrit with a CL's numeric ID 2022-01-28 tho.laroche@gmail.com Check shm extension is supported before using it 2022-01-28 capn@google.com Suggest only active owners as code reviewers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I7c7bb60d94f2e24ae4267b485234cb01523cb52c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3427046 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b934fad9 2022-01-31T07:02:28 Roll Chromium from 4d71de73b37d to 97a33ab1a078 (625 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4d71de73b37d..97a33ab1a078 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c033fc477f..251d3d7d45 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/7246413309..d0ad43c5e1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/df87133fcb..91b483090a * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/09aa08e993..3d6486f686 * third_party/android_ndk: https://chromium.googlesource.com/android_ndk.git/+log/401019bf85..9644104c8c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6b30850934 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/289dedd36b..8dd74d4f85 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e9331be2f4..4ccc066727 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/ff9c7dc63d..92807057e1 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I3620eb6bb4d8bbf2ead0dabd518cb03cea21b7ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3426821 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a4a4fec8 2022-01-29T14:47:02 Roll vulkan-deps from f703f3cc0975 to 69f4b9c09e48 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f703f3cc0975..69f4b9c09e48 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a73e724359..20b122b2e0 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8aad559a09..f4aeed4464 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/cf9f239a93..af13a29d6f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I34755b5d6be63df32c3f6e9ca34637337935060c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3426005 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 69263b38 2022-01-29T06:38:02 Roll vulkan-deps from 746e518a0b0e to f703f3cc0975 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/746e518a0b0e..f703f3cc0975 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4c043dd599..cf9f239a93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ia90988280d25ee2a7f333e0dfb4b040bce187827 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3426000 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 55ef2b4f 2022-01-28T23:24:49 Update one more SYNC-HAZARD-WRITE_AFTER_READ skip vkCmdCopyImageToBuffer() was changed to vkCmdCopyImageToBuffer in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/3705 Skip both variants for now, the old one to be removed after a VVL roll. Bug: chromium:1292106 Change-Id: I8c1a6be7bcf829c9a8b848c5ef2362462a965a11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3424667 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 168e0ae5 2022-01-27T16:50:00 Vulkan: Refactor descriptor pool code. This uses vk::Context to init DynamicDescriptorPool, and removes some accesses to ProgramExecutableVk member variables so the methods can more easily be moved into another class. The changes should have no effective behaviour difference. Note that the immutable sampler descriptor count is entirely set by the format of the immutable samplers. However we can't determine this count by looking at the descriptor set layout desc with the current implementation. Bug: angleproject:6776 Change-Id: I0a323d19fa3720b5afd8300401ed9c30b105c0ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3424657 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov a994ea99 2022-01-28T17:52:16 Update SYNC-HAZARD-WRITE_AFTER_READ skip VK_PIPELINE_STAGE_2_NONE_KHR was renamed to VK_PIPELINE_STAGE_2_NONE in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/3705 Skip both variants for now, KHR to be removed after a VVL roll. Bug: chromium:1292106 Change-Id: Ie8d095eccedc526880edf7d3601fa0aca23c1498 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3424665 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jeff Vigil e03f1753 2022-01-06T09:48:12 EGL: mutable_render_buffer deferredFlush fix When in SINGLE_BUFFER mode, need to get around deferredFlush and call Swapbuffers to force update This must do status check for OUT_OF_DATE. Bug: angleproject:6878 Change-Id: I34b7381f6799879bf6f6d490aba02feffc5c3748 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373739 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e27bb397 2022-01-28T19:31:02 Roll vulkan-deps from a19b5047ffca to 746e518a0b0e (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a19b5047ffca..746e518a0b0e Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/81cc10a498..c34bb3b6c5 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a6c1ddca49..4c043dd599 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I916fedcae5acc54e9195f96a52d98b06fc9bb338 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3425081 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
sugoi1 8a1f8af4 2022-01-28T10:51:47 Turn on the Vulkan backend on ChromeOS ChromeOS needs to switch from testing on legacy SwiftShader GL to testing on SwANGLE instead. This CL allows ANGLE's Vulkan backend to exist on ChromeOS. Bug: chromium:1225003 Change-Id: I7bf702ce18857707226461152b560a570797fce0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3424658 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Lubosz Sarnecki 9bf5716c 2022-01-26T16:39:11 Tests: Add War Planet Online trace. Add GL_KHR_texture_compression_astc_ldr prerequisite. Test: angle_perftests --gtest_filter="*war_planet_online*" Bug: angleproject:6774 Change-Id: I3d595453a0a570a1af4b1e6673cfc77e4ff9210b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3420296 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Lubosz Sarnecki 287057b3 2022-01-25T17:01:43 FrameCapture: Don't track coherent buffers before capture starts. Even though coherent buffer storages were only captured after capture was activated, the buffer tracker was incorrectly initialized with the first call to glMapBufferRange, even though capture was not active. This fixes corrupted rendering in War Planet Online due to all coherent buffer storages being tracked at initialization of the app, when FrameCapture was enabled but not active. Introduce mMidExecutionCaptureActive, which exposes if MEC is currently executed. Bug: angleproject:5857 Bug: angleproject:6774 Change-Id: I4849d6497e8e08aefc60e68bae027915e9b2912f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3416227 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Lubosz Sarnecki 42c8b29d 2022-01-05T13:35:23 Tests: Add Dead By Daylight trace. Add GL_EXT_shader_framebuffer_fetch prerequisite. Ignore SYNC-HAZARD-READ_AFTER_WRITE validation error in RendererVk. Test: angle_perftests --gtest_filter="*dead_by_daylight*" Bug: angleproject:6870 Change-Id: I01f53ff8d26b704b75afe8c02ac12777b51fd5de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3372793 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 46b420f6 2022-01-28T10:01:09 Roll SwiftShader from bca23447ad46 to 518c5780ac4f (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/bca23447ad46..518c5780ac4f 2022-01-27 sugoi@google.com Vulkan 1.3 API 2022-01-27 capn@google.com Add benchmarks for trigonometry and transcendental functions 2022-01-27 dvet@google.com Add affinity options to the configuration. 2022-01-27 capn@google.com Clarify the need to log into Gerrit 2022-01-27 sugoi@google.com Fix compilation error in new Vulkan headers 2022-01-27 capn@google.com Use rr::MulAdd() to implement GLSL.std.450's Fma instruction 2022-01-27 capn@google.com Implement MulAdd() which may perform FMA If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Id4f43c6ad4283c9b5d248c6ad7e62699a7f8a495 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3423813 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 078f7ea0 2022-01-28T07:00:47 Roll Chromium from 8ff0cb4f71d8 to 4d71de73b37d (550 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8ff0cb4f71d8..4d71de73b37d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/45926bacc9..c033fc477f * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c8a5d430f2..7246413309 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0928533770..df87133fcb * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/cfdfe8d145..ce12c7a75a * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f7460e1e05..09aa08e993 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d90eeee993 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d5862557d6..289dedd36b * third_party/r8: KOlWWUU4CAY1EqgiZ6iljOP7ycIjceTEFcwWxL14HFoC..tamyW0-567_CaEZt2m7Pwy2NSUKeocbxdkoGsf-z3F0C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b93ee79874..00a9400ecf * tools/luci-go: git_revision:7528d700b89db0b6feb32be098d40597f738d3c7..git_revision:9c88febc5ab63469baf5aae05a74f8e419970ef3 * tools/luci-go: git_revision:7528d700b89db0b6feb32be098d40597f738d3c7..git_revision:9c88febc5ab63469baf5aae05a74f8e419970ef3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cae500a685..619214929f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7c555d7184..e9331be2f4 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I798fc14c60b8c46a607daf4f582fd9aff7385bed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3423507 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kyle Piddington c4a9d416 2022-01-05T15:28:11 Metal: Refactor to build without SPIR-V Refactor ShaderInterfaceInfoMap and constant names to thier own files, allowing Webkit to build without needing to compile SPIRV code via mtl_glslang_utils.cpp. Bug: angleproject:6782 Change-Id: I7a9c7e387145c95807f780e24bd2764e0efb5709 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3364970 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Charlie Lao 701d51b1 2022-01-25T15:44:39 Vulkan: Add SmallBufferPool for small allocations The small pool uses buddy algorithm that is much faster. The only downside is that it rounds size to power of two. For small allocations that rounding does not generate much waste and avoid fragmentation as well. This CL adds a small pool for host visible non-coherent pool. My testing with gardenscape shows that on top of other CLs, this reduces CPU overhead from 1.77ms to 1.55ms as measured with --minimize-gpu-work with offscreen. Bug: b/215768827 Change-Id: I68434931f238c4e980b77d3df46d762260ef1db5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3415211 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Robert Phillips 66e01ae5 2022-01-26T15:57:26 Expand error message on BindTexture validation failure Bug: chromium:1288391 Change-Id: I34098a64162c78c20a485ece1cd98178242c6864 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3417919 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 706e44b0 2021-12-23T19:36:44 Tests: Add PUBG Mobile launch trace Note: This isn't full representative of the shader compilation phase, since the glGetProgramBinary() calls are excluded from the trace due to missing functionality. The goal of this trace is to benchmark the compile/link/use program steps, so this trace is still useful from that perspective. Test: TracePerfTest.Run/*pubg_mobile_launch Bug: angleproject:6848 Bug: angleproject:6850 Change-Id: Ic0572b9fd1d0d26a53571c64446e577c7af7fa3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3355556 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Charlie Lao df19e35a 2022-01-24T17:47:58 Vulkan: Use queue for mGarbageQueue This variable is also acting exactly like queue as the name implies. This CL changes from vector to queue so that the very last erase() call will not actually move anything. Bug: b/215768827 Change-Id: Ieb39c3a1b3acb25f93bcda2a46737a6d009d71f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3414355 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Jamie Madill 4e644b33 2022-01-22T16:17:46 Vulkan: Remove ProgramExecutableVk back-pointers. This removes the mProgram and mProgramPipeline back-pointers from ProgramExecutableVk. In order to fix this, we needed to refactor the VkPipeline init functions to call through ProgramExecutableVk only instead of passing through ProgramVk. We also needed to move the early fragment shader optimization boolean out from Program. This CL also fixes a few places where the early fragment test optimization boolean wasn't properly updated. Bug: angleproject:3570 Change-Id: Ie4c48087f6eb022e6f0a4dacc2710085165d49e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3408267 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Patrick To b3ed4780 2021-12-21T17:20:19 Change Windows display initialization from ANSI to wide version Bug: angleproject:6846 Change-Id: I2aee8f4b5b7546fc707705e435251fa9861e27d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3352866 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 602b957b 2022-01-26T15:01:21 Enable robustnessEXT for SwiftShader. This is a reland of commit b803b60df1806f189c1b29ca77da47896241e0f1. The issue with webgl-oversized-printing.html crashes is supposed to be resolved by commit b1216bf1759ab23ffe2d6b6727f9ec10ddfa4d0f Failing test angle-instanced-arrays-out-of-bounds.html disabled by commit d235e032000d611d31e6fd8a8190e4425b4c0ecb I don't think we need to change the test expectations any more as that swiftshader issue is supposed to be already fixed http://anglebug.com/6906#c4 Bug: chromium:1287631 Bug: angleproject:6922 Change-Id: I0fdf806cac51d000088a029bbb3070906453dfb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3415875 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 8b966cfc 2022-01-27T10:01:03 Roll vulkan-deps from ae6a4b829252 to a19b5047ffca (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ae6a4b829252..a19b5047ffca Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5003644f55..a73e724359 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/db4c3177aa..8aad559a09 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/2ee12e8ba3..b69bea3446 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ie7e44ffd59a4f7e92a6269e372363e18490a4574 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3418845 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 322d118f 2022-01-27T10:01:08 Roll SwiftShader from 711968667748 to bca23447ad46 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/711968667748..bca23447ad46 2022-01-26 sugoi@google.com Update Vulkan headers to version 1.3.204 2022-01-26 capn@google.com Make MemoryMapper a JITRoutine member 2022-01-26 swiftshader.regress@gmail.com Regres: Update test lists @ 71196866 2022-01-26 nicolascapens@google.com Revert "Regres: Build dEQP with asserts enabled" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I306a8a1740484fe1a6088959306f6dd3d9047d2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3420148 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 47d63b4e 2022-01-27T07:00:06 Roll Chromium from 7b890e4b915b to 8ff0cb4f71d8 (485 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7b890e4b915b..8ff0cb4f71d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/37cced769f..45926bacc9 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e4cc353cbf..df43e1b039 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a53609bdb8..0928533770 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e79b8ea964..cfdfe8d145 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/941c8c5b02..f7460e1e05 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d90eeee993 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d05a2e0395..d5862557d6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5518918903..b93ee79874 * tools/luci-go: git_revision:09f8b3edbbf18dc63d0d5aa7722ae7acc20b11b4..git_revision:7528d700b89db0b6feb32be098d40597f738d3c7 * tools/luci-go: git_revision:09f8b3edbbf18dc63d0d5aa7722ae7acc20b11b4..git_revision:7528d700b89db0b6feb32be098d40597f738d3c7 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cb2a01ac98..cae500a685 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b53db1cd9f..7c555d7184 Clang version changed llvmorg-14-init-12719-gc4b45eeb:llvmorg-14-init-17086-g38e16e1c Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/55189189038d366b821a45d0cd153be7e8b7cf9a..b93ee79874a76bf9c74264ef736f05a760c5dea3/scripts/update.py Bug: angleproject:2192,angleproject:3111,angleproject:4846,angleproject:5505,angleproject:6922 Tbr: ynovikov@google.com Change-Id: Ic33dba8c9a764d2eeb299092cca9807939c4f81e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3418843 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 2ad5f350 2022-01-25T12:15:16 Vulkan: Fix texture array level redefinition When a level of a texture is redefined, all staged updates to that level should be removed, not the ones specific to the new layers. The bug fixed was that if the texture was redefined to have its number of layers changed, the staged higher-layer-count update to the image was not removed. Bug: chromium:1289383 Change-Id: I9b90025f78af80ab19a280f90b58510716da31d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3413004 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
John Cunningham 45237a04 2022-01-11T00:14:01 Metal: Fix undefined behavior of depth write Writing to an unbound depth attachment is undefined behavior in Metal. Fix this by emitting a function constant to guard depth buffer use in fragment shaders. Bug: angleproject:6865 Change-Id: Id7c10d0aeb349aacfe09c397bc292a71199ab50a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3380304 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Brandon Schade aadc6434 2022-01-24T18:28:19 Vulkan: Fix to correctly redefine gl_PerVertex in GS Angle translator structures were inconsistent of data lookup of gl_PerVertex data when it is user defined. Bug: angleproject:5579 Test: KHR-GLES32.core.geometry_shader.api.getProgramiv3 Test: GLSLTest_ES31.PerVertex* Change-Id: Ied9ea25ce86ade29261f4f75ce0b48af15061760 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2962352 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Garrett Beaty 25e8f02b 2022-01-26T13:23:26 [infra] Use python3 for run_presubmit recipe. Bug: chromium:1256437 Change-Id: I6ef3d7de6818d13d3e53b0ad5c5a905a8ee62664 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3418137 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Charlie Lao a7970889 2022-01-24T11:50:27 Vulkan: Use queue instead of vector for mSharedGarbageList The garbage collector code is iterating the mSharedGarbageList from begin to end and if the garbage object is completed, we destroy it and erase it from the vector. This is done one by one. The problem with that is each erase call end up moving the remaining vector to ahead by one, and this process is repeated for each completed element. This is O(N^2) problem and really magnifies when you have many garbage objects. Since we only add garbage when it is GPU pending, so most of these garbages are in sort of fifo order anyway. This CL changes the garbage list from vector to queue so that erase becomes pop and this becomes a O(N) problem. This reduces CPU overhead as measured with minimize-gpu-work for gardenscapes from 10ms to 2ms due to suballocation generates lots of garbages. But this CL is a general improvement for the garbage collection performance. Bug: b/215768827 Change-Id: I002aadf75f958d8b79eb6281a2608597776e908d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3414354 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 39f66a9c 2021-12-16T23:26:00 Vulkan: Support different SCBs for outside and inside RP The render pass command buffers are generally much larger than outside render pass command buffers, and their allocation sizes and frequencies differ. This change allows choosing between ANGLE and Vulkan secondary CBs independently for outside and inside render pass commands, as part of an investigation to understand which implementation performs best for each. Switching to Vulkan secondary command buffers is still slower. In the ball park, switching outside render pass SCBs doesn't seem to make much difference, while switching render pass SCBs duplicates the frame's CPU time. Bug: angleproject:6811 Change-Id: Ia8455fd19897a0eaeadf3d6db29286ea53df1f5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3346341 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill cb96c236 2022-01-26T18:53:55 Revert "Vulkan: Enable framebuffer fetch on SwiftShader." This reverts commit 5107231939b5e04d3d5e4376176db42c3ae60193. Reason for revert: Fails new code paths in Chrome+Skia. Bug: angleproject:6947 Original change's description: > Vulkan: Enable framebuffer fetch on SwiftShader. > > This also fixes a bug with non-coherent fetch in the symbol table. > > Bug: angleproject:6947 > Bug: angleproject:6948 > Change-Id: I190b2e0cddf1bc1b53a79079d3e2f79ccbb40d15 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3412998 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:6947 Bug: angleproject:6948 Change-Id: I8bd6c55598552b733547e45c854f6d55768d2b65 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3417503 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 7c1346bd 2022-01-21T11:35:45 Vulkan: Consolidate uniforms code in ProgramExecutableVk. De-duplicates several methods. Refactoring change only. Bug: angleproject:3570 Change-Id: Ib68bc30b3e9b1087871bb268ea292677e0c9fe2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3408061 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill b2d55742 2022-01-21T12:28:32 Program: Add generic uniform update methods. This will make it easier to make central changes to all the update methods. Otherwise we'd have to replicate changes in each separate member. Bug: angleproject:3570 Change-Id: Ia765720507642338d6e9777b7e38fb323800359b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3407734 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 374e0c43 2022-01-20T14:04:27 ProgramPipeline: Remove mHas members. These are no longer needed now that the excutable mirrors uniforms/ samplers/sahder buffers/etc.. Refactoring change only. Bug: angleproject:3570 Change-Id: I768381ac64a750f04180ab824302e3550030911c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3403047 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0dc0dc2a 2021-12-30T11:35:40 Re-land: "Vulkan: Remove "fillProgramStateMap"." This copies additional shader info like uniforms from the Program to the Program Piplines. There is now a duplication between PPOs and Programs. There is no additional storage required for non-PPO Programs. Re-land fixes fragment in/out uniform updating with PPOs. Bug: angleproject:3570 Change-Id: I64b2db6fbc3a610f3b5e617301f94eb30d915939 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3412999 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 51072319 2022-01-25T10:41:25 Vulkan: Enable framebuffer fetch on SwiftShader. This also fixes a bug with non-coherent fetch in the symbol table. Bug: angleproject:6947 Bug: angleproject:6948 Change-Id: I190b2e0cddf1bc1b53a79079d3e2f79ccbb40d15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3412998 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 1316d153 2022-01-26T10:01:03 Roll vulkan-deps from 4ec99dddf407 to ae6a4b829252 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4ec99dddf407..ae6a4b829252 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/6624e13673..81cc10a498 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/58d8b4e29c..5003644f55 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ec84a665fd..db4c3177aa * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7f229d1544..a6c1ddca49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I97761284e447469a02c5ccd0dba8fb226be7eaa7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3415215 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f44159cd 2022-01-26T10:01:09 Roll SwiftShader from 366db5aedd90 to 711968667748 (8 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/366db5aedd90..711968667748 2022-01-26 capn@google.com Make image descriptor fields unsigned 2022-01-26 capn@google.com Regres: Apply lazy initialization patch 2022-01-25 nicolascapens@google.com Merge changes If2b3adf8,I8408644a 2022-01-25 sugoi@google.com Remove a few unused includes and declarations 2022-01-25 sugoi@google.com VK_EXT_tooling_info support 2022-01-25 capn@google.com Optimize Abs() using LLVM intrinsics 2022-01-25 dvet@google.com Refactor and modernize the Configurator class, add tests. 2022-01-25 mikaelpessa@google.com Add logging to SPIR-V validation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I06be4ce3c5d41db19fceefe263e06f4854312a55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3417055 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 83ca1fbc 2022-01-26T08:35:23 Roll Chromium from 94c8695167c4 to 7b890e4b915b (100 revisions) https://chromium.googlesource.com/chromium/src.git/+log/94c8695167c4..7b890e4b915b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1c8bf9081f..37cced769f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d1caa42e57..a53609bdb8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d90eeee993 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/403558f6ee..d05a2e0395 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I8e1ec06a214da22581e6f6cb44122c5362afaff5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3415214 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 54f8a8f7 2022-01-26T01:22:34 Roll Chromium from 35ed79e6a83b to 94c8695167c4 (935 revisions) https://chromium.googlesource.com/chromium/src.git/+log/35ed79e6a83b..94c8695167c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bec2a5518d..1c8bf9081f * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/fd0ef6db30..e4cc353cbf * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8a418d7076..d1caa42e57 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e16f79ac43..941c8c5b02 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d90eeee993 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/18a2844b53..403558f6ee * third_party/turbine: 8Wzi8_CpwqQkJeczCQavMiPI6wJMCSLh_4jpRwUIlSkC..RkSl7-UvBXltU55m5zi387oPTAJqTj3Oz6nIpQkOI4wC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4e3276cdb9..5518918903 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a958c71673..cb2a01ac98 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7b5cbc79fb..b53db1cd9f No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I728d23720bfcfedad6a7d687758abc607b0633d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3415212 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov aaac31b4 2022-01-25T18:27:11 Unskip dEQP.GLES3/functional_shaders_operator_unary_operator_minus_* Fixed in crrev.com/c/3407737 Bug: angleproject:6916, angleproject:6645 Change-Id: I9b7ee44aed7d77e581b48f871e0f0dd1195dabf0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3413009 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Lubosz Sarnecki c5498b95 2022-01-21T13:33:49 FrameCapture: Reset immutable buffers correctly. Restore immutable buffers using UpdateClientBufferData. Regenerate immutable buffers using CaptureBufferStorageEXT. Bug: angleproject:4599 Bug: angleproject:5857 Bug: angleproject:6774 Change-Id: I8e80e9e32633b1303855e5a6ba7ac62941929645 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406755 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Lubosz Sarnecki 8474c8e1 2022-01-21T12:30:15 FrameCapture: Add Renderbuffers to mStartingResources. This prevents Renderbuffers being deleted in Reset when they were captured with MEC and added to the Setup function. Bug: angleproject:5857 Bug: angleproject:4599 Change-Id: Ie61f75f69e3a3846877b1e8f5d9c98d5d0cecb2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406754 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Roman Lavrov 5f0badf4 2022-01-18T20:05:55 Vulkan: Prevent out of bounds read in divisor emulation path. Split the replicated part of StreamVertexData out to StreamVertexDataWithDivisor, there is only a partial argument overlap between the two. Bug: chromium:1285885 Change-Id: Ibf6ab3efc6b12b430b1d391c6ae61bd9668b4407 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3398816 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Lubosz Sarnecki 526c93dd 2022-01-05T17:21:34 FrameCapture: Detect GL_MAP_COHERENT_BIT_EXT correctly. In MEC, look for GL_MAP_COHERENT_BIT_EXT in getStorageExtUsageFlags as it will never occur in getAccessFlags. GL_MAP_COHERENT_BIT_EXT will also never occur in glMapBuffer access flags, so just pass false. Bug: angleproject:5857 Change-Id: I9bc2a5d334d3b90653d33439d4055965593de5b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406753 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll f5dc2a95 2022-01-25T12:26:03 Roll vulkan-deps from 238eaa6f9d25 to 4ec99dddf407 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/238eaa6f9d25..4ec99dddf407 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c38495656d..58d8b4e29c * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/0873a22a11..1dace16d80 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/dab15e0c45..ec84a665fd * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4bd7579d17..7f229d1544 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: If321764265a5cf01b90eb7ae0155a386dbb857fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3415210 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8fc4d3b1 2022-01-25T10:01:09 Roll SwiftShader from e823eef17385 to 366db5aedd90 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/e823eef17385..366db5aedd90 2022-01-24 dvet@google.com Add SwiftConfig.cpp to Android build. 2022-01-24 dvet@google.com Add a simple configuration file implementation. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Id802859fe60140c40fa0fec76e228b2703736a72 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3414853 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny d7585c22 2021-12-15T13:35:51 Capture/Replay: don't capture MS depth renderbuffer pixels Vulkan can't resolve depth textures and no emulation has been implemented todo so when required, therefore we hit an assertion in ImageHelper::readPixels if we try to read back the MS depth renderbuffer pixels. To work around this problem don't read back the data. Reorder the renderbuffer readback code a bit to make the code easier to follow. Bug: angleproject:6324 Change-Id: I6fb4d0f993b061393b249706efe4b2c9d44a6f96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3340940 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Jeff Vigil d6dd0cb5 2021-09-21T15:26:13 EGL: EGL_KHR_lock_surface3 backend Add vulkan implementation Add test: EGLLockSurface3Test Test: angle_end2end_test --gtest_filter=EGLLockSurface3Test Bug: angleproject:6062 Change-Id: Id5bfe37895b550392d11e9e9cc1262c1f0288c42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3174323 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 6a14e328 2022-01-25T00:49:45 Revert "Vulkan: Remove "fillProgramStateMap"." This reverts commit 38deffe40db83836588e0cd50864945a9ddba36b. Reason for revert: angle_end2end_tests failures on Pixel 6. Original change's description: > Vulkan: Remove "fillProgramStateMap". > > This copies additional shader info like uniforms from the Program > to the Program Piplines. There is now a duplication between PPOs > and Programs. There is no additional storage required for non-PPO > Programs. > > Bug: angleproject:3570 > Change-Id: I5ed6c946df945aaf2f65752f797b16e7649d5584 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3362297 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Tim Van Patten <timvp@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:3570 Change-Id: I3a4822c8a65d024070a9fe5df103b88a3c8333d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3414024 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov bd87cc1c 2022-01-24T17:44:58 Skip flaky CopyTextureTest.CopyOutsideMipmap On Win NVIDIA GLES Bug: angleproject:4716 Change-Id: Ia9b9b8b736a0703e0b774d6325fd1131876921ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3412885 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov c7f31b8a 2022-01-24T15:39:57 Expand TransformFeedbackTest.SpanMultipleRenderPasses suppression Looks like the test is flaky on SwiftShader in general, not just on ASAN. Bug: angleproject:6875 Change-Id: Ie011e0e3939be85413a8de94f32284c19d5a3c02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3413273 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 29678329 2022-01-21T14:06:42 Vulkan: Fix advertised precision ranges Advertise precision ranges similar to the spec requirements. This change requires a fix to the CTS to allow drivers to provide more precision in some situations: 97ceb2222747fef380d25acd15638b599fbc1d5a in VK-GL-CTS Bug: angleproject:6645 Change-Id: I9b537a8acdf885e35fbcb539c70b730c5f2accc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3407737 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 38deffe4 2021-12-30T11:35:40 Vulkan: Remove "fillProgramStateMap". This copies additional shader info like uniforms from the Program to the Program Piplines. There is now a duplication between PPOs and Programs. There is no additional storage required for non-PPO Programs. Bug: angleproject:3570 Change-Id: I5ed6c946df945aaf2f65752f797b16e7649d5584 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3362297 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 540b2e46 2022-01-24T13:44:25 Fix MultithreadingTestES3.MultithreadFenceDraw skip on SwiftShader Bug: angleproject:5418 Change-Id: I59ee80f3f5666c7d9551d33926ecdbb6942712ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3413272 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gregg Tavares 73c82310 2022-01-24T09:54:18 Update the Capture and Replay docs Mention that you must set ANGLE_CAPTURE_START_FRAME to 1 or greater. Bug: angleproject:6945 Change-Id: I3ff999749e62e1f4084656ada5d2f23c082641fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3413172 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Yuly Novikov 85e2991f 2022-01-21T18:14:35 Fix couple LSAN detected leaks in unit and end2end tests Bug: angleproject:6937 Change-Id: Ibef9a300056509437edd50e9db18908c0b6d449e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3413271 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi adb80238 2022-01-21T22:02:22 On invalidate, only sync the relevant framebuffer binding ... instead of syncing both framebuffer bindings. This showed up as a bug in the dithering emulation where the draw framebuffer was never sync'ed (so its render target cache was not populated), but its binding was. The test only ever accessed the read framebuffer. Bug: angleproject:6755 Change-Id: I29445d1c896712b9ccf4c7127baa6b9e4fc63527 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3407958 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev a20cd8b7 2022-01-22T01:40:34 Fix initialization for ETC2 punchthrough alpha formats * Zero-filled ETC2_A1 data must be treated as opaque black * Removed init functions when emulation is not needed * Fixed initialization for emulated ETC2_R8G8B8A1_SRGB_BLOCK Bug: angleproject:6936 Bug: angleproject:6941 Change-Id: Ie5555bbaa6b1a2bcfd9c22cb9c17d1a96e72aa70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406761 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Sergey Ulanov cac4e54a 2022-01-24T05:43:00 Mark GL_RGBX8_ANGLE format as filterable. `filterable` field was set to set to NeverSupported for GL_RGBX8_ANGLE, while it is filterable when it's supported. Bug: angleproject:6690, chromium:126982 Change-Id: If44f18014c3c7a30378f51d0426ce9980c2feae0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3411538 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 64c49da3 2022-01-24T07:58:23 Roll Chromium from b7f974a39665 to 35ed79e6a83b (570 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b7f974a39665..35ed79e6a83b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/906b90c327..bec2a5518d * buildtools/linux64: git_revision:80a40b07305373617eba2d5878d353532af77da3..git_revision:0725d7827575b239594fbc8fd5192873a1d62f44 * buildtools/mac: git_revision:80a40b07305373617eba2d5878d353532af77da3..git_revision:0725d7827575b239594fbc8fd5192873a1d62f44 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/295f84c04f..c8a5d430f2 * buildtools/win: git_revision:80a40b07305373617eba2d5878d353532af77da3..git_revision:0725d7827575b239594fbc8fd5192873a1d62f44 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9ef62302b2..8a418d7076 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..56a84f9f66 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6bfbe35cce..18a2844b53 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/170758333f..4e3276cdb9 * tools/luci-go: git_revision:5b02a4aaeb5fd78d6fe41d6d54d1cb58da17f192..git_revision:09f8b3edbbf18dc63d0d5aa7722ae7acc20b11b4 * tools/luci-go: git_revision:5b02a4aaeb5fd78d6fe41d6d54d1cb58da17f192..git_revision:09f8b3edbbf18dc63d0d5aa7722ae7acc20b11b4 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d5139d0314..a958c71673 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/8e8704fdfa..5b5485d9df * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ae043af23c..7b5cbc79fb * tools/skia_goldctl/linux: YNf7R76UZBvuCmgAKDzb1F43jfA8FkFy9DCW6B98MHEC..a94AbgYafC6yjxWNmJJ4cHUWWXNhjFUQLcU79HycYjkC * tools/skia_goldctl/mac_amd64: x0lVRcTpz47HUZXm2WnVv16tuAKSZ-QUF9A1T1j2RykC..IEdOBXQmFOksbZa16aKIWU6uYVYJlgvPwyX3wktMkkIC * tools/skia_goldctl/mac_arm64: Cbv4TR0stWg2pA84PBfgi-N9jV07KWhEcAsg8ZX8ZkYC..XtI7k09JHcA8aaaRNlOF92uDqOXfr8HMmepwH0q9uk0C * tools/skia_goldctl/win: 0Z6Y_DY-axS2RajDae9CHJrDn1a4CTif2VkT4CR5jOMC..3uvz7bDTL-QoL5KPX-caB_HxcvVE7JamyMibu71hqHAC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Id9387ce54c2a15b3d6cfbd56deba3e45608cd500 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3411541 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 096c268b 2022-01-12T15:21:02 Add a few overrides for Samsung 1. Enable perFrameWindowSizeQuery feature 2. Return correct vendor string Bug: angleproject:5111 Change-Id: I9efb0d2168994c6f209d8730c658f2568f3d3afa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3387848 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 339a6d18 2022-01-23T19:17:02 Roll vulkan-deps from c9b583de6eb8 to 238eaa6f9d25 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c9b583de6eb8..238eaa6f9d25 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8a40f6de57..c38495656d * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/60d17fe6c6..dab15e0c45 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e5c8d9bc16..4bd7579d17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I49a552caddb07cf78165dca447b4c86ceb577ca5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3411311 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 0f00fbae 2022-01-21T00:28:48 Translator: Make vec/matrix size getters unsigned TType stored type's primary and secondary sizes as `unsigned char`, but the getters returned `int`. This caused unnecessary casts when the size was passed from one TType to another, as well as comparisons with other unsigned numbers. This change specifies the type of these members as `uint8_t` and makes the getters return the same type. The call sites are accordingly adjusted to remove unnecessary casts, use the correct type in local variables, and add casts when passed to ostream::operator<<. Bug: angleproject:6755 Change-Id: Ia4d86bd4ccb5c1a2ae1e10a0085a5166c3a6bcf7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402850 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev ca3b28b4 2022-01-21T14:59:47 Metal: Fix compressed texture initialization and add DXT1 test There was a divergence between WebKit and upstream ANGLE in InitializeTextureContents' handling of compressed textures. Align upstream ANGLE with WebKit, fix a problem with emulated compressed texture formats like ETC2, and add a new test: DXT1CompressedTextureTestWebGL2.InitializeTextureContents Bug: chromium:1289428 Change-Id: Ieac6b99a4b19a34d0d87b7577882760ea395c605 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406746 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Kenneth Russell 4a5a559d 2022-01-21T09:20:28 Update Metal/iOS status from "planned" to "in progress". Apple has upstreamed basically all of their changes to ANGLE's Metal backend and are successfully using it on iOS, though this code path isn't yet being tested on ANGLE's waterfall. Bug: angleproject:6934 Change-Id: I3eda46d84fb84282cd70a043740de532c3389f78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402336 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Mohan Maiya a0fbcb37 2022-01-13T14:26:58 Vulkan: Remove flush from SyncHelperNativeFence::serverWait The spec doesn't require a flush in native fence's server wait method Bug: angleproject:2517 Test: EGLSyncTest.AndroidNativeFence_* Change-Id: If6870fe1e25ddf3a1b724e776f5408523a7bdf50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3388231 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 038d2877 2022-01-21T19:30:35 Roll VK-GL-CTS from bfede065f419 to 97ceb2222747 (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/bfede065f419..97ceb2222747 2021-12-03 syoussefi@google.com Fix shader operator tests' precision expectation 2021-12-03 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/master 2021-12-02 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,syoussefi@google.com Change-Id: I1f86fa13ebba9d7e74aee087c5ea8403033b5171 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3407858 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 29e25468 2022-01-07T07:02:53 Account for EGL 1.5 version when dealing with robustness EGL 1.5 spec allows for EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY and EGL_CONTEXT_OPENGL_ROBUST_ACCESS enums to be passed in to eglCreateContext. Update the validation layer and queries to account for the new enums. Bug: angleproject:6883 Tests: KHR-NoContext.es32.context_flags.*flag* Tests: KHR-NoContext.es32.robustness.*reset* Change-Id: I7088e0dca08cea2cfdcf1877b6d999c0e0336e5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373133 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Yuly Novikov 78d482e5 2022-01-13T14:49:26 Add standalone ANGLE Pixel 6 experimental bots The bot only runs dEQP tests with Vulkan backend, not GLES. Also skipping non-Vulkan tests in angle_end2end_tests. Also no perf/trace tests, as these time out uploading to device. Adding suppressions for the failing tests at the same time. Bug: chromium:1280418, angleproject:6819 Bug: angleproject:6898, angleproject:6899, angleproject:6900 Bug: angleproject:6905, angleproject:6907, angleproject:6908 Bug: angleproject:6909, angleproject:6910, angleproject:6916 Bug: angleproject:6917, angleproject:6918, angleproject:6919 Bug: angleproject:6931 Change-Id: I3598e6ff7f458ad7ab2defb86e02a17fbf2d20ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3387108 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Brandon Schade a5e22715 2021-09-30T17:03:34 Vulkan: Fixed TC shader and gl_PerVertex block interaction TransformSpirV() does not account for the fact that the tessellation control shader's output gl_PerVertex block is a named array. This results in the input and output blocks being sometimes flipped. Added code to track the IdRef of both input and output array gl_PerVertex blocks and swap them if necessary. Bug: angleproject:5557 Tests: KHR-GLES32.core.tessellation_shader.tessellation_control_to_tessellation_evaluation.data_pass_through Change-Id: Ie3823701b4eaa53daa8ca34faab657f54d8aee38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208513 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Peng Huang a64d52fd 2022-01-21T13:09:34 Add ANGLE_FORMAT_PRINTF() for catching format errors Bug: chromium:1288391 Change-Id: I0856d09b924ccce8192cad8cd7b590e0098ec5d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402851 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 31bb03fe 2022-01-19T10:06:49 Add more tests for program pipelines. Bug: angleproject:3570 Change-Id: I2fa5ea6d90a15f4ec8ee41cde6921c30923974c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402099 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll e6ed6977 2022-01-21T10:01:09 Roll SwiftShader from 2e74d5dc03df to e823eef17385 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/2e74d5dc03df..e823eef17385 2022-01-20 bclayton@google.com BUILD.gn: Remove XCB sources for chromeos. 2022-01-20 bclayton@google.com BUILD.gn: Remove VK_USE_PLATFORM_XCB_KHR define 2022-01-20 capn@google.com Remove heap size padding 2022-01-20 capn@google.com Disable Kokoro builds with REACTOR_EMIT_DEBUG_INFO/PRINT_LOCATION If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:6444 Tbr: syoussefi@google.com Change-Id: I3f5e70a662cc81908008294f521fc24d7f640032 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406608 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a4b312c0 2022-01-21T10:01:03 Roll vulkan-deps from 70b3eb7a5ab4 to c9b583de6eb8 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/70b3eb7a5ab4..c9b583de6eb8 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f7828a52f1..e5c8d9bc16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I6d84a63613c38b3f8ea637ae4c79969b1d9b9072 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3406624 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 515f60bd 2022-01-20T17:39:48 FrameCapture: Keep MEC Setup resources in Reset. This fixes a regression in Reset when using MEC introduced by 462cdb08e395edbf5bace1408715e35239a0b1fa. Don't call MaybeCaptureUpdateResourceIDs in maybeCapturePostCallUpdates before capture starts, since it's adding resource IDs to mNewResources. Don't add resources to mNewResources if they are already in mStartingResources in CaptureUpdateResourceIDs. Add FrameBuffers to mStartingResources before MaybeCaptureUpdateResourceIDs is called. Add Buffers to mStartingResources before calling MaybeCaptureUpdateResourceIDs. Add VertexArrays to mStartingResources in CaptureMidExecutionSetup. Bug: angleproject:4599 Bug: angleproject:6870 Change-Id: If428cbbdbcfa17c221b9e110a990cf6ebc9107c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3404087 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 034b5058 2022-01-21T08:38:24 Roll Chromium from d5bf6f7f9376 to b7f974a39665 (478 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d5bf6f7f9376..b7f974a39665 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/841e388a14..906b90c327 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/7d7912617f..fd0ef6db30 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/efb2cbd374..295f84c04f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/12a61da8be..9ef62302b2 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/5023a5c74e..f0d4a3b4c8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8bc3659ded * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a657331e90..6bfbe35cce * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/5227e7d830..2dc9e853e1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/df50898d39..170758333f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4b17b6153e..d5139d0314 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2fc4907330..ae043af23c * tools/python: https://chromium.googlesource.com/chromium/src/tools/python/+log/373d1fcd62..a21ec45e2d No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I4c867084c33a525d368d0784131a89be68736df0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402335 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 1ab6c9f6 2022-01-20T18:37:56 Hide ES 3.0+ extensions from ES 2.0 clients Bug: angleproject:6928 Change-Id: I0aa1a9c124022fb7d89c2889b18817573ec271a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3404083 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Brandon Schade 2caa9d4f 2021-10-04T09:43:57 Vulkan: Add missing glGetProgramPipelineiv parameters handling The glGetProgramPipelineiv function call was missing the case handling for tessellation control and evaluation shaders. Bug: angleproject:5557 Tests: KHR-GLES32.core.tessellation_shader.tessellation_control_to_tessellation_evaluation.gl_MaxPatchVertices_Position_PointSize Change-Id: Id888d1a9ae94228a33cfabcc7f65d1f63d596425 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208511 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Charlie Lao d2354968 2022-01-20T10:59:05 Vulkan: Rename BufferHelper::initFor* to allocateFor* Simply name change per feedback from other CL's review. Bug: b/205337962 Change-Id: Ieb53ed9a2922d09716a1219eb340fe273e5f1807 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402882 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao a83f7e91 2022-01-19T14:14:16 Vulkan: inline some of the BufferSuballocation APIs These are simply get* calls and frequent used ones. The measurement I have on Pixel6 shows there is 0.01ms out of 2.28ms on CPU overhead with asphalt_8 app trace measured with --minimize-gpu-work. Bug: b/205337962 Change-Id: I746a1ccc67c589d1aba25495601ad874ddc034a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3403159 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 1b5efe51 2022-01-19T14:04:35 Vulkan: Rename SubAllocation to Suballocation Simply a name change to make it one word. No functional change is expected. Bug: b/205337962 Change-Id: Ic505536821f18141c0d036b13d9aa81554a8bafd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3403158 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 659725aa 2022-01-20T15:24:40 Metal: Cleanup texture caps init The removed line is redundant as the ASTC texture support is enabled during the setTextureExtensionSupport call. Bug: angleproject:6874 Change-Id: Ib9016e4d40acf1f466fa10920384b7419e6fed49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3404100 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Jamie Madill 3064920a 2022-01-19T11:48:57 Capture/Replay: Serialize ActiveTexturesCache. Also add group scope to samplers. Bug: angleproject:3570 Change-Id: I616a54d95544af1e3c4eeff196806e5bfb20292e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402100 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 16164321 2022-01-20T10:01:03 Roll vulkan-deps from d1b842fca80d to 70b3eb7a5ab4 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d1b842fca80d..70b3eb7a5ab4 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/b8047fbe45..b42ba6d92f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f79e0540ff..f7828a52f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I06741f05fce94233d72452a7b8ff26f5d67a2602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3404258 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7ff95f28 2022-01-20T07:01:19 Roll Chromium from b24759852b71 to d5bf6f7f9376 (533 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b24759852b71..d5bf6f7f9376 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7fe67152ba..841e388a14 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/94855f7b7c..7d7912617f * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/57e4aff4a1..efb2cbd374 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/476fe6fd8d..12a61da8be * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/914c1d8c62..e79b8ea964 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8bc3659ded * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb340f5b7b..a657331e90 * tools/luci-go: git_revision:d1e877e2b3e5a05a5cd34c4a340fedba14a16c2b..git_revision:5b02a4aaeb5fd78d6fe41d6d54d1cb58da17f192 * tools/luci-go: git_revision:d1e877e2b3e5a05a5cd34c4a340fedba14a16c2b..git_revision:5b02a4aaeb5fd78d6fe41d6d54d1cb58da17f192 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f500acb211..4b17b6153e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/160d34ae85..2fc4907330 * tools/python: https://chromium.googlesource.com/chromium/src/tools/python/+log/d17f53e496..373d1fcd62 No update to Clang. Bug: angleproject:6884 Tbr: syoussefi@google.com Change-Id: I5296d957f9def6b02f5a5553dfbacab444768768 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3403968 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kyle Piddington 1bd1a3db 2022-01-06T15:08:48 Metal: Canvas resizing causes webpage to run out of memory For https://bugs.webkit.org/show_bug.cgi?id=232122 Introduce a maximum resident amount of memory that a single command buffer can use, before forcing a flush. As part of ensuring that a command buffer is ready, check to see if this limit is exceeded. if so, flush the command buffer, and create a new one. Bug: angleproject:6880 Change-Id: I5e89735d05adbc174237ab79b006a75bbe89e560 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3369922 Reviewed-by: Gregg Tavares <gman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Charlie Lao 15439f8e 2022-01-13T14:58:41 Vulkan: Remove BufferMemoryAllocator This class was added in crrev.com/c/3036256. The original intention was to use VMA to implement buffer suballocation. Because VMA itself does not support buffer suballocation, I was thinking to use VMA custom pool to implement it and this class was intended to wrap all these functionality into one class. But now thanks to Jamie's effort, VMA exported generic suballocation algorithm via API and we have implemented buffer suballocation using that virtual allocation API. So this BufferMemoryAllocator class is really no longer useful. This CL mostly reverted that CL and flatten out the buffer allocation call to directly use VMA's Allocator object. Bug: b/205337962 Change-Id: I0336056e440f39e2ff49fee8e0ff4b1f355cefe4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3244022 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Yuly Novikov dcac02ac 2022-01-19T21:30:21 Revert "Enable robustnessEXT for SwiftShader." This reverts commit b803b60df1806f189c1b29ca77da47896241e0f1. Reason for revert: blocks roll into Chrome - anglebug.com/6922 Original change's description: > Enable robustnessEXT for SwiftShader. > > Bug: chromium:1287631 > Bug: angleproject:6906 > Change-Id: I3c8c32561a1ac7860c83b8d3ba22aafd0bf81fd4 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3390489 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Roman Lavrov <romanl@google.com> Bug: chromium:1287631 Bug: angleproject:6906, angleproject:6922 Change-Id: Ic8ff7dd996455009037cbff9e10b6fbbc420b37e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402820 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0