kc3-lang/angle

Log

Author Commit Date CI Message
Geoff Lang d40669bb 2023-07-17T11:49:13 Android: Use ALooper_pollOnce instead of ALooper_pollAll ALooper_pollAll can cause potential deadlocks. These calls are only made by our test suites. Bug: chromium:1464077 Change-Id: Id56c0db67e10d6df00c3e6b9126952ffa1d40d48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4690382 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 0518a3ff 2023-07-14T14:53:39 Android: Simplify power metrics collection Also check for missing values and dupes Bug: b/291604008 Change-Id: I909ca2bf53d3aa0bf5ba66f7168e9925cfd7da3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685323 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi bebb83d9 2023-07-14T12:30:15 Translator: Limit variable sizes vs uint overflow Bug: chromium:1464680 Change-Id: I90e204db1ce57c87ed5fe19912e4c157cee18a90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685236 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 05ea1147 2023-07-14T16:49:24 Vulkan: Bugfix in gl_FragData array redeclaration Both OpenGL ES and Vulkan spec allows implementations to limit the number of output attachments when dual-source blending is enabled. Account for this limit when setting gl_FragData array length by re-declaring the gl_FragData array size to match maxFragmentDualSrcAttachments value. Bug: angleproject:5537 Test: EXTBlendFuncExtendedDrawTest.FragData/ES2_Vulkan Change-Id: I5a462344f4c4faf850f56e9c5d4c392370d3d010 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4688396 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi bd8001e5 2023-07-17T11:32:23 Fix deadlock on device loss Some backends generate a device loss (propagated to all contexts) while querying the device status. The latter is held under a lock, and the former would attempt to hold the lock when marking the calling context with device loss. Bug: chromium:1465262 Change-Id: I55fd96f3573732953daf2a305b0120dbcae6ea30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4690063 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov e8e17211 2023-07-17T15:20:14 Retry angle_deqp_gles2_metal_tests Flaky crashes in OSXWindow::messageLoop(), like the other GTest based tests on Mac, which already have retries enabled. Bug: angleproject:6570 Change-Id: I65ffc4b09a6ece68dcfe404055fcfe50d013c000 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685573 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop a04d5443 2023-07-17T09:09:02 Docs: Add a couple of Android pointers Hit some rough edges while setting up a clean install. Bug: angleproject:4347 Change-Id: I241cddac0c86d0eb00195e42304f50e2c7bba5e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4688533 Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov c0f2f71e 2023-06-27T16:00:09 Use VK_EXT_legacy_dithering when available instead of emulation Yields improvement in gpu power: http://b/284462263#comment45 Bug: b/284462263 Change-Id: I5bfd115557b6baac17c05639118feaebf19c5cd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4652590 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuly Novikov d04dda15 2023-07-17T14:29:44 Skip WebGL2CompatibilityTest.DrawWithZeroSizedBuffer on iOS GL Bug: angleproject:8264 Change-Id: Icac83200b8e9aa35ba3e85be8b34bd45e616a8bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685572 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll a18246ac 2023-07-17T07:26:08 Roll Chromium from 68d783529187 to 48a8f73f303f (690 revisions) https://chromium.googlesource.com/chromium/src.git/+log/68d783529187..48a8f73f303f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7565823755..a158d61f27 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2bac855313..b98bc2989c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/6514de5457..9ce3e620bd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..394c179782 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/abbd5858fa..b389d031a2 * third_party/fuchsia-sdk/sdk: version:13.20230711.2.1..version:13.20230714.0.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4786f206b4..c05e52187e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f8f7cb6141..5ce938841d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/86375f9e21..a2303f1c72 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/27e9a92f3b..e10259da24 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I3f305f69842c73569aad368fb3fb7d222c91d231 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4688527 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Dave Tapuska 507f67cc 2023-07-14T15:23:48 Fix cfi issue with Angle invoking worker pool Mark the function as ignoring cfi-icall because of broken upstream builds. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20CFI/25615/overview Bug: angleproject:8256 Change-Id: I63b5fee27bc0565dc6881bd83fd284abc7a9f1f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685324 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Roman Lavrov c5b7fc36 2023-07-14T15:39:25 Ensure settings get cleaned up on exceptions Before this change, Ctrl-C or another exception leaves settings behind Bug: b/284462263 Change-Id: I5694cbb2ca7d43a4173099d126e6695e07ec9d2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685238 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov d6dc46db 2023-07-14T17:51:26 Revert "Add minimal setup for Go codegen in Android.bp." This reverts commit 9f7b6babe1fd7313a6a344d037aed542505d126e. Reason for revert: No longer appears needed as 1) number of diffs was greatly reduced via cc_default 2) build configs got simpler with switching to platform zlib. No recent conflicts introduced by build scripts Original change's description: > Add minimal setup for Go codegen in Android.bp. > > Based on Cody's http://ag/19603310. > > Only adds libEGL_angle_codegen to libEGL_angle and is a no-op. > > Tested in an aosp checkout. Hopefully this doesn't cause merge conflicts > with internal master as all diffs are close to the top of the file. > > Android.bp diff: https://paste.googleplex.com/6626641357832192 > > Bug: b/242929755 > Change-Id: I6d7ac9f3dd502074c41838bd1aa10075a8c99145 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3876890 > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: b/242929755 Change-Id: Id4cbdf68e9704138396ee1bef7a4f1edef3f50cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685320 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 97368229 2023-07-14T17:09:15 Skip dEQP-EGL.functional.native_[color|coord]_mapping.native_window.* Skip on all platforms instead of the individual suppressions, that let test failures to slip into build failures. Bug: angleproject:8261 Change-Id: I16a5eaceb5fe49dc4e23233bfe4fe146b77a95f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685567 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Geoff Lang 972f8107 2023-07-14T12:05:40 Reject program binaries when the renderer string changes If the underlying driver changes, reject program binaries from the old versions. The driver is supposed to do this for us (on OpenGL, at least) but this adds some extra protection. Bug: angleproject:4981 Change-Id: Id9486d8e6f9136970c0d7c37d59dea5d43b0a50e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685317 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang c0cd00e8 2023-07-12T13:51:11 Sync all framebuffer attachments when checking completeness. If the backend requires that a framebuffer is synchronized before checking backend completeness, make sure all attachments are synchronized too. GL has completeness rules based on GL_BASE_LEVEL and GL_MAX_LEVEL of texture attachments which are not syncrhonized until the textures are. If they are left un-sychronized during completeness checks, the driver will tell us that the framebuffer isn't complete. Bug: chromium:1455725 Change-Id: I7c3bf6a38f63feaa863f4d8914c3655e286dd768 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678286 Reviewed-by: Brian Ho <hob@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 5032f08b 2023-07-13T15:23:49 Translator: Unconditionally limit variable sizes ... instead of just for WebGL. This is to avoid hitting driver bugs that were prevented with this check for WebGL on a compromised renderer that can create non-WebGL contexts. Bug: chromium:1464682 Change-Id: I47a9d9690bd1ca9d701391fb7d70932f2dbe7334 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685307 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 35c077b1 2023-07-14T13:22:24 Remove obsolete VUID suppressions 02859 was renamed to 08608 and 06538 was renamed to 08753 in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/6008/commits/0cc78b9c282aa3e97316e739b88641a5d45f9463 Bug: angleproject:8242, angleproject:8119, angleproject:7105 Change-Id: Icde11d7c5b598bfb617d899daa795d3e19c8a178 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4687419 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang cc8ea4c2 2023-07-13T12:41:56 Metal: Call terminate if display initialization fails. This ensures that any resources that were partially initialized are cleaned up. This is a speculative fix for dual GPU macs not falling back to the low power GPU. DisplayMtl leaks the metal device if it fails to initialize due to unsupported GPU families or vendors. Bug: chromium:1322521 Change-Id: I93930de8c07bb94318ac41c67513a3b1c8bd3bf0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4681842 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 8f76a7eb 2023-06-20T16:15:22 Metal: Use the pipeline cache for RenderUtils compute shaders This ensures that all pipelines created in the Metal backend are stored in the single pipeline cache. Bug: chromium:1329376 Change-Id: I99db93426acb3467be41d1fca5238b34553f6684 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4628680 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 75dd634d 2023-07-14T10:01:08 Roll vulkan-deps from ad8a66bf7d69 to aa35b58fce7d (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ad8a66bf7d69..aa35b58fce7d Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/44779f508a..f47028995c * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9ab811a125..29431859f5 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8b94e87bff..6837a92c34 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c3065a7aed..80679543ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I5edc436c35669da2ddddd038c9895216781c211c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684021 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll da9ccc01 2023-07-14T07:00:12 Roll Chromium from de1153f640b8 to 68d783529187 (590 revisions) https://chromium.googlesource.com/chromium/src.git/+log/de1153f640b8..68d783529187 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4c5f2bf0f3..7565823755 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8d21803b90..d6ce172e32 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a59ee3caa2..2bac855313 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..afb1d77b69 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7265d88a45..abbd5858fa * third_party/fuchsia-sdk/sdk: version:13.20230629.2.1..version:13.20230711.2.1 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/ffa8abcd30..80da587681 * tools/luci-go: git_revision:1b0aa1222dd6e11673230e5b093d0a8ed6244e95..git_revision:f02582af78f530a7bbfe2f059fa5d211c9517756 * tools/luci-go: git_revision:1b0aa1222dd6e11673230e5b093d0a8ed6244e95..git_revision:f02582af78f530a7bbfe2f059fa5d211c9517756 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f7c0d5e54a..f8f7cb6141 * tools/skia_goldctl/linux: rm5mLaL8XD6eQvwq5a1oqtyfUbbjnUo1uQlcF6zoxLAC..Q5cqdj5BQE3eWNCe2CqhLT13X-o0w1ta7V2XnmXIrnEC * tools/skia_goldctl/mac_amd64: D2Xn7R8I-IEY0P-2JklhAHVSbuuUizevvyMlfXENjKkC..YieDEr0s0SH8j_1Os9w89pblPmGHE2vvLJtvdTYamfAC * tools/skia_goldctl/mac_arm64: xKGurBAqifTBoPNsTYQDrb9o_k5Twba5Dh1qwgE3iR8C..isJD0ZhCCqmn1h8q6_12lvDCcKt_M-8v548oOoQwpN4C * tools/skia_goldctl/win: rpb78oS4WtlmYjaFPtWhEWaEIOXmzXAoSTnFu9WwSmsC..OzmCj3mfsBuDD-gOktZNf1BcL8eg8Ewi8ekcYDI4tsAC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I96f28cdabed15d6d46736d0dfc49a7eba527f655 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684436 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 19c4e885 2023-07-13T15:24:03 Update input color in YUVSampleLinearFiltering test This test uses narrow range encoding (as can be seen from the color value for black) but the Cr component for red is greater than 240. On some platforms with different clamping logic the output color after conversion ends up not being red. Update the input colors to account for different implementations. Bug: b/210526871 Test: ImageTestES3.SourceYUVAHBTargetExternalYUVSampleLinearFiltering* Change-Id: Ib9b76c9433b07f5ce8a129779e77bc682bb341ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684018 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 817f4b81 2023-07-10T00:00:00 Restrict color writemasks for RGB9_E5 color buffers Per-channel write operations to shared exponent color buffers are loosely defined and may cause driver validation errors. Restricted the set of allowed color writemasks for RGB9_E5 color buffers so that RGB channels must be either all enabled or all disabled. Added a Metal-specific adjustment to ignore alpha writemask for RGB9_E5 color buffers. Removed an unused function from RenderPipelineColorAttachmentDesc. Bug: angleproject:8043 Change-Id: I902c3b70ddc6d8e65069d98a4a02a82122f413a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685566 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 6ffd0d20 2023-07-12T12:09:45 Vulkan: Clean up depth stencil feedback mode part 2 Right now the tracking of depth stencil buffer readOnly or feedback loop is in FramebufferVk class. This really belongs to ContextVk, since it is not a permanent state of framebuffer, but current state of context. This CL moves it to ContextVk and changes to use BitSet instead of four boolean. Bug: b/289436017 Change-Id: I955c439259935f82eff30ddfff776a69723e5d0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679886 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao a33ec5dd 2023-07-11T18:01:12 Vulkan: Clean up depthStencil feedback loop implementation Part1 This is first clean up effort for depth stencil feedback loop implementation. This CL moves updateRenderPassStencilReadOnlyMode and updateRenderPassDepthReadOnlyMode methods from FramebufferVk to RenderPassCommandBufferHelper class. The method is actually updating renderPass's state, not FramebufferVk's state. In the next CL, FramebufferVk will be removed from the argument as well. With this change, I also removes updateStartedRenderPassWithDepthMode() and updateStartedRenderPassWithStencilMode() to use updateStartedRenderPassWithDepthStencilMode() directly. This CL is mechanical changes only, no behavior chnage is expected. Bug: b/289436017 Change-Id: Id3960f973a7115c05ebea199cb8ef802e995941a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679365 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yiwei Zhang 79ebd10a 2023-07-13T23:23:27 Vulkan: disable explicitlyCastMediumpFloatTo16Bit for Venus Workaround for platforms shipping Venus until vk-gl-cts issue 4554 gets resolved. Bug: b/290425152 Test: CtsSkQPTestCases org.skia.skqp.SkQPRunner#gles_gradient_many_stops Change-Id: Ia05d905a9b56264164ed3325e4966dd2976b1fe9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684548 Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 74cf6a3a 2023-07-12T14:44:17 Ensure lockless entry point validations only access private data Bug: angleproject:8224 Change-Id: I19e867923b088879f9f37d0a3b4ff8b681470be0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678352 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 3a0da09d 2023-06-22T15:07:11 Metal: Cache compute pipelines for provoking vertex emulation Remove ProvokingVertexComputePipelineCache and update ProvokingVertexHelper to use the PipelineCache. Bug: chromium:1329376 Change-Id: Ifca89fbb572d850c806b24f124fb86c65eec4f11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4637204 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 927410a8 2023-07-13T15:02:58 Prevent accidental misuse of ANGLE_ENABLED ... by removing it altogether. This macro was only available when features.h was included. If that header was not included, the preprocessor would automatically consider it 0, which has the opposite effect from what was desired. Bug: angleproject:8256 Change-Id: Ia141573c0c8b44eef1388f4c3ec73ef770cd2854 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685226 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 75254b98 2023-06-22T15:06:29 Metal: Cache compute pipelines with render pipelines. Support caching of compute pipelines in the same LRU cache as render pipelines in mtl::PipelineCache. Bug: chromium:1329376 Change-Id: I93bbfadb8f5c1461144f1c222362c174402cced1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4628673 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
Dave Tapuska fe08eee8 2023-07-12T18:03:30 Fix Angle creating its own worker pool. The WorkerPool was created on the first postTask and could create a number of threads. We were seeing this on blink for iOS where we would have expected using the delegate's worker pool. However ANGLE_ENABLED was undefined because it wasn't included. This caused the comparison of ANGLE_DELEGATE_WORKERS to not work. Instead of including the header for ANGLE_ENABLED since that would cause a dependency on libAngle, just use #if X instead, while this also isn't the best because X can be undefined its a solution for now. Bug: angleproject:8256 Change-Id: I5aeb686dcc117feaba884cdea5c89e4b146cb57f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679894 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 2a524390 2023-07-13T13:04:37 Make insertion/retrieval of Debug messages thread-safe Bug: angleproject:8135 Bug: angleproject:8224 Change-Id: I5ad53b6bb57fe3ee2a261d4e52b7027736fddfd1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4681843 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 435d575c 2023-07-10T00:00:00 Skip component type validation of non-existent draw buffers The default framebuffer is initialized with just one draw buffer slot so WebGL-specific validation causes an assertion when clearing not present draw buffers. Bug: angleproject:2831 Change-Id: I23ceb3f31dd8bae005fe8497cf20c49880f37938 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4683451 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Geoff Lang fbf9e3c7 2023-06-12T16:58:04 Metal: Use the per-context pipeline cache for RenderUtils The various RenderUtils classes created hundreds of RenderPipelineCache objects which did not reliquish their pipelines for the life of the Display. Hook them into the per-context PipelineCache so that they share the total pipeline limit with programs. Make RenderUtils fully RAII and store it in a unique_ptr in DisplayMtl. Remove RenderPipelineCache. Bug: chromium:1329376 Change-Id: I265e4e05fd3fd1da34932de36803cfe977f1f6a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4607153 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cody Northrop cdb822e7 2023-07-13T09:45:00 Revert "Android: Assert that CFI is disabled" This reverts commit 43ef50f389e97131dc487081d6c8c02373e4a22c Reason for revert: LLVM bug is fixed upstream. Fix: https://reviews.llvm.org/rG92fbb602f3b635110417e40e2f774b31798b0b1d LLVM Roll: https://chromium.googlesource.com/chromium/src/tools/clang/+/243d4473a3739d43cab35eeb0b4934bf5f7a7d05 CLs in the roll: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/7586aeab..0c545a44 Original change's description: > Android: Assert that CFI is disabled > > There appears to be a bug in the interaction of CFI and > relative vtables. On armv9 it results in a crash with SIGILL > when loading traces. > > Since we can't overwrite the flags used to control this > just assert that it is correct in GN args. > > To avoid the assert, add the following to your GN args: > > arm_control_flow_integrity = "none" > > Test: Build and run traces on armv9 devices > Bug: b/278955379 > Bug: chromium:1441148 Test: angle_trace_tests on ARM v9 device with flag removed from GN Bug: b/278955379 Bug: chromium:1441148 Change-Id: Ib90405a143503896041c2522f484c234a943a6fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684008 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi c9a42949 2023-07-12T15:07:17 Make validation make straight calls to ErrorSet ... and avoid going through the context (just to get a const cast). This change is also in preparation for an follow up where some entry points directly use ErrorSet and don't access context at all. Bug: angleproject:8224 Change-Id: Idef0a88d9407870e7a84b4fe6967fbff175c269b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678350 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 79f5b73a 2023-07-12T12:55:51 Make error handling and debug messages thread safe Bug: angleproject:8135 Bug: angleproject:8224 Change-Id: I1527b6a02d917724034873b5206f2006ae0eaf05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678284 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 84b53359 2023-07-13T00:06:48 [ssci] Roll VMA forward for README.chromium change See the LSC doc at go/lsc-chrome-metadata. Bug: b/285450740 Change-Id: Ia4430b6ecfeb85738dcc80c0fd65e256510261e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4681127 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
yanhongchen b03a018c 2023-06-15T19:36:16 Android: Add privapp-permissions XML Bug: angleproject:8210 Bug: b/242671681 Change-Id: I57d14eb026fab319e080cedcfefd5c160c1321d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4617552 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
Geoff Lang 1d496191 2023-07-13T14:14:08 Revert "Terminate the display if initialization fails." This reverts commit ebaadc6c2cba4085e0d31ca7deebd00192e33f64. Reason for revert: Breaking some Chrome/Dawn tests that use the VK backend Original change's description: > Terminate the display if initialization fails. > > If DisplayImpl::initialize fails, call terminate to ensure no resources > are leaked. > > This is a speculative fix for dual GPU macs not falling back to the > low power GPU. DisplayMtl leaks the metal device if it fails to > initialize due to unsupported GPU families or vendors. > > Bug: chromium:1322521 > Change-Id: Ie227216bc92ef2834ec50190fbb78bec45e9c053 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4641107 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> Bug: chromium:1322521 Change-Id: I379521130071623a8d050d2cadf2059c0b696d32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678359 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 394c90ea 2023-07-12T15:58:04 Remove stale autogen files The GL entry points were combined per major version in: https://chromium-review.googlesource.com/c/angle/angle/+/2566592 But the stale minor-version based autogenerated files were not removed. Bug: angleproject:2621 Change-Id: I8c793a7d5e44e323dd4d702747ccb9bb58105e19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678351 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi fd80ef86 2023-07-12T13:35:44 Remove redundant mip-level-size validation The ValidImageSizeParameters function already calls ValidMipLevel. The few places that called ValidMipLevels are fixed not to redundantly do so. Bug: angleproject:8224 Change-Id: I8e0745edb68be97a6903d7801560212cc53d0d6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678285 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 27465cda 2023-07-13T10:01:05 Roll vulkan-deps from 4ba3255697ef to ad8a66bf7d69 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4ba3255697ef..ad8a66bf7d69 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/d0006a3938..f1ba373ef0 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7ff331af66..9ab811a125 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/011b0090ed..c3065a7aed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ibb6582a8c777d7aa38318c439fa0a98104634db7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4681277 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a7e31a4e 2023-07-13T10:01:15 Roll SwiftShader from dda70a3ef9fe to 151fa797ee3e (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/dda70a3ef9fe..151fa797ee3e 2023-07-12 aredulla@google.com [ssci] Added Shipped field to READMEs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I6e8b8e0d551766b260adc255f3ede6966719f4e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4683185 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6946ca87 2023-07-13T07:00:34 Roll Chromium from 3d5d845687d5 to de1153f640b8 (604 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3d5d845687d5..de1153f640b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e7cd327c47..4c5f2bf0f3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0732a94e42..a59ee3caa2 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/14eb523de5..996d3d5271 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4ca1551fb4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/43bf9b7258..7265d88a45 * third_party/r8: GB_DKiGwJt0TJAnCuEsWhGQdS_JTlr-KQRb0J6aO-r8C..Sz7S7AlqFPYB_t29P5b6i5K80Wq00mpvN2y8aNUAqo0C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/1206f0dbef..61dc0bd13f * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e5b5f210e7..ffa8abcd30 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c29b6b927f..4786f206b4 * tools/luci-go: git_revision:5d9f8239e3691bb585eeb88103ee6b4a8d212c0e..git_revision:1b0aa1222dd6e11673230e5b093d0a8ed6244e95 * tools/luci-go: git_revision:5d9f8239e3691bb585eeb88103ee6b4a8d212c0e..git_revision:1b0aa1222dd6e11673230e5b093d0a8ed6244e95 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3fd043fc8b..f7c0d5e54a * tools/skia_goldctl/linux: 6IuiEt6PqBPJ4kLiJ80ktH5SSuZwmG3r9o0xjRAYkNkC..rm5mLaL8XD6eQvwq5a1oqtyfUbbjnUo1uQlcF6zoxLAC * tools/skia_goldctl/mac_amd64: Ts8bufL5zc4XHclA3vKuDS5FyicKlY7XQ_luGzlpdQ4C..D2Xn7R8I-IEY0P-2JklhAHVSbuuUizevvyMlfXENjKkC * tools/skia_goldctl/mac_arm64: wk3OK108QbrE71cy85i0x-mRelw2_Hln3-7oAEyjA8cC..xKGurBAqifTBoPNsTYQDrb9o_k5Twba5Dh1qwgE3iR8C * tools/skia_goldctl/win: ECZgbn-oQ7jsny_alVyAdR5ZDzOuPhKMX-YhZPdfnBIC..rpb78oS4WtlmYjaFPtWhEWaEIOXmzXAoSTnFu9WwSmsC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I0f289bf738f9cd7cb1281d248e3669fc4956e2c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4681416 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 8ae9f28d 2023-07-11T16:35:19 Make context-loss state atomic This state can be set by other threads, including those without a context in the share group; context loss can originate from the Display and is propagated to all contexts. This change makes the relevant flags atomic which are read with relaxed memory order to minimize their impact on performance. Bug: angleproject:8224 Change-Id: I1f0a29210e07cd153db79fdc01d551cf96df4143 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678784 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao f5986fbb 2023-07-11T12:11:20 Vulkan: Dont break RP if there is actual render feedback loop There is a bit terminology confusion here that will be fixed in next CL. If a depth attachment is read only, then there is no feedback loop, we should not call feedback loop for read only depth attachment. The real depth render feedback loop mode is formed when we write to depth and sample from depth at the same time. In this condition, the content is undefined per OpenGLES spec section 9.3.1 (https://registry.khronos.org/OpenGL/specs/es/3.2/es_spec_3.2.pdf). The shouldSwitchToReadOnlyDepthStencilFeedbackLoopMode() implementation handles the usage case that the same render pass has depth write and then switch to read only. Under this usage there is no actual feedback loop, and we should still work properly by end current render pass and start a new render pass with read only depth attachment. This implementation also treating the actual feedback loop case exactly the same way by ending render pass first, even though this is undefined behavior. gangstar_vegas has the exact this undefined behavior usage case, where it write and sample from depth buffer at the same draw call. Native driver is not ending the render pass but ANGLE currently does. This puts ANGLE into worse performance. Since this is undefined behavior, either way is correct. This CL checks if there is an actual feedback loop in the current render pass and if yes, we adopt the native driver's behavior that keep the current render pass going. This improves gangstar_vegas frame time from 4.365ms to 3.89ms, and interestingly, yield the same golden image. Bug: b/289436017 Change-Id: Ifc04ecd8ad6455a88e8615bd5452b9cce88c6687 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679361 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 2a08c33b 2023-07-10T17:47:49 Vulkan: Avoid flushCommandsAndEndRenderPass for readonlyDS switch When we switch to read only depth stencil mode, right now we always call flushCommandsAndEndRenderPass, even though the started render pass is empty and loadOp is load. This flush will cause render pass actually submitted and color attachment being cleared and then color attachment gets loaded in the subsequent render pass. In this CL, we only flush if the depthStencil attachment has clear or written This CL save one renderPass for the following app traces: antutu_refinery, aztec_ruins, manhattan_10, manhattan_31. Bug: b/290833623 Change-Id: I13b7a968d797b4c913f1cfbe9677d9b8abe791d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674087 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 9962f078 2023-07-11T15:39:50 Pass only context-private state to private entry points This change ensures that the implementation for these entry points cannot access anything other than context-private state. Bug: angleproject:8224 Change-Id: I988672b138d861db25e91d71ab8c34baa4e8ebee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678783 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 491c2a54 2023-07-11T15:20:09 Split the context-private part of the state cache In preparation for passing it directly to entry point implementations, ensuring no access to the share-group-accessible part. Bug: angleproject:8224 Change-Id: I705e6a8fb5204bab71caffff4dcb56d16c3d6e10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678782 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 40111c68 2023-07-11T14:21:21 Rename context-local to context-private state Bug: angleproject:8224 Change-Id: I1bb39475043f8fb14d683d11a038b4850692a8c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678781 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop c93682d3 2023-07-12T11:08:25 Revert "Stop rolling third_party/cpu_features" This reverts commit da710ac3f731c128caf0aff75c0cd6e58a0591af Reason for revert: Causes Android roll to fail http://anglebug.com/8255 Original change's description: > Stop rolling third_party/cpu_features > > It was probably needed for zlib previously but now zlib already depends > on the ndk's cpufeatures. There are no references to third_party > cpu_features in the generated Android.bp. > > Bug: b/289259681 > Change-Id: Ib849b26391d0c23e533662094e74384c267c8620 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4656761 > Reviewed-by: Solti Ho <solti@google.com> > Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> > Auto-Submit: Roman Lavrov <romanl@google.com> > Commit-Queue: Solti Ho <solti@google.com> Test: scripts/roll_aosp.sh Bug: angleproject:8255 Change-Id: I2a879a3675a1c041a0e6ffff2be886aa693e486d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4680107 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 75e64719 2023-07-12T10:01:34 Roll SwiftShader from 3e73cce1c470 to dda70a3ef9fe (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/3e73cce1c470..dda70a3ef9fe 2023-07-11 jif@google.com [LLVM 16] Have Swiftshader built with Android.bp use LLVM 16. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ib06f37931e7291887caf54a19c4601d87e79066b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4681283 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Phan Quang Minh 4cab5e94 2023-07-12T10:04:10 Vulkan: Enable timeline semaphores if supported by device This is needed for a similar change in Chromium to function with `--enable-features=VulkanFromANGLE`. Bug: angleproject:8253 Change-Id: I422964ea010c650439dd4797ee8ba7b533f26a87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675807 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 2134a9de 2023-07-12T10:01:34 Roll vulkan-deps from 03c816988bfd to 4ba3255697ef (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/03c816988bfd..4ba3255697ef Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/eaa7057768..44779f508a * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4be7d0e3ca..7ff331af66 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/db290809b5..011b0090ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I82ccb55b54c9e8d30eb9a889a08cb48eb9f0771f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679255 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 94ceedb7 2023-07-10T00:00:00 Add GL_EXT_texture_compression_astc_decode_mode stubs Bug: angleproject:8254 Change-Id: I2a839139b5738710e32842b04db35eab8fb04687 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679683 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1aa2c87c 2023-07-12T07:01:45 Roll Chromium from d0f9360d7ae6 to 3d5d845687d5 (622 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d0f9360d7ae6..3d5d845687d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/143d726c8e..e7cd327c47 * buildtools/linux64: git_revision:11e12b0ef870b42ecd3b489a194c0c434a054d25..git_revision:fae280eabe5d31accc53100137459ece19a7a295 * buildtools/mac: git_revision:11e12b0ef870b42ecd3b489a194c0c434a054d25..git_revision:fae280eabe5d31accc53100137459ece19a7a295 * buildtools/win: git_revision:11e12b0ef870b42ecd3b489a194c0c434a054d25..git_revision:fae280eabe5d31accc53100137459ece19a7a295 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7a9572876c..0732a94e42 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/aa4f4558ff..e197e4c396 * third_party/android_build_tools/lint: z1zqFkwGcjud6JnSJ-81QiOYgD-OlvkQg5Fgt_gHwtoC..OPMAEfzTB1WPytaO0pMOPg9GHVByubIOUvOsCwKS1oQC * third_party/android_build_tools/manifest_merger: oD5bP72e45KzyT-yHx9yFfQcqpEfOUERdpMaR7rkTRcC..kxzD7gkXhEJiL_u2jVkpX0Npl2MLoSvbnBezhq29dAgC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2565a43987 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e5277508c8..43bf9b7258 * third_party/jdk: CAecD8de4xl5Dzo6fbtuVg-F4wY-ejtCBAmN3Qhj0J8C..9-e8GxXJduErc9j3s5VUmbAWTorSHxvcn23GNjYtCNwC * third_party/r8: FxcKKMhpNz8EQC9ZdDwB64ZzLm1VrWw21A_m20AOKaAC..GB_DKiGwJt0TJAnCuEsWhGQdS_JTlr-KQRb0J6aO-r8C * third_party/requests/src: https://chromium.googlesource.com/external/github.com/kennethreitz/requests.git/+log/refs/tags/..c7e0fc087c * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/7eff33bc00..1206f0dbef * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/7b20bcffe9..e5b5f210e7 * tools/luci-go: git_revision:15be1e7f953cb4ef6d88aba86f57ca28724d1c9a..git_revision:5d9f8239e3691bb585eeb88103ee6b4a8d212c0e * tools/luci-go: git_revision:15be1e7f953cb4ef6d88aba86f57ca28724d1c9a..git_revision:5d9f8239e3691bb585eeb88103ee6b4a8d212c0e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/56589b6087..3fd043fc8b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4b4a958480..86375f9e21 * tools/skia_goldctl/linux: 209WoWuXITgke_BJDnvM7aTy7wu2jFOUPYs4uIoJ3CAC..6IuiEt6PqBPJ4kLiJ80ktH5SSuZwmG3r9o0xjRAYkNkC * tools/skia_goldctl/mac_amd64: vEHTSSZiGWhNdCjMGZ22sj4PfyPzgoIIkV97YXOJeKEC..Ts8bufL5zc4XHclA3vKuDS5FyicKlY7XQ_luGzlpdQ4C * tools/skia_goldctl/mac_arm64: CcHM6-LZ7_b-Api718RTCYQPD0v17lWKuQBaz42b8r4C..wk3OK108QbrE71cy85i0x-mRelw2_Hln3-7oAEyjA8cC * tools/skia_goldctl/win: u5j7yik1xZdFc9dECFfFDX9vRP9go2GpqukfJwOLCbgC..ECZgbn-oQ7jsny_alVyAdR5ZDzOuPhKMX-YhZPdfnBIC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ie61d1ebe8be0620b0d41d6ee8a39d49b97a29527 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679254 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang ebaadc6c 2023-06-24T08:41:15 Terminate the display if initialization fails. If DisplayImpl::initialize fails, call terminate to ensure no resources are leaked. This is a speculative fix for dual GPU macs not falling back to the low power GPU. DisplayMtl leaks the metal device if it fails to initialize due to unsupported GPU families or vendors. Bug: chromium:1322521 Change-Id: Ie227216bc92ef2834ec50190fbb78bec45e9c053 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4641107 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Yuxin Hu 759027e8 2023-07-07T14:51:56 Enable the new deqp khr test suites on Bot This CL enables the deqp khr test suites added in https://chromium-review.googlesource.com/c/angle/angle/+/4654841 on below bots: pixel4 vulkan backend pixel6 vulkan backend windows vulkan backend linux swiftshader backend linux swiftshader backend tsan linux swiftshader backend asan The current linux driver on bot does not support the new test suites on vulkan backend. We will enable the test suites on linux vulkan backend after we upgrade the bot machine driver to a newer version: https://bugs.chromium.org/p/chromium/issues/detail?id=1271688 Bug: b/286921997 Bug: angleproject:8251 Change-Id: I659424efc09028f685edff076711c9089ec635d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4673582 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Oliver Wolff 6473008c 2018-08-22T13:12:07 winrt: Fix initialization of zero-sized window The clientRect might be empty when creating a window of zero size. The side effect of a division by zero is that matrix transformation fails and hence the swapchain gets into an invalid state. See: https://code.qt.io/cgit/qt/qtbase.git/tree/src/angle/patches/0005-ANGLE-Fix-initialization-of-zero-sized-window.patch?h=5.15 Signed-off-by: L. E. Segovia <amy@amyspark.me> Bug: None Change-Id: Idbaed72deadb7b87052ac27e194a40d1810e6f7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661674 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 9b63700b 2023-07-11T10:25:40 Translator: Reorganize files This change makes the translator files more organized by: - Grouping files that are specific to a certain output under their own directory, - Moving transformations under tree_ops - Removing Direct from metal translation now that that SPIR-V Cross path is removed Bug: angleproject:6394 Change-Id: Iaf5bb8d5604b84748dece029821b1f77b2813967 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678780 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang 4e6124da 2023-06-23T14:46:28 GL: Ensure all instanced attributes have a buffer with data Apple OpenGL drivers sometimes crash when given an instanced draw with a buffer that has never been given data. It's not efficient to check if the attribute is both zero-sized and instanced so just ensure that every time a zero-sized buffer is bound to an attribute, it gets initialized with some data. Bug: chromium:1456243 Change-Id: I66b7c7017843153db2df3bc50010cba765d03c5f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4642048 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Oliver Wolff 5922b83b 2018-08-22T13:01:10 D3D11: Fix Windows Store D3D Trim and Level 9 requirements Due to additional validation not covered in previous patches, the Windows Store certification compatibility had regressed. These changes ensure that the required D3D behaviors are met. See: https://code.qt.io/cgit/qt/qtbase.git/tree/src/angle/patches/0003-ANGLE-Fix-Windows-Store-D3D-Trim-and-Level-9-require.patch?h=5.15 Co-authored-by: L. E. Segovia <amy@amyspark.me> Signed-off-by: L. E. Segovia <amy@amyspark.me> Bug: None Change-Id: If8bc2f8cd4b2f84e1d92a1627951da2537212125 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661673 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi f0653461 2023-07-11T10:13:09 Translator: Fix metal-only build Bug: angleproject:6306 Change-Id: I068dc93528b7583ddc84836ac73b52adcde890f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4677722 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi f5ad056b 2023-07-10T22:13:34 GL: Fix ScalarizeVecAndMatConstructorArgs and move to gl/ This transformation was buggy and was disabled. Originally, it was intended to be used everywhere. It is now needed for a GL driver workaround. This change reimplements this transformation and uses it as a GL workaround. Bug: chromium:1420130 Change-Id: I42d63fa5844bcf683ac41e61925aa637e033ca2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4676634 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 0312c76f 2023-07-10T15:12:52 Translator: Move metal-only transformation to its own dir Bug: angleproject:6306 Change-Id: I5ff453f03cccd1c4bcec59e21a18fc6049598383 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675654 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 648f24c9 2023-07-10T17:59:29 Start Mac AMD 13.4.1 experiment Bug: chromium:1462473 Change-Id: Ic30d5f5a0999c10949581aff813febdb83a8cef9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675805 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
angle-autoroll 7de7b9a4 2023-07-11T10:01:30 Roll vulkan-deps from 869b279baef4 to 03c816988bfd (17 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/869b279baef4..03c816988bfd Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/3ebb72cc74..eaa7057768 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/870fd1e17a..4be7d0e3ca * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/179b26a792..2565ffa31e * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/9d38cccf33..8b94e87bff * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/39090f9152..6e7fa4d975 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/db466666ac..db290809b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Idb10483c233a386723d71bd478c396ba5546947c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675703 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll daeef9fa 2023-07-11T07:00:57 Roll Chromium from 749d653d9a36 to d0f9360d7ae6 (471 revisions) https://chromium.googlesource.com/chromium/src.git/+log/749d653d9a36..d0f9360d7ae6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/194f8687fe..143d726c8e * buildtools/linux64: git_revision:1de45d1a11cc9f8cb5c75a031386151e1c384847..git_revision:11e12b0ef870b42ecd3b489a194c0c434a054d25 * buildtools/mac: git_revision:1de45d1a11cc9f8cb5c75a031386151e1c384847..git_revision:11e12b0ef870b42ecd3b489a194c0c434a054d25 * buildtools/win: git_revision:1de45d1a11cc9f8cb5c75a031386151e1c384847..git_revision:11e12b0ef870b42ecd3b489a194c0c434a054d25 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/24349b4e60..7a9572876c * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/fa6fe66454..aa4f4558ff * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/ea2e39562f..14eb523de5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7d7df42f80 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/247429efd9..e5277508c8 * third_party/jdk: -1zDGMOzS_Qsja50TakJCSqN9C9TYppQrsny4HATSQwC..CAecD8de4xl5Dzo6fbtuVg-F4wY-ejtCBAmN3Qhj0J8C * third_party/six: https://chromium.googlesource.com/chromium/src/third_party/six/+log/c96255caa8..32c68ae5c1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eaa6ca74e2..c29b6b927f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/21264809df..56589b6087 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I89b29bf8b6a8a065b70a1c6037f0ddd4c804b955 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4676841 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Sunny Sachanandani 7bcd88cc 2023-07-06T15:44:44 gl: Do not propagate copyTexSubImage2D error to client https://chromium-review.googlesource.com/c/angle/angle/+/4662393 ensured that BlitGL::copyTexSubImage allowed the caller to fallback when the underlying copyTexSubImage2D call failed, but the GL error was also propagated to the client due to the Context::handleError call in CheckError - that error still causes webgl conformance failures even though the pixel expectations are now satisfied. This CL makes BlitGL::copyTexSubImage use getError directly so that the error is not propagated to the client. Bug: chromium:1458040 Change-Id: I3e4c06871c55d449facbe471c78e84f68b529f60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4671325 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Shahbaz Youssefi c0069e62 2023-07-05T21:53:34 Vulkan: Enable ANGLE_pack_reverse_row_order This allows testing the compute path implementation of PBO download for SNORM targets. Bug: b/286882707 Change-Id: I01393f8cad96bf8857a0dfb1638ff2c6366c28a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4668228 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Amirali Abdolrashidi b0e262fb 2023-07-10T11:33:53 Group Texture3DTestES2 skips on iOS GL Bug: angleproject:8213 Change-Id: Ib00bd8d28aa58a56012f2b46f4ac153481d1be38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674080 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll db6b0357 2023-07-10T16:24:53 Manual roll Chromium from 8a1e61637248 to 749d653d9a36 (139 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/8a1e61637248..749d653d9a36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/11876f21fd..24349b4e60 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7d7df42f80 * third_party/turbine: 9rSngS4o9OIlNubLcU1zXF_w0dPYif6AS-_k1pPAV1kC..2I2Nz480QsuCxpQ1lMfbigX8l5HAhX3_ykWU4TKRGo4C No update to Clang. Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I7fd7532722aca9f5a7d7bdd42bf3a0ef92fe95f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675961 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 8b0e5413 2023-06-14T13:27:42 Metal: Put a limit on the total MTLLibrary objects cached Use an MRU for holding the cached libraries in mtl::LibraryCache. Using a maximum cache size of 128 and a GC size of 32 yields the same ratio of cache hits as before (40%) while cycling out the more unique shaders that are not re-used. Lowering the cache size to 64 or 96 yields a hit rate of 30-35%. Bug: chromium:1329376 Change-Id: I75dd6b20cf3f8b67c4b3c31da4e05e1857ad61db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4614362 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 10194966 2023-07-10T13:56:13 Skip 2 flaky Perf tests on Win Intel Vulkan pubg_mobile_launch flaky timeout monster_hunter_stories flaky context lost Bug: angleproject:7929, angleproject:7557 Change-Id: I45d7b22bd3186419a584314c6c1f52ed0427ec8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674342 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Yuly Novikov b2b1363a 2023-07-10T12:29:03 Skip Texture3DTestES2.DefineTexture2DArrayShouldFail on iOS GL Bug: angleproject:8213 Change-Id: I5487bd7b0a8033445d5552bb8d86dc3af80f1305 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674340 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 5d3ca3ba 2023-07-10T07:01:37 Roll Chromium from 96802d0bdfdd to 8a1e61637248 (514 revisions) https://chromium.googlesource.com/chromium/src.git/+log/96802d0bdfdd..8a1e61637248 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6b59eb95c1..194f8687fe * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f11186bf34..1cc82962cb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b4958339ec..11876f21fd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7d7df42f80 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4303140531..247429efd9 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f37f647574..7b20bcffe9 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/50358e9b66..eaa6ca74e2 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I28cf76358fda84b7e4df0cf18c344821adec4fbf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674826 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 6ee402f6 2023-07-06T16:56:28 Clamp the max Framebuffer width and height to 16 bit GraphicsDriverUniforms struct packs framebuffer width and height into a 32 bit uint, meaning the maximum width and height supported are 16 bit each. We should make sure below values do not exceed the maximum value of a 16-bit uint: caps.maxFramebufferWidth caps.maxFramebufferHeight caps.maxRenderbufferSize so that the application won't try to create a FBO with width/height exceeding 16-bit. We have clamped the caps.max2DTextureSize to 32768, it makes sense to clamp the FBO width and height to the same value. Bug: b/286921997 Change-Id: Iae598b37215c58d1a0f6a50bba9f391d4d23d1f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4671327 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 3c814a34 2023-07-05T15:18:22 Include files declared in compiler.gni in shader program cache key We should invalidate the program cache when the files declared in compiler.gni changes. Add those files for shader cache key calculations. Bug: angleproject:4981 Bug: b/285871779 Change-Id: I9a8a65c1b02c4efcc6126d8b77017ddd8328e7a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662395 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev b57d5638 2023-06-29T00:00:00 Reland "Cleanup multiview support" This is a reland of commit 9a7c0b88ba68e328d3f5f7991a6df0ab5de92311 Original change's description: > Cleanup multiview support > > * Removed remaining mentions of ANGLE_multiview > > * Removed AST transformations used only in > the side-by-side multiview implementation > > * Changed the type of the internal ViewID_OVR > variable to use the dedicated qualifier > > * Removed side-by-side multiview support > from the D3D11 renderer > > * Removed an unused helper for side-by-side > multiview support from the OpenGL renderer > > * Removed obsoleted test suppressions Fixed: angleproject:3341 Change-Id: I3ce9304c79c0873462c73e8cf02b85f7a1aaf874 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4669604 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Mohan Maiya 8b680c93 2023-07-07T09:24:44 Vulkan: Bug fix in GetAvailableValidationLayers(...) GetAvailableValidationLayers(...) had a bug where it did not account for a subset of kVkValidationLayerNames being available. Bug: angleproject:8247 Change-Id: Id7bc3570b2caf5550ca9d011a3ba9429702af8af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4673189 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Roman Lavrov 5997f1d7 2023-07-07T16:01:36 Fix little_cpu_power collection. Currently always getting 0, significantly undercounting cpu power at least in some cases (e.g. I saw 1700 vs 4300 in fishdom) Bug: b/284462263 Change-Id: Idd525f25cfc419a4a9d23a3fc99e938e99e1e715 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672592 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Charlie Lao 3cc3327c 2023-07-07T10:29:45 Vulkan: limit preferCPUForBufferSubData flag to mali job manager This feature flag was introduced with testing on pixel 6 pro with aliexpress trace. The GPU has a job manager does the scheduling and transfer workload was put in the same job queue as geometry work which causing unnecessary bubble in the pipeline. This problem does not exist on newer GPU architecture where it has a command stream front end that transfer has its own dedicated queue. As test result on pixel 7 devices indicates, this feature flag shows no difference on pixel 7with aliexpress trace, and has negative perf impact with gangstar_vegas trace. This CL limits the feature flag to ARM's job manager based GPU. This improves gangstar_vegas frame time from 8.4576ms to 4.6370ms on pixel 7 pro. Bug: b/289436017 Change-Id: I604fb1e26d0a99bcf8f4c2574ced360c31ac712d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4671326 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 04c0cc8d 2023-07-06T21:58:06 Simplify aliasing-exception logic in entry point generation Bug: angleproject:8224 Change-Id: Ic54c233ab3d8a0f9a1ac803804aea770c6f7cc07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672145 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 51320fab 2023-07-06T16:01:58 Make most GLES1 entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I80223340348d62a56109324ab3e4f935e53419b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4670407 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi eb205e68 2023-07-06T13:34:28 Make the glPatchParameteri entry point lockless This entry points only sets context-local state and thus doesn't require locking. Bug: angleproject:8224 Change-Id: I17975a97aa7f68c3ddf2ef78069b8f519fdc4c1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4670405 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
Shahbaz Youssefi 5869fb3b 2023-07-06T22:13:36 Remove big-GL files from normal builds of ANGLE Bug: angleproject:7533 Change-Id: I3616296d9923310200830a921190813e3ecfe80b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672146 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 732a8f07 2023-07-05T17:03:46 Move max-shader-compile-threads state out of LocalState While this state is indeed context-local, setting it calls into the backend (GL backend specifically, where it forwards the call to the driver). The call to set this state is rare and now worth the risk associated with making it lockless. Bug: angleproject:8224 Change-Id: I3af395721fa18b9345698870c0da63e8cac83610 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666355 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll f9b16593 2023-07-07T15:05:41 Manual roll Chromium from e506ce09bac4 to 96802d0bdfdd (1526 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/e506ce09bac4..96802d0bdfdd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f87ccdf42a..6b59eb95c1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6d00f8d8c5..f11186bf34 * buildtools/linux64: git_revision:da5fe01bce4ae84b2619caca7a3aa7ec7d3eb8a7..git_revision:1de45d1a11cc9f8cb5c75a031386151e1c384847 * buildtools/mac: git_revision:da5fe01bce4ae84b2619caca7a3aa7ec7d3eb8a7..git_revision:1de45d1a11cc9f8cb5c75a031386151e1c384847 * buildtools/win: git_revision:da5fe01bce4ae84b2619caca7a3aa7ec7d3eb8a7..git_revision:1de45d1a11cc9f8cb5c75a031386151e1c384847 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ac3cb62a5a..b4958339ec * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b5862634ee..ae5ee2a38f * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/4cb10f1315..fa6fe66454 * third_party/android_build_tools/lint: DjoXGsdMeTwnppye9Nwe5ozhXIqKyJQDzgb0nTFH8SAC..z1zqFkwGcjud6JnSJ-81QiOYgD-OlvkQg5Fgt_gHwtoC * third_party/android_build_tools/manifest_merger: MN3CF2GQ8xeB6obj4qf5J6l15-NoA43u4__RQTTe8I4C..oD5bP72e45KzyT-yHx9yFfQcqpEfOUERdpMaR7rkTRcC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/36fd99b5ae..6514de5457 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/a72ec125fa..4b4eee2d24 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..451fa58bf6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/872ac9bd3d..4303140531 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/19617929c3..e2247b3708 * third_party/kotlin_stdlib: bhkmCcKzQ5IXUsDnWkRfouPfdzzyrgw40PUzRvArrGEC..Z1gsqhL967kFQecxKrRwXHbl-vwQjpv0l7PMUZ0EVO8C * third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/13f4e8c9e2..006709ba3e * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/678d565421..c468546c25 * third_party/r8: vw5kLlW3-suSlCKSO9OQpFWpR8oDnvQ8k1RgKNUapQYC..FxcKKMhpNz8EQC9ZdDwB64ZzLm1VrWw21A_m20AOKaAC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f999826d2d..7eff33bc00 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/39d4cc4ec8..f37f647574 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/75c7faf556..50358e9b66 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/33899440a1..21264809df * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/57b3b9e7c0..9a047fd494 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/159b3b88fd..4b4a958480 Clang version changed llvmorg-17-init-12166-g7586aeab:llvmorg-17-init-16420-g0c545a44 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/75c7faf55603c3ced48829d6f122e9719ff168e0..50358e9b66c22540954585c1b8df092d69eeb7f0/scripts/update.py Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: I6af984fb327e9b028cb3d48b89be73676192ba1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672995 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 9cd1205f 2023-07-07T12:22:14 Skip street_fighter_iv_ce on SwiftShader keyframe=86, runs very slow on SwS: https://anglebug.com/8243#c1 Bug: angleproject:8243 Change-Id: Iae3c758ea6b6e6a2a68f91a1355c10bc9c92f432 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672588 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 44acab29 2023-07-07T12:02:51 Use latest build-tools from android_sdk (same as catapult) https://crsrc.org/c/third_party/catapult/devil/devil/android/sdk/build_tools.py;drc=8a3feaaaab63b383fb6b138be2986e9ad6dcaca2;l=61 Also do not fall back to just 'aapt' as that isn't hermetic. Bug: angleproject:7670 Change-Id: Ided9dfe16d6c6815c3425bdc64b2d572bbe564c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672808 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov da710ac3 2023-06-29T09:36:42 Stop rolling third_party/cpu_features It was probably needed for zlib previously but now zlib already depends on the ndk's cpufeatures. There are no references to third_party cpu_features in the generated Android.bp. Bug: b/289259681 Change-Id: Ib849b26391d0c23e533662094e74384c267c8620 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4656761 Reviewed-by: Solti Ho <solti@google.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Solti Ho <solti@google.com>
Anne Redulla 66c2e4fc 2023-07-04T17:02:07 [ssci] Added Shipped field to READMEs This CL adds the Shipped field (and may update the License File field) in Chromium READMEs. Changes were automatically created, so if you disagree with any of them (e.g. a package is used only for testing purposes and is not shipped), comment the suggested change and why. See the LSC doc at go/lsc-chrome-metadata. Bug: b/285450740 Change-Id: I770554248e33c1e50938cc32daee36a83b643ec9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672125 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 65ae56ba 2023-07-07T10:01:23 Roll vulkan-deps from c421d230f1c1 to 869b279baef4 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c421d230f1c1..869b279baef4 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f2f60da66f..db466666ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ifaa2d0b7d639fe0a5c9fa392c05b384f75e8b458 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672746 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 7e0fb7e4 2023-07-05T17:20:23 Make glIsEnabled* entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I6fe40bf4381e1d42248358f773ec9d5675883ada Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666356 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 72c26926 2023-07-05T16:31:23 Make pack/unpack and hint entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I5694d319df61a7a9df1766cf1f723b9a05208209 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666352 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 208dfe28 2023-07-05T15:18:57 Make glStencil* entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I612d8219ba038464173490b2c261e9e7b229c83f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661702 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c3c2f450 2023-07-05T14:52:10 Make glBlend* entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: Ie811c35ae7b65106db9af9f7531ad3a5e0bd4f8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661701 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 44395930 2023-07-05T11:59:23 Make various state setting entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I428c23cc862e9356d571bc085b5df0bf48017175 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661700 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0