kc3-lang/angle/scripts

scripts

Log

Author Commit Date CI Message
Roman Lavrov d6dc46db 2023-07-14T17:51:26 Revert "Add minimal setup for Go codegen in Android.bp." This reverts commit 9f7b6babe1fd7313a6a344d037aed542505d126e. Reason for revert: No longer appears needed as 1) number of diffs was greatly reduced via cc_default 2) build configs got simpler with switching to platform zlib. No recent conflicts introduced by build scripts Original change's description: > Add minimal setup for Go codegen in Android.bp. > > Based on Cody's http://ag/19603310. > > Only adds libEGL_angle_codegen to libEGL_angle and is a no-op. > > Tested in an aosp checkout. Hopefully this doesn't cause merge conflicts > with internal master as all diffs are close to the top of the file. > > Android.bp diff: https://paste.googleplex.com/6626641357832192 > > Bug: b/242929755 > Change-Id: I6d7ac9f3dd502074c41838bd1aa10075a8c99145 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3876890 > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: b/242929755 Change-Id: Id4cbdf68e9704138396ee1bef7a4f1edef3f50cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685320 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 74cf6a3a 2023-07-12T14:44:17 Ensure lockless entry point validations only access private data Bug: angleproject:8224 Change-Id: I19e867923b088879f9f37d0a3b4ff8b681470be0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678352 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
yanhongchen b03a018c 2023-06-15T19:36:16 Android: Add privapp-permissions XML Bug: angleproject:8210 Bug: b/242671681 Change-Id: I57d14eb026fab319e080cedcfefd5c160c1321d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4617552 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 9962f078 2023-07-11T15:39:50 Pass only context-private state to private entry points This change ensures that the implementation for these entry points cannot access anything other than context-private state. Bug: angleproject:8224 Change-Id: I988672b138d861db25e91d71ab8c34baa4e8ebee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678783 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 40111c68 2023-07-11T14:21:21 Rename context-local to context-private state Bug: angleproject:8224 Change-Id: I1bb39475043f8fb14d683d11a038b4850692a8c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678781 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop c93682d3 2023-07-12T11:08:25 Revert "Stop rolling third_party/cpu_features" This reverts commit da710ac3f731c128caf0aff75c0cd6e58a0591af Reason for revert: Causes Android roll to fail http://anglebug.com/8255 Original change's description: > Stop rolling third_party/cpu_features > > It was probably needed for zlib previously but now zlib already depends > on the ndk's cpufeatures. There are no references to third_party > cpu_features in the generated Android.bp. > > Bug: b/289259681 > Change-Id: Ib849b26391d0c23e533662094e74384c267c8620 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4656761 > Reviewed-by: Solti Ho <solti@google.com> > Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> > Auto-Submit: Roman Lavrov <romanl@google.com> > Commit-Queue: Solti Ho <solti@google.com> Test: scripts/roll_aosp.sh Bug: angleproject:8255 Change-Id: I2a879a3675a1c041a0e6ffff2be886aa693e486d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4680107 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 94ceedb7 2023-07-10T00:00:00 Add GL_EXT_texture_compression_astc_decode_mode stubs Bug: angleproject:8254 Change-Id: I2a839139b5738710e32842b04db35eab8fb04687 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679683 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 9b63700b 2023-07-11T10:25:40 Translator: Reorganize files This change makes the translator files more organized by: - Grouping files that are specific to a certain output under their own directory, - Moving transformations under tree_ops - Removing Direct from metal translation now that that SPIR-V Cross path is removed Bug: angleproject:6394 Change-Id: Iaf5bb8d5604b84748dece029821b1f77b2813967 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678780 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 7de7b9a4 2023-07-11T10:01:30 Roll vulkan-deps from 869b279baef4 to 03c816988bfd (17 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/869b279baef4..03c816988bfd Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/3ebb72cc74..eaa7057768 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/870fd1e17a..4be7d0e3ca * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/179b26a792..2565ffa31e * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/9d38cccf33..8b94e87bff * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/39090f9152..6e7fa4d975 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/db466666ac..db290809b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Idb10483c233a386723d71bd478c396ba5546947c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675703 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 04c0cc8d 2023-07-06T21:58:06 Simplify aliasing-exception logic in entry point generation Bug: angleproject:8224 Change-Id: Ic54c233ab3d8a0f9a1ac803804aea770c6f7cc07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672145 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 51320fab 2023-07-06T16:01:58 Make most GLES1 entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I80223340348d62a56109324ab3e4f935e53419b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4670407 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi eb205e68 2023-07-06T13:34:28 Make the glPatchParameteri entry point lockless This entry points only sets context-local state and thus doesn't require locking. Bug: angleproject:8224 Change-Id: I17975a97aa7f68c3ddf2ef78069b8f519fdc4c1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4670405 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
Roman Lavrov da710ac3 2023-06-29T09:36:42 Stop rolling third_party/cpu_features It was probably needed for zlib previously but now zlib already depends on the ndk's cpufeatures. There are no references to third_party cpu_features in the generated Android.bp. Bug: b/289259681 Change-Id: Ib849b26391d0c23e533662094e74384c267c8620 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4656761 Reviewed-by: Solti Ho <solti@google.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Solti Ho <solti@google.com>
Shahbaz Youssefi 7e0fb7e4 2023-07-05T17:20:23 Make glIsEnabled* entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I6fe40bf4381e1d42248358f773ec9d5675883ada Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666356 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 72c26926 2023-07-05T16:31:23 Make pack/unpack and hint entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I5694d319df61a7a9df1766cf1f723b9a05208209 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666352 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 208dfe28 2023-07-05T15:18:57 Make glStencil* entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I612d8219ba038464173490b2c261e9e7b229c83f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661702 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c3c2f450 2023-07-05T14:52:10 Make glBlend* entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: Ie811c35ae7b65106db9af9f7531ad3a5e0bd4f8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661701 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 44395930 2023-07-05T11:59:23 Make various state setting entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I428c23cc862e9356d571bc085b5df0bf48017175 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661700 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 9daac2b7 2023-07-05T11:36:46 Make glEnable/Disable entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: Id4eab729115bd75f82e1ec7a27355c821a7c4320 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661697 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 0892420b 2023-06-28T23:03:51 Vulkan: Optimize PBO download between RGBA and BGRA Google Meet hits this path in Chrome when blurring the background. The CPU readback was particularly slow on Intel/Mesa where readback from the temp buffer took hundreds of milliseconds. This change adds a compute shader that directly copies from the image to the pack buffer in simple but common cases. Bug: b/286882707 Change-Id: I9877ea01e3d8377db96f2539362aca67cf832b4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4657058 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi be41fe29 2023-07-04T15:35:46 Make glColor/DepthMask entry points lockless These entry points only set state that is entirely accessed by the owning context (context-local) and thus don't require locking. glColorMask* functions also affect the cached context state (in particular draw validity), so the relevant cached state is also modified to support being locklessly modified. Bug: angleproject:8224 Change-Id: I221b4efa25fc1c11419d1ac942f1c37e59ec92c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4658173 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop ec8fb51b 2023-07-03T11:44:26 Tests: Add Evony: The King's Return trace Test: angle_trace_tests --gtest_filter="*evony_the_kings_return*" Bug: b/266237531 Bug: b/275096133 Change-Id: I32daa8b1bd4f3253887d02a5127ef4682df4951a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4664602 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 4db13081 2023-07-04T14:40:31 Make glClearColor/Depth/Stencil entry points lockless These entry points only set state that is entirely accessed by the owning context and thus don't require locking. Bug: angleproject:8224 Change-Id: I6cddee865ffd38e228f8f87dd14adffb916e0fed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4658172 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll cb5cd76d 2023-07-03T15:54:58 Manual roll vulkan-deps from 2b2cba62bfea to e21365bc9170 (38 revisions) Manual roll requested by ynovikov@google.com Suppress new VUIDs: "VUID-vkCmdDrawIndexed-None-08608", "VUID-vkCmdDraw-None-08753", "VUID-vkCmdDrawIndexed-None-08753", https://chromium.googlesource.com/vulkan-deps.git/+log/2b2cba62bfea..e21365bc9170 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/9575e33186..3ebb72cc74 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/2d3a152081..b8e742c91b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/310a67020a..58459c2b1a * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/b6a29e5ca8..ad5f8ee975 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a1d9d485ce..dce85674e2 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/247c806c93..2e5260d44c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/926ffb1f41..4400858043 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8242 Change-Id: I475146b418565e633043f6b57cb07baedcff02ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662877 Commit-Queue: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
angle-autoroll 0e8a8e0f 2023-07-03T16:00:35 Roll VK-GL-CTS from 12bc45af35d5 to e7b180ad5366 (12 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/12bc45af35d5..e7b180ad5366 2023-07-03 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-06-30 lorenzo@khronosgroup.org Merge "Merge remote-tracking branch 'vk-gl-cts/vulkansc-cts-1.0.1'" into main 2023-06-30 aitor@lunarg.com Add EGL_ANDROID_RECORDABLE to config testing 2023-06-30 rgarcia@igalia.com Add GPL variants to fragment shader barycentric tests 2023-06-30 rgarcia@igalia.com Test tessellation state switches 2023-06-30 cturner@igalia.com Vk Video: Upgrade the NVIDIA parser interface to version 0.9.9 2023-06-30 paulthomson@google.com Skip dEQP-VK.api.info.android.* if not Android 2023-06-30 scerveau@igalia.com cts: add deviceName to SessionInfo 2023-06-30 rgarcia@igalia.com Test maxSamplerLodBias 2023-06-30 cturner@igalia.com Update handling of field flags for improved compatibility. 2023-06-26 gleese@broadcom.com Switch float controls tests from deBool to C++ bool 2023-06-26 gleese@broadcom.com Remove duplicate direct linking options If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I55e947c71f921d7ef55ffb5f2b61b0a19f304170 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662878 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 574d163f 2023-07-03T14:36:59 Manual roll vulkan-deps from 23a32754e715 to 2b2cba62bfea (29 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/23a32754e715..2b2cba62bfea Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/10db9d4e19..3469b164e2 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/54691dcd73..310a67020a * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/c1a8560c5c..b6a29e5ca8 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b02d69f3a1..a1d9d485ce * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/07924a8a49..247c806c93 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/cb9c77d609..926ffb1f41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: I4b5e433bdd24644f6e502f10f21974b670b2a0b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662876 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f015b253 2023-06-26T14:21:25 Roll VK-GL-CTS from f29bd2feeaff to 12bc45af35d5 (10 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/f29bd2feeaff..12bc45af35d5 2023-06-23 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/opengl-es-cts-3.2.9' 2023-06-23 piotr.byszewski@mobica.com Regenerate mustpass 2023-06-23 aitor@lunarg.com Test partial binding of depth/stencil images 2023-06-23 piotr.byszewski@mobica.com Test commands on transfer-only queue 2023-06-23 cturner@igalia.com Allow DECODE_OUTPUT and DECODE_DPB features for YCbCr formats 2023-06-23 matt.coster@imgtec.com Don't attempt pipeline library tests without VK_KHR_pipeline_library 2023-06-23 rgarcia@igalia.com Test occlusion and frag shader inv counts with flat shading 2023-06-23 alyssa@rosenzweig.io surfaceless: Fix shared contexts and implement makeCurrent 2023-06-23 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-06-22 alexander.galazin@imgtec.com Notice of withdrawal of Vulkan CTS 1.3.3.x If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I96a35e762f3cd5585027a5afa84d160619ee02c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4646068 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 174742fd 2023-06-18T13:07:00 Roll VK-GL-CTS from 7fcb3c6e0082 to f29bd2feeaff (19 revisions) Suppress dEQP-EGL failures. https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7fcb3c6e0082..f29bd2feeaff 2023-06-18 lorenzo@khronosgroup.org Merge vk-gl-cts/github-main into vk-gl-cts/main 2023-06-16 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2023-06-16 piotr.byszewski@mobica.com Split pipeline.txt in vksc-default 2023-06-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-06-16 alexander.galazin@imgtec.com Fix check_build_sanity.py error 2023-06-16 lorenzo@khronosgroup.org Add missing line in AndroidGen.mk for vktFragmentShadingRateMiscTests.cpp 2023-06-16 rgarcia@igalia.com Test FSR in a pipeline without fragment shader 2023-06-16 ziga@lunarg.com Add xfb test drawing outside of xfb begin 2023-06-16 piotr.byszewski@mobica.com Test RT interaction with flags added by GPL 2023-06-16 rgarcia@igalia.com Test gl_SampleMaskIn with sample shading 2023-06-16 rgarcia@igalia.com Test enabling and disabling VRS statically 2023-06-16 rgarcia@igalia.com Test allocation and binding offsets with index buffers 2023-06-16 pdaniell@nvidia.com Remove the "Error:" prefix with NotSupported results 2023-06-16 jenatali@microsoft.com Fix skipping when synchronization2 is unsupported on Windows 2023-06-16 gleese@broadcom.com Remove 64-bit test code for builtins which don't support it 2023-06-16 jenatali@microsoft.com Don't include windows.h in the vk namespace 2023-06-16 rgarcia@igalia.com Disallow direct linking of GLES libraries by default 2023-06-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-06-15 younggwan.kim@arm.com Merge dev/EXT_shader_tile_image into main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8214 Change-Id: I84598fb784adf1e30abbeaac3c53dcd97108d58a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4624553 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 949d9e34 2023-06-19T10:01:43 Roll vulkan-deps from 58c6e1ea988a to c5656423525b (18 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/58c6e1ea988a..c5656423525b Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/72713baf74..5793fbd624 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d33bea5847..a720a6926e * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/cb71b646f1..c1a8560c5c * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/bcfb502054..db51885950 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/17edcc1455..ca8bb4ee3c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4d4fc0e5a2..fff7423f1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I1268ec340ea63b9cf151e77a7e69ae1d261ba77d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4626257 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov f102184d 2023-06-13T14:34:07 Make Test spec JSON generator hashless. Removes scripts/code_generation_hashes/Test_spec_JSON.json Instead, run codegen in --verify-only mode and compare content. This run during presubmits and is fast (~0.2s in my tests) Similar to https://crrev.com/c/4604579 With this, should be able to auto-resolve conflicts in infra/specs/angle.json Also testing/buildbot/mixins.pyl seems to have had hashes routinely updated by autorolls. Bug: angleproject:8193 Change-Id: Ic1a657dbf464e6f4a8066ea8c5e18297e27a3b4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4605467 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov df787cf0 2023-06-14T17:56:11 Add ANGLE experimental SwiftShader builders For testing Ubuntu 22.04 Recipe-side CL http://crrev.com/c/4614428 Testers: linux-exp-swiftshader linux-exp-swiftshader-asan linux-exp-swiftshader-tsan Builders: linux-exp-asan-test linux-exp-tsan-test Modify LUCI MILO console to show only the active experimental builders. Bug: chromium:1380082 Change-Id: Iac74b606fca7b1762028cebf4868e691b3ed074c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4614533 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
angle-autoroll e8a29d6c 2023-06-15T07:01:30 Roll Chromium from bfc7c889fd6c to 7df45c601f1c (609 revisions) https://chromium.googlesource.com/chromium/src.git/+log/bfc7c889fd6c..7df45c601f1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a838ac9f43..1889753ce5 * buildtools/linux64: git_revision:1cd35c1b722472e714c30d12031af81443bb20ae..git_revision:4bd1a77e67958fb7f6739bd4542641646f264e5d * buildtools/mac: git_revision:1cd35c1b722472e714c30d12031af81443bb20ae..git_revision:4bd1a77e67958fb7f6739bd4542641646f264e5d * buildtools/win: git_revision:1cd35c1b722472e714c30d12031af81443bb20ae..git_revision:4bd1a77e67958fb7f6739bd4542641646f264e5d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ed771cb046..da030c5a1c * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/85f7b5752b..834450f113 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..89fad9023d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2b19afb820..dedeb88991 * third_party/fuchsia-sdk/sdk: version:13.20230613.4.1..version:13.20230614.3.1 * third_party/r8: AostPkk2hQv2Pz7k7JMtoD346t5IWWll26jAdkVHk2wC..vw5kLlW3-suSlCKSO9OQpFWpR8oDnvQ8k1RgKNUapQYC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/21289a1a1b..573d371dff * tools/luci-go: git_revision:e99800d3fd42249c9cdda3f58ba31c674b4876f6..git_revision:39f255d5875293d3e1d978888b819ac124a8b0cc * tools/luci-go: git_revision:e99800d3fd42249c9cdda3f58ba31c674b4876f6..git_revision:39f255d5875293d3e1d978888b819ac124a8b0cc * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b69b0ca417..bf6c9c4977 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1b905778b8..3a42bc4aaa * tools/skia_goldctl/linux: TCcuUOFbPU3igS_xlEVBu_d1nZ71zngQ3oL-Bdm0GOoC..tVDltUu_xw7_tk4k-rnp7Ua8pKhf3EEHmTwX5c6BS4AC * tools/skia_goldctl/mac_amd64: Btg2SHJpGjd1aivMSCt0RT5G6j33TDTYYfLANClZApYC..ov_DuOSHCneWQSTW6AZ9gWHEeoJxXEYDX9dl_0rA_d0C * tools/skia_goldctl/mac_arm64: SW3HcHhCf69xzWwap7_fHNSualUgKeG_3N6xTMmVuVoC..3wDkZAVD4vV1dNhXfRNMOUBvODbzJ23AVmmsFbTsbkQC * tools/skia_goldctl/win: yDoSOjnzDYE9APn8a3d-FcPJ6wwwq2FXWUTOJpf2__8C..yW7os_HVMoE-wq04olb6B7GNgEmaYZYPN0ecTzPPBdkC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I9b6216bdb66bdc0c30c64226a785ec25e2da3b2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4617669 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov 36c3e0f5 2023-01-17T17:42:59 Implement "Shared Context Mutex" functionality. Existing implementation uses single `GlobalMutex` for - EGL calls - GL calls for Contexts with concurrent access. This CL introduces abstract `egl::ContextMutex` with two implementations: - SingleContextMutex; - SharedContextMutex<Mutex>; Note: `std::mutex` is used in this commit. It is very easy to change mutex type either at compile-time or at run-time (single type per Display). When Context: - is not Shared; - does not use `EGLImage`s; - does not use EGL_DISPLAY_TEXTURE_SHARE_GROUP_ANGLE - does not use EGL_DISPLAY_SEMAPHORE_SHARE_GROUP_ANGLE then it will be using `SingleContextMutex` with minimal overhead. Before such Context is used as `shareContext` or uses `EGLImage` its mutex replaced by `SharedContextMutex<Mutex>`. The `GlobalMutex` is only used for EGL calls, while `egl::ContextMutex` implementations for GL calls. Because some EGL calls use Context, explicit `egl::ContextMutex` lock is required. This is implemented by generating "egl_context_mutex_autogen.h" header, and insertion of `ANGLE_EGL_SCOPED_CONTEXT_LOCK()` macro before `ANGLE_EGL_VALIDATE()` in each EGL entry point. Implementation in "egl_context_lock_impl.h" returns lock for required APIs. Special cases of `egl::ContextMutex` lock handled separately. `std::unique_lock<>` is not used for performance reasons. `egl::ContextMutex` explicitly locked when capturing EGL calls. Fixes EGLImage problem: https://chromium.googlesource.com/angle/angle/+/e18240d136d15e5cdfa4fa4a6355ca21c8d807b6 Mark contexts as shared when importing EGL images. Details: - EGLImage inherits Context's mutex when created. Mutex is used when the EGLImage accessed or destroyed. - When EGLImage is used in Context with other `egl::ContextMutex`, two mutexes are merged into one. - After the mutex merge, Context Groups will remain separate, but will not be able to run in parallel. Fixes race when checking `context->isShared()` in the `SCOPED_SHARE_CONTEXT_LOCK()` macro. One Context may start executing GL call while not "Shared", but become "Shared" inside the call. New (second) "Shared" Context may immediately start using GL and potentially corrupt some "Shared" state. Possible performance benefit: allows parallel execution in some cases, when single `GlobalMutex` would block. Important note: Process of replacing the `SingleContextMutex` by `SharedContextMutex<Mutex>` is not 100% safe. This mean that original Context may still be using `SingleContextMutex` after activating `SharedContextMutex<Mutex>`. However, this was always the case before introduction of this CL. Old `Context::mShared` member update was not synchronized in any way at all. In other words, this solution does not 100% fix the original problem. For 100% safe solution `SingleContextMutex` should not be used (always pass `SharedContextMutex<Mutex>` to the `gl::Context` constructor). See `lockAndActivateSharedContextMutex()` for more details. CL adds new build option: angle_enable_shared_context_mutex = true Behavior with other build options: - When: `angle_enable_shared_context_mutex` is disabled or `angle_enable_share_context_lock` is disabled or `angle_force_context_check_every_call` is enabled, Contexts will always have `SingleContextMutex`, however it will be only used in special cases. `SCOPED_SHARE_CONTEXT_LOCK()` will use `GlobalMutex` when applicable. - Otherwise, `SCOPED_SHARE_CONTEXT_LOCK()` will use `egl::ContextMutex`. Some GFXBench "1080p Driver Overhead 2 Offscreen" performance numbers. Tested on S906B (Samsung Galaxy S22+) on old ANGLE base: https://chromium.googlesource.com/angle/angle/+/807c94ea85e046c6f279d081d99f0fb1bcf1191a Capture/Replay: Adjust tests do adhere to capture limits Each test result is an average frame number from 6 runs. SingleContextMutex 6579 ( +0.13%) (old) GetContextLock() (mShared is false) 6570 Forced `mShared = true` or NOT using `SingleContextMutex`. SharedContextMutex<std::mutex> FORCE 5061 (-22.97%) (old) GetContextLock() FORCE 4766 (-27.46%) Bug: angleproject:6957 Bug: chromium:1336126 Change-Id: Idcd919f9d4bf482b9ae489bd8b4415ec96048e32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4374545 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 341dabf8 2023-06-14T10:01:56 Roll vulkan-deps from 701c5daafb72 to cebf5626ca50 (30 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/701c5daafb72..cebf5626ca50 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a6662c53ce..72713baf74 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/030d0be28c..2d3a152081 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/93c13345e1..40dde04ca2 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/605dc6d3e7..cb71b646f1 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c97930ba36..88d70047fb * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ee8fe8140a..5cde5d21a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Id2fb37c26ef6d6ca61d4b72a1c18dc5180e18654 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4614205 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1e06b31e 2023-06-13T06:42:27 Roll VK-GL-CTS from 7dc49a77dd0f to f7646f53ba61 (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7dc49a77dd0f..f7646f53ba61 2023-06-12 marcin.zajac@mobica.com Vulkan video capabilities tests for 1.3.253 2023-06-12 alexander.galazin@imgtec.com Merge vk-gl-cts-public/main into vk-gl-cts/main 2023-06-12 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2023-06-12 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2023-06-12 marcin.zajac@mobica.com Enabling storage image write support 2023-06-12 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Idf35864a0c0a40546477e0352fd35cd59613500b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4606371 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 1572f609 2023-06-09T18:39:52 Disable hashes for ANGLE features generator Features autogen files are small, fast to regenerate. Run the generator in --verify-only mode and check content every time, instead of using hashes. Bug: angleproject:8193 Change-Id: I3988ab50a6c33171b7b7252c03f34a74f09fcf18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4604579 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 21f16cb1 2023-06-09T17:30:38 Disable clang-format on ANGLE features autogen outputs Updates the script to produce reasonably formatted code without clang-format. Autogen files moved to autogen/ sub-directories because clang-format does not support per-file settings ;( This allows to run this codegen very quickly (~50ms on my machine) Bug: angleproject:8193 Change-Id: Ie84282090d574ebb4debe3edcfd82f983f27a5ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4604578 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Steven Noonan a01a566c 2023-06-09T00:31:06 extension xmls: fix incorrect use of <ptype> tags I was having trouble using some GL/EGL loader generators because of some errors in the XML definitions for ANGLE. The first major problem is the content of the <ptype> tags. Let's refer to the Khronos registry XML schema (which is annoyingly a PDF rather than an xsd that we can test against, though I don't know if an xsd would catch this anyway): https://raw.githubusercontent.com/KhronosGroup/OpenGL-Registry/master/xml/readme.pdf In section 12.4.2, "Contents of <param> tags" it states: The <ptype> tag is optional, and contains text which is a valid type name found in <type> tag, and indicates that this type must be previously defined for the definition of the command to succeed. Builtin C types, and any derived types which are expected to be found in other header files, should not be wrapped in <ptype> tags Note that the above is repeated for the contents of <proto> tags as well. The extension XML files currently have a bunch of <ptype> tags which don't meet the expectations described above. The correct transformation for them would be, for example: <ptype>GLfloat *</ptype> -> <ptype>GLfloat</ptype> * <ptype>void *</ptype> -> void * <ptype>const char *</ptype> -> const char * <ptype>EGLAttrib *</ptype> -> <ptype>EGLAttrib</ptype> * The next issue is that some tags have some typos, such as "<pytpe>" instead of "<ptype>". (Now *that* is something an .xsd would catch...) The last issue is the use of the typename "GLvoid" which is not as serious a problem. It is still defined in Khronos' gl.xml <types> block, but Khronos no longer uses it in their XML registries. The comment for the "GLvoid" type in their <types> block states: <type comment="Not an actual GL type, though used in headers in the past">typedef void <name>GLvoid</name>;</type> So we might as well replace those with just plain "void". Anyway, long story short: to apply these transformations, I used Perl regular expressions, and applied these expressions in order: - Fix the tag misspellings: s#<(/?)pytpe>#<\1ptype>#g - Move the const qualifiers (if present) and pointer asterisk(s) (if any) outside the <ptype> tag itself: s#<ptype>(const )?([A-Za-z0-9]+)[ ]?(\*\*?)</ptype> #\1<ptype>\2</ptype> \3#g - Replace "GLvoid", "char", and "void" inside ptype tags to normal C types outside tags: s#<ptype>(GLvoid|void|char)</ptype>#\1#g Bug: angleproject:8190 Change-Id: Ib0bea79fecb7e714910b6e92124bb9f52994d0fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4603709 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang d55c91c3 2023-06-09T15:14:54 Don't roll third_party/android_toolchain into AOSP. Bug: None Change-Id: I43a34f4e17b81482d8a0f994f9b729b7abd94b3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4603670 Reviewed-by: Solti Ho <solti@google.com>
Mark Lobodzinski 72df4283 2023-06-09T10:54:31 Tests: Add Lotsa Slots trace Test: angle_trace_tests --gtest_filter=TraceTest.lotsa_slots Bug: b/286514838 Change-Id: I8756a21596f2a09abff8262b3a9489b638d3522d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4603714 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Steven Noonan beeb465b 2023-06-08T23:28:30 xml: fix enum EGL_SYNC_METAL_SHARED_EVENT_SIGNALED_ANGLE The name in the extension/require block did not match the name in the enum specification block. This caused some EGL loader generators to fail to run properly. Bug: angleproject:8190 Change-Id: I6ce6e226121e7ea9aa611c7d331a8fd1bc83e55b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4603708 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Roman Lavrov 3e4f4cae 2023-06-09T12:02:52 Tests: reduce load on perf bots by collecting less data Collecting this data takes a significant amount of resources but we do not actively use it at the moment. Disable --split-shard-samples (will avoid separate calibration on each shard) Reduce samples to 6 (from default 10) Bug: angleproject:7671 Change-Id: I87d45f21badb30ed44de9b9854c94fe7f67ecdc8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4605335 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 52152933 2023-06-06T15:36:36 Add trace_interface: functions and callbacks for traces Defines the interface between the test suite (or an other TraceLibrary class user) and trace libraries. TraceFunctions defines entry points for calls suite->trace, such as SetupReplay() or SetBinaryDataDir(). TraceCallbacks defines entry points for calls trace->suite, for example for loading .angledata.gz files. These are set up via the exported SetupEntryPoints() call. Functions like SetupReplay etc no longer need to be exported from the trace library. TraceInfo (parsed representation of the trace json) is moved to trace_interface as is. This is convenient for further changes to the fixture that will allow to easily move some of the captured parameters to json. This also moves Decompress functionality (and memory ownership) to test suite entirely, which avoids Decompress/Delete callbacks - the trace just calls LoadBinaryData via TraceCallbacks and TraceLibrary releases the memory either on FinishReplay or in its destructor. This should also take care of the memory leak described in https://crrev.com/c/3858185 Bug: b/286072760 Change-Id: Ibc6f6f64156ad805b1917c8fc41a3b0d2c0d6375 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4594445 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Prashanth Swaminathan c49674d1 2023-06-02T15:34:49 Remove stale Android NDK and references [2/2] Now that chromium/base has rolled and switched the android_ndk_root to the new android_toolchain directory, remove the stale Android NDK. Fix roller scripts to no longer roll Android NDK and Android blueprint generation can remove references to the removed sources. Bug: chromium:1448383 Test: Verified build of ANGLE. Change-Id: Iba8bfd8be9fd6bfb4f75f5d3a273411bd11f6b5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4585389 Auto-Submit: Prashanth Swaminathan <prashanthsw@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov b5d261ac 2023-06-08T13:13:29 Roll chromium_revision be1b60e248..510a3dff2b (1154868:1154869) Change fuchsia_sdk_cipd_prefix from fuchsia/sdk/gn to fuchsia/sdk/core per https://chromium-review.googlesource.com/c/chromium/src/+/4544541 Change log: https://chromium.googlesource.com/chromium/src/+log/be1b60e248..510a3dff2b Full diff: https://chromium.googlesource.com/chromium/src/+/be1b60e248..510a3dff2b Changed dependencies * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2d01747514 * third_party/fuchsia-sdk/sdk: version:12.20230601.2.1..version:12.20230607.1.1 * third_party/r8: e9kuk0ZE8fKLVJ33ULiDJQ43Sg-S8wbRD0pG7hEcP9AC..4nvRHMrsaaAwaTGCTVhj-rVB4rr7rtMUb01KL83_TA8C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/9c8e4fdccb..6fe0f7956f * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/a16d54239e..b9d0126966 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/66d5da40df..cc47a7ca0f * tools/luci-go: git_revision:2eaf659a45c8945c3e15f202c4e8a734243f8270..git_revision:0ecab437ae2532a879b1203efc48f54bc6cadb77 * tools/luci-go: git_revision:2eaf659a45c8945c3e15f202c4e8a734243f8270..git_revision:0ecab437ae2532a879b1203efc48f54bc6cadb77 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6b669febe1..ccf90ad0a2 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/cc6bc21649..57b3b9e7c0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7aca1a25c2..8ba510e8e2 DEPS diff: https://chromium.googlesource.com/chromium/src/+/be1b60e248..510a3dff2b/DEPS No update to Clang. Bug: None Change-Id: Ib0dd750864863bdec2229c5b0fc50a36930870f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4598293 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll ae9953ce 2023-06-08T10:01:05 Roll vulkan-deps from a6525fe76b4c to c5a1402a455f (35 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a6525fe76b4c..c5a1402a455f Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/12542fc6fc..030d0be28c * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ec244c8598..59b4febd81 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/3df77fb3e4..605dc6d3e7 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/1f20a308fc..c97930ba36 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/9a252664d7..2c83dd6cb2 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2e88dc0a67..ee8fe8140a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia832a37a1f46eb2a740c1101f0db0b22508813c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4599934 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Prashanth Swaminathan bc66167d 2023-06-07T17:39:14 Disable the roll of 'android_ndk' Chromium is being updated to 'android_toolchain', which means the 'android_ndk' DEPS is no longer present. Remove it from the roller until the transition is complete, then it can be removed from this script entirely. Bug: chromium:1448383 Change-Id: I0b515611a94f9aae5951655639a57ec5a9e7ffde Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4600111 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Prashanth Swaminathan <prashanthsw@google.com>
Prashanth Swaminathan 15a29438 2023-06-02T15:31:52 Migrate Android NDK to CIPD [1/2] The Android NDK dependency is moving to a CIPD bucket to reduce the checkout cost and to eventually move to NDK v25. This introduces the NDK into an 'android_toolchain' directory. Following the roll of chromium/base in this repository, a second change will delete the old 'android_ndk' checkout. As a result, the checkout size of this repository will temporarily increase. Bug: chromium:1448383 Test: Verified local builds of ANGLE. Change-Id: Id2b7593270ae8d98e7353011dbc1b564da107786 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4585388 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 176989ad 2023-06-07T07:42:58 Roll Chromium from 9e0b5e8b8a85 to fe5f79e217c4 (537 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9e0b5e8b8a85..fe5f79e217c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c884d70f0c..7921c7ccf1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/098d0a11e4..c1df87f08b * third_party/android_build_tools/lint: FObSM0x4tmlkstBzjEhG3sHenn993tmoNjl5naaW28AC..3AJFzcPQ9EDTP7XlHY6bgKZvGn7D812ptquuXFcUWzEC * third_party/android_build_tools/manifest_merger: u2r6t6i4MR-JZBn40RJTHzLBwT4y59mjHv6kkrAlLSQC..nGzWwB6kx8dBDTH7L1jUxm8y3INDX3qVm9co3ntGk7EC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1c6d2fbaf7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d627781be..e445df0bfb * third_party/r8: iTbMDX2gRMW4nmoA8J7oToRDDsMcjm6hJNVH-RpYKIoC..e9kuk0ZE8fKLVJ33ULiDJQ43Sg-S8wbRD0pG7hEcP9AC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/81976120c2..a16d54239e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/38995191a8..6b669febe1 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/1084fb884e..cc6bc21649 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7813c31dc3..7aca1a25c2 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ic0801cd566edf88973d7bfef7a83374268dda2ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4593673 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 31aa3fa5 2023-06-06T09:54:37 Roll Chromium from d6f22a2a164b to 9e0b5e8b8a85 (1063 revisions) Manually update third_party/flatbuffers from Chromium https://chromium.googlesource.com/chromium/src.git/+log/d6f22a2a164b..9e0b5e8b8a85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/defeac7e7d..c884d70f0c * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/cd144ced35..b5a43ecdac * testing: https://chromium.googlesource.com/chromium/src/testing/+log/21f1443014..098d0a11e4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..dc627ec37b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9e0ff22bfb..0d627781be * third_party/flatbuffers/src: https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/a56f9ec50e..13fc75cb6b * third_party/r8: 0LMjUUpzAmxHrlftkzbDAaeuTDNXrOEgTgyJm8qIyvMC..iTbMDX2gRMW4nmoA8J7oToRDDsMcjm6hJNVH-RpYKIoC * third_party/turbine: Foa7uRpVoKr4YoayCKc9EERkjpmGOE3DAUTWFLL7gKEC..G8Cku1fztaDd9to_8gk3PNWM2iRacAxD9zcUAgUPUEAC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/982b036a25..9c8e4fdccb * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/07b548d993..81976120c2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/499a012d25..66d5da40df * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/10c4d4779d..38995191a8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f08244f24a..7813c31dc3 * tools/skia_goldctl/linux: UMqOqE8nlXwo9xj56g4W9ySvvqo2Tsw3B6tWZLo19L8C..7Xu0Ohf2xgwAgLoFgq7LiZmi_Uk3x5gIX5Dta-tZg40C * tools/skia_goldctl/mac_amd64: vjY1ew6KN-bIFZEk7IbwPCAb6xZxib9uqLXMwbi8JLQC..KYHtCI8pS_1-ZVhMhj0d7h-3H8ZdNtaGLYsYnDqRbnMC * tools/skia_goldctl/mac_arm64: twOZsJTmRSqlOwstPpWMhT_fXhiOaijMu24-UJLGK20C..h-5CLVE7g4EEE3-uXZ610OaDlIMoYEx3RLgGWHXRA9AC * tools/skia_goldctl/win: wveYksSfL51dPfdRZ5474IFmCMkL8gg6ygZxxPdBezAC..VWg6iFKkt4rAdHxGoJNLVlgsRlbT-Woz_41P6cFybmYC No update to Clang. Bug: angleproject:8178 Tbr: geofflang@google.com Change-Id: Id46eb10ca81c88f396e42c17b55ead4f77af08c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4593140 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Roman Lavrov e7a9275b 2023-06-02T18:09:40 Make run_code_generation faster using python3 for auto_script Only changes the way we get auto_script inputs/outputs. Before this CL, some of the scripts (depending on the shebang) are run via vpython3 - which can take a few seconds. But the inputs/outputs code generally doesn't require any unusual imports, so we can just add little hacks to suppress those imports where needed when an argument is given to the script. Bug: angleproject:8184 Change-Id: Ib09a35b839318253fe7e913e24a756d2cb46dad1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4585820 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e64794b2 2023-06-02T15:46:31 Manual roll VK-GL-CTS from 356e6d2f8796 to 0c2e936905ea (9 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/356e6d2f8796..0c2e936905ea 2023-06-02 rgarcia@igalia.com Test in-bounds attribute in out-of-bounds stride 2023-06-02 marcin.zajac@mobica.com vk-build-programs executors limiter 2023-06-02 ziga@lunarg.com Add xfb query copy tests with availablity 2023-06-02 rgarcia@igalia.com Test negative vertex offset indices with indexed draws 2023-06-02 gleese@broadcom.com Change normalize precision to reduce needless inaccuracy 2023-06-02 vantablack@google.com Add VkFormat to AHB Format cases to dEQP 2023-06-02 gleese@broadcom.com Fix reference values for double precision degrees and radians 2023-06-02 piotr.byszewski@mobica.com Auto-generate knownConformanceVersions 2023-06-02 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ia8229869be6fc13fac4e9d58b5780ac74bdd7746 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4582660 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 4d205990 2023-06-02T10:56:24 Add all of tools/android to DEPS Additional dependencies are being added to //build that reside outside of it, and that also resolves the problem where lookup_dep.py was manually checked in into ANGLE: https://anglebug.com/8178#c15 Bug: angleproject:8178 Change-Id: I332cd955ad6857f87e5611284ed43da6a69d4c30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4582331 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 5726566a 2023-06-01T10:01:45 Roll vulkan-deps from 354eac3ca8c8 to a6525fe76b4c (50 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/354eac3ca8c8..a6525fe76b4c Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/9fbc561947..a6662c53ce * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/69155b22b3..8e2ad27488 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f29e11dcb6..ec244c8598 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/9e61870ecb..3df77fb3e4 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b95d065ec5..1f20a308fc * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/9aafa3cf1a..9a252664d7 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/27c61c8dd6..2e88dc0a67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I1cc7ff765daf355cab281712b6a3fb9cedd8a4ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4577893 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi b0e9bbd7 2023-05-31T14:23:40 Vulkan: Split features for dynamic state When a driver bug with dynamic state is encountered, it is hard to debug which dynamic state exactly is causing an issue, due to the current granularity of disabling all entire state from an extension. With this change, every dynamic state gets its own ANGLE feature, and can be toggled as necessary. Disabling the supportsExtendedDynamicState* features implicitly disables all dependent features. Bug: b/285124778 Bug: b/275210062 Bug: fuchsia:107106 Bug: angleproject:5906 Change-Id: Ic291279872df2d0eb58618ff364ab118bdcc4a9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4577553 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Mark Lobodzinski 29ad234a 2023-05-30T12:03:30 Tests: Add Off The Road trace Test: angle_trace_tests --gtest_filter=TraceTest.off_the_road Bug: b/285110104 Change-Id: I63e86ea9a18f9f60680ac758e284cc1b5e90c0ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4576882 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu dfb2bab0 2023-05-25T15:08:19 Apply Aliased Decorators To Image DataTypes Bug: b/274478912 Bug: b/266235549 Change-Id: I2cd272a1e7481a8803be63efe0be11c61560b23e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4568287 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 0bc13958 2023-05-31T09:51:13 Roll Chromium from 57b220f0ca60 to a4089b2e7987 (733 revisions) Manually add third_party/cpu_features DEPS per https://chromium-review.googlesource.com/c/chromium/src/+/4545271 https://chromium.googlesource.com/chromium/src.git/+log/57b220f0ca60..a4089b2e7987 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6cb0fb63f3..1ee2c02fc6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5102dd5718..dddefcbae6 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/48cb81215e..2445bb17e1 * third_party/android_build_tools/lint: pSX8QZklEn1odNNyvBBDnanIA4IBlNNFgsAYPXnk-SYC..FObSM0x4tmlkstBzjEhG3sHenn993tmoNjl5naaW28AC * third_party/android_build_tools/manifest_merger: guwWgYx931yQa5Mj6M08VMupp2R1bo_2F6zOS-azX9UC..u2r6t6i4MR-JZBn40RJTHzLBwT4y59mjHv6kkrAlLSQC * third_party/android_ndk: https://chromium.googlesource.com/android_ndk.git/+log/8388a2be54..310956bd12 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/f312145c41..9f29aca7dd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9f3ef9c2ea * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/530d86d40b..05ab73be51 * third_party/fuchsia-sdk/sdk: version:12.20230529.1.1..version:12.20230530.1.1 * third_party/r8: 9dmrdF_0VI2W4VoKglVJJXLHpn8Aw00PAHSpkQL63hcC..4Oq32DG2vuDh7Frxj6tH5xyi77sVgBWpvvl4hwvZRR4C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/337322d10f..0cf42a2592 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fa0546ccb6..b86e044e91 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2ff63e72c7..6f1c5c73da No update to Clang. Bug: chromium:1446042 No-try: true Change-Id: Id621741615cdfd54657f8f6cb9f88ec303dcb0a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4575480 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 8447e279 2023-05-30T13:56:19 code_generation_hashes json files end with newline Bug: None Change-Id: Iddd2c1777a1d5486a4d390c6e3d56ffb09f47f02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4574569 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 89228c43 2023-05-30T07:02:32 Roll Chromium from c0f2c5cab1b4 to 57b220f0ca60 (1475 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c0f2c5cab1b4..57b220f0ca60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/40ec269a47..6cb0fb63f3 * buildtools/linux64: git_revision:e9e83d9095d3234adf68f3e2866f25daf766d5c7..git_revision:e3978de3e8dafb50a2b11efa784e08699a43faf8 * buildtools/mac: git_revision:e9e83d9095d3234adf68f3e2866f25daf766d5c7..git_revision:e3978de3e8dafb50a2b11efa784e08699a43faf8 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/982e218cb8..5c8dbff7a4 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/55ceecab99..cd144ced35 * buildtools/win: git_revision:e9e83d9095d3234adf68f3e2866f25daf766d5c7..git_revision:e3978de3e8dafb50a2b11efa784e08699a43faf8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/06f1c1ef67..5102dd5718 * third_party/android_build_tools/aapt2: aidBg3POIv_jPt-kZ7O9aQ6-UdFSuLd8uBgGg4REBjsC..STY0BXlZxsEhudnlXQFed-B5UpwehcoM0sYqor6qRqsC * third_party/android_build_tools/lint: AS57ntD4VO2MAIu0pkI0b3c3cFkdGt0cAkmSkiRimZkC..pSX8QZklEn1odNNyvBBDnanIA4IBlNNFgsAYPXnk-SYC * third_party/android_build_tools/manifest_merger: HW7DJwNOXl50MEneaQnyD1Yg1sy_0Eej5E1nKepXq40C..guwWgYx931yQa5Mj6M08VMupp2R1bo_2F6zOS-azX9UC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..44beba1e6d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/456d085e75..530d86d40b * third_party/fuchsia-sdk/sdk: version:12.20230520.1.1..version:12.20230529.1.1 * third_party/r8: dJL8gwEiDUoK5pirX6la4l7ofdBufwcc1HUaCv4CZ8cC..9dmrdF_0VI2W4VoKglVJJXLHpn8Aw00PAHSpkQL63hcC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/14dd4c4455..337322d10f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/88e8637696..6cf0c7b139 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b7e3f403e3..2ff63e72c7 No update to Clang. Bug: angleproject:8178 Tbr: solti@google.com Change-Id: Ic974cb92ecf2a6c87f80a740bd7110effccfb392 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4572632 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 16b9a16a 2023-05-26T14:45:15 Add supports_legacy_dithering feature VK_EXT_legacy_dithering => VkPhysicalDeviceLegacyDitheringFeaturesEXT.legacyDithering => supportsLegacyDithering Now getting enabled=true on Android master. Bug: b/284462263 Change-Id: Ibf43184c78d9847044b10413d2050b653e452c9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4567572 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4dcfd08c 2023-05-26T14:52:21 Roll VK-GL-CTS from f7a3350256a6 to 356e6d2f8796 (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/f7a3350256a6..356e6d2f8796 2023-05-26 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2023-05-25 gleese@broadcom.com Fix problems when buffer_storage not supported 2023-05-25 gleese@broadcom.com Remove deFloatCmp functions 2023-05-25 rgarcia@igalia.com Test clearing images with 64-bit formats 2023-05-25 matt.coster@imgtec.com Add pre-VK_KHR_maintenance1 implied features to compressed formats 2023-05-25 lionel.g.landwerlin@intel.com Enable descriptor buffer tests on implementation without compute only queues 2023-05-25 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-05-22 piotr.byszewski@mobica.com Split pipeline.txt mustpass into multiple files 2023-05-20 alexander.galazin@imgtec.com Add option to skip build post checks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I09d94c9696c30eb81f374608ac778fb80b2fe4e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4571063 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Joanna Wang 388a184d 2023-05-25T22:19:46 Fix clang_format -> clang-format path in DEPS. Bug: chromium:1447924 Change-Id: I42a99b9d5015fd5d957ad3a7fe74e90f5442bc83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4566834 Auto-Submit: Joanna Wang <jojwang@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Mark Lobodzinski c5282661 2023-05-24T15:33:19 Tests: Add Infinity Ops Trace Test: angle_trace_tests --gtest_filter=TraceTest.infinity_ops Bug: b/284273677 Change-Id: I19daa0a0e96a619ff3ec18074012cda213854947 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4566950 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Kenneth Russell aea88562 2023-05-19T16:52:43 Reland "Metal: Optimized BufferSubData per device" This reverts commit ee64836f702332adaca58d9f452063a04b2da955 , relanding the patch stack described there. Between patchsets 1 and 5: - The shadow buffer allocation has been replaced with a multimap of precisely-sized buffers, rather than rounding up buffer sizes. - Garbage collection of shadow buffers is triggered in three situations: - A certain number of context switches have occurred; this number was hand-tuned to avoid GC every frame. - A certain number of command buffer submissions has occurred; this number was hand-tuned to GC no more often than every few seconds on representative workloads. - The total size of the allocated shadow buffers is more than 1 MB, and either more than twice the size at the last garbage collection, or 64 MB more than at the last garbage collection. In this case, aggressive GC is performed in order to reclaim shadow buffers more quickly. Performance before and after these changes appears identical on microbenchmarks. On one Figma test case, comparing GPU memory allocated inside the BufferManager, peak consumption is decreased by over 75%, and steady-state consumption decreases by over 88%. Patchset 6 adds a needed workaround for a bug in the AMDMTLBronzeDriver affecting uploads of client-side data, and therefore some dEQP tests. It also streamlines the aggressive GC. Bug: angleproject:7544 Change-Id: I81b061f0b33c27fa403527fa12d626f4e9c88ebe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4497413 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Joanna Wang c121b013 2023-05-23T14:58:11 Change clang_format path in angle. Bug: chromium:1447924 Change-Id: I148f8861d1fdc47c25aaad659aa2effe1f1e0af4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4567824 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Joanna Wang <jojwang@chromium.org>
Mike Schuchardt c18972fd 2023-04-05T10:22:38 Tests: Add Gangstar Vegas trace Test: angle_trace_tests --gtest_filter=TraceTest.gangstar_vegas Bug: b/280785771 Change-Id: Ia1d5de22d45979b44b0711fc510d2dfb7600b910 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4507340 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski ad386845 2023-05-24T11:14:12 Tests: Add Empires and Puzzles trace Test: angle_trace_tests --gtest_filter=TraceTest.empires_and_puzzles Bug: b/283500712 Change-Id: I3b4ed61ebe8948319ca74e79cb74053b554b0009 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4551449 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 24504dd1 2023-05-23T20:27:49 Tests: Add Kentucky Route Zero trace Test: angle_trace_tests --gtest_filter="*kentucky_route_zero*" Bug: b/284061674 Change-Id: Iab42008bfa3604e306628e90abc04b7ceb6fd4bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4559458 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 33e38862 2023-05-24T00:00:00 Vulkan: Limit clampFragDepth workaround to affected drivers Bug: angleproject:3970 Change-Id: I708591d86b8f2cb10d0cbdc7c14518fda45ac626 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4562134 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Mark Lobodzinski 9e47cbd3 2023-05-18T14:40:37 Capture/Replay: Rework trace EGLDisplay handling Refactor the trace-replay EGLDisplay handling to allow initializing the global EGLDisplay handle in the InitializeReplay4() body. This included adding support for eglGetCurrentDisplay() to the EGL-on- WGL shim. Test: angle_trace_tests --gtest_filter=infinity_ops Bug: b/282725258 Change-Id: I2319fd9a35f8fb9c0a7f10547ca39f49ce402b8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4546267 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Geoff Lang 6d3e5870 2023-05-17T16:42:47 Metal: Disable Metal support on NVIDIA GPUs NVIDIA GPUs are in a very small number of Macs and we don't have have adequate test coverage to properly support them. Add the disable_metal_on_nvidia feature to control support for NVIDIA at runtime. Also factor the support of GPU family 1 into a feature. Bug: angleproject:8170 Change-Id: I160036d710cc9e278eb77e351a483b9f5b69e8ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4544659 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Alexey Knyazev 7abc5248 2023-05-19T00:00:00 Vulkan: Enable VK_EXT_depth_clamp_zero_one Replaced the 'depth_clamping' workaround with the dedicated extension or explicit fragment depth clamping. Fixed: angleproject:3970 Bug: angleproject:8077 Change-Id: Ia7666fcb3e0e949922c13a3fd11b818cbc5a8e26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4545084 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a4b1d12c 2023-05-22T07:02:43 Roll Chromium from be870e411d55 to 853c619b8b56 (679 revisions) https://chromium.googlesource.com/chromium/src.git/+log/be870e411d55..853c619b8b56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8aefde05e4..7f93a1e7ae * buildtools/linux64: git_revision:6975103d9f59ed9f3cfbc6d2201298f2c2fde046..git_revision:e9e83d9095d3234adf68f3e2866f25daf766d5c7 * buildtools/mac: git_revision:6975103d9f59ed9f3cfbc6d2201298f2c2fde046..git_revision:e9e83d9095d3234adf68f3e2866f25daf766d5c7 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a4c3a6dc75..982e218cb8 * buildtools/win: git_revision:6975103d9f59ed9f3cfbc6d2201298f2c2fde046..git_revision:e9e83d9095d3234adf68f3e2866f25daf766d5c7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/60112c1352..2ab5e92e5f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c6222c27ba * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b0e8e7adbc..3a5cc40813 * third_party/fuchsia-sdk/sdk: version:12.20230518.3.1..version:12.20230520.1.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c419c81c92..4ee099ac1c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/182e9e0811..242e5a37e4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/adeff0564b..4d8da41eb0 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I4924e9d31cc5c85413826ab87722e3bc77bc2b5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4551447 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop c04ad8e0 2023-05-17T10:59:36 Tests: Add Honkai: Star Rail trace Test: angle_trace_tests --gtest_filter="*honkai_star_rail*" Bug: b/283129009 Change-Id: I4c41345b83b7ea2429bccb8a814994bcb13a7486 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4545308 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov 9208efb6 2023-05-19T16:56:59 Stop ANGLE Mac Intel 13.3 experiment Bug: chromium:1429033 Change-Id: I2a4cf72d68855c54b87fc33bc6b0c150ad5246ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4549123 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll 18ff4555 2023-05-19T16:45:54 Roll VK-GL-CTS from 876d164bd88a to a46ca6e9c7bb (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/876d164bd88a..a46ca6e9c7bb 2023-05-19 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2023-05-19 ziga@lunarg.com Add depth bias constant and slope tests 2023-05-19 zzoon@igalia.com Add more tests for FSR with depth/stencil attachments on various cases. 2023-05-19 rgarcia@igalia.com Test multiple queries in PGQ tests 2023-05-19 rgarcia@igalia.com Avoid waiting for fences in primitives generated query tests 2023-05-19 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-05-16 rgarcia@igalia.com For merge of bb2e68d9b5220e6eb4195002e56d61c79d2c8261 to main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I41a5d029e9db6941cfb3c42c2a11c10c8fab3540 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4549597 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c9029ddf 2023-05-19T07:00:45 Roll Chromium from bc320a94824d to be870e411d55 (839 revisions) https://chromium.googlesource.com/chromium/src.git/+log/bc320a94824d..be870e411d55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/36246d88fa..8aefde05e4 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/7454e17b0d..a4c3a6dc75 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7e91557f2b..60112c1352 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1ab95012c7..7a6ed2c936 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ac9d6ede9a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cdefe67b38..b0e8e7adbc * third_party/fuchsia-sdk/sdk: version:12.20230517.1.1..version:12.20230518.3.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/096dcd2735..c419c81c92 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f4fa549a2b..182e9e0811 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c278749207..adeff0564b No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I02b5540faaaf176bb5765af2467be5c25a5bc247 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4548152 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 7d4c6d1d 2023-05-09T12:19:54 Allow glDelete* while PLS is active Banning glDelete* is extremely dangerous. It will almost definitely cause memory leaks in client code, and it makes JS garbage collection needlessly complex. Instead, specify that PLS is implicity deactivated if the client deletes anything that is attached to the current draw framebuffer during a PLS rendering pass. Bug: chromium:1421437 Change-Id: I3a18ee6b5d5567431e6fa3eccea58cb049845502 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4521436 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Shahbaz Youssefi b76166d0 2023-05-18T09:57:25 Vulkan: Separate image and sampler 2D view of 3D features The sampler feature is used to determine if EGL_KHR_gl_texture_3D_image can be exposed. The image feature is used to support base GLES 3.1 storage images. Bug: b/274478146 Change-Id: Ifb283633078ace7ee65f8aafe756d0a02b727bd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4545005 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll d238e8b9 2023-05-17T21:20:43 Manual roll Chromium from 79f85a216141 to bc320a94824d (1646 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/79f85a216141..bc320a94824d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/44a4b24b05..36246d88fa * buildtools/linux64: git_revision:26aa46c283e40199b6f847ecca088dcea7099ded..git_revision:6975103d9f59ed9f3cfbc6d2201298f2c2fde046 * buildtools/mac: git_revision:26aa46c283e40199b6f847ecca088dcea7099ded..git_revision:6975103d9f59ed9f3cfbc6d2201298f2c2fde046 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f2cb09f94e..7454e17b0d * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/129773dde5..55ceecab99 * buildtools/win: git_revision:26aa46c283e40199b6f847ecca088dcea7099ded..git_revision:6975103d9f59ed9f3cfbc6d2201298f2c2fde046 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9d1f44540f..7e91557f2b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/534624edd1..72efcb2452 * third_party/android_build_tools/aapt2: fFfHyo80O9opPFsbOisSHF4d3tV4GGxLgxXWzGRuY2IC..aidBg3POIv_jPt-kZ7O9aQ6-UdFSuLd8uBgGg4REBjsC * third_party/android_build_tools/lint: MTFSl9JaPMnHhDPun-Ry9w5lM4HeEVlSFebjgzoraCQC..AS57ntD4VO2MAIu0pkI0b3c3cFkdGt0cAkmSkiRimZkC * third_party/android_build_tools/manifest_merger: VcQAPv15h63jZcRobvLMBWCiuDXUdmwB8OH1x6W1aJMC..HW7DJwNOXl50MEneaQnyD1Yg1sy_0Eej5E1nKepXq40C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f1f7a299cb * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a1e578320b..cdefe67b38 * third_party/fuchsia-sdk/sdk: version:12.20230512.2.1..version:12.20230517.1.1 * third_party/turbine: j0GanRK31QhKNs04PYT0D3ls32n6IrjrAL8bR4dv9jMC..sTawWbD0GN8RYp6JHHFxxGNi2nNPvuNSuBjIpS4GaD0C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/062d938956..096dcd2735 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d0e45e54c3..f4fa549a2b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/25bb7e161f..c278749207 No update to Clang. Bug: angleproject:8081 Tbr: yuxinhu@google.com,ynovikov@google.com Change-Id: I6d78dc2cd54eac092554bb3792a32561a39f00ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4545305 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu c1fc512b 2023-05-16T17:14:23 Manual roll VK-GL-CTS from e3b9db9ad121 to 876d164bd88a (32 revisions) Manual roll requested by yuxinhu@google.com * Skipped the following tests: dEQP-EGL.functional.fence_sync.valid.egl_fence_persistent_buffer KHR-GLES31.core.texture_buffer.texture_buffer_errors https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/e3b9db9ad121..876d164bd88a 2023-05-16 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2023-05-16 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2023-05-15 piotr.byszewski@mobica.com Fix vkExtensionFunctions.inl 2023-05-15 javed@igalia.com Add coverage for specific synchronization2 access flags 2023-05-15 cturner@igalia.com Add VPS handling for h265 tests 2023-05-15 ziga@lunarg.com Fix api version check in entry_points test 2023-05-15 matt.coster@imgtec.com VK_FORMAT_FEATURE_TRANSFER_{SRC,DST}_BIT are implied on Vulkan 1.0 without VK_KHR_maintenance1 2023-05-15 ziga@lunarg.com Set missing dynamic states in null_color_blend_att_ptr tests 2023-05-15 scerveau@igalia.com vulkan-video: update ESExtractor to v0.3.3 2023-05-15 cturner@igalia.com Add extra checks for FENV_ACCESS support on 32-bit ARM 2023-05-15 rgarcia@igalia.com Test large values when converting from float to 64-bit ints 2023-05-15 ziga@lunarg.com Enable graphicsPipelineLibrary feature when libraries are used 2023-05-15 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-05-15 alexander.galazin@imgtec.com Notice of withdrawal of Vulkan CTS 1.3.2.x 2023-05-08 rgarcia@igalia.com Test multi-value sample mask with dynamic rasterization samples 2023-05-08 rgarcia@igalia.com Test GPL with null VkPipelineRenderingCreateInfo contents 2023-05-08 rgarcia@igalia.com Test EDS3 null pipeline state pointers 2023-05-05 ziga@lunarg.com Add tests for pipeline robustness with cache 2023-05-05 debarshid@google.com Implement Sync Tests between CPU and GPU 2023-05-05 chrisglover@google.com Add tests for EXT_gl_colorspace_bt2020 2023-05-05 cturner@igalia.com Fix VUID-VkVideoSessionCreateInfoKHR-maxActiveReferencePictures-04849 2023-05-05 cturner@igalia.com Fix VUID-vkCmdDecodeVideoKHR-pDecodeInfo-07163 validation error 2023-05-05 cturner@igalia.com Fix memory corruption during validation for decode.h264_interleaving 2023-05-05 marcin.zajac@mobica.com fetch_sources.py for cygwin and mingw 2023-05-05 gleese@broadcom.com Fix VK/VK-SC generated file inclusion 2023-05-05 gleese@broadcom.com Remove unused VKUTIL_LIBS 2023-05-05 rgarcia@igalia.com Test read-only depth/stencil attachment with VRS 2023-05-05 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.5 into vk-gl-cts/main 2023-05-04 rgarcia@igalia.com Test some EDS3 line rasterization parameters with mesh shaders 2023-05-04 rgarcia@igalia.com Test dynamic blend equation with dual source blending 2023-05-03 piotr.byszewski@mobica.com Update vulkan-docs to current version 2023-05-03 cturner@igalia.com Update removeTags in fetch_sources.py for glslang If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8166 Bug: angleproject:8167 Bug: angleproject:8169 Change-Id: I0fb573b382e63bf4820a083759e57647f6159763 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4544088 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop ec308b35 2023-05-15T15:03:10 Vulkan: Add feature to limit sample count to 2 This CL adds a feature called `limitSampleCountTo2`. Using it will have the Vulkan backend limit max samples to 2. Why 2? That's the minimum required in Vulkan to multisample without error. Here's an example validation error: vkCmdResolveImage: srcImage sample count is VK_SAMPLE_COUNT_1_BIT. The Vulkan spec states: srcImage must have a sample count equal to any valid sample count value other than VK_SAMPLE_COUNT_1_BIT. https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkCmdResolveImage-srcImage-00257 Using a limit as opposed to forcing a value allows non-multisampling (sample count of 1) to continue working. To see how tests fare when the feature is set, see the following test results that force the value on: https://chromium-review.googlesource.com/c/angle/angle/+/4534098/4 Test: adb shell setprop debug.angle.feature_overrides_enabled limitSampleCountTo2 Bug: b/279498079 Bug: angleproject:8162 Change-Id: I1df2822709151e6084c32055b5aff444e0b10db5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4518562 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Greg Schlomoff <gregschlom@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov df53154b 2023-05-09T12:02:13 Add a script to bundle trace(s) for sharing with partners. Similar to mb.py zip but with a few ANGLE-specific tricks significantly reducing the clutter, and with a couple of helper scripts added to the zip (see file docstring for details). vs mb.py, single trace, not including lib.unstripped: 400+MB => <100MB ~5800 files => <50 files Time to bundle: ~30s => ~6s Bug: b/276474703 Change-Id: I57f51dd6302045d02d0ee94ef84186446cafd570 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4518061 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang b1395bcb 2023-05-09T12:34:55 GL: Disable EXT_clip_control on Mali-G72 and G76. Querying the clip control state from the driver when sychronizing external contexts generates driver errors. Simply disable this extension in this configuration for now. Chrome is currently not using it for rasterization. This issue was noticed on specific Huawei devices in the wild. It hasn't been observed on other OEMs. Bug: chromium:1434317 Change-Id: I88d9bff1933274f61020b75e68aee9c94b0b684a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4518062 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org>
Hailin Zhang 8b9440b6 2023-05-01T15:31:01 Vulkan: add option to control pipeline cache data compression. Bug: b/258207403 Change-Id: I487b1cadbacfa2f7ee889a8f58278307a126a391 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4497248 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Hailin Zhang <hailinzhang@google.com>
Yuly Novikov 39ac3fab 2023-05-10T17:43:17 Start ANGLE Mac Intel 13.3 experiment Bug: chromium:1429033 Change-Id: I8c640004f3255b8c563e172b8bbce9c516437277 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4517830 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll 1b8d11a5 2023-05-10T07:38:02 Roll Chromium from d08108198321 to 1e9340f9e024 (1189 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d08108198321..1e9340f9e024 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d609da478e..6bbe2e2f61 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a26ff314e9..33efc9db43 * buildtools/linux64: git_revision:3dadaf0ee3ee07d7c29ad926e1a42d90068d7e6b..git_revision:26aa46c283e40199b6f847ecca088dcea7099ded * buildtools/mac: git_revision:3dadaf0ee3ee07d7c29ad926e1a42d90068d7e6b..git_revision:26aa46c283e40199b6f847ecca088dcea7099ded * buildtools/win: git_revision:3dadaf0ee3ee07d7c29ad926e1a42d90068d7e6b..git_revision:26aa46c283e40199b6f847ecca088dcea7099ded * testing: https://chromium.googlesource.com/chromium/src/testing/+log/74258afcd3..a6b84b1027 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c225168a18..1ab95012c7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e40b8a3047 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4931c18599..f155639336 * third_party/fuchsia-sdk/sdk: version:12.20230505.3.1..version:12.20230509.4.1 * third_party/r8: _FuL1VmaJnETpwNIaiuiSLxVNzzt0qXGmsfAck4CPCkC.._46Jff_5DxQREre2ppSsZwebqQYn7rCXCukEvdhmjqsC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/448305bbeb..1e3e58d7f0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0377ee52d9..0a32157f59 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5b4a9ede47..864d61e2e7 No update to Clang. Bug: angleproject:7079 Tbr: abdolrashidi@google.com Change-Id: Ic6f8aa5ac3e6507bf5af1d867840c73fa3731fdb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4519844 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Scott Violet b0f9c01e 2023-05-01T12:54:10 metal: adds feature that minimizes generated shader differences This adds a feature (enabled by default) that results in generating the same code regardless of whether emulateAlphaToCoverage is enabled or addExplicitBoolCasts. This is done to maximize cache sharing. Bug: chromium:1423136 Change-Id: Ia491f13469c750fc2c45aecf1f93fed53b782dc5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4496254 Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org>
Yuly Novikov a7b26adf 2023-05-09T18:12:27 Revert "Retry flaky failures on SwiftShader *SAN builds." This reverts commit f0d2dbec74362c07806d9adb57f27bfa2ff6e91c. Reason for revert: flakiness root cause expected to be fixed Original change's description: > Retry flaky failures on SwiftShader *SAN builds. > > This should green up the TSAN builder. > > Bug: chromium:1275223 > Change-Id: Id8dc2e35b739caa6688d13fcabfefb9833940d79 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3804745 > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Auto-Submit: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1275223 Change-Id: I53645f859d7288fb82c258a0540259ae8a9e7138 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4517644 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Geoff Lang fbca2b29 2023-05-08T16:19:54 Metal: Build built-in shaders from source on the simulator Compiling the built-in shaders with iphonesimulator sdk generates the same shaders as on iOS which do not work on the simulator. Fall back to simply building them from source on the simulator. Bug: chromium:1385510 Change-Id: If6a3846fd06a4ff12c1e46c31f207e2a7b6c50bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4515521 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 7f04dc7d 2023-04-19T15:05:47 Reland: Metal: Embed precompiled default shaders. Compile all builtin shaders to an embedded mtllib to avoid the overhead of compiling them at startup. This reland adds ios simulator precompiled shaders. Bug: chromium:1385510 Change-Id: Ic8585ffe566875e705f2fb00f8e665e8a80797f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4512494 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 1a847d4a 2023-05-08T07:01:47 Roll Chromium from 16e9449c3c88 to d08108198321 (723 revisions) https://chromium.googlesource.com/chromium/src.git/+log/16e9449c3c88..d08108198321 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/54bd39c0c5..d609da478e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/dd3595d173..a26ff314e9 * buildtools/linux64: git_revision:5a004f9427a050c6c393c07ddb85cba8ff3849fa..git_revision:3dadaf0ee3ee07d7c29ad926e1a42d90068d7e6b * buildtools/mac: git_revision:5a004f9427a050c6c393c07ddb85cba8ff3849fa..git_revision:3dadaf0ee3ee07d7c29ad926e1a42d90068d7e6b * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/737446fc52..f8279b0108 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/66967963e9..d5e79e117c * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/88bd83fe09..229ff3e232 * buildtools/win: git_revision:5a004f9427a050c6c393c07ddb85cba8ff3849fa..git_revision:3dadaf0ee3ee07d7c29ad926e1a42d90068d7e6b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7a97f0e3c4..74258afcd3 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/eec484b5a6..2248225726 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7924448af6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/71ab1b77a7..4931c18599 * third_party/fuchsia-sdk/sdk: version:12.20230504.4.1..version:12.20230505.3.1 * third_party/r8: 7-lseJ9e9PfiZg_2LgyaUA4ru9NwaTGoDwYGMYP0BeYC.._FuL1VmaJnETpwNIaiuiSLxVNzzt0qXGmsfAck4CPCkC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/dc8628ce87..0377ee52d9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/02f2a2edd4..5b4a9ede47 No update to Clang. Bug: angleproject:5223,angleproject:6430 Tbr: cnorthrop@google.com Change-Id: I319fdde69f4ff5b854a86f45c70175a2eb03cf77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4511879 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 577b6c8d 2023-05-05T10:49:04 Tests: Add Street Fighter IV CE trace Test: angle_trace_tests --gtest_filter=TraceTest.street_fighter_iv_ce Bug: b/281007960 Change-Id: I81da4b005c50e915090f342d50362e4f8f0ac1f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4508393 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll df8733c9 2023-05-05T09:08:55 Roll Chromium from becaac9672a0 to 16e9449c3c88 (618 revisions) https://chromium.googlesource.com/chromium/src.git/+log/becaac9672a0..16e9449c3c88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1345fb9c5d..54bd39c0c5 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fe9a4e4107..dd3595d173 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9460fb138d..737446fc52 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/19470647da..7a97f0e3c4 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/f0c7b47622..f312145c41 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/5353fa6142..d8e55758cb * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6b573b0676 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dbcecc9017..71ab1b77a7 * third_party/fuchsia-sdk/sdk: version:12.20230503.3.1..version:12.20230504.4.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9969814713..448305bbeb * tools/luci-go: git_revision:e91834850a06011c64eb9a24f317371194bde3de..git_revision:55cc876158c057cd64677f1a1a2573c36c6c3025 * tools/luci-go: git_revision:e91834850a06011c64eb9a24f317371194bde3de..git_revision:55cc876158c057cd64677f1a1a2573c36c6c3025 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/295d9239b1..dc8628ce87 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ce6519bca3..02f2a2edd4 * tools/python: https://chromium.googlesource.com/chromium/src/tools/python/+log/00ecbd0693..64dd0e593f * tools/skia_goldctl/linux: CxdbSDz7x0X2t_Dg2V1hC-j5REZM59AmMDtLZNg9J_8C..a-YJwLTxkjqd2RiPjLgNKQrPzZY4CwqYLxtiQmB1KM8C * tools/skia_goldctl/mac_amd64: 66xq4FM7P4vA4N6oUkuUIEHz8vHWRjxClUgkjPZ71pQC..UVEHL3UFZ4Zyc_SiQYiOWInJuMcA4GAcLMlCWyEH6W0C * tools/skia_goldctl/mac_arm64: d3aWqZUdjjbgmIsOh-iK7HRZKaYz672JkzWg-0BkauUC..AwMNPFd_J5v55oBqSbV3MzxaPtyLyLmtEA_e1KMQ_PcC * tools/skia_goldctl/win: 5HtHEYI8MUjySHqpU8-ewiaPfNEVcY0SamdPah6R0CYC..rZtqSPxHMFApdEuqDjW0FlpdEQJTl335JOkoHTawxtkC Clang version changed llvmorg-17-init-8029-g27f27d15:llvmorg-17-init-10134-g3da83fba Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/996981471300dc79bd41808d4b02bc44ee1112e7..448305bbeb6dfddd88b74a016c6aeeb16d6de1cd/scripts/update.py Bug: angleproject:6430 Tbr: cnorthrop@google.com Change-Id: Ifa152a1d4e8239666c070cf1353efe708938a0e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4508558 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop d925c5c9 2023-05-04T16:16:11 Revert "Metal: Embed precompiled default shaders." This reverts commit 9f6c9f6630b63f541f5fd875aef87ce2a26fd618. Reason for revert: iOS Metal tests broken downstream: https://ci.chromium.org/ui/p/chromium/builders/ci/ios-blink-dbg-fyi/4972/overview Original change's description: > Metal: Embed precompiled default shaders. > > Compile all builtin shaders to an embedded mtllib to avoid the overhead > of compiling them at startup. > > Bug: chromium:1385510 > Change-Id: I1c31ae0088babae01a9e42d63b3c2c30b65f4476 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4450126 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Quyen Le <lehoangquyen@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> Bug: angleproject:8152 Bug: chromium:1385510, chromium:1441754 Change-Id: I7f253f7aa14117b93d1e09ed61db0c4563fc9c3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4508064 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 1f672466 2023-05-02T16:13:13 Make export_targets faster Use temporary sets, then sort them is faster than sorting all the time. And a faster regex. ~1.5s faster presubmits on my machine. Bug: None Change-Id: Ieb4a9c35781ffba7ae0057086490489727b305ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4507977 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 7fd01d03 2023-04-19T00:54:24 Vulkan: Throttle the CPU without holding the global lock CPU throttling goes through CommandQueue and is thread-safe. Performing it in an unlocked tail call allows other unrelated EGL calls to go through. Bug: angleproject:8135 Change-Id: Idb3841be5d8ea8c4b76217f6707be26b28ea39c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4444027 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov fdb2dcb1 2023-05-02T14:24:20 Gather auto_script 'inputs' and 'outputs' in parallel Get rid of chdir which breaks parallel execution due to global state. Makes dirty verification faster. auto_script runs scripts with args which can be slow (as scripts have imports) On my machine, this speeds up verification from ~6s to ~1.3s Bug: None Change-Id: I78227cc80be54b0901029a286b0f017d36348a71 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4499820 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 2087fe01 2023-05-04T10:01:41 Roll vulkan-deps from 94976560d112 to 446f1da0d121 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/94976560d112..446f1da0d121 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/dfc97740ff..bc6b2bc17a * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/7f1d2f4158..268a061764 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a525dccbe8..2189ad7a5a * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/870a531486..bae9700cd9 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/71254bedee..ab6f4023be * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/631fde41b2..94f89255bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ibed0395d18f93a573519d2f90c6aca1e5f3253df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4505298 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0