kc3-lang/angle

Log

Author Commit Date CI Message
Lubosz Sarnecki d98f4812 2022-02-17T15:22:22 FrameCapture: Capture empty buffer generation. This avoids emitting VertexAttribPointer with non-null offsets when the array buffer is empty and a vertex array is bound in MEC. When no buffer is bound, which was also the case if the buffer was empty, non-null offsets are not allowed in VertexAttribPointer and will result in: "Client data cannot be used with a non-default vertex array object." Add EmptyArrayBuffer test to VertexAttributeTestES3. Test: angle_end2end_tests --gtest_filter="VertexAttributeTestES3.EmptyArrayBuffer/*" Bug: angleproject:7026 Change-Id: I0cb02a5588f5d2bbc85f58b75fd14493b644d52b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3468524 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 7a4fd421 2022-02-18T07:01:09 Roll Chromium from d984ec3b132a to 6594a8d1e6cf (1749 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d984ec3b132a..6594a8d1e6cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/47f630a2c5..2fb44025ab * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/169eef5b95..93c15529c3 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/1e0047c09e..7539622043 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e5e34cbf4b..aa5552f516 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/00852ba1c5..4c73a7ae74 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..91986b1fdb * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d6a3040bfd..988c0af5be * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/901a5d97c2..31e5ad1c42 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0a9dd7740c..3730026620 * tools/luci-go: git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa..git_revision:582e828c5a8aaf5cdd0ad1d5465fb9092b71eab8 * tools/luci-go: git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa..git_revision:582e828c5a8aaf5cdd0ad1d5465fb9092b71eab8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/25c9dfaa86..69635b2a1b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/715f5e95c1..16a46ce6d2 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/0e5920bffa..5045db5098 Clang version changed llvmorg-15-init-1464-gbf7f8d6f:llvmorg-15-init-1995-g5bec1ea7 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/0a9dd7740c61dddd0144cf2a17e06f2cfb3b9265..3730026620f6de2d26c2ad3f35e21e6982101e5d/scripts/update.py Bug: angleproject:6430 Tbr: cnorthrop@google.com Change-Id: I034db73ada1f0e525d49a42aaf9314bf82fe7ec8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3472702 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b1bdce5f 2022-02-17T23:14:29 Roll VK-GL-CTS from 834c2e16ae1c to d321c7ec84de (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/834c2e16ae1c..d321c7ec84de 2022-02-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/github-main into vk-gl-cts/main 2022-02-17 d.evans@samsung.com Fix waived tests being able to crash suite 2022-02-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main 2022-02-17 rgarcia@igalia.com Test more depth/stencil formats in load_store_op_none tests 2022-02-17 rgarcia@igalia.com Check dynamic viewports with depth clip control 2022-02-17 juha.heiskanen@siru.fi Add tests for zero initialize workgroup memory 2022-02-17 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,cnorthrop@google.com Change-Id: I86e633450bbdf03d81e42385197b30b6a0f27e4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3472692 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao f996d4d8 2022-02-16T09:27:04 Vulkan: Fix DynamicBuffer cache reuse. There is a regression bug that the DynamicBuffer's BufferHelper's size is no longer the size of entire buffer block's size, but the size of suballocation. This caused buffer reuse logic to screw up since it relies on the size to make the decision to keep or free the mFreeBufferList. This CL fixes this bug by using the buffer block's size. This CL also removes DynamicBufferPolicy since it is not used any more since most of DynamicBuffer usages that triggered that DynamicBufferPolicy implementation have been switched to BufferPool. The remaining DynamicBuffer usage is only for attributes and uniforms which are generally small and per context. Bug: angleproject:6980 Change-Id: I9e013cbd67dd74f5e7fc5bb7d9c9696bd1f69965 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469714 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 8dc9e83e 2022-02-16T21:48:53 Translator: Fix RunAtTheEndOfShader w.r.t discard RunAtTheEndOfShader wrapped main() if it ended in discard. However, it didn't account for the fact that the discard instruction could be wrapped in a block. This change makes RunAtTheEndOfShader more conservative w.r.t discard and has it wrap main() on any encounter of discard. The change additionally adds AST validation to ensure transformations don't generate dead code after branches. Test credit to Cody Northrop. Test: GLSLTest_ES3.ConstantConditionGuardingDiscard Test: GLSLTest_ES3.NestedUnconditionalDiscards Bug: angleproject:7033 Change-Id: Ie9d5210a5cfbb13449720a8a3f44666df9443d98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3471014 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki 00169174 2022-02-17T14:11:01 gl.xml: Remove GL_BLEND_EQUATION_EXT from GetPName. When retrieving the GL_BLEND_EQUATION enum using glGet, FrameCapture incorrectly emitted GL_BLEND_EQUATION_EXT, which is not part of core GL4, GLES 2+3. Add BlendEquationGetInteger test to SimpleOperationTest which failed to compile in the capture/replay tests before this change. Bug: angleproject:7026 Test: angle_end2end_tests --gtest_filter="SimpleOperationTest.BlendEquationGetInteger/*" Change-Id: I886e64ca316754f05ada8e45604bd3aef58a5ba5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3468522 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Jamie Madill 8ade4c2f 2022-02-16T13:14:54 Vulkan: Add overlay and stats for descriptor set caches. This adds more overlay widgets for different metrics of descriptor sets, including for uniforms and for all sets. Bug: angleproject:6776 Change-Id: If1a053bd711454227e7ccbdb01202a712a5f9787 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469228 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 671fcf73 2022-02-16T14:22:38 Vulkan: Add a feature to retain SPIR-V debug info Add a feature to retain debug info in SPIR-V blob. It is enabled when validation layers are enabled. Bug: angleproject:5901 Change-Id: Iccdff31ae0f12fc95d59d20e43e94b6f3d1ae00e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850388 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Jamie Madill 1315bc81 2022-02-09T11:25:58 Vulkan: Refactor DynamicBuffer::allocate. Reduces duplicate code by re-using allocateFromCurrentBuffer. Bug: angleproject:6980 Change-Id: I3f1126a53136be8f68a3a79008dd9adae45c86b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3449279 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 8d966f7d 2022-02-08T11:05:09 Vulkan: Simplify SubAllocation data types. We no longer need to bootstrap on the wrapper classes because we use a separate garbage list. This simplifies the code for the allocation tracking considerably. Also we remove a few mutable accessor to fortify our OOP design. (Credit to Jamie since it is splited from his CL) Bug: angleproject:6980 Change-Id: I2025ec4d141531273e824bb586957a38efc30be1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469715 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 57b8b933 2022-02-17T10:01:41 Roll vulkan-deps from 9fb91023eb58 to 4d9fe6bf1f0c (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9fb91023eb58..4d9fe6bf1f0c Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/90d4bd05cd..d15deba1d8 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/131278458e..188dc8b13c * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/edb793cf31..a32af9ca72 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0b8873487d..efcb50f63a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I5e197c9eb4e8258e8e398888eeaf8d89cb316e4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469732 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu ae9c94f1 2022-02-05T01:47:09 Add instructions to build RenderDoc for Android on Windows Add instructions on how to 1. Install Android dependencies on Windows 2. Install build tools on Windows 3. Build errors and resolutions 4. Steps to build and use RenderDoc for Android on Windows Bug: b/210134963 Change-Id: I707ddf68f5f834fcacd106fd0e3041b8757ae05c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3441634 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 38723c28 2022-02-15T16:29:36 Vulkan: Allocate space for default attrib only if it is enabled When context's default attributes is dirty, we allocate space for the default attribute, regardless it is enabled or not. Then we call into VertexArrayVk::updateDefaultAttrib() which only update its state if the attribute is enabled. This causes a use-after-free scenario that if it is disabled, the vertex array may have a pointer to the buffer that is now becomes inflight which may gets deleted when DynamicBuffer code think the size no longer matches etc. Bug: chromium:1296467 Change-Id: Ib9ec8e60ebdb326f9bbfb215b3711c37631fce4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3466776 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Kenneth Russell ad462491 2022-02-16T13:36:21 Refine suppression for GLSLTest.SwizzledChainedAssignIncrement. On NVIDIA, skip only on OpenGL and GLES, not Vulkan. Bug: angleproject:7029 Change-Id: I2ec2732a94d3952a147df8616fd248876f12172c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469723 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 8cb58667 2022-02-16T13:47:22 Vulkan: Add uniform descriptor set caching test. This covers the case where we'd continually miss the cache due to buffer size mismatches. Bug: angleproject:6980 Change-Id: Ia58871f431b6241af52fa0c37ab51952bc1c4f97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469227 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Kyle Piddington bfbe8661 2022-02-15T16:52:07 Fix UpdateChromeANGLE on mac for debug angle Update script to copy libABSL, libC++ and google_zLIB optionally Add in check before removing nonexistant files Tested by running script after building ANGLE Bug: angleproject:1944 Change-Id: I532d055b7fc70f58ebd807e7e203e4fa6a86be0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3466777 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi a0d558f0 2022-02-16T12:23:29 Vulkan: Fix D/S invalidation for MSAA EGL configs Bug: angleproject:7007 Change-Id: I165ce16e8fdd388ae13aa2e3d05901199706ee24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469221 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 3b891062 2022-02-16T11:38:31 Roll Chromium DEPS manually. Includes a fix for the removed Gold service account mixin. Also upgrades roll_chromium_deps to Python 3. Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/021b19e04d..47f630a2c5 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/01efcb5d51..738dc100c6 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/b323ac8f4c..1e0047c09e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2062399745..e5e34cbf4b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/47dfacfcce..ad002f6051 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/86630a4fe3..00852ba1c5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6fbe58035d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f72361d313..d6a3040bfd * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4e87a80d55..901a5d97c2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ad74e59c0f..0a9dd7740c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/aa8103bd9b..25c9dfaa86 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6d4e79909d..715f5e95c1 No update to Clang. Bug: angleproject:5707 Change-Id: I781dc018443fab6bbde1351c6c0ab426338be4d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469215 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill fb6303a1 2022-02-15T10:50:27 Update docs for checkout with 'fetch' tool. Bug: angleproject:7018 Change-Id: I3e7e905ce536353bb07e260302bfba07d4a4a619 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3465504 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll afacf7f9 2022-02-16T10:01:42 Roll vulkan-deps from 956ca5369840 to 9fb91023eb58 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/956ca5369840..9fb91023eb58 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/471428a04f..d18d0d92e5 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5e96fd5450..edb793cf31 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ca162081a7..0b8873487d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I54387fa7687d2a1c421a054c7316c9dda5a08554 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3464511 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 2893effa 2022-02-10T14:28:32 validationESEXT: Implement ValidateGetCompressedTexImageANGLE. Add CompressedTexImageNegativeAPI test. Bug: angleproject:6177 Test: angle_end2end_tests --gtest_filter="GetImageTest.CompressedTexImageNegativeAPI*" Change-Id: Ia7ed503a7a98f10e4b02deb3954f367f842da3fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452112 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Lubosz Sarnecki b1075951 2022-02-09T17:35:56 vk_helpers: Adjust CopyImageToBuffer extent to block size. When using readPixels with compressed formats, the VkBufferImageCopy bufferRowLength and bufferImageHeight need to be a multiple of the block size. This prevents the following Vk validation errors: VUID-vkCmdCopyImageToBuffer-bufferRowLength-00203 VUID-vkCmdCopyImageToBuffer-bufferImageHeight-00204 Add tests with texture sizes that are not multiple of block size. Test: angle_end2end_tests --gtest_filter="GetImageTest.CompressedTexImageNotBlockMultiple*" Test: angle_end2end_tests --gtest_filter="GetImageTest.CompressedTexImageCubeMap*" Test: angle_end2end_tests --gtest_filter="GetImageTestES32.CompressedTexImageCubeMapArray*" Bug: angleproject:6177 Change-Id: I34c788efece285753857500801e88abeaa6a8a78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452111 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll d77f64b3 2022-02-16T10:01:11 Roll SwiftShader from 5f1c00bda1c1 to 13f7365e81be (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/5f1c00bda1c1..13f7365e81be 2022-02-16 capn@google.com Skip testing subnormals when flushed to zero 2022-02-16 capn@google.com Benchmark the effect of flush-to-zero / denormals-are-zero 2022-02-15 capn@google.com Don't treat all warnings as errors in tests and benchmarks 2022-02-15 swiftshader.regress@gmail.com Regres: Update test lists @ 5f1c00bd 2022-02-15 capn@google.com Don't silently ignore unsupported extension structures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I3615b55bb8905f7fdf6407e99b252ef2535c7050 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3467757 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki bdedf146 2022-01-14T13:35:30 TextureVk: Implement getCompressedTexImage. Extend ImageHelper::readPixels to support compressed formats. Implement readPixelsForCompressedGetImage. Add compression tests to GetImageTest. Implement CaptureGetCompressedTexImageANGLE_pixels in capture_gles_ext_params. Test: angle_end2end_tests --gtest_filter="GetImageTest*.CompressedTexImage*" Bug: angleproject:6177 Change-Id: I6e5b6d746b9c6cc9b885fa44f75a985660d8fb58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452110 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Shahbaz Youssefi 5f3f13f6 2022-02-15T13:39:57 Vulkan: Invalidate D/S for multisampled EGL configs too Regardless of whether the EGL config is MSAA, depth/stencil should be invalidated at the end of the last render pass. Originally, optimizeRenderPassForPresent was gated on !MSAA because it was only affecting the layout of the color attachment. Bug: angleproject:7007 Change-Id: I7cd5497a9da6eeb168c3b55b91f2ff6f5674adb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3465498 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kyle Piddington eeddb050 2022-01-27T11:36:10 Metal: Incorrect parenthization for assignment expressions Fix for Webgl tests conformance/ogles/GL/build/build_017_to_024.html Create intermediate values for assign-equals operations, as they cause issues on expansion later. Bug: angleproject:6489 Change-Id: I7fea162bd1f59c7c765868af739d6ddfc1c1747f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3421527 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Gregg Tavares ed39d49a 2022-02-14T11:32:12 Metal: Fix Hang in WebGL CTS Occlusionquery_strict test If a query was just in progress and then we switch contexts a command buffer, which has already been enqueued, is not committed. Later, other command buffers are enqueued and committed and Metal hangs, waiting on the uncommitted but previously enqueued command buffer. The solution was to not enqueue a command buffer early but instead, enqueue just before committing. Bug: angleproject:6752 Change-Id: I62c07ca3d1ed98cc5b27c8c4af405fdedff922b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3461419 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Steven Noonan 760253ce 2022-01-27T07:24:27 Vulkan: replace uniforms FastIntegerMap with FastUnorderedMap This is in preparation for removing FastIntegerSet and FastIntegerMap. Bug: angleproject:6954 Change-Id: Ifa0a5c5ca39c705a9f774558bb6cad72ed8f0bc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3420952 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 93186337 2022-02-14T11:15:04 Vulkan: Check Serial is valid in SyncHelperNativeFence The change 6d94471bc70 incorrectly checked for validity of mUse in the clientWait and getStatus methods. mUse is valid once the constructor is complete, instead check for validity of the serial. Bug: angleproject:2517 Test: EGLSyncTest.AndroidNativeFence_* Change-Id: Id71eddc4ecf27cea487be56cb362afd68db1fd65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3465455 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Cody Northrop 904a4797 2022-02-15T10:58:07 Python3 upgrades Required to run run_code_generation.py on gLinux. Bug: angleproject:5707 Change-Id: Ifb416be6f89eb67faf43e7de66c6f9a92a5eb5e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3465514 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll c590a1aa 2022-02-15T16:58:29 Roll VK-GL-CTS from 2d1377ec02b5 to 834c2e16ae1c (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2d1377ec02b5..834c2e16ae1c 2022-02-15 quic_mnetsch@quicinc.com Merge pull request #305 from akihikodaki/do-not-directly-use-openglcts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,cnorthrop@google.com Change-Id: Ie680635cbff87ab878e804ed8e64d2c435367333 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3464456 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Sean Risser 3adace15 2022-01-10T22:53:19 Don't expose detailed driver version info to webGL WebGL's GL_RENDERER string now only includes basic version information on all backends. This is controlled through a bool passed through getBackendVersionString. Bug: angleproject:6777 Change-Id: Ie4e3d91d22c96f175a8139fac1c66e985ed9e1b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3380263 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Sean Risser <srisser@google.com>
Sergiy Belozorov 255fec89 2022-02-10T17:57:05 Remove reference to policy_testserver.py The file has been removed in https://crrev.com/c/3452227. Bug: chromium:1270314 Change-Id: I8c0a00540cd820f852364ad3f8b17ccdb3711225 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452114 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop e2f8ff32 2022-02-14T15:55:04 Tests: Add State of Survival trace Test: angle_perftests --gtest_filter="*state_of_survival*" Bug: angleproject:7020 Change-Id: I3e09fa1aaffbd647c4e99316f21db984bbebb2f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3462802 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Vadim Shtayura a5badc3e 2022-02-09T11:39:36 [infra] Update active lucicfg experiments. Remove retired noop experiments and add the one needed for the ongoing luci-scheduler.cfg format migration. R: jmadill@chromium.org Bug: chromium:1182002 Change-Id: I759e03f8fd189682c282af0b8a0b108815b46329 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3449242 Auto-Submit: Vadim Shtayura <vadimsh@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya cf4b50c5 2022-02-14T14:12:13 Vulkan: Retain images before changeLayoutAndQueue This change d9882db5f694c1c added retain calls for images in some places. Such retains are needed for textures and renderbuffers as well. Bug: angleproject:4628 Change-Id: I6b08033870f82851cc62a123bfd9c780812f17b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3462801 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 3b8b1f70 2022-02-15T12:59:11 Roll SwiftShader from cbd31d271e4c to 5f1c00bda1c1 (12 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/cbd31d271e4c..5f1c00bda1c1 2022-02-14 natsu@google.com Fix `WARNING: UNSUPPORTED:` warnings for having external format in sampler 2022-02-14 penghuang@chromium.org Win32SurfaceKHR: use StretchDIBits to replace StrectchBlt. 2022-02-11 dvet@google.com Add a SPIR-V profiling and reporting framework. 2022-02-11 capn@google.com Don't build PowerVR samples by default 2022-02-11 swiftshader.regress@gmail.com Regres: Update test lists @ 0863290d 2022-02-10 sugoi@google.com Add partial support of VK_EXT_extended_dynamic_state2 2022-02-10 sugoi@google.com Support VK_EXT_texel_buffer_alignment promoted features 2022-02-10 capn@google.com Fix shuffling of vectors with a different size mask 2022-02-10 sugoi@google.com VK_EXT_extended_dynamic_state support 2022-02-10 capn@google.com Remove unused sin/cos approximations 2022-02-10 capn@google.com Optimize SPIR-V sin and cos operations 2022-02-10 swiftshader.regress@gmail.com Regres: Update test lists @ cbd31d27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I912bcc3f3e36a026785eda03c7c587535d8eab56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3463540 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f3b6af59 2022-02-15T10:01:43 Roll vulkan-deps from 3a6f074dbd38 to 956ca5369840 (55 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3a6f074dbd38..956ca5369840 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/16e3b403aa..90d4bd05cd * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/1a36968e5d..131278458e * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/b42ba6d92f..6a55fade62 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7fa9e746ef..471428a04f * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/1dace16d80..b32da5329b * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/cdebcc4ee0..5e96fd5450 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/bb32aa13d4..5f9e5f14e5 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/54c295b067..ca162081a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iad11c36fc56beaac2d18d11bbf4782328090ee88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3460010 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ad4fae64 2022-02-15T07:02:09 Roll Chromium from c9825531290b to d984ec3b132a (580 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c9825531290b..d984ec3b132a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/33861deb09..021b19e04d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9a29c97787..01efcb5d51 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/de0d4ad6ba..2062399745 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/20f7561cb6..86630a4fe3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7bede422a7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/54e30e7043..f72361d313 * third_party/turbine: ZweGxnankyMPNqORbYcApzrOXpyg-9XcK7_-qdjELlcC..VhmfIPuSDHHeilnA7WC0MhR9ShZNF25tA0Te4RYIZG8C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d8f49e6ae1..4e87a80d55 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2e7608b9ab..ad74e59c0f * tools/luci-go: git_revision:fbbb5b9748a05dd16fe621f7ea48a4ece1913874..git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa * tools/luci-go: git_revision:fbbb5b9748a05dd16fe621f7ea48a4ece1913874..git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/361fc1446d..aa8103bd9b * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/7d12c5dcdd..4d131c20da * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/57f7ff80ea..6d4e79909d Clang version changed llvmorg-14-init-18258-g9477a308:llvmorg-15-init-1464-gbf7f8d6f Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/2e7608b9ab35f90d79eaddf645bef8503d2366b8..ad74e59c0f7604c85e55f144f09cf863927e6adb/scripts/update.py Bug: None Tbr: cnorthrop@google.com Change-Id: I45ec72e02e69a3486f10ed2d6d8d8b18e71e1e26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3460009 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu e5045587 2022-02-11T22:29:55 Debug Overlay Demo Add a new debug overlay to display texture descriptor set cache size Bug: angleproject:6976 Change-Id: I8bb2d88d4550947f1c6cbd732f936e3e060b1b04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3457356 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 527ceb73 2022-02-07T18:25:02 Vulkan: Switch XFB counter buffer to suballocation Bug: b/205337962 Change-Id: I2e26fa3ab150b858f07665459fa108440af988d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402333 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao a0bc9dab 2022-02-10T13:40:18 Vulkan: Switch stencilBlitResolveNoShaderExport to suballocation Bug: b/205337962 Change-Id: Ia7e2f80a9baadb68ec26d9e94af49dababf9bedb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3453310 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Andrew Naumov d36df8d7 2022-02-10T15:12:01 Unicode support for system_utils on Windows Failed to load ANGLE_GLESV2_LIBRARY_NAME via ansi WinAPI if path contains unicode, use wide version instead. Bug: chromium:1296105 Change-Id: Ifae18b2aba83f3ae84954cc4dd9afc0e2c58834c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452103 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cody Northrop 54d428dd 2022-02-10T20:25:51 Tests: Add MARVEL Strike Force trace Test: angle_perftests --gtest_filter="*marvel_strike_force*" Bug: angleproject:7005 Change-Id: Ife9c6f303651bc746953e0ecfc529a2c9ec0b0d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3457744 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 1e29ba62 2022-02-11T15:08:05 Vulkan: Enable overlay by default with debug layers Bug: angleproject:6976 Change-Id: I8fdd7546358fc1079525862cba0a4a6ff8357f78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3457346 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 19f40531 2022-02-11T11:17:22 Vulkan: Enable subgroup feature in GenerateMipmap.comp Enable subgroup feature to optimize shaders used for generating mipmaps. Remove definition of SPD_NO_WAVE_OPERATIONS to enable subgroups. Regenerate all internal shaders with target as vulkan 1.1 to enable subgroup feature. Bug: angleproject:7006 Change-Id: I36f50f3d27517fedb52e3028a8f6288347b1bfa0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3453288 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 2efbfd05 2022-02-14T16:08:34 Roll VK-GL-CTS from 071bfca11aa9 to 2d1377ec02b5 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/071bfca11aa9..2d1377ec02b5 2022-02-11 quic_mnetsch@quicinc.com Merge vk-gl-cts/github-main into vk-gl-cts/main 2022-02-10 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/master 2022-02-10 juha.heiskanen@siru.fi Resolve multisample image tests with renderArea < attachment size 2022-02-10 siglesias@igalia.com Added tests to check vkGetPhysicalDeviceImageFormatProperties with VK_IMAGE_CREATE_EXTENDED_USAGE_BIT 2022-02-10 ilkka.saarelainen@siru.fi Remove duplicate makeComputePipeline definitions 2022-02-10 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-02-10 ari.suonpaa@siru.fi Add imageStore tests that write constant values 2022-02-10 siglesias@igalia.com Added vkCmdCopyQueryPoolResults() tests with count==1 and stride=0 2022-02-10 d.evans@samsung.com Update docs to use python3 executable where required 2022-02-10 pdaniell@nvidia.com Don't filter out some VK_NV extensions used in tests 2022-02-10 ari.suonpaa@siru.fi Fix rounding issues with texture generation shader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,cnorthrop@google.com Change-Id: I07f7c0fa03ceb786888a1f6406b9d6ddafce78fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3461273 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c6f5a5bb 2022-02-14T07:45:25 Roll Chromium from c0b2804cbd93 to c9825531290b (658 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c0b2804cbd93..c9825531290b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3408ba5737..33861deb09 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c69bde298d..9a29c97787 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/2b08f9958d..b323ac8f4c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3ff9ded263..de0d4ad6ba * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d6030bc070..20f7561cb6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..516c0b3d3e * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/dd9a1330e5..d8f49e6ae1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b9894ca3bc..2e7608b9ab * tools/luci-go: git_revision:462d0a9cdbe947cd652fcd0c54f64ebc712858a5..git_revision:fbbb5b9748a05dd16fe621f7ea48a4ece1913874 * tools/luci-go: git_revision:462d0a9cdbe947cd652fcd0c54f64ebc712858a5..git_revision:fbbb5b9748a05dd16fe621f7ea48a4ece1913874 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2497ef3703..57f7ff80ea * tools/skia_goldctl/linux: x5DuM_cFqeCFMlXDtBAVjbyWLSGKdFH2UEf-w1ZKrJAC..njGzzVyYPSA__3tShsGxsvh8k5kJfL9V0wvLthXSUV4C * tools/skia_goldctl/mac_amd64: D9f-ltgviMq1P9HlpfREM3YKpCL6XVLKFuBQw9qO7SIC..hO0OT7GrBan0deDL_pb0LFML9ueWrbdDtzCU-awv-8IC * tools/skia_goldctl/mac_arm64: XlO5MLseLPLIFzjP_ZqyzC_mL0jxKtTHw6hSvu2ZfqMC..iG5_8Fr1Z6-7hWUIaiAy_BdqEqZztiO1hsUkG8KD_csC * tools/skia_goldctl/win: rL1WCW55dVVbB31YPyHoH7cdor3y_GdjUbUiAGRpScgC..k8tTHDT2HQHQFD7TPjRrdMHGABN8YbxP1GXsJnmS9JIC No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I843aa2dec572ea4f58cb63204f17f51e1db681ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3461272 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brandon Schade 06edae72 2022-01-11T11:13:20 Vulkan: Allow duplicated block name in different shader interface In OpenGL ES 3.2 Shading Language specification(4.3.9), A block name is allowed to have different definitions in different shader interfaces within the same shader. Bug: angleproject:5557 Test: KHR-GLES32.core.tessellation_shader.single.max_patch_vertices Change-Id: I49f149cfd8f6f063fc5045aa154cc401d3e38cfb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3429684 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Cody Northrop 6cced91b 2022-02-08T10:24:11 FrameCapture: Remove destroyed contexts from share group If a GL Context is destroyed, remove it from the list of shared contexts tracked by FrameCapture. Before this CL, we would crash in runMidExecutionCapture when trying to iterate through contexts that were gone: INFO: checking for SetupCalls in context id: 1 INFO: checking for SetupCalls in context id: 2 INFO: checking for SetupCalls in context id: 1769237601 Test: Mortal Kombat MEC Bug: angleproject:6997 Change-Id: I3c2f6a77419d241af9a0b300936e7784446306f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3448681 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Charlie Lao f7f26956 2022-02-10T13:33:32 Vulkan: Fix two bugs exposed by moving mEmptyBuffer to suballocation There are two bugs exposed when I try to switch mEmptyBuffer to use suballocation. 1) BufferHelper::initializeNonZeroMemory() for device local memory uses GPU to do zero fill, but it is missing an vkEndCommandBuffer call. 2) glTexSubImage2D call try to pick glCopyuBufferToImage code path and we are not checking against pixel format. Vulkan spec requires offset must be number of pixel size and we are using "4" for pixel size which does not work for RGB format. Bug: b/205337962 Change-Id: Ibca6a60ebd6afc5e2bca07b9cc6a43ebdd240f15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3449348 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Jamie Madill 9b7a77b0 2022-02-11T11:34:19 Double batch timeout for sanitizer tests. It seems the batch was timing out in ASAN builds. Bug: angleproject:6965 Change-Id: I059e138e7fc43928fb25f905bf85fbb34becd500 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3456662 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 4b45576d 2022-02-10T23:51:54 Keep ANGLE_base_vertex_base_instance available for ES 2.0 Bug: chromium:1289771 Change-Id: Ic8cd2d366985deeb7c1566cfcf8b8dd0425ed615 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3453802 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi d285d6a7 2021-11-23T23:12:00 Vulkan: Use VK_EXT_depth_clip_control Bug: angleproject:6679 Change-Id: Iea3b7a2d8db630dcea19836732de8f9e0a7a568f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3298356 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Constantine Shablya 3f0a28ba 2022-02-11T16:18:37 Add entry points for EGL_KHR_partial_update Bug: angleproject:6960 Change-Id: If248b7ef5ebacd7dfb8c612e5a9106ba0060282e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3455787 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 3b4548bb 2022-02-02T15:19:06 Traces: Add restricted_trace_perf.py script for Android We've been using restricted_trace_perf.py to gather numbers on Android devices. The script uses angle_perftests and records: - Wall time per frame - GPU time per frame - CPU time per frame - GPU power per frame - CPU power per frame - GPU memory per frame It reports numbers to the terminal and creates a spreadsheet at the end. A typical command to run it would be: python3 restricted_trace_perf.py --fixedtime 10 --power \ --output-tag <tag> --loop-count 5 Power numbers are only available on Pixel 6 as we read directly from power rails. Also included is a gpumem shell script run on the Android device, and a power_denoising script that deactivates a number of services to reduce variance. The former is invoked automatically, the latter is only invoked by hand. Bug: angleproject:6970 Change-Id: I11fd346790565b5efcda228f43dc36dd41025642 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3432821 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev a3c785fc 2022-02-11T15:57:50 GL: Remove avoid_dxt1_srgb_texture_format feature The workaround was removed in https://crrev.com/c/2627425 Bug: angleproject:5543 Change-Id: Idf3d3c47b035e0cc505b5b54fcc3ab608d6838b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3455786 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Hyunchang Kim fd378ce5 2022-01-25T18:06:31 Rebind program on glUseProgramStages Rebinding program causes all uniform resetting. And uniform resetting is required not to use wrong uniform for changed program stages. Bug: angleproject:6946 Change-Id: Ic969aa8fec2ff6e16f46b96a61c6d876bf37ff2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3416791 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cheryl Wei 3a72994e 2022-01-26T13:18:14 Vulkan: Add an end2end test Add this test for re-producing http://anglebug.com/6926, currently it has been skipped,once the bug is fixed,will re-open this test. Bug: angleproject:6926 Change-Id: Idbd2b3b60bdbf2a4100e6f6c89353cbf09e5e36b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3412970 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki 0a320d16 2022-02-09T13:36:18 GetImageTest: Enable on Vulkan SwiftShader. Add SwiftShader ES2 and ES3 Vulkan targets to ANGLE_INSTANTIATE_TEST. Bug: angleproject:6177 Change-Id: Idc964202d8b02f38118b69bbef7984bf4d22e61b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452109 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 56872491 2022-02-11T07:52:27 Roll Chromium from bf99b2cc0f6b to c0b2804cbd93 (526 revisions) https://chromium.googlesource.com/chromium/src.git/+log/bf99b2cc0f6b..c0b2804cbd93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e2f3130fc3..3408ba5737 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/53a6cf1529..c69bde298d * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/107cd56799..2b08f9958d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2a55423c36..3ff9ded263 * third_party/android_build_tools/aapt2: 0yR8wK_fSMgdVKwnx4nRPi-amaLV7Kcr4Os6mg_DGI4C..yQIf5Ev_-q9u6Pr_a0APd1dHcImJSmotVADw4Pj151QC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8e8a9001da..d6030bc070 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7b5325d761 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c49a7334d3..54e30e7043 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/14f4303f3d..dd9a1330e5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c7ca87fb03..b9894ca3bc * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b30a18f2ee..361fc1446d * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/5b5485d9df..7d12c5dcdd * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/99b01d7d39..2497ef3703 Clang version changed llvmorg-14-init-17086-g38e16e1c:llvmorg-14-init-18258-g9477a308 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/c7ca87fb03218b752674ea837622c5eb4778ff0d..b9894ca3bc6596a03cb033ddbdd36990f11b8ce7/scripts/update.py Bug: None Tbr: ianelliott@google.com Change-Id: Ic7a58c399a9b2e8c978be80b4d611cfe5933fbcd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3455085 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao d5df2331 2022-02-10T11:55:17 Vulkan: Disable EGLContextSharingTestNoSyncTextureUploads on Pixel6 This test is causing other tests to crash on pixel 6. Disable it for now until we root cause it. Bug: angleproject:7004 Change-Id: I88c71b44cc2b56caf2aaf3a1d9741ccd8aca3725 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3452503 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 038adcae 2022-02-08T16:46:40 Vulkan: Render the overlay in the graphics pipeline Bug: angleproject:6976 Change-Id: I388d429f0726b4d6a1c4ecd446ead93579a14a1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3448643 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll b39add31 2022-02-10T20:00:09 Roll VK-GL-CTS from b594e2aabae9 to 071bfca11aa9 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b594e2aabae9..071bfca11aa9 2022-02-10 quic_mnetsch@quicinc.com Merge pull request #283 from imirkin/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,ianelliott@google.com Change-Id: Ica942319a92f51f86e3f133fe7e68bf9e3ed273b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3453445 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 419bca3f 2022-01-19T18:22:56 Vulkan: Use Vulkan API directly for BufferPool's buffer allocation There are two motivations in this CL. 1) There are two layers of suballocator right now. BufferPool provides first suballocation. It tries to allocate from one of the buffers in the pool. If that failed, it try to create a new BufferBlock (i.e, a VkBuffer). Right now that calls into VMA which creates another pool to allocate a buffer. We really only need one layer of suballocation. And 2) Because we uses VMA to do actual VkBuffer allocation, we have to use Allocator object. But VMA can not handle external buffers, so we end up having a BufferMemory class just to handle two different cases. This CL attempts to clean up this by let ANGLE calling into vulkan driver directly for the actual buffer allocation, just like we did for VkImages. By doing so, we able to remove BufferHelper::mMemory data member as well as BufferMemory class all together. External memory is now treated exactly the same at BufferHelper. Bug: b/205337962 Change-Id: I7c183ab0fd7d9aceb6cf416b0214c300798bc010 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402740 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Mohan Maiya 6fd2588d 2022-02-08T14:39:58 Update GL_MAX_CLIP_DISTANCES_EXT validation GL_MAX_CLIP_DISTANCES_EXT is a valid enum to query only if either "GL_APPLE_clip_distance" or "GL_EXT_clip_cull_distance" is supported. Account for the possibility that "GL_EXT_clip_cull_distance" is supported while "GL_APPLE_clip_distance" is not. Bug: angleproject:5458 Change-Id: Ia2a089e0e9e2587449553ead6318b9b35fde0648 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3448688 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Steven Noonan 734365a7 2022-01-27T06:05:56 Vulkan: improve command buffer reset performance When trying to profile why a game's framerate was decreasing over time, I found that memset() was taking the most self time out of any function in the process. The top two callers of memset() were: RenderPassCommandBufferHelper::reset OutsideRenderPassCommandBufferHelper::flushToPrimary Profiling specifically called out mUsedBuffers.clear() and mRenderPassUsedImages.clear() as being the worst offending lines. The problem is that FastIntegerSet (and by proxy, FastIntegerMap, where FastIntegerSet manages the keys) perform best when all keys are close to zero. With large key values (in this case, large image and buffer serials), significantly more memory gets allocated, causing mUsedBuffers.clear() and mRenderPassUsedImages.clear() during command buffer reset to take more and more time the longer the process runs. This change is essentially a partial revert of f9a062c9754. Bug: angleproject:6954 Change-Id: Id2542f6425f0845fe81d393ecf6b614b474c53c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3420925 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Xiaopeng Li 118ce6aa 2022-01-20T16:55:04 Support to open d3d12 shared handles For https://docs.microsoft.com/en-us/windows/win32/api/d3d12/nf-d3d12-id3d12device-createsharedhandle Bug: angleproject:6927 Change-Id: I0f0ce7bff37abfc278a167c6eec92eb3b6df1370 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3404060 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll a0e3a5fb 2022-02-10T10:01:53 Roll SwiftShader from 0915ab4bddf7 to cbd31d271e4c (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/0915ab4bddf7..cbd31d271e4c 2022-02-09 sugoi@google.com Dynamic state refactor 2022-02-09 sugoi@google.com VK_EXT_subgroup_size_control support 2022-02-09 capn@google.com Add compute benchmarks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I24bb93771c71b2aee92f1151da9ca242fe20025b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3450585 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov f63d5f1c 2022-02-09T21:32:18 Revert "Don't build dEQP tests on MSVC temporarily" This reverts commit d7b3c6d109f3b9cd6ba855343fc011c3e93c24f3. Reason for revert: VK-GL-CTS fix in https://github.com/KhronosGroup/VK-GL-CTS/commit/438d92079b85a9d2b32420f319e0ad1d7efacf17 Original change's description: > Don't build dEQP tests on MSVC temporarily > > dEQP fails compile on MSVC Due to build switching to C++17. > Temporarily stop building them while VK-GL-CTS is being fixed upstream. > > Bug: angleproject:6737 > Change-Id: I288aab95cb76104fde7635eafb37d56b4ed0a600 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308820 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:6737 Change-Id: Ic690e7379674fc1c929eb0213d521845df5a6636 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3450863 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4b6a5a84 2022-02-10T07:01:28 Roll Chromium from 60719c9cd084 to bf99b2cc0f6b (543 revisions) https://chromium.googlesource.com/chromium/src.git/+log/60719c9cd084..bf99b2cc0f6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a290966f62..e2f3130fc3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2a745cc87d..169eef5b95 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a18d792116..53a6cf1529 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/b86911d6e7..107cd56799 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0d797fdc60..2a55423c36 * third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/6a8f3a2781..872ba9e68a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9ffdb58347..47dfacfcce * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..954eec7434 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cc0f7a5170..c49a7334d3 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/1c4422cef7..299c223073 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/172367d1f3..14f4303f3d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/05b87ed168..b30a18f2ee * tools/md_browser: https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/b61dc90769..ac44704f23 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/919041bfbf..99b01d7d39 * tools/python: https://chromium.googlesource.com/chromium/src/tools/python/+log/a21ec45e2d..8cb897d698 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: If15e25edff1a5786f70d1c6704335c18ab37fede Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3451565 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 670a6e47 2022-02-09T09:18:33 Ignore invalid texture type error When EGL_KHR_create_context_no_error is enabled, silent return when an invalid texture type is passed in to glBindTexture and glTexParameteri. Bug: angleproject:6995 Test: ContextNoErrorTest.InvalidTextureType* Change-Id: I80034b18e7cb757bfa0e835f3aa15df7cd96775d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3447274 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Kyle Piddington 91f92540 2022-01-14T18:34:44 Metal: Fix multisample resolves. 1) Only use MTLLoadActionDontCare if store action was MTLStoreActionDontCare, ignoring MTLStoreActionMultisampleResolve. 2) For color, depth and stencil attachments, if they have implicit multisample textures, use MTLStoreActionStoreAndMultisampleResolve rather than MTLStoreActionStore. This addresses bugs when resolving a multisampled framebuffer and copying it to a texture, and fixes these two Three.js demos: https://threejs.org/examples/webgl_framebuffer_texture https://threejs.org/examples/webgl_decals Added CopyTextureTestES3.DrawThenCopyThenBlend modeled after new WebGL 2.0 conformance test in: https://github.com/KhronosGroup/WebGL/pull/3379 Confirmed to catch the bug. On Intel Macs, the Metal debug layers and load/store action validation must be enabled: MTL_DEBUG_LAYER=1 \ MTL_DEBUG_LAYER_VALIDATE_LOAD_ACTIONS=1 \ MTL_DEBUG_LAYER_VALIDATE_STORE_ACTIONS=1 \ MTL_DEBUG_LAYER_VALIDATE_UNRETAINED_RESOURCES=4 \ angle_end2end_tests ... Bug: angleproject:6972 Change-Id: I7bcb7c19e434e22e24b800fdce4c480d10b1fc40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3450033 Reviewed-by: Gregg Tavares <gman@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Charlie Lao 82352237 2022-02-08T12:01:38 Vulkan: Fix incorrect DescriptorSet's bufferInfo in XFB emulation path The mAlignmentOffsets are pre-calculated at TransformFeedbackVK::begin() time but never gets updated when buffer changes after XFB begin call, which causes us sending down incorrect bufferInfo to the descriptor set. This CL removes mAlignmentOffsets and always calculate the aligned offset when mBufferOffsets is needed. This CL also modify the existing test to demonstrate the bug. Test: SimpleStateChangeTestES3.RespecifyBufferAfterBeginTransformFeedbackInDeletedPaddingBuffer Bug: angleproject:6998 Change-Id: I11a9f114385d2e49ba9bdc2d820727c85c8244dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3448682 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll 37f59b85 2022-02-07T19:34:11 Roll VK-GL-CTS from 97ceb2222747 to b594e2aabae9 (64 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/97ceb2222747..b594e2aabae9 2022-02-05 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/master" 2022-02-04 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/master 2022-02-03 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/master 2022-01-29 ilkka.saarelainen@siru.fi Add depth and stencil multisample copy tests 2022-01-29 juha.heiskanen@siru.fi Add color output check to early fragment sample count tests 2022-01-29 juha.heiskanen@siru.fi Test dynamic descriptors with different stage visibility 2022-01-29 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-01-29 mika.vainola@siru.fi Remove EnableBlendCase from ES 3.1 2022-01-29 srisser@google.com Delay initializing fragment_shading_rate tests 2022-01-28 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master 2022-01-27 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/master 2022-01-23 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master 2022-01-18 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master" 2022-01-16 ari.suonpaa@siru.fi Add coverage for transition between compute and indirect draw 2022-01-14 emmanuel.tanguy@broadcom.com Add missing barrier to fix multi-core issue 2022-01-14 juha.heiskanen@siru.fi Test EarlyFragmentTests effect on color output and sample counting 2022-01-14 jari.komppa@siru.fi Add more power of two checks 2022-01-14 piotr.byszewski@mobica.com Update vulkan-docs version 2022-01-14 jari.komppa@siru.fi Add missing formats to mapTextureFormat 2022-01-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2022-01-13 ari.suonpaa@siru.fi Move draw buffers indexed tests from ES3.1 to ES3 group 2022-01-11 pdaniell@nvidia.com VK_EXT_pageable_device_local_memory test coverage 2022-01-10 piotr.byszewski@mobica.com Rename mustpass master branch to main 2022-01-10 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/dev/VK_EXT_image_view_min_lod into vk-gl-cts/master" 2022-01-10 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master 2022-01-07 corentin.noel@collabora.com gl4cMapBufferAlignmentTests: ensure that the GL_ARB_buffer_storage extension is present 2022-01-07 jari.komppa@siru.fi Update README.md files, replacing old link 2022-01-07 arkadiusz.sarwa@amd.com Add support for building with Visual Studio 2022 2022-01-07 juha.heiskanen@siru.fi Remove unused variables from occlusion query tests 2022-01-07 dneto@google.com Assert that isnan and isinf cases cover intended classes 2022-01-07 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-01-07 venni.ihanakangas@siru.fi Improve AHB image_formats subtest log output 2022-01-07 marcin.zajac@mobica.com OpPtrEqual OpPtrNotEqual for non-variable pointers 2022-01-07 piotr.byszewski@mobica.com Extend FSR multiview tests 2022-01-07 michal.jakubek@mobica.com Handle VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_* flags 2022-01-07 jari.komppa@siru.fi Add 8-bit blend_operation_advanced tests 2022-01-07 rgarcia@igalia.com Test constant and dynamically uniform subgroup shuffle deltas 2022-01-07 ilkka.saarelainen@siru.fi Rework platform memory limits 2022-01-07 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/master 2022-01-07 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2022-01-05 quic_mnetsch@quicinc.com Notice of withdrawal of Vulkan CTS 1.2.5.x 2021-12-11 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2021-12-11 rgarcia@igalia.com Fix dot product with saturation tests 2021-12-11 piotr.byszewski@mobica.com Add dynamic rendering to attachment rate tests 2021-12-11 rgarcia@igalia.com Further VK_NV_mesh_shader test variants and fixes 2021-12-11 pdaniell@nvidia.com Fix and enable dynamic rendering multivew coverage 2021-12-11 quic_mnetsch@quicinc.com Merge "Merge dev/VK_EXT_depth_clip_control into master" 2021-12-11 ari.suonpaa@siru.fi Fix integer overflow in Random::getInt() 2021-12-11 juha.heiskanen@siru.fi TRANSIENT_ATTACHMENT_BIT store/load op test 2021-12-11 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master 2021-12-10 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-12-06 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master 2021-12-03 ilkka.saarelainen@siru.fi Add missing feature check to MS copy tests 2021-12-03 jarcher@nvidia.com Update Android API and permissions for OpenGL 2021-12-03 antto.makinen@siru.fi Test no-op image layout transitions in VK_KHR_synchronization2 2021-12-03 antto.makinen@siru.fi Ensure that compute shaders have a subgroup size that is uniform in command scope 2021-12-03 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/dev/VK_ARM_rasterization_order_attachment_access into vk-gl-cts/master" 2021-12-03 juha.heiskanen@siru.fi Missing coverage for vkCmdCopyQueryPoolResults 2021-12-03 jari.komppa@siru.fi Add suite of div by zero tests 2021-12-03 ari.suonpaa@siru.fi Enable packed formats for border swizzle tests 2021-12-03 piotr.byszewski@mobica.com Add portability_subset to extensions_data.txt 2021-12-03 lionel.g.landwerlin@intel.com Verify that timeline semaphores cannot import/export SYNC_FD 2021-12-03 piotr.byszewski@mobica.com Execute FDM tests with dynamic rendering 2021-12-03 piotr.byszewski@mobica.com Execute FDM tests with legacy renderpass If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:6773, angleproject:6737, angleproject:4394 Change-Id: I5e8157787a821d116231640f89b67cde2cc2fce4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3442372 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Cody Northrop 02ce52d2 2022-02-08T20:41:01 Test: Add Lords Mobile trace Test: angle_perftests --gtest_filter="*lords_mobile*" Bug: angleproject:7000 Change-Id: I451433be5269c199ff404162df406b16ecee155b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3450029 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 33d17b7f 2022-01-17T10:29:28 Fix perf test runner script. For Python3, and a couple other tweaks. Bug: angleproject:5707 Change-Id: I64365bf9f7834c78dd8cded277a13c35811e0f9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3395812 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis 4349904b 2022-02-04T14:22:53 Add keying on backend to ANGLE Display caching. Webkit needs to use one ANGLE display with OpenGL and another with Metal. Our display caching is interfering with this, so it should be updated to also key on the selected backend. Bug: angleproject:6978 Change-Id: I9ec47a28e16646f5fc75956e3bd78236990cc392 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3440780 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Sergey Ulanov 9cfd8724 2022-02-09T08:23:02 Allow surface creation in DisplayVkNull Previously DisplayVkNull was returning unusable surface from createWindowSurfaceVk(). Updated it to return OffscreenSurfaceVk, which makes it usable with some tests that try to create surface through EGL Bug: chromium:1225002 Change-Id: If21a454201a32017b0e80ee7c01568a089ab0b0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3450034 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll a91d5603 2022-02-09T10:01:54 Roll SwiftShader from e576ca6011cd to 0915ab4bddf7 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/e576ca6011cd..0915ab4bddf7 2022-02-08 capn@google.com Fix validation layer error for ClearImage benchmarks 2022-02-08 capn@google.com Fix non-x86 build of LLVM Reactor 2022-02-08 kramerb@google.com Avoid deprecated llvm::IRBuilder::CreateShuffleVector overload 2022-02-08 capn@google.com Unroll transcendentals benchmarks by 10x 2022-02-08 swiftshader.regress@gmail.com Regres: Update test lists @ e576ca60 2022-02-08 capn@google.com Remove Vulkan structure enum to integer casts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:3430 Tbr: ianelliott@google.com Change-Id: I32d9d320e0a40da770ea7b29da91199bb61f94bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3448151 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4716e0fe 2022-02-09T07:00:31 Roll Chromium from 817a527fde8c to 60719c9cd084 (571 revisions) https://chromium.googlesource.com/chromium/src.git/+log/817a527fde8c..60719c9cd084 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bcaab68639..a290966f62 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/77c52e2f68..a18d792116 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/67a0c97ff4..0d797fdc60 * third_party/android_sdk/public: Ez2NWws2SJYCF6qw2O-mSCqK6424l3ZdSTpppLyVR_cC..PGPmqJtSIQ84If155ba7iTU846h5WJ-bL5d_OoUWEWYC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..25f38be662 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1b93e14c92..cc0f7a5170 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/3fc79233fe..172367d1f3 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/94a76bd470..c7ca87fb03 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6e1210b239..919041bfbf No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ic28446f280d1f89cf3fd697e06107938b2b10572 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3450032 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 71d06198 2022-02-07T11:16:41 Vulkan: Fix vkCmdClearAttachments vs multiview Bug: angleproject:6262 Change-Id: I5a24693bb1b35201213c2e3fa25f7864609357b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3442255 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 1b9774f5 2022-01-26T13:37:03 Vulkan: Force submit updates to immutable textures Submit immutable texture updates recorded in outside renderpass commands when the following conditions are met - 1. "forceSubmitImmutableTextureUpdates" feature is enabled 2. The texture is immutable This works around a problem that manifests in some applications that do not perform appropriate synchronization of shared contexts. Bug: angleproject:6929 Test: EGLContextSharingTestNoSyncTextureUploads.* Change-Id: I2a237046e2cc53650eb8dc07e3697f7481df9b02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3418138 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Jamie Madill a3961843 2022-02-04T08:45:34 Vulkan: Bind aligned default uniform buffer size. This makes us let reuse caches more often when uniforms change size slightly. It also simplifies the cache key management. Bug: angleproject:6776 Change-Id: I68ab48ab7761237bb9d28c4a4a88f4fc6e2c5af6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3439068 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6207fe88 2022-02-03T14:11:30 Vulkan: Minor cleanup to DynamicDescriptorPool. In preparation for future changes. Bug: angleproject:6776 Change-Id: I0a2ab004883ad482f4ed19075c5f5f4e9c451ae0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3437413 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 5b43a30e 2022-02-08T13:15:45 Overlay: Rearrange the font image Each glyph is now placed in a separate layer, and the image is made mipped. This is to prepare for FS-based rendering of the overlay and provide more flexible sizing of the font. Bug: angleproject:6976 Change-Id: Iefe139d1801c22ce303e445f5759f9b25597cdce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3448710 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 70c510eb 2022-02-03T07:54:29 Vulkan: Use common storage for descriptor set descs. This lets us avoid using templates when implementing descriptor set caches. As an added bonus, the key size now scales with the number of active items in the cache. In the case of using a smaller set of active textures, our keys now use sizeof(uint32_t) * (kFastBufferWordLimit) + sizeof(void *) bytes of storage (132/136) instead of sizeof(uint32_t) * 3 * 96 bytes (1152) per set. This reduction should improve cache coherency. Bug: angleproject:6776 Change-Id: I904fc5527ff033af927e25abe6d13d98142e3f14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3436767 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 50fb842d 2022-02-08T12:52:09 Expand SwiftShader Win/ASAN suppression. Bug: angleproject:6965 Change-Id: I00021add3d22f1c64610355e4a6dc73c6c0471e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3447565 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Charlie Lao 52045876 2022-02-07T15:08:15 Vulkan: StreamVertexDataWithDivisor write beyond buffer boundary StreamVertexDataWithDivisor() function is advancing dst with dstStride, but then later on it is treating dst as if it never advanced, thus result in write out of buffer boundary. This was hidden by VMA's memory suballocation, which means it may result in some rendering artifacts. Bug: angleproject:6990 Change-Id: Ic91e917cedd247dfe85b12a69ae26b21b7a4e67a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3445528 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Greg Thompson d635feb1 2022-02-08T11:49:21 [fuchsia] Tests using additional_manifest_fragments are CFv1. These tests will be migrated to CFv2 as their fragments (and their respective required capabilities) are migrated to CFv2. Bug: chromium:1256502 Change-Id: I9ae42c35da005fe174cb0cebec925995f4fa7026 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3447540 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 8622810c 2022-02-08T10:01:52 Roll SwiftShader from ad6d7f84f2a1 to e576ca6011cd (19 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/ad6d7f84f2a1..e576ca6011cd 2022-02-08 natsu@google.com Fix `WARNING: UNSUPPORTED:` warnings related to Android swapchain 2022-02-08 natsu@google.com Fix `WARNING: UNSUPPORTED: ... EXTERNAL_FORMAT_ANDROID` warnings 2022-02-07 capn@google.com Benchmark optimized SPIR-V transcendental instructions 2022-02-07 capn@google.com Copy Reactor transcendentals benchmarks to new PipelineBenchmarks 2022-02-07 capn@google.com Test building benchmarks with Kokoro 2022-02-07 swiftshader.regress@gmail.com Regres: Update test lists @ 45f7fdc3 2022-02-07 capn@google.com Ignore VK_STRUCTURE_TYPE_IMAGE_VIEW_MIN_LOD_CREATE_INFO_EXT usage 2022-02-07 capn@google.com Eliminate EmulatedIntrinsics 2022-02-07 capn@google.com Remove OptimalIntrinsics source and header 2022-02-07 capn@google.com Eliminate rr::Precision 2022-02-07 capn@google.com Use full-precision transcendental function implementations in Reactor 2022-02-07 capn@google.com Update dEQP-VK and Cherry usage documentation 2022-02-07 capn@google.com Use ShaderCore functions to implement GLSL.std.450 transcendentals 2022-02-07 capn@google.com Copy optimized transcendental intrinsics to ShaderCore 2022-02-07 dvet@google.com Add an option to control where ASM listings are dumped. 2022-02-07 capn@google.com Make the Reactor build target an alias 2022-02-07 swiftshader.regress@gmail.com Regres: Update test lists @ ad6d7f84 2022-02-07 capn@google.com Regres: Adjust mustpass folder for Vulkan 1.3 2022-02-07 nicolascapens@google.com Revert "Regres: Apply lazy initialization patch" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ic34cd1a9de7db23699118d53ad2ca027f214e837 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3445206 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d066f9a3 2022-02-08T07:00:07 Roll Chromium from 26dacbf4b527 to 817a527fde8c (500 revisions) https://chromium.googlesource.com/chromium/src.git/+log/26dacbf4b527..817a527fde8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f85248b050..bcaab68639 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/5b0a8cf88e..77c52e2f68 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/f2ef96ecb8..b86911d6e7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/122e089027..67a0c97ff4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..25f38be662 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a6ea731ab2..1b93e14c92 * third_party/r8: tamyW0-567_CaEZt2m7Pwy2NSUKeocbxdkoGsf-z3F0C..cEv1yyfxfmP_MaZrG22cR7YPc7hehgHAZd82lRx0DFAC * third_party/turbine: g7lRRNWdEQAksTvScmHd-o0PUx4ts7kioIdeDtQ-ifMC..ZweGxnankyMPNqORbYcApzrOXpyg-9XcK7_-qdjELlcC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a8ca822230..94a76bd470 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/40222e9dab..05b87ed168 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/eb37312a1e..6e1210b239 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Id1fde2f9164e3622d125fe0ef15a7bae7c52ff57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3445539 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 2df2a9ec 2022-02-05T00:16:54 Add instructions to enable Debug Overlay On Android Add notes on how to set debug overlay environment variables on Android build. Bug: angleproject:6806 Change-Id: I129080cf5671b19890cdb05dadc72a46f06aa816 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3441082 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 236a3d0f 2022-02-06T16:09:24 Tests: Add Dead Trigger 2 trace Test: angle_perftests --gtest_filter="*dead_trigger_2*" Bug: angleproject:5823 Bug: angleproject:6986 Change-Id: I259cfb2f9c9d2d0f14af315c0e02fcd42d24cb8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3442757 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 1acfe659 2022-02-06T21:18:44 Test: Add Last Shelter: Survival trace Test: angle_perftests --gtest_filter="*last_shelter_survival*" Bug: angleproject:6987 Change-Id: Ia565a0b75aff74fc9cd136763a7063890072225c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3442766 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 8b81742d 2022-02-03T07:41:16 Vulkan: Move shader resources descriptor set update. This is in preparation for adding shader serial information to the desc, to work around a bug with incorrect descriptor set cache hits. It could have some perf impact if we restart command buffers constantly while using UBOs/SSBOs. Bug: angleproject:6776 Change-Id: I24f5cefd329a1c36f7f60cb2a520cfdf5f127051 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3436765 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 02ad19e3 2022-02-07T13:46:46 Vulkan: Fix vkCmdResolveImage offsets glBlitFramebuffer takes identical regions for src and dst when resolving. vkCmdResolveImage should use the clipped area instead of using the actual offsets passed to this function. Bug: chromium:1292537 Change-Id: I13b91a4e14bdb3fcbf8f01edb36d7fb4110429ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3444340 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d9fcebb8 2022-02-07T14:11:58 Vulkan: Make framebuffer fetch syncval errors more specific The errors are very generic, so now they are only suppressed if framebuffer fetch is used by the application. This change partially relands 2eeb87488. Bug: angleproject:6951 Change-Id: I55f444d19360d3066f1d4b0959d25e676dbb1a38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3444341 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 939da294 2022-02-05T17:12:31 Tests: Add Magic Rush: Heroes trace Test: angle_perftests --gtest_filter="*magic_rush_heroes*" Bug: angleproject:6985 Change-Id: I29ea1746202345cb09d994336ad4c01719bae70e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3440686 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Ian Elliott 9208dcc6 2022-02-07T18:23:12 Revert "Vulkan: Enable framebuffer fetch on SwiftShader" This reverts commit 2eeb8748867c529474200d302f21f20ab461b9b4. Reason for revert: Breaks tests for ANGLE-to-Chromium autoroller Original change's description: > Vulkan: Enable framebuffer fetch on SwiftShader > > Bug: angleproject:6951 > Change-Id: I10eeb58be9e8639c0519fc47f327a0894155b755 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3437409 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:6951 Change-Id: I35eaf2b7411d1bf055484bbb32f7e681286edd42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3442370 Reviewed-by: Ian Elliott <ianelliott@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
kmx.io     mail     discord kmxgit v0.4.0