Log

Author Commit Date CI Message
Manh Nguyen db88baa8 2020-07-23T11:12:46 Serializes GL context states and reformats frame_capture_utils Adds the ability to serialize GL context states. Adds serialization of GL context states to serializeContext method so that capture replay regression testing now compares the GL context states. Reformats frame_capture_utils to make most serialization methods private, except for the ones called by other classes and template methods. Bug: angleproject:4817 Change-Id: I2d53c88be3d503268bd6e2e5058b5fabe0644f67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314829 Commit-Queue: Manh Nguyen <nguyenmh@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 52d25633 2020-07-27T17:37:46 Disable GPU time tracking in trace tests. Adds considerable overhead to wall time on Adreno. Not tested on other platforms. Bug: angleproject:4879 Change-Id: Ib219f14162fb5768e484f717ed2a870478bd1c86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321404 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Charlie Lao afdea864 2020-07-20T17:03:31 Vulkan: Add cache for driver uniform descriptor set As we have done for default uniforms and textures, we should cache descriptorset for driver uniforms to avoid repeatedly create them. Bug: b/161750230 Change-Id: I0afabb226d5a8e8c7838fa2484ec7f9689ed5fa0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309349 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 248119b3 2020-07-20T16:05:45 Vulkan: Fix render target's tracking of content defined Imagine the following scenario: 1. Clear draw framebuffer 2. Invalidate draw framebuffer 3. Update texture attached to draw framebuffer 4. Draw again into draw framebuffer Step 3 could be a number of things, such as glCopyTex[Sub]Image, glBlitFramebuffer, glTex[Sub]Image2D, glGenerateMipmap etc. In the above scenario, at step 2, the framebuffer's render target remembers it being invalidated (mContentDefined = false). This is used to set the loadOp of the next render pass to DONT_CARE. However, mContentDefined was implemented for a very specific optimization regarding the swapchain's depth buffer. The reuse of this variable for glInvalidateFramebuffer was erroneous as this variable didn't track whether the contents are defined for the general case. With this change, mContentDefined is set to true during FramebufferVk::syncState for each render target whose contents are marked dirty. This change additionally makes glBlitFramebuffer signal the contents of the blit targets as dirty, as well as textures that are used as storage images. Bug: angleproject:4859 Change-Id: I68c829f75ff4a3d03bb293ec72c609384983026d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309110 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Mohan Maiya 2c3ff0a0 2020-07-25T11:35:19 Vulkan: Enable VK_KHR_get_memory_requirements2 extension Don't assume support for VK_KHR_get_memory_requirements2, enable the extension, if supported, during device creation. Bug: angleproject:4830 Change-Id: I0faf955aac8a2ae4dea636f349225672e6717662 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319079 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Charlie Lao cf49403e 2020-07-21T11:40:56 Vulkan: Increase default uniform buffer size to 64K Since these are per context, we can increase it (and subject to the driver maxUniformBufferRange limit) to reduce the amount of descriptor set allocated. Bug: b/161391337 Change-Id: I89e5cf16ee377735c412e9a9a22c651e1c677ded Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310910 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Jamie Madill 308078b0 2020-07-24T11:02:21 Tests: Add getProcAddress method to GLWindowBase. This will allow the Trace tests to load a custom GL after the GL window has already loaded the default entry points. Bug: angleproject:4845 Change-Id: Ic1b65b6cf1a582ea7c2f58a9f76077760e5cf0d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315626 Reviewed-by: Manh Nguyen <nguyenmh@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tobin Ehlis dcdd6b6a 2020-05-14T14:36:31 Vulkan:Enable Validation best practices layer When Vulkan Validation layers are enabled, also enable the validation best practices layer which includes ARM's perfdoc layer. Initially adding skips for all of the best practices errors that are triggered so that these can be enabled by default. Bug: b/156661359 Change-Id: I7eab9710bf9632d07ff6b80375d3ad1789d58f7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2202634 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Charlie Lao 8765b46a 2020-07-15T17:10:35 Vulkan: Make mDefaultUniformStorage per ContextVk Right now the dynamic buffer for default uniform is per program. Most of time the buffer is unused. That is a huge waste of memory (and these memory are wired memory). This CL moves the mDefaultUniformStorage from per ProgramVk to ContextVk so that we all share with each other. Bug: b/161391337 Change-Id: I1fe8523b2b2dbc39bec3509a3432e38e34bd5713 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2274870 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Ethan Lee d92c4ab6 2020-07-24T15:26:53 Add GGP to Platform Support table Bug: angleproject:4874 Change-Id: I0a497719b00330407b5755d64153315115a95b48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2318047 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Maksim Sisov 62b11a47 2020-07-23T16:35:29 X11: cast native display type to XDisplay. This is required to have use_x11 && use_ozone builds at the same time. Bug: chromium:1085700 Change-Id: I3d4cdf590e1ecf79af9e2d4bd585955c3f1b7af6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315031 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Manh Nguyen 3b0c9918 2020-07-21T11:52:13 Update CaptureAndReplay.md and Python script with links Links to the Python script in CaptureAndReplay.md Links to CaptureAndReplay.md's testing section in the Python script Bug: angleproject:4817 Change-Id: I584f8508661950e4907dae1adb8f0fe300387198 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309226 Commit-Queue: Manh Nguyen <nguyenmh@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 4ccf4d0a 2020-07-27T07:01:14 Roll SwiftShader from 6a8a74986c35 to 3b2cd31c7400 (9 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/6a8a74986c35..3b2cd31c7400 2020-07-26 capn@google.com Update Vulkan headers to version 1.2.148 2020-07-26 capn@google.com Refactor native instruction intrinsics 2020-07-24 amaiorano@google.com Delete third_party/llvm-7.0 2020-07-23 sugoi@google.com Add basic support for VK_EXT_debug_utils 2020-07-23 srisser@google.com Add support for depthBiasClamp 2020-07-23 spang@chromium.org Silence warnings on dedicated external memory allocations 2020-07-23 capn@google.com Regres: Roll dEQP to 1.2.3 2020-07-23 amaiorano@google.com Fix CMake failure on MacOS when PowerVR submodule is checked out 2020-07-23 capn@google.com Don't update CMake for Windows Kokoro builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I51df404988b223be4c2e2a3d30891c86797e4b8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319979 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 45de2793 2020-07-27T07:01:26 Roll Vulkan-ValidationLayers from adf938680697 to 361fb5311b9b (13 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/adf938680697..361fb5311b9b 2020-07-24 jzulauf@lunarg.com syncval: Update ordering/most recent hazard checks 2020-07-24 mikes@lunarg.com build: Handle glslang static lib dependency cycles 2020-07-23 christophe@lunarg.com doc: Highlight Vulkan Configurator 2020-07-23 christophe@lunarg.com doc: Fix links on LunarXchange 2020-07-23 jeremyk@lunarg.com tests: Add test for corner sampled with CtE 2020-07-23 jeremyk@lunarg.com layers: Add check for corner sampled with CtE 2020-07-23 jeremy@lunarg.com tests: Fix push-constant test 2020-07-23 s.fricke@samsung.com tests: Add export AHB positive tests 2020-07-23 s.fricke@samsung.com layers: Fix exported AHB checking allocationSize 2020-07-23 s.fricke@samsung.com tests: AHB test for bindBufferMemory 2020-07-23 s.fricke@samsung.com layers: Remove AHB bindBuffer VUs 2020-07-23 mark@lunarg.com chassis: Move layer option handling into separate files 2020-07-23 mark@lunarg.com chassis: Localize config and env settings handling If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ibb4a62f4c004feb6aaac60e9612c33d7c78205d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319980 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c3ccd3a7 2020-07-27T07:01:51 Roll Vulkan-Headers from 83825d55c7d5 to a0f1f5149d91 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/83825d55c7d5..a0f1f5149d91 2020-07-23 git@haasn.xyz Fix enum order for backwards compatibility If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: I25985607c096ddf8f17736410e7224a805f2b0e4 Bug: None Tbr: timvp@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319864 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 3f851efa 2020-07-24T14:54:37 Vulkan: Fix overflow in maxCombinedUniformComponents The value is capped to INT_MAX to avoid overflow when queried with glGetIntegerv(). Bug: angleproject:4554 Bug: angleproject:4788 Change-Id: I36d52fc608ef5adc2bc0b73e379db66cbfd9bb54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2318046 Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 07ae186b 2020-07-24T10:55:33 Capture/Replay: Update headers. Instead of including "angle_trace_gl.h" in shared capture header we can include it in each cpp file. This prevents a header conflict with the "old" way of using the util GL loader. Bug: angleproject:4845 Change-Id: Ia00a2beffc77446c779ceec8995fce9704e7b8af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315625 Reviewed-by: Manh Nguyen <nguyenmh@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 8adc5469 2020-07-02T10:15:17 Vulkan: Generate mipmap in compute An initial implementation based on AMD's FFX SPD (Single Pass Downsampler). Apart from requiring STORAGE_IMAGE support for the image format, the following limitations are in place due to FFX SPD: - Image must be 2D or 2D array (including cube maps) - Image must be single-sampled The following _can_ be supported, but not yet implemented: - sRGB formats - Integer formats - depth/stencil formats Bug: angleproject:4551 Change-Id: Ibc4d5cea701cca31e55e3d651540872bbd3b473f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2278713 Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten bef908ee 2020-07-24T12:53:13 Enable KHR GLES31 tests blocked on Issue 4146 The KHR GLES31 tests disabled and marked with Issue 4146 are passing, likely due to the work for Issue 3570: Vulkan: Implement separate shader objects or program pipeline objects. This CL re-enables the tests. Bug: angleproject:4146 Bug: angleproject:3570 Test: KHR-GLES31.core.shader_storage_buffer_object.basic-syntaxSSO Test: KHR-GLES31.core.vertex_attrib_binding.advanced-bindingUpdate Test: KHR-GLES31.core.vertex_attrib_binding.advanced-largeStrideAndOffsetsNewAndLegacyAPI Change-Id: I4e42129c873604c937cf03412a105170755413e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2318265 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Tim Van Patten 43b951c8 2020-07-21T17:36:06 Remove third_party/angle/ from generate_android_bp.py Android builds are failing due to .git/HEAD being listed in the Android.bp, which generate_android_bp.py is supposed to remove. The problem is that the blacklist contains '//third_party/angle/.git/HEAD' rather than '//.git/HEAD', due to generating the GN files from chromium/src/ rather than angle/. This CL cleans this up. Bug: b/160727922 Test: Manual script execution and building in AOSP Change-Id: Ia1682605097791d20b28686f3043ddc08d49ca52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310960 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll df5ed61d 2020-07-23T07:01:26 Roll Vulkan-ValidationLayers from d92ddcef72ef to adf938680697 (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d92ddcef72ef..adf938680697 2020-07-22 jeremy@lunarg.com layers: Improve push constant error logging 2020-07-22 jzulauf@lunarg.com syncval: Cleanup of extraneous tags, user doc revs 2020-07-22 jzulauf@lunarg.com syncval: Style cleanup design/add user doc 2020-07-22 jakub@okonski.org Revert "Simplify the guard around ValidateMaxTimelineSemaphoreValueDifference" 2020-07-22 jakub@okonski.org Add a test for binary semaphore value difference checks 2020-07-22 jakub@okonski.org Simplify the guard around ValidateMaxTimelineSemaphoreValueDifference 2020-07-22 jakub@okonski.org Fix timeline semaphore value difference validations on binary semaphores 2020-07-22 christophe@lunarg.com doc: Add links to per-feature docs 2020-07-22 tony@lunarg.com tests: Skip test if limits are very large If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ie3197c42fb6e55018ec373f6851424596ba03252 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315295 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3c3470b9 2020-07-23T07:01:20 Roll glslang from 11fa4d0d5694 to 3ee5f2f1d331 (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/11fa4d0d5694..3ee5f2f1d331 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I659c87076350acbd56ccbfdcb0751bb152fa72d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315294 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 201d43ae 2020-07-23T07:01:14 Roll SwiftShader from f272427bda39 to 6a8a74986c35 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/f272427bda39..6a8a74986c35 2020-07-22 amaiorano@google.com Fix ReactorDebugInfo off by one line issues 2020-07-22 amaiorano@google.com Fix GN debug builds of SwiftShader on LLVM 10 2020-07-22 tommek@google.com Fix copying between images and buffers with padding If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:4861 Tbr: timvp@google.com Change-Id: I4a7da511bda78aa04b627cb3ba3ac79bc74a0c48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315293 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jiajia Qin f359cb66 2020-07-02T15:15:54 Reland: Refactor DisplayGbm::generateConfigs We should explicitly set EGL_SURFACE_TYPE to EGL_DONT_CARE. Otherwise, it's default value is EGL_WINDOW_BIT. However, on some platforms, only EGL_PBUFFER_BIT is supported. In this case, no matching config is found. So mWindowSurface and mPbufferSurface will be nullptr. That's why we see the bot failed. Bug: chromium:1105208 Change-Id: I8ee2487fd24bab86a5ec22fbe7b8ff68081bc15c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304429 Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jiajia Qin 074bc23f 2020-07-21T18:11:57 Implement DRM_FORMAT to GL format conversion Bug: chromium:1096442 Change-Id: I79722073bd1f2674b40e7eaa8d5311a09bc36416 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309636 Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cody Northrop ca8f856a 2020-07-22T13:56:40 Tests: Update gfxbench traces Migrate from traces recorded on desktop to traces recorded on a Pixel 4 XL. This impacts the resolution and framebuffer config used for the tests. They now more accurately reflect the numbers seen from running the benchmark directly. Test: angle_perftests --gtest_filter=TracePerfTest.Run/* Bug: angleproject:4048 Change-Id: Ib013dfb35c32c6f97bcae76a74cc16d9a5d1a369 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314896 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mohan Maiya ffb31229 2020-07-22T12:02:54 Capture/Replay: Enable capturing slingshot scenes Implemented parameter capture functions for: glGetActiveUniformsiv glGetActiveUniformBlockName glGetActiveUniformBlockiv Added a check for bound unused locations when capturing glLinkProgram Changed CaptureGetParameter to always request a gReadBuffer allocation of the maximum reported possible array size needed to query GL_COMPRESSED_TEXTURE_FORMATS. Recording the value on the capturing device would previously have buffer overflow issues when the replaying the capture on a device with more formats available. Changed VertexAttribType::UnsignedInt2101010's string to reflect the correct type Bug: angleproject:4834 Change-Id: Icd1ff404369ae9f18cad7cd4f56fbcccc89e7e98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306735 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Jamie Madill a4535c18 2020-07-22T14:52:26 Fix trace tests auto-generation. This moves the trace header inclusion to the cpp file so that the test itself doesn't need to look at the individual trace headers. This fixes an include directory dependency. Also removes the FBO change callback from the generated traces. Bug: angleproject:4845 Change-Id: I019f0d347a62a81b92bf32110572911111212689 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314217 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 9faf0cdc 2020-07-20T10:30:55 Capture/Replay: Use custom GL header. This will let us override the util loader for all new traces. It will also be easier to maintain going forward if we have to change the header again. The end goal is to run the trace tests with a custom GL layer that can intercept certain API calls. Bug: angleproject:4845 Change-Id: I028a1afdadf638998805d7b9a2cc6717cf5f0148 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2308029 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang ab95a449 2020-07-20T12:12:18 Textures that have bound surfaces are always renderable. Chrome still tends to use ES2 contexts for most rasterization. This is a problem when trying to use FP16 IOSurfaces for rendering HDR because GL_RGBA16F is not renderable in ES2. Since a surface is always renderable, allow rendering to any textures with a bound surface. Update the tests to verify that ES3 formats can be used with ES2 contexts. Add tests for RGBA16F IOSurfaces. BUG: chromium:1103112 Change-Id: I9e8c082fc97a0e072289b097e71fc944988d4872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307454 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Wander Lairson Costa ee9c4fe4 2020-07-14T15:29:40 D3D: Make possible to build angle without D3D11 A few files inside the D3D11 tree are used by D3D9 and WGL backends. We add these files to the build system even when D3D11 is disabled. Also, we fix the use the of ANGLE_DEFAULT_D3D11 symbol. Bug: angleproject:4839 Change-Id: I981f4bfc60d973c02549caa737c5aed5ccf31282 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2298143 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll f3c72fdf 2020-07-22T07:01:20 Roll glslang from b99a6a727318 to 11fa4d0d5694 (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b99a6a727318..11fa4d0d5694 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ic08523541b7efe21d00e2b410ca014cc18f6f661 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311940 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d17b53d1 2020-07-22T07:01:32 Roll Vulkan-Tools from 50e737c82347 to 3b36fdc64014 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/50e737c82347..3b36fdc64014 2020-07-20 shannon@lunarg.com build: Update known-good files for 1.2.148 header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I34c9270fdfc6581e546f7861cd7294e0213d45ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311941 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c0482a16 2020-07-22T07:01:14 Roll SwiftShader from 97f9923235cf to f272427bda39 (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/97f9923235cf..f272427bda39 2020-07-21 capn@google.com Eliminate dead host/target feature code for Subzero 2020-07-21 amaiorano@google.com Fix ENABLE_RR_DEBUG_INFO on LLVM 10 2020-07-21 amaiorano@google.com Remove support for LLVM < 10 2020-07-21 amaiorano@google.com Delete LLVM 7 Kokoro configs 2020-07-21 amaiorano@google.com Fix LLVM-10 CMake build 2020-07-21 swiftshader.regress@gmail.com Regres: Update test lists @ 97f99232 2020-07-21 capn@google.com Regres: Don't test changes with negative scores If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I7a23451d6fef9da2f33b5d62b078ce9b0072ac27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311730 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 62b67239 2020-07-22T07:01:26 Roll Vulkan-ValidationLayers from 7cc0ead05174 to d92ddcef72ef (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7cc0ead05174..d92ddcef72ef 2020-07-21 jzulauf@lunarg.com syncval: Cleanup document from autogeneration 2020-07-21 mark@lunarg.com tests: Add test for non-device concurrent buffer qfamily 2020-07-21 mark@lunarg.com corechecks: Check CONCURRENT_MODE against ALL pdev qfamilies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Id0295628171dae6f3198bbe1dcb5fa55496ad115 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311731 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi f6659b3d 2020-07-20T15:55:52 Vulkan: Fix invalidate + deferred clear Imagine the following scenario: 1. Clear draw framebuffer 2. Invalidate draw framebuffer 3. Copy from read framebuffer into texture that is attached to draw framebuffer 4. Draw again into draw framebuffer At step 2, FramebufferVk::syncState is called which extracts the clear and stores it in mDeferredClears, but since the framebuffer description hasn't changed, a new render pass is not started. At step 3, the texture attached to the draw framebuffer is used as copy destination, but its clear which is stored in the (apparently irrelevant) draw framebuffer is not flushed. At step 4, a new render pass is started which clears the draw framebuffer, trampling the copy in step 3. This change makes sure invalidate results in a flushDeferredClears(). With glInvalidateFramebuffer() (not glInvalidateSubFramebuffer()), the deferred clears for invalidated framebuffers are discarded first. It is unknown whether there are similar situations where syncState gathers deferred clears, but they are not flushed before the attachments are updated outside the framebuffer. To catch similar bugs in the future, assertions are added to FramebufferVk::syncState such that if a dirty bit is set for the contents of an attachment, we can make sure there are no prior deferred clears stored for that attachment. Bug: angleproject:4862 Change-Id: Idb1a08b53e7f011f0fc9a54d478289030b6d77a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2308034 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c757e607 2020-07-21T10:18:41 Vulkan: Fix deferred clears and noop clear and blit Imagine the following situation: 1. Clear draw framebuffer 2. Noop operation on the framebuffer (Clear, ClearBuffer, BlitFramebuffer with flags specifying non-existing attachments) 3. Change framebuffer's attachment 4. Draw into framebuffer At step 2, FramebufferVk::syncState was called before noop-ing the operation. During syncState, deferred clears were stored in the framebuffer and weren't flushed because the actual operation was not performed. At step 4, the deferred clear meant for the prior attachment gets applied to the new attachment. Bug: angleproject:4865 Change-Id: I5b096bacf00356b4dccd4cbc9561b87b1bb557d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309224 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Courtney Goeltzenleuchter 93eb633c 2020-07-07T15:41:38 Inline depth/stencil clear if in middle of renderpass Some apps have a pattern where they clear the depth & stencil buffers in the middle of the frame which causes the Vulkan backend to stop the existing render pass and start a new one. This causes more loads & stores of buffer contents than if we inline that clear with a draw. Bug: b/159808300 Bug: angleproject:4695 Change-Id: I7a15af22f47a81051fa33fa19eaa123d8b66597c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289945 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 964c4089 2020-07-21T14:08:21 Vulkan: fix RenderPassDesc::mColorAttachmentRange This variable tracks the index range of color attachments. A previous change (d8ce865b5fd113d8e0cec4368a9a192a524566a1) made the range inclusive so it can fit in 3 bits, but that's incorrect as it's no longer possible to specify a range where no color attachments are present. This change partially reverts d8ce865b5fd113d8e0cec4368a9a192a524566a1 to restore the previous semantics of RenderPassDesc::mColorAttachmentRange. Bug: chromium:1107884 Change-Id: I08da2568b5e63a48a672edd499a8b6653060eadb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310578 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 6ca2c116 2020-07-17T13:07:24 Make trace tests a shared library. This will facilitate intercepting the GL calls and implementing emulation paths for offscreen redering. Or other EGL/GL features. It does not yet override the GLES loader and uses the shared 'angle_util' loader as it did before. Bug: angleproject:4845 Change-Id: I68806c307f59e1852999299e88dc358781817f12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305042 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Manh Nguyen <nguyenmh@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 4fa75b5c 2020-07-17T12:58:50 Move restricted trace functions to cpp file. This is a refactoring change only. It will facilitate moving these functions to a shared library. A shared library will allow us to more easily override GL functions with an interception layer. The intercept layer will allow us to do emulation for features like offscreen tests. Bug: angleproject:4845 Change-Id: I0e00c0c22a26f1bb8faec30a825c71953033f8a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305039 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 23211585 2020-07-21T10:08:03 Roll chromium_revision b0410bba02..fb6cbaf6e5 (763000:790363) Also updates a Vulkan back-end file to not return error. Change log: https://chromium.googlesource.com/chromium/src/+log/b0410bba02..fb6cbaf6e5 Full diff: https://chromium.googlesource.com/chromium/src/+/b0410bba02..fb6cbaf6e5 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/45ab3c89af..1ee11394cf * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/204a35a2a6..9e121212d4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3993ef1f52..f126fc6578 * third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/36657c103c..9c8566e047 * third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/217407c478..defbf92951 * third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/{chromium_..ec647b85b6 * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/4fa54ca5f7..19f3fad68d * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/ae385786ed..89bddfee9c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/04b99e7bf9..6412135b39 * tools/md_browser: https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/aae45d8d82..be8cf5a17d DEPS diff: https://chromium.googlesource.com/chromium/src/+/b0410bba02..fb6cbaf6e5/DEPS Clang version changed 4e0d9925d6a3561449bdd8def27fd3f3f1b3fb9f:04b9a46c842f793a2baedcad64de35fcbd3e93b7 Details: https://chromium.googlesource.com/chromium/src/+/b0410bba02..fb6cbaf6e5/tools/clang/scripts/update.py Bug: angleproject:4867 Change-Id: I184945ad4d1fc39f4ad9b37cbf411b2c2b74a3ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309223 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 1cfc6f0a 2020-07-20T16:03:38 Add test for deferred clear + attachment gaps This test makes sure the list of clear values given to the render pass (for deferred clears) are correctly passed. Bug: angleproject:4862 Change-Id: I4830a72a6f2b01570f6d4427ffb025429b5aa03c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309109 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Geoff Lang 16856027 2020-07-08T13:47:33 Support EXT_shader_texture_lod on Vulkan. Bug: angleproject:2899,b/161716126 Change-Id: Ia850cbda948c8f6da9ced0bf46fd7f8371125032 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2288333 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Manh Nguyen 10e9e9a1 2020-07-13T17:02:38 Apply multiprocessing to capture_replay_tests.py Multiple tests are run in paralell to squeeze the most out of CPUs. Tests are stored in a work queue. Whenever a CPU becomes available, the next unrun test is grabbed and run on a spawn process on that CPU. Each cpu gets their own environment and build folders and trace folders so that tests don't overwrite each other. Bug: angleproject:4817 Change-Id: Ifd35c9c75522e480b0257d090d5af70f2a3428ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2296040 Commit-Queue: Manh Nguyen <nguyenmh@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 7c79945a 2020-07-21T11:30:01 Roll VK-GL-CTS from 30aa06f22718 to 4b40207be32d (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/30aa06f22718..4b40207be32d 2020-07-21 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master 2020-07-21 alexander.galazin@arm.com Remove Amber example test 2020-07-20 slawomir.cygan@intel.com Reintroduce excluded dEQP-VK.binding_model.descriptorset_random tests 2020-07-20 alexander.galazin@arm.com Update Vulkan headers 2020-07-20 gary.sweet@broadcom.com VK_EXT_image_robustness tests 2020-07-20 alexander.galazin@arm.com Update glslang, SPIR-V Headers and tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,timvp@google.com Change-Id: Ie3adac45f59f362fefc67f759356d26924e84d1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309638 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0dd63428 2020-07-21T07:01:55 Roll Vulkan-Loader from dd3511549b18 to bfe4f378aee6 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/dd3511549b18..bfe4f378aee6 2020-07-20 shannon@lunarg.com build: Update known-good files for 1.2.148 header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I71939d8fdd18bdf762eaa8f76106bdc801cd26cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309668 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3045ca3a 2020-07-21T07:01:55 Roll SPIRV-Tools from 717e7877cac1 to 8b5ed4448dfe (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/717e7877cac1..8b5ed4448dfe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I7d8f1390f84432f7f5409e869d1c4ecd4dca3653 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309789 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a27692d1 2020-07-21T07:01:58 Roll SwiftShader from ea6f21a052c9 to 97f9923235cf (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/ea6f21a052c9..97f9923235cf 2020-07-20 mark@chromium.org Fix macOS arm64 GN build by building llvm RWMutex.cpp 2020-07-20 ddorwin@google.com Update tests/presubmit.sh with modern syntax for Fuchsia bugs 2020-07-20 amaiorano@google.com Update to latest PowerVR to keep cmake source clean 2020-07-20 capn@google.com Support _PACK32 storage image formats and fix asserts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I33b83dbecc68115347b146721180c628bfd3c998 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309790 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d0057db3 2020-07-21T07:01:09 Roll Vulkan-ValidationLayers from b1346703979e to 7cc0ead05174 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b1346703979e..7cc0ead05174 2020-07-20 locke@lunarg.com syncval: Add descriptor type and image layout 2020-07-20 jzulauf@lunarg.com syncval: Add heuristic to suppress safe WAW msg 2020-07-20 jzulauf@lunarg.com syncval: Add additional access info to hazard msg 2020-07-20 shannon@lunarg.com build: Update known-good files for 1.2.148 header 2020-07-20 tony@lunarg.com tests: Avoid "abort, retry, ignore" dialog boxes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I502f7d36f6e4aad6f3b51a93b8d69ec45461dea0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309666 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4ce72e14 2020-07-21T07:01:44 Roll glslang from 9eef54b2513c to b99a6a727318 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9eef54b2513c..b99a6a727318 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ib84d914c6ab19a88a93ea9662dc09ecae50e581d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309667 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi d9818fd6 2020-07-19T00:37:21 Vulkan: Improve RenderTargetVk's getImage interface Prior to this change, RenderTargetVk had getImage() and getImageForWrite(). This change introduces getImageForCopy() and renames getImage() to getImageForRenderPass(). Currently, all three functions do the same thing. However, with upcoming changes the semantics will be different: - getImageForRenderPass(): This is the image used as the non-resolve attachment. When resolve attachments are introduced, there will be a corresponding getResolveImageForRenderPass(). - getImageForCopy(): When GL_EXT_multisampled_render_to_texture is implemented, this will return the image that owns the data. - getImageForWrite(): Similar to getImageForCopy(), but should set mContentDefined. This is currently missing, and is a bug that will be resolved in a follow up. This split change gets the mechanical rename out of the way to make future changes simpler. Bug: angleproject:4836 Bug: angleproject:4859 Change-Id: I5f7657cc049c0e1772a7c510e74289e685ba93c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306516 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Tim Van Patten 20eb9be5 2020-07-07T16:24:55 Generate Android.bp from multiple gn descriptions With the introduction of ABI-specific build targets (zlib), the script generate_android_bp.py needs to be updated to consume ABI-specific gn descriptions and generate ABI-specific build rules for each target. The roll_aosp.sh script was updated to generate ABI-specific gn descriptions for each: arm arm64 x86 x64 Bug: b/160727922 Test: Manual script execution and building in AOSP Change-Id: I459b388176f8fcc010f9f5668535d941b931cdd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2285272 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tim Van Patten 80d7725d 2020-07-15T15:14:17 Use Subject/Observer pattern for Programs/Executables in PPOs This CL updates the frontend to use the subject/observer pattern for Programs and ProgramExecutables in PPOs. This allows us to remove the hack that iterated through all PPOs and marking them all dirty when a Program is re-linked. Instead, just the PPOs the Program is bound to are signalled, and only when the Program is in a PPO. Additionally the necessary PPOs are signalled when an Executable's textures are updated, rather than iterating through all PPOs and signalling them. Bug: angleproject:4559 Test: CQ Change-Id: Iaefb88c64c13259e921c8dfe95cf640247d17f85 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300705 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi d8ce865b 2020-07-19T00:20:17 Vulkan: Make room in RenderPassDesc for resolve attachments Data in RenderPassDesc is packed better to make room for resolve attachments (9 bits made available; 8 for color and 1 for depth/stencil). mColorAttachmentRange contains values in [0, 8). The right side of the range is made inclusive (i.e. [0, 7]) so it will fit in 3 bits. The number of samples is always a power of 2, and below 128 (for the foreseeable future), so its log is stored instead in 3 bits. This change doesn't add support for resolve attachments yet, but is split off the one that does to simplify it. Bug: angleproject:4836 Change-Id: I2856286d5239499d0ab0c78b8154881c003309bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306515 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Ian Elliott 7e2a9820 2020-07-20T12:38:05 Vulkan: Make explicitly-[non-]rotated get methods Split FramebufferVk::getCompleteRenderArea() into 2, [non-]rotated, explicitly-named methods. Simplify the uses of these methods, and fix some rotation cases. Also explicitly-name FramebufferVk::getScissoredRenderArea(). Bug: b/151111296 Change-Id: I1754ec2796fd8625b916a2dba2e723e70ecba419 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305389 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Charlie Lao bdc79361 2020-07-15T17:01:05 Vulkan: No need to add current buffer into mResourceUseList This is follow up to https://chromium-review.googlesource.com/c/angle/angle/+/2288325. There is no need to add current buffer to mResourceUseList for the per context dynamic buffers. These dynamic buffers always shut down after we call finishImpl. Bug: b/160777679 Change-Id: I013cb3c30b4d31804cee13ce9e42da381fd1ae1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300208 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi cd5489ad 2020-07-19T00:05:21 Vulkan: Faster FramebufferDesc compare Objects of this class are used as keys to a hash map and contain 10 serials. Prior to this change, operator== would compare all 10 serials. This change tracks the maximum index set and only compares up to that many serials. To make sure this maximum index stays low in the presence of depth/stencil attachment, this class stores the depth/stencil attachment's serial before the color attachments. The update API of the class is improved so this implementation detail is not leaked. This is in preparation for supporting resolve attachments, which would add another 8 serials to the class. With this change, the performance of cases that don't use resolve attachments won't be affected. Bug: angleproject:4836 Change-Id: Ia4874ab79163901fb86f5bee4120e9f19babdc09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306514 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Charlie Lao 234be194 2020-07-15T14:55:18 Vulkan: Move mEmptyBuffer from program to ContextVk And merge that with TheNUllBuffer as well so that you only have one dummy buffer per context. Bug: b/161391337 Change-Id: I75fddb5c48393876e745ff237e11d9c5672ae10e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300707 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Ian Elliott 0df0b79c 2020-07-17T16:26:21 Vulkan: Optimize changing texture max level For applications that frequently change the texture max level, to a value that is a subset of the texture's maximum levels, just recreate the VkImageView's. Test: NBA 2K20 game play Bug: b/160976091 Change-Id: I62a05a90cdb90147056ba8cec960c2114479ec37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300532 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Geoff Lang 49108a12 2020-06-30T11:53:23 Support BGRA_1010102 IOSurfaces in CGL and Vulkan. Bug: chromium:1100599 Change-Id: I7bc2c2e35490e28e9f6fe8f2e0c26cdea50650b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2275731 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cody Northrop 5671c2bd 2020-07-17T13:32:22 Capture/Replay: Fix vertex array objects for MEC While debugging NBA2K20 MEC, fixed the following issues: * Don't bind built-in attributes locations. * Don't emit glGenBuffers for the default VAO. * Include element array buffer in MEC. Test: NBA2K20 MEC Bug: b/160014453 Change-Id: I1b809946d67b6748b0670814be8dd090278dc38f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307276 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Manh Nguyen <nguyenmh@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 55e85549 2020-07-17T14:02:36 Lift warning from trace tests. Noticed when working on a related feature. Bug: angleproject:3630 Change-Id: I82638d37ee6d27dc824d5782c96387f0d000d585 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305040 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 0d8a4da6 2020-07-20T07:01:10 Roll Vulkan-ValidationLayers from 412b1b7dd18c to b1346703979e (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/412b1b7dd18c..b1346703979e 2020-07-17 40687079+rumblehhh@users.noreply.github.com corechecks: Default init ACCELERATION_STRUCTURE_STATE members 2020-07-17 locke@lunarg.com syval: Get sub extent by aspect 2020-07-17 locke@lunarg.com tests: Add comment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I72073f78cd0df32d9695b84222dfb96174dd3f51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307057 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b9411968 2020-07-20T08:20:41 Roll Vulkan-Headers from 858b13a1220a to 83825d55c7d5 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/858b13a1220a..83825d55c7d5 2020-07-20 oddhack@sonic.net Update for Vulkan-Docs 1.2.148 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: I8963f84e3fac3b06974e23843617c9014ba0f39f Bug: None Tbr: timvp@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307169 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a4b01730 2020-07-20T07:01:58 Roll SwiftShader from 0a8f44c514ce to ea6f21a052c9 (9 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/0a8f44c514ce..ea6f21a052c9 2020-07-18 capn@google.com Fix GN UBSanVPtr build of LLVM 10 JIT 2020-07-17 amaiorano@google.com Fix Win32 Chromium and ANGLE builds 2020-07-17 capn@google.com Remove Travis CI and AppVeyor build badges 2020-07-17 capn@google.com Update Kokoro's clang-format to version 10 2020-07-17 amaiorano@google.com Fix MacOS Chromium build (source_set dupe) 2020-07-16 amaiorano@google.com Fix MacOS (darwin) Chromium build on LLVM 10 2020-07-16 amaiorano@google.com Added Fuchsia support to LLVM 10 update script and updated configs 2020-07-16 amaiorano@google.com Use LLVM 10 instead of 7 for GN builds 2020-07-16 cwallez@chromium.org Fix B<->T copies of multiple array layers and unpacked rowpitch If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:4851 Tbr: jonahr@google.com Change-Id: I516b970e7a306734cd85238c405e9ba7a87c68bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307061 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a48e333f 2020-07-20T07:01:55 Roll Vulkan-Tools from d093d9723b7c to 50e737c82347 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d093d9723b7c..50e737c82347 2020-07-17 tony@lunarg.com cube: Add option to select phys device If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I6e85f604ceb2b24bd27a649ff3c7a6abdf4c478b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307060 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 53515a3a 2020-07-20T07:01:55 Roll SPIRV-Tools from 680c77fa6c81 to 717e7877cac1 (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/680c77fa6c81..717e7877cac1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I9f0c0fb29bed6084993c482c1061346a3da18e54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307059 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f4f3309a 2020-07-20T07:01:44 Roll glslang from f3cb1896971f to 9eef54b2513c (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f3cb1896971f..9eef54b2513c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I6b0a7504f58c6d6b51c8f4438ca9389a038b399e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307058 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kenneth Russell 08c4d094 2020-07-16T18:48:59 Improve WebGL 2.0 readPixels support. Emulate GL_PACK_SKIP_PIXELS and GL_PACK_SKIP_ROWS on macOS, where it appears the OpenGL driver ignores these parameters. Add WebGL 2.0-specific validation constraints for pixel pack and unpack parameters. Bug: angleproject:4849 Change-Id: Iab566299223e05484a009817acb1ed2816023823 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2303905 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Courtney Goeltzenleuchter 9a9ef0ae 2020-07-15T16:50:32 Vulkan: Fix RTs attached to textures with non-0 mip Cleared confusion between GL level indices and VK level indices by adding the corresponding suffix to variables and function arguments. A handful of places that sent one index and expected the other are fixed. A couple more places needed this adjustment that were missed in the first CL. Also included a test to provoke those situations. The conversion between the two is given by: levelIndexGL = levelIndexVk + baseLevel; Bug: angleproject:4695 Change-Id: I3b8e5699abee1b011e52b666e6e245f44cb8ad6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2302549 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Ian Elliott bcec11c2 2020-07-16T18:28:17 Vulkan: FramebufferVk::clearImpl() break-RP fix FramebufferVk::clearImpl() needs to potentially rotate the results of getCompleteRenderArea(), so that it can be compared with the results of getScissoredRenderArea(). Bug: b/151111296 Change-Id: Iad1fbdcb1943bae00835d31863d32ee85dbc7c2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2303606 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Le Hoang Quyen 5f531342 2020-07-08T12:50:00 Metal: Enable dEQP GLES2 tests on AMD. The tests are disabled on Intel & NVIDIA for now. Bug: angleproject:4235 Change-Id: I06f7f8ba332edf308b7209f0ca6e6a6503aa1981 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2176814 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill 4e577a2a 2020-07-15T15:50:06 Perf Tests: Make "offscreen" a common test param. This will let us use it in the trace perf tests. Bug: angleproject:4845 Change-Id: I6188a0765c6f482bb38842faa4c58209c70b0153 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300206 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Xinyi He 9b9472c3 2020-07-17T10:21:11 Fix ContextLostTest if robustness ext is disabled Reset notification behavior is defined in the GL_EXT_robustness extension, and the resulting context must support the extension and the specified reset strategy. So if the ext is not supported, it should disable delivery of reset notifications. Bug: angleproject:4823 Change-Id: I49b9364a83eab9ebc0fdca3b1dc075c1a43070cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2302874 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 94303d17 2020-07-17T10:20:57 Enable fixed swiftshader tests Bug: b/159712754 Change-Id: I5dc26726072ddadc3104561606cd425755679a83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304173 Reviewed-by: Nicolas Capens <nicolascapens@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll c754c02a 2020-07-17T13:16:01 Roll VK-GL-CTS from 8726fda3f865 to 30aa06f22718 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/8726fda3f865..30aa06f22718 2020-07-17 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master 2020-07-17 rgarcia@igalia.com Test pipeline layout lifetime after ending cmd buffer 2020-07-17 dcastagna@google.com Add export/import drm modifier test 2020-07-17 rgarcia@igalia.com Test frag shader side effects are not removed by optimizations 2020-07-17 jbolz@nvidia.com VK_EXT_robustness2 tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jonahr@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com,angle-bots+autoroll-info@google.com Change-Id: Id48ef26916cdd755b73512b15c6fca921c59a1fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304442 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5a4af462 2020-07-17T07:01:55 Roll SPIRV-Tools from 7221ccf85e26 to 680c77fa6c81 (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7221ccf85e26..680c77fa6c81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ibccb8cb205986112774a2ba1c7489edf3662ee10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304358 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 69adcf94 2020-07-17T07:01:44 Roll glslang from 4f72970ed3e0 to f3cb1896971f (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4f72970ed3e0..f3cb1896971f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I5c2d1f93bcfccda9fe2876765247673167d05ad9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304357 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e158751b 2020-07-17T07:01:09 Roll Vulkan-ValidationLayers from 7548cbeabfa7 to 412b1b7dd18c (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7548cbeabfa7..412b1b7dd18c 2020-07-16 tony@lunarg.com practices: Make copies of createInfos 2020-07-16 jan-harald.fredriksen@arm.com tests: Add tests for VK_EXT_fragment_density_map2 2020-07-16 jan-harald.fredriksen@arm.com layers: Validate VK_EXT_fragment_density_map2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Icbab820f849123ace5a0308012a2d0b4c4005f2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304356 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao cc551385 2020-06-29T10:25:45 Vulkan: Add cache for default uniform descriptor set Instead of free and allocate a descriptor set whenever buffer changes, add it into the descriptorset cache. Every time you get the buffer, we also look in the cache first to see if there is a descriptorset for that buffer or not. If yes, we use the cached descriptor set instead of allocate one. Bug: b/159457348 Change-Id: I64c252dfe22db66ea8188415e1b384af371b82ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2273698 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Charlie Lao 67980f13 2020-07-08T08:51:02 Vulkan: add Buffer/Texture/ImageViewSerial class In a few places we need a unique ID to represent that object and use that to compute hash key. Right now we are using Serial for that purpose but it creates confusion with QueueSerial which we are using Serial to track GPU progress. This CL changes these usage of Serial to TextureSerial, SamplerSerial, ImageViewSerial type so that compiler can perform type checking. It also adds BufferSerial in preparation for next CL. Bug: b/159457348 Change-Id: I8e2da69c2029e4ddbcf163981ae46f85e19f751b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287426 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten e0a2bd5e 2020-07-15T18:07:45 Remove ProgramPipelineState::mHasBeenBound The member ProgramPipelineState::mHasBeenBound is unused and should be removed. Bug: angleproject:3570 Test: CQ Change-Id: Idc41574f79e665ac36bef5b206704c667c49dadb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301101 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Charlie Lao 22e1f3e2 2020-06-26T14:26:50 Vulkan: Let all shader stages share one buffer for default uniform Right now each shader stage has its own vk::DynamicBuffer for default uniform storage. This is less efficient than just share one buffer. This CL moves the storage from per shader stage into its ProgramVk object. Bug: b/159457348 Change-Id: If47248ea23c4e48407d3b211583ae2b048d4d10f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2265281 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 4e7a6a69 2020-07-15T19:35:43 Perf Tests: Fix trace test calibration. The trace tests were including the startup time in their calibration calculations. Then was forcing them to always render one step. This fixes the calibration to attempt to get a more consistent measurement. The trace tests now render many more steps than they did before. It should increase the stability and decrease variance in our measurements as they will be runnnig many more frames than before. Also adds a verbose logging flag to help debugging. Noticed this bug when working on the trace test offscreen mode. Bug: angleproject:4845 Change-Id: Iff0c987008a935e7051fca34ef12f4433eb46092 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300205 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Xinyi He 45f54928 2020-06-17T16:25:35 Vulkan: Fix capturing arrays using VK_EXT_transform_feedback Vulkan is able to capture the whole array when using transform feedback extension. Add a new end2end test for it. Due to the outdated nv bots, khr_gles31 tests are faild. Add these suppressions in the khr_gles31 expectations file in order to unblock the commit. Bug: angleproject:4723 Change-Id: I929f99544a01cf5fc781dc31c2c041c851976676 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2247952 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Le Hoang Quyen 349b661d 2020-07-08T12:50:00 Metal: fix max point size and RGB565 renderbuffer bug. - Max point size is set to 64, since this is the max size observed. It is not 511 as https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf claims. - RGB565 is emulated on macOS by RGBA, needs to disable alpha write for this format. This was already done for TextureMtl, but wasn't for RenderBufferMtl. - Also enable true non-power-of-two textures support (OES_texture_npot). This was technically already supported, just that the extension wasn't advertised yet. - New Test: FramebufferFormatsTest.RGB565Renderbuffer Bug: angleproject:4816 Bug: angleproject:2634 Change-Id: Ie7e3efb4cb29bb9a3fd706c26e2b50b42ff3f6be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281797 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Le Hoang Quyen 08b9ad57 2020-07-08T12:50:00 Metal: Prevent vertex shader's inactive varying from being removed If vertex shader declares a varying but doesn't use it, and this varying is being used in fragment shader, linking will fail because the varying would be removed by spirv-cross. Fix: initilize the unused varying with zero(s). New test: GLSLTest.InactiveVaryingInVertexActiveInFragment. Bug: angleproject:2634 Change-Id: Ia37acd8eea85d5da4ddbca6457d6cddb1b41662c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281796 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 82359f92 2020-07-16T07:01:55 Roll SPIRV-Tools from 4c33fb0d3dba to 7221ccf85e26 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4c33fb0d3dba..7221ccf85e26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I2a8920fc337b444d2036d7410be3fa6066f16239 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301353 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2361c593 2020-07-16T07:01:58 Roll SwiftShader from 1de497cc50ab to 0a8f44c514ce (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/1de497cc50ab..0a8f44c514ce 2020-07-15 bclayton@google.com Regres: Collate and add new documentation for Regres If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Icc753a1ac3871ebfaf3a30c6aa999b3fb24c49f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301354 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0f55d55a 2020-07-16T07:01:44 Roll glslang from b481744aea1e to 4f72970ed3e0 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b481744aea1e..4f72970ed3e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: If2f1140131bd5ce6052491dbff763935502a44bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301350 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b7c81133 2020-07-16T07:01:55 Roll Vulkan-Tools from 521eaacef67a to d093d9723b7c (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/521eaacef67a..d093d9723b7c 2020-07-16 bob@lunarg.com scripts: fix update_deps retry clone 2020-07-15 shannon@lunarg.com build: Update known-good files for 1.2.147 header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I9ca9134800e9ad27340fd43348f6ca389be2b187 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301352 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll eb3d8ee6 2020-07-16T07:01:55 Roll Vulkan-Loader from d8f34456c819 to dd3511549b18 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/d8f34456c819..dd3511549b18 2020-07-16 bob@lunarg.com scripts: fix update_deps retry clone If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Idc84db0de207a83f25c798899bc4e5a66958529a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301351 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 452ab092 2020-07-16T07:01:09 Roll Vulkan-ValidationLayers from 04c82ec6f36f to 7548cbeabfa7 (100 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/04c82ec6f36f..7548cbeabfa7 2020-07-15 bob@lunarg.com scripts: fix update_deps retry clone 2020-07-15 tony@lunarg.com tests: Add ShieldTV rev b to skiplist 2020-07-15 tony@lunarg.com gpu: Report errors when shader instrumentation fails 2020-07-15 shannon@lunarg.com build: Address VUID inconsistencies for 1.2.147 2020-07-15 shannon@lunarg.com build: Update known-good files for 1.2.147 header 2020-07-14 jzulauf@lunarg.com tests: Add test for attachment final layout tran 2020-07-14 8729214+jonahryandavis@users.noreply.github.com Fix -Wrange-loop-construct range var copy warning 2020-07-14 jzulauf@lunarg.com syval: Correct assert during final layout record 2020-07-14 tksuoran@gmail.com lifetimes: Fix GetPhysDeviceDisplayProp2 null derefs 2020-07-13 pdaniell@nvidia.com tests: Add VK_EXT_extended_dynamic_state tests 2020-07-13 pdaniell@nvidia.com layers: Add VK_EXT_extended_dynamic_state validation 2020-07-13 bob@lunarg.com scripts: update copyright notice for update_deps 2020-07-13 bob@lunarg.com scripts: update_deps retry on clone or fetch failure 2020-07-13 jzulauf@lunarg.com docs: Add synchronization design doc 2020-07-13 locke@lunarg.com tests: Layout Transition error test 2020-07-13 jzulauf@lunarg.com syncval: Add stage/access info to hazard messages 2020-07-13 jzulauf@lunarg.com syncval: Add input attachment state tracking 2020-07-13 jzulauf@lunarg.com syncval: Fixes for attachment detection/update 2020-07-13 locke@lunarg.com layers: Fix sub extents 2020-07-13 locke@lunarg.com syncval: Add Prior access 2020-07-13 locke@lunarg.com syncval: Fix for 3D image 2020-07-13 jzulauf@lunarg.com syncval: Correct order for syval end rendpass calls 2020-07-13 locke@lunarg.com syncval: Fix wrong mip count in encoder 2020-07-13 jzulauf@lunarg.com syncval: Bound access resolve to range. 2020-07-13 locke@lunarg.com syncval: Check for no current renderpass 2020-07-13 locke@lunarg.com syncval: Fix blitImage offset and extent error 2020-07-13 jzulauf@lunarg.com syncval: Add command name to harzard reports 2020-07-13 jzulauf@lunarg.com layers: Refactor Command name lookup to function 2020-07-13 jzulauf@lunarg.com syncval: Add tag information to hazard log messages 2020-07-13 locke@lunarg.com syncval: Record in StateTracker 2020-07-13 locke@lunarg.com tests: Test syval depth/stencil speparately 2020-07-13 locke@lunarg.com syncval: Test depth/stencil separately 2020-07-13 locke@lunarg.com syncval: Skip FS validation w/rasterizerDiscardEnable 2020-07-13 locke@lunarg.com syncval: Check fs writable output 2020-07-13 locke@lunarg.com syncval: Remove dupl. input attachment validation 2020-07-13 locke@lunarg.com syncval: Refactor detect/update for draw/dispatch 2020-07-13 locke@lunarg.com layers: Catch if shader use store function 2020-07-13 locke@lunarg.com syncval: Check every shader stages 2020-07-13 locke@lunarg.com scripts: Add shader stage map 2020-07-13 locke@lunarg.com tests: More syval test in Cmd 2020-07-13 locke@lunarg.com syncval: Refactor get pipeline 2020-07-13 locke@lunarg.com syncval: More syval in cmd 2020-07-13 locke@lunarg.com syncval: Detect/Update Subpass attachments 2020-07-13 locke@lunarg.com syncval: shared_ptr renderpass/framebuffer 2020-07-13 locke@lunarg.com syncval: Syval vertex and index 2020-07-13 locke@lunarg.com syncval: Syval more cmd 2020-07-13 locke@lunarg.com tests: Fix fail 2020-07-13 locke@lunarg.com tests: Syval CmdDispatch 2020-07-13 locke@lunarg.com syncval: Syval descriptorSets in CmdDispatch 2020-07-13 jzulauf@lunarg.com syncval: Add renderpass store sync validation 2020-07-13 locke@lunarg.com layers: D24 depth pixel size is 3, not 4 2020-07-13 locke@lunarg.com scripts: Deal with MEMORY_READ/WRITE_BIT 2020-07-13 jzulauf@lunarg.com syncval: Add additional resolve att. val/update 2020-07-13 jzulauf@lunarg.com syncval: Add resolve validations NextSubpass only 2020-07-13 jzulauf@lunarg.com syncval: Add hazard detection with ordering checks 2020-07-13 jzulauf@lunarg.com syncval: Add loadOp validation to renderpass 2020-07-13 jzulauf@lunarg.com syncval: Synch Val bugfixes from design review 2020-07-13 locke@lunarg.com syncval: Deal with whole size and remaining 2020-07-13 jzulauf@lunarg.com tests: Add begin renderpass hazard test 2020-07-13 jzulauf@lunarg.com syncval: Convert all sync tagging to new style 2020-07-13 jzulauf@lunarg.com syncval: Add renderpass image layout sync checks 2020-07-13 jzulauf@lunarg.com layers: Add additional attachment info 2020-07-13 jzulauf@lunarg.com layers: Add hinted invalidation to parallel iter 2020-07-13 jzulauf@lunarg.com tests: Fix access mask logic for SetLayout 2020-07-13 locke@lunarg.com syncval: Merge contiguous ranges during encode 2020-07-13 locke@lunarg.com syncval: Fix texel size in ImageRangeEncoder 2020-07-13 locke@lunarg.com syncval: Encode linear image as optimal in MockICD 2020-07-13 locke@lunarg.com syncval: Move image encoder init to BindMemory 2020-07-13 jzulauf@lunarg.com syncval: Add FreeCommandBuffer callback support 2020-07-13 locke@lunarg.com scripts: Sort syncval output for consistency 2020-07-13 jzulauf@lunarg.com syncval: Remove per-handle maps for AccessState 2020-07-13 jzulauf@lunarg.com layers: Add support for fake device memory address 2020-07-13 locke@lunarg.com syncval: Refactor Image encoder/generator 2020-07-13 jzulauf@lunarg.com syncval: Cleanup/Refactor AccessContext 2020-07-13 jzulauf@lunarg.com layers: Add range operator + and copy constructor 2020-07-13 jzulauf@lunarg.com layers: Add subpass transition info to RP state 2020-07-13 jzulauf@lunarg.com syncval: Clean up and bugfix Access state resolve 2020-07-13 locke@lunarg.com syncval: Change offset generator to image generator 2020-07-13 locke@lunarg.com syncval: Add default constructors for Encoders 2020-07-13 jzulauf@lunarg.com syncval: Clean attachment first/last for RP creation 2020-07-13 jzulauf@lunarg.com syncval: Add end renderpass access context resolve 2020-07-13 jzulauf@lunarg.com syncval: Change hazard check to use resolved map. 2020-07-13 locke@lunarg.com syncval: Add function name to hazard log messages 2020-07-13 locke@lunarg.com tests: Test copy buffer image and blit hazards 2020-07-13 locke@lunarg.com syncval: Add copy buffer image and blit entry points 2020-07-13 locke@lunarg.com syncval: Use new generator in synchronization 2020-07-13 locke@lunarg.com tests: Fix test synchronization errors 2020-07-13 locke@lunarg.com syncval: Add dest image adjustment for compressed 2020-07-13 locke@lunarg.com syncval: Add new RangeEncoder and RangeGenerator 2020-07-13 jzulauf@lunarg.com syncval: Add context interface for detect/update 2020-07-13 jzulauf@lunarg.com layers: Enhance Subpass DAG tree information 2020-07-13 jzulauf@lunarg.com syncval: Adding race hazard support 2020-07-13 jzulauf@lunarg.com syncval: Add logical stage extension to exec scope 2020-07-13 jzulauf@lunarg.com sync: Add earlier/later stage maps to codegen 2020-07-13 jzulauf@lunarg.com syncval: Add image layout transition hazard checks 2020-07-13 jzulauf@lunarg.com tests: Add first image sync tests 2020-07-13 jzulauf@lunarg.com syncval: Add image sync validation for CopyImage 2020-07-13 jzulauf@lunarg.com tests: Add more flexible interface to VkImageObj 2020-07-13 jzulauf@lunarg.com tests: Add testcases for buffer region copies 2020-07-13 jzulauf@lunarg.com syncval: Init Sync Val Resource Hazard If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ib945290815d94bdff93297daa0f3f700772e90fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301349 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 6fe87f4a 2020-07-10T09:13:39 Tests: Change screen orientation for traces on Android This CL adds a reverse JNI call to our Android Native Activity that sets the orientation of the screen based on width and height. To achieve this we: * Attach to the java thread once at the beginning to grab JNI env. * Detach from the thread once when platform sends APP_CMD_DESTROY * Set the orientation during test init Bug: angleproject:4327 Change-Id: Ifbe31a6a84dd60a0dfe7d7032962c99b290d8b81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289054 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Manh Nguyen dc9743fb 2020-07-14T11:33:29 Add buffer serialization capability Serializes buffers' states stored on CPU. Gets buffers contents on GPU by mapping buffers to CPU's address space, then copy their data. Unmap buffers after finish. Since this feature is for tests only, it is only implemented for the Vulkan backend. Adds buffer serialization to serializeContext method so that capture replay regresssion testing now compares the states of buffers too. Bug: angleproject:4817 Change-Id: Ic9b529701014d5ba8420023a021cd5ea381bd9a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2295950 Commit-Queue: Manh Nguyen <nguyenmh@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis a3ed8e19 2020-07-09T12:31:15 GL: Fix issue with EXTBlendFuncExtendedES3DrawTest The call to glBindFragDataLocationIndexedEXT was not being properly forwarded through ANGLE because we assumed that if its location was set, then its index was set, which is not always the case. Fixed this, and also added a link status check after linking so the error will properly propagate in the future. Bug: chromium:1099763 Change-Id: I28981c04a3f2d6a59c239b35b3f7eb0c7f586804 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289653 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill debe4683 2020-07-15T14:36:33 Test Runner: Accept Chromium args. This change lets the test runner accept the same isolated script parameter syntax as Chromium. It keeps the old parameter names so the tests accept both. This will let us more easily integrate with the Chromium Android test_runner.py script. Also update the README which was missing a few flags. Bug: angleproject:3162 Change-Id: Ic22b289a095418ffdaa19a04caa1b45c6c657872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300530 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Kenneth Russell 5927706b 2020-07-14T17:26:27 Revise documentation on adding EGL extensions. Provided more links and steps per earlier advice from geofflang@. Bug: angleproject:4842 No-Try: true Change-Id: I9c9361b4b71a63fd36f79a87d45e0f4b04c4140c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2297528 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop dd4723e3 2020-06-23T11:08:43 Capture/Replay: More ES 3.1 support This CL adds the following changes: * Support variable block sizes for ASTC * Support glMapBuffer * Additional param captures Test: Capture from beginning of Asphalt 8 and Aztec Ruins Bug: b/150484427 Bug: b/160808198 Change-Id: Ic1041011c3f51c32dbf7bf7105f41dffb9460b87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2264832 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Manh Nguyen <nguyenmh@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>